[GitHub] [apisix] Firstsawyou commented on issue #4090: Request help: Correspondence between matched rules and upstreams within one route
Firstsawyou commented on issue #4090:
URL: https://github.com/apache/apisix/issues/4090#issuecomment-823709437
You can try the traffic-split plug-in. Here is an example of configuration:
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/hello",
"plugins": {
"traffic-split": {
"rules": [
{
"match": [
{
"vars": [
["http_id","==","1"]
]
}
],
"weighted_upstreams": [
{
"upstream": {
"name": "upstream_A",
"type": "roundrobin",
"nodes": {
"127.0.0.1:1981":1
}
},
"weight": 3
}
]
},
{
"match": [
{
"vars": [
["http_id","==","2"]
]
}
],
"weighted_upstreams": [
{
"upstream": {
"name": "upstream_B",
"type": "roundrobin",
"nodes": {
"127.0.0.1:1982":1
}
},
"weight": 3
}
]
}
]
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:1980": 1
}
}
}'
```
However, it may not take effect in APISIX 2.5. You can try it in versions
before 2.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #386: feat: add event & status for ApisixRoute v2
gxthrj commented on pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823710143 related to : #394 #395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-control-plane] gxthrj merged pull request #41: chore: fix Go code styles
gxthrj merged pull request #41: URL: https://github.com/apache/apisix-control-plane/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-control-plane] branch master updated: chore: fix go code styles (#41)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-control-plane.git
The following commit(s) were added to refs/heads/master by this push:
new 0183669 chore: fix go code styles (#41)
0183669 is described below
commit 0183669db0636559d2387bddaac9650f7770700e
Author: Joey
AuthorDate: Wed Apr 21 09:34:44 2021 +0800
chore: fix go code styles (#41)
Signed-off-by: imjoey
---
pkg/adapter/route.go | 3 ++-
pkg/yml/plugin.go| 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/pkg/adapter/route.go b/pkg/adapter/route.go
index 635573b..4029747 100644
--- a/pkg/adapter/route.go
+++ b/pkg/adapter/route.go
@@ -18,9 +18,10 @@
package adapter
import (
+ "reflect"
+
"github.com/apache/apisix-control-plane/pkg/dp/apisix"
"github.com/apache/apisix-control-plane/pkg/mem"
- "reflect"
)
func ToRoute(r *mem.Route) *apisix.Route {
diff --git a/pkg/yml/plugin.go b/pkg/yml/plugin.go
index 739940a..c8e9074 100644
--- a/pkg/yml/plugin.go
+++ b/pkg/yml/plugin.go
@@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
+
package yml
import "github.com/apache/apisix-control-plane/pkg/mem"
[GitHub] [apisix-docker] gxthrj commented on pull request #159: feat: automate upload image to Dockerhub
gxthrj commented on pull request #159: URL: https://github.com/apache/apisix-docker/pull/159#issuecomment-823713945 Yes, the secret needed. I will try to set the secrets through infra of Apache. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup
wjx8382 commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-823721227
> > > From the configuration snippet the `allow_admin` was rendered
correctly, so it should work, would you like to try the `0.5.0` version, it was
released few days ago.
> >
> >
> > After using the `0.5.0` version,apisix-ingress-controller logs
> > ```
> > 2021-04-20T15:26:34+08:00warncontroller/apisix_route.go:205
sync ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"tools/httpserver-route","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null},
"error": "2 errors occurred:\n\t* object missing primary index\n\t* object
missing primary index\n\n"}
> > ```
> >
> >
> > In addition, why `helm install apisix` will also generate
apisix-ingress-controller, but its version is `0.4.0`, `helm install
apisix-ingress-controller` will generate apisix-ingress-controller which
version is `0.5.0`, which should I use?
>
> The error `object missing primary index` occurred basically due to you
wrote some route on apisix-dashboard. It's **NOT** a recommended way.
>
> > In addition, why helm install apisix will also generate
apisix-ingress-controller, but its version is 0.4.0, helm install
apisix-ingress-controller will generate apisix-ingress-controller which version
is 0.5.0, which should I use?
>
> We recommend you to use the `0.5.0` release.
I did not write anything on apisix-dashboard.After I installed APISIX and
apisix-ingress-controller,i just running `kubectl apply -f httpbin-route.yaml
-n tools`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-ingress-controller] branch master updated: test: add e2e test cases for ip-restriction plugin (#388)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 783ba62 test: add e2e test cases for ip-restriction plugin (#388)
783ba62 is described below
commit 783ba6257486c29d0c334513765fb9b1280b0424
Author: Alex Zhang
AuthorDate: Wed Apr 21 10:11:14 2021 +0800
test: add e2e test cases for ip-restriction plugin (#388)
---
test/e2e/plugins/ip-restriction.go | 238 +
1 file changed, 238 insertions(+)
diff --git a/test/e2e/plugins/ip-restriction.go
b/test/e2e/plugins/ip-restriction.go
new file mode 100644
index 000..7242ef9
--- /dev/null
+++ b/test/e2e/plugins/ip-restriction.go
@@ -0,0 +1,238 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package plugins
+
+import (
+ "fmt"
+
+ "github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+)
+
+var _ = ginkgo.Describe("proxy-rewrite plugin", func() {
+ opts := &scaffold.Options{
+ Name:"default",
+ Kubeconfig: scaffold.GetKubeconfig(),
+ APISIXConfigPath:"testdata/apisix-gw-config.yaml",
+ APISIXDefaultConfigPath:
"testdata/apisix-gw-config-default.yaml",
+ IngressAPISIXReplicas: 1,
+ HTTPBinServicePort: 80,
+ APISIXRouteVersion: "apisix.apache.org/v2alpha1",
+ }
+ s := scaffold.NewScaffold(opts)
+ ginkgo.It("ip whitelist", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /hello
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ weight: 10
+ plugins:
+ - name: ip-restriction
+ enable: true
+ config:
+ whitelist:
+ - "192.168.3.3"
+`, backendSvc, backendPorts[0])
+
+ assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(ar))
+
+ err := s.EnsureNumApisixUpstreamsCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ err = s.EnsureNumApisixRoutesCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of routes")
+
+ // As we use port forwarding so the ip address is 127.0.0.1
+ s.NewAPISIXClient().GET("/hello").WithHeader("Host",
"httpbin.org").
+ Expect().
+ Status(403).
+ Body().
+ Contains("Your IP address is not allowed")
+
+ ar = fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /ip
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ weight: 10
+ plugins:
+ - name: ip-restriction
+ enable: true
+ config:
+ whitelist:
+ - "127.0.0.1"
+`, backendSvc, backendPorts[0])
+
+ assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(ar))
+
+ err = s.EnsureNumApisixUpstreamsCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ err = s.EnsureNumApisixRoutesCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of routes")
+
+ // As we use port forwarding so the ip address is 127.0.0.1
+ s.NewAPISIXClient().GET("/ip").WithHeader("Host",
"httpbin.org").
+ Expect().
+ Status(200).
+ Body().
+ Contains("origin")
+ })
+ ginkgo.It("ip blacklist", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion:
[GitHub] [apisix-ingress-controller] tokers merged pull request #388: test: add e2e test cases for ip-restriction plugin
tokers merged pull request #388: URL: https://github.com/apache/apisix-ingress-controller/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: test: add api-breaker plugin e2e test cases (#393)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new cc67f0f test: add api-breaker plugin e2e test cases (#393)
cc67f0f is described below
commit cc67f0f61fad0d4b7b6c2560d1440f37fc32fcec
Author: Alex Zhang
AuthorDate: Wed Apr 21 10:11:30 2021 +0800
test: add api-breaker plugin e2e test cases (#393)
---
test/e2e/plugins/api_breaker.go | 149
test/e2e/testdata/apisix-gw-config.yaml | 1 +
2 files changed, 150 insertions(+)
diff --git a/test/e2e/plugins/api_breaker.go b/test/e2e/plugins/api_breaker.go
new file mode 100644
index 000..f7a09f4
--- /dev/null
+++ b/test/e2e/plugins/api_breaker.go
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package plugins
+
+import (
+ "fmt"
+ "net/http"
+ "time"
+
+ "github.com/stretchr/testify/assert"
+
+ "github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
+ "github.com/onsi/ginkgo"
+)
+
+var _ = ginkgo.Describe("api-breaker plugin", func() {
+ opts := &scaffold.Options{
+ Name:"default",
+ Kubeconfig: scaffold.GetKubeconfig(),
+ APISIXConfigPath:"testdata/apisix-gw-config.yaml",
+ APISIXDefaultConfigPath:
"testdata/apisix-gw-config-default.yaml",
+ IngressAPISIXReplicas: 1,
+ HTTPBinServicePort: 80,
+ APISIXRouteVersion: "apisix.apache.org/v2alpha1",
+ }
+ s := scaffold.NewScaffold(opts)
+ ginkgo.It("sanity", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /status/*
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ resolveGranularity: service
+ plugins:
+ - name: api-breaker
+ enable: true
+ config:
+ break_response_code: 502
+ unhealthy:
+ http_statuses:
+ - 505
+ failures: 2
+ max_breaker_sec: 3
+ healthy:
+ http_statuses:
+ - 200
+ successes: 2
+`, backendSvc, backendPorts[0])
+
+ assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(ar))
+ err := s.EnsureNumApisixUpstreamsCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ err = s.EnsureNumApisixRoutesCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of routes")
+
+ resp :=
s.NewAPISIXClient().GET("/status/200").WithHeader("Host",
"httpbin.org").Expect()
+ resp.Status(http.StatusOK)
+
+ for i := 0; i < 2; i++ {
+ resp =
s.NewAPISIXClient().GET("/status/505").WithHeader("Host",
"httpbin.org").Expect()
+ resp.Status(505)
+ }
+
+ // Trigger the api-breaker threshold
+ resp =
s.NewAPISIXClient().GET("/status/505").WithHeader("Host",
"httpbin.org").Expect()
+ resp.Status(http.StatusBadGateway)
+
+ time.Sleep(3500 * time.Millisecond)
+ resp =
s.NewAPISIXClient().GET("/status/200").WithHeader("Host",
"httpbin.org").Expect()
+ resp.Status(http.StatusOK)
+ })
+ ginkgo.It("disable plugin", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /status/*
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ resolveGranularity: service
+ plugins:
+ - name: api-breaker
+ enable: false
+ config:
+ break_response_code: 502
+ unhealthy:
+ h
[GitHub] [apisix-ingress-controller] tokers merged pull request #393: test: add api-breaker plugin e2e test cases
tokers merged pull request #393: URL: https://github.com/apache/apisix-ingress-controller/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #385: WIP: fix wrong group version for extensions/v1beta1.Ingress
tokers commented on pull request #385: URL: https://github.com/apache/apisix-ingress-controller/pull/385#issuecomment-823722031 @vincenthcui Ping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4091: feature: support to fetch balancer `ip`/`port` from `ctx.vars`
Firstsawyou commented on issue #4091: URL: https://github.com/apache/apisix/issues/4091#issuecomment-823733774 Assigned to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on pull request #159: feat: automate upload image to Dockerhub
gxthrj commented on pull request #159: URL: https://github.com/apache/apisix-docker/pull/159#issuecomment-823746325 I submitted an INFRA to discuss this matter. If Apache does not allow this, we will roll back this PR, and if allowed, we will continue to apply for secrets. INFRA: https://issues.apache.org/jira/browse/INFRA-21756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis opened a new issue #1810: style(fe): how about changing the navigation bar to dark?
membphis opened a new issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823750638 @tokers @starsz please have a look again when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] leon1509 commented on issue #1796: 关于路由/*有效，/foo/*无效
leon1509 commented on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823750668 My back-end service is http://localhost:8080/api/user/get, I want to add /api/user/get via apisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] leon1509 edited a comment on issue #1796: 关于路由/*有效，/foo/*无效
leon1509 edited a comment on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823750668 My back-end service is http://localhost:8080/api/user/get, I want to add /foo[/api/user/get] via apisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
membphis commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617175576 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +[Unit] +Description=Manager-API service Review comment: I think we should add the keyword "Apache APISIX" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
membphis commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617176088 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +[Unit] +Description=Manager-API service + +[Service] +Type=simple +Restart=on-failure +RestartSec=5 +WorkingDirectory=<"Your Directory">/apisix-dashboard/output Review comment: do we have created an issue about this when we build an RPM package? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd opened a new issue #4093: bug: The manager-api and apache apisix are mismatched?
hzbd opened a new issue #4093: URL: https://github.com/apache/apisix/issues/4093 ### Issue description Request Error Code: 201 The manager-api and apache apisix are mismatched.  ### Environment **CentOS 7.9** [root@xxx dashboard]# ./manager-api -v **Version : 2.5 GitHash : 5c95d97** [root@xxx dashboard]# apisix version /usr/local/openresty/luajit/bin/luajit /usr/local/apisix/apisix/cli/apisix.lua version 2.5 [root@xxx dashboard]# openresty -v **nginx version: openresty/1.19.3.1** Is this a bug or is it a problem with my settings？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd commented on issue #4093: bug: The manager-api and apache apisix are mismatched?
hzbd commented on issue #4093: URL: https://github.com/apache/apisix/issues/4093#issuecomment-823753480 Maybe I should submit it to the apisix-dashboard side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd closed issue #4093: bug: The manager-api and apache apisix are mismatched?
hzbd closed issue #4093: URL: https://github.com/apache/apisix/issues/4093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] hzbd opened a new issue #1811: The manager-api and apache apisix are mismatched?
hzbd opened a new issue #1811: URL: https://github.com/apache/apisix-dashboard/issues/1811 **Issue description** _Request Error Code: 201 The manager-api and apache apisix are mismatched._  **Environment** **CentOS 7.9** [root@xxx dashboard]# ./manager-api -v **Version : 2.5 GitHash : 5c95d97** [root@xxx dashboard]# apisix version **/usr/local/openresty/luajit/bin/luajit /usr/local/apisix/apisix/cli/apisix.lua version 2.5** [root@xxx dashboard]# openresty -v **nginx version: openresty/1.19.3.1** Is this a bug or is it a problem with my settings？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #4092: fix(traffic-split): when the rules array has multiple upstream conditions (weighted_upstreams + match), the request will be confused amon
Firstsawyou commented on pull request #4092: URL: https://github.com/apache/apisix/pull/4092#issuecomment-823762795 Related issues: https://github.com/apache/apisix/issues/4090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617191937 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review comment: Do we still need this file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
nic-chen commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823768235 +1 for keeping the current behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-823769178 hi @bisakhmondal I think we should also embed `dag-to-lua`, see: https://github.com/apache/apisix-dashboard/blob/master/api/build.sh#L38-L42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1705: fix: detailed error for store init failure and deferred execution of closers
netlify[bot] edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-818713534 Deploy preview for *apisix-dashboard* processing. Building with commit 8c21565a846016227d47ca8280cfc911d581fe3b https://app.netlify.com/sites/apisix-dashboard/deploys/607facfb15016400084c7125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] StretchV opened a new issue #4094: request help: How to configure apisix and dashboad if etcd turns on certificate authentication
StretchV opened a new issue #4094: URL: https://github.com/apache/apisix/issues/4094 ### Issue description ### Environment * apisix version (cmd: `apisix version`):2.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1807: docs: add correct custom IDs to links
nic-chen commented on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823771931 hi @KishaniKandasamy I am updating api doc and that will be a big update. I think we don't need to update this file now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1811: The manager-api and apache apisix are mismatched?
nic-chen commented on issue #1811: URL: https://github.com/apache/apisix-dashboard/issues/1811#issuecomment-823774139 hi @hzbd can't use Dashboard 2.5 with APISIX 2.5, need to wait for Dashboard 2.6. Dashboard 2.5 works with APISIX 2.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617198292 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review comment: Hii, nope it's not required anymore. I forgot to clean it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617198607 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +[Unit] +Description=Manager-API service Review comment: Hi, the binary takes care of running itself as a service. Unit file for each platform isn't required anymore. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1796: 关于路由/*有效，/foo/*无效
nic-chen commented on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823774884 > My back-end service is http://localhost:8080/api/user/get, I want to add /foo[/api/user/get] via apisix I think you could use the proxy-rewrite plugin to achieve your need: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/proxy-rewrite.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* processing. Building with commit 27876cf77506f9a89ea97a5e66ff8b7323c9bc6f https://app.netlify.com/sites/apisix-dashboard/deploys/607fb00c4b33810008bdba9b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1810: style(fe): how about changing the navigation bar to dark?
nic-chen commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-823775689 I We can directly try to see the modified effect. cc @LiteSun @juzhiyuan @liuxiran @guoqqqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27876cf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `20.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1667 +/- ## === - Coverage 72.48% 52.40% -20.08% === Files 133 39 -94 Lines5728 2740 -2988 Branches 6660 -666 === - Hits 4152 1436 -2716 + Misses 1332 1110 -222 + Partials 244 194 -50 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.40% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27876cf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `5.70%`. > The diff coverage is `42.30%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1667 +/- ## == - Coverage 72.48% 66.78% -5.71% == Files 133 48 -85 Lines5728 3233-2495 Branches 6660 -666 == - Hits 4152 2159-1993 + Misses 1332 803 -529 - Partials 244 271 +27 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.11% <42.30%> (-2.41%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.40% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | `13.51% <13.51%> (ø)` | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `52.54% <53.76%> (-6.92%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `56.92% <0.00%> (-19.01%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1705: fix: detailed error for store init failure and deferred execution of closers
codecov-commenter edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-821808163 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1705](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c21565) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.02%`. > The diff coverage is `76.92%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1705 +/- ## == + Coverage 71.78% 71.81% +0.02% == Files 172 172 Lines6100 6106 +6 Branches 713 713 == + Hits 4379 4385 +6 + Misses 1478 1477 -1 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.70% <53.84%> (+0.13%)` | :arrow_up: | | backend-e2e-test-ginkgo | `49.17% <53.84%> (+0.06%)` | :arrow_up: | | backend-unit-test | `52.42% <100.00%> (+0.01%)` | :arrow_up: | | frontend-e2e-test | `71.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `59.49% <70.00%> (+0.03%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.09% <100.00%> (-1.13%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (+3.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...8c21565](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27876cf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `1.90%`. > The diff coverage is `42.30%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1667 +/- ## == - Coverage 72.48% 70.58% -1.91% == Files 133 48 -85 Lines5728 3233-2495 Branches 6660 -666 == - Hits 4152 2282-1870 + Misses 1332 699 -633 - Partials 244 252 +8 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.11% <42.30%> (-2.41%)` | :arrow_down: | | backend-e2e-test-ginkgo | `48.65% <42.30%> (+0.61%)` | :arrow_up: | | backend-unit-test | `52.40% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | `13.51% <13.51%> (ø)` | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `52.54% <53.76%> (-6.92%)` | :arrow_down: | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <0.00%> (-2.82%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `91.07% <0.00%> (-0.42%)` | :arrow_down: | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | | | | [...rc/components/PluginOrchestration/customConfig.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
[GitHub] [apisix-dashboard] hzbd closed issue #1811: The manager-api and apache apisix are mismatched?
hzbd closed issue #1811: URL: https://github.com/apache/apisix-dashboard/issues/1811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1788: feat: embed assets in api binary
bisakhmondal commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-823779141 > hi @bisakhmondal > I think we should also embed `dag-to-lua`, see: > https://github.com/apache/apisix-dashboard/blob/master/api/build.sh#L38-L42 Okay. Let me have a look. I'll update it accordingly. Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57bd49d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `0.57%`. > The diff coverage is `68.42%`. > :exclamation: Current head 57bd49d differs from pull request most recent head 27876cf. Consider uploading reports for the commit 27876cf to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1667 +/- ## == - Coverage 72.48% 71.91% -0.58% == Files 133 125 -8 Lines5728 2948-2780 Branches 666 713 +47 == - Hits 4152 2120-2032 + Misses 1332 828 -504 + Partials 2440 -244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `71.91% <68.42%> (-2.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | `82.14% <ø> (ø)` | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <ø> (-11.48%)` | :arrow_down: | | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `90.00% <ø> (ø)` | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <ø> (ø)` | | | [web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `39.13% <ø> (-2.54%)` | :arrow_down: | | [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | | | [web/src/pages/Route/service.ts](https://codecov.io/gh/apac
[GitHub] [apisix-dashboard] Firstsawyou commented on issue #1796: 关于路由/*有效，/foo/*无效
Firstsawyou commented on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823784682 You can also try to configure it like this in Dashboard: https://user-images.githubusercontent.com/52862365/115500683-62272180-a2a4-11eb-96d7-d5789b7e7e46.png";> https://user-images.githubusercontent.com/52862365/115500706-6ce1b680-a2a4-11eb-89a5-2adde9de8d26.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
liuxiran commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823786050 @juzhiyuan @nic-chen keep the current behavior is also reasonable for me If there is no objection, we will close the issue cc @ericsyh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy commented on pull request #1807: docs: add correct custom IDs to links
KishaniKandasamy commented on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823797345 > hi @KishaniKandasamy > I am updating api doc and that will be a big update. > I think we don't need to update this file now. Okay:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] ericsyh commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
ericsyh commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823798761 ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1756: chore: update setup script
bisakhmondal commented on pull request #1756: URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-823800940 Any thoughts here 😄🤡? @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4094: request help: How to configure apisix and dashboad if etcd turns on certificate authentication
Firstsawyou commented on issue #4094: URL: https://github.com/apache/apisix/issues/4094#issuecomment-823805907 In the APISIX configuration file, there is a default `etcd. tls.verify` as true. Is this okay? https://github.com/apache/apisix/blob/964a92ee773264999eb67d0cd5539baf8961001b/conf/config-default.yaml#L200-L202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] totemofwolf opened a new issue #4095: bug: cors() does not work after modifying
totemofwolf opened a new issue #4095:
URL: https://github.com/apache/apisix/issues/4095
### Issue description
### Environment
* apisix version (cmd: `apisix version`): APISIX/2.5
* OS (cmd: `uname -a`): 2.5-alpine
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): 3.4
* apisix-dashboard version, if have: 2.5
### Minimal test code / Steps to reproduce the issue
1. request:
```
# request:
curl 'http://pilot.x.work/apisix/admin/routes/350558925461914554' \
-X 'PUT' \
-H 'Connection: keep-alive' \
-H 'Accept: application/json' \
-H 'DNT: 1' \
-H 'Authorization: ' \
-H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_2_3)
AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.128 Safari/537.36' \
-H 'Content-Type: application/json;charset=UTF-8' \
-H 'Origin: http://pilot.x.work' \
-H 'Referer: http://pilot.x.work/routes/list' \
-H 'Accept-Language: zh-CN,zh;q=0.9' \
--data-raw '{
"uris":[
"/*"
],
"name":"https_mapi-x",
"desc":"https://x";,
"priority":10,
"hosts":[
"x"
],
"vars":[
[
"scheme",
"==",
"https"
]
],
"plugins":{
"cors":{
"allow_credential":true,
"allow_headers":"*",
"allow_methods":"*",
"allow_origins":"https://x";,
"expose_headers":"*",
"max_age":-1
}
},
"upstream_id":"350558615033086906",
"status":1
}
' \
--compressed \
--insecure
```
2.response
```
# curl the route with response:
HTTP/2 404
content-type: text/plain; charset=utf-8
content-length: 18
date: Wed, 21 Apr 2021 06:43:25 GMT
server: APISIX/2.5
access-control-allow-origin: *
access-control-allow-methods: *
access-control-max-age: 5
access-control-expose-headers: *
access-control-allow-headers: *
```
### What's the actual result? (including assertion message & call stack if
applicable)
### What's the expected result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4094: request help: How to configure apisix and dashboad if etcd turns on certificate authentication
Firstsawyou commented on issue #4094: URL: https://github.com/apache/apisix/issues/4094#issuecomment-823821197 The configuration of etcd client certificate is not supported in APISIX 2.3. It is only supported in APISIX 2.5 This is the configuration information of etcd in 2.5 https://github.com/apache/apisix/blob/b17bb8fe728583dbb1f41bccc9c22fc8081ce5e0/conf/config-default.yaml#L204-L210 Dashboard's etcd client certificate configuration try to configure it here? https://github.com/apache/apisix-dashboard/blob/v2.4/api/conf/conf.yaml#L31-L34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #398: feat: add tcp route data structures and cache
tokers opened a new pull request #398: URL: https://github.com/apache/apisix-ingress-controller/pull/398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
