[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 6bf9cbaba2840ff5198dbd22b1fac1ae6d2ee0e4 https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value
netlify[bot] edited a comment on pull request #1799: URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760 Deploy preview for *apisix-dashboard* processing. Building with commit b67ad5c55da93fff013faca9ae59a08518261149 https://app.netlify.com/sites/apisix-dashboard/deploys/6092328966176883269d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6bf9cba) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **decrease** coverage by `19.30%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.78% 52.47% -19.31% === Files 172 39 -133 Lines6100 2742 -3358 Branches 7130 -713 === - Hits 4379 1439 -2940 + Misses 1478 1109 -369 + Partials 243 194 -49 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.47% <ø> (+0.07%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1813: feat: refactor Plugin Orchestration
juzhiyuan commented on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-832429204 Reduce 400+ lines codes hh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 6bf9cbaba2840ff5198dbd22b1fac1ae6d2ee0e4 https://app.netlify.com/sites/apisix-dashboard/deploys/609231ed7afa120007088df9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] fregie edited a comment on issue #364: ci: add golint workflow
fregie edited a comment on issue #364: URL: https://github.com/apache/apisix-ingress-controller/issues/364#issuecomment-832409276 @tokers Please assign this to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] fregie closed pull request #418: Golint test
fregie closed pull request #418: URL: https://github.com/apache/apisix-ingress-controller/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] fregie opened a new pull request #418: Golint test
fregie opened a new pull request #418: URL: https://github.com/apache/apisix-ingress-controller/pull/418 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch fix-minor-issues created (now dd479b6)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch fix-minor-issues in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at dd479b6 Merge branch 'fix-minor-issues' of github.com:juzhiyuan/apisix-dashboard into fix-minor-issues No new revisions were added by this update.
[GitHub] [apisix-ingress-controller] fregie commented on issue #364: ci: add golint workflow
fregie commented on issue #364: URL: https://github.com/apache/apisix-ingress-controller/issues/364#issuecomment-832409276 @tokers Please assigned this to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton commented on a change in pull request #3624: feat: add pre-commit framework
jbampton commented on a change in pull request #3624: URL: https://github.com/apache/apisix/pull/3624#discussion_r626245528 ## File path: codespell.txt ## @@ -0,0 +1,17 @@ +ba Review comment: Yes the file is necessary but you are correct that we don't need Spanish words in the ignore list. We use all lowercase "words" in the ignore list. I just now ran: ``` codespell --skip="./docs/es,./docs/zh,./.git,./**/*.crt,./**/go.sum" | cut -d' ' -f2 | sort | uniq WithT hel nD nd nin witht ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: add more way to install APISIX (#4181)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new d4e5bca docs: add more way to install APISIX (#4181) d4e5bca is described below commit d4e5bca1312c123c56bd97a885efd083141560f7 Author: 罗泽轩 AuthorDate: Wed May 5 12:20:47 2021 +0800 docs: add more way to install APISIX (#4181) Also prefer to install via package instead of source. The latter one is not so friendly for beginner. Signed-off-by: spacewander --- docs/en/latest/how-to-build.md | 20 ++-- docs/zh/latest/how-to-build.md | 20 ++-- 2 files changed, 28 insertions(+), 12 deletions(-) diff --git a/docs/en/latest/how-to-build.md b/docs/en/latest/how-to-build.md index bbbc66b..0d1f402 100644 --- a/docs/en/latest/how-to-build.md +++ b/docs/en/latest/how-to-build.md @@ -31,6 +31,20 @@ So before installation, please follow the different operating systems [install D You can install Apache APISIX in a variety of ways, including source code packages, Docker, and Luarocks. +### Installation via RPM package (CentOS 7) + +```shell +sudo yum install -y https://github.com/apache/apisix/releases/download/2.5/apisix-2.5-0.x86_64.rpm +``` + +### Installation via Docker + +See https://hub.docker.com/r/apache/apisix + +### Installation via Helm Chart + +See https://github.com/apache/apisix-helm-chart + ### Installation via source release You need to download the Apache source release first: @@ -48,12 +62,6 @@ cd apisix-2.5 make deps ``` -### Installation via RPM package (CentOS 7) - -```shell -sudo yum install -y https://github.com/apache/apisix/releases/download/2.5/apisix-2.5-0.x86_64.rpm -``` - ## 3. Manage (start/stop) APISIX Server We can start the APISIX server by command `make run` in APISIX home folder, diff --git a/docs/zh/latest/how-to-build.md b/docs/zh/latest/how-to-build.md index 6b434ed..35b4526 100644 --- a/docs/zh/latest/how-to-build.md +++ b/docs/zh/latest/how-to-build.md @@ -31,6 +31,20 @@ Apache APISIX 的运行环境需要 Nginx 和 etcd， 你可以通过源码包、Docker、Luarocks 等多种方式来安装 Apache APISIX。 +### 通过 RPM 包安装（CentOS 7） + +```shell +sudo yum install -y https://github.com/apache/apisix/releases/download/2.5/apisix-2.5-0.x86_64.rpm +``` + +### 通过 Docker 安装 + +见 https://hub.docker.com/r/apache/apisix + +### 通过 Helm Chart 安装 + +见 https://github.com/apache/apisix-helm-chart + ### 通过源码包安装 你需要先下载 Apache Release 源码包： @@ -48,12 +62,6 @@ cd apisix-2.5 make deps ``` -### 通过 RPM 包安装（CentOS 7） - -```shell -sudo yum install -y https://github.com/apache/apisix/releases/download/2.5/apisix-2.5-0.x86_64.rpm -``` - ## 3. 管理（启动、关闭等）APISIX 服务 我们可以在 apisix 的目录下用 `make run` 命令来启动服务，或者用 `make stop` 方式关闭服务。
[GitHub] [apisix] spacewander merged pull request #4181: docs: add more way to install APISIX
spacewander merged pull request #4181: URL: https://github.com/apache/apisix/pull/4181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4181: docs: add more way to install APISIX
spacewander commented on a change in pull request #4181: URL: https://github.com/apache/apisix/pull/4181#discussion_r626243839 ## File path: docs/en/latest/how-to-build.md ## @@ -31,6 +31,20 @@ So before installation, please follow the different operating systems [install D You can install Apache APISIX in a variety of ways, including source code packages, Docker, and Luarocks. +### Installation via RPM package (CentOS 7) + +```shell Review comment: I see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #4181: docs: add more way to install APISIX
juzhiyuan commented on a change in pull request #4181: URL: https://github.com/apache/apisix/pull/4181#discussion_r626243316 ## File path: docs/en/latest/how-to-build.md ## @@ -31,6 +31,20 @@ So before installation, please follow the different operating systems [install D You can install Apache APISIX in a variety of ways, including source code packages, Docker, and Luarocks. +### Installation via RPM package (CentOS 7) + +```shell Review comment: No, just want to confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3624: feat: add pre-commit framework
spacewander commented on a change in pull request #3624: URL: https://github.com/apache/apisix/pull/3624#discussion_r626237343 ## File path: codespell.txt ## @@ -0,0 +1,17 @@ +ba Review comment: Is this file necessary? It would be better to skip `docs/es` instead of putting Spanish words in the ignore list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4182: request help: apisix config backup
Firstsawyou commented on issue #4182: URL: https://github.com/apache/apisix/issues/4182#issuecomment-832391588 Can you use etcd data backup and recovery? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton edited a comment on pull request #3624: feat: add pre-commit framework
jbampton edited a comment on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-832391304 Hey @Yiyiyimu can you please review ? I have removed all the Python checks from the pre-commit and I have removed the original GitHub Actions for markdownlint and yamlint. I added pre-commit to the CI. I added a new check to pre-commit called codespell which found some more spelling mistakes and we now have a small custom dictionary. I cleaned up the lint file removing the emoji since I think it might look better. pre-commit has a check for trailing whitespace but it does not give us as much coverage as our custom GitHub action since with pre-commit we ignore the file but with actions we ignore lines in that file. Still good to at least have a check on pre-commit for trailing whitespace. You can even write your own hook scripts and on Apache Airflow they write them in Shell and Python. Pre-commit can be installed with `pip`, `curl`, `brew` or `conda` so maybe we should leave it up to the user to install since they might prefer a certain way.I am willing to add some more docs too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton edited a comment on pull request #3624: feat: add pre-commit framework
jbampton edited a comment on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-832391304 Hey @Yiyiyimu can you please review ? I have removed all the Python checks from the pre-commit and I have removed the original GitHub Actions for markdownlint and yamlint. I added pre-commit to the CI. I added a new check to pre-commit called codespell which found some more spelling mistakes and we now have a small custom dictionary. I cleaned up the lint file removing the emoji since I think it might look better. pre-commit has a check for trailing whitespace but it doesn't not give us as much coverage as our custom GitHub action since with pre-commit we ignore the file but with actions we ignore lines in that file. Still good to at least have a check on pre-commit for trailing whitespace. You can even write your own hook scripts and on Apache Airflow they write them in Shell and Python. Pre-commit can be installed with `pip`, `curl`, `brew` or `conda` so maybe we should leave it up to the user to install since they might prefer a certain way.I am willing to add some more docs too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton commented on pull request #3624: feat: add pre-commit framework
jbampton commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-832391304 Hey @Yiyiyimu can you please review ? I have removed all the Python checks from the pre-commit and I have removed the original GitHub Actions for markdownlint and yamlint. I added pre-commit to the CI. I added a new check to pre-commit called codespell which found some more spelling mistakes and we now have a small custom dictionary. I cleaned up the lint file removing the emoji since I think it might look better. pre-commit has a check for trailing whitespace but it doesn not give us as much coverage as our custom GitHub action since with pre-commit we ignore the file but with actions we ignore lines in that file. Still good to at least have a check on pre-commit for trailing whitespace. You can even write your own hook scripts and on Apache Airflow they write them in Shell and Python. Pre-commit can be installed with `pip`, `curl`, `brew` or `conda` so maybe we should leave it up to the user to install since they might prefer a certain way.I am willing to add some more docs too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4181: docs: add more way to install APISIX
spacewander commented on a change in pull request #4181: URL: https://github.com/apache/apisix/pull/4181#discussion_r626234506 ## File path: docs/en/latest/how-to-build.md ## @@ -31,6 +31,20 @@ So before installation, please follow the different operating systems [install D You can install Apache APISIX in a variety of ways, including source code packages, Docker, and Luarocks. +### Installation via RPM package (CentOS 7) + +```shell Review comment: The original one used `shell`. Does it really matter to use only `bash` or `shell`? I don't want to waste time on a trivial thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #4181: docs: add more way to install APISIX
juzhiyuan commented on a change in pull request #4181: URL: https://github.com/apache/apisix/pull/4181#discussion_r626232336 ## File path: docs/en/latest/how-to-build.md ## @@ -31,6 +31,20 @@ So before installation, please follow the different operating systems [install D You can install Apache APISIX in a variety of ways, including source code packages, Docker, and Luarocks. +### Installation via RPM package (CentOS 7) + +```shell Review comment: I see we use `bash` and `shell`, do we need to use the same lang? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1643: When creating a route, the upstream cannot select ‘none’
juzhiyuan closed issue #1643: URL: https://github.com/apache/apisix-dashboard/issues/1643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1643: When creating a route, the upstream cannot select ‘none’
juzhiyuan commented on issue #1643: URL: https://github.com/apache/apisix-dashboard/issues/1643#issuecomment-832383945 ok, I see what happened. `None` is only available when creating a Service. When creating Route, we can't use `None` here. Consider closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhangwenjian commented on issue #4177: request help: I need tcp upstream connection result as a response to tcp client
zhangwenjian commented on issue #4177: URL: https://github.com/apache/apisix/issues/4177#issuecomment-832369480 Someone suggests to write a nginx c module to realize a own tcp protocol gateway. Actually, the core logic of my gateway is very simple, do I need to write a new full nginx stream module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] li1234yun opened a new issue #4182: request help: apisix config backup
li1234yun opened a new issue #4182: URL: https://github.com/apache/apisix/issues/4182 ### Issue description When I use apisix in my dev environment, I want to import my dev environment config to production environment. Maybe you can think of the config backup and restore. ### Environment * apisix version: 2.5 * OS (cmd: `uname -a`): Darwin * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): 3.4.15 * apisix-dashboard version, if have: 2.5 * luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4181: docs: add more way to install APISIX
spacewander opened a new pull request #4181: URL: https://github.com/apache/apisix/pull/4181 Also prefer to install via package instead of source. The latter one is not so friendly for beginner. Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on pull request #4175: docs: fix broken links and ids in plugins
KishaniKandasamy commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-832105117 > @iamayushdas @KishaniKandasamy > Have you read my review? > > > Not all pages need a sidebar. They can go back from the browser. > > > And this problem should be fixed by the doc render framework itself. Adding unrelative doc to the sidebar to fix it is a hack. > > I won't want to review anymore if your guys keep ignoring my feedback. > > And such a change should not have such a title called 'docs: fix broken links and ids in plugins'! > > Please open another PR with **correct** name and **suitable** change! > > I am quite annoyed by you today. I am really Sorry for the hassle! I will try to open another PR later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on issue #330: docs: add Last updated on , by to docs
KishaniKandasamy commented on issue #330: URL: https://github.com/apache/apisix-website/issues/330#issuecomment-832102833 > ok! But those docs are pulling from origin repos, not sure if it's working without Git history 樂 please have a try! Okay I will try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1643: When creating a route, the upstream cannot select ‘none’
iamayushdas commented on issue #1643: URL: https://github.com/apache/apisix-dashboard/issues/1643#issuecomment-832037266 Do you want me to fix this @juzhiyuan ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on issue #1643: When creating a route, the upstream cannot select ‘none’
iamayushdas edited a comment on issue #1643: URL: https://github.com/apache/apisix-dashboard/issues/1643#issuecomment-832034066 > @iamayushdas Please have a check if this issue gets fixed, if yes, then cc me to close this issue :) Thanks No its not :( cc @juzhiyuan  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1643: When creating a route, the upstream cannot select ‘none’
iamayushdas commented on issue #1643: URL: https://github.com/apache/apisix-dashboard/issues/1643#issuecomment-832034066 > @iamayushdas Please have a check if this issue gets fixed, if yes, then cc me to close this issue :) Thanks No its not :(  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1813: feat: refactor Plugin Orchestration
juzhiyuan commented on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-832032737 I'm back, and will continue this PR tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #329: [Fe] dark mode enhancement in download page
juzhiyuan commented on issue #329: URL: https://github.com/apache/apisix-website/issues/329#issuecomment-832030913 sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #330: docs: add Last updated on , by to docs
juzhiyuan commented on issue #330: URL: https://github.com/apache/apisix-website/issues/330#issuecomment-832030492 ok! But those docs are pulling from origin repos, not sure if it's working without Git history 樂 please have a try! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #318: chore: Test Docusaurus webpack 5 support
juzhiyuan merged pull request #318: URL: https://github.com/apache/apisix-website/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-832015165 Any idea why the upstream test suite is breaking樂, the PR doesn't touch anything on that segment and moreover, it's HTTP 400!! All starts with `test upstream delete [It] create upstream without plugin ` i.e failing to process upstream request and rest (other tests) is dominos effect. But it's working fine locally  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #328: docs: fixed kubernetes service api broken link
iamayushdas commented on pull request #328: URL: https://github.com/apache/apisix-website/pull/328#issuecomment-832009183 > > There are quite a lot of broken links found in #326, we'd better fix them all together in this PR > > > > I tried to search those links in every repositories, but those links doesn't exist now. @iamayushdas could you check the issue once again. Oh yes, zh folder doesn't exist now in docs. You can look for other links, if all links are working fine just ping me here. Thank you for contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1816: feat: Use monaco editor
juzhiyuan edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831983979 ~~ok I know what happened~~ Let me recheck in local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831983979 ok I know what happened -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831982960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
netlify[bot] edited a comment on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-823982455 Deploy preview for *apisix-dashboard* ready! Built with commit 84e18e6da94fbd9aff6ddfa0ff6f46a52f6c0ef2 https://deploy-preview-1814--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1814: fix: store init error from etcd and deferred execution of closers
netlify[bot] edited a comment on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-823982455 Deploy preview for *apisix-dashboard* processing. Building with commit 84e18e6da94fbd9aff6ddfa0ff6f46a52f6c0ef2 https://app.netlify.com/sites/apisix-dashboard/deploys/609155ddf16b980008212223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1814: fix: store init error from etcd and deferred execution of closers
netlify[bot] edited a comment on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-823982455 Deploy preview for *apisix-dashboard* ready! Built with commit c66c9144f89e2353465089ea8e36b3e145378f18 https://deploy-preview-1814--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1814: fix: store init error from etcd and deferred execution of closers
netlify[bot] edited a comment on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-823982455 Deploy preview for *apisix-dashboard* processing. Building with commit c66c9144f89e2353465089ea8e36b3e145378f18 https://app.netlify.com/sites/apisix-dashboard/deploys/6091539bbdb39c00078a4735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4177: request help: I need tcp upstream connection result as a response to tcp client
spacewander commented on issue #4177: URL: https://github.com/apache/apisix/issues/4177#issuecomment-831949015 I have been heard some people did it before. Unfortunately, there is no open source code AFAIK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1814: fix: store init error from etcd and deferred execution of closers
bisakhmondal commented on a change in pull request #1814:
URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r625769191
##
File path: api/cmd/managerapi.go
##
@@ -65,6 +66,14 @@ func printVersion() {
// NewManagerAPICommand creates the manager-api command.
func NewManagerAPICommand() *cobra.Command {
+ cobra.OnInitialize(func() {
+ var err error
+ service, err = createService()
Review comment:
Wait, what!! that's not from this PR 樂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] moonming closed pull request #1830: feat: add switch of online debug
moonming closed pull request #1830: URL: https://github.com/apache/apisix-dashboard/pull/1830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhangwenjian edited a comment on issue #4177: request help: I need tcp upstream connection result as a response to tcp client
zhangwenjian edited a comment on issue #4177: URL: https://github.com/apache/apisix/issues/4177#issuecomment-831877364 to spacewander: The solution based on ngx.socket.tcp is to overide the default implemention of upstream connection in nginx? My tcp connection to upstream server will be kept running, not for every request. Is there any open source code for reference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhangwenjian commented on issue #4177: request help: I need tcp upstream connection result as a response to tcp client
zhangwenjian commented on issue #4177: URL: https://github.com/apache/apisix/issues/4177#issuecomment-831877364 to spacewander: The solution based on ngx.socket.tcp is to overide the default implemention of upstream connection in nginx? Is there any open source code for reference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #4175: docs: fix broken links and ids in plugins
spacewander closed pull request #4175: URL: https://github.com/apache/apisix/pull/4175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4175: docs: fix broken links and ids in plugins
spacewander commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831870516 @iamayushdas @KishaniKandasamy Have you read my review? > Not all pages need a sidebar. They can go back from the browser. > And this problem should be fixed by the doc render framework itself. Adding unrelative doc to the sidebar to fix it is a hack. I won't want to review anymore if your guys keep ignoring my feedback. And such a change should not have such a title called 'docs: fix broken links and ids in plugins'! Please open another PR with **correct** name and **suitable** change! I am quite annoyed by you today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
qian0817 commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831868630 > ok, just triggered to redeploy. Codes LGTM @juzhiyuan Still failing to deploy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy opened a new issue #330: docs: add Last updated on , by to docs
KishaniKandasamy opened a new issue #330: URL: https://github.com/apache/apisix-website/issues/330 **Actual Behaviour** Except https://apisix.apache.org/docs/general/ docs, Other projects lack details about when docs are updated by whom. **Expected Behaviour** Docs contains when docs are updated by whom. Something like apisix-website/website/docs/general/  **Steps to reproduce it** I think we could add showLastUpdateAuthor and showLastUpdateTime to docusurus.config.json for other docs. **Would you like to work on the issue?** Yes.I would like to work on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #4107: [discuss]：Hope apisix supports dynamic modification of nginx configuration
spacewander closed issue #4107: URL: https://github.com/apache/apisix/issues/4107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr opened a new pull request #4180: fix: fix peer missed in skywalking
dmsolr opened a new pull request #4180: URL: https://github.com/apache/apisix/pull/4180 ### What this PR does / why we need it: So far, `peer` of the exit span is a hard code, "upstream service". This is PR intends to fix it by getting `ip:port` from dynamic balancer. I tried to get the information at the `rewrite` phase, but it seems like cannot get it. Because of that, I move it into the `body_filter` phase. ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value
netlify[bot] edited a comment on pull request #1799: URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760 Deploy preview for *apisix-dashboard* ready! Built with commit dd479b66f16353a61b4cf0bd72162b3e98acf943 https://deploy-preview-1799--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value
netlify[bot] edited a comment on pull request #1799: URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760 Deploy preview for *apisix-dashboard* processing. Building with commit dd479b66f16353a61b4cf0bd72162b3e98acf943 https://app.netlify.com/sites/apisix-dashboard/deploys/6091187c56981741c24b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] 01/01: test: added testcase
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch fix-minor-issues
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
commit 601acd72dfdbd3bdf82b3616545cd742d637e846
Author: juzhiyuan
AuthorDate: Tue May 4 17:46:22 2021 +0800
test: added testcase
---
web/cypress/fixtures/selector.json | 5 -
.../route/create-edit-duplicate-delete-route.spec.js | 16 ++--
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/web/cypress/fixtures/selector.json
b/web/cypress/fixtures/selector.json
index f075bc0..86a9b20 100644
--- a/web/cypress/fixtures/selector.json
+++ b/web/cypress/fixtures/selector.json
@@ -75,5 +75,8 @@
"selectDropdown": ".ant-select-dropdown",
"codeMirrorMode": "[data-cy='code-mirror-mode']",
"selectJSON": ".ant-select-dropdown [label=JSON]",
- "deleteAlert": ".ant-modal-body"
+ "deleteAlert": ".ant-modal-body",
+ "schemaErrorMessage": ".ant-form-item-explain.ant-form-item-explain-error",
+ "advancedMatchingTable": ".ant-table-row.ant-table-row-level-0",
+ "advancedMatchingTableOperation": ".ant-space"
}
diff --git
a/web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
b/web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
index 5157f86..bac6611 100644
--- a/web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
+++ b/web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
@@ -64,7 +64,12 @@ context('Create and Delete Route', () => {
cy.contains('Confirm').click();
cy.contains('Next').click();
-cy.get(this.domSelector.nodes_0_host).type(this.data.host2);
+cy.get(this.domSelector.nodes_0_host).type('@');
+cy.get(this.domSelector.schemaErrorMessage).should('exist');
+cy.get(this.domSelector.nodes_0_host).clear().type('*1');
+cy.get(this.domSelector.schemaErrorMessage).should('not.exist');
+
+cy.get(this.domSelector.nodes_0_host).clear().type(this.data.host2);
cy.get(this.domSelector.nodes_0_port).type(this.data.port);
cy.get(this.domSelector.nodes_0_weight).type(this.data.weight);
cy.contains('Next').click();
@@ -128,7 +133,8 @@ context('Create and Delete Route', () => {
cy.get(this.domSelector.drawer).should('be.visible');
cy.get(this.domSelector.codemirrorScroll).within(() => {
- cy.contains('upstream').should("exist");
+ cy.contains('upstream').should('exist');
+ cy.contains('vars').should('exist')
cy.contains(name).should('exist');
});
});
@@ -145,6 +151,11 @@ context('Create and Delete Route', () => {
cy.get('#status').should('have.class', 'ant-switch-checked');
cy.get(this.domSelector.name).clear().type(newName);
cy.get(this.domSelector.description).clear().type(this.data.description2);
+cy.get(this.domSelector.advancedMatchingTable).should('exist');
+cy.get(this.domSelector.advancedMatchingTableOperation).within(() => {
+ cy.contains('Delete').click().should('not.exist');
+});
+
cy.contains('Next').click();
cy.contains('Next').click();
cy.contains('Next').click();
@@ -161,6 +172,7 @@ context('Create and Delete Route', () => {
cy.get(this.domSelector.codemirrorScroll).within(() => {
cy.contains('upstream').should("exist");
+ cy.contains('vars').should('not.exist');
cy.contains(newName).should('exist');
});
});
[apisix-dashboard] branch fix-minor-issues created (now 601acd7)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch fix-minor-issues in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 601acd7 test: added testcase This branch includes the following new commits: new 601acd7 test: added testcase The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1643: When creating a route, the upstream cannot select ‘none’
iamayushdas commented on issue #1643: URL: https://github.com/apache/apisix-dashboard/issues/1643#issuecomment-831815050 > @iamayushdas Please have a check if this issue gets fixed, if yes, then cc me to close this issue :) Thanks Ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1238: sync plugins' testcases from apisix automatically
juzhiyuan closed issue #1238: URL: https://github.com/apache/apisix-dashboard/issues/1238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1643: When creating a route, the upstream cannot select ‘none’
juzhiyuan commented on issue #1643: URL: https://github.com/apache/apisix-dashboard/issues/1643#issuecomment-831814278 @iamayushdas Please have a check if this issue gets fixed, if yes, then cc me to close this issue :) Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1827: When create the upstream, some properties can still be edited on the preview page
juzhiyuan closed issue #1827: URL: https://github.com/apache/apisix-dashboard/issues/1827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on pull request #4175: docs: fix broken links and ids in plugins
KishaniKandasamy commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831806244 > @spacewander what do you think about adding or moreover nesting example inside authentication -> hmac-auth -> example: hmac generate signature ? > @KishaniKandasamy want to know your opinion too Yes Ayush That would be better IMO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas edited a comment on pull request #4175: docs: fix broken links and ids in plugins
iamayushdas edited a comment on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831805292 @spacewander what do you think about adding or moreover nesting example inside authentication -> hmac-auth -> example: hmac generate signature ? @KishaniKandasamy want to know your opinion too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #4175: docs: fix broken links and ids in plugins
iamayushdas commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831805292 @spacewander what do you think about adding or moreover nesting example inside authentication -> hmac-auth -> example: hmac generate signature ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas opened a new issue #329: [Fe] dark mode enhancement in download page
iamayushdas opened a new issue #329: URL: https://github.com/apache/apisix-website/issues/329 **Actual Behaviour** In dark mode Dialogue appearing after clicking Download button in download page does not follow dark mode **Expected Behaviour** Dialogue box should also be following dark mode **Steps to reproduce it** - Goto apisix.apache.org -> click downloads -> click download button **Screenshots of the issue**  **Would you like to work on the issue?** yes i would like to work in this issue, but as this could be the good first issue , i would like new committers to give a PR :smiley: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit bef031ab4acfa49fb820f63d8c01c74ffd71bb7d https://app.netlify.com/sites/apisix-dashboard/deploys/6091126f8fe216000793fb8b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
juzhiyuan commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831787974 ok, just triggered to redeploy. Codes LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit 82933979330ff234b9dc20c2e3b7812e178323ec https://app.netlify.com/sites/apisix-dashboard/deploys/60910c857f4e92048dd9abc2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1814: fix: store init error from etcd and deferred execution of closers
bisakhmondal commented on a change in pull request #1814:
URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r625604849
##
File path: api/cmd/managerapi.go
##
@@ -65,6 +66,14 @@ func printVersion() {
// NewManagerAPICommand creates the manager-api command.
func NewManagerAPICommand() *cobra.Command {
+ cobra.OnInitialize(func() {
+ var err error
+ service, err = createService()
Review comment:
Hi @tokers, I'm afraid that's not possible here due to variable
shadowing.
`service` is a global variable and assignment through go's short assignment
operator (`:=`) will create a brand new `service` var in this scope without
referencing the global one.
I looked into the docs and also cross-checked
[ref](https://golang.org/ref/spec#Declarations_and_scope)
>An identifier declared in a block may be redeclared in an inner block.
While the identifier of the inner declaration is in scope, it denotes the
entity declared by the inner declaration.
Anyway, Thank you. Got the scope to re-read the docs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4179: feat(ext-plugin): handle error response
spacewander opened a new pull request #4179: URL: https://github.com/apache/apisix/pull/4179 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd edited a comment on issue #4124: request help: how to get current limit count from redis cache?
hzbd edited a comment on issue #4124: URL: https://github.com/apache/apisix/issues/4124#issuecomment-831746567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd edited a comment on issue #4124: request help: how to get current limit count from redis cache?
hzbd edited a comment on issue #4124: URL: https://github.com/apache/apisix/issues/4124#issuecomment-831746567  ps: this is a screenshot of redis key naming for consumer plugin `limit count` by `consumer_name ` part 1: common prefix part 2: consumer username part 3: ？ Q1: Is this part(part 3) a version attribute? Can you help find out where the key generation rules are in the source code? Q2: If it is convenient for a third-party program to directly obtain the consumer's latest limit count value in redis, can we remove part3 and only keep the latest version(part1 + part2)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd edited a comment on issue #4124: request help: how to get current limit count from redis cache?
hzbd edited a comment on issue #4124: URL: https://github.com/apache/apisix/issues/4124#issuecomment-831746567  ps: this is a screenshot of redis key naming for consumer plugin `limit count` by `consumer_name ` part 1: common prefix part 2: consumer username part 3: ？ Q1: Is this part(part 3) a version attribute? Can you help find out where the key generation rules are in the source code? Q2: If it is convenient for a third-party program to directly obtain the consumer's latest limit count value in redis, can we remove part3 and only keep the latest version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd edited a comment on issue #4124: request help: how to get current limit count from redis cache?
hzbd edited a comment on issue #4124: URL: https://github.com/apache/apisix/issues/4124#issuecomment-831746567  ps: this is a screenshot of redis key naming for consumer `limit count`. part 1: common prefix part 2: consumer username part 3: ？ Q1: Is this part(part 3) a version attribute? Can you help find out where the key generation rules are in the source code? Q2: If it is convenient for a third-party program to directly obtain the consumer's latest limit count value in redis, can we remove part3 and only keep the latest version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd edited a comment on issue #4124: request help: how to get current limit count from redis cache?
hzbd edited a comment on issue #4124: URL: https://github.com/apache/apisix/issues/4124#issuecomment-831746567  ps: this is a screenshot of redis key naming for limit count. part 1: common prefix part 2: consumer username part 3: ？ Is this part(part 3) a version attribute? Can you help find out where the key generation rules are in the source code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd edited a comment on issue #4124: request help: how to get current limit count from redis cache?
hzbd edited a comment on issue #4124: URL: https://github.com/apache/apisix/issues/4124#issuecomment-831746567  ps:This is a screenshot of redis key naming for limit count. part 1: common prefix part 2: consumer username part 3: ？ Is this part(part 3) a version attribute? Can you help find out where the key generation rules are in the source code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd commented on issue #4124: request help: how to get current limit count from redis cache?
hzbd commented on issue #4124: URL: https://github.com/apache/apisix/issues/4124#issuecomment-831746567  part 1: common prefix part 2: consumer username part 3: ？ Is this part(part 3) a version attribute? Can you help find out where the key generation rules are in the source code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4175: docs: fix broken links and ids in plugins
spacewander commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831740037 @KishaniKandasamy 1. Don't change something that works well. 2. Before you submit a PR, please discuss it carefully and limit the scope. Most of your change in this PR is not relative to "broken links" or `ids`. Even without a quote, I think most people will think https://host.domain/auth/realms/foo/.well-known/uma2-configuration is just a "fake" example instead of a real link. Those links are **used as the example**. How many people in the real world have been misled by those links? What's the evidence? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
qian0817 commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831735929 @juzhiyuan It throws an error when running `npm run build` during Netlify deployment, but it works fine on my local machine. Can you help me point out where is wrong? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4175: docs: fix broken links and ids in plugins
spacewander commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625560772 ## File path: docs/en/latest/plugins/authz-keycloak.md ## @@ -42,9 +42,9 @@ For more information on Keycloak, refer to [Keycloak Authorization Docs](https:/ | Name | Type | Requirement | Default | Valid | Description | | -- | - | --- | - | -- | --- | -| discovery | string| optional| | https://host.domain/auth/realms/foo/.well-known/uma2-configuration | URL to discovery document for Keycloak Authorization Services. | -| token_endpoint | string| optional| | https://host.domain/auth/realms/foo/protocol/openid-connect/token | A OAuth2-compliant Token Endpoint that supports the `urn:ietf:params:oauth:grant-type:uma-ticket` grant type. Overrides value from discovery, if given. | -| resource_registration_endpoint | string| optional| | https://host.domain/auth/realms/foo/authz/protection/resource_set | A Keycloak Protection API-compliant resource registration endpoint. Overrides value from discovery, if given. | +| discovery | string| optional| | `https://host.domain/auth/realms/foo/.well-known/uma2-configuration` | URL to discovery document for Keycloak Authorization Services. | Review comment: > It would be more helpful to me if you @spacewander explain me why you used (``) http://127.0.0.1:9080/apisix/dashboard/ in apisix.apache.org/docs/apisix/plugins/limit-req#how-to-enable-on-the-route-or-serivce. You should not ask me. If you know how to use `git blame`, you can see **every lines in this page is not written by me**. How can I answer you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] TkClark closed pull request #4178: Merge pull request #1 from apache/master
TkClark closed pull request #4178: URL: https://github.com/apache/apisix/pull/4178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] TkClark opened a new pull request #4178: Merge pull request #1 from apache/master
TkClark opened a new pull request #4178: URL: https://github.com/apache/apisix/pull/4178 Update ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imjoey commented on issue #4150: bug: Inconsistent behavior of schema check for response-rewrite plugin between AdminAPI and ManagerAPI
imjoey commented on issue #4150: URL: https://github.com/apache/apisix/issues/4150#issuecomment-831726093 > @imjoey i guess the issue is resolved now, you can close the issue now > > @iamayushdas I'm afraid not yet. In ADMIN API, response-rewrite plug-in also checks if the input `body` is base64-decodable, while there is no such check in MANAGER API. Current checks performed in MANAGER API is merely property validation, without any logical checks like ADMIN API. While, there is no such similar mechanism for additional plug-in checks in MANAGER API. Probably we would better to define the `checkSchema` method within each plug-in if it requires additional checks. Then we can exact the plugins from request data and check what we want to. Please let me know what do you think. Thanks. @tokers @iamayushdas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
codecov-commenter edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8293397) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.49%`. > The diff coverage is `59.13%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1816 +/- ## == + Coverage 71.78% 72.27% +0.49% == Files 172 125 -47 Lines6100 2958-3142 Branches 713 711 -2 == - Hits 4379 2138-2241 + Misses 1478 820 -658 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `72.27% <59.13%> (+0.29%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `64.78% <60.97%> (+1.85%)` | :arrow_up: | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <77.41%> (+0.57%)` | :arrow_up: | | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (-1.30%)` | :arrow_down: | | [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | | | [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | `94.64% <0.00%> (-0.10%)` | :arrow_down: | | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <0.00%> (ø)` | | |
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4175: docs: fix broken links and ids in plugins
KishaniKandasamy commented on a change in pull request #4175: URL: https://github.com/apache/apisix/pull/4175#discussion_r625550360 ## File path: docs/en/latest/plugins/authz-keycloak.md ## @@ -42,9 +42,9 @@ For more information on Keycloak, refer to [Keycloak Authorization Docs](https:/ | Name | Type | Requirement | Default | Valid | Description | | -- | - | --- | - | -- | --- | -| discovery | string| optional| | https://host.domain/auth/realms/foo/.well-known/uma2-configuration | URL to discovery document for Keycloak Authorization Services. | -| token_endpoint | string| optional| | https://host.domain/auth/realms/foo/protocol/openid-connect/token | A OAuth2-compliant Token Endpoint that supports the `urn:ietf:params:oauth:grant-type:uma-ticket` grant type. Overrides value from discovery, if given. | -| resource_registration_endpoint | string| optional| | https://host.domain/auth/realms/foo/authz/protection/resource_set | A Keycloak Protection API-compliant resource registration endpoint. Overrides value from discovery, if given. | +| discovery | string| optional| | `https://host.domain/auth/realms/foo/.well-known/uma2-configuration` | URL to discovery document for Keycloak Authorization Services. | Review comment: I thought ,If a phrase doesn't direct to any page ,we could better go with `` rather than explicitly showing it as a link,,something like   It would be more helpful to me if you @spacewander explain me why you used (``) `http://127.0.0.1:9080/apisix/dashboard/` in https://apisix.apache.org/docs/apisix/plugins/limit-req#how-to-enable-on-the-route-or-serivce. As I really don't know how to explain this, I would like to request @juzhiyuan too to review this PR ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4177: request help: I need tcp upstream connection result as a response to tcp client
spacewander commented on issue #4177: URL: https://github.com/apache/apisix/issues/4177#issuecomment-831722705 This feature is not supported by Nginx's stream subsystem's proxy_pass. But you can implement the proxy feature in Lua via `ngx.socket.tcp` and achieve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas edited a comment on issue #4150: bug: Inconsistent behavior of schema check for response-rewrite plugin between AdminAPI and ManagerAPI
iamayushdas edited a comment on issue #4150: URL: https://github.com/apache/apisix/issues/4150#issuecomment-831675431 @imjoey i guess the issue is resolved now, you can close the issue now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4175: docs: fix broken links and ids in plugins
spacewander commented on a change in pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#discussion_r625542469
##
File path: docs/en/latest/config.json
##
@@ -162,6 +162,13 @@
"discovery/eureka"
]
},
+{
+ "type": "category",
+ "label": "Examples",
Review comment:
And this problem should be fixed by the doc render framework itself.
Adding unrelative doc to the sidebar to fix it is **a hack**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4150: bug: Inconsistent behavior of schema check for response-rewrite plugin between AdminAPI and ManagerAPI
tokers commented on issue #4150: URL: https://github.com/apache/apisix/issues/4150#issuecomment-831718141 ping @imjoey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4175: docs: fix broken links and ids in plugins
spacewander commented on a change in pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#discussion_r625541979
##
File path: docs/en/latest/config.json
##
@@ -162,6 +162,13 @@
"discovery/eureka"
]
},
+{
+ "type": "category",
+ "label": "Examples",
Review comment:
Not all pages need a sidebar. They can go back from the browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4175: docs: fix broken links and ids in plugins
KishaniKandasamy commented on a change in pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#discussion_r625540565
##
File path: docs/en/latest/config.json
##
@@ -162,6 +162,13 @@
"discovery/eureka"
]
},
+{
+ "type": "category",
+ "label": "Examples",
Review comment:
So when visitors see this page
https://apisix.apache.org/docs/apisix/examples/plugins-hmac-auth-generate-signature,
how could they see other menus?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #328: docs: fixed kubernetes service api broken link
netlify[bot] commented on pull request #328: URL: https://github.com/apache/apisix-website/pull/328#issuecomment-831715603 Deploy preview for *apisix* processing. Building with commit b70a6a33beacc4747b94ac25ed8a5801e1da688c https://app.netlify.com/sites/apisix/deploys/6090ec022642840007d3b102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] xdshivani opened a new pull request #328: docs: fixed kubernetes service api broken link
xdshivani opened a new pull request #328: URL: https://github.com/apache/apisix-website/pull/328 Fixes: #326 Changes: fixed kubernetes service api broken link Thankyou @iamayushdas for making me understand architecture of apisix-website. Here is my first PR Have a look to this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit 82933979330ff234b9dc20c2e3b7812e178323ec https://app.netlify.com/sites/apisix-dashboard/deploys/6090ebadfaf7d40007d75d6c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1814: fix: store init error from etcd and deferred execution of closers
tokers commented on a change in pull request #1814:
URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r625537043
##
File path: api/cmd/managerapi.go
##
@@ -65,6 +66,14 @@ func printVersion() {
// NewManagerAPICommand creates the manager-api command.
func NewManagerAPICommand() *cobra.Command {
+ cobra.OnInitialize(func() {
+ var err error
+ service, err = createService()
Review comment:
Use short variables creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zhangwenjian opened a new issue #4177: request help: I need tcp upstream connection result as a response to tcp client
zhangwenjian opened a new issue #4177: URL: https://github.com/apache/apisix/issues/4177 ### Issue description I use openresty as my tcp protocol gateway, you can imagine that is a rdp gateway. The tcp client will send final server ip address after connected with gateway, and the balancer_by_lua_block will call set_current_peer to set the assigned server ip address as final backend. Then I need to response to the client that server is connected successfully or failed. But after set_current_peer returns, I don't known whether final backend server can be connected. How do to get the result and notify my client? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
