[GitHub] [apisix] sandy420 closed issue #3452: why? I can only get the first query through the interface (/apimix/admin/routes or /apimix/admin/upstreams or /apimix/admin/services)
sandy420 closed issue #3452: URL: https://github.com/apache/apisix/issues/3452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] fc13240 commented on pull request #4153: docs: update limit-count.md to add redis_password in `redis-cluster` policy
fc13240 commented on pull request #4153: URL: https://github.com/apache/apisix/pull/4153#issuecomment-833292070 finished update docs/zh/latest/plugins/limit-count.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #416: feat: add ApisixClusterConfig controller loop
codecov-commenter edited a comment on pull request #416: URL: https://github.com/apache/apisix-ingress-controller/pull/416#issuecomment-829782944 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#416](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (14905a5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0460a092004d5029c3936be91fbfe667291f73ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0460a09) will **decrease** coverage by `1.25%`. > The diff coverage is `15.04%`. > :exclamation: Current head 14905a5 differs from pull request most recent head 6da81fb. Consider uploading reports for the commit 6da81fb to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #416 +/- ## == - Coverage 38.33% 37.08% -1.26% == Files 42 43 +1 Lines3529 3713 +184 == + Hits 1353 1377 +24 - Misses 1997 2157 +160 Partials 179 179 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `55.00% <0.00%> (-0.94%)` | :arrow_down: | | [pkg/ingress/apisix\_cluster\_config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Vwc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/manifest.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvbWFuaWZlc3QuZ28=) | `66.66% <0.00%> (-1.13%)` | :arrow_down: | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `51.38% <ø> (ø)` | | | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `64.70% <40.00%> (-19.51%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `27.27% <60.00%> (-0.12%)` | :arr
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #416: feat: add ApisixClusterConfig controller loop
codecov-commenter edited a comment on pull request #416: URL: https://github.com/apache/apisix-ingress-controller/pull/416#issuecomment-829782944 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#416](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (304d742) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0460a092004d5029c3936be91fbfe667291f73ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0460a09) will **decrease** coverage by `0.82%`. > The diff coverage is `15.04%`. > :exclamation: Current head 304d742 differs from pull request most recent head 6da81fb. Consider uploading reports for the commit 6da81fb to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #416 +/- ## == - Coverage 38.33% 37.51% -0.83% == Files 42 43 +1 Lines3529 3713 +184 == + Hits 1353 1393 +40 - Misses 1997 2143 +146 + Partials 179 177 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `55.00% <0.00%> (-0.94%)` | :arrow_down: | | [pkg/ingress/apisix\_cluster\_config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Vwc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/manifest.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvbWFuaWZlc3QuZ28=) | `66.66% <0.00%> (-1.13%)` | :arrow_down: | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `51.38% <ø> (ø)` | | | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `64.70% <40.00%> (-19.51%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `32.90% <60.00%> (+5.50%)` | :arr
[GitHub] [apisix-ingress-controller] fregie commented on pull request #419: ci: add golangci-lint
fregie commented on pull request #419:
URL:
https://github.com/apache/apisix-ingress-controller/pull/419#issuecomment-833303001
Fixed,please check it.
I notice that golantci-lint run failed:
``` golang
Error: pkg/kube/translation/context.go:32:29: func
`(*TranslateContext).addStreamRoute` is unused (unused)
func (tc *TranslateContext) addStreamRoute(sr *apisix.StreamRoute) {
```
Should I fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] fregie edited a comment on pull request #419: ci: add golangci-lint
fregie edited a comment on pull request #419:
URL:
https://github.com/apache/apisix-ingress-controller/pull/419#issuecomment-833303001
Fixed,please check it.
I notice that golangci-lint run failed:
``` golang
Error: pkg/kube/translation/context.go:32:29: func
`(*TranslateContext).addStreamRoute` is unused (unused)
func (tc *TranslateContext) addStreamRoute(sr *apisix.StreamRoute) {
```
Should I fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-833320046 > Hi @bisakhmondal, there have some errors in Backend CI. Yeshh!! Sad moments🥺 Looking into it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1838: chore: use data value directly in tests
juzhiyuan commented on pull request #1838: URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833320396 @iamayushdas Hi, please update other test cases in other PRs. One PR with one Testcase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #182: refactor: fix Google Lighthouse errors and warnings
juzhiyuan commented on issue #182: URL: https://github.com/apache/apisix-website/issues/182#issuecomment-833321416 ok! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1838: chore: use data value directly in tests
iamayushdas commented on pull request #1838: URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833321523 > @iamayushdas Hi, please update other test cases in other PRs. One PR with one Testcase. okay sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] fregie edited a comment on pull request #419: ci: add golangci-lint
fregie edited a comment on pull request #419:
URL:
https://github.com/apache/apisix-ingress-controller/pull/419#issuecomment-833303001
@tokers
Fixed,please check it.
I notice that golangci-lint run failed:
``` golang
Error: pkg/kube/translation/context.go:32:29: func
`(*TranslateContext).addStreamRoute` is unused (unused)
func (tc *TranslateContext) addStreamRoute(sr *apisix.StreamRoute) {
```
Should I fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #419: ci: add golangci-lint
gxthrj commented on pull request #419: URL: https://github.com/apache/apisix-ingress-controller/pull/419#issuecomment-833327384 ping @tokers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #419: ci: add golangci-lint
tokers commented on pull request #419:
URL:
https://github.com/apache/apisix-ingress-controller/pull/419#issuecomment-833327857
> @tokers
> Fixed,please check it.
> I notice that golangci-lint run failed:
>
> ```go
> Error: pkg/kube/translation/context.go:32:29: func
`(*TranslateContext).addStreamRoute` is unused (unused)
> func (tc *TranslateContext) addStreamRoute(sr *apisix.StreamRoute) {
> ```
>
> Should I fix this?
We can wait until another PR about TCP proxy is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #416: feat: add ApisixClusterConfig controller loop
gxthrj commented on pull request #416: URL: https://github.com/apache/apisix-ingress-controller/pull/416#issuecomment-83861 There are many overlaps with this [pr](https://github.com/apache/apisix-ingress-controller/pull/414), should we merge #414 first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #414: chore: optimize the apisix cluster processing
gxthrj commented on pull request #414: URL: https://github.com/apache/apisix-ingress-controller/pull/414#issuecomment-86523 > > I have two questions. > > How to configure multi-clusters ? > > How to match cluster `name` and `admin url` and `key`? > > Not in this PR. See the issue description, multiple-clusters will be supported in the future, this PR is just one of the prerequisites. It is difficult to set up a multi-cluster according to the current configuration. The user modified the configuration according to `defaultxxx` this time, and the next time the multi-cluster is actually configured, it will be modified again. It is hoped that this modification can finalize the configuration file structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #4160: bug: Seek help !Problems of Prometheus, This should be a bug, please fix it!!!
tzssangglass commented on issue #4160:
URL: https://github.com/apache/apisix/issues/4160#issuecomment-833340213
my reproduction process
1. start apisix 2.4
2. add route
```json
{
"update_time": 1619936610,
"uri": "/hello",
"create_time": 1619936610,
"id": "1",
"status": 1,
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:1980": 1
},
"scheme": "http",
"hash_on": "vars",
"pass_host": "pass"
},
"priority": 0
}
```
3. `curl -i http://127.0.0.1:9080/apisix/prometheus/metrics`
`item.modifiedIndex` is a number type value.
what did you do to cause `item.modifiedIndex` to become a string type value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] sandy420 commented on issue #4160: bug: Seek help !Problems of Prometheus, This should be a bug, please fix it!!!
sandy420 commented on issue #4160:
URL: https://github.com/apache/apisix/issues/4160#issuecomment-833350765
This is one of my route configurations:
{
"methods": [
"HEAD",
"POST",
"GET",
"PUT",
"DELETE",
"OPTIONS",
"PATCH"
],
"id": "7643",
"hosts": [
"..com"
],
"status": 1,
"desc": "",
"update_time": 1619686104,
"create_time": 1618974733,
"enable_websocket": false,
"plugin_config_id": "666",
"name": "x",
"upstream_id": "345631436537070303",
"uris": [
"/x/*"
],
"plugins": {
"proxy-rewrite": {
"disable": false,
"host": "x..com",
"headers": {
"primeval_host": "$host",
"Cookie":
"xxx_online=$cookie_xxx_passport;xxx_passport=$cookie_dev_passport;
$http_cookie"
}
}
},
"priority": 0
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] jbampton opened a new pull request #4188: docs: fix links in Arabic and English docs
jbampton opened a new pull request #4188: URL: https://github.com/apache/apisix/pull/4188 ### What this PR does / why we need it: Mainly fixes links in the Arabic README. Need to fix the broken links for better user experience. Also created the correct "latest" folder for Arabic like the other languages. ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4186: fix: init dns resolvers in stream subsystem
spacewander merged pull request #4186: URL: https://github.com/apache/apisix/pull/4186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (17ae333 -> f7460ee)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 17ae333 doc: fix capitalization and image alt attributes (#4008) add f7460ee fix: init dns resolvers in stream subsystem (#4186) No new revisions were added by this update. Summary of changes: apisix/cli/ngx_tpl.lua | 6 +- apisix/init.lua| 4 +++- t/APISIX.pm| 5 - t/misc/patch.t | 33 + 4 files changed, 45 insertions(+), 3 deletions(-)
[GitHub] [apisix] spacewander closed issue #3939: docs: update limit-count.md document
spacewander closed issue #3939: URL: https://github.com/apache/apisix/issues/3939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4153: docs: update limit-count.md to add redis_password in `redis-cluster` policy
spacewander merged pull request #4153: URL: https://github.com/apache/apisix/pull/4153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4184: docs: update README.md to add WeChat public number, video number of QR code pictures.
spacewander merged pull request #4184: URL: https://github.com/apache/apisix/pull/4184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (f7460ee -> 81120e4)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from f7460ee fix: init dns resolvers in stream subsystem (#4186) add 81120e4 docs: update limit-count.md to add redis_password in `redis-cluster` policy (#4153) No new revisions were added by this update. Summary of changes: docs/en/latest/plugins/limit-count.md | 1 + docs/zh/latest/plugins/limit-count.md | 1 + 2 files changed, 2 insertions(+)
[apisix] branch master updated (81120e4 -> 8de7df9)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 81120e4 docs: update limit-count.md to add redis_password in `redis-cluster` policy (#4153) add 8de7df9 docs: update README.md to add WeChat public number, video number of QR code pictures. (#4184) No new revisions were added by this update. Summary of changes: docs/assets/images/MA.jpeg | Bin 0 -> 45199 bytes docs/assets/images/OA.jpg | Bin 0 -> 27192 bytes docs/zh/latest/README.md | 4 3 files changed, 4 insertions(+) create mode 100644 docs/assets/images/MA.jpeg create mode 100644 docs/assets/images/OA.jpg
[GitHub] [apisix] spacewander opened a new pull request #4189: docs: avoid the misleading comment
spacewander opened a new pull request #4189: URL: https://github.com/apache/apisix/pull/4189 Also remove helpless yaml lint. Fix #3962 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #416: feat: add ApisixClusterConfig controller loop
tokers commented on pull request #416: URL: https://github.com/apache/apisix-ingress-controller/pull/416#issuecomment-833405798 > There are many overlaps with this [pr](https://github.com/apache/apisix-ingress-controller/pull/414), should we merge #414 first? Yep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #414: chore: optimize the apisix cluster processing
gxthrj commented on pull request #414: URL: https://github.com/apache/apisix-ingress-controller/pull/414#issuecomment-833408418 Got it, with `ApisixClusterConfig` CRD . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: chore: optimize the apisix cluster processing (#414)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new a3279e4 chore: optimize the apisix cluster processing (#414) a3279e4 is described below commit a3279e4028643799d0d3e5b0e3298f5366435f51 Author: Alex Zhang AuthorDate: Thu May 6 18:14:32 2021 +0800 chore: optimize the apisix cluster processing (#414) * chore: optimize the apisix cluster processing * fix --- cmd/ingress/ingress.go | 7 +-- conf/config-default.yaml | 15 +-- pkg/apisix/apisix.go | 26 ++ pkg/config/config.go | 26 -- pkg/config/config_test.go | 14 -- pkg/ingress/apisix_upstream.go | 6 -- pkg/ingress/controller.go | 15 --- pkg/ingress/manifest.go| 14 -- 8 files changed, 96 insertions(+), 27 deletions(-) diff --git a/cmd/ingress/ingress.go b/cmd/ingress/ingress.go index f90b50f..df931ef 100644 --- a/cmd/ingress/ingress.go +++ b/cmd/ingress/ingress.go @@ -147,8 +147,11 @@ the apisix cluster and others are created`, cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ElectionID, "election-id", config.IngressAPISIXLeader, "election id used for campaign the controller leader") cmd.PersistentFlags().StringVar(&cfg.Kubernetes.IngressVersion, "ingress-version", config.IngressNetworkingV1, "the supported ingress api group version, can be \"networking/v1beta1\", \"networking/v1\" (for Kubernetes version v1.19.0 or higher) and \"extensions/v1beta1\"") cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixRouteVersion, "apisix-route-version", config.ApisixRouteV2alpha1, "the supported apisixroute api group version, can be \"apisix.apache.org/v1\" or \"apisix.apache.org/v2alpha1\"") - cmd.PersistentFlags().StringVar(&cfg.APISIX.BaseURL, "apisix-base-url", "", "the base URL for APISIX admin api / manager api") - cmd.PersistentFlags().StringVar(&cfg.APISIX.AdminKey, "apisix-admin-key", "", "admin key used for the authorization of APISIX admin api / manager api") + cmd.PersistentFlags().StringVar(&cfg.APISIX.BaseURL, "apisix-base-url", "", "the base URL for APISIX admin api / manager api (deprecated, using --default-apisix-cluster-base-url instead)") + cmd.PersistentFlags().StringVar(&cfg.APISIX.AdminKey, "apisix-admin-key", "", "admin key used for the authorization of APISIX admin api / manager api (deprecated, using --default-apisix-cluster-admin-key instead)") + cmd.PersistentFlags().StringVar(&cfg.APISIX.DefaultClusterBaseURL, "default-apisix-cluster-base-url", "", "the base URL of admin api / manager api for the default APISIX cluster") + cmd.PersistentFlags().StringVar(&cfg.APISIX.DefaultClusterAdminKey, "default-apisix-cluster-admin-key", "", "admin key used for the authorization of admin api / manager api for the default APISIX cluster") + cmd.PersistentFlags().StringVar(&cfg.APISIX.DefaultClusterName, "default-apisix-cluster-name", "default", "name of the default apisix cluster") return cmd } diff --git a/conf/config-default.yaml b/conf/config-default.yaml index e255b18..78c4f5d 100644 --- a/conf/config-default.yaml +++ b/conf/config-default.yaml @@ -43,7 +43,7 @@ kubernetes: election_id: "ingress-apisix-leader" # the election id for the controller leader campaign, # only the leader will watch and delivery resource changes, # other instances (as candidates) stand by. - ingress_class: "apisix" # The class of an Ingress object is set using the field + ingress_class: "apisix" # the class of an Ingress object is set using the field # IngressClassName in Kubernetes clusters version v1.18.0 # or higher or the annotation "kubernetes.io/ingress.class" # (deprecated). @@ -56,5 +56,16 @@ kubernetes: # default is "apisix.apache.org/v2alpha1". # APISIX related configurations. apisix: - base_url: "http://127.0.0.1:9080/apisix/admin"; # the APISIX admin api / manager api + base_url: "http://127.0.0.1:9080/apisix/admin"; # (Deprecated, use default_cluster_base_url) the APISIX admin api / manager api # base url, it's required. + + default_cluster_base_url: "http://127.0.0.1:9080/apisix/admin"; # The base url of admin api / manager api + # of the default APISIX cluster + + admin_key: "" # (Deprecated, use default_cluster_admin_key) the admin key used for the authenti
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #414: chore: optimize the apisix cluster processing
gxthrj merged pull request #414: URL: https://github.com/apache/apisix-ingress-controller/pull/414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #416: feat: add ApisixClusterConfig controller loop
gxthrj commented on pull request #416: URL: https://github.com/apache/apisix-ingress-controller/pull/416#issuecomment-833409017 some conflicting files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #416: feat: add ApisixClusterConfig controller loop
tokers commented on pull request #416: URL: https://github.com/apache/apisix-ingress-controller/pull/416#issuecomment-833411237 @gxthrj Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm opened a new issue #420: add examples about migrating from nginx ingress controller
lxm opened a new issue #420: URL: https://github.com/apache/apisix-ingress-controller/issues/420 ### Issue description Due to most people started to get in touch with Kubernetes ingress is using `nginx ingress controller`, so it is likely to use a lot of nginx ingress's annotations. It's a good idea to add some example about migrating from nginx ingress controller. Such as ``` nginx.ingress.kubernetes.io/configuration-snippet: | rewrite ^/api/(.*) /$1 break; ``` ``` nginx.ingress.kubernetes.io/proxy-body-size ``` and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4189: docs: avoid the misleading comment
spacewander commented on pull request #4189: URL: https://github.com/apache/apisix/pull/4189#issuecomment-833441108 If we ignore it, there is almost nothing left that can be checked. I quite regard about accepting yamllint. Several months have been passed, it has been proved that the linter is helpless but causes misleading and inconvenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4189: docs: avoid the misleading comment
spacewander commented on pull request #4189: URL: https://github.com/apache/apisix/pull/4189#issuecomment-833442889 Don't try to sell us linter anymore... We are not an experimental lab for such "modern" technologies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton commented on pull request #4189: docs: avoid the misleading comment
jbampton commented on pull request #4189: URL: https://github.com/apache/apisix/pull/4189#issuecomment-833445268 You are wrong again since the comments disable rule is only one yamllint rule and there are many to check. There are about 20 yamllint rules :) Also most of the worlds top projects use yamllint like Apache Airflow and they know it's not helpless. https://yamllint.readthedocs.io/en/latest/rules.html https://user-images.githubusercontent.com/418747/117289867-78da9480-aeb0-11eb-8bca-1971f7d24d21.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #416: feat: add ApisixClusterConfig controller loop
gxthrj commented on a change in pull request #416:
URL:
https://github.com/apache/apisix-ingress-controller/pull/416#discussion_r627331195
##
File path: test/e2e/scaffold/k8s.go
##
@@ -193,6 +193,26 @@ func (s *Scaffold) ListApisixUpstreams() ([]*v1.Upstream,
error) {
return cli.Cluster("").Upstream().List(context.TODO())
}
+// ListApisixGlobalRules list all global_rules from APISIX
+func (s *Scaffold) ListApisixGlobalRules() ([]*v1.GlobalRule, error) {
+ u := url.URL{
+ Scheme: "http",
+ Host: s.apisixAdminTunnel.Endpoint(),
+ Path: "/apisix/admin",
+ }
+ cli, err := apisix.NewClient()
+ if err != nil {
+ return nil, err
+ }
+ err = cli.AddCluster(&apisix.ClusterOptions{
+ BaseURL: u.String(),
+ })
+ if err != nil {
+ return nil, err
+ }
+ return cli.Cluster("").GlobalRule().List(context.TODO())
Review comment:
Should cluster be got with `DefaultClusterName`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Molio-tan commented on issue #4157: bug: After installing the Apisix on ARM-based System,but it can't works properly.
Molio-tan commented on issue #4157: URL: https://github.com/apache/apisix/issues/4157#issuecomment-833446367 > 1. check that `events.lua` does not appear in the search path of the error log > 2. check the `events.lua` file permissions Thank you for your rely. I check the file`events.lua`esixts in the path below as the red box:  And the file permissions as follows  I installed the apisix with the `root` user all the time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #420: add examples about migrating from nginx ingress controller
tokers commented on issue #420: URL: https://github.com/apache/apisix-ingress-controller/issues/420#issuecomment-833446977 @lxm That's right, we may maintain a document to tell people if you're using xxx feature in ingress-nginx, and you're trying to migrate to ingress-apisix, that what you need to configure to achieve the same purpose. Workload is huge, but we can list some common and important features, adding examples for them preferentially. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #420: add examples about migrating from nginx ingress controller
tokers commented on issue #420: URL: https://github.com/apache/apisix-ingress-controller/issues/420#issuecomment-833447138 @gxthrj @tao12345666333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #401: feat: tcp route translation
gxthrj commented on a change in pull request #401:
URL:
https://github.com/apache/apisix-ingress-controller/pull/401#discussion_r627332911
##
File path: test/e2e/scaffold/k8s.go
##
@@ -213,6 +224,26 @@ func (s *Scaffold) ListApisixRoutes() ([]*v1.Route, error)
{
return cli.Cluster("").Route().List(context.TODO())
}
+// ListApisixStreamRoutes list all stream_routes from APISIX.
+func (s *Scaffold) ListApisixStreamRoutes() ([]*v1.StreamRoute, error) {
+ u := url.URL{
+ Scheme: "http",
+ Host: s.apisixAdminTunnel.Endpoint(),
+ Path: "/apisix/admin",
+ }
+ cli, err := apisix.NewClient()
+ if err != nil {
+ return nil, err
+ }
+ err = cli.AddCluster(&apisix.ClusterOptions{
+ BaseURL: u.String(),
+ })
+ if err != nil {
+ return nil, err
+ }
+ return cli.Cluster("").StreamRoute().List(context.TODO())
Review comment:
Need to update from `master`, ClusterName need to be specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #401: feat: tcp route translation
tokers commented on a change in pull request #401:
URL:
https://github.com/apache/apisix-ingress-controller/pull/401#discussion_r627333831
##
File path: test/e2e/scaffold/k8s.go
##
@@ -213,6 +224,26 @@ func (s *Scaffold) ListApisixRoutes() ([]*v1.Route, error)
{
return cli.Cluster("").Route().List(context.TODO())
}
+// ListApisixStreamRoutes list all stream_routes from APISIX.
+func (s *Scaffold) ListApisixStreamRoutes() ([]*v1.StreamRoute, error) {
+ u := url.URL{
+ Scheme: "http",
+ Host: s.apisixAdminTunnel.Endpoint(),
+ Path: "/apisix/admin",
+ }
+ cli, err := apisix.NewClient()
+ if err != nil {
+ return nil, err
+ }
+ err = cli.AddCluster(&apisix.ClusterOptions{
+ BaseURL: u.String(),
+ })
+ if err != nil {
+ return nil, err
+ }
+ return cli.Cluster("").StreamRoute().List(context.TODO())
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #401: feat: tcp route translation
tokers commented on a change in pull request #401:
URL:
https://github.com/apache/apisix-ingress-controller/pull/401#discussion_r627335654
##
File path: test/e2e/scaffold/k8s.go
##
@@ -213,6 +224,26 @@ func (s *Scaffold) ListApisixRoutes() ([]*v1.Route, error)
{
return cli.Cluster("").Route().List(context.TODO())
}
+// ListApisixStreamRoutes list all stream_routes from APISIX.
+func (s *Scaffold) ListApisixStreamRoutes() ([]*v1.StreamRoute, error) {
+ u := url.URL{
+ Scheme: "http",
+ Host: s.apisixAdminTunnel.Endpoint(),
+ Path: "/apisix/admin",
+ }
+ cli, err := apisix.NewClient()
+ if err != nil {
+ return nil, err
+ }
+ err = cli.AddCluster(&apisix.ClusterOptions{
+ BaseURL: u.String(),
+ })
+ if err != nil {
+ return nil, err
+ }
+ return cli.Cluster("").StreamRoute().List(context.TODO())
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Molio-tan commented on issue #1832: bug: apisix-dashboard v2.5 make build failed on Huawei Kunpeng system
Molio-tan commented on issue #1832: URL: https://github.com/apache/apisix-dashboard/issues/1832#issuecomment-833449970 > > > @Molio-tan the logs seem not very helpful. So could you please show us more information from the `/var/log/message` and `dmesg` command during the installation? I believe that they could give us some clues. Thanks. > > > > > > Ok, but I don't know exactly about how many lines or messages created during the installation.Forgive me to giving the whole file as follows. > > [messages.log](https://github.com/apache/apisix-dashboard/files/6431355/messages.log) > > [dmesg.log](https://github.com/apache/apisix-dashboard/files/6431357/dmesg.log) > > @Molio-tan thanks for providing the logs, while I'm so sorry that I've to say I can find nothing useful to help us get through with this issue. Do you mind adding my WeChat `majunjiev` that I'm able to debug your environment? Thanks. No, I don't mind that. I had send the request for your Wechat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1838: chore: use data value directly in tests
guoqqqi commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627335494
##
File path:
web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##
@@ -17,38 +17,52 @@
/* eslint-disable no-undef */
context('Create and delete consumer with proxy-mirror plugin form', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
-
const selector = {
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
+notificationCloseIcon: '.ant-notification-close-icon',
host: "#host",
alert: "[role=alert]"
}
Review comment:
```suggestion
notification: '.ant-notification-notice-message',
notificationCloseIcon: '.ant-notification-close-icon',
host: '#host',
alert: '[role=alert]'
}
```
It is best to use both single and double quotation marks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #416: feat: add ApisixClusterConfig controller loop
tokers commented on a change in pull request #416:
URL:
https://github.com/apache/apisix-ingress-controller/pull/416#discussion_r627336341
##
File path: test/e2e/scaffold/k8s.go
##
@@ -193,6 +193,26 @@ func (s *Scaffold) ListApisixUpstreams() ([]*v1.Upstream,
error) {
return cli.Cluster("").Upstream().List(context.TODO())
}
+// ListApisixGlobalRules list all global_rules from APISIX
+func (s *Scaffold) ListApisixGlobalRules() ([]*v1.GlobalRule, error) {
+ u := url.URL{
+ Scheme: "http",
+ Host: s.apisixAdminTunnel.Endpoint(),
+ Path: "/apisix/admin",
+ }
+ cli, err := apisix.NewClient()
+ if err != nil {
+ return nil, err
+ }
+ err = cli.AddCluster(&apisix.ClusterOptions{
+ BaseURL: u.String(),
+ })
+ if err != nil {
+ return nil, err
+ }
+ return cli.Cluster("").GlobalRule().List(context.TODO())
Review comment:
Here we don't need to do this because the cluster is added by ourselves
(see the code above this line), which is nameless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #401: feat: tcp route translation
codecov-commenter edited a comment on pull request #401: URL: https://github.com/apache/apisix-ingress-controller/pull/401#issuecomment-824684718 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#401](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (998eebe) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/a3279e4028643799d0d3e5b0e3298f5366435f51?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3279e4) will **decrease** coverage by `0.81%`. > The diff coverage is `28.23%`. > :exclamation: Current head 998eebe differs from pull request most recent head 20992f7. Consider uploading reports for the commit 20992f7 to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #401 +/- ## == - Coverage 38.90% 38.09% -0.82% == Files 42 41 -1 Lines3557 3628 +71 == - Hits 1384 1382 -2 - Misses 1996 2067 +71 - Partials 177 179 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `43.26% <0.00%> (-5.12%)` | :arrow_down: | | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `60.86% <0.00%> (-39.14%)` | :arrow_down: | | [pkg/ingress/manifest.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvbWFuaWZlc3QuZ28=) | `67.90% <80.00%> (+1.23%)` | :arrow_up: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `27.39% <0.00%> (-5.66%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `33.33% <0.00%> (-2.23%)` | :arrow_down: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?u
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1838: chore: use data value directly in tests
iamayushdas commented on pull request #1838: URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833451351 Ok @guoqqqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4157: bug: After installing the Apisix on ARM-based System,but it can't works properly.
tokers commented on issue #4157: URL: https://github.com/apache/apisix/issues/4157#issuecomment-833451897 @Molio-tan Which user are used for running APISIX? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat: upgrade lua-resty-radixtree & retire patch (#4185)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new b551f42 feat: upgrade lua-resty-radixtree & retire patch (#4185)
b551f42 is described below
commit b551f42d90d07598efd775fdeac392043534f8b4
Author: 罗泽轩
AuthorDate: Thu May 6 19:39:13 2021 +0800
feat: upgrade lua-resty-radixtree & retire patch (#4185)
Signed-off-by: spacewander
---
apisix/patch.lua | 24
rockspec/apisix-master-0.rockspec | 4 ++--
2 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/apisix/patch.lua b/apisix/patch.lua
index 66bf17d..a291110 100644
--- a/apisix/patch.lua
+++ b/apisix/patch.lua
@@ -24,7 +24,6 @@ local ngx_socket = ngx.socket
local original_tcp = ngx.socket.tcp
local concat_tab = table.concat
local new_tab = require("table.new")
-local expr = require("resty.expr.v1")
local log = ngx.log
local WARN = ngx.WARN
local ipairs = ipairs
@@ -268,27 +267,6 @@ local function luasocket_tcp()
end
-local patched_expr_new
-do
-local function eval_empty_rule(self, ctx, ...)
-return true
-end
-
-
-local mt = {__index = {eval = eval_empty_rule}}
-local old_expr_new = expr.new
-
-
-function patched_expr_new(rule)
-if #rule == 0 then
-return setmetatable({}, mt)
-end
-
-return old_expr_new(rule)
-end
-end
-
-
function _M.patch()
-- make linter happy
-- luacheck: ignore
@@ -300,8 +278,6 @@ function _M.patch()
return luasocket_tcp()
end
-
-expr.new = patched_expr_new
end
diff --git a/rockspec/apisix-master-0.rockspec
b/rockspec/apisix-master-0.rockspec
index bc1082f..6207610 100644
--- a/rockspec/apisix-master-0.rockspec
+++ b/rockspec/apisix-master-0.rockspec
@@ -44,7 +44,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
-"lua-resty-radixtree = 2.7.0",
+"lua-resty-radixtree = 2.8.0",
"lua-protobuf = 0.3.1",
"lua-resty-openidc = 1.7.2-1",
"luafilesystem = 1.7.0-2",
@@ -59,7 +59,7 @@ dependencies = {
"binaryheap = 0.4",
"dkjson = 2.5-2",
"resty-redis-cluster = 1.02-4",
-"lua-resty-expr = 1.2.0",
+"lua-resty-expr = 1.3.0",
"graphql = 0.0.2",
"argparse = 0.7.1-1",
"luasocket = 3.0rc1-2",
[GitHub] [apisix] tokers merged pull request #4185: feat: upgrade lua-resty-radixtree & retire patch
tokers merged pull request #4185: URL: https://github.com/apache/apisix/pull/4185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1838: chore: use data value directly in tests
juzhiyuan commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627350348
##
File path:
web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##
@@ -17,38 +17,52 @@
/* eslint-disable no-undef */
context('Create and delete consumer with proxy-mirror plugin form', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
-
const selector = {
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
+notificationCloseIcon: '.ant-notification-close-icon',
host: "#host",
alert: "[role=alert]"
}
Review comment:
Why there have spaces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Donghui0 opened a new issue #421: bug: The upstream associated with other routes cannot be deleted, and the delete event keeps retrying
Donghui0 opened a new issue #421: URL: https://github.com/apache/apisix-ingress-controller/issues/421 ### Issue description controller log as below:  upstream delete failed, The delete event is added to the queue again. ### Environment * apisix-ingress-controller version: v0.5.0 * Kubernetes cluster version: v1.16.9 ### Minimal test code / Steps to reproduce the issue 1. create apisix route, service field references an existing k8s service. 2. delete apisix route resouce ### What's the actual result? (including assertion message & call stack if applicable) the delete event keeps retrying ### What's the expected result? ignore related upstream  add resp.StatusCode != 400 condition ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1838: chore: use data value directly in tests
guoqqqi commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627352223
##
File path:
web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##
@@ -17,38 +17,52 @@
/* eslint-disable no-undef */
context('Create and delete consumer with proxy-mirror plugin form', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
-
const selector = {
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
+notificationCloseIcon: '.ant-notification-close-icon',
host: "#host",
alert: "[role=alert]"
}
Review comment:
This is my problem. I didn't see the space gap clearly when commenting
on my phone……
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #4160: bug: Seek help !Problems of Prometheus, This should be a bug, please fix it!!!
tzssangglass commented on issue #4160:
URL: https://github.com/apache/apisix/issues/4160#issuecomment-833468542
@sandy420 good catch! welcome PR!
I can reproduce it now
step 1：create a plugin config
```
curl http://127.0.0.1:9080/apisix/admin/plugin_configs/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"desc": "blah",
"plugins": {
"prometheus":{}
}
}'
```
step2: bind it to route
```
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"uris": ["/hello"],
"plugin_config_id": 1,
"plugins": {
"limit-count": {
"count": 20,
"time_window": 60,
"rejected_code": 503
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:1980": 1
}
}
}'
```
step3: trigger route
```
curl 127.0.0.1:9080/hello
```
step4: request prometheus endpoint
```
curl http://127.0.0.1:9080/apisix/prometheus/metrics
```
if it does not appear, repeat step4.
the error.log is
```
2021/05/06 20:00:17 [error] 32148#32148: *480 lua entry thread aborted:
runtime error: /usr/local/apisix/apisix/plugins/prometheus/exporter.lua:209:
attempt to compare number with string
stack traceback:
coroutine 0:
/usr/local/apisix/apisix/plugins/prometheus/exporter.lua: in function
'set_modify_index'
/usr/local/apisix/apisix/plugins/prometheus/exporter.lua:232: in
function 'etcd_modify_index'
/usr/local/apisix/apisix/plugins/prometheus/exporter.lua:298: in
function 'handler'
/usr/local/apisix/apisix/api_router.lua:130: in function 'handler'
/usr/local/apisix//deps/share/lua/5.1/resty/radixtree.lua:720: in
function 'dispatch'
/usr/local/apisix/apisix/api_router.lua:165: in function 'match'
/usr/local/apisix/apisix/init.lua:292: in function 'http_access_phase'
access_by_lua(nginx.conf:204):2: in main chunk, client: 127.0.0.1,
server: , request: "GET /apisix/prometheus/metrics HTTP/1.1", host:
"127.0.0.1:9080"
```
this problem may be caused by
https://github.com/apache/apisix/blob/b551f42d90d07598efd775fdeac392043534f8b4/apisix/plugin_config.lua#L65
@spacewander pls take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1838: chore: use data value directly in tests
juzhiyuan commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627379075
##
File path:
web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##
@@ -17,38 +17,52 @@
/* eslint-disable no-undef */
context('Create and delete consumer with proxy-mirror plugin form', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
-
const selector = {
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
+notificationCloseIcon: '.ant-notification-close-icon',
host: "#host",
alert: "[role=alert]"
}
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1838: chore: use data value directly in tests
guoqqqi commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627335494
##
File path:
web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##
@@ -17,38 +17,52 @@
/* eslint-disable no-undef */
context('Create and delete consumer with proxy-mirror plugin form', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
-
const selector = {
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
+notificationCloseIcon: '.ant-notification-close-icon',
host: "#host",
alert: "[role=alert]"
}
Review comment:
```suggestion
notification: '.ant-notification-notice-message',
notificationCloseIcon: '.ant-notification-close-icon',
host: '#host',
alert: '[role=alert]'
}
```
It is best to use both single and double quotation marks
##
File path:
web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##
@@ -17,38 +17,52 @@
/* eslint-disable no-undef */
context('Create and delete consumer with proxy-mirror plugin form', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
-
const selector = {
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
+notificationCloseIcon: '.ant-notification-close-icon',
host: "#host",
alert: "[role=alert]"
}
Review comment:
```suggestion
notification: '.ant-notification-notice-message',
notificationCloseIcon: '.ant-notification-close-icon',
host: '#host',
alert: '[role=alert]'
}
```
It is best to use both single and double quotation marks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1839: chore: update plugin catagory display name.
juzhiyuan commented on pull request #1839: URL: https://github.com/apache/apisix-dashboard/pull/1839#issuecomment-833489007 @dmsolr Please update your PR's description :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests
netlify[bot] edited a comment on pull request #1838: URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508 Deploy preview for *apisix-dashboard* processing. Building with commit 8171e3bc9fe92b1448e42b7854347764108b39d3 https://app.netlify.com/sites/apisix-dashboard/deploys/6093f711b360b800077342b3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests
netlify[bot] edited a comment on pull request #1838: URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508 Deploy preview for *apisix-dashboard* ready! Built with commit 8171e3bc9fe92b1448e42b7854347764108b39d3 https://deploy-preview-1838--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests
netlify[bot] edited a comment on pull request #1838: URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508 Deploy preview for *apisix-dashboard* processing. Building with commit 8b3bbbdc968ac0734517c7495647e89a7aef5d1b https://app.netlify.com/sites/apisix-dashboard/deploys/6093f7cd37ecc4000852c4c7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests
netlify[bot] edited a comment on pull request #1838: URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508 Deploy preview for *apisix-dashboard* ready! Built with commit 8b3bbbdc968ac0734517c7495647e89a7aef5d1b https://deploy-preview-1838--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1838: chore: use data value directly in tests
iamayushdas closed pull request #1838: URL: https://github.com/apache/apisix-dashboard/pull/1838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #421: bug: The upstream associated with other routes cannot be deleted, and the delete event keeps retrying
tokers commented on issue #421: URL: https://github.com/apache/apisix-ingress-controller/issues/421#issuecomment-833569624 We may need to handle the given error from the caching operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
starsz commented on a change in pull request #1814:
URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r627474268
##
File path: api/internal/utils/pid.go
##
@@ -26,6 +26,9 @@ import (
// WritePID write pid to the given file path.
func WritePID(filepath string) error {
+ if _, err := os.Stat(filepath); err == nil {
+ return fmt.Errorf("instance of Manager API already running: a
pid file exists in %s", filepath)
Review comment:
Does this mean the manager can't start successfully if there exists a
PID file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
tokers commented on a change in pull request #1814:
URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r627478821
##
File path: api/internal/utils/pid.go
##
@@ -26,6 +26,9 @@ import (
// WritePID write pid to the given file path.
func WritePID(filepath string) error {
+ if _, err := os.Stat(filepath); err == nil {
+ return fmt.Errorf("instance of Manager API already running: a
pid file exists in %s", filepath)
Review comment:
We may add an option to start forcely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] fregie opened a new issue #1840: manager-api: Why putting the feature of daemon in core code?
fregie opened a new issue #1840: URL: https://github.com/apache/apisix-dashboard/issues/1840 When I reading the code of manager-api,it take me a lot of time understanding the moudle of daemon and cmd,but these are not the core features of manager-api.Why don't we keep the core code less and simple? Maybe it's a good idea taking this feature out of manager-api as a stand-alone tool to manage the manager-api service.And manager-api will only be a executable file that launching a http/https service when executing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on a change in pull request #1814:
URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r627484178
##
File path: api/internal/utils/pid.go
##
@@ -26,6 +26,9 @@ import (
// WritePID write pid to the given file path.
func WritePID(filepath string) error {
+ if _, err := os.Stat(filepath); err == nil {
+ return fmt.Errorf("instance of Manager API already running: a
pid file exists in %s", filepath)
Review comment:
Hii guys, as we are now supporting manager-api as an os service, the PID
file should not be overwritten unknowingly, because then `./manager-api stop`
won't work. we have to take help from the os service manager explicitly.
> We may add an option to start forcely.
Yes, we can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on a change in pull request #1814:
URL: https://github.com/apache/apisix-dashboard/pull/1814#discussion_r627484178
##
File path: api/internal/utils/pid.go
##
@@ -26,6 +26,9 @@ import (
// WritePID write pid to the given file path.
func WritePID(filepath string) error {
+ if _, err := os.Stat(filepath); err == nil {
+ return fmt.Errorf("instance of Manager API already running: a
pid file exists in %s", filepath)
Review comment:
Hii guys, as we are now supporting manager-api as an os service, the PID
file should not be overwritten unknowingly, because then `./manager-api stop`
won't work. we have to take help from the os service manager explicitly.
> We may add an option to start forcely.
Yes, we can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
netlify[bot] commented on pull request #333: URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826 Deploy preview for *apisix* processing. Building with commit 59714ad0d7ad2e7a3e7c4812b5c77be9a60081e4 https://app.netlify.com/sites/apisix/deploys/60940e955b86fb0007d02926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy opened a new pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
KishaniKandasamy opened a new pull request #333: URL: https://github.com/apache/apisix-website/pull/333 Fixes: #325 Changes: update run-ingress-apisix-on-amazon-eks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #333: docs: fix broken links in Run Ingress on Amazon EKS blog
netlify[bot] edited a comment on pull request #333: URL: https://github.com/apache/apisix-website/pull/333#issuecomment-833626826 Deploy preview for *apisix* ready! Built with commit 59714ad0d7ad2e7a3e7c4812b5c77be9a60081e4 https://deploy-preview-333--apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu opened a new issue #170: request help: image 2.2-alpine got falsely overwriten to `release/2.5`
Yiyiyimu opened a new issue #170: URL: https://github.com/apache/apisix-docker/issues/170 Hi all Thanks you for the quick response. I just want to point out that I'm not using APISIX 2.5. I'm using the docker image for APISIX /apache/apisix:2.2-alpine with the apache/apisix-dashboard:2.3 dashboard. One thing that I've noticed is that the apache/apisix:2.2-alpine has been updated 10 days ago, so my question is has this image perhaps been erroneous updated ? I've tracked down the intermittent nature of the issue: Docker images that are working are apache/apisix:2.2-alpine (digest 186f0052e1191) Docker images that are not working are apache/apisix:2.2-alpine (digest 22a167dfcf31e) _Originally posted by @rdouman in https://github.com/apache/apisix/issues/4048#issuecomment-820361055_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on issue #170: request help: image 2.2-alpine got falsely overwriten to `release/2.5`
Yiyiyimu commented on issue #170: URL: https://github.com/apache/apisix-docker/issues/170#issuecomment-833664466 Checked and indeed it contains code from apisix release/2.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu edited a comment on issue #170: request help: image 2.2-alpine got falsely overwriten to `release/2.5`
Yiyiyimu edited a comment on issue #170: URL: https://github.com/apache/apisix-docker/issues/170#issuecomment-833664466 Checked and indeed it contains code from apisix release/2.5, need to regenerate and upload the correct version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1841: chore: refactored create_and_delete_consumer.spec.js
netlify[bot] commented on pull request #1841: URL: https://github.com/apache/apisix-dashboard/pull/1841#issuecomment-833697431 Deploy preview for *apisix-dashboard* processing. Building with commit 5a1b3441e837e6c00d777d46292e5feda01535ed https://app.netlify.com/sites/apisix-dashboard/deploys/609423c13700df00072cc8ea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1841: chore: refactored create_and_delete_consumer.spec.js
iamayushdas opened a new pull request #1841: URL: https://github.com/apache/apisix-dashboard/pull/1841 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. **Related issues** fix/resolve #1774 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1841: chore: refactored create_and_delete_consumer.spec.js
netlify[bot] edited a comment on pull request #1841: URL: https://github.com/apache/apisix-dashboard/pull/1841#issuecomment-833697431 Deploy preview for *apisix-dashboard* ready! Built with commit 5a1b3441e837e6c00d777d46292e5feda01535ed https://deploy-preview-1841--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1842: Test create consumer with proxy mirror
netlify[bot] commented on pull request #1842: URL: https://github.com/apache/apisix-dashboard/pull/1842#issuecomment-833704492 Deploy preview for *apisix-dashboard* processing. Building with commit da65b18852e4939da2ea884cf3c2dfacfb1379c9 https://app.netlify.com/sites/apisix-dashboard/deploys/6094265cb1c18200085b2bf2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1842: Test create consumer with proxy mirror
iamayushdas opened a new pull request #1842: URL: https://github.com/apache/apisix-dashboard/pull/1842 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. **Related issues** fix/resolve #0001 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1842: Test create consumer with proxy mirror
iamayushdas closed pull request #1842: URL: https://github.com/apache/apisix-dashboard/pull/1842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1841: chore: refactored create_and_delete_consumer.spec.js
iamayushdas closed pull request #1841: URL: https://github.com/apache/apisix-dashboard/pull/1841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1842: Test create consumer with proxy mirror
netlify[bot] edited a comment on pull request #1842: URL: https://github.com/apache/apisix-dashboard/pull/1842#issuecomment-833704492 Deploy preview for *apisix-dashboard* ready! Built with commit da65b18852e4939da2ea884cf3c2dfacfb1379c9 https://deploy-preview-1842--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu opened a new pull request #4190: docs: fix argument name for prometheus
Yiyiyimu opened a new pull request #4190: URL: https://github.com/apache/apisix/pull/4190 Signed-off-by: yiyiyimu ### What this PR does / why we need it: fix #4127 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3624: feat: add pre-commit framework
Yiyiyimu commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-833739486 For real? Force push again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #4038: [DO-NOT-MERGE] test if luarocks back to normal with cron
Yiyiyimu commented on pull request #4038: URL: https://github.com/apache/apisix/pull/4038#issuecomment-833740728 @spacewander It seems luarocks back to normal, do we need to remove all those retry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1843: chore: Refactored Test create consumer with limit count
iamayushdas opened a new pull request #1843: URL: https://github.com/apache/apisix-dashboard/pull/1843 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. **Related issues** fix/resolve # **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1843: chore: Refactored Test create consumer with limit count
netlify[bot] commented on pull request #1843: URL: https://github.com/apache/apisix-dashboard/pull/1843#issuecomment-833772303 Deploy preview for *apisix-dashboard* processing. Building with commit bd0b29b94beb7337fa1f1490c658e30b468a5f15 https://app.netlify.com/sites/apisix-dashboard/deploys/609439d7745a960008bb6f43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1843: chore: Refactored Test create consumer with limit count
iamayushdas closed pull request #1843: URL: https://github.com/apache/apisix-dashboard/pull/1843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1843: chore: Refactored Test create consumer with limit count
netlify[bot] edited a comment on pull request #1843: URL: https://github.com/apache/apisix-dashboard/pull/1843#issuecomment-833772303 Deploy preview for *apisix-dashboard* ready! Built with commit bd0b29b94beb7337fa1f1490c658e30b468a5f15 https://deploy-preview-1843--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1844: chore: refactored test create-and-delete-consumer
iamayushdas opened a new pull request #1844: URL: https://github.com/apache/apisix-dashboard/pull/1844 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. **Related issues** fix/resolve #0001 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1844: chore: refactored test create-and-delete-consumer
netlify[bot] commented on pull request #1844: URL: https://github.com/apache/apisix-dashboard/pull/1844#issuecomment-833784656 Deploy preview for *apisix-dashboard* processing. Building with commit 32a07fe6fb78753980e5fa9452aaa338cdd268fd https://app.netlify.com/sites/apisix-dashboard/deploys/60943d388e30870008808ee0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1845: chore: refactored test create-consumer-with-api-breaker
iamayushdas opened a new pull request #1845: URL: https://github.com/apache/apisix-dashboard/pull/1845 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. **Related issues** fix/resolve #0001 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1845: chore: refactored test create-consumer-with-api-breaker
netlify[bot] commented on pull request #1845: URL: https://github.com/apache/apisix-dashboard/pull/1845#issuecomment-833787493 Deploy preview for *apisix-dashboard* processing. Building with commit 13f8b6323074e2461af5b6a384a03f1427006616 https://app.netlify.com/sites/apisix-dashboard/deploys/60943e3fc107da000878b2c7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1844: chore: refactored test create-and-delete-consumer
netlify[bot] edited a comment on pull request #1844: URL: https://github.com/apache/apisix-dashboard/pull/1844#issuecomment-833784656 Deploy preview for *apisix-dashboard* ready! Built with commit 32a07fe6fb78753980e5fa9452aaa338cdd268fd https://deploy-preview-1844--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1845: chore: refactored test create-consumer-with-api-breaker
netlify[bot] edited a comment on pull request #1845: URL: https://github.com/apache/apisix-dashboard/pull/1845#issuecomment-833787493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1846: chore: refactored test create-consumer-with-limit-count
iamayushdas opened a new pull request #1846: URL: https://github.com/apache/apisix-dashboard/pull/1846 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. **Related issues** fix/resolve #1774 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1845: chore: refactored test create-consumer-with-api-breaker
netlify[bot] edited a comment on pull request #1845: URL: https://github.com/apache/apisix-dashboard/pull/1845#issuecomment-833787493 Deploy preview for *apisix-dashboard* ready! Built with commit 2b8460fe700c492ee54ca887d4ca617ece3e6c11 https://deploy-preview-1845--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1846: chore: refactored test create-consumer-with-limit-count
netlify[bot] commented on pull request #1846: URL: https://github.com/apache/apisix-dashboard/pull/1846#issuecomment-833798048 Deploy preview for *apisix-dashboard* processing. Building with commit 30c262a99d5623de68615486858dcc52782060bb https://app.netlify.com/sites/apisix-dashboard/deploys/6094423e96fced00074edd73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1847: Test4
iamayushdas opened a new pull request #1847: URL: https://github.com/apache/apisix-dashboard/pull/1847 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. **Related issues** fix/resolve #0001 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
