[GitHub] [apisix-dashboard] starsz commented on issue #1840: manager-api: Why putting the feature of daemon in core code?
starsz commented on issue #1840: URL: https://github.com/apache/apisix-dashboard/issues/1840#issuecomment-837874290 > @starsz > I can have a try. > Assigne this to me? Cool.Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran merged pull request #1867: chore: refactored test create-route-with-proxy-rewrite-plugin.spec.js
liuxiran merged pull request #1867: URL: https://github.com/apache/apisix-dashboard/pull/1867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: refactored test create-route-with-proxy-rewrite-plugin.spec.js (#1867)
This is an automated email from the ASF dual-hosted git repository.
liuxiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 059b30b chore: refactored test
create-route-with-proxy-rewrite-plugin.spec.js (#1867)
059b30b is described below
commit 059b30b3c44b7fd8957678b425161a2c3aeda70b
Author: Ayush das
AuthorDate: Tue May 11 11:13:29 2021 +0530
chore: refactored test create-route-with-proxy-rewrite-plugin.spec.js
(#1867)
---
.../create-route-with-proxy-rewrite-plugin.spec.js | 114 -
1 file changed, 64 insertions(+), 50 deletions(-)
diff --git
a/web/cypress/integration/route/create-route-with-proxy-rewrite-plugin.spec.js
b/web/cypress/integration/route/create-route-with-proxy-rewrite-plugin.spec.js
index 5ce18fd..8c77fca 100644
---
a/web/cypress/integration/route/create-route-with-proxy-rewrite-plugin.spec.js
+++
b/web/cypress/integration/route/create-route-with-proxy-rewrite-plugin.spec.js
@@ -20,15 +20,14 @@ import componentLocaleUS from
'../../../src/locales/en-US/component';
import routeLocaleUS from '../../../src/pages/Route/locales/en-US';
context('create route with proxy-rewrite plugin', () => {
- const data = {
-rewriteUri: '/get',
-rewriteHeaderKey1: 'test1',
-rewriteHeaderKey2: 'test2',
-rewriteHeaderValue1: '1',
-rewriteHeaderValue2: '2',
- };
-
- const domSelector = {
+ const selector = {
+name: '#name',
+nodes_0_host: '#nodes_0_host',
+nodes_0_port: '#nodes_0_port',
+nodes_0_weight: '#nodes_0_weight',
+nameSelector: '[title=Name]',
+deleteAlert: '.ant-modal-body',
+notification: '.ant-notification-notice-message',
staticUri: '[data-cy=uri-static]',
staticHost: '[data-cy=host-static]',
keepHost: '[data-cy=host-keep]',
@@ -41,13 +40,24 @@ context('create route with proxy-rewrite plugin', () => {
rewriteHeaderValue1: '#proxyRewrite_kvHeaders_0_value',
rewriteHeaderKey2: '#proxyRewrite_kvHeaders_1_key',
rewriteHeaderValue2: '#proxyRewrite_kvHeaders_1_value',
- }
+ };
+
+ const data = {
+host2: '12.12.12.12',
+port: '80',
+weight: 1,
+routeName: 'test_route',
+submitSuccess: 'Submit Successfully',
+deleteRouteSuccess: 'Delete Route Successfully',
+rewriteUri: '/get',
+rewriteHeaderKey1: 'test1',
+rewriteHeaderKey2: 'test2',
+rewriteHeaderValue1: '1',
+rewriteHeaderValue2: '2',
+ };
beforeEach(() => {
cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
});
it('should create route with proxy-rewrite plugin', function () {
@@ -57,92 +67,96 @@ context('create route with proxy-rewrite plugin', () => {
// show create page
cy.contains(componentLocaleUS['component.global.create']).click();
cy.contains('Next').click().click();
-cy.get(this.domSelector.name).type(this.data.routeName);
+cy.get(selector.name).type(data.routeName);
// show requestOverride PanelSection
-
cy.contains(routeLocaleUS['page.route.panelSection.title.requestOverride']).should('be.visible');
+
cy.contains(routeLocaleUS['page.route.panelSection.title.requestOverride']).should(
+ 'be.visible',
+);
// should show newPath after the URIRewriteType static clicked
-cy.get(domSelector.staticUri).click();
+cy.get(selector.staticUri).click();
cy.contains(routeLocaleUS['page.route.form.itemLabel.newPath']).should('be.visible');
-cy.get(domSelector.newUri).should('be.visible').type(data.rewriteUri);
+cy.get(selector.newUri).should('be.visible').type(data.rewriteUri);
// should show regexp and template after URIRewriteType regexp clicked
cy.contains(routeLocaleUS['page.route.radio.regex']).click();
cy.contains(routeLocaleUS['page.route.form.itemLabel.regex']).should('be.visible');
-cy.get(domSelector.uriRewriteReg).should('be.visible');
+cy.get(selector.uriRewriteReg).should('be.visible');
cy.contains(routeLocaleUS['page.route.form.itemLabel.template']).should('be.visible');
-cy.get(domSelector.uriRewriteTemp).should('be.visible');
+cy.get(selector.uriRewriteTemp).should('be.visible');
-cy.get(domSelector.staticUri).click();
+cy.get(selector.staticUri).click();
// should show newhost after static host clicked
-cy.get(domSelector.staticHost).click();
+cy.get(selector.staticHost).click();
cy.contains(routeLocaleUS['page.route.form.itemLabel.newHost']).should('be.visible');
-cy.get(domSelector.newHost).should('be.visible');
-cy.get(domSelector.keepHost).click();
-cy.get(domSelector.newHost).should('not.exist');
+cy.get(selector.newHost).should('be.visible');
+cy.get(selector.keepHost).click();
+cy.get(selector.newHost).should('not.exist');
// new header key value input after createNewRewriteHeader button
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1876: chore: refactored test save-paginator-status.spec.js
liuxiran commented on a change in pull request #1876:
URL: https://github.com/apache/apisix-dashboard/pull/1876#discussion_r629858502
##
File path: web/cypress/integration/service/save-paginator-status.spec.js
##
@@ -42,57 +55,57 @@ context('Save Paginator Status', () => {
},
body: {
upstream: {
-nodes: {"39.97.63.215:80": 1},
-timeout: {connect: 6, read: 6, send: 6},
+nodes: { '39.97.63.215:80': 1 },
Review comment:
it would be better to define the whole body as a test data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #420: add examples about migrating from nginx ingress controller
gxthrj commented on issue #420: URL: https://github.com/apache/apisix-ingress-controller/issues/420#issuecomment-837841675 Sure，We should also add documents to describe 1. the configuration scope of our support for native k8s Ingress resource. 2. How to migrate from K8s Ingress resource to ApisixRoute resource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #430: ci: introduce skywalking-eyes
codecov-commenter edited a comment on pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-836674682 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#430](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (76afdee) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (dc43be8) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #430 +/- ## === Coverage 36.58% 36.58% === Files 43 43 Lines3799 3799 === Hits 1390 1390 Misses 2230 2230 Partials 179 179 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [dc43be8...76afdee](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
dmsolr commented on a change in pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629851392 ## File path: conf/kubeconfig ## @@ -1,3 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + apiVersion: v1 clusters: - cluster: Review comment: Removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
dmsolr commented on a change in pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629849461 ## File path: conf/kubeconfig ## @@ -1,3 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + apiVersion: v1 clusters: - cluster: Review comment: I am asking the file whether we can add a license header. If it is not in use, I think it should be removed in a new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
dmsolr commented on a change in pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629349330 ## File path: conf/kubeconfig ## @@ -1,3 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + apiVersion: v1 clusters: - cluster: Review comment: Please double check this file whether can we add a license header? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dickens7 commented on pull request #3648: [WIP] APISIX-2291 - AMQP Logger Initial Implementation
dickens7 commented on pull request #3648: URL: https://github.com/apache/apisix/pull/3648#issuecomment-837822987 I have implemented a version before but the performance is relatively poor, so I gave up using amqp in apisix and forwarded it to amqp proxy through http. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
iamayushdas commented on a change in pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#discussion_r629846359
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -17,117 +17,137 @@
/* eslint-disable no-undef */
context('Create and Delete Upstream', () => {
+
+ const selector = {
+"name": "#name",
+"nodes_0_host": "#nodes_0_host",
+"nodes_0_port": "#nodes_0_port",
+"nodes_0_weight": "#nodes_0_weight",
+"input": ":input",
+"notification": ".ant-notification-notice-message",
+"nameSelector": "[title=Name]",
+"upstreamType": ".ant-select-item-option-content",
+"drawer": ".ant-drawer-content",
+"codemirrorScroll": ".CodeMirror-scroll",
+"description": "#desc",
+ }
+
+ const data = {
+"upstreamName": "test_upstream",
+"description": "desc_by_autotest",
+"ip1": "127.0.0.1",
+"createUpstreamSuccess": "Create Upstream Successfully",
+"deleteUpstreamSuccess": "Delete Upstream Successfully",
+ }
+
beforeEach(() => {
cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
});
it('should create upstream with default type (roundrobin)', function () {
cy.visit('/');
cy.contains('Upstream').click();
cy.contains('Create').click();
-cy.get(this.domSelector.name).type(this.data.upstreamName);
-cy.get(this.domSelector.description).type(this.data.description);
+cy.get(selector.name).type(data.upstreamName);
+cy.get(selector.description).type(data.description);
-cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
-cy.get(this.domSelector.nodes_0_port).clear().type('7000');
-cy.get(this.domSelector.nodes_0_weight).clear().type(1);
+cy.get(selector.nodes_0_host).type(data.ip1);
+cy.get(selector.nodes_0_port).clear().type('7000');
Review comment:
okay, sure...I defined it here because it was not re-occuring,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629424618 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1", -"stylelint": "^13.0.0" +"stylelint": "^13.0.0", +"webpack": "^5.35.0" Review comment: ~~I find it is a [bug](https://github.com/umijs/umi/issues/6398),I will update dependency version to fix it.~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1879: chore: refactored test create_and_delete_upstream.spec.js
liuxiran commented on a change in pull request #1879:
URL: https://github.com/apache/apisix-dashboard/pull/1879#discussion_r629844775
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -17,117 +17,137 @@
/* eslint-disable no-undef */
context('Create and Delete Upstream', () => {
+
+ const selector = {
+"name": "#name",
+"nodes_0_host": "#nodes_0_host",
+"nodes_0_port": "#nodes_0_port",
+"nodes_0_weight": "#nodes_0_weight",
+"input": ":input",
+"notification": ".ant-notification-notice-message",
+"nameSelector": "[title=Name]",
+"upstreamType": ".ant-select-item-option-content",
+"drawer": ".ant-drawer-content",
+"codemirrorScroll": ".CodeMirror-scroll",
+"description": "#desc",
+ }
+
+ const data = {
+"upstreamName": "test_upstream",
+"description": "desc_by_autotest",
+"ip1": "127.0.0.1",
+"createUpstreamSuccess": "Create Upstream Successfully",
+"deleteUpstreamSuccess": "Delete Upstream Successfully",
+ }
+
beforeEach(() => {
cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
});
it('should create upstream with default type (roundrobin)', function () {
cy.visit('/');
cy.contains('Upstream').click();
cy.contains('Create').click();
-cy.get(this.domSelector.name).type(this.data.upstreamName);
-cy.get(this.domSelector.description).type(this.data.description);
+cy.get(selector.name).type(data.upstreamName);
+cy.get(selector.description).type(data.description);
-cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
-cy.get(this.domSelector.nodes_0_port).clear().type('7000');
-cy.get(this.domSelector.nodes_0_weight).clear().type(1);
+cy.get(selector.nodes_0_host).type(data.ip1);
+cy.get(selector.nodes_0_port).clear().type('7000');
Review comment:
it would be better to define test data for `7000` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] dickens7 opened a new pull request #4212: feat snowflake plugin
dickens7 opened a new pull request #4212: URL: https://github.com/apache/apisix/pull/4212 #4209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1881: chore: refactored test login.spec.js
liuxiran commented on a change in pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#discussion_r629843361
##
File path: web/cypress/integration/user/login.spec.js
##
@@ -17,39 +17,45 @@
/* eslint-disable no-undef */
context('Login Test', () => {
+ const selector = {
+errorExplain: '.ant-form-item-explain',
+usernameInput: '#control-ref_username',
+passwordInput: '#control-ref_password',
+notification: '.ant-notification-notice-message',
+ };
+
Review comment:
but other prs define `data` to store test data, it would be better to
keep the same way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629841937 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1", -"stylelint": "^13.0.0" +"stylelint": "^13.0.0", +"webpack": "^5.35.0" Review comment: @juzhiyuan I find this bug was not fully fixed in the latest release and i reported the [issue](https://github.com/umijs/umi/issues/6551).need to wait for the next release of umi.So it needs to be fixed later in a new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1881: chore: refactored test login.spec.js
iamayushdas commented on a change in pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#discussion_r629841040
##
File path: web/cypress/integration/user/login.spec.js
##
@@ -17,39 +17,45 @@
/* eslint-disable no-undef */
context('Login Test', () => {
+ const selector = {
+errorExplain: '.ant-form-item-explain',
+usernameInput: '#control-ref_username',
+passwordInput: '#control-ref_password',
+notification: '.ant-notification-notice-message',
+ };
+
Review comment:
no, not here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1881: chore: refactored test login.spec.js
liuxiran commented on a change in pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#discussion_r629840470
##
File path: web/cypress/integration/user/login.spec.js
##
@@ -17,39 +17,45 @@
/* eslint-disable no-undef */
context('Login Test', () => {
+ const selector = {
+errorExplain: '.ant-form-item-explain',
+usernameInput: '#control-ref_username',
+passwordInput: '#control-ref_password',
+notification: '.ant-notification-notice-message',
+ };
+
Review comment:
do we need to define `data`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4211: ci: move license & plugin style check to separate job
spacewander opened a new pull request #4211: URL: https://github.com/apache/apisix/pull/4211 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #336: feat: darkmode added to download-dropdown
iamayushdas commented on pull request #336: URL: https://github.com/apache/apisix-website/pull/336#issuecomment-837756916 @Yiyiyimu new line has been added, have a look now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Marco-Zheng commented on issue #423: bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效
Marco-Zheng commented on issue #423: URL: https://github.com/apache/apisix-ingress-controller/issues/423#issuecomment-837736303 > @Marco-Zheng Any suspicious error logs? How does ingress work? If ingress parsing route yaml and store the route in etcd? how can we know the route.yaml is efficient -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Marco-Zheng edited a comment on issue #423: bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效
Marco-Zheng edited a comment on issue #423: URL: https://github.com/apache/apisix-ingress-controller/issues/423#issuecomment-837728666 > @Marco-Zheng Any suspicious error logs? Here is apisix log  and here is apisix-ingress-controller log  no error was found -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Marco-Zheng edited a comment on issue #423: bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效
Marco-Zheng edited a comment on issue #423: URL: https://github.com/apache/apisix-ingress-controller/issues/423#issuecomment-837728666 > @Marco-Zheng Any suspicious error logs? Here is apisix log  and here is apisix-ingress-controller log  no error was found, but I found a strange thing per the first log , i send request to  but it seems to visit another place  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Marco-Zheng commented on issue #423: bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效
Marco-Zheng commented on issue #423: URL: https://github.com/apache/apisix-ingress-controller/issues/423#issuecomment-837728666 > @Marco-Zheng Any suspicious error logs? Here is apisix log  and here is apisix-ingress-controller log  no error was found, but I found a strange thing per the first log , i send request to  but it seems to visit another place  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dickens7 commented on issue #4209: New feature suggestion: request-id plugin supports "snowflake" algorithm
dickens7 commented on issue #4209: URL: https://github.com/apache/apisix/issues/4209#issuecomment-837724977 I am now doing it as a standalone plugin, so I will submit a version first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4209: New feature suggestion: request-id plugin supports "snowflake" algorithm
spacewander commented on issue #4209: URL: https://github.com/apache/apisix/issues/4209#issuecomment-837715861 @dickens7 We can add more options in the request-id to control the id generation way. PR is welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new issue #432: Pull Request template doesn't conform our demand
tokers opened a new issue #432: URL: https://github.com/apache/apisix-ingress-controller/issues/432 ### Issue description The current Pull Request template is not so good, we may change it to [the one](https://github.com/apache/apisix/blob/master/.github/PULL_REQUEST_TEMPLATE.md) in APISIX. ### Environment * your apisix-ingress-controller version (output of `apisix-ingress-controller version --long`); * your Kubernetes cluster version (output of `kubectl version`); * if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (`uname -a`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dickens7 commented on issue #4209: New feature suggestion: request-id plugin supports "snowflake" algorithm
dickens7 commented on issue #4209: URL: https://github.com/apache/apisix/issues/4209#issuecomment-837708741 I have my own request-id plugin implements a snowflake algorithm using https://github.com/stuartcarnie/lua-snowflake -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] daputaowang opened a new issue #4210: request help: Is there a more readable and detailed process for Tengine to replace OpenResty?
daputaowang opened a new issue #4210: URL: https://github.com/apache/apisix/issues/4210 ### Issue description In install-Dependents.md I only see ci/linux_tengine_runner.sh, but that's not enough to help me complete the tengine replacement of openresty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #431: chore: refactor the structures of kube clients, shared index informer factories
codecov-commenter commented on pull request #431: URL: https://github.com/apache/apisix-ingress-controller/pull/431#issuecomment-837705603 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#431](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5b9f043) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (dc43be8) will **increase** coverage by `0.02%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #431 +/- ## == + Coverage 36.58% 36.61% +0.02% == Files 43 43 Lines3799 3796 -3 == Hits 1390 1390 + Misses 2230 2227 -3 Partials 179 179 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Vwc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [dc43be8...5b9f043](https://codecov.io/gh/apache/apisix-ingress-controller/pull/431?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #423: bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效
tokers commented on issue #423: URL: https://github.com/apache/apisix-ingress-controller/issues/423#issuecomment-837704372 @Marco-Zheng Any suspicious error logs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #431: chore: refactor the structures of kube clients, shared index informer factories
tokers opened a new pull request #431: URL: https://github.com/apache/apisix-ingress-controller/pull/431 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] younglifestyle commented on issue #171: docker compoest start image, but etcd start failed
younglifestyle commented on issue #171: URL: https://github.com/apache/apisix-docker/issues/171#issuecomment-837662816 thanks，this method has no effect on the dockerfile of repo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] oldthreefeng commented on issue #1882: default connection timeout not equal with nginx?
oldthreefeng commented on issue #1882: URL: https://github.com/apache/apisix-dashboard/issues/1882#issuecomment-837656789 I found a send_timeout default set to 10s in apisix config-default.yaml ``` send_timeout: 10s # timeout for transmitting a response to the client.then the connection is closed ``` this broke the rules by Using nginx default send_timeout 60s ? xref: https://nginx.org/en/docs/http/ngx_http_core_module.html#send_timeout @starsz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] mrcaobin opened a new issue #1886: consumer/list page bug
mrcaobin opened a new issue #1886: URL: https://github.com/apache/apisix-dashboard/issues/1886 in consumer/list, click view button, on the pop up page ,cllick submit, it will add a new data record named 'undifined' 在消费者页面，点击查看页面，在右侧弹出框中，直接点击提交，不是进行更新，二是会增加一条新的记录。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1885: docs: manager-api as os service
juzhiyuan commented on pull request #1885: URL: https://github.com/apache/apisix-dashboard/pull/1885#issuecomment-837652167 It seems that this PR gets pending due to CI issues... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on issue #171: docker compoest start image, but etcd start failed
tokers commented on issue #171: URL: https://github.com/apache/apisix-docker/issues/171#issuecomment-837651235 @younglifestyle `777` is so permissive and It's fine in a development environment, while when you deploy components in the production environment, make sure don't assign such permission to avoid security problems. Now considering it was solved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers closed issue #171: docker compoest start image, but etcd start failed
tokers closed issue #171: URL: https://github.com/apache/apisix-docker/issues/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4164: feat: add 50x html for error page
tokers commented on a change in pull request #4164:
URL: https://github.com/apache/apisix/pull/4164#discussion_r629797144
##
File path: apisix/cli/ops.lua
##
@@ -605,6 +614,7 @@ local function start(env, ...)
local cmd_logs = "mkdir -p " .. env.apisix_home .. "/logs"
util.execute_cmd(cmd_logs)
+
Review comment:
Why adding an empty line here?
##
File path: apisix/init.lua
##
@@ -534,6 +533,10 @@ end
function _M.http_header_filter_phase()
+if not ngx.ctx or not ngx.ctx.api_ctx then
+ngx.ctx = ctxdump.apply_ngx_ctx(ngx_var.ctx_ref)
Review comment:
Stash `ngx.ctx` unconditionally but checking the existence of `ngx.ctx`
, this behavior leaks some keys for `ngx.ctx` tables (for those requests which
doesn't make internal redirect).
##
File path: t/error_page/error_page.t
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
Review comment:
Ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4164: feat: add 50x html for error page
spacewander commented on a change in pull request #4164: URL: https://github.com/apache/apisix/pull/4164#discussion_r629796005 ## File path: apisix/cli/ops.lua ## @@ -605,6 +611,9 @@ local function start(env, ...) local cmd_logs = "mkdir -p " .. env.apisix_home .. "/logs" util.execute_cmd(cmd_logs) +local cmd_html = "mkdir -p " .. env.apisix_home .. "/html" Review comment: Need to add it to gitignore: https://github.com/apache/apisix/blob/504cd1b0966880101b3e2582cfb1cf65f23a7863/.gitignore#L48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1813: feat: refactor Plugin Orchestration
juzhiyuan commented on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-837635873 CI passes twice, cc @liuxiran @imjoey @LiteSun @bzp2010 to review, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown
netlify[bot] edited a comment on pull request #336: URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687 Deploy preview for *apisix* ready! Built with commit 3ae527cf5d7d2158c8ece999bdff7056f1bc9efd https://deploy-preview-336--apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown
netlify[bot] edited a comment on pull request #336: URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687 Deploy preview for *apisix* processing. Building with commit 3ae527cf5d7d2158c8ece999bdff7056f1bc9efd https://app.netlify.com/sites/apisix/deploys/6099e202e79c5828ddb2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #430: ci: introduce skywalking-eyes
tokers commented on a change in pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629791269 ## File path: .licenserc.yaml ## @@ -0,0 +1,41 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +header: + license: +spdx-id: Apache-2.0 +copyright-owner: Apache Software Foundation + + paths-ignore: +- 'dist' +- 'licenses' +- '**/*.md' +- '**/testdata/**' +- '**/go.mod' +- '**/go.sum' +- 'LICENSE' +- 'NOTICE' +- '**/assets/header-templates/**' +- '**/assets/lcs-templates/**' +- '**/assets/languages.yaml' +- '**/assets/assets.gen.go' +- '**/*.json' +- '.github/ISSUE_TEMPLATE' +- '.github/PULL_REQUEST_TEMPLATE' +- 'pkg/kube/apisix/client/**' +- '**/zz_generated.deepcopy.go' + + comment: on-failure Review comment: Please check the editor config, the EOL symbol is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #336: feat: darkmode added to download-dropdown
juzhiyuan commented on a change in pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#discussion_r629791259
##
File path: website/src/css/customTheme.css
##
@@ -644,4 +656,4 @@ a:hover {
.help-page .card p {
color: var(--color-help-subtitle);
-}
+}
Review comment:
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #430: ci: introduce skywalking-eyes
tokers commented on a change in pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629791032 ## File path: conf/kubeconfig ## @@ -1,3 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + apiVersion: v1 clusters: - cluster: Review comment: Actually, this file is not in use, and I'd like to propose that we can remove this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #4209: New feature suggestion: request-id plugin supports "snowflake" algorithm
tzssangglass commented on issue #4209: URL: https://github.com/apache/apisix/issues/4209#issuecomment-837619686 This is a feature to be implemented, and as far as I know there is no suitable implementation of the snowflake algorithm in the lua language, see also this comment: https://github.com/apache/apisix/blob/ac21146c356cc9f9702b79b55dc42bbb3dec6877/apisix/core/etcd.lua#L296-L299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
juzhiyuan commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-837618503 I have to say it's unstable, please create an issue to track this :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1883: fix: generate an uid when post a route without id
starsz commented on a change in pull request #1883:
URL: https://github.com/apache/apisix-dashboard/pull/1883#discussion_r629781967
##
File path: api/test/e2enew/route/route_with_plugin_orchestration_test.go
##
@@ -23,6 +23,7 @@ import (
"github.com/onsi/ginkgo"
"github.com/onsi/ginkgo/extensions/table"
"github.com/onsi/gomega"
+ "github.com/tidwall/gjson"
Review comment:
The request body was contained in dag-conf.json.Also include the
`script` field.
You can see this file line 32.
```
bytes, err := ioutil.ReadFile("../../testdata/dag-conf.json")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] fregie edited a comment on issue #1840: manager-api: Why putting the feature of daemon in core code?
fregie edited a comment on issue #1840: URL: https://github.com/apache/apisix-dashboard/issues/1840#issuecomment-837541844 @starsz I can have a try. Assigne this to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1813: feat: refactor Plugin Orchestration
juzhiyuan commented on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-837585680 Hi, I just fixed the `dag-to-lua` issue in CI, and retriggered the Test to make sure it's stable as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4191: fix: enable etcd health-check
spacewander commented on a change in pull request #4191:
URL: https://github.com/apache/apisix/pull/4191#discussion_r629778272
##
File path: apisix/core/config_etcd.lua
##
@@ -545,6 +558,33 @@ local function _automatic_fetch(premature, self)
local ok, err = sync_data(self)
if err then
+if string.find(err, "connection refused")
+or string.find(err, "Service Unavailable") then
+local etcd_cli, err = get_etcd()
+if not etcd_cli then
+error("all etcd endpoints are unhealthy: " .. err)
+end
+self.etcd_cli = etcd_cli
+log.warn("changed to new etcd endpoint")
+end
+if string.find(err, "has no healthy etcd endpoint available")
then
Review comment:
elseif
##
File path: apisix/core/config_etcd.lua
##
@@ -545,6 +558,33 @@ local function _automatic_fetch(premature, self)
local ok, err = sync_data(self)
if err then
+if string.find(err, "connection refused")
+or string.find(err, "Service Unavailable") then
+local etcd_cli, err = get_etcd()
+if not etcd_cli then
+error("all etcd endpoints are unhealthy: " .. err)
+end
+self.etcd_cli = etcd_cli
+log.warn("changed to new etcd endpoint")
+end
+if string.find(err, "has no healthy etcd endpoint available")
then
+local reconnected = false
+while err and not reconnected do
+local backoff_duration, backoff_factor, backoff_step =
1, 2, 10
+for _ = 0, backoff_step, 1 do
+ngx_sleep(backoff_duration)
+_, err = sync_data(self)
+if not string.find(err, "has no healthy etcd
endpoint available") then
+log.warn("reconnected to etcd")
+reconnected = true
+break
+end
+backoff_duration = backoff_duration *
backoff_factor
+log.error("no healthy etcd endpoint available,
next retry after "
+ .. backoff_duration .. "s")
+end
+end
+end
if err ~= "timeout" and err ~= "Key not found"
Review comment:
elseif
##
File path: apisix/core/config_etcd.lua
##
@@ -545,6 +558,33 @@ local function _automatic_fetch(premature, self)
local ok, err = sync_data(self)
if err then
+if string.find(err, "connection refused")
+or string.find(err, "Service Unavailable") then
+local etcd_cli, err = get_etcd()
Review comment:
The `get_etcd` only gets the singleton of etcd client, it doesn't
recreate it.
##
File path: apisix/core/config_etcd.lua
##
@@ -529,6 +531,17 @@ local function _automatic_fetch(premature, self)
return
end
+if not health_check.conf then
Review comment:
Where will `health_check.conf` be assigned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4164: feat: add 50x html for error page
spacewander commented on a change in pull request #4164: URL: https://github.com/apache/apisix/pull/4164#discussion_r629776898 ## File path: html/50x.html ## @@ -0,0 +1,38 @@
[GitHub] [apisix-dashboard] fregie commented on issue #1884: feat: provide command line interface of Manager API
fregie commented on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837578486 > I think it's a great idea to provide a data entity library, but implementing it requires some modifications to the existing code. I think it worth to do,Let's listen to other's opinions. Ping @starsz @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] fregie edited a comment on issue #1884: feat: provide command line interface of Manager API
fregie edited a comment on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837578486 > I think it's a great idea to provide a data entity library, but implementing it requires some modifications to the existing code. I think it worth to do,Let's listen to other's opinions. Ping @starsz @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4207: request help: implement consul support
spacewander commented on issue #4207: URL: https://github.com/apache/apisix/issues/4207#issuecomment-837576358 You can talk a look at https://github.com/apache/apisix/blob/master/apisix/discovery/consul_kv.lua -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4208: feat: support passing different host headers in multiple nodes
spacewander commented on pull request #4208: URL: https://github.com/apache/apisix/pull/4208#issuecomment-837575568 @membphis We can do it in a separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on issue #1884: feat: provide command line interface of Manager API
bzp2010 edited a comment on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837572775 @fregie I agree with you, but it seems that `apisix-control-plane` hasn't made any new progress for some time, which is why I didn't mention him in the proposal. And I didn't see any plans for its next development. I think it's a great idea to provide a data entity library, but implementing it requires some modifications to the existing code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #1884: feat: provide command line interface of Manager API
bzp2010 commented on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837572775 @fregie I agree with you, but it seems that `apisix-control-plane` hasn't made any new progress for some time, which is why I didn't mention him in the proposal. I think it's a great idea to provide a data entity library, but implementing it requires some modifications to the existing code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 removed a comment on issue #1884: feat: provide command line interface of Manager API
bzp2010 removed a comment on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837570137 @fregie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #1884: feat: provide command line interface of Manager API
bzp2010 commented on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837570137 @fregie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] fregie commented on issue #1884: feat: provide command line interface of Manager API
fregie commented on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837568998 I don't think it's a good idea put the cli feature in manager-api.Maybe it's better put it in [apisix-control-plane](https://github.com/apache/apisix-control-plane). We can use yaml or cli declarative definition method to define complete rules. On the other hand,I think we can abstract a library of managing data in etcd for the other project to use.Like _apisix-control-plane_ and _apisix-ingress-controller_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on issue #1884: feat: provide command line interface of Manager API
bzp2010 edited a comment on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837552492 @starsz Yes, we don't have to put this new CLI module into Manager API. But the way of putting Manager API mentioned in the proposal can help us develop reusable code quickly. Currently in Manager API, part of the code about the storage entity is placed in the `internal` package, which makes the code unable to be imported and used. These code needs to be modified. In my opinion, thanks to the good scalability of the `cobra` library, the code can be placed in Manager API according to the current way, and it can also be easily split in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #1884: feat: provide command line interface of Manager API
bzp2010 commented on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837552492 @starsz Yes, we don't have to put this new CLI module into Manager API. But the way of putting Manager API mentioned in the proposal can help us develop reusable code quickly. Currently in Manager API, part of the code about the storage entity is placed in the `internal` package, which makes the code unable to be imported and used. These code needs to be modified. In my opinion, thanks to the good scalability of the `cobra` library, the code can be placed in Manager API according to the current scheme, and it can also be easily split in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 5d6f3f7c8f2d59b303c7a8cd86dcfaa4ce226960 https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e27bcd6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/177059644e3eb5d8ddd42da6a2b48413c70eb044?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1770596) will **decrease** coverage by `18.80%`. > The diff coverage is `n/a`. > :exclamation: Current head e27bcd6 differs from pull request most recent head 5d6f3f7. Consider uploading reports for the commit 5d6f3f7 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.22% 52.42% -18.81% === Files 173 39 -134 Lines6221 2745 -3476 Branches 7120 -712 === - Hits 4431 1439 -2992 + Misses 1534 1112 -422 + Partials 256 194 -62 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.42% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] fregie commented on issue #1840: manager-api: Why putting the feature of daemon in core code?
fregie commented on issue #1840: URL: https://github.com/apache/apisix-dashboard/issues/1840#issuecomment-837541844 I can have a try. Assigne this to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 5d6f3f7c8f2d59b303c7a8cd86dcfaa4ce226960 https://app.netlify.com/sites/apisix-dashboard/deploys/6099cdb719c961000746c629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu edited a comment on pull request #4191: fix: enable etcd health-check
Yiyiyimu edited a comment on pull request #4191: URL: https://github.com/apache/apisix/pull/4191#issuecomment-837350315 Things get a bit weird right now Before I work on this fix, I test that if killing one node out of an etcd cluster, apisix would fail, as those related issues talk about. However, right now when I test this scenario again on the master branch, apisix would **not** be affected by the closed etcd node and runs normally. I checked the recent commits and it seems no changes have applied to this problem. Could someone help me to reproduce the program again --- Test running apisix and etcd in Kubernetes, delete one etcd node, and apisix runs normally with master branch. So don't know if anything went wrong yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #4191: fix: enable etcd health-check
Yiyiyimu commented on pull request #4191: URL: https://github.com/apache/apisix/pull/4191#issuecomment-837379107 Waiting for lua-resty-etcd new release: https://github.com/api7/lua-resty-etcd/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #4191: fix: enable etcd health-check
Yiyiyimu commented on pull request #4191: URL: https://github.com/apache/apisix/pull/4191#issuecomment-837350315 Things get a bit weird right now Before I work on this fix, I test that if killing one node out of an etcd cluster, apisix would fail, as those related issues talk about. However, right now when I test this scenario again on the master branch, apisix would **not** be affected by the closed etcd node and runs normally. I checked the recent commits and it seems no changes have applied to this problem. Could someone help me to reproduce the program again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on issue #4199: request help:
Yiyiyimu commented on issue #4199: URL: https://github.com/apache/apisix/issues/4199#issuecomment-837111831 > What do you mean by master branch and how can I access it ... could you please give me more details? you can try to get apisix with `git clone https://github.com/apache/apisix.git` or `docker pull apache/apisix:dev` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #336: feat: darkmode added to download-dropdown
Yiyiyimu commented on a change in pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#discussion_r629577009
##
File path: website/src/css/customTheme.css
##
@@ -644,4 +656,4 @@ a:hover {
.help-page .card p {
color: var(--color-help-subtitle);
-}
+}
Review comment:
missing a newline here. Maybe you could make your IDE do the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1885: docs: manager-api as os service
netlify[bot] edited a comment on pull request #1885: URL: https://github.com/apache/apisix-dashboard/pull/1885#issuecomment-836996883 Deploy preview for *apisix-dashboard* ready! Built with commit 34d0ecbad938a1c42f8bd51e664db3636636f6ff https://deploy-preview-1885--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1885: docs: manager-api as os service
netlify[bot] commented on pull request #1885: URL: https://github.com/apache/apisix-dashboard/pull/1885#issuecomment-836996883 Deploy preview for *apisix-dashboard* processing. Building with commit 34d0ecbad938a1c42f8bd51e664db3636636f6ff https://app.netlify.com/sites/apisix-dashboard/deploys/60996b2e5eb9ab0008ecf643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1885: docs: manager-api as os service
bisakhmondal opened a new pull request #1885: URL: https://github.com/apache/apisix-dashboard/pull/1885 **Why submit this pull request?** - [x] docs **What changes will this PR take into?** Users guide. **Related issues** closes #842 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [x] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1825: how to create an viewer account for apisix-dashboard?
starsz commented on issue #1825: URL: https://github.com/apache/apisix-dashboard/issues/1825#issuecomment-836936940 > I can give it a try. @nic-chen how are we planning to support this as of now, through YAML? > Seems like we had a similar conversation a month back :) Use YAML is fine. And the front end should also do some work. You can refer to the config of apisix. https://github.com/apache/apisix/blob/504cd1b0966880101b3e2582cfb1cf65f23a7863/conf/config-default.yaml#L82-L83 You can send your proposal to the email list. Then we can discuss it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1840: manager-api: Why putting the feature of daemon in core code?
starsz commented on issue #1840: URL: https://github.com/apache/apisix-dashboard/issues/1840#issuecomment-836925677 > I have an immature draft,maybe we can just split manager-api into two part If so, I think we can use `supervisor` instead. IMO, I think the feature of the daemon is very good. The reason is talked about before. Thanks for the @bisakhmondal. . If you had met any problem while reding the code. You can create an issue to discuss it or can you help to improve the code readability. That would be more interesting if we can keep this feature and improve the code readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1882: default connection timeout not equal with nginx?
starsz commented on issue #1882: URL: https://github.com/apache/apisix-dashboard/issues/1882#issuecomment-836906896 > what the value the apisix upstream use It will inherit the timeout value of the global nginx.conf configuration (like proxy_connect_timeout. You can referer: https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.md#set_timeouts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hozaifaaoud commented on issue #4199: request help:
hozaifaaoud commented on issue #4199: URL: https://github.com/apache/apisix/issues/4199#issuecomment-836902179 What do you mean by master branch and how can I access it ... could you please give me more details? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hozaifaaoud edited a comment on issue #4199: request help:
hozaifaaoud edited a comment on issue #4199: URL: https://github.com/apache/apisix/issues/4199#issuecomment-834934490 What do you mean by master branch and how can I access it ... could you please give me more details? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz edited a comment on issue #1884: feat: provide command line interface of Manager API
starsz edited a comment on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-836894338 The idea sounds pretty good. But is it needed to do on manager-api? Maybe you can create another project like `apisix-cli`.That would be better. Just in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1884: feat: provide command line interface of Manager API
starsz commented on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-836894338 The idea sounds pretty good. But is it needed to do on manager-api? Maybe you can create another project like `apisix-cli`.That would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit f3c9985a36d87b5476f14421a27747948edd5fa4 https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f3c9985) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/177059644e3eb5d8ddd42da6a2b48413c70eb044?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1770596) will **decrease** coverage by `5.22%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1813 +/- ## == - Coverage 71.22% 66.00% -5.23% == Files 173 48 -125 Lines6221 3271-2950 Branches 7120 -712 == - Hits 4431 2159-2272 + Misses 1534 836 -698 - Partials 256 276 +20 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `45.27% <ø> (-0.49%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.45% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `56.92% <0.00%> (-26.16%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `40.00% <0.00%> (-10.00%)` | :arrow_down: | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `38.62% <0.00%> (-9.66%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `90.47% <0.00%> (-9.53%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f3c9985) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/177059644e3eb5d8ddd42da6a2b48413c70eb044?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1770596) will **decrease** coverage by `18.76%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.22% 52.45% -18.77% === Files 173 39 -134 Lines6221 2745 -3476 Branches 7120 -712 === - Hits 4431 1440 -2991 + Misses 1534 -423 + Partials 256 194 -62 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.45% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit f3c9985a36d87b5476f14421a27747948edd5fa4 https://app.netlify.com/sites/apisix-dashboard/deploys/609957f10d8e8400083ec63f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit d6c261954b9ebbd2e8b4cbd6888e70afa8dbcaff https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 27048b0b714b71281fb106cad0eda60e8101ec11 https://app.netlify.com/sites/apisix-dashboard/deploys/60995042ea0818efc90d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629424618 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1", -"stylelint": "^13.0.0" +"stylelint": "^13.0.0", +"webpack": "^5.35.0" Review comment: I find it is a [bug](https://github.com/umijs/umi/issues/6398),I will update dependency version to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 1cf880b187ebb96ab3061e71c011f52deab72ad1 https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1835: docs: add the visit the dashboard
netlify[bot] edited a comment on pull request #1835: URL: https://github.com/apache/apisix-dashboard/pull/1835#issuecomment-829794254 Deploy preview for *apisix-dashboard* ready! Built with commit 04cd17f21ced27f8ab5de6ba7ed8f976cedeccf3 https://deploy-preview-1835--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629394731 ## File path: web/package.json ## @@ -68,6 +67,7 @@ "js-yaml": "^4.0.0", "lodash": "^4.17.11", "moment": "^2.25.3", +"monaco-editor-webpack-plugin": "^3.0.1", Review comment: If removed then monaco editor will not show highlighting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629393048 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1", -"stylelint": "^13.0.0" +"stylelint": "^13.0.0", +"webpack": "^5.35.0" Review comment: But if I remove the webpack dependency then it will throw an error in `yarn install`.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1835: docs: add the visit the dashboard
netlify[bot] edited a comment on pull request #1835: URL: https://github.com/apache/apisix-dashboard/pull/1835#issuecomment-829794254 Deploy preview for *apisix-dashboard* processing. Building with commit 04cd17f21ced27f8ab5de6ba7ed8f976cedeccf3 https://app.netlify.com/sites/apisix-dashboard/deploys/60993df35242bd0008ca0253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
juzhiyuan commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629385785 ## File path: web/package.json ## @@ -68,6 +67,7 @@ "js-yaml": "^4.0.0", "lodash": "^4.17.11", "moment": "^2.25.3", +"monaco-editor-webpack-plugin": "^3.0.1", Review comment: 樂 Why we need this plugin? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
juzhiyuan commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629386504 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1", -"stylelint": "^13.0.0" +"stylelint": "^13.0.0", +"webpack": "^5.35.0" Review comment: Ant Design Pro contains UmiJS, and it will handle Webpack configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d72e538) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/177059644e3eb5d8ddd42da6a2b48413c70eb044?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1770596) will **decrease** coverage by `18.80%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.22% 52.42% -18.81% === Files 173 39 -134 Lines6221 2745 -3476 Branches 7120 -712 === - Hits 4431 1439 -2992 + Misses 1534 1112 -422 + Partials 256 194 -62 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.42% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
