[GitHub] [apisix-dashboard] iamayushdas commented on issue #1774: improve Testcases
iamayushdas commented on issue #1774: URL: https://github.com/apache/apisix-dashboard/issues/1774#issuecomment-836270430 @LiteSun @nic-chen @liuxiran @imjoey can i have the review on these improved test cases Thank you for your time :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #336: feat: darkmode added to download-dropdown
Yiyiyimu commented on pull request #336: URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836275111  Currently the color change at hover is too small for user to make sure where is s/he -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj merged pull request #69: add README for charts/apisix-ingress-controller
gxthrj merged pull request #69: URL: https://github.com/apache/apisix-helm-chart/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: add README for charts/apisix-ingress-controller (#69)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 6228fb7 add README for charts/apisix-ingress-controller (#69) 6228fb7 is described below commit 6228fb7cdb010e85bb8f20c0d5ee285408f9a164 Author: Jintao Zhang AuthorDate: Mon May 10 15:09:54 2021 +0800 add README for charts/apisix-ingress-controller (#69) Signed-off-by: Jintao Zhang --- charts/apisix-ingress-controller/README.md | 59 ++ 1 file changed, 59 insertions(+) diff --git a/charts/apisix-ingress-controller/README.md b/charts/apisix-ingress-controller/README.md new file mode 100644 index 000..b379834 --- /dev/null +++ b/charts/apisix-ingress-controller/README.md @@ -0,0 +1,59 @@ +# Apache APISIX ingress controller + +[APISIX Ingress controller](https://github.com/apache/apisix-ingress-controller/) for Kubernetes using Apache APISIX as a high performance reverse proxy and load balancer. + +If you have installed multiple ingress controller, add the `kubernetes.io/ingress.class: apisix` annotation to your Ingress resources. + +This chart bootstraps an apisix-ingress-controller deployment on a [Kubernetes](http://kubernetes.io) cluster using the [Helm](https://helm.sh) package manager. + +## Prerequisites + +Apisix ingress controller requires Kubernetes version 1.14+. + +## Get Repo Info + +```console +helm repo add apisix https://charts.apiseven.com +helm repo update +``` + +## Install Chart + +**Important:** only helm3 is supported + +```console +helm install [RELEASE_NAME] apisix/apisix-ingress-controller +``` + +The command deploys apisix-ingress-controller on the Kubernetes cluster in the default configuration. + +_See [configuration](#configuration) below._ + +_See [helm install](https://helm.sh/docs/helm/helm_install/) for command documentation._ + +## Uninstall Chart + +```console +helm uninstall [RELEASE_NAME] +``` + +This removes all the Kubernetes components associated with the chart and deletes the release. + +_See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command documentation._ + +## Upgrading Chart + +```console +helm upgrade [RELEASE_NAME] [CHART] --install +``` + +_See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documentation._ + + +## Configuration + +See [Customizing the Chart Before Installing](https://helm.sh/docs/intro/using_helm/#customizing-the-chart-before-installing). To see all configurable options with detailed comments, visit the chart's [values.yaml](./values.yaml), or run these configuration commands: + +```console +helm show values apisix/apisix-ingress-controller +```
[GitHub] [apisix-dashboard] iamayushdas edited a comment on issue #1774: improve Testcases
iamayushdas edited a comment on issue #1774: URL: https://github.com/apache/apisix-dashboard/issues/1774#issuecomment-836270430 @LiteSun @nic-chen @liuxiran @imjoey @qian0817 can i have the review on these improved test cases Thank you for your time :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #336: feat: darkmode added to download-dropdown
iamayushdas commented on pull request #336: URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836276966 >  > > Currently the color change at hover is too small for user to make sure where is s/he OKAY ,thanks for reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* ready! Built with commit f0a8e4dca1b6fe911e04f85952c6ecb9fae21dd9 https://deploy-preview-1816--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] oldthreefeng opened a new issue #1882: default connection timeout not equal with nginx?
oldthreefeng opened a new issue #1882: URL: https://github.com/apache/apisix-dashboard/issues/1882 ## Issue description what is the default connection timeout in apisix? for i found it used 6s to default (User Guide Picture). nginx set the timeout to 60s . why this happened? ## Expected behavior ## How to Reproduce just install. ## Screenshots ## Environment * apisix version (cmd: `apisix version`): 2.5 * OS (cmd: `uname -a`): * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): 3.4.14 * apisix-dashboard version, if have: 2.6 * Browser version, if have: ## Additional context -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown
netlify[bot] edited a comment on pull request #336: URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687 Deploy preview for *apisix* processing. Building with commit 81cb7daf9ec27986a834a57139d463cc0535ba5a https://app.netlify.com/sites/apisix/deploys/6098e4a236ff770008e5957f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #336: feat: darkmode added to download-dropdown
iamayushdas commented on pull request #336: URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836313586 >  > > Currently the color change at hover is too small for user to make sure where is s/he is it fine now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] younglifestyle commented on issue #171: docker compoest start image, but etcd start failed
younglifestyle commented on issue #171: URL: https://github.com/apache/apisix-docker/issues/171#issuecomment-836314853 > @younglifestyle could the method provide by @anyeshe fix your problem I'll try now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown
netlify[bot] edited a comment on pull request #336: URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687 Deploy preview for *apisix* ready! Built with commit 81cb7daf9ec27986a834a57139d463cc0535ba5a https://deploy-preview-336--apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] younglifestyle commented on issue #171: docker compoest start image, but etcd start failed
younglifestyle commented on issue #171: URL: https://github.com/apache/apisix-docker/issues/171#issuecomment-836329780 > > @younglifestyle could the method provide by @anyeshe fix your problem > > I'll try now failed. Etcd can't see the log. the configuration is here  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4207: request help: implement consul support
spacewander commented on issue #4207: URL: https://github.com/apache/apisix/issues/4207#issuecomment-836336454 Maybe you can take a look at Consul's API: https://www.consul.io/api-docs/catalog#list-nodes-for-service -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4208: feat: support passing different host headers in multiple nodes
spacewander opened a new pull request #4208: URL: https://github.com/apache/apisix/pull/4208 Fix #2620 Fix #4197 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz opened a new pull request #1883: fix: generate a uid when post a route without id
starsz opened a new pull request #1883: URL: https://github.com/apache/apisix-dashboard/pull/1883 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** This PR is to fix this situation: when creating the route with the script, but without the id.The original logic will return the `key is required`. - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Fix the situation: When creating the route with the script, but without the id.The original logic will return the `key is required`. **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1883: fix: generate a uid when post a route without id
netlify[bot] commented on pull request #1883: URL: https://github.com/apache/apisix-dashboard/pull/1883#issuecomment-836343461 Deploy preview for *apisix-dashboard* processing. Building with commit 8e97cf3c3c8a0204c397664f8989c15baab938a0 https://app.netlify.com/sites/apisix-dashboard/deploys/6098eaed5d034800082b4b02 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1883: fix: generate a uid when post a route without id
netlify[bot] edited a comment on pull request #1883: URL: https://github.com/apache/apisix-dashboard/pull/1883#issuecomment-836343461 Deploy preview for *apisix-dashboard* ready! Built with commit 8e97cf3c3c8a0204c397664f8989c15baab938a0 https://deploy-preview-1883--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #72: Add ability to specify automountServiceAccountToken
tao12345666333 opened a new pull request #72: URL: https://github.com/apache/apisix-helm-chart/pull/72 improve Helm chart xref: https://github.com/apache/apisix-helm-chart/issues/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] water1st commented on issue #4207: request help: implement consul support
water1st commented on issue #4207: URL: https://github.com/apache/apisix/issues/4207#issuecomment-836361716 yes, i hope apisix consul support use this way, not just key value way, how can i implement that , maybe i need write some openrest script for implement,but i don't know how the openrest work and i dont konw how the script work, can you offer some help?like offer some other discovery implement exmple. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1883: fix: generate a uid when post a route without id
codecov-commenter commented on pull request #1883: URL: https://github.com/apache/apisix-dashboard/pull/1883#issuecomment-836375845 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1883](https://codecov.io/gh/apache/apisix-dashboard/pull/1883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8e97cf3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **decrease** coverage by `5.56%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1883 +/- ## == - Coverage 72.10% 66.54% -5.57% == Files 125 173 +48 Lines2947 6208+3261 Branches 711 712 +1 == + Hits 2125 4131+2006 - Misses822 1755 +933 - Partials0 322 +322 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `45.76% <0.00%> (?)` | | | backend-e2e-test-ginkgo | `48.40% <100.00%> (?)` | | | frontend-e2e-test | `72.47% <ø> (+0.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `67.75% <100.00%> (ø)` | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `85.29% <0.00%> (ø)` | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `55.86% <0.00%> (ø)` | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `61.03% <0.00%> (ø)` | | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (ø)` | | | [api/internal/utils/json\_patch.go](https://codecov.
[GitHub] [apisix-ingress-controller] tokers commented on issue #423: bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效
tokers commented on issue #423: URL: https://github.com/apache/apisix-ingress-controller/issues/423#issuecomment-836396812 > ``` > apiVersion: v1 > data: > config.yaml: | > # log options > log_level: "info" > log_output: "stderr" > http_listen: ":8080" > enable_profiling: true > kubernetes: > kubeconfig: "" > resync_interval: "60s" > app_namespaces: > - "*" > apisix: > base_url: "http://xx:9180/apisix/admin"; > admin_key: "edd1c9f034335f136f87ad84b625c8f1" > kind: ConfigMap > metadata: > annotations: > meta.helm.sh/release-name: apisix-ingress-controller > meta.helm.sh/release-namespace: ingress-apisix > creationTimestamp: "2021-05-08T08:09:34Z" > labels: > app.kubernetes.io/instance: apisix-ingress-controller > app.kubernetes.io/managed-by: Helm > app.kubernetes.io/name: apisix-ingress-controller > app.kubernetes.io/version: 0.4.0 > helm.sh/chart: apisix-ingress-controller-0.3.0 > name: apisix-ingress-controller-configmap > namespace: ingress-apisix > resourceVersion: "7545638850" > selfLink: /api/v1/namespaces/ingress-apisix/configmaps/apisix-ingress-controller-configmap > uid: 74524651-7a57-4d6d-a894-2f0b4715e11a > ``` ``` apiVersion: v1 data: config.yaml: | # log options log_level: "info" log_output: "stderr" http_listen: ":8080" enable_profiling: true kubernetes: kubeconfig: "" resync_interval: "60s" **ingressVersion: networking/v1beta1** app_namespaces: - "*" apisix: base_url: "http://xx:9180/apisix/admin"; admin_key: "edd1c9f034335f136f87ad84b625c8f1" kind: ConfigMap metadata: annotations: meta.helm.sh/release-name: apisix-ingress-controller meta.helm.sh/release-namespace: ingress-apisix creationTimestamp: "2021-05-08T08:09:34Z" labels: app.kubernetes.io/instance: apisix-ingress-controller app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: apisix-ingress-controller app.kubernetes.io/version: 0.4.0 helm.sh/chart: apisix-ingress-controller-0.3.0 name: apisix-ingress-controller-configmap namespace: ingress-apisix resourceVersion: "7545638850" selfLink: /api/v1/namespaces/ingress-apisix/configmaps/apisix-ingress-controller-configmap uid: 74524651-7a57-4d6d-a894-2f0b4715e11a ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers edited a comment on issue #423: bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效
tokers edited a comment on issue #423: URL: https://github.com/apache/apisix-ingress-controller/issues/423#issuecomment-836396812 > ``` > apiVersion: v1 > data: > config.yaml: | > # log options > log_level: "info" > log_output: "stderr" > http_listen: ":8080" > enable_profiling: true > kubernetes: > kubeconfig: "" > resync_interval: "60s" > app_namespaces: > - "*" > apisix: > base_url: "http://xx:9180/apisix/admin"; > admin_key: "edd1c9f034335f136f87ad84b625c8f1" > kind: ConfigMap > metadata: > annotations: > meta.helm.sh/release-name: apisix-ingress-controller > meta.helm.sh/release-namespace: ingress-apisix > creationTimestamp: "2021-05-08T08:09:34Z" > labels: > app.kubernetes.io/instance: apisix-ingress-controller > app.kubernetes.io/managed-by: Helm > app.kubernetes.io/name: apisix-ingress-controller > app.kubernetes.io/version: 0.4.0 > helm.sh/chart: apisix-ingress-controller-0.3.0 > name: apisix-ingress-controller-configmap > namespace: ingress-apisix > resourceVersion: "7545638850" > selfLink: /api/v1/namespaces/ingress-apisix/configmaps/apisix-ingress-controller-configmap > uid: 74524651-7a57-4d6d-a894-2f0b4715e11a > ``` I add the change for the watching version of ingress. ``` apiVersion: v1 data: config.yaml: | # log options log_level: "info" log_output: "stderr" http_listen: ":8080" enable_profiling: true kubernetes: kubeconfig: "" resync_interval: "60s" ingressVersion: networking/v1beta1 app_namespaces: - "*" apisix: base_url: "http://xx:9180/apisix/admin"; admin_key: "edd1c9f034335f136f87ad84b625c8f1" kind: ConfigMap metadata: annotations: meta.helm.sh/release-name: apisix-ingress-controller meta.helm.sh/release-namespace: ingress-apisix creationTimestamp: "2021-05-08T08:09:34Z" labels: app.kubernetes.io/instance: apisix-ingress-controller app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: apisix-ingress-controller app.kubernetes.io/version: 0.4.0 helm.sh/chart: apisix-ingress-controller-0.3.0 name: apisix-ingress-controller-configmap namespace: ingress-apisix resourceVersion: "7545638850" selfLink: /api/v1/namespaces/ingress-apisix/configmaps/apisix-ingress-controller-configmap uid: 74524651-7a57-4d6d-a894-2f0b4715e11a ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #70: proposal: restructure the apisix-helm-chart repo
tokers commented on issue #70: URL: https://github.com/apache/apisix-helm-chart/issues/70#issuecomment-836402321 @tao12345666333 Assigned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #4164: feat: add 50x html for error page
starsz commented on a change in pull request #4164:
URL: https://github.com/apache/apisix/pull/4164#discussion_r629188844
##
File path: apisix/cli/ngx_tpl.lua
##
@@ -617,6 +642,17 @@ http {
proxy_pass $upstream_mirror_host$request_uri;
}
{% end %}
+
+location = /50x.html {
Review comment:
Oh, I found a new way. We can use "try_files" to get the html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1882: default connection timeout not equal with nginx?
juzhiyuan commented on issue #1882: URL: https://github.com/apache/apisix-dashboard/issues/1882#issuecomment-836431800 https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L345-L353 Just rechecked the schema_def, there doesn't have default value actually, so this issue turns to what's default value should dashboard use on timeout fields. @totemofwolf I remember you also have this question? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: efficient error handling in manager-api including graceful shutdown, self contained methods. (#1814)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 260b767 fix: efficient error handling in manager-api including
graceful shutdown, self contained methods. (#1814)
260b767 is described below
commit 260b767476bf5301e6cc3a438f2483b02e96551d
Author: Bisakh Mondal
AuthorDate: Mon May 10 14:33:14 2021 +0530
fix: efficient error handling in manager-api including graceful shutdown,
self contained methods. (#1814)
---
api/cmd/managerapi.go | 66 ++-
api/internal/core/store/store.go | 6 ++--
api/internal/core/store/store_test.go | 3 +-
api/internal/utils/pid.go | 3 ++
api/test/shell/cli_test.sh| 53
5 files changed, 104 insertions(+), 27 deletions(-)
diff --git a/api/cmd/managerapi.go b/api/cmd/managerapi.go
index 4f56b5f..a3543b1 100644
--- a/api/cmd/managerapi.go
+++ b/api/cmd/managerapi.go
@@ -101,7 +101,7 @@ func manageAPI() error {
if err := utils.WritePID(conf.PIDPath); err != nil {
log.Errorf("failed to write pid: %s", err)
- panic(err)
+ return err
}
utils.AppendToClosers(func() error {
if err := os.Remove(conf.PIDPath); err != nil {
@@ -111,6 +111,15 @@ func manageAPI() error {
return nil
})
+ // Signal received to the process externally.
+ quit := make(chan os.Signal, 1)
+ signal.Notify(quit, syscall.SIGINT, syscall.SIGTERM)
+
+ defer func() {
+ utils.CloseAll()
+ signal.Stop(quit)
+ }()
+
droplet.Option.Orchestrator = func(mws []droplet.Middleware)
[]droplet.Middleware {
var newMws []droplet.Middleware
// default middleware order: resp_reshape, auto_input,
traffic_log
@@ -122,17 +131,21 @@ func manageAPI() error {
if err := storage.InitETCDClient(conf.ETCDConfig); err != nil {
log.Errorf("init etcd client fail: %w", err)
- panic(err)
+ return err
}
if err := store.InitStores(); err != nil {
log.Errorf("init stores fail: %w", err)
- panic(err)
+ return err
}
+ var server, serverSSL *http.Server
+ // For internal error handling across multiple goroutines.
+ errsig := make(chan error, 1)
+
// routes
r := internal.SetUpRouter()
- addr := fmt.Sprintf("%s:%d", conf.ServerHost, conf.ServerPort)
- s := &http.Server{
+ addr := net.JoinHostPort(conf.ServerHost, strconv.Itoa(conf.ServerPort))
+ server = &http.Server{
Addr: addr,
Handler: r,
ReadTimeout: time.Duration(1000) * time.Millisecond,
@@ -141,21 +154,17 @@ func manageAPI() error {
log.Infof("The Manager API is listening on %s", addr)
- quit := make(chan os.Signal, 1)
- signal.Notify(quit, syscall.SIGINT, syscall.SIGTERM)
- defer signal.Stop(quit)
-
go func() {
- if err := s.ListenAndServe(); err != nil && err !=
http.ErrServerClosed {
- utils.CloseAll()
- log.Fatalf("listen and serv fail: %s", err)
+ if err := server.ListenAndServe(); err != nil && err !=
http.ErrServerClosed {
+ log.Errorf("listen and serv fail: %s", err)
+ errsig <- err
}
}()
// HTTPS
if conf.SSLCert != "" && conf.SSLKey != "" {
addrSSL := net.JoinHostPort(conf.ServerHost,
strconv.Itoa(conf.SSLPort))
- serverSSL := &http.Server{
+ serverSSL = &http.Server{
Addr: addrSSL,
Handler: r,
ReadTimeout: time.Duration(1000) * time.Millisecond,
@@ -169,28 +178,37 @@ func manageAPI() error {
go func() {
err := serverSSL.ListenAndServeTLS(conf.SSLCert,
conf.SSLKey)
if err != nil && err != http.ErrServerClosed {
- utils.CloseAll()
- log.Fatalf("listen and serve for HTTPS failed:
%s", err)
+ log.Errorf("listen and serve for HTTPS failed:
%s", err)
+ errsig <- err
}
}()
}
printInfo()
- sig := <-quit
- log.Infof("The Manager API server receive %s and start shutting down",
sig.String())
+ select {
+ case err := <-errsig:
+ return err
- ctx, cancel := context.WithTimeout(context.TODO(), 5*time.Second)
- defer canc
[GitHub] [apisix-dashboard] tokers closed issue #1684: program panic when failed to initialize etcd store is unreasonable
tokers closed issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers merged pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
tokers merged pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Marco-Zheng commented on issue #423: bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效
Marco-Zheng commented on issue #423: URL: https://github.com/apache/apisix-ingress-controller/issues/423#issuecomment-836469087 > > ``` > > apiVersion: v1 > > data: > > config.yaml: | > > # log options > > log_level: "info" > > log_output: "stderr" > > http_listen: ":8080" > > enable_profiling: true > > kubernetes: > > kubeconfig: "" > > resync_interval: "60s" > > app_namespaces: > > - "*" > > apisix: > > base_url: "http://xx:9180/apisix/admin"; > > admin_key: "edd1c9f034335f136f87ad84b625c8f1" > > kind: ConfigMap > > metadata: > > annotations: > > meta.helm.sh/release-name: apisix-ingress-controller > > meta.helm.sh/release-namespace: ingress-apisix > > creationTimestamp: "2021-05-08T08:09:34Z" > > labels: > > app.kubernetes.io/instance: apisix-ingress-controller > > app.kubernetes.io/managed-by: Helm > > app.kubernetes.io/name: apisix-ingress-controller > > app.kubernetes.io/version: 0.4.0 > > helm.sh/chart: apisix-ingress-controller-0.3.0 > > name: apisix-ingress-controller-configmap > > namespace: ingress-apisix > > resourceVersion: "7545638850" > > selfLink: /api/v1/namespaces/ingress-apisix/configmaps/apisix-ingress-controller-configmap > > uid: 74524651-7a57-4d6d-a894-2f0b4715e11a > > ``` > > I add the change for the watching version of ingress. > > ``` > apiVersion: v1 > data: > config.yaml: | > # log options > log_level: "info" > log_output: "stderr" > http_listen: ":8080" > enable_profiling: true > kubernetes: > kubeconfig: "" > resync_interval: "60s" > ingressVersion: networking/v1beta1 > app_namespaces: > - "*" > apisix: > base_url: "http://xx:9180/apisix/admin"; > admin_key: "edd1c9f034335f136f87ad84b625c8f1" > kind: ConfigMap > metadata: > annotations: > meta.helm.sh/release-name: apisix-ingress-controller > meta.helm.sh/release-namespace: ingress-apisix > creationTimestamp: "2021-05-08T08:09:34Z" > labels: > app.kubernetes.io/instance: apisix-ingress-controller > app.kubernetes.io/managed-by: Helm > app.kubernetes.io/name: apisix-ingress-controller > app.kubernetes.io/version: 0.4.0 > helm.sh/chart: apisix-ingress-controller-0.3.0 > name: apisix-ingress-controller-configmap > namespace: ingress-apisix > resourceVersion: "7545638850" > selfLink: /api/v1/namespaces/ingress-apisix/configmaps/apisix-ingress-controller-configmap > uid: 74524651-7a57-4d6d-a894-2f0b4715e11a > ``` > > ``` > > apiVersion: v1 > > data: > > config.yaml: | > > # log options > > log_level: "info" > > log_output: "stderr" > > http_listen: ":8080" > > enable_profiling: true > > kubernetes: > > kubeconfig: "" > > resync_interval: "60s" > > app_namespaces: > > - "*" > > apisix: > > base_url: "http://xx:9180/apisix/admin"; > > admin_key: "edd1c9f034335f136f87ad84b625c8f1" > > kind: ConfigMap > > metadata: > > annotations: > > meta.helm.sh/release-name: apisix-ingress-controller > > meta.helm.sh/release-namespace: ingress-apisix > > creationTimestamp: "2021-05-08T08:09:34Z" > > labels: > > app.kubernetes.io/instance: apisix-ingress-controller > > app.kubernetes.io/managed-by: Helm > > app.kubernetes.io/name: apisix-ingress-controller > > app.kubernetes.io/version: 0.4.0 > > helm.sh/chart: apisix-ingress-controller-0.3.0 > > name: apisix-ingress-controller-configmap > > namespace: ingress-apisix > > resourceVersion: "7545638850" > > selfLink: /api/v1/namespaces/ingress-apisix/configmaps/apisix-ingress-controller-configmap > > uid: 74524651-7a57-4d6d-a894-2f0b4715e11a > > ``` > > I add the change for the watching version of ingress. > > ``` > apiVersion: v1 > data: > config.yaml: | > # log options > log_level: "info" > log_output: "stderr" > http_listen: ":8080" > enable_profiling: true > kubernetes: > kubeconfig: "" > resync_interval: "60s" > ingressVersion: networking/v1beta1 > app_namespaces: > - "*" > apisix: > base_url: "http://xx:9180/apisix/admin"; > admin_key: "edd1c9f034335f136f87ad84b625c8f1" > kind: ConfigMap > metadata: > annotations: > meta.helm.sh/release-name: apisix-ingress-controller > meta.helm.sh/release-namespace: ingress-apisix > creationTimestamp: "2021-05-08T08:09:34Z" > labels: > app.kubernetes.io/instance: apisix-ingress-controller > app.kube
[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #429: release 0.6.0
gxthrj opened a new pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #429: release 0.6.0
codecov-commenter commented on pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836484350 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#429](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7bb4934) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #429 +/- ## === Coverage 36.58% 36.58% === Files 43 43 Lines3799 3799 === Hits 1390 1390 Misses 2230 2230 Partials 179 179 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...7bb4934](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #429: release 0.6.0
tao12345666333 commented on a change in pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#discussion_r629222542 ## File path: CHANGELOG.md ## @@ -19,12 +19,32 @@ # Table of Contents +- [0.6.0](#060) - [0.5.0](#050) - [0.4.0](#040) - [0.3.0](#030) - [0.2.0](#020) - [0.1.0](#010) +# 0.6.0 + +这个版本我们新增了一些特性，修复了一些bug,同时也对内部代码做了一些优化。 Review comment: In English? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit bd1ec32ac21219a7aeeaddd753ab8da1fa00bd54 https://app.netlify.com/sites/apisix-dashboard/deploys/6099021777841a00075ecb1c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #73: feat: support for controller-only deployment
tao12345666333 opened a new pull request #73: URL: https://github.com/apache/apisix-helm-chart/pull/73 Add new top-level `apisix.enabled` setting to control whether deploy apisix-ingress controller only. Signed-off-by: Jintao Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #73: feat: support for controller-only deployment
tokers commented on a change in pull request #73: URL: https://github.com/apache/apisix-helm-chart/pull/73#discussion_r629227642 ## File path: charts/apisix/values.yaml ## @@ -14,6 +14,11 @@ # See the License for the specific language governing permissions and # limitations under the License. +apisix: + # Enable or disable Apache APISIX itself + # Set it to flase and ingress-controller.enabled=true will deploy only ingress-controller + enabled: true Review comment: There are so many top-level fields which are related with APISIX, I think we can put all of them under the apisix field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #429: release 0.6.0
gxthrj commented on a change in pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#discussion_r629228285 ## File path: CHANGELOG.md ## @@ -19,12 +19,32 @@ # Table of Contents +- [0.6.0](#060) - [0.5.0](#050) - [0.4.0](#040) - [0.3.0](#030) - [0.2.0](#020) - [0.1.0](#010) +# 0.6.0 + +这个版本我们新增了一些特性，修复了一些bug,同时也对内部代码做了一些优化。 Review comment: yep ## File path: CHANGELOG.md ## @@ -19,12 +19,32 @@ # Table of Contents +- [0.6.0](#060) - [0.5.0](#050) - [0.4.0](#040) - [0.3.0](#030) - [0.2.0](#020) - [0.1.0](#010) +# 0.6.0 + +这个版本我们新增了一些特性，修复了一些bug,同时也对内部代码做了一些优化。 Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #73: feat: support for controller-only deployment
tao12345666333 commented on a change in pull request #73: URL: https://github.com/apache/apisix-helm-chart/pull/73#discussion_r629228964 ## File path: charts/apisix/values.yaml ## @@ -14,6 +14,11 @@ # See the License for the specific language governing permissions and # limitations under the License. +apisix: + # Enable or disable Apache APISIX itself + # Set it to flase and ingress-controller.enabled=true will deploy only ingress-controller + enabled: true Review comment: Yep. I did not modify it because I was worried about breaking changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #429: release 0.6.0
codecov-commenter edited a comment on pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836484350 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#429](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5820f31) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #429 +/- ## === Coverage 36.58% 36.58% === Files 43 43 Lines3799 3799 === Hits 1390 1390 Misses 2230 2230 Partials 179 179 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...5820f31](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Firstsawyou commented on a change in pull request #71: chore: update the default version of apisix-dashboard
Firstsawyou commented on a change in pull request #71: URL: https://github.com/apache/apisix-helm-chart/pull/71#discussion_r629234222 ## File path: charts/apisix-dashboard/values.yaml ## @@ -24,7 +24,7 @@ image: repository: apache/apisix-dashboard pullPolicy: IfNotPresent # Overrides the image tag whose default is the chart appVersion. - tag: "2.3" + tag: "2.6" Review comment: Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] oldthreefeng commented on issue #1882: default connection timeout not equal with nginx?
oldthreefeng commented on issue #1882: URL: https://github.com/apache/apisix-dashboard/issues/1882#issuecomment-836508312 if i dont set the timeout section. what the value the apisxi upstream use? @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated (6228fb7 -> 1f4eb59)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git. from 6228fb7 add README for charts/apisix-ingress-controller (#69) add 1f4eb59 Add ability to specify automountServiceAccountToken (#72) No new revisions were added by this update. Summary of changes: charts/apisix-ingress-controller/templates/service-account.yaml | 1 + charts/apisix-ingress-controller/values.yaml| 5 - 2 files changed, 5 insertions(+), 1 deletion(-)
[GitHub] [apisix-helm-chart] gxthrj merged pull request #72: feat: add ability to specify automountServiceAccountToken
gxthrj merged pull request #72: URL: https://github.com/apache/apisix-helm-chart/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #73: feat: support for controller-only deployment
gxthrj commented on a change in pull request #73: URL: https://github.com/apache/apisix-helm-chart/pull/73#discussion_r629246563 ## File path: charts/apisix/values.yaml ## @@ -14,6 +14,11 @@ # See the License for the specific language governing permissions and # limitations under the License. +apisix: + # Enable or disable Apache APISIX itself + # Set it to flase and ingress-controller.enabled=true will deploy only ingress-controller + enabled: true Review comment: There is no place to reference this value yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-836538380 Hi guys, the CI hadn't passed in this PR. Some checking was left to be done from my side. I truly am sorry, I got caught up in university exams for a few days. I think we should revert the commit. CI has failed in the master too. https://github.com/apache/apisix-dashboard/pull/1814#discussion_r627478821 Also this need to be taken care of. Sorry for the inconvenience. I am updating the PR as soon as possible. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #429: release 0.6.0
codecov-commenter edited a comment on pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836484350 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#429](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5820f31) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #429 +/- ## == + Coverage 36.58% 36.60% +0.01% == Files 43 44 +1 Lines3799 3800 +1 == + Hits 1390 1391 +1 Misses 2230 2230 Partials 179 179 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | `100.00% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...5820f31](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4164: feat: add 50x html for error page
tokers commented on a change in pull request #4164:
URL: https://github.com/apache/apisix/pull/4164#discussion_r629259165
##
File path: t/error_page/error_page.t
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
Review comment:
Keep three empty lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4206: bug: consul example response 500
Firstsawyou commented on issue #4206: URL: https://github.com/apache/apisix/issues/4206#issuecomment-836551722 > yes , i did. Okay, I will confirm it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1883: fix: generate an uid when post a route without id
juzhiyuan commented on a change in pull request #1883: URL: https://github.com/apache/apisix-dashboard/pull/1883#discussion_r629268776 ## File path: api/test/e2enew/route/route_with_plugin_orchestration_test.go ## @@ -23,6 +23,7 @@ import ( "github.com/onsi/ginkgo" "github.com/onsi/ginkgo/extensions/table" "github.com/onsi/gomega" + "github.com/tidwall/gjson" Review comment: Hi, this file seems doesn't test `script` field? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #429: release 0.6.0
tokers commented on a change in pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#discussion_r629269285 ## File path: CHANGELOG.md ## @@ -19,12 +19,32 @@ # Table of Contents +- [0.6.0](#060) - [0.5.0](#050) - [0.4.0](#040) - [0.3.0](#030) - [0.2.0](#020) - [0.1.0](#010) +# 0.6.0 + +We have added some new features, fixed some bugs, and made some optimizations to the internal code. Review comment: Should tell people, CRDs were changed, should re-apply them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #429: release 0.6.0
tokers commented on pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836563108 @gxthrj Should also change the document to tell people the compatibility relationship between APISIX and apisix-ingress-controller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
juzhiyuan commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-836564304 @bisakhmondal Hi, if it's ok, could you please send a new PR to fix that failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: generate a uid when post a route without id (#1883)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 1770596 fix: generate a uid when post a route without id (#1883)
1770596 is described below
commit 177059644e3eb5d8ddd42da6a2b48413c70eb044
Author: Peter Zhu
AuthorDate: Mon May 10 19:10:47 2021 +0800
fix: generate a uid when post a route without id (#1883)
---
api/internal/handler/route/route.go| 2 +-
.../route/route_with_plugin_orchestration_test.go | 61 ++
2 files changed, 62 insertions(+), 1 deletion(-)
diff --git a/api/internal/handler/route/route.go
b/api/internal/handler/route/route.go
index 2775679..fae4429 100644
--- a/api/internal/handler/route/route.go
+++ b/api/internal/handler/route/route.go
@@ -338,7 +338,7 @@ func (h *Handler) Create(c droplet.Context) (interface{},
error) {
}
if input.Script != nil {
- if input.ID == "" {
+ if utils.InterfaceToString(input.ID) == "" {
input.ID = utils.GetFlakeUidStr()
}
script := &entity.Script{}
diff --git a/api/test/e2enew/route/route_with_plugin_orchestration_test.go
b/api/test/e2enew/route/route_with_plugin_orchestration_test.go
index 57e612e..304240f 100644
--- a/api/test/e2enew/route/route_with_plugin_orchestration_test.go
+++ b/api/test/e2enew/route/route_with_plugin_orchestration_test.go
@@ -23,6 +23,7 @@ import (
"github.com/onsi/ginkgo"
"github.com/onsi/ginkgo/extensions/table"
"github.com/onsi/gomega"
+ "github.com/tidwall/gjson"
"github.com/apisix/manager-api/test/e2enew/base"
)
@@ -108,4 +109,64 @@ var _ = ginkgo.Describe("route with plugin orchestration",
func() {
Sleep:base.SleepTime,
}),
)
+
+ table.DescribeTable("test route with plugin orchestration (post
method)",
+ func(tc base.HttpTestCase) {
+ base.RunTestCase(tc)
+ },
+ table.Entry("make sure the route is not created",
base.HttpTestCase{
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusNotFound,
+ ExpectBody: `{"error_msg":"404 Route Not Found"}`,
+ }),
+ )
+
+ var routeID string
+ ginkgo.It("create route with correct dag config by post", func() {
+ resp, code, err :=
base.HttpPost(base.ManagerAPIHost+"/apisix/admin/routes",
+ map[string]string{"Authorization": base.GetToken()},
dagConf)
+ gomega.Expect(err).To(gomega.BeNil())
+ gomega.Expect(code).Should(gomega.Equal(200))
+ routeID = gjson.Get(string(resp), "data.id").String()
+ })
+
+ ginkgo.It("test the route with plugin orchestration", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Desc: "verify the route (should be blocked)",
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: "/hello",
+ Query:"t=root.exe",
+ ExpectStatus: http.StatusForbidden,
+ ExpectBody: `blocked`,
+ Sleep:base.SleepTime,
+ })
+ base.RunTestCase(base.HttpTestCase{
+ Desc: "verify the route (should not be
blocked)",
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusOK,
+ ExpectBody: `hello world`,
+ })
+ base.RunTestCase(base.HttpTestCase{
+ Desc: "delete the route by routeID",
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodDelete,
+ Path: "/apisix/admin/routes/" + routeID,
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ })
+ base.RunTestCase(base.HttpTestCase{
+ Desc: "make sure the route has been deleted",
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusNotFound,
+ ExpectBody: `{"error_msg":"404 Route Not
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1883: fix: generate an uid when post a route without id
juzhiyuan merged pull request #1883: URL: https://github.com/apache/apisix-dashboard/pull/1883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on issue #171: docker compoest start image, but etcd start failed
tokers commented on issue #171: URL: https://github.com/apache/apisix-docker/issues/171#issuecomment-836565115 @anyeshe As you use the bind mount, which inherits the permission on host machine, you should check the permission and the owner of the `./etcd_data` directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #429: release 0.6.0
gxthrj commented on pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836568318 > @gxthrj Should also change the document to tell people the compatibility relationship between APISIX and apisix-ingress-controller. changed, apisix-ingress-controller 0.6 with apisix 2.6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #429: release 0.6.0
gxthrj commented on a change in pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429#discussion_r629274934 ## File path: CHANGELOG.md ## @@ -19,12 +19,32 @@ # Table of Contents +- [0.6.0](#060) - [0.5.0](#050) - [0.4.0](#040) - [0.3.0](#030) - [0.2.0](#020) - [0.1.0](#010) +# 0.6.0 + +We have added some new features, fixed some bugs, and made some optimizations to the internal code. Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] younglifestyle commented on issue #171: docker compoest start image, but etcd start failed
younglifestyle commented on issue #171: URL: https://github.com/apache/apisix-docker/issues/171#issuecomment-836576089 > > > @younglifestyle could the method provide by @anyeshe fix your problem > > > > > > I'll try now > > failed. Etcd can't see the log. the configuration is here >  I modified etcd_data permission to 777, it's running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Molio-tan commented on issue #4157: bug: After installing the Apisix on ARM-based System,but it can't works properly.
Molio-tan commented on issue #4157: URL: https://github.com/apache/apisix/issues/4157#issuecomment-836580098 > @Molio-tan Have you tried the similar solution provided by https://blog.csdn.net/nange_nice/article/details/82182635? Probably this may give you a quick fix. > > Currently, only OpenSSL is well tested with openresty. The introduction of [GmSSL repository](https://github.com/guanzhi/GmSSL#about-gmssl) tells `Existing projects such as Apache web server can be easily ported to GmSSL with minor modification and a simple rebuild.`, so maybe there still needs some work to get along with openresty. > > Since the uncommonly used GmSSL introduces too much complexity and uncertainty. Could you use OpenSSL first to check if it works? If everything goes well, I guess the only work is to make openresty successfully running on GmSSL. > > Looking forward to your feedback. Thanks. I felt SO SORRY that we came back at first on this issue. The module 'resty.worker.events' not found. Here are my steps: 1. install openssl111 ``` tar -zf openssl-1.1.1h.tar.gz cd openssl-1.1.1h/ ./config --prefix=/usr/local/openssl111 --openssldir=/usr/local/openssl111 make && make install ``` 2. install openresty ``` tar -xzf openresty-1.19.3.1.tar.gz cd openresty-1.19.3.1/ ./configure --prefix=/usr/local/openresty --with-pcre-jit--with-ipv6 --with-http_stub_status_module --without-http_gzip_module --with-http_realip_module --with-http_v2_module make && make install ln -s /usr/local/openresty/bin/openresty /usr/bin/ ``` 3. set the path of 'OPENSSL_LIBDIR' and 'OPENSSL_INCDIR' by `luarocks` ``` luarocks config variables.OPENSSL_LIBDIR /usr/local/openssl111/lib luarocks config variables.OPENSSL_INCDIR /usr/local/openssl111/include ``` 4. start APISIX by `./bin/apisix start` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #4164: feat: add 50x html for error page
starsz commented on a change in pull request #4164:
URL: https://github.com/apache/apisix/pull/4164#discussion_r629280214
##
File path: t/error_page/error_page.t
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
Review comment:
What for?
##
File path: apisix/cli/ngx_tpl.lua
##
@@ -367,6 +381,17 @@ http {
apisix.http_admin()
}
}
+
+location = /50x.html {
Review comment:
Updated.
##
File path: apisix/cli/ngx_tpl.lua
##
@@ -290,6 +293,17 @@ http {
apisix.http_control()
}
}
+
+location = /50x.html {
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2620: request help: we need to support multi-nodes in upstream when pass_host == node
membphis commented on issue #2620: URL: https://github.com/apache/apisix/issues/2620#issuecomment-836588315 > > So we only need to enable this feature for users who use OpenResty 1.19.3? > > can we patch the old versions? > Or make sure that the version of OpenResty that apisix depends on is adjusted to 1.19.3 in the future? > > @membphis what do you think? only support 1.19.3 is fine. In the future, APISIX will mainly work with patched openresty to support mTLS and other new functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-836596045 > @bisakhmondal Hi, if it's ok, could you please send a new PR to fix that failure? Ya, that sounds awesome. but yet, I can't reproduce the failure(totally irrelevant to this PR) locally even with the same environment like CI inside a docker container,  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-836598386 > @bisakhmondal Hi, if it's ok, could you please send a new PR to fix that failure? @juzhiyuan It seems to be a CI glitch, now the master is fine after a recent commit.  Even the last commit has passed all CI. What do you think, can we ignore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #429: release 0.6.0
gxthrj merged pull request #429: URL: https://github.com/apache/apisix-ingress-controller/pull/429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: release 0.6.0 (#429)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new c4514fb release 0.6.0 (#429)
c4514fb is described below
commit c4514fb5612a234edeb64bf978806c0511bfb1a5
Author: kv
AuthorDate: Mon May 10 19:52:57 2021 +0800
release 0.6.0 (#429)
* release 0.6.0
---
CHANGELOG.md | 22 ++
Makefile | 2 +-
docs/en/latest/getting-started.md | 1 +
3 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5010448..94f423c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,12 +19,34 @@
# Table of Contents
+- [0.6.0](#060)
- [0.5.0](#050)
- [0.4.0](#040)
- [0.3.0](#030)
- [0.2.0](#020)
- [0.1.0](#010)
+# 0.6.0
+
+We have added some new features, fixed some bugs, and made some optimizations
to the internal code.
+
+**Note: The CRDs should be re-applied because of some new features**
+
+## Core
+
+* Support TCP definition
[#115](https://github.com/apache/apisix-ingress-controller/issues/115)
+* Add labels to mark resources are pushed by ingress controller
[#242](https://github.com/apache/apisix-ingress-controller/issues/242)
+* Add jsonschema validate for ApisixUpstream and ApisixTls resource
[#371](https://github.com/apache/apisix-ingress-controller/issues/371)
[#372](https://github.com/apache/apisix-ingress-controller/issues/372)
+* Support to record kubernetes events for resources processing
[#394](https://github.com/apache/apisix-ingress-controller/issues/394)
+* Support to report resources status
[#395](https://github.com/apache/apisix-ingress-controller/issues/395)
+* Support global_rules for cluster scoped plugins
[#402](https://github.com/apache/apisix-ingress-controller/issues/402)
+
+## Fix
+
+* Remove upstream caching correctly
[#421](https://github.com/apache/apisix-ingress-controller/issues/421)
+* Avoid retrying caused by 404 when deleting cache
[#424](https://github.com/apache/apisix-ingress-controller/pull/424)
+* Handle cookie exprs correctly
[#425](https://github.com/apache/apisix-ingress-controller/pull/425)
+
# 0.5.0
A lot of important features are supported in this release, it makes
apisix-ingress-controller more powerful and flexible.
diff --git a/Makefile b/Makefile
index f74ae3b..2a6c7e7 100644
--- a/Makefile
+++ b/Makefile
@@ -16,7 +16,7 @@
#
default: help
-VERSION ?= 0.5.0
+VERSION ?= 0.6.0
RELEASE_SRC = apache-apisix-ingress-controller-${VERSION}-src
LOCAL_REGISTRY="localhost:5000"
IMAGE_TAG ?= dev
diff --git a/docs/en/latest/getting-started.md
b/docs/en/latest/getting-started.md
index 809403f..9941435 100644
--- a/docs/en/latest/getting-started.md
+++ b/docs/en/latest/getting-started.md
@@ -77,5 +77,6 @@ The following table describes the compatibility between
apisix-ingress-controlle
| apisix-ingress-controller | Apache APISIX |
| :| ---:|
| `master` | `>= 2.4`, `2.5` is recommended. |
+| `0.6` | `>= 2.6`, `2.6` is recommended. |
| `0.5` | `>= 2.4`, `2.5` is recommended. |
| `0.4` |`>= 2.4`|
[GitHub] [apisix-helm-chart] gxthrj merged pull request #73: feat: support for controller-only deployment
gxthrj merged pull request #73: URL: https://github.com/apache/apisix-helm-chart/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: feat: support for controller-only deployment (#73)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 7d9a437 feat: support for controller-only deployment (#73) 7d9a437 is described below commit 7d9a4370fe3a48a9c423faa5b91678929de81797 Author: Jintao Zhang AuthorDate: Mon May 10 19:54:30 2021 +0800 feat: support for controller-only deployment (#73) Signed-off-by: Jintao Zhang --- charts/apisix/values.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/charts/apisix/values.yaml b/charts/apisix/values.yaml index f3a5943..be73804 100644 --- a/charts/apisix/values.yaml +++ b/charts/apisix/values.yaml @@ -14,6 +14,11 @@ # See the License for the specific language governing permissions and # limitations under the License. +apisix: + # Enable or disable Apache APISIX itself + # Set it to flase and ingress-controller.enabled=true will deploy only ingress-controller + enabled: true + replicaCount: 1 image: repository: apache/apisix
[apisix-ingress-controller] tag 0.6.0 created (now c4514fb)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to tag 0.6.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. at c4514fb (commit) No new revisions were added by this update.
[apisix-ingress-controller] branch v0.6.0 created (now c4514fb)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch v0.6.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. at c4514fb release 0.6.0 (#429) No new revisions were added by this update.
[GitHub] [apisix] dickens7 opened a new issue #4209: New feature suggestion: request-id plugin supports "snowflake" algorithm
dickens7 opened a new issue #4209: URL: https://github.com/apache/apisix/issues/4209 Add support for snowflake algorithm to Request-ID plugin, or provide a separate snowflake algorithm plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr opened a new pull request #430: ci: introduce skywalking-eyes
dmsolr opened a new pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430 Please answer these questions before submitting a pull request Introduce apache/skywalking-eyes to do license header check. - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #430: ci: introduce skywalking-eyes
codecov-commenter commented on pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-836674682 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#430](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b728a5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #430 +/- ## === Coverage 36.58% 36.58% === Files 43 43 Lines3799 3799 === Hits 1390 1390 Misses 2230 2230 Partials 179 179 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...7b728a5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 opened a new issue #1884: feat: provide command line interface of Manager API
bzp2010 opened a new issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884 # Feature request ## Please describe your feature Adding a command line interface to the Manager API, let it can operate the back-end storage in cli mode. It will provide commands such as `manager-api cli route` + `get\add\edit\delete`. (need discuss) ## Describe the solution you'd like The current command line uses `cobra` library to implement, which can support my simple extension of new command. The operation on `etcd` will reuse the current storage layer directly. It will be implemented gradually from an entity. ## Additional context [there is a issue](https://github.com/apache/apisix-control-plane/issues/42) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
dmsolr commented on a change in pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629349330 ## File path: conf/kubeconfig ## @@ -1,3 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + apiVersion: v1 clusters: - cluster: Review comment: Please double check this file whether we can need a license header? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-control-plane] gxthrj commented on issue #42: feat:Use curl to encapsulate the Admin API into a script
gxthrj commented on issue #42: URL: https://github.com/apache/apisix-control-plane/issues/42#issuecomment-836687921 @kasini3000 Please take a look at https://github.com/apache/apisix-dashboard/issues/1884, maybe what you want. Apisix-control-plane hopes to make a yaml declarative configuration, and of course there will be command line tools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: ci: revert luarocks retry (#4038)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 504cd1b ci: revert luarocks retry (#4038)
504cd1b is described below
commit 504cd1b0966880101b3e2582cfb1cf65f23a7863
Author: Shuyang Wu
AuthorDate: Mon May 10 09:23:03 2021 -0400
ci: revert luarocks retry (#4038)
---
.github/workflows/fuzzing-ci.yaml | 8 +---
ci/centos7-ci.sh | 8 +---
ci/common.sh | 8 +---
ci/linux_apisix_current_luarocks_runner.sh | 9 +
ci/linux_apisix_master_luarocks_runner.sh | 10 +-
utils/install-apisix.sh| 20 ++--
6 files changed, 11 insertions(+), 52 deletions(-)
diff --git a/.github/workflows/fuzzing-ci.yaml
b/.github/workflows/fuzzing-ci.yaml
index 4b3299c..259f62b 100644
--- a/.github/workflows/fuzzing-ci.yaml
+++ b/.github/workflows/fuzzing-ci.yaml
@@ -51,13 +51,7 @@ jobs:
sudo apt-get install -y git openresty curl openresty-openssl111-dev
unzip make gcc
sudo ./utils/linux-install-luarocks.sh
-for (( i = 0; i < 10; i++ )); do
-if [[ "$i" -eq 10 ]]; then
-echo "failed to make deps in time"
-exit 1
-fi
-make deps && break
-done
+make deps
make init
make run
diff --git a/ci/centos7-ci.sh b/ci/centos7-ci.sh
index b03d4d2..779f4a3 100755
--- a/ci/centos7-ci.sh
+++ b/ci/centos7-ci.sh
@@ -59,13 +59,7 @@ install_dependencies() {
# install dependencies
git clone https://github.com/iresty/test-nginx.git test-nginx
-for (( i = 0; i < 10; i++ )); do
-if [[ "$i" -eq 10 ]]; then
-echo "failed to make deps in time"
-exit 1
-fi
-make deps && break
-done
+make deps
}
run_case() {
diff --git a/ci/common.sh b/ci/common.sh
index 26e7b6f..a6b7814 100644
--- a/ci/common.sh
+++ b/ci/common.sh
@@ -26,13 +26,7 @@ export_or_prefix() {
create_lua_deps() {
echo "Create lua deps"
-for (( i = 0; i < 10; i++ )); do
-if [[ "$i" -eq 10 ]]; then
-echo "failed to make deps in time"
-exit 1
-fi
-make deps && break
-done
+make deps
# maybe reopen this feature later
# luarocks install luacov-coveralls --tree=deps --local > build.log 2>&1
|| (cat build.log && exit 1)
}
diff --git a/ci/linux_apisix_current_luarocks_runner.sh
b/ci/linux_apisix_current_luarocks_runner.sh
index 5989c66..e055c4c 100755
--- a/ci/linux_apisix_current_luarocks_runner.sh
+++ b/ci/linux_apisix_current_luarocks_runner.sh
@@ -33,14 +33,7 @@ script() {
sudo rm -rf /usr/local/apisix
# install APISIX with local version
-for (( i = 0; i < 10; i++ )); do
-if [[ "$i" -eq 10 ]]; then
-echo "failed to install in time"
-cat build.log && exit 1
-exit 1
-fi
-sudo luarocks install rockspec/apisix-master-0.rockspec --only-deps >
build.log 2>&1 && break
-done
+sudo luarocks install rockspec/apisix-master-0.rockspec --only-deps >
build.log 2>&1 || (cat build.log && exit 1)
sudo luarocks make rockspec/apisix-master-0.rockspec > build.log 2>&1 ||
(cat build.log && exit 1)
mkdir cli_tmp && cd cli_tmp
diff --git a/ci/linux_apisix_master_luarocks_runner.sh
b/ci/linux_apisix_master_luarocks_runner.sh
index f0f14a4..c889ed2 100755
--- a/ci/linux_apisix_master_luarocks_runner.sh
+++ b/ci/linux_apisix_master_luarocks_runner.sh
@@ -53,15 +53,7 @@ script() {
sudo PATH=$PATH ./utils/install-apisix.sh remove > build.log 2>&1 || (cat
build.log && exit 1)
# install APISIX by luarocks
-for (( i = 0; i < 10; i++ )); do
-if [[ "$i" -eq 10 ]]; then
-echo "failed to fetch lua rocks in time"
-cat build.log && exit 1
-exit 1
-fi
-sudo luarocks install $APISIX_MAIN > build.log 2>&1 && break
-i=$(( i + 1 ))
-done
+sudo luarocks install $APISIX_MAIN > build.log 2>&1 || (cat build.log &&
exit 1)
cp ../bin/apisix /usr/local/bin/apisix
# show install files
diff --git a/utils/install-apisix.sh b/utils/install-apisix.sh
index 91e0142..92a3dd6 100755
--- a/utils/install-apisix.sh
+++ b/utils/install-apisix.sh
@@ -42,20 +42,12 @@ echo $UNAME
do_install() {
-i=0
-while true; do
-if [ "$i" = "10" ]; then
-echo "failed to install in time"
-cat build.log && exit 1
-exit 1
-fi
-if [ "$LUAROCKS_VER" = 'luarocks 3.' ]; then
-sudo luarocks install --lua-dir=$LUA_JIT_DIR $APISIX_VER
--tree=/usr/local/apisix/deps --local > build.log 2>&1 && break
-else
-sudo luarocks install $APISIX_VER --tree=/usr/local/apisix
[GitHub] [apisix] spacewander merged pull request #4038: ci: revert luarocks retry
spacewander merged pull request #4038: URL: https://github.com/apache/apisix/pull/4038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #1884: feat: provide command line interface of Manager API
bzp2010 commented on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-836723762 ## Enhance CLI of Manager API Provides a way to operate the etcd storage of Apache APISIX by CLI. ### Significance The current deployment mode of dashboard is too heavy for small-scale applications such as stand-alone deployment. It may be difficult to connect to etcd when using docker deployment in stand-alone deployment. The compilation deployment needs to install some tools such as golang and nodejs, as well as their version problems. ### Goal The goal of the tool is to simplify the use in these scenarios, and the can be used to control the gateway just through a single binary program with CLI. ### Implement The current command line uses cobra library to implement, which can support my simple extension of new command. The operation on etcd will reuse the current storage layer directly. In the beginning, it will provide the simplest control like this. `manager-api cli route create [flags]` `--name` `--host` `--methods` It could end up like this `manager-api cli route create --name test --host example.com --methods get,post --upstream-id --etcd-endpoint 127.0.0.1:2379` **Is there any better suggestion on this part?** ### Development Plan 1. Provide configuration mode based on JSON. 2. Provides configuration based on command line parameters. (split configuration in JSON into parameters according to entity parameters) 3. Try to provide support for the above functions in a more extensible way, so that it can face the changes of entity attributes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on issue #1884: feat: provide command line interface of Manager API
bzp2010 edited a comment on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-836723762 ## Enhance CLI of Manager API Provides a way to operate the etcd storage of Apache APISIX by CLI. ### Significance The current deployment mode of dashboard is too heavy for small-scale applications such as stand-alone deployment. It may be difficult to connect to etcd when using docker deployment in stand-alone deployment. The compilation deployment needs to install some tools such as golang and nodejs, as well as their version problems. ### Goal The goal of the tool is to simplify the use in these scenarios, and the can be used to control the gateway just through a single binary program with CLI. ### Implement The current command line uses cobra library to implement, which can support my simple extension of new command. The operation on etcd will reuse the current storage layer directly. In the beginning, it will provide the simplest control like this. `manager-api cli route create [flags]` `--name` `--host` `--methods` It could end up like this `manager-api cli route create --name test --host example.com --methods get,post --upstream-id --etcd-endpoint 127.0.0.1:2379` **Is there any better suggestion on this part?** ### Development Plan 0. Modify the current cli implementation to a better form. 1. Provide configuration mode based on JSON. 2. Provides configuration based on command line parameters. (split configuration in JSON into parameters according to entity parameters) 3. Try to provide support for the above functions in a more extensible way, so that it can face the changes of entity attributes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on issue #1884: feat: provide command line interface of Manager API
bzp2010 edited a comment on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-836723762 ## Enhance CLI of Manager API Provides a way to operate the etcd storage of Apache APISIX by CLI. ### Significance The current deployment mode of dashboard is too heavy for small-scale applications such as stand-alone deployment. It may be difficult to connect to etcd when using docker deployment in stand-alone deployment. The compilation deployment needs to install some tools such as golang and nodejs, as well as their version problems. ### Goal The goal of the tool is to simplify the use in these scenarios, and the can be used to control the gateway just through a single binary program with CLI. ### Implement The current command line uses cobra library to implement, which can support my simple extension of new command. The operation on etcd will reuse the current storage layer directly. In the beginning, it will provide the simplest control like this. `manager-api cli route create [flags]` `--name` `--host` `--methods` It could end up like this `manager-api cli route create --name test --host example.com --methods get,post --upstream-id --etcd-endpoint 127.0.0.1:2379` ### Development Plan 0. Modify the current cli implementation to a better form. 1. Provide configuration mode based on JSON. 2. Provides configuration based on command line parameters. (split configuration in JSON into parameters according to entity parameters) 3. Try to provide support for the above functions in a more extensible way, so that it can face the changes of entity attributes. **Is there any better suggestion on this part?** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit d72e5382b8bd3b1ed1a734c9bc988b0ec4890f3a https://app.netlify.com/sites/apisix-dashboard/deploys/60993c6e9d5adf00076781b8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d72e538) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/177059644e3eb5d8ddd42da6a2b48413c70eb044?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1770596) will **decrease** coverage by `18.80%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.22% 52.42% -18.81% === Files 173 39 -134 Lines6221 2745 -3476 Branches 7120 -712 === - Hits 4431 1439 -2992 + Misses 1534 1112 -422 + Partials 256 194 -62 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.42% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
juzhiyuan commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629386504 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1", -"stylelint": "^13.0.0" +"stylelint": "^13.0.0", +"webpack": "^5.35.0" Review comment: Ant Design Pro contains UmiJS, and it will handle Webpack configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
juzhiyuan commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629385785 ## File path: web/package.json ## @@ -68,6 +67,7 @@ "js-yaml": "^4.0.0", "lodash": "^4.17.11", "moment": "^2.25.3", +"monaco-editor-webpack-plugin": "^3.0.1", Review comment: 🤔 Why we need this plugin? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1835: docs: add the visit the dashboard
netlify[bot] edited a comment on pull request #1835: URL: https://github.com/apache/apisix-dashboard/pull/1835#issuecomment-829794254 Deploy preview for *apisix-dashboard* processing. Building with commit 04cd17f21ced27f8ab5de6ba7ed8f976cedeccf3 https://app.netlify.com/sites/apisix-dashboard/deploys/60993df35242bd0008ca0253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629393048 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1", -"stylelint": "^13.0.0" +"stylelint": "^13.0.0", +"webpack": "^5.35.0" Review comment: But if I remove the webpack dependency then it will throw an error in `yarn install`.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629394731 ## File path: web/package.json ## @@ -68,6 +67,7 @@ "js-yaml": "^4.0.0", "lodash": "^4.17.11", "moment": "^2.25.3", +"monaco-editor-webpack-plugin": "^3.0.1", Review comment: If removed then monaco editor will not show highlighting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1835: docs: add the visit the dashboard
netlify[bot] edited a comment on pull request #1835: URL: https://github.com/apache/apisix-dashboard/pull/1835#issuecomment-829794254 Deploy preview for *apisix-dashboard* ready! Built with commit 04cd17f21ced27f8ab5de6ba7ed8f976cedeccf3 https://deploy-preview-1835--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 1cf880b187ebb96ab3061e71c011f52deab72ad1 https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
qian0817 commented on a change in pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629424618 ## File path: web/package.json ## @@ -131,7 +132,8 @@ "prettier": "^2.0.1", "pro-download": "1.0.1", "puppeteer-core": "^4.0.1", -"stylelint": "^13.0.0" +"stylelint": "^13.0.0", +"webpack": "^5.35.0" Review comment: I find it is a [bug](https://github.com/umijs/umi/issues/6398),I will update dependency version to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 27048b0b714b71281fb106cad0eda60e8101ec11 https://app.netlify.com/sites/apisix-dashboard/deploys/60995042ea0818efc90d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit d6c261954b9ebbd2e8b4cbd6888e70afa8dbcaff https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit f3c9985a36d87b5476f14421a27747948edd5fa4 https://app.netlify.com/sites/apisix-dashboard/deploys/609957f10d8e8400083ec63f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f3c9985) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/177059644e3eb5d8ddd42da6a2b48413c70eb044?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1770596) will **decrease** coverage by `18.76%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1813 +/- ## === - Coverage 71.22% 52.45% -18.77% === Files 173 39 -134 Lines6221 2745 -3476 Branches 7120 -712 === - Hits 4431 1440 -2991 + Misses 1534 -423 + Partials 256 194 -62 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.45% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1813](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f3c9985) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/177059644e3eb5d8ddd42da6a2b48413c70eb044?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1770596) will **decrease** coverage by `5.22%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1813 +/- ## == - Coverage 71.22% 66.00% -5.23% == Files 173 48 -125 Lines6221 3271-2950 Branches 7120 -712 == - Hits 4431 2159-2272 + Misses 1534 836 -698 - Partials 256 276 +20 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `45.27% <ø> (-0.49%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.45% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `56.92% <0.00%> (-26.16%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `40.00% <0.00%> (-10.00%)` | :arrow_down: | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `38.62% <0.00%> (-9.66%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit f3c9985a36d87b5476f14421a27747948edd5fa4 https://deploy-preview-1813--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1884: feat: provide command line interface of Manager API
starsz commented on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-836894338 The idea sounds pretty good. But is it needed to do on manager-api? Maybe you can create another project like `apisix-cli`.That would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz edited a comment on issue #1884: feat: provide command line interface of Manager API
starsz edited a comment on issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-836894338 The idea sounds pretty good. But is it needed to do on manager-api? Maybe you can create another project like `apisix-cli`.That would be better. Just in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
