[GitHub] [apisix-website] iamayushdas commented on issue #344: feature request: increase main contents max width
iamayushdas commented on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842061788 Working on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] lingsamuel opened a new issue #77: apiextensions.k8s.io/v1beta1 will be unavailable in k8s v1.22.0+
lingsamuel opened a new issue #77: URL: https://github.com/apache/apisix-helm-chart/issues/77 Deprecated in v1.16: kubernetes/kubernetes#79604 Migration guide: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new issue #4259: docs: Improve the plugin name in the response-rewrite plugin docs
Firstsawyou opened a new issue #4259: URL: https://github.com/apache/apisix/issues/4259 # Improve Docs ## Please describe which part of docs should be improved or typo fixed In the response-rewrite plugin documentation, there are many ways to write `response rewrite`, for example: https://user-images.githubusercontent.com/52862365/118446139-dc22bd00-b721-11eb-82cd-c29f5fffaa74.png";> But in fact it should be `response-rewrite`. Therefore, we need to change the `response rewrite` in the Chinese and English documents to `response-rewrite`. ## Describe the solution you'd like We need to change the `response rewrite` in the Chinese and English documents to `response-rewrite`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4260: feat: avoid overriding customized X-Forwarded-Proto header
spacewander opened a new pull request #4260: URL: https://github.com/apache/apisix/pull/4260 Close #4252 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] FightingLiming commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
FightingLiming commented on issue #4258: URL: https://github.com/apache/apisix/issues/4258#issuecomment-842117880 When a service has multiple interfaces, the timeout period of each interface may be different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.
tokers commented on a change in pull request #453:
URL:
https://github.com/apache/apisix-ingress-controller/pull/453#discussion_r633325314
##
File path: pkg/kube/init.go
##
@@ -25,16 +25,12 @@ import (
// KubeClient contains some objects used to communicate with Kubernetes API
Server.
type KubeClient struct {
+ cfg *config.Config
+
// Client is the object used to operate Kubernetes builtin resources.
Client kubernetes.Interface
// APISIXClient is the object used to operate resources under
apisix.apache.org group.
APISIXClient clientset.Interface
- // SharedIndexInformerFactory is the index informer factory object used
to watch and
Review comment:
OK, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3760: feat: support the configuration of keepalive related parameters in config.yaml
Firstsawyou commented on issue #3760: URL: https://github.com/apache/apisix/issues/3760#issuecomment-842142699 Assigned to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #453: fix: panic of start leading. sync ingress failed when apisix not start.
codecov-commenter commented on pull request #453: URL: https://github.com/apache/apisix-ingress-controller/pull/453#issuecomment-842160355 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#453](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f820ab5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5d479ae148d2acdb51082bb0f129548fdfa146b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d479ae) will **increase** coverage by `62.95%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #453 +/- ## + Coverage 37.04% 100.00% +62.95% Files 47 1 -46 Lines3841 1 -3840 - Hits 1423 1 -1422 + Misses 2233 0 -2233 + Partials 185 0 -185 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | | | [pkg/kube/translation/context.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vY29udGV4dC5nbw==) | | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | | | | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | | | | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | | | | [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | | | | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | | | | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | | | | [pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==) | | | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller
[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #457: Discuss: Remove the priority field under the ApisixRoute resource
gxthrj opened a new issue #457: URL: https://github.com/apache/apisix-ingress-controller/issues/457 ### Issue description When ApisixRoute resources use `exprs` for traffic split, they need to be used with the priority field. It is particularly troublesome when used, and the user has to display the priority to the related rules. In order to make the configuration easy to understand, and there is no need to modify the priority when declaring the configuration, and to further increase the ease of use of ApisixRoute, it is recommended that the routing rules in ApisixRoute (same host + URI) are matched in order from top to bottom in the order of declaration, no longer using the priority field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #344: feature request: increase main contents max width
iamayushdas commented on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842171849 @Yiyiyimu have a look to this and compare https://apisix-website-sidebarfix.netlify.app/docs/apisix/admin-api -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on issue #344: feature request: increase main contents max width
iamayushdas edited a comment on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842171849 @Yiyiyimu have a look to this and compare https://apisix-website-sidebarfix.netlify.app/docs/apisix/admin-api Earlier  now:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on issue #344: feature request: increase main contents max width
iamayushdas edited a comment on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842171849 @Yiyiyimu have a look to this and compare https://apisix-website-sidebarfix.netlify.app/docs/apisix/admin-api Earlier  now:  also while decreasing right side space , not getting the desired result, still trying for right side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
spacewander commented on issue #4258: URL: https://github.com/apache/apisix/issues/4258#issuecomment-842194980 We can pass through the timeout via ctx: https://github.com/apache/apisix/blob/0114c983eecee1a9a9a3f3c13c3b149f9fe7d89f/apisix/balancer.lua#L138-L140 PR is welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1856: chore: refactored test create-edit-delete-plugin-template.spec.js
LiteSun merged pull request #1856: URL: https://github.com/apache/apisix-dashboard/pull/1856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (e1a8dec -> 347fa30)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from e1a8dec chore: refactor test create-edit-duplicate-delete-route.spec.js (#1860) add 347fa30 chore: refactored test create-edit-delete-plugin-template.spec.js (#1856) No new revisions were added by this update. Summary of changes: .../create-edit-delete-plugin-template.spec.js | 69 ++ 1 file changed, 44 insertions(+), 25 deletions(-)
[apisix-dashboard] branch master updated: chore: refactored test create-delete-in-drawer-plugin (#1854)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new ddfecc6 chore: refactored test create-delete-in-drawer-plugin (#1854)
ddfecc6 is described below
commit ddfecc682f2e95ed0aafcf8c46643ff5f75d13d3
Author: Ayush das
AuthorDate: Mon May 17 15:34:50 2021 +0530
chore: refactored test create-delete-in-drawer-plugin (#1854)
---
.../plugin/create-delete-in-drawer-plugin.spec.js | 44 ++
1 file changed, 29 insertions(+), 15 deletions(-)
diff --git
a/web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js
b/web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js
index 0ce3a3b..bcde1e3 100644
--- a/web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js
+++ b/web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js
@@ -19,11 +19,25 @@
context('Delete Plugin List with the Drawer', () => {
const timeout = 5000;
+ const selector = {
+pluginCardBordered: '.ant-card-bordered',
+drawer: '.ant-drawer-content',
+selectDropdown: '.ant-select-dropdown',
+codeMirrorMode: "[data-cy='code-mirror-mode']",
+selectJSON: '.ant-select-dropdown [label=JSON]',
+drawerFooter: '.ant-drawer-footer',
+disabledSwitcher: '#disable',
+checkedSwitcher: '.ant-switch-checked',
+refresh: '.anticon-reload',
+empty: '.ant-empty-normal',
+ }
+
+ const data = {
+basicAuthPlugin: 'basic-auth',
+ }
+
beforeEach(() => {
cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
});
it('should visit plugin market and enable plugin', function () {
@@ -31,41 +45,41 @@ context('Delete Plugin List with the Drawer', () => {
cy.contains('Plugin').click();
cy.contains('Enable').click();
-
cy.contains(this.data.basicAuthPlugin).parents(this.domSelector.pluginCardBordered).within(()
=> {
+
cy.contains(data.basicAuthPlugin).parents(selector.pluginCardBordered).within(()
=> {
cy.get('button').click({
force: true
});
});
-cy.get(this.domSelector.codeMirrorMode).invoke('text').then(text => {
+cy.get(selector.codeMirrorMode).invoke('text').then(text => {
if (text === 'Form') {
-cy.get(this.domSelector.codeMirrorMode).click();
-cy.get(this.domSelector.selectDropdown).should('be.visible');
-cy.get(this.domSelector.selectJSON).click();
+cy.get(selector.codeMirrorMode).click();
+cy.get(selector.selectDropdown).should('be.visible');
+cy.get(selector.selectJSON).click();
}
});
-cy.get(this.domSelector.drawer).should('be.visible').within(() => {
- cy.get(this.domSelector.disabledSwitcher).click();
- cy.get(this.domSelector.checkedSwitcher).should('exist');
+cy.get(selector.drawer).should('be.visible').within(() => {
+ cy.get(selector.disabledSwitcher).click();
+ cy.get(selector.checkedSwitcher).should('exist');
});
cy.contains('button', 'Submit').click();
-cy.get(this.domSelector.drawer, {
+cy.get(selector.drawer, {
timeout
}).should('not.exist');
});
it('should delete the plugin with the drawer', function () {
cy.visit('/plugin/list');
-cy.get(this.domSelector.refresh).click();
+cy.get(selector.refresh).click();
cy.contains('button', 'Configure').click();
-cy.get(this.domSelector.drawerFooter).contains('button', 'Delete').click({
+cy.get(selector.drawerFooter).contains('button', 'Delete').click({
force: true
});
cy.contains('button', 'Confirm').click({
force: true
});
-cy.get(this.domSelector.empty).should('be.visible');
+cy.get(selector.empty).should('be.visible');
});
});
[GitHub] [apisix-dashboard] LiteSun merged pull request #1854: chore: refactored test create-delete-in-drawer-plugin
LiteSun merged pull request #1854: URL: https://github.com/apache/apisix-dashboard/pull/1854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: refactored test switch-langauge.spec.js (#1853)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 4663156 chore: refactored test switch-langauge.spec.js (#1853)
4663156 is described below
commit 466315622d7de1bff3beef9661fcc94689cc2b12
Author: Ayush das
AuthorDate: Mon May 17 15:35:25 2021 +0530
chore: refactored test switch-langauge.spec.js (#1853)
---
web/cypress/integration/lang/switch-language.spec.js | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/web/cypress/integration/lang/switch-language.spec.js
b/web/cypress/integration/lang/switch-language.spec.js
index e93bfef..dfdaf9a 100644
--- a/web/cypress/integration/lang/switch-language.spec.js
+++ b/web/cypress/integration/lang/switch-language.spec.js
@@ -19,23 +19,25 @@
context('Switch language', () => {
const timeout = 1000;
+ const selector = {
+languageSwitcher: '.ant-space-align-center',
+ }
+
beforeEach(() => {
cy.login();
-
-cy.fixture('selector.json').as('domSelector');
});
it('should switch language', function () {
cy.visit('/');
-cy.get(this.domSelector.languageSwitcher).click('right');
+cy.get(selector.languageSwitcher).click('right');
cy.contains('简体中文').click({
force: true,
timeout,
});
cy.contains('服务').click();
-cy.get(this.domSelector.languageSwitcher).click('right');
+cy.get(selector.languageSwitcher).click('right');
cy.contains('English').click({
force: true,
timeout,
[GitHub] [apisix-dashboard] LiteSun merged pull request #1853: chore: refactored test switch-langauge.spec.js
LiteSun merged pull request #1853: URL: https://github.com/apache/apisix-dashboard/pull/1853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1852: chore: refactored test dashboard-smoketest.spec.js
LiteSun merged pull request #1852: URL: https://github.com/apache/apisix-dashboard/pull/1852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (4663156 -> f43785d)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 4663156 chore: refactored test switch-langauge.spec.js (#1853) add f43785d chore: refactored test dashboard-smoketest.spec.js (#1852) No new revisions were added by this update. Summary of changes: web/cypress/integration/dashboard/dashboard-smoketest.spec.js | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)
[apisix-dashboard] branch master updated: chore: refactored test create-with-referer-restriction-form (#1851)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 5e60418 chore: refactored test create-with-referer-restriction-form
(#1851)
5e60418 is described below
commit 5e604183f3dd06747579014b732aa4bbd2167591
Author: Ayush das
AuthorDate: Mon May 17 15:37:06 2021 +0530
chore: refactored test create-with-referer-restriction-form (#1851)
---
.../create-with-referer-restriction-form.spec.js | 51 +-
1 file changed, 31 insertions(+), 20 deletions(-)
diff --git
a/web/cypress/integration/consumer/create-with-referer-restriction-form.spec.js
b/web/cypress/integration/consumer/create-with-referer-restriction-form.spec.js
index 7a43c2e..304b928 100644
---
a/web/cypress/integration/consumer/create-with-referer-restriction-form.spec.js
+++
b/web/cypress/integration/consumer/create-with-referer-restriction-form.spec.js
@@ -17,42 +17,53 @@
/* eslint-disable no-undef */
context('Create and delete Consumer with referer-restriction form ', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
const selector = {
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
whitelist: "#whitelist_0",
bypass_missing: "#bypass_missing",
}
const data = {
+consumerName: 'test_consumer',
+description: 'desc_by_autotest',
+createConsumerSuccess: 'Create Consumer Successfully',
+deleteConsumerSuccess: 'Delete Consumer Successfully',
whitelist: 'yy.com',
}
+ beforeEach(() => {
+cy.login();
+ });
+
it('creates consumer with referer-restriction form', function () {
cy.visit('/');
cy.contains('Consumer').click();
-cy.get(this.domSelector.empty).should('be.visible');
+cy.get(selector.empty).should('be.visible');
cy.contains('Create').click();
// basic information
-cy.get(this.domSelector.username).type(this.data.consumerName);
-cy.get(this.domSelector.description).type(this.data.description);
+cy.get(selector.username).type(data.consumerName);
+cy.get(selector.description).type(data.description);
cy.contains('Next').click();
// config auth plugin
-cy.contains(this.domSelector.pluginCard, 'key-auth').within(() => {
+cy.contains(selector.pluginCard, 'key-auth').within(() => {
cy.contains('Enable').click({
force: true,
});
});
-cy.focused(this.domSelector.drawer).should('exist');
-cy.get(this.domSelector.disabledSwitcher).click();
+cy.focused(selector.drawer).should('exist');
+cy.get(selector.disabledSwitcher).click();
// edit codemirror
-cy.get(this.domSelector.codeMirror)
+cy.get(selector.codeMirror)
.first()
.then((editor) => {
editor[0].CodeMirror.setValue(
@@ -63,34 +74,34 @@ context('Create and delete Consumer with
referer-restriction form ', () => {
cy.contains('button', 'Submit').click();
});
-cy.contains(this.domSelector.pluginCard, 'referer-restriction').within(()
=> {
+cy.contains(selector.pluginCard, 'referer-restriction').within(() => {
cy.contains('Enable').click({
force: true,
});
});
-cy.focused(this.domSelector.drawer).should('exist');
+cy.focused(selector.drawer).should('exist');
// config referer-restriction form
cy.get(selector.whitelist).type(data.whitelist);
cy.get(selector.bypass_missing).click();
-cy.get(this.domSelector.drawer).within(() => {
+cy.get(selector.drawer).within(() => {
cy.contains('Submit').click({
force: true,
});
});
-cy.get(this.domSelector.drawer).should('not.exist');
+cy.get(selector.drawer).should('not.exist');
cy.contains('button', 'Next').click();
cy.contains('button', 'Submit').click();
-cy.get(this.domSelector.notification).should('contain',
this.data.createConsumerSuccess);
+cy.get(selector.notification).should('contain',
data.createConsumerSuccess);
});
it('delete the consumer', function () {
cy.visit('/consumer/list');
-
cy.contains(this.data.consumerName).should('be.visible').siblings().contains('Delete').click();
+
cy.contains(data.consumerName).should('be.visible').siblings().contains('Delete').click();
cy.contains('button', 'Confirm').click();
-cy.get(this.domSelector.notification).should('contain',
this.data.deleteConsumerSuccess);
+cy.get(selector.notification).should('contain',
data.deleteConsumerSuccess);
});
});
[GitHub] [apisix-dashboard] LiteSun merged pull request #1851: chore: refactored test create-with-referer-restriction-form
LiteSun merged pull request #1851: URL: https://github.com/apache/apisix-dashboard/pull/1851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: refactored test create-upstream-with-limit-request-form (#1849)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new a6e5e7e chore: refactored test
create-upstream-with-limit-request-form (#1849)
a6e5e7e is described below
commit a6e5e7e60c392d03840494ea36ec5bd39f906484
Author: Ayush das
AuthorDate: Mon May 17 15:38:44 2021 +0530
chore: refactored test create-upstream-with-limit-request-form (#1849)
---
.../create-upstream-with-limit-req-form.spec.js| 61 +-
1 file changed, 36 insertions(+), 25 deletions(-)
diff --git
a/web/cypress/integration/consumer/create-upstream-with-limit-req-form.spec.js
b/web/cypress/integration/consumer/create-upstream-with-limit-req-form.spec.js
index 51b806f..1e375ef 100644
---
a/web/cypress/integration/consumer/create-upstream-with-limit-req-form.spec.js
+++
b/web/cypress/integration/consumer/create-upstream-with-limit-req-form.spec.js
@@ -17,42 +17,53 @@
/* eslint-disable no-undef */
context('Create and Delete Consumer', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
const selector = {
-rate: "#rate",
-burst: "#burst",
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
+rate: '#rate',
+burst: '#burst',
key: '#key',
-remote_addr: "[title=remote_addr]"
+remote_addr: '[title=remote_addr]'
}
const data = {
+consumerName: 'test_consumer',
+description: 'desc_by_autotest',
+createConsumerSuccess: 'Create Consumer Successfully',
+deleteConsumerSuccess: 'Delete Consumer Successfully',
time: 2,
}
+ beforeEach(() => {
+cy.login();
+ });
+
it('creates consumer with limit-req form', function () {
cy.visit('/');
cy.contains('Consumer').click();
-cy.get(this.domSelector.empty).should('be.visible');
+cy.get(selector.empty).should('be.visible');
cy.contains('Create').click();
// basic information
-cy.get(this.domSelector.username).type(this.data.consumerName);
-cy.get(this.domSelector.description).type(this.data.description);
+cy.get(selector.username).type(data.consumerName);
+cy.get(selector.description).type(data.description);
cy.contains('Next').click();
// config auth plugin
-cy.contains(this.domSelector.pluginCard, 'key-auth').within(() => {
+cy.contains(selector.pluginCard, 'key-auth').within(() => {
cy.contains('Enable').click({ force: true });
});
-cy.focused(this.domSelector.drawer).should('exist');
-cy.get(this.domSelector.disabledSwitcher).click().should('have.class',
'ant-switch-checked');
+cy.focused(selector.drawer).should('exist');
+cy.get(selector.disabledSwitcher).click().should('have.class',
'ant-switch-checked');
// edit codemirror
-cy.get(this.domSelector.codeMirror)
+cy.get(selector.codeMirror)
.first()
.then((editor) => {
editor[0].CodeMirror.setValue(
@@ -63,41 +74,41 @@ context('Create and Delete Consumer', () => {
cy.contains('button', 'Submit').click();
});
-cy.contains(this.domSelector.pluginCard, 'limit-req').within(() => {
+cy.contains(selector.pluginCard, 'limit-req').within(() => {
cy.contains('Enable').click({
force: true,
});
});
-cy.get(this.domSelector.drawer).should('be.visible');
+cy.get(selector.drawer).should('be.visible');
// config proxy-mirror form
-cy.get(this.domSelector.drawer).within(() => {
+cy.get(selector.drawer).within(() => {
cy.contains('Submit').click({
force: true,
});
});
-cy.get(this.domSelector.notification).should('contain', 'Invalid plugin
data');
+cy.get(selector.notification).should('contain', 'Invalid plugin data');
cy.get(selector.rate).type(data.time);
cy.get(selector.burst).type(data.time);
cy.get(selector.key).click();
cy.get(selector.remote_addr).click();
-cy.get(this.domSelector.drawer).within(() => {
+cy.get(selector.drawer).within(() => {
cy.contains('Submit').click({
force: true,
});
});
-cy.get(this.domSelector.drawer).should('not.exist');
+cy.get(selector.drawer).should('not.exist');
cy.contains('button', 'Next').click();
cy.contains('button', 'Submit').click();
-cy.get(this.domSelector.notification).should('contain',
this.data.createConsumerSuccess);
+cy.get(selector.notification).should('contain',
data.createConsumerSuccess);
});
it('delete the consumer', function () {
[GitHub] [apisix-dashboard] LiteSun merged pull request #1849: chore: refactored test create-upstream-with-limit-request-form
LiteSun merged pull request #1849: URL: https://github.com/apache/apisix-dashboard/pull/1849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gxthrj commented on issue #4254: request help: introspection address somehow changed..
gxthrj commented on issue #4254: URL: https://github.com/apache/apisix/issues/4254#issuecomment-842198496 I think the IP 172.20.7.243 is one of the IP of `dev01` pods. Is it right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: refactored test create-upstream-with-cors-form (#1848)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 59d6f73 chore: refactored test create-upstream-with-cors-form (#1848)
59d6f73 is described below
commit 59d6f73dc428bf80e3001211d5e0b7679cb7897c
Author: Ayush das
AuthorDate: Mon May 17 15:39:31 2021 +0530
chore: refactored test create-upstream-with-cors-form (#1848)
---
.../create-upstream-with-cors-form.spec.js | 68 +-
1 file changed, 42 insertions(+), 26 deletions(-)
diff --git
a/web/cypress/integration/consumer/create-upstream-with-cors-form.spec.js
b/web/cypress/integration/consumer/create-upstream-with-cors-form.spec.js
index 9afa316..f6450a0 100644
--- a/web/cypress/integration/consumer/create-upstream-with-cors-form.spec.js
+++ b/web/cypress/integration/consumer/create-upstream-with-cors-form.spec.js
@@ -17,42 +17,58 @@
/* eslint-disable no-undef */
context('Create and Delete Consumer', () => {
- beforeEach(() => {
-cy.login();
-
-cy.fixture('selector.json').as('domSelector');
-cy.fixture('data.json').as('data');
- });
const selector = {
-max_age: "#max_age",
-allow_origins_by_regex: "#allow_origins_by_regex_0"
+empty:'.ant-empty-normal',
+username: '#username',
+description: '#desc',
+pluginCard: '.ant-card',
+drawer: '.ant-drawer-content',
+dropdown: '.rc-virtual-list',
+disabledSwitcher: '#disable',
+codeMirror: '.CodeMirror',
+notification: '.ant-notification-notice-message',
+notificationCloseIcon: '.ant-notification-close-icon',
+rate: '#rate',
+burst: '#burst',
+key: '#key',
+remote_addr: '[title=remote_addr]',
+max_age: '#max_age',
+allow_origins_by_regex: '#allow_origins_by_regex_0'
}
const data = {
+consumerName: 'test_consumer',
+description: 'desc_by_autotest',
+createConsumerSuccess: 'Create Consumer Successfully',
+deleteConsumerSuccess: 'Delete Consumer Successfully',
time: 2,
}
+ beforeEach(() => {
+cy.login();
+ });
+
it('creates consumer with cors form', function () {
cy.visit('/');
cy.contains('Consumer').click();
-cy.get(this.domSelector.empty).should('be.visible');
+cy.get(selector.empty).should('be.visible');
cy.contains('Create').click();
// basic information
-cy.get(this.domSelector.username).type(this.data.consumerName);
-cy.get(this.domSelector.description).type(this.data.description);
+cy.get(selector.username).type(data.consumerName);
+cy.get(selector.description).type(data.description);
cy.contains('Next').click();
// config auth plugin
-cy.contains(this.domSelector.pluginCard, 'key-auth').within(() => {
+cy.contains(selector.pluginCard, 'key-auth').within(() => {
cy.contains('Enable').click({
force: true
});
});
-cy.focused(this.domSelector.drawer).should('exist');
-cy.get(this.domSelector.disabledSwitcher).click().should('have.class',
'ant-switch-checked');
+cy.focused(selector.drawer).should('exist');
+cy.get(selector.disabledSwitcher).click().should('have.class',
'ant-switch-checked');
// edit codemirror
-cy.get(this.domSelector.codeMirror)
+cy.get(selector.codeMirror)
.first()
.then((editor) => {
editor[0].CodeMirror.setValue(
@@ -63,43 +79,43 @@ context('Create and Delete Consumer', () => {
cy.contains('button', 'Submit').click();
});
-cy.contains(this.domSelector.pluginCard, 'cors').within(() => {
+cy.contains(selector.pluginCard, 'cors').within(() => {
cy.contains('Enable').click({
force: true,
});
});
-cy.get(this.domSelector.drawer).should('be.visible');
+cy.get(selector.drawer).should('be.visible');
cy.get(selector.max_age).clear();
// config cors form
-cy.get(this.domSelector.drawer).within(() => {
+cy.get(selector.drawer).within(() => {
cy.contains('Submit').click({
force: true,
});
});
-cy.get(this.domSelector.notification).should('contain', 'Invalid plugin
data');
-cy.get(this.domSelector.notificationCloseIcon).click().should('not.exist');
+cy.get(selector.notification).should('contain', 'Invalid plugin data');
+cy.get(selector.notificationCloseIcon).click().should('not.exist');
cy.get(selector.max_age).type(data.time);
cy.get(selector.allow_origins_by_regex).type('.*.test.com');
-cy.get(this.domSelector.drawer).within(() => {
+cy.get(selector.drawer).within(() => {
cy.contains('Submit').click({
force: true,
});
});
-cy.get(this.domSelector.drawer).should('not.exist');
+cy.get(selector.drawer).should('not.exist');
cy.contains('button', 'Next').click();
cy.contains('button', 'Submit').clic
[GitHub] [apisix-dashboard] LiteSun merged pull request #1848: chore: refactored test create-upstream-with-cors-form
LiteSun merged pull request #1848: URL: https://github.com/apache/apisix-dashboard/pull/1848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel opened a new pull request #458: Optimize log message when the endpoint does not have a corresponding service
lingsamuel opened a new pull request #458: URL: https://github.com/apache/apisix-ingress-controller/pull/458 - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Some endpoints doesn't have corresponding services, currently endpoint controller will log massive warning continuously -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #458: Optimize log message when the endpoint does not have a corresponding service
lingsamuel commented on pull request #458: URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842202203 @tokers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (59d6f73 -> 085be97)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 59d6f73 chore: refactored test create-upstream-with-cors-form (#1848) add 085be97 ci: fix gitleaks not allowed running (#1897) No new revisions were added by this update. Summary of changes: .github/actions/gitleaks-action | 1 + .github/workflows/gitleaks.yml | 9 + .gitmodules | 3 +++ 3 files changed, 9 insertions(+), 4 deletions(-) create mode 16 .github/actions/gitleaks-action
[GitHub] [apisix-dashboard] LiteSun closed issue #1817: fix GitLeaks Action and make it working
LiteSun closed issue #1817: URL: https://github.com/apache/apisix-dashboard/issues/1817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1897: ci: fix gitleaks not allowed running
LiteSun merged pull request #1897: URL: https://github.com/apache/apisix-dashboard/pull/1897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] dependabot[bot] commented on pull request #1890: chore(deps): bump actions/checkout from 2 to 2.3.4
dependabot[bot] commented on pull request #1890: URL: https://github.com/apache/apisix-dashboard/pull/1890#issuecomment-842203839 Looks like actions/checkout is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] dependabot[bot] closed pull request #1890: chore(deps): bump actions/checkout from 2 to 2.3.4
dependabot[bot] closed pull request #1890: URL: https://github.com/apache/apisix-dashboard/pull/1890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new pull request #4261: feat: support the configuration of keepalive related parameters in upstream
Firstsawyou opened a new pull request #4261: URL: https://github.com/apache/apisix/pull/4261 ### What this PR does / why we need it: Signed-off-by: Firstsawyou yuelin...@gmail.com close #3760 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng commented on issue #4254: request help: introspection address somehow changed..
Marco-Zheng commented on issue #4254: URL: https://github.com/apache/apisix/issues/4254#issuecomment-842232952 > 172.20.7.243 @gxthrj yes，`172.20.253.6` is cluster ip, `172.20.7.243` is node ip, but `172.20.7.236` is a strange ip address.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng commented on issue #4254: request help: introspection address somehow changed..
Marco-Zheng commented on issue #4254: URL: https://github.com/apache/apisix/issues/4254#issuecomment-842234593 > @Marco-Zheng Have you ever checked the DNS resolvers used by APISIX container? Yeap, i didn't find any problem with DNS resolvers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on issue #344: feature request: increase main contents max width
1502shivam-singh commented on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842295401 > now: >  > > also while decreasing right side space , not getting the desired result, still trying for right side Hey @iamayushdas. I guess what @Yiyiyimu is talking about is increasing the overall width of the main content on this page and elsewhere where there are tables, as in using a small part of the unused space on the right (or left, keeping proportions) to increase the overall width of the table for not so congested text in the table fields. My recommendation would be to try to use some space from the right side (or left), to increase the width of the table and relieve the congestion when sidebar is closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on issue #344: feature request: increase main contents max width
1502shivam-singh commented on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842300203 Also, something I noticed @Yiyiyimu, the margin from the left in your provided shot, is way more than on my system (Just thinking, maybe I have a small screen 😅). Have you zoomed out in your browser ? maybe check that. >  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4260: feat: avoid overriding customized X-Forwarded-Proto header
spacewander commented on pull request #4260: URL: https://github.com/apache/apisix/pull/4260#issuecomment-842305542 I think we can wait for people's requirement. It is rare to override them instead of setting the value according to the request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #4246: docs: add instruction about how to add systemd unit files
starsz commented on a change in pull request #4246: URL: https://github.com/apache/apisix/pull/4246#discussion_r633510621 ## File path: docs/en/latest/how-to-build.md ## @@ -167,3 +167,15 @@ Content-Type: text/html Some features require you to build OpenResty with extra Nginx modules. If you need those features, you can build OpenResty with [this build script](https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-openresty.sh). + +## 7. Add systemd unit file for APISIX + +If you install APISIX with rpm package, the unit file is installed automatically, and you could directly do + +``` +$ systemctl start apisix +$ systemctl stop apisix +$ systemctl enable apisix +``` + +If installed in other methods, you could refer to [the unit file template](https://github.com/api7/apisix-build-tools/blob/master/usr/lib/systemd/system/apisix.service), modify if needed, and place it as `usr/lib/systemd/system/apisix.service`. Review comment: Installed in other methods, maybe don't have `apisix.service` in the file system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #457: Discuss: Remove the priority field under the ApisixRoute resource
tokers commented on issue #457: URL: https://github.com/apache/apisix-ingress-controller/issues/457#issuecomment-842317749 +1, agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #458: chore: optimize log message when the endpoint does not have a corresponding service
codecov-commenter commented on pull request #458: URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842319124 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#458](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d44af1) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5d479ae148d2acdb51082bb0f129548fdfa146b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d479ae) will **increase** coverage by `0.40%`. > The diff coverage is `0.00%`. > :exclamation: Current head 5d44af1 differs from pull request most recent head 4f6a04c. Consider uploading reports for the commit 4f6a04c to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #458 +/- ## == + Coverage 37.04% 37.44% +0.40% == Files 47 46 -1 Lines3841 3840 -1 == + Hits 1423 1438 +15 + Misses 2233 2219 -14 + Partials 185 183 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <0.00%> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `35.29% <0.00%> (+2.20%)` | :arrow_up: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `32.61% <0.00%> (+5.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4a55307...4f6a04c](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific
[apisix] branch master updated: feat: avoid overriding customized X-Forwarded-Proto header (#4260)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 5d58dac feat: avoid overriding customized X-Forwarded-Proto header
(#4260)
5d58dac is described below
commit 5d58dacaa8d279ae9ec6e061800b771b8a49e5e1
Author: 罗泽轩
AuthorDate: Mon May 17 21:23:56 2021 +0800
feat: avoid overriding customized X-Forwarded-Proto header (#4260)
Close #4252
Signed-off-by: spacewander
---
apisix/cli/ngx_tpl.lua| 3 --
apisix/core/ctx.lua | 2 ++
apisix/init.lua | 12 +++-
t/APISIX.pm | 25 +
t/lib/server.lua | 11 +++-
t/plugin/proxy-rewrite2.t | 71 +++
6 files changed, 119 insertions(+), 5 deletions(-)
diff --git a/apisix/cli/ngx_tpl.lua b/apisix/cli/ngx_tpl.lua
index d0c3b32..99cde87 100644
--- a/apisix/cli/ngx_tpl.lua
+++ b/apisix/cli/ngx_tpl.lua
@@ -531,9 +531,6 @@ http {
if ($http_x_forwarded_for != "") {
set $var_x_forwarded_for "${http_x_forwarded_for},
${realip_remote_addr}";
}
-if ($http_x_forwarded_proto != "") {
-set $var_x_forwarded_proto $http_x_forwarded_proto;
-}
if ($http_x_forwarded_host != "") {
set $var_x_forwarded_host $http_x_forwarded_host;
}
diff --git a/apisix/core/ctx.lua b/apisix/core/ctx.lua
index 5373942..4018180 100644
--- a/apisix/core/ctx.lua
+++ b/apisix/core/ctx.lua
@@ -128,6 +128,8 @@ do
upstream_no_cache = true,
upstream_cache_key = true,
upstream_cache_bypass = true,
+
+var_x_forwarded_proto = true,
}
local mt = {
diff --git a/apisix/init.lua b/apisix/init.lua
index 3185b63..3c395ee 100644
--- a/apisix/init.lua
+++ b/apisix/init.lua
@@ -251,6 +251,16 @@ local function set_upstream_host(api_ctx, picked_server)
end
+local function set_upstream_headers(api_ctx, picked_server)
+set_upstream_host(api_ctx, picked_server)
+
+local hdr = core.request.header(api_ctx, "X-Forwarded-Proto")
+if hdr then
+api_ctx.var.var_x_forwarded_proto = hdr
+end
+end
+
+
local function get_upstream_by_id(up_id)
local upstreams = core.config.fetch_created_obj("/upstreams")
if upstreams then
@@ -474,7 +484,7 @@ function _M.http_access_phase()
api_ctx.picked_server = server
-set_upstream_host(api_ctx, server)
+set_upstream_headers(api_ctx, server)
ngx_var.ctx_ref = ctxdump.stash_ngx_ctx()
local up_scheme = api_ctx.upstream_scheme
diff --git a/t/APISIX.pm b/t/APISIX.pm
index 388ade9..3bd44b3 100644
--- a/t/APISIX.pm
+++ b/t/APISIX.pm
@@ -377,6 +377,8 @@ _EOC_
error_page 500 \@50x.html;
+variables_hash_bucket_size 128;
+
upstream apisix_backend {
server 0.0.0.1;
balancer_by_lua_block {
@@ -583,6 +585,29 @@ _EOC_
proxy_set_header Connection\$upstream_connection;
proxy_set_header X-Real-IP \$remote_addr;
proxy_pass_header Date;
+
+### the following x-forwarded-* headers is to send to upstream
server
+
+set \$var_x_forwarded_for\$remote_addr;
+set \$var_x_forwarded_proto \$scheme;
+set \$var_x_forwarded_host \$host;
+set \$var_x_forwarded_port \$server_port;
+
+if (\$http_x_forwarded_for != "") {
+set \$var_x_forwarded_for "\${http_x_forwarded_for},
\${realip_remote_addr}";
+}
+if (\$http_x_forwarded_host != "") {
+set \$var_x_forwarded_host \$http_x_forwarded_host;
+}
+if (\$http_x_forwarded_port != "") {
+set \$var_x_forwarded_port \$http_x_forwarded_port;
+}
+
+proxy_set_header X-Forwarded-For \$var_x_forwarded_for;
+proxy_set_header X-Forwarded-Proto\$var_x_forwarded_proto;
+proxy_set_header X-Forwarded-Host \$var_x_forwarded_host;
+proxy_set_header X-Forwarded-Port \$var_x_forwarded_port;
+
proxy_pass
\$upstream_scheme://apisix_backend\$upstream_uri;
mirror /proxy_mirror;
diff --git a/t/lib/server.lua b/t/lib/server.lua
index 984886e..149ed4b 100644
--- a/t/lib/server.lua
+++ b/t/lib/server.lua
@@ -134,6 +134,13 @@ function _M.ewma()
end
+local builtin_hdr_ignore_list = {
+["x-forwarded-for"] = true,
+["x-forwarded-proto"] = true,
+["x-forwarded-host"] = true,
+["x-forwarded-port"] = true,
+}
+
function _M.uri()
-- ngx.sleep(1)
ngx.say("uri: ", ngx.var.uri)
@@ -141,7 +148,9 @@ function _M.uri()
local keys = {}
for k in pairs(headers) do
-table.insert(keys, k)
[GitHub] [apisix] tokers merged pull request #4260: feat: avoid overriding customized X-Forwarded-Proto header
tokers merged pull request #4260: URL: https://github.com/apache/apisix/pull/4260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers closed issue #4252: bug: The proxy-rewrite plugin can't rewrite "X-Forwarded-Proto" header
tokers closed issue #4252: URL: https://github.com/apache/apisix/issues/4252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou edited a comment on issue #4254: request help: introspection address somehow changed..
Firstsawyou edited a comment on issue #4254: URL: https://github.com/apache/apisix/issues/4254#issuecomment-841828257 @gxthrj @tokers Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #344: feature request: increase main contents max width
iamayushdas commented on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842344551 But their is something bad bad, that it has same configuration as docusaurus but, Many of its configs are not properly working in our website, like collapsing sidebar is not smooth, page slides up a bit while toggling sidebar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4262: chore: add missing PHONY marks
spacewander opened a new pull request #4262: URL: https://github.com/apache/apisix/pull/4262 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat: support uri encoding in redirect (#4244)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new b0cae10 feat: support uri encoding in redirect (#4244)
b0cae10 is described below
commit b0cae100d2a8c42b023836799265a63cebb1876a
Author: Gary-Airwallex
AuthorDate: Mon May 17 22:42:16 2021 +0800
feat: support uri encoding in redirect (#4244)
---
apisix/plugins/redirect.lua| 37 +++
docs/en/latest/plugins/redirect.md | 3 +-
docs/zh/latest/plugins/redirect.md | 3 +-
t/plugin/redirect.t| 97 ++
4 files changed, 129 insertions(+), 11 deletions(-)
diff --git a/apisix/plugins/redirect.lua b/apisix/plugins/redirect.lua
index 40db3e0..c2c2aec 100644
--- a/apisix/plugins/redirect.lua
+++ b/apisix/plugins/redirect.lua
@@ -22,6 +22,8 @@ local re_gmatch = ngx.re.gmatch
local re_sub = ngx.re.sub
local ipairs = ipairs
local ngx = ngx
+local str_find = core.string.find
+local str_sub = string.sub
local lrucache = core.lrucache.new({
ttl = 300, count = 100
@@ -49,6 +51,7 @@ local schema = {
}
},
http_to_https = {type = "boolean"},
+encode_uri = {type = "boolean", default = false}
},
oneOf = {
{required = {"uri"}},
@@ -160,18 +163,18 @@ function _M.rewrite(conf, ctx)
end
if ret_code then
+local new_uri
if uri then
-local new_uri, err = concat_new_uri(uri, ctx)
+local err
+new_uri, err = concat_new_uri(uri, ctx)
if not new_uri then
core.log.error("failed to generate new uri by: " .. uri .. err)
return 500
end
-
-core.response.set_header("Location", new_uri)
-return ret_code
elseif regex_uri then
-local new_uri, n, err = re_sub(ctx.var.uri, regex_uri[1],
- regex_uri[2], "jo")
+local n, err
+new_uri, n, err = re_sub(ctx.var.uri, regex_uri[1],
+ regex_uri[2], "jo")
if not new_uri then
local msg = string_format("failed to substitute the uri:%s
(%s) with %s, error:%s",
ctx.var.uri, regex_uri[1],
regex_uri[2], err)
@@ -179,11 +182,27 @@ function _M.rewrite(conf, ctx)
return 500
end
-if n > 0 then
-core.response.set_header("Location", new_uri)
-return ret_code
+if n < 1 then
+return
end
end
+
+if not new_uri then
+return
+end
+
+if conf.encode_uri then
+local index = str_find(new_uri, "?")
+if index then
+new_uri = core.utils.uri_safe_encode(str_sub(new_uri, 1,
index-1)) ..
+ str_sub(new_uri, index)
+else
+new_uri = core.utils.uri_safe_encode(new_uri)
+end
+end
+
+core.response.set_header("Location", new_uri)
+return ret_code
end
end
diff --git a/docs/en/latest/plugins/redirect.md
b/docs/en/latest/plugins/redirect.md
index 4652f26..9ce47bc 100644
--- a/docs/en/latest/plugins/redirect.md
+++ b/docs/en/latest/plugins/redirect.md
@@ -41,8 +41,9 @@ URI redirect.
| uri | string | optional| | | New URL which can
contain Nginx variable, eg: `/test/index.html`, `$uri/index.html`. You can
refer to variables in a way similar to `${xxx}` to avoid ambiguity, eg:
`${uri}foo/index.html`. If you just need the original `$` character, add `\` in
front of it, like this one: `/\$foo/index.html`. If you refer to a variable
name that does not exist, this will not produce an error, and it will be used
as an empty string. |
| regex_uri | array[string] | optional| | | Use
regular expression to match URL from client, when the match is successful, the
URL template will be redirected to. If the match is not successful, the URL
from the client will be forwarded to the upstream. Only one of `uri` and
`regex_uri` can be exist. For example: [" ^/iresty/(.*)/(.*)/(.*)",
"/$1-$2-$3"], the first element represents the matching regular expression and
the second element represents the URL t [...]
| ret_code | integer | optional| 302 | [200, ...] | Response
code
[GitHub] [apisix] spacewander merged pull request #4244: feat: support uri encoding in redirect
spacewander merged pull request #4244: URL: https://github.com/apache/apisix/pull/4244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1902: feat: separate entry in a simple function
netlify[bot] commented on pull request #1902: URL: https://github.com/apache/apisix-dashboard/pull/1902#issuecomment-842413279 Deploy preview for *apisix-dashboard* processing. Building with commit b1cbf344ae27dcbf382ae64cdf0e3b800cedd763 https://app.netlify.com/sites/apisix-dashboard/deploys/60a28a05e77ab400078d6602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] fregie opened a new pull request #1902: feat: separate entry in a simple function
fregie opened a new pull request #1902: URL: https://github.com/apache/apisix-dashboard/pull/1902 **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **Related issues** resolve #1840 ## Hi everyone :wave: About the issue related #1840 ,I have a idea.Maybe this is not a good idea,but I like it!Check it out: I add a `main.go` at the root directory,and only a main function in this file,this function do all things must be done,include init and serve.This means you can find everything at the root directory,in this single file and in this single function,this is really simple and easy to read.You can pay all your attention to the logic of the service and don't need to worry about managing the service.It just a executable file and serve,you don’t need to understand what it does on your system to run,easier for users to understand. I know this does not conform to the _standard go project layout_,but I don't think that's important. We can also keep the entry in `cmd`,users can chose the simple version of `main.go` or the version include service mangement in `cmd`.And users can also manage the service by themselves with the simple version,like `supervisor`. I haven't done all the jobs,I just want to hear your opinions first. @starsz @nic-chen @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on issue #344: feature request: increase main contents max width
1502shivam-singh commented on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842419380 > But their is something bad bad, that it has same configuration as docusaurus but, > Many of its configs are not properly working in our website, like collapsing sidebar is not smooth, page slides up a bit while toggling sidebar. Yes, I saw another issue related to scroll snapping. Try solving this one first, we will look into those later maybe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1902: feat: separate entry in a simple function
netlify[bot] edited a comment on pull request #1902: URL: https://github.com/apache/apisix-dashboard/pull/1902#issuecomment-842413279 Deploy preview for *apisix-dashboard* ready! Built with commit b1cbf344ae27dcbf382ae64cdf0e3b800cedd763 https://deploy-preview-1902--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #344: feature request: increase main contents max width
iamayushdas commented on issue #344: URL: https://github.com/apache/apisix-website/issues/344#issuecomment-842420240 Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yxudong commented on issue #4259: docs: Improve the plugin name in the response-rewrite plugin docs
yxudong commented on issue #4259: URL: https://github.com/apache/apisix/issues/4259#issuecomment-842423358 Hi , i would like to work on this issue. Please assign me this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yxudong opened a new pull request #4263: fixed response-rewrite plugin docs type error
yxudong opened a new pull request #4263: URL: https://github.com/apache/apisix/pull/4263 ### What this PR does / why we need it: [https://github.com/apache/apisix/issues/4259](https://github.com/apache/apisix/issues/4259) ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on issue #288: bug: hidableSidebar does not behave correctly
1502shivam-singh commented on issue #288: URL: https://github.com/apache/apisix-website/issues/288#issuecomment-842435418 @juzhiyuan @Yiyiyimu It seems this issue is solved now. Don't see any jerks or snapping no more on my system. Least that can be done now is to hide the x-scroll bar when sidebar is out, so the text doesn't block. If you feel this is good, I will submit a PR for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #4261: feat: support the configuration of keepalive related parameters in upstream
Firstsawyou commented on pull request #4261: URL: https://github.com/apache/apisix/pull/4261#issuecomment-842484691 > Need to add test in https://github.com/apache/apisix/blob/master/t/cli/test_main.sh Added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4259: docs: Improve the plugin name in the response-rewrite plugin docs
Firstsawyou commented on issue #4259: URL: https://github.com/apache/apisix/issues/4259#issuecomment-842486570 PR is welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #459: docs: fix APISIX helm installation
tao12345666333 opened a new pull request #459: URL: https://github.com/apache/apisix-ingress-controller/pull/459 This change was introduced from https://github.com/apache/apisix-helm-chart/pull/74 Signed-off-by: Jintao Zhang Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #459: docs: fix APISIX helm installation
codecov-commenter commented on pull request #459: URL: https://github.com/apache/apisix-ingress-controller/pull/459#issuecomment-842490054 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#459](https://codecov.io/gh/apache/apisix-ingress-controller/pull/459?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56aefa5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5d479ae148d2acdb51082bb0f129548fdfa146b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d479ae) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #459 +/- ## == - Coverage 37.04% 37.03% -0.02% == Files 47 46 -1 Lines3841 3840 -1 == - Hits 1423 1422 -1 Misses 2233 2233 Partials 185 185 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/459?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/459?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4a55307...56aefa5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/459?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new issue #78: bug: RBAC insufficient permissions
tao12345666333 opened a new issue #78: URL: https://github.com/apache/apisix-helm-chart/issues/78 ``` Failed to watch *v2alpha1.ApisixClusterConfig: failed to list *v2alpha1.ApisixClusterConfig: apisixclusterconfigs.apisix.apache.org is forbidden: User "system:serviceaccount:apisix:apisix-ingress-controller" cannot list resource "apisixclusterconfigs" in API group "apisix.apache.org" at the cluster sco ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #79: chore: fix RBAC permissions
tao12345666333 opened a new pull request #79: URL: https://github.com/apache/apisix-helm-chart/pull/79 fixes #78 fix RBAC permissions according to https://github.com/apache/apisix-ingress-controller/pull/452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4258: discuss: Allow to set custom timeout for route when route belongs to service or upstream
spacewander commented on issue #4258: URL: https://github.com/apache/apisix/issues/4258#issuecomment-841812860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1788: feat: embed assets in api binary
bisakhmondal commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-841787048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1899: fix: invalid import issues
netlify[bot] commented on pull request #1899: URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841827057 Deploy preview for *apisix-dashboard* processing. Building with commit 2bd58fe1c4bdee2f73c7d107e9be13722d8c20c8 https://app.netlify.com/sites/apisix-dashboard/deploys/60a12fa607855700084db29d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1821: I want to edit the Id when creating the upstream、route and service
starsz commented on issue #1821: URL: https://github.com/apache/apisix-dashboard/issues/1821#issuecomment-841796592 I will close this ISSUE. If there is a problem, you can reopen it @cverdela. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1774: improve Testcases
iamayushdas commented on issue #1774: URL: https://github.com/apache/apisix-dashboard/issues/1774#issuecomment-841813090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1818: feat: support more judgment conditions for plugin orchestration
starsz commented on issue #1818: URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-841796507 ping @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1894: fix: restrict host and path of debugging URL
starsz commented on a change in pull request #1894:
URL: https://github.com/apache/apisix-dashboard/pull/1894#discussion_r633070535
##
File path: api/internal/handler/route_online_debug/route_online_debug.go
##
@@ -92,12 +108,60 @@ func (h *Handler) DebugRequestForwarding(c
droplet.Context) (interface{}, error)
type HTTPProtocolSupport struct {
}
+func checkHost(host string) error {
+ if len(conf.Gateways) < 1 {
+ return errors.New("host list of APISIX gateways not configured")
+ }
+ for _, gatewayHost := range conf.Gateways {
+ if host == gatewayHost {
+ return nil
+ }
+ }
Review comment:
Move the `inArray` in `ssl.go` to `utils.go` and use it.
##
File path: api/internal/handler/tool/tool.go
##
@@ -109,3 +111,7 @@ func (h *Handler) VersionMatch(c droplet.Context)
(interface{}, error) {
return &output, nil
}
+
+func (h *Handler) Gateways(_ droplet.Context) (interface{}, error) {
+ return conf.Gateways, nil
Review comment:
Miss e2e test to test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #454: Prepare for General Availability
gxthrj commented on issue #454: URL: https://github.com/apache/apisix-ingress-controller/issues/454#issuecomment-841789363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1882: default connection timeout not equal with nginx?
starsz commented on issue #1882: URL: https://github.com/apache/apisix-dashboard/issues/1882#issuecomment-841796415 Close this issue. If there is a problem, you can reopen it. @oldthreefeng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz merged pull request #1871: chore: refactored test online-debug.spec.js
starsz merged pull request #1871: URL: https://github.com/apache/apisix-dashboard/pull/1871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-841800524 > @nic-chen Something just come up into my mind. Let me know what you think about it. hi, @bisakhmondal , LGTM. But I think it’s better to put it in the `[WorkDir](https://github.com/apache/apisix-dashboard/blob/master/api/cmd/managerapi.go#L91)`, not in a temporary directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1894: fix: restrict host and path of debugging URL
nic-chen commented on pull request #1894: URL: https://github.com/apache/apisix-dashboard/pull/1894#issuecomment-841763932 @liuxiran seems we need to update FE test cases due to the host and path restriction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz closed issue #1882: default connection timeout not equal with nginx?
starsz closed issue #1882: URL: https://github.com/apache/apisix-dashboard/issues/1882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #1894: fix: restrict host and path of debugging URL
gxthrj commented on a change in pull request #1894:
URL: https://github.com/apache/apisix-dashboard/pull/1894#discussion_r633061960
##
File path: api/conf/conf.yaml
##
@@ -59,6 +59,9 @@ conf:
# log example: 2020-12-09T16:38:09.039+0800 INFO
filter/logging.go:46/apisix/admin/routes/r1 {"status": 401, "host":
"127.0.0.1:9000", "query": "asdfsafd=adf&a=a", "requestId":
"3d50ecb8-758c-46d1-af5b-cd9d1c820156", "latency": 0, "remoteIP": "127.0.0.1",
"method": "PUT", "errs": []}
max_cpu: 0 # supports tweaking with the number of OS threads are
going to be used for parallelism. Default value: 0 [will use max number of
available cpu cores considering hyperthreading (if any)]. If the value is
negative, is will not touch the existing parallelism profile.
+ gateways: # host list of APISIX gateway, currently only used as
a list of debuggable hosts
Review comment:
```suggestion
debug_gateways: # host list of APISIX gateway, currently only
used as a list of debuggable hosts
```
##
File path: api/internal/handler/route_online_debug/route_online_debug.go
##
@@ -92,12 +108,60 @@ func (h *Handler) DebugRequestForwarding(c
droplet.Context) (interface{}, error)
type HTTPProtocolSupport struct {
}
+func checkHost(host string) error {
+ if len(conf.Gateways) < 1 {
+ return errors.New("host list of APISIX gateways not configured")
+ }
+ for _, gatewayHost := range conf.Gateways {
+ if host == gatewayHost {
+ return nil
+ }
+ }
+
+ return errors.New("doesn't match any host of APISIX gateways")
+}
+
+func checkPath(path string) error {
+ if strings.HasPrefix(path, "/apisix/") {
+ return errors.New("the path is forbidden for debugging")
Review comment:
```suggestion
return fmt.Errorf(("The path %s is forbidden for debugging",
path)
```
##
File path: api/internal/handler/route_online_debug/route_online_debug.go
##
@@ -92,12 +108,60 @@ func (h *Handler) DebugRequestForwarding(c
droplet.Context) (interface{}, error)
type HTTPProtocolSupport struct {
}
+func checkHost(host string) error {
+ if len(conf.Gateways) < 1 {
+ return errors.New("host list of APISIX gateways not configured")
+ }
+ for _, gatewayHost := range conf.Gateways {
+ if host == gatewayHost {
+ return nil
+ }
+ }
+
+ return errors.New("doesn't match any host of APISIX gateways")
+}
+
+func checkPath(path string) error {
+ if strings.HasPrefix(path, "/apisix/") {
+ return errors.New("the path is forbidden for debugging")
+ }
+ return nil
+}
+
+func checkMethod(method string) error {
+ if exists := allowMethods[strings.ToUpper(method)]; !exists {
+ return errors.New("the method is not allowed for debugging")
Review comment:
```suggestion
return fmt.Errorf("The method %s is not allowed for debugging",
method)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1788: feat: embed assets in api binary
starsz commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-841795464 Hi, @bisakhmondal > it will have another job that is writing the lua package into temporary directory (`os.TempDir()`). I don't get the point of this line, can you give more details about it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
codecov-commenter edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas removed a comment on issue #1774: improve Testcases
iamayushdas removed a comment on issue #1774: URL: https://github.com/apache/apisix-dashboard/issues/1774#issuecomment-841815275 https://github.com/apache/apisix-dashboard/issues/1774#issuecomment-832716932 Can you have a look please, i was doing on purpose, sorry if thats going in that way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
qian0817 commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-841816299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4209: New feature suggestion: request-id plugin supports "snowflake" algorithm
spacewander commented on issue #4209: URL: https://github.com/apache/apisix/issues/4209#issuecomment-841796781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1893: feat: add api of config migrate, export and import
codecov-commenter edited a comment on pull request #1893: URL: https://github.com/apache/apisix-dashboard/pull/1893#issuecomment-840227725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] fregie removed a comment on pull request #1893: feat: add api of config migrate, export and import
fregie removed a comment on pull request #1893: URL: https://github.com/apache/apisix-dashboard/pull/1893#issuecomment-841041600 > Oh, big feature. thanks for contribution. > I think we should want to discuss clearly. > Do you mind sending a proposal to the maillist([d...@apisix.apache.org](mailto:d...@apisix.apache.org)) for discussion first? Thanks. OK,how to join the mailist?I tried to mail to dev-subscr...@apisix.apache.org, but no reply recevied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz closed issue #1821: I want to edit the Id when creating the upstream、route and service
starsz closed issue #1821: URL: https://github.com/apache/apisix-dashboard/issues/1821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #4256: fix: making APISIX compatible on macOS with ARM chip
Yiyiyimu commented on pull request #4256: URL: https://github.com/apache/apisix/pull/4256#issuecomment-841713791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4246: docs: add instruction about how to add systemd unit files
Yiyiyimu commented on a change in pull request #4246: URL: https://github.com/apache/apisix/pull/4246#discussion_r632997089 ## File path: docs/en/latest/how-to-build.md ## @@ -167,3 +167,15 @@ Content-Type: text/html Some features require you to build OpenResty with extra Nginx modules. If you need those features, you can build OpenResty with [this build script](https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-openresty.sh). + +## 7. Add systemd unit file for APISIX + +If you install APISIX with rpm package, the unit file is installed automatically, and you could directly do + +``` +$ systemctl start apisix +$ systemctl stop apisix +$ systemctl enable apisix +``` + +If installed in other methods, you could refer to [the unit file template](https://github.com/api7/apisix-build-tools/blob/master/usr/lib/systemd/system/apisix.service), modify if needed, and place it as `usr/lib/systemd/system/apisix.service`. Review comment: The path would work when PR in api7 merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1898: feat: additional flag to force start manager-api
starsz commented on a change in pull request #1898:
URL: https://github.com/apache/apisix-dashboard/pull/1898#discussion_r633072940
##
File path: api/internal/utils/pid.go
##
@@ -25,9 +25,13 @@ import (
)
// WritePID write pid to the given file path.
-func WritePID(filepath string) error {
- if _, err := os.Stat(filepath); err == nil {
- return fmt.Errorf("instance of Manager API already running: a
pid file exists in %s", filepath)
+func WritePID(filepath string, forceStart bool) error {
+ if pid, err := ReadPID(filepath); err == nil {
+ if !forceStart {
+ return fmt.Errorf("instance of Manager API already
running: a pid file exists in %s", filepath)
+ } else {
+ fmt.Printf("force starting new instance. another
instance of Manager API is already running with pid %d\n", pid)
Review comment:
`is already` => `maybe`
Is this would be better? Since the old manager API maybe is not running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #452: fix: add status subresource permission in clusterRole
tokers merged pull request #452: URL: https://github.com/apache/apisix-ingress-controller/pull/452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1894: fix: restrict host and path of debugging URL
netlify[bot] edited a comment on pull request #1894: URL: https://github.com/apache/apisix-dashboard/pull/1894#issuecomment-841100038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed issue #434: bug: status update is failed
tokers closed issue #434: URL: https://github.com/apache/apisix-ingress-controller/issues/434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1774: improve Testcases
spacewander commented on issue #1774: URL: https://github.com/apache/apisix-dashboard/issues/1774#issuecomment-841812482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on pull request #342: docs: include Helm charts and Docker to documents page
KishaniKandasamy commented on pull request #342: URL: https://github.com/apache/apisix-website/pull/342#issuecomment-841786813 > Hi, Is there anything that need to be changed in this PR? @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1894: fix: restrict host and path of debugging URL
tokers commented on a change in pull request #1894:
URL: https://github.com/apache/apisix-dashboard/pull/1894#discussion_r633060998
##
File path: api/conf/conf.yaml
##
@@ -59,6 +59,9 @@ conf:
# log example: 2020-12-09T16:38:09.039+0800 INFO
filter/logging.go:46/apisix/admin/routes/r1 {"status": 401, "host":
"127.0.0.1:9000", "query": "asdfsafd=adf&a=a", "requestId":
"3d50ecb8-758c-46d1-af5b-cd9d1c820156", "latency": 0, "remoteIP": "127.0.0.1",
"method": "PUT", "errs": []}
max_cpu: 0 # supports tweaking with the number of OS threads are
going to be used for parallelism. Default value: 0 [will use max number of
available cpu cores considering hyperthreading (if any)]. If the value is
negative, is will not touch the existing parallelism profile.
+ gateways: # host list of APISIX gateway, currently only used as
a list of debuggable hosts
Review comment:
Better to add big hints for users to be careful about this field.
##
File path: api/internal/handler/route_online_debug/route_online_debug.go
##
@@ -92,12 +108,60 @@ func (h *Handler) DebugRequestForwarding(c
droplet.Context) (interface{}, error)
type HTTPProtocolSupport struct {
}
+func checkHost(host string) error {
+ if len(conf.Gateways) < 1 {
+ return errors.New("host list of APISIX gateways not configured")
+ }
+ for _, gatewayHost := range conf.Gateways {
+ if host == gatewayHost {
+ return nil
+ }
+ }
+
+ return errors.New("doesn't match any host of APISIX gateways")
Review comment:
```suggestion
return errors.New("host denied")
```
##
File path: api/internal/handler/route_online_debug/route_online_debug.go
##
@@ -92,12 +108,60 @@ func (h *Handler) DebugRequestForwarding(c
droplet.Context) (interface{}, error)
type HTTPProtocolSupport struct {
}
+func checkHost(host string) error {
Review comment:
Return a boolean value is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #434: bug: status update is failed
tokers commented on issue #434: URL: https://github.com/apache/apisix-ingress-controller/issues/434#issuecomment-841788671 Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1894: fix: restrict host and path of debugging URL
codecov-commenter edited a comment on pull request #1894: URL: https://github.com/apache/apisix-dashboard/pull/1894#issuecomment-841541152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dickens7 commented on issue #4209: New feature suggestion: request-id plugin supports "snowflake" algorithm
dickens7 commented on issue #4209: URL: https://github.com/apache/apisix/issues/4209#issuecomment-841789520 > 10 bits for 10 msec is not enough as I proved. Maybe it is faster to change lua-snowflake to support this (only need to change some constants). I will fork lua-snowflake and change it according to this algorithm definition ``` 39 bits saves timestamp, accurate to milliseconds. That means the maximum usable life is 17 years. 14 bits machine bits, can be attached to 16384 machine nodes to generate ID. 10 bits number，the maximum number of unique IDs generated in a millisecond is 1024. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
