[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1923: chore(deps): bump actions/cache from 2.1.4 to 2.1.6
codecov-commenter commented on pull request #1923: URL: https://github.com/apache/apisix-dashboard/pull/1923#issuecomment-850157274 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1923?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1923](https://codecov.io/gh/apache/apisix-dashboard/pull/1923?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (157c9fa) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d11ff4f587438d2854007424ecd436b3b907ad62?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d11ff4f) will **decrease** coverage by `11.67%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1923?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1923 +/- ## === - Coverage 64.13% 52.46% -11.68% === Files 122 38 -84 Lines3112 2680 -432 Branches 7480 -748 === - Hits 1996 1406 -590 + Misses 1116 1086 -30 - Partials0 188 +188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.46% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1923?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1923/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | | | | [web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1923/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==) | | | | [web/src/pages/Setting/Setting.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1923/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL1NldHRpbmcudHN4) | | | | [...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1923/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==) | | | | [web/src/pages/Dashboard/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1923/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvc2VydmljZS50cw==) | | | | [web/src/pages/Upstream/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1923/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [...pages/SSL/components/CertificateUploader/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1923/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZVVwbG9hZGVyL2luZGV4LnRzeA==) | | | | [web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1923/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz) | | | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1923: chore(deps): bump actions/cache from 2.1.4 to 2.1.6
netlify[bot] edited a comment on pull request #1923: URL: https://github.com/apache/apisix-dashboard/pull/1923#issuecomment-850151795 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: 157c9fa2d98e0d3ab7715e8547b640f236690c1d :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60b083d3682cfe00074f477a](https://app.netlify.com/sites/apisix-dashboard/deploys/60b083d3682cfe00074f477a?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-1923--apisix-dashboard.netlify.app/](https://deploy-preview-1923--apisix-dashboard.netlify.app/?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] dependabot[bot] commented on pull request #1892: chore(deps): bump actions/cache from 2.1.4 to 2.1.5
dependabot[bot] commented on pull request #1892: URL: https://github.com/apache/apisix-dashboard/pull/1892#issuecomment-850151765 Superseded by #1923. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] dependabot[bot] closed pull request #1892: chore(deps): bump actions/cache from 2.1.4 to 2.1.5
dependabot[bot] closed pull request #1892: URL: https://github.com/apache/apisix-dashboard/pull/1892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] dependabot[bot] opened a new pull request #1923: chore(deps): bump actions/cache from 2.1.4 to 2.1.6
dependabot[bot] opened a new pull request #1923: URL: https://github.com/apache/apisix-dashboard/pull/1923 Bumps [actions/cache](https://github.com/actions/cache) from 2.1.4 to 2.1.6. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v2.1.6 Catch unhandled bad file descriptor errors that sometimes occurs when the cache server returns non-successful response (https://github-redirect.dependabot.com/actions/cache/pull/596;>actions/cache#596) v2.1.5 Fix permissions error seen when extracting caches with GNU tar that were previously created using BSD tar (https://github-redirect.dependabot.com/actions/cache/issues/527;>actions/cache#527) Commits https://github.com/actions/cache/commit/c64c572235d810460d0d6876e9c705ad5002b353;>c64c572 Catch and log unhandled exceptions stemming from closed file descriptor (https://github-redirect.dependabot.com/actions/cache/issues/596;>#596) https://github.com/actions/cache/commit/cc2d767a726ddd654506e76169ec14b20dc75915;>cc2d767 Update Rust directories recommended for caching (https://github-redirect.dependabot.com/actions/cache/issues/433;>#433) https://github.com/actions/cache/commit/2fa955d825a29821e73ec064792122ea9f70e573;>2fa955d Update examples.md (https://github-redirect.dependabot.com/actions/cache/issues/588;>#588) https://github.com/actions/cache/commit/3a696372f2ec10535e4c026a4fdae5fcca629e4a;>3a69637 elixir typo - stray parenthesis (https://github-redirect.dependabot.com/actions/cache/issues/569;>#569) https://github.com/actions/cache/commit/366e5ba0224e0ebd6fba2a453d108cb20e734946;>366e5ba Update cache key for Elixir (https://github-redirect.dependabot.com/actions/cache/issues/568;>#568) https://github.com/actions/cache/commit/8d3f2fc3ce25d6c95a1297ce8d93f9c3c3ac8f00;>8d3f2fc Update dependencies (https://github-redirect.dependabot.com/actions/cache/issues/565;>#565) https://github.com/actions/cache/commit/1a9e2138d905efd099035b49d8b7a3888c653ca8;>1a9e213 Update cache module to v1.0.7 (https://github-redirect.dependabot.com/actions/cache/issues/562;>#562) https://github.com/actions/cache/commit/981fa981ed950efef5277587ee4ba0eead30cadf;>981fa98 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/469;>#469 from ericmj/patch-1 https://github.com/actions/cache/commit/4498c5b4d8b0673dbc7d9731bc11d9cc5a2c6087;>4498c5b Drop the example based on using pip's internals (https://github-redirect.dependabot.com/actions/cache/issues/519;>#519) https://github.com/actions/cache/commit/4134e6de47156381d31ff74f8aabf86718858f70;>4134e6d It is not recommended to cache node_modules (https://github-redirect.dependabot.com/actions/cache/issues/537;>#537) Additional commits viewable in https://github.com/actions/cache/compare/v2.1.4...v2.1.6;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1923: chore(deps): bump actions/cache from 2.1.4 to 2.1.6
netlify[bot] commented on pull request #1923: URL: https://github.com/apache/apisix-dashboard/pull/1923#issuecomment-850151795 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: 157c9fa2d98e0d3ab7715e8547b640f236690c1d :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60b083d3682cfe00074f477a](https://app.netlify.com/sites/apisix-dashboard/deploys/60b083d3682cfe00074f477a?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch dependabot/github_actions/actions/cache-2.1.6 created (now 157c9fa)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/cache-2.1.6 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 157c9fa chore(deps): bump actions/cache from 2.1.4 to 2.1.6 No new revisions were added by this update.
[GitHub] [apisix] vincentwc commented on issue #4328: request help: 怎么实现自定义路由？
vincentwc commented on issue #4328: URL: https://github.com/apache/apisix/issues/4328#issuecomment-850148515 > @vincentwc So you want to separate all routes into multiple groups and distinguish them by the ETCD key prefix? > Yes > I don't know your real scenario but it's not feasible in APISIX, you have to hack it. Also, if the group is used for management, try the labels feature, you can set labels by using apisix-dashboard. we should has seperate whit different group , i think we should change apisix source code, maybe just change route key could implement it,so i init this issue,but know i don't know how to get param in function _M.get() with routes.lua file. i think could use ngx.ctx to get http request header info and get it at _M.get() function, but now i hava no idea how to implement it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4302: request help: charset config in ngx_tpl.lua
Firstsawyou commented on issue #4302: URL: https://github.com/apache/apisix/issues/4302#issuecomment-850147719 Assigned to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #513: feat: add verify scripts, add verify-codegen CI
codecov-commenter commented on pull request #513: URL: https://github.com/apache/apisix-ingress-controller/pull/513#issuecomment-850147080 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#513](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (13ca7ae) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/a3f58d07a749b4594e460b4645ef77d8d21598fb?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a3f58d0) will **increase** coverage by `0.94%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #513 +/- ## == + Coverage 36.29% 37.23% +0.94% == Files 51 53 +2 Lines4094 4208 +114 == + Hits 1486 1567 +81 - Misses 2406 2434 +28 - Partials 202 207 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <0.00%> (ø)` | | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `51.38% <0.00%> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | | [pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==) | `100.00% <0.00%> (ø)` | | | [pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv) | `28.88% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv) | `73.33% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.20% <0.00%> (+1.20%)` | :arrow_up: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `25.27% <0.00%> (+1.80%)` | :arrow_up: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `35.29% <0.00%> (+2.20%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/513?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #513: feat: add verify scripts, add verify-codegen CI
gxthrj commented on a change in pull request #513:
URL:
https://github.com/apache/apisix-ingress-controller/pull/513#discussion_r641278632
##
File path: pkg/kube/apisix/apis/config/v2alpha1/zz_generated.deepcopy.go
##
@@ -28,6 +28,7 @@ import (
// DeepCopyInto is an autogenerated deepcopy function, copying the receiver,
writing into out. in must be non-nil.
func (in *ApisixClusterAdminConfig) DeepCopyInto(out
*ApisixClusterAdminConfig) {
*out = *in
+ out.ClientTimeout = in.ClientTimeout
Review comment:
Is this line automatically generated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel opened a new pull request #513: feat: add verify scripts, add verify-codegen CI
lingsamuel opened a new pull request #513: URL: https://github.com/apache/apisix-ingress-controller/pull/513 Signed-off-by: Ling Samuel Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### New feature or improvement - Describe the details and related test reports. ```bash make verify-all ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #497: feat: subset translation
codecov-commenter edited a comment on pull request #497: URL: https://github.com/apache/apisix-ingress-controller/pull/497#issuecomment-848440378 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#497](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0919e53) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/cddcd299459cc1a0ad2aee02e611cc88cda64c8e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cddcd29) will **decrease** coverage by `0.45%`. > The diff coverage is `16.21%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #497 +/- ## == - Coverage 37.25% 36.79% -0.46% == Files 54 53 -1 Lines4209 4237 +28 == - Hits 1568 1559 -9 - Misses 2434 2466 +32 - Partials 207 212 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `47.19% <4.76%> (-13.68%)` | :arrow_down: | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `45.67% <10.00%> (-5.71%)` | :arrow_down: | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `42.71% <33.33%> (ø)` | | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `87.33% <100.00%> (ø)` | | | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <100.00%> (ø)` | | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `33.08% <0.00%> (-2.21%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `23.46% <0.00%> (-1.81%)` | :arrow_down: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/497?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #16: ci: don't require PR to up-to-date with main branch
spacewander merged pull request #16: URL: https://github.com/apache/apisix-java-plugin-runner/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #497: feat: subset translation
tokers commented on a change in pull request #497:
URL:
https://github.com/apache/apisix-ingress-controller/pull/497#discussion_r641274653
##
File path: pkg/ingress/pod.go
##
@@ -0,0 +1,100 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package ingress
+
+import (
+ "context"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ "k8s.io/client-go/tools/cache"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+)
+
+type podController struct {
+ controller *Controller
+}
+
+func (c *Controller) newPodController() *podController {
+ ctl := {
+ controller: c,
+ }
+ ctl.controller.podInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ DeleteFunc: ctl.onDelete,
+ },
+ )
+ return ctl
+}
+
+func (c *podController) run(ctx context.Context) {
+ log.Info("pod controller started")
+ defer log.Info("pod controller exited")
+
+ if ok := cache.WaitForCacheSync(ctx.Done(),
c.controller.podInformer.HasSynced); !ok {
+ log.Error("informers sync failed")
+ return
+ }
+
+ <-ctx.Done()
+}
+
+func (c *podController) onAdd(obj interface{}) {
+ key, err := cache.MetaNamespaceKeyFunc(obj)
+ if err != nil {
+ log.Errorf("found pod with bad namespace/name: %s, ignore it",
err)
+ return
+ }
+ if !c.controller.namespaceWatching(key) {
+ return
+ }
+ log.Debugw("pod add event arrived",
+ zap.Any("object", obj),
+ )
+ pod := obj.(*corev1.Pod)
+ if err := c.controller.podCache.Add(pod); err != nil {
Review comment:
handled inside `podCache.Add`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-java-plugin-runner] branch main updated: ci: don't require PR to up-to-date with main branch (#16)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git The following commit(s) were added to refs/heads/main by this push: new ce3ebda ci: don't require PR to up-to-date with main branch (#16) ce3ebda is described below commit ce3ebdaec3f58c309caf55a2364a71b711d8b600 Author: 罗泽轩 AuthorDate: Fri May 28 13:21:37 2021 +0800 ci: don't require PR to up-to-date with main branch (#16) --- .asf.yaml | 4 1 file changed, 4 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index ac966c2..0e640e8 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -30,10 +30,6 @@ github: issues: true protected_branches: main: - required_status_checks: -strict: true -contexts: - - CI required_pull_request_reviews: dismiss_stale_reviews: true required_approving_review_count: 1
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #497: feat: subset translation
tokers commented on a change in pull request #497:
URL:
https://github.com/apache/apisix-ingress-controller/pull/497#discussion_r641274413
##
File path: pkg/ingress/pod.go
##
@@ -0,0 +1,100 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package ingress
+
+import (
+ "context"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ "k8s.io/client-go/tools/cache"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+)
+
+type podController struct {
+ controller *Controller
+}
+
+func (c *Controller) newPodController() *podController {
+ ctl := {
+ controller: c,
+ }
+ ctl.controller.podInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ DeleteFunc: ctl.onDelete,
Review comment:
Don't need to handle update event, as the pod's IP and name won't
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] qier222 commented on pull request #357: feat: versioning Chinese docs
qier222 commented on pull request #357: URL: https://github.com/apache/apisix-website/pull/357#issuecomment-850135915 Preview: https://60b07a3cbb59fb5d1bcfd1ee--apisix.netlify.app/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #357: feat: versioning Chinese docs
netlify[bot] edited a comment on pull request #357: URL: https://github.com/apache/apisix-website/pull/357#issuecomment-850128815 :heavy_check_mark: Deploy Preview for *apisix* ready! :hammer: Explore the source changes: f8d965ca554a20d5f5cdc758d7d4d3a3f0d90022 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60b076a8c9d575000845560a](https://app.netlify.com/sites/apisix/deploys/60b076a8c9d575000845560a?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-357--apisix.netlify.app](https://deploy-preview-357--apisix.netlify.app?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #357: feat: versioning Chinese docs
netlify[bot] commented on pull request #357: URL: https://github.com/apache/apisix-website/pull/357#issuecomment-850128815 :construction_worker: Deploy Preview for *apisix* processing. :hammer: Explore the source changes: f8d965ca554a20d5f5cdc758d7d4d3a3f0d90022 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60b076a8c9d575000845560a](https://app.netlify.com/sites/apisix/deploys/60b076a8c9d575000845560a?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] qier222 opened a new pull request #357: feat: versioning Chinese docs
qier222 opened a new pull request #357: URL: https://github.com/apache/apisix-website/pull/357 Fixes: #[Add issue number here] Changes: Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS
codecov-commenter edited a comment on pull request #492: URL: https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (58f1698) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f089ffe) will **increase** coverage by `0.16%`. > The diff coverage is `1.20%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #492 +/- ## == + Coverage 36.28% 36.44% +0.16% == Files 50 53 +3 Lines4093 4261 +168 == + Hits 1485 1553 +68 - Misses 2406 2498 +92 - Partials 202 210 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.20% <0.00%> (+1.20%)` | :arrow_up: | | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `32.06% <100.00%> (-2.98%)` | :arrow_down: | | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <0.00%> (ø)` | | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `51.38% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv) | `73.33% <0.00%> (ø)` | | | [pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==) | `100.00% <0.00%> (ø)` | | | [pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv) |
[GitHub] [apisix] NMSAzulX opened a new issue #4329: 请问如何编写插件? 文档没有看明白
NMSAzulX opened a new issue #4329: URL: https://github.com/apache/apisix/issues/4329 如题: 1. 我看到 https://github.com/apache/apisix/blob/master/apisix/plugins/openid-connect.lua 中有很多方法, 请问哪些是管道最开始执行的方法? 2. 如果插件方法需要终止管道并且返回401, 该使用什么方法终止管道继续运行? 3. 如何管理插件类及管道的生命周期? 4. 如何在已配置路由映射的情况下, 使用插件终止转发并返回插件中的结果? 5. 是否支持其他语言编写插件, 是否有传送门列表? 感谢 Apisix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4324: Improve Docs: APISIX如何使用非Lua语言编写插件
spacewander commented on issue #4324: URL: https://github.com/apache/apisix/issues/4324#issuecomment-850096066 Currently we don't have plan to add C# support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4312: bug: 启用proxy-mirror后正常的请求报404
Firstsawyou commented on issue #4312: URL: https://github.com/apache/apisix/issues/4312#issuecomment-850095078 @sandy420 Local test did not show 404. You should check whether apisix has log information records, as @tokers said, providing context information for 404 requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS
codecov-commenter edited a comment on pull request #492: URL: https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9ad3254) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f089ffe) will **increase** coverage by `0.16%`. > The diff coverage is `1.20%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #492 +/- ## == + Coverage 36.28% 36.44% +0.16% == Files 50 53 +3 Lines4093 4261 +168 == + Hits 1485 1553 +68 - Misses 2406 2498 +92 - Partials 202 210 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.20% <0.00%> (+1.20%)` | :arrow_up: | | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `32.06% <100.00%> (-2.98%)` | :arrow_down: | | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <0.00%> (ø)` | | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `51.38% <0.00%> (ø)` | | | [pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv) | `28.88% <0.00%> (ø)` | | | [pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==) | `100.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv) |
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #356: fix: download info for dashboard 2.6.1
netlify[bot] edited a comment on pull request #356: URL: https://github.com/apache/apisix-website/pull/356#issuecomment-85009 :heavy_check_mark: Deploy Preview for *apisix* ready! :hammer: Explore the source changes: 2b03b65f423e987d7ab5f42efeb01d088a54bd40 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60b068ca30eceb000720e09e](https://app.netlify.com/sites/apisix/deploys/60b068ca30eceb000720e09e?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-356--apisix.netlify.app](https://deploy-preview-356--apisix.netlify.app?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] nic-chen opened a new pull request #356: fix: download info for dashboard 2.6.1
nic-chen opened a new pull request #356: URL: https://github.com/apache/apisix-website/pull/356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #356: fix: download info for dashboard 2.6.1
netlify[bot] commented on pull request #356: URL: https://github.com/apache/apisix-website/pull/356#issuecomment-85009 :construction_worker: Deploy Preview for *apisix* processing. :hammer: Explore the source changes: 2b03b65f423e987d7ab5f42efeb01d088a54bd40 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60b068ca30eceb000720e09e](https://app.netlify.com/sites/apisix/deploys/60b068ca30eceb000720e09e?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] 01/01: fix: download info for dashboard 2.6.1
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a commit to branch dashboard-download-link
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit 2b03b65f423e987d7ab5f42efeb01d088a54bd40
Author: nic-chen
AuthorDate: Fri May 28 11:50:25 2021 +0800
fix: download info for dashboard 2.6.1
---
website/docusaurus.config.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index 9ce4426..4b7340f 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -93,8 +93,8 @@ module.exports = {
shape: "square",
color: "#10B981",
githubRepo: "apache/apisix-dashboard",
-version: "2.6",
-releaseDate: "2021-04-22",
+version: "2.6.1",
+releaseDate: "2021-05-27",
firstDocPath: "/USER_GUIDE",
},
{
[apisix-website] branch dashboard-download-link created (now 2b03b65)
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch dashboard-download-link in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 2b03b65 fix: download info for dashboard 2.6.1 This branch includes the following new commits: new 2b03b65 fix: download info for dashboard 2.6.1 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS
codecov-commenter edited a comment on pull request #492: URL: https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (18b8f7b) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f089ffe) will **increase** coverage by `0.16%`. > The diff coverage is `1.20%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #492 +/- ## == + Coverage 36.28% 36.44% +0.16% == Files 50 53 +3 Lines4093 4261 +168 == + Hits 1485 1553 +68 - Misses 2406 2498 +92 - Partials 202 210 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.20% <0.00%> (+1.20%)` | :arrow_up: | | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `32.06% <100.00%> (-2.98%)` | :arrow_down: | | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <0.00%> (ø)` | | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `51.38% <0.00%> (ø)` | | | [pkg/types/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL3BvZC5nbw==) | `100.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv) | `73.33% <0.00%> (ø)` | | | [pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv) |
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #507: feat: subset changes in controllers
codecov-commenter edited a comment on pull request #507: URL: https://github.com/apache/apisix-ingress-controller/pull/507#issuecomment-849592176 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#507](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (21d33cc) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/cddcd299459cc1a0ad2aee02e611cc88cda64c8e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cddcd29) will **decrease** coverage by `0.52%`. > The diff coverage is `15.31%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #507 +/- ## == - Coverage 37.23% 36.71% -0.53% == Files 53 53 Lines4208 4252 +44 == - Hits 1567 1561 -6 - Misses 2434 2478 +44 - Partials 207 213 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Vwc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `47.19% <9.09%> (-13.68%)` | :arrow_down: | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `46.98% <38.09%> (-4.41%)` | :arrow_down: | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `42.71% <40.00%> (ø)` | | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `87.33% <100.00%> (ø)` | | | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <100.00%> (ø)` | | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `33.08% <0.00%> (-2.21%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `23.46% <0.00%> (-1.81%)` | :arrow_down: | -- [Continue to review full report at
[apisix-ingress-controller] branch master updated (cddcd29 -> 880d573)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from cddcd29 feat: add pod controller and pod cache (#490) add 880d573 ci: fix cancel workflow not working (#509) No new revisions were added by this update. Summary of changes: .github/actions/cancel-workflow-runs | 1 + .github/actions/gitleaks-action | 1 - .gitmodules | 6 +++--- 3 files changed, 4 insertions(+), 4 deletions(-) create mode 16 .github/actions/cancel-workflow-runs delete mode 16 .github/actions/gitleaks-action
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #509: ci: fix cancel workflow not working
gxthrj merged pull request #509: URL: https://github.com/apache/apisix-ingress-controller/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] NMSAzulX commented on issue #4324: Improve Docs: APISIX如何使用非Lua语言编写插件
NMSAzulX commented on issue #4324: URL: https://github.com/apache/apisix/issues/4324#issuecomment-850088250 请问有C#版本的吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #509: ci: fix cancel workflow not working
codecov-commenter edited a comment on pull request #509: URL: https://github.com/apache/apisix-ingress-controller/pull/509#issuecomment-850070162 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#509](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5588f3e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/23e5ebdb837cf581db94a613e02e292167d52eae?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (23e5ebd) will **not change** coverage. > The diff coverage is `n/a`. > :exclamation: Current head 5588f3e differs from pull request most recent head 6823a56. Consider uploading reports for the commit 6823a56 to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #509 +/- ## === Coverage 36.84% 36.84% === Files 52 52 Lines4136 4136 === Hits 1524 1524 Misses 2408 2408 Partials 204 204 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [23e5ebd...6823a56](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel opened a new issue #512: bug: can't update status, resource not found
lingsamuel opened a new issue #512: URL: https://github.com/apache/apisix-ingress-controller/issues/512 ### Issue description  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS
codecov-commenter edited a comment on pull request #492: URL: https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (144512c) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f089ffe) will **increase** coverage by `0.16%`. > The diff coverage is `37.11%`. > :exclamation: Current head 144512c differs from pull request most recent head ca94b3e. Consider uploading reports for the commit ca94b3e to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #492 +/- ## == + Coverage 36.28% 36.44% +0.16% == Files 50 53 +3 Lines4093 4261 +168 == + Hits 1485 1553 +68 - Misses 2406 2498 +92 - Partials 202 210 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.20% <0.00%> (+1.20%)` | :arrow_up: | | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `51.38% <ø> (ø)` | | | [pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv) | `28.88% <28.88%> (ø)` | | | [pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv) | `73.33% <73.33%> (ø)` | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `32.06% <100.00%> (-2.98%)` | :arrow_down: | | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <100.00%> (ø)` | | |
[GitHub] [apisix] spacewander closed issue #1592: request help: A better way to support the Etcd Cluster and the two-way authentication with ETCD.
spacewander closed issue #1592: URL: https://github.com/apache/apisix/issues/1592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #1592: request help: A better way to support the Etcd Cluster and the two-way authentication with ETCD.
spacewander commented on issue #1592: URL: https://github.com/apache/apisix/issues/1592#issuecomment-850087351 APISIX now supports mTLS by itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on issue #511: bug: RBAC: should be able to create `events`
lingsamuel commented on issue #511: URL: https://github.com/apache/apisix-ingress-controller/issues/511#issuecomment-850087209 ```patch Index: samples/deploy/rbac/apisix_view_clusterrole.yaml IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 === diff --git a/samples/deploy/rbac/apisix_view_clusterrole.yaml b/samples/deploy/rbac/apisix_view_clusterrole.yaml --- a/samples/deploy/rbac/apisix_view_clusterrole.yaml (revision ca94b3e4fb9537d3b27fedb97a941b7e680aea3a) +++ b/samples/deploy/rbac/apisix_view_clusterrole.yaml (date 1622169931397) @@ -22,6 +22,12 @@ rules: - apiGroups: - "" + resources: + - events + verbs: +- "*" +- apiGroups: + - "" resources: - configmaps - endpoints @@ -40,7 +46,6 @@ - "" resources: - bindings - - events - limitranges - namespaces/status - pods/log ··· -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #511: bug: RBAC: should be able to create `events`
tokers commented on issue #511: URL: https://github.com/apache/apisix-ingress-controller/issues/511#issuecomment-850084724 It seems the problem was not fixed totally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #511: bug: RBAC: should be able to create `events`
tokers commented on issue #511: URL: https://github.com/apache/apisix-ingress-controller/issues/511#issuecomment-850084637 @gxthrj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #178: ci: change new release trigger from release to release branch
tokers commented on a change in pull request #178: URL: https://github.com/apache/apisix-docker/pull/178#discussion_r641215072 ## File path: MAINTAINING.md ## @@ -0,0 +1,5 @@ +## New release + +To make and publish new docker images on docker hub, maintainers should create branch under `apisix-docker` repo with specific name. + +For apisix and dashboard new version, the branch name should use prefix `release/apisix` and `release/dashboard` seperately. Remember to delete the release branch after the new images published, since the branch would got no use afterwards. Review comment: I mean: ```suggestion For apisix and dashboard new version, the branch name should use prefix `release/apisix` and `release/dashboard` separately (e.g. `release/apisix-2.6`, `release/dashboard-2.6`). Remember to delete the release branch after the new images published, since the branch would got no use afterwards. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4327: Extend the admin mTLS doc to cover all the mTLS concepts
tokers commented on issue #4327: URL: https://github.com/apache/apisix/issues/4327#issuecomment-850083548 @lingsamuel Assigned to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4328: request help: 怎么实现自定义路由？
tokers commented on issue #4328: URL: https://github.com/apache/apisix/issues/4328#issuecomment-850082017 @vincentwc So you want to separate all routes into multiple groups and distinguish them by the ETCD key prefix? I don't know your real scenario but it's not feasible in APISIX, you have to hack it. Also, if the group is used for management, try the labels feature, you can set labels by using apisix-dashboard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] starsz merged pull request #490: feat: add pod controller and pod cache
starsz merged pull request #490: URL: https://github.com/apache/apisix-ingress-controller/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated (23e5ebd -> cddcd29)
This is an automated email from the ASF dual-hosted git repository. starsz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from 23e5ebd feat: apisixconsumer translator (#474) add cddcd29 feat: add pod controller and pod cache (#490) No new revisions were added by this update. Summary of changes: pkg/ingress/controller.go | 14 + pkg/ingress/pod.go | 100 + pkg/ingress/pod_test.go| 111 + pkg/kube/translation/translator.go | 1 + pkg/types/pod.go | 84 pkg/types/pod_test.go | 69 +++ 6 files changed, 379 insertions(+) create mode 100644 pkg/ingress/pod.go create mode 100644 pkg/ingress/pod_test.go create mode 100644 pkg/types/pod.go create mode 100644 pkg/types/pod_test.go
[GitHub] [apisix-ingress-controller] lingsamuel opened a new issue #511: bug: RBAC: should be able to create `events`
lingsamuel opened a new issue #511: URL: https://github.com/apache/apisix-ingress-controller/issues/511 ### Issue description Lack of permission to create `events`: [clusterrole.yaml](https://github.com/apache/apisix-ingress-controller/blob/23e5ebdb837cf581db94a613e02e292167d52eae/samples/deploy/rbac/apisix_view_clusterrole.yaml) Helm chart also has this issue: [rbac.yaml](https://github.com/apache/apisix-helm-chart/blob/ab1dbe50854de3ee6a6fb42d8e1b8c4b8eb09699/charts/apisix-ingress-controller/templates/rbac.yaml) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] vincentwc commented on issue #4328: request help: 怎么实现自定义路由？
vincentwc commented on issue #4328: URL: https://github.com/apache/apisix/issues/4328#issuecomment-850078587 > As far as I am concerned, it is not recommended to modify the structure of `key`. Because this may bring a series of problems. For example: it cannot be compatible with APISIX in the community, cannot be used with `APISIX Dashboard`, etc. i know your concerned，but now i want to seperate by api group, so i need to add string at route's key. i think we can't reply it by dashboard?so how to implemets it by apisix not dashboard? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4328: request help: 怎么实现自定义路由？
Firstsawyou commented on issue #4328: URL: https://github.com/apache/apisix/issues/4328#issuecomment-850074745 As far as I am concerned, it is not recommended to modify the structure of `key`. Because this may bring a series of problems. For example: it cannot be compatible with APISIX in the community, cannot be used with `APISIX Dashboard`, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #510: Change skywalking-eyes version to main
codecov-commenter commented on pull request #510: URL: https://github.com/apache/apisix-ingress-controller/pull/510#issuecomment-850070939 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/510?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#510](https://codecov.io/gh/apache/apisix-ingress-controller/pull/510?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (acb8c4a) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/23e5ebdb837cf581db94a613e02e292167d52eae?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (23e5ebd) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/510?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #510 +/- ## === Coverage 36.83% 36.83% === Files 51 51 Lines4135 4135 === Hits 1523 1523 Misses 2408 2408 Partials 204 204 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/510?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/510?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [23e5ebd...acb8c4a](https://codecov.io/gh/apache/apisix-ingress-controller/pull/510?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr opened a new pull request #510: Change skywalking-eyes version to main
dmsolr opened a new pull request #510: URL: https://github.com/apache/apisix-ingress-controller/pull/510 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? Not pin the version to avoid missing bugfix. ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #509: ci: fix cancel workflow not working
codecov-commenter commented on pull request #509: URL: https://github.com/apache/apisix-ingress-controller/pull/509#issuecomment-850070162 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#509](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5588f3e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/23e5ebdb837cf581db94a613e02e292167d52eae?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (23e5ebd) will **not change** coverage. > The diff coverage is `n/a`. > :exclamation: Current head 5588f3e differs from pull request most recent head 6823a56. Consider uploading reports for the commit 6823a56 to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #509 +/- ## === Coverage 36.83% 36.83% === Files 51 51 Lines4135 4135 === Hits 1523 1523 Misses 2408 2408 Partials 204 204 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [23e5ebd...6823a56](https://codecov.io/gh/apache/apisix-ingress-controller/pull/509?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Yiyiyimu opened a new pull request #509: ci: fix cancel workflow not working
Yiyiyimu opened a new pull request #509: URL: https://github.com/apache/apisix-ingress-controller/pull/509 Signed-off-by: yiyiyimu Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description Sorry again that I use the incorrect repo for cancel workflow. Thank you again for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: feat: apisixconsumer translator (#474)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 23e5ebd feat: apisixconsumer translator (#474)
23e5ebd is described below
commit 23e5ebdb837cf581db94a613e02e292167d52eae
Author: Alex Zhang
AuthorDate: Fri May 28 10:17:44 2021 +0800
feat: apisixconsumer translator (#474)
---
pkg/ingress/controller.go| 2 +-
pkg/kube/translation/apisix_consumer.go | 47
pkg/kube/translation/apisix_consumer_test.go | 74 +
pkg/kube/translation/plugin.go | 50 +
pkg/kube/translation/plugin_test.go | 154 ++-
pkg/kube/translation/translator.go | 5 +-
pkg/types/apisix/v1/plugin_types.go | 26 +
pkg/types/apisix/v1/types.go | 23
pkg/types/apisix/v1/zz_generated.deepcopy.go | 77 +++---
9 files changed, 440 insertions(+), 18 deletions(-)
diff --git a/pkg/ingress/controller.go b/pkg/ingress/controller.go
index 9914c02..c283034 100644
--- a/pkg/ingress/controller.go
+++ b/pkg/ingress/controller.go
@@ -435,7 +435,7 @@ func (c *Controller) namespaceWatching(key string) (ok
bool) {
}
ns, _, err := cache.SplitMetaNamespaceKey(key)
if err != nil {
- // Ignore resource with invalid key.
+ // Ignore resource pkg/types/apisix/v1/plugin_types.gowith
invalid key.
ok = false
log.Warnf("resource %s was ignored since: %s", key, err)
return
diff --git a/pkg/kube/translation/apisix_consumer.go
b/pkg/kube/translation/apisix_consumer.go
new file mode 100644
index 000..67672c6
--- /dev/null
+++ b/pkg/kube/translation/apisix_consumer.go
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+ "fmt"
+
+ configv2alpha1
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2alpha1"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+func (t *translator) TranslateApisixConsumer(ac
*configv2alpha1.ApisixConsumer) (*apisixv1.Consumer, error) {
+ // As the CRD schema ensures that only one authN can be configured,
+ // so here the order is no matter.
+
+ plugins := make(apisixv1.Plugins)
+ if ac.Spec.AuthParameter.KeyAuth != nil {
+ cfg, err := t.translateConsumerKeyAuthPlugin(ac.Namespace,
ac.Spec.AuthParameter.KeyAuth)
+ if err != nil {
+ return nil, fmt.Errorf("invalid key auth config: %s",
err)
+ }
+ plugins["key-auth"] = cfg
+ } else if ac.Spec.AuthParameter.BasicAuth != nil {
+ cfg, err := t.translateConsumerBasicAuthPlugin(ac.Namespace,
ac.Spec.AuthParameter.BasicAuth)
+ if err != nil {
+ return nil, fmt.Errorf("invalid basic auth config: %s",
err)
+ }
+ plugins["basic-auth"] = cfg
+ }
+
+ consumer := apisixv1.NewDefaultConsumer()
+ consumer.Username = apisixv1.ComposeConsumerName(ac.Namespace, ac.Name)
+ consumer.Plugins = plugins
+ return consumer, nil
+}
diff --git a/pkg/kube/translation/apisix_consumer_test.go
b/pkg/kube/translation/apisix_consumer_test.go
new file mode 100644
index 000..cf1c796
--- /dev/null
+++ b/pkg/kube/translation/apisix_consumer_test.go
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an
[GitHub] [apisix-ingress-controller] tokers merged pull request #474: feat: apisixconsumer translator
tokers merged pull request #474: URL: https://github.com/apache/apisix-ingress-controller/pull/474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lingsamuel commented on issue #4327: Extend the admin mTLS doc to cover all the mTLS concepts
lingsamuel commented on issue #4327: URL: https://github.com/apache/apisix/issues/4327#issuecomment-850058348 @spacewander can you assign me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] vincentwc opened a new issue #4328: request help: 怎么实现自定义路由？
vincentwc opened a new issue #4328:
URL: https://github.com/apache/apisix/issues/4328
### 我现在想在创建路由的时候给路由的key添加一个字符串该怎么实现
看了一下etcd里面路由的存储，key都是
/apisix/routes/85这样的，现在想对这个做一些扩展，/apisix/routes/{String}/85
该怎么实现？
目前的思路是在请求头里面添加一个k/v，然后再apisix里面怎么解析出来并在routes.lua里面使用?
目前的想法是将k/v放到ngx.ctx里面，但是之前没做过，所以不知道该怎么实现，可以该我个实现说明吗
### Environment
Request help without environment information will be ignored or closed.
* apisix version (cmd: `apisix version`):
* OS (cmd: `uname -a`):
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
* apisix-dashboard version, if have:
* luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4324: Improve Docs: APISIX如何使用非Lua语言编写插件
spacewander commented on issue #4324: URL: https://github.com/apache/apisix/issues/4324#issuecomment-850056026 This project is almost finished but is not released yet. We will add the documentation before release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj closed issue #504: request help: Add .dockerignore to avoid unwanted cache miss
gxthrj closed issue #504: URL: https://github.com/apache/apisix-ingress-controller/issues/504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #506: chore: add docker ignore to avoid unwanted cache miss
gxthrj merged pull request #506: URL: https://github.com/apache/apisix-ingress-controller/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: chore: add docker ignore to avoid unwanted cache miss (#506)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new fe2db92 chore: add docker ignore to avoid unwanted cache miss (#506) fe2db92 is described below commit fe2db92740eda6dab6f50cb096b279aec7c0d15b Author: Sarasa Kisaragi AuthorDate: Fri May 28 09:57:35 2021 +0800 chore: add docker ignore to avoid unwanted cache miss (#506) * chore: add docker ignore to avoid unwanted cache miss Signed-off-by: Ling Samuel * add license Signed-off-by: Ling Samuel --- .dockerignore | 28 1 file changed, 28 insertions(+) diff --git a/.dockerignore b/.dockerignore new file mode 100644 index 000..990a88c --- /dev/null +++ b/.dockerignore @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# Allowlist + +* +!cmd +!conf +!pkg +!go.mod +!go.sum +!Makefile +!main.go
[GitHub] [apisix-ingress-controller] Yiyiyimu merged pull request #508: ci: fix cancel workflow not working
Yiyiyimu merged pull request #508: URL: https://github.com/apache/apisix-ingress-controller/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: ci: fix cancel workflow not working (#508)
This is an automated email from the ASF dual-hosted git repository. shuyangw pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new d87f856 ci: fix cancel workflow not working (#508) d87f856 is described below commit d87f856acbaf3f11a0559199ad7090beea7bcc45 Author: Shuyang Wu AuthorDate: Thu May 27 21:50:02 2021 -0400 ci: fix cancel workflow not working (#508) --- .github/workflows/e2e-test-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/e2e-test-ci.yml b/.github/workflows/e2e-test-ci.yml index 88deadb..3ad847d 100644 --- a/.github/workflows/e2e-test-ci.yml +++ b/.github/workflows/e2e-test-ci.yml @@ -30,6 +30,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 +with: + submodules: recursive - name: Install kind run: | curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.10.0/kind-linux-amd64
[GitHub] [apisix] topzyh commented on issue #4324: Improve Docs: APISIX如何使用非Lua语言编写插件
topzyh commented on issue #4324: URL: https://github.com/apache/apisix/issues/4324#issuecomment-850052201 > Let's watch the development of https://github.com/apache/apisix-java-plugin-runner! 有没有相关的使用文档呢，我没有找到 （什么时候能补充一下 ）感谢~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new issue #4327: Extend the admin mTLS doc to cover all the mTLS concepts
spacewander opened a new issue #4327: URL: https://github.com/apache/apisix/issues/4327 Currently we don't have a united place to hold all the mTLS info. Let's write one from the users' aspect. CC @lingsamuel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4326: chore: show priority of stream plugins
spacewander opened a new pull request #4326: URL: https://github.com/apache/apisix/pull/4326 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4319: fix: ensure the plugin is always reloaded
Firstsawyou commented on a change in pull request #4319:
URL: https://github.com/apache/apisix/pull/4319#discussion_r641089058
##
File path: apisix/admin/init.lua
##
@@ -286,9 +286,22 @@ local function post_reload_plugins()
end
-local function sync_local_conf_to_etcd()
-core.log.warn("sync local conf to etcd")
+local function plugins_eq(old, new)
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4325: feat: nacos discovery support group
spacewander commented on a change in pull request #4325:
URL: https://github.com/apache/apisix/pull/4325#discussion_r641084748
##
File path: docs/en/latest/discovery/nacos.md
##
@@ -124,7 +124,7 @@ The formatted response as below:
"node": {
Review comment:
It would be better if we can add a table of "discovery args" to
`nacos.md` like
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/limit-count.md#attributes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4319: fix: ensure the plugin is always reloaded
spacewander commented on a change in pull request #4319:
URL: https://github.com/apache/apisix/pull/4319#discussion_r641082849
##
File path: apisix/admin/init.lua
##
@@ -286,9 +286,22 @@ local function post_reload_plugins()
end
-local function sync_local_conf_to_etcd()
-core.log.warn("sync local conf to etcd")
+local function plugins_eq(old, new)
Review comment:
We can't do it, as the attribute is not stored in the etcd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #508: ci: fix cancel workflow not working
codecov-commenter commented on pull request #508: URL: https://github.com/apache/apisix-ingress-controller/pull/508#issuecomment-849927153 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/508?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#508](https://codecov.io/gh/apache/apisix-ingress-controller/pull/508?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ab86c0d) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/a3f58d07a749b4594e460b4645ef77d8d21598fb?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a3f58d0) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. > :exclamation: Current head ab86c0d differs from pull request most recent head 1d895de. Consider uploading reports for the commit 1d895de to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/508?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #508 +/- ## == - Coverage 36.29% 36.28% -0.02% == Files 51 50 -1 Lines4094 4093 -1 == - Hits 1486 1485 -1 Misses 2406 2406 Partials 202 202 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/508?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/508/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/508?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/508?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [a3f58d0...1d895de](https://codecov.io/gh/apache/apisix-ingress-controller/pull/508?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Yiyiyimu opened a new pull request #508: ci: fix cancel workflow not working
Yiyiyimu opened a new pull request #508: URL: https://github.com/apache/apisix-ingress-controller/pull/508 Signed-off-by: yiyiyimu Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description Complement to #505. Sorry forgot recursively checkout to get the submodule -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #178: ci: change new release trigger from release to release branch
Yiyiyimu commented on a change in pull request #178: URL: https://github.com/apache/apisix-docker/pull/178#discussion_r640947930 ## File path: MAINTAINING.md ## @@ -0,0 +1,5 @@ +## New release + +To make and publish new docker images on docker hub, maintainers should create branch under `apisix-docker` repo with specific name. + +For apisix and dashboard new version, the branch name should use prefix `release/apisix` and `release/dashboard` seperately. Remember to delete the release branch after the new images published, since the branch would got no use afterwards. Review comment: I intended to add one, but since it would get deleted, I think naming it `release/apisix` or `release/apisix-v2.6` would makes no difference here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #492: feat: ApisixTls support mTLS
codecov-commenter edited a comment on pull request #492: URL: https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6c11758) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f089ffe) will **decrease** coverage by `0.56%`. > The diff coverage is `1.47%`. > :exclamation: Current head 6c11758 differs from pull request most recent head 7f0a35d. Consider uploading reports for the commit 7f0a35d to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #492 +/- ## == - Coverage 36.28% 35.71% -0.57% == Files 50 50 Lines4093 4141 +48 == - Hits 1485 1479 -6 - Misses 2406 2460 +54 Partials 202 202 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `32.06% <100.00%> (-2.98%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [f089ffe...7f0a35d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #492: feat: ApisixTls support mTLS
codecov-commenter commented on pull request #492: URL: https://github.com/apache/apisix-ingress-controller/pull/492#issuecomment-849817659 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#492](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a02d74b) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f089ffe) will **decrease** coverage by `0.56%`. > The diff coverage is `1.47%`. > :exclamation: Current head a02d74b differs from pull request most recent head 0779d3e. Consider uploading reports for the commit 0779d3e to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #492 +/- ## == - Coverage 36.28% 35.71% -0.57% == Files 50 50 Lines4093 4141 +48 == - Hits 1485 1479 -6 - Misses 2406 2460 +54 Partials 202 202 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `32.06% <100.00%> (-2.98%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [f089ffe...0779d3e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/492?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[GitHub] [apisix] Engine-AI commented on issue #4324: Improve Docs: APISIX如何使用非Lua语言编写插件
Engine-AI commented on issue #4324: URL: https://github.com/apache/apisix/issues/4324#issuecomment-849767978 You can develop your own personalized authentication plug-in through lua, but it needs to be compatible with the dashboard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a change in pull request #506: chore: add docker ignore to avoid unwanted cache miss
lingsamuel commented on a change in pull request #506: URL: https://github.com/apache/apisix-ingress-controller/pull/506#discussion_r640767127 ## File path: .dockerignore ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# Allowlist Review comment: Means ignore everything (`*`) *except* allowlist below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1907: feat: Use monaco editor
codecov-commenter edited a comment on pull request #1907: URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845098946 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1907](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6d24015) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9728a430193331d135da4fd5661cd4100308afbf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9728a43) will **decrease** coverage by `14.51%`. > The diff coverage is `n/a`. > :exclamation: Current head 6d24015 differs from pull request most recent head 24a4fe9. Consider uploading reports for the commit 24a4fe9 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1907 +/- ## === - Coverage 66.97% 52.46% -14.52% === Files 169 38 -131 Lines6314 2680 -3634 Branches 7450 -745 === - Hits 4229 1406 -2823 + Misses 1833 1086 -747 + Partials 252 188 -64 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.46% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1907?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1907/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4319: fix: ensure the plugin is always reloaded
Firstsawyou commented on a change in pull request #4319:
URL: https://github.com/apache/apisix/pull/4319#discussion_r640731913
##
File path: apisix/admin/init.lua
##
@@ -286,9 +286,22 @@ local function post_reload_plugins()
end
-local function sync_local_conf_to_etcd()
-core.log.warn("sync local conf to etcd")
+local function plugins_eq(old, new)
Review comment:
Can we also compare `plugin_attr` for equality? Like this:
https://github.com/apache/apisix/blob/9a40fd7cb497974f9d7bd75f128eed5dd238cdc6/apisix/plugin.lua#L147-L153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1907: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1907: URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845072931 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: 24a4fe9f9630f114d8c25064f5157e83bb3fe93a :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60afb6325950180007e9ad27](https://app.netlify.com/sites/apisix-dashboard/deploys/60afb6325950180007e9ad27?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-1907--apisix-dashboard.netlify.app](https://deploy-preview-1907--apisix-dashboard.netlify.app?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1907: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1907: URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845072931 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: 24a4fe9f9630f114d8c25064f5157e83bb3fe93a :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60afb6325950180007e9ad27](https://app.netlify.com/sites/apisix-dashboard/deploys/60afb6325950180007e9ad27?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1907: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1907: URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845072931 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: b7ebdd5a976a8b856599cd417237dd7e42f7f274 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60afb1f588ff4600088243a5](https://app.netlify.com/sites/apisix-dashboard/deploys/60afb1f588ff4600088243a5?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-1907--apisix-dashboard.netlify.app/](https://deploy-preview-1907--apisix-dashboard.netlify.app/?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1907: feat: Use monaco editor
netlify[bot] edited a comment on pull request #1907: URL: https://github.com/apache/apisix-dashboard/pull/1907#issuecomment-845072931 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: b7ebdd5a976a8b856599cd417237dd7e42f7f274 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60afb1f588ff4600088243a5](https://app.netlify.com/sites/apisix-dashboard/deploys/60afb1f588ff4600088243a5?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1922: special route cause the page suspend
juzhiyuan commented on issue #1922: URL: https://github.com/apache/apisix-dashboard/issues/1922#issuecomment-849647737 Just to make sure, the data you mentioned is created by API or dashboard web? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Demogorgon314 opened a new pull request #4325: feat: nacos discovery support group
Demogorgon314 opened a new pull request #4325: URL: https://github.com/apache/apisix/pull/4325 ### What this PR does / why we need it: nacos discovery support group ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #506: chore: add docker ignore to avoid unwanted cache miss
gxthrj commented on a change in pull request #506: URL: https://github.com/apache/apisix-ingress-controller/pull/506#discussion_r640609212 ## File path: .dockerignore ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# Allowlist Review comment: What is the meaning of this line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #497: feat: subset translation
gxthrj commented on a change in pull request #497:
URL:
https://github.com/apache/apisix-ingress-controller/pull/497#discussion_r640606110
##
File path: pkg/ingress/pod.go
##
@@ -0,0 +1,100 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package ingress
+
+import (
+ "context"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ "k8s.io/client-go/tools/cache"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+)
+
+type podController struct {
+ controller *Controller
+}
+
+func (c *Controller) newPodController() *podController {
+ ctl := {
+ controller: c,
+ }
+ ctl.controller.podInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ DeleteFunc: ctl.onDelete,
Review comment:
There is no updateFunc?
##
File path: pkg/ingress/pod.go
##
@@ -0,0 +1,100 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package ingress
+
+import (
+ "context"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ "k8s.io/client-go/tools/cache"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+)
+
+type podController struct {
+ controller *Controller
+}
+
+func (c *Controller) newPodController() *podController {
+ ctl := {
+ controller: c,
+ }
+ ctl.controller.podInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ DeleteFunc: ctl.onDelete,
+ },
+ )
+ return ctl
+}
+
+func (c *podController) run(ctx context.Context) {
+ log.Info("pod controller started")
+ defer log.Info("pod controller exited")
+
+ if ok := cache.WaitForCacheSync(ctx.Done(),
c.controller.podInformer.HasSynced); !ok {
+ log.Error("informers sync failed")
+ return
+ }
+
+ <-ctx.Done()
+}
+
+func (c *podController) onAdd(obj interface{}) {
+ key, err := cache.MetaNamespaceKeyFunc(obj)
+ if err != nil {
+ log.Errorf("found pod with bad namespace/name: %s, ignore it",
err)
+ return
+ }
+ if !c.controller.namespaceWatching(key) {
+ return
+ }
+ log.Debugw("pod add event arrived",
+ zap.Any("object", obj),
+ )
+ pod := obj.(*corev1.Pod)
+ if err := c.controller.podCache.Add(pod); err != nil {
Review comment:
Need to check the status of pod, on some status like pending, the pod IP
is not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #474: feat: apisixconsumer translator
gxthrj commented on a change in pull request #474:
URL:
https://github.com/apache/apisix-ingress-controller/pull/474#discussion_r640602382
##
File path: pkg/ingress/controller.go
##
@@ -435,7 +435,7 @@ func (c *Controller) namespaceWatching(key string) (ok
bool) {
}
ns, _, err := cache.SplitMetaNamespaceKey(key)
if err != nil {
- // Ignore resource with invalid key.
+ // Ignore resource pkg/types/apisix/v1/plugin_types.gowith
invalid key.
Review comment:
```suggestion
// Ignore resource pkg/types/apisix/v1/plugin_types.go with
invalid key.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-ingress-controller] branch master updated: fix: ack.md link fix (#503)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new a3f58d0 fix: ack.md link fix (#503)
a3f58d0 is described below
commit a3f58d07a749b4594e460b4645ef77d8d21598fb
Author: Shivani chauhan <56837749+xdshiv...@users.noreply.github.com>
AuthorDate: Thu May 27 18:31:22 2021 +0530
fix: ack.md link fix (#503)
---
docs/en/latest/deployments/ack.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/en/latest/deployments/ack.md
b/docs/en/latest/deployments/ack.md
index 224cc23..0d0d372 100644
--- a/docs/en/latest/deployments/ack.md
+++ b/docs/en/latest/deployments/ack.md
@@ -52,7 +52,7 @@ kubectl get service --namespace ingress-apisix
Two Service resources were created, one is `apisix-gateway`, which processes
the real traffic; another is `apisix-admin`, which acts as the control plane to
process all the configuration changes.
-The gateway service type is set to `LoadBalancer` (See [Access services
through SLB](https://help.aliyun.com/document_detail/182218.html) for more
details), so that clients can access Apache APISIX through a load balancer. You
can find the load balancer ip by running:
+The gateway service type is set to `LoadBalancer` (See [Access services
through SLB](https://www.alibabacloud.com/help/doc-detail/182218.htm) for more
details), so that clients can access Apache APISIX through a load balancer. You
can find the load balancer ip by running:
```shell
kubectl get service apisix-gateway --namespace ingress-apisix -o
jsonpath='{.status.loadBalancer.ingress[].ip}'
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #503: fix: ack.md link fix
gxthrj merged pull request #503: URL: https://github.com/apache/apisix-ingress-controller/pull/503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #500: request help: no kind is registered for the type v1.ApisixUpstream in scheme "pkg/runtime/scheme.go:100"
gxthrj commented on issue #500: URL: https://github.com/apache/apisix-ingress-controller/issues/500#issuecomment-849611992 @shuoshadow Please use the command `kubectl get crd | grep apisixupstreams` to check if the CRD has been defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on issue #177: dashboard image on docker hub have wrong tag
gxthrj commented on issue #177: URL: https://github.com/apache/apisix-docker/issues/177#issuecomment-849607375 latest have be re-pushed with 2.6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] gxthrj merged pull request #355: chore: upgrade APISIX Dashboard version to 2.6.1
gxthrj merged pull request #355: URL: https://github.com/apache/apisix-website/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: chore: upgrade APISIX Dashboard version to 2.6.1 (#355)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 456f6a1 chore: upgrade APISIX Dashboard version to 2.6.1 (#355)
456f6a1 is described below
commit 456f6a1c2dcd8a3fcf84336e9c8da07393874287
Author: nic-chen <33000667+nic-c...@users.noreply.github.com>
AuthorDate: Thu May 27 20:45:15 2021 +0800
chore: upgrade APISIX Dashboard version to 2.6.1 (#355)
---
website/docusaurus.config.js| 4 ++--
.../2021-05-27-release-apache-apisix-dashboard-2.6.1.md | 13 +
website/static/data/events.json | 4
3 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index 1419389..9ce4426 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -34,8 +34,8 @@ module.exports = {
shape: "square",
color: "#10B981",
githubRepo: "apache/apisix-dashboard",
-version: "2.6",
-releaseDate: "2021-04-22",
+version: "2.6.1",
+releaseDate: "2021-05-27",
firstDocPath: "/USER_GUIDE",
},
{
diff --git a/website/events/2021-05-27-release-apache-apisix-dashboard-2.6.1.md
b/website/events/2021-05-27-release-apache-apisix-dashboard-2.6.1.md
new file mode 100644
index 000..e4b4d1e
--- /dev/null
+++ b/website/events/2021-05-27-release-apache-apisix-dashboard-2.6.1.md
@@ -0,0 +1,13 @@
+---
+title: Release Apache APISIX Dashboard 2.6.1
+---
+
+
+This release mainly contains bugfixes.
+
+`Manager API` 2.6.1 should be used with [Apache APISIX
2.5](https://apisix.apache.org/downloads/). It is not recommended to use with
other Apache APISIX versions.
+
+### Bugfix
+
+- Fix: use remote address instead of client ip
[#1831](https://github.com/apache/apisix-dashboard/pull/1831)
+- Fix: turn off online debug
[#1903](https://github.com/apache/apisix-dashboard/pull/1903)
diff --git a/website/static/data/events.json b/website/static/data/events.json
index 59803b8..1353db8 100644
--- a/website/static/data/events.json
+++ b/website/static/data/events.json
@@ -1,5 +1,9 @@
[
{
+"title": "Release Apache APISIX Dashboard 2.6.1",
+"fileName": "2021-05-27-release-apache-apisix-dashboard-2.6.1"
+ },
+ {
"title": "Release Apache APISIX 2.6",
"fileName": "2021-05-24-release-apache-apisix-2.6"
},
[apisix-java-plugin-runner] branch main updated: test: add test cases about filter (#15)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git
The following commit(s) were added to refs/heads/main by this push:
new 88c0c26 test: add test cases about filter (#15)
88c0c26 is described below
commit 88c0c267f0593d7c8ce17533b2917f8768e99ad2
Author: tzssangglass
AuthorDate: Thu May 27 20:32:40 2021 +0800
test: add test cases about filter (#15)
---
.../runner/codec/impl/FlatBuffersDecoder.java | 6 +-
.../plugin/runner/handler/A6ConfigHandler.java | 7 +-
.../runner/handler/A6HandlerConfiguration.java | 4 +-
.../plugin/runner/handler/A6HttpCallHandler.java | 2 +-
.../plugin/runner/handler/A6ConfigHandlerTest.java | 197
.../runner/handler/A6HttpCallHandlerTest.java | 251 +
.../apache/apisix/plugin/runner/HttpRequest.java | 2 +-
.../apache/apisix/plugin/runner/HttpResponse.java | 4 +
.../apisix/plugin/runner/filter/PluginFilter.java | 2 +
9 files changed, 466 insertions(+), 9 deletions(-)
diff --git
a/runner-core/src/main/java/org/apache/apisix/plugin/runner/codec/impl/FlatBuffersDecoder.java
b/runner-core/src/main/java/org/apache/apisix/plugin/runner/codec/impl/FlatBuffersDecoder.java
index 8b199e8..acbfac7 100644
---
a/runner-core/src/main/java/org/apache/apisix/plugin/runner/codec/impl/FlatBuffersDecoder.java
+++
b/runner-core/src/main/java/org/apache/apisix/plugin/runner/codec/impl/FlatBuffersDecoder.java
@@ -39,7 +39,7 @@ public class FlatBuffersDecoder implements
PluginRunnerDecoder {
try {
type = buffer.get();
} catch (BufferUnderflowException e) {
-logger.error("receive empty data");
+logger.warn("receive empty data");
return new A6ErrRequest(Code.BAD_REQUEST);
}
@@ -51,7 +51,7 @@ public class FlatBuffersDecoder implements
PluginRunnerDecoder {
body = getBody(buffer);
a6ConfigRequest = A6ConfigRequest.from(body);
} catch (BufferUnderflowException | IndexOutOfBoundsException
e) {
-logger.error("receive error data length");
+logger.warn("receive error data length");
return new A6ErrRequest(Code.BAD_REQUEST);
}
return a6ConfigRequest;
@@ -68,7 +68,7 @@ public class FlatBuffersDecoder implements
PluginRunnerDecoder {
break;
}
-logger.error("receive unsupported type: {}", type);
+logger.warn("receive unsupported type: {}", type);
return new A6ErrRequest(Code.BAD_REQUEST);
}
diff --git
a/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6ConfigHandler.java
b/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6ConfigHandler.java
index 7022363..c69e4b3 100644
---
a/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6ConfigHandler.java
+++
b/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6ConfigHandler.java
@@ -53,7 +53,6 @@ public class A6ConfigHandler implements Handler {
PluginFilterChain chain = createFilterChain(req);
A6Conf config = new A6Conf(req, chain);
cache.put(token, config);
-
}
private PluginFilterChain createFilterChain(Req req) {
@@ -62,7 +61,11 @@ public class A6ConfigHandler implements Handler {
TextEntry conf = req.conf(i);
PluginFilter filter = filters.get(conf.name());
if (Objects.isNull(filter)) {
-logger.error("receive undefined filter: {}, skip it",
conf.name());
+logger.warn("receive undefined filter: {}, skip it",
conf.name());
+continue;
+}
+if (chainFilters.contains(filter)) {
+logger.warn("skip the same filter: {}", conf.name());
continue;
}
chainFilters.add(filter);
diff --git
a/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6HandlerConfiguration.java
b/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6HandlerConfiguration.java
index 9497e43..761400b 100644
---
a/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6HandlerConfiguration.java
+++
b/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6HandlerConfiguration.java
@@ -48,7 +48,7 @@ public class A6HandlerConfiguration {
List pluginFilterList =
beanProvider.orderedStream().collect(Collectors.toList());
Map filterMap = new HashMap<>();
for (PluginFilter filter : pluginFilterList) {
-filterMap.put(filter.getClass().getSimpleName(), filter);
+filterMap.put(filter.name(), filter);
}
return new A6ConfigHandler(cache, filterMap);
}
@@ -76,7 +76,7 @@ public class
[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #15: test: add test cases about filter
spacewander merged pull request #15: URL: https://github.com/apache/apisix-java-plugin-runner/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander opened a new pull request #16: ci: don't require PR to up-to-date with main branch
spacewander opened a new pull request #16: URL: https://github.com/apache/apisix-java-plugin-runner/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #507: feat: subset changes in controllers
codecov-commenter commented on pull request #507: URL: https://github.com/apache/apisix-ingress-controller/pull/507#issuecomment-849592176 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#507](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (756a939) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f089ffe9788526b95e43d1c42efc0757b062a8cf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f089ffe) will **increase** coverage by `63.71%`. > The diff coverage is `n/a`. > :exclamation: Current head 756a939 differs from pull request most recent head fdc32bc. Consider uploading reports for the commit fdc32bc to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #507 +/- ## + Coverage 36.28% 100.00% +63.71% Files 50 1 -49 Lines4093 1 -4092 - Hits 1485 1 -1484 + Misses 2406 0 -2406 + Partials 202 0 -202 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | | | | [pkg/apisix/stream\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zdHJlYW1fcm91dGUuZ28=) | | | | [pkg/kube/translation/annotations/rewrite.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmV3cml0ZS5nbw==) | | | | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | | | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | | | | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | | | | [pkg/metrics/prometheus.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvcHJvbWV0aGV1cy5nbw==) | | | | [pkg/ingress/apisix\_cluster\_config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/507/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | | | |
