[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #529: fix: nil pointer dereference
tao12345666333 commented on pull request #529: URL: https://github.com/apache/apisix-ingress-controller/pull/529#issuecomment-855187398 I have opened a PR to change APISIX consumer name's max length. https://github.com/apache/apisix/pull/4379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tao12345666333 opened a new pull request #4379: chore: change consumer name max length match with route name
tao12345666333 opened a new pull request #4379: URL: https://github.com/apache/apisix/pull/4379 Signed-off-by: Jintao Zhang ### What this PR does / why we need it: change consumer name's max length to match with route name. ref: https://github.com/apache/apisix-ingress-controller/pull/529 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: feat: support customzing worker's user
ysc972 commented on a change in pull request #4362: URL: https://github.com/apache/apisix/pull/4362#discussion_r645931881 ## File path: docs/zh/latest/FAQ.md ## @@ -501,3 +501,4 @@ $ acme.sh --renew --domain demo.domain ``` 详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351 + Review comment: I am sorry.I want to know if there is a way to let me know my mistakes like this blank in my native environment before I commit.Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: feat: support customzing worker's user
spacewander commented on a change in pull request #4362: URL: https://github.com/apache/apisix/pull/4362#discussion_r645928620 ## File path: docs/zh/latest/FAQ.md ## @@ -501,3 +501,4 @@ $ acme.sh --renew --domain demo.domain ``` 详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351 + Review comment: Please remove the blank line which causes the failure: https://github.com/apache/apisix/pull/4362/checks?check_run_id=2751014883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4376: request help: How to use proxy-rewrite add multiple regex_uri property
spacewander commented on issue #4376: URL: https://github.com/apache/apisix/issues/4376#issuecomment-855169744 Maybe `"regex_uri": ["^/prefix/service/?(.*)", "/service/$1"]` can work for you? Unless you want to match `/prefix/serviceA`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4378: test: add case for default health status
spacewander opened a new pull request #4378: URL: https://github.com/apache/apisix/pull/4378 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4374: request help: cloudflare forward request
spacewander commented on issue #4374: URL: https://github.com/apache/apisix/issues/4374#issuecomment-855169192 You should change `real_ip_from`. Read http://nginx.org/en/docs/http/ngx_http_realip_module.html#set_real_ip_from for what it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #361: feat: added doc name to doc dropdown selection
iamayushdas commented on pull request #361: URL: https://github.com/apache/apisix-website/pull/361#issuecomment-855155098 > @iamayushdas Cool! Thanks a lot!!! > > > > Found one problem is that `APISIX` and `dashboard` page still got their own links on the sidebar, others are good to me Your wlcm, Yes that will be removed by there origin repo. Will do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1934: After configuring redirect in route, dashboard cannot run normally
liuxiran commented on issue #1934: URL: https://github.com/apache/apisix-dashboard/issues/1934#issuecomment-855152791 duplicate with #1922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ak476565 commented on issue #4157: bug: After installing the Apisix on ARM-based System,but it can't works properly.
ak476565 commented on issue #4157: URL: https://github.com/apache/apisix/issues/4157#issuecomment-855131575 > > > 在国产环境下，启动apisix，需要在nginx.conf文件中增加用户root；配置，才能正常启动。 > > > 在国内环境中，开始apisix，您需要添加用户root在nginx.conf文件; apisix 可以正常启动。 > > > > > > @ysc972感谢您的建议。它没有错误日志。@Molio-tan我刚刚在你的环境中尝试了 APISIX v2.6，一切都很顺利，请检查一下`/opt/ALB-V1.0/apisix`。 > > 仅供参考，我进行了更改`/usr/local/openresty/nginx/conf/nginx.conf`以使用`user root;`而不是`# user nobody;`. > > @imjoey @ysc972谢谢大家，我可以正确使用 apisix。 Hi,Can you share your ARM64 image of Apisix on DockerHub? I'm having problems compiling. thanks bro. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #361: feat: added doc name to doc dropdown selection
Yiyiyimu commented on pull request #361: URL: https://github.com/apache/apisix-website/pull/361#issuecomment-855019891 @iamayushdas Cool! Thanks a lot!!! Found one problem is that `APISIX` and `dashboard` page still got their own links on the sidebar, others are good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #529: fix: nil pointer dereference
tao12345666333 commented on pull request #529: URL: https://github.com/apache/apisix-ingress-controller/pull/529#issuecomment-854899222 ApisixConsumer's e2e test failed because it triggered the max length limit of consumer name in APISIX. Current limit is 32 https://github.com/apache/apisix/blob/10677e9067b43fb3b2555c917c322b4454b22c77/apisix/schema_def.lua#L623 We have two solutions 1. Increase the limit on the length of APISIX consumer name. https://github.com/apache/apisix/blob/10677e9067b43fb3b2555c917c322b4454b22c77/apisix/schema_def.lua#L623 2. Shorten the namespace name generated by the current e2e test https://github.com/apache/apisix-ingress-controller/blob/2bf4b6be29648c1c3e98006edae50252a0555a08/test/e2e/scaffold/scaffold.go#L262 I tried to create ApisixConsumer in other namespaces, but ApisixIngress currently only monitors the namespace where it is located. A third solution can be derived here, which is to update deployment in this testcase. But I think the second method has the lowest cost. cd @tokers @gxthrj @membphis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #361: feat: added doc name to doc dropdown selection
netlify[bot] edited a comment on pull request #361: URL: https://github.com/apache/apisix-website/pull/361#issuecomment-854885640 :heavy_check_mark: Deploy Preview for *apisix* ready! :hammer: Explore the source changes: 333cbab640782c4efa21073e0540091766868a3f :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60ba60370232d7000900ada9](https://app.netlify.com/sites/apisix/deploys/60ba60370232d7000900ada9?utm_source=github_campaign=bot_dl) :sunglasses: Browse the preview: [https://deploy-preview-361--apisix.netlify.app](https://deploy-preview-361--apisix.netlify.app?utm_source=github_campaign=bot_dp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #361: feat: added doc name to doc dropdown selection
iamayushdas commented on pull request #361: URL: https://github.com/apache/apisix-website/pull/361#issuecomment-854886239 cc @Yiyiyimu @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #361: feat: added doc name to doc dropdown selection
netlify[bot] commented on pull request #361: URL: https://github.com/apache/apisix-website/pull/361#issuecomment-854885640 :construction_worker: Deploy Preview for *apisix* processing. :hammer: Explore the source changes: 333cbab640782c4efa21073e0540091766868a3f :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60ba60370232d7000900ada9](https://app.netlify.com/sites/apisix/deploys/60ba60370232d7000900ada9?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas opened a new pull request #361: feat: added doc name to doc dropdown selection
iamayushdas opened a new pull request #361: URL: https://github.com/apache/apisix-website/pull/361 Fixes: #360 Changes: added the navigated doc page name to docs dropdown Screenshots of the change:  live url: https://apisix-website-navigation.netlify.app/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #360: remove the useless top button on the sidebar
iamayushdas commented on issue #360: URL: https://github.com/apache/apisix-website/issues/360#issuecomment-854882066 @Yiyiyimu check this link is this what you wanted? https://apisix-website-navigation.netlify.app/  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hozaifaaoud commented on issue #4374: request help: cloudflare forward request
hozaifaaoud commented on issue #4374: URL: https://github.com/apache/apisix/issues/4374#issuecomment-854837236 Here is the configuration:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #96: chore: bump APISIX to v2.6.0
tao12345666333 commented on pull request #96: URL: https://github.com/apache/apisix-helm-chart/pull/96#issuecomment-854825852 wait for #95 #97 fix #92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #97: fix: apisix-dashboard appversion mismatch real version
tao12345666333 opened a new pull request #97: URL: https://github.com/apache/apisix-helm-chart/pull/97 Signed-off-by: Jintao Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas removed a comment on issue #360: remove the useless top button on the sidebar
iamayushdas removed a comment on issue #360: URL: https://github.com/apache/apisix-website/issues/360#issuecomment-854819889 > Considering the need to show where we are, maybe we could change the field `Docs` in navbar to where we are after one option is chosen, keeps the drop-down arrow so people still know they could switch different docs there >  i have achieved your desired idea of changing dropdown title according to page @Yiyiyimu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on issue #360: remove the useless top button on the sidebar
iamayushdas edited a comment on issue #360: URL: https://github.com/apache/apisix-website/issues/360#issuecomment-854819889 > Considering the need to show where we are, maybe we could change the field `Docs` in navbar to where we are after one option is chosen, keeps the drop-down arrow so people still know they could switch different docs there >  i have achieved your desired idea of changing dropdown title according to page @Yiyiyimu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on issue #360: remove the useless top button on the sidebar
iamayushdas edited a comment on issue #360: URL: https://github.com/apache/apisix-website/issues/360#issuecomment-854819889 > Considering the need to show where we are, maybe we could change the field `Docs` in navbar to where we are after one option is chosen, keeps the drop-down arrow so people still know they could switch different docs there >  i have achieved your desired idea of changing dropdown title according to page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #360: remove the useless top button on the sidebar
iamayushdas commented on issue #360: URL: https://github.com/apache/apisix-website/issues/360#issuecomment-854819889 > @1502shivam-singh Thank you for the information! > > Considering the need to show where we are, maybe we could change the field `Docs` in navbar to where we are after one option is chosen, keeps the drop-down arrow so people still know they could switch different docs there >  i have achieved your desired idea of changing dropdown title according to page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #96: chore: bump APISIX to v2.6.0
tao12345666333 opened a new pull request #96: URL: https://github.com/apache/apisix-helm-chart/pull/96 Signed-off-by: Jintao Zhang * bump APISIX 's version to latest v2.6.0 * update dependence apisix-ingress-controller's version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #95: chore: bump apisix-ingress-controller to v0.6.0
tao12345666333 opened a new pull request #95: URL: https://github.com/apache/apisix-helm-chart/pull/95 Signed-off-by: Jintao Zhang APISIX Ingress controller v0.6.0 has been released 22 days ago. full diff https://github.com/apache/apisix-ingress-controller/compare/0.5.0...0.6.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new issue #94: need verification in CI
tao12345666333 opened a new issue #94: URL: https://github.com/apache/apisix-helm-chart/issues/94 We should add a check in CI to determine whether the dependency in Chart.yaml is consistent with our cached dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #92: add instruction on install apisix only and etcd cluster
tao12345666333 commented on issue #92: URL: https://github.com/apache/apisix-helm-chart/issues/92#issuecomment-854803072 I will submit a PR to update Helm chart version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #92: add instruction on install apisix only and etcd cluster
tao12345666333 commented on issue #92: URL: https://github.com/apache/apisix-helm-chart/issues/92#issuecomment-854764716 I think this may be due to a problem with the package we published to the Helm repo. If you clone this repo, you can go through ``` ➜ charts git:(master) cd charts ➜ charts git:(master) helm template apisix > /tmp/default.yaml ➜ charts git:(master) helm template apisix --set ingress-controller.enabled=true > /tmp/install-with-apisix-ingress.yaml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ieayoio edited a comment on issue #4376: request help: How to use proxy-rewrite add multiple regex_uri property
ieayoio edited a comment on issue #4376:
URL: https://github.com/apache/apisix/issues/4376#issuecomment-854739198
其实我提出这个问题起因并没有这么复杂，只是通过快速入门，想在我原服务的基础上加一个前缀
例如原服务(tomcat)：
```
http://host2:8080/service/
```
加前缀用如下形式替代:
```
http://host1:9080/prefix/service/
```
我进行了如下配置
```json
"proxy-rewrite": {
"regex_uri": ["^/prefix/service(.*)", "/service$1"]
}
```
当我访问`http://host1:9080/prefix/service/`，一切正常，我访问到了原服务`http://host2:8080/service/`的内容
问题出现在我访问`http://host1:9080/prefix/service` (没有了结尾的"/")
浏览器url却直接跳转到了`http://host1:9080/service/`，当然这个无法访问的
我分析原因，问题出现在原服务访问`http://host2:8080/service`会加/跳转到`http://host2:8080/service/`
因此，我认为最适合我的是配置两个regex_uri
分别为`"regex_uri": ["^/prefix/service", "/service/"]` 直接加/后缀
和`"regex_uri": ["^/prefix/service(.+)", "/service$1"]`
目前我已经通过配置两条路由解决了，能满足我的要求
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] ieayoio edited a comment on issue #4376: request help: How to use proxy-rewrite add multiple regex_uri property
ieayoio edited a comment on issue #4376:
URL: https://github.com/apache/apisix/issues/4376#issuecomment-854739198
其实我提出这个问题起因并没有这么复杂，只是通过快速入门，想在我原服务的基础上加一个前缀
例如原服务(tomcat)：
```
http://host2:8080/service/
```
加前缀用如下形式替代:
```
http://host1:9080/prefix/service/
```
我进行了如下配置
```json
"proxy-rewrite": {
"regex_uri": ["^/prefix/service(.*)", "/service$1"]
}
```
当我访问`http://host1:9080/prefix/service/`，一切正常，我访问到了原服务`http://host2:8080/service/`的内容
问题出现在我访问`http://host1:9080/prefix/service` (没有了结尾的"/")
浏览器url却直接跳转到了`http://host1:9080/service/`，当然这个无法访问的
我分析原因，问题出现在原服务访问`http://host2:8080/service`会加/跳转到`http://host2:8080/service/`
因此，我任务最适合我的是配置两个regex_uri
分别为`"regex_uri": ["^/prefix/service", "/service/"]` 直接加/后缀
和`"regex_uri": ["^/prefix/service(.+)", "/service$1"]`
目前我已经通过配置两条路由解决了，能满足我的要求
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] ieayoio commented on issue #4376: request help: How to use proxy-rewrite add multiple regex_uri property
ieayoio commented on issue #4376:
URL: https://github.com/apache/apisix/issues/4376#issuecomment-854739198
其实我提出这个问题起因并没有这么复杂，只是通过快速入门，想在我原服务的基础上加一个前缀
例如原服务(tomcat)：
```
http://host2:8080/service/
```
加前缀用如下形式替代:
```
http://host1:9080/prefix/service/
```
我进行了如下配置
```json
"proxy-rewrite": {
"regex_uri": ["^/prefix/service(.*)", "/service$1"]
}
```
当我访问http://host1:9080/prefix/service/，一切正常，我访问到了原服务http://host2:8080/service/的内容
问题出现在我访问http://host1:9080/prefix/service (没有了结尾的"/")
浏览器url却直接跳转到了http://host1:9080/service/，当然这个无法访问的
我分析原因，问题出现在原服务访问http://host2:8080/service会加/跳转到http://host2:8080/service/
因此，我任务最适合我的是配置两个regex_uri
分别为`"regex_uri": ["^/prefix/service", "/service/"]` 直接加/后缀
和`"regex_uri": ["^/prefix/service(.+)", "/service$1"]`
目前我已经通过配置两条路由解决了，能满足我的要求
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] ak476565 commented on issue #2156: bug: can not run apisix on ARM
ak476565 commented on issue #2156: URL: https://github.com/apache/apisix/issues/2156#issuecomment-854736282 @moonming Can you share your ARM64 image of Apisix on DockerHub? I'm having problems compiling. thank you https://user-images.githubusercontent.com/3871722/120811186-4ccd3480-c57e-11eb-9b32-289c0c0a2777.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: feat: support customzing worker's user
ysc972 commented on a change in pull request #4362: URL: https://github.com/apache/apisix/pull/4362#discussion_r645572682 ## File path: docs/zh/latest/FAQ.md ## @@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain ``` 详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351 + +## 如何在kylin v10 国产操作系统运行apisix Review comment: I have removed this FAQ and committed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #2720: request help: Apache APISIX support gzip
tzssangglass commented on issue #2720: URL: https://github.com/apache/apisix/issues/2720#issuecomment-854721228 > I found that brotli is not work when i already compiled with google/ngx_brotli in openresty, and 'proxy_set_header Accept-Encoding ""' was setted by proxy-rewrite. The content was not encoded in gzip either. supported, please try this compile script https://github.com/api7/apisix-build-tools/blob/792a61f3de2e23b124c92f34c975d1e6ce753498/build-apisix-openresty.sh#L80 to compile the `http_gzip_static_module` . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #6: feat: customize logger
spacewander merged pull request #6: URL: https://github.com/apache/apisix-go-plugin-runner/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-go-plugin-runner] branch master updated: feat: customize logger (#6)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-go-plugin-runner.git
The following commit(s) were added to refs/heads/master by this push:
new c0b2ae7 feat: customize logger (#6)
c0b2ae7 is described below
commit c0b2ae72efeb4d220a40832aaac7ca090ea9bbae
Author: 罗泽轩
AuthorDate: Fri Jun 4 21:12:55 2021 +0800
feat: customize logger (#6)
---
.gitignore | 1 +
cmd/go-runner/main.go | 54 +++--
go.mod | 1 +
go.sum | 23
internal/log/log.go | 28 ---
internal/server/server.go | 6 ++--
internal/log/log.go => pkg/runner/runner.go | 49 +-
7 files changed, 112 insertions(+), 50 deletions(-)
diff --git a/.gitignore b/.gitignore
index af0f1bb..d3ab02b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,3 +5,4 @@ release/
.idea
.DS_Store
coverage.txt
+logs/
diff --git a/cmd/go-runner/main.go b/cmd/go-runner/main.go
index 74851db..881dbc1 100644
--- a/cmd/go-runner/main.go
+++ b/cmd/go-runner/main.go
@@ -17,11 +17,15 @@ package main
import (
"fmt"
"io"
+ "log"
"os"
+ "path/filepath"
"github.com/spf13/cobra"
+ "github.com/thediveo/enumflag"
+ "go.uber.org/zap/zapcore"
- "github.com/apache/apisix-go-plugin-runner/internal/server"
+ "github.com/apache/apisix-go-plugin-runner/pkg/runner"
)
var (
@@ -46,14 +50,60 @@ func newVersionCommand() *cobra.Command {
return cmd
}
+type RunMode enumflag.Flag
+
+const (
+ Dev RunMode = iota // Development
+ Prod// Product
+
+ LogFilePath = "./logs/runner.log"
+)
+
+var RunModeIds = map[RunMode][]string{
+ Prod: {"prod"},
+ Dev: {"dev"},
+}
+
+func openFileToWrite(name string) (*os.File, error) {
+ dir := filepath.Dir(name)
+ if dir != "." {
+ err := os.MkdirAll(dir, 0755)
+ if err != nil {
+ return nil, err
+ }
+ }
+ f, err := os.OpenFile(name, os.O_WRONLY|os.O_CREATE|os.O_APPEND, 0644)
+ if err != nil {
+ return nil, err
+ }
+
+ return f, nil
+}
+
func newRunCommand() *cobra.Command {
+ var mode RunMode
cmd := {
Use: "run",
Short: "run",
Run: func(cmd *cobra.Command, _ []string) {
- server.Run()
+ cfg := runner.RunnerConfig{}
+ if mode == Prod {
+ cfg.LogLevel = zapcore.WarnLevel
+ f, err := openFileToWrite(LogFilePath)
+ if err != nil {
+ log.Fatalf("failed to open log: %s",
err)
+ }
+ cfg.LogOutput = f
+ }
+ runner.Run(cfg)
},
}
+
+ cmd.PersistentFlags().VarP(
+ enumflag.New(, "mode", RunModeIds,
enumflag.EnumCaseInsensitive),
+ "mode", "m",
+ "the runner's run mode; can be 'prod' or 'dev', default to
'dev'")
+
return cmd
}
diff --git a/go.mod b/go.mod
index 34ee1d0..f24abab 100644
--- a/go.mod
+++ b/go.mod
@@ -8,6 +8,7 @@ require (
github.com/google/flatbuffers v2.0.0+incompatible
github.com/spf13/cobra v1.1.3
github.com/stretchr/testify v1.7.0
+ github.com/thediveo/enumflag v0.10.1
go.uber.org/multierr v1.7.0 // indirect
go.uber.org/zap v1.16.0
)
diff --git a/go.sum b/go.sum
index 4e96f53..a2e52a5 100644
--- a/go.sum
+++ b/go.sum
@@ -23,6 +23,7 @@ github.com/alvaroloes/enumer v1.1.2/go.mod
h1:FxrjvuXoDAx9isTJrv4c+T410zFi0DtXIT
github.com/api7/ext-plugin-proto v0.1.4
h1:gxw+fmtM2UPsSku+mEOFNTQpAGEOKrkWZvQgIcglaG0=
github.com/api7/ext-plugin-proto v0.1.4/go.mod
h1:8dbdAgCESeqwZ0IXirbjLbshEntmdrAX3uet+LW3jVU=
github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e/go.mod
h1:3U/XgcO3hCbHZ8TKRvWD2dDTCfh9M9ya+I9JpbB7O8o=
+github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod
h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8=
github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da/go.mod
h1:Q73ZrmVTwzkszR9V5SSuryQ31EELlFMUz1kKyl939pY=
github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod
h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8=
github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod
h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=
@@ -32,7 +33,9 @@ github.com/bketelsen/crypt
v0.0.3-0.20200106085610-5cbc8cc4026c/go.mod h1:MKsuJm
github.com/cespare/xxhash v1.1.0/go.mod
[GitHub] [apisix] spacewander closed issue #4376: request help: How to use proxy-rewrite add multiple regex_uri property
spacewander closed issue #4376: URL: https://github.com/apache/apisix/issues/4376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4376: request help: How to use proxy-rewrite add multiple regex_uri property
spacewander commented on issue #4376: URL: https://github.com/apache/apisix/issues/4376#issuecomment-854711992 Is this general enough to put it into proxy-rewrite? If it is for a special purpose, we can do it via a custom plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: feat: support customzing worker's user
spacewander commented on a change in pull request #4362: URL: https://github.com/apache/apisix/pull/4362#discussion_r64376 ## File path: docs/zh/latest/FAQ.md ## @@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain ``` 详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351 + +## 如何在kylin v10 国产操作系统运行apisix Review comment: We need an official confirm for the FAQ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jxhecong commented on issue #2720: request help: Apache APISIX support gzip
jxhecong commented on issue #2720: URL: https://github.com/apache/apisix/issues/2720#issuecomment-854706133 I found that brotli is not work when i already compiled with google/ngx_brotli in openresty, and 'proxy_set_header Accept-Encoding ""' was setted by proxy-rewrite. The content was not encoded in gzip either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jxhecong commented on issue #2720: request help: Apache APISIX support gzip
jxhecong commented on issue #2720: URL: https://github.com/apache/apisix/issues/2720#issuecomment-854696777 How to turn on gzip in apisix ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4370: request help: An error is reported when the configuration is updated from etcd regularly
tokers commented on issue #4370: URL: https://github.com/apache/apisix/issues/4370#issuecomment-854619383 @xyz2b You may also show us the APISIX config.yaml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #92: add instruction on install apisix only and etcd cluster
tokers commented on issue #92: URL: https://github.com/apache/apisix-helm-chart/issues/92#issuecomment-854614074 @Yiyiyimu Have you ever tried to clone this repo and use the local helm chart templates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers merged pull request #4368: feat: upgrade protobuf to 0.3.2
tokers merged pull request #4368: URL: https://github.com/apache/apisix/pull/4368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: chore: upgrade protobuf to 0.3.2 (#4368)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 10677e9 chore: upgrade protobuf to 0.3.2 (#4368)
10677e9 is described below
commit 10677e9067b43fb3b2555c917c322b4454b22c77
Author: yuhongyu879 <31095891+yuhongyu...@users.noreply.github.com>
AuthorDate: Fri Jun 4 18:48:31 2021 +0800
chore: upgrade protobuf to 0.3.2 (#4368)
Co-authored-by: leonnyu
---
apisix/plugins/grpc-transcode/proto.lua | 7 ++-
rockspec/apisix-master-0.rockspec | 2 +-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/apisix/plugins/grpc-transcode/proto.lua
b/apisix/plugins/grpc-transcode/proto.lua
index 83b6f38..9f82890 100644
--- a/apisix/plugins/grpc-transcode/proto.lua
+++ b/apisix/plugins/grpc-transcode/proto.lua
@@ -43,7 +43,12 @@ local function create_proto_obj(proto_id)
end
local _p = protoc.new()
-local res = _p:load(content)
+-- the loaded proto won't appears in _p.loaded without a file name after
lua-protobuf=0.3.2,
+-- which means _p.loaded after _p:load(content) is always empty, so we can
pass a fake file
+-- name to keep the code below unchanged, or we can create our own load
function with returning
+-- the loaded DescriptorProto table additionally, see more details in
+-- https://github.com/apache/apisix/pull/4368
+local res = _p:load(content, "filename for loaded")
if not res or not _p.loaded then
return nil, "failed to load proto content"
diff --git a/rockspec/apisix-master-0.rockspec
b/rockspec/apisix-master-0.rockspec
index 6207610..f91ba68 100644
--- a/rockspec/apisix-master-0.rockspec
+++ b/rockspec/apisix-master-0.rockspec
@@ -45,7 +45,7 @@ dependencies = {
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
"lua-resty-radixtree = 2.8.0",
-"lua-protobuf = 0.3.1",
+"lua-protobuf = 0.3.2",
"lua-resty-openidc = 1.7.2-1",
"luafilesystem = 1.7.0-2",
"lua-tinyyaml = 1.0",
[GitHub] [apisix] tokers commented on a change in pull request #4191: fix: enable etcd health-check
tokers commented on a change in pull request #4191: URL: https://github.com/apache/apisix/pull/4191#discussion_r645476306 ## File path: apisix/core/config_etcd.lua ## @@ -545,7 +558,34 @@ local function _automatic_fetch(premature, self) local ok, err = sync_data(self) if err then -if err ~= "timeout" and err ~= "Key not found" +if string.find(err, "connection refused") +or string.find(err, "Service Unavailable") then +log.warn(err, ", ", tostring(self)) Review comment: Then the error message should be more semantic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4376: request help: How to use proxy-rewrite add multiple regex_uri property
tokers commented on issue #4376: URL: https://github.com/apache/apisix/issues/4376#issuecomment-854610460 @ieayoio Currently, we have to use multiple routes to meet your demands. Also, PR's welcome to extend proxy-rewrite plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1933: On the front end, the websocket button is useless
iamayushdas commented on issue #1933: URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-854558826 Checking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: feat: support customzing worker's user
ysc972 commented on a change in pull request #4362: URL: https://github.com/apache/apisix/pull/4362#discussion_r645448468 ## File path: docs/zh/latest/FAQ.md ## @@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain ``` 详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351 + +## 如何在kylin v10 国产操作系统运行apisix Review comment: But in the Chinese arm OS , if we do not change this config, the apisix cannot run . It will throw "require faild" error like issue #4157. So should we write something in the FAQ to tell someone who uses apisix in Chinese arm OS how to resolve the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #529: fix: nil pointer dereference
codecov-commenter commented on pull request #529: URL: https://github.com/apache/apisix-ingress-controller/pull/529#issuecomment-854538608 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#529](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (668913c) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f6cb4f9a0300b13ee586a9536623962d183d9d6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f6cb4f9) will **increase** coverage by `0.16%`. > The diff coverage is `0.00%`. > :exclamation: Current head 668913c differs from pull request most recent head 9f0e769. Consider uploading reports for the commit 9f0e769 to get more accurate results [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #529 +/- ## == + Coverage 34.82% 34.98% +0.16% == Files 54 54 Lines4497 4499 +2 == + Hits 1566 1574 +8 + Misses 2716 2713 -3 + Partials 215 212 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.12% <0.00%> (-0.01%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `25.17% <0.00%> (+1.79%)` | :arrow_up: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `35.29% <0.00%> (+2.20%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [2bf4b6b...9f0e769](https://codecov.io/gh/apache/apisix-ingress-controller/pull/529?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou opened a new issue #1934: After configuring redirect in route, dashboard cannot run normally
Firstsawyou opened a new issue #1934: URL: https://github.com/apache/apisix-dashboard/issues/1934 ## Issue description After configuring the redirection in the route, click Edit `Route` again. Dashboard does not work normally, and then the Dashboard page crashes. ## Expected behavior After configuring `redirect` in the configuration of `Route`, Dashboard can work correctly. ## How to Reproduce 1. Configure redirect in route https://user-images.githubusercontent.com/52862365/120780741-fb5f7e00-c55a-11eb-960f-14e37c062d7a.png;> https://user-images.githubusercontent.com/52862365/120780786-03b7b900-c55b-11eb-9d8e-63152179bb54.png;> 2. Edit the route again and any data at noon on the page https://user-images.githubusercontent.com/52862365/120781147-5c875180-c55b-11eb-804d-934ea52bac67.png;> 3. Clicking on the other options of Dashboard is invalid and the page is abnormal https://user-images.githubusercontent.com/52862365/120781211-6b6e0400-c55b-11eb-986b-ec00befd9293.png;> https://user-images.githubusercontent.com/52862365/120781228-732da880-c55b-11eb-9f43-74c2ec638b6d.png;> ## Screenshots ## Environment * apisix version (cmd: `apisix version`): 2.5 * OS (cmd: `uname -a`): Linux * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): 1.19.3 * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): 3.4.0 * apisix-dashboard version, if have: 2.6 * Browser version, if have: ## Additional context -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: route search test optimised (#1928)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new a72bed2 fix: route search test optimised (#1928)
a72bed2 is described below
commit a72bed254c90179bc7d315e1e5847eb241760caf
Author: Ayush das
AuthorDate: Fri Jun 4 14:43:52 2021 +0530
fix: route search test optimised (#1928)
---
web/cypress/integration/route/search-route.spec.js | 23 ++
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/web/cypress/integration/route/search-route.spec.js
b/web/cypress/integration/route/search-route.spec.js
index 5c170e3..e0b7898 100644
--- a/web/cypress/integration/route/search-route.spec.js
+++ b/web/cypress/integration/route/search-route.spec.js
@@ -29,8 +29,8 @@ context('Create and Search Route', () => {
nodes_0_host: '#nodes_0_host',
nodes_0_port: '#nodes_0_port',
nodes_0_weight: '#nodes_0_weight',
-nameSearch: '[title=Name]',
-pathSearch: '[title=Path]',
+nameSearchInput: '#name',
+pathSearchInput: '#uri',
labelSelect_0: '.ant-select-selection-overflow',
dropdown: '.rc-virtual-list',
disabledSwitcher: '#disable',
@@ -114,21 +114,19 @@ context('Create and Search Route', () => {
cy.visit('/');
cy.contains('Route').click();
// full match
-cy.get(selector.nameSearch).type(data.test1);
+cy.get(selector.nameSearchInput).type(data.test1);
cy.contains('Search').click();
cy.contains(data.test1).siblings().should('contain', data.desc1);
cy.contains(data.test0).should('not.exist');
cy.contains(data.test2).should('not.exist');
// partial match
-cy.reload();
-cy.get(selector.nameSearch).type(data.test);
+cy.get(selector.nameSearchInput).clear().type(data.test);
cy.contains('Search').click();
cy.contains(data.test0).siblings().should('contain', data.desc0);
cy.contains(data.test1).siblings().should('contain', data.desc1);
cy.contains(data.test2).siblings().should('contain', data.desc2);
// no match
-cy.reload();
-cy.get(selector.nameSearch).type(data.testx);
+cy.get(selector.nameSearchInput).clear().type(data.testx);
cy.contains('Search').click();
cy.contains(data.test0).should('not.exist');
cy.contains(data.test1).should('not.exist');
@@ -139,21 +137,19 @@ context('Create and Search Route', () => {
cy.visit('/');
cy.contains('Route').click();
// full match
-cy.get(selector.pathSearch).type(data.uris1);
+cy.get(selector.pathSearchInput).type(data.uris1);
cy.contains('Search').click();
cy.contains(data.uris1).should('contain', data.uris1);
cy.contains(data.uris0).should('not.exist');
cy.contains(data.uris2).should('not.exist');
// partial match
-cy.reload();
-cy.get(selector.pathSearch).type(data.uris);
+cy.get(selector.pathSearchInput).clear().type(data.uris);
cy.contains('Search').click();
cy.contains(data.uris0).should('contain', data.uris);
cy.contains(data.uris1).should('contain', data.uris);
cy.contains(data.uris2).should('contain', data.uris);
// no match
-cy.reload();
-cy.get(selector.pathSearch).type(data.urisx);
+cy.get(selector.pathSearchInput).clear().type(data.urisx);
cy.contains('Search').click();
cy.contains(data.uris0).should('not.exist');
cy.contains(data.uris1).should('not.exist');
@@ -161,8 +157,9 @@ context('Create and Search Route', () => {
});
it('should search the route with labels', function () {
+cy.visit('/');
+cy.contains('Route').click();
// search one label
-cy.reload();
cy.get(selector.expandSearch).click();
cy.get(selector.labelSelect_0).click({ timeout });
cy.get(selector.dropdown).contains(data.value0).should('be.visible').click();
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #529: fix: nil pointer dereference
tao12345666333 opened a new pull request #529: URL: https://github.com/apache/apisix-ingress-controller/pull/529 Signed-off-by: Jintao Zhang Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix This was introduced through #516 while resolving the conflict. :crying_cat_face: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4377: refactor: use plugin_attr to fetch plugin attribute
spacewander opened a new pull request #4377: URL: https://github.com/apache/apisix/pull/4377 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #528: Feat ar add auth
tao12345666333 opened a new pull request #528: URL: https://github.com/apache/apisix-ingress-controller/pull/528 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: feat: support customzing worker's user
spacewander commented on a change in pull request #4362: URL: https://github.com/apache/apisix/pull/4362#discussion_r645399311 ## File path: docs/zh/latest/FAQ.md ## @@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain ``` 详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351 + +## 如何在kylin v10 国产操作系统运行apisix Review comment: I think we can remove the FAQ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ieayoio opened a new issue #4376: request help: How to use proxy-rewrite add multiple regex_uri property
ieayoio opened a new issue #4376: URL: https://github.com/apache/apisix/issues/4376 怎么在插件proxy-rewrite配置多个regex_uri实现不同url转发到不同的路径下 例如： url：http://host1:9080/samplePrefix/get/service1 转发到 http://host2:8080/test url：http://host1:9080/samplePrefix/get/service2 转发到 http://host2:8080/service 是不是只能做两条路由实现 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
ysc972 commented on a change in pull request #4362: URL: https://github.com/apache/apisix/pull/4362#discussion_r645397149 ## File path: docs/zh/latest/FAQ.md ## @@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain ``` 详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351 + +## 如何在kylin v10 国产操作系统运行apisix Review comment: Need I submit a new PR or change FAQ file in this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] heyanlong commented on a change in pull request #430: ci: introduce skywalking-eyes
heyanlong commented on a change in pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r645373562 ## File path: .github/workflows/license-checker.yml ## @@ -14,7 +32,7 @@ jobs: steps: - uses: actions/checkout@v2 - - - name: run license check -run: | - make license-check + - name: Check License Header +uses: apache/skywalking-eyes@v0.1.0 Review comment: Maybe it is more appropriate to use `apache/skywalking-eyes@main` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yuhongyu879 edited a comment on pull request #4368: feat: upgrade protobuf to 0.3.2
yuhongyu879 edited a comment on pull request #4368: URL: https://github.com/apache/apisix/pull/4368#issuecomment-854455158 @spacewander Whom could i ask for another approving? It says that 'Only reviews by reviewers with write access count toward mergeability' on @Firstsawyou 's approving -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1932: feat: split cmd package code
codecov-commenter edited a comment on pull request #1932: URL: https://github.com/apache/apisix-dashboard/pull/1932#issuecomment-854380711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1932: feat: split cmd package code
netlify[bot] commented on pull request #1932: URL: https://github.com/apache/apisix-dashboard/pull/1932#issuecomment-854379989 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: 470a86f5aea0f860af9354d5045142544a01ce83 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60b9bfaf912471000745a2a6](https://app.netlify.com/sites/apisix-dashboard/deploys/60b9bfaf912471000745a2a6?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3444: bug: when etcd down, apisix would keep printing error log
spacewander commented on issue #3444: URL: https://github.com/apache/apisix/issues/3444#issuecomment-854463379 Consider solved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xyz2b edited a comment on issue #4370: request help: An error is reported when the configuration is updated from etcd regularly
xyz2b edited a comment on issue #4370: URL: https://github.com/apache/apisix/issues/4370#issuecomment-854352089 Reinstalled apisix openresty and apisix, the problem remains. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] heyanlong commented on pull request #430: ci: introduce skywalking-eyes
heyanlong commented on pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-854469070 Please check if read and write permissions are set `Settings` -> `Actions` -> `Runners` -> `Workflow permissions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] starsz merged pull request #527: fix: add namespace for the ServiceAccount reference in ClusterRoleBinding
starsz merged pull request #527: URL: https://github.com/apache/apisix-ingress-controller/pull/527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4191: fix: enable etcd health-check
spacewander commented on a change in pull request #4191:
URL: https://github.com/apache/apisix/pull/4191#discussion_r645384366
##
File path: apisix/core/config_etcd.lua
##
@@ -545,7 +558,34 @@ local function _automatic_fetch(premature, self)
local ok, err = sync_data(self)
if err then
-if err ~= "timeout" and err ~= "Key not found"
+if string.find(err, "connection refused")
+or string.find(err, "Service Unavailable") then
+log.warn(err, ", ", tostring(self))
+local etcd_cli, err = get_etcd(true)
+if not etcd_cli then
+error("all etcd endpoints are unhealthy: " .. err)
+end
+self.etcd_cli = etcd_cli
+log.warn("changed to new etcd endpoint")
+elseif string.find(err, "has no healthy etcd endpoint
available") then
+log.warn(err, ", ", tostring(self))
+local reconnected = false
+while err and not reconnected do
+local backoff_duration, backoff_factor, backoff_step =
1, 2, 10
+for _ = 0, backoff_step, 1 do
+ngx_sleep(backoff_duration)
+_, err = sync_data(self)
+if not string.find(err, "has no healthy etcd
endpoint available") then
Review comment:
The `err` can be nil which will cause `find` to throw an error
##
File path: apisix/core/config_etcd.lua
##
@@ -529,6 +531,17 @@ local function _automatic_fetch(premature, self)
return
end
+if not health_check.conf then
Review comment:
Is it because fail_timeout takes effect?
https://github.com/api7/lua-resty-etcd/blob/1fe01f77dda252f2d95eed0a7635f3479097b8ed/lib/resty/etcd/health_check.lua#L34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1932: feat: split cmd package code
codecov-commenter commented on pull request #1932: URL: https://github.com/apache/apisix-dashboard/pull/1932#issuecomment-854380711 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1932?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1932](https://codecov.io/gh/apache/apisix-dashboard/pull/1932?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (470a86f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9850df28b9539713566849069ba093b6be7c3be7?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9850df2) will **decrease** coverage by `14.54%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1932?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1932 +/- ## === - Coverage 67.02% 52.48% -14.55% === Files 169 38 -131 Lines6317 2679 -3638 Branches 7480 -748 === - Hits 4234 1406 -2828 + Misses 1831 1085 -746 + Partials 252 188 -64 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.48% <0.00%> (+0.01%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1932?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1932/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (ø)` | | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1932/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1932/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1932/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1932/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1932/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1932/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1932/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) |
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
dmsolr commented on a change in pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r645388528 ## File path: .github/workflows/license-checker.yml ## @@ -14,7 +32,7 @@ jobs: steps: - uses: actions/checkout@v2 - - - name: run license check -run: | - make license-check + - name: Check License Header +uses: apache/skywalking-eyes@v0.1.0 Review comment: fixed by #510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yuhongyu879 commented on pull request #4368: feat: upgrade protobuf to 0.3.2
yuhongyu879 commented on pull request #4368: URL: https://github.com/apache/apisix/pull/4368#issuecomment-854455158 @spacewander Whom could i ask for approving? It says that 'Only reviews by reviewers with write access count toward mergeability' on @Firstsawyou 's approving -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1932: feat: split cmd package code
netlify[bot] edited a comment on pull request #1932: URL: https://github.com/apache/apisix-dashboard/pull/1932#issuecomment-854379989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on pull request #430: ci: introduce skywalking-eyes
dmsolr commented on pull request #430: URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-854476751 > Please check if read and write permissions are set > > `Settings` -> `Actions` -> `Runners` -> `Workflow permissions` Thank you, @heyanlong . The author of skywalking-eyes told me, because of github action limitation, auto-comment bot cannot work while the PR from the fork repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3444: bug: when etcd down, apisix would keep printing error log
spacewander closed issue #3444: URL: https://github.com/apache/apisix/issues/3444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hozaifaaoud edited a comment on issue #4374: request help: cloudflare forward request
hozaifaaoud edited a comment on issue #4374: URL: https://github.com/apache/apisix/issues/4374#issuecomment-854315112 I changed the "X-Real-IP" to "CF-Connecting-IP" and also tried "True-Client-IP" and both are not working ... could you please help? I checked the logs and found that the IP received by apisix is"172.17.0.2" and the machine IP that I sent the request from is "41.232.211.202" ... I also registered this IP "41.232.211.202" in the ip-restriction plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] GoneGo1ng commented on issue #4375: request help: ‘v1/healthcheck’ returns an empty json
GoneGo1ng commented on issue #4375:
URL: https://github.com/apache/apisix/issues/4375#issuecomment-854321450
> etcdctl get --prefix /apisix/upstreams
```
/apisix/upstreams/
init_dir
/apisix/upstreams/357655931518976703
{
"name": "httpbin-upstream",
"scheme": "http",
"type": "roundrobin",
"pass_host": "pass",
"hash_on": "vars",
"id": "357655931518976703",
"nodes": [
{
"weight": 1,
"port": ,
"host": "172.16.65.34",
"priority": 0
},
{
"weight": 1,
"port": 7778,
"host": "172.16.65.34",
"priority": 0
}
],
"update_time": 1622719457,
"timeout": {
"connect": 6,
"send": 6,
"read": 6
},
"checks": {
"active": {
"concurrency": 10,
"http_path": "\/ping",
"https_verify_certificate": true,
"timeout": 5,
"healthy": {
"successes": 1,
"http_statuses": [
200,
201
],
"interval": 5
},
"type": "http",
"unhealthy": {
"http_statuses": [
400,
404,
500
],
"http_failures": 2,
"tcp_failures": 2,
"timeouts": 3,
"interval": 5
}
}
},
"create_time": 1622709147
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on issue #4341: ci: update `cancel-workflow-actions` to concurrency in github actions
Yiyiyimu commented on issue #4341: URL: https://github.com/apache/apisix/issues/4341#issuecomment-854268294 Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4374: request help: cloudflare forward request
spacewander commented on issue #4374: URL: https://github.com/apache/apisix/issues/4374#issuecomment-854300577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1907: feat: Use monaco editor
liuxiran commented on a change in pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#discussion_r644386553
##
File path:
web/cypress/integration/consumer/create-consumer-with-api-breaker-plugin-form.spec.js
##
@@ -60,17 +59,13 @@ context('Create and delete consumer with api-breaker plugin
form', () => {
});
cy.focused(selector.drawer).should('exist');
cy.get(selector.disabledSwitcher).click();
-// edit codemirror
-cy.get(selector.codeMirror)
- .first()
- .then((editor) => {
-editor[0].CodeMirror.setValue(
- JSON.stringify({
-key: 'test',
- }),
-);
-cy.contains('button', 'Submit').click();
- });
+
+// edit monaco
+cy.window().then((window) => {
+ cy.waitUntil(() => window.monacoEditor)
Review comment:
hi @qian0817, I noticed you import a new lib `cypress-wait-until`, could
you please also offer some useful references about why you choose this lib, and
Introduce the risks it can pose and its usage scenarios, that would helpful for
reviewers and other developers, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] starsz merged pull request #91: docs: fix install docs
starsz merged pull request #91: URL: https://github.com/apache/apisix-helm-chart/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou removed a comment on issue #4366: request help: Why is it wrong when I modify the URI of the route
Firstsawyou removed a comment on issue #4366:
URL: https://github.com/apache/apisix/issues/4366#issuecomment-853633040
You can do this:
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PATCH -i -d '{
"uri": null,
"uris": ["/a","/b"]
}'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #5: chore: add Codecov badge
codecov-commenter commented on pull request #5: URL: https://github.com/apache/apisix-go-plugin-runner/pull/5#issuecomment-853689321 # [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/5?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#5](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/5?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (05bdb07) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/5e186f907ee5d8aa00deed3c9efd887b40abce85?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5e186f9) will **decrease** coverage by `2.12%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/5?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #5 +/- ## == - Coverage 82.03% 79.90% -2.13% == Files 88 Lines 423 423 == - Hits 347 338 -9 - Misses 57 64 +7 - Partials 19 21 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/5?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/5/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `49.51% <0.00%> (-8.74%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/5?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/5?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [5e186f9...05bdb07](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/5?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] suifff closed issue #1930: request help: apisix cannot use CORS plug-in after upgrading from 2.0 to 2.5 and partial route failure
suifff closed issue #1930: URL: https://github.com/apache/apisix-dashboard/issues/1930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #4369: check duplicate service to avoid duplicate creation
spacewander closed issue #4369: URL: https://github.com/apache/apisix/issues/4369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1929: ci: use concurrency to cancel workflow
netlify[bot] commented on pull request #1929: URL: https://github.com/apache/apisix-dashboard/pull/1929#issuecomment-853505680 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: d8e34bc657f1aea68493f8ea535a73689de4f0e6 :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60b83a04af300f00078baa5a](https://app.netlify.com/sites/apisix-dashboard/deploys/60b83a04af300f00078baa5a?utm_source=github_campaign=bot_dl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4372: request help:
tokers commented on issue #4372: URL: https://github.com/apache/apisix/issues/4372#issuecomment-854302201 @hozaifaaoud Try `0.0.0.0/0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hozaifaaoud commented on issue #4372: request help:
hozaifaaoud commented on issue #4372: URL: https://github.com/apache/apisix/issues/4372#issuecomment-854128049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers merged pull request #4364: ci: use concurrency to cancel duplicate workflow
tokers merged pull request #4364: URL: https://github.com/apache/apisix/pull/4364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1893: feat: add api of config migrate, export and import
codecov-commenter edited a comment on pull request #1893: URL: https://github.com/apache/apisix-dashboard/pull/1893#issuecomment-840227725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1907: feat: Use monaco editor
qian0817 commented on a change in pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#discussion_r644761722
##
File path:
web/cypress/integration/consumer/create-consumer-with-api-breaker-plugin-form.spec.js
##
@@ -60,17 +59,13 @@ context('Create and delete consumer with api-breaker plugin
form', () => {
});
cy.focused(selector.drawer).should('exist');
cy.get(selector.disabledSwitcher).click();
-// edit codemirror
-cy.get(selector.codeMirror)
- .first()
- .then((editor) => {
-editor[0].CodeMirror.setValue(
- JSON.stringify({
-key: 'test',
- }),
-);
-cy.contains('button', 'Submit').click();
- });
+
+// edit monaco
+cy.window().then((window) => {
+ cy.waitUntil(() => window.monacoEditor)
Review comment:
@liuxiran I need to wait for `window.monacoEditor` to be set which means
monaco editor is initialized successfully. Can you tell me any better way to
achieve this, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz merged pull request #1929: ci: use concurrency to cancel duplicate workflow
starsz merged pull request #1929: URL: https://github.com/apache/apisix-dashboard/pull/1929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4370: request help: An error is reported when the configuration is updated from etcd regularly
spacewander commented on issue #4370: URL: https://github.com/apache/apisix/issues/4370#issuecomment-854296181 It is strange. The TLS handshake in the init phase doesn't use the `lua_ssl_trusted_certificate` directly. It just uses the configured CA: https://github.com/apache/apisix/blob/c61261af8d19557b77535c9c745f4f8182bb63b2/apisix/patch.lua#L207-L210 I try with self-signed certificate locally and can't reproduce it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] fregie commented on pull request #1893: feat: add api of config migrate, export and import
fregie commented on pull request #1893: URL: https://github.com/apache/apisix-dashboard/pull/1893#issuecomment-853895422 Resolved,please check it. @starsz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
ysc972 commented on a change in pull request #4362: URL: https://github.com/apache/apisix/pull/4362#discussion_r644456291 ## File path: apisix/cli/ngx_tpl.lua ## @@ -19,6 +19,8 @@ return [=[ # Configuration File - Nginx Server Configs # This is a read-only file, do not try to modify it. +user root; Review comment: I have add a configuration field in `config-default.yaml`,and add `How to run APISIX on the Chinese OS` to FAQ. ## File path: docs/zh/latest/FAQ.md ## @@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain ``` 详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351 + +## 如何在kylin v10 国产操作系统运行apisix Review comment: Officials don't know about this problem, it's just my adaptation to the kylin v10 OS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4191: fix: enable etcd health-check
tokers commented on a change in pull request #4191: URL: https://github.com/apache/apisix/pull/4191#discussion_r645242854 ## File path: apisix/core/config_etcd.lua ## @@ -545,7 +558,34 @@ local function _automatic_fetch(premature, self) local ok, err = sync_data(self) if err then -if err ~= "timeout" and err ~= "Key not found" +if string.find(err, "connection refused") +or string.find(err, "Service Unavailable") then +log.warn(err, ", ", tostring(self)) Review comment: Is this for debugging purpose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #526: docs: add docs about Ingress feature comparison
tokers commented on a change in pull request #526: URL: https://github.com/apache/apisix-ingress-controller/pull/526#discussion_r644508898 ## File path: README.md ## @@ -47,6 +47,8 @@ This project is currently considered experimental. * Ingress controller itself as a pluggable hot-reload component. * Multi-cluster configuration distribution. +[More about Ingress feature comparison.](https://docs.google.com/spreadsheets/d/191WWNpjJ2za6-nbG4ZoUMXMpUK8KlCIosvQB0f-oq3k/edit?ts=5fd6c769#gid=907731238) Review comment: ```suggestion [More about comparison among multiple Ingress Controllers](https://docs.google.com/spreadsheets/d/191WWNpjJ2za6-nbG4ZoUMXMpUK8KlCIosvQB0f-oq3k/edit?ts=5fd6c769#gid=907731238). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Yiyiyimu commented on pull request #1929: ci: use concurrency to cancel duplicate workflow
Yiyiyimu commented on pull request #1929: URL: https://github.com/apache/apisix-dashboard/pull/1929#issuecomment-853506804 Workflow canceled as expected: https://github.com/apache/apisix-dashboard/actions/runs/901331504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1893: feat: add api of config migrate, export and import
netlify[bot] edited a comment on pull request #1893: URL: https://github.com/apache/apisix-dashboard/pull/1893#issuecomment-839915322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #6: feat: customize logger
codecov-commenter commented on pull request #6: URL: https://github.com/apache/apisix-go-plugin-runner/pull/6#issuecomment-854338144 # [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#6](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (23265ce) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/5e186f907ee5d8aa00deed3c9efd887b40abce85?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5e186f9) will **decrease** coverage by `6.63%`. > The diff coverage is `32.00%`. [](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #6 +/- ## == - Coverage 82.03% 75.39% -6.64% == Files 88 Lines 423 443 +20 == - Hits 347 334 -13 - Misses 57 88 +31 - Partials 19 21 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [cmd/go-runner/main.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9tYWluLmdv) | `50.00% <22.72%> (-19.24%)` | :arrow_down: | | [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `40.77% <100.00%> (-17.48%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [5e186f9...23265ce](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/6?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj merged pull request #87: feat: add service monitor
gxthrj merged pull request #87: URL: https://github.com/apache/apisix-helm-chart/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
