[GitHub] [apisix-website] kezhenxu94 commented on pull request #624: WIP: chore: add preview branch condition
kezhenxu94 commented on pull request #624: URL: https://github.com/apache/apisix-website/pull/624#issuecomment-925541804 > Update: > Currently, we can't get the token through GitHub secret. We're looking for infra's help. Secrets are not passed into the fork repo, I don’t think this GitHub action would work as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #689: feat: init ApisixPluginConfig crd (#638)
tao12345666333 commented on a change in pull request #689: URL: https://github.com/apache/apisix-ingress-controller/pull/689#discussion_r714506786 ## File path: samples/deploy/crd/v1beta1/ApisixPluginConfig.yaml ## @@ -0,0 +1,64 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +apiVersion: apiextensions.k8s.io/v1beta1 +kind: CustomResourceDefinition +metadata: + name: apisixpluginconfigs.apisix.apache.org +spec: + group: apisix.apache.org + versions: +- name: v2alpha1 + served: true + storage: true + scope: Cluster Review comment: ```suggestion scope: Namespaced ``` We can set it to ns level, so as to avoid interference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #689: feat: init ApisixPluginConfig crd (#638)
tao12345666333 commented on a change in pull request #689:
URL:
https://github.com/apache/apisix-ingress-controller/pull/689#discussion_r714506395
##
File path: pkg/kube/apisix/apis/config/v2beta1/types.go
##
@@ -197,3 +197,35 @@ type ApisixRouteList struct {
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
+
+// +genclient
+// +genclient:nonNamespaced
Review comment:
Yes, we can set it to ns scope, so as to avoid interference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #689: feat: init ApisixPluginConfig crd (#638)
tao12345666333 commented on a change in pull request #689: URL: https://github.com/apache/apisix-ingress-controller/pull/689#discussion_r714502681 ## File path: samples/deploy/crd/v1beta1/ApisixPluginConfig.yaml ## @@ -0,0 +1,64 @@ +# Review comment: No, Currently `make codegen` does not generate CRD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #689: feat: init ApisixPluginConfig crd (#638)
tao12345666333 commented on a change in pull request #689:
URL:
https://github.com/apache/apisix-ingress-controller/pull/689#discussion_r714485988
##
File path: pkg/kube/apisix/apis/config/v2beta1/types.go
##
@@ -197,3 +197,35 @@ type ApisixRouteList struct {
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
+
+// +genclient
+// +genclient:nonNamespaced
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:subresource:status
+
+// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
+// An ApisixPluginConfig is used to support a group of plugin configs
+type ApisixPluginConfig struct {
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
+
+ // Spec defines the desired state of ApisixPluginConfigSpec.
+ Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
+ Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
+}
+
+// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
+type ApisixPluginConfigSpec struct {
+ Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`
+ // Plugins contains a list of ApisixRouteHTTPPluginConfig
+ Plugins []ApisixRouteHTTPPluginConfig `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
+}
+
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
+// ApisixPluginConfigList contains a list of ApisixPluginConfig.
+type ApisixPluginConfigList struct {
Review comment:
It can be deleted, no need for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang opened a new pull request #5122: feat: add rejected_message support for plugin request-validation
leslie-tsang opened a new pull request #5122: URL: https://github.com/apache/apisix/pull/5122 ### What this PR does / why we need it: Ref #5108 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #689: feat: init ApisixPluginConfig crd (#638)
tokers commented on a change in pull request #689:
URL:
https://github.com/apache/apisix-ingress-controller/pull/689#discussion_r714493943
##
File path: pkg/kube/apisix/apis/config/v2beta1/types.go
##
@@ -197,3 +197,35 @@ type ApisixRouteList struct {
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
+
+// +genclient
+// +genclient:nonNamespaced
Review comment:
IMHO it should be a namespaced resource.
##
File path: pkg/kube/apisix/apis/config/v2beta1/types.go
##
@@ -197,3 +197,35 @@ type ApisixRouteList struct {
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
+
+// +genclient
+// +genclient:nonNamespaced
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:subresource:status
+
+// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
+// An ApisixPluginConfig is used to support a group of plugin configs
+type ApisixPluginConfig struct {
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
+
+ // Spec defines the desired state of ApisixPluginConfigSpec.
+ Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
+ Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
+}
+
+// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
+type ApisixPluginConfigSpec struct {
+ Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`
Review comment:
We may add more constraints for this structure. See the JSON schema for
it: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L830
##
File path: pkg/kube/apisix/apis/config/v2beta1/types.go
##
@@ -197,3 +197,35 @@ type ApisixRouteList struct {
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
+
+// +genclient
+// +genclient:nonNamespaced
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:subresource:status
+
+// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
+// An ApisixPluginConfig is used to support a group of plugin configs
+type ApisixPluginConfig struct {
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
+
+ // Spec defines the desired state of ApisixPluginConfigSpec.
+ Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
+ Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
+}
+
+// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
+type ApisixPluginConfigSpec struct {
+ Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`
+ // Plugins contains a list of ApisixRouteHTTPPluginConfig
+ Plugins []ApisixRouteHTTPPluginConfig `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
+}
+
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
+// ApisixPluginConfigList contains a list of ApisixPluginConfig.
+type ApisixPluginConfigList struct {
Review comment:
Is this no longer used? Or how do we list ApisixPluginConfig?
##
File path: samples/deploy/crd/v1beta1/ApisixPluginConfig.yaml
##
@@ -0,0 +1,64 @@
+#
Review comment:
Is this generated by `make codegen`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] CGerAJ commented on pull request #2145: docs: update FAQ.md to include SPA deployment
CGerAJ commented on pull request #2145: URL: https://github.com/apache/apisix-dashboard/pull/2145#issuecomment-925529613 I get it,Deployment Spa with APSIX is not recommended -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] CGerAJ closed pull request #2145: docs: update FAQ.md to include SPA deployment
CGerAJ closed pull request #2145: URL: https://github.com/apache/apisix-dashboard/pull/2145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #689: feat: init ApisixPluginConfig crd (#638)
tao12345666333 commented on a change in pull request #689:
URL:
https://github.com/apache/apisix-ingress-controller/pull/689#discussion_r714488820
##
File path: pkg/kube/apisix/apis/config/v2beta1/types.go
##
@@ -197,3 +197,35 @@ type ApisixRouteList struct {
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
+
+// +genclient
+// +genclient:nonNamespaced
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:subresource:status
+
+// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
+// An ApisixPluginConfig is used to support a group of plugin configs
+type ApisixPluginConfig struct {
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
+
+ // Spec defines the desired state of ApisixPluginConfigSpec.
+ Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
+ Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
+}
+
+// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
+type ApisixPluginConfigSpec struct {
+ Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`
+ // Plugins contains a list of ApisixRouteHTTPPluginConfig
+ Plugins []ApisixRouteHTTPPluginConfig `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
+}
+
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
+// ApisixPluginConfigList contains a list of ApisixPluginConfig.
+type ApisixPluginConfigList struct {
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on a change in pull request #689: feat: init ApisixPluginConfig crd (#638)
neverCase commented on a change in pull request #689:
URL:
https://github.com/apache/apisix-ingress-controller/pull/689#discussion_r714486829
##
File path: pkg/kube/apisix/apis/config/v2beta1/types.go
##
@@ -197,3 +197,35 @@ type ApisixRouteList struct {
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
+
+// +genclient
+// +genclient:nonNamespaced
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:subresource:status
+
+// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
+// An ApisixPluginConfig is used to support a group of plugin configs
+type ApisixPluginConfig struct {
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
+
+ // Spec defines the desired state of ApisixPluginConfigSpec.
+ Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
+ Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
+}
+
+// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
+type ApisixPluginConfigSpec struct {
+ Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`
+ // Plugins contains a list of ApisixRouteHTTPPluginConfig
+ Plugins []ApisixRouteHTTPPluginConfig `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
+}
+
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
+// ApisixPluginConfigList contains a list of ApisixPluginConfig.
+type ApisixPluginConfigList struct {
Review comment:
do u meaning the `ApisixPluginConfigList`?
ok, i will delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #5122: feat: add rejected_message support for plugin request-validation
leslie-tsang commented on pull request #5122: URL: https://github.com/apache/apisix/pull/5122#issuecomment-925521983 @tokers Any comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhixiang0608 commented on issue #5120: apisix delay
zhixiang0608 commented on issue #5120:
URL: https://github.com/apache/apisix/issues/5120#issuecomment-925522143
{"id":"373703982817739720","create_time":1632274531,"update_time":1632274531,"uris":["/zymk-getuserinfo-api/*"],"name":"zymk-getuserinfo-api","methods":["GET","POST","PUT","DELETE","PATCH","HEAD","OPTIONS","CONNECT","TRACE"],"plugins":{"prometheus":{"disable":false,"prefer_name":true},"proxy-rewrite":{"headers":{"X-Api-Engine":"apisix","X-Api-Version":"v1"},"regex_uri":["^/zymk-getuserinfo-api/(.*)","/$1$2$3"]}},"upstream":{"nodes":[{"host":"172.21.24.51","port":7202,"weight":1}],"timeout":{"connect":6,"read":6,"send":6},"type":"roundrobin","scheme":"http","pass_host":"pass"},"status":1}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5103: request help: Apache APISIX with Secured Websockets
tzssangglass commented on issue #5103: URL: https://github.com/apache/apisix/issues/5103#issuecomment-925521026 > I created an SSL for my service (in a linux machine) but I cant find a way to connect my route to this SNI, any special instructions? here:https://github.com/apache/apisix/blob/master/docs/en/latest/certificate.md#single-sni -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase opened a new pull request #689: fix: init ApisixPluginConfig crd (#638)
neverCase opened a new pull request #689: URL: https://github.com/apache/apisix-ingress-controller/pull/689 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #638 ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 edited a comment on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925514670 You can open a PR and set it as draft status. Related discussions can be held in the PR, which will be more convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925514670 You can open a PR and set it as draf status. Related discussions can be held in the PR, which will be more convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on pull request #624: WIP: chore: add preview branch condition
bzp2010 commented on pull request #624: URL: https://github.com/apache/apisix-website/pull/624#issuecomment-925514673 Update: Currently, we can't get the token through GitHub secret. We're looking for infra's help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925507993 > @neverCase You can use `[]ApisixRouteHTTPPlugin` directly, no need to define the list yourself. before pr, should i make up the field `validation` in the `ApisixPluginConfig.yaml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925501421 @neverCase You can use `[]ApisixRouteHTTPPlugin` directly, no need to define the list yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 edited a comment on issue #638:
URL:
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925493450
You can open a PR and submit your current changes directly.
The PluginConfig document is here
https://apisix.apache.org/docs/apisix/architecture-design/plugin-config
It looks like this:
```go
// ApisixPluginConfigSpec defines the desired state of
ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
Desc string`json:"desc,omitempty" yaml:"desc,omitempty"`
Plugins []ApisixRouteHTTPPlugin //
https://github.com/apache/apisix-ingress-controller/blob/3e9bdbf0cee6d49c8e0db27152d46565df704e8c/pkg/kube/apisix/apis/config/v2beta1/types.go#L118
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 edited a comment on issue #638:
URL:
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925493450
You can open a PR and submit your current changes directly.
The PluginConfig document is here
https://apisix.apache.org/docs/apisix/architecture-design/plugin-config
It looks like this:
```go
// ApisixPluginConfigSpec defines the desired state of
ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
Desc string`json:"desc,omitempty" yaml:"desc,omitempty"`
Plugins ApisixRouteHTTPPluginConfig //
https://github.com/apache/apisix-ingress-controller/blob/3e9bdbf0cee6d49c8e0db27152d46565df704e8c/pkg/kube/apisix/apis/config/v2beta1/types.go#L129
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638:
URL:
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925493450
You can open a PR and submit your current changes directly.
The PluginConfig document is here
https://apisix.apache.org/docs/apisix/architecture-design/plugin-config
It looks like this:
```go
// ApisixPluginConfigSpec defines the desired state of
ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
Desc string`json:"desc,omitempty" yaml:"desc,omitempty"`
Plugins Plugins // it should be imported from
https://github.com/apache/apisix-ingress-controller/blob/3e9bdbf0cee6d49c8e0db27152d46565df704e8c/pkg/types/apisix/v1/types.go#L158
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] okaybase commented on issue #5115: bug: APISIX start failed when one of ETCD nodes down
okaybase commented on issue #5115: URL: https://github.com/apache/apisix/issues/5115#issuecomment-925491577 Production environment Case: In our prod environment, we upgrade etcd cluster to v3.5, but we also met this case: https://github.com/etcd-io/etcd/issues/12845#issuecomment-869505034, result to some etcd nodes down~ So, I also inclined to do some enhancement~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase edited a comment on issue #638:
URL:
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925490391
ok, i had created ApisixPluginConfig.yaml and add 3 structs
`ApisixPluginConfig`, `ApisixPluginConfigSpec`, `ApisixPluginConfigList` in the
v2alpha1/types.go.
But i had trouble in making up fields inside `ApisixPluginConfigSpec`,
because i can't find any structs which could be linked to the `plugin` in
types.go.
```sh
// +genclient
// +genclient:nonNamespaced
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +kubebuilder:subresource:status
// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
// An ApisixPluginConfig is used to support a group of plugin configs
type ApisixPluginConfig struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
// Spec defines the desired state of ApisixPluginConfigSpec.
Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
}
// ApisixPluginConfigSpec defines the desired state of
ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
}
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// ApisixPluginConfigList contains a list of ApisixPluginConfig.
type ApisixPluginConfigList struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixPluginConfig `json:"items,omitempty"
yaml:"items,omitempty"`
}
```
could u provide me more details about the plugins
@tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638:
URL:
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925490391
ok, i had created ApisixPluginConfig.yaml and add 3 structs
`ApisixPluginConfig`, `ApisixPluginConfigSpec`, `ApisixPluginConfigList` in the
v2alpha1/types.go.
But i had trouble in making up fields inside `ApisixPluginConfigSpec`,
because i can't find any structs could be linked to the `plugin` in types.go.
```sh
// +genclient
// +genclient:nonNamespaced
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +kubebuilder:subresource:status
// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
// An ApisixPluginConfig is used to support a group of plugin configs
type ApisixPluginConfig struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
// Spec defines the desired state of ApisixPluginConfigSpec.
Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
}
// ApisixPluginConfigSpec defines the desired state of
ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
}
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// ApisixPluginConfigList contains a list of ApisixPluginConfig.
type ApisixPluginConfigList struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixPluginConfig `json:"items,omitempty"
yaml:"items,omitempty"`
}
```
could u provide me more details about the plugins
@tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925487850 After discussing it with @tokers and @gxthrj . We finally reached an agreement. We can set the `plugins` field and `pluginconfig` field in `ApisixRoute` to be mutually exclusive. This means that the user can only configure one of the `plugins` or `pluginconfig` in `ApisixRoute`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5120: apisix delay
tzssangglass commented on issue #5120: URL: https://github.com/apache/apisix/issues/5120#issuecomment-925487471 can you paste the route configuration of `zyml-getuserinfo-api` as text? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5115: bug: APISIX start failed when one of ETCD nodes down
spacewander commented on issue #5115: URL: https://github.com/apache/apisix/issues/5115#issuecomment-925483881 I changed my mind. We can allow broken nodes to work around some unstable status in etcd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch master updated (59f2664 -> 3ecee9b)
This is an automated email from the ASF dual-hosted git repository. bzp2010 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. from 59f2664 docs: use make instead of docker (#225) add 3ecee9b docs: optimize the reading experience (#226) No new revisions were added by this update. Summary of changes: README.md | 67 +++ docs/en/latest/example.md | 8 +++--- 2 files changed, 48 insertions(+), 27 deletions(-)
[apisix-docker] branch master updated (ba4b1ab -> 59f2664)
This is an automated email from the ASF dual-hosted git repository. bzp2010 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. from ba4b1ab fix(etcd): fix etcd startup report permission issue (#209) add 59f2664 docs: use make instead of docker (#225) No new revisions were added by this update. Summary of changes: docs/en/latest/build.md | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)
[GitHub] [apisix] tzssangglass opened a new pull request #5121: docs: fix error link of build apisix openresty
tzssangglass opened a new pull request #5121: URL: https://github.com/apache/apisix/pull/5121 Signed-off-by: tzssangglass ### What this PR does / why we need it: The current Chinese documentation for `步骤6：为 Apache APISIX 构建 OpenResty` jump link looks like this:  The jump link does not jump to the `步骤6：为 Apache APISIX 构建 OpenResty` After this PR is modified, it will look like this:  ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 merged pull request #226: docs: optimize the reading experience
bzp2010 merged pull request #226: URL: https://github.com/apache/apisix-docker/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 merged pull request #225: docs: use make instead of docker
bzp2010 merged pull request #225: URL: https://github.com/apache/apisix-docker/pull/225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 opened a new pull request #624: chore: add preview branch condition
bzp2010 opened a new pull request #624: URL: https://github.com/apache/apisix-website/pull/624 Changes: Add branch restrictions for PR preview push CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5116: docs: add gzip and real-ip zh docs
tzssangglass commented on a change in pull request #5116: URL: https://github.com/apache/apisix/pull/5116#discussion_r714437984 ## File path: docs/zh/latest/plugins/real-ip.md ## @@ -0,0 +1,103 @@ +--- +title: real-ip +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) + +## 简介 + +The `real-ip` 可以动态改变客户端的 `IP` 和端口。 + +它工作方式和 `Nginx` 里 `ngx_http_realip_module` 模块一样，并且更为灵活。 + +**该插件依赖 `APISIX` 运行在 [APISIX-OpenResty](../how-to-build.md#步骤6：为-apache-apisix-构建-openresty) 上。** + +## 属性 + +| 名称 | 类型 | 必选项 | 默认值| 有效值 | 描述 | +| - | - | --- | -- | | --- | +| source | string| 必填|| 任何 Nginx 变量，如 `arg_realip` 或 `http_x_forwarded_for` | 在 `APISIX` 的视图中，根据变量的值动态设置客户端的IP和端口。如果. 如果该值不包含端口，则不会更改客户端的端口。 | +| trusted_addresses| array[string] | 可选|| `IP` 或 `CIDR` 范围列表 | 动态设置 `set_real_ip_from` 指令 | + + Review comment: ```suggestion ``` ## File path: docs/zh/latest/plugins/gzip.md ## @@ -0,0 +1,108 @@ +--- +title: gzip +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) + +## 简介 + +`gzip` 插件能动态设置 `Nginx` 的压缩行为。 + +**该插件依赖 `APISIX` 运行在 [APISIX-OpenResty](../how-to-build.md#步骤6：为-apache-apisix-构建-openresty) 上。** Review comment: ditto ## File path: docs/zh/latest/plugins/real-ip.md ## @@ -0,0 +1,103 @@ +--- +title: real-ip +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) + +## 简介 + +The `real-ip` 可以动态改变客户端的 `IP` 和端口。 + +它工作方式和 `Nginx` 里 `ngx_http_realip_module` 模块一样，并且更为灵活。 + +**该插件依赖 `APISIX` 运行在 [APISIX-OpenResty](../how-to-build.md#步骤6：为-apache-apisix-构建-openresty) 上。** Review comment: ```suggestion **该插件依赖 `APISIX` 运行在 [APISIX-OpenResty](../how-to-build.md#步骤6：为-Apache-APISIX-构建-OpenResty) 上。** ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] RedemptionC edited a comment on pull request #2065: feat: add cache verification tool for dashbaord
RedemptionC edited a comment on pull request #2065: URL: https://github.com/apache/apisix-dashboard/pull/2065#issuecomment-925472938 @nic-chen The failure doesn't seem to reproduce all the time what should I do? (and the CI seems to take so long to finish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] RedemptionC commented on pull request #2065: feat: add cache verification tool for dashbaord
RedemptionC commented on pull request #2065: URL: https://github.com/apache/apisix-dashboard/pull/2065#issuecomment-925472938 > @RedemptionC please fix the CI. The failure doesn't seem to reproduce all the time what should I do? (and the CI seems to take so long to finish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2065: feat: add cache verification tool for dashbaord
codecov-commenter edited a comment on pull request #2065: URL: https://github.com/apache/apisix-dashboard/pull/2065#issuecomment-897455810 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2065](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a79ca3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0972f1610d1c57cbf59c8069dd2acd94c23cdbd4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0972f16) will **increase** coverage by `4.52%`. > The diff coverage is `40.62%`. > :exclamation: Current head 5a79ca3 differs from pull request most recent head 4f5751c. Consider uploading reports for the commit 4f5751c to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2065 +/- ## == + Coverage 64.90% 69.43% +4.52% == Files 60 62 +2 Lines3790 3982 +192 == + Hits 2460 2765 +305 + Misses 1043 923 -120 - Partials 287 294 +7 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `45.00% <10.93%> (-2.21%)` | :arrow_down: | | backend-e2e-test-ginkgo | `48.79% <40.62%> (?)` | | | backend-unit-test | `53.02% <63.33%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/cache\_verify.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9jYWNoZV92ZXJpZnkuZ28=) | `4.00% <4.00%> (ø)` | | | [api/internal/handler/cache\_verify/cache\_verify.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY2FjaGVfdmVyaWZ5L2NhY2hlX3ZlcmlmeS5nbw==) | `80.00% <80.00%> (ø)` | | | [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | `80.43% <100.00%> (+0.43%)` | :arrow_up: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `86.84% <100.00%> (+0.35%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.94% <0.00%> (+1.57%)` | :arrow_up: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `70.70% <0.00%> (+2.52%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&u
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2065: feat: add cache verification tool for dashbaord
codecov-commenter edited a comment on pull request #2065: URL: https://github.com/apache/apisix-dashboard/pull/2065#issuecomment-897455810 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2065](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a79ca3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0972f1610d1c57cbf59c8069dd2acd94c23cdbd4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0972f16) will **increase** coverage by `0.96%`. > The diff coverage is `40.62%`. > :exclamation: Current head 5a79ca3 differs from pull request most recent head 4f5751c. Consider uploading reports for the commit 4f5751c to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2065 +/- ## == + Coverage 64.90% 65.87% +0.96% == Files 60 62 +2 Lines3790 3982 +192 == + Hits 2460 2623 +163 - Misses 1043 1065 +22 - Partials 287 294 +7 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `48.79% <40.62%> (?)` | | | backend-unit-test | `53.02% <63.33%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/cache\_verify.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9jYWNoZV92ZXJpZnkuZ28=) | `4.00% <4.00%> (ø)` | | | [api/internal/handler/cache\_verify/cache\_verify.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY2FjaGVfdmVyaWZ5L2NhY2hlX3ZlcmlmeS5nbw==) | `80.00% <80.00%> (ø)` | | | [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | `80.43% <100.00%> (+0.43%)` | :arrow_up: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `78.94% <100.00%> (-7.54%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `32.11% <0.00%> (-35.41%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `68.11% <0.00%> (-17.40%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_m
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #687: fix: the fields in UpstreamPassiveHealthCheckUnhealthy should be timeouts
tao12345666333 merged pull request #687: URL: https://github.com/apache/apisix-ingress-controller/pull/687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: fix: the fields in UpstreamPassiveHealthCheckUnhealthy should be timeouts (#687)
This is an automated email from the ASF dual-hosted git repository.
zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 3e9bdbf fix: the fields in UpstreamPassiveHealthCheckUnhealthy should
be timeouts (#687)
3e9bdbf is described below
commit 3e9bdbf0cee6d49c8e0db27152d46565df704e8c
Author: kv
AuthorDate: Thu Sep 23 10:47:39 2021 +0800
fix: the fields in UpstreamPassiveHealthCheckUnhealthy should be timeouts
(#687)
---
pkg/apisix/schema.go | 1 +
pkg/kube/apisix/apis/config/v1/types.go| 8
pkg/kube/translation/apisix_upstream.go| 4 ++--
pkg/types/apisix/v1/types.go | 8
samples/deploy/crd/v1beta1/ApisixUpstream.yaml | 10 ++
5 files changed, 17 insertions(+), 14 deletions(-)
diff --git a/pkg/apisix/schema.go b/pkg/apisix/schema.go
index 3f30525..34ce2ce 100644
--- a/pkg/apisix/schema.go
+++ b/pkg/apisix/schema.go
@@ -17,6 +17,7 @@ package apisix
import (
"context"
+
"go.uber.org/zap"
"github.com/apache/apisix-ingress-controller/pkg/apisix/cache"
diff --git a/pkg/kube/apisix/apis/config/v1/types.go
b/pkg/kube/apisix/apis/config/v1/types.go
index 3eea11a..61d9f3f 100644
--- a/pkg/kube/apisix/apis/config/v1/types.go
+++ b/pkg/kube/apisix/apis/config/v1/types.go
@@ -217,10 +217,10 @@ type PassiveHealthCheckHealthy struct {
// PassiveHealthCheckUnhealthy defines the conditions to judge whether
// an upstream node is unhealthy with the passive manager.
type PassiveHealthCheckUnhealthy struct {
- HTTPCodes[]int `json:"httpCodes,omitempty"
yaml:"httpCodes,omitempty"`
- HTTPFailures int `json:"httpFailures,omitempty"
yaml:"http_failures,omitempty"`
- TCPFailures int `json:"tcpFailures,omitempty"
yaml:"tcpFailures,omitempty"`
- Timeout time.Duration `json:"timeout,omitempty"
yaml:"timeout,omitempty"`
+ HTTPCodes[]int `json:"httpCodes,omitempty"
yaml:"httpCodes,omitempty"`
+ HTTPFailures int `json:"httpFailures,omitempty"
yaml:"http_failures,omitempty"`
+ TCPFailures int `json:"tcpFailures,omitempty"
yaml:"tcpFailures,omitempty"`
+ Timeouts int `json:"timeout,omitempty" yaml:"timeout,omitempty"`
}
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
diff --git a/pkg/kube/translation/apisix_upstream.go
b/pkg/kube/translation/apisix_upstream.go
index f9ce843..40fd598 100644
--- a/pkg/kube/translation/apisix_upstream.go
+++ b/pkg/kube/translation/apisix_upstream.go
@@ -226,7 +226,7 @@ func (t *translator)
translateUpstreamActiveHealthCheck(config *configv1.ActiveH
}
}
active.Unhealthy.TCPFailures = config.Unhealthy.TCPFailures
- active.Unhealthy.Timeouts = config.Unhealthy.Timeout.Seconds()
+ active.Unhealthy.Timeouts = config.Unhealthy.Timeouts
if config.Unhealthy.HTTPCodes != nil &&
len(config.Unhealthy.HTTPCodes) < 1 {
return nil, &translateError{
@@ -295,7 +295,7 @@ func (t *translator)
translateUpstreamPassiveHealthCheck(config *configv1.Passiv
}
}
passive.Unhealthy.TCPFailures = config.Unhealthy.TCPFailures
- passive.Unhealthy.Timeouts = config.Unhealthy.Timeout.Seconds()
+ passive.Unhealthy.Timeouts = config.Unhealthy.Timeouts
if config.Unhealthy.HTTPCodes != nil &&
len(config.Unhealthy.HTTPCodes) < 1 {
return nil, &translateError{
diff --git a/pkg/types/apisix/v1/types.go b/pkg/types/apisix/v1/types.go
index 297f915..5838028 100644
--- a/pkg/types/apisix/v1/types.go
+++ b/pkg/types/apisix/v1/types.go
@@ -288,10 +288,10 @@ type UpstreamActiveHealthCheckUnhealthy struct {
// an upstream node is unhealthy with the passive manager.
// +k8s:deepcopy-gen=true
type UpstreamPassiveHealthCheckUnhealthy struct {
- HTTPStatuses []int `json:"http_statuses,omitempty"
yaml:"http_statuses,omitempty"`
- HTTPFailures int `json:"http_failures,omitempty"
yaml:"http_failures,omitempty"`
- TCPFailures int `json:"tcp_failures,omitempty"
yaml:"tcp_failures,omitempty"`
- Timeouts float64 `json:"timeouts,omitempty"
yaml:"timeouts,omitempty"`
+ HTTPStatuses []int `json:"http_statuses,omitempty"
yaml:"http_statuses,omitempty"`
+ HTTPFailures int `json:"http_failures,omitempty"
yaml:"http_failures,omitempty"`
+ TCPFailures int `json:"tcp_failures,omitempty"
yaml:"tcp_failures,omitempty"`
+ Timeouts int `json:"timeouts,omitempty" yaml:"timeouts,omitempty"`
}
// Ssl apisix ssl object
diff --git a/samples/deploy/crd/v1beta1/ApisixUpstream.yaml
b/samples/deploy/crd/v1beta1/ApisixUpstream.yam
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2065: feat: add cache verification tool for dashbaord
codecov-commenter edited a comment on pull request #2065: URL: https://github.com/apache/apisix-dashboard/pull/2065#issuecomment-897455810 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2065](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a79ca3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0972f1610d1c57cbf59c8069dd2acd94c23cdbd4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0972f16) will **decrease** coverage by `11.88%`. > The diff coverage is `63.33%`. > :exclamation: Current head 5a79ca3 differs from pull request most recent head 4f5751c. Consider uploading reports for the commit 4f5751c to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2065 +/- ## === - Coverage 64.90% 53.02% -11.89% === Files 60 39 -21 Lines3790 3025 -765 === - Hits 2460 1604 -856 - Misses 1043 1221 +178 + Partials 287 200 -87 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-unit-test | `53.02% <63.33%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/cache\_verify/cache\_verify.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY2FjaGVfdmVyaWZ5L2NhY2hlX3ZlcmlmeS5nbw==) | `63.33% <63.33%> (ø)` | | | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-68.19%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2065/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
[GitHub] [apisix-website] Baoyuantop commented on pull request #550: feat: add Zh Blogs
Baoyuantop commented on pull request #550: URL: https://github.com/apache/apisix-website/pull/550#issuecomment-925466768 Hi @KishaniKandasamy, Could you please help deal with conflicting files? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #602: feat: add vercel preview
juzhiyuan merged pull request #602: URL: https://github.com/apache/apisix-website/pull/602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: feat: add vercel preview (#602)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 5a2cfad feat: add vercel preview (#602)
5a2cfad is described below
commit 5a2cfadc18c972a495f65e685b68eb9c8612d04a
Author: bzp2010
AuthorDate: Wed Sep 22 21:35:20 2021 -0500
feat: add vercel preview (#602)
---
.github/workflows/preview.yml | 52 +++
1 file changed, 52 insertions(+)
diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml
new file mode 100644
index 000..48b7365
--- /dev/null
+++ b/.github/workflows/preview.yml
@@ -0,0 +1,52 @@
+name: Preview Pull Request
+
+on:
+ push:
+ pull_request:
+branches: [master]
+
+jobs:
+ build:
+runs-on: ubuntu-latest
+steps:
+ - uses: actions/checkout@v2
+
+ - name: Setup Node.js environment
+uses: actions/setup-node@v2.4.0
+with:
+ node-version: 14.x
+
+ - name: Install Dependencies
+run: |
+ cd scripts && yarn install
+ cd ../website && yarn install
+
+ - name: Sync documents
+run: |
+ cd scripts && yarn sync && git status
+
+ - name: Build
+run: |
+ cd website && yarn build
+ cp ../.asf.yaml ./build
+
+ - name: Compress build artifacts
+run: |
+ mkdir artifact && cd artifact
+ tar cvzf - ../website/build | split -d -b 90m - website
+
+ - name: Archive artifacts to GitHub
+uses: actions/upload-artifact@v2
+with:
+ name: artifact.zip
+ path: artifact
+ retention-days: 5
+
+ - name: Deploy Preview
+uses: amondnet/vercel-action@v20
+with:
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+ vercel-token: ${{ secrets.VERCEL_TOKEN }}
+ vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
+ vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID }}
+ working-directory: artifact
[GitHub] [apisix] zhixiang0608 opened a new issue #5120: apisix delay
zhixiang0608 opened a new issue #5120:
URL: https://github.com/apache/apisix/issues/5120
### Issue description
hello,
Gateway delay p99 is much higher than other indicators
This is the result of my pressure test using wrk
My routing configuration is
### Environment
apisix vesion：apisix-2.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #687: fix: the fields in UpstreamPassiveHealthCheckUnhealthy should be timeouts
gxthrj commented on pull request #687: URL: https://github.com/apache/apisix-ingress-controller/pull/687#issuecomment-925464257 But this is also a bug in the v1 version, and I think it needs to be fixed in the v1 version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] arthur-zhang commented on pull request #5016: feat: xml-json-conversion plugin convert xml data from request body to json response, and vice versa
arthur-zhang commented on pull request #5016: URL: https://github.com/apache/apisix/pull/5016#issuecomment-925462244 > > What are scenes can this plugin be used? > > The plugin can rewrite the content returned upstream as well as APACHE APISIX itself. Users can specify input and output protocol what they want, it only support xml and json protocol conversion mutually at now why not make a plugin to transform the body before return the response instead of send it again to apisix. Based on `Content-Type` header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #2065: feat: add cache verification tool for dashbaord
nic-chen commented on pull request #2065: URL: https://github.com/apache/apisix-dashboard/pull/2065#issuecomment-925457773 @RedemptionC please fix the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2010: feat: new authentication framework
nic-chen commented on a change in pull request #2010:
URL: https://github.com/apache/apisix-dashboard/pull/2010#discussion_r714426477
##
File path: api/internal/filter/authentication.go
##
@@ -90,7 +93,40 @@ func (mw *AuthenticationMiddleware) Handle(ctx
droplet.Context) error {
return nil
}
- if _, ok := conf.UserList[claims.Subject]; !ok {
+ userExist := false
+ switch conf.DataSourceType(claims.Audience) {
+ case conf.DataSourceTypeEtcd:
Review comment:
In my understanding, `local` should be written into etcd through yaml
configuration, and `external` is from third-party. It looks like `local` and
`etcd` are still different here? In this way, users configured in yaml cannot
be managed on the dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zhendongcmss opened a new issue #5119: request help: APISIX can export current configratures to apisix.yaml
zhendongcmss opened a new issue #5119: URL: https://github.com/apache/apisix/issues/5119 ### Issue description (1) when upgrade from etcd v2 to v3, due to compatibility issues, v2 cannot be directly upgraded to v3. The configuration file can be used as an intermediate transition. (2) It is converient for duplicate one config to another (3) K8S and other softwares have exporting config function ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #5118: docs(stream_routes): now support CIDR to match addr
spacewander opened a new pull request #5118: URL: https://github.com/apache/apisix/pull/5118 Fix https://github.com/apache/apisix/issues/4902 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Superskyyy commented on a change in pull request #5101: chore: clean up SkyWalking docs
Superskyyy commented on a change in pull request #5101: URL: https://github.com/apache/apisix/pull/5101#discussion_r714422930 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -26,25 +26,27 @@ title: skywalking - [**Name**](#name) - [**Attributes**](#attributes) - [**How To Enable**](#how-to-enable) +- [**How to set endpoint**](#how-to-set-endpoint) - [**Test Plugin**](#test-plugin) - - [**Run Skywalking Example**](#run-skywalking-example) + - [**Running SkyWalking**](#running-skywalking) - [**Disable Plugin**](#disable-plugin) - [**Upstream services(Code With SpringBoot)**](#Upstream-services(Code-With-SpringBoot)) ## Name -[**Skywalking**](https://github.com/apache/skywalking) uses its native Nginx LUA tracer to provide tracing, topology analysis, and metrics from service and URI perspective. -The skywalking server can supports both http and grpc protocols. The APISIX client only support http protocols. +[**SkyWalking**](https://github.com/apache/skywalking) uses its native Nginx LUA tracer to provide tracing, topology analysis, and metrics from service and URI perspective. + +The SkyWalking server can support both HTTP and gRPC protocols. Currently, the APISIX client only supports the HTTP protocol. ## Attributes | Name | Type | Requirement | Default | Valid| Description | | | -- | --- | | | | -| sample_ratio | number | required| 1| [0.1, 1] | the ratio of sample | +| sample_ratio | number | required| 1| [0.1, 1] | The ratio of sampling | Review comment: Ok, fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Superskyyy commented on a change in pull request #5101: chore: clean up SkyWalking docs
Superskyyy commented on a change in pull request #5101: URL: https://github.com/apache/apisix/pull/5101#discussion_r714421605 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -26,25 +26,27 @@ title: skywalking - [**Name**](#name) - [**Attributes**](#attributes) - [**How To Enable**](#how-to-enable) +- [**How to set endpoint**](#how-to-set-endpoint) - [**Test Plugin**](#test-plugin) - - [**Run Skywalking Example**](#run-skywalking-example) + - [**Running SkyWalking**](#running-skywalking) Review comment: My bad, fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on issue #623: About the i18n of blogs
bzp2010 commented on issue #623: URL: https://github.com/apache/apisix-website/issues/623#issuecomment-925450305 > > Hi, @Baoyuantop https://www.docusaurus.cn/docs/i18n/introduction#translation-files-location Here is a guide to supporting i18n, which I think we should use to solve the problem > > OK, I'll try this method. At the same time, you can also find it in the PR list. I remember some contributors did it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Baoyuantop commented on issue #623: About the i18n of blogs
Baoyuantop commented on issue #623: URL: https://github.com/apache/apisix-website/issues/623#issuecomment-925447914 > Hi, @Baoyuantop https://www.docusaurus.cn/docs/i18n/introduction#translation-files-location Here is a guide to supporting i18n, which I think we should use to solve the problem OK, I'll try this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on issue #623: About the i18n of blogs
bzp2010 commented on issue #623: URL: https://github.com/apache/apisix-website/issues/623#issuecomment-925447651 > Hi, @Baoyuantop https://www.docusaurus.cn/docs/i18n/introduction#translation-files-location Here is a guide to supporting i18n, which I think we should use to solve the problem +1 agree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3792: discuss: the "active.host" in the active health check should be optional
spacewander commented on issue #3792: URL: https://github.com/apache/apisix/issues/3792#issuecomment-925447351 I think we can close this issue now. Every field in this health check configuration is optional. There is no need to emphasize that one of them is optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on issue #623: About the i18n of blogs
guoqqqi commented on issue #623: URL: https://github.com/apache/apisix-website/issues/623#issuecomment-925446439 Hi, @Baoyuantop https://www.docusaurus.cn/docs/i18n/introduction#translation-files-location Here is a guide to supporting i18n, which I think we should use to solve the problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925446318 > I had replied a mail on the apache mail list, but it seems something wrong. > After sending, i can't find my reply on the mail list. > @tao12345666333 @tokers Yes, you need to subscribe the d...@apisix.apache.org before you send any mails. **Of course, whether you are discussing in this issue or on the mailing list, it’s okay.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925445772 > Add a CRD like `ApisixPluginConfig` to support a group of plugin configs, and `ApisixRoute` add a field be associated with it. > > If we want to implement this function, we can split the following tasks: > > * [ ] Add ApisixPluginConfig custom resource. Only need to modify YAML. > * [ ] Add ApisixPluginConfig data structures. > * [ ] Add client implementation to interact with Apache APISIX. > * [ ] Add ApisixPluginConfig translator, it can convert ApisixPluginConfig data structure into APISIX. > * [ ] Add ApisixPluginConfig controller loop, It watches the ApisixPluginConfig resource in the Kubernetes cluster and converts it to the ApisixPluginConfig data structure. > * [ ] Add docs to describe it. You can split this function into multiple small tasks to carry out, refer to these tasks I added in the description. @neverCase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5117: docs: supplementary health check documents
spacewander commented on a change in pull request #5117: URL: https://github.com/apache/apisix/pull/5117#discussion_r714416089 ## File path: docs/en/latest/health-check.md ## @@ -91,12 +91,13 @@ The configures in `checks` are belong to health check, the type of `checks` contains: `active` or `passive`. * `active`: To enable active health checks, you need to specify the configuration items under `checks.active` in the Upstream object configuration. - + * `active.type`: The type of active health check, supports `http`, `https`, `tcp`, default: `http`. * `active.timeout`: Socket timeout for active checks (in seconds), support decimals. For example `1.01` means `1010` milliseconds, `2` means `2000` milliseconds. - + * `active.concurrency`: Number of targets to check concurrently in active health checks, default: `10`. * `active.http_path`: The HTTP GET request path used to detect if the upstream is healthy. * `active.host`: The HTTP request host used to detect if the upstream is healthy. * `active.port`: The customize health check host port (optional), this will override the port in the `upstream` node. + * `active.https_verify_certificate`: Whether to check the validity of the SSL certificate of the remote host when performing active health checks using HTTPS. Default: `true`. Review comment: Some fields are still missing, like "http_statuses". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (8d69af5 -> 2ead265)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8d69af5 test(debug): add test cases for hook ctx (#5113) add 2ead265 fix(nacos): distinguish services that has same name but in different groups or namespaces (#5083) No new revisions were added by this update. Summary of changes: apisix/discovery/nacos.lua| 43 +--- apisix/upstream.lua | 2 +- ci/install-ext-services-via-docker.sh | 14 ++- t/discovery/nacos.t | 184 ++ 4 files changed, 225 insertions(+), 18 deletions(-)
[GitHub] [apisix] spacewander closed issue #5061: bug：nacos.lua 脚本 同样的服务名称不同分组的实例，会存储到同一个nacos服务节点中
spacewander closed issue #5061: URL: https://github.com/apache/apisix/issues/5061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5083: fix(nacos): distinguish services that has same name but in different groups or namespaces
spacewander merged pull request #5083: URL: https://github.com/apache/apisix/pull/5083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1946: refactor: migrate to viper configure manage
juzhiyuan merged pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5101: chore: clean up SkyWalking docs
spacewander commented on a change in pull request #5101: URL: https://github.com/apache/apisix/pull/5101#discussion_r714413738 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -26,25 +26,27 @@ title: skywalking - [**Name**](#name) - [**Attributes**](#attributes) - [**How To Enable**](#how-to-enable) +- [**How to set endpoint**](#how-to-set-endpoint) - [**Test Plugin**](#test-plugin) - - [**Run Skywalking Example**](#run-skywalking-example) + - [**Running SkyWalking**](#running-skywalking) Review comment: Please use `Run` like other titles ## File path: docs/en/latest/plugins/skywalking.md ## @@ -26,25 +26,27 @@ title: skywalking - [**Name**](#name) - [**Attributes**](#attributes) - [**How To Enable**](#how-to-enable) +- [**How to set endpoint**](#how-to-set-endpoint) - [**Test Plugin**](#test-plugin) - - [**Run Skywalking Example**](#run-skywalking-example) + - [**Running SkyWalking**](#running-skywalking) - [**Disable Plugin**](#disable-plugin) - [**Upstream services(Code With SpringBoot)**](#Upstream-services(Code-With-SpringBoot)) ## Name -[**Skywalking**](https://github.com/apache/skywalking) uses its native Nginx LUA tracer to provide tracing, topology analysis, and metrics from service and URI perspective. -The skywalking server can supports both http and grpc protocols. The APISIX client only support http protocols. +[**SkyWalking**](https://github.com/apache/skywalking) uses its native Nginx LUA tracer to provide tracing, topology analysis, and metrics from service and URI perspective. + +The SkyWalking server can support both HTTP and gRPC protocols. Currently, the APISIX client only supports the HTTP protocol. ## Attributes | Name | Type | Requirement | Default | Valid| Description | | | -- | --- | | | | -| sample_ratio | number | required| 1| [0.1, 1] | the ratio of sample | +| sample_ratio | number | required| 1| [0.1, 1] | The ratio of sampling | Review comment: Please use lowercase for the first word like other cells ## File path: docs/en/latest/plugins/skywalking.md ## @@ -78,20 +80,20 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 }' ``` -You also can complete the above operation through the web interface, first add a route, then add skywalking plugin: +You also can complete the above operation through the web interface, first add a route, then add SkyWalking plugin:  ## How to set endpoint -We can set the endpoint by specified the configuration in `conf/config.yaml`. +We can set the endpoint by specifying the configuration in `conf/config.yaml`. | Name | Type | Default | Description | | | -- | | | -| service_name | string | "APISIX" | service name for skywalking reporter | -| service_instance_name | string |"APISIX Instance Name" | service instance name for skywalking reporter， set it to `$hostname` to get local hostname directly.| -| endpoint_addr | string | "http://127.0.0.1:12800"; | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | -| report_interval | integer | use the value in the skywalking client library | the report interval, in seconds | +| service_name | string | "APISIX" | service name for SkyWalking reporter | +| service_instance_name | string |"APISIX Instance Name" | service instance name for SkyWalking reporter， set it to `$hostname` to get local hostname directly.| +| endpoint_addr | string | "http://127.0.0.1:12800"; | the HTTP endpoint of SkyWalking, for example: http://127.0.0.1:12800 | +| report_interval | integer | uses the value in the SkyWalking client library | the report interval, in seconds | Review comment: ```suggestion | report_interval | integer | use the value in the SkyWalking client library | the report interval, in seconds | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: refactor: migrate to viper configure manage (#1946)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 0972f16 refactor: migrate to viper configure manage (#1946)
0972f16 is described below
commit 0972f1610d1c57cbf59c8069dd2acd94c23cdbd4
Author: bzp2010
AuthorDate: Wed Sep 22 20:26:51 2021 -0500
refactor: migrate to viper configure manage (#1946)
---
api/cmd/root.go | 3 +-
api/go.mod| 10 +-
api/go.sum| 330 --
api/internal/conf/conf.go | 190 +-
4 files changed, 422 insertions(+), 111 deletions(-)
diff --git a/api/cmd/root.go b/api/cmd/root.go
index b9d2aa4..6f830e3 100644
--- a/api/cmd/root.go
+++ b/api/cmd/root.go
@@ -30,7 +30,6 @@ import (
)
var (
- configFile string
forceStart bool
)
@@ -52,7 +51,7 @@ func init() {
}
})
- rootCmd.PersistentFlags().StringVarP(&configFile, "config", "c",
"./conf/conf.yml", "config file")
+ rootCmd.PersistentFlags().StringVarP(&conf.ConfigFile, "config", "c",
"", "config file")
rootCmd.PersistentFlags().StringVarP(&conf.WorkDir, "work-dir", "p",
".", "current work directory")
rootCmd.PersistentFlags().BoolVarP(&forceStart, "force", "f", false,
"force start manager-api")
diff --git a/api/go.mod b/api/go.mod
index 6968a13..003f6ed 100644
--- a/api/go.mod
+++ b/api/go.mod
@@ -9,7 +9,6 @@ replace github.com/coreos/bbolt => go.etcd.io/bbolt v1.3.5
require (
github.com/coreos/bbolt v1.3.2 // indirect
github.com/coreos/etcd v3.3.25+incompatible // indirect
- github.com/coreos/go-semver v0.3.0 // indirect
github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf //
indirect
github.com/coreos/pkg v0.0.0-20180928190104-399ea9e2e55f // indirect
github.com/dgrijalva/jwt-go v3.2.0+incompatible
@@ -19,14 +18,10 @@ require (
github.com/gin-contrib/pprof v1.3.0
github.com/gin-contrib/static v0.0.0-20200916080430-d45d9a37d28e
github.com/gin-gonic/gin v1.6.3
- github.com/gogo/protobuf v1.3.2 // indirect
- github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e //
indirect
github.com/google/uuid v1.1.2 // indirect
github.com/gorilla/websocket v1.4.2 // indirect
github.com/grpc-ecosystem/go-grpc-middleware v1.2.2 // indirect
- github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
github.com/jonboulle/clockwork v0.2.2 // indirect
- github.com/json-iterator/go v1.1.11 // indirect
github.com/prometheus/client_golang v1.8.0 // indirect
github.com/satori/go.uuid v1.2.0
github.com/shiningrush/droplet v0.2.6-0.20210127040147-53817015cd1b
@@ -34,7 +29,7 @@ require (
github.com/sirupsen/logrus v1.7.0 // indirect
github.com/sony/sonyflake v1.0.0
github.com/spf13/cobra v0.0.3
- github.com/spf13/pflag v1.0.5 // indirect
+ github.com/spf13/viper v1.8.1
github.com/stretchr/testify v1.7.0
github.com/takama/daemon v1.0.0
github.com/tidwall/gjson v1.6.7
@@ -42,9 +37,8 @@ require (
github.com/xeipuuv/gojsonschema v1.2.0
github.com/yuin/gopher-lua v0.0.0-20200816102855-ee81675732da
go.etcd.io/etcd v3.3.25+incompatible
- go.uber.org/zap v1.16.0
+ go.uber.org/zap v1.17.0
golang.org/x/time v0.0.0-20201208040808-7e3f01d25324 // indirect
- google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c //
indirect
gopkg.in/yaml.v2 v2.4.0
sigs.k8s.io/yaml v1.2.0 // indirect
)
diff --git a/api/go.sum b/api/go.sum
index 4339ec3..80d1561 100644
--- a/api/go.sum
+++ b/api/go.sum
@@ -1,6 +1,41 @@
cloud.google.com/go v0.34.0/go.mod
h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
+cloud.google.com/go v0.38.0/go.mod
h1:990N+gfupTy94rShfmMCWGDn0LpTmnzTp2qbd1dvSRU=
+cloud.google.com/go v0.44.1/go.mod
h1:iSa0KzasP4Uvy3f1mN/7PiObzGgflwredwwASm/v6AU=
+cloud.google.com/go v0.44.2/go.mod
h1:60680Gw3Yr4ikxnPRS/oxxkBccT6SA1yMk63TGekxKY=
+cloud.google.com/go v0.45.1/go.mod
h1:RpBamKRgapWJb87xiFSdk4g1CME7QZg3uwTez+TSTjc=
+cloud.google.com/go v0.46.3/go.mod
h1:a6bKKbmY7er1mI7TEI4lsAkts/mkhTSZK8w33B4RAg0=
+cloud.google.com/go v0.50.0/go.mod
h1:r9sluTvynVuxRIOHXQEHMFffphuXHOMZMycpNR5e6To=
+cloud.google.com/go v0.52.0/go.mod
h1:pXajvRH/6o3+F9jDHZWQ5PbGhn+o8w9qiu/CffaVdO4=
+cloud.google.com/go v0.53.0/go.mod
h1:fp/UouUEsRkN6ryDKNW/Upv/JBKnv6WDthjR6+vze6M=
+cloud.google.com/go v0.54.0/go.mod
h1:1rq2OEkV3YMf6n/9ZvGWI3GWw0VoqH/1x2nd8Is/bPc=
+cloud.google.com/go v0.56.0/go.mod
h1:jr7tqZxxKOVYizybht9+26Z/gUq7tiRzu+ACVAMbKVk=
+cloud.google.com/go v0.57.0/go.mod
h1:oXiQ6Rzq3RAkkY7N6t3TcE6jE+CIBBbA36lwQ1JyzZs=
+cloud.google.com/go v0.62.0/go.mod
h1:jmCYTdRCQuc1PHIIJ/maLInMho30T/Y0M
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #1946: refactor: migrate to viper configure manage
moonming commented on a change in pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#discussion_r714414659 ## File path: api/go.mod ## @@ -19,32 +18,27 @@ require ( github.com/gin-contrib/pprof v1.3.0 github.com/gin-contrib/static v0.0.0-20200916080430-d45d9a37d28e github.com/gin-gonic/gin v1.6.3 - github.com/gogo/protobuf v1.3.2 // indirect - github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e // indirect github.com/google/uuid v1.1.2 // indirect github.com/gorilla/websocket v1.4.2 // indirect github.com/grpc-ecosystem/go-grpc-middleware v1.2.2 // indirect - github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect github.com/jonboulle/clockwork v0.2.2 // indirect - github.com/json-iterator/go v1.1.11 // indirect github.com/prometheus/client_golang v1.8.0 // indirect github.com/satori/go.uuid v1.2.0 github.com/shiningrush/droplet v0.2.6-0.20210127040147-53817015cd1b github.com/shiningrush/droplet/wrapper/gin v0.2.1 github.com/sirupsen/logrus v1.7.0 // indirect github.com/sony/sonyflake v1.0.0 github.com/spf13/cobra v0.0.3 - github.com/spf13/pflag v1.0.5 // indirect + github.com/spf13/viper v1.8.1 Review comment: Having a dependency with a Category B license is fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] leslie-tsang commented on a change in pull request #224: chore: add more makefile output prompts
leslie-tsang commented on a change in pull request #224:
URL: https://github.com/apache/apisix-docker/pull/224#discussion_r714413510
##
File path: Makefile
##
@@ -63,86 +63,110 @@ endef
### build-on-centos : Build apache/apisix:xx-centos image
.PHONY: build-on-centos
build-on-centos:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-centos -f
./centos/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine : Build apache/apisix:xx-alpine image
.PHONY: build-on-alpine
build-on-alpine:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine -f
./alpine/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine-local : Build apache/apisix:xx-alpine-local image
# Actually it is not build on certain version but on local code
# Use this name (in the same patterns with others) for convenient CI
.PHONY: build-on-alpine-local
build-on-alpine-local:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine-local
--build-arg APISIX_PATH=${APISIX_PATH} -f ./alpine-local/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### push-on-centos : Push apache/apisix:xx-centos image
# centos not support multiarch since it reply on x86 rpm package
.PHONY: push-on-centos
push-on-centos:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) push $(ENV_APISIX_IMAGE_TAG_NAME)-centos
$(ENV_DOCKER) build -t $(IMAGE_NAME):latest -f ./centos/Dockerfile .
$(ENV_DOCKER) push $(IMAGE_NAME):latest
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### push-on-alpine : Push apache/apisix:xx-alpine image
.PHONY: push-multiarch-on-alpine
push-multiarch-on-alpine:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) buildx build --push \
-t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine \
--platform linux/amd64,linux/arm64 \
-f ./alpine/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine-cn : Build apache/apisix:xx-alpine image (for chinese)
.PHONY: build-on-alpine-cn
build-on-alpine-cn:
- $(ENV_DOCKER) build -t $(IMAGE_NAME):${APISIX_VERSION}-alpine
--build-arg APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
+ @$(call func_echo_status, "$@ -> [ Start ]")
+ $(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine --build-arg
APISIX_VERSION=$(APISIX_VERSION) --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
Review comment:
@tokers fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #687: fix: the fields in UpstreamPassiveHealthCheckUnhealthy should be timeouts
tokers commented on pull request #687: URL: https://github.com/apache/apisix-ingress-controller/pull/687#issuecomment-925442416 > The changes are LGTM. > > Only one question: it's v1 stable version, should we bump the api-version? Agree +1, we may also generate a `v2alpha1` version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tokers commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925442254 > my plan > > 1. add ApisixPluginConfig in types.go and generated libraries (such as clientset) > 2. add ApisixRoute as a group in config > 3. add looper for watching specific resources by using clientset (like k8s.io/client-go) and convert it 1. Refer to other types (see https://github.com/apache/apisix-ingress-controller/blob/master/pkg/kube/apisix/apis/config/v2beta1/types.go#L30) so that the CRD definition can be generated with the OpenAPIV3Schema. 2. We need to talk about the mutual exclusivity between `pluginConfig` and `plugins` fields. @tao12345666333 @gxthrj @neverCase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tokers commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925440805 > I had replied a mail on the apache mail list, but it seems something wrong. > After sending, i can't find my reply on the mail list. > @tao12345666333 @tokers You have to subscribe the d...@apisix.apache.org before you send any mails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #1946: refactor: migrate to viper configure manage
bzp2010 commented on a change in pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#discussion_r680320059 ## File path: api/go.mod ## @@ -19,32 +18,27 @@ require ( github.com/gin-contrib/pprof v1.3.0 github.com/gin-contrib/static v0.0.0-20200916080430-d45d9a37d28e github.com/gin-gonic/gin v1.6.3 - github.com/gogo/protobuf v1.3.2 // indirect - github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e // indirect github.com/google/uuid v1.1.2 // indirect github.com/gorilla/websocket v1.4.2 // indirect github.com/grpc-ecosystem/go-grpc-middleware v1.2.2 // indirect - github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect github.com/jonboulle/clockwork v0.2.2 // indirect - github.com/json-iterator/go v1.1.11 // indirect github.com/prometheus/client_golang v1.8.0 // indirect github.com/satori/go.uuid v1.2.0 github.com/shiningrush/droplet v0.2.6-0.20210127040147-53817015cd1b github.com/shiningrush/droplet/wrapper/gin v0.2.1 github.com/sirupsen/logrus v1.7.0 // indirect github.com/sony/sonyflake v1.0.0 github.com/spf13/cobra v0.0.3 - github.com/spf13/pflag v1.0.5 // indirect + github.com/spf13/viper v1.8.1 Review comment: Hi, @moonming. Sorry to bother you again. - I have read this specification [https://www.apache.org/legal/resolved.html](https://www.apache.org/legal/resolved.html) and made a query in JIRA, I found the following discussion, [LEGAL-562: Handling dependency licenses for the Solr Operator, a go project](https://issues.apache.org/jira/browse/LEGAL-562). I think our situation is similar to that in the article. We do not include the code under the MPL-2.0 license in the code distribution. The code is downloaded by the user during the compilation process. In the docker image involving binary distribution (It belongs to class B in the specification, and we can distribute it using binary), we should modify the `LICENSE` and `NOTICE` files and include them in the image as a reminder. Just like these project, [apache/skywalking-banyandb](https://github.com/apache/skywalking-banyandb). usage eg. in apache/skywalking-banyandb [https://github.com/apache/skywalking-banyandb/blob/c6314fe15b56143836e8969bd756a1310779b3b0/go.mod#L20](https://github.com/apache/skywalking-banyandb/blob/c6314fe15b56143836e8969bd756a1310779b3b0/go.mod#L20) - If we really can't include the dependencies of this library, can the above scheme of replacing the dependent library code with shim? [here](https://github.com/apache/apisix-dashboard/pull/1946#discussion_r670114961) 🤔 What do you think of this? Thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #224: chore: add more makefile output prompts
tokers commented on a change in pull request #224:
URL: https://github.com/apache/apisix-docker/pull/224#discussion_r714411304
##
File path: Makefile
##
@@ -63,86 +63,110 @@ endef
### build-on-centos : Build apache/apisix:xx-centos image
.PHONY: build-on-centos
build-on-centos:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-centos -f
./centos/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine : Build apache/apisix:xx-alpine image
.PHONY: build-on-alpine
build-on-alpine:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine -f
./alpine/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
Review comment:
```suggestion
@$(call func_echo_success_status, "$@ -> [ Done ]")
```
##
File path: Makefile
##
@@ -63,86 +63,110 @@ endef
### build-on-centos : Build apache/apisix:xx-centos image
.PHONY: build-on-centos
build-on-centos:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-centos -f
./centos/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
Review comment:
```suggestion
@$(call func_echo_success_status, "$@ -> [ Done ]")
```
##
File path: Makefile
##
@@ -63,86 +63,110 @@ endef
### build-on-centos : Build apache/apisix:xx-centos image
.PHONY: build-on-centos
build-on-centos:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-centos -f
./centos/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine : Build apache/apisix:xx-alpine image
.PHONY: build-on-alpine
build-on-alpine:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine -f
./alpine/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine-local : Build apache/apisix:xx-alpine-local image
# Actually it is not build on certain version but on local code
# Use this name (in the same patterns with others) for convenient CI
.PHONY: build-on-alpine-local
build-on-alpine-local:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine-local
--build-arg APISIX_PATH=${APISIX_PATH} -f ./alpine-local/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### push-on-centos : Push apache/apisix:xx-centos image
# centos not support multiarch since it reply on x86 rpm package
.PHONY: push-on-centos
push-on-centos:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) push $(ENV_APISIX_IMAGE_TAG_NAME)-centos
$(ENV_DOCKER) build -t $(IMAGE_NAME):latest -f ./centos/Dockerfile .
$(ENV_DOCKER) push $(IMAGE_NAME):latest
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
Review comment:
```suggestion
@$(call func_echo_success_status, "$@ -> [ Done ]")
```
##
File path: Makefile
##
@@ -63,86 +63,110 @@ endef
### build-on-centos : Build apache/apisix:xx-centos image
.PHONY: build-on-centos
build-on-centos:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-centos -f
./centos/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine : Build apache/apisix:xx-alpine image
.PHONY: build-on-alpine
build-on-alpine:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine -f
./alpine/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine-local : Build apache/apisix:xx-alpine-local image
# Actually it is not build on certain version but on local code
# Use this name (in the same patterns with others) for convenient CI
.PHONY: build-on-alpine-local
build-on-alpine-local:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-alpine-local
--build-arg APISIX_PATH=${APISIX_PATH} -f ./alpine-local/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
Review comment:
```suggestion
@$(call func_echo_success_status, "$@ -> [ Done ]")
```
##
File path: Makefile
##
@@ -63,86 +63,110 @@ endef
### build-on-centos : Build apache/apisix:xx-centos image
.PHONY: build-on-centos
build-on-centos:
+ @$(call func_echo_status, "$@ -> [ Start ]")
$(ENV_DOCKER) build -t $(ENV_APISIX_IMAGE_TAG_NAME)-centos -f
./centos/Dockerfile .
+ @$(call func_echo_success_status, "$@ -> [ Done ]")
### build-on-alpine : Build apache/apisix:xx-alpine image
.PHONY: build-on-alpine
build-on-
[GitHub] [apisix-website] liuxiran commented on issue #623: About the i18n of blogs
liuxiran commented on issue #623: URL: https://github.com/apache/apisix-website/issues/623#issuecomment-925439264 Hi @Baoyuantop , there is a [pr](https://github.com/apache/apisix-website/pull/550) about split blog into Chinese and English, see if it matches your original claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5116: docs: add gzip and real-ip zh docs
tokers commented on a change in pull request #5116: URL: https://github.com/apache/apisix/pull/5116#discussion_r714409615 ## File path: docs/zh/latest/plugins/gzip.md ## @@ -0,0 +1,108 @@ +--- +title: gzip +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) + +## 简介 + +`gzip` 插件能动态设置 `Nginx` 的压缩行为。 + +**该插件依赖 `APISIX` 运行在 [APISIX-OpenResty](../how-to-build.md#步骤6：为-apache-apisix-构建-openresty) 上。** + +## 属性 + +| 名称 | 类型 | 必选项 | 默认值| 有效值 | 描述 | +| --| | -- | | --- | --- | +| types | array[string] or "*" | 可选| ["text/html"] | | 动态设置 `gzip_types` 指令，特殊值 `"*"` 匹配任何 MIME 类型 | +| min_length | integer | 可选| 20| >= 1 | 动态设置 `gzip_min_length` 指令 | +| comp_level | integer | 可选| 1 | [1, 9] | 动态设置 `gzip_comp_level` 指令 | +| http_version | number | 可选| 1.1 | 1.1, 1.0 | 动态设置 `gzip_http_version` 指令 | +| buffers.number | integer | 可选| 32| >= 1 | 动态设置 `gzip_buffers` 指令 | +| buffers.size | integer | 可选| 4096 | >= 1 | 动态设置 `gzip_buffers` 指令 | +| vary | boolean| 可选| false | | 动态设置 `gzip_vary` 指令 | Review comment: Should we add a link for the `ngx_http_gzip_module` so that people can get the corresponding meaning of each directive. ## File path: docs/zh/latest/plugins/real-ip.md ## @@ -0,0 +1,103 @@ +--- +title: real-ip +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) + +## 简介 + +The `real-ip` 可以动态改变客户端的 `IP` 和端口。 Review comment: ```suggestion `real-ip` 插件用于动态改变客户端的 `IP` 和端口。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5020: docs: need example to introduce the details of route match
tzssangglass commented on issue #5020: URL: https://github.com/apache/apisix/issues/5020#issuecomment-925433467 this PR: https://github.com/apache/apisix/pull/5100 can fix this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2144: feat: support proto API (entity)
nic-chen commented on a change in pull request #2144:
URL: https://github.com/apache/apisix-dashboard/pull/2144#discussion_r714403464
##
File path: api/internal/core/entity/entity.go
##
@@ -58,14 +58,6 @@ func (info *BaseInfo) KeyCompat(key string) {
}
}
-type BaseInfoSetter interface {
- GetBaseInfo() *BaseInfo
-}
-
-type BaseInfoGetter interface {
- GetBaseInfo() *BaseInfo
-}
Review comment:
oh, please keep them, their responsibilities are different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] leslie-tsang commented on pull request #226: docs: optimize the reading experience
leslie-tsang commented on pull request #226: URL: https://github.com/apache/apisix-docker/pull/226#issuecomment-925429167 Ref to #194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] leslie-tsang opened a new pull request #226: docs: optimize the reading experience
leslie-tsang opened a new pull request #226: URL: https://github.com/apache/apisix-docker/pull/226 Signed-off-by: leslie tsang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Baoyuantop opened a new issue #623: About the i18n of blogs
Baoyuantop opened a new issue #623: URL: https://github.com/apache/apisix-website/issues/623 **Actual Behaviour** Currently, our blogs are mixed in English and Chinese. All blogs are displayed whether in English or Chinese. This often brings confusion and inconvenience to users of different languages. **Expected Behaviour** When the current environment is in English, only English blogs are displayed, and in the Chinese environment, only Chinese blogs are displayed. After analysis, we can use the [`draft`](https://docusaurus.io/zh-CN/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-frontmatter) property of the markdown file to solve, It means that the current document is still in draft and will not be displayed in the blog. So because we default to the English environment, add the `draft` property to all Chinese blogs in the `website/blog` directory. After that, copy all the blog files to the `website/i18n/zh/docusaurus-plugin-content-blog` directory, and then add the `draft` property to all English blogs. **Note**: draft will still be displayed in development mode, but after build, it works ~ What do you think？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2144: feat: support proto API (entity)
liuxiran commented on pull request #2144: URL: https://github.com/apache/apisix-dashboard/pull/2144#issuecomment-925411036 Hi @bzp2010 it would be better to add test cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] leslie-tsang opened a new pull request #225: docs: use make instead of docker
leslie-tsang opened a new pull request #225: URL: https://github.com/apache/apisix-docker/pull/225 1. update APISIX version to `2.9` 2. use make instead of docker cmd in docs, more elegant Signed-off-by: leslie tsang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2145: docs: update FAQ.md to include SPA deployment
liuxiran commented on pull request #2145: URL: https://github.com/apache/apisix-dashboard/pull/2145#issuecomment-925407730 As @bzp2010 said, we recommend using APISIX way to solve the problem so that you can experience the advantages of APISIX > as you known, static SPA index.html not has port. sorry, I did not got you this point @CGerAJ . From your doc, let`s suppose that your SPA was deploied in 127.0.0.1：8099, and you can visit `http://127. 0.0.1:8099/` to visit your SPA app. you can just publish a route with upstream `127.0.0.1:8099` with uri `/*`, maybe you would wonder how to proxy any uri to your upstream `/` or `/index.html` right? If so you can refer to `proxy-rewrite` plugin Please let me know whether I have any misunderstanding, Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] leslie-tsang opened a new pull request #224: chore: add more makefile output prompts
leslie-tsang opened a new pull request #224: URL: https://github.com/apache/apisix-docker/pull/224 1. add more makefile target output prompts 2. fix target `help` prompts to sync with linux runtime > before ```bash docker build output ... ``` > after ```bash [ info ] build-on-centos -> [ Start ] docker build output ... [ info ] build-on-centos -> [ Done ] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Superskyyy commented on pull request #5101: chore: clean up SkyWalking docs
Superskyyy commented on pull request #5101: URL: https://github.com/apache/apisix/pull/5101#issuecomment-925178191 Please review and merge this first, logo fix will be coming in another PR. @tokers Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr commented on pull request #5101: chore: clean up SkyWalking docs
dmsolr commented on pull request #5101: URL: https://github.com/apache/apisix/pull/5101#issuecomment-925083978 > That is a screenshot from the original plugin contributor right? I will need to deploy APISIX to make a new ss, let's merge this one first and I will do the logo fix when I got time. What you think. @dmsolr Yes. This is good to me to update the screenshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on pull request #5117: docs: supplementary health check documents
shuaijinchao commented on pull request #5117: URL: https://github.com/apache/apisix/pull/5117#issuecomment-924990144 https://github.com/apache/apisix/blob/0ba89d5c0f9dc2863329a8fa6552c380453627cf/apisix/schema_def.lua#L131-L145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new pull request #5117: docs: supplementary health check documents
shuaijinchao opened a new pull request #5117: URL: https://github.com/apache/apisix/pull/5117 ### What this PR does / why we need it: Supplementary health check documents. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] huang-x-h opened a new pull request #5116: docs: add gzip and real-ip zh docs
huang-x-h opened a new pull request #5116: URL: https://github.com/apache/apisix/pull/5116 ### What this PR does / why we need it: https://github.com/apache/apisix-website/issues/544 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun edited a comment on pull request #1769: feat: add Cancel Previous Runs CI
LiteSun edited a comment on pull request #1769: URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-924951428 Duplicate with https://github.com/apache/apisix-dashboard/pull/1795 and close this pr. A-0: When a GitHub action is running with a new commit, the CI of the previous commit is not automatically cancelled. Need to check if the GitHub action has been updated. A-1: see https://github.com/styfle/cancel-workflow-action#advanced-canceling-other-workflows docs. A-2: will not affect each other. see: https://github.com/styfle/cancel-workflow-action#how-does-it-work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun closed pull request #1769: feat: add Cancel Previous Runs CI
LiteSun closed pull request #1769: URL: https://github.com/apache/apisix-dashboard/pull/1769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1769: feat: add Cancel Previous Runs CI
LiteSun commented on pull request #1769: URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-924951428 Duplicate with https://github.com/apache/apisix-dashboard/pull/1795 and close this or. A-0: When a GitHub action is running with a new commit, the CI of the previous commit is not automatically cancelled. Need to check if the GitHub action has been updated. A-1: see https://github.com/styfle/cancel-workflow-action#advanced-canceling-other-workflows docs. A-2: will not affect each other. see: https://github.com/styfle/cancel-workflow-action#how-does-it-work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Superskyyy edited a comment on pull request #5101: chore: clean up SkyWalking docs
Superskyyy edited a comment on pull request #5101: URL: https://github.com/apache/apisix/pull/5101#issuecomment-924910084 > Hi, @Superskyyy I saw the picture of SkyWalking topology which is using Nginx logo as APISIX's logo. > It is out of date in SkyWalking 8.7.0. Could you update the picture? That is a screenshot from the original plugin contributor right? I will need to deploy APISIX to make a new ss, let's merge this one first and I will do the logo fix when I got time. What you think. @dmsolr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2145: docs: update FAQ.md to include SPA deployment
juzhiyuan commented on pull request #2145: URL: https://github.com/apache/apisix-dashboard/pull/2145#issuecomment-924932072 Yes, although Apache APISIX could support Static files, it's not recommended to use like this way 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Superskyyy edited a comment on pull request #5101: chore: clean up SkyWalking docs
Superskyyy edited a comment on pull request #5101: URL: https://github.com/apache/apisix/pull/5101#issuecomment-924910084 > Hi, @Superskyyy I saw the picture of SkyWalking topology which is using Nginx logo as APISIX's logo. > It is out of date in SkyWalking 8.7.0. Could you update the picture? Sure! Will update later. @dmsolr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Superskyyy commented on pull request #5101: chore: clean up SkyWalking docs
Superskyyy commented on pull request #5101: URL: https://github.com/apache/apisix/pull/5101#issuecomment-924910084 > Hi, @Superskyyy I saw the picture of SkyWalking topology which is using Nginx logo as APISIX's logo. > It is out of date in SkyWalking 8.7.0. Could you update the picture? Sure! Will update later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (d848a44 -> 8d69af5)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from d848a44 fix(nacos): continue to process other services when request failed (#5112) add 8d69af5 test(debug): add test cases for hook ctx (#5113) No new revisions were added by this update. Summary of changes: t/debug/dynamic-hook.t | 64 ++ 1 file changed, 64 insertions(+)
