[GitHub] [apisix-website] juzhiyuan merged pull request #637: feat: add Draft Property to newly added blogs
juzhiyuan merged pull request #637: URL: https://github.com/apache/apisix-website/pull/637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: docs: add Draft Property to newly added blogs (#637)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 7b77f0e docs: add Draft Property to newly added blogs (#637)
7b77f0e is described below
commit 7b77f0ed3044f0610d45a4cd873775cd15da0646
Author: Kishani Kandasamy <53715187+kishanikandas...@users.noreply.github.com>
AuthorDate: Wed Oct 6 09:01:35 2021 +0530
docs: add Draft Property to newly added blogs (#637)
---
.../blog/2021-06-29-release-apache-apisix-2.7.md | 61 -
.../blog/2021-07-28-release-apache-apisix-2.8.md | 152 -
...ors-the-golden-metric-of-openSource-projects.md | 94 -
website/blog/2021-09-30-weekly-report.md | 1 +
website/blog/2021-10-01-openEuler.md | 1 +
.../2021-06-29-release-apache-apisix-2.7-en.md | 61 -
.../2021-07-28-release-apache-apisix-2.8-en.md | 151
...-the-golden-metric-of-openSource-projects-en.md | 97 -
.../2021-09-29-release-apache-apisix-2.10.md | 0
.../2021-09-30-weekly-report.md| 0
.../2021-10-01-openEuler.md| 0
11 files changed, 2 insertions(+), 616 deletions(-)
diff --git a/website/blog/2021-06-29-release-apache-apisix-2.7.md
b/website/blog/2021-06-29-release-apache-apisix-2.7.md
deleted file mode 100644
index 18a8e11..000
--- a/website/blog/2021-06-29-release-apache-apisix-2.7.md
+++ /dev/null
@@ -1,61 +0,0 @@
-title: "Apache APISIX 2.7.0-Release 正式发布"
-author: "罗泽轩"
-authorURL: "https://github.com/spacewander";
-authorImageURL: "https://avatars.githubusercontent.com/u/4161644?v=4";
-keywords:
-- Apache APISIX
-- Release Notes
-Description: Apache APISIX 2.7.0-Release 正式发布！
-tags: [Release]
-draft: true
-
-> Apache APISIX 2.7.0-Release 正式发布！
-
-
-
-Apache APISIX 2.7.0-Release 正式发布！欢迎大家下载使用。
-
-这个版本支持了多语言插件、增强了四层 TCP 代理、增强了 Nginx 功能，有 20+ 开发者参与，共提交了 70+ PR，下面是重点功能的介绍。
-
-## Release Notes
-
-### 多语言插件
-
-随着 apisix-java-plugin-runner 发布第一个版本，外加 apisix-go-plugin-runner 完成主体功能，APISIX
的多语言插件功能已经支持两大最广泛使用的后端编程语言。如果你还担忧 APISIX 的插件开发会受限于 Lua 生态，不妨试试使用我们的多语言 plugin
runner 来开发 Java / Go 插件。
-
-### 增强四层 TCP 代理
-
-2.7 版本中，我们开发了 TCP 代理新功能，包括：
-
-* 允许 upstream 中配置域名
-* 允许 mqtt-proxy 插件配置域名
-* 支持接收 TLS over TCP 连接，这一块的证书自然是可以像 HTTPS 的证书一样动态配置的
-* 基于 SNI 的路由规则
-* 动态校验客户端证书
-
-在后续版本中，我们也会继续分配部分资源来完善现有的 TCP 代理功能，敬请期待！
-
-### 增强 Nginx 功能
-
-我们希望能够动态设置越来越多的 Nginx 配置，所以我们添加自己的补丁和 Nginx C 模块，增强原生 Nginx 的功能。
-
-目前包含了以下新功能：
-
-* 动态设置 mTLS
-* 动态设置 client_max_body_size
-
-在 APISIX 后续版本中，我们也会陆续允许下面的 Nginx 配置能够被动态设置：
-
-* upstream 的 keepalive
-* gzip
-* real_ip
-* proxy_max_temp_file_size
-
-## 下载
-
-下载 Apache APISIX 2.7.0-Release
-
-* 源代码：请访问[下载页面](https://apisix.apache.org/downloads/)
-* 二进制安装包：请访问[安装指南](https://apisix.apache.org/zh/docs/apisix/how-to-build/)
diff --git a/website/blog/2021-07-28-release-apache-apisix-2.8.md
b/website/blog/2021-07-28-release-apache-apisix-2.8.md
deleted file mode 100644
index 6013243..000
--- a/website/blog/2021-07-28-release-apache-apisix-2.8.md
+++ /dev/null
@@ -1,152 +0,0 @@
-title: "Apache APISIX 2.8 正式发布，带来更多新功能！"
-author: "罗泽轩"
-authorURL: "https://github.com/spacewander";
-authorImageURL: "https://avatars.githubusercontent.com/u/4161644?v=4";
-keywords:
-- APISIX
-- Release Notes
-- Apache APISIX
-description: Apache APISIX 2.8 版本正式发布！
-tags: [Release]
-draft: true
-
-> Apache APISIX 2.8 版本正式发布！
-
-
-
-Apache APISIX 2.8 版本正式发布！🎉 这个版本有 30+ 开发者参与，共提交了 100+ PR，支持了 **1 个新功能、1 个新体验、2
个新插件、2 个新玩法**，快去阅读了解 2.8 版本的新特性吧！
-
-👇👇👇
-
-## Release Notes
-
-### 新功能：独立的 Keepalive 连接池
-
-从[2.7
版本](https://apisix.apache.org/blog/2021/06/29/release-apache-apisix-2.7)开始添加
Apache APISIX 自己的补丁和 Nginx C 模块，增强原生 Nginx 的功能，希望能够动态设置越来越多的 Nginx
配置。在发布的最新版本中，Apache APISIX 已经支持在 Upstream 级别上配置独立的 Keepalive 连接池。
-
-目前包含了以下功能：
-
-- 动态设置 mTLS
-- 动态设置 client_max_body_size
-- Upstream 的 keepalive（2.8 新功能）
-- gzip （2.8 新插件）
-
-在 Apache APISIX 后续版本中，我们也会陆续允许下面的 Nginx 配置能够被动态设置：
-
-- real_ip
-- proxy_max_temp_file_size
-- ……
-
-Upstream 的配置举例：
-
-```JSON
-{
-"id": "backend",
-"nodes": {"host:80": 100},
-"type":"roundrobin",
-"keepalive_pool": {
-"size": 4,
-"idle_timeout": 8,
-"requests": 16
-}
-}
-```
-
-### 新体验：stream 代理功能增强
-
-在 2.8 版本中，把
[ip-restriction](http://apisix.apache.org/docs/apisix/plugins/ip-restriction/)
和 [limit-conn](http://apisix.apache.org/docs/apisix/plugins/limit-conn/) 两个插件从
HTTP 部分的移植到了 stream 部分，这么做的好处是丰富网关在 stream 代理的功能，增加对上游服务的安全性保障。
-
-ip-restriction 可以用来做 IP 黑白名单过滤，保证只有来自特定 IP 的请求才能访问到后端服务。
-
-limit-conn 可以用来限制特定路由上同时存在的连接个数，限制客户端的并发访问量。
-
-### 新插件：gzip 插件
-
-2.8 版本中新增了 gzip 插件，使用 gzip 插件可以**动态设置路由级别的 gzip 参数**。
-
-gzip 配置举例：
-
-```JSON
-{
-"plugins": {
-"gzip": {
-"min_length": 20,
-"http_version"
[GitHub] [apisix-ingress-controller] geffzhang edited a comment on issue #569: request help: apisix ingress controller with Dapr
geffzhang edited a comment on issue #569: URL: https://github.com/apache/apisix-ingress-controller/issues/569#issuecomment-935307672 bash-5.1# netstat -an | grep 90 tcp0 0 0.0.0.0:90800.0.0.0:* LISTEN tcp0 0 0.0.0.0:90800.0.0.0:* LISTEN tcp0 0 127.0.0.1:9090 0.0.0.0:* LISTEN tcp0 0 127.0.0.1:9091 0.0.0.0:* LISTEN tcp0 0 10.244.0.16:908010.240.0.4:38288 ESTABLISHED tcp0 0 10.244.0.16:908010.240.0.6:54711 ESTABLISHED tcp0 0 10.244.0.16:908010.240.0.5:12667 ESTABLISHED tcp0 0 :::9080 :::*LISTEN tcp0 0 :::9080 :::*LISTEN unix 3 [ ] STREAM CONNECTED 1365790 @tokers 9090 is https://github.com/apache/apisix-ingress-controller/blob/1c17b41249361444b5b10f4a8897f62484b545b0/test/e2e/scaffold/apisix.go#L127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] geffzhang commented on issue #569: request help: apisix ingress controller with Dapr
geffzhang commented on issue #569: URL: https://github.com/apache/apisix-ingress-controller/issues/569#issuecomment-935307672 bash-5.1# netstat -an | grep 90 tcp0 0 0.0.0.0:90800.0.0.0:* LISTEN tcp0 0 0.0.0.0:90800.0.0.0:* LISTEN tcp0 0 127.0.0.1:9090 0.0.0.0:* LISTEN tcp0 0 127.0.0.1:9091 0.0.0.0:* LISTEN tcp0 0 10.244.0.16:908010.240.0.4:38288 ESTABLISHED tcp0 0 10.244.0.16:908010.240.0.6:54711 ESTABLISHED tcp0 0 10.244.0.16:908010.240.0.5:12667 ESTABLISHED tcp0 0 :::9080 :::*LISTEN tcp0 0 :::9080 :::*LISTEN unix 3 [ ] STREAM CONNECTED 1365790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2144: feat: support proto API (entity)
bzp2010 commented on a change in pull request #2144:
URL: https://github.com/apache/apisix-dashboard/pull/2144#discussion_r722811146
##
File path: api/internal/core/entity/entity.go
##
@@ -290,3 +282,10 @@ type PluginConfig struct {
Plugins map[string]interface{} `json:"plugins"`
Labels map[string]string `json:"labels,omitempty"`
}
+
+// swagger:model Proto
Review comment:
I think this can be used to generate API documents and should be
retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh edited a comment on pull request #641: feat: update the blog page
1502shivam-singh edited a comment on pull request #641: URL: https://github.com/apache/apisix-website/pull/641#issuecomment-934829074 > 2. there seems to be some empty space and I'm torn between removing it and adding the header, but I think it looks good too, it just looks like something is missing Absence of balancing visual element i guess (check example below). Though, it seems trivial to me for now, we can work on it later maybe.  the dots graphic and slight color change does that here. We can too put something less focus wanting, but a balancing visual element in the right or left area for some balance. Though, this one looks fine too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #641: feat: update the blog page
1502shivam-singh commented on pull request #641: URL: https://github.com/apache/apisix-website/pull/641#issuecomment-934829074 > 2. there seems to be some empty space and I'm torn between removing it and adding the header, but I think it looks good too, it just looks like something is missing Absence of balancing visual element i guess (check example below). Though, it seems trivial to me for now, we can work on it later maybe.  the dots graphic and slight color change does that here. We can too put something less focus wanting, but a balancing visual element in the right or left area for some balance. Though, this one also looks fine too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #641: feat: update the blog page
1502shivam-singh commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722663987
##
File path: website/src/theme/BlogTagsPostsPage/index.js
##
@@ -0,0 +1,68 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+import React, { useEffect, useState } from 'react';
+import Layout from '@theme/Layout';
+import BlogPostItem from '@theme/BlogPostItem';
+import BlogSidebar from '@theme/BlogSidebar';
+import { ThemeClassNames } from '@docusaurus/theme-common'; // Very simple
pluralization: probably good enough for now
+
+function BlogTagsPostPage(props) {
+ const { metadata, items } = props;
+ const { name: tagName } = metadata;
+ const [, setTagsCount] = useState();
+ const tagsTotal = JSON.parse(localStorage.getItem('tagsTotal'));
Review comment:
Will pushing the definition of `tagsTotal` in useEffect cause some
errors or unwanted behaviour ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #641: feat: update the blog page
1502shivam-singh commented on a change in pull request #641: URL: https://github.com/apache/apisix-website/pull/641#discussion_r722679257 ## File path: website/src/theme/BlogPostItem/index.js ## @@ -0,0 +1,134 @@ +/** + * Copyright (c) Facebook, Inc. and its affiliates. + * + * This source code is licensed under the MIT license found in the Review comment: Yup, the blog page is not so customisable directly, so docusaurus has this functionality to `swizzle` out elements, Refer to this - [`swizzle`](https://github.com/apache/apisix-website/issues/490#issuecomment-911850832) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #641: feat: update the blog page
1502shivam-singh commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722663987
##
File path: website/src/theme/BlogTagsPostsPage/index.js
##
@@ -0,0 +1,68 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+import React, { useEffect, useState } from 'react';
+import Layout from '@theme/Layout';
+import BlogPostItem from '@theme/BlogPostItem';
+import BlogSidebar from '@theme/BlogSidebar';
+import { ThemeClassNames } from '@docusaurus/theme-common'; // Very simple
pluralization: probably good enough for now
+
+function BlogTagsPostPage(props) {
+ const { metadata, items } = props;
+ const { name: tagName } = metadata;
+ const [, setTagsCount] = useState();
+ const tagsTotal = JSON.parse(localStorage.getItem('tagsTotal'));
Review comment:
Will pushing the definition of `tagsTotal` in useEffect cause some
errors ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #641: feat: update the blog page
1502shivam-singh commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722663987
##
File path: website/src/theme/BlogTagsPostsPage/index.js
##
@@ -0,0 +1,68 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+import React, { useEffect, useState } from 'react';
+import Layout from '@theme/Layout';
+import BlogPostItem from '@theme/BlogPostItem';
+import BlogSidebar from '@theme/BlogSidebar';
+import { ThemeClassNames } from '@docusaurus/theme-common'; // Very simple
pluralization: probably good enough for now
+
+function BlogTagsPostPage(props) {
+ const { metadata, items } = props;
+ const { name: tagName } = metadata;
+ const [, setTagsCount] = useState();
+ const tagsTotal = JSON.parse(localStorage.getItem('tagsTotal'));
Review comment:
Will pushing the definition of this in useEffect cause some errors ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zhendongcmss opened a new pull request #5174: refine init response message
zhendongcmss opened a new pull request #5174: URL: https://github.com/apache/apisix/pull/5174 fix https://github.com/apache/apisix/issues/3316 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on issue #5149: request help: use name instead of id in grafana dashboard
starsz commented on issue #5149: URL: https://github.com/apache/apisix/issues/5149#issuecomment-934524208 Yes.I think we can use the name as the label of Prometheus if the name exists? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2144: feat: support proto API (entity)
starsz commented on a change in pull request #2144:
URL: https://github.com/apache/apisix-dashboard/pull/2144#discussion_r716211270
##
File path: api/internal/core/entity/entity.go
##
@@ -290,3 +282,10 @@ type PluginConfig struct {
Plugins map[string]interface{} `json:"plugins"`
Labels map[string]string `json:"labels,omitempty"`
}
+
+// swagger:model Proto
Review comment:
I think we don't need swagger.
cc @nic-chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2010: feat: new authentication framework
starsz commented on a change in pull request #2010:
URL: https://github.com/apache/apisix-dashboard/pull/2010#discussion_r722365009
##
File path: api/internal/conf/authentication.go
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package conf
+
+import (
+ "strconv"
+
+ "github.com/apisix/manager-api/internal/utils"
+ "github.com/apisix/manager-api/internal/utils/consts"
+)
+
+var (
+ // UserList is a mapping of user type and users
+ // like local => [User1, User2] google => [User3, User4] github =>
[User5, User6]
+ UserList = make([]DashboardUserLocal, 0)
Review comment:
Why not use map instead ?
##
File path: api/internal/handler/authentication/authentication.go
##
@@ -87,22 +94,61 @@ func (h *Handler) userLogin(c droplet.Context)
(interface{}, error) {
username := input.Username
password := input.Password
- user := conf.UserList[username]
- if username != user.Username || password != user.Password {
- return nil, consts.ErrUsernamePassword
- }
+ loginSuccess := false
+ switch conf.DataSource {
+ case conf.DataSourceTypeLocal:
+ users := conf.UserList
+ for _, user := range users {
+ if username == user.Username {
+ ok, err := user.Valid(password)
+ if !ok && err != nil {
+ return nil, err
+ }
+
+ loginSuccess = true
+ }
+ }
+ case conf.DataSourceTypeEtcd:
+ ret, err := h.dashboardUserStore.List(c.Context(),
store.ListInput{
+ Predicate: func(obj interface{}) bool {
+ return obj.(*entity.DashboardUser).Username ==
username
+ },
+ Format: func(obj interface{}) interface{} {
+ return obj.(*entity.DashboardUser)
+ },
+ PageSize: math.MaxInt32,
+ PageNumber: 1,
+ })
+ if err != nil {
+ return nil, err
+ }
- // create JWT for session
- claims := jwt.StandardClaims{
- Subject: username,
- IssuedAt: time.Now().Unix(),
- ExpiresAt: time.Now().Add(time.Second *
time.Duration(conf.AuthConf.ExpireTime)).Unix(),
+ if ret.TotalSize == 1 {
+ user := ret.Rows[0].(*entity.DashboardUser)
+ err :=
bcrypt.CompareHashAndPassword([]byte(user.Password), []byte(password))
Review comment:
I would prefer the way that uses salt.
##
File path: api/internal/filter/authentication.go
##
@@ -90,7 +93,40 @@ func (mw *AuthenticationMiddleware) Handle(ctx
droplet.Context) error {
return nil
}
- if _, ok := conf.UserList[claims.Subject]; !ok {
+ userExist := false
+ switch conf.DataSourceType(claims.Audience) {
+ case conf.DataSourceTypeEtcd:
+ dashboardUserStore := store.GetStore(store.HubKeyDashboardUser)
+ ret, err := dashboardUserStore.List(ctx.Context(),
store.ListInput{
+ Predicate: func(obj interface{}) bool {
+ return claims.Subject ==
obj.(*entity.DashboardUser).Username
+ },
+ Format: func(obj interface{}) interface{} {
+ return obj.(*entity.DashboardUser)
+ },
+ PageSize: math.MaxInt32,
+ PageNumber: 1,
+ })
+ if err != nil {
+ log.Warn("user not exist in etcd")
+ ctx.SetOutput(&data.SpecCodeResponse{StatusCode:
http.StatusUnauthorized, Response: response})
+ return nil
+ }
+
+ if ret.TotalSize > 0 {
+ userExist = true
+
[GitHub] [apisix-website] guoqqqi commented on a change in pull request #641: feat: update the blog page
guoqqqi commented on a change in pull request #641: URL: https://github.com/apache/apisix-website/pull/641#discussion_r722283461 ## File path: website/src/theme/BlogPostItem/index.js ## @@ -0,0 +1,134 @@ +/** + * Copyright (c) Facebook, Inc. and its affiliates. + * + * This source code is licensed under the MIT license found in the Review comment: The file is a commit of the PR I recovered under https://github.com/apache/apisix-website/pull/616 and it appears to be a shell CLI generated file, https://docusaurus.io/docs/cli#docusaurus-swizzle-sitedir cc @Baoyuantop have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #640: New landing page Issues
juzhiyuan commented on issue #640: URL: https://github.com/apache/apisix-website/issues/640#issuecomment-934449969 > EDIT: We have blog posts tagged as events in blogs, maybe add them to events.json ? Ya, maybe @Serendipity96 could explain why we remove the Events page and using the events tag 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #641: feat: update the blog page
juzhiyuan commented on a change in pull request #641: URL: https://github.com/apache/apisix-website/pull/641#discussion_r722278022 ## File path: website/src/theme/BlogPostItem/index.js ## @@ -0,0 +1,134 @@ +/** + * Copyright (c) Facebook, Inc. and its affiliates. + * + * This source code is licensed under the MIT license found in the Review comment: This file is copied from Facebook? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #641: feat: update the blog page
guoqqqi commented on pull request #641: URL: https://github.com/apache/apisix-website/pull/641#issuecomment-934440047  I am not currently adding too much styling to the header page and I have a few problems that I need help with. 1. if I add a background colour or image to the header section, it doesn't seem to match the style of the other pages, like the team etc page  2. there seems to be some empty space and I'm torn between removing it and adding the header, but I think it looks good too, it just looks like something is missing cc @juzhiyuan @1502shivam-singh @Baoyuantop @bzp2010 @liuxiran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh edited a comment on issue #640: New landing page Issues
1502shivam-singh edited a comment on issue #640: URL: https://github.com/apache/apisix-website/issues/640#issuecomment-934394672 > In the Events part, some links are broken. cc @guoqqqi Oh okay, surprisingly there is no events tab any more ? Where do we link the events to, blog pages ? EDIT: We have blog posts tagged as events in blogs, maybe add them to events.json ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on issue #640: New landing page Issues
1502shivam-singh commented on issue #640: URL: https://github.com/apache/apisix-website/issues/640#issuecomment-934394672 > In the Events part, some links are broken. cc @guoqqqi Oh okay, surprisingly there is no events tab any more ? Where do we link the events to, blog pages ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #637: feat: add Draft Property to newly added blogs
juzhiyuan commented on pull request #637: URL: https://github.com/apache/apisix-website/pull/637#issuecomment-934391824 Thanks! Need @Baoyuantop @guoqqqi to have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #640: New landing page Issues
juzhiyuan commented on issue #640: URL: https://github.com/apache/apisix-website/issues/640#issuecomment-934390984 ya, I would suggest using a Playlist here :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] guoqqqi opened a new pull request #641: feat: update the blog page
guoqqqi opened a new pull request #641: URL: https://github.com/apache/apisix-website/pull/641 Changes:  1. Left sidebar replaced with tags Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on issue #640: New landing page Issues
1502shivam-singh commented on issue #640: URL: https://github.com/apache/apisix-website/issues/640#issuecomment-934383893 > 1. This Video is muted, I couldn't play it with audio; It wasn't an Yt embed so I just left it on mute, will unmute it 👍 > 2. How about using YouTube's playlist here? so visitors could watch and play more videos. For Chinese, we could change the Playlist to Apache APISIX's Bilibili. I guess a nice option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #2453: discuss: apisix supports obtaining etcd data information through plugin
github-actions[bot] commented on issue #2453: URL: https://github.com/apache/apisix/issues/2453#issuecomment-934260342 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Qizhd commented on a change in pull request #5163: fix: pass correct host header to health checker target nodes
Qizhd commented on a change in pull request #5163: URL: https://github.com/apache/apisix/pull/5163#discussion_r722014551 ## File path: apisix/upstream.lua ## @@ -293,7 +293,7 @@ function _M.set_by_route(route, api_ctx) end if nodes_count > 1 then -local checker = fetch_healthchecker(up_conf) +local checker = fetch_healthchecker(up_conf, api_ctx.var.host) Review comment: @spacewander ok, will update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy edited a comment on pull request #637: feat: add Draft Property to newly added blogs
KishaniKandasamy edited a comment on pull request #637: URL: https://github.com/apache/apisix-website/pull/637#issuecomment-934065491 > > Hi @KishaniKandasamy, I noticed we also have some posts duplicated, do we have to keep them? e.g the `release-apache-apisix-2.10.md` in Chinese. > > No if both english and chinese translations are done for a blog, then we could remove its duplicate and there is no need to add draft property there.I will check it out and remove them in this PR👍 Hi @juzhiyuan the duplicates are removed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #582: Support PR preview
juzhiyuan commented on issue #582: URL: https://github.com/apache/apisix-website/issues/582#issuecomment-934130630 Yes, will find out another way 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #156: https for website
juzhiyuan commented on issue #156: URL: https://github.com/apache/apisix-website/issues/156#issuecomment-934129987 Yes, I did, but still no response 🥲 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
