[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2178: feat: add gzip middleware
bzp2010 commented on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947379939 LGTM ping @nic-chen @starsz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2178: feat: add gzip middleware
bzp2010 commented on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947377811 > > @nic-6443 I have fixed this problem. By the way, have you tested the effect of gzip compression on speeding up the transmission of static resources in your local environment? > > Yes, static files size decrease greatly after gzip.  According to the maximum file size (~500k) and 5s timeout, then the network transmission speed is greater than 100 KB/s, it can work normally. Nice job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2178: feat: add gzip middleware
codecov-commenter edited a comment on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09f6f70) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **increase** coverage by `7.95%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2178 +/- ## == + Coverage 62.70% 70.65% +7.95% == Files 62 62 Lines3928 3929 +1 == + Hits 2463 2776 +313 + Misses 1178 857 -321 - Partials 287 296 +9 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.34% <100.00%> (+0.75%)` | :arrow_up: | | backend-e2e-test-ginkgo | `49.35% <100.00%> (?)` | | | backend-unit-test | `50.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.17% <100.00%> (+0.33%)` | :arrow_up: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `70.70% <0.00%> (+2.52%)` | :arrow_up: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `92.74% <0.00%> (+3.22%)` | :arrow_up: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `92.10% <0.00%> (+5.26%)` | :arrow_up: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `78.94% <0.00%> (+5.26%)` | :arrow_up: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `74.40% <0.00%> (+5.68%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2lud
[GitHub] [apisix-dashboard] nic-6443 commented on pull request #2178: feat: add gzip middleware
nic-6443 commented on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947377060 > @nic-6443 I have fixed this problem. By the way, have you tested the effect of gzip compression on speeding up the transmission of static resources in your local environment? Yes, static files size decrease greatly after gzip.  According to the maximum file size (~500k) and 5s timeout, then the network transmission speed is greater than 100 KB/s, it can work normally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2178: feat: add gzip middleware
codecov-commenter edited a comment on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09f6f70) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **increase** coverage by `4.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2178 +/- ## == + Coverage 62.70% 66.70% +4.00% == Files 62 62 Lines3928 3929 +1 == + Hits 2463 2621 +158 + Misses 1178 1015 -163 - Partials 287 293 +6 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `49.35% <100.00%> (?)` | | | backend-unit-test | `50.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.17% <100.00%> (+0.33%)` | :arrow_up: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `32.11% <0.00%> (-35.41%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `68.11% <0.00%> (-17.40%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `60.00% <0.00%> (-13.00%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `84.48% <0.00%> (-1.73%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `68.68% <0.00%> (+0.50%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVy
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2178: feat: add gzip middleware
codecov-commenter edited a comment on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09f6f70) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **decrease** coverage by `12.31%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2178 +/- ## === - Coverage 62.70% 50.39% -12.32% === Files 62 40 -22 Lines3928 3072 -856 === - Hits 2463 1548 -915 - Misses 1178 1330 +152 + Partials 287 194 -93 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-unit-test | `50.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-68.19%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-60.00%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/utils/pid.go](https://codecov.io/gh/
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2178: feat: add gzip middleware
bzp2010 commented on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947373743 @nic-6443 I have fixed this problem. By the way, have you tested the effect of gzip compression on speeding up the transmission of static resources in your local environment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2178: feat: add gzip middleware
codecov-commenter edited a comment on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00149ce) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **increase** coverage by `4.20%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2178 +/- ## == + Coverage 62.70% 66.91% +4.20% == Files 62 62 Lines3928 3929 +1 == + Hits 2463 2629 +166 + Misses 1178 1006 -172 - Partials 287 294 +7 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `49.55% <100.00%> (?)` | | | backend-unit-test | `50.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.17% <100.00%> (+0.33%)` | :arrow_up: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `32.11% <0.00%> (-35.41%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `68.11% <0.00%> (-17.40%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `60.00% <0.00%> (-13.00%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `84.48% <0.00%> (-1.73%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `68.68% <0.00%> (+0.50%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGV
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2178: feat: add gzip middleware
codecov-commenter edited a comment on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00149ce) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **decrease** coverage by `12.31%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2178 +/- ## === - Coverage 62.70% 50.39% -12.32% === Files 62 40 -22 Lines3928 3072 -856 === - Hits 2463 1548 -915 - Misses 1178 1330 +152 + Partials 287 194 -93 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-unit-test | `50.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-68.19%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-60.00%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/utils/pid.go](https://codecov.io/gh/
[GitHub] [apisix] zaunist commented on pull request #5274: docs: add simplified Chinese translation for plugin authz-casbin
zaunist commented on pull request #5274: URL: https://github.com/apache/apisix/pull/5274#issuecomment-947369374 Hi, @leslie-tsang ,I have updated docs, please take a look😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2178: feat: add gzip middleware
bzp2010 commented on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947368449 @nic-6443 Because the frontend static files are not compiled and correctly placed during the backend E2E test, the server will respond to 404 errors. Just ignore it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2178: feat: add gzip middleware
codecov-commenter edited a comment on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (42ada8e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **decrease** coverage by `12.34%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2178 +/- ## === - Coverage 62.70% 50.35% -12.35% === Files 62 40 -22 Lines3928 3072 -856 === - Hits 2463 1547 -916 - Misses 1178 1331 +153 + Partials 287 194 -93 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-unit-test | `50.35% <ø> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-68.19%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-60.00%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/utils/pid.go](http
[GitHub] [apisix] mangoGoForward edited a comment on pull request #5016: feat: xml-json-conversion plugin convert xml data from request body to json response, and vice versa
mangoGoForward edited a comment on pull request #5016: URL: https://github.com/apache/apisix/pull/5016#issuecomment-947305115 > I am curious about the use case of this plugin. If it is just converting XML to JSON online, and echoing it back, why should we add it as a feature of API gateway? Maybe we should pass the converted body to the upstream, which could be useful. I think so right now, thanks for your suggestion. @spacewander @arthur-zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #715: feat: add label-selector for watching namespace
tao12345666333 commented on a change in pull request #715:
URL:
https://github.com/apache/apisix-ingress-controller/pull/715#discussion_r731475754
##
File path: pkg/ingress/compare.go
##
@@ -50,17 +50,17 @@ func (c *Controller) CompareResources(ctx context.Context)
error {
log.Error(err.Error())
ctx.Done()
} else {
- wns := make(map[string]struct{}, len(nsList.Items))
+ //wns := make(map[string]struct{}, len(nsList.Items))
Review comment:
Remove this comment
##
File path: docs/en/latest/practices/the-hard-way.md
##
@@ -623,6 +623,8 @@ data:
resync_interval: "30s"
app_namespaces:
- "*"
Review comment:
this one should be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #684: request help: error log "failed to delete pod from cache"
tao12345666333 closed issue #684: URL: https://github.com/apache/apisix-ingress-controller/issues/684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #684: request help: error log "failed to delete pod from cache"
tao12345666333 commented on issue #684: URL: https://github.com/apache/apisix-ingress-controller/issues/684#issuecomment-947344660 #714 has been merged, I think we can close this one. If you have any question please feel free to reopen it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #714: fix: ignore delete pod cache error msg
tao12345666333 merged pull request #714: URL: https://github.com/apache/apisix-ingress-controller/pull/714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated (fa27b03 -> 97fdc90)
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from fa27b03 chore: fix spelling error in modules.png (#717) add 97fdc90 fix: ignore delete pod cache error msg (#714) No new revisions were added by this update. Summary of changes: pkg/types/pod.go | 2 +- pkg/types/pod_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #717: fix spelling error in modules.png
tao12345666333 merged pull request #717: URL: https://github.com/apache/apisix-ingress-controller/pull/717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated (68125e3 -> fa27b03)
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from 68125e3 chore: v1.3 release (#716) add fa27b03 chore: fix spelling error in modules.png (#717) No new revisions were added by this update. Summary of changes: docs/assets/images/modules.png | Bin 13292 -> 6461 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #718: request help: is Apisix-ingress-controller able to integrate with the Apisix-dashboard
tao12345666333 commented on issue #718: URL: https://github.com/apache/apisix-ingress-controller/issues/718#issuecomment-947338709 > Could you pls give more details about deploy ingress controller outside the kubernets cluster? Nothing too special, it is a binary file, you only need to provide it with a configuration file to access the Kubernetes APIServer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] feipengheart commented on issue #2177: request help: 为什么插件编排后只有一个生效
feipengheart commented on issue #2177: URL: https://github.com/apache/apisix-dashboard/issues/2177#issuecomment-947337364 > hi @feipengheart > > Could you please provide the configuration data stored in etcd for the route? How can I find the configuration data stored in etcd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] yunfhu commented on issue #718: request help: is Apisix-ingress-controller able to integrate with the Apisix-dashboard
yunfhu commented on issue #718: URL: https://github.com/apache/apisix-ingress-controller/issues/718#issuecomment-947329615 > * For the first question, the answer is yes, you can also use the apisix-dashboard, but we don't recommend you to edit any resources from it, it can be used as a view board. > * It depends on your demands, you can deploy Apache APISIX Ingress Controller inside the Kubernetes cluster or just outside it. Could you pls give more details about deploy ingress controller outside the kubernets cluster? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2179: fix: login repeat 2 times
bzp2010 commented on a change in pull request #2179:
URL: https://github.com/apache/apisix-dashboard/pull/2179#discussion_r732415948
##
File path: web/src/pages/User/Login.tsx
##
@@ -57,8 +57,16 @@ const Page: React.FC = () => {
description: response.message,
duration: 1,
onClose: () => {
-const redirect = getUrlQuery('redirect');
-history.replace(redirect ? decodeURIComponent(redirect) : '/');
+let redirect = getUrlQuery('redirect');
+if (redirect) {
+ redirect = decodeURIComponent(redirect);
+ if (redirect === '/user/logout') {
Review comment:
@liuxiran I failed to stably reproduce this problem and failed to find
out the reason why `/user/logout` became a callback address. However, the
current patch can alleviate this problem without affecting other scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2178: feat: add gzip middleware
codecov-commenter edited a comment on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e97124) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **increase** coverage by `2.84%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2178 +/- ## == + Coverage 62.70% 65.54% +2.84% == Files 62 189 +127 Lines3928 7276+3348 Branches0 823 +823 == + Hits 2463 4769+2306 - Misses 1178 2217+1039 - Partials 287 290 +3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.22% <100.00%> (+0.62%)` | :arrow_up: | | backend-unit-test | `50.39% <ø> (ø)` | | | frontend-e2e-test | `68.18% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.17% <100.00%> (+0.33%)` | :arrow_up: | | [.../components/passive-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9IZWFsdGh5L0h0dHBTdGF0dXNlcy50c3g=) | `8.33% <0.00%> (ø)` | | | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `98.73% <0.00%> (ø)` | | | [web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=) | `100.00% <0.00%> (ø)` | | | [...pages/Route/components/CreateStep4/CreateStep4.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0NyZWF0ZVN0ZXA0L0NyZWF0ZVN0ZXA0LnRzeA==) | `90.90% <0.00%> (ø)` | | | [...rc/components/Upstream/components/UpstreamType.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVXBzdHJlYW1UeXBlLnRzeA==) | `100.00% <0.00%> (ø)` | | | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_so
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2179: fix: login repeat 2 times
codecov-commenter commented on pull request #2179: URL: https://github.com/apache/apisix-dashboard/pull/2179#issuecomment-947327011 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2179?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2179](https://codecov.io/gh/apache/apisix-dashboard/pull/2179?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89e55dc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0fc4be7d05e1eed66877a900c0acef7d7b46201d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fc4be7) will **decrease** coverage by `0.10%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2179 +/- ## == - Coverage 68.24% 68.13% -0.11% == Files 127 127 Lines3347 3352 +5 Branches 823 824 +1 == Hits 2284 2284 - Misses 1063 1068 +5 ``` | Flag | Coverage Δ | | |---|---|---| | frontend-e2e-test | `68.13% <0.00%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2179/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | `60.00% <0.00%> (-12.00%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2179?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2179?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0fc4be7...89e55dc](https://codecov.io/gh/apache/apisix-dashboard/pull/2179?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2179: fix: login repeat 2 times
liuxiran commented on a change in pull request #2179:
URL: https://github.com/apache/apisix-dashboard/pull/2179#discussion_r732410376
##
File path: web/src/pages/User/Login.tsx
##
@@ -57,8 +57,16 @@ const Page: React.FC = () => {
description: response.message,
duration: 1,
onClose: () => {
-const redirect = getUrlQuery('redirect');
-history.replace(redirect ? decodeURIComponent(redirect) : '/');
+let redirect = getUrlQuery('redirect');
+if (redirect) {
+ redirect = decodeURIComponent(redirect);
+ if (redirect === '/user/logout') {
Review comment:
may I ask when will the redirect === '/user/logout' @bzp2010 , can we
avoid this situation? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2178: feat: add gzip middleware
codecov-commenter edited a comment on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e97124) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **increase** coverage by `0.59%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2178 +/- ## == + Coverage 62.70% 63.29% +0.59% == Files 62 62 Lines3928 3929 +1 == + Hits 2463 2487 +24 + Misses 1178 1152 -26 - Partials 287 290 +3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.22% <100.00%> (+0.62%)` | :arrow_up: | | backend-unit-test | `50.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.17% <100.00%> (+0.33%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.45% <0.00%> (+1.56%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.24% <0.00%> (+2.36%)` | :arrow_up: | | [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | `80.00% <0.00%> (+11.11%)` | :arrow_up: | | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `55.73% <0.00%> (+16.39%)` | :arrow_up: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `66.66% <0.00%> (+33.33%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=c
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2178: feat: add gzip middleware
codecov-commenter commented on pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178#issuecomment-947319121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2178](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e97124) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9f17637090627e971d244be33c72629f6dd051a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f17637) will **decrease** coverage by `12.31%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2178 +/- ## === - Coverage 62.70% 50.39% -12.32% === Files 62 40 -22 Lines3928 3072 -856 === - Hits 2463 1548 -915 - Misses 1178 1330 +152 + Partials 287 194 -93 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-unit-test | `50.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-68.19%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-60.00%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/
[GitHub] [apisix-dashboard] bzp2010 opened a new pull request #2179: fix: login repeat 2 times
bzp2010 opened a new pull request #2179: URL: https://github.com/apache/apisix-dashboard/pull/2179 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Fix login repeat 2 times bug. **Related issues** fix #2174 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] mangoGoForward commented on pull request #5016: feat: xml-json-conversion plugin convert xml data from request body to json response, and vice versa
mangoGoForward commented on pull request #5016: URL: https://github.com/apache/apisix/pull/5016#issuecomment-947305115 > I am curious about the use case of this plugin. If it is just converting XML to JSON online, and echoing it back, why should we add it as a feature of API gateway? Maybe we should pass the converted body to the upstream, which could be useful. I think so at now, thanks for your suggestion. @spacewander @arthur-zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-6443 opened a new pull request #2178: feat: add gzip middleware
nic-6443 opened a new pull request #2178: URL: https://github.com/apache/apisix-dashboard/pull/2178 Add gzip middleware to optimize user experience in a weak network environment. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ] Backport patches **Related issues** fix/resolve #2165 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #5288: feat: initial wasm support
spacewander opened a new pull request #5288: URL: https://github.com/apache/apisix/pull/5288 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5248: refactor: unify code style in Makefile
spacewander commented on a change in pull request #5248: URL: https://github.com/apache/apisix/pull/5248#discussion_r732391791 ## File path: Makefile ## @@ -33,55 +33,48 @@ ENV_OS_NAME?= $(shell uname -s | tr '[:upper:]' '[:lower:]') ENV_OS_ARCH?= $(shell uname -m | tr '[:upper:]' '[:lower:]') ENV_APISIX ?= $(CURDIR)/bin/apisix ENV_GIT?= git +ENV_TAR?= tar +ENV_INSTALL?= install ENV_DOCKER ?= docker ENV_DOCKER_COMPOSE ?= docker-compose --project-directory $(CURDIR) -p $(project_name) -f $(project_compose_ci) -ENV_NGINX ?= nginx -p $(CURDIR) -c $(CURDIR)/conf/nginx.conf - - -# OSX archive `._` cache file -ifeq ($(ENV_OS_NAME), darwin) - ENV_TAR ?= COPYFILE_DISABLE=1 tar -else - ENV_TAR ?= tar +ENV_NGINX ?= $(ENV_NGINX_EXEC) -p $(CURDIR) -c $(CURDIR)/conf/nginx.conf +ENV_NGINX_EXEC ?= $(shell which openresty 2>/dev/null || which nginx 2>/dev/null) Review comment: Can we cache the output? It is unacceptable to call `which openresty` each time we refer it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] arthur-zhang commented on pull request #5016: feat: xml-json-conversion plugin convert xml data from request body to json response, and vice versa
arthur-zhang commented on pull request #5016: URL: https://github.com/apache/apisix/pull/5016#issuecomment-947296950 > I am curious about the use case of this plugin. If it is just converting XML to JSON online, and echoing it back, why should we add it as a feature of API gateway? Maybe we should pass the converted body to the upstream, which could be useful. agree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5016: feat: xml-json-conversion plugin convert xml data from request body to json response, and vice versa
spacewander commented on pull request #5016: URL: https://github.com/apache/apisix/pull/5016#issuecomment-947296603 I am curious about the use case of this plugin. If it is just converting XML to JSON online, and echoing it back, why should we add it as a feature of API gateway? Maybe we should pass the converted body to the upstream, which could be useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5016: feat: xml-json-conversion plugin convert xml data from request body to json response, and vice versa
spacewander commented on a change in pull request #5016:
URL: https://github.com/apache/apisix/pull/5016#discussion_r732391129
##
File path: t/plugin/xml-json-conversion.t
##
@@ -0,0 +1,206 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+no_shuffle();
+log_level('info');
+run_tests;
+
+__DATA__
+
+=== TEST 1: sanity
+--- config
+location /t {
+content_by_lua_block {
+local plugin = require("apisix.plugins.xml-json-conversion")
+local conf = {from = "xml", to = "json"}
+
+local ok, err = plugin.check_schema(conf)
+if not ok then
+ngx.say(err)
+end
+
+ngx.say("done")
+}
+}
+--- request
+GET /t
+--- response_body
+done
+--- no_error_log
Review comment:
We can check no_error_log by default like:
https://github.com/apache/apisix/blob/b5d72cbf1315f1efc80689246a7dcf124c9e6443/t/plugin/gzip.t#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #2177: request help: 为什么插件编排后只有一个生效
nic-chen commented on issue #2177: URL: https://github.com/apache/apisix-dashboard/issues/2177#issuecomment-947289179 hi @feipengheart Could you please provide the configuration data stored in etcd for the route? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5016: feat: xml-json-conversion plugin convert xml data from request body to json response, and vice versa
spacewander commented on a change in pull request #5016:
URL: https://github.com/apache/apisix/pull/5016#discussion_r732386842
##
File path: apisix/plugins/xml-json-conversion.lua
##
@@ -0,0 +1,149 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local handler = require("xmlhandler.tree")
+local string = require("string")
+local parser = require("xml2lua").parser
+local table_to_xml = require("xml2lua").toXml
+local json_decode = require('cjson.safe').decode
Review comment:
Better to use core.json
##
File path: apisix/plugins/xml-json-conversion.lua
##
@@ -0,0 +1,149 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local handler = require("xmlhandler.tree")
+local string = require("string")
+local parser = require("xml2lua").parser
+local table_to_xml = require("xml2lua").toXml
+local json_decode = require('cjson.safe').decode
+local json_encode = require('cjson.safe').encode
+
+
+local schema = {
+type = "object",
+properties = {
+from = {
+type = "string",
+enum = {"json", "xml"},
+default = "xml"
+},
+to = {
+type = "string",
+enum = {"json", "xml"},
+default = "json"
+}
+},
+additionalProperties = false,
+}
+
+local plugin_name = "xml-json-conversion"
+
+local _M = {
+version = 0.1,
+priority = 9,
+name = plugin_name,
+schema = schema,
+}
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+local function xml2json(xml_data)
+local convert_handler = handler:new()
+local parser_handler = parser(convert_handler)
+parser_handler:parse(xml_data)
+return 200, json_encode(convert_handler.root)
+end
+
+local function json2xml(table_data)
+local xmlStr = table_to_xml(json_decode(table_data))
+xmlStr = string.gsub(xmlStr, "%s+", "")
Review comment:
Could we use `re.gsub`?
##
File path: conf/config-default.yaml
##
@@ -347,6 +347,7 @@ plugins: # plugin list (sorted by
priority)
#- log-rotate# priority: 100
# <- recommend to use priority (0, 100) for your custom plugins
- example-plugin # priority: 0
+ - xml-json-conversion# priority: 9
Review comment:
Why "priority: 9" is after "priority: 0"? And we should avoid '(0, 100)'
for builtin plugins
##
File path: apisix/plugins/xml-json-conversion.lua
##
@@ -0,0 +1,149 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= requ
[GitHub] [apisix] wadeLouis closed issue #5283: request help: request websocket get 504 error
wadeLouis closed issue #5283: URL: https://github.com/apache/apisix/issues/5283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wadeLouis commented on issue #5283: request help: request websocket get 504 error
wadeLouis commented on issue #5283: URL: https://github.com/apache/apisix/issues/5283#issuecomment-947288838 I retested today. Some progress has been made. The url of my test will not return any information, but because of the response timeout of apisix, apisix returned a timeout of 504. If I have any content returned within this timeout period, the connection will not be disconnected. A long connection is invalid if no data is sent for a period of time, and it will cut off these connections on its own initiative. Thank you for your reply and for tolerating me, a low-level student. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5274: docs: add simplified Chinese translation for plugin authz-casbin
leslie-tsang commented on a change in pull request #5274:
URL: https://github.com/apache/apisix/pull/5274#discussion_r732386197
##
File path: docs/zh/latest/plugins/authz-casbin.md
##
@@ -0,0 +1,249 @@
+---
+title: authz-casbin
+---
+
+
+
+## 目录
+
+- [**简介**](#简介)
+- [**属性**](#属性)
+- [**元数据**](#元数据)
+- [**如何启用**](#如何启用)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+- [**示例**](#示例)
+
+## 简介
+
+`authz-casbin` 是一个基于 [Lua Casbin](https://github.com/casbin/lua-casbin/)
的访问控制插件，该插件支持基于各种访问控制模型的授权场景。
+
+有关如何创建模型和策略的详细文档, 请参阅 [Casbin](https://casbin.org/docs/en/supported-models)。
+
+## 属性
+
+| 名称| 类型 | 必选项| 默认值 | 有效值 | 描述 |
+| --- | -- | --- | --- | - |
---|
+| model_path | string | 必须| | | Casbin 模型配置文件路径 |
+| policy_path | string | 必须| | | Casbin 策略配置文件路径 |
+| model | string | 必须| | | 描述 Casbin 的模型定义|
+| policy | string | 必须| | | 描述 Casbin 的策略定义|
+| username| string | 必须| | | 描述请求中有可以通过访问控制的用户名 |
+
+**注意**: 在插件配置中指定 `model_path`、`policy_path` 和 `username`，或者在插件配置中指定 `model`、
`policy` 和 `username` 来使插件生效。如果你想使用全局的 Casbin 配置，可以先在插件元数据中指定模型和策略，然后插件配置中指定
`username`。通过这种方式可以使所有的路由共享一个配置。
+
+## 元数据
+
+| 名称| 类型 | 必选项 | 默认值 | 有效值 | 描述 |
+| --- | -- | --- | --- | - |
+| model | string | 必须| | | 描述 Casbin 的模型定义 |
+| policy | string | 必须| | | 描述 Casbin 的策略定义 |
+
+## 如何启用
+
+你可以通过使用模型/策略文件路径或直接在路由中配置模型/策略以启用插件。
+
+### 通过配置文件启用
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"authz-casbin": {
+"model_path": "/path/to/model.conf",
+"policy_path": "/path/to/policy.csv",
+"username": "user"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}'
+```
+
+这将在你第一次请求时从模型/策略文件路径中创建一个 Casbin enforcer。
+
+### 通过路由配置启用
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"authz-casbin": {
+"model": "[request_definition]
+r = sub, obj, act
+
+[policy_definition]
+p = sub, obj, act
+
+[role_definition]
+g = _, _
+
+[policy_effect]
+e = some(where (p.eft == allow))
+
+[matchers]
+m = (g(r.sub, p.sub) || keyMatch(r.sub, p.sub)) && keyMatch(r.obj,
p.obj) && keyMatch(r.act, p.act)",
+
+"policy": "p, *, /, GET
+p, admin, *, *
+g, alice, admin",
+
+"username": "user"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}'
+```
+
+这将在你第一次请求时从模型和策略描述中创建一个 Casbin enforcer。
+
+### 通过 plugin metadata 配置模型/策略
+
+首先，发送一个 `PUT` 请求，使用 Admin API
将模型和策略配置信息添加到插件的元数据中。所有通过这种插件的方式创建的路由都会带有一个带插件元数据配置的 Casbin enforcer。同时也可以使用
`PUT` 请求修改模型和策略配置信息，Apache APISIX 会自动读取最新的配置。
Review comment:
@zaunist Hello there, I'm afraid we need a better translation to avoid
confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] wadeLouis commented on issue #5283: request help: request websocket get 504 error
wadeLouis commented on issue #5283: URL: https://github.com/apache/apisix/issues/5283#issuecomment-947284896 > proxy_http_version 1.1; proxy_set_header Upgrade $http_upgrade; proxy_set_header Connection "Upgrade"; proxy_set_header Host $host; I also test this with nginx native ,it work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wadeLouis commented on issue #5283: request help: request websocket get 504 error
wadeLouis commented on issue #5283:
URL: https://github.com/apache/apisix/issues/5283#issuecomment-947284713
> @wadeLouis your test `curl -vk -H "host: wsocser2.platformcenter.net" -H
"Upgrade: websocket" -H "Sec-WebSocket-Version: 13" -H "Sec-WebSocket-Key:
websocket" -H "Connection: Upgrade"
"http://127.0.0.1/ws?userId=1vbn68fv6923ff0¢reId=1v9r2sk99fc9d99"` not
match your route,
>
> > {
> > "uri": "/esb/*"
> > ..
> > }
>
> you should
use`http://127.0.0.1/esb/ws?userId=1vbn68fv6923ff0¢reId=1v9r2sk99fc9d99` as
request url
This is a copy wrong ,just get what i mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5274: docs: add simplified Chinese translation for plugin authz-casbin
leslie-tsang commented on a change in pull request #5274: URL: https://github.com/apache/apisix/pull/5274#discussion_r732370784 ## File path: docs/zh/latest/plugins/authz-casbin.md ## @@ -0,0 +1,249 @@ +--- +title: authz-casbin +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**元数据**](#元数据) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) +- [**示例**](#示例) + +## 简介 + +`authz-casbin` 是一个基于 [Lua Casbin](https://github.com/casbin/lua-casbin/) 的访问控制插件，该插件支持基于各种访问控制模型的授权场景。 + +有关如何创建模型和策略的详细文档, 请参阅 [Casbin](https://casbin.org/docs/en/supported-models)。 + +## 属性 + +| 名称| 类型 | 必选项| 默认值 | 有效值 | 描述 | +| --- | -- | --- | --- | - | ---| +| model_path | string | 必须| | | Casbin 模型配置文件路径 | +| policy_path | string | 必须| | | Casbin 策略配置文件路径 | +| model | string | 必须| | | 描述 Casbin 的模型定义| +| policy | string | 必须| | | 描述 Casbin 的策略定义| +| username| string | 必须| | | 描述请求中有可以通过访问控制的用户名 | Review comment: Need for better translation of `in text format`. ## File path: docs/zh/latest/plugins/authz-casbin.md ## @@ -0,0 +1,249 @@ +--- +title: authz-casbin +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**元数据**](#元数据) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) +- [**示例**](#示例) + +## 简介 + +`authz-casbin` 是一个基于 [Lua Casbin](https://github.com/casbin/lua-casbin/) 的访问控制插件，该插件支持基于各种访问控制模型的授权场景。 + +有关如何创建模型和策略的详细文档, 请参阅 [Casbin](https://casbin.org/docs/en/supported-models)。 + +## 属性 + +| 名称| 类型 | 必选项| 默认值 | 有效值 | 描述 | +| --- | -- | --- | --- | - | ---| +| model_path | string | 必须| | | Casbin 模型配置文件路径 | +| policy_path | string | 必须| | | Casbin 策略配置文件路径 | +| model | string | 必须| | | 描述 Casbin 的模型定义| +| policy | string | 必须| | | 描述 Casbin 的策略定义| +| username| string | 必须| | | 描述请求中有可以通过访问控制的用户名 | + +**注意**: 在插件配置中指定 `model_path`、`policy_path` 和 `username`，或者在插件配置中指定 `model`、 `policy` 和 `username` 来使插件生效。如果你想使用全局的 Casbin 配置，可以先在插件元数据中指定模型和策略，然后插件配置中指定 `username`。通过这种方式可以使所有的路由共享一个配置。 + +## 元数据 + +| 名称| 类型 | 必选项 | 默认值 | 有效值 | 描述 | +| --- | -- | --- | --- | - | +| model | string | 必须| | | 描述 Casbin 的模型定义 | +| policy | string | 必须| | | 描述 Casbin 的策略定义 | Review comment: ```suggestion | 名称| 类型 | 必选项 | 默认值 | 有效值 | 描述 | | --- | -- | -- | --- | - | ---| | model | string | 必须| | | 描述 Casbin 的模型定义 | | policy | string | 必须| | | 描述 Casbin 的策略定义 | ``` Markdown syntax errors. ## File path: docs/zh/latest/plugins/authz-casbin.md ## @@ -0,0 +1,249 @@ +--- +title: authz-casbin +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**元数据**](#元数据) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) +- [**示例**](#示例) + +## 简介 + +`authz-casbin` 是一个基于 [Lua Casbin](https://github.com/casbin/lua-casbin/) 的访问控制插件，该插件支持基于各种访问控制模型的授权场景。 + +有关如何创建模型和策略的详细文档, 请参阅 [Casbin](https://casbin.org/docs/en/supported-models)。 + +## 属性 + +| 名称| 类型 | 必选项| 默认值 | 有效值 | 描述 | +| --- | -- | --- | --- | - | ---| +| model_path | string | 必须| | | Casbin 模型配置文件路径 | +| policy_path | string | 必须| | | Casbin 策略配置文件路径 | +| model | string | 必须| | | 描述 Casbin 的模型定义| +| policy | string | 必须| | | 描述 Casbin 的策略定义| +| username| string | 必须| | | 描述请求中有可以通过访问控制的用户名 | + +**注意**: 在插件配置中指定 `model_path`、`policy_path` 和 `username`，或者在插件配置中指定 `model`、 `policy` 和 `username` 来使插件生效。如果你想使用全局的 Casbin 配置，可以先在插件元数据中指定模型和策略，然后插件配置中指定 `username`。通过这种方式可以使所有的路由共享一个配置。 + +## 元数据 + +| 名称| 类型 | 必选项 | 默认值 | 有效值 | 描述 | +| --- | -- | --- | --- | - | +| model | string | 必须| | | 描述 Casbin 的模型定义 | +| policy | string | 必须| | | 描述 Casbin 的策略定义 | + +## 如何启用 + +你可以通过使用模型/策略文件路径或直接在路由中配置模型/策略以启用插件。 Review comment: ```suggestion 你可以通过使用模型/策略文件路径或直接在任意路由中配置模型/策略描述以启用该插件。 ``` ## File path: docs/zh/latest/plugins/authz-casbin.md ## @@ -0,0 +1,249 @@ +--- +title: authz-casbin +--- + + + +## 目录 + +- [**简介**](#简介) +-
[GitHub] [apisix] spacewander closed issue #5249: request help: redirect plugin can't not work with other plugin?
spacewander closed issue #5249: URL: https://github.com/apache/apisix/issues/5249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5249: request help: redirect plugin can't not work with other plugin?
spacewander commented on issue #5249: URL: https://github.com/apache/apisix/issues/5249#issuecomment-947283337 Closed as lack of response. Feel free to reopen it if need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] feipengheart opened a new issue #2177: request help: 为什么插件编排后只有一个生效
feipengheart opened a new issue #2177: URL: https://github.com/apache/apisix-dashboard/issues/2177 ### Issue description 编排篇日志如下  为什么只有hmac-auth生效了，jwt-auth没生效呢 一直都是最后一个生效 ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3586: docs: fix MD045 - Images should have alternate text (alt text)
spacewander closed issue #3586: URL: https://github.com/apache/apisix/issues/3586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5280: docs: enabling MD045 - images with alternate text
spacewander merged pull request #5280: URL: https://github.com/apache/apisix/pull/5280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: enabling MD045 - images with alternate text (#5280)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 1b96444 docs: enabling MD045 - images with alternate text (#5280)
1b96444 is described below
commit 1b964443c81ab80bd839cc1119e2257deb24c8a1
Author: Bisakh
AuthorDate: Wed Oct 20 08:39:48 2021 +0530
docs: enabling MD045 - images with alternate text (#5280)
---
.markdownlint.yml | 1 -
docs/en/latest/aws.md | 10 +-
docs/en/latest/discovery.md| 2 +-
docs/en/latest/discovery/consul_kv.md | 2 +-
docs/en/latest/plugins/hmac-auth.md| 6 --
docs/en/latest/plugins/jwt-auth.md | 9 ++---
docs/en/latest/plugins/key-auth.md | 4 ++--
docs/en/latest/plugins/limit-conn.md | 2 +-
docs/en/latest/plugins/prometheus.md | 16
docs/en/latest/plugins/response-rewrite.md | 2 +-
docs/en/latest/plugins/sls-logger.md | 2 +-
docs/en/latest/plugins/wolf-rbac.md| 4 ++--
docs/en/latest/plugins/zipkin.md | 7 ---
docs/zh/latest/README.md | 4 ++--
docs/zh/latest/discovery.md| 24
docs/zh/latest/plugins/jwt-auth.md | 7 ---
docs/zh/latest/plugins/key-auth.md | 4 ++--
docs/zh/latest/plugins/limit-conn.md | 2 +-
docs/zh/latest/plugins/prometheus.md | 16
docs/zh/latest/plugins/response-rewrite.md | 2 +-
docs/zh/latest/plugins/sls-logger.md | 2 +-
docs/zh/latest/plugins/wolf-rbac.md| 4 ++--
docs/zh/latest/plugins/zipkin.md | 6 +++---
23 files changed, 72 insertions(+), 66 deletions(-)
diff --git a/.markdownlint.yml b/.markdownlint.yml
index 3836e57..36d2485 100644
--- a/.markdownlint.yml
+++ b/.markdownlint.yml
@@ -31,5 +31,4 @@ MD034: false
MD036: false
MD040: false
MD041: false
-MD045: false
MD046: false
diff --git a/docs/en/latest/aws.md b/docs/en/latest/aws.md
index 07a0e7d..ce9636c 100644
--- a/docs/en/latest/aws.md
+++ b/docs/en/latest/aws.md
@@ -27,7 +27,7 @@ title: Running APISIX in AWS with AWS CDK
This reference architecture walks you through building **APISIX** as a
serverless container API Gateway on top of AWS Fargate with AWS CDK.
-
+
## Generate an AWS CDK project with `projen`
@@ -208,15 +208,15 @@ Address: 44.226.102.63
Configure the IP addresses returned as your upstream nodes in your **APISIX**
dashboard followed by the **Services** and **Routes** configuration. Let's say
we have a `/index.php` as the URI for the first route for our first **Service**
from the **Upstream** IP addresses.
-
-
-
+
+
+
## Validation
OK. Let's test the `/index.php` on `{apiSix.ApiSixServiceServiceURL}/index.php`
-
+
Now we have been successfully running **APISIX** in AWS Fargate as serverless
container API Gateway service.
diff --git a/docs/en/latest/discovery.md b/docs/en/latest/discovery.md
index 6565178..89f7ef1 100644
--- a/docs/en/latest/discovery.md
+++ b/docs/en/latest/discovery.md
@@ -25,7 +25,7 @@ title: Integration service discovery registry
When system traffic changes, the number of servers of the upstream service
also increases or decreases, or the server needs to be replaced due to its
hardware failure. If the gateway maintains upstream service information through
configuration, the maintenance costs in the microservices architecture pattern
are unpredictable. Furthermore, due to the untimely update of these
information, will also bring a certain impact for the business, and the impact
of human error operation can not be [...]
-
+
1. When the service starts, it will report some of its information, such as
the service name, IP, port and other information to the registry. The services
communicate with the registry using a mechanism such as a heartbeat, and if the
registry and the service are unable to communicate for a long time, the
instance will be cancel.When the service goes offline, the registry will delete
the instance information.
2. The gateway get
[GitHub] [apisix] spacewander commented on a change in pull request #5028: feat(proxy-cache): support memory-based strategy
spacewander commented on a change in pull request #5028:
URL: https://github.com/apache/apisix/pull/5028#discussion_r732382937
##
File path: apisix/cli/ngx_tpl.lua
##
@@ -209,16 +209,22 @@ http {
{% if enabled_plugins["proxy-cache"] then %}
# for proxy cache
{% for _, cache in ipairs(proxy_cache.zones) do %}
+{% if cache.disk_path and cache.cache_levels and cache.disk_size then %}
Review comment:
We can check the cache attributes with schema, like:
https://github.com/apache/apisix/blob/b5d72cbf1315f1efc80689246a7dcf124c9e6443/apisix/cli/ops.lua#L154
##
File path: t/plugin/proxy-cache-memory.t
##
@@ -0,0 +1,733 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+BEGIN {
+$ENV{TEST_NGINX_FORCE_RESTART_ON_TEST} = 0;
+}
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_shuffle();
+no_root_location();
+log_level('info');
+
+
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+my $http_config = $block->http_config // <<_EOC_;
+
+# for proxy cache
+proxy_cache_path /tmp/disk_cache_one levels=1:2
keys_zone=disk_cache_one:50m inactive=1d max_size=1G;
+proxy_cache_path /tmp/disk_cache_two levels=1:2
keys_zone=disk_cache_two:50m inactive=1d max_size=1G;
+lua_shared_dict memory_cache 50m;
+
+# for proxy cache
+map \$upstream_cache_zone \$upstream_cache_zone_info {
+disk_cache_one /tmp/disk_cache_one,1:2;
+disk_cache_two /tmp/disk_cache_two,1:2;
+}
+
+server {
+listen 1986;
+server_tokens off;
+
+location / {
+expires 60s;
+
+if (\$arg_expires) {
+expires \$arg_expires;
+}
+
+if (\$arg_cc) {
+expires off;
+add_header Cache-Control \$arg_cc;
+}
+
+return 200 "hello world!";
+}
+
+location /hello-not-found {
+return 404;
+}
+}
+_EOC_
+
+$block->set_value("http_config", $http_config);
+});
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: sanity check (invalid cache strategy)
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[[{
+"plugins": {
+"proxy-cache": {
+ "cache_strategy": "network",
+ "cache_key":["$host","$uri"],
+ "cache_zone": "disk_cache_one",
+ "cache_bypass": ["$arg_bypass"],
+ "cache_method": ["GET"],
+ "cache_http_status": [200],
+ "hide_cache_headers": true,
+ "no_cache": ["$arg_no_cache"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1986": 1
+},
+"type": "roundrobin"
+},
+"uri": "/hello*"
+ }]]
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- error_code: 400
+--- response_body eval
+qr/failed to check the configuration of plugin proxy-cache err: property
\\"cache_strategy\\" validation failed: matches none of the enum values/
+--- no_error_log
Review comment:
We can check no_error_log by default like:
https://github.com/apache/apisix/blob/b5d72cbf1315f1efc80689246a7dcf124c9e6443/t/plugin/gzip.t#L40
##
File path: t/plugin/proxy-cache-memory.t
##
@@ -0,0 +1,733 @@
+#
Review comment:
Let's rename this test file to t/plugin/proxy-cache/memory.t. The origin
t/plugin/proxy-cache.t can be renamed to t/plugin/proxy-cache/disk.t
##
File path: apisix/plugins/proxy-cache/memory.lua
##
@@ -0,0 +1,70 @@
+--
+-- Licensed
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2104: feat: supports stream route API
nic-chen commented on a change in pull request #2104:
URL: https://github.com/apache/apisix-dashboard/pull/2104#discussion_r732380280
##
File path: api/test/e2enew/base/base.go
##
@@ -81,6 +82,19 @@ func APISIXExpect() *httpexpect.Expect {
return httpexpect.New(t, APISIXHost)
}
+func APISIXStreamProxyExpect(port uint16, isHTTPS bool) *httpexpect.Expect {
+ if port == 0 {
+ port = 10090
+ }
+ t := getTestingHandle()
+
+ if isHTTPS {
+ return httpexpect.New(t, "https://"; +
net.JoinHostPort("127.0.0.1", strconv.Itoa(int(port
+ } else {
+ return httpexpect.New(t, "http://"; +
net.JoinHostPort("127.0.0.1", strconv.Itoa(int(port
+ }
+}
Review comment:
I think we should add a TCP test case, make sure it works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] feipengheart opened a new issue #5287: request help: 为什么插件编排后只有一个生效
feipengheart opened a new issue #5287: URL: https://github.com/apache/apisix/issues/5287 ### Issue description 编排篇日志如下  为什么只有hmac-auth生效了，jwt-auth没生效呢 一直都是最后一个生效 ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5280: docs: enabling MD045 - images with alternate text
bisakhmondal commented on a change in pull request #5280: URL: https://github.com/apache/apisix/pull/5280#discussion_r732369754 ## File path: docs/en/latest/plugins/jwt-auth.md ## @@ -111,14 +114,14 @@ You can use [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to co 1. Add a Consumer through the web console: - + then add jwt-auth plugin in the Consumer page: - + 2. Create a Route or Service object and enable the jwt-auth plugin: - + Review comment: fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #158: chore: apisix-ingress-controller v1.3 released
tao12345666333 commented on a change in pull request #158: URL: https://github.com/apache/apisix-helm-chart/pull/158#discussion_r732367225 ## File path: .github/workflows/ci.yaml ## @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: -k8s: [v1.14.10, v1.15.12, v1.16.15, v1.17.17, v1.18.19, v1.19.11, v1.20.7, v1.21.1] +k8s: [v1.16.15, v1.17.17, v1.18.19, v1.19.11, v1.20.7, v1.21.1] Review comment: Good catch! Addressed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rogerwangzy commented on issue #5283: request help: request websocket get 504 error
rogerwangzy commented on issue #5283: URL: https://github.com/apache/apisix/issues/5283#issuecomment-947256471 proxy_http_version 1.1; proxy_set_header Upgrade $http_upgrade; proxy_set_header Connection "Upgrade"; proxy_set_header Host $host; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5274: docs: add simplified Chinese translation for plugin authz-casbin
spacewander commented on pull request #5274: URL: https://github.com/apache/apisix/pull/5274#issuecomment-947244472 @leslie-tsang Please have a look 😃 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #158: chore: apisix-ingress-controller v1.3 released
tokers commented on a change in pull request #158: URL: https://github.com/apache/apisix-helm-chart/pull/158#discussion_r732358136 ## File path: .github/workflows/ci.yaml ## @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: -k8s: [v1.14.10, v1.15.12, v1.16.15, v1.17.17, v1.18.19, v1.19.11, v1.20.7, v1.21.1] +k8s: [v1.16.15, v1.17.17, v1.18.19, v1.19.11, v1.20.7, v1.21.1] Review comment: Ignore the `v1.22.x`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #718: request help: is Apisix-ingress-controller able to integrate with the Apisix-dashboard
tokers commented on issue #718: URL: https://github.com/apache/apisix-ingress-controller/issues/718#issuecomment-947239250 1. For the first question, the answer is yes, you can also use the apisix-dashboard, but we don't recommend you to edit any resources from it, it can be used as a view board. 2. It depends on your demands, you can deploy Apache APISIX Ingress Controller inside the Kubernetes cluster or just outside it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5283: request help: request websocket get 504 error
tokers commented on issue #5283: URL: https://github.com/apache/apisix/issues/5283#issuecomment-947237334 > [root@iZuf64g8pjwxoltlhga88cZ example]# curl -vk -H "host: wsocser2.platformcenter.net" -H "Upgrade: websocket" -H "Sec-WebSocket-Version: 13" -H "Sec-WebSocket-Key: websocket" -H "Connection: Upgrade" "http://192.168.3.65:12345/ws?userId=1vbn68fv6923ff0¢reId=1v9r2sk99fc9d99"; * About to connect() to 192.168.3.65 port 12345 (#0) * Trying 192.168.3.65... * Connected to 192.168.3.65 (192.168.3.65) port 12345 (#0) > GET /ws?userId=1vbn68fv6923ff0¢reId=1v9r2sk99fc9d99 HTTP/1.1 > User-Agent: curl/7.29.0 > Accept: */* > host: wsocser2.platformcenter.net > Upgrade: websocket > Sec-WebSocket-Version: 13 > Sec-WebSocket-Key: websocket > Connection: Upgrade > # This will no response and connect keepalive forever without 504 error. Why does the `101 Switching Protocols` response not send from your backend? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran merged pull request #2168: fix: select Use the domain or IP from Node List
liuxiran merged pull request #2168: URL: https://github.com/apache/apisix-dashboard/pull/2168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran closed issue #2155: bug: apisix-dashboard unable to set `upstream.pass_host` as `node` when node more than 1
liuxiran closed issue #2155: URL: https://github.com/apache/apisix-dashboard/issues/2155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (9f17637 -> 0fc4be7)
This is an automated email from the ASF dual-hosted git repository. liuxiran pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 9f17637 feat: support proto API (#2099) add 0fc4be7 fix: select Use the domain or IP from Node List (#2168) No new revisions were added by this update. Summary of changes: .../upstream/create_and_delete_upstream.spec.js| 32 ++ .../components/Upstream/components/PassHost.tsx| 2 +- 2 files changed, 33 insertions(+), 1 deletion(-)
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5280: docs: enabling MD045 - images with alternate text
bisakhmondal commented on a change in pull request #5280: URL: https://github.com/apache/apisix/pull/5280#discussion_r732350746 ## File path: docs/en/latest/plugins/jwt-auth.md ## @@ -111,14 +114,14 @@ You can use [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to co 1. Add a Consumer through the web console: - + then add jwt-auth plugin in the Consumer page: - + 2. Create a Route or Service object and enable the jwt-auth plugin: - + Review comment: Hi! As these were just alternate texts and only going to be rendered if the URL is broken, I guess I didn't put much notice on the consistency of the texts that I was writing😅. Let me update it then. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-6443 edited a comment on pull request #2171: Adjust the read and write timeout configuration of the http server
nic-6443 edited a comment on pull request #2171: URL: https://github.com/apache/apisix-dashboard/pull/2171#issuecomment-947229168 > @nic-6443 Would you like to try using gin `gzip` middleware to solve the problem? If you don't have time to do it, I'll try to fix it. I can do it, do I need a new pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-6443 commented on pull request #2171: Adjust the read and write timeout configuration of the http server
nic-6443 commented on pull request #2171: URL: https://github.com/apache/apisix-dashboard/pull/2171#issuecomment-947229168 > @nic-6443 Would you like to try using gin `gzip` middleware to solve the problem? If you don't have time to do it, I'll try to fix it. I can do it, do I need a new pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2171: Adjust the read and write timeout configuration of the http server
bzp2010 commented on pull request #2171: URL: https://github.com/apache/apisix-dashboard/pull/2171#issuecomment-947228613 @nic-6443 Would you like to try using gin `gzip` middleware to solve the problem? If you don't have time to do it, I'll try to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-6443 edited a comment on issue #5283: request help: request websocket get 504 error
nic-6443 edited a comment on issue #5283:
URL: https://github.com/apache/apisix/issues/5283#issuecomment-946826528
@wadeLouis
your test `curl -vk -H "host: wsocser2.platformcenter.net" -H "Upgrade:
websocket" -H "Sec-WebSocket-Version: 13" -H "Sec-WebSocket-Key: websocket" -H
"Connection: Upgrade"
"http://127.0.0.1/ws?userId=1vbn68fv6923ff0¢reId=1v9r2sk99fc9d99"` not
match your route,
> {
"uri": "/esb/*"
..
}
you should
use`http://127.0.0.1/esb/ws?userId=1vbn68fv6923ff0¢reId=1v9r2sk99fc9d99` as
request url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2174: bug: apisix dashoard 2.9版本需要重复登录才能进入UI界面
zaunist commented on issue #2174: URL: https://github.com/apache/apisix-dashboard/issues/2174#issuecomment-947221887 > * [bug: apisix dashoard 2.9版本需要重复登录才能进入UI界面 #2174 (comment)](https://github.com/apache/apisix-dashboard/issues/2174#issue-1025939093) > * [bug: apisix dashoard 2.9版本需要重复登录才能进入UI界面 #2174 (comment)](https://github.com/apache/apisix-dashboard/issues/2174#issuecomment-943329232) > > so these two comments are different issues? @zaunist I think it's the same problem, both need to call the login interface twice to log in successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5271: feat(control): expose services
spacewander merged pull request #5271: URL: https://github.com/apache/apisix/pull/5271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5284: chore: remove unused ASFLicenseHeaderMarkdown
spacewander merged pull request #5284: URL: https://github.com/apache/apisix/pull/5284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (e68e03f -> b5d72cb)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from e68e03f feat(control): expose services(#5271) add b5d72cb chore: remove unused ASFLicenseHeaderMarkdown (#5284) No new revisions were added by this update. Summary of changes: ci/ASFLicenseHeaderMarkdown.txt | 18 -- 1 file changed, 18 deletions(-) delete mode 100644 ci/ASFLicenseHeaderMarkdown.txt
[apisix] branch master updated (50fed63 -> e68e03f)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 50fed63 feat(control): add dump upstream api (#5259)
add e68e03f feat(control): expose services(#5271)
No new revisions were added by this update.
Summary of changes:
apisix/control/v1.lua | 53 ++-
docs/en/latest/control-api.md | 82 +++
t/control/{routes.t => services.t} | 88 +-
3 files changed, 200 insertions(+), 23 deletions(-)
copy t/control/{routes.t => services.t} (53%)
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5274: docs: add simplified Chinese translation for plugin authz-casbin
juzhiyuan commented on a change in pull request #5274:
URL: https://github.com/apache/apisix/pull/5274#discussion_r732286896
##
File path: docs/zh/latest/plugins/authz-casbin.md
##
@@ -0,0 +1,249 @@
+---
+title: authz-casbin
+---
+
+
+
+## 目录
+
+- [**简介**](#简介)
+- [**属性**](#属性)
+- [**元数据**](#元数据)
+- [**如何启用**](#如何启用)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+- [**示例**](#示例)
+
+## 简介
+
+`authz-casbin` 是一个基于 [Lua Casbin](https://github.com/casbin/lua-casbin/)
的访问控制插件，该插件支持基于各种访问控制模型的授权场景。
+
+有关如何创建模型和策略的详细文档, 请参阅 [Casbin](https://casbin.org/docs/en/supported-models)。
+
+## 属性
+
+| 名称| 类型 | 必选项| 默认值 | 有效值 | 描述 |
+| --- | -- | --- | --- | - |
---|
+| model_path | string | 必须| | | Casbin 模型配置文件路径 |
+| policy_path | string | 必须| | | Casbin 策略配置文件路径 |
+| model | string | 必须| | | 描述 Casbin 的模型定义|
+| policy | string | 必须| | | 描述 Casbin 的策略定义|
+| username| string | 必须| | | 描述请求中有可以通过访问控制的用户名 |
+
+**注意**: 在插件配置中指定 `model_path`、`policy_path` 和 `username`，或者在插件配置中指定 `model`、
`policy` 和 `username` 来使插件生效。如果你想使用全局的 Casbin 配置，可以先在插件元数据中指定模型和策略，然后插件配置中指定
`username`。通过这种方式可以使所有的路由共享一个配置。
+
+## 元数据
+
+| 名称| 类型 | 必选项 | 默认值 | 有效值 | 描述 |
+| --- | -- | --- | --- | - |
+| model | string | 必须| | | 描述 Casbin 的模型定义 |
+| policy | string | 必须| | | 描述 Casbin 的策略定义 |
+
+## 如何启用
+
+你可以通过使用模型/策略文件路径或直接在路由中配置模型/策略以启用插件。
+
+### 通过配置文件启用
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"authz-casbin": {
+"model_path": "/path/to/model.conf",
+"policy_path": "/path/to/policy.csv",
+"username": "user"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}'
+```
+
+这将在你第一次请求时从模型/策略文件路径中创建一个 Casbin enforcer。
+
+### 通过路由配置启用
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"authz-casbin": {
+"model": "[request_definition]
+r = sub, obj, act
+
+[policy_definition]
+p = sub, obj, act
+
+[role_definition]
+g = _, _
+
+[policy_effect]
+e = some(where (p.eft == allow))
+
+[matchers]
+m = (g(r.sub, p.sub) || keyMatch(r.sub, p.sub)) && keyMatch(r.obj,
p.obj) && keyMatch(r.act, p.act)",
+
+"policy": "p, *, /, GET
+p, admin, *, *
+g, alice, admin",
+
+"username": "user"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}'
+```
+
+这将在你第一次请求时从模型和策略描述中创建一个 Casbin enforcer。
+
+### 通过 plugin metadata 配置模型/策略
+
+首先，发送一个 `PUT` 请求，使用 Admin API
将模型和策略配置信息添加到插件的元数据中。所有通过这种插件的方式创建的路由都会带有一个带插件元数据配置的 Casbin enforcer。同时也可以使用
`PUT` 请求修改模型和策略配置信息，Apache APISIX 会自动读取最新的配置。
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/plugin_metadata/authz-casbin -H
'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -i -X PUT -d '
+{
+"model": "[request_definition]
+r = sub, obj, act
+
+[policy_definition]
+p = sub, obj, act
+
+[role_definition]
+g = _, _
+
+[policy_effect]
+e = some(where (p.eft == allow))
+
+[matchers]
+m = (g(r.sub, p.sub) || keyMatch(r.sub, p.sub)) && keyMatch(r.obj, p.obj) &&
keyMatch(r.act, p.act)",
+
+"policy": "p, *, /, GET
+p, admin, *, *
+g, alice, admin"
+}'
+```
+
+然后通过发送以下请求将这个插件添加到一个路由上。注意，现在不再需要添加模型/策略的详细描述。
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"plugins": {
+"authz-casbin": {
+"username": "user"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}'
+```
+
+**注意**: 插件路由配置比插件元数据配置有更高的优先权。因此，如果模型/策略配置存在于插件路由配置中，插件将使用它而不是元数据配置。
+
+## 测试插件
+
+我们将定义模型为:
+
+```conf
+[request_definition]
+r = sub, obj, act
+
+[policy_definition]
+p = sub, obj, act
+
+[role_definition]
+g = _, _
+
+[policy_effect]
+e = some(where (p.eft == allow))
+
+[matchers]
+m = (g(r.sub, p.sub) || keyMatch(r.sub, p.sub)) && keyMatch(r.obj, p.obj) &&
keyMatch(r.act, p.act)
+```
+
+并应用该策略:
+
+```conf
+p, *, /, GET
+p, admin, *, *
+g, alice, admin
+```
+
+这意味着任何人都可以使用 `GET` 请求方法访问主页（`/`），而只有具有管理权限的用户可以访问其他页面和使用其他请求方法。
+
+例如，在这里，任何人都可以用GET请求方法访问主页，请求正常进行。
+
+```shell
+curl -i http://127.0.0.1:9080/ -X GET
+```
+
+如果一些未经授权的用户 `bob` 试图访问任何其他页面，他们将得到一个403错
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5280: docs: enabling MD045 - images with alternate text
juzhiyuan commented on a change in pull request #5280:
URL: https://github.com/apache/apisix/pull/5280#discussion_r732285406
##
File path: docs/en/latest/plugins/jwt-auth.md
##
@@ -111,14 +114,14 @@ You can use [APISIX
Dashboard](https://github.com/apache/apisix-dashboard) to co
1. Add a Consumer through the web console:
-
+
then add jwt-auth plugin in the Consumer page:
-
+
2. Create a Route or Service object and enable the jwt-auth plugin:
-
+
Review comment:
May I know why we use `enabling` here, but use `enable` on Line 120?
##
File path: docs/zh/latest/plugins/key-auth.md
##
@@ -67,10 +67,10 @@ curl http://127.0.0.1:9080/apisix/admin/consumers -H
'X-API-KEY: edd1c9f034335f1
```
你也可以通过 web 界面来完成上面的操作，先增加一个 consumer：
-
+
Review comment:
```suggestion
```
##
File path: docs/en/latest/aws.md
##
@@ -208,15 +208,15 @@ Address: 44.226.102.63
Configure the IP addresses returned as your upstream nodes in your **APISIX**
dashboard followed by the **Services** and **Routes** configuration. Let's say
we have a `/index.php` as the URI for the first route for our first **Service**
from the **Upstream** IP addresses.
-
-
-
+
+
+
## Validation
OK. Let's test the `/index.php` on `{apiSix.ApiSixServiceServiceURL}/index.php`
-
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #2174: bug: apisix dashoard 2.9版本需要重复登录才能进入UI界面
juzhiyuan edited a comment on issue #2174: URL: https://github.com/apache/apisix-dashboard/issues/2174#issuecomment-947131081 - https://github.com/apache/apisix-dashboard/issues/2174#issue-1025939093 - https://github.com/apache/apisix-dashboard/issues/2174#issuecomment-943329232 so these two comments are different issues? @zaunist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2174: bug: apisix dashoard 2.9版本需要重复登录才能进入UI界面
juzhiyuan commented on issue #2174: URL: https://github.com/apache/apisix-dashboard/issues/2174#issuecomment-947131081 - https://github.com/apache/apisix-dashboard/issues/2174#issue-1025939093 - https://github.com/apache/apisix-dashboard/issues/2174#issuecomment-943329232 so this two comments are different issues? @zaunist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] RalapZ edited a comment on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
RalapZ edited a comment on issue #5276: URL: https://github.com/apache/apisix/issues/5276#issuecomment-947105418 > can you show the logs in error.log, just like `[lua] balancer.lua:349: run(): proxy request to 127.0.0.1:1980 while connecting to upstream, client: 127.0.0.1, server: localhost, request: "GET /hello HTTP/1.1", host: "127.0.0.1:1984"` >curl myzone.ak.xyz -H "x-ak-request-id:10009" >log info >>2021/10/20 05:05:45 [error] 18332#18332: *39585706 upstream sent no valid HTTP/1.0 header while reading response header from upstream, client: 10.48.8.13, server: _, request: "GET / HTTP/1.1", upstream: "http://10.49.0.248:22/";, host: "myzone.ak.xyz" 2021/10/20 05:05:45 [error] 18332#18332: *39585706 readv() failed (104: Connection reset by peer) while reading upstream, client: 10.48.8.13, server: _, request: "GET / HTTP/1.1", upstream: "http://10.49.0.248:22/";, host: "myzone.ak.xyz" > this error is a new request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] RalapZ commented on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
RalapZ commented on issue #5276: URL: https://github.com/apache/apisix/issues/5276#issuecomment-947105418 > can you show the logs in error.log, just like `[lua] balancer.lua:349: run(): proxy request to 127.0.0.1:1980 while connecting to upstream, client: 127.0.0.1, server: localhost, request: "GET /hello HTTP/1.1", host: "127.0.0.1:1984"` >>2021/10/20 05:05:45 [error] 18332#18332: *39585706 upstream sent no valid HTTP/1.0 header while reading response header from upstream, client: 10.48.8.13, server: _, request: "GET / HTTP/1.1", upstream: "http://10.49.0.248:22/";, host: "myzone.ak.xyz" 2021/10/20 05:05:45 [error] 18332#18332: *39585706 readv() failed (104: Connection reset by peer) while reading upstream, client: 10.48.8.13, server: _, request: "GET / HTTP/1.1", upstream: "http://10.49.0.248:22/";, host: "myzone.ak.xyz" > this error is a new request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #158: chore: apisix-ingress-controller v1.3 released
tao12345666333 opened a new pull request #158: URL: https://github.com/apache/apisix-helm-chart/pull/158 In this commit, I set the served of ApisixRoute v1 version resources to false, which also means that users will not be able to use ApisixRoute v1 resources. Signed-off-by: Jintao Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on issue #3601: test: add test cases for streaming gRPC proxy
bisakhmondal commented on issue #3601: URL: https://github.com/apache/apisix/issues/3601#issuecomment-946890377 After having a discussion with @spacewander, there is something, I'd like to point out here. At present we are testing the gRPC plugin through an upstream server written in Go ([api7/grpc_server_example](https://github.com/api7/grpc_server_example)) and a shell script to test the expected behaviour. But the thing is the CI setup for this is not a good approach for few reasons - First, we are pulling the release candidate binary that runs the server and then again we are cloning the repository to get the proto file. https://github.com/apache/apisix/blob/50fed630823bb3c562f411d7cb5f5d38218348fb/ci/linux_openresty_common_runner.sh#L47-L58 So whenever we want to make any changes in the upstream gRPC example server repo, we have to explicitly release a new binary just for the sake of satisfying this approach which is manual and not at all developer-friendly. ## Proposed Solution One easy solution could be cloning the master branch every time we run the CI, but it could introduce instability in the CIs as maybe at some point of time the master is not fully ready or broken. I think we could leverage the benefits of `git submodules` here by putting the api7/grpc_server_example project into a suitable subdirectory. In this way, we will have explicit control over the state of the submodule on which we are running the tests because the submodule HEAD itself points to a commit hash. And whenever we update the upstream, we just have to move the submodule HEAD to that particular commit hash via a `git pull` or something like that. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #143: feat: add initContainer for apisix-ingress-controller
tao12345666333 commented on a change in pull request #143:
URL: https://github.com/apache/apisix-helm-chart/pull/143#discussion_r732024308
##
File path: charts/apisix-ingress-controller/templates/deployment.yaml
##
@@ -46,6 +46,10 @@ spec:
items:
- key: config.yaml
path: config.yaml
+ initContainers:
+- name: wait-apisix-admin
+ image: {{ .Values.initContainer.image }}:{{.Values.initContainer.tag
}}
+ command: ['sh', '-c', "until nc -z {{
.Values.config.apisix.serviceName }}.{{ .Values.config.apisix.serviceNamespace
}}.svc.{{.Values.clusterDomain}} {{ .Values.config.apisix.servicePort }} ; do
echo waiting for apisix-admin; sleep 2; done;"]
Review comment:
```suggestion
command: ['sh', '-c', "until nc -z {{
.Values.config.apisix.serviceName }}.{{ .Values.config.apisix.serviceNamespace
}}.svc.{{ .Values.clusterDomain }} {{ .Values.config.apisix.servicePort }} ; do
echo waiting for apisix-admin; sleep 2; done;"]
```
##
File path: charts/apisix-ingress-controller/templates/deployment.yaml
##
@@ -46,6 +46,10 @@ spec:
items:
- key: config.yaml
path: config.yaml
+ initContainers:
+- name: wait-apisix-admin
+ image: {{ .Values.initContainer.image }}:{{.Values.initContainer.tag
}}
Review comment:
```suggestion
image: {{ .Values.initContainer.image }}:{{
.Values.initContainer.tag }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
tzssangglass commented on issue #5276: URL: https://github.com/apache/apisix/issues/5276#issuecomment-946849587 can you show the logs in error.log, just like `[lua] balancer.lua:349: run(): proxy request to 127.0.0.1:1980 while connecting to upstream, client: 127.0.0.1, server: localhost, request: "GET /hello HTTP/1.1", host: "127.0.0.1:1984"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5281: request help: jwt-auth sets the public and private keys, and the requested token cannot be used
tzssangglass commented on issue #5281: URL: https://github.com/apache/apisix/issues/5281#issuecomment-946843735 > 即，如果令牌给了其他人，它也可以访问API Yes, JWT is designed to do so. > 我认为私钥由客户端用于令牌加密，然后JwT-Auth可以使用公钥或签名对其进行解密，但事实并非如此。 I don't want to discuss this. JWT generation and validation should be done by the server. > 公钥和私钥似乎没有任何作用。 The private key is stored in the place where the JWT is issued, and the public key is stored in the place where the JWT is verified, so as to effectively prevent the private key from being leaked. > 有没有办法解决这个问题，比如给用户一个私钥，只有拥有私钥的用户才能使用有效的令牌访问API what is the difference between this and username password login. It is actually possible to achieve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-6443 commented on issue #5283: request help: request websocket get 504 error
nic-6443 commented on issue #5283:
URL: https://github.com/apache/apisix/issues/5283#issuecomment-946826528
@wadeLouis
your test `curl -vk -H "host: wsocser2.platformcenter.net" -H "Upgrade:
websocket" -H "Sec-WebSocket-Version: 13" -H "Sec-WebSocket-Key: websocket" -H
"Connection: Upgrade"
"http://127.0.0.1/ws?userId=1vbn68fv6923ff0¢reId=1v9r2sk99fc9d99"` not
match your route,
> {
"uri": "/esb/*"
..
}
you should
use`http://127.0.0.1/esb/ws?userId=1vbn68fv6923ff0¢reId=1v9r2sk99fc9d99`
use request url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] yunfhu opened a new issue #718: request help: is Apisix-ingress-controller able to integrate with the Apisix-dashboard
yunfhu opened a new issue #718: URL: https://github.com/apache/apisix-ingress-controller/issues/718 ### Issue description Actually I have two question about Apisix-ingress-controller.The 1st one is whether is able to integrate with the Apisix-dashboard.Another question is as the kubernets' ingress controller,it is deployed as a thread on the node or deployed as service in the pod ? ### Environment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] RalapZ commented on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
RalapZ commented on issue #5276:
URL: https://github.com/apache/apisix/issues/5276#issuecomment-946792768
> > req_id is key in my logformat; but value is "http_x_ak_request_id"
>
> take a look
at:https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/traffic-split.md#matching-rules-correspond-to-upstream
>
> ```
> "vars": [
> ["http_x-api-id","==","2"]
> ]
> ```
>
> the request header it will match is `x-api-id`
>{
```
"rules": [
{
"match": [
{
"vars": [
[ "http_x-ak-request-id","==","10008" ]
]
}
],
"weighted_upstreams": [
{
"upstream": {
"hash_on": "vars",
"name": "upstream_a",
"nodes": [
{
"host": "10.49.0.248",
"port": 2379,
"weight": 11
},
{
"host": "10.49.1.114",
"port": 2379,
"weight": 11
}
],
"pass_host": "pass",
"scheme": "http",
"type": "roundrobin"
},
"weight": 1
}
]
},
{
"match": [
{
"vars": [
[ "http_x-ak-request-id","==","10009" ]
]
}
],
"weighted_upstreams": [
{
"upstream": {
"hash_on": "vars",
"name": "upstream_B",
"nodes": [
{
"host": "10.49.0.248",
"port": 22,
"weight": 11
},
{
"host": "10.49.1.114",
"port": 22,
"weight": 11
}
],
"pass_host": "pass",
"scheme": "http",
"type": "roundrobin"
},
"weight": 1
}
]
}
]
```
log
>>{"datetime":"19/Oct/2021:22:36:28 +0800","remote_addr":
"10.48.8.13","http_host": "myzone.ak.xyz","upstream_addr":
"10.49.1.114:22","request_method": "GET","http_referer": "-","req_id":
"10008","company_id": "-","zid": "-","status": "009","server_name":
"_","request_uri": "/","http_user_agent": "curl/7.29.0","http_x_forwarded_for":
"-","body_bytes_sent": "0","upstream_response_time": "0.007","request_time":
"0.007"}
>follow you guide,but there is the same result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #5248: refactor: unify code style in Makefile
leslie-tsang commented on pull request #5248: URL: https://github.com/apache/apisix/pull/5248#issuecomment-946787402 > Is this PR still in progress? Yes for sure, working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] feipengheart commented on issue #5281: request help: jwt-auth设置公钥和私钥，请求到的token不能用
feipengheart commented on issue #5281: URL: https://github.com/apache/apisix/issues/5281#issuecomment-946775630 这是可以的，但我发现了一个新问题，即，如果令牌给了其他人，它也可以访问API。我认为私钥由客户端用于令牌加密，然后JwT-Auth可以使用公钥或签名对其进行解密，但事实并非如此。在请求令牌之后，直接将令牌添加到头以访问API。公钥和私钥似乎没有任何作用。有没有办法解决这个问题，比如给用户一个私钥，只有拥有私钥的用户才能使用有效的令牌访问API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] feipengheart commented on issue #5281: request help: jwt-auth设置公钥和私钥，请求到的token不能用
feipengheart commented on issue #5281: URL: https://github.com/apache/apisix/issues/5281#issuecomment-946773067 > take a look at: > > https://github.com/apache/apisix/blob/50fed630823bb3c562f411d7cb5f5d38218348fb/t/plugin/jwt-auth.t#L702-L749 > > what is `BEGIN RSA PUBLIC KEY`? I think it should be `BEGIN PUBLIC KEY`. It is ok, but I found a new problem, that is, if the token is given to others, it can also access the API. I thought that the private key is used by the client for token encryption, and then JwT-Auth can decrypt it using the public key, or signature, but the fact is not so. After requesting the token, add the token directly to the header to access the API. The public and private keys do not seem to have any effect。Is there any way to solve this problem, such as giving the user a private key, and only the user who has the private key can access the API with a valid token -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-6443 closed pull request #2171: Adjust the read and write timeout configuration of the http server
nic-6443 closed pull request #2171: URL: https://github.com/apache/apisix-dashboard/pull/2171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
tzssangglass commented on issue #5276: URL: https://github.com/apache/apisix/issues/5276#issuecomment-946747076 > req_id is key in my logformat; but value is "http_x_ak_request_id" take a look at:https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/traffic-split.md#matching-rules-correspond-to-upstream ``` "vars": [ ["http_x-api-id","==","2"] ] ``` the request header it will match is `x-api-id` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #5248: refactor: unify code style in Makefile
tzssangglass commented on pull request #5248: URL: https://github.com/apache/apisix/pull/5248#issuecomment-946744725 Is this PR still in progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2104: feat: supports stream route API
bzp2010 commented on a change in pull request #2104:
URL: https://github.com/apache/apisix-dashboard/pull/2104#discussion_r731885114
##
File path: api/test/e2enew/base/base.go
##
@@ -81,6 +82,19 @@ func APISIXExpect() *httpexpect.Expect {
return httpexpect.New(t, APISIXHost)
}
+func APISIXStreamProxyExpect(port uint16, isHTTPS bool) *httpexpect.Expect {
+ if port == 0 {
+ port = 10090
+ }
+ t := getTestingHandle()
+
+ if isHTTPS {
+ return httpexpect.New(t, "https://"; +
net.JoinHostPort("127.0.0.1", strconv.Itoa(int(port
+ } else {
+ return httpexpect.New(t, "http://"; +
net.JoinHostPort("127.0.0.1", strconv.Itoa(int(port
+ }
+}
Review comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] RalapZ edited a comment on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
RalapZ edited a comment on issue #5276:
URL: https://github.com/apache/apisix/issues/5276#issuecomment-946739822
> we have test cases covering this case:
>
>
https://github.com/apache/apisix/blob/50fed630823bb3c562f411d7cb5f5d38218348fb/t/plugin/traffic-split2.t#L593-L710
>
> > {"datetime":"19/Oct/2021:08:11:33 +0800","remote_addr":
"10.49.0.248","http_host": "myzone.ak.xyz","upstream_addr":
"10.49.0.248:22","request_method": "GET","http_referer": "-","req_id":
"10008","company_id": "-","zid": "-","status": "009","server_name":
"_","request_uri": "/","http_user_agent": "curl/7.29.0","http_x_forwarded_for":
"-","body_bytes_sent": "0","upstream_response_time": "0.008","request_time":
"0.009"}
>
> What kind of log is this? And according to the logs I found some
suspicions:
>
> the matching conditions are
>
> ```
> [
> "http_x_ak_request_id",
> "==",
> "10008"
> ]
> ```
>
> but the header in request is `req_id`? `http_x_ak_request_id` match the
`x-ak-request-id` in header, take a look
at:https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/traffic-split.md#matching-rules-correspond-to-upstream
>this is log format
>>access_log_format: '{"datetime":"$time_local","remote_addr":
"$remote_addr","http_host": "$http_host","upstream_addr":
"$upstream_addr","request_method": "$request_method","http_referer":
"$http_referer","req_id": "$http_x_ak_request_id","company_id":
"$http_x_ak_company_id","zid": "$http_zid","status": "$status","server_name":
"$server_name","request_uri": "$request_uri","http_user_agent":
"$http_user_agent","http_x_forwarded_for":
"$http_x_forwarded_for","body_bytes_sent":
"$body_bytes_sent","upstream_response_time":
"$upstream_response_time","request_time": "$request_time"}'
>req_id is key in my logformat; but value is "http_x_ak_request_id"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] RalapZ edited a comment on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
RalapZ edited a comment on issue #5276:
URL: https://github.com/apache/apisix/issues/5276#issuecomment-946739822
> we have test cases covering this case:
>
>
https://github.com/apache/apisix/blob/50fed630823bb3c562f411d7cb5f5d38218348fb/t/plugin/traffic-split2.t#L593-L710
>
> > {"datetime":"19/Oct/2021:08:11:33 +0800","remote_addr":
"10.49.0.248","http_host": "myzone.ak.xyz","upstream_addr":
"10.49.0.248:22","request_method": "GET","http_referer": "-","req_id":
"10008","company_id": "-","zid": "-","status": "009","server_name":
"_","request_uri": "/","http_user_agent": "curl/7.29.0","http_x_forwarded_for":
"-","body_bytes_sent": "0","upstream_response_time": "0.008","request_time":
"0.009"}
>
> What kind of log is this? And according to the logs I found some
suspicions:
>
> the matching conditions are
>
> ```
> [
> "http_x_ak_request_id",
> "==",
> "10008"
> ]
> ```
>
> but the header in request is `req_id`? `http_x_ak_request_id` match the
`x-ak-request-id` in header, take a look
at:https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/traffic-split.md#matching-rules-correspond-to-upstream
this is log format
>>access_log_format: '{"datetime":"$time_local","remote_addr":
"$remote_addr","http_host": "$http_host","upstream_addr":
"$upstream_addr","request_method": "$request_method","http_referer":
"$http_referer","req_id": "$http_x_ak_request_id","company_id":
"$http_x_ak_company_id","zid": "$http_zid","status": "$status","server_name":
"$server_name","request_uri": "$request_uri","http_user_agent":
"$http_user_agent","http_x_forwarded_for":
"$http_x_forwarded_for","body_bytes_sent":
"$body_bytes_sent","upstream_response_time":
"$upstream_response_time","request_time": "$request_time"}'
req_id is key in my logformat; but value is "http_x_ak_request_id"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] RalapZ edited a comment on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
RalapZ edited a comment on issue #5276:
URL: https://github.com/apache/apisix/issues/5276#issuecomment-946739822
> we have test cases covering this case:
>
>
https://github.com/apache/apisix/blob/50fed630823bb3c562f411d7cb5f5d38218348fb/t/plugin/traffic-split2.t#L593-L710
>
> > {"datetime":"19/Oct/2021:08:11:33 +0800","remote_addr":
"10.49.0.248","http_host": "myzone.ak.xyz","upstream_addr":
"10.49.0.248:22","request_method": "GET","http_referer": "-","req_id":
"10008","company_id": "-","zid": "-","status": "009","server_name":
"_","request_uri": "/","http_user_agent": "curl/7.29.0","http_x_forwarded_for":
"-","body_bytes_sent": "0","upstream_response_time": "0.008","request_time":
"0.009"}
>
> What kind of log is this? And according to the logs I found some
suspicions:
>
> the matching conditions are
>
> ```
> [
> "http_x_ak_request_id",
> "==",
> "10008"
> ]
> ```
>
> but the header in request is `req_id`? `http_x_ak_request_id` match the
`x-ak-request-id` in header, take a look
at:https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/traffic-split.md#matching-rules-correspond-to-upstream
this is log format
---
access_log_format: '{"datetime":"$time_local","remote_addr":
"$remote_addr","http_host": "$http_host","upstream_addr":
"$upstream_addr","request_method": "$request_method","http_referer":
"$http_referer","req_id": "$http_x_ak_request_id","company_id":
"$http_x_ak_company_id","zid": "$http_zid","status": "$status","server_name":
"$server_name","request_uri": "$request_uri","http_user_agent":
"$http_user_agent","http_x_forwarded_for":
"$http_x_forwarded_for","body_bytes_sent":
"$body_bytes_sent","upstream_response_time":
"$upstream_response_time","request_time": "$request_time"}'
req_id is key in my logformat; but value is "http_x_ak_request_id"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] RalapZ commented on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
RalapZ commented on issue #5276:
URL: https://github.com/apache/apisix/issues/5276#issuecomment-946739822
> we have test cases covering this case:
>
>
https://github.com/apache/apisix/blob/50fed630823bb3c562f411d7cb5f5d38218348fb/t/plugin/traffic-split2.t#L593-L710
>
> > {"datetime":"19/Oct/2021:08:11:33 +0800","remote_addr":
"10.49.0.248","http_host": "myzone.ak.xyz","upstream_addr":
"10.49.0.248:22","request_method": "GET","http_referer": "-","req_id":
"10008","company_id": "-","zid": "-","status": "009","server_name":
"_","request_uri": "/","http_user_agent": "curl/7.29.0","http_x_forwarded_for":
"-","body_bytes_sent": "0","upstream_response_time": "0.008","request_time":
"0.009"}
>
> What kind of log is this? And according to the logs I found some
suspicions:
>
> the matching conditions are
>
> ```
> [
> "http_x_ak_request_id",
> "==",
> "10008"
> ]
> ```
>
> but the header in request is `req_id`? `http_x_ak_request_id` match the
`x-ak-request-id` in header, take a look
at:https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/traffic-split.md#matching-rules-correspond-to-upstream
this is log format
==
access_log_format: '{"datetime":"$time_local","remote_addr":
"$remote_addr","http_host": "$http_host","upstream_addr":
"$upstream_addr","request_method": "$request_method","http_referer":
"$http_referer","req_id": "$http_x_ak_request_id","company_id":
"$http_x_ak_company_id","zid": "$http_zid","status": "$status","server_name":
"$server_name","request_uri": "$request_uri","http_user_agent":
"$http_user_agent","http_x_forwarded_for":
"$http_x_forwarded_for","body_bytes_sent":
"$body_bytes_sent","upstream_response_time":
"$upstream_response_time","request_time": "$request_time"}'
==
req_id is key in my logformat; but value is "http_x_ak_request_id"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5276: bug:module:"traffic-split" ,when config multi rules. and multi nodes. There is a problem with the matching rule
tzssangglass commented on issue #5276:
URL: https://github.com/apache/apisix/issues/5276#issuecomment-946733596
we have test cases covering this
case:https://github.com/apache/apisix/blob/50fed630823bb3c562f411d7cb5f5d38218348fb/t/plugin/traffic-split2.t#L593-L710
> {"datetime":"19/Oct/2021:08:11:33 +0800","remote_addr":
"10.49.0.248","http_host": "myzone.ak.xyz","upstream_addr":
"10.49.0.248:22","request_method": "GET","http_referer": "-","req_id":
"10008","company_id": "-","zid": "-","status": "009","server_name":
"_","request_uri": "/","http_user_agent": "curl/7.29.0","http_x_forwarded_for":
"-","body_bytes_sent": "0","upstream_response_time": "0.008","request_time":
"0.009"}
What kind of log is this? And according to the logs I found some suspicions:
the matching conditions are
```
[
"http_x_ak_request_id",
"==",
"10008"
]
```
but the header in request is `req_id`? `http_x_ak_request_id` match the
`x-ak-request-id` in header, take a look
at:https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/traffic-split.md#matching-rules-correspond-to-upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
