[GitHub] [apisix-website] juzhiyuan commented on issue #705: Prevent from 301 redirect when visit Apache APISIX's website
juzhiyuan commented on issue #705: URL: https://github.com/apache/apisix-website/issues/705#issuecomment-960478436 The ticket above just gets updated, and if we want to prevent the extra 301, we need infra's help to modify .htaccess, I will update the generated sitemap.xml with an ending `/`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] jikunchong closed issue #176: docs: Failed to deploy under non ingress-apisix namespace
jikunchong closed issue #176: URL: https://github.com/apache/apisix-helm-chart/issues/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] jikunchong commented on issue #176: docs: Failed to deploy under non ingress-apisix namespace
jikunchong commented on issue #176: URL: https://github.com/apache/apisix-helm-chart/issues/176#issuecomment-960478118 ok，tks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #176: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
tao12345666333 commented on issue #176: URL: https://github.com/apache/apisix-helm-chart/issues/176#issuecomment-960476433 This configuration item is newly added, the document has not been completed yet, welcome to submit a PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch chore-algolia updated (d25a36f -> ec6a2e3)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch chore-algolia in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from d25a36f chore: added appId to Algolia configuration add ec6a2e3 feat: added Algolia Craeler verification code No new revisions were added by this update. Summary of changes: website/static/robots.txt | 2 ++ 1 file changed, 2 insertions(+)
[GitHub] [apisix-helm-chart] jikunchong commented on issue #176: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
jikunchong commented on issue #176: URL: https://github.com/apache/apisix-helm-chart/issues/176#issuecomment-960475387 那针对这种一键部署的，建议在官方文档中多说明一下有关指定自己的命名空间时需要怎么做，谢谢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan opened a new pull request #707: chore: added appId to Algolia configuration
juzhiyuan opened a new pull request #707: URL: https://github.com/apache/apisix-website/pull/707 **Changes:** Add appId to Algolia configuration according to https://github.com/facebook/docusaurus/pull/5632 NOTE: It's ok and safe to commit the appKey here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] 01/01: chore: added appId to Algolia configuration
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch chore-algolia
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit d25a36f06f2624b249ad1b40e4c9ac767e092559
Author: juzhiyuan
AuthorDate: Thu Nov 4 13:30:00 2021 +0800
chore: added appId to Algolia configuration
---
website/docusaurus.config.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index ac86bbb..4c967c0 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -681,7 +681,8 @@ module.exports = {
defaultLanguage: 'bash',
},
algolia: {
- apiKey: "287206c9872faf0e77b7c5228d4c3789",
+ appId: '38VC84A2WJ',
+ apiKey: '73248b6e5908d49bb7986c4aef5fd30d',
indexName: "apache_apisix",
contextualSearch: true,
},
[apisix-website] branch chore-algolia created (now d25a36f)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch chore-algolia in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at d25a36f chore: added appId to Algolia configuration This branch includes the following new commits: new d25a36f chore: added appId to Algolia configuration The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix] Rehtt opened a new issue #5418: can use ip:port access ?
Rehtt opened a new issue #5418: URL: https://github.com/apache/apisix/issues/5418 ### Issue description apisix in 192.168.1.2 eg: ``` 192.168.1.2:1234 -> 192.168.1.5:8080 192.168.1.2:2345 -> 192.168.1.6:8090 ``` ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] lijing-21 opened a new pull request #706: docs: add skywalking bolg
lijing-21 opened a new pull request #706: URL: https://github.com/apache/apisix-website/pull/706 add skywalking bolg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #700: Do we need to keep the edit older contents link?
juzhiyuan commented on issue #700: URL: https://github.com/apache/apisix-website/issues/700#issuecomment-960430695 I just fixed one issue #704 for Apache APISIX's website, to keep the correct editUrl for versioned docs. BTW, after discussion with @bzp2010, we two support not updating the older docs 樂 We encourage users to use the latest Apache APISIX from https://apisix.apache.org/downloads . Maybe we could disable `editUrl` link for older docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Xunzhuo commented on pull request #244: feat: install apisix with apisix rpm repo
Xunzhuo commented on pull request #244: URL: https://github.com/apache/apisix-docker/pull/244#issuecomment-960430150 cc @spacewander @tokers ,please take a look, thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] jikunchong opened a new issue #176: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
jikunchong opened a new issue #176: URL: https://github.com/apache/apisix-helm-chart/issues/176 ### Issue description 在非 ingress-apisix 命名空间下部署时， 报错： nc: bad address 'apisix-admin.ingress-apisix.svc.cluster.local' waiting for apisix-admin 原因： wait-apisix-admin 初始化脚本，只找固定命名空间：ingress-apisix initContainers: - name: wait-apisix-admin image: 'busybox:1.28' command: - sh - '-c' - >- until nc -z apisix-admin.ingress-apisix.svc.cluster.local 9180 ; do echo waiting for apisix-admin; sleep 2; done; 手动变更后，才能正常初始化。 ### Environment * your apisix-ingress-controller version (output of `apisix-ingress-controller version --long`); * your Kubernetes cluster version (output of `kubectl version`); * if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (`uname -a`). ### Minimal test code / Steps to reproduce the issue 1. 2. 3. ### What's the actual result? (including assertion message & call stack if applicable) ### What's the expected result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #705: Prevent from 301 redirect when visit Apache APISIX's website
juzhiyuan commented on issue #705: URL: https://github.com/apache/apisix-website/issues/705#issuecomment-960429128 If Infra cannot update its policy, we have to update our sitemap file[1], we need to update every link with a `/` ending. [1] https://apisix.apache.org/sitemap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #175: feat: support more APISIX features
tao12345666333 commented on a change in pull request #175: URL: https://github.com/apache/apisix-helm-chart/pull/175#discussion_r742514044 ## File path: charts/apisix/values.yaml ## @@ -186,6 +188,8 @@ stream_plugins: - ip-restriction - limit-conn +pluginAttrs: null Review comment: Its type should be array, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5414: fix(traffix-split): multiple rules with multiple weighted_upstreams under each rule cause upstream_key duplicate
tzssangglass commented on a change in pull request #5414: URL: https://github.com/apache/apisix/pull/5414#discussion_r742513904 ## File path: apisix/plugins/traffic-split.lua ## @@ -203,6 +207,14 @@ local function new_rr_obj(weighted_upstreams) elseif upstream_obj.upstream then -- Add a virtual id field to uniquely identify the upstream key. upstream_obj.upstream.vid = i +if upstream_obj.upstream.nodes then Review comment: remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan opened a new issue #705: Prevent from 301 redirect when visit Apache APISIX's website
juzhiyuan opened a new issue #705: URL: https://github.com/apache/apisix-website/issues/705 **Actual Behaviour** Hi, when we visit one URL which does not end with `/`, our website will redirect us to a new URL that ends with `/`, after searching, I find that it's because the ASF's Apache Server returns a 301 status code. Why does this matter to us? Bcoz a 301 redirect will reduce SEO rank according to https://help.ahrefs.com/en/articles/2405181-3xx-redirect-in-sitemap-error-in-site-audit . I have submitted a ticket here https://issues.apache.org/jira/browse/INFRA-22482 , wait for Infra's reply. BTW, not only Apache APISIX's website is affected by this policy, Apache SkyWalking's website will return 301 too. cc @wu-sheng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5414: fix(traffix-split): multiple rules with multiple weighted_upstreams under each rule cause upstream_key duplicate
tzssangglass commented on a change in pull request #5414: URL: https://github.com/apache/apisix/pull/5414#discussion_r742512981 ## File path: apisix/plugins/traffic-split.lua ## @@ -203,6 +207,14 @@ local function new_rr_obj(weighted_upstreams) elseif upstream_obj.upstream then -- Add a virtual id field to uniquely identify the upstream key. upstream_obj.upstream.vid = i Review comment: may not, here test vid:https://github.com/apache/apisix/blob/4dafab5afa3293b3d72007517246e01da385f8ef/t/plugin/traffic-split3.t#L398-L461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed issue #676: incorrect image URL for different versions' documentation
juzhiyuan closed issue #676: URL: https://github.com/apache/apisix-website/issues/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #676: incorrect image URL for different versions' documentation
juzhiyuan commented on issue #676: URL: https://github.com/apache/apisix-website/issues/676#issuecomment-960427104 fixed by #697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #736: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
tao12345666333 commented on issue #736: URL: https://github.com/apache/apisix-ingress-controller/issues/736#issuecomment-960422774 ref: https://github.com/apache/apisix-helm-chart/blob/0ddba2d6d17376654553675604da3f1018521ea1/charts/apisix-ingress-controller/values.yaml#L100-L102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 removed a comment on issue #736: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
tao12345666333 removed a comment on issue #736: URL: https://github.com/apache/apisix-ingress-controller/issues/736#issuecomment-960422635 ref: helm install apisix charts/apisix --set gateway.type=NodePort --set ingress-controller.enabled=true --set ingress-controller.config.apisix.serviceNamespace=apisix-ingress-v13 --namespace apisix-ingress-v13 --create-namespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #736: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
tao12345666333 commented on issue #736: URL: https://github.com/apache/apisix-ingress-controller/issues/736#issuecomment-960422635 ref: helm install apisix charts/apisix --set gateway.type=NodePort --set ingress-controller.enabled=true --set ingress-controller.config.apisix.serviceNamespace=apisix-ingress-v13 --namespace apisix-ingress-v13 --create-namespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5411: bug: basic-auth plugin will cause the request abort if Authorization header value is invalid
spacewander commented on issue #5411: URL: https://github.com/apache/apisix/issues/5411#issuecomment-960422523 @leslie-tsang Would you have a try? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #736: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
tao12345666333 commented on issue #736: URL: https://github.com/apache/apisix-ingress-controller/issues/736#issuecomment-960422141 you should add `--set ingress-controller.config.apisix.serviceNamespace=` flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] jikunchong commented on issue #736: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
jikunchong commented on issue #736:
URL:
https://github.com/apache/apisix-ingress-controller/issues/736#issuecomment-960419185
我用的是 1.3.0 版本，helm 部署的。
sudo helm install apisix apisix/apisix \
--set apisix.image.tag=2.10.1-alpine \
--set gateway.type=NodePort \
--set admin.allow.ipList="{0.0.0.0/0}" \
--set dashboard.enabled=true \
--set ingress-controller.enabled=true \
--namespace apisix-system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
spacewander commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-960418497 Maybe we can suffix some rand bytes from https://github.com/thibaultcha/lua-resty-jit-uuid/issues/19#issuecomment-521076462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] jikunchong opened a new issue #736: bug: 在非 ingress-apisix 命名空间下部署时，wait-apisix-admin 失败，脚本错误
jikunchong opened a new issue #736: URL: https://github.com/apache/apisix-ingress-controller/issues/736 ### Issue description 在非 ingress-apisix 命名空间下部署时， 报错： nc: bad address 'apisix-admin.ingress-apisix.svc.cluster.local' waiting for apisix-admin 原因： wait-apisix-admin 初始化脚本，只找固定命名空间：ingress-apisix initContainers: - name: wait-apisix-admin image: 'busybox:1.28' command: - sh - '-c' - >- until nc -z apisix-admin.ingress-apisix.svc.cluster.local 9180 ; do echo waiting for apisix-admin; sleep 2; done; 手动变更后，才能正常初始化。 ### Environment * your apisix-ingress-controller version (output of `apisix-ingress-controller version --long`); * your Kubernetes cluster version (output of `kubectl version`); * if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (`uname -a`). ### Minimal test code / Steps to reproduce the issue 1. 2. 3. ### What's the actual result? (including assertion message & call stack if applicable) ### What's the expected result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers opened a new issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
tokers opened a new issue #5417: URL: https://github.com/apache/apisix/issues/5417 ### Issue description Currently, Apache APISIX will generate an id while initializing if the user doesn't specify one, and it relies on the [lua-resty-jit-uuid](https://github.com/thibaultcha/lua-resty-jit-uuid) library but without an explicit seed. https://github.com/apache/apisix/blob/4dafab5afa3293b3d72007517246e01da385f8ef/apisix/core/id.lua#L76-L78 While the jit-uuid library creates the seed by the process id and the time in ngx_lua context. https://github.com/thibaultcha/lua-resty-jit-uuid/blob/82538049040ae85ff880b79886f21d8593140c7d/lib/resty/jit-uuid.lua#L53-L54 However, in a containerized environment, the process id (the master process) might be the same, i.e. the No. 1 process, also, if users try to deploy Apache APISIX clusters on Kubernetes through the `Deployment` resource, the time might be the same since `ngx.time` doesn't have enough precisions (only at milliseconds level). so the generated apisix id might be duplicated, and if the id is critical, this may cause some fatal problems in the business scenarios. ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): ### Steps to reproduce N/A ### Actual result N/A ### Error log N/A ### Expected result _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch feat/better-support updated (666e604 -> 57c5171)
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch feat/better-support in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git. from 666e604 feat: support more APISIX features add 57c5171 feat: pod uid No new revisions were added by this update. Summary of changes: charts/apisix/templates/deployment.yaml | 13 + charts/apisix/values.yaml | 4 +++- 2 files changed, 16 insertions(+), 1 deletion(-)
[GitHub] [apisix-website] juzhiyuan closed pull request #550: feat: add Zh Blogs
juzhiyuan closed pull request #550: URL: https://github.com/apache/apisix-website/pull/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #626: feat: add Zh Blogs
juzhiyuan commented on pull request #626: URL: https://github.com/apache/apisix-website/pull/626#issuecomment-960398654 Hi @KishaniKandasamy, thanks for your continuous contrition! I have translated all necessary blogs in #681 #682 #679 #678 from Chinese to English, so I will close this PR and #550 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed pull request #626: feat: add Zh Blogs
juzhiyuan closed pull request #626: URL: https://github.com/apache/apisix-website/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Xunzhuo commented on a change in pull request #5378: feat(limit-count): support multiple variables as key
Xunzhuo commented on a change in pull request #5378:
URL: https://github.com/apache/apisix/pull/5378#discussion_r742496235
##
File path: apisix/plugins/limit-count.lua
##
@@ -171,7 +170,29 @@ function _M.access(conf, ctx)
return 500
end
-local key = (ctx.var[conf.key] or "") .. ctx.conf_type .. ctx.conf_version
+local conf_key = conf.key
+local key
+if conf.key_type == "var_combination" then
+local err, n_resolved
+key, err, n_resolved = core.utils.resolve_var(conf_key, ctx.var);
+if err then
+core.log.error("could not resolve vars in ", conf_key, " error: ",
err)
+end
+
+if n_resolved == 0 then
+key = nil
+end
+else
+key = (ctx.var[conf_key] or "")
Review comment:
@spacewander Done and add more test cases when `key_type` is `var`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #156: https for website
juzhiyuan commented on issue #156: URL: https://github.com/apache/apisix-website/issues/156#issuecomment-960381916 **Update** The ASF Infra cannot achieve this for Apache APISIX's website only for now, bcoz those configurations will take effect for all projects 樂 see https://issues.apache.org/jira/browse/INFRA-22392?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel still pending -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2193: refactor: lint shell for shellcheck
zaunist commented on pull request #2193: URL: https://github.com/apache/apisix-dashboard/pull/2193#issuecomment-960373235 cc @bzp2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #702: docs: add Airwallex usercase
juzhiyuan merged pull request #702: URL: https://github.com/apache/apisix-website/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #734: fix: ApisixRoute backendPoint duplicate (#732)
codecov-commenter commented on pull request #734: URL: https://github.com/apache/apisix-ingress-controller/pull/734#issuecomment-960364629 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#734](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1029f90) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/65f7c88193eb6e83b2bb4ca87a981321a99503e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (65f7c88) will **decrease** coverage by `0.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #734 +/- ## == - Coverage 31.70% 31.69% -0.02% == Files 66 65 -1 Lines6640 6639 -1 == - Hits 2105 2104 -1 Misses 4280 4280 Partials 255 255 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `19.63% <0.00%> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [65f7c88...1029f90](https://codecov.io/gh/apache/apisix-ingress-controller/pull/734?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #704: fix: incorrect editUrl for versioned docs
juzhiyuan merged pull request #704: URL: https://github.com/apache/apisix-website/pull/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5413: feat(limit-conn): support multiple variables as key in L4
spacewander merged pull request #5413: URL: https://github.com/apache/apisix/pull/5413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: incorrect editUrl for versioned docs (#704)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 9661d11 fix: incorrect editUrl for versioned docs (#704)
9661d11 is described below
commit 9661d118d731f61f6fc3ade93732f4ef1aa944ec
Author: 琚致远
AuthorDate: Thu Nov 4 10:02:50 2021 +0800
fix: incorrect editUrl for versioned docs (#704)
---
website/docusaurus.config.js | 88 ++--
1 file changed, 77 insertions(+), 11 deletions(-)
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index ec954cd..ac86bbb 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -1,5 +1,16 @@
const { ssrTemplate } = require('./config/ssrTemplate');
+const getEditUrl = ({
+ projectName,
+ version,
+ locale,
+ docPath,
+ defaultBranch = "master"
+}) => {
+ const branch = version === 'current' ? defaultBranch : `release/${version}`;
+ return
`https://github.com/apache/${projectName}/edit/${branch}/docs/${locale}/latest/${docPath}`;
+}
+
module.exports = {
title: "Apache APISIX® -- Cloud-Native API Gateway",
tagline:
@@ -293,11 +304,16 @@ module.exports = {
routeBasePath: "/docs/apisix",
sidebarPath: require.resolve("./docs/apisix/sidebars.json"),
editUrl: function ({
- locale,
docPath,
+ version,
+ locale
}) {
- // TODO: support Edit on multiple versions/branches
- return
`https://github.com/apache/apisix/edit/master/docs/${locale}/latest/${docPath}`;
+ return getEditUrl({
+projectName: "apisix",
+locale,
+docPath,
+version
+ })
},
},
],
@@ -312,8 +328,15 @@ module.exports = {
sidebarPath: require.resolve("./docs/apisix-dashboard/sidebars.json"),
editUrl: function ({
docPath,
+ version,
+ locale
}) {
- return
`https://github.com/apache/apisix-dashboard/edit/master/docs/en/latest/${docPath}`;
+ return getEditUrl({
+projectName: "apisix-dashboard",
+locale,
+docPath,
+version
+ })
},
},
],
@@ -330,8 +353,15 @@ module.exports = {
),
editUrl: function ({
docPath,
+ version,
+ locale
}) {
- return
`https://github.com/apache/apisix-ingress-controller/edit/master/docs/en/latest/${docPath}`;
+ return getEditUrl({
+projectName: "apisix-ingress-controller",
+locale,
+docPath,
+version
+ })
},
},
],
@@ -346,8 +376,15 @@ module.exports = {
sidebarPath: require.resolve("./docs/apisix-helm-chart/sidebars.json"),
editUrl: function ({
docPath,
+ version,
+ locale
}) {
- return
`https://github.com/apache/apisix-helm-chart/edit/master/docs/en/latest/${docPath}`;
+ return getEditUrl({
+projectName: "apisix-helm-chart",
+locale,
+docPath,
+version
+ })
},
},
],
@@ -362,8 +399,15 @@ module.exports = {
sidebarPath: require.resolve("./docs/apisix-docker/sidebars.json"),
editUrl: function ({
docPath,
+ version,
+ locale
}) {
- return
`https://github.com/apache/apisix-docker/edit/master/docs/en/latest/${docPath}`;
+ return getEditUrl({
+projectName: "apisix-docker",
+locale,
+docPath,
+version
+ })
},
},
],
@@ -378,8 +422,16 @@ module.exports = {
sidebarPath:
require.resolve("./docs/apisix-java-plugin-runner/sidebars.json"),
editUrl: function ({
docPath,
+ version,
+ locale
}) {
- return
`https://github.com/apache/apisix-java-plugin-runner/edit/main/docs/en/latest/${docPath}`;
+ return getEditUrl({
+projectName: "apisix-java-plugin-runner",
+locale,
+docPath,
+version,
+defaultBranch: "main"
+ })
},
},
],
@@ -394,8 +446,15 @@ module.exports = {
sidebarPath:
require.resolve("./docs/apisix-go-plugin-runner/sidebars.json"),
editUrl: function ({
docPath,
+ version,
+ locale
}) {
- return
`https://github.com/apache/apisix-go-plugin-runner/edit/master/docs/en/latest/${docPath}`;
+ return getEditUrl({
+projectName: "apisix-go-plugin-runner",
+locale,
+docPath,
+version,
+ })
},
},
],
@@ -410,8 +469,15 @@
[GitHub] [apisix] spacewander commented on a change in pull request #5414: fix(traffix-split): multiple rules with multiple weighted_upstreams nder each rule cause upstream_key duplicate
spacewander commented on a change in pull request #5414: URL: https://github.com/apache/apisix/pull/5414#discussion_r742466415 ## File path: apisix/plugins/traffic-split.lua ## @@ -203,6 +207,14 @@ local function new_rr_obj(weighted_upstreams) elseif upstream_obj.upstream then -- Add a virtual id field to uniquely identify the upstream key. upstream_obj.upstream.vid = i Review comment: It seems the vid is no longer required? ## File path: apisix/plugins/traffic-split.lua ## @@ -203,6 +207,14 @@ local function new_rr_obj(weighted_upstreams) elseif upstream_obj.upstream then -- Add a virtual id field to uniquely identify the upstream key. upstream_obj.upstream.vid = i +if upstream_obj.upstream.nodes then Review comment: Look like the nodes check here can be skipped? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5378: feat(limit-count): support multiple variables as key
spacewander commented on a change in pull request #5378:
URL: https://github.com/apache/apisix/pull/5378#discussion_r741949841
##
File path: docs/en/latest/plugins/limit-count.md
##
@@ -68,13 +69,38 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H
'X-API-KEY: edd1c9f034335
"count": 2,
"time_window": 60,
"rejected_code": 503,
+"key_type": "var",
"key": "remote_addr"
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
-"39.97.63.215:80": 1
+"127.0.0.1:9001": 1
+}
+}
+}'
+```
+
+Here's an example, enable the `limit count` plugin on the specified route and
when setting `key_type` to `var_combination` :
Review comment:
```suggestion
Here's an example, enable the `limit count` plugin on the specified route
when setting `key_type` to `var_combination` :
```
##
File path: docs/zh/latest/plugins/limit-count.md
##
@@ -42,7 +42,8 @@ title: limit-count
| --- | --- | - |
- |
---
|
-
|
| count | integer | 必须 |
| count > 0
| 指定时间窗口内的请求数量阈值
|
| time_window | integer | 必须 |
| time_window > 0
| 时间窗口的大小（以秒为单位），超过这个时间就会重置
|
-| key | string | 可选 |
"remote_addr" | ["remote_addr", "server_addr", "http_x_real_ip",
"http_x_forwarded_for", "consumer_name", "service_id"] | 用来做请求计数的有效值。例如，可以使用主机名（或服务器区域）作为关键字，以便限制每个主机名规定时间内的请求次数。我们也可以使用客户端地址作为关键字，这样我们就可以避免单个客户端规定时间内多次的连接我们的服务。当前接受的 key 有："remote_addr"（客户端 IP 地址）, "server_addr"（服务端 IP 地址）,
请求头中的"X-Forwarded-For" 或 "X-Real-IP", "consumer_name"（consumer 的 username）,
"service_id" 。 |
+| key_type | string | 可选 | "var" | ["var", "var_combination"]
| key 的类型 |
+| key | string | 可选 |"remote_addr"| | 用来做请求计数的依据。如果
`key_type` 为 "var"，那么 key 会被当作变量名称。当前接受的 key 有："remote_addr"（客户端 IP 地址）,
"server_addr"（服务端 IP 地址）, 请求头中的"X-Forwarded-For" 或 "X-Real-IP",
"consumer_name"（consumer 的 username）, "service_id" 。如果 `key_type` 为
"var_combination"，那么 key 会当作变量组。比如设置 "$remote_addr $consumer_name" 作为
keys，那么插件会同时受 remote_addr 和 consumer_name 两个 key 的约束。 |
Review comment:
Ditto
##
File path: docs/en/latest/plugins/limit-count.md
##
@@ -39,7 +39,8 @@ Limit request rate by a fixed number of requests in a given
time window.
| --- | --- | --- |
- |
---
|
--
|
| count | integer | required|
| count > 0
| the specified number of requests
threshold.
[GitHub] [apisix] spacewander closed issue #4241: request help: when add jwt-auth plugin to a service/route，jwt token must contain "key" claim。
spacewander closed issue #4241: URL: https://github.com/apache/apisix/issues/4241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5390: docs: fix markdown render issue in the example
spacewander merged pull request #5390: URL: https://github.com/apache/apisix/pull/5390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Xunzhuo removed a comment on pull request #242: feat: replace openresty with apisix-base
Xunzhuo removed a comment on pull request #242: URL: https://github.com/apache/apisix-docker/pull/242#issuecomment-958643739 /hold /do-not-merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Xunzhuo commented on pull request #242: chore: replace openresty with apisix-base
Xunzhuo commented on pull request #242: URL: https://github.com/apache/apisix-docker/pull/242#issuecomment-958643739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #5410: bug: enable dubbo proxy ,start apisix occur error
shuaijinchao commented on issue #5410: URL: https://github.com/apache/apisix/issues/5410#issuecomment-958689227 Please refer to the documentation requirements: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/dubbo-proxy.md#requirement Check if Tengine's mod_dubbo module is compiled in Openresty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #2048: test: chaos test on delay
github-actions[bot] commented on pull request #2048: URL: https://github.com/apache/apisix-dashboard/pull/2048#issuecomment-958811046 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #5198: Why plugin list disappear after adding a new plugin?
shuaijinchao commented on issue #5198: URL: https://github.com/apache/apisix/issues/5198#issuecomment-958678749 You can check whether the ETCD status is normal through the client. Are there any other problems? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #5330: request help: my upstream is not evenly loaded
shuaijinchao commented on issue #5330: URL: https://github.com/apache/apisix/issues/5330#issuecomment-958676190 Is there a personalized strategy for different requests? Is it possible to filter a specific API log analysis request and whether the load is balanced? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] SSSherg commented on issue #79: request help: Custom plugins have no effect
SSSherg commented on issue #79: URL: https://github.com/apache/apisix-java-plugin-runner/issues/79#issuecomment-958702371 > can you remove jwt plugin and test ext-plugin-pre-req? > > I reproduced ext-plugin-pre-req and didn't find the problem you mentioned. thanks ! The problem has already been solved. add ext-plugin-pre-req in config.yaml -- plugins: # plugin list ·· - ext-plugin-pre-req - I didn't realize to add this plugin ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4241: request help: when add jwt-auth plugin to a service/route，jwt token must contain "key" claim。
spacewander commented on issue #4241: URL: https://github.com/apache/apisix/issues/4241#issuecomment-958959822 Closed as lack of response. Feel free to reopen it if need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #2643: request help: Use ngx.var.request_id as unique id for requests and response tracing, not jit-uuid.
github-actions[bot] commented on issue #2643: URL: https://github.com/apache/apisix/issues/2643#issuecomment-958808305 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed pull request #2048: test: chaos test on delay
juzhiyuan closed pull request #2048: URL: https://github.com/apache/apisix-dashboard/pull/2048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #5406: request help: migrate Kong to APISIX
shuaijinchao commented on issue #5406: URL: https://github.com/apache/apisix/issues/5406#issuecomment-958637370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Xunzhuo closed issue #240: chore: change rpm package link from github release download to rpm repo
Xunzhuo closed issue #240: URL: https://github.com/apache/apisix-docker/issues/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated (0189f0f -> 4bc3c97)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 0189f0f docs: update tags: [Technology] (#701) add 4bc3c97 docs: added Airwallex usercase (#702) No new revisions were added by this update. Summary of changes: website/blog/2021/11/03/airwallex-usercase.md | 125 + .../2021/11/03/airwallex-usercase.md | 123 2 files changed, 248 insertions(+) create mode 100644 website/blog/2021/11/03/airwallex-usercase.md create mode 100644 website/i18n/zh/docusaurus-plugin-content-blog/2021/11/03/airwallex-usercase.md
[GitHub] [apisix] tzssangglass commented on issue #5376: request help: how to distinguish in the http-logger plugin whether the response is returned by upstream or apisix
tzssangglass commented on issue #5376: URL: https://github.com/apache/apisix/issues/5376#issuecomment-959514325 I think this should be changed in the log function of `http-logger`. add `X-APISIX-Upstream-Status` to indicate the status of the upstream response. just like the `set_resp_upstream_status` function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 merged pull request #697: fix: extract docs from target branch
bzp2010 merged pull request #697: URL: https://github.com/apache/apisix-website/pull/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5415: request help: Custom plugins have no effect
tzssangglass commented on issue #5415: URL: https://github.com/apache/apisix/issues/5415#issuecomment-959461539 it looks strange, if the `ext-plugin-pre-req plugin` is not enabled in `config.yaml`, the plugin runner's logs should not be output. well, I know why. even if the `ext-plugin-pre-req plugin` is not enabled in `config.yaml`, APISIX will still run the plugin runner in the `http_init_worker` phase. see: https://github.com/apache/apisix/blob/10833592282787352ee9960ca1c5593985b785bb/apisix/init.lua#L130 https://github.com/apache/apisix/blob/10833592282787352ee9960ca1c5593985b785bb/apisix/plugins/ext-plugin/init.lua#L778-L797 so we should check in the `init_worker` function of `ext-plugin-*` that `ext-plugin-*` is enabled. PR is welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5407: test: remove unused conf & make t/core/config_etcd.t stable
spacewander merged pull request #5407: URL: https://github.com/apache/apisix/pull/5407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] commented on issue #192: etcdmain: cannot access data directory: mkdir /bitnami/etcd/data: permission denied
github-actions[bot] commented on issue #192: URL: https://github.com/apache/apisix-docker/issues/192#issuecomment-958807565 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat(limit-conn): support multiple variables as key in L4 (#5413)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 4dafab5 feat(limit-conn): support multiple variables as key in L4
(#5413)
4dafab5 is described below
commit 4dafab5afa3293b3d72007517246e01da385f8ef
Author: 罗泽轩
AuthorDate: Thu Nov 4 09:48:02 2021 +0800
feat(limit-conn): support multiple variables as key in L4 (#5413)
---
apisix/stream/plugins/limit-conn.lua | 7 +-
docs/en/latest/plugins/limit-conn.md | 4 -
docs/en/latest/plugins/limit-req.md | 2 -
docs/zh/latest/plugins/limit-conn.md | 4 -
docs/zh/latest/plugins/limit-req.md | 2 -
t/admin/plugins.t| 2 +-
t/stream-plugin/limit-conn.t | 145 +++
7 files changed, 150 insertions(+), 16 deletions(-)
diff --git a/apisix/stream/plugins/limit-conn.lua
b/apisix/stream/plugins/limit-conn.lua
index d2bd25e..1beb7c7 100644
--- a/apisix/stream/plugins/limit-conn.lua
+++ b/apisix/stream/plugins/limit-conn.lua
@@ -26,9 +26,10 @@ local schema = {
burst = {type = "integer", minimum = 0},
default_conn_delay = {type = "number", exclusiveMinimum = 0},
only_use_default_delay = {type = "boolean", default = false},
-key = {
-type = "string",
-enum = {"remote_addr", "server_addr"}
+key = {type = "string"},
+key_type = {type = "string",
+enum = {"var", "var_combination"},
+default = "var",
},
},
required = {"conn", "burst", "default_conn_delay", "key"}
diff --git a/docs/en/latest/plugins/limit-conn.md
b/docs/en/latest/plugins/limit-conn.md
index 1af26f3..4790039 100644
--- a/docs/en/latest/plugins/limit-conn.md
+++ b/docs/en/latest/plugins/limit-conn.md
@@ -47,10 +47,6 @@ Limiting request concurrency plugin.
| rejected_msg | string | optional|
| non-empty| the response body returned
when the request exceeds `conn` + `burst` will be rejected.
|
| allow_degradation | boolean | optional
| false |
| Whether to enable plugin degradation when the limit-conn function
is temporarily unavailable. Allow requests to continue when the value is set to
true, default false. |
-**Key can be customized by the user, only need to modify a line of code of the
plug-in to complete. It is a security consideration that is not open in the
plugin.**
-
-When used in the stream proxy, only `remote_addr` and `server_addr` can be
used as key. And `rejected_code` is meaningless.
-
## How To Enable
Here's an example, enable the limit-conn plugin on the specified route:
diff --git a/docs/en/latest/plugins/limit-req.md
b/docs/en/latest/plugins/limit-req.md
index 500ed8d..0c16c76 100644
--- a/docs/en/latest/plugins/limit-req.md
+++ b/docs/en/latest/plugins/limit-req.md
@@ -47,8 +47,6 @@ limit request rate using the "leaky bucket" method.
| nodelay | boolean | optional| false |
| If nodelay flag is true,
bursted requests will not get delayed |
| allow_degradation | boolean | optional
| false |
| Whether to enable plugin degradation when the limit-req function
is temporarily unavailable. Allow requests to continue when the value is set to
true, default false. |
-**Key can be customized by the user, only need to modify a line of code of the
plug-in to complete. It is a security consideration that is not open in the
plugin.**
-
## Example
### How to enable on the `route` or `service`
diff --git a/docs/zh/latest/plugins/limit-conn.md
b/docs/zh/latest/plugins/limit-conn.md
index 0438229..ca3a381 100644
--- a/docs/zh/latest/plugins/limit-conn.md
+++ b/docs/zh/latest/plugins/limit-conn.md
@@ -37,10 +37,6 @@ title: limit-conn
| rejected_msg | string | 可选|
| 非空 | 当请求超过 `conn` + `burst`
这个阈值时，返回的响应体。
|
| allow_degradation | boolean | 可选
| false |
|
[GitHub] [apisix] spacewander merged pull request #5408: chore(deps): bump actions/checkout from 2.3.5 to 2.4.0
spacewander merged pull request #5408: URL: https://github.com/apache/apisix/pull/5408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] commented on issue #185: modify nginx.conf not restart apisix
github-actions[bot] commented on issue #185: URL: https://github.com/apache/apisix-docker/issues/185#issuecomment-958807535 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 merged pull request #701: docs: update tags: [Technology]
bzp2010 merged pull request #701: URL: https://github.com/apache/apisix-website/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 closed pull request #174: chore: bump apisix-ingress chart version
tao12345666333 closed pull request #174: URL: https://github.com/apache/apisix-helm-chart/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5393: ci: no need to exclude submodule explicitly
spacewander merged pull request #5393: URL: https://github.com/apache/apisix/pull/5393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] commented on issue #195: Request Error Code: 2000001 The manager-api and apache apisix are mismatched.
github-actions[bot] commented on issue #195: URL: https://github.com/apache/apisix-docker/issues/195#issuecomment-958807618 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5412: request help: proxy_mirror复制流量时，插件内host配置的域名指向nginx-ingress-controller无法接收流量
tokers commented on issue #5412: URL: https://github.com/apache/apisix/issues/5412#issuecomment-958781390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5411: bug: basic-auth plugin will cause the request abort if Authorization header value is invalid
spacewander commented on issue #5411: URL: https://github.com/apache/apisix/issues/5411#issuecomment-958778277 It could be solved with this: https://github.com/apache/apisix/blob/10833592282787352ee9960ca1c5593985b785bb/apisix/plugins/ldap-auth.lua#L99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #694: refactor：load images from CDN
guoqqqi commented on pull request #694: URL: https://github.com/apache/apisix-website/pull/694#issuecomment-959142560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] commented on issue #193: | nginx: [warn] could not build optimal variables_hash
github-actions[bot] commented on issue #193: URL: https://github.com/apache/apisix-docker/issues/193#issuecomment-958807592 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #5378: feat(limit-count): support multiple variables as key
moonming commented on a change in pull request #5378:
URL: https://github.com/apache/apisix/pull/5378#discussion_r741900875
##
File path: apisix/plugins/limit-count.lua
##
@@ -36,11 +36,10 @@ local schema = {
properties = {
count = {type = "integer", exclusiveMinimum = 0},
time_window = {type = "integer", exclusiveMinimum = 0},
-key = {
-type = "string",
-enum = {"remote_addr", "server_addr", "http_x_real_ip",
-"http_x_forwarded_for", "consumer_name", "service_id"},
-default = "remote_addr",
+key = {type = "string", default = "remote_addr"},
+key_type = {type = "string",
+enum = {"var", "var_combination"},
Review comment:
please add test cases for non-existent variable @Xunzhuo
##
File path: apisix/plugins/limit-count.lua
##
@@ -171,7 +170,29 @@ function _M.access(conf, ctx)
return 500
end
-local key = (ctx.var[conf.key] or "") .. ctx.conf_type .. ctx.conf_version
+local conf_key = conf.key
+local key
+if conf.key_type == "var_combination" then
+local err, n_resolved
+key, err, n_resolved = core.utils.resolve_var(conf_key, ctx.var);
+if err then
+core.log.error("could not resolve vars in ", conf_key, " error: ",
err)
+end
+
+if n_resolved == 0 then
+key = nil
+end
+else
+key = ctx.var[conf_key]
Review comment:
if `ctx.var[conf_key]` is `nil`, what is the result you expect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Xunzhuo commented on a change in pull request #5378: feat(limit-count): support multiple variables as key
Xunzhuo commented on a change in pull request #5378:
URL: https://github.com/apache/apisix/pull/5378#discussion_r741587987
##
File path: apisix/plugins/limit-count.lua
##
@@ -36,11 +36,10 @@ local schema = {
properties = {
count = {type = "integer", exclusiveMinimum = 0},
time_window = {type = "integer", exclusiveMinimum = 0},
-key = {
-type = "string",
-enum = {"remote_addr", "server_addr", "http_x_real_ip",
-"http_x_forwarded_for", "consumer_name", "service_id"},
-default = "remote_addr",
+key = {type = "string", default = "remote_addr"},
+key_type = {type = "string",
+enum = {"var", "var_combination"},
Review comment:
Thanks @tokers I am working on it, update it later~
##
File path: apisix/plugins/limit-count.lua
##
@@ -171,7 +170,29 @@ function _M.access(conf, ctx)
return 500
end
-local key = (ctx.var[conf.key] or "") .. ctx.conf_type .. ctx.conf_version
+local conf_key = conf.key
+local key
+if conf.key_type == "var_combination" then
+local err, n_resolved
+key, err, n_resolved = core.utils.resolve_var(conf_key, ctx.var);
+if err then
+core.log.error("could not resolve vars in ", conf_key, " error: ",
err)
+end
+
+if n_resolved == 0 then
+key = nil
+end
+else
+key = ctx.var[conf_key]
Review comment:
CI failure occurred, I wonder if I should use 'key = ( ctx.var[conf_key]
or "")' instead of the current way. cc @spacewander
##
File path: apisix/plugins/limit-count.lua
##
@@ -171,7 +170,29 @@ function _M.access(conf, ctx)
return 500
end
-local key = (ctx.var[conf.key] or "") .. ctx.conf_type .. ctx.conf_version
+local conf_key = conf.key
+local key
+if conf.key_type == "var_combination" then
+local err, n_resolved
+key, err, n_resolved = core.utils.resolve_var(conf_key, ctx.var);
+if err then
+core.log.error("could not resolve vars in ", conf_key, " error: ",
err)
+end
+
+if n_resolved == 0 then
+key = nil
+end
+else
+key = ctx.var[conf_key]
Review comment:
Yes, I got it, thanks~
##
File path: docs/zh/latest/plugins/limit-count.md
##
@@ -42,7 +42,8 @@ title: limit-count
| --- | --- | - |
- |
---
|
-
|
| count | integer | 必须 |
| count > 0
| 指定时间窗口内的请求数量阈值
|
| time_window | integer | 必须 |
| time_window > 0
| 时间窗口的大小（以秒为单位），超过这个时间就会重置
|
-| key | string | 可选 |
"remote_addr" | ["remote_addr", "server_addr", "http_x_real_ip",
"http_x_forwarded_for", "consumer_name", "service_id"] | 用来做请求计数的有效值。例如，可以使用主机名（或服务器区域）作为关键字，以便限制每个主机名规定时间内的请求次数。我们也可以使用客户端地址作为关键字，这样我们就可以避免单个客户端规定时间内多次的连接我们的服务。当前接受的 key 有："remote_addr"（客户端 IP 地址）, "server_addr"（服务端 IP 地址）,
请求头中的"X-Forwarded-For" 或 "X-Real-IP", "consumer_name"（consumer 的 username）,
"service_id" 。 |
+| key_type | string | 可选 | "var" | ["var", "var_combination"]
| key 的类型 |
+| key | string | 可选 |"remote_addr"| | 用来做请求计数的依据。如果
`key_type` 为 "var"，那么 key 会被当作变量名称。当前接受的 key 有："remote_addr"（客户端 IP 地址）,
"server_addr"（服务端 IP
[GitHub] [apisix-website] spacewander commented on issue #700: Do we need to keep the edit older contents link?
spacewander commented on issue #700: URL: https://github.com/apache/apisix-website/issues/700#issuecomment-958737697 I think we should only allow editing the latest content and submit PR to the source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] fish2018 commented on issue #5412: request help: cannot receive traffic after using proxy_mirror plugin
fish2018 commented on issue #5412: URL: https://github.com/apache/apisix/issues/5412#issuecomment-958790633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] spacewander merged pull request #242: feat: replace openresty with apisix-base
spacewander merged pull request #242: URL: https://github.com/apache/apisix-docker/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] gy09535 edited a comment on issue #2194: Should apisix support environment config or profile config?
gy09535 edited a comment on issue #2194: URL: https://github.com/apache/apisix-dashboard/issues/2194#issuecomment-957159239 > @gy09535 You can specify a different profile with `-c`. BTW, Are you trying to overwrite the contents of the configuration file via environment variables? En., yeah I use it in publish platform, for different environment, I want use one docker image, and change the config with different environment variables, like this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #172: fix: remove trailing white space in configmap
tao12345666333 merged pull request #172: URL: https://github.com/apache/apisix-helm-chart/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #700: Do we need to keep the edit older contents link?
juzhiyuan commented on issue #700: URL: https://github.com/apache/apisix-website/issues/700#issuecomment-958632981 What do you think of this? cc @bzp2010 @spacewander @iamayushdas @lilien1010 @tokers @tao12345666333 @imjoey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5378: feat(limit-count): support multiple variables as key
tokers commented on a change in pull request #5378:
URL: https://github.com/apache/apisix/pull/5378#discussion_r741741820
##
File path: apisix/plugins/limit-count.lua
##
@@ -36,11 +36,10 @@ local schema = {
properties = {
count = {type = "integer", exclusiveMinimum = 0},
time_window = {type = "integer", exclusiveMinimum = 0},
-key = {
-type = "string",
-enum = {"remote_addr", "server_addr", "http_x_real_ip",
-"http_x_forwarded_for", "consumer_name", "service_id"},
-default = "remote_addr",
+key = {type = "string", default = "remote_addr"},
+key_type = {type = "string",
+enum = {"var", "var_combination"},
Review comment:
OK, I saw the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #722: bug: empty apisixupstream can be apply but it cause panic
tao12345666333 commented on issue #722: URL: https://github.com/apache/apisix-ingress-controller/issues/722#issuecomment-958784033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] qq54903099 commented on issue #5376: request help: how to distinguish in the http-logger plugin whether the response is returned by upstream or apisix
qq54903099 commented on issue #5376: URL: https://github.com/apache/apisix/issues/5376#issuecomment-958777333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5401: test: avoid client timeout caused by DNS query
spacewander merged pull request #5401: URL: https://github.com/apache/apisix/pull/5401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #725: request help: apisix error：Failed to watch *v2beta1.ApisixRoute
tao12345666333 commented on issue #725: URL: https://github.com/apache/apisix-ingress-controller/issues/725#issuecomment-958779666 If you using apisix-ingress v1.3 with latest CRD, you should get the following output ```bash ➜ ~ kubectl api-resources |grep apisix apisixclusterconfigs acc apisix.apache.org/v2alpha1 falseApisixClusterConfig apisixconsumers ac apisix.apache.org/v2alpha1 true ApisixConsumer apisixroutes ar apisix.apache.org/v2beta2 true ApisixRoute apisixtlses atls apisix.apache.org/v1 true ApisixTls apisixupstreams au apisix.apache.org/v1 true ApisixUpstream ``` If you want to use https://github.com/apache/apisix-ingress-controller/tree/master/samples/deploy/crd/v1 You need run `kubectl apply -k ./samples/deploy/crd/v1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on pull request #242: chore: replace openresty with apisix-base
tokers commented on pull request #242: URL: https://github.com/apache/apisix-docker/pull/242#issuecomment-958635369 > > && luarocks config variables.OPENSSL_LIBDIR /usr/local/openresty/openssl/lib > > && luarocks config variables.OPENSSL_INCDIR /usr/local/openresty/openssl/include \ > > `api7/apisix-base:1.19.3.2.1` don't contain OPENSSL* dir Use dir `/usr/local/openresty/openssl111`. @Xunzhuo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jaredhuang commented on issue #5356: request help: I have a url with # how can i config forward
jaredhuang commented on issue #5356: URL: https://github.com/apache/apisix/issues/5356#issuecomment-958620073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #5412: request help: cannot receive traffic after using proxy_mirror plugin
shuaijinchao commented on issue #5412: URL: https://github.com/apache/apisix/issues/5412#issuecomment-958794149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on a change in pull request #702: docs: add Airwallex usercase
yzeng25 commented on a change in pull request #702: URL: https://github.com/apache/apisix-website/pull/702#discussion_r741630683 ## File path: website/blog/2021/11/03/airwallex-usercase.md ## @@ -0,0 +1,125 @@ +--- +title: "How Apache APISIX protects Airwallex data sovereignty through the gateway layer" +author: "Yang Li" +keywords: +- Apache APISIX +- Airwallex +- Data Sovereignty +- Data +description: This article will bring you about how Airwallex air cloud sink uses Apache APISIX for gateway layer deployment to strengthen the construction of data sovereignty. +tags: [User Case] +--- + +> This article will bring you about how Airwallex air cloud sink uses Apache APISIX for gateway layer deployment to strengthen the construction of data sovereignty. + + + +## Why deal with data sovereignty? + +[Airwallex](https://www.airwallex.com) is a global financial technology company that helps global users with payment services and cross-border payment scenarios. A global financial infrastructure platform has been built, and the payment network has covered more than 50 currencies in more than 130 countries and regions around the world, providing enterprises with digital financial technology products. + + + +Under the demand of global service content, the risk of data sovereignty must be considered in the conduct of the company's business. + +### What is data sovereignty? + +Data sovereignty refers to the national sovereignty in cyberspace, which reflects the status of the state as the subject of controlling data rights. Before describing the importance of data sovereignty, let's give a few examples. + +GDPR (General Data Protection Regulation) is a regulatory document formulated by the European Union, which is aimed at the privacy and protection of personal data. One of the most basic requirements in GDPR is that all user data collection activities need to be approved by the user, while ensuring that the user can clear personal data on their own. + +Therefore, if the Airwallex sink wants to transfer European data to other regions, it must ensure that the requirements of third-party countries on data sovereignty meet the requirements of the European Union on data sovereignty. +With regard to the need for data to comply with local laws, there are indeed a lot of concerns in multinational operations. + +For example, the American Patriot Act requires all data stored in the United States, or data stored by American companies, to be regulated in the United States, and the US Department of Justice and CIA can require companies to provide data. + +After 9 / 11, 2013, the Justice Department asked Microsoft to provide some of the email information it stored on its servers in Ireland, when Microsoft rejected the request on the grounds that it would violate EU regulatory requirements. Then the U.S. Department of Justice took Microsoft to court, but Microsoft won in the end. Later, in order to avoid the risk of the opposite of data sovereignty, many American companies put their data centers directly to Europe, thinking that it would be safe. But in some recent cases, judges have ruled that the United States still has the authority to ask for data from American companies in Europe. + +Judging from the above events, data sovereignty has indeed brought great challenges to Airwallex's global business, and how to properly handle the issue of data sovereignty in the business has become particularly important. + +### Current situation of transnational business data transmission + +Because the business involves transnational attributes, some problems will be encountered in the technical processing. + + Review comment: ```suggestion  ``` ## File path: website/blog/2021/11/03/airwallex-usercase.md ## @@ -0,0 +1,125 @@ +--- +title: "How Apache APISIX protects Airwallex data sovereignty through the gateway layer" +author: "Yang Li" +keywords: +- Apache APISIX +- Airwallex +- Data Sovereignty +- Data +description: This article will bring you about how Airwallex air cloud sink uses Apache APISIX for gateway layer deployment to strengthen the construction of data sovereignty. +tags: [User Case] +--- + +> This article will bring you about how Airwallex air cloud sink uses Apache APISIX for gateway layer deployment to strengthen the construction of data sovereignty. + + + +## Why deal with data sovereignty? + +[Airwallex](https://www.airwallex.com) is a global financial technology company that helps global users with payment services and cross-border payment scenarios. A global financial infrastructure platform has been built, and the
[GitHub] [apisix] shuaijinchao closed issue #5199: how to config error_page like nginx?
shuaijinchao closed issue #5199: URL: https://github.com/apache/apisix/issues/5199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5346: request help: shall we use editorconfig to consistent coding styles ?
spacewander closed issue #5346: URL: https://github.com/apache/apisix/issues/5346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao closed issue #5406: request help: migrate Kong to APISIX
shuaijinchao closed issue #5406: URL: https://github.com/apache/apisix/issues/5406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #2166: Route.vars support "!" operator
starsz commented on issue #2166: URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-958745895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #696: docs: update blogs' links and fix some errors
juzhiyuan merged pull request #696: URL: https://github.com/apache/apisix-website/pull/696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #5402: Waaa
spacewander closed pull request #5402: URL: https://github.com/apache/apisix/pull/5402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #735: docs: add upgrade guide
tokers commented on a change in pull request #735: URL: https://github.com/apache/apisix-ingress-controller/pull/735#discussion_r741571766 ## File path: docs/en/latest/upgrade.md ## @@ -0,0 +1,71 @@ +--- +title: Upgrade Guide +--- + + + +## Validate Compatibility + +Apache APISIX Ingress project is a continuously actively developed project. +In order to make it better, some breaking changes will be added when the new version is released. Review comment: ```suggestion In order to make it better, some broken changes will be added when the new version is released. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5373: bug: if password contains "@" nacos discovery happens error
tzssangglass commented on issue #5373: URL: https://github.com/apache/apisix/issues/5373#issuecomment-958609472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
