date:20211128

[GitHub] [apisix] shuaijinchao opened a new issue #5636: proposal: support splunk hec logging plugin

2021-11-28 Thread GitBox



shuaijinchao opened a new issue #5636:
URL: https://github.com/apache/apisix/issues/5636


   ### Issue description
   
   Splunk is a machine data search engine. According to the latest database 
search engine ranking [1], Splunk has been ranked second, and Splunk can be 
used to collect, index and retrieve various application data. Splunk, like 
ElasticSearch, is quasi-real-time and can provide an uninterrupted data stream 
of search results. I think Apache APISIX can provide a plugin that supports 
pushing request logs to Splunk, expands the data observability of APISIX, and 
reduces the cost of Splunk users using APISIX as a gateway.
   
   ### Name
   
   - splunk-hec-logging
   
   ### Configuration
   
   ```json
   {
   "endpoint":{
   "uri":"https://hec-splunk.company.com/services/collector;,
   "token":"BD274822-96AA-4DA6-90EC-18940FB2414C",
   "channel":"FE0ECFAD-13D5-401B-847D-77833BD77131",
   "ssl":true
   },
   "inactive_timeout":10,
   "max_retry_count":0,
   "buffer_duration":60,
   "retry_delay":1,
   "batch_max_size":1
   }
   ```
   
   - `endpoint`Splunk HTTP Event Collector(HEC) endpoint
   - `endpoint.uri`Splunk HTTP Event Collector(HEC) endpoint request uri
   - `endpoint.token`  Splunk HTTP Event Collector(HEC) endpoint request 
access token [2]
   - `endpoint.channel`Splunk HTTP Event Collector(HEC) endpoint channel 
identifier (GUID) [3]
   - `endpoint.ssl`Enable SSL Verify
   - `max_retry_count` max number of retries before removing from the 
processing pipe line
   - `retry_delay` number of seconds the process execution should be 
delayed if the execution fails
   - `buffer_duration` max age in seconds of the oldest entry in a batch 
before the batch must be processed
   - `inactive_timeout`max age in seconds when the buffer will be flushed 
if inactive
   - `batch_max_size`  max size of each batch
   
   ### Details
   
    Configuration process
   
   1. Add and set up the Http Event Controller (HEC) through the Splunk console 
and get the access token.
   2. If HEC enable the indexer to confirm, you must specify a channel and 
obtain the channel ID.
   3. Set the request URI, access token, and channel ID of HEC to the plugin 
configuration
   
    HTTP Request process
   
   1. Obtain and assemble request information data in the APISIX Log stage, 
data format refer to [4]
   2. Add the assembled request data to the batch queue
   3. When the threshold of the batch queue is triggered, the requested data is 
submitted in batches to Splunk's HEC
   
   [1] https://db-engines.com/en/ranking/search+engine
   [2] 
https://docs.splunk.com/Documentation/Splunk/latest/Data/UsetheHTTPEventCollector#Create_an_Event_Collector_token_on_Splunk_Enterprise
   [3] 
https://docs.splunk.com/Documentation/Splunk/latest/Data/AboutHECIDXAck#About_channels_and_sending_data
   [4] 
https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] yzeng25 commented on a change in pull request #776: docs: add contribution guidelines

2021-11-28 Thread GitBox



yzeng25 commented on a change in pull request #776:
URL: https://github.com/apache/apisix-website/pull/776#discussion_r758082999



##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide
+
+## Overview
+
+Welcome to Apache APISIX's website and blog repository.
+
+This guideline will teach you how to contribute if you want to add a new blog, 
or modify existing blog contents.
+
+If you find an issue on current documents, please feel free to file an issue 
to let the community know about it, or you can sumbit a pull request to fix or 
update. Both actions are welcome and recommended.
+
+The blogs are written in two languages: English and Chinese. We encourage 
contributors to add blogs in their preferred language. It is completely up to 
you. We can handle translations and ask you to do a pull request review later.
+
+English blogs are located in the `website/blog` directory, in which they are 
categorized by year, month and date. For example, 
`website/blog/2021/11/22/develop-apisix-ingress-with-nocalhost-in-kubernetes.md`
 means that a blog named 
`develop-apisix-ingress-with-nocalhost-in-kubernetes.md` was published on 
November 22nd, 2021, and it is located in the `website/blog/2021/11/22 
directory`.
+
+Similarly, Chinese blogs are located in 
`website/i18n/zh/docusaurus-plugin-content-blog` directory and follow the same 
rules described above.
+
+## What you can contribute
+
+### Add a new blog
+
+To add a new blog, please perform the following steps:
+
+1. Find the right place to store your blog.
+1. If you plan to submit a blog written in English, please create a 
markdown file under `website/blog` directory.
+2. If you plan to submit a blog written in Chinese, please create a 
markdown file under `website/i18n/zh/docusaurus-plugin-content-blog` directory.
+3. If you cannot find an existing year, month, or date directory that fits 
your desired published date, you can go ahead and create such directory on your 
own.
+
+2. Create a markdown file in the directory. Please make sure that the file 
name is written in English with **no** capitalized letters. During review 
session, we may suggest changing it to achieve better SEO performance. (Yes, 
currently some files names contain capitalized letters, we are working on it, 
see https://github.com/apache/apisix-website/issues/713)
+
+3. Add text, images, diagrams, charts to the markdown file.
+1. There is nothing much to say about adding text.
+2. To add images, please upload images to https://markdown.apiseven.com/#/ 
, and copy the links from there.
+3. To add charts or diagrams, we are happy to see any sort of charts and 
diagrams, as long as it formats correctly on the page. From previous 
experience, charts with 4 columns or less are the perfect size displayed on 
screen.
+
+4. Optional: run locally to inspect any typos or formatting issues left 
behind. Although we implemented lint and error checks in the repository, we 
suggest running it locally to avoid repeated work. To run it locally, please 
run `cd website`, and then run `yarn start` commands in your terminal.
+
+5. Submit a pull request to our repository.
+
+ Blog's header information
+
+Our blogs start with a header like this:
+
+```
+title: "blog's title"
+author: "blog's author"
+authorURL: "author's GitHub ID"
+authorImageURL: "author's GitHub Image"
+keywords:
+- keywords 1
+- keywords 2
+- keywords 3
+- keywords 4
+- keywords 5
+description: description of this blog
+tags: [tag1]
+```
+
+# title
+
+Required field, the title of the article, the standard expression in the form 
of `title: "title"`, although the actual test single quotation marks or no 
quotation marks can be, but in order to maintain the standard, the unified use 
of English double quotation marks to wrap the text.
+
+# author
+
+Required field, the article's author name, the standard form of expression for 
author: "author", although the actual test single quotation marks or no 
quotation marks can be, but in order to maintain the standard, the unified use 
of English double quotation marks to wrap the text.
+
+1. community author: if you are willing to provide your real name, use your 
real name, if not, use your GitHub account name.
+
+2. business case authors: real names, such as John Doe.
+
+# authorURL
+
+For business users or business cases, you can leave this item blank. Because 
GitHub is personal, and in the case of a business case, the person represents 
his company rather than himself, it is recommended that you leave this blank to 
avoid unnecessary controversy. This does not mean leave `authorURL`: blank, it 
means just delete the entire line that corresponds to it, including the 
variable name.
+
+# authorImageURL
+
+The author's GitHub avatar, it is related with `authorURL`. For the same 
reason described  above, this is an optional field. See below for how to get 
the avatar.
+
+# keywords
+
+Required

[GitHub] [apisix-website] yzeng25 commented on a change in pull request #776: docs: add contribution guidelines

2021-11-28 Thread GitBox



yzeng25 commented on a change in pull request #776:
URL: https://github.com/apache/apisix-website/pull/776#discussion_r758064397



##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide

Review comment:
Ok I will move this document under `website/docs/general` and update 
`sidebars.json` accordingly.

##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide
+
+## Overview
+
+Welcome to Apache APISIX's website and blog repository.
+
+This guideline will teach you how to contribute if you want to add a new blog, 
or modify existing blog contents.
+
+If you find an issue on current documents, please feel free to file an issue 
to let the community know about it, or you can sumbit a pull request to fix or 
update. Both actions are welcome and recommended.
+
+The blogs are written in two languages: English and Chinese. We encourage 
contributors to add blogs in their preferred language. It is completely up to 
you. We can handle translations and ask you to do a pull request review later.
+
+English blogs are located in the `website/blog` directory, in which they are 
categorized by year, month and date. For example, 
`website/blog/2021/11/22/develop-apisix-ingress-with-nocalhost-in-kubernetes.md`
 means that a blog named 
`develop-apisix-ingress-with-nocalhost-in-kubernetes.md` was published on 
November 22nd, 2021, and it is located in the `website/blog/2021/11/22 
directory`.
+
+Similarly, Chinese blogs are located in 
`website/i18n/zh/docusaurus-plugin-content-blog` directory and follow the same 
rules described above.
+
+## What you can contribute
+
+### Add a new blog

Review comment:
   Yes, descriptions are added.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander opened a new pull request #5635: refactor: exact APISIX vars

2021-11-28 Thread GitBox



spacewander opened a new pull request #5635:
URL: https://github.com/apache/apisix/pull/5635


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] GhangZh commented on issue #767: request help: ingress forward auth

2021-11-28 Thread GitBox



GhangZh commented on issue #767:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/767#issuecomment-981330167


   > > > Hi,
   > > > These annotations are not parsed by APISIX Ingress Controller, and 
what's more, the underlying APISIX doesn't support the forward auth feature.
   > > > It seems that we have some issues in APISIX repo with the related 
topic [apache/apisix#5475](https://github.com/apache/apisix/issues/5475).
   > > > Thanks，So if I do an http request forwarding to my forwoard auth 
service by customizing a plugin, it will be fine, right?
   > 
   > That's right, you can implement a custom plugin to support it, but it 
would better if you'd like to design a generic solution and send a proposal to 
the mailing list ([d...@apisix.apache.org](mailto:d...@apisix.apache.org)), 
then others can also use it if they desire.
   
   I would like to implement a custom plugin to support it , but I found that I 
can use severless plugin for custom authentication , But I see the serverless 
plugin documentation is only written as a function, I want to write an http 
proxy in it, this plug-in can support it？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] GhangZh removed a comment on issue #767: request help: ingress forward auth

2021-11-28 Thread GitBox



GhangZh removed a comment on issue #767:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/767#issuecomment-981292526


   > 
   I would like to implement a custom plugin to support it , but I found that I 
can use severless  plugin for custom  authentication , But I see the serverless 
plugin documentation is only written as a function, I want to write an http 
proxy in it, this plug-in can support it？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #5634: request help: support get the key from function in limit-* plugins

2021-11-28 Thread GitBox



spacewander commented on issue #5634:
URL: https://github.com/apache/apisix/issues/5634#issuecomment-981329670


   What about allowing user to register their var in 
https://github.com/apache/apisix/blob/8f0b066c86257ad6af19f9b3b7e209ece95d17c9/apisix/core/ctx.lua#L147?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #5616: feat: faas plugin refactoring with url path forwarding

2021-11-28 Thread GitBox



spacewander merged pull request #5616:
URL: https://github.com/apache/apisix/pull/5616


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: feat: faas plugin refactoring with url path forwarding (#5616)

2021-11-28 Thread spacewander

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 8f0b066  feat: faas plugin refactoring with url path forwarding (#5616)
8f0b066 is described below

commit 8f0b066c86257ad6af19f9b3b7e209ece95d17c9
Author: Bisakh 
AuthorDate: Mon Nov 29 11:58:49 2021 +0530

feat: faas plugin refactoring with url path forwarding (#5616)
---
 apisix/plugins/azure-functions.lua |  98 ++
 apisix/plugins/serverless/generic-upstream.lua | 135 +
 t/plugin/azure-functions.t | 115 +
 3 files changed, 261 insertions(+), 87 deletions(-)

diff --git a/apisix/plugins/azure-functions.lua 
b/apisix/plugins/azure-functions.lua
index 1597f2a..0b0e64d 100644
--- a/apisix/plugins/azure-functions.lua
+++ b/apisix/plugins/azure-functions.lua
@@ -14,30 +14,15 @@
 -- See the License for the specific language governing permissions and
 -- limitations under the License.
 
-local core = require("apisix.core")
-local http = require("resty.http")
 local plugin = require("apisix.plugin")
-local ngx  = ngx
-local plugin_name = "azure-functions"
+local plugin_name, plugin_version, priority = "azure-functions", 0.1, -1900
 
-local schema = {
+local azure_authz_schema = {
 type = "object",
 properties = {
-function_uri = {type = "string"},
-authorization = {
-type = "object",
-properties = {
-apikey = {type = "string"},
-clientid = {type = "string"}
-}
-},
-timeout = {type = "integer", minimum = 100, default = 3000},
-ssl_verify = {type = "boolean", default = true},
-keepalive = {type = "boolean", default = true},
-keepalive_timeout = {type = "integer", minimum = 1000, default = 
6},
-keepalive_pool = {type = "integer", minimum = 1, default = 5}
-},
-required = {"function_uri"}
+apikey = {type = "string"},
+clientid = {type = "string"}
+}
 }
 
 local metadata_schema = {
@@ -48,31 +33,8 @@ local metadata_schema = {
 }
 }
 
-local _M = {
-version = 0.1,
-priority = -1900,
-name = plugin_name,
-schema = schema,
-metadata_schema = metadata_schema
-}
-
-function _M.check_schema(conf, schema_type)
-if schema_type == core.schema.TYPE_METADATA then
-return core.schema.check(metadata_schema, conf)
-end
-return core.schema.check(schema, conf)
-end
-
-function _M.access(conf, ctx)
-local uri_args = core.request.get_uri_args(ctx)
-local headers = core.request.headers(ctx) or {}
-local req_body, err = core.request.get_body()
-
-if err then
-core.log.error("error while reading request body: ", err)
-return 400
-end
-
+local function request_processor(conf, ctx, params)
+local headers = params.headers or {}
 -- set authorization headers if not already set by the client
 -- we are following not to overwrite the authz keys
 if not headers["x-functions-key"] and
@@ -91,47 +53,9 @@ function _M.access(conf, ctx)
 end
 end
 
-headers["host"] = nil
-local params = {
-method = ngx.req.get_method(),
-body = req_body,
-query = uri_args,
-headers = headers,
-keepalive = conf.keepalive,
-ssl_verify = conf.ssl_verify
-}
-
--- Keepalive options
-if conf.keepalive then
-params.keepalive_timeout = conf.keepalive_timeout
-params.keepalive_pool = conf.keepalive_pool
-end
-
-local httpc = http.new()
-httpc:set_timeout(conf.timeout)
-
-local res, err = httpc:request_uri(conf.function_uri, params)
-
-if not res or err then
-core.log.error("failed to process azure function, err: ", err)
-return 503
-end
-
--- According to RFC7540 
https://datatracker.ietf.org/doc/html/rfc7540#section-8.1.2.2, endpoint
--- must not generate any connection specific headers for HTTP/2 requests.
-local response_headers = res.headers
-if ngx.var.http2 then
-response_headers["Connection"] = nil
-response_headers["Keep-Alive"] = nil
-response_headers["Proxy-Connection"] = nil
-response_headers["Upgrade"] = nil
-response_headers["Transfer-Encoding"] = nil
-end
-
--- setting response headers
-core.response.set_header(response_headers)
-
-return res.status, res.body
+params.headers = headers
 end
 
-return _M
+
+return require("apisix.plugins.serverless.generic-upstream")(plugin_name,
+plugin_version, priority, request_processor, azure_authz_schema, 
metadata_schema)
diff --git a/apisix/plugins/serverless/generic-upstream.lua 
b/apisix/plugins/serverless/generic-upstream.lua
new file mode 100644
index 000..0ae59b6
--- /dev/null
+++

[GitHub] [apisix] starsz opened a new issue #5634: request help: support get the key from function in limit-* plugins

2021-11-28 Thread GitBox



starsz opened a new issue #5634:
URL: https://github.com/apache/apisix/issues/5634


   ### Issue description
   
   Hi, 
   Now, I see we had support `var`, `var_combination` in apisix limit-* plugins 
yet.
   I think we can support a type like `function` so that we can write some 
logic as a function in the key.
   Then we can get the key by the function.
   
   
   
   ### Environment
   
   - apisix version (cmd: `apisix version`): 2.10.2
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] dongyudan opened a new issue #5633: bug: enable skywalking plugin , the route rewrite is not affected

2021-11-28 Thread GitBox



dongyudan opened a new issue #5633:
URL: https://github.com/apache/apisix/issues/5633


   ### Issue description
   
   **1、route instance properties**
   {
 "uri": "/sk2/hello",
 "name": "test skywalking",
 "methods": [
   "GET",
   "POST",
   "PUT",
   "DELETE",
   "PATCH",
   "HEAD",
   "OPTIONS",
   "CONNECT",
   "TRACE"
 ],
 "host": "192.168.42.104",
 "plugins": {
   "proxy-rewrite": {
 "uri": "/hello"
   },
   "skywalking": {
 "disable": false,
 "sample_ratio": 1
   }
 },
 "upstream_id": "382869453731268977",
 "status": 1
   }
   
   **2、apisix config** 
   apisix:
 admin_key:
   - name: admin
 key: edd1c9f034335f136f87ad84b625c8f1  # using fixed API token has 
security risk, please update it when you deploy to production environment
 role: admin
   plugins:
   - skywalking
   plugin_attr:
 skywalking:
   service_name: Dane
   service_instance_name: "Dane Instance Name"
   endpoint_addr: http://127.0.0.1:12800
   report_interval: 10
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):2.10.2
   - OS (cmd: `uname -a`):centos7
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:2.9
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   
   
   ### Steps to reproduce
   
   
   
![image](https://user-images.githubusercontent.com/11826929/143817162-392b49fc-066b-4d54-8172-de6ef05caecb.png)
   add new route, config static rewrite url "/hello"
   1、Open “skywalking”  plugin in the dashboard
   2、Test route  url  http://192.168.42.104:9080/sky/hello
   3、Return the  error message " There was an unexpected error (type=Not Found, 
status=404)"，
   4、Debug up-stream service，found request url  is not rewrite still  is 
"/sky/hello"
   5、Disable “skywalking‘’ plugin  in the dashboard
   6、Retest route  url  http://192.168.42.104:9080/sky/hello
   7、Return the right data
   
   ### Actual result
   
   Route url the same as up stream service node url ，rewrite never happened
   
   ### Error log
   
   Whitelabel Error Page
   This application has no explicit mapping for /error, so you are seeing this 
as a fallback.
   
   Mon Nov 29 11:27:26 CST 2021
   There was an unexpected error (type=Not Found, status=404).
   No message available
   
   ### Expected result
   
   url  is rewrite to "/hello",return the right message .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #5425: request help: How to best handle oidc providers that do not support introspection endpoints?

2021-11-28 Thread GitBox



tzssangglass commented on issue #5425:
URL: https://github.com/apache/apisix/issues/5425#issuecomment-981321037


   It sounds different. This issue is about using  jwks with openid-connect to 
authenticate a JWT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] shuaijinchao edited a comment on issue #5474: proposal: support google cloud logging service plugin

2021-11-28 Thread GitBox



shuaijinchao edited a comment on issue #5474:
URL: https://github.com/apache/apisix/issues/5474#issuecomment-965962436


   Name
    
   plugin name is: `google-cloud-logging`
   
   Configuration
   
   
   ```json
   {
   "inactive_timeout":10,
   "max_retry_count":0,
   "buffer_duration":60,
   "resource":{
   "type":"global"
   },
   "log_id":"syslog",
   "auth_config":{
   "private_key":"-BEGIN RSA PRIVATE KEY-KEY-END RSA 
PRIVATE KEY-",
   "token_uri":"http://127.0.0.1:1980/google/logging/token;,
   "scopes":[
   "https://apisix.apache.org/logs:admin;
   ],
   "entries_uri":"http://127.0.0.1:1980/google/logging/entries;,
   "project_id":"apisix"
   },
   "retry_delay":1,
   "batch_max_size":1
   }
   ```
   
   - `auth_config`  the google service account 
config（Semi-optional, one of `auth_config` or `auth_file` must be configured）
   - `auth_config.private_key`  the private key parameters of the Google 
service account
   - `auth_config.project_id`the project id parameters of the Google 
service account
   - `auth_config.token_uri`the token uri parameters of the Google service 
account
   - `auth_config.scopes` the access scopes parameters of the Google service 
account,  refer to: 
https://developers.google.com/identity/protocols/oauth2/scopes#logging
   - `auth_config.entries_uri` google logging service  API
   - `auth_file`path to the google service account json 
file（Semi-optional, one of `auth_config` or `auth_file` must be configured）
   - `resource`the Google monitor resource, refer to: 
https://cloud.google.com/logging/docs/reference/v2/rest/v2/MonitoredResource
   - `log_id`  google logging id, refer to: 
https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry
   - `max_retry_count` max number of retries before removing from the 
processing pipe line
   - `retry_delay` number of seconds the process execution should be delayed if 
the execution fails
   - `buffer_duration` max age in seconds of the oldest entry in a batch before 
the batch must be processed
   - `inactive_timeout` max age in seconds when the buffer will be flushed if 
inactive
   - `batch_max_size`  max size of each batch
   
   
   Details
   
   
   1. Obtain and assemble request information in the APISIX Log phase
   2. To interact with google logging service for the first time, you need to 
request token information. After obtaining the token, it will be cached in the 
memory of the working node.
   3. After obtaining a valid token, put the request information into the batch 
processing queue. When the batch processing queue triggers the batch_max_size 
or batch_timeout threshold, the data in the queue is synchronized to the google 
cloud logging service
   4. Before each request is sent, check whether the token is about to time 
out, and refresh the token if it will time out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] arabot777 opened a new issue #91: request help: when reload apisix, the java service will be restarted too, and during this period, it is not available.

2021-11-28 Thread GitBox



arabot777 opened a new issue #91:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/91


   ### Issue description
   when reload apisix, the java service will be reload too, and during this 
period, apisix is not available（return 503）.
   Is there a better solution? running java service in debugger?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] webup commented on a change in pull request #183: feat(apisix): add service monitor support

2021-11-28 Thread GitBox



webup commented on a change in pull request #183:
URL: https://github.com/apache/apisix-helm-chart/pull/183#discussion_r758051260



##
File path: charts/apisix/templates/configmap.yaml
##
@@ -226,6 +226,13 @@ data:
 
 {{- if .Values.customPlugins.enabled }}
 plugin_attr:
+  {{- if .Values.serviceMonitor.enabled }}
+  prometheus:
+export_addr:
+  ip: 0.0.0.0

Review comment:
   So how shall we expose metrics from APISIX gateway, any better approach?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] tag 2.11.0 created (now a694c4d)

2021-11-28 Thread sunyi

This is an automated email from the ASF dual-hosted git repository.

sunyi pushed a change to tag 2.11.0
in repository https://gitbox.apache.org/repos/asf/apisix.git.


  at a694c4d  (commit)
No new revisions were added by this update.

[GitHub] [apisix-ingress-controller] GhangZh commented on issue #767: request help: ingress forward auth

2021-11-28 Thread GitBox



GhangZh commented on issue #767:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/767#issuecomment-981292526


   > 
   I would like to implement a custom plugin to support it , but I found that I 
can use severless  plugin for custom  authentication , But I see the serverless 
plugin documentation is only written as a function, I want to write an http 
proxy in it, this plug-in can support it？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #5607: bug: traffic-split err

2021-11-28 Thread GitBox



tzssangglass commented on issue #5607:
URL: https://github.com/apache/apisix/issues/5607#issuecomment-981287621


   the upstream is `382981255605519758` looks strange, what have you done 
anything with this upstream?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #5607: bug: traffic-split err

2021-11-28 Thread GitBox



tzssangglass commented on issue #5607:
URL: https://github.com/apache/apisix/issues/5607#issuecomment-981285991


   is your upstream `382981468860712334 ` or `382981255605519758 ` exist?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #5607: bug: traffic-split err

2021-11-28 Thread GitBox



tzssangglass commented on issue #5607:
URL: https://github.com/apache/apisix/issues/5607#issuecomment-981285251


   I cannot reproduce your error on the master branch, here are the steps I 
took to reproduce it
   
   1. add upstream
   
   ```shell
   curl --location --request PUT 
'http://127.0.0.1:9080/apisix/admin/upstreams/100' \
   --header 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' \
   --header 'Content-Type: application/json' \
   --data-raw '{
   "type":"roundrobin",
   "nodes":{
   "httpbin.org:80": 1
   }
   }'
   ```
   
   2. add route
   
   ```shell
   curl --location --request PUT 'http://127.0.0.1:9080/apisix/admin/routes/1' \
   --header 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' \
   --header 'Content-Type: application/json' \
   --data-raw '{
   "plugins": {
   "traffic-split": {
   "rules": [
   {
   "match": [
   {
   "vars": [
   [
   "http_release",
   "==",
   "new_release"
   ]
   ]
   }
   ],
   "weighted_upstreams": [
   {
   "upstream_id": "100",
   "weight": 2
   },
   {
   "weight": 1
   }
   ]
   }
   ]
   }
   },
   "upstream": {
   "nodes": {
   "127.0.0.1:1980": 1
   },
   "type": "roundrobin"
   },
   "uri": "/*"
   }'
   ```
   
   3. my backend 1980 is 
https://github.com/apache/apisix/blob/master/benchmark/server/conf/nginx.conf
   
   4. test
   
   ```
   curl http://127.0.0.1:9080/get -H 'release: new_release'
   ```
   
   5. no `attempt to index field 'upstream' (a string value) `in 
`logs/error.log`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #776: docs: add contribution guidelines

2021-11-28 Thread GitBox



juzhiyuan commented on a change in pull request #776:
URL: https://github.com/apache/apisix-website/pull/776#discussion_r758026372



##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide
+
+## Overview
+
+Welcome to Apache APISIX's website and blog repository.
+
+This guideline will teach you how to contribute if you want to add a new blog, 
or modify existing blog contents.
+
+If you find an issue on current documents, please feel free to file an issue 
to let the community know about it, or you can sumbit a pull request to fix or 
update. Both actions are welcome and recommended.
+
+The blogs are written in two languages: English and Chinese. We encourage 
contributors to add blogs in their preferred language. It is completely up to 
you. We can handle translations and ask you to do a pull request review later.
+
+English blogs are located in the `website/blog` directory, in which they are 
categorized by year, month and date. For example, 
`website/blog/2021/11/22/develop-apisix-ingress-with-nocalhost-in-kubernetes.md`
 means that a blog named 
`develop-apisix-ingress-with-nocalhost-in-kubernetes.md` was published on 
November 22nd, 2021, and it is located in the `website/blog/2021/11/22 
directory`.
+
+Similarly, Chinese blogs are located in 
`website/i18n/zh/docusaurus-plugin-content-blog` directory and follow the same 
rules described above.
+
+## What you can contribute
+
+### Add a new blog
+
+To add a new blog, please perform the following steps:
+
+1. Find the right place to store your blog.
+1. If you plan to submit a blog written in English, please create a 
markdown file under `website/blog` directory.
+2. If you plan to submit a blog written in Chinese, please create a 
markdown file under `website/i18n/zh/docusaurus-plugin-content-blog` directory.
+3. If you cannot find an existing year, month, or date directory that fits 
your desired published date, you can go ahead and create such directory on your 
own.
+
+2. Create a markdown file in the directory. Please make sure that the file 
name is written in English with **no** capitalized letters. During review 
session, we may suggest changing it to achieve better SEO performance. (Yes, 
currently some files names contain capitalized letters, we are working on it, 
see https://github.com/apache/apisix-website/issues/713)
+
+3. Add text, images, diagrams, charts to the markdown file.
+1. There is nothing much to say about adding text.
+2. To add images, please upload images to https://markdown.apiseven.com/#/ 
, and copy the links from there.
+3. To add charts or diagrams, we are happy to see any sort of charts and 
diagrams, as long as it formats correctly on the page. From previous 
experience, charts with 4 columns or less are the perfect size displayed on 
screen.
+
+4. Optional: run locally to inspect any typos or formatting issues left 
behind. Although we implemented lint and error checks in the repository, we 
suggest running it locally to avoid repeated work. To run it locally, please 
run `cd website`, and then run `yarn start` commands in your terminal.
+
+5. Submit a pull request to our repository.
+
+ Blog's header information
+
+Our blogs start with a header like this:
+
+```
+title: "blog's title"
+author: "blog's author"
+authorURL: "author's GitHub ID"
+authorImageURL: "author's GitHub Image"
+keywords:
+- keywords 1
+- keywords 2
+- keywords 3
+- keywords 4
+- keywords 5
+description: description of this blog
+tags: [tag1]
+```
+
+# title
+
+Required field, the title of the article, the standard expression in the form 
of `title: "title"`, although the actual test single quotation marks or no 
quotation marks can be, but in order to maintain the standard, the unified use 
of English double quotation marks to wrap the text.
+
+# author
+
+Required field, the article's author name, the standard form of expression for 
author: "author", although the actual test single quotation marks or no 
quotation marks can be, but in order to maintain the standard, the unified use 
of English double quotation marks to wrap the text.
+
+1. community author: if you are willing to provide your real name, use your 
real name, if not, use your GitHub account name.
+
+2. business case authors: real names, such as John Doe.
+
+# authorURL
+
+For business users or business cases, you can leave this item blank. Because 
GitHub is personal, and in the case of a business case, the person represents 
his company rather than himself, it is recommended that you leave this blank to 
avoid unnecessary controversy. This does not mean leave `authorURL`: blank, it 
means just delete the entire line that corresponds to it, including the 
variable name.
+
+# authorImageURL
+
+The author's GitHub avatar, it is related with `authorURL`. For the same 
reason described  above, this is an optional field. See below for how to get 
the avatar.
+
+# keywords
+

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #776: docs: add contribution guidelines

2021-11-28 Thread GitBox



juzhiyuan commented on a change in pull request #776:
URL: https://github.com/apache/apisix-website/pull/776#discussion_r758026293



##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide
+
+## Overview
+
+Welcome to Apache APISIX's website and blog repository.
+
+This guideline will teach you how to contribute if you want to add a new blog, 
or modify existing blog contents.
+
+If you find an issue on current documents, please feel free to file an issue 
to let the community know about it, or you can sumbit a pull request to fix or 
update. Both actions are welcome and recommended.
+
+The blogs are written in two languages: English and Chinese. We encourage 
contributors to add blogs in their preferred language. It is completely up to 
you. We can handle translations and ask you to do a pull request review later.
+
+English blogs are located in the `website/blog` directory, in which they are 
categorized by year, month and date. For example, 
`website/blog/2021/11/22/develop-apisix-ingress-with-nocalhost-in-kubernetes.md`
 means that a blog named 
`develop-apisix-ingress-with-nocalhost-in-kubernetes.md` was published on 
November 22nd, 2021, and it is located in the `website/blog/2021/11/22 
directory`.
+
+Similarly, Chinese blogs are located in 
`website/i18n/zh/docusaurus-plugin-content-blog` directory and follow the same 
rules described above.
+
+## What you can contribute
+
+### Add a new blog

Review comment:
   Do we have some descriptions about what post/blog we will receive?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #776: docs: add contribution guidelines

2021-11-28 Thread GitBox



juzhiyuan commented on a change in pull request #776:
URL: https://github.com/apache/apisix-website/pull/776#discussion_r758026080



##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide

Review comment:
   The comment above is optional, contents and workflow in this guide is 
more important.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #776: docs: add contribution guidelines

2021-11-28 Thread GitBox



juzhiyuan commented on a change in pull request #776:
URL: https://github.com/apache/apisix-website/pull/776#discussion_r758025957



##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide

Review comment:
   How about putting this guide under the Community section? We have a 
related page here: 
   
   https://apisix.apache.org/docs/general/community/
   
    If we put this file under the repo directly, users have to read docs from 
markdown file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2202: test: migrate global rule e2e

2021-11-28 Thread GitBox



juzhiyuan merged pull request #2202:
URL: https://github.com/apache/apisix-dashboard/pull/2202


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: test: migrate global rule e2e (#2202)

2021-11-28 Thread juzhiyuan

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new a555684  test: migrate global rule e2e (#2202)
a555684 is described below

commit a55568408cec5eb2628971d2098a9bef992ff548
Author: Zeping Bai 
AuthorDate: Mon Nov 29 12:02:55 2021 +0800

test: migrate global rule e2e (#2202)
---
 api/test/e2e/global_rule_test.go   | 403 -
 .../e2enew/global_rule/global_rule_suite_test.go   |  38 ++
 api/test/e2enew/global_rule/global_rule_test.go| 201 ++
 3 files changed, 239 insertions(+), 403 deletions(-)

diff --git a/api/test/e2e/global_rule_test.go b/api/test/e2e/global_rule_test.go
deleted file mode 100644
index 41dbbb7..000
--- a/api/test/e2e/global_rule_test.go
+++ /dev/null
@@ -1,403 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
-   "io/ioutil"
-   "net/http"
-   "testing"
-   "time"
-
-   "github.com/stretchr/testify/assert"
-   "github.com/tidwall/gjson"
-)
-
-func TestGlobalRule(t *testing.T) {
-   tests := []HttpTestCase{
-   {
-   Desc: "make sure the route doesn't exist",
-   Object:   APISIXExpect(t),
-   Method:   http.MethodGet,
-   Path: "/hello",
-   ExpectStatus: http.StatusNotFound,
-   ExpectBody:   `{"error_msg":"404 Route Not Found"}`,
-   },
-   {
-   Desc:   "create route",
-   Object: ManagerApiExpect(t),
-   Method: http.MethodPut,
-   Path:   "/apisix/admin/routes/r1",
-   Body: `{
-   "name": "route1",
-"uri": "/hello",
-"upstream": {
-"type": "roundrobin",
-   "nodes": [{
-   "host": "` + UpstreamIp + `",
-   "port": 1981,
-   "weight": 1
-   }]
-}
-}`,
-   Headers:  map[string]string{"Authorization": token},
-   ExpectStatus: http.StatusOK,
-   },
-   {
-   Desc:   "create global rule",
-   Object: ManagerApiExpect(t),
-   Path:   "/apisix/admin/global_rules/1",
-   Method: http.MethodPut,
-   Body: `{
-"plugins": {
-   "response-rewrite": {
-   "headers": {
-   "X-VERSION":"1.0"
-   }
-   },
-   "uri-blocker": {
-   "block_rules": 
["select.+(from|limit)", "(?:(union(.*?)select))"]
-   }
-}
-}`,
-   Headers:  map[string]string{"Authorization": token},
-   ExpectStatus: http.StatusOK,
-   ExpectBody:   "\"X-VERSION\":\"1.0\"",
-   },
-   {
-   Desc:  "verify route with header",
-   Object:APISIXExpect(t),
-   Method:http.MethodGet,
-   Path:  "/hello",
-   ExpectStatus:  http.StatusOK,
-   ExpectBody:"hello world",
-   ExpectHeaders: map[string]string{"X-VERSION": "1.0"},
-   Sleep: sleepTime,
-

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



juzhiyuan merged pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: ci: clean up the E2E test environment (#2225)

2021-11-28 Thread juzhiyuan

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 9578937  ci: clean up the E2E test environment (#2225)
9578937 is described below

commit 95789376a33b645cf0ed8718796ada77da6e8552
Author: Zeping Bai 
AuthorDate: Mon Nov 29 12:02:04 2021 +0800

ci: clean up the E2E test environment (#2225)
---
 api/test/docker/docker-compose.yaml | 143 ++--
 api/test/docker/upstream.conf   |  55 +++---
 2 files changed, 100 insertions(+), 98 deletions(-)

diff --git a/api/test/docker/docker-compose.yaml 
b/api/test/docker/docker-compose.yaml
index 8403efc..7473e69 100644
--- a/api/test/docker/docker-compose.yaml
+++ b/api/test/docker/docker-compose.yaml
@@ -17,8 +17,19 @@
 version: "3.6"
 
 services:
-  node1:
-image: gcr.io/etcd-development/etcd:v3.4.0
+  etcd1:
+image: bitnami/etcd:3.5.1
+environment:
+  - ALLOW_NONE_AUTHENTICATION=yes
+  - ETCD_DATA_DIR=/etcd-data
+  - ETCD_NAME=etcd1
+  - ETCD_INITIAL_ADVERTISE_PEER_URLS=http://172.16.238.10:2380
+  - ETCD_LISTEN_PEER_URLS=http://0.0.0.0:2380
+  - ETCD_ADVERTISE_CLIENT_URLS=http://172.16.238.10:2379
+  - ETCD_LISTEN_CLIENT_URLS=http://0.0.0.0:2379
+  - 
ETCD_INITIAL_CLUSTER=etcd1=http://172.16.238.10:2380,etcd2=http://172.16.238.11:2380,etcd3=http://172.16.238.12:2380
+  - ETCD_INITIAL_CLUSTER_STATE=new
+  - ETCD_INITIAL_CLUSTER_TOKEN=docker-etcd
 ports:
   - "2379:2379"
 expose:
@@ -27,93 +38,52 @@ services:
 networks:
   apisix_dashboard_e2e:
 ipv4_address: 172.16.238.10
-environment:
-  - ETCDCTL_API=3
-command:
-  - /usr/local/bin/etcd
-  - --data-dir=/etcd-data
-  - --name
-  - node1
-  - --initial-advertise-peer-urls
-  - http://172.16.238.10:2380
-  - --listen-peer-urls
-  - http://0.0.0.0:2380
-  - --advertise-client-urls
-  - http://172.16.238.10:2379
-  - --listen-client-urls
-  - http://0.0.0.0:2379
-  - --initial-cluster
-  - 
node1=http://172.16.238.10:2380,node2=http://172.16.238.11:2380,node3=http://172.16.238.12:2380
-  - --initial-cluster-state
-  - new
-  - --initial-cluster-token
-  - docker-etcd
 
-  node2:
-image: gcr.io/etcd-development/etcd:v3.4.0
-networks:
-  apisix_dashboard_e2e:
-ipv4_address: 172.16.238.11
+  etcd2:
+image: bitnami/etcd:3.5.1
 environment:
-  - ETCDCTL_API=3
+  - ALLOW_NONE_AUTHENTICATION=yes
+  - ETCD_DATA_DIR=/etcd-data
+  - ETCD_NAME=etcd2
+  - ETCD_INITIAL_ADVERTISE_PEER_URLS=http://172.16.238.11:2380
+  - ETCD_LISTEN_PEER_URLS=http://0.0.0.0:2380
+  - ETCD_ADVERTISE_CLIENT_URLS=http://172.16.238.11:2379
+  - ETCD_LISTEN_CLIENT_URLS=http://0.0.0.0:2379
+  - 
ETCD_INITIAL_CLUSTER=etcd1=http://172.16.238.10:2380,etcd2=http://172.16.238.11:2380,etcd3=http://172.16.238.12:2380
+  - ETCD_INITIAL_CLUSTER_STATE=new
+  - ETCD_INITIAL_CLUSTER_TOKEN=docker-etcd
 expose:
   - 2379
   - 2380
-command:
-  - /usr/local/bin/etcd
-  - --data-dir=/etcd-data
-  - --name
-  - node2
-  - --initial-advertise-peer-urls
-  - http://172.16.238.11:2380
-  - --listen-peer-urls
-  - http://0.0.0.0:2380
-  - --advertise-client-urls
-  - http://172.16.238.11:2379
-  - --listen-client-urls
-  - http://0.0.0.0:2379
-  - --initial-cluster
-  - 
node1=http://172.16.238.10:2380,node2=http://172.16.238.11:2380,node3=http://172.16.238.12:2380
-  - --initial-cluster-state
-  - new
-  - --initial-cluster-token
-  - docker-etcd
-
-  node3:
-image: gcr.io/etcd-development/etcd:v3.4.0
 networks:
   apisix_dashboard_e2e:
-ipv4_address: 172.16.238.12
+ipv4_address: 172.16.238.11
+
+  etcd3:
+image: bitnami/etcd:3.5.1
 environment:
-  - ETCDCTL_API=3
+  - ALLOW_NONE_AUTHENTICATION=yes
+  - ETCD_DATA_DIR=/etcd-data
+  - ETCD_NAME=etcd3
+  - ETCD_INITIAL_ADVERTISE_PEER_URLS=http://172.16.238.12:2380
+  - ETCD_LISTEN_PEER_URLS=http://0.0.0.0:2380
+  - ETCD_ADVERTISE_CLIENT_URLS=http://172.16.238.12:2379
+  - ETCD_LISTEN_CLIENT_URLS=http://0.0.0.0:2379
+  - 
ETCD_INITIAL_CLUSTER=etcd1=http://172.16.238.10:2380,etcd2=http://172.16.238.11:2380,etcd3=http://172.16.238.12:2380
+  - ETCD_INITIAL_CLUSTER_STATE=new
+  - ETCD_INITIAL_CLUSTER_TOKEN=docker-etcd
 expose:
   - 2379
   - 2380
-command:
-  - /usr/local/bin/etcd
-  - --data-dir=/etcd-data
-  - --name
-  - node3
-  - --initial-advertise-peer-urls
-  - http://172.16.238.12:2380
-  - --listen-peer-urls
-  - http://0.0.0.0:2380
-  - --advertise-client-urls
-  - http://172.16.238.12:2379
-  -

[apisix] branch master updated: feat: release 2.11.0 (#5567)

2021-11-28 Thread sunyi

This is an automated email from the ASF dual-hosted git repository.

sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 78b3880  feat: release 2.11.0 (#5567)
78b3880 is described below

commit 78b3880a5698f5ee345079aebfbb7711b198a45a
Author: 罗泽轩 
AuthorDate: Mon Nov 29 11:46:48 2021 +0800

feat: release 2.11.0 (#5567)

Signed-off-by: spacewander 
Co-authored-by: litesun <7sunm...@gmail.com>
---
 .asf.yaml |  4 ++
 .github/workflows/build.yml   |  7 ---
 CHANGELOG.md  | 31 +
 apisix/core/version.lua   |  2 +-
 docs/en/latest/config.json|  2 +-
 docs/en/latest/how-to-build.md| 14 +++---
 docs/zh/latest/CHANGELOG.md   | 31 +
 docs/zh/latest/config.json|  2 +-
 docs/zh/latest/how-to-build.md| 14 +++---
 rockspec/apisix-2.11.0-0.rockspec | 96 +++
 10 files changed, 179 insertions(+), 24 deletions(-)

diff --git a/.asf.yaml b/.asf.yaml
index 152a720..0b980d9 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -47,6 +47,10 @@ github:
 required_pull_request_reviews:
   require_code_owner_reviews: true
   required_approving_review_count: 2
+  release/2.11:
+required_pull_request_reviews:
+  require_code_owner_reviews: true
+  required_approving_review_count: 2
   release/2.10:
 required_pull_request_reviews:
   require_code_owner_reviews: true
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 5de3073..825c6dd 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -107,10 +107,3 @@ jobs:
 
   - name: Linux Script
 run: sudo ./ci/${{ matrix.os_name }}_runner.sh script
-
-  - name: Publish Artifact
-if: ${{ startsWith(github.ref, 'refs/heads/release/') && 
matrix.os_name == 'linux_openresty' }}
-uses: actions/upload-artifact@v2.2.4
-with:
-  name: ${{ steps.branch_env.outputs.fullname }}
-  path: ${{ steps.branch_env.outputs.fullname }}
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 752cb0e..dc4f86a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,7 @@ title: Changelog
 
 ## Table of Contents
 
+- [2.11.0](#2110)
 - [2.10.2](#2102)
 - [2.10.1](#2101)
 - [2.10.0](#2100)
@@ -48,6 +49,36 @@ title: Changelog
 - [0.7.0](#070)
 - [0.6.0](#060)
 
+## 2.11.0
+
+### Change
+
+- change(wolf-rbac): change default port number and add `authType` parameter 
to documentation [#5477](https://github.com/apache/apisix/pull/5477)
+
+### Core
+
+- :sunrise: feat: support advanced matching based on post form 
[#5409](https://github.com/apache/apisix/pull/5409)
+- :sunrise: feat: initial wasm support 
[#5288](https://github.com/apache/apisix/pull/5288)
+- :sunrise: feat(control): expose 
services[#5271](https://github.com/apache/apisix/pull/5271)
+- :sunrise: feat(control): add dump upstream api 
[#5259](https://github.com/apache/apisix/pull/5259)
+- :sunrise: feat: etcd cluster single node failure APISIX startup failure 
[#5158](https://github.com/apache/apisix/pull/5158)
+- :sunrise: feat: support specify custom sni in etcd conf 
[#5206](https://github.com/apache/apisix/pull/5206)
+
+### Plugin
+
+- :sunrise: feat(plugin): azure serverless functions 
[#5479](https://github.com/apache/apisix/pull/5479)
+- :sunrise: feat(kafka-logger): supports logging request body 
[#5501](https://github.com/apache/apisix/pull/5501)
+- :sunrise: feat: provide skywalking logger plugin 
[#5478](https://github.com/apache/apisix/pull/5478)
+- :sunrise: feat(plugins): Datadog for metrics collection 
[#5372](https://github.com/apache/apisix/pull/5372)
+- :sunrise: feat(limit-* plugin):  fallback to remote_addr when key is missing 
[#5422](https://github.com/apache/apisix/pull/5422)
+- :sunrise: feat(limit-count): support multiple variables as key 
[#5378](https://github.com/apache/apisix/pull/5378)
+- :sunrise: feat(limit-conn): support multiple variables as key 
[#5354](https://github.com/apache/apisix/pull/5354)
+- :sunrise: feat(proxy-rewrite): rewrite method 
[#5292](https://github.com/apache/apisix/pull/5292)
+- :sunrise: feat(limit-req): support multiple variables as key 
[#5302](https://github.com/apache/apisix/pull/5302)
+- :sunrise: feat(proxy-cache): support memory-based strategy 
[#5028](https://github.com/apache/apisix/pull/5028)
+- :sunrise: feat(ext-plugin): avoid sending conf request more times 
[#5183](https://github.com/apache/apisix/pull/5183)
+- :sunrise: feat: Add ldap-auth plugin 
[#3894](https://github.com/apache/apisix/pull/3894)
+
 ## 2.10.2
 
 ### Bugfix
diff --git a/apisix/core/version.lua b/apisix/core/version.lua
index 1761fb5..9ac6caa 100644
--- a/apisix/core/version.lua
+++ b/apisix/core/version.lua
@@ -15,5 +15,5 @@
 -- limitations under the License.
 --
 return {
-

[GitHub] [apisix] LiteSun merged pull request #5567: feat: release 2.11.0

2021-11-28 Thread GitBox



LiteSun merged pull request #5567:
URL: https://github.com/apache/apisix/pull/5567


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#issuecomment-980831326


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2225](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (23eb3f2) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ebf381d213a85343a321defd138f51d7f0f74a14?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ebf381d) will **increase** coverage by `1.69%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2225  +/-   ##
   ==
   + Coverage   68.13%   69.83%   +1.69% 
   ==
 Files 127  184  +57 
 Lines3352 7257+3905 
 Branches  824  824  
   ==
   + Hits 2284 5068+2784 
   - Misses   1068 1896 +828 
   - Partials0  293 +293 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.81% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `51.01% <ø> (?)` | |
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `67.95% <ø> (-0.18%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4)
 | `66.86% <0.00%> (-3.49%)` | :arrow_down: |
   | 
[api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv)
 | `75.00% <0.00%> (ø)` | |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `56.00% <0.00%> (ø)` | |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `79.31% <0.00%> (ø)` | |
   | 
[api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==)
 | `61.70% <0.00%> (ø)` | |
   | 
[api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=)
 | `60.00% <0.00%> (ø)` | |
   |

[GitHub] [apisix] GreenShadeZhang commented on issue #5425: request help: How to best handle oidc providers that do not support introspection endpoints?

2021-11-28 Thread GitBox



GreenShadeZhang commented on issue #5425:
URL: https://github.com/apache/apisix/issues/5425#issuecomment-981261443


   I also have the same needs. My idea is to use the openid connect plugin to 
obtain the token for the front-end project, and then configure the jwks data as 
the api to verify the token. Do you think my requirement meets your habits?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] LiteSun merged pull request #777: feat: release APISIX 2.11.0

2021-11-28 Thread GitBox



LiteSun merged pull request #777:
URL: https://github.com/apache/apisix-website/pull/777


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-website] branch master updated: feat: release APISIX 2.11.0 (#777)

2021-11-28 Thread sunyi

This is an automated email from the ASF dual-hosted git repository.

sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 092953d  feat: release APISIX 2.11.0 (#777)
092953d is described below

commit 092953daa98e423b6830a92a67604ffa4aad9c6f
Author: litesun 
AuthorDate: Mon Nov 29 11:18:52 2021 +0800

feat: release APISIX 2.11.0 (#777)
---
 website/config/docs.js  | 4 ++--
 website/config/downloads.js | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/website/config/docs.js b/website/config/docs.js
index c4b0d97..da88e03 100644
--- a/website/config/docs.js
+++ b/website/config/docs.js
@@ -6,8 +6,8 @@ module.exports = [
 shape: "triangle",
 color: "#e8433e",
 githubRepo: "apache/apisix",
-version: "2.10.2",
-releaseDate: "2021-11-19",
+version: "2.11.0",
+releaseDate: "2021-11-29",
 firstDocPath: "/getting-started",
   },
   {
diff --git a/website/config/downloads.js b/website/config/downloads.js
index 4b40faf..8353985 100644
--- a/website/config/downloads.js
+++ b/website/config/downloads.js
@@ -7,9 +7,9 @@ module.exports = [
 color: "#e8433e",
 githubRepo: "apache/apisix",
 githubBranch: "master",
-downloadPath: "apisix/2.10.2/apache-apisix-2.10.2-src",
-version: "2.10.2",
-releaseDate: "2021-11-19",
+downloadPath: "apisix/2.11.0/apache-apisix-2.11.0-src",
+version: "2.11.0",
+releaseDate: "2021-11-29",
 firstDocPath: "/getting-started",
   },
   {

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #774: fix: delete the cluster object when give up the leadership

2021-11-28 Thread GitBox



gxthrj commented on pull request #774:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-981245301


   better to add e2e for this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] LiteSun opened a new pull request #777: feat: release APISIX 2.11.0

2021-11-28 Thread GitBox



LiteSun opened a new pull request #777:
URL: https://github.com/apache/apisix-website/pull/777


   update APISIX Release version 2.11.0
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #5600: feat(ext-plugin): support to get request body

2021-11-28 Thread GitBox



spacewander merged pull request #5600:
URL: https://github.com/apache/apisix/pull/5600


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: feat(ext-plugin): support to get request body (#5600)

2021-11-28 Thread spacewander

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new e7ceda0  feat(ext-plugin): support to get request body (#5600)
e7ceda0 is described below

commit e7ceda0387909ba41c0eb90a897c7b70e1e96545
Author: tzssangglass 
AuthorDate: Sun Nov 28 20:41:06 2021 -0600

feat(ext-plugin): support to get request body (#5600)
---
 apisix/plugins/ext-plugin/init.lua |  12 +++
 t/lib/ext-plugin.lua   |  31 +-
 t/plugin/ext-plugin/request-body.t | 201 +
 3 files changed, 243 insertions(+), 1 deletion(-)

diff --git a/apisix/plugins/ext-plugin/init.lua 
b/apisix/plugins/ext-plugin/init.lua
index 1a8fc9c..1e3ff0c 100644
--- a/apisix/plugins/ext-plugin/init.lua
+++ b/apisix/plugins/ext-plugin/init.lua
@@ -28,6 +28,7 @@ local extra_info = require("A6.ExtraInfo.Info")
 local extra_info_req = require("A6.ExtraInfo.Req")
 local extra_info_var = require("A6.ExtraInfo.Var")
 local extra_info_resp = require("A6.ExtraInfo.Resp")
+local extra_info_reqbody = require("A6.ExtraInfo.ReqBody")
 local text_entry = require("A6.TextEntry")
 local err_resp = require("A6.Err.Resp")
 local err_code = require("A6.Err.Code")
@@ -273,6 +274,17 @@ local function handle_extra_info(ctx, input)
 
 local var_name = var_req:Name()
 res = ctx.var[var_name]
+elseif info_type == extra_info.ReqBody then
+local info = req:Info()
+local reqbody_req = extra_info_reqbody.New()
+reqbody_req:Init(info.bytes, info.pos)
+
+local err
+res, err = core.request.get_body()
+if err then
+core.log.error("failed to read request body: ", err)
+end
+
 else
 return nil, "unsupported info type: " .. info_type
 end
diff --git a/t/lib/ext-plugin.lua b/t/lib/ext-plugin.lua
index f38951a..33e87d5 100644
--- a/t/lib/ext-plugin.lua
+++ b/t/lib/ext-plugin.lua
@@ -33,7 +33,7 @@ local extra_info = require("A6.ExtraInfo.Info")
 local extra_info_req = require("A6.ExtraInfo.Req")
 local extra_info_var = require("A6.ExtraInfo.Var")
 local extra_info_resp = require("A6.ExtraInfo.Resp")
-
+local extra_info_reqbody = require("A6.ExtraInfo.ReqBody")
 
 local _M = {}
 local builder = flatbuffers.Builder(0)
@@ -169,6 +169,8 @@ function _M.go(case)
 local entry = call_req:Args(1)
 assert(entry:Name() == "x")
 assert(entry:Value() == "z")
+elseif case.get_request_body then
+assert(call_req:Method() == a6_method.POST)
 else
 assert(call_req:Method() == a6_method.GET)
 end
@@ -208,6 +210,33 @@ function _M.go(case)
 local res = resp:ResultAsString()
 assert(res == action.result, res)
 end
+
+if action.type == "reqbody" then
+extra_info_reqbody.Start(builder)
+local reqbody_req = extra_info_reqbody.End(builder)
+build_extra_info(reqbody_req, extra_info.ReqBody)
+local req = extra_info_req.End(builder)
+builder:Finish(req)
+data = builder:Output()
+local ok, err = ext.send(sock, constants.RPC_EXTRA_INFO, 
data)
+if not ok then
+ngx.log(ngx.ERR, err)
+return
+end
+ngx.log(ngx.WARN, "send extra info req successfully")
+
+local ty, data = ext.receive(sock)
+if not ty then
+ngx.log(ngx.ERR, data)
+return
+end
+
+assert(ty == constants.RPC_EXTRA_INFO, ty)
+local buf = flatbuffers.binaryArray.New(data)
+local resp = extra_info_resp.GetRootAsResp(buf, 0)
+local res = resp:ResultAsString()
+assert(res == action.result, res)
+end
 end
 end
 
diff --git a/t/plugin/ext-plugin/request-body.t 
b/t/plugin/ext-plugin/request-body.t
new file mode 100644
index 000..fe01362
--- /dev/null
+++ b/t/plugin/ext-plugin/request-body.t
@@ -0,0 +1,201 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#issuecomment-980831326


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2225](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (23eb3f2) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ebf381d213a85343a321defd138f51d7f0f74a14?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ebf381d) will **increase** coverage by `3.30%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2225  +/-   ##
   ==
   + Coverage   68.13%   71.44%   +3.30% 
   ==
 Files 127   57  -70 
 Lines3352 3905 +553 
 Branches  8240 -824 
   ==
   + Hits 2284 2790 +506 
   + Misses   1068  822 -246 
   - Partials0  293 +293 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `44.81% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `51.01% <ø> (?)` | |
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/SSL/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvc2VydmljZS50cw==)
 | | |
   | 
[.../Route/components/DebugViews/DebugFormDataView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdGb3JtRGF0YVZpZXcudHN4)
 | | |
   | 
[web/src/components/PluginFlow/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29uc3RhbnRzLnRz)
 | | |
   | 
[web/src/pages/SSL/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvTGlzdC50c3g=)
 | | |
   | 
[web/src/pages/Service/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL3NlcnZpY2UudHM=)
 | | |
   | 
[web/src/components/Upstream/components/Scheme.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvU2NoZW1lLnRzeA==)
 | | |
   | 
[...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==)
 | | |
   |

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#issuecomment-980831326


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2225](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (23eb3f2) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ebf381d213a85343a321defd138f51d7f0f74a14?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ebf381d) will **decrease** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2225  +/-   ##
   ==
   - Coverage   68.13%   68.09%   -0.05% 
   ==
 Files 127   57  -70 
 Lines3352 3905 +553 
 Branches  8240 -824 
   ==
   + Hits 2284 2659 +375 
   + Misses   1068  958 -110 
   - Partials0  288 +288 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test-ginkgo | `51.01% <ø> (?)` | |
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==)
 | | |
   | 
[...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==)
 | | |
   | 
[...mponents/Upstream/components/active-check/Port.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1BvcnQudHN4)
 | | |
   | 
[...components/PluginFlow/components/Toolbar/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9Ub29sYmFyL2luZGV4LnRzeA==)
 | | |
   | 
[...mponents/PluginFlow/components/FlowGraph/shapes.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvc2hhcGVzLnRz)
 | | |
   | 
[web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=)
 | | |
   | 
[...ream/components/active-check/Healthy/Successes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvU3VjY2Vzc2VzLnRzeA==)
 | | |
   |

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#issuecomment-980831326


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2225](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (23eb3f2) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ebf381d213a85343a321defd138f51d7f0f74a14?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ebf381d) will **decrease** coverage by `18.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2225   +/-   ##
   ===
   - Coverage   68.13%   49.16%   -18.98% 
   ===
 Files 127   41   -86 
 Lines3352 3171  -181 
 Branches  8240  -824 
   ===
   - Hits 2284 1559  -725 
   - Misses   1068 1412  +344 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...eam/components/passive-check/Healthy/Successes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9IZWFsdGh5L1N1Y2Nlc3Nlcy50c3g=)
 | | |
   | 
[web/src/pages/Dashboard/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvc2VydmljZS50cw==)
 | | |
   | 
[web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4)
 | | |
   | 
[...src/pages/SSL/components/CertificateForm/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZUZvcm0vaW5kZXgudHN4)
 | | |
   | 
[...s/Upstream/components/active-check/Concurrency.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0NvbmN1cnJlbmN5LnRzeA==)
 | | |
   | 
[web/src/pages/SSL/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvTGlzdC50c3g=)
 | | |
   | 
[...am/components/passive-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvVGltZW91dHMudHN4)
 | | |
   | 
[web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz)
 | | |
   |

[apisix] branch master updated: docs: remember to register release info (#5632)

2021-11-28 Thread spacewander

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new c8c09eb  docs: remember to register release info (#5632)
c8c09eb is described below

commit c8c09eb4d98eeda07822e351f43171f75d57e2f8
Author: 罗泽轩 
AuthorDate: Mon Nov 29 10:22:20 2021 +0800

docs: remember to register release info (#5632)
---
 MAINTAIN.md | 24 +---
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/MAINTAIN.md b/MAINTAIN.md
index 11f1a23..0a0b2cd 100644
--- a/MAINTAIN.md
+++ b/MAINTAIN.md
@@ -29,11 +29,12 @@ via `VERSION=x.y.z make release-src`
 5. Send the [vote 
email](https://lists.apache.org/thread/vq4qtwqro5zowpdqhx51oznbjy87w9d0) to 
d...@apisix.apache.org
 6. When the vote is passed, send the [vote result 
email](https://lists.apache.org/thread/k2frnvj4zj9oynsbr7h7nd6n6m3q5p89) to 
d...@apisix.apache.org
 7. Move the vote artifact to Apache's apisix repo
-8. Create a [GitHub 
release](https://github.com/apache/apisix/releases/tag/2.10.2) from the minor 
branch
-9. Update [APISIX's 
website](https://github.com/apache/apisix-website/commit/f9104bdca50015722ab6e3714bbcd2d17e5c5bb3)
-10. Update APISIX rpm package
-11. Update [APISIX 
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601),
 and create new branch form master, named as `release/apisix-${version}`, e.g. 
`release/apisix-2.10.2`
-12. Send the [ANNOUNCE 
email](https://lists.apache.org/thread.html/ree7b06e6eac854fd42ba4f302079661a172f514a92aca2ef2f1aa7bb%40%3Cdev.apisix.apache.org%3E)
 to d...@apisix.apache.org & annou...@apache.org
+8. Register the release info in 
https://reporter.apache.org/addrelease.html?apisix
+9. Create a [GitHub 
release](https://github.com/apache/apisix/releases/tag/2.10.2) from the minor 
branch
+10. Update [APISIX's 
website](https://github.com/apache/apisix-website/commit/f9104bdca50015722ab6e3714bbcd2d17e5c5bb3)
+11. Update APISIX rpm package
+12. Update [APISIX 
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601),
 and create new branch form master, named as `release/apisix-${version}`, e.g. 
`release/apisix-2.10.2`
+13. Send the [ANNOUNCE 
email](https://lists.apache.org/thread.html/ree7b06e6eac854fd42ba4f302079661a172f514a92aca2ef2f1aa7bb%40%3Cdev.apisix.apache.org%3E)
 to d...@apisix.apache.org & annou...@apache.org
 
 ### Release minor version
 
@@ -43,9 +44,10 @@ via `VERSION=x.y.z make release-src`
 3. Send the [vote 
email](https://lists.apache.org/thread/q8zq276o20r5r9qjkg074nfzb77xwry9) to 
d...@apisix.apache.org
 4. When the vote is passed, send the [vote result 
email](https://lists.apache.org/thread/p1m9s116rojlhb91g38cj8646393qkz7) to 
d...@apisix.apache.org
 5. Move the vote artifact to Apache's apisix repo
-6. Create a [GitHub 
release](https://github.com/apache/apisix/releases/tag/2.10.0) from the minor 
branch
-7. Merge the pull request into master branch
-8. Update [APISIX's 
website](https://github.com/apache/apisix-website/commit/7bf0ab5a1bbd795e6571c4bb89a6e646115e7ca3)
-9. Update APISIX rpm package
-10. Update [APISIX 
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601),
 and create new branch form master, named as `release/apisix-${version}`, e.g. 
`release/apisix-2.10.2`
-11. Send the [ANNOUNCE 
email](https://lists.apache.org/thread/4s4msqwl1tq13p9dnv3hx7skbgpkozw1) to 
d...@apisix.apache.org & annou...@apache.org
+6. Register the release info in 
https://reporter.apache.org/addrelease.html?apisix
+7. Create a [GitHub 
release](https://github.com/apache/apisix/releases/tag/2.10.0) from the minor 
branch
+8. Merge the pull request into master branch
+9. Update [APISIX's 
website](https://github.com/apache/apisix-website/commit/7bf0ab5a1bbd795e6571c4bb89a6e646115e7ca3)
+10. Update APISIX rpm package
+11. Update [APISIX 
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601),
 and create new branch form master, named as `release/apisix-${version}`, e.g. 
`release/apisix-2.10.2`
+12. Send the [ANNOUNCE 
email](https://lists.apache.org/thread/4s4msqwl1tq13p9dnv3hx7skbgpkozw1) to 
d...@apisix.apache.org & annou...@apache.org

[GitHub] [apisix] spacewander merged pull request #5632: docs: remember to register release info

2021-11-28 Thread GitBox



spacewander merged pull request #5632:
URL: https://github.com/apache/apisix/pull/5632


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#issuecomment-980831326


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2225](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (0ea7c30) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ebf381d213a85343a321defd138f51d7f0f74a14?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ebf381d) will **decrease** coverage by `18.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2225   +/-   ##
   ===
   - Coverage   68.13%   49.16%   -18.98% 
   ===
 Files 127   41   -86 
 Lines3352 3171  -181 
 Branches  8240  -824 
   ===
   - Hits 2284 1559  -725 
   - Misses   1068 1412  +344 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=)
 | | |
   | 
[...omponents/passive-check/Unhealthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==)
 | | |
   | 
[...c/components/Upstream/components/KeepalivePool.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvS2VlcGFsaXZlUG9vbC50c3g=)
 | | |
   | 
[...eam/components/active-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9UaW1lb3V0cy50c3g=)
 | | |
   | 
[web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==)
 | | |
   | 
[web/src/components/HeaderDropdown/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0hlYWRlckRyb3Bkb3duL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=)
 | | |
   |

[GitHub] [apisix] tzssangglass commented on issue #5622: bug: APISIX occasional blocking

2021-11-28 Thread GitBox



tzssangglass commented on issue #5622:
URL: https://github.com/apache/apisix/issues/5622#issuecomment-981229992


   I see this error log: `cannot assign requested address`
   
   Is this a problem with your environment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#issuecomment-980831326


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2225](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (66d020f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ebf381d213a85343a321defd138f51d7f0f74a14?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ebf381d) will **decrease** coverage by `19.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2225   +/-   ##
   ===
   - Coverage   68.13%   49.13%   -19.01% 
   ===
 Files 127   41   -86 
 Lines3352 3171  -181 
 Branches  8240  -824 
   ===
   - Hits 2284 1558  -726 
   - Misses   1068 1413  +345 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.13% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...am/components/passive-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvVGltZW91dHMudHN4)
 | | |
   | 
[web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==)
 | | |
   | 
[web/src/components/Plugin/UI/proxy-mirror.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wcm94eS1taXJyb3IudHN4)
 | | |
   | 
[...mponents/Upstream/components/active-check/Port.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1BvcnQudHN4)
 | | |
   | 
[...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==)
 | | |
   | 
[...c/components/Upstream/components/KeepalivePool.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvS2VlcGFsaXZlUG9vbC50c3g=)
 | | |
   | 
[web/src/pages/SSL/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvTGlzdC50c3g=)
 | | |
   | 
[...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==)
 |

[GitHub] [apisix-docker] spacewander merged pull request #249: fix: all-in-one docker image build error

2021-11-28 Thread GitBox



spacewander merged pull request #249:
URL: https://github.com/apache/apisix-docker/pull/249


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] spacewander closed issue #248: occur docker build error via apisix-docker/all-in-one/apisix

2021-11-28 Thread GitBox



spacewander closed issue #248:
URL: https://github.com/apache/apisix-docker/issues/248


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #5596: request help: customize Nginx variable in the configuration

2021-11-28 Thread GitBox



spacewander commented on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-981222992


   Yes, @zlhgo  can write a plugin and do it in the `access` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-docker] branch master updated: fix: all-in-one docker image build error (#249)

2021-11-28 Thread spacewander

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-docker.git


The following commit(s) were added to refs/heads/master by this push:
 new 369f084  fix: all-in-one docker image build error (#249)
369f084 is described below

commit 369f0840a2ee17e7857b1878c4a68ecb12df5df8
Author: Mohit Saxena <76725454+mohitsaxenaknol...@users.noreply.github.com>
AuthorDate: Mon Nov 29 07:22:01 2021 +0530

fix: all-in-one docker image build error (#249)
---
 all-in-one/apisix/Dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/all-in-one/apisix/Dockerfile b/all-in-one/apisix/Dockerfile
index 7d62e38..61fb1cf 100644
--- a/all-in-one/apisix/Dockerfile
+++ b/all-in-one/apisix/Dockerfile
@@ -24,7 +24,7 @@ RUN set -x \
 openldap-dev \
 && luarocks install 
https://github.com/apache/apisix/raw/master/rockspec/apisix-${APISIX_VERSION}-0.rockspec
 --tree=/usr/local/apisix/deps \
 && cp -v 
/usr/local/apisix/deps/lib/luarocks/rocks-5.1/apisix/${APISIX_VERSION}-0/bin/apisix
 /usr/bin/ \
-&& (if [ "$APISIX_VERSION" = "master" ] || [ "$APISIX_VERSION" \> "2.2" ]; 
then echo 'use shell ';else bin='#! 
/usr/local/openresty/luajit/bin/luajit\npackage.path = 
"/usr/local/apisix/?.lua;" .. package.path'; sed -i "1s@.*@$bin@" 
/usr/bin/apisix ; fi;) \
+&& (function ver_lt { [ "$1" = "$2" ] && return 1 || [ "$1" = "`echo -e 
"$1\n$2" | sort -V | head -n1`" ]; };  if [ "$APISIX_VERSION" = "master" ] || 
ver_lt 2.2.0 $APISIX_VERSION; then echo 'use shell ';else bin='#! 
/usr/local/openresty/luajit/bin/luajit\npackage.path = 
"/usr/local/apisix/?.lua;" .. package.path'; sed -i "1s@.*@$bin@" 
/usr/bin/apisix ; fi;) \
 && mv /usr/local/apisix/deps/share/lua/5.1/apisix /usr/local/apisix \
 && apk del .builddeps build-base make unzip

[GitHub] [apisix-website] yzeng25 commented on a change in pull request #776: docs: add contribution guidelines

2021-11-28 Thread GitBox



yzeng25 commented on a change in pull request #776:
URL: https://github.com/apache/apisix-website/pull/776#discussion_r757982507



##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide
+
+## Overview
+
+Welcome to Apache APISIX's website and blog repository.
+
+This guideline will teach you how to contribute if you want to add a new blog, 
or modify existing blog contents.
+
+If you find an issue on current documents, please feel free to file an issue 
to let the community know about it, or you can sumbit a pull request to fix or 
update. Both actions are welcome and recommended.
+
+The blogs are written in two languages: English and Chinese. We encourage 
contributors to add blogs in their preferred language. It is completely up to 
you. We can handle translations and ask you to do a pull request review later.
+
+English blogs are located in the `website/blog` directory, in which they are 
categorized by year, month and date. For example, 
`website/blog/2021/11/22/develop-apisix-ingress-with-nocalhost-in-kubernetes.md`
 means that a blog named 
`develop-apisix-ingress-with-nocalhost-in-kubernetes.md` was published on 
November 22nd, 2021, and it is located in the `website/blog/2021/11/22 
directory`.
+
+Similarly, Chinese blogs are located in 
website/i18n/zh/docusaurus-plugin-content-blog directory and follow the same 
rules described above.

Review comment:
   ```suggestion
   Similarly, Chinese blogs are located in 
`website/i18n/zh/docusaurus-plugin-content-blog` directory and follow the same 
rules described above.
   ```

##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,338 @@
+# Apache APISIX Blog Contributing Guide
+
+## Overview
+
+Welcome to Apache APISIX's website and blog repository.
+
+This guideline will teach you how to contribute if you want to add a new blog, 
or modify existing blog contents.
+
+If you find an issue on current documents, please feel free to file an issue 
to let the community know about it, or you can sumbit a pull request to fix or 
update. Both actions are welcome and recommended.
+
+The blogs are written in two languages: English and Chinese. We encourage 
contributors to add blogs in their preferred language. It is completely up to 
you. We can handle translations and ask you to do a pull request review later.
+
+English blogs are located in the `website/blog` directory, in which they are 
categorized by year, month and date. For example, 
`website/blog/2021/11/22/develop-apisix-ingress-with-nocalhost-in-kubernetes.md`
 means that a blog named 
`develop-apisix-ingress-with-nocalhost-in-kubernetes.md` was published on 
November 22nd, 2021, and it is located in the `website/blog/2021/11/22 
directory`.
+
+Similarly, Chinese blogs are located in 
website/i18n/zh/docusaurus-plugin-content-blog directory and follow the same 
rules described above.
+
+## What you can contribute
+
+### Add a new blog
+
+To add a new blog, please perform the following steps:
+
+1. Find the right place to store your blog.
+1. If you plan to submit a blog written in English, please create a 
markdown file under `website/blog` directory.
+2. If you plan to submit a blog written in Chinese, please create a 
markdown file under `website/i18n/zh/docusaurus-plugin-content-blog` directory.
+3. If you cannot find an existing year, month, or date directory that fits 
your desired published date, you can go ahead and create such directory on your 
own.
+
+2. Create a markdown file in the directory. Please make sure that the file 
name is written in English with no capitalized letters. During review session, 
we may suggest changing it to achieve better SEO performance. (Yes, currently 
some files names contain capitalized letters, we are working on it, see 
https://github.com/apache/apisix-website/issues/713)
+
+3. Add text, images, diagrams, charts to the markdown file.
+1. There is nothing much to say about adding text.
+2. To add images, please upload images to https://markdown.apiseven.com/#/ 
, and copy the links from there.
+3. To add charts or diagrams, we are happy to see any sort of charts and 
diagrams, as long as it formats correctly on the page. From previous 
experience, charts with 4 columns or less are the perfect size displayed on 
screen.
+
+4. Optional: run locally to inspect any typos or formatting issues left 
behind. We highly recommend running the website locally before submission. 
Although we implemented lint and error checks in the repository, we suggest 
running it locally to avoid repeated work. To run it locally, please run `cd 
website`, and then run `yarn start` commands in your terminal.
+
+5. Submit a pull request to our repository.
+
+ Blog's header information
+
+Our blogs start with a header like this:
+
+```
+title: "blog's title"
+author: "blog's author"
+authorURL: "author's GitHub ID"
+authorImageURL: "author's GitHub Image"
+keywords:
+- keywords 1
+- keywords 2

[GitHub] [apisix] tzssangglass commented on issue #5609: bug: error when using the zipkin plugin

2021-11-28 Thread GitBox



tzssangglass commented on issue #5609:
URL: https://github.com/apache/apisix/issues/5609#issuecomment-981221245


   considered resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #5596: request help: customize Nginx variable in the configuration

2021-11-28 Thread GitBox



tzssangglass commented on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-981220726


   > BTW, look like this part has to be maintained in the fork...
   > 
   > ```
   > diff --git a/apisix/init.lua b/apisix/init.lua
   > index 801809f6..816352bf 100644
   > --- a/apisix/init.lua
   > +++ b/apisix/init.lua
   > @@ -505,6 +505,9 @@ function _M.http_access_phase()
   > or route_val.upstream
   >  end
   >  
   > +-- need to care of matched_upstream
   > +ngx.var.upstream_name = api_ctx.matched_upstream.parent.value.name
   > +
   >  if enable_websocket then
   >  api_ctx.var.upstream_upgrade= api_ctx.var.http_upgrade
   >  api_ctx.var.upstream_connection = api_ctx.var.http_connection
   > ```
   
   I think this part is more suitable for users to develop their own plugins to 
do so.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander opened a new pull request #5632: doc: remember to register release info

2021-11-28 Thread GitBox



spacewander opened a new pull request #5632:
URL: https://github.com/apache/apisix/pull/5632


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#issuecomment-980831326


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2225](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (d8391be) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ebf381d213a85343a321defd138f51d7f0f74a14?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ebf381d) will **decrease** coverage by `18.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2225   +/-   ##
   ===
   - Coverage   68.13%   49.16%   -18.98% 
   ===
 Files 127   41   -86 
 Lines3352 3171  -181 
 Branches  8240  -824 
   ===
   - Hits 2284 1559  -725 
   - Misses   1068 1412  +344 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==)
 | | |
   | 
[web/src/pages/Service/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL3RyYW5zZm9ybS50cw==)
 | | |
   | 
[web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=)
 | | |
   | 
[web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4)
 | | |
   | 
[web/src/pages/SSL/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvQ3JlYXRlLnRzeA==)
 | | |
   | 
[web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=)
 | | |
   | 
[web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=)
 | | |
   |

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#issuecomment-980831326


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2225](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (2198416) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ebf381d213a85343a321defd138f51d7f0f74a14?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ebf381d) will **decrease** coverage by `18.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2225   +/-   ##
   ===
   - Coverage   68.13%   49.16%   -18.98% 
   ===
 Files 127   41   -86 
 Lines3352 3171  -181 
 Branches  8240  -824 
   ===
   - Hits 2284 1559  -725 
   - Misses   1068 1412  +344 
   - Partials0  200  +200 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.16% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../src/pages/Route/components/Step1/ProxyRewrite.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1Byb3h5UmV3cml0ZS50c3g=)
 | | |
   | 
[web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==)
 | | |
   | 
[...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=)
 | | |
   | 
[...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==)
 | | |
   | 
[web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==)
 | | |
   | 
[...pages/SSL/components/CertificateUploader/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZVVwbG9hZGVyL2luZGV4LnRzeA==)
 | | |
   | 
[web/src/pages/SSL/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2225/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvQ3JlYXRlLnRzeA==)
 | | |
   |

[GitHub] [apisix] spacewander commented on issue #5037: request help: I want to add the result data of the request response to the access log

2021-11-28 Thread GitBox



spacewander commented on issue #5037:
URL: https://github.com/apache/apisix/issues/5037#issuecomment-981213002


   Solved by https://github.com/apache/apisix/pull/5550


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #5037: request help: I want to add the result data of the request response to the access log

2021-11-28 Thread GitBox



spacewander closed issue #5037:
URL: https://github.com/apache/apisix/issues/5037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #5596: request help: customize Nginx variable in the configuration

2021-11-28 Thread GitBox



spacewander commented on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-981208090


   BTW, look like this part has to be maintained in the fork...
   ```
   diff --git a/apisix/init.lua b/apisix/init.lua
   index 801809f6..816352bf 100644
   --- a/apisix/init.lua
   +++ b/apisix/init.lua
   @@ -505,6 +505,9 @@ function _M.http_access_phase()
   or route_val.upstream
end

   +-- need to care of matched_upstream
   +ngx.var.upstream_name = api_ctx.matched_upstream.parent.value.name
   +
if enable_websocket then
api_ctx.var.upstream_upgrade= api_ctx.var.http_upgrade
api_ctx.var.upstream_connection = api_ctx.var.http_connection
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on issue #5631: How to use Grafana to monitor the number of requests in a time period?

2021-11-28 Thread GitBox



tokers commented on issue #5631:
URL: https://github.com/apache/apisix/issues/5631#issuecomment-981207651


   There is a metric `apisix_http_status`, you can get the accumulated value if 
you ignore the `code` label.
   
   * http://apisix.apache.org/docs/apisix/plugins/prometheus/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #5596: request help: save upstream name to var

2021-11-28 Thread GitBox



spacewander commented on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-981205228


   @zlhgo 
   Would you give it a try?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #5595: feat: add gen-vote-content script

2021-11-28 Thread GitBox



spacewander commented on a change in pull request #5595:
URL: https://github.com/apache/apisix/pull/5595#discussion_r757981554



##
File path: utils/gen-vote-contents.sh
##
@@ -0,0 +1,92 @@
+#!/bin/sh
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+VERSION=$1
+
+SUBSTRING1=$(echo $VERSION| cut -d'.' -f 1)
+SUBSTRING2=$(echo $VERSION| cut -d'.' -f 2)
+BLOB_VERSION=$SUBSTRING1.$SUBSTRING2
+
+read -p "Please enter release note pr: " RELEASE_NOTE_PR
+read -p "Please enter release commit id: " COMMIT_ID
+
+vote_contents=$(cat

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



bzp2010 commented on a change in pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#discussion_r757980828



##
File path: api/test/docker/apisix_config.yaml
##
@@ -20,8 +20,6 @@
 etcd:
   host:
 - "http://172.16.238.10:2379;
-- "http://172.16.238.11:2379;
-- "http://172.16.238.12:2379;

Review comment:
   OK, I will modify to keep it. But currently we don't have test cases 
that actually use it, such as skipping failed nodes, auto reconnect, etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #5618: docs: Path of example is corrected

2021-11-28 Thread GitBox



spacewander merged pull request #5618:
URL: https://github.com/apache/apisix/pull/5618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #5617: docs(dubbo-proxy) the path of example is wrong

2021-11-28 Thread GitBox



spacewander closed issue #5617:
URL: https://github.com/apache/apisix/issues/5617


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (9426500 -> 0344606)

2021-11-28 Thread spacewander

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from 9426500  docs: exec code block for shell commands in Test Nginx (#5625)
 add 0344606  docs: Path of example is corrected (#5618)

No new revisions were added by this update.

Summary of changes:
 docs/en/latest/plugins/dubbo-proxy.md | 2 +-
 docs/zh/latest/plugins/dubbo-proxy.md | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[GitHub] [apisix] LiteSun commented on a change in pull request #5595: feat: add gen-vote-content script

2021-11-28 Thread GitBox



LiteSun commented on a change in pull request #5595:
URL: https://github.com/apache/apisix/pull/5595#discussion_r757976717



##
File path: utils/gen-vote-contents.sh
##
@@ -0,0 +1,92 @@
+#!/bin/sh
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+VERSION=$1
+
+SUBSTRING1=$(echo $VERSION| cut -d'.' -f 1)
+SUBSTRING2=$(echo $VERSION| cut -d'.' -f 2)
+BLOB_VERSION=$SUBSTRING1.$SUBSTRING2
+
+read -p "Please enter release note pr: " RELEASE_NOTE_PR
+read -p "Please enter release commit id: " COMMIT_ID
+
+vote_contents=$(cat > ./release/apache-apisix-$VERSION-vote-contents.txt

Review comment:
   Yes. Not quite familiar with shell script, just updated邏




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2225: ci: clean up the E2E test environment

2021-11-28 Thread GitBox



nic-chen commented on a change in pull request #2225:
URL: https://github.com/apache/apisix-dashboard/pull/2225#discussion_r757976048



##
File path: api/test/docker/apisix_config.yaml
##
@@ -20,8 +20,6 @@
 etcd:
   host:
 - "http://172.16.238.10:2379;
-- "http://172.16.238.11:2379;
-- "http://172.16.238.12:2379;

Review comment:
   We should keep them, people generally use etcd in a cluster instead of a 
single node
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on issue #5630: docs: add APISIX software architecture diagram

2021-11-28 Thread GitBox



tokers commented on issue #5630:
URL: https://github.com/apache/apisix/issues/5630#issuecomment-981190337


   > clearer version
   > 
   > 
   > 
   > https://user-images.githubusercontent.com/6814606/143735451-13d6fd62-6793-480c-bf53-fa832864e0d3.png;>
   > 
   > 
   
   Terms like service is captial while client is all in uppercase, I think it's 
better to keep them consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] 1502shivam-singh merged pull request #2210: fix: build then launch link

2021-11-28 Thread GitBox



1502shivam-singh merged pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] 1502shivam-singh closed issue #2211: bug: deployment document link error in README

2021-11-28 Thread GitBox



1502shivam-singh closed issue #2211:
URL: https://github.com/apache/apisix-dashboard/issues/2211


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: fix: "build then launch" link (#2210)

2021-11-28 Thread singhsh

This is an automated email from the ASF dual-hosted git repository.

singhsh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 41a1360  fix: "build then launch" link (#2210)
41a1360 is described below

commit 41a13602c7338aeac094c76338ae412c5e42fcc4
Author: Applenice 
AuthorDate: Mon Nov 29 06:42:14 2021 +0800

fix: "build then launch" link (#2210)

* fix: source codes link

* fix: build then launch link

* fix: build then launch link
---
 README.md | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index fdb7d34..eb73846 100644
--- a/README.md
+++ b/README.md
@@ -77,9 +77,8 @@ Password: admin
 
 Support the following ways currently.
 
-- [Source Codes](./docs/en/latest/deploy.md)
-- [Docker](./docs/en/latest/deploy-with-docker.md)
-- [RPM package（only for CentOS 7）](./docs/en/latest/deploy-with-rpm.md)
+- [Docker, RPM, Source Codes](./docs/en/latest/install.md)
+- [Rebuild docker image](./docs/en/latest/deploy-with-docker.md)
 
 ## Development

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2210: fix: build then launch link

2021-11-28 Thread GitBox



codecov-commenter edited a comment on pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#issuecomment-968323740


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2210](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (96a5766) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/5fc0834b6bf3a37b3624fc7a4aa41623efe9562b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (5fc0834) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2210/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#2210   +/-   ##
   ===
 Coverage   68.07%   68.07%   
   ===
 Files 127  127   
 Lines3352 3352   
 Branches  824  824   
   ===
 Hits 2282 2282   
 Misses   1070 1070   
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.07% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Last update 
[5fc0834...96a5766](https://codecov.io/gh/apache/apisix-dashboard/pull/2210?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 closed pull request #2054: fix: perform pid lookup for existing pid file

2021-11-28 Thread GitBox



bzp2010 closed pull request #2054:
URL: https://github.com/apache/apisix-dashboard/pull/2054


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2054: fix: perform pid lookup for existing pid file

2021-11-28 Thread GitBox



bzp2010 commented on pull request #2054:
URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-981124303


   ## Update
   In the previous PR we have removed the dependency on the built-in service 
management library and also removed the code for PID file generation.
   ## 
   So I'll close this PR for now and you can open it again if you need to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] github-actions[bot] removed a comment on pull request #2084: ci: run e2e test parallel

2021-11-28 Thread GitBox



github-actions[bot] removed a comment on pull request #2084:
URL: https://github.com/apache/apisix-dashboard/pull/2084#issuecomment-970117694


   This pull request has been marked as stale due to 60 days of inactivity. It 
will be closed in 4 weeks if no further activity occurs. If you think that's 
incorrect or this pull request should instead be reviewed, please simply write 
any comment. Even if closed, you can still revive the PR at any time ordiscuss 
it on the d...@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2210: fix: build then launch link

2021-11-28 Thread GitBox



bzp2010 commented on pull request #2210:
URL: https://github.com/apache/apisix-dashboard/pull/2210#issuecomment-981123715


   > 樂 Why it fail?? @LiteSun please take a look.
   
   @juzhiyuan This is the case of instability in the test, and it is usually 
sufficient to perform several retries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2202: test: migrate global rule e2e

2021-11-28 Thread GitBox



bzp2010 commented on a change in pull request #2202:
URL: https://github.com/apache/apisix-dashboard/pull/2202#discussion_r757928639



##
File path: api/test/e2enew/global_rule/global_rule_test.go
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package global_rule_test
+
+import (
+   "net/http"
+
+   . "github.com/onsi/ginkgo"
+   . "github.com/onsi/ginkgo/extensions/table"
+
+   "github.com/apisix/manager-api/test/e2enew/base"
+)
+
+var _ = Describe("Global Rule", func() {
+   var _ = DescribeTable("test global rule curd",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   Entry("create global rule", base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/global_rules/1",
+   Body: `{
+   "plugins": {
+   "response-rewrite": {
+   "headers": {
+   "X-VERSION":"1.0"
+   }
+   }
+   }
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "\"X-VERSION\":\"1.0\"",
+   }),
+   Entry("full update global rule", base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/global_rules/1",
+   Body: `{
+   "plugins": {
+   "response-rewrite": {
+   "headers": {
+   "X-TEST":"1.0"
+   }
+   }
+   }
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "\"X-TEST\":\"1.0\"",
+   }),
+   Entry("partial update global rule", base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPatch,
+   Path:   "/apisix/admin/global_rules/1/plugins",
+   Body: `{
+   "response-rewrite": {
+   "headers": {
+   "X-VERSION":"1.0"
+   }
+   },
+   "key-auth": {}
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "\"key-auth\":{}",
+   }),
+   Entry("delete global rule", base.HttpTestCase{
+   Object:   base.ManagerApiExpect(),
+   Method:   http.MethodDelete,
+   Path: "/apisix/admin/global_rules/1",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   )
+
+   var _ = DescribeTable("test global rule integration",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   Entry("create route", base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "name": "route1",
+

[GitHub] [apisix-dashboard] bzp2010 closed issue #2220: bug: the TCP Failures configuration does not work

2021-11-28 Thread GitBox



bzp2010 closed issue #2220:
URL: https://github.com/apache/apisix-dashboard/issues/2220


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 merged pull request #2221: fix: correct the property name for tcp_failures

2021-11-28 Thread GitBox



bzp2010 merged pull request #2221:
URL: https://github.com/apache/apisix-dashboard/pull/2221


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh merged pull request #774: chore: add 1502shivam-singh (Shivam Singh) as committer in team

2021-11-28 Thread GitBox



1502shivam-singh merged pull request #774:
URL: https://github.com/apache/apisix-website/pull/774


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: fix: correct the property name for tcp_failures (#2221)

2021-11-28 Thread bzp2010

This is an automated email from the ASF dual-hosted git repository.

bzp2010 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new a381b61  fix: correct the property name for tcp_failures (#2221)
a381b61 is described below

commit a381b61df6f2a55bb988ca1774d5f01ae0a4778b
Author: okaybase <75366457+okayb...@users.noreply.github.com>
AuthorDate: Mon Nov 29 01:35:15 2021 +0800

fix: correct the property name for tcp_failures (#2221)
---
 .../Upstream/components/active-check/Unhealthy/TCPFailures.tsx  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/web/src/components/Upstream/components/active-check/Unhealthy/TCPFailures.tsx 
b/web/src/components/Upstream/components/active-check/Unhealthy/TCPFailures.tsx
index 79657bf..8b7d9a8 100644
--- 
a/web/src/components/Upstream/components/active-check/Unhealthy/TCPFailures.tsx
+++ 
b/web/src/components/Upstream/components/active-check/Unhealthy/TCPFailures.tsx
@@ -36,7 +36,7 @@ const TCPFailures: React.FC = ({ readonly }) => {
   })}
 >

[apisix-website] branch master updated: chore: add 1502shivam-singh as committer in team (#774)

2021-11-28 Thread singhsh

This is an automated email from the ASF dual-hosted git repository.

singhsh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 13606cc  chore: add 1502shivam-singh as committer in team (#774)
13606cc is described below

commit 13606cc82e5ff5c145aad659ca65845c67ae59eb
Author: Shivam Singh <57267960+1502shivam-si...@users.noreply.github.com>
AuthorDate: Sun Nov 28 23:05:04 2021 +0530

chore: add 1502shivam-singh as committer in team (#774)
---
 website/config/team.js | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/website/config/team.js b/website/config/team.js
index 83ebdb7..359ea7f 100644
--- a/website/config/team.js
+++ b/website/config/team.js
@@ -240,6 +240,12 @@ module.exports = [
 "username": "wang-yeliang",
 "githubUsername": "wang-yeliang",
 "avatarUrl": "https://avatars.githubusercontent.com/u/19886745?v=4;
+  },
+  {
+"name": "Shivam Singh",
+"username": "singhsh",
+"githubUsername": "1502shivam-singh",
+"avatarUrl": "https://avatars.githubusercontent.com/u/57267960?v=4;
   }
 ]
   }

[GitHub] [apisix-website] bzp2010 merged pull request #775: docs: add contibutor-to-comitter journey blog (@1502shivam-singh)

2021-11-28 Thread GitBox



bzp2010 merged pull request #775:
URL: https://github.com/apache/apisix-website/pull/775


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-website] branch master updated (ee6a801 -> 774710a)

2021-11-28 Thread bzp2010

This is an automated email from the ASF dual-hosted git repository.

bzp2010 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git.


from ee6a801  docs: update topic to avoid displaying issue (#772)
 add 774710a  docs: add contibutor-to-comitter journey blog 
(@1502shivam-singh) (#775)

No new revisions were added by this update.

Summary of changes:
 .../11/26/apache-apisix-committer-experience.md| 47 ++
 1 file changed, 47 insertions(+)
 create mode 100644 
website/blog/2021/11/26/apache-apisix-committer-experience.md

[GitHub] [apisix-website] juzhiyuan commented on pull request #776: docs: add contribution guidelines

2021-11-28 Thread GitBox



juzhiyuan commented on pull request #776:
URL: https://github.com/apache/apisix-website/pull/776#issuecomment-981109730


   wow! looking forward to this guideline


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on issue #763: combine configuration files into one

2021-11-28 Thread GitBox



juzhiyuan commented on issue #763:
URL: https://github.com/apache/apisix-website/issues/763#issuecomment-981109253


   >  And what will the hiddenDocumentList do, does it contains some 
configuration that aren't public or something that is not to be shown in the 
website?
   
   樂 Yes, you're right, for this case, we don't need that property at all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #61:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-981081360


   > Obviously this is a permissions issue with docker. I would recommend 
developing under linux.
   
   I use mac OS.
   this is the processes in the docker container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody, the java process user is root, so no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 commented on issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it starts

2021-11-28 Thread GitBox



cws1981 commented on issue #78:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/78#issuecomment-981084264


   > 
   
   ```java
   Runtime.getRuntime().exec("chmod 777 " + socketFile);
   ```
   this is work for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #61:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-981081360


   > Obviously this is a permissions issue with docker. I would recommend 
developing under linux.
   I use mac OS.
   this is the processes in the docker container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody, the java process user is root, so no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #61:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-981081360


   > Obviously this is a permissions issue with docker. I would recommend 
developing under linux.
   I use mac OS.
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody, the java process user is root, so no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #61:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-981081360


   > Obviously this is a permissions issue with docker. I would recommend 
developing under linux.
   I user mac OS.
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody, the java process user is root, so no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #61:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-981081360


   > Obviously this is a permissions issue with docker. I would recommend 
developing under linux.
   
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody, the java process user is root, so no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #61:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-981081360


   > Obviously this is a permissions issue with docker. I would recommend 
developing under linux.
   
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody so no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 commented on issue #61: bug: Can not connect java plugin with apache apisix container

2021-11-28 Thread GitBox



cws1981 commented on issue #61:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-981081360


   > Obviously this is a permissions issue with docker. I would recommend 
developing under linux.
   
   
   
   > Obviously this is a permissions issue with docker. I would recommend 
developing under linux.
   
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody so no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #78:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/78#issuecomment-981078931


   This is my Dockerfile:
   ```
   FROM apache/apisix:2.10.0-alpine
   
   RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" 
/etc/apk/repositories && apk add --no-cache openjdk11-jre-headless
   
   ADD apisix-java-plugin-runner.jar /usr/local/apisix-java-plugin-runner.jar
   ```
   I rebuild docker images add apisix-java-plugin-runner.jar, so the 
java-plugin will in the same container with apisix, but it still outputs errors 
in the error.log:
   ```
   2021/11/25 06:33:31 [crit] 44#44: *2280 connect() to 
unix:/usr/local/apisix/conf/apisix-1.sock failed (13: Permission denied)
   ```
   
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody so no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 commented on issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it starts

2021-11-28 Thread GitBox



cws1981 commented on issue #78:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/78#issuecomment-981080801


   > 1. on debug mode, the socket file is generated by Java plugin runner;
   > 2. on run mode, the socket file is generated by APISXI, so we don't need 
to set the file permissions by code, otherwise this code will cause an 
exception in run mode.
   
   apisix worker process user is nobody no Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #78:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/78#issuecomment-981078931


   This is my Dockerfile:
   ```
   FROM apache/apisix:2.10.0-alpine
   
   RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" 
/etc/apk/repositories && apk add --no-cache openjdk11-jre-headless
   
   ADD apisix-java-plugin-runner.jar /usr/local/apisix-java-plugin-runner.jar
   ```
   I rebuild docker images add apisix-java-plugin-runner.jar, so the 
java-plugin will in the same container with apisix, but it still outputs errors 
in the error.log:
   ```
   2021/11/25 06:33:31 [crit] 44#44: *2280 connect() to 
unix:/usr/local/apisix/conf/apisix-1.sock failed (13: Permission denied)
   ```
   
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```
   pid 44 user is nobody so not Permission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #78:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/78#issuecomment-981078931


   This is my Dockerfile:
   ```
   FROM apache/apisix:2.10.0-alpine
   
   RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" 
/etc/apk/repositories && apk add --no-cache openjdk11-jre-headless
   
   ADD apisix-java-plugin-runner.jar /usr/local/apisix-java-plugin-runner.jar
   ```
   I rebuild docker images add apisix-java-plugin-runner.jar, so the 
java-plugin will in the same container with apisix, but it still outputs errors 
in the error.log:
   ```
   2021/11/25 06:33:31 [crit] 44#44: *2280 connect() to 
unix:/usr/local/apisix/conf/apisix-1.sock failed (13: Permission denied)
   ```
   
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it

2021-11-28 Thread GitBox



cws1981 edited a comment on issue #78:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/78#issuecomment-981078931


   this is my Dockerfile:
   ```
   FROM apache/apisix:2.10.0-alpine
   
   RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" 
/etc/apk/repositories && apk add --no-cache openjdk11-jre-headless
   
   ADD apisix-java-plugin-runner.jar /usr/local/apisix-java-plugin-runner.jar
   ```
   i rebuild docker images add apisix-java-plugin-runner.jar, so the 
java-plugin will in the same container with apisix, but it still outputs errors 
in the error.log:
   ```
   2021/11/25 06:33:31 [crit] 44#44: *2280 connect() to 
unix:/usr/local/apisix/conf/apisix-1.sock failed (13: Permission denied)
   ```
   
   this is the processes in the container:
   ```
   PID   USER TIME  COMMAND
   1 root  0:00 {openresty} nginx: master process 
/usr/local/openresty/bin/openresty -p /usr/local/apisix -g daemon off;
  44 nobody0:00 {openresty} nginx: worker process
  45 nobody0:00 {openresty} nginx: worker process
  46 nobody0:00 {openresty} nginx: worker process
  47 nobody0:00 {openresty} nginx: worker process
  48 nobody0:00 {openresty} nginx: cache manager process
  49 nobody0:00 {openresty} nginx: cache loader process
  50 root  0:00 {openresty} nginx: privileged agent process
  56 root  0:15 java -jar -Xmx4g -Xms4g 
/usr/local/apisix-runner-bin/apisix-java-plugin-runner.jar
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

1 2 >

1 - 100 of 121 matches

Mail list logo