[GitHub] [apisix] zhangweidongyyl removed a comment on issue #5689: request help: how i use cosocket and parse http1.1 responsebody in body_filter
zhangweidongyyl removed a comment on issue #5689: URL: https://github.com/apache/apisix/issues/5689#issuecomment-985986523 i had solve my problem,replace cosocket with resty.http -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhangweidongyyl opened a new issue #5691: request help: how ngx.timer.at get response set for ngx.arg[1] in body_filter?
zhangweidongyyl opened a new issue #5691:
URL: https://github.com/apache/apisix/issues/5691
### Issue description
` local function push_data(premature, args)
httpc, err = http:new() --
创建 http 连接对象
httpc:set_timeout(time) --
注意名字里有一个下划线
httpc:set_timeout(connect_timeout, -- 同上
send_timeout, read_timeout)
local res, err = httpc:request_uri( --
发送 HTTP 请求，默认是 GET
'http://www.baidu.com',
-- 指定 IP 地址
{path = '/echo',--
指定具体路径
query = {name = 'chrono'}} --
请求的参数，使用 Lua 表
)
if not res then --
检查请求是否成功
core.log.error("failed to request : ", err)
return
end
core.log.info("args:", type(args))
core.log.info("res.body：",res.body)
-- 输出响应体
end
local resp = ""
local ok, err = ngx.timer.at(0, push_data, ngx.var.args)
if not ok then
ngx.log(ngx.ERR, "failed to create timer: ", err)
return
end
ngx.arg[1] = "success"
ngx.arg[2] = true`
how i set res.body for global
### Environment
- apisix version (cmd: `apisix version`):
- OS (cmd: `uname -a`):
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] commented on pull request #36: refactor: request processing flow
codecov[bot] commented on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26f35ae) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `1.48%`. > The diff coverage is `88.27%`. [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 91.44% -1.49% == Files 13 12 -1 Lines 722 725 +3 == - Hits 671 663 -8 - Misses 51 62 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `94.44% <ø> (-2.33%)` | :arrow_down: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `77.19% <75.92%> (-15.22%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `97.29% <97.29%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.17% <97.82%> (-0.83%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [apisix/runner/server/config.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvY29uZmlnLnB5) | `94.11% <100.00%> (ø)` | | | [apisix/runner/server/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #785: docs: Optimize installation documentation
tao12345666333 commented on a change in pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785#discussion_r762404700 ## File path: docs/en/latest/deployments/minikube.md ## @@ -41,7 +40,7 @@ kubectl create ns ingress-apisix helm install apisix apisix/apisix \ --set gateway.type=NodePort \ --set ingress-controller.enabled=true \ - --namespace ingress-apisix + --namespace ingress-apisix \ Review comment: Please add one more `--set ingress-controller.config.apisix.serviceNamespace=ingress-apisix` flag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26f35ae) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `1.48%`. > The diff coverage is `88.27%`. > :exclamation: Current head 26f35ae differs from pull request most recent head 29104e7. Consider uploading reports for the commit 29104e7 to get more accurate results [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 91.44% -1.49% == Files 13 12 -1 Lines 722 725 +3 == - Hits 671 663 -8 - Misses 51 62 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `94.44% <ø> (-2.33%)` | :arrow_down: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `77.19% <75.92%> (-15.22%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `97.29% <97.29%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.17% <97.82%> (-0.83%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [apisix/runner/server/config.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIv
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29104e7) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `1.48%`. > The diff coverage is `88.27%`. [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 91.44% -1.49% == Files 13 12 -1 Lines 722 725 +3 == - Hits 671 663 -8 - Misses 51 62 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `94.44% <ø> (-2.33%)` | :arrow_down: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `77.19% <75.92%> (-15.22%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `97.29% <97.29%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.17% <97.82%> (-0.83%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [apisix/runner/server/config.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvY29uZmlnLnB5) | `94.11% <100.00%> (ø)` | | | [apisix/runner/server/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path
tao12345666333 commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-985995871 Thanks! I have put it in my list. PS: I will submit a PR to fix the problem of e2e failure (Ingress LB status case) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path
tao12345666333 commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-985996122 In addition, can you please add documentation to introduce this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29104e7) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `1.48%`. > The diff coverage is `88.27%`. > :exclamation: Current head 29104e7 differs from pull request most recent head 4645a25. Consider uploading reports for the commit 4645a25 to get more accurate results [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 91.44% -1.49% == Files 13 12 -1 Lines 722 725 +3 == - Hits 671 663 -8 - Misses 51 62 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `94.44% <ø> (-2.33%)` | :arrow_down: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `77.19% <75.92%> (-15.22%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `97.29% <97.29%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.17% <97.82%> (-0.83%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [apisix/runner/server/config.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIv
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4645a25) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `1.18%`. > The diff coverage is `89.09%`. [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 91.74% -1.19% == Files 13 12 -1 Lines 722 727 +5 == - Hits 671 667 -4 - Misses 51 60 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `94.44% <ø> (-2.33%)` | :arrow_down: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/plugin/cache.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY2FjaGUucHk=) | `94.11% <50.00%> (-5.89%)` | :arrow_down: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `77.19% <75.92%> (-15.22%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `99.09% <99.09%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.74% <100.00%> (-0.26%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [apisix/runner/server/config.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4645a25) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `1.18%`. > The diff coverage is `89.09%`. > :exclamation: Current head 4645a25 differs from pull request most recent head 2af5b79. Consider uploading reports for the commit 2af5b79 to get more accurate results [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 91.74% -1.19% == Files 13 12 -1 Lines 722 727 +5 == - Hits 671 667 -4 - Misses 51 60 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `94.44% <ø> (-2.33%)` | :arrow_down: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/plugin/cache.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY2FjaGUucHk=) | `94.11% <50.00%> (-5.89%)` | :arrow_down: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `77.19% <75.92%> (-15.22%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `99.09% <99.09%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.74% <100.00%> (-0.26%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4v
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2af5b79) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `1.18%`. > The diff coverage is `89.09%`. [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 91.74% -1.19% == Files 13 12 -1 Lines 722 727 +5 == - Hits 671 667 -4 - Misses 51 60 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `94.44% <ø> (-2.33%)` | :arrow_down: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/plugin/cache.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY2FjaGUucHk=) | `94.11% <50.00%> (-5.89%)` | :arrow_down: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `77.19% <75.92%> (-15.22%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `99.09% <99.09%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.74% <100.00%> (-0.26%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [apisix/runner/server/config.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src
[GitHub] [apisix-dashboard] bzp2010 closed issue #1884: feat: provide command line interface of Manager API
bzp2010 closed issue #1884: URL: https://github.com/apache/apisix-dashboard/issues/1884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #2951: request help: migrate apisix data from 1.5 to 2.x
github-actions[bot] closed issue #2951: URL: https://github.com/apache/apisix/issues/2951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #2129: bug: set route fail when ETCD host is domain in K8S env
github-actions[bot] commented on issue #2129: URL: https://github.com/apache/apisix/issues/2129#issuecomment-986002406 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #2129: bug: set route fail when ETCD host is domain in K8S env
github-actions[bot] closed issue #2129: URL: https://github.com/apache/apisix/issues/2129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #2951: request help: migrate apisix data from 1.5 to 2.x
github-actions[bot] commented on issue #2951: URL: https://github.com/apache/apisix/issues/2951#issuecomment-986002410 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #2069: feat: request-id plugin form added
github-actions[bot] commented on pull request #2069: URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-986002491 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #5449: feat(oidc): make it possible to validate tokens against provider host…
starsz commented on a change in pull request #5449:
URL: https://github.com/apache/apisix/pull/5449#discussion_r762418069
##
File path: t/plugin/openid-connect.t
##
@@ -1487,3 +1487,140 @@ GET /t
{"access_token_in_authorization_header":false,"bearer_only":false,"client_id":"kbyuFDidLLm280LIwVFiazOqjO3ty8KH","client_secret":"60Op4HFM0I8ajz0WdiStAbziZ-VFQttXuxixHHs2R7r7-CW8GR79l-mmLqMhc-Sa","discovery":"http://127.0.0.1:1980/.well-known/openid-configuration","introspection_endpoint_auth_method":"client_secret_basic","logout_path":"/logout","realm":"apisix","scope":"openid","set_access_token_header":true,"set_id_token_header":true,"set_userinfo_header":true,"ssl_verify":false,"timeout":3}
--- no_error_log
[error]
+
+
+
+=== TEST 25: Update plugin with ID provider jwks endpoint for token
verification.
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{ "plugins": {
+"openid-connect": {
+"client_id":
"kbyuFDidLLm280LIwVFiazOqjO3ty8KH",
+"client_secret":
"60Op4HFM0I8ajz0WdiStAbziZ-VFQttXuxixHHs2R7r7-CW8GR79l-mmLqMhc-Sa",
+"discovery":
"https://samples.auth0.com/.well-known/openid-configuration";,
+"redirect_uri": "https://iresty.com";,
+"ssl_verify": false,
+"timeout": 10,
+"bearer_only": true,
+"scope": "apisix",
+"use_jwks": true,
+"token_signing_alg_values_expected": "RS256"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/hello"
+}]],
+[[{ "node": {
+"value": {
+"plugins": {
+"openid-connect": {
+"client_id":
"kbyuFDidLLm280LIwVFiazOqjO3ty8KH",
+"client_secret":
"60Op4HFM0I8ajz0WdiStAbziZ-VFQttXuxixHHs2R7r7-CW8GR79l-mmLqMhc-Sa",
+"discovery":
"https://samples.auth0.com/.well-known/openid-configuration";,
+"redirect_uri": "https://iresty.com";,
+"ssl_verify": false,
+"timeout": 10,
+"bearer_only": true,
+"scope": "apisix",
+"use_jwks": true,
+"token_signing_alg_values_expected":
"RS256"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/hello"
+},
+"key": "/apisix/routes/1"
+},
+"action": "set"
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 26: Access route with valid token.
Review comment:
OK. @moonming Let me have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] hepyu opened a new issue #5692: request help: etcd high load, etcd high cpu usage, and "put /data_plane/server_info" have lots of "apply request took too long" error
hepyu opened a new issue #5692: URL: https://github.com/apache/apisix/issues/5692 ### Issue description (1).question 1.question-1： the etcd cluster have 3 nodes, 2 of them has high load and cpu usage, but load and cpu usage of the third node is low, I am so confused： node1 and node2：high load and high cpu usage  node3：load and cpu usage is low  2.question-2： "put /data_plane/server_info" have lots of "apply request took too long" error is this the reason why etcd nodes have high cpu usage and load?  I don't know why this so simple request had so many error requests.  (2). other information the etcd cluster have 3 nodes like this：etcd cluster is ok. And this etcd cluster support two apisix cluster(version: 2.8.0).   ### Environment - apisix version：2.8 - etcd version：3.5.0 - OS： aws linux ami 2 - OpenResty / Nginx version：openresty/1.19.9.1 - apisix-dashboard version, if have: have two , one is 2.8, another is 2.9.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] haozileung commented on issue #4942: bug: upstreaam response http code 302，then we found it was be redirected to an new port 9080
haozileung commented on issue #4942: URL: https://github.com/apache/apisix/issues/4942#issuecomment-986030780 I have encountered exactly the same problem here, using k8s + apisix ingress + jenkins. Changing the port is not a good approach and modified the source code could work but annoying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhangweidongyyl opened a new issue #5693: bug: response_rewrite plugin can not return result
zhangweidongyyl opened a new issue #5693:
URL: https://github.com/apache/apisix/issues/5693
### Issue description
when i write plugin like response_rewrite ,curl can not return result, but
the log is all right,this is why。response_rewrite plugin can right exec
`
do
function _M.body_filter(conf, ctx)
local function push_data(premature, uri,args,result)
if premature then
return
end
local httpc, err = http:new()
if err then
result = "fail create http conn"
end
httpc:set_timeout(time)
httpc:set_timeout(connect_timeout,
send_timeout, read_timeout)
local url = "http://"; .. host_str ..":" .. host_port
local res, err = httpc:request_uri(url,{path = uri,query = args})
if not res then
result = "fail to request"
core.log.error("failed to request : ", err)
return
end
result = result .. res.body
core.log.info("res.body：",res.body)
-- 输出响应体
core.log.info("result:", result)
end
local ok, err = ngx.timer.at(0, push_data,ngx.var.uri,
ngx.var.args,result)
if err then
ngx.log(ngx.ERR, "failed to create timer: ", err)
return
end
if not ok then
ngx.log(ngx.ERR, "failed to create timer: ", err)
return
end
ngx.arg[1] = result
ngx.arg[2] = true
end
end
`
### Environment
- apisix version (cmd: `apisix version`):
- OS (cmd: `uname -a`):
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
### Steps to reproduce
do plugin like this
### Actual result
can right return res
### Error log
no err log
### Expected result
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zhangweidongyyl commented on issue #5693: bug: response_rewrite plugin can not return result
zhangweidongyyl commented on issue #5693: URL: https://github.com/apache/apisix/issues/5693#issuecomment-986035141 plugin log is right ,but curl return curl: (52) Empty reply from server -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Easy-deve opened a new issue #51: request help: does go runner support intercepting response to handle special business
Easy-deve opened a new issue #51: URL: https://github.com/apache/apisix-go-plugin-runner/issues/51 Does the go-runner plug-in support processing the information returned from upstream? If not, can you write an internal plug-in in Lua language to intercept the response to handle special business. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2af5b79) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `1.18%`. > The diff coverage is `89.09%`. > :exclamation: Current head 2af5b79 differs from pull request most recent head 4914e0f. Consider uploading reports for the commit 4914e0f to get more accurate results [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 91.74% -1.19% == Files 13 12 -1 Lines 722 727 +5 == - Hits 671 667 -4 - Misses 51 60 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `94.44% <ø> (-2.33%)` | :arrow_down: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/plugin/cache.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY2FjaGUucHk=) | `94.11% <50.00%> (-5.89%)` | :arrow_down: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `77.19% <75.92%> (-15.22%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `99.09% <99.09%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.74% <100.00%> (-0.26%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4v
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4914e0f) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `0.06%`. > The diff coverage is `91.69%`. [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 92.86% -0.07% == Files 13 12 -1 Lines 722 729 +7 == + Hits 671 677 +6 - Misses 51 52 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `100.00% <ø> (+3.22%)` | :arrow_up: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `88.13% <87.50%> (-4.27%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `99.09% <99.09%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.74% <100.00%> (-0.26%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/cache.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY2FjaGUucHk=) | `100.00% <100.00%> (ø)` | | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [apisix/runner/server/config.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_me
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-986156768 > In addition, can you please add documentation to introduce this feature? sure. Because `exprs` is complex, more configurations may be added in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5676: docs: update MAINTAIN.md
spacewander commented on a change in pull request #5676:
URL: https://github.com/apache/apisix/pull/5676#discussion_r762503645
##
File path: MAINTAIN.md
##
@@ -27,13 +27,15 @@
4. Package a vote artifact to Apache's dev-apisix repo. The artifact can be
created
via `VERSION=x.y.z make release-src`
5. Send the [vote
email](https://lists.apache.org/thread/vq4qtwqro5zowpdqhx51oznbjy87w9d0) to
d...@apisix.apache.org
+ > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `/release` directory
named `apache-apisix-${x.y.z}-vote-contents`
6. When the vote is passed, send the [vote result
email](https://lists.apache.org/thread/k2frnvj4zj9oynsbr7h7nd6n6m3q5p89) to
d...@apisix.apache.org
7. Move the vote artifact to Apache's apisix repo
8. Register the release info in
https://reporter.apache.org/addrelease.html?apisix
9. Create a [GitHub
release](https://github.com/apache/apisix/releases/tag/2.10.2) from the minor
branch
10. Update [APISIX's
website](https://github.com/apache/apisix-website/commit/f9104bdca50015722ab6e3714bbcd2d17e5c5bb3)
11. Update APISIX rpm package
-12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601),
and create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
+> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically
generate rpm package, which can be downloaded from artifacts in action
+12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository](https://github.com/apache/apisix-docker), and
create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10**.2***`
Review comment:
```suggestion
12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository](https://github.com/apache/apisix-docker), and
create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
```
##
File path: MAINTAIN.md
##
@@ -27,13 +27,15 @@
4. Package a vote artifact to Apache's dev-apisix repo. The artifact can be
created
via `VERSION=x.y.z make release-src`
5. Send the [vote
email](https://lists.apache.org/thread/vq4qtwqro5zowpdqhx51oznbjy87w9d0) to
d...@apisix.apache.org
+ > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `/release` directory
named `apache-apisix-${x.y.z}-vote-contents`
Review comment:
```suggestion
> After executing the `VERSION=x.y.z make release-src` command, the
content of the vote email will be automatically generated in the `./release`
directory named `apache-apisix-${x.y.z}-vote-contents`
```
##
File path: MAINTAIN.md
##
@@ -27,13 +27,15 @@
4. Package a vote artifact to Apache's dev-apisix repo. The artifact can be
created
via `VERSION=x.y.z make release-src`
5. Send the [vote
email](https://lists.apache.org/thread/vq4qtwqro5zowpdqhx51oznbjy87w9d0) to
d...@apisix.apache.org
+ > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `/release` directory
named `apache-apisix-${x.y.z}-vote-contents`
6. When the vote is passed, send the [vote result
email](https://lists.apache.org/thread/k2frnvj4zj9oynsbr7h7nd6n6m3q5p89) to
d...@apisix.apache.org
7. Move the vote artifact to Apache's apisix repo
8. Register the release info in
https://reporter.apache.org/addrelease.html?apisix
9. Create a [GitHub
release](https://github.com/apache/apisix/releases/tag/2.10.2) from the minor
branch
10. Update [APISIX's
website](https://github.com/apache/apisix-website/commit/f9104bdca50015722ab6e3714bbcd2d17e5c5bb3)
11. Update APISIX rpm package
-12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601),
and create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
+> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically
generate rpm package, which can be downloaded from artifacts in action
Review comment:
```suggestion
> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically submit
the rpm package to yum repo
```
##
File path: MAINTAIN.md
##
@@ -42,12 +44,14 @@ via `VERSION=x.y.z make release-src`
2. Package a vote artifact to Apache's dev-apisix repo. The artifact can be
created
via `VERSIO
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #51: request help: does go runner support intercepting response to handle special business
spacewander commented on issue #51: URL: https://github.com/apache/apisix-go-plugin-runner/issues/51#issuecomment-986158339 Not support yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander closed issue #50: bug: 如果配置了plugin，前端调用的时候就会跨域
spacewander closed issue #50: URL: https://github.com/apache/apisix-go-plugin-runner/issues/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #50: bug: 如果配置了plugin，前端调用的时候就会跨域
spacewander commented on issue #50: URL: https://github.com/apache/apisix-go-plugin-runner/issues/50#issuecomment-986158403 Look like an issue of your MicroserviceFilter plugin, which is not provided by this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander closed issue #49: register plugin success but do not match it when i visit the route
spacewander closed issue #49: URL: https://github.com/apache/apisix-go-plugin-runner/issues/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5683: bug: The Function is contrary For ip-restriction plugin
spacewander commented on issue #5683: URL: https://github.com/apache/apisix/issues/5683#issuecomment-986160217 Only APISIX 2.2+ can support OpenResty 1.19+ Could you upgrade the APISIX to see if the problem is solved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4958: request help: Mac安装部署报错，Error: Lua interpreter not found at /opt/lua@5.1
spacewander commented on issue #4958: URL: https://github.com/apache/apisix/issues/4958#issuecomment-986161375 Consider solved. Feel free to reopen it if need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #4958: request help: Mac安装部署报错，Error: Lua interpreter not found at /opt/lua@5.1
spacewander closed issue #4958: URL: https://github.com/apache/apisix/issues/4958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] solo-xwz opened a new issue #5694: How to pass custom context in different phases of plugin execution?
solo-xwz opened a new issue #5694: URL: https://github.com/apache/apisix/issues/5694 ### Issue description Such as access and log phases ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5682: fix(patch): add global `math.randomseed` patch support
spacewander commented on pull request #5682: URL: https://github.com/apache/apisix/pull/5682#issuecomment-986166462 Please fix the lint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #5682: fix(patch): add global `math.randomseed` patch support
moonming commented on a change in pull request #5682: URL: https://github.com/apache/apisix/pull/5682#discussion_r762510942 ## File path: apisix/patch.lua ## @@ -86,6 +92,53 @@ do end +-- Inspired by kong.globalpatches +do -- `_G.math.randomseed` patch Review comment: why we need this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5682: fix(patch): add global `math.randomseed` patch support
spacewander commented on a change in pull request #5682:
URL: https://github.com/apache/apisix/pull/5682#discussion_r762510887
##
File path: apisix/patch.lua
##
@@ -86,6 +92,53 @@ do
end
+-- Inspired by kong.globalpatches
+do -- `_G.math.randomseed` patch
+local resty_random = require("resty.random")
+local math_randomseed = math.randomseed
+local seeded = {}
+-- make linter happy
+-- luacheck: ignore
+_G.math.randomseed = function()
+local seed
+local worker_pid = ngx.worker.pid()
+
+-- check seed mark
+if seeded[worker_pid] then
+log(WARN, debug.traceback("attempt to seed already seeded random
number " ..
Review comment:
Let's use DEBUG level log like what kong has done.
##
File path: apisix/patch.lua
##
@@ -86,6 +92,53 @@ do
end
+-- Inspired by kong.globalpatches
+do -- `_G.math.randomseed` patch
+local resty_random = require("resty.random")
+local math_randomseed = math.randomseed
+local seeded = {}
+-- make linter happy
+-- luacheck: ignore
+_G.math.randomseed = function()
+local seed
+local worker_pid = ngx.worker.pid()
+
+-- check seed mark
+if seeded[worker_pid] then
+log(WARN, debug.traceback("attempt to seed already seeded random
number " ..
+ "generator on process #" ..
tostring(worker_pid), 2))
+return
+end
+
+-- get randomseed
+local bytes = resty_random.bytes(8)
+if bytes then
+log(ngx.INFO, "seeding from resty.random.bytes")
+
+local t = {}
+for i = 1, #bytes do
Review comment:
We can check if `#str > 12` here. And we need to comment why 12 is
chosen.
##
File path: apisix/patch.lua
##
@@ -86,6 +92,53 @@ do
end
+-- Inspired by kong.globalpatches
+do -- `_G.math.randomseed` patch
+local resty_random = require("resty.random")
+local math_randomseed = math.randomseed
+local seeded = {}
+-- make linter happy
+-- luacheck: ignore
+_G.math.randomseed = function()
+local seed
+local worker_pid = ngx.worker.pid()
+
+-- check seed mark
+if seeded[worker_pid] then
+log(WARN, debug.traceback("attempt to seed already seeded random
number " ..
+ "generator on process #" ..
tostring(worker_pid), 2))
+return
+end
+
+-- get randomseed
+local bytes = resty_random.bytes(8)
+if bytes then
+log(ngx.INFO, "seeding from resty.random.bytes")
Review comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set
spacewander commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762511228
##
File path: conf/config.yaml
##
@@ -30,6 +30,16 @@
# And then run `export ETCD_HOST=$your_host` before `make init`.
#
# If the configured environment variable can't be found, an error will be
thrown.
+#
+# Also, If you want to use default value when the environment variable not set,
+# Use `${{VAR::default_value}}` instead. For instance:
Review comment:
I am curious why `::` is chosen as the separator. It is different from
the common way. Is there a special reason behind it?
##
File path: apisix/cli/file.lua
##
@@ -65,8 +65,15 @@ local function resolve_conf_var(conf)
local var_used = false
-- we use '${{var}}' because '$var' and '${var}' are taken
-- by Nginx
-local new_val = val:gsub("%$%{%{%s*([%w_]+)%s*%}%}", function(var)
-local v = getenv(var)
+local new_val =
val:gsub("%$%{%{%s*([%w_]+[%:%:[%w%-%.%:%?%/=]+]?)%s*%}%}", function(var)
Review comment:
Why do we need a regex to check the default variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set
spacewander commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762511289
##
File path: apisix/cli/file.lua
##
@@ -65,8 +65,15 @@ local function resolve_conf_var(conf)
local var_used = false
-- we use '${{var}}' because '$var' and '${var}' are taken
-- by Nginx
-local new_val = val:gsub("%$%{%{%s*([%w_]+)%s*%}%}", function(var)
-local v = getenv(var)
+local new_val =
val:gsub("%$%{%{%s*([%w_]+[%:%:[%w%-%.%:%?%/=]+]?)%s*%}%}", function(var)
Review comment:
Why do we need a regex to check the default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5609: bug: error when using the zipkin plugin
spacewander closed issue #5609: URL: https://github.com/apache/apisix/issues/5609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5304: how to support multiple nodes balance on MQTT proxy?
spacewander commented on issue #5304: URL: https://github.com/apache/apisix/issues/5304#issuecomment-986168480 Solved by https://github.com/apache/apisix/pull/5666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5304: how to support multiple nodes balance on MQTT proxy?
spacewander closed issue #5304: URL: https://github.com/apache/apisix/issues/5304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5682: fix(patch): add global `math.randomseed` patch support
tokers commented on a change in pull request #5682: URL: https://github.com/apache/apisix/pull/5682#discussion_r762513934 ## File path: apisix/patch.lua ## @@ -86,6 +92,53 @@ do end +-- Inspired by kong.globalpatches +do -- `_G.math.randomseed` patch Review comment: @moonming Please see https://github.com/apache/apisix/issues/5417 for details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #784: request help: regex_uri in proxy-rewriter
tokers commented on issue #784: URL: https://github.com/apache/apisix-ingress-controller/issues/784#issuecomment-986171321 Please paste more details about the `ApisixRoute` that you created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #779: feat: support regex in path
tokers commented on a change in pull request #779:
URL:
https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762514537
##
File path: pkg/kube/translation/ingress.go
##
@@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing
*networkingv1.Ingress) (*TranslateCo
ctx.addUpstream(ups)
}
uris := []string{pathRule.Path}
- if pathRule.PathType != nil && *pathRule.PathType ==
networkingv1.PathTypePrefix {
- // As per the specification of Ingress path
matching rule:
- // if the last element of the path is a
substring of the
- // last element in request path, it is not a
match, e.g. /foo/bar
- // matches /foo/bar/baz, but does not match
/foo/barbaz.
- // While in APISIX, /foo/bar matches both
/foo/bar/baz and
- // /foo/barbaz.
- // In order to be conformant with Ingress
specification, here
- // we create two paths here, the first is the
path itself
- // (exact match), the other is path + "/*"
(prefix match).
- prefix := pathRule.Path
- if strings.HasSuffix(prefix, "/") {
- prefix += "*"
- } else {
- prefix += "/*"
+ var nginxVars []configv2alpha1.ApisixRouteHTTPMatchExpr
+ if pathRule.PathType != nil {
+ if *pathRule.PathType ==
networkingv1.PathTypePrefix {
+ // As per the specification of Ingress
path matching rule:
+ // if the last element of the path is a
substring of the
+ // last element in request path, it is
not a match, e.g. /foo/bar
+ // matches /foo/bar/baz, but does not
match /foo/barbaz.
+ // While in APISIX, /foo/bar matches
both /foo/bar/baz and
+ // /foo/barbaz.
+ // In order to be conformant with
Ingress specification, here
+ // we create two paths here, the first
is the path itself
+ // (exact match), the other is path +
"/*" (prefix match).
+ prefix := pathRule.Path
+ if strings.HasSuffix(prefix, "/") {
+ prefix += "*"
+ } else {
+ prefix += "/*"
+ }
+ uris = append(uris, prefix)
+ } else if *pathRule.PathType ==
networkingv1.PathTypeImplementationSpecific && useRegex {
+ nginxVars = append(nginxVars,
configv2alpha1.ApisixRouteHTTPMatchExpr{
+ Subject:
configv2alpha1.ApisixRouteHTTPMatchExprSubject{
+ Scope:
configv2alpha1.ScopePath,
+ },
+ Op:
configv2alpha1.OpRegexMatch,
+ Value: &pathRule.Path,
Review comment:
I think we should validate the regex pattern in the admission server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Easy-deve commented on issue #51: request help: does go runner support intercepting response to handle special business
Easy-deve commented on issue #51: URL: https://github.com/apache/apisix-go-plugin-runner/issues/51#issuecomment-986172223 Thanks for replying, I have another idea to be confirmed. I looked at the source code of apisix, and knew that I could get data from upstream in '_M.body_filter'. I want to write a own plug-in and call other services in '_M.body_filter' to perform some business processes. Is this feasible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5692: request help: etcd high load, etcd high cpu usage, and "put /data_plane/server_info" have lots of "apply request took too long" error
tokers commented on issue #5692: URL: https://github.com/apache/apisix/issues/5692#issuecomment-986172247 > the etcd cluster have 3 nodes, 2 of them has high load and cpu usage, but load and cpu usage of the third node is low, I am so confused： Do the 3 nodes have the same hardware configurations? Also, you may check out the file I/O utilizations. > 2.question-2： "put /data_plane/server_info" have lots of "apply request took too long" error What's the frequency settings for the `server-info` plugin, I remember the period is somewhat long (`60s`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5650: request help: etcd tls connect handshake failed
tokers commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986172345 @deepzz0 Please read our replies carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers removed a comment on issue #5650: request help: etcd tls connect handshake failed
tokers removed a comment on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986172345 @deepzz0 Please read our replies carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5650: request help: etcd tls connect handshake failed
tokers commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986172595 I forget the details about lua-resty-http, I'm not sure whether it will set the SNI if the node is pure IP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5650: request help: etcd tls connect handshake failed
tokers commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986172654 @deepzz0 Could you try to preserve only one node in the etcd host and set the SNI to its IP address and check out the result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5653: feat: rocketmq logger
tokers commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r762515837
##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,256 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local type = type
+local ipairs = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local ngx = ngx
+local timer_at = ngx.timer.at
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "array",
+minItems = 1,
+items = {
+type = "string"
+}
+},
+topic = {type = "string"},
+key = {type = "string"},
+tag = {type = "string"},
+timeout = {type = "integer", minimum = 1, default = 3},
+use_tls = {type = "boolean", default = false},
+access_key = {type = "string", default = ""},
+secret_key = {type = "string", default = ""},
+name = {type = "string", default = "rocketmq logger"},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+include_req_body = {type = "boolean", default = false},
+include_req_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+include_resp_body = {type = "boolean", default = false},
+include_resp_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+},
+required = {"nameserver_list", "topic"}
+}
+
+local metadata_schema = {
+type = "object",
+properties = {
+log_format = log_util.metadata_schema_log_format,
+},
+}
+
+local _M = {
+version = 0.1,
+priority = 402,
+name = plugin_name,
+schema = schema,
+metadata_schema = metadata_schema,
+}
+
+
+function _M.check_schema(conf, schema_type)
+if schema_type == core.schema.TYPE_METADATA then
+return core.schema.check(metadata_schema, conf)
+end
+
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return nil, err
+end
+return log_util.check_log_schema(conf)
+end
+
+
+-- remove stale objects from the memory after timer expires
+local function remove_stale_objects(premature)
+if premature then
+return
+end
+
+for key, batch in ipairs(buffers) do
Review comment:
The `buffers` is used as a table, here we should use `pairs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #186: Cannot set skywalking endpoint in helm installation?
tokers commented on issue #186: URL: https://github.com/apache/apisix-helm-chart/issues/186#issuecomment-986173904 > Hi!, The capability to configure `pluginAttrs` was just supported in fews days ago, see https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #5686: feat: add a tool that can help users quickly try your project
tokers commented on pull request #5686: URL: https://github.com/apache/apisix/pull/5686#issuecomment-986174229 @JiaoMaMJ Thanks for your contribution! It's great! Let's resolve the conflicts so that we can merge it to the master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #5695: feat(wasm): allow running in the rewrite phase
spacewander opened a new pull request #5695: URL: https://github.com/apache/apisix/pull/5695 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5650: request help: etcd tls connect handshake failed
tzssangglass commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986175190 > 我忘记了关于lua-resty-http的细节，我不确定如果节点是纯IP的它是否会设置SNI。 see: https://github.com/api7/lua-resty-etcd/pull/146#discussion_r724843510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #2234: chore: update URL for online demo
nic-chen opened a new pull request #2234: URL: https://github.com/apache/apisix-dashboard/pull/2234 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** update URL for online demo **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2234: chore: update URL for online demo
codecov-commenter commented on pull request #2234: URL: https://github.com/apache/apisix-dashboard/pull/2234#issuecomment-986183131 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2234](https://codecov.io/gh/apache/apisix-dashboard/pull/2234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d32df7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `1.75%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2234 +/- ## == - Coverage 69.87% 68.12% -1.76% == Files 184 127 -57 Lines7274 3369-3905 Branches 829 829 == - Hits 5083 2295-2788 + Misses 1897 1074 -823 + Partials 2940 -294 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `68.12% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/handler/stream\_route/stream\_route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3RyZWFtX3JvdXRlL3N0cmVhbV9yb3V0ZS5nbw==) | | | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2234/diff?src=pr&el=t
