[GitHub] [apisix] soham4abc commented on issue #5630: docs: add APISIX software architecture diagram
soham4abc commented on issue #5630: URL: https://github.com/apache/apisix/issues/5630#issuecomment-986185227 I am willing to work on this issue. If possible pls assign! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] soham4abc opened a new pull request #5698: Software architecture diagram added
soham4abc opened a new pull request #5698: URL: https://github.com/apache/apisix/pull/5698 ### What this PR does / why we need it: APISIX software architecture diagram added Fixes #5630 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] soham4abc commented on pull request #5698: docs: Software architecture diagram added
soham4abc commented on pull request #5698: URL: https://github.com/apache/apisix/pull/5698#issuecomment-986186878 PTAL @membphis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set
kevinw66 commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762530881
##
File path: conf/config.yaml
##
@@ -30,6 +30,16 @@
# And then run `export ETCD_HOST=$your_host` before `make init`.
#
# If the configured environment variable can't be found, an error will be
thrown.
+#
+# Also, If you want to use default value when the environment variable not set,
+# Use `${{VAR::default_value}}` instead. For instance:
Review comment:
I want to use `:` in first time, But sometimes default value may
contains it, like etcd.host=${{ETCD_HOST::demo.domain.com:1234}}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set
kevinw66 commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762531135
##
File path: apisix/cli/file.lua
##
@@ -65,8 +65,15 @@ local function resolve_conf_var(conf)
local var_used = false
-- we use '${{var}}' because '$var' and '${var}' are taken
-- by Nginx
-local new_val = val:gsub("%$%{%{%s*([%w_]+)%s*%}%}", function(var)
-local v = getenv(var)
+local new_val =
val:gsub("%$%{%{%s*([%w_]+[%:%:[%w%-%.%:%?%/=]+]?)%s*%}%}", function(var)
Review comment:
If we don't check, It will fail to match when config contains default
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] kevinw66 commented on pull request #5675: feat: support resolve default value when environment not set
kevinw66 commented on pull request #5675: URL: https://github.com/apache/apisix/pull/5675#issuecomment-986190928 BTW, Can you help me to check the ut? I'm confusing about the error log, and it cannot run in my local machine right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path
lxm commented on a change in pull request #779:
URL:
https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762533120
##
File path: pkg/kube/translation/ingress.go
##
@@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing
*networkingv1.Ingress) (*TranslateCo
ctx.addUpstream(ups)
}
uris := []string{pathRule.Path}
- if pathRule.PathType != nil && *pathRule.PathType ==
networkingv1.PathTypePrefix {
- // As per the specification of Ingress path
matching rule:
- // if the last element of the path is a
substring of the
- // last element in request path, it is not a
match, e.g. /foo/bar
- // matches /foo/bar/baz, but does not match
/foo/barbaz.
- // While in APISIX, /foo/bar matches both
/foo/bar/baz and
- // /foo/barbaz.
- // In order to be conformant with Ingress
specification, here
- // we create two paths here, the first is the
path itself
- // (exact match), the other is path + "/*"
(prefix match).
- prefix := pathRule.Path
- if strings.HasSuffix(prefix, "/") {
- prefix += "*"
- } else {
- prefix += "/*"
+ var nginxVars []configv2alpha1.ApisixRouteHTTPMatchExpr
+ if pathRule.PathType != nil {
+ if *pathRule.PathType ==
networkingv1.PathTypePrefix {
+ // As per the specification of Ingress
path matching rule:
+ // if the last element of the path is a
substring of the
+ // last element in request path, it is
not a match, e.g. /foo/bar
+ // matches /foo/bar/baz, but does not
match /foo/barbaz.
+ // While in APISIX, /foo/bar matches
both /foo/bar/baz and
+ // /foo/barbaz.
+ // In order to be conformant with
Ingress specification, here
+ // we create two paths here, the first
is the path itself
+ // (exact match), the other is path +
"/*" (prefix match).
+ prefix := pathRule.Path
+ if strings.HasSuffix(prefix, "/") {
+ prefix += "*"
+ } else {
+ prefix += "/*"
+ }
+ uris = append(uris, prefix)
+ } else if *pathRule.PathType ==
networkingv1.PathTypeImplementationSpecific && useRegex {
+ nginxVars = append(nginxVars,
configv2alpha1.ApisixRouteHTTPMatchExpr{
+ Subject:
configv2alpha1.ApisixRouteHTTPMatchExprSubject{
+ Scope:
configv2alpha1.ScopePath,
+ },
+ Op:
configv2alpha1.OpRegexMatch,
+ Value: &pathRule.Path,
Review comment:
this path comes from ingress resources, I don't thinke we need to do
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed pull request #4957: docs: Update getting-started.md
github-actions[bot] closed pull request #4957: URL: https://github.com/apache/apisix/pull/4957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #4957: docs: Update getting-started.md
github-actions[bot] commented on pull request #4957: URL: https://github.com/apache/apisix/pull/4957#issuecomment-986200605 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #2063: feat: add cache verification tool for dashbaord
github-actions[bot] commented on issue #2063: URL: https://github.com/apache/apisix-dashboard/issues/2063#issuecomment-986200838 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #2010: feat: new authentication framework
github-actions[bot] commented on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-986200835 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (f21a78c -> 6e09d56)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from f21a78c chore(cli): update error command prompt (#5681) add 6e09d56 chore(ext-plugin): we already handled extraInfo (#5685) No new revisions were added by this update. Summary of changes: apisix/plugins/ext-plugin/init.lua | 1 - 1 file changed, 1 deletion(-)
[GitHub] [apisix] spacewander merged pull request #5685: chore(ext-plugin): we already handled extraInfo
spacewander merged pull request #5685: URL: https://github.com/apache/apisix/pull/5685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #5699: test: we don't need to check the response of http://apisix.apache.org
spacewander opened a new pull request #5699: URL: https://github.com/apache/apisix/pull/5699 Once we can connect it, we know the address is resolved by ourselves. Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set
spacewander commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762550515
##
File path: conf/config.yaml
##
@@ -30,6 +30,16 @@
# And then run `export ETCD_HOST=$your_host` before `make init`.
#
# If the configured environment variable can't be found, an error will be
thrown.
+#
+# Also, If you want to use default value when the environment variable not set,
+# Use `${{VAR::default_value}}` instead. For instance:
Review comment:
What about using `:=`? In bash, it means "Assign Default Values".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set
spacewander commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762550646
##
File path: apisix/cli/file.lua
##
@@ -65,8 +65,15 @@ local function resolve_conf_var(conf)
local var_used = false
-- we use '${{var}}' because '$var' and '${var}' are taken
-- by Nginx
-local new_val = val:gsub("%$%{%{%s*([%w_]+)%s*%}%}", function(var)
-local v = getenv(var)
+local new_val =
val:gsub("%$%{%{%s*([%w_]+[%:%:[%w%-%.%:%?%/=]+]?)%s*%}%}", function(var)
Review comment:
Sure. But we don't need to be too strict with `[%w%-%.%:%?%/=]+`? What
if people want to use space in the default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5675: feat: support resolve default value when environment not set
spacewander commented on pull request #5675: URL: https://github.com/apache/apisix/pull/5675#issuecomment-986215789 Solving with https://github.com/apache/apisix/pull/5699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5682: fix(patch): add global `math.randomseed` patch support
spacewander commented on a change in pull request #5682:
URL: https://github.com/apache/apisix/pull/5682#discussion_r762551643
##
File path: .luacheckrc
##
@@ -2,6 +2,13 @@ std = "ngx_lua"
unused_args = false
redefined = false
max_line_length = 100
+
exclude_files = {
"apisix/cli/ngx_tpl.lua",
}
+
+files["apisix/patch.lua"] = {
Review comment:
We can solve in this way, which is consistent:
https://github.com/apache/apisix/blob/6e09d56e9c93666b52fccdeb6e1d3fb1178b678c/apisix/patch.lua#L310-L311
##
File path: apisix/patch.lua
##
@@ -86,6 +92,53 @@ do
end
+-- Inspired by kong.globalpatches
+do -- `_G.math.randomseed` patch
+local resty_random = require("resty.random")
+local math_randomseed = math.randomseed
+local seeded = {}
+-- make linter happy
+-- luacheck: ignore
+_G.math.randomseed = function()
+local seed
+local worker_pid = ngx.worker.pid()
+
+-- check seed mark
+if seeded[worker_pid] then
+log(WARN, debug.traceback("attempt to seed already seeded random
number " ..
+ "generator on process #" ..
tostring(worker_pid), 2))
+return
+end
+
+-- get randomseed
+local bytes = resty_random.bytes(8)
+if bytes then
+log(ngx.INFO, "seeding from resty.random.bytes")
+
+local t = {}
+for i = 1, #bytes do
Review comment:
`for i = 1, min(#bytes, 12) do` should be already OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3610: discuss: `batch-processor` should not depend on plugin `prometheus`
spacewander commented on issue #3610: URL: https://github.com/apache/apisix/issues/3610#issuecomment-986217446 The batch processor depends on prometheus exporter, not the prometheus plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #779: feat: support regex in path
tokers commented on a change in pull request #779:
URL:
https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762553682
##
File path: pkg/kube/translation/ingress.go
##
@@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing
*networkingv1.Ingress) (*TranslateCo
ctx.addUpstream(ups)
}
uris := []string{pathRule.Path}
- if pathRule.PathType != nil && *pathRule.PathType ==
networkingv1.PathTypePrefix {
- // As per the specification of Ingress path
matching rule:
- // if the last element of the path is a
substring of the
- // last element in request path, it is not a
match, e.g. /foo/bar
- // matches /foo/bar/baz, but does not match
/foo/barbaz.
- // While in APISIX, /foo/bar matches both
/foo/bar/baz and
- // /foo/barbaz.
- // In order to be conformant with Ingress
specification, here
- // we create two paths here, the first is the
path itself
- // (exact match), the other is path + "/*"
(prefix match).
- prefix := pathRule.Path
- if strings.HasSuffix(prefix, "/") {
- prefix += "*"
- } else {
- prefix += "/*"
+ var nginxVars []configv2alpha1.ApisixRouteHTTPMatchExpr
+ if pathRule.PathType != nil {
+ if *pathRule.PathType ==
networkingv1.PathTypePrefix {
+ // As per the specification of Ingress
path matching rule:
+ // if the last element of the path is a
substring of the
+ // last element in request path, it is
not a match, e.g. /foo/bar
+ // matches /foo/bar/baz, but does not
match /foo/barbaz.
+ // While in APISIX, /foo/bar matches
both /foo/bar/baz and
+ // /foo/barbaz.
+ // In order to be conformant with
Ingress specification, here
+ // we create two paths here, the first
is the path itself
+ // (exact match), the other is path +
"/*" (prefix match).
+ prefix := pathRule.Path
+ if strings.HasSuffix(prefix, "/") {
+ prefix += "*"
+ } else {
+ prefix += "/*"
+ }
+ uris = append(uris, prefix)
+ } else if *pathRule.PathType ==
networkingv1.PathTypeImplementationSpecific && useRegex {
+ nginxVars = append(nginxVars,
configv2alpha1.ApisixRouteHTTPMatchExpr{
+ Subject:
configv2alpha1.ApisixRouteHTTPMatchExprSubject{
+ Scope:
configv2alpha1.ScopePath,
+ },
+ Op:
configv2alpha1.OpRegexMatch,
+ Value: &pathRule.Path,
Review comment:
Why? Does the Ingress resource validator validate it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #779: feat: support regex in path
tokers commented on a change in pull request #779:
URL:
https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762553776
##
File path: pkg/kube/translation/ingress.go
##
@@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing
*networkingv1.Ingress) (*TranslateCo
ctx.addUpstream(ups)
}
uris := []string{pathRule.Path}
- if pathRule.PathType != nil && *pathRule.PathType ==
networkingv1.PathTypePrefix {
- // As per the specification of Ingress path
matching rule:
- // if the last element of the path is a
substring of the
- // last element in request path, it is not a
match, e.g. /foo/bar
- // matches /foo/bar/baz, but does not match
/foo/barbaz.
- // While in APISIX, /foo/bar matches both
/foo/bar/baz and
- // /foo/barbaz.
- // In order to be conformant with Ingress
specification, here
- // we create two paths here, the first is the
path itself
- // (exact match), the other is path + "/*"
(prefix match).
- prefix := pathRule.Path
- if strings.HasSuffix(prefix, "/") {
- prefix += "*"
- } else {
- prefix += "/*"
+ var nginxVars []configv2alpha1.ApisixRouteHTTPMatchExpr
+ if pathRule.PathType != nil {
+ if *pathRule.PathType ==
networkingv1.PathTypePrefix {
+ // As per the specification of Ingress
path matching rule:
+ // if the last element of the path is a
substring of the
+ // last element in request path, it is
not a match, e.g. /foo/bar
+ // matches /foo/bar/baz, but does not
match /foo/barbaz.
+ // While in APISIX, /foo/bar matches
both /foo/bar/baz and
+ // /foo/barbaz.
+ // In order to be conformant with
Ingress specification, here
+ // we create two paths here, the first
is the path itself
+ // (exact match), the other is path +
"/*" (prefix match).
+ prefix := pathRule.Path
+ if strings.HasSuffix(prefix, "/") {
+ prefix += "*"
+ } else {
+ prefix += "/*"
+ }
+ uris = append(uris, prefix)
+ } else if *pathRule.PathType ==
networkingv1.PathTypeImplementationSpecific && useRegex {
+ nginxVars = append(nginxVars,
configv2alpha1.ApisixRouteHTTPMatchExpr{
+ Subject:
configv2alpha1.ApisixRouteHTTPMatchExprSubject{
+ Scope:
configv2alpha1.ScopePath,
+ },
+ Op:
configv2alpha1.OpRegexMatch,
+ Value: &pathRule.Path,
Review comment:
>
Even it comes from the Ingress, we still have to validate it before
translating, or it cannot be used by APISIX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #5700: fix(batch-processor): we didn't free stale object actually
spacewander opened a new pull request #5700: URL: https://github.com/apache/apisix/pull/5700 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] spacewander commented on pull request #36: refactor: request processing flow
spacewander commented on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-986221540 Could we make codecov pass? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: test: we don't need to check the response of http://apisix.apache.org (#5699)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 319f620 test: we don't need to check the response of
http://apisix.apache.org (#5699)
319f620 is described below
commit 319f6208ba699ac3f353318dd55664376d48314d
Author: 罗泽轩
AuthorDate: Sun Dec 5 20:33:16 2021 +0800
test: we don't need to check the response of http://apisix.apache.org
(#5699)
---
t/misc/patch.t | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/misc/patch.t b/t/misc/patch.t
index b479f07..a735126 100644
--- a/t/misc/patch.t
+++ b/t/misc/patch.t
@@ -144,13 +144,13 @@ apisix:
ngx.log(ngx.ERR, err)
return
end
-ngx.say(res.status)
+ngx.say("ok")
}
}
--- request
GET /t
--- response_body
-200
+ok
@@ -176,11 +176,11 @@ apisix:
ngx.log(ngx.ERR, err)
return ngx.exit(-1)
end
-sock:send(res.status)
+sock:send("ok")
}
--- stream_request eval
m
stream_response: 200
+--- stream_response: ok
--- no_error_log
[error]
[GitHub] [apisix] spacewander merged pull request #5699: test: we don't need to check the response of http://apisix.apache.org
spacewander merged pull request #5699: URL: https://github.com/apache/apisix/pull/5699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #746: feat: add v2beta3
tao12345666333 commented on pull request #746: URL: https://github.com/apache/apisix-ingress-controller/pull/746#issuecomment-986224973 ping @tokers @lingsamuel for review, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5700: fix(batch-processor): we didn't free stale object actually
spacewander commented on pull request #5700: URL: https://github.com/apache/apisix/pull/5700#issuecomment-986226127 We have had this problem since v2.0 ~ v2.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander removed a comment on pull request #5700: fix(batch-processor): we didn't free stale object actually
spacewander removed a comment on pull request #5700: URL: https://github.com/apache/apisix/pull/5700#issuecomment-986226127 We have had this problem since v2.0 ~ v2.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5700: fix(batch-processor): we didn't free stale object actually
spacewander commented on pull request #5700: URL: https://github.com/apache/apisix/pull/5700#issuecomment-986229057 TODO: refactor the batch processor after https://github.com/apache/apisix/pull/5653 is merged. We need to refactor so that we can add test for it (currently the removing stale object is triggered after 30min) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5650: request help: etcd tls connect handshake failed
tzssangglass commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986230349 see more: https://github.com/apache/apisix/issues/5155#issuecomment-929948164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #51: request help: does go runner support intercepting response to handle special business
spacewander commented on issue #51: URL: https://github.com/apache/apisix-go-plugin-runner/issues/51#issuecomment-986230804 It depends on whether you need to rewrite the body. Due to Nginx's limitation (you can't suspend the body handling), you can call other services via `ngx.timer.at` async, but you can't rewrite the body with the result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #89: bug: 部署好java的plugin之后，调用报错
tzssangglass commented on issue #89: URL: https://github.com/apache/apisix-java-plugin-runner/issues/89#issuecomment-986230977 > failed to connect to the unix socket unix:/usr/local/apisix/conf/apisix-1.sock: no such file or directory check this error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it st
tzssangglass commented on issue #78: URL: https://github.com/apache/apisix-java-plugin-runner/issues/78#issuecomment-986231043 > 我在 docker 中通过 docker-compose 运行 APISXI，在运行模式下，仍然出现权限被拒绝 see: https://github.com/apache/apisix/discussions/5628#discussioncomment-1713241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #93: bug: HttpRequest.getConfig(this) raise IndexOutOfBoundsException
tzssangglass commented on issue #93: URL: https://github.com/apache/apisix-java-plugin-runner/issues/93#issuecomment-986231150 pls use master branch to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #91: request help: when reload apisix, the java service will be reload too, and during this period, it is not available.
tzssangglass commented on issue #91: URL: https://github.com/apache/apisix-java-plugin-runner/issues/91#issuecomment-986231697 > Is there a better solution The processes of the runner are governed by apisix on runtime, so what is the better solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5694: How to pass custom context in different phases of plugin execution?
spacewander commented on issue #5694: URL: https://github.com/apache/apisix/issues/5694#issuecomment-986232941 You can use the ctx argument. https://github.com/apache/apisix/blob/master/apisix/plugins/zipkin.lua is a good example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2234: chore: update URL for online demo
zaunist commented on pull request #2234: URL: https://github.com/apache/apisix-dashboard/pull/2234#issuecomment-986234060 /LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8205cad) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **decrease** coverage by `18.86%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 68.02% 49.16% -18.87% === Files 127 41 -86 Lines3359 3171 -188 Branches 8260 -826 === - Hits 2285 1559 -726 - Misses 1074 1412 +338 - Partials0 200 +200 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | | | | [web/src/pages/Service/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL3NlcnZpY2UudHM=) | | | | [web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4) | | | | [web/src/pages/Upstream/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/components/Plugin/UI/basic-auth.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9iYXNpYy1hdXRoLnRzeA==) | | | | [web/src/components/Plugin/UI/proxy-mirror.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wcm94eS1taXJyb3IudHN4) | | | | [...ts/Upstream/components/active-check/ReqHeaders.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1JlcUhlYWRlcnMudHN4) | | | | [web/src/pages/Service/Create.tsx](https://code
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8205cad) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **decrease** coverage by `5.51%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 68.02% 62.50% -5.52% == Files 127 57 -70 Lines3359 3905 +546 Branches 8260 -826 == + Hits 2285 2441 +156 - Misses 1074 1180 +106 - Partials0 284 +284 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.94% <ø> (?)` | | | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz) | | | | [web/src/components/Plugin/UI/basic-auth.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9iYXNpYy1hdXRoLnRzeA==) | | | | [...eam/components/active-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9UaW1lb3V0cy50c3g=) | | | | [...tream/components/active-check/Healthy/Interval.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSW50ZXJ2YWwudHN4) | | | | [web/src/pages/User/Logout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ291dC50c3g=) | | | | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | | | | [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | | | | [web/src/components/Upstream/component
[GitHub] [apisix] tzssangglass commented on issue #5672: bug: modify SSL Port not working in 2.10.1
tzssangglass commented on issue #5672: URL: https://github.com/apache/apisix/issues/5672#issuecomment-986235790 can you show the `conf/nginx.conf` after you only do the step 1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5693: bug: response_rewrite plugin can not return result
tzssangglass commented on issue #5693: URL: https://github.com/apache/apisix/issues/5693#issuecomment-986236170 We do not check the code written by the user himself. If the issue is not relevant to the project, I will turn it into a discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d326c13) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **decrease** coverage by `18.86%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 68.02% 49.16% -18.87% === Files 127 41 -86 Lines3359 3171 -188 Branches 8260 -826 === - Hits 2285 1559 -726 - Misses 1074 1412 +338 - Partials0 200 +200 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | | | | [...c/components/Upstream/components/KeepalivePool.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvS2VlcGFsaXZlUG9vbC50c3g=) | | | | [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | | | | [web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4) | | | | [web/src/components/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL3NlcnZpY2UudHM=) | | | | [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | | | | [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | | | | [...components/active-check/HttpsVerifyCertificate.tsx](https://codecov.io/gh/apac
[GitHub] [apisix] tzssangglass commented on issue #5689: request help: how i use cosocket and parse http1.1 responsebody in body_filter
tzssangglass commented on issue #5689: URL: https://github.com/apache/apisix/issues/5689#issuecomment-986236381 the issue is not relevant to the project, I will turn it into a discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5691: request help: how ngx.timer.at get response set for ngx.arg[1] in body_filter?
tzssangglass commented on issue #5691: URL: https://github.com/apache/apisix/issues/5691#issuecomment-986236532 the issue is not relevant to the project, I will turn it into a discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d326c13) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **decrease** coverage by `5.54%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 68.02% 62.48% -5.55% == Files 127 57 -70 Lines3359 3905 +546 Branches 8260 -826 == + Hits 2285 2440 +155 - Misses 1074 1181 +107 - Partials0 284 +284 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.92% <ø> (?)` | | | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ages/Route/components/Step2/RequestRewriteView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL1JlcXVlc3RSZXdyaXRlVmlldy50c3g=) | | | | [web/src/components/Plugin/UI/proxy-mirror.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wcm94eS1taXJyb3IudHN4) | | | | [web/src/components/Upstream/components/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZW91dC50c3g=) | | | | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | | | | [...nents/Upstream/components/ServiceDiscoveryArgs.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvU2VydmljZURpc2NvdmVyeUFyZ3MudHN4) | | | | [...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==) | | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d366fce) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **decrease** coverage by `18.86%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 68.02% 49.16% -18.87% === Files 127 41 -86 Lines3359 3171 -188 Branches 8260 -826 === - Hits 2285 1559 -726 - Misses 1074 1412 +338 - Partials0 200 +200 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...omponents/passive-check/Unhealthy/HttpFailures.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvSHR0cEZhaWx1cmVzLnRzeA==) | | | | [...rc/components/Upstream/components/RetryTimeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUmV0cnlUaW1lb3V0LnRzeA==) | | | | [web/src/pages/Route/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL2luZGV4LnRzeA==) | | | | [web/src/components/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL3NlcnZpY2UudHM=) | | | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | | | | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | | | | [web/src/pages/Setting/Setting.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL1Nl
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d366fce) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **increase** coverage by `0.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 68.02% 68.19% +0.16% == Files 127 57 -70 Lines3359 3905 +546 Branches 8260 -826 == + Hits 2285 2663 +378 + Misses 1074 949 -125 - Partials0 293 +293 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `56.85% <ø> (?)` | | | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==) | | | | [...components/active-check/Unhealthy/HttpFailures.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9IdHRwRmFpbHVyZXMudHN4) | | | | [.../components/passive-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9IZWFsdGh5L0h0dHBTdGF0dXNlcy50c3g=) | | | | [...components/PluginFlow/components/Toolbar/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9Ub29sYmFyL2luZGV4LnRzeA==) | | | | [web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==) | | | | [...ream/components/active-check/Healthy/Successes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvU3VjY2Vzc2VzLnRzeA==) | | | | [...omponents/passive-check/Unhealthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d366fce) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **increase** coverage by `3.34%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 68.02% 71.37% +3.34% == Files 127 57 -70 Lines3359 3905 +546 Branches 8260 -826 == + Hits 2285 2787 +502 + Misses 1074 824 -250 - Partials0 294 +294 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.79% <ø> (?)` | | | backend-e2e-test-ginkgo | `56.85% <ø> (?)` | | | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | | | | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | | | | [web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4) | | | | [web/src/pages/User/Logout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ291dC50c3g=) | | | | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | | | | [web/src/components/PanelSection/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BhbmVsU2VjdGlvbi9pbmRleC50c3g=) | | | | [web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=) | | | | [.../components/passive-check/Healthy/HttpStatuses.tsx](https:/
[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path
lxm commented on a change in pull request #779:
URL:
https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762570713
##
File path: pkg/kube/translation/ingress.go
##
@@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing
*networkingv1.Ingress) (*TranslateCo
ctx.addUpstream(ups)
}
uris := []string{pathRule.Path}
- if pathRule.PathType != nil && *pathRule.PathType ==
networkingv1.PathTypePrefix {
- // As per the specification of Ingress path
matching rule:
- // if the last element of the path is a
substring of the
- // last element in request path, it is not a
match, e.g. /foo/bar
- // matches /foo/bar/baz, but does not match
/foo/barbaz.
- // While in APISIX, /foo/bar matches both
/foo/bar/baz and
- // /foo/barbaz.
- // In order to be conformant with Ingress
specification, here
- // we create two paths here, the first is the
path itself
- // (exact match), the other is path + "/*"
(prefix match).
- prefix := pathRule.Path
- if strings.HasSuffix(prefix, "/") {
- prefix += "*"
- } else {
- prefix += "/*"
+ var nginxVars []configv2alpha1.ApisixRouteHTTPMatchExpr
+ if pathRule.PathType != nil {
+ if *pathRule.PathType ==
networkingv1.PathTypePrefix {
+ // As per the specification of Ingress
path matching rule:
+ // if the last element of the path is a
substring of the
+ // last element in request path, it is
not a match, e.g. /foo/bar
+ // matches /foo/bar/baz, but does not
match /foo/barbaz.
+ // While in APISIX, /foo/bar matches
both /foo/bar/baz and
+ // /foo/barbaz.
+ // In order to be conformant with
Ingress specification, here
+ // we create two paths here, the first
is the path itself
+ // (exact match), the other is path +
"/*" (prefix match).
+ prefix := pathRule.Path
+ if strings.HasSuffix(prefix, "/") {
+ prefix += "*"
+ } else {
+ prefix += "/*"
+ }
+ uris = append(uris, prefix)
+ } else if *pathRule.PathType ==
networkingv1.PathTypeImplementationSpecific && useRegex {
+ nginxVars = append(nginxVars,
configv2alpha1.ApisixRouteHTTPMatchExpr{
+ Subject:
configv2alpha1.ApisixRouteHTTPMatchExprSubject{
+ Scope:
configv2alpha1.ScopePath,
+ },
+ Op:
configv2alpha1.OpRegexMatch,
+ Value: &pathRule.Path,
Review comment:
currently, the apisix-ingress-controller will not validate all the
ingress resource being created? Maybe valiate the ingress resource should be
another feature.
On the other hand, a issue in kubernetes projects
https://github.com/kubernetes/kubernetes/issues/90210
the validation was removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5690: request help: apisix hmac url paramater encode result not equal java ecnode result
tzssangglass commented on issue #5690: URL: https://github.com/apache/apisix/issues/5690#issuecomment-986245534 In fact, APISIX uses `[ngx.escape_uri](https://github.com/openresty/lua-nginx-module#ngxescape_uri)` to escape uri, this way the `+` is translated into a space, I hope this is useful to you: https://www.cnblogs.com/zhengxl5566/p/10783422.html refer to: [1]: https://github.com/openresty/lua-nginx-module/issues/1124 [2]: https://juejin.cn/post/6844903512485134343#heading-6 [3]: https://www.cnblogs.com/zhengxl5566/p/10783422.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] alex8224 opened a new issue #5706: request help: How to route according to the configuration of nacos metadata?
alex8224 opened a new issue #5706: URL: https://github.com/apache/apisix/issues/5706 ### Issue description I use nacos discovery, and for each microservice I register some additional metadata for finer-grained control I know that the traffic-split plugin can match routes at a certain level of granularity As far as I know, this plugin can't match upstreams based on metadata level So, I would like to ask how to do this Tks ### Environment - apisix 2.10.2 - Centos7 - openresty/1.19.3.2 - etcd 3.5.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5654: bug: URI encoding issue
tzssangglass commented on issue #5654: URL: https://github.com/apache/apisix/issues/5654#issuecomment-986250154 ok, I've had a look around and I don't think it's a bug. Nginx will escape the `" ", "#", "%", "&", "+", "?"` and the `%00-%1F` and `%7F-%FF` to follow rfc3986#section-2.2. so I recommend not using %3C in the uri. refer to: https://juejin.cn/post/6844903512485134343#heading-5 cc @tokers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5692: request help: etcd high load, etcd high cpu usage, and "put /data_plane/server_info" have lots of "apply request took too long" error
tzssangglass commented on issue #5692: URL: https://github.com/apache/apisix/issues/5692#issuecomment-986251113 refer to: https://etcd.io/docs/v3.1/faq/#what-does-the-etcd-warning-apply-entries-took-too-long-mean I think it would be more appropriate to look at the etcd dimension for this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5653: feat: rocketmq logger
tzssangglass commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r762583502
##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,256 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local type = type
+local ipairs = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local ngx = ngx
+local timer_at = ngx.timer.at
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "array",
+minItems = 1,
+items = {
+type = "string"
+}
+},
+topic = {type = "string"},
+key = {type = "string"},
+tag = {type = "string"},
+timeout = {type = "integer", minimum = 1, default = 3},
+use_tls = {type = "boolean", default = false},
+access_key = {type = "string", default = ""},
+secret_key = {type = "string", default = ""},
+name = {type = "string", default = "rocketmq logger"},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+include_req_body = {type = "boolean", default = false},
+include_req_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+include_resp_body = {type = "boolean", default = false},
+include_resp_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+},
+required = {"nameserver_list", "topic"}
+}
+
+local metadata_schema = {
+type = "object",
+properties = {
+log_format = log_util.metadata_schema_log_format,
+},
+}
+
+local _M = {
+version = 0.1,
+priority = 402,
+name = plugin_name,
+schema = schema,
+metadata_schema = metadata_schema,
+}
+
+
+function _M.check_schema(conf, schema_type)
+if schema_type == core.schema.TYPE_METADATA then
+return core.schema.check(metadata_schema, conf)
+end
+
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return nil, err
+end
+return log_util.check_log_schema(conf)
+end
+
+
+-- remove stale objects from the memory after timer expires
+local function remove_stale_objects(premature)
+if premature then
+return
+end
+
+for key, batch in ipairs(buffers) do
+if #batch.entry_buffer.entries == 0 and #batch.batch_to_process == 0
then
+core.log.warn("removing batch processor stale object, conf: ",
+ core.json.delay_encode(key))
+buffers[key] = nil
+end
+end
+
+stale_timer_running = false
+end
+
+
+local function create_producer(nameserver_list, producer_config)
+core.log.info("create new rocketmq producer instance")
+local prod = producer.new(nameserver_list, "apisixLogProducer")
Review comment:
In some cases the nameserver_list will be updated. So we need a new
producer with new nameserver_list.
##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,256 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contri
[GitHub] [apisix] tzssangglass commented on a change in pull request #5653: feat: rocketmq logger
tzssangglass commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r762585556
##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,256 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local type = type
+local ipairs = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local ngx = ngx
+local timer_at = ngx.timer.at
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "array",
+minItems = 1,
+items = {
+type = "string"
+}
+},
+topic = {type = "string"},
+key = {type = "string"},
+tag = {type = "string"},
+timeout = {type = "integer", minimum = 1, default = 3},
+use_tls = {type = "boolean", default = false},
+access_key = {type = "string", default = ""},
+secret_key = {type = "string", default = ""},
+name = {type = "string", default = "rocketmq logger"},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+include_req_body = {type = "boolean", default = false},
+include_req_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+include_resp_body = {type = "boolean", default = false},
+include_resp_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+},
+required = {"nameserver_list", "topic"}
+}
+
+local metadata_schema = {
+type = "object",
+properties = {
+log_format = log_util.metadata_schema_log_format,
+},
+}
+
+local _M = {
+version = 0.1,
+priority = 402,
+name = plugin_name,
+schema = schema,
+metadata_schema = metadata_schema,
+}
+
+
+function _M.check_schema(conf, schema_type)
+if schema_type == core.schema.TYPE_METADATA then
+return core.schema.check(metadata_schema, conf)
+end
+
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return nil, err
+end
+return log_util.check_log_schema(conf)
+end
+
+
+-- remove stale objects from the memory after timer expires
+local function remove_stale_objects(premature)
+if premature then
+return
+end
+
+for key, batch in ipairs(buffers) do
+if #batch.entry_buffer.entries == 0 and #batch.batch_to_process == 0
then
+core.log.warn("removing batch processor stale object, conf: ",
+ core.json.delay_encode(key))
+buffers[key] = nil
+end
+end
+
+stale_timer_running = false
+end
+
+
+local function create_producer(nameserver_list, producer_config)
+core.log.info("create new rocketmq producer instance")
+local prod = producer.new(nameserver_list, "apisixLogProducer")
+if producer_config.use_tls then
+prod:setUseTLS(true)
+end
+if producer_config.access_key ~= '' then
+local aclHook = acl_rpchook.new(producer_config.access_key,
producer_config.secret_key)
+prod:addRPCHook(aclHook)
+end
+prod:setTimeout(producer_config.
[GitHub] [apisix] tzssangglass commented on a change in pull request #5675: feat: support resolve default value when environment not set
tzssangglass commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762587621
##
File path: t/cli/test_main.sh
##
@@ -310,6 +310,45 @@ fi
echo "pass: support environment variables in local_conf"
+# should use default value when environment not set
+echo '
+tests:
+key: ${{TEST_ENV::1.1.1.1}}
+' > conf/config.yaml
+
+make init
+
+if ! grep "env TEST_ENV=1.1.1.1;" conf/nginx.conf > /dev/null; then
+echo "failed: should use default value when environment not set"
+exit 1
+fi
+
+echo '
+tests:
+key:
${{TEST_ENV::very-long-domain-with-many-symbols.absolutely-non-exists-123ss.com:1234/path?param1=value1}}
+' > conf/config.yaml
+
+make init
+
+if ! grep "env
TEST_ENV=very-long-domain-with-many-symbols.absolutely-non-exists-123ss.com:1234/path?param1=value1;"
conf/nginx.conf > /dev/null; then
+echo "failed: should use default value when environment not set"
+exit 1
+fi
+
+echo '
+tests:
+key: ${{TEST_ENV::192.168.1.1}}
+' > conf/config.yaml
+
+TEST_ENV=127.0.0.1 make init
+
+if ! grep "env TEST_ENV=127.0.0.1;" conf/nginx.conf > /dev/null; then
+echo "failed: should use default value when environment not set"
+exit 1
+fi
+
+echo "pass: should use default value when environment not set"
Review comment:
we can use `support default value when environment not set` here.
Earlier I suggested taht change `echo "failed: support default value when
environment not set"` to `echo "failed: should use default value when
environment not set"` above is to output exactly that failed test case when it
fails. If the error output is the same for all three tests above, then when an
error occurs we need to take the time to see which one is actually wrong.
I think you can tweak the error output of the test case a little.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
tzssangglass commented on issue #5706: URL: https://github.com/apache/apisix/issues/5706#issuecomment-986265060 > I know that the traffic-split plugin can match routes at a certain level of granularity the ` traffic-split` plugin is not involved in route matching. Are you trying to select upstream based on the additional information obtained in nacos? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #90: bug: serverless-pre-function配置报错
tzssangglass commented on issue #90: URL: https://github.com/apache/apisix-java-plugin-runner/issues/90#issuecomment-986265639 This error is not related to this project. pls go to the APISIX project and submit an issue with a replication example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #90: bug: serverless-pre-function配置报错
tzssangglass closed issue #90: URL: https://github.com/apache/apisix-java-plugin-runner/issues/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #88: request help: can't get header "Authorization" from the request, but other name like "jwt-token" is ok
tzssangglass closed issue #88: URL: https://github.com/apache/apisix-java-plugin-runner/issues/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set
kevinw66 commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762595361
##
File path: t/cli/test_main.sh
##
@@ -310,6 +310,45 @@ fi
echo "pass: support environment variables in local_conf"
+# should use default value when environment not set
+echo '
+tests:
+key: ${{TEST_ENV::1.1.1.1}}
+' > conf/config.yaml
+
+make init
+
+if ! grep "env TEST_ENV=1.1.1.1;" conf/nginx.conf > /dev/null; then
+echo "failed: should use default value when environment not set"
+exit 1
+fi
+
+echo '
+tests:
+key:
${{TEST_ENV::very-long-domain-with-many-symbols.absolutely-non-exists-123ss.com:1234/path?param1=value1}}
+' > conf/config.yaml
+
+make init
+
+if ! grep "env
TEST_ENV=very-long-domain-with-many-symbols.absolutely-non-exists-123ss.com:1234/path?param1=value1;"
conf/nginx.conf > /dev/null; then
+echo "failed: should use default value when environment not set"
+exit 1
+fi
+
+echo '
+tests:
+key: ${{TEST_ENV::192.168.1.1}}
+' > conf/config.yaml
+
+TEST_ENV=127.0.0.1 make init
+
+if ! grep "env TEST_ENV=127.0.0.1;" conf/nginx.conf > /dev/null; then
+echo "failed: should use default value when environment not set"
+exit 1
+fi
+
+echo "pass: should use default value when environment not set"
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set
kevinw66 commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762595417
##
File path: conf/config.yaml
##
@@ -30,6 +30,16 @@
# And then run `export ETCD_HOST=$your_host` before `make init`.
#
# If the configured environment variable can't be found, an error will be
thrown.
+#
+# Also, If you want to use default value when the environment variable not set,
+# Use `${{VAR::default_value}}` instead. For instance:
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set
kevinw66 commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762595427
##
File path: apisix/cli/file.lua
##
@@ -65,8 +65,15 @@ local function resolve_conf_var(conf)
local var_used = false
-- we use '${{var}}' because '$var' and '${var}' are taken
-- by Nginx
-local new_val = val:gsub("%$%{%{%s*([%w_]+)%s*%}%}", function(var)
-local v = getenv(var)
+local new_val =
val:gsub("%$%{%{%s*([%w_]+[%:%:[%w%-%.%:%?%/=]+]?)%s*%}%}", function(var)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
tokers commented on issue #5706: URL: https://github.com/apache/apisix/issues/5706#issuecomment-986342395 @alex8224 You may implement your own balancer and use it in `Upstream` objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
tokers commented on issue #5706: URL: https://github.com/apache/apisix/issues/5706#issuecomment-986342755 > @alex8224 You may implement your own balancer and use it in `Upstream` objects. See https://apisix.apache.org/blog/2021/07/28/release-apache-apisix-2.8/#new-way-to-develop-support-for-custom-balancer . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5650: request help: etcd tls connect handshake failed
tokers commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986343505 If so, the TLS handshaking should succeed, @deepzz0 Could you try to capture some TLS handshaking packages? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #779: feat: support regex in path
tokers commented on a change in pull request #779:
URL:
https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762646731
##
File path: pkg/kube/translation/ingress.go
##
@@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing
*networkingv1.Ingress) (*TranslateCo
ctx.addUpstream(ups)
}
uris := []string{pathRule.Path}
- if pathRule.PathType != nil && *pathRule.PathType ==
networkingv1.PathTypePrefix {
- // As per the specification of Ingress path
matching rule:
- // if the last element of the path is a
substring of the
- // last element in request path, it is not a
match, e.g. /foo/bar
- // matches /foo/bar/baz, but does not match
/foo/barbaz.
- // While in APISIX, /foo/bar matches both
/foo/bar/baz and
- // /foo/barbaz.
- // In order to be conformant with Ingress
specification, here
- // we create two paths here, the first is the
path itself
- // (exact match), the other is path + "/*"
(prefix match).
- prefix := pathRule.Path
- if strings.HasSuffix(prefix, "/") {
- prefix += "*"
- } else {
- prefix += "/*"
+ var nginxVars []configv2alpha1.ApisixRouteHTTPMatchExpr
+ if pathRule.PathType != nil {
+ if *pathRule.PathType ==
networkingv1.PathTypePrefix {
+ // As per the specification of Ingress
path matching rule:
+ // if the last element of the path is a
substring of the
+ // last element in request path, it is
not a match, e.g. /foo/bar
+ // matches /foo/bar/baz, but does not
match /foo/barbaz.
+ // While in APISIX, /foo/bar matches
both /foo/bar/baz and
+ // /foo/barbaz.
+ // In order to be conformant with
Ingress specification, here
+ // we create two paths here, the first
is the path itself
+ // (exact match), the other is path +
"/*" (prefix match).
+ prefix := pathRule.Path
+ if strings.HasSuffix(prefix, "/") {
+ prefix += "*"
+ } else {
+ prefix += "/*"
+ }
+ uris = append(uris, prefix)
+ } else if *pathRule.PathType ==
networkingv1.PathTypeImplementationSpecific && useRegex {
+ nginxVars = append(nginxVars,
configv2alpha1.ApisixRouteHTTPMatchExpr{
+ Subject:
configv2alpha1.ApisixRouteHTTPMatchExprSubject{
+ Scope:
configv2alpha1.ScopePath,
+ },
+ Op:
configv2alpha1.OpRegexMatch,
+ Value: &pathRule.Path,
Review comment:
All right, that'd be unexpected, would you like to submit an issue? I
think we can implement it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #690: bug: Ingress Status Load Balancer IPs Not Being Updated
tao12345666333 commented on issue #690: URL: https://github.com/apache/apisix-ingress-controller/issues/690#issuecomment-986354550 #740 has been merged. I will close this one. Feel free to reopen it. @Bonitas you can try to build apisix-ingress-controller using latest code, or wait for v1.4 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #690: bug: Ingress Status Load Balancer IPs Not Being Updated
tao12345666333 closed issue #690: URL: https://github.com/apache/apisix-ingress-controller/issues/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #746: feat: add v2beta3
tao12345666333 merged pull request #746: URL: https://github.com/apache/apisix-ingress-controller/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55a83f5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **decrease** coverage by `18.86%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 68.02% 49.16% -18.87% === Files 127 41 -86 Lines3359 3171 -188 Branches 8260 -826 === - Hits 2285 1559 -726 - Misses 1074 1412 +338 - Partials0 200 +200 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==) | | | | [...eb/src/components/Upstream/components/TimeUnit.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZVVuaXQudHN4) | | | | [...ts/Upstream/components/active-check/ReqHeaders.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1JlcUhlYWRlcnMudHN4) | | | | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | | | | [...omponents/passive-check/Unhealthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==) | | | | [...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==) | | | | [web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache
[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on pull request #36: refactor: request processing flow
shuaijinchao commented on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-986360390 > After refactoring, the coverage ratio of part of the code is reduced, causing codecov to fail. At present, the core logic of Python has not been completely refactored, and use cases will continue to be added in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55a83f5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **increase** coverage by `0.29%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 68.02% 68.32% +0.29% == Files 127 57 -70 Lines3359 3905 +546 Branches 8260 -826 == + Hits 2285 2668 +383 + Misses 1074 944 -130 - Partials0 293 +293 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `57.13% <ø> (?)` | | | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/pages/SSL/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvc2VydmljZS50cw==) | | | | [web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [...components/active-check/Unhealthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9IdHRwU3RhdHVzZXMudHN4) | | | | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | | | | [web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=) | | | | [.../components/passive-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9IZWFsdGh5L0h0dHBTdGF0dXNlcy50c3g=) | | | | [web/src/pages/SSL/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55a83f5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbcac5f) will **increase** coverage by `3.34%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 68.02% 71.37% +3.34% == Files 127 57 -70 Lines3359 3905 +546 Branches 8260 -826 == + Hits 2285 2787 +502 + Misses 1074 823 -251 - Partials0 295 +295 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `41.07% <ø> (?)` | | | backend-e2e-test-ginkgo | `57.13% <ø> (?)` | | | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz) | | | | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | | | | [web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hY2Nlc3MudHM=) | | | | [...pages/SSL/components/CertificateUploader/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZVVwbG9hZGVyL2luZGV4LnRzeA==) | | | | [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | | | | [web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==) | | | | [...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==) | | | | [web/src/global.tsx](h
[GitHub] [apisix] qq54903099 commented on issue #5690: request help: apisix hmac url paramater encode result not equal java ecnode result
qq54903099 commented on issue #5690: URL: https://github.com/apache/apisix/issues/5690#issuecomment-986362097 > In fact, APISIX uses `[ngx.escape_uri](https://github.com/openresty/lua-nginx-module#ngxescape_uri)` to escape uri, this way the `+` is translated into a space, I hope this is useful to you: https://www.cnblogs.com/zhengxl5566/p/10783422.html refer to: [1]: [openresty/lua-nginx-module#1124](https://github.com/openresty/lua-nginx-module/issues/1124) [2]: https://juejin.cn/post/6844903512485134343#heading-6 [3]: https://www.cnblogs.com/zhengxl5566/p/10783422.html `+` apisix is %20 but in java is %2B `space` apisix is %20 but in java is + `!` apisix is ! but in java is %21 `#` apisix is %24 but in java is %23 `%` apisix is % but in java is %25 `(` apisix is ( but in java is %28 ')' apisix is ) but in java is %29 I don't thin use replace is good idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Baoyuantop commented on a change in pull request #785: docs: Optimize installation documentation
Baoyuantop commented on a change in pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785#discussion_r762653656 ## File path: docs/en/latest/deployments/minikube.md ## @@ -41,7 +40,7 @@ kubectl create ns ingress-apisix helm install apisix apisix/apisix \ --set gateway.type=NodePort \ --set ingress-controller.enabled=true \ - --namespace ingress-apisix + --namespace ingress-apisix \ --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix Review comment: Does it already exist? @tao12345666333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] alex8224 commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
alex8224 commented on issue #5706: URL: https://github.com/apache/apisix/issues/5706#issuecomment-986364982 @tzssangglass yes, I want to select upstream based on metadata obtained in nacos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger
yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r762654690
##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,256 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local type = type
+local ipairs = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local ngx = ngx
+local timer_at = ngx.timer.at
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "array",
+minItems = 1,
+items = {
+type = "string"
+}
+},
+topic = {type = "string"},
+key = {type = "string"},
+tag = {type = "string"},
+timeout = {type = "integer", minimum = 1, default = 3},
+use_tls = {type = "boolean", default = false},
+access_key = {type = "string", default = ""},
+secret_key = {type = "string", default = ""},
+name = {type = "string", default = "rocketmq logger"},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+include_req_body = {type = "boolean", default = false},
+include_req_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+include_resp_body = {type = "boolean", default = false},
+include_resp_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+},
+required = {"nameserver_list", "topic"}
+}
+
+local metadata_schema = {
+type = "object",
+properties = {
+log_format = log_util.metadata_schema_log_format,
+},
+}
+
+local _M = {
+version = 0.1,
+priority = 402,
+name = plugin_name,
+schema = schema,
+metadata_schema = metadata_schema,
+}
+
+
+function _M.check_schema(conf, schema_type)
+if schema_type == core.schema.TYPE_METADATA then
+return core.schema.check(metadata_schema, conf)
+end
+
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return nil, err
+end
+return log_util.check_log_schema(conf)
+end
+
+
+-- remove stale objects from the memory after timer expires
+local function remove_stale_objects(premature)
+if premature then
+return
+end
+
+for key, batch in ipairs(buffers) do
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4914e0f) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **decrease** coverage by `0.06%`. > The diff coverage is `91.69%`. > :exclamation: Current head 4914e0f differs from pull request most recent head f4e83cc. Consider uploading reports for the commit f4e83cc to get more accurate results [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == - Coverage 92.93% 92.86% -0.07% == Files 13 12 -1 Lines 722 729 +7 == + Hits 671 677 +6 - Misses 51 52 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `100.00% <ø> (+3.22%)` | :arrow_up: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `88.13% <87.50%> (-4.27%)` | :arrow_down: | | [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `99.09% <99.09%> (ø)` | | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.74% <100.00%> (-0.26%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/cache.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY2FjaGUucHk=) | `100.00% <100.00%> (ø)` | | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #36: refactor: request processing flow
codecov[bot] edited a comment on pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36#issuecomment-985995139 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#36](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4e83cc) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/fe6f842ab4977820ff812e2f64f9cd2fbb00a62c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f842) will **increase** coverage by `0.06%`. > The diff coverage is `92.05%`. [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #36 +/- ## == + Coverage 92.93% 93.00% +0.06% == Files 13 12 -1 Lines 722 729 +7 == + Hits 671 678 +7 Misses 51 51 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/base.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vYmFzZS5weQ==) | `100.00% <ø> (+3.22%)` | :arrow_up: | | [apisix/runner/server/server.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvc2VydmVyLnB5) | `50.74% <46.42%> (+7.88%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `88.13% <87.50%> (-4.27%)` | :arrow_down: | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `97.74% <100.00%> (-0.26%)` | :arrow_down: | | [apisix/runner/http/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3Jlc3BvbnNlLnB5) | `100.00% <100.00%> (+1.14%)` | :arrow_up: | | [apisix/runner/plugin/cache.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY2FjaGUucHk=) | `100.00% <100.00%> (ø)` | | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [apisix/runner/server/config.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvY29uZmlnLnB5) | `94.11% <100.00%> (ø)` | | | [apisix/runner/server/response.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/36/diff?src=pr&el=tree&ut
[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger
yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r762656485
##
File path: t/plugin/rocketmq-logger.t
##
@@ -0,0 +1,1098 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+run_tests;
+
+__DATA__
+
+=== TEST 1: sanity
+--- config
+location /t {
+content_by_lua_block {
+local plugin = require("apisix.plugins.rocketmq-logger")
+local ok, err = plugin.check_schema({
+ topic = "test",
+ key = "key1",
+ nameserver_list = {
+"127.0.0.1:3"
+ }
+})
+if not ok then
+ngx.say(err)
+end
+ngx.say("done")
+}
+}
+--- request
+GET /t
+--- response_body
+done
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: missing nameserver list
+--- config
+location /t {
+content_by_lua_block {
+local plugin = require("apisix.plugins.rocketmq-logger")
+local ok, err = plugin.check_schema({topic = "test", key= "key1"})
+if not ok then
+ngx.say(err)
+end
+ngx.say("done")
+}
+}
+--- request
+GET /t
+--- response_body
+property "nameserver_list" is required
+done
+--- no_error_log
+[error]
+
+
+
+=== TEST 3: wrong type of string
+--- config
+location /t {
+content_by_lua_block {
+local plugin = require("apisix.plugins.rocketmq-logger")
+local ok, err = plugin.check_schema({
+nameserver_list = {
+"127.0.0.1:3000"
+},
+timeout = "10",
+topic ="test",
+key= "key1"
+})
+if not ok then
+ngx.say(err)
+end
+ngx.say("done")
+}
+}
+--- request
+GET /t
+--- response_body
+property "timeout" validation failed: wrong type: expected integer, got string
+done
+--- no_error_log
+[error]
+
+
+
+=== TEST 4: set route(id: 1)
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"rocketmq-logger": {
+"nameserver_list" : [ "127.0.0.1:9876" ],
+"topic" : "test2",
+"key" : "key1",
+"timeout" : 1,
+"batch_max_size": 1
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/hello"
+}]],
+[[{
+"node": {
+"value": {
+"plugins": {
+ "rocketmq-logger": {
+"nameserver_list" : [ "127.0.0.1:9876" ],
+"topic" : "test2",
+"key" : "key1",
+"timeout" : 1,
+"batch_max_size": 1
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/hello"
+},
+"key": "/apisix/routes/1"
+},
+"action": "set"
+}]]
+)
+if code >= 300 then
+ngx.status = code
+
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (561ad30) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvd
[GitHub] [apisix] leslie-tsang commented on pull request #5698: docs: Software architecture diagram added
leslie-tsang commented on pull request #5698: URL: https://github.com/apache/apisix/pull/5698#issuecomment-986368547 Hello there, Would give it a try to update [zh docs](https://github.com/apache/apisix/blob/master/docs/zh/latest/architecture-design/apisix.md) at the same time ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang edited a comment on pull request #5698: docs: Software architecture diagram added
leslie-tsang edited a comment on pull request #5698: URL: https://github.com/apache/apisix/pull/5698#issuecomment-986368547 Hello there, Would you give it a try to update [zh docs](https://github.com/apache/apisix/blob/master/docs/zh/latest/architecture-design/apisix.md) at the same time ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-python-plugin-runner] branch master updated: refactor: request processing flow (#36)
This is an automated email from the ASF dual-hosted git repository.
shuaijinchao pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/apisix-python-plugin-runner.git
The following commit(s) were added to refs/heads/master by this push:
new 232450b refactor: request processing flow (#36)
232450b is described below
commit 232450b9a11baaad6453700b3b8d78def330475d
Author: 帅进超
AuthorDate: Mon Dec 6 09:58:48 2021 +0800
refactor: request processing flow (#36)
---
.github/workflows/runner-lint.yml | 2 +-
.github/workflows/runner-test.yml | 8 +-
apisix/plugins/rewrite.py | 14 +-
apisix/plugins/stop.py | 7 +-
apisix/runner/http/method.py | 77
apisix/runner/http/request.py | 88 ++---
apisix/runner/http/response.py | 131 +++---
apisix/runner/plugin/base.py | 35
apisix/runner/plugin/cache.py | 2 +
apisix/runner/plugin/core.py | 48 ++---
apisix/runner/server/config.py | 4 +-
apisix/runner/server/handle.py | 198 +
apisix/runner/server/response.py | 2 +-
apisix/runner/server/server.py | 51 --
.../runner/{http/protocol.py => utils/__init__.py} | 9 -
apisix/runner/utils/common.py | 198 +
apisix/main.py => bin/py-runner| 4 +-
{apisix => conf}/config.yaml | 0
docs/en/latest/developer-guide.md | 29 +--
docs/en/latest/getting-started.md | 7 +-
requirements.txt | 2 +-
setup.py | 2 +-
tests/runner/http/test_method.py | 55 --
tests/runner/http/test_protocol.py | 26 ---
tests/runner/http/test_request.py | 122 +
tests/runner/http/test_response.py | 115 ++--
tests/runner/plugin/test_base.py | 4 +
tests/runner/plugin/test_cache.py | 21 +++
tests/runner/plugin/test_core.py | 72
tests/runner/server/test_config.py | 2 +-
tests/runner/server/test_handle.py | 194
tests/runner/server/test_protocol.py | 12 +-
tests/runner/server/test_response.py | 22 ++-
tests/runner/server/test_server.py | 22 ++-
tests/runner/utils/test_common.py | 84 +
35 files changed, 817 insertions(+), 852 deletions(-)
diff --git a/.github/workflows/runner-lint.yml
b/.github/workflows/runner-lint.yml
index 6222861..1372061 100644
--- a/.github/workflows/runner-lint.yml
+++ b/.github/workflows/runner-lint.yml
@@ -37,6 +37,6 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
with:
- python-version: 3.6
+ python-version: 3.7
- name: Lint codes
run: make lint
diff --git a/.github/workflows/runner-test.yml
b/.github/workflows/runner-test.yml
index af36bef..9cd9859 100644
--- a/.github/workflows/runner-test.yml
+++ b/.github/workflows/runner-test.yml
@@ -31,21 +31,25 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
-python-version: [ 3.6, 3.7, 3.8, 3.9 ]
+python-version: [ '3.7', '3.8', '3.9', '3.10' ]
fail-fast: false
steps:
- name: Checkout source codes
uses: actions/checkout@v2
with:
submodules: true
+
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
+
- name: Set up dependencies
run: make setup install
+
- name: Run unit tests
run: make test
+
- name: Upload coverage profile
-if: ${{ matrix.python-version == '3.6' }}
+if: ${{ matrix.python-version == '3.7' }}
run: bash <(curl -s https://codecov.io/bash)
diff --git a/apisix/plugins/rewrite.py b/apisix/plugins/rewrite.py
index af034ea..12543dc 100644
--- a/apisix/plugins/rewrite.py
+++ b/apisix/plugins/rewrite.py
@@ -42,18 +42,10 @@ class Rewrite(Base):
# print(self.config)
# Rewrite request headers
-headers = request.headers
-headers["X-Resp-A6-Runner"] = "Python"
-response.headers = headers
+request.headers["X-Resp-A6-Runner"] = "Python"
# Rewrite request args
-args = request.args
-args["a6_runner"] = "Python"
-response.args = args
+request.args["a6_runner"] = "Python"
# Rewrite request path
-path = request.path
-response.path = path
-
-# Set pl
[GitHub] [apisix-python-plugin-runner] shuaijinchao merged pull request #36: refactor: request processing flow
shuaijinchao merged pull request #36: URL: https://github.com/apache/apisix-python-plugin-runner/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger
yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r762658128
##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,256 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local type = type
+local ipairs = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local ngx = ngx
+local timer_at = ngx.timer.at
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "array",
+minItems = 1,
+items = {
+type = "string"
+}
+},
+topic = {type = "string"},
+key = {type = "string"},
+tag = {type = "string"},
+timeout = {type = "integer", minimum = 1, default = 3},
+use_tls = {type = "boolean", default = false},
+access_key = {type = "string", default = ""},
+secret_key = {type = "string", default = ""},
+name = {type = "string", default = "rocketmq logger"},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+include_req_body = {type = "boolean", default = false},
+include_req_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+include_resp_body = {type = "boolean", default = false},
+include_resp_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+},
+required = {"nameserver_list", "topic"}
+}
+
+local metadata_schema = {
+type = "object",
+properties = {
+log_format = log_util.metadata_schema_log_format,
+},
+}
+
+local _M = {
+version = 0.1,
+priority = 402,
+name = plugin_name,
+schema = schema,
+metadata_schema = metadata_schema,
+}
+
+
+function _M.check_schema(conf, schema_type)
+if schema_type == core.schema.TYPE_METADATA then
+return core.schema.check(metadata_schema, conf)
+end
+
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return nil, err
+end
+return log_util.check_log_schema(conf)
+end
+
+
+-- remove stale objects from the memory after timer expires
+local function remove_stale_objects(premature)
+if premature then
+return
+end
+
+for key, batch in ipairs(buffers) do
+if #batch.entry_buffer.entries == 0 and #batch.batch_to_process == 0
then
+core.log.warn("removing batch processor stale object, conf: ",
+ core.json.delay_encode(key))
+buffers[key] = nil
+end
+end
+
+stale_timer_running = false
+end
+
+
+local function create_producer(nameserver_list, producer_config)
+core.log.info("create new rocketmq producer instance")
+local prod = producer.new(nameserver_list, "apisixLogProducer")
+if producer_config.use_tls then
+prod:setUseTLS(true)
+end
+if producer_config.access_key ~= '' then
+local aclHook = acl_rpchook.new(producer_config.access_key,
producer_config.secret_key)
+prod:addRPCHook(aclHook)
+end
+prod:setTimeout(producer_config.timeout
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (561ad30) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `1.65%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 69.87% 68.22% -1.66% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2664-2419 + Misses 1897 948 -949 + Partials 294 293 -1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `56.87% <ø> (+5.27%)` | :arrow_up: | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `32.11% <0.00%> (-35.41%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `60.00% <0.00%> (-13.00%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.24% <0.00%> (-3.94%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.54% <0.00%> (-2.09%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `84.48% <0.00%> (-1.73%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (561ad30) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b86ff4) will **increase** coverage by `1.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 69.87% 71.16% +1.28% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2779-2304 + Misses 1897 831-1066 - Partials 294 295 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.38% <ø> (-4.15%)` | :arrow_down: | | backend-e2e-test-ginkgo | `56.87% <ø> (+5.27%)` | :arrow_up: | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.24% <0.00%> (-3.94%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `89.58% <0.00%> (-1.05%)` | :arrow_down: | | [...nents/Upstream/components/active-check/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1RpbWVvdXQudHN4) | | | | [web/src/pages/Route/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL2luZGV4LnRzeA==) | | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | | | | [web/src/pages/SSL/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundat
[GitHub] [apisix] spacewander commented on a change in pull request #5682: fix(patch): add global `math.randomseed` patch support
spacewander commented on a change in pull request #5682: URL: https://github.com/apache/apisix/pull/5682#discussion_r762658450 ## File path: apisix/patch.lua ## @@ -86,6 +93,64 @@ do end +do -- `_G.math.randomseed` patch Review comment: ```suggestion do -- `math.randomseed` patch ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5700: fix(batch-processor): we didn't free stale object actually
spacewander merged pull request #5700: URL: https://github.com/apache/apisix/pull/5700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger
yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r762658128
##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,256 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local type = type
+local ipairs = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local ngx = ngx
+local timer_at = ngx.timer.at
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "array",
+minItems = 1,
+items = {
+type = "string"
+}
+},
+topic = {type = "string"},
+key = {type = "string"},
+tag = {type = "string"},
+timeout = {type = "integer", minimum = 1, default = 3},
+use_tls = {type = "boolean", default = false},
+access_key = {type = "string", default = ""},
+secret_key = {type = "string", default = ""},
+name = {type = "string", default = "rocketmq logger"},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+include_req_body = {type = "boolean", default = false},
+include_req_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+include_resp_body = {type = "boolean", default = false},
+include_resp_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+},
+required = {"nameserver_list", "topic"}
+}
+
+local metadata_schema = {
+type = "object",
+properties = {
+log_format = log_util.metadata_schema_log_format,
+},
+}
+
+local _M = {
+version = 0.1,
+priority = 402,
+name = plugin_name,
+schema = schema,
+metadata_schema = metadata_schema,
+}
+
+
+function _M.check_schema(conf, schema_type)
+if schema_type == core.schema.TYPE_METADATA then
+return core.schema.check(metadata_schema, conf)
+end
+
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return nil, err
+end
+return log_util.check_log_schema(conf)
+end
+
+
+-- remove stale objects from the memory after timer expires
+local function remove_stale_objects(premature)
+if premature then
+return
+end
+
+for key, batch in ipairs(buffers) do
+if #batch.entry_buffer.entries == 0 and #batch.batch_to_process == 0
then
+core.log.warn("removing batch processor stale object, conf: ",
+ core.json.delay_encode(key))
+buffers[key] = nil
+end
+end
+
+stale_timer_running = false
+end
+
+
+local function create_producer(nameserver_list, producer_config)
+core.log.info("create new rocketmq producer instance")
+local prod = producer.new(nameserver_list, "apisixLogProducer")
+if producer_config.use_tls then
+prod:setUseTLS(true)
+end
+if producer_config.access_key ~= '' then
+local aclHook = acl_rpchook.new(producer_config.access_key,
producer_config.secret_key)
+prod:addRPCHook(aclHook)
+end
+prod:setTimeout(producer_config.timeout
[apisix] branch master updated (319f620 -> 4df272c)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 319f620 test: we don't need to check the response of http://apisix.apache.org (#5699) add 4df272c fix(batch-processor): we didn't free stale object actually (#5700) No new revisions were added by this update. Summary of changes: apisix/plugins/datadog.lua | 3 ++- apisix/plugins/google-cloud-logging.lua | 4 ++-- apisix/plugins/http-logger.lua | 3 ++- apisix/plugins/kafka-logger.lua | 3 +-- apisix/plugins/skywalking-logger.lua| 4 ++-- apisix/plugins/sls-logger.lua | 3 ++- apisix/plugins/syslog.lua | 4 ++-- apisix/plugins/tcp-logger.lua | 4 ++-- apisix/plugins/udp-logger.lua | 4 ++-- 9 files changed, 17 insertions(+), 15 deletions(-)
[GitHub] [apisix] yuz10 commented on a change in pull request #5653: feat: rocketmq logger
yuz10 commented on a change in pull request #5653:
URL: https://github.com/apache/apisix/pull/5653#discussion_r762658128
##
File path: apisix/plugins/rocketmq-logger.lua
##
@@ -0,0 +1,256 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local log_util = require("apisix.utils.log-util")
+local producer = require ("resty.rocketmq.producer")
+local acl_rpchook = require("resty.rocketmq.acl_rpchook")
+local batch_processor = require("apisix.utils.batch-processor")
+local plugin = require("apisix.plugin")
+
+local type = type
+local ipairs = ipairs
+local plugin_name = "rocketmq-logger"
+local stale_timer_running = false
+local ngx = ngx
+local timer_at = ngx.timer.at
+local buffers = {}
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+type = "object",
+properties = {
+meta_format = {
+type = "string",
+default = "default",
+enum = {"default", "origin"},
+},
+nameserver_list = {
+type = "array",
+minItems = 1,
+items = {
+type = "string"
+}
+},
+topic = {type = "string"},
+key = {type = "string"},
+tag = {type = "string"},
+timeout = {type = "integer", minimum = 1, default = 3},
+use_tls = {type = "boolean", default = false},
+access_key = {type = "string", default = ""},
+secret_key = {type = "string", default = ""},
+name = {type = "string", default = "rocketmq logger"},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+include_req_body = {type = "boolean", default = false},
+include_req_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+include_resp_body = {type = "boolean", default = false},
+include_resp_body_expr = {
+type = "array",
+minItems = 1,
+items = {
+type = "array",
+items = {
+type = "string"
+}
+}
+},
+},
+required = {"nameserver_list", "topic"}
+}
+
+local metadata_schema = {
+type = "object",
+properties = {
+log_format = log_util.metadata_schema_log_format,
+},
+}
+
+local _M = {
+version = 0.1,
+priority = 402,
+name = plugin_name,
+schema = schema,
+metadata_schema = metadata_schema,
+}
+
+
+function _M.check_schema(conf, schema_type)
+if schema_type == core.schema.TYPE_METADATA then
+return core.schema.check(metadata_schema, conf)
+end
+
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return nil, err
+end
+return log_util.check_log_schema(conf)
+end
+
+
+-- remove stale objects from the memory after timer expires
+local function remove_stale_objects(premature)
+if premature then
+return
+end
+
+for key, batch in ipairs(buffers) do
+if #batch.entry_buffer.entries == 0 and #batch.batch_to_process == 0
then
+core.log.warn("removing batch processor stale object, conf: ",
+ core.json.delay_encode(key))
+buffers[key] = nil
+end
+end
+
+stale_timer_running = false
+end
+
+
+local function create_producer(nameserver_list, producer_config)
+core.log.info("create new rocketmq producer instance")
+local prod = producer.new(nameserver_list, "apisixLogProducer")
+if producer_config.use_tls then
+prod:setUseTLS(true)
+end
+if producer_config.access_key ~= '' then
+local aclHook = acl_rpchook.new(producer_config.access_key,
producer_config.secret_key)
+prod:addRPCHook(aclHook)
+end
+prod:setTimeout(producer_config.timeout
[GitHub] [apisix] spacewander commented on a change in pull request #5676: docs: update MAINTAIN.md
spacewander commented on a change in pull request #5676:
URL: https://github.com/apache/apisix/pull/5676#discussion_r762659173
##
File path: MAINTAIN.md
##
@@ -44,14 +45,14 @@ via `VERSION=x.y.z make release-src`
2. Package a vote artifact to Apache's dev-apisix repo. The artifact can be
created
via `VERSION=x.y.z make release-src`
3. Send the [vote
email](https://lists.apache.org/thread/q8zq276o20r5r9qjkg074nfzb77xwry9) to
d...@apisix.apache.org
- > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `/release` directory
named `apache-apisix-${x.y.z}-vote-contents`
+ > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `./release` directory
named `apache-apisix-${x.y.z}-vote-contents`
4. When the vote is passed, send the [vote result
email](https://lists.apache.org/thread/p1m9s116rojlhb91g38cj8646393qkz7) to
d...@apisix.apache.org
5. Move the vote artifact to Apache's apisix repo
6. Register the release info in
https://reporter.apache.org/addrelease.html?apisix
7. Create a [GitHub
release](https://github.com/apache/apisix/releases/tag/2.10.0) from the minor
branch
8. Merge the pull request into master branch
9. Update [APISIX's
website](https://github.com/apache/apisix-website/commit/7bf0ab5a1bbd795e6571c4bb89a6e646115e7ca3)
10. Update APISIX rpm package.
-> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically
generate rpm package, which can be downloaded from artifacts in action
+> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically submit
the rpm package to yum repo
11. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository](https://github.com/apache/apisix-docker), and
create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
Review comment:
```suggestion
11. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository](https://github.com/apache/apisix-docker), and
create new branch from master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
```
##
File path: MAINTAIN.md
##
@@ -27,15 +27,16 @@
4. Package a vote artifact to Apache's dev-apisix repo. The artifact can be
created
via `VERSION=x.y.z make release-src`
5. Send the [vote
email](https://lists.apache.org/thread/vq4qtwqro5zowpdqhx51oznbjy87w9d0) to
d...@apisix.apache.org
- > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `/release` directory
named `apache-apisix-${x.y.z}-vote-contents`
+ > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `./release` directory
named `apache-apisix-${x.y.z}-vote-contents`
6. When the vote is passed, send the [vote result
email](https://lists.apache.org/thread/k2frnvj4zj9oynsbr7h7nd6n6m3q5p89) to
d...@apisix.apache.org
7. Move the vote artifact to Apache's apisix repo
8. Register the release info in
https://reporter.apache.org/addrelease.html?apisix
9. Create a [GitHub
release](https://github.com/apache/apisix/releases/tag/2.10.2) from the minor
branch
10. Update [APISIX's
website](https://github.com/apache/apisix-website/commit/f9104bdca50015722ab6e3714bbcd2d17e5c5bb3)
11. Update APISIX rpm package
-> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically
generate rpm package, which can be downloaded from artifacts in action
-12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository](https://github.com/apache/apisix-docker), and
create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10**.2***`
+> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically submit
the
+package to yum repo
+12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository](https://github.com/apache/apisix-docker), and
create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
Review comment:
```suggestion
12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository]
[apisix] branch master updated (4df272c -> 2d32547)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4df272c fix(batch-processor): we didn't free stale object actually (#5700) add 2d32547 chore: upgrade tinyyaml to 0.4.1 (#5678) No new revisions were added by this update. Summary of changes: rockspec/apisix-master-0.rockspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [apisix] spacewander merged pull request #5678: chore: upgrade tinyyaml to 0.4.1
spacewander merged pull request #5678: URL: https://github.com/apache/apisix/pull/5678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #5698: docs: Software architecture diagram added
moonming commented on pull request #5698: URL: https://github.com/apache/apisix/pull/5698#issuecomment-986375305 > we can add issue for Chinese developers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: Software architecture diagram added (#5698)
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 31f99bc docs: Software architecture diagram added (#5698) 31f99bc is described below commit 31f99bc6511395d816dbb99442fb194e4fce838b Author: Soham Banerjee <63705023+soham4...@users.noreply.github.com> AuthorDate: Mon Dec 6 07:42:14 2021 +0530 docs: Software architecture diagram added (#5698) Signed-off-by: Soham Banerjee --- docs/assets/images/flow-software-architecture.png | Bin 0 -> 334625 bytes docs/en/latest/architecture-design/apisix.md | 4 2 files changed, 4 insertions(+) diff --git a/docs/assets/images/flow-software-architecture.png b/docs/assets/images/flow-software-architecture.png new file mode 100644 index 000..633d04c Binary files /dev/null and b/docs/assets/images/flow-software-architecture.png differ diff --git a/docs/en/latest/architecture-design/apisix.md b/docs/en/latest/architecture-design/apisix.md index 558e072..f5d262e 100644 --- a/docs/en/latest/architecture-design/apisix.md +++ b/docs/en/latest/architecture-design/apisix.md @@ -21,6 +21,10 @@ title: APISIX # --> +## Apache APISIX : Software Architecture + + + ## Plugin Loading Process 
[GitHub] [apisix] moonming closed issue #5630: docs: add APISIX software architecture diagram
moonming closed issue #5630: URL: https://github.com/apache/apisix/issues/5630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
