[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (75e9e71) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `7.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 69.87% 62.61% -7.27% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2445-2638 + Misses 1897 1177 -720 + Partials 294 283 -11 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `41.07% <ø> (-3.46%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.13% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: | | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-76.20%)` | :arrow_down: | | [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `0.00% <0.00%> (-53.04%)` | :arrow_down: | | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `8.06% <0.00%> (-51.62%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `23.00% <0.00%> (-44.25%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/stream\_route/stream\_route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3RyZWFtX3JvdXRlL3N0cmVhbV9yb3V0ZS5nbw==) | `36.36% <0.00%> (-31.17%)` | :arrow_down: | |
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #788: fix: ingress LB status records
tao12345666333 opened a new pull request #788: URL: https://github.com/apache/apisix-ingress-controller/pull/788 Signed-off-by: Jintao Zhang Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
spacewander commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763722187
##
File path: apisix/plugins/log-rotate.lua
##
@@ -194,18 +231,33 @@ local function rotate()
core.log.info("rotate interval:", interval)
core.log.info("rotate max keep:", max_kept)
-local time = ngx.time()
-if time % interval == 0 then
-time = time - interval
-else
-time = time - time % interval
+if not default_logs then
+-- first init default log filepath and filename
+default_logs = {}
+init_default_logs(default_logs, DEFAULT_ACCESS_LOG_FILENAME)
+init_default_logs(default_logs, DEFAULT_ERROR_LOG_FILENAME)
end
-local date_str = os.date("%Y-%m-%d_%H-%M-%S", time)
+local now_time = ngx_time()
+if not rotate_time then
+-- first init rotate time
+rotate_time = now_time + interval
+core.log.info("first init rotate time is: ", rotate_time)
+return
+end
+
+if now_time < rotate_time then
+-- did not reach the rotate time
+core.log.info("rotate time: ", rotate_time, " now time: ", now_time)
+return
+end
-local ok1 = rotate_file(date_str, "access.log")
-local ok2 = rotate_file(date_str, "error.log")
-if not ok1 and not ok2 then
+local now_date = os_date("%Y-%m-%dT%H-%M-%S", now_time)
Review comment:
We should use the original format. Changing format without discussion is
a bad idea. Even this seems `more standard`, but it breaks the user's code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (75e9e71) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.74%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.13% -20.75% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1558 -3525 + Misses 1897 1413 -484 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.13% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | |
[GitHub] [apisix] spacewander commented on a change in pull request #5718: docs: refactor Installation Guide
spacewander commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r763718777
##
File path: docs/en/latest/how-to-build.md
##
@@ -94,6 +95,23 @@ Please refer to: [Installing Apache APISIX with Helm
Chart](https://github.com/a
make install
```
+## Step 2: Install ETCD
+
+This step is required when installing Apache APISIX via RPM or Docker.
Review comment:
Maybe we have an independent doc for "install from source"?
##
File path: docs/en/latest/how-to-build.md
##
@@ -94,6 +95,23 @@ Please refer to: [Installing Apache APISIX with Helm
Chart](https://github.com/a
make install
```
+## Step 2: Install ETCD
+
+This step is required when installing Apache APISIX via RPM or Docker.
+
+You can install ETCD via Docker or binary etc. The following command installs
ETCD via binary.
+
+```shell
+ETCD_VERSION='3.4.13'
+wget
https://github.com/etcd-io/etcd/releases/download/v${ETCD_VERSION}/etcd-v${ETCD_VERSION}-linux-amd64.tar.gz
+tar -xvf etcd-v${ETCD_VERSION}-linux-amd64.tar.gz && \
+cd etcd-v${ETCD_VERSION}-linux-amd64 && \
+sudo cp -a etcd etcdctl /usr/bin/
+nohup etcd &
+```
+
+Note: When ETCD is started with the command `nohup etcd &`, the data in ETCD
is not stored persistently. For more information on ETCD, please refer to the
[ETCD documentation](https://etcd.io/docs/).
Review comment:
`When ETCD is started with the command `nohup etcd &`, the data in ETCD
is not stored persistently.` This statement is incorrect. We can remove it as
this is not a doc about etcd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] SylviaBABY opened a new pull request #796: docs: add Shivam committer Chinese version blog
SylviaBABY opened a new pull request #796: URL: https://github.com/apache/apisix-website/pull/796 Changes: Add Chinese version of Shivam committer blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3231: request help: how to use apisix with zookeeper service discovery
spacewander commented on issue #3231: URL: https://github.com/apache/apisix/issues/3231#issuecomment-987655214 Note that dubbo's zookeeper service discovery has some special dubbo relative logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #52: request help: pkgHttp.Request can't handle body data?
spacewander commented on issue #52: URL: https://github.com/apache/apisix-go-plugin-runner/issues/52#issuecomment-987654700 The feature is not supported yet, but is already in our plan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zero-create opened a new issue #5723: apisix长时间运行，etcd CPU占用升高
zero-create opened a new issue #5723: URL: https://github.com/apache/apisix/issues/5723 apisix版本 2.10.1，etcd 版本3.4.15，docker部署，长时间运行，etcd CPU逐渐升高，最高时CPU到80%，关闭apisix，etcd CPU就下降， etcd日志偶尔有以下打印： 2021-12-07 06:23:26.982193 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (136.668999ms) to execute 2021-12-07 06:44:00.043365 W | etcdserver: request "header: lease_revoke:" with result "size:31" took too long (234.484595ms) to execute 2021-12-07 07:18:17.082965 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (108.981903ms) to execute 2021-12-07 07:48:59.565930 W | etcdserver: request "header: lease_revoke:" with result "size:31" took too long (201.968585ms) to execute 2021-12-07 08:22:52.752530 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (127.81604ms) to execute 2021-12-07 08:36:01.713813 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (102.883766ms) to execute 2021-12-07 09:05:49.631922 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (101.036581ms) to execute 2021-12-07 09:09:40.330354 W | etcdserver: request "header: put:" with result "size:286" took too long (149.166486ms) to execute 2021-12-07 09:14:59.524125 W | etcdserver: request "header: put:" with result "size:286" took too long (217.955465ms) to execute -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (3d5f554 -> a4b6931)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 3d5f554 docs: update README.md (#5713) add a4b6931 feat(wasm): allow running in the rewrite phase (#5695) No new revisions were added by this update. Summary of changes: apisix/cli/ops.lua | 243 +--- apisix/cli/schema.lua | 274 apisix/core/config_local.lua| 4 + apisix/discovery/consul_kv/init.lua | 3 - apisix/discovery/dns/init.lua | 4 - apisix/discovery/eureka/init.lua| 4 - apisix/discovery/nacos/init.lua | 4 - apisix/init.lua | 20 +-- apisix/wasm.lua | 14 +- docs/en/latest/wasm.md | 3 +- t/wasm/route.t | 35 - 11 files changed, 333 insertions(+), 275 deletions(-) create mode 100644 apisix/cli/schema.lua
[GitHub] [apisix] spacewander merged pull request #5695: feat(wasm): allow running in the rewrite phase
spacewander merged pull request #5695: URL: https://github.com/apache/apisix/pull/5695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
shuaijinchao commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763696459
##
File path: apisix/plugins/log-rotate.lua
##
@@ -194,18 +231,33 @@ local function rotate()
core.log.info("rotate interval:", interval)
core.log.info("rotate max keep:", max_kept)
-local time = ngx.time()
-if time % interval == 0 then
-time = time - interval
-else
-time = time - time % interval
+if not default_logs then
+-- first init default log filepath and filename
+default_logs = {}
+init_default_logs(default_logs, DEFAULT_ACCESS_LOG_FILENAME)
+init_default_logs(default_logs, DEFAULT_ERROR_LOG_FILENAME)
end
-local date_str = os.date("%Y-%m-%d_%H-%M-%S", time)
+local now_time = ngx_time()
Review comment:
yes, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] wgs111 commented on issue #136: How does the ingress controller work well with dashboard without relying on the Apache APISIX-Admin api?
wgs111 commented on issue #136: URL: https://github.com/apache/apisix-ingress-controller/issues/136#issuecomment-987634885 do we have a plan to support apisix stand-alone mode in the future? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path
tao12345666333 commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987633377 re-run all jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6ffcb1e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **increase** coverage by `1.36%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 69.87% 71.24% +1.36% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2782-2301 + Misses 1897 828-1069 - Partials 294 295 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.81% <ø> (-3.72%)` | :arrow_down: | | backend-e2e-test-ginkgo | `56.69% <ø> (+5.09%)` | :arrow_up: | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `46.45% <0.00%> (-4.73%)` | :arrow_down: | | [...components/active-check/Unhealthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9IdHRwU3RhdHVzZXMudHN4) | | | | [web/src/app.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hcHAudHN4) | | | | [web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz) | | | | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | | | | [...mponents/PluginFlow/components/FlowGraph/shapes.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvc2hhcGVzLnRz) | | | | [web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=) | | | | [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6ffcb1e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `1.78%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 69.87% 68.09% -1.79% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2659-2424 + Misses 1897 954 -943 + Partials 294 292 -2 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `56.69% <ø> (+5.09%)` | :arrow_up: | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `32.11% <0.00%> (-35.41%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `60.00% <0.00%> (-13.00%)` | :arrow_down: | | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `53.19% <0.00%> (-8.52%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `46.45% <0.00%> (-4.73%)` | :arrow_down: | | [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | `75.00% <0.00%> (-3.13%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.02% <0.00%> (-2.61%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `84.48% <0.00%> (-1.73%)` | :arrow_down: | |
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
shuaijinchao commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763689392
##
File path: apisix/plugins/log-rotate.lua
##
@@ -194,18 +231,33 @@ local function rotate()
core.log.info("rotate interval:", interval)
core.log.info("rotate max keep:", max_kept)
-local time = ngx.time()
-if time % interval == 0 then
-time = time - interval
-else
-time = time - time % interval
+if not default_logs then
+-- first init default log filepath and filename
+default_logs = {}
+init_default_logs(default_logs, DEFAULT_ACCESS_LOG_FILENAME)
+init_default_logs(default_logs, DEFAULT_ERROR_LOG_FILENAME)
end
-local date_str = os.date("%Y-%m-%d_%H-%M-%S", time)
+local now_time = ngx_time()
+if not rotate_time then
+-- first init rotate time
+rotate_time = now_time + interval
+core.log.info("first init rotate time is: ", rotate_time)
+return
+end
+
+if now_time < rotate_time then
+-- did not reach the rotate time
+core.log.info("rotate time: ", rotate_time, " now time: ", now_time)
+return
+end
-local ok1 = rotate_file(date_str, "access.log")
-local ok2 = rotate_file(date_str, "error.log")
-if not ok1 and not ok2 then
+local now_date = os_date("%Y-%m-%dT%H-%M-%S", now_time)
Review comment:
The current time format follows the rfc3339 specification. Compared with
underscore, I think this format is more standard, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6ffcb1e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
shuaijinchao commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763689392
##
File path: apisix/plugins/log-rotate.lua
##
@@ -194,18 +231,33 @@ local function rotate()
core.log.info("rotate interval:", interval)
core.log.info("rotate max keep:", max_kept)
-local time = ngx.time()
-if time % interval == 0 then
-time = time - interval
-else
-time = time - time % interval
+if not default_logs then
+-- first init default log filepath and filename
+default_logs = {}
+init_default_logs(default_logs, DEFAULT_ACCESS_LOG_FILENAME)
+init_default_logs(default_logs, DEFAULT_ERROR_LOG_FILENAME)
end
-local date_str = os.date("%Y-%m-%d_%H-%M-%S", time)
+local now_time = ngx_time()
+if not rotate_time then
+-- first init rotate time
+rotate_time = now_time + interval
+core.log.info("first init rotate time is: ", rotate_time)
+return
+end
+
+if now_time < rotate_time then
+-- did not reach the rotate time
+core.log.info("rotate time: ", rotate_time, " now time: ", now_time)
+return
+end
-local ok1 = rotate_file(date_str, "access.log")
-local ok2 = rotate_file(date_str, "error.log")
-if not ok1 and not ok2 then
+local now_date = os_date("%Y-%m-%dT%H-%M-%S", now_time)
Review comment:
The current time format follows the rfc3339 specification. Compared with
the underscore, I think this format is more standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 closed issue #184: Gateway service external IPs should not reference admin external IPs
tao12345666333 closed issue #184: URL: https://github.com/apache/apisix-helm-chart/issues/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #184: Gateway service external IPs should not reference admin external IPs
tao12345666333 commented on issue #184: URL: https://github.com/apache/apisix-helm-chart/issues/184#issuecomment-987626959 #188 has been merged. I will close this one. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #188: Fix condition to use gateway.externalIPs
tao12345666333 commented on pull request #188: URL: https://github.com/apache/apisix-helm-chart/pull/188#issuecomment-987626601 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #188: Fix condition to use gateway.externalIPs
tao12345666333 merged pull request #188: URL: https://github.com/apache/apisix-helm-chart/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: Fix condition to use gateway.externalIPs (#188)
This is an automated email from the ASF dual-hosted git repository.
zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 08c69d4 Fix condition to use gateway.externalIPs (#188)
08c69d4 is described below
commit 08c69d4363a9f46e900ad0b084a74b53e21b40ea
Author: Silas Parker
AuthorDate: Tue Dec 7 07:00:17 2021 +
Fix condition to use gateway.externalIPs (#188)
---
charts/apisix/templates/service-gateway.yaml | 2 +-
charts/apisix/values.yaml| 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/charts/apisix/templates/service-gateway.yaml
b/charts/apisix/templates/service-gateway.yaml
index 6d99468..3a1d4c2 100644
--- a/charts/apisix/templates/service-gateway.yaml
+++ b/charts/apisix/templates/service-gateway.yaml
@@ -40,7 +40,7 @@ spec:
{{- end }}
{{- end }}
{{- end }}
- {{- if gt (len .Values.admin.externalIPs) 0 }}
+ {{- if gt (len .Values.gateway.externalIPs) 0 }}
externalIPs:
{{- range $ip := .Values.gateway.externalIPs }}
- {{ $ip }}
diff --git a/charts/apisix/values.yaml b/charts/apisix/values.yaml
index d150b17..c30d6c9 100644
--- a/charts/apisix/values.yaml
+++ b/charts/apisix/values.yaml
@@ -82,6 +82,7 @@ gateway:
# type: LoadBalancer
# annotations:
# service.beta.kubernetes.io/aws-load-balancer-type: nlb
+ externalIPs: []
http:
enabled: true
servicePort: 80
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #187: feat: add service discovery
tao12345666333 merged pull request #187: URL: https://github.com/apache/apisix-helm-chart/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: feat: add service discovery (#187)
This is an automated email from the ASF dual-hosted git repository.
zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new d730498 feat: add service discovery (#187)
d730498 is described below
commit d73049876c4567668538ce590c8715ae880c9b91
Author: Gallardot
AuthorDate: Tue Dec 7 14:57:51 2021 +0800
feat: add service discovery (#187)
---
charts/apisix/README.md| 27 +++
charts/apisix/templates/_helpers.tpl | 13 +
charts/apisix/templates/configmap.yaml | 8
charts/apisix/values.yaml | 23 +++
4 files changed, 71 insertions(+)
diff --git a/charts/apisix/README.md b/charts/apisix/README.md
index 817336d..427bfc0 100644
--- a/charts/apisix/README.md
+++ b/charts/apisix/README.md
@@ -150,6 +150,33 @@ If etcd.enabled is true, set more values of bitnami/etcd
helm chart use etcd as
Default enabled plugins. See [configmap
template](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/configmap.yaml)
for details.
+### discovery parameters
+
+| Parameter | Description
| Default|
+|-|-||
+| `discovery.enabled` | Enable or disable Apache APISIX
integration service discovery | `false` |
+| `discovery.registry` | Registry is the same to the one in
APISIX
[config-default.yaml](https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L281),
and refer to such file for more setting details. also refer to [this
documentation for integration service
discovery](https://apisix.apache.org/docs/apisix/discovery) | nil |
+
+If you have enabled this feature, here is an example:
+
+```yaml
+discovery:
+ enabled: true
+ registry:
+eureka:
+ host:
+- "http://${username}:${password}@${eureka_host1}:${eureka_port1};
+- "http://${username}:${password}@${eureka_host2}:${eureka_port2};
+ prefix: "/eureka/"
+ fetch_interval: 30
+ weight: 100
+ timeout:
+connect: 2000
+send: 2000
+read: 5000
+```
+
+
### dashboard parameters
Configurations for apisix-dashboard sub chart.
diff --git a/charts/apisix/templates/_helpers.tpl
b/charts/apisix/templates/_helpers.tpl
index 27252c0..a20eb72 100644
--- a/charts/apisix/templates/_helpers.tpl
+++ b/charts/apisix/templates/_helpers.tpl
@@ -61,3 +61,16 @@ Create the name of the service account to use
{{- default "default" .Values.serviceAccount.name }}
{{- end }}
{{- end }}
+
+{{/*
+Renders a value that contains template.
+Usage:
+{{ include "apisix.tplvalues.render" ( dict "value" .Values.path.to.the.Value
"context" $) }}
+*/}}
+{{- define "apisix.tplvalues.render" -}}
+{{- if typeIs "string" .value }}
+{{- tpl .value .context }}
+{{- else }}
+{{- tpl (.value | toYaml) .context }}
+{{- end }}
+{{- end -}}
diff --git a/charts/apisix/templates/configmap.yaml
b/charts/apisix/templates/configmap.yaml
index 9cbb634..2c5657a 100644
--- a/charts/apisix/templates/configmap.yaml
+++ b/charts/apisix/templates/configmap.yaml
@@ -209,6 +209,14 @@ data:
sni: "{{ .Values.etcd.auth.tls.sni }}"
{{- end }}
+{{- if .Values.discovery.enabled }}
+discovery:
+ {{- range $key, $value := .Values.discovery.registry }}
+ {{ $key }}:
+{{- include "apisix.tplvalues.render" (dict "value" $value "context"
$) | nindent 8 }}
+ {{- end }}
+{{- end }}
+
{{- if .Values.plugins }}
plugins: # plugin list
{{- range $plugin := .Values.plugins }}
diff --git a/charts/apisix/values.yaml b/charts/apisix/values.yaml
index 9da5cde..d150b17 100644
--- a/charts/apisix/values.yaml
+++ b/charts/apisix/values.yaml
@@ -213,6 +213,29 @@ customPlugins:
- key: ""
path: ""
+discovery:
+ enabled: false
+ registry:
+ # Integration service discovery registry. E.g eureka\dns\nacos\consul_kv
+ # reference:
+ #
https://apisix.apache.org/docs/apisix/discovery#configuration-for-eureka
+ #
https://apisix.apache.org/docs/apisix/discovery/dns#service-discovery-via-dns
+ #
https://apisix.apache.org/docs/apisix/discovery/consul_kv#configuration-for-consul-kv
+ #
https://apisix.apache.org/docs/apisix/discovery/nacos#configuration-for-nacos
+ #
+ # an eureka example:
+ # eureka:
+ # host:
+ # -
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987622827 @gxthrj @tao12345666333 need a review I think the e2e failure has nothing to do with this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lihuawei321 opened a new issue #5719: bug: 当我使用kafka-logger插件时候，kafka里没有获取到写入时间
lihuawei321 opened a new issue #5719:
URL: https://github.com/apache/apisix/issues/5719
### Issue description
我写入kafka的日志格式是：
[{"client_ip":"192.168.35.122","host":"192.168.9.234","@timestamp":"2021-12-07T10:41:12+08:00","route_id":"363894265081758809"}]
但是kafka显示的没有时间戳
### Environment
- apisix version (cmd: `apisix version`): 2.10
- OS (cmd: `uname -a`): centos7
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have: 2.9
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] zero-create opened a new issue #251: apisix长时间运行，etcd CPU占用升高
zero-create opened a new issue #251: URL: https://github.com/apache/apisix-docker/issues/251 apisix版本 2.10.1，etcd 版本3.4.15，docker部署，长时间运行，etcd CPU逐渐升高，最高时CPU到80%，关闭apisix，etcd CPU就下降， etcd日志偶尔有以下打印： 2021-12-07 06:23:26.982193 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (136.668999ms) to execute 2021-12-07 06:44:00.043365 W | etcdserver: request "header: lease_revoke:" with result "size:31" took too long (234.484595ms) to execute 2021-12-07 07:18:17.082965 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (108.981903ms) to execute 2021-12-07 07:48:59.565930 W | etcdserver: request "header: lease_revoke:" with result "size:31" took too long (201.968585ms) to execute 2021-12-07 08:22:52.752530 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (127.81604ms) to execute 2021-12-07 08:36:01.713813 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (102.883766ms) to execute 2021-12-07 09:05:49.631922 W | etcdserver: request "header: lease_grant:" with result "size:44" took too long (101.036581ms) to execute 2021-12-07 09:09:40.330354 W | etcdserver: request "header: put:" with result "size:286" took too long (149.166486ms) to execute 2021-12-07 09:14:59.524125 W | etcdserver: request "header: put:" with result "size:286" took too long (217.955465ms) to execute -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1b0e4d0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **increase** coverage by `1.49%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 69.87% 71.37% +1.49% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2787-2296 + Misses 1897 823-1074 - Partials 294 295 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `41.02% <ø> (-3.51%)` | :arrow_down: | | backend-e2e-test-ginkgo | `56.38% <ø> (+4.78%)` | :arrow_up: | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `89.58% <0.00%> (-1.05%)` | :arrow_down: | | [...ream/components/active-check/Healthy/Successes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvU3VjY2Vzc2VzLnRzeA==) | | | | [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | | | | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | | | | [...mponents/PluginFlow/components/FlowGraph/shapes.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvc2hhcGVzLnRz) | | | | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | | | | [web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1b0e4d0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `7.24%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 69.87% 62.63% -7.25% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2446-2637 + Misses 1897 1176 -721 + Partials 294 283 -11 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `41.02% <ø> (-3.51%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: | | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-76.20%)` | :arrow_down: | | [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `0.00% <0.00%> (-53.04%)` | :arrow_down: | | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `8.06% <0.00%> (-51.62%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `23.00% <0.00%> (-44.25%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/stream\_route/stream\_route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3RyZWFtX3JvdXRlL3N0cmVhbV9yb3V0ZS5nbw==) | `36.36% <0.00%> (-31.17%)` | :arrow_down: | |
[GitHub] [apisix] JiaoMaMJ commented on pull request #5686: feat: add a tool that can help users quickly try your project
JiaoMaMJ commented on pull request #5686: URL: https://github.com/apache/apisix/pull/5686#issuecomment-987613300 > IMO, we need to discuss in ML first, TeamCode is a commercial product and requires user login to use Hi, I sent a mail to the address: dev-subscr...@apisix.apache.org . Hope the letter will resolve your concerns. Looking forward to your reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1b0e4d0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (068bbcb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `7.90%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 69.87% 61.97% -7.91% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2420-2663 + Misses 1897 1204 -693 + Partials 294 281 -13 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.33% <ø> (-4.20%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: | | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-76.20%)` | :arrow_down: | | [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `0.00% <0.00%> (-53.04%)` | :arrow_down: | | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `8.06% <0.00%> (-51.62%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `23.00% <0.00%> (-44.25%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | |
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5682: fix(patch): add global `math.randomseed` patch support
leslie-tsang commented on a change in pull request #5682:
URL: https://github.com/apache/apisix/pull/5682#discussion_r763666306
##
File path: apisix/patch.lua
##
@@ -86,6 +93,44 @@ do
end
+do -- `math.randomseed` patch
+-- `math.random` generates PRND(pseudo-random numbers) from the seed set
by `math.randomseed`
+-- Many module libraries use `ngx.time` and `ngx.worker.pid` to generate
seeds which may
+-- loss randomness in container env (where pids are identical, e.g. root
pid is 1)
+-- Kubernetes may launch multi instance with deployment RS, so `ngx.time`
may get same return in pods.
+-- Therefore, this global patch enforce entire framework to use the
best-practice PRND generates.
+
+local resty_random = require("resty.random")
+local math_randomseed = math.randomseed
+local seeded
+
+-- make linter happy
+-- luacheck: ignore
+math.randomseed = function()
+-- check seed mark
+if seeded or false then
+log(ngx.DEBUG, debug.traceback("Random seed has been inited", 2))
+return
+end
+
+-- generate randomseed
+-- chose 6 from APISIX's SIX, 256 ^ 6 should do the trick
+-- it shouldn't be large than 16 to prevent overflow.
+local random_bytes = resty_random.bytes(6)
+local t = {}
+
+for i = 1, #random_bytes do
+t[i] = string.byte(random_bytes, i)
+end
+
+local s = table.concat(t)
+
+seeded = true
+math_randomseed(tonumber(s))
Review comment:
Make sense. thanks for suggestion. 拾
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5717: test(kafka-logger): reduce duplicate sections
spacewander commented on pull request #5717: URL: https://github.com/apache/apisix/pull/5717#issuecomment-987601512 The duplicate sections are removed by this script: ```python #!/usr/bin/env python # coding: utf-8 # Usage: ./simpify.py $test_filename import sys with open(sys.argv[1]) as f: lines = [l.rstrip() for l in f.readlines()] newlines = [] for i, l in enumerate(lines): if ((l == "GET /t" and lines[i-1] == "--- request") or (l == "[error]" and lines[i-1] == "--- no_error_log")): newlines = newlines[:-1] continue newlines.append(l) res = "\n".join(newlines) # print(res) with open(sys.argv[1], "w") as f: f.write(res + '\n') ``` I also use reindex to update the TEST number: https://github.com/openresty/openresty-devel-utils#reindex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5682: fix(patch): add global `math.randomseed` patch support
tzssangglass commented on a change in pull request #5682:
URL: https://github.com/apache/apisix/pull/5682#discussion_r763657591
##
File path: apisix/patch.lua
##
@@ -86,6 +93,44 @@ do
end
+do -- `math.randomseed` patch
+-- `math.random` generates PRND(pseudo-random numbers) from the seed set
by `math.randomseed`
+-- Many module libraries use `ngx.time` and `ngx.worker.pid` to generate
seeds which may
+-- loss randomness in container env (where pids are identical, e.g. root
pid is 1)
+-- Kubernetes may launch multi instance with deployment RS, so `ngx.time`
may get same return in pods.
+-- Therefore, this global patch enforce entire framework to use the
best-practice PRND generates.
+
+local resty_random = require("resty.random")
+local math_randomseed = math.randomseed
+local seeded
+
+-- make linter happy
+-- luacheck: ignore
+math.randomseed = function()
+-- check seed mark
+if seeded or false then
Review comment:
can we just use `if not seeded then`
##
File path: apisix/patch.lua
##
@@ -86,6 +93,44 @@ do
end
+do -- `math.randomseed` patch
+-- `math.random` generates PRND(pseudo-random numbers) from the seed set
by `math.randomseed`
+-- Many module libraries use `ngx.time` and `ngx.worker.pid` to generate
seeds which may
+-- loss randomness in container env (where pids are identical, e.g. root
pid is 1)
+-- Kubernetes may launch multi instance with deployment RS, so `ngx.time`
may get same return in pods.
+-- Therefore, this global patch enforce entire framework to use the
best-practice PRND generates.
+
+local resty_random = require("resty.random")
+local math_randomseed = math.randomseed
+local seeded
+
+-- make linter happy
+-- luacheck: ignore
+math.randomseed = function()
+-- check seed mark
+if seeded or false then
+log(ngx.DEBUG, debug.traceback("Random seed has been inited", 2))
+return
+end
+
+-- generate randomseed
+-- chose 6 from APISIX's SIX, 256 ^ 6 should do the trick
+-- it shouldn't be large than 16 to prevent overflow.
+local random_bytes = resty_random.bytes(6)
+local t = {}
+
+for i = 1, #random_bytes do
+t[i] = string.byte(random_bytes, i)
+end
+
+local s = table.concat(t)
+
+seeded = true
+math_randomseed(tonumber(s))
Review comment:
I would like to set `seeded = true` after `math_randomseed(tonumber(s))`
藍
it just looks a bit strange here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (068bbcb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9bd6b44) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix] tzssangglass commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
tzssangglass commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763646799
##
File path: apisix/plugins/log-rotate.lua
##
@@ -194,18 +231,33 @@ local function rotate()
core.log.info("rotate interval:", interval)
core.log.info("rotate max keep:", max_kept)
-local time = ngx.time()
-if time % interval == 0 then
-time = time - interval
-else
-time = time - time % interval
+if not default_logs then
+-- first init default log filepath and filename
+default_logs = {}
+init_default_logs(default_logs, DEFAULT_ACCESS_LOG_FILENAME)
+init_default_logs(default_logs, DEFAULT_ERROR_LOG_FILENAME)
end
-local date_str = os.date("%Y-%m-%d_%H-%M-%S", time)
+local now_time = ngx_time()
Review comment:
do we need to update time by `ngx.update_time` here?
##
File path: apisix/plugins/log-rotate.lua
##
@@ -194,18 +231,33 @@ local function rotate()
core.log.info("rotate interval:", interval)
core.log.info("rotate max keep:", max_kept)
-local time = ngx.time()
-if time % interval == 0 then
-time = time - interval
-else
-time = time - time % interval
+if not default_logs then
+-- first init default log filepath and filename
+default_logs = {}
+init_default_logs(default_logs, DEFAULT_ACCESS_LOG_FILENAME)
+init_default_logs(default_logs, DEFAULT_ERROR_LOG_FILENAME)
end
-local date_str = os.date("%Y-%m-%d_%H-%M-%S", time)
+local now_time = ngx_time()
+if not rotate_time then
+-- first init rotate time
+rotate_time = now_time + interval
+core.log.info("first init rotate time is: ", rotate_time)
+return
+end
+
+if now_time < rotate_time then
+-- did not reach the rotate time
+core.log.info("rotate time: ", rotate_time, " now time: ", now_time)
+return
+end
-local ok1 = rotate_file(date_str, "access.log")
-local ok2 = rotate_file(date_str, "error.log")
-if not ok1 and not ok2 then
+local now_date = os_date("%Y-%m-%dT%H-%M-%S", now_time)
Review comment:
the origin format is `"%Y-%m-%d_%H-%M-%S"`, I think wo should follow
this.
Some log capture systems just use regular matching filenames to capture log
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #793: docs: add APISIX integrate SkyWalking plugins blog
juzhiyuan merged pull request #793: URL: https://github.com/apache/apisix-website/pull/793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed issue #787: Slack banner dark mode display not good
juzhiyuan closed issue #787: URL: https://github.com/apache/apisix-website/issues/787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #794: fix: change slack image
juzhiyuan merged pull request #794: URL: https://github.com/apache/apisix-website/pull/794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: docs: add APISIX integrate SkyWalking plugins blog (#793)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 6280d80 docs: add APISIX integrate SkyWalking plugins blog (#793) 6280d80 is described below commit 6280d8090b838e4c8e5dc9ca1225ae4bfea9dbbb Author: Sylvia <39793568+sylviab...@users.noreply.github.com> AuthorDate: Tue Dec 7 13:59:03 2021 +0800 docs: add APISIX integrate SkyWalking plugins blog (#793) --- .../12/07/apisix-integrate-skywalking-plugin.md| 198 + .../12/07/apisix-integrate-skywalking-plugin.md| 196 2 files changed, 394 insertions(+) diff --git a/website/blog/2021/12/07/apisix-integrate-skywalking-plugin.md b/website/blog/2021/12/07/apisix-integrate-skywalking-plugin.md new file mode 100644 index 000..a0a01d1 --- /dev/null +++ b/website/blog/2021/12/07/apisix-integrate-skywalking-plugin.md @@ -0,0 +1,198 @@ +--- +title: "Apache APISIX Integrates with SkyWalking to Create a Full Fange of Log Processing" +author: "Haochao Zhuang" +authorURL: "https://github.com/dmsolr; +authorImageURL: "https://avatars.githubusercontent.com/u/29735230?v=4; +keywords: +- Apache APISIX +- Apache SkyWalking +- Log Process +- Plugin +description: This paper mainly introduces two Apache APISIX integrated SkyWalking log plug-ins to provide a more convenient operation and environment for log processing in Apache APISIX. +tags: [Technology] +--- + +> This paper mainly introduces two Apache APISIX integrated SkyWalking log plug-ins to provide a more convenient operation and environment for log processing in Apache APISIX. + + + +In the field of observability, the three main directions of data collection and analysis, Metrics, Logger and Tracing, are usually used to achieve insight into the operational status of applications. + +Apache APISIX has integrated Apache SkyWaling Tracing capabilities as early as version 1.4, with features such as error logging and access log collection added in subsequent versions. Now with Apache SkyWalking's support for Metrics, it enables Apache APISIX to implement a one-stop observable solution in integrated mode, covering both logging, metrics and call tracing. + +## Feature Development Background + +Those of you who are familiar with Apache APISIX should know that Apache APISIX produces two types of logs during operation, namely the access log and the error log. + +Access logs record detailed information about each request and are logs generated within the scope of the request, so they can be directly associated with Tracing. Error logs, on the other hand, are Apache APISIX runtime output log messages, which are application-wide logs, but cannot be 100% associated with requests. + +At present, Apache APISIX provides very rich log processing plug-ins, including TCP/HTTP/Kafka and other collection and reporting plug-ins, but they are weakly associated with Tracing. Take Apache SkyWalking as an example. We extract the SkyWalking Tracing Conetxt Header from the log records of Apache APISIX and export it to the file system, and then use the log processing framework (fluentbit) to convert the logs into a log format acceptable to SkyWalking. The Tracing Context is then pa [...] + +Obviously, the above way of handling the process is tedious and complicated, and requires additional conversion of log formats. For this reason, in [PR#5500](https://github.com/apache/apisix/pull/5550) we have implemented the Apache SkyWalking access log into the Apache APISIX plug-in ecosystem to make it easier for users to collect and process logs using Apache SkyWalking in Apache APISIX. + +## Introduction of the New Plugins + +### SkyWalking Logger Pulgin + +The SkyWalking Logger plugin parses the SkyWalking Tracing Context Header and prints the relevant Tracing Context information to the log, thus enabling the log to be associated with the call chain. + +By using this plug-in, Apache APISIX can get the SkyWalking Tracing Context and associate it with Tracing even if the SkyWalking Tracing plug-in is not turned on, if Apache SkyWalking is already integrated downstream. + + + +The above Content is the log content, where the Apache APISIX metadata configuration is used to collect request-related information. You can later modify the Log Format to customize the log content by Plugin Metadata, please refer to the [official documentation.](https://apisix.apache.org/docs/apisix/plugins/skywalking-logger#metadata) + + How to Use + +When using this plugin, since the SkyWalking plugin is "not enabled" by default, you need to manually modify the `plugins` section in the `conf/default-apisix.yaml` file to enable the plugin. + +```yaml +plugins: + ... + -
[apisix-website] branch master updated (b0ebae1 -> 95715f5)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from b0ebae1 docs: update Dapr blog EN version images (#795) add 95715f5 fix: change slack image (#794) No new revisions were added by this update. Summary of changes: README.md | 2 +- website/static/img/join-slack.png | Bin 0 -> 54213 bytes 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 website/static/img/join-slack.png
[GitHub] [apisix-website] juzhiyuan merged pull request #795: docs: update Dapr blog EN version images
juzhiyuan merged pull request #795: URL: https://github.com/apache/apisix-website/pull/795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: docs: update Dapr blog EN version images (#795)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new b0ebae1 docs: update Dapr blog EN version images (#795)
b0ebae1 is described below
commit b0ebae1fbd137281fc026f85eb209269eb41e11c
Author: Sylvia <39793568+sylviab...@users.noreply.github.com>
AuthorDate: Tue Dec 7 13:55:06 2021 +0800
docs: update Dapr blog EN version images (#795)
---
website/blog/2021/11/17/dapr-with-apisix.md | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/website/blog/2021/11/17/dapr-with-apisix.md
b/website/blog/2021/11/17/dapr-with-apisix.md
index 1571119..8e05a7a 100644
--- a/website/blog/2021/11/17/dapr-with-apisix.md
+++ b/website/blog/2021/11/17/dapr-with-apisix.md
@@ -21,7 +21,7 @@ Essentially, the Apache APISIX controller will configure the
same standard DAPR
The following diagram shows the architectural flow of the actual project:
-
+
## Overview
@@ -131,7 +131,7 @@ helm install apisix apisix/apisix -f dapr-annotations.yaml
-n ingress-apisix
First, configure Apache APISIX upstream-apisix-dapr.
-
+
Fill in the hostname here: apisix-gateway-dapr and the port number 3500.
@@ -159,7 +159,7 @@ Fill in the hostname here: apisix-gateway-dapr and the port
number 3500.
Then configure the Apache APISIX service apisix-gateway-dapr, and select
apisix-dapr for the upstream service.
-
+
```json
{
@@ -178,7 +178,7 @@ kubectl apply -f 02.deployment.yaml
kubectl apply -f 03.svc.yaml
```
-
+
The image above shows a hypothetical microservice running with the Dapr app-id
kennethreitz-httpbin.
@@ -186,7 +186,7 @@ The image above shows a hypothetical microservice running
with the Dapr app-id k
Here we add some settings related to path matching. For example, if the
request gateway is /httpbin/, the backend receive path should be /, with
httpbin acting as a service name identifier.
-
+
On hosted platforms that support namespaces, the Dapr application ID is in a
valid FQDN format, which includes the target namespace. For example, the
following string contains the application ID (svc-kennethreitz-httpbin) and the
namespace the application is running in (kind-test).
[GitHub] [apisix-website] SylviaBABY opened a new pull request #795: docs: update Dapr blog EN version images
SylviaBABY opened a new pull request #795: URL: https://github.com/apache/apisix-website/pull/795 Changes: Update Dapr EN version blog images -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass opened a new pull request #5718: docs: refactor Installation Guide
tzssangglass opened a new pull request #5718: URL: https://github.com/apache/apisix/pull/5718 Closes #5673 Signed-off-by: tzssangglass ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Baoyuantop opened a new pull request #794: fix: change slack image
Baoyuantop opened a new pull request #794: URL: https://github.com/apache/apisix-website/pull/794 Fixes: #787 Changes: modify slack invitation picture Screenshots of the change:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (409ea41) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `4.83%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 69.87% 65.03% -4.84% == Files 184 184 Lines7274 7274 Branches 829 829 == - Hits 5083 4731 -352 - Misses 1897 2259 +362 + Partials 294 284 -10 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.84% <ø> (-3.69%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `68.06% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: | | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-76.20%)` | :arrow_down: | | [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `0.00% <0.00%> (-53.04%)` | :arrow_down: | | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `8.06% <0.00%> (-51.62%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `23.00% <0.00%> (-44.25%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/stream\_route/stream\_route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3RyZWFtX3JvdXRlL3N0cmVhbV9yb3V0ZS5nbw==) | `36.36% <0.00%> (-31.17%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (409ea41) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `7.44%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 69.87% 62.43% -7.45% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2438-2645 + Misses 1897 1183 -714 + Partials 294 284 -10 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.84% <ø> (-3.69%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: | | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-76.20%)` | :arrow_down: | | [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `0.00% <0.00%> (-53.04%)` | :arrow_down: | | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `8.06% <0.00%> (-51.62%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `23.00% <0.00%> (-44.25%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/stream\_route/stream\_route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3RyZWFtX3JvdXRlL3N0cmVhbV9yb3V0ZS5nbw==) | `36.36% <0.00%> (-31.17%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (409ea41) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2200: test: migrate route_export_test e2e
zaunist commented on a change in pull request #2200:
URL: https://github.com/apache/apisix-dashboard/pull/2200#discussion_r763607871
##
File path: api/test/e2enew/route/route_export_test.go
##
@@ -0,0 +1,2490 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+ "net/http"
+ "strings"
+ "time"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "github.com/apisix/manager-api/test/e2enew/base"
+)
+
+var _ = ginkgo.Describe("Route", func() {
+ ginkgo.Context("test route export data empty", func() {
+ ginkgo.It("Export route when data is empty", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodGet,
+ Path: "/apisix/admin/export/routes",
+ Headers:
map[string]string{"Authorization": base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ ExpectBody:
"{\"code\":1,\"message\":\"Route data is empty, cannot be
exported\",\"data\":null",
Review comment:
Code 1, this is an error message, is it right? So it's a correct act?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix] branch master updated: docs: update README.md (#5713)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 3d5f554 docs: update README.md (#5713) 3d5f554 is described below commit 3d5f554c66903e0dc888303e92d9adf122863dbf Author: Bo Shao AuthorDate: Tue Dec 7 11:40:47 2021 +0800 docs: update README.md (#5713) --- README.md| 6 +++--- docs/zh/latest/README.md | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index b3c8909..02febfb 100644 --- a/README.md +++ b/README.md @@ -146,10 +146,10 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against - Custom routing: Support users to implement routing algorithms themselves. - **Multi-Language support** - - Apache APISIX is a multi-language gateway for plugin development and provides support via `WASM` and `RPC`. + - Apache APISIX is a multi-language gateway for plugin development and provides support via `RPC` and `WASM`.  - - The WASM or WebAssembly, is the modern way. APISIX can load and run WASM bytecode via APISIX [wasm plugin](https://github.com/apache/apisix/blob/master/docs/en/latest/wasm.md) written with the [Proxy WASM SDK](https://github.com/proxy-wasm/spec#sdks). Developers only need to write the code according to the SDK and then compile it into a WASM bytecode that runs on WASM VM with APISIX. - - The RPC way, is a traditional way. Developers can choose the language according to their needs and after starting an independent process with the RPC, it exchanges data with APISIX through local RPC communication. Till this moment, APISIX has support for [Java](https://github.com/apache/apisix-java-plugin-runner), [Golang](https://github.com/apache/apisix-go-plugin-runner), [Python](https://github.com/apache/apisix-python-plugin-runner) and Node.js. + - The RPC way, is the current way. Developers can choose the language according to their needs and after starting an independent process with the RPC, it exchanges data with APISIX through local RPC communication. Till this moment, APISIX has support for [Java](https://github.com/apache/apisix-java-plugin-runner), [Golang](https://github.com/apache/apisix-go-plugin-runner), [Python](https://github.com/apache/apisix-python-plugin-runner) and Node.js. + - The WASM or WebAssembly, is an experimental way. APISIX can load and run WASM bytecode via APISIX [wasm plugin](https://github.com/apache/apisix/blob/master/docs/en/latest/wasm.md) written with the [Proxy WASM SDK](https://github.com/proxy-wasm/spec#sdks). Developers only need to write the code according to the SDK and then compile it into a WASM bytecode that runs on WASM VM with APISIX. - **Serverless** - [Lua functions](docs/en/latest/plugins/serverless.md): Invoke functions in each phase in APISIX. diff --git a/docs/zh/latest/README.md b/docs/zh/latest/README.md index d46eb94..d6ed28d 100644 --- a/docs/zh/latest/README.md +++ b/docs/zh/latest/README.md @@ -145,10 +145,10 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、抵 - 自定义路由: 支持用户自己实现路由算法。 - **多语言支持** - - Apache APISIX 是一个通过 `WASM` 和 `RPC` 支持不同语言来进行插件开发的网关. +- Apache APISIX 是一个通过 `RPC` 和 `WASM` 支持不同语言来进行插件开发的网关.  - - WASM 或 WebAssembly 是比较现代的开发方式。 APISIX 能加载运行使用[Proxy WASM SDK](https://github.com/proxy-wasm/spec#sdks)编译的 WASM 字节码。开发者仅需要使用该 SDK 编写代码，然后编译成 WASM 字节码，即可运行在 APISIX 中的 WASM 虚拟机中。 - - RPC 是一种比较传统的开发方式。开发者可以使用他们需要的语言来进行 RPC 服务的开发，该 RPC 通过本地通讯来跟 APISIX 进行数据交换。到目前为止，APISIX 已支持[Java](https://github.com/apache/apisix-java-plugin-runner), [Golang](https://github.com/apache/apisix-go-plugin-runner), [Python](https://github.com/apache/apisix-python-plugin-runner) and Node.js. + - RPC 是当前采用的开发方式。开发者可以使用他们需要的语言来进行 RPC 服务的开发，该 RPC 通过本地通讯来跟 APISIX 进行数据交换。到目前为止，APISIX 已支持[Java](https://github.com/apache/apisix-java-plugin-runner), [Golang](https://github.com/apache/apisix-go-plugin-runner), [Python](https://github.com/apache/apisix-python-plugin-runner) 和 Node.js。 + - WASM 或 WebAssembly 是实验性的开发方式。 APISIX 能加载运行使用[Proxy WASM SDK](https://github.com/proxy-wasm/spec#sdks)编译的 WASM 字节码。开发者仅需要使用该 SDK 编写代码，然后编译成 WASM 字节码，即可运行在 APISIX 中的 WASM 虚拟机中。 - **Serverless** - [Lua functions](plugins/serverless.md): 能在 APISIX 每个阶段调用 lua 函数.
[GitHub] [apisix] spacewander closed issue #5649: docs: the WASM way is experimental
spacewander closed issue #5649: URL: https://github.com/apache/apisix/issues/5649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5713: docs: update README.md
spacewander merged pull request #5713: URL: https://github.com/apache/apisix/pull/5713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on a change in pull request #793: docs: add APISIX integrate SkyWalking plugins blog
yzeng25 commented on a change in pull request #793:
URL: https://github.com/apache/apisix-website/pull/793#discussion_r763584254
##
File path:
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/07/apisix-integrate-skywalking-plugin.md
##
@@ -0,0 +1,196 @@
+---
+title: "强强联合！APISIX 集成 SkyWalking 打造全方位日志处理"
+author: "庄浩潮"
+authorURL: "https://github.com/dmsolr;
+authorImageURL: "https://avatars.githubusercontent.com/u/29735230?v=4;
+keywords:
+- Apache APISIX
+- Apache SkyWalking
+- 日志处理
+- 插件集成
+description: 本文主要介绍了两款 Apache APISIX 集成 SkyWalking 的日志插件，为之后大家在 Apache APISIX
中进行日志处理提供更方便的操作与环境。
+tags: [Technology]
+---
+
+> 本文主要介绍了两款 Apache APISIX 集成 SkyWalking 的日志插件，为之后大家在 Apache APISIX
中进行日志处理提供更方便的操作与环境。
+
+
+
+在可观测性领域，通常采用 Metrics、Logger 与 Tracing 三大方向的数据收集与分析，以达到洞察应用运行状态的目的，Apache
SkyWalking 的日志处理正好具备了以上三方面。
+
+Apache APISIX 早在 1.4 版本就已经集成 Apache SkyWaling Tracing
能力，并在后续版本中加入了错误日志和访问日志收集等功能。如今随着 Apache SkyWalking 对 Metrics 的支持，能够帮助 Apache
APISIX 在集成模式下实现一站式可观测方案，同时覆盖到日志、度量和调用追踪。
+
+## 功能开发背景
+
+熟悉 Apache APISIX 的小伙伴应该知道，Apache APISIX 在运行中会产出两种日志，即访问日志和错误日志。
+
+访问日志记录着每个请求的详细信息，属于**请求范围**内产生的日志，因此可以直接与 Tracing 关联。而错误日志则是 Apache APISIX
**运行时**产出日志信息，是整个应用级别日志，但无法确保能百分百关联到请求上。
+
+目前 Apache APISIX 提供了非常丰富的日志处理插件，包括 TCP/HTTP/Kafka 等收集上报插件，但它们与 Tracing
关联都比较弱。以 Apache SkyWalking 为例，提取 Apache APISIX 端日志记录中的 SkyWalking Tracing
Conetxt Header 并输出到文件系统，之后利用日志处理框架(fluentbit) 将日志转成 SkyWalking
可接受的日志格式。后续从中解析提取 Tracing Context，从而获得 Tracing ID 进而与 Trace 建立联系。
Review comment:
```suggestion
目前 Apache APISIX 提供了非常丰富的日志处理插件，包括 TCP/HTTP/Kafka 等收集上报插件，但它们与 Tracing
关联都比较弱。以 Apache SkyWalking 为例，提取 Apache APISIX 端日志记录中的 SkyWalking Tracing
Conetxt Header 并输出到文件系统，之后利用日志处理框架（fluentbit）将日志转成 SkyWalking 可接受的日志格式。后续从中解析提取
Tracing Context，从而获得 Tracing ID 进而与 Trace 建立联系。
```
##
File path:
website/i18n/zh/docusaurus-plugin-content-blog/2021/12/07/apisix-integrate-skywalking-plugin.md
##
@@ -0,0 +1,196 @@
+---
+title: "强强联合！APISIX 集成 SkyWalking 打造全方位日志处理"
+author: "庄浩潮"
+authorURL: "https://github.com/dmsolr;
+authorImageURL: "https://avatars.githubusercontent.com/u/29735230?v=4;
+keywords:
+- Apache APISIX
+- Apache SkyWalking
+- 日志处理
+- 插件集成
+description: 本文主要介绍了两款 Apache APISIX 集成 SkyWalking 的日志插件，为之后大家在 Apache APISIX
中进行日志处理提供更方便的操作与环境。
+tags: [Technology]
+---
+
+> 本文主要介绍了两款 Apache APISIX 集成 SkyWalking 的日志插件，为之后大家在 Apache APISIX
中进行日志处理提供更方便的操作与环境。
+
+
+
+在可观测性领域，通常采用 Metrics、Logger 与 Tracing 三大方向的数据收集与分析，以达到洞察应用运行状态的目的，Apache
SkyWalking 的日志处理正好具备了以上三方面。
+
+Apache APISIX 早在 1.4 版本就已经集成 Apache SkyWaling Tracing
能力，并在后续版本中加入了错误日志和访问日志收集等功能。如今随着 Apache SkyWalking 对 Metrics 的支持，能够帮助 Apache
APISIX 在集成模式下实现一站式可观测方案，同时覆盖到日志、度量和调用追踪。
+
+## 功能开发背景
+
+熟悉 Apache APISIX 的小伙伴应该知道，Apache APISIX 在运行中会产出两种日志，即访问日志和错误日志。
+
+访问日志记录着每个请求的详细信息，属于**请求范围**内产生的日志，因此可以直接与 Tracing 关联。而错误日志则是 Apache APISIX
**运行时**产出日志信息，是整个应用级别日志，但无法确保能百分百关联到请求上。
+
+目前 Apache APISIX 提供了非常丰富的日志处理插件，包括 TCP/HTTP/Kafka 等收集上报插件，但它们与 Tracing
关联都比较弱。以 Apache SkyWalking 为例，提取 Apache APISIX 端日志记录中的 SkyWalking Tracing
Conetxt Header 并输出到文件系统，之后利用日志处理框架(fluentbit) 将日志转成 SkyWalking
可接受的日志格式。后续从中解析提取 Tracing Context，从而获得 Tracing ID 进而与 Trace 建立联系。
+
+显然，上述方式处理流程比较繁琐复杂，还需要额外转换日志格式。为此，在
[PR#5500](https://github.com/apache/apisix/pull/5550) 中我们实现了将 Apache SkyWalking
访问日志接入 Apache APISIX 插件生态，方便用户在使用 Apache APISIX 中更方便地利用 Apache SkyWalking
进行收集和处理相关日志。
+
+## 全新日志插件介绍
+
+### SkyWalking Logger 插件
+
+SkyWalking Logger 插件能够解析 SkyWalking Tracing Context Header，并将相关 Tracing
Context 信息打印到日志中，从而实现日志与调用链建立关联。
+
+通过使用此插件，可以实现在下游已经集成 Apache SkyWalking 的情况下，Apache APISIX 即便没有打开 SkyWalking
Tracing 插件也能获取到 SkyWalking Tracing Context 并实现与 Tracing 关联。
+
+
+
+>上图 Content 为日志内容，这里使用了 Apache APISIX metadata 配置来收集 Request 相关信息。后续可通过 Plugin
Metadata 修改 Log Format
定制日志内容，具体可以参考[官方文档](https://apisix.apache.org/docs/apisix/plugins/skywalking-logger#metadata)。
+
+ 使用方法
+
+在使用该插件时，由于 SkyWalking 插件默认为「不开启」，所以需要手动修改 `conf/default-apisix.yaml` 文件中
`plugins` 章节来解开SkyWalking 注释从而启用插件。
+
+```yaml
+plugins:
+ ...
+ - skywalking
+ ...
+```
+
+之后便可使用 SkyWalking Tracing 插件直接得到 Tracing 数据，以便接下来验证 Logging 插件相关功能是否能够正常开启与工作。
+
+# 步骤一：创建路由
+
+接下来创建一个路由，并绑定 SkyWalking Tracing 插件和 SkyWalking Logging 插件。关于插件具体配置细节可以参考
[Apache APISIX
官方文档](https://apisix.apache.org/docs/apisix/plugins/skywalking-logger)，这里不再赘述。
+
+```bash
+curl -X PUT 'http://192.168.0.108:9080/apisix/admin/routes/1001' \
+-H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' \
+-H 'Content-Type: application/json' \
+-d '{
+"uri": "/get",
+"plugins": {
+"skywalking": {
+"sample_ratio": 1
+},
+"skywalking-logger": {
+"endpoint_addr": "http://127.0.0.1:12800;
+}
+},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"httpbin.org:80": 1
+}
+}
+}'
+```
+
+#
[GitHub] [apisix] spacewander opened a new pull request #5717: test(kafka-logger): reduce duplicate sections
spacewander opened a new pull request #5717: URL: https://github.com/apache/apisix/pull/5717 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5714: Proposal: support OpenPolicyAgent for access control
juzhiyuan commented on issue #5714: URL: https://github.com/apache/apisix/issues/5714#issuecomment-987535893 Just added a Discussion here[1], looking forward to more reviews from community :) [1] https://github.com/open-policy-agent/feedback/discussions/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on issue #5714: Proposal: support OpenPolicyAgent for access control
leslie-tsang commented on issue #5714: URL: https://github.com/apache/apisix/issues/5714#issuecomment-987534052 It's great to see the Apache APISIX ecosystem expanding. > 琚致远 ***@***.***>於2021年12月7日 上午11:22寫道： > > > SGTM!! I noticed Open Policy Agent supports Ecosystem see https://www.openpolicyagent.org/docs/latest/ecosystem/ > > > > cc @yzeng25 @bzp2010 @moonming > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or unsubscribe. > Triage notifications on the go with GitHub Mobile for iOS or Android. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5714: Proposal: support OpenPolicyAgent for access control
juzhiyuan commented on issue #5714: URL: https://github.com/apache/apisix/issues/5714#issuecomment-987532303 SGTM!! I noticed Open Policy Agent supports Ecosystem see https://www.openpolicyagent.org/docs/latest/ecosystem/  cc @yzeng25 @bzp2010 @moonming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass opened a new pull request #5716: chore: delete expired inspiration statements
tzssangglass opened a new pull request #5716: URL: https://github.com/apache/apisix/pull/5716 Signed-off-by: tzssangglass ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
shuaijinchao commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763597332
##
File path: apisix/plugins/log-rotate.lua
##
@@ -181,6 +151,70 @@ local function scan_log_folder()
end
+local function rename_file(log, date_str)
+local new_file
+if not log.new_file then
+core.log.warn(log.type, " is off")
+return nil
+end
+
+new_file = str_format(log.new_file, date_str)
+if file_exists(new_file) then
+core.log.info("file exist: " .. new_file)
+return new_file
+end
+
+local ok, err = os_rename(log.file, new_file)
+if not ok then
+core.log.error("move file from ", log.file, " to ", new_file,
+" res:", ok, " msg:", err)
+return nil
+end
+
+return new_file
+end
+
+
+local function compression_file(new_file)
+if not new_file or type(new_file) ~= "string" then
+core.log.info("compression file: ", new_file, " invalid")
+return
+end
+
+local n = get_last_index(new_file, "/")
+local new_filepath = string.sub(new_file, 1, n)
+local new_filename = string.sub(new_file, n + 1)
+local com_filename = new_filename .. COMPRESSION_FILE_SUFFIX
+local cmd = str_format("cd %s && tar -zcf %s %s", new_filepath,
+com_filename, new_filename)
+core.log.info("log file compress command: " .. cmd)
+
+local ok, stdout, stderr, reason, status = shell.run(cmd)
+if not ok then
+core.log.error("compress log file from ", new_filename, " to ",
com_filename,
+" fail, stdout: ", stdout, " stderr: ", stderr, " reason: ",
reason,
+" status: ", status)
+return
+end
+
+ok, stderr = os_remove(new_file)
+if not ok then
+core.log.error("remove uncompressed log file: ", new_file, " fail,
err: ", stderr)
+return
+end
+end
+
+
+local function init_default_logs(logs_info, log_type)
+local filepath, filename = get_log_path_info(log_type)
+logs_info[log_type] = { type = log_type }
+if filename ~= "off" then
+logs_info[log_type].file = str_format("%s/%s", filepath, filename)
+logs_info[log_type].new_file = filepath .. "/%s_" .. filename
Review comment:
OK, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] brighten1023 edited a comment on issue #784: request help: regex_uri in proxy-rewriter
brighten1023 edited a comment on issue #784:
URL:
https://github.com/apache/apisix-ingress-controller/issues/784#issuecomment-987523094
```
apiVersion: apisix.apache.org/v2beta2
kind: ApisixRoute
metadata:
name: frontend-route
spec:
http:
- name: frontend
match:
hosts:
- test.aaa.com
paths:
- /*
backends:
- serviceName: frontend
servicePort: 80
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri: ["^/(.*)", "/$1"]
```
and
```apiVersion: apisix.apache.org/v2beta2
kind: ApisixRoute
metadata:
name: backend-route
spec:
http:
- name: backend
match:
hosts:
- test.aaa.com
paths:
- /api/*
backends:
- serviceName: backend
servicePort: 8080
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri: ["^/api/(.*)$", "/api/$1"]
```
Temporarily, I use apisix dashboard to create route and upstream, and it
goes well
```//route frontend
{
"uri": "/*",
"name": "frontend_route",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"^/(.*)",
"/$1"
]
}
},
"upstream_id": "384232553139143705",
"status": 1
}
```
and
```//route backend
{
"uri": "/api/*",
"name": "backend_route",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"^/api/(.*)",
"/api/$1"
]
}
},
"upstream_id": "384236511421269017",
"status": 1
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] brighten1023 edited a comment on issue #784: request help: regex_uri in proxy-rewriter
brighten1023 edited a comment on issue #784:
URL:
https://github.com/apache/apisix-ingress-controller/issues/784#issuecomment-987523094
`apiVersion: apisix.apache.org/v2beta2
kind: ApisixRoute
metadata:
name: frontend-route
spec:
http:
- name: frontend
match:
hosts:
- test.aaa.com
paths:
- /*
backends:
- serviceName: frontend
servicePort: 80
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri: ["^/(.*)", "/$1"]
`
and
`apiVersion: apisix.apache.org/v2beta2
kind: ApisixRoute
metadata:
name: backend-route
spec:
http:
- name: backend
match:
hosts:
- test.aaa.com
paths:
- /api/*
backends:
- serviceName: backend
servicePort: 8080
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri: ["^/api/(.*)$", "/api/$1"]
`
Temporarily, I use apisix dashboard to create route and upstream, and it
goes well
`//route frontend
{
"uri": "/*",
"name": "frontend_route",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"^/(.*)",
"/$1"
]
}
},
"upstream_id": "384232553139143705",
"status": 1
}
`
and
`//route backend
{
"uri": "/api/*",
"name": "backend_route",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"/api/(.*)",
"/api/$1"
]
}
},
"upstream_id": "384236511421269017",
"status": 1
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] brighten1023 edited a comment on issue #784: request help: regex_uri in proxy-rewriter
brighten1023 edited a comment on issue #784:
URL:
https://github.com/apache/apisix-ingress-controller/issues/784#issuecomment-987523094
`apiVersion: apisix.apache.org/v2beta2
kind: ApisixRoute
metadata:
name: frontend-route
spec:
http:
- name: frontend
match:
hosts:
- test.aaa.com
paths:
- /*
backends:
- serviceName: frontend
servicePort: 80
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri: ["^/(.*)", "/$1"]`
and
`apiVersion: apisix.apache.org/v2beta2
kind: ApisixRoute
metadata:
name: backend-route
spec:
http:
- name: backend
match:
hosts:
- test.aaa.com
paths:
- /api/*
backends:
- serviceName: backend
servicePort: 8080
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri: ["^/api/(.*)$", "/api/$1"]`
Temporarily, I use apisix dashboard to create route and upstream, and it
goes well
`//route frontend
{
"uri": "/*",
"name": "frontend_route",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"^/(.*)",
"/$1"
]
}
},
"upstream_id": "384232553139143705",
"status": 1
}`
and
`//route backend
{
"uri": "/api/*",
"name": "backend_route",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"/api/(.*)",
"/api/$1"
]
}
},
"upstream_id": "384236511421269017",
"status": 1
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] brighten1023 commented on issue #784: request help: regex_uri in proxy-rewriter
brighten1023 commented on issue #784:
URL:
https://github.com/apache/apisix-ingress-controller/issues/784#issuecomment-987523094
`apiVersion: apisix.apache.org/v2beta2
kind: ApisixRoute
metadata:
name: frontend-route
spec:
http:
- name: frontend
match:
hosts:
- test.aaa.com
paths:
- /*
backends:
- serviceName: frontend
servicePort: 80
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri: ["^/(.*)", "/$1"]`
`apiVersion: apisix.apache.org/v2beta2
kind: ApisixRoute
metadata:
name: backend-route
spec:
http:
- name: backend
match:
hosts:
- test.aaa.com
paths:
- /api/*
backends:
- serviceName: backend
servicePort: 8080
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri: ["^/api/(.*)$", "/api/$1"]`
Temporarily, I use apisix dashboard to create route and upstream, and it
goes well
`//route frontend
{
"uri": "/*",
"name": "frontend_route",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"^/(.*)",
"/$1"
]
}
},
"upstream_id": "384232553139143705",
"status": 1
}`
`//route backend
{
"uri": "/api/*",
"name": "backend_route",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"/api/(.*)",
"/api/$1"
]
}
},
"upstream_id": "384236511421269017",
"status": 1
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] GhangZh commented on issue #787: request help: ApisixRoute apiversion Inconsistency
GhangZh commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-987515689 > Did you update the CRD again？ I recreated the crd after the update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #787: request help: ApisixRoute apiversion Inconsistency
tao12345666333 commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-987513951 Did you update the CRD again？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] GhangZh edited a comment on issue #787: request help: ApisixRoute apiversion Inconsistency
GhangZh edited a comment on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-987508513 > > the problem still occurs when you switch to 1.3.0 > > How did you upgrade to v1.3? Reinstalled via helm uninstall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] GhangZh commented on issue #787: request help: ApisixRoute apiversion Inconsistency
GhangZh commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-987508513 > > the problem still occurs when you switch to 1.3.0 > > How did you upgrade to v1.3? Reinstalled via helm uninstall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] GhangZh commented on issue #787: request help: ApisixRoute apiversion Inconsistency
GhangZh commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-987508160 > This will not cause the program to fail, and it will not cause you to declare an error in the `ApisixRoute` resource. The reason why it is displayed as `apisix.apache.org/v1` is because v1 is the most recent release version. So should I configure it according to the definition of v1, or v2beta1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] SylviaBABY opened a new pull request #793: docs: add APISIX integrate SkyWalking plugins blog
SylviaBABY opened a new pull request #793: URL: https://github.com/apache/apisix-website/pull/793 Changes: add Blog of APISIX Pulgins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] deepzz0 commented on issue #5650: request help: etcd tls connect handshake failed
deepzz0 commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-987496965 @tokers It means I didn't provide the client certificate, when i use `-cert` and `-key` in openssl, it's ok. `Certificate host Mismatch` is an error reported by the client when trying to verify the server certificate. I will do more verification in my spare time to confirm the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
spacewander commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763564390
##
File path: apisix/plugins/log-rotate.lua
##
@@ -181,6 +151,70 @@ local function scan_log_folder()
end
+local function rename_file(log, date_str)
+local new_file
+if not log.new_file then
+core.log.warn(log.type, " is off")
+return nil
+end
+
+new_file = str_format(log.new_file, date_str)
+if file_exists(new_file) then
+core.log.info("file exist: " .. new_file)
+return new_file
+end
+
+local ok, err = os_rename(log.file, new_file)
+if not ok then
+core.log.error("move file from ", log.file, " to ", new_file,
+" res:", ok, " msg:", err)
+return nil
+end
+
+return new_file
+end
+
+
+local function compression_file(new_file)
+if not new_file or type(new_file) ~= "string" then
+core.log.info("compression file: ", new_file, " invalid")
+return
+end
+
+local n = get_last_index(new_file, "/")
+local new_filepath = string.sub(new_file, 1, n)
+local new_filename = string.sub(new_file, n + 1)
+local com_filename = new_filename .. COMPRESSION_FILE_SUFFIX
+local cmd = str_format("cd %s && tar -zcf %s %s", new_filepath,
+com_filename, new_filename)
+core.log.info("log file compress command: " .. cmd)
+
+local ok, stdout, stderr, reason, status = shell.run(cmd)
+if not ok then
+core.log.error("compress log file from ", new_filename, " to ",
com_filename,
+" fail, stdout: ", stdout, " stderr: ", stderr, " reason: ",
reason,
+" status: ", status)
+return
+end
+
+ok, stderr = os_remove(new_file)
+if not ok then
+core.log.error("remove uncompressed log file: ", new_file, " fail,
err: ", stderr)
+return
+end
+end
+
+
+local function init_default_logs(logs_info, log_type)
+local filepath, filename = get_log_path_info(log_type)
+logs_info[log_type] = { type = log_type }
+if filename ~= "off" then
+logs_info[log_type].file = str_format("%s/%s", filepath, filename)
+logs_info[log_type].new_file = filepath .. "/%s_" .. filename
Review comment:
Why should we change the rotated filename? It is not a good idea to
change the default rotated filename without a strong reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
spacewander commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763564390
##
File path: apisix/plugins/log-rotate.lua
##
@@ -181,6 +151,70 @@ local function scan_log_folder()
end
+local function rename_file(log, date_str)
+local new_file
+if not log.new_file then
+core.log.warn(log.type, " is off")
+return nil
+end
+
+new_file = str_format(log.new_file, date_str)
+if file_exists(new_file) then
+core.log.info("file exist: " .. new_file)
+return new_file
+end
+
+local ok, err = os_rename(log.file, new_file)
+if not ok then
+core.log.error("move file from ", log.file, " to ", new_file,
+" res:", ok, " msg:", err)
+return nil
+end
+
+return new_file
+end
+
+
+local function compression_file(new_file)
+if not new_file or type(new_file) ~= "string" then
+core.log.info("compression file: ", new_file, " invalid")
+return
+end
+
+local n = get_last_index(new_file, "/")
+local new_filepath = string.sub(new_file, 1, n)
+local new_filename = string.sub(new_file, n + 1)
+local com_filename = new_filename .. COMPRESSION_FILE_SUFFIX
+local cmd = str_format("cd %s && tar -zcf %s %s", new_filepath,
+com_filename, new_filename)
+core.log.info("log file compress command: " .. cmd)
+
+local ok, stdout, stderr, reason, status = shell.run(cmd)
+if not ok then
+core.log.error("compress log file from ", new_filename, " to ",
com_filename,
+" fail, stdout: ", stdout, " stderr: ", stderr, " reason: ",
reason,
+" status: ", status)
+return
+end
+
+ok, stderr = os_remove(new_file)
+if not ok then
+core.log.error("remove uncompressed log file: ", new_file, " fail,
err: ", stderr)
+return
+end
+end
+
+
+local function init_default_logs(logs_info, log_type)
+local filepath, filename = get_log_path_info(log_type)
+logs_info[log_type] = { type = log_type }
+if filename ~= "off" then
+logs_info[log_type].file = str_format("%s/%s", filepath, filename)
+logs_info[log_type].new_file = filepath .. "/%s_" .. filename
Review comment:
Why should we change the rotated filename?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5711: bug: apisix.service cannot be started automatically, and ulimit is not set
spacewander closed issue #5711: URL: https://github.com/apache/apisix/issues/5711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5711: bug: apisix.service cannot be started automatically, and ulimit is not set
spacewander commented on issue #5711: URL: https://github.com/apache/apisix/issues/5711#issuecomment-987489443 Solved by https://github.com/api7/apisix-build-tools/pull/143 Thanks for @saintak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 123liubao commented on issue #698: Update SkyWalking plugin's docs
123liubao commented on issue #698: URL: https://github.com/apache/apisix-website/issues/698#issuecomment-987488393 @juzhiyuan Sorry, I want to confirm that this is a release-2.9 branch problem, the master branch is correct, so which branch should I pull from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5650: request help: etcd tls connect handshake failed
tokers commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-987486570 > > Is this a self-signed certificate or signed by a private CA? Have you configured the `ssl_trusted_certificate` option? > > Yes, it's self-signed. You can see the configuration above, `ssl_trusted_certificate` has been set. > > If `verify` is set to true, an error "Certificate host Mismatch."，But I have no problem passing OpenSSL authentication Your OpenSSL authentication also reports a bad certificate alert: > verify return:1 140718298392464:error:14094412:SSL routines:ssl3_read_bytes:sslv3 alert bad certificate:s3_pkt.c:1493:SSL alert number 42 140718298392464:error:140790E5:SSL routines:ssl23_write:ssl handshake failure:s23_lib.c:177: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #5682: fix(patch): add global `math.randomseed` patch support
moonming commented on a change in pull request #5682: URL: https://github.com/apache/apisix/pull/5682#discussion_r763560122 ## File path: apisix/patch.lua ## @@ -86,6 +93,64 @@ do end +do -- `math.randomseed` patch + +-- Seeds the random generator, use with care. +-- Once - properly - seeded, this method is replaced with a stub +-- one. This is to enforce best-practices for seeding in ngx_lua, +-- and prevents third-party modules from overriding our correct seed +-- (many modules make a wrong usage of `math.randomseed()` by calling +-- it multiple times or by not using unique seeds for Nginx workers). +-- Inspired by kong.globalpatches Review comment: if these codes are copied from kong, you MUST add copyright in https://github.com/apache/apisix/blob/master/LICENSE. if not, please remove this line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5694: How to pass custom context in different phases of plugin execution?
spacewander closed issue #5694: URL: https://github.com/apache/apisix/issues/5694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #5653: feat: rocketmq logger
membphis commented on pull request #5653: URL: https://github.com/apache/apisix/pull/5653#issuecomment-987473648 Thank you very much for your outstanding contribution @yuz10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5653: feat: rocketmq logger
spacewander merged pull request #5653: URL: https://github.com/apache/apisix/pull/5653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (9731f51 -> 49762bc)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 9731f51 docs: Software architecture diagram added (zh-docs) (#5712)
add 49762bc feat: rocketmq logger (#5653)
No new revisions were added by this update.
Summary of changes:
README.md | 2 +-
.../{kafka-logger.lua => rocketmq-logger.lua} | 148 ++
ci/linux-ci-init-service.sh| 6 +
ci/pod/docker-compose.yml | 24 +
conf/config-default.yaml | 1 +
docs/en/latest/config.json | 1 +
.../{kafka-logger.md => rocketmq-logger.md}| 68 ++-
docs/zh/latest/README.md | 2 +-
docs/zh/latest/config.json | 1 +
.../{kafka-logger.md => rocketmq-logger.md}| 65 ++-
rockspec/apisix-master-0.rockspec | 1 +
t/admin/plugins.t | 1 +
t/debug/debug-mode.t | 1 +
...r-log-format.t => rocketmq-logger-log-format.t} | 16 +-
t/plugin/{kafka-logger.t => rocketmq-logger.t} | 528 ++---
15 files changed, 303 insertions(+), 562 deletions(-)
copy apisix/plugins/{kafka-logger.lua => rocketmq-logger.lua} (62%)
copy docs/en/latest/plugins/{kafka-logger.md => rocketmq-logger.md} (72%)
copy docs/zh/latest/plugins/{kafka-logger.md => rocketmq-logger.md} (72%)
copy t/plugin/{kafka-logger-log-format.t => rocketmq-logger-log-format.t} (89%)
copy t/plugin/{kafka-logger.t => rocketmq-logger.t} (62%)
[GitHub] [apisix] tzssangglass commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
tzssangglass commented on issue #5706:
URL: https://github.com/apache/apisix/issues/5706#issuecomment-987464045
> 1. at what stage does the nacos metadata information get and where is it
placed?
You can see how the service registration information for nacos is obtained
and how it is stored in nacos.lua. e.g.
https://github.com/apache/apisix/blob/master/apisix/discovery/nacos/init.lua#L216-L230
> 2. where to add require("apisix.balancer.your_balancer")?
your_balancer is placed in the apisix/balancer folder
> 3. what functions should I implement in my custom balancer?
take a look at:
https://github.com/apache/apisix/blob/master/apisix/balancer/roundrobin.lua
BTW, I think this is a bit difficult, if you haven't had experience
developing plugins before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] moonming commented on issue #5711: bug: apisix.service无法开机自启动，而且ulimit没有设置
moonming commented on issue #5711: URL: https://github.com/apache/apisix/issues/5711#issuecomment-987463145 @saintak Please use English in the public channel, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on issue #5709: 请求返回504
moonming commented on issue #5709: URL: https://github.com/apache/apisix/issues/5709#issuecomment-987461326 @fish2018 Please use English in the public channel, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] qq54903099 closed issue #5690: request help: apisix hmac url paramater encode result not equal java ecnode result
qq54903099 closed issue #5690: URL: https://github.com/apache/apisix/issues/5690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] alex8224 edited a comment on issue #5706: request help: How to route according to the configuration of nacos metadata?
alex8224 edited a comment on issue #5706:
URL: https://github.com/apache/apisix/issues/5706#issuecomment-986914757
> > @alex8224 You may implement your own balancer and use it in `Upstream`
objects.
>
> See
https://apisix.apache.org/blog/2021/07/28/release-apache-apisix-2.8/#new-way-to-develop-support-for-custom-balancer
.
@tokers
I can only find very little about how to implement a balancer from the url
you gave, are there other more detailed guides on how to easily add a balancer
type?
For example.
1. at what stage does the nacos metadata information get and where is it
placed?
2. where to add require("apisix.balancer.your_balancer")?
3. what functions should I implement in my custom balancer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] alex8224 edited a comment on issue #5706: request help: How to route according to the configuration of nacos metadata?
alex8224 edited a comment on issue #5706:
URL: https://github.com/apache/apisix/issues/5706#issuecomment-986914757
> > @alex8224 You may implement your own balancer and use it in `Upstream`
objects.
>
> See
https://apisix.apache.org/blog/2021/07/28/release-apache-apisix-2.8/#new-way-to-develop-support-for-custom-balancer
.
I can only find very little about how to implement a balancer from the url
you gave, are there other more detailed guides on how to easily add a balancer
type?
For example.
1. at what stage does the nacos metadata information get and where is it
placed?
2. where to add require("apisix.balancer.your_balancer")?
3. what functions should I implement in my custom balancer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] alex8224 commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
alex8224 commented on issue #5706: URL: https://github.com/apache/apisix/issues/5706#issuecomment-986914757 > > @alex8224 You may implement your own balancer and use it in `Upstream` objects. > > See https://apisix.apache.org/blog/2021/07/28/release-apache-apisix-2.8/#new-way-to-develop-support-for-custom-balancer . I can only find very little about how to implement a balancer from the url you gave, are there other more detailed guides on how to easily add a balancer type? Similar to implementing a new discovery type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership
tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r763124136 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: @tokers any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #785: docs: Optimize installation documentation
tao12345666333 commented on pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785#issuecomment-986893582 > I think it would be better if you can modify the installation steps on other platforms. @Baoyuantop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #785: docs: Optimize installation documentation
tao12345666333 commented on a change in pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785#discussion_r763122020 ## File path: docs/en/latest/deployments/minikube.md ## @@ -41,7 +40,7 @@ kubectl create ns ingress-apisix helm install apisix apisix/apisix \ --set gateway.type=NodePort \ --set ingress-controller.enabled=true \ - --namespace ingress-apisix + --namespace ingress-apisix \ --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix Review comment: yep. it was introduced by https://github.com/apache/apisix-ingress-controller/pull/747 I forgot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #787: request help: ApisixRoute apiversion Inconsistency
tao12345666333 commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-986890457 > the problem still occurs when you switch to 1.3.0 How did you upgrade to v1.3? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #792: Keep the same language in blog
juzhiyuan commented on issue #792: URL: https://github.com/apache/apisix-website/issues/792#issuecomment-986855181 cc @yzeng25 @SylviaBABY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan opened a new issue #792: Keep the same language in blog
juzhiyuan opened a new issue #792: URL: https://github.com/apache/apisix-website/issues/792 **Actual Behaviour** Take https://apisix.apache.org/blog/2021/11/30/use-apisix-ingress-in-kubesphere/ as an example, it's written in English but with the image in Chinese 樂 **Expected Behaviour** I would suggest using the same language in the posts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #787: request help: ApisixRoute apiversion Inconsistency
gxthrj commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-986843851 This will not cause the program to fail, and it will not cause you to declare an error in the `ApisixRoute` resource. The reason why it is displayed as `apisix.apache.org/v1` is because v1 is the most recent release version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
