[GitHub] [apisix] shuaijinchao commented on a change in pull request #5713: docs: update README.md
shuaijinchao commented on a change in pull request #5713: URL: https://github.com/apache/apisix/pull/5713#discussion_r763040276 ## File path: docs/zh/latest/README.md ## @@ -145,10 +145,10 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、抵 - 自定义路由: 支持用户自己实现路由算法。 - **多语言支持** - - Apache APISIX 是一个通过 `WASM` 和 `RPC` 支持不同语言来进行插件开发的网关. +- Apache APISIX 是一个通过 `RPC` 和 `WASM` 支持不同语言来进行插件开发的网关.  - - WASM 或 WebAssembly 是比较现代的开发方式。 APISIX 能加载运行使用[Proxy WASM SDK](https://github.com/proxy-wasm/spec#sdks)编译的 WASM 字节码。开发者仅需要使用该 SDK 编写代码，然后编译成 WASM 字节码，即可运行在 APISIX 中的 WASM 虚拟机中。 - - RPC 是一种比较传统的开发方式。开发者可以使用他们需要的语言来进行 RPC 服务的开发，该 RPC 通过本地通讯来跟 APISIX 进行数据交换。到目前为止，APISIX 已支持[Java](https://github.com/apache/apisix-java-plugin-runner), [Golang](https://github.com/apache/apisix-go-plugin-runner), [Python](https://github.com/apache/apisix-python-plugin-runner) and Node.js. + - RPC 是当前采用的开发方式。开发者可以使用他们需要的语言来进行 RPC 服务的开发，该 RPC 通过本地通讯来跟 APISIX 进行数据交换。到目前为止，APISIX 已支持[Java](https://github.com/apache/apisix-java-plugin-runner), [Golang](https://github.com/apache/apisix-go-plugin-runner), [Python](https://github.com/apache/apisix-python-plugin-runner) and Node.js. Review comment: and Node.js. ```suggestion - RPC 是当前采用的开发方式。开发者可以使用他们需要的语言来进行 RPC 服务的开发，该 RPC 通过本地通讯来跟 APISIX 进行数据交换。到目前为止，APISIX 已支持[Java](https://github.com/apache/apisix-java-plugin-runner), [Golang](https://github.com/apache/apisix-go-plugin-runner), [Python](https://github.com/apache/apisix-python-plugin-runner) 和 Node.js。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
shuaijinchao opened a new pull request #5715: URL: https://github.com/apache/apisix/pull/5715 ### What this PR does / why we need it: FIX #5658 FIX #5663 ### process `Before FIX: ` rename log -> compression log -> nginx reopen `After FIX: ` rename log -> nginx reopen -> compression log refer to: https://nginx.org/en/docs/control.html#logs ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] GhangZh opened a new issue #787: request help: ApisixRoute apiversion Inconsistency
GhangZh opened a new issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787 ### Issue description apisix-ingress-controller set apisix_route_version: "apisix.apache.org/v2beta1" but my apisixroute apiVersion still "apisix.apache.org/v1"。ingress-controller 1.2.0 had this problem, but the problem still occurs when you switch to 1.3.0   ### Environment * your apisix-ingress-controller version (output of `apisix-ingress-controller version --long`):apisix-ingress-controller version 1.3.0-no-git-module-go1.13.8 * your Kubernetes cluster version (output of `kubectl version`):1.18.10 * if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (`uname -a`).linux -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj closed issue #671: bug: recordStatus status is overwritten
gxthrj closed issue #671: URL: https://github.com/apache/apisix-ingress-controller/issues/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #671: bug: recordStatus status is overwritten
gxthrj commented on issue #671: URL: https://github.com/apache/apisix-ingress-controller/issues/671#issuecomment-986767928 close this issue as #706 has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5714: Proposal: support OpenPolicyAgent for access control
tzssangglass commented on issue #5714: URL: https://github.com/apache/apisix/issues/5714#issuecomment-986753078 sounds good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5650: request help: etcd tls connect handshake failed
tzssangglass commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986752194 you can specify the SNI for etcd, as mentioned above. see more: https://github.com/apache/apisix/issues/5155#issuecomment-929948164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] deepzz0 commented on issue #5650: request help: etcd tls connect handshake failed
deepzz0 commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986700762 > Is this a self-signed certificate or signed by a private CA? Have you configured the `ssl_trusted_certificate` option? Yes, it's self-signed. You can see the configuration above, `ssl_trusted_certificate` has been set. If `verify` is set to true, an error "Certificate host Mismatch."，But I have no problem passing OpenSSL authentication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #779: feat: support regex in path
codecov-commenter edited a comment on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-984603700 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#779](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f0f5775) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1bbadf0d8e6aefeb11e55ab0d7230547d3c06135?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1bbadf0) will **increase** coverage by `0.49%`. > The diff coverage is `80.76%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #779 +/- ## == + Coverage 32.42% 32.91% +0.49% == Files 65 65 Lines6872 6929 +57 == + Hits 2228 2281 +53 - Misses 4396 4397 +1 - Partials 248 251 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/annotations/cors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvY29ycy5nbw==) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/iprestriction.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvaXByZXN0cmljdGlvbi5nbw==) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/redirect.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmVkaXJlY3QuZ28=) | `0.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/rewrite.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmV3cml0ZS5nbw==) | `0.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/types.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvdHlwZXMuZ28=) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `73.16% <80.76%> (+4.32%)` | :arrow_up: | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `21.03% <0.00%> (+0.35%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-986634421 > In addition, can you please add documentation to introduce this feature? done for docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #779: feat: support regex in path
codecov-commenter edited a comment on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-984603700 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#779](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (973d745) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1bbadf0d8e6aefeb11e55ab0d7230547d3c06135?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1bbadf0) will **increase** coverage by `0.20%`. > The diff coverage is `80.76%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #779 +/- ## == + Coverage 32.42% 32.63% +0.20% == Files 65 65 Lines6872 6929 +57 == + Hits 2228 2261 +33 - Misses 4396 4410 +14 - Partials 248 258 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/annotations/cors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvY29ycy5nbw==) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/iprestriction.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvaXByZXN0cmljdGlvbi5nbw==) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/redirect.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmVkaXJlY3QuZ28=) | `0.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/rewrite.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmV3cml0ZS5nbw==) | `0.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/types.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvdHlwZXMuZ28=) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `73.16% <80.76%> (+4.32%)` | :arrow_up: | | [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.02% <0.00%> (-3.31%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: | |
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #779: feat: support regex in path
codecov-commenter edited a comment on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-984603700 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#779](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1faf7cf) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1bbadf0d8e6aefeb11e55ab0d7230547d3c06135?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1bbadf0) will **increase** coverage by `0.49%`. > The diff coverage is `80.76%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #779 +/- ## == + Coverage 32.42% 32.91% +0.49% == Files 65 65 Lines6872 6929 +57 == + Hits 2228 2281 +53 - Misses 4396 4397 +1 - Partials 248 251 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/annotations/cors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvY29ycy5nbw==) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/iprestriction.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvaXByZXN0cmljdGlvbi5nbw==) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/redirect.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmVkaXJlY3QuZ28=) | `0.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/rewrite.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvcmV3cml0ZS5nbw==) | `0.00% <ø> (ø)` | | | [pkg/kube/translation/annotations/types.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvdHlwZXMuZ28=) | `100.00% <ø> (ø)` | | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `73.16% <80.76%> (+4.32%)` | :arrow_up: | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `21.03% <0.00%> (+0.35%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/779?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path
lxm commented on a change in pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762862781 ## File path: pkg/kube/translation/ingress.go ## @@ -29,16 +29,23 @@ import ( "github.com/apache/apisix-ingress-controller/pkg/id" apisixv12 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v1" + configv2alpha1 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2alpha1" Review comment: a lot of changes were made. I've done the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] closed pull request #2070: feat: added ip-restriction form
github-actions[bot] closed pull request #2070: URL: https://github.com/apache/apisix-dashboard/pull/2070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #2070: feat: added ip-restriction form
github-actions[bot] commented on pull request #2070: URL: https://github.com/apache/apisix-dashboard/pull/2070#issuecomment-986624049 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5714: Proposal: support OpenPolicyAgent for access control
tokers commented on issue #5714: URL: https://github.com/apache/apisix/issues/5714#issuecomment-986607750 SGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] GhangZh edited a comment on issue #5708: request help: go-plugin-runner error after starting in debug mode
GhangZh edited a comment on issue #5708: URL: https://github.com/apache/apisix/issues/5708#issuecomment-986594212 > Is it relative to [#5628 (reply in thread)](https://github.com/apache/apisix/discussions/5628#discussioncomment-1713241)? Different, his sock is not found, my issue is not to look for this sock at all, but to find this sock:apisix-46.sock, and my /tmp/runner.sock is automatically generated,not mounted in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5650: request help: etcd tls connect handshake failed
tokers commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-986595093 Is this a self-signed certificate or signed by a private CA? Have you configured the `ssl_trusted_certificate` option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] GhangZh commented on issue #5708: request help: go-plugin-runner error after starting in debug mode
GhangZh commented on issue #5708: URL: https://github.com/apache/apisix/issues/5708#issuecomment-986594212 > Is it relative to [#5628 (reply in thread)](https://github.com/apache/apisix/discussions/5628#discussioncomment-1713241)? Different, his sock is not found, my issue is not to find the sock, and my /tmp/runner.sock is automatically generated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5630: docs: add APISIX software architecture diagram
spacewander closed issue #5630: URL: https://github.com/apache/apisix/issues/5630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5712: docs: Software architecture diagram added (zh-docs)
spacewander merged pull request #5712: URL: https://github.com/apache/apisix/pull/5712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (9754b5b -> 9731f51)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 9754b5b docs: update MAINTAIN.md (#5676) add 9731f51 docs: Software architecture diagram added (zh-docs) (#5712) No new revisions were added by this update. Summary of changes: docs/zh/latest/architecture-design/apisix.md | 4 1 file changed, 4 insertions(+)
[GitHub] [apisix] bzp2010 opened a new issue #5714: Proposal: support OpenPolicyAgent for access control
bzp2010 opened a new issue #5714:
URL: https://github.com/apache/apisix/issues/5714
## Background
OPA is an open source lightweight general-purpose policy engine, which is a
full-featured policy engine that can replace the built-in policy module in your
software and decouple the service from the policy engine.
It describes policies through a policy DSL language "Rego" and stores policy
data through JSON, after which the user can send a query request and OPA will
combine the policy with the data and the query request entered by the user to
generate policy decisions.
Users can easily integrate OPA with its services, such as program libraries,
HTTP API, etc. In this plugin, we will integrate OPA using HTTP API.
## Test Environment
```text
# Run the OPA throught Docker
docker run -d --name opa -p 8181:8181 openpolicyagent/opa:0.35.0 run -s
# Create policy 'example'
curl -XPUT 'localhost:8181/v1/policies/example' \
--header 'Content-Type: text/plain' \
--data-raw 'package example
default allow = false
allow {
input.request.http.headers["test-header"] == "only-for-test"
}'
# Test: success
curl -XPOST 'localhost:8181/v1/data/example/allow' \
--header 'Content-Type: application/json' \
--data-raw '{
"input": {
"request": {
"http": {
"headers": {
"test-header": "only-for-test"
}
}
}
}
}'
{
"result": true
}
# Test: failed
curl -XPOST 'localhost:8181/v1/data/example/allow' \
--header 'Content-Type: application/json' \
--data-raw '{
"input": {
"request": {
"http": {
"headers": {
"test-header": "not-for-test"
}
}
}
}
}'
{
"result": false
}
```
## Solutions
### Configure schema
Name | Type | Requirement | Default | Description
-- | -- | -- | -- | --
host | string | required | | OPA host (eg. https://localhost:8181)
ssl_verify | boolean | optional | true | Whether to verify the certificate
package | string | required | | Policy package
decision | string | required | | Policy rule name
### More functions (Need more discuss)
Name | Type | Requirement | Default | Description
-- | -- | -- | -- | --
with_route | boolean | optional | false | Carry current Route information in
OPA API requests
with_consumer | boolean | optional | false | Carry current Consumer
information in OPA API requests
with_upstream | boolean | optional | false | Carry current Upstream
information in OPA API requests
### Implemention
Create a plugin that encodes the request information as JSON during the
access execution phase, sends it to the OPA Data API and gets the response,
decides whether to overwrite the response and terminates the request processing
accordingly.
We provide a standard OPA response body specification, and the parts that
conform to it will be parsed by APISIX. (complex response as follows)
```json
## Requests like this `https://apisix.apache.org/contribute?abc=123`
{
"input": {
"request": {
"http": { # for HTTP subsystem（maybe can used by Stream subsystem also）
"host": "apisix.apache.org",
"port": "443",
"tls": {},
"method": "GET",
"scheme": "https",
"path": "/contribute",
"query": {
"abc" : "123"
},
"headers": {
"accept-encoding": "gzip, deflate"
}
}
},
"remote_addr": "127.0.0.1",
"upstream": {},
"route": {},
"consumer": {}
}
}
## Simply decision response from OPA
{
"result": true | false
}
## Complex decision response from OPA (supports overwriting responses and
terminating request processing)
{
"result": {
"allow": true | false,
"headers":{
"opa": "forbidden"
},
"statusCode": 403,
"body": "You are not authorized to access."
}
}
```
## Roadmap
The plugin implementation will follow the following roadmap, splitting into
different PRs for submission.
1. Implement MVP first: Supports sending request information to OPA and
processing the request with a simple response
2. Support OPA complex response with response overwrite
3. Support sending routing, upstream and other information to OPA to assist
in policy determination
## Other
What are your ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[GitHub] [apisix] youlianyiran removed a comment on issue #3231: request help: how to use apisix with zookeeper service discovery
youlianyiran removed a comment on issue #3231: URL: https://github.com/apache/apisix/issues/3231#issuecomment-986545990 > I am a java programmer. I am not familiar with the apisix and nginx, just a probably understanding of them, need a lot of time to be proficient in item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] youlianyiran removed a comment on issue #3231: request help: how to use apisix with zookeeper service discovery
youlianyiran removed a comment on issue #3231: URL: https://github.com/apache/apisix/issues/3231#issuecomment-986545643 > I am a java programmer. I am not familiar with the apisix and nginx, just a probably understanding of them, need a lot of time to be proficient in item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] youlianyiran commented on issue #3231: request help: how to use apisix with zookeeper service discovery
youlianyiran commented on issue #3231: URL: https://github.com/apache/apisix/issues/3231#issuecomment-986545990 > I am a java programmer. I am not familiar with the apisix and nginx, just a probably understanding of them, need a lot of time to be proficient in item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] youlianyiran commented on issue #3231: request help: how to use apisix with zookeeper service discovery
youlianyiran commented on issue #3231: URL: https://github.com/apache/apisix/issues/3231#issuecomment-986545643 > I am a java programmer. I am not familiar with the apisix and nginx, just a probably understanding of them, need a lot of time to be proficient in item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] youlianyiran commented on issue #3231: request help: how to use apisix with zookeeper service discovery
youlianyiran commented on issue #3231: URL: https://github.com/apache/apisix/issues/3231#issuecomment-986545173 > I am a java programmer. I am not familiar with the apisix and nginx, just a probably understanding of them, need a lot of time to be proficient in item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] youlianyiran removed a comment on issue #3231: request help: how to use apisix with zookeeper service discovery
youlianyiran removed a comment on issue #3231: URL: https://github.com/apache/apisix/issues/3231#issuecomment-986545173 > I am a java programmer. I am not familiar with the apisix and nginx, just a probably understanding of them, need a lot of time to be proficient in item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] saintak commented on issue #5711: bug: apisix.service无法开机自启动，而且ulimit没有设置
saintak commented on issue #5711: URL: https://github.com/apache/apisix/issues/5711#issuecomment-986542582 > > > PR is welcome, would you take it a try ? > > > > > > 翻看了半天没在代码库找到apisix.service的位置，所以我应该提到哪个位置呢？ > > Hello there, right [here](https://github.com/api7/apisix-build-tools/blob/master/usr/lib/systemd/system/apisix.service) 好的，已经提了pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] LiteSun merged pull request #5676: docs: update MAINTAIN.md
LiteSun merged pull request #5676: URL: https://github.com/apache/apisix/pull/5676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: update MAINTAIN.md (#5676)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 9754b5b docs: update MAINTAIN.md (#5676)
9754b5b is described below
commit 9754b5b694fb570078d79428724666948ef1d15b
Author: litesun
AuthorDate: Mon Dec 6 16:13:45 2021 +0800
docs: update MAINTAIN.md (#5676)
Co-authored-by: leslie <59061168+leslie-ts...@users.noreply.github.com>
---
MAINTAIN.md | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/MAINTAIN.md b/MAINTAIN.md
index 0a0b2cd..ec9a983 100644
--- a/MAINTAIN.md
+++ b/MAINTAIN.md
@@ -27,13 +27,16 @@
4. Package a vote artifact to Apache's dev-apisix repo. The artifact can be
created
via `VERSION=x.y.z make release-src`
5. Send the [vote
email](https://lists.apache.org/thread/vq4qtwqro5zowpdqhx51oznbjy87w9d0) to
d...@apisix.apache.org
+ > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `./release` directory
named `apache-apisix-${x.y.z}-vote-contents`
6. When the vote is passed, send the [vote result
email](https://lists.apache.org/thread/k2frnvj4zj9oynsbr7h7nd6n6m3q5p89) to
d...@apisix.apache.org
7. Move the vote artifact to Apache's apisix repo
8. Register the release info in
https://reporter.apache.org/addrelease.html?apisix
9. Create a [GitHub
release](https://github.com/apache/apisix/releases/tag/2.10.2) from the minor
branch
10. Update [APISIX's
website](https://github.com/apache/apisix-website/commit/f9104bdca50015722ab6e3714bbcd2d17e5c5bb3)
11. Update APISIX rpm package
-12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601),
and create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
+> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically submit
the
+package to yum repo
+12. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository](https://github.com/apache/apisix-docker), and
create new branch from master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
13. Send the [ANNOUNCE
email](https://lists.apache.org/thread.html/ree7b06e6eac854fd42ba4f302079661a172f514a92aca2ef2f1aa7bb%40%3Cdev.apisix.apache.org%3E)
to d...@apisix.apache.org & annou...@apache.org
### Release minor version
@@ -42,12 +45,14 @@ via `VERSION=x.y.z make release-src`
2. Package a vote artifact to Apache's dev-apisix repo. The artifact can be
created
via `VERSION=x.y.z make release-src`
3. Send the [vote
email](https://lists.apache.org/thread/q8zq276o20r5r9qjkg074nfzb77xwry9) to
d...@apisix.apache.org
+ > After executing the `VERSION=x.y.z make release-src` command, the content
of the vote email will be automatically generated in the `./release` directory
named `apache-apisix-${x.y.z}-vote-contents`
4. When the vote is passed, send the [vote result
email](https://lists.apache.org/thread/p1m9s116rojlhb91g38cj8646393qkz7) to
d...@apisix.apache.org
5. Move the vote artifact to Apache's apisix repo
6. Register the release info in
https://reporter.apache.org/addrelease.html?apisix
7. Create a [GitHub
release](https://github.com/apache/apisix/releases/tag/2.10.0) from the minor
branch
8. Merge the pull request into master branch
9. Update [APISIX's
website](https://github.com/apache/apisix-website/commit/7bf0ab5a1bbd795e6571c4bb89a6e646115e7ca3)
-10. Update APISIX rpm package
-11. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601),
and create new branch form master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
+10. Update APISIX rpm package.
+> Go to [apisix-build-tools](https://github.com/api7/apisix-build-tools)
repository and create a new tag named `apisix-${x.y.z}` to automatically submit
the rpm package to yum repo
+11. Update [APISIX
docker](https://github.com/apache/apisix-docker/commit/829d45559c303bea7edde5bebe9fcf4938071601)
in [APISIX docker repository](https://github.com/apache/apisix-docker), and
create new branch from master, named as `release/apisix-${version}`, e.g.
`release/apisix-2.10.2`
12. Send the [ANNOUNCE
email](https://lists.apache.org/thread/4s4msqwl1tq13p9dnv3hx7skbgpkozw1) to
d...@apisix.apache.org & annou...@apache.org
