[GitHub] [apisix] tzssangglass commented on issue #5723: CPU usage gets higher when Apache APISIX is running a long time
tzssangglass commented on issue #5723: URL: https://github.com/apache/apisix/issues/5723#issuecomment-987934535 related to: https://github.com/apache/apisix/issues/5692 can you provide packet capture data for the network between apisix and etcd? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5596: request help: customize Nginx variable in the configuration
tzssangglass commented on issue #5596: URL: https://github.com/apache/apisix/issues/5596#issuecomment-987926989 > so maybe we are missing an http_server_location_configuration_snippet item. Yes, that's what I mean about our lack of provision for users to set custom variables. Would you like to try it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5728: refine the ua-restriction plugin configuration checksum logic
juzhiyuan commented on pull request #5728: URL: https://github.com/apache/apisix/pull/5728#issuecomment-987915927 @zuiyangqingzhou Hi, please also update this PR's description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5728: refine the ua-restriction plugin configuration checksum logic
juzhiyuan commented on a change in pull request #5728:
URL: https://github.com/apache/apisix/pull/5728#discussion_r763979941
##
File path: apisix/plugins/ua-restriction.lua
##
@@ -34,11 +35,11 @@ local schema = {
type = "boolean",
default = false,
},
-allowlist = {
+allow_list = {
type = "array",
minItems = 1
},
-denylist = {
+deny_list = {
Review comment:
May I know the reason to modify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
tzssangglass commented on issue #5706: URL: https://github.com/apache/apisix/issues/5706#issuecomment-987915215 Maybe we can enhance nacos discovery to make it work. Would anyone like to give a detailed example? For example, from which interface of nacos do we get information? What information is being fetched? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5727: feat: add CSRF plugin
juzhiyuan commented on a change in pull request #5727:
URL: https://github.com/apache/apisix/pull/5727#discussion_r763978097
##
File path: apisix/plugins/csrf.lua
##
@@ -0,0 +1,150 @@
+local core= require("apisix.core")
+local ngx = ngx
+local plugin_name = "csrf"
+local ngx_encode_base64 = ngx.encode_base64
+local ngx_decode_base64 = ngx.decode_base64
+local ck = require "resty.cookie"
+local math = math
+
+local lrucache = core.lrucache.new({
+type = "plugin",
+})
+
+local schema = {
+ type = "object",
+ properties = {
+ key = {
+ description = "use to generate csrf token",
+ type = "string",
+ },
+ expires = {
+ description = "expires time for csrf token",
+ type = "integer",
+ default = 7200
+ },
+name = {
Review comment:
Format your codes？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5686: feat: add a tool that can help users quickly try your project
juzhiyuan commented on pull request #5686: URL: https://github.com/apache/apisix/pull/5686#issuecomment-987909316 > > IMO, we need to discuss in ML first, TeamCode is a commercial product and requires user login to use > > Hi, I sent a mail to the address: [dev-subscr...@apisix.apache.org](mailto:dev-subscr...@apisix.apache.org) . Hope the letter will resolve your concerns. Looking forward to your reply. Hi, please follow https://apisix.apache.org/docs/general/subscribe-guide to subscribe the mailing list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5719: bug: 当我使用kafka-logger插件时候，kafka里没有获取到写入时间
juzhiyuan commented on issue #5719: URL: https://github.com/apache/apisix/issues/5719#issuecomment-987908278 Hi, could you please provide more steps so I could reproduce it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xuminwlt commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
xuminwlt commented on issue #5706: URL: https://github.com/apache/apisix/issues/5706#issuecomment-987902430 +1 need too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xuminwlt opened a new issue #5729: request help: module 'toolkit.json' not found when use test-nginx for unit test
xuminwlt opened a new issue #5729: URL: https://github.com/apache/apisix/issues/5729 ### Issue description  test-nginx project is clone like this root/ is project root - root/test-nginx - roor/apisix test-nginx test is fine. but cd to apisix and run is fail ``` prove -I. -I../test-nginx/inc -I../test-nginx/lib -r t/script ``` Then copy the https://github.com/api7/test-toolkit to root/apisix/t/toolkit https://github.com/apache/apisix/issues/2936 The problem is still there. In addition, there are some problems in the documentation of the development environment of the whole apifix. Although I have handled them, it still took me two days. Hope this is the last question. - -! ### Environment - apisix version (cmd: `apisix version`): master - OS (cmd: `uname -a`): macos - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): 1.19.3.2 - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #784: request help: regex_uri in proxy-rewriter
tokers commented on issue #784:
URL:
https://github.com/apache/apisix-ingress-controller/issues/784#issuecomment-987894374
> ```
>
> apiVersion: apisix.apache.org/v2beta2
>
> kind: ApisixRoute
>
> metadata:
>
> name: frontend-route
>
> spec:
>
> http:
>
> - name: frontend
>
> match:
>
> hosts:
>
> - test.aaa.com
>
> paths:
>
> - /*
>
> backends:
>
>- serviceName: frontend
>
> servicePort: 80
>
> plugins:
>
>- name: proxy-rewrite
>
> enable: true
>
> config:
>
>regex_uri: ["^/(.*)", "/$1"]
>
> ```
>
> and
>
> ```apiVersion: apisix.apache.org/v2beta2
>
> kind: ApisixRoute
>
> metadata:
>
> name: backend-route
>
> spec:
>
> http:
>
> - name: backend
>
> match:
>
> hosts:
>
> - test.aaa.com
>
> paths:
>
> - /api/*
>
> backends:
>
>- serviceName: backend
>
> servicePort: 8080
>
> plugins:
>
>- name: proxy-rewrite
>
> enable: true
>
> config:
>
>regex_uri: ["^/api/(.*)$", "/api/$1"]
>
> ```
>
> Temporarily, I use apisix dashboard to create route and upstream, and it
goes well
>
> ```//route frontend
>
> {
>
> "uri": "/*",
>
> "name": "frontend_route",
>
> "methods": [
>
> "GET",
>
> "POST",
>
> "PUT",
>
> "DELETE",
>
> "PATCH",
>
> "HEAD",
>
> "OPTIONS",
>
> "CONNECT",
>
> "TRACE"
>
> ],
>
> "plugins": {
>
> "proxy-rewrite": {
>
> "regex_uri": [
>
> "^/(.*)",
>
> "/$1"
>
> ]
>
> }
>
> },
>
> "upstream_id": "384232553139143705",
>
> "status": 1
>
> }
>
> ```
>
> and
>
> ```//route backend
>
> {
>
> "uri": "/api/*",
>
> "name": "backend_route",
>
> "methods": [
>
> "GET",
>
> "POST",
>
> "PUT",
>
> "DELETE",
>
> "PATCH",
>
> "HEAD",
>
> "OPTIONS",
>
> "CONNECT",
>
> "TRACE"
>
> ],
>
> "plugins": {
>
> "proxy-rewrite": {
>
> "regex_uri": [
>
> "^/api/(.*)",
>
> "/api/$1"
>
> ]
>
> }
>
> },
>
> "upstream_id": "384236511421269017",
>
> "status": 1
>
> }
>
> ```
>
>
The ApisixRoute configurations look good to me. But are there any logs
printed by apisix ingress controller?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #5718: docs: refactor Installation Guide
tokers commented on pull request #5718: URL: https://github.com/apache/apisix/pull/5718#issuecomment-987891961 > > docs: refactor Installation Guide > > > > Hi @tzssangglass, I'm confused by this file Because this file's title is `How to build Apache APISIX`, it's more like used in a Development environment (including the Make Test part). > > > > We have feedbacks that it seems that we mixed the Installation Guide with Developer Guides, when users want to install and use Apache APISIX, they only need to follow Step 1 ~ Step 3, right? And they could continue reading AdminAPI docs > > > > Note: This comment is not related to this PR It's my understanding that we can prepare two files, the one for installation and the other one for building from the source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #774: fix: delete the cluster object when give up the leadership
tokers commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r763953716 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: I have updated it but I don't have time to validate the e2e case until this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5728: refine the ua-restriction plugin configuration checksum logic
tokers commented on a change in pull request #5728:
URL: https://github.com/apache/apisix/pull/5728#discussion_r763952504
##
File path: apisix/plugins/ua-restriction.lua
##
@@ -34,11 +35,11 @@ local schema = {
type = "boolean",
default = false,
},
-allowlist = {
+allow_list = {
Review comment:
It's a broken change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5449: feat(oidc): make it possible to validate tokens against provider host…
juzhiyuan commented on pull request #5449: URL: https://github.com/apache/apisix/pull/5449#issuecomment-987879068 > Author of the PR here, just to avoid confusion. I have deployed the above fix already internally and its working there for me. From what I can see here merging is currently blocked because of currently used testing infrastructure (Tokens and Endpoints from Auth0) missing properties in the Token and therefore tests failing. I personally am not working on the issues with the testing infrastructure. Thanks for your update, and when you're free, welcome to continue on this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anderseknert commented on issue #5714: Proposal: support OpenPolicyAgent for access control
anderseknert commented on issue #5714: URL: https://github.com/apache/apisix/issues/5714#issuecomment-987872952 Thanks for raising this @bzp2010 Let me know if there's any questions along the way with regards to OPA, and I'd be happy to answer them :) As for the suggested input format - looks mostly good to me! I would suggest however to not use `http` as the "top level" attribute inside of the request, but rather put that detail inside of the request object. That way one can write and use the same policies for any type of request, and just check a single attribute later if one needs to take the protocol into account. As for the response object, also looks pretty good to me! I'd suggest renaming `body` to `reason`, and it looks a bit odd that `statusCode` in the response is camel case, while the input attributes are snake case, so I'd suggest using one or the other consistently. But either way, looks like a great start! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987855282 ping @tao12345666333 @gxthrj @lingsamuel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zlhgo edited a comment on issue #5596: request help: customize Nginx variable in the configuration
zlhgo edited a comment on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-987792571
i have written a plugin for this issue, but there is a problem that the `set
$upstream_name -;` directive must be placed in the location block, so maybe we
are missing an http_server_location_configuration_snippet item.
1. nginx config
```
log_format main escape=default '$remote_addr - [$remote_addr] - $remote_user
[$time_local] "$request" $status $body_bytes_sent "$http_referer"
"$http_user_agent" $request_length $request_time [$upstream_name]
$upstream_addr $upstream_response_length $upstream_response_time
$upstream_status $req_id $host [$scheme]';
location / {
set $upstream_name -;
}
```
2. code
```
function _M.before_proxy(conf, ctx)
-- maybe the ctx.matched_upstream can not access in the access phase
ngx.var.upstream_name = ctx.matched_upstream.name
core.log.warn("set $upstream_name=", ngx.var.upstream_name)
end
```
3. access log
```
192.168.235.25 - [192.168.235.25] - - [07/Dec/2021:10:20:10 +] "GET
/hostname HTTP/2.0" 200 33 "-" "curl/7.64.0" 48 0.003
[devops_flask-demo-online_8000] 172.16.214.127:8000 33 0.003 200
20d275ca0a73c2f141be75e22254b119 flask-demo.apisix.net [https]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zlhgo edited a comment on issue #5596: request help: customize Nginx variable in the configuration
zlhgo edited a comment on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-987792571
i have written a plugin for this issue, but there is a problem that the `set
$upstream_name -;` directive must be placed in the location block, so maybe we
are missing a http_server_location_configuration_snippet item.
1. nginx config
```
log_format main escape=default '$remote_addr - [$remote_addr] - $remote_user
[$time_local] "$request" $status $body_bytes_sent "$http_referer"
"$http_user_agent" $request_length $request_time [$upstream_name]
$upstream_addr $upstream_response_length $upstream_response_time
$upstream_status $req_id $host [$scheme]';
location / {
set $upstream_name -;
}
```
2. code
```
function _M.before_proxy(conf, ctx)
-- maybe the ctx.matched_upstream can not access in the access phase
ngx.var.upstream_name = ctx.matched_upstream.name
core.log.warn("set $upstream_name=", ngx.var.upstream_name)
end
```
3. access log
```
192.168.235.25 - [192.168.235.25] - - [07/Dec/2021:10:20:10 +] "GET
/hostname HTTP/2.0" 200 33 "-" "curl/7.64.0" 48 0.003
[devops_flask-demo-online_8000] 172.16.214.127:8000 33 0.003 200
20d275ca0a73c2f141be75e22254b119 flask-demo.apisix.net [https]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zlhgo edited a comment on issue #5596: request help: customize Nginx variable in the configuration
zlhgo edited a comment on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-987792571
i have written a plugin for this issue, but there is a problem that the `set
$upstream_name -;` directive must be placed in the location section, so maybe
we are missing a http_server_location_configuration_snippet item.
1. nginx config
```
log_format main escape=default '$remote_addr - [$remote_addr] - $remote_user
[$time_local] "$request" $status $body_bytes_sent "$http_referer"
"$http_user_agent" $request_length $request_time [$upstream_name]
$upstream_addr $upstream_response_length $upstream_response_time
$upstream_status $req_id $host [$scheme]';
location / {
set $upstream_name -;
}
```
2. code
```
function _M.before_proxy(conf, ctx)
-- maybe the ctx.matched_upstream can not access in the access phase
ngx.var.upstream_name = ctx.matched_upstream.name
core.log.warn("set $upstream_name=", ngx.var.upstream_name)
end
```
3. access log
```
192.168.235.25 - [192.168.235.25] - - [07/Dec/2021:10:20:10 +] "GET
/hostname HTTP/2.0" 200 33 "-" "curl/7.64.0" 48 0.003
[devops_flask-demo-online_8000] 172.16.214.127:8000 33 0.003 200
20d275ca0a73c2f141be75e22254b119 flask-demo.apisix.net [https]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zlhgo edited a comment on issue #5596: request help: customize Nginx variable in the configuration
zlhgo edited a comment on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-987792571
i have written a plugin for this issue, but there is a problem that the `set
$upstream_name -;` directive must place in the location section, so maybe we
are missing a http_server_location_configuration_snippet item.
1. nginx config
```
log_format main escape=default '$remote_addr - [$remote_addr] - $remote_user
[$time_local] "$request" $status $body_bytes_sent "$http_referer"
"$http_user_agent" $request_length $request_time [$upstream_name]
$upstream_addr $upstream_response_length $upstream_response_time
$upstream_status $req_id $host [$scheme]';
location / {
set $upstream_name -;
}
```
2. code
```
function _M.before_proxy(conf, ctx)
-- maybe the ctx.matched_upstream can not access in the access phase
ngx.var.upstream_name = ctx.matched_upstream.name
core.log.warn("set $upstream_name=", ngx.var.upstream_name)
end
```
3. access log
```
192.168.235.25 - [192.168.235.25] - - [07/Dec/2021:10:20:10 +] "GET
/hostname HTTP/2.0" 200 33 "-" "curl/7.64.0" 48 0.003
[devops_flask-demo-online_8000] 172.16.214.127:8000 33 0.003 200
20d275ca0a73c2f141be75e22254b119 flask-demo.apisix.net [https]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] fbartels commented on pull request #5449: feat(oidc): make it possible to validate tokens against provider host…
fbartels commented on pull request #5449: URL: https://github.com/apache/apisix/pull/5449#issuecomment-987830406 Author of the PR here, just to avoid confusion. I have deployed the above fix already internally and its working there for me. From what I can see here merging is currently blocked because of currently used testing infrastructure (Tokens and Endpoints from Auth0) missing properties in the Token and therefore tests failing. I personally am not working on the issues with the testing infrastructure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #788: fix: ingress LB status records
codecov-commenter edited a comment on pull request #788: URL: https://github.com/apache/apisix-ingress-controller/pull/788#issuecomment-987664591 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#788](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2032d88) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1bbadf0d8e6aefeb11e55ab0d7230547d3c06135?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1bbadf0) will **decrease** coverage by `0.29%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #788 +/- ## == - Coverage 32.42% 32.12% -0.30% == Files 65 66 +1 Lines6872 6876 +4 == - Hits 2228 2209 -19 - Misses 4396 4412 +16 - Partials 248 255 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.02% <0.00%> (-3.31%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | `100.00% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [1bbadf0...2032d88](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zlhgo edited a comment on issue #5596: request help: customize Nginx variable in the configuration
zlhgo edited a comment on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-987792571
i have written a plugin for this issue, but there is a problem that the `set
$upstream_name -;` directive must place in the location section, so maybe we
are missing a http_server_location_configuration_snippet item.
1. nginx config
```
log_format main escape=default '$remote_addr - [$remote_addr] - $remote_user
[$time_local] "$request" $status $body_bytes_sent "$http_referer"
"$http_user_agent" $request_length $request_time [$upstream_name]
$upstream_addr $upstream_response_length $upstream_response_time
$upstream_status $req_id $host [$scheme]';
location / {
set $upstream_name -;
}
```
2. code
```
function _M.before_proxy(conf, ctx)
-- maybe the ctx.matched_upstream can not access in the access phase
ngx.var.upstream_name = ctx.matched_upstream.name
core.log.warn("set $upstream_name=", ngx.var.upstream_name)
end
```
3. access log
```
192.168.235.25 - [192.168.235.25] - - [07/Dec/2021:10:20:10 +] "GET
/hostname HTTP/2.0" 200 33 "-" "curl/7.64.0" 48 0.003
[devops_flask-demo-online_8000] 172.16.214.127:8000 33 0.003 200
20d275ca0a73c2f141be75e22254b119 flask-demo.apisix.net [https]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zlhgo commented on issue #5596: request help: customize Nginx variable in the configuration
zlhgo commented on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-987792571
i have written a plugin for this issue, but there is a problem that the `set
$upstream_name -;` directive must place in the location section, so maybe we
are missing a http_server_location_configuration_snippet item.
1. nginx config
```
log_format main escape=default '$remote_addr - [$remote_addr] - $remote_user
[$time_local] "$request" $status $body_bytes_sent "$http_referer"
"$http_user_agent" $request_length $request_time [$upstream_name]
$upstream_addr $upstream_response_length $upstream_response_time
$upstream_status $req_id $host [$scheme]';
location / {
set $upstream_name -;
}
```
2. code
```
function _M.before_proxy(conf, ctx)
-- maybe the ctx.matched_upstream can not access in the access phase
ngx.var.upstream_name = ctx.matched_upstream.name
core.log.warn("set $upstream_name=", ngx.var.upstream_name)
end
```
3. access log
```
192.168.235.25 - [192.168.235.25] - - [07/Dec/2021:10:20:10 +] "GET
/hostname HTTP/2.0" 200 33 "-" "curl/7.64.0" 48 0.003
[devops_flask-demo-online_8000] 172.16.214.127:8000 33 0.003 200
20d275ca0a73c2f141be75e22254b119 flask-demo.rd.kuaiyin123.net [https]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #796: docs: add Shivam committer Chinese version blog
juzhiyuan merged pull request #796: URL: https://github.com/apache/apisix-website/pull/796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: docs: add Shivam committer Chinese version blog (#796)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new aa81b30 docs: add Shivam committer Chinese version blog (#796) aa81b30 is described below commit aa81b30e0c2b432e43932170ec7301b5e8bb2815 Author: Sylvia <39793568+sylviab...@users.noreply.github.com> AuthorDate: Tue Dec 7 18:36:33 2021 +0800 docs: add Shivam committer Chinese version blog (#796) --- .../11/26/apache-apisix-committer-experience.md| 61 ++ 1 file changed, 61 insertions(+) diff --git a/website/i18n/zh/docusaurus-plugin-content-blog/2021/11/26/apache-apisix-committer-experience.md b/website/i18n/zh/docusaurus-plugin-content-blog/2021/11/26/apache-apisix-committer-experience.md new file mode 100644 index 000..bcd14f9 --- /dev/null +++ b/website/i18n/zh/docusaurus-plugin-content-blog/2021/11/26/apache-apisix-committer-experience.md @@ -0,0 +1,61 @@ +--- +title: "成为 Apache APISIX Committer 让我体会到了知识转换价值的意义" +author: "Shivam Singh" +authorURL: "https://github.com/1502shivam-singh; +authorImageURL: "https://avatars.githubusercontent.com/u/57267960?v=4; +keywords: +- 开源 +- Apache APISIX +- 社区 +- 人物故事 +description: 本文将从 Shivam Singh（@1502shivam-singh）个人角度，简要描述了他是如何在 Apache APISIX 社区中从贡献者成长为 Apache Committer。希望他的个人参与历程可以帮助到那些希望在 Apache APISIX 社区或其他开源社区进行项目贡献的朋友。 +tags: [Community] +--- + +> 本文将从 Shivam Singh（[@1502shivam-singh](https://github.com/1502shivam-singh)）个人角度，简要描述了他是如何在 Apache APISIX 社区中从贡献者成长为 Apache Committer。希望他的个人参与历程可以帮助到那些希望在 Apache APISIX 社区或其他开源社区进行项目贡献的朋友。 + + + +我是 [Shivam Singh](https://twitter.com/Shivam15_)，Indian Institute of Information Technology 本科生，目前也是一名全栈工程师和产品设计师。我认为每一个伟大的产品都是工程和设计的结晶，产品的呈现不仅需要融合技术，同时也要带来视觉上的愉悦，最终在结果导向下解决终端用户的各种关键问题。 + +我个人非常喜欢「创作之路」的历程。比如独立开发一个产品或应用，从最初的概念化开始，到产品最终完成和交付，我可以非常享受地完成这中间涵盖的所有工程与设计细节。 + +也正是对于细节与创作的关注，才有了现在与开源社区和 Apache APISIX 的碰撞。 + +## 与 Apache APISIX 的美好回忆 + +自从开始参与 Apache APISIX 项目，我在社区里结识了很多友好且乐于沟通协作的伙伴们，或许大家都来自不同的国家，但这种「技术社区协作」却给我留下了一段非常美好的开源旅程回忆。 + +我觉得参与 Apache APISIX 社区对于想要接触开源项目和开源文化的朋友而言，都是一个不可多得的体验起点。 + +### 相识 + +这一切的开始要从 2021 年 2 月说起。那时的我为了将自己所学知识真正地发挥出来，想要给人们提供一些真正有价值的东西，所以开始在 GitHub 上寻找可以参与贡献的开源软件项目。 + +大家如果跟我一样也想搜寻一些适合自己的可贡献开源项目，可以查看一下 [Google Summer of Code](https://summerofcode.withgoogle.com/archive/) 组织页面或者搜索一些带有「good first issue」的简易项目 issue 进行相关的贡献。 + +在四处寻找和测试了几个项目后，我遇到了 Apache APISIX。在查阅了项目的任务 JIRA 面板后，与社区相关人员取得了联系并收到了加入社区 Slack 的邀请，之后的故事就顺理成章地开始了。 + +### 相知 + +考虑到个人的专业领域，我选择了 [apache/apisix-website](https://github.com/apache/apisix-website) 这个项目下的 issue 开始真正步入「开源旅程」。 + +当我开始接手尝试去做 Apache APISIX 官网页面时，我注意到这个项目在很多方面都有所欠缺，尤其是当时的官网页面所展示的功能与 Apache APISIX 真正所能提供的细节上存在很大的差距。一个产品有多好，不能只是产品本身做得好就够了，也需要通过一些途径向外界展示出来「到底有多好」。 + +针对这个问题我提出了相关意见，与社区伙伴们探讨后，刚好借由 Google Summer of Code 开始了针对 Apache APISIX 官网页面的改造。该项目从今年 5 月开始，2021 年 9 月新版官网成功上线。感谢参与这个项目中来自 Apache APISIX 社区多位 Committer 成员（[温铭](https://github.com/moonming)、[琚致远](https://github.com/juzhiyuan)和[吴舒旸](https://github.com/Yiyiyimu)）的帮助。 + +### 感恩有你 + +能够通过提高社区影响力和改善品牌形象的目的来参与社区，对我来说是一个很好的经历。这也使我在 Apache APISIX 的成长进入到一个新阶段。 + + + +我在用户体验（设计+前端）、产品和增长方面为社区做出了自己力所能及的努力，也通过这些努力收获了来自社区的认可，并被大家投票评选为 Apache APISIX Committer。这个过程对我而言是非常真实且富有激励作用的，让我有了更多的热情和信心在未来去参与更多的开源项目贡献。 + +## 还在观望开源社区？ + +最后，从我的个人经历角度给大家提供一些参考建议。 + +对于像我一样的大学生或刚开始从事开源项目的朋友来说，在参与开源的过程中一定要热爱你所做的事情，多从创造产品的角度去思考。因为能够创造出对他人有用并广为流传的产品，对于每一个从事开源参与者来说都是一件很骄傲的事情。我相信这也是开源软件所存在的意义。 + +探索并找到你喜欢的东西，然后沉迷于此，是一件很幸福的事情。
[GitHub] [apisix] zuiyangqingzhou opened a new pull request #5728: refine the ua-restriction plugin configuration checksum logic
zuiyangqingzhou opened a new pull request #5728: URL: https://github.com/apache/apisix/pull/5728 fix: [5724](https://github.com/apache/apisix/issues/5724) ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Baoyuantop opened a new pull request #5727: feat: add CSRF plugin
Baoyuantop opened a new pull request #5727: URL: https://github.com/apache/apisix/pull/5727 ### What this PR does / why we need it: Add CSRF plugin for APISIX Discuss in https://lists.apache.org/thread/ddj53svylg9s541vf2gpysxwgyrhwlzx ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan edited a comment on pull request #5718: docs: refactor Installation Guide
juzhiyuan edited a comment on pull request #5718: URL: https://github.com/apache/apisix/pull/5718#issuecomment-987782053 Here has one issue about Make Test: https://github.com/apache/apisix/issues/5726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5718: docs: refactor Installation Guide
juzhiyuan commented on pull request #5718: URL: https://github.com/apache/apisix/pull/5718#issuecomment-987782053 Here has one PR about Make Test: https://github.com/apache/apisix/issues/5726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5723: apisix长时间运行，etcd CPU占用升高
tokers commented on issue #5723: URL: https://github.com/apache/apisix/issues/5723#issuecomment-987776625 @zero-create Would you try to disable the `server-info` plugin to see what happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5723: apisix长时间运行，etcd CPU占用升高
tokers commented on issue #5723: URL: https://github.com/apache/apisix/issues/5723#issuecomment-987776298 It seems that the lease grant requests cost a lot of time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] besich commented on issue #5726: docs: suggest separate “step 4: run test cases” from the installation document
besich commented on issue #5726: URL: https://github.com/apache/apisix/issues/5726#issuecomment-987775618 problems encountered in executing make test to run unit tests. execute ```shell make ci-env-up make ci-env-up project_compose_ci=ci/pod/docker-compose.common.yml make init make test ``` there are still environment dependency issues, mainly * about test-nginx. suggest git submodule add https://github.com/iresty/test-nginx.git t/test-nginx * make test executes prove -I../test-nginx/lib -I./ -r -s t/. there are two main problems * -I../test-nginx/lib: it’s not recommended to place dependencies outside the project. * -I. : I feel that the introduction of this directory(.) is redundant, this to be confirmed? * make test report an error. Failed to get the version of the Nginx in PATH: Since the makefile can recognize my mac system, it’s can identify the env variable and execute it itself. at present, i’m executing TEST_NGINX_BINARY=/usr/local/bin/openresty prove -It/test-nginx/lib -I./ -r t/admin * make ci-env-up is executed through docker composer. It requires machine memory. It is recommended to add a separate container for environment inspection. It should be executed once when starting. Check the environment and give a warning. For example, the prompt memory is less than 10g, but it is still executed. In this way, when various conditions are caused by insufficient memory settings, you can judge and adjust according to the prompt In summary, it is recommended that the add make ci-env-init be checked similarly to the environment dependency. which is only used for make test and the development and test APISIX built by ourselves, and will not have any impact on the production environment the above suggestions are only for the implementation of make test and do not involve changing any production environment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] besich opened a new issue #5726: docs:
besich opened a new issue #5726: URL: https://github.com/apache/apisix/issues/5726 ### Improved or typo fixed. this document contains the relevant chapters “Step 4: Run Test Cases” i suggest that this chapter be separated into a markdown file. The reasons are as follows: * follow the installtion step. make test will not run successfully, because it lacks the dependency. * keep the purity of installtion document. running test cases belongs to development documents, and the dependent installtion of test cases is very complex, so independent documents are required ### Solution i suggest that this chapter be separated into a markdown file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9e326ce) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.74%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.13% -20.75% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1558 -3525 + Misses 1897 1413 -484 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.13% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #2152: feat: added dashboard backend api for apisix status summary
github-actions[bot] commented on pull request #2152: URL: https://github.com/apache/apisix-dashboard/pull/2152#issuecomment-987766216 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #2923: bug: missing ssl cert for ssl
github-actions[bot] commented on issue #2923: URL: https://github.com/apache/apisix/issues/2923#issuecomment-987763713 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #4984: docs: fulfill discovery_type description
github-actions[bot] commented on pull request #4984: URL: https://github.com/apache/apisix/pull/4984#issuecomment-987763764 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed pull request #4984: docs: fulfill discovery_type description
github-actions[bot] closed pull request #4984: URL: https://github.com/apache/apisix/pull/4984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #2923: bug: missing ssl cert for ssl
github-actions[bot] closed issue #2923: URL: https://github.com/apache/apisix/issues/2923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] GhangZh closed issue #5708: request help: go-plugin-runner error after starting in debug mode
GhangZh closed issue #5708: URL: https://github.com/apache/apisix/issues/5708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] GhangZh commented on issue #5708: request help: go-plugin-runner error after starting in debug mode
GhangZh commented on issue #5708: URL: https://github.com/apache/apisix/issues/5708#issuecomment-987752837 > Thanks for the help, it was a problem with the environment variables that didn't get this configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (769dec8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cbcac5f74b1da44540603493f0f4bfe417de414b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cbcac5f) will **increase** coverage by `1.81%`. > The diff coverage is `93.93%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 68.02% 69.83% +1.81% == Files 127 184 +57 Lines3359 7274+3915 Branches 826 829 +3 == + Hits 2285 5080+2795 - Misses 1074 1899 +825 - Partials0 295 +295 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.94% <ø> (?)` | | | backend-e2e-test-ginkgo | `57.13% <ø> (?)` | | | backend-unit-test | `49.16% <ø> (?)` | | | frontend-e2e-test | `68.06% <93.93%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <ø> (ø)` | | | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | `88.09% <87.50%> (+0.91%)` | :arrow_up: | | [web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==) | `92.30% <100.00%> (ø)` | | | [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <100.00%> (ø)` | | | [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `91.66% <100.00%> (ø)` | | | [.../src/pages/Route/components/Step1/ProxyRewrite.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1Byb3h5UmV3cml0ZS50c3g=) | `94.82% <100.00%> (+0.38%)` | :arrow_up: | |
[GitHub] [apisix-website] okaybase commented on pull request #796: docs: add Shivam committer Chinese version blog
okaybase commented on pull request #796: URL: https://github.com/apache/apisix-website/pull/796#issuecomment-987736649 congratulation~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zuiyangqingzhou opened a new issue #5724: bug: regular matches have bugs in specific scenarios
zuiyangqingzhou opened a new issue #5724:
URL: https://github.com/apache/apisix/issues/5724
### Issue description
The ngx.re.find method is used in the ua-restriction and uri-blocker
plug-ins, but there is no strict logical checking of the regex parameter, which
in some cases can cause the program to crash.
### Environment
- apisix version (cmd: `apisix version`): 2.9.0
- OS (cmd: `uname -a`): x86_64 x86_64 x86_64 GNU/Linux
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
openresty/1.19.9.1
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
### Steps to reproduce
1. turn on the ua-restriction plugin
```
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"methods": ["GET"],
"uri": "/test",
"plugins": {
"ua-restriction": {
"denylist": [
null,
],
"message": "x"
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:": 1
}
}
}'
```
2. call http request
```
curl -i ‘http://127.0.0.1:9080/test’ -H 'User-Agent: Mozilla/5.0 (Macintosh;
Intel Mac OS X 10_9_3) AppleWebKit/537.75.14 (KHTML, like Gecko) Version/7.0.3
Safari/7046A194A'
```
### Actual result
HTTP/1.1 500 Internal Server Error
Server: openresty
Date: Tue, 07 Dec 2021 09:08:55 GMT
Content-Type: text/html; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
500 Internal Server Error
body {
width: 35em;
margin: 0 auto;
font-family: Tahoma, Verdana, Arial, sans-serif;
}
Sorry, an error occurred.
### Error log
2021/12/06 08:32:50 [error] 15486#15486: *7140153 lua entry thread aborted:
runtime error: /usr/local/openresty/lualib/resty/core/regex.lua:584: attempt to
concatenate local 'regex' (a userdata value)
stack traceback:
coroutine 0:
/usr/local/openresty/lualib/resty/core/regex.lua: in function
're_match_compile'
/usr/local/openresty/lualib/resty/core/regex.lua:624: in function
're_find'
/usr/local/apisix/apisix/plugins/ua-restriction.lua:72: in function
'create_obj_fun'
/usr/local/apisix/apisix/core/lrucache.lua:92: in function
'lrucache_useragent'
/usr/local/apisix/apisix/plugins/ua-restriction.lua:121: in function
'phase_func'
/usr/local/apisix/apisix/plugin.lua:654: in function 'run_plugin'
/usr/local/apisix/apisix/init.lua:465: in function 'http_access_phase'
access_by_lua(nginx.conf:267):2: in main chunk, client: 10.18.1.80,
server: _, request: "GET /test HTTP/1.1", host: "127.0.0.1:9080"
### Expected result
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on a change in pull request #796: docs: add Shivam committer Chinese version blog
yzeng25 commented on a change in pull request #796: URL: https://github.com/apache/apisix-website/pull/796#discussion_r763795682 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/11/26/apache-apisix-committer-experience.md ## @@ -0,0 +1,61 @@ +--- +title: "成为 Apache APISIX Committer 让我体会到了知识转换价值的意义" +author: "Shivam Singh" +authorURL: "https://github.com/1502shivam-singh; +authorImageURL: "https://avatars.githubusercontent.com/u/57267960?v=4; +keywords: +- 开源 +- Apache APISIX +- 社区 +- 人物故事 +description: 本文将从 Shivam Singh（@1502shivam-singh）个人角度，简要描述了他是如何在 Apache APISIX 社区中从贡献者成长为 Apache Committer。希望他的个人参与历程可以帮助到那些希望在 Apache APISIX 社区或其他开源社区进行项目贡献的朋友。 +tags: [Community] +--- + +> 本文将从 Shivam Singh（[@1502shivam-singh](https://github.com/1502shivam-singh)）个人角度，简要描述了他是如何在 Apache APISIX 社区中从贡献者成长为 Apache Committer。希望他的个人参与历程可以帮助到那些希望在 Apache APISIX 社区或其他开源社区进行项目贡献的朋友。 + + + +我是 [Shivam Singh](https://twitter.com/Shivam15_)，Indian Institute of Information Technology 本科生，目前也是一名全栈工程师和产品设计师。我认为每一个伟大的产品都是工程和设计的结晶，产品的呈现不仅需要融合技术，同时也要带来视觉上的愉悦，最终在结果导向下解决终端用户的各种关键问题。 + +我个人非常喜欢「创作之路」的历程。比如独立开发一个产品或应用，从最初的概念化开始，到产品最终完成和交付，我可以非常享受地完成这中间涵盖的所有工程与设计细节。 + +也正是对于细节与创作的关注，才有了现在与开源社区和 Apache APISIX 的碰撞。 + +## 与 Apache APISIX 的美好回忆 + +自从开始参与 Apache APISIX 项目，我在社区里结识了很多友好且乐于沟通协作的伙伴们，或许大家都来自不同的国家，但这种「技术社区协作」却给我留下了一段非常美好的开源旅程回忆。 + +我觉得参与 Apache APISIX 社区对于想要接触开源项目和开源文化的朋友而言，都是一个不可多得的体验起点。 + +### 相识 + +这一切的开始要从 2021 年 2 月说起。那时的我为了将自己所学知识真正地发挥出来，想要给人们提供一些真正有价值的东西，所以开始在 GitHub 上寻找可以参与贡献的开源软件项目。 + +大家如果跟我一样也想搜寻一些适合自己的可贡献开源项目，可以查看一下 [Google Summer of Code](https://summerofcode.withgoogle.com/archive/) 组织页面或者搜索一些带有「good first issue」的简易项目 issue 进行相关的贡献。 + +在四处寻找和测试了几个项目后，我遇到了 Apache APISIX。在查阅了项目的任务 JIRA 面板后，与社区相关人员取得了联系并收到了加入社区 Slack 的邀请，之后的故事就顺理成章地开始了。 + +### 相知 + +考虑到个人的专业领域，我选择了 [apache/apisix-website](https://github.com/apache/apisix-website) 这个项目下的 issue 开始真正步入「开源旅程」。 + +当我开始接手尝试去做 Apache APISIX 官网页面时，我注意到这个项目在很多方面都有所欠缺，尤其是当时的官网页面所展示的功能与 Apache APISIX 真正所能提供的细节上存在很大的差距。一个产品有多好，不能只是产品本身做得好就够了，也需要通过一些途径向外界展示出来「到底有多好」。 + +针对这个问题我提出了相关意见，与社区伙伴们探讨后，刚好借由 Google Summer of Code 开始了针对 Apache APISIX 官网页面的改造。该项目从今年 5 月开始，2021 年 9 月新版官网成功上线。感谢参与这个项目中来自 Apache APISIX 社区多位 Committer 成员（[温铭](https://github.com/moonming)、[琚致远](https://github.com/juzhiyuan)和[吴舒旸](https://github.com/Yiyiyimu)）的帮助。 Review comment: NVM, my bad. ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/11/26/apache-apisix-committer-experience.md ## @@ -0,0 +1,61 @@ +--- +title: "成为 Apache APISIX Committer 让我体会到了知识转换价值的意义" +author: "Shivam Singh" +authorURL: "https://github.com/1502shivam-singh; +authorImageURL: "https://avatars.githubusercontent.com/u/57267960?v=4; +keywords: +- 开源 +- Apache APISIX +- 社区 +- 人物故事 +description: 本文将从 Shivam Singh（@1502shivam-singh）个人角度，简要描述了他是如何在 Apache APISIX 社区中从贡献者成长为 Apache Committer。希望他的个人参与历程可以帮助到那些希望在 Apache APISIX 社区或其他开源社区进行项目贡献的朋友。 +tags: [Community] +--- + +> 本文将从 Shivam Singh（[@1502shivam-singh](https://github.com/1502shivam-singh)）个人角度，简要描述了他是如何在 Apache APISIX 社区中从贡献者成长为 Apache Committer。希望他的个人参与历程可以帮助到那些希望在 Apache APISIX 社区或其他开源社区进行项目贡献的朋友。 + + + +我是 [Shivam Singh](https://twitter.com/Shivam15_)，Indian Institute of Information Technology 本科生，目前也是一名全栈工程师和产品设计师。我认为每一个伟大的产品都是工程和设计的结晶，产品的呈现不仅需要融合技术，同时也要带来视觉上的愉悦，最终在结果导向下解决终端用户的各种关键问题。 + +我个人非常喜欢「创作之路」的历程。比如独立开发一个产品或应用，从最初的概念化开始，到产品最终完成和交付，我可以非常享受地完成这中间涵盖的所有工程与设计细节。 + +也正是对于细节与创作的关注，才有了现在与开源社区和 Apache APISIX 的碰撞。 + +## 与 Apache APISIX 的美好回忆 + +自从开始参与 Apache APISIX 项目，我在社区里结识了很多友好且乐于沟通协作的伙伴们，或许大家都来自不同的国家，但这种「技术社区协作」却给我留下了一段非常美好的开源旅程回忆。 + +我觉得参与 Apache APISIX 社区对于想要接触开源项目和开源文化的朋友而言，都是一个不可多得的体验起点。 + +### 相识 + +这一切的开始要从 2021 年 2 月说起。那时的我为了将自己所学知识真正地发挥出来，想要给人们提供一些真正有价值的东西，所以开始在 GitHub 上寻找可以参与贡献的开源软件项目。 + +大家如果跟我一样也想搜寻一些适合自己的可贡献开源项目，可以查看一下 [Google Summer of Code](https://summerofcode.withgoogle.com/archive/) 组织页面或者搜索一些带有「good first issue」的简易项目 issue 进行相关的贡献。 + +在四处寻找和测试了几个项目后，我遇到了 Apache APISIX。在查阅了项目的任务 JIRA 面板后，与社区相关人员取得了联系并收到了加入社区 Slack 的邀请，之后的故事就顺理成章地开始了。 + +### 相知 + +考虑到个人的专业领域，我选择了 [apache/apisix-website](https://github.com/apache/apisix-website) 这个项目下的 issue 开始真正步入「开源旅程」。 + +当我开始接手尝试去做 Apache APISIX 官网页面时，我注意到这个项目在很多方面都有所欠缺，尤其是当时的官网页面所展示的功能与 Apache APISIX 真正所能提供的细节上存在很大的差距。一个产品有多好，不能只是产品本身做得好就够了，也需要通过一些途径向外界展示出来「到底有多好」。 + +针对这个问题我提出了相关意见，与社区伙伴们探讨后，刚好借由 Google Summer of Code 开始了针对 Apache APISIX 官网页面的改造。该项目从今年 5 月开始，2021 年 9 月新版官网成功上线。感谢参与这个项目中来自 Apache APISIX 社区多位 Committer 成员（[温铭](https://github.com/moonming)、[琚致远](https://github.com/juzhiyuan)和[吴舒旸](https://github.com/Yiyiyimu)）的帮助。 Review comment: Remove extra "）" ```suggestion 针对这个问题我提出了相关意见，与社区伙伴们探讨后，刚好借由 Google Summer of Code 开始了针对 Apache APISIX 官网页面的改造。该项目从今年 5 月开始，2021 年 9 月新版官网成功上线。感谢参与这个项目中来自 Apache APISIX 社区多位 Committer 成员（[温铭](https://github.com/moonming)、[琚致远](https://github.com/juzhiyuan)和[吴舒旸](https://github.com/Yiyiyimu)的帮助。 ``` -- This is an automated message from the Apache Git
[GitHub] [apisix] spacewander closed issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
spacewander closed issue #5417: URL: https://github.com/apache/apisix/issues/5417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5682: fix(patch): add global `math.randomseed` patch support
spacewander merged pull request #5682: URL: https://github.com/apache/apisix/pull/5682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix(patch): add global `math.randomseed` patch support (#5682)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new b85ebd4 fix(patch): add global `math.randomseed` patch support (#5682)
b85ebd4 is described below
commit b85ebd4e1cc1a41f7799f6458d421d56169e5e05
Author: leslie <59061168+leslie-ts...@users.noreply.github.com>
AuthorDate: Tue Dec 7 17:22:07 2021 +0800
fix(patch): add global `math.randomseed` patch support (#5682)
Co-authored-by: 罗泽轩
---
apisix/patch.lua | 47 +++
1 file changed, 47 insertions(+)
diff --git a/apisix/patch.lua b/apisix/patch.lua
index 51cb14b..69506e6 100644
--- a/apisix/patch.lua
+++ b/apisix/patch.lua
@@ -20,18 +20,23 @@ local ipmatcher = require("resty.ipmatcher")
local socket = require("socket")
local unix_socket = require("socket.unix")
local ssl = require("ssl")
+local ngx = ngx
local get_phase = ngx.get_phase
local ngx_socket = ngx.socket
local original_tcp = ngx.socket.tcp
local original_udp = ngx.socket.udp
local concat_tab = table.concat
+local debug = debug
local new_tab = require("table.new")
local log = ngx.log
local WARN = ngx.WARN
local ipairs = ipairs
local select = select
local setmetatable = setmetatable
+local string = string
+local table = table
local type = type
+local tonumber = tonumber
local config_local
@@ -86,6 +91,48 @@ do
end
+do -- `math.randomseed` patch
+-- `math.random` generates PRND(pseudo-random numbers) from the seed set
by `math.randomseed`
+-- Many module libraries use `ngx.time` and `ngx.worker.pid` to generate
seeds which may
+-- loss randomness in container env (where pids are identical, e.g. root
pid is 1)
+-- Kubernetes may launch multi instance with deployment RS at the same
time, `ngx.time` may
+-- get same return in the pods.
+-- Therefore, this global patch enforce entire framework to use
+-- the best-practice PRND generates.
+
+local resty_random = require("resty.random")
+local math_randomseed = math.randomseed
+local seeded = {}
+
+-- make linter happy
+-- luacheck: ignore
+math.randomseed = function()
+local worker_pid = ngx.worker.pid()
+
+-- check seed mark
+if seeded[worker_pid] then
+log(ngx.DEBUG, debug.traceback("Random seed has been inited", 2))
+return
+end
+
+-- generate randomseed
+-- chose 6 from APISIX's SIX, 256 ^ 6 should do the trick
+-- it shouldn't be large than 16 to prevent overflow.
+local random_bytes = resty_random.bytes(6)
+local t = {}
+
+for i = 1, #random_bytes do
+t[i] = string.byte(random_bytes, i)
+end
+
+local s = table.concat(t)
+
+math_randomseed(tonumber(s))
+seeded[worker_pid] = true
+end
+end -- do
+
+
local patch_udp_socket
do
local old_udp_sock_setpeername
[GitHub] [apisix] juzhiyuan commented on pull request #5718: docs: refactor Installation Guide
juzhiyuan commented on pull request #5718: URL: https://github.com/apache/apisix/pull/5718#issuecomment-987723380 > docs: refactor Installation Guide Hi @tzssangglass, I'm confused by this file Because this file's title is `How to build Apache APISIX`, it's more like used in a Development environment (including the Make Test part). We have feedbacks that it seems that we mixed the Installation Guide with Developer Guides, when users want to install and use Apache APISIX, they only need to follow Step 1 ~ Step 3, right? And they could continue reading AdminAPI docs Note: This comment is not related to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5708: request help: go-plugin-runner error after starting in debug mode
spacewander commented on issue #5708: URL: https://github.com/apache/apisix/issues/5708#issuecomment-987721607 Can't reproduce on my side. My configuration is: ``` ext-plugin: path_for_test: /tmp/runner.sock #cmd: ["/home/lzx/git/apisix-go-plugin-runner/go-runner", "run", "-m", "prod"] ``` I got the expected error: "phase_func(): failed to connect to the unix socket unix:/tmp/runner.sock". Maybe you can add more log to https://github.com/apache/apisix/blob/a4b6931390c302724675f9026078d479c6295119/apisix/plugins/ext-plugin/helper.lua#L32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
shuaijinchao commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763780260
##
File path: apisix/plugins/log-rotate.lua
##
@@ -194,18 +231,33 @@ local function rotate()
core.log.info("rotate interval:", interval)
core.log.info("rotate max keep:", max_kept)
-local time = ngx.time()
-if time % interval == 0 then
-time = time - interval
-else
-time = time - time % interval
+if not default_logs then
+-- first init default log filepath and filename
+default_logs = {}
+init_default_logs(default_logs, DEFAULT_ACCESS_LOG_FILENAME)
+init_default_logs(default_logs, DEFAULT_ERROR_LOG_FILENAME)
end
-local date_str = os.date("%Y-%m-%d_%H-%M-%S", time)
+local now_time = ngx_time()
+if not rotate_time then
+-- first init rotate time
+rotate_time = now_time + interval
+core.log.info("first init rotate time is: ", rotate_time)
+return
+end
+
+if now_time < rotate_time then
+-- did not reach the rotate time
+core.log.info("rotate time: ", rotate_time, " now time: ", now_time)
+return
+end
-local ok1 = rotate_file(date_str, "access.log")
-local ok2 = rotate_file(date_str, "error.log")
-if not ok1 and not ok2 then
+local now_date = os_date("%Y-%m-%dT%H-%M-%S", now_time)
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
shuaijinchao commented on a change in pull request #5715:
URL: https://github.com/apache/apisix/pull/5715#discussion_r763780260
##
File path: apisix/plugins/log-rotate.lua
##
@@ -194,18 +231,33 @@ local function rotate()
core.log.info("rotate interval:", interval)
core.log.info("rotate max keep:", max_kept)
-local time = ngx.time()
-if time % interval == 0 then
-time = time - interval
-else
-time = time - time % interval
+if not default_logs then
+-- first init default log filepath and filename
+default_logs = {}
+init_default_logs(default_logs, DEFAULT_ACCESS_LOG_FILENAME)
+init_default_logs(default_logs, DEFAULT_ERROR_LOG_FILENAME)
end
-local date_str = os.date("%Y-%m-%d_%H-%M-%S", time)
+local now_time = ngx_time()
+if not rotate_time then
+-- first init rotate time
+rotate_time = now_time + interval
+core.log.info("first init rotate time is: ", rotate_time)
+return
+end
+
+if now_time < rotate_time then
+-- did not reach the rotate time
+core.log.info("rotate time: ", rotate_time, " now time: ", now_time)
+return
+end
-local ok1 = rotate_file(date_str, "access.log")
-local ok2 = rotate_file(date_str, "error.log")
-if not ok1 and not ok2 then
+local now_date = os_date("%Y-%m-%dT%H-%M-%S", now_time)
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (7bd5a52) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix-ingress-controller] lxm edited a comment on pull request #779: feat: support regex in path
lxm edited a comment on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987688535 > re-run all jobs. E2E tests failed with "check the ingress lb status is updated" this time, maybe something wrong with test cases. I can pass this case with single run in a private environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987688535 > re-run all jobs. E2E tests failed with "check the ingress lb status is updated" this time, maybe something wrong with test cases. I can pass this case singly in a private environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on a change in pull request #796: docs: add Shivam committer Chinese version blog
yzeng25 commented on a change in pull request #796: URL: https://github.com/apache/apisix-website/pull/796#discussion_r763743951 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/11/26/apache-apisix-committer-experience.md ## @@ -0,0 +1,61 @@ +--- +title: "成为 Apache APISIX Committer 让我体会到了知识转换价值的意义" +author: "Shivam Singh" +authorURL: "https://github.com/1502shivam-singh; +authorImageURL: "https://avatars.githubusercontent.com/u/57267960?v=4; +keywords: +- 开源 +- Apache APISIX +- 社区 +- 人物故事 +description: 本文将从 Shivam Singh（@1502shivam-singh）个人角度，简要描述了他是如何在 Apache APISIX 社区中从贡献者成长为 Apache Committer。希望他的个人参与历程可以帮助到那些希望在 Apache APISIX 社区或其他开源社区进行项目贡献的朋友。 +tags: [Community] +--- + +> 本文将从 Shivam Singh（[@1502shivam-singh](https://github.com/1502shivam-singh)）个人角度，简要描述了他是如何在 Apache APISIX 社区中从贡献者成长为 Apache Committer。希望他的个人参与历程可以帮助到那些希望在 Apache APISIX 社区或其他开源社区进行项目贡献的朋友。 + + + +我是 [Shivam Singh](https://twitter.com/Shivam15_)，Indian Institute of Information Technology 本科生，目前也是一名全栈工程师和产品设计师。我认为每一个伟大的产品都是工程和设计的结晶，产品的呈现不仅需要融合技术，同时也要带来视觉上的愉悦，最终在结果导向下解决终端用户的各种关键问题。 + +我个人非常喜欢「创作之路」的历程。比如独立开发一个产品或应用，从最初的概念化开始，到产品最终完成和交付，我可以非常享受地完成这中间涵盖的所有工程与设计细节。 + +也正是对于细节与创作的关注，才有了现在与开源社区和 Apache APISIX 的碰撞。 + +## 与 Apache APISIX 的美好回忆 + +自从开始参与 Apache APISIX 项目，我在社区里结识了很多友好且乐于沟通协作的伙伴们，或许大家都来自不同的国家，但这种「技术社区协作」却给我留下了一段非常美好的开源旅程回忆。 + +我觉得参与 Apache APISIX 社区对于想要接触开源项目和开源文化的朋友而言，都是一个不可多得的体验起点。 + +### 相识 + +这一切的开始要从 2021 年 2 月说起。那时的我为了将自己所学知识真正地发挥出来，想要给人们提供一些真正有价值的东西，所以开始在 GitHub 上寻找可以参与贡献的开源软件项目。 + +大家如果跟我一样也想搜寻一些适合自己的可贡献开源项目，可以查看一下 [Google Summer of Code](https://summerofcode.withgoogle.com/archive/) 组织页面或者搜索一些带有「good first issue」的简易项目 issue 进行相关的贡献。 + +在四处寻找和测试了几个项目后，我遇到了 Apache APISIX。在查阅了项目的任务 JIRA 面板后，与社区相关人员取得了联系并收到了加入社区 Slack 的邀请，之后的故事就顺理成章地开始了。 + +### 相知 + +考虑到个人的专业领域，我选择了 [apache/apisix-website](https://github.com/apache/apisix-website) 这个项目下的 issue 开始真正步入「开源旅程」。 + +当我开始接手尝试去做 Apache APISIX 官网页面时，我注意到这个项目在很多方面都有所欠缺，尤其是当时的官网页面所展示的功能与 Apache APISIX 真正所能提供的细节上存在很大的差距。一个产品有多好，不能只是产品本身做得好就够了，也需要通过一些途径向外界展示出来「到底有多好」。 + +针对这个问题我提出了相关意见，与社区伙伴们探讨后，刚好借由 Google Summer of Code 开始了针对 Apache APISIX 官网页面的改造。该项目从今年 5 月开始，2021 年 9 月新版官网成功上线。感谢参与这个项目中来自 Apache APISIX 社区多位 Committer 成员（[温铭](https://github.com/moonming)、[琚致远](https://github.com/juzhiyuan)和[吴舒旸](https://github.com/Yiyiyimu)）的帮助。 Review comment: Remove extra "）" ```suggestion 针对这个问题我提出了相关意见，与社区伙伴们探讨后，刚好借由 Google Summer of Code 开始了针对 Apache APISIX 官网页面的改造。该项目从今年 5 月开始，2021 年 9 月新版官网成功上线。感谢参与这个项目中来自 Apache APISIX 社区多位 Committer 成员（[温铭](https://github.com/moonming)、[琚致远](https://github.com/juzhiyuan)和[吴舒旸](https://github.com/Yiyiyimu)的帮助。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #698: Update SkyWalking plugin's docs
juzhiyuan commented on issue #698: URL: https://github.com/apache/apisix-website/issues/698#issuecomment-987673394 > the master branch is correct You're right, and let's lead users to use the Latest branch by default I will close this issue soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed issue #698: Update SkyWalking plugin's docs
juzhiyuan closed issue #698: URL: https://github.com/apache/apisix-website/issues/698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0f4ca10) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **increase** coverage by `0.82%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == + Coverage 69.87% 70.70% +0.82% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2761-2322 + Misses 1897 851-1046 + Partials 294 293 -1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.38% <ø> (-4.15%)` | :arrow_down: | | backend-e2e-test-ginkgo | `56.33% <ø> (+4.73%)` | :arrow_up: | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `44.68% <0.00%> (-17.03%)` | :arrow_down: | | [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | `62.50% <0.00%> (-15.63%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `44.88% <0.00%> (-6.30%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.02% <0.00%> (-2.61%)` | :arrow_down: | | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | | | | [...nents/Upstream/components/ServiceDiscoveryArgs.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvU2VydmljZURpc2NvdmVyeUFyZ3MudHN4) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0f4ca10) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `7.90%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2200 +/- ## == - Coverage 69.87% 61.97% -7.91% == Files 184 57 -127 Lines7274 3905-3369 Branches 8290 -829 == - Hits 5083 2420-2663 + Misses 1897 1204 -693 + Partials 294 281 -13 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.38% <ø> (-4.15%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: | | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-76.20%)` | :arrow_down: | | [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `0.00% <0.00%> (-53.04%)` | :arrow_down: | | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `8.06% <0.00%> (-51.62%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `23.00% <0.00%> (-44.25%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | |
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5718: docs: refactor Installation Guide
juzhiyuan commented on a change in pull request #5718: URL: https://github.com/apache/apisix/pull/5718#discussion_r763727963 ## File path: docs/en/latest/how-to-build.md ## @@ -21,22 +21,29 @@ title: How to build Apache APISIX # --> -## Step 1: Install dependencies +## Step 1: Install Apache APISIX -The Apache APISIX runtime environment requires dependencies on NGINX and etcd. +You can install Apache APISIX via RPM Repository, RPM package, Docker, Helm Chart, and source release package. Please choose one from the following options. -Before installing Apache APISIX, please install dependencies according to the operating system you are using. We provide the dependencies installation instructions for **CentOS7**, **Fedora 31 & 32**, **Ubuntu 16.04 & 18.04**, **Debian 9 & 10**, and **MacOS**, please refer to [Install Dependencies](install-dependencies.md) for more details. +### Installation via RPM Repository(CentOS 7) -## Step 2: Install Apache APISIX +This installation method is suitable for CentOS 7. -You can install Apache APISIX via RPM Repository, RPM package, Docker, Helm Chart, and source release package. Please choose one from the following options. +If the official OpenResty repository is not installed yet, the following command will help you automatically install both the repositories of OpenResty and Apache APISIX. -### Installation via RPM Repository(CentOS 7) +```shell +sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +``` -This installation method is suitable for CentOS 7. For now, the Apache APISIX RPM repository for CentOS 7 is already supported. Please run the following commands to install the repository and Apache APISIX. +If the official OpenResty repository is installed, the following command will help you automatically install both the repositories of Apache APISIX. Review comment: > install both the repositories of Apache APISIX. Both...and... ## File path: docs/zh/latest/how-to-build.md ## @@ -94,6 +95,23 @@ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-rep make install ``` +## 步骤2：安装 ETCD + +通过 RPM 或者 Docker 安装 Apache APISIX 时，需要执行此步骤。 + +你可以通过 Docker 或者二进制等方式安装 ETCD。以下命令通过二进制方式安装 ETCD。 + +```shell +ETCD_VERSION='3.4.13' Review comment: Maybe add a `$` prefix is clearer in the multiple lines -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0f4ca10) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #788: fix: ingress LB status records
codecov-commenter commented on pull request #788: URL: https://github.com/apache/apisix-ingress-controller/pull/788#issuecomment-987664591 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#788](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2032d88) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1bbadf0d8e6aefeb11e55ab0d7230547d3c06135?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1bbadf0) will **decrease** coverage by `0.30%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #788 +/- ## == - Coverage 32.42% 32.11% -0.31% == Files 65 65 Lines6872 6875 +3 == - Hits 2228 2208 -20 - Misses 4396 4412 +16 - Partials 248 255 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.02% <0.00%> (-3.31%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [1bbadf0...2032d88](https://codecov.io/gh/apache/apisix-ingress-controller/pull/788?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
