[GitHub] [apisix-docker] vcqr commented on issue #227: 2379: bind: address already in use
vcqr commented on issue #227: URL: https://github.com/apache/apisix-docker/issues/227#issuecomment-995528924 > > @biubiue do you still have this issue? > > I has resolved this problem , by stop my local k8s 这样是正解 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 commented on pull request #254: feat: bump APISIX Dashboard 2.10
bzp2010 commented on pull request #254: URL: https://github.com/apache/apisix-docker/pull/254#issuecomment-995530108 Hi, @nic-chen. PTAL, however, it should be noted that these modifications cannot be tested by CI, and CI can only be triggered by `push`, so please look at the modifications carefully. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5708: request help: go-plugin-runner error after starting in debug mode
juzhiyuan commented on issue #5708: URL: https://github.com/apache/apisix/issues/5708#issuecomment-995538311 > Bro, I also met the general problem, can you tell me how to solve it? Hi, please create a new issue and attach the detailed reproduction steps, so we could help you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0
juzhiyuan commented on issue #2246: URL: https://github.com/apache/apisix-dashboard/issues/2246#issuecomment-995540467 > so can i move the swagger json path summary as operationId? Actually, I'm not very sure about this, may need @nic-chen's help to have a check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2237: test(balancer): migrate balancer test to ginkgo implement
juzhiyuan merged pull request #2237: URL: https://github.com/apache/apisix-dashboard/pull/2237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2095: Feature request: support appending query string in redirect plugin
juzhiyuan commented on issue #2095: URL: https://github.com/apache/apisix-dashboard/issues/2095#issuecomment-995541322 @zaunist could you help to check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (4ee0021 -> 0b1abaf)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 4ee0021 feat: use apisix-build-tools master branch (#2249)
add 0b1abaf test(balancer): migrate balancer test to ginkgo implement
(#2237)
No new revisions were added by this update.
Summary of changes:
api/test/e2e/balancer_test.go | 221 -
.../balancer_suite_test.go}| 8 +-
api/test/e2enew/balancer/balancer_test.go | 212
api/test/e2enew/base/http.go | 9 +-
api/test/e2enew/go.sum | 2 +
.../e2enew/route/route_service_upstream_test.go| 6 +-
api/test/e2enew/service/service_test.go| 2 +-
7 files changed, 228 insertions(+), 232 deletions(-)
delete mode 100644 api/test/e2e/balancer_test.go
copy api/test/e2enew/{plugin_config/plugin_config_suite_test.go =>
balancer/balancer_suite_test.go} (87%)
create mode 100644 api/test/e2enew/balancer/balancer_test.go
[GitHub] [apisix-dashboard] zaunist commented on issue #2095: Feature request: support appending query string in redirect plugin
zaunist commented on issue #2095: URL: https://github.com/apache/apisix-dashboard/issues/2095#issuecomment-995549545 > @zaunist could you help to check this? A great pleasure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tao12345666333 commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
tao12345666333 commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-995552921 I am not familiar with the operating mechanism of luarocks. :face_exhaling: Is there any explanation or release note for this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 edited a comment on pull request #254: feat: bump APISIX Dashboard to 2.10
bzp2010 edited a comment on pull request #254: URL: https://github.com/apache/apisix-docker/pull/254#issuecomment-995530108 Hi, all. PTAL, however, it should be noted that these modifications cannot be tested by CI, and CI can only be triggered by `push`, so please look at the modifications carefully. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5727: feat: add CSRF plugin
leslie-tsang commented on a change in pull request #5727:
URL: https://github.com/apache/apisix/pull/5727#discussion_r770335616
##
File path: apisix/plugins/csrf.lua
##
@@ -0,0 +1,169 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local ngx = ngx
+local plugin_name = "csrf"
+local ngx_encode_base64 = ngx.encode_base64
+local ngx_decode_base64 = ngx.decode_base64
+local request_method = ngx.var.request_method
+local timer = ngx.time
+local cookie_time = ngx.cookie_time
+local ck = require "resty.cookie"
+local math = math
+
+local schema = {
+type = "object",
+properties = {
+ key = {
Review comment:
Got it. Thanks for reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #5727: feat: add CSRF plugin
leslie-tsang commented on pull request #5727: URL: https://github.com/apache/apisix/pull/5727#issuecomment-995569788 > Would you please take a look when you have time? Thanks. Hello there, Would you mind to pass the CI test first ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5830: docs: Fix typo in documentation
spacewander merged pull request #5830: URL: https://github.com/apache/apisix/pull/5830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
spacewander commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-995572479 Luarocks automatically handles the URL conversion in this commit: https://github.com/luarocks/luarocks/commit/9ff512e35455939f02eaec2318e3acc77782fdeb, which is included in v3.8.0. So there is no need to handle this by ourselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (de65fc4 -> a68a03c)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from de65fc4 fix(mqtt-proxy): client id can be empty (#5816) add a68a03c docs: Fix typo in documentation (#5830) No new revisions were added by this update. Summary of changes: docs/en/latest/plugins/api-breaker.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [apisix] spacewander commented on pull request #5829: docs: add offline install to 'how-to-build.md'
spacewander commented on pull request #5829: URL: https://github.com/apache/apisix/pull/5829#issuecomment-995573256 @leslie-tsang Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 123liubao commented on pull request #5829: docs: add offline install to 'how-to-build.md'
123liubao commented on pull request #5829: URL: https://github.com/apache/apisix/pull/5829#issuecomment-995574556 > Contents LGTM, just to make sure, the `./apisix` folder is created from where? @juzhiyuan I'm not sure what do you mean , `sudo mkdir -p apisix` this step is to create the folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5820: fix(sls-logger): log entry unable get millisecond timestamp
spacewander commented on a change in pull request #5820:
URL: https://github.com/apache/apisix/pull/5820#discussion_r770344198
##
File path: t/plugin/sls-logger.t
##
@@ -188,9 +184,41 @@ hello world
ngx.say(data)
}
}
request
-GET /t
--- response_body
123
no_error_log
-[error]
+
+
+
+=== TEST 7: sls log get milliseconds
+--- config
+location /t {
+content_by_lua_block {
+local function get_syslog_timestamp_millisecond(log_entry)
+local first_idx = string.find(log_entry, " ") + 1
+local last_idx2 = string.find(log_entry, " ", first_idx)
+local rfc3339_date = string.sub(log_entry, first_idx,
last_idx2)
+local rfc3339_len = string.len(rfc3339_date)
+local rfc3339_millisecond = string.sub(rfc3339_date,
rfc3339_len - 4, rfc3339_len - 2)
+return tonumber(rfc3339_millisecond)
+end
+
+math.randomseed(os.time())
+local rfc5424 = require("apisix.plugins.slslog.rfc5424")
+local m = 0
+for i = 1, 5 do
+ngx.sleep(string.format("%0.3f", math.random()))
Review comment:
Let's add this explanation as a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #5829: docs: add offline install to 'how-to-build.md'
leslie-tsang commented on pull request #5829: URL: https://github.com/apache/apisix/pull/5829#issuecomment-995577091 > Contents LGTM, just to make sure, the `./apisix` folder is created from where? folder `./apisix` create by CMD `sudo mkdir -p apisix`, user can replace it with any other folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy
spacewander commented on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-995579251 I tried `mosquitto_pub -t test -m "Hello" -h 127.0.0.1 -p 9100` & `mosquitto_sub -t test -v`, and it worked well with me. Maybe you can provide the detailed commands & configuration so we can reproduce it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5820: fix(sls-logger): log entry unable get millisecond timestamp
shuaijinchao commented on a change in pull request #5820:
URL: https://github.com/apache/apisix/pull/5820#discussion_r770352424
##
File path: t/plugin/sls-logger.t
##
@@ -188,9 +184,41 @@ hello world
ngx.say(data)
}
}
request
-GET /t
--- response_body
123
no_error_log
-[error]
+
+
+
+=== TEST 7: sls log get milliseconds
+--- config
+location /t {
+content_by_lua_block {
+local function get_syslog_timestamp_millisecond(log_entry)
+local first_idx = string.find(log_entry, " ") + 1
+local last_idx2 = string.find(log_entry, " ", first_idx)
+local rfc3339_date = string.sub(log_entry, first_idx,
last_idx2)
+local rfc3339_len = string.len(rfc3339_date)
+local rfc3339_millisecond = string.sub(rfc3339_date,
rfc3339_len - 4, rfc3339_len - 2)
+return tonumber(rfc3339_millisecond)
+end
+
+math.randomseed(os.time())
+local rfc5424 = require("apisix.plugins.slslog.rfc5424")
+local m = 0
+for i = 1, 5 do
+ngx.sleep(string.format("%0.3f", math.random()))
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] xuminwlt commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
xuminwlt commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-995587417 It is not the problem of M1, but also the permissions of MAC system to system path.see "macos sip". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'
leslie-tsang commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r770354967 ## File path: docs/zh/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### 通过 RPM 包离线安装（CentOS 7） + +下载 APISIX 离线 RPM 包到 `./apisix` 文件夹 + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix Review comment: Ditto ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Installation via RPM Offline Package(CentOS 7) + +Download APISIX offline RPM package to `./apisix` folder + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix +``` + +Copy `./apisix` folder to the target host, run the following command to install Apache APISIX. + +```shell +$ yum install ./apisix/*.rpm Review comment: Shall we add a `sudo` here ? ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Installation via RPM Offline Package(CentOS 7) + +Download APISIX offline RPM package to `./apisix` folder + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix Review comment: ```suggestion # Create a folder `apisix` to store the RPM packages sudo mkdir -p apisix # Install apisix repo sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm # Rebuild YUM cache sudo yum clean all && yum makecache # Download apisix and its deps package to the `apisx` folder sudo yum install -y --downloadonly --downloaddir=./apisix apisix ``` Shall we remove `$` ? @juzhiyuan IMO, `$` is used to distinguish between `command` and its `output` like ```bash $ uptime 17:24:16 up 3 days, 8:06, 1 user, load average: 0.00, 0.01, 0.05 ``` ## File path: docs/zh/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### 通过 RPM 包离线安装（CentOS 7） + +下载 APISIX 离线 RPM 包到 `./apisix` 文件夹 + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix +``` + +拷贝 `./apisix` 文件夹到目标主机，使用以下命令安装 Apache APISIX。 + +```shell +$ yum install ./apisix/*.rpm Review comment: Ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Josh-Cena commented on a change in pull request #5823: docs: remove the redundant space between Chinese characters
Josh-Cena commented on a change in pull request #5823: URL: https://github.com/apache/apisix/pull/5823#discussion_r770361686 ## File path: docs/zh/latest/architecture-design/plugin.md ## @@ -26,8 +26,8 @@ title: Plugin `Plugin` 配置可直接绑定在 `Route` 上，也可以被绑定在 `Service` 或 `Consumer`上。而对于同一 个插件的配置，只能有一份是有效的，配置选择优先级总是 `Consumer` > `Route` > `Service`。 -在 `conf/config.yaml` 中，可以声明本地 APISIX 节点都支持哪些插件。这是个白名单机制，不在该 -白名单的插件配置，都将会被自动忽略。这个特性可用于临时关闭或打开特定插件，应对突发情况非常有效。 +在 `conf/config.yaml` 中，可以声明本地 APISIX 节点都支持哪些插件。这是个白名单机制，不在该白名单的插件配置， Review comment: > If we use 2 spaces and line breaking, it will be rendered in 2 lines. It's actually part of the Markdown spec that two trailing spaces => `` tag and two line breaks => begin a new paragraph. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 123liubao commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'
123liubao commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r770372456 ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Installation via RPM Offline Package(CentOS 7) + +Download APISIX offline RPM package to `./apisix` folder + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix +``` + +Copy `./apisix` folder to the target host, run the following command to install Apache APISIX. + +```shell +$ yum install ./apisix/*.rpm Review comment: OK , I've already added this. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 123liubao commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'
123liubao commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r770372711 ## File path: docs/zh/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### 通过 RPM 包离线安装（CentOS 7） + +下载 APISIX 离线 RPM 包到 `./apisix` 文件夹 + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix +``` + +拷贝 `./apisix` 文件夹到目标主机，使用以下命令安装 Apache APISIX。 + +```shell +$ yum install ./apisix/*.rpm Review comment: OK , I've already added this. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5829: docs: add offline install to 'how-to-build.md'
juzhiyuan commented on pull request #5829: URL: https://github.com/apache/apisix/pull/5829#issuecomment-995612651 > > Contents LGTM, just to make sure, the `./apisix` folder is created from where? > > @juzhiyuan I'm not sure what do you mean , `sudo mkdir -p apisix` this step is to create the folder. Oh yes, I didn't notice this order 😅  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan commented on a change in pull request #5823: URL: https://github.com/apache/apisix/pull/5823#discussion_r770384060 ## File path: docs/zh/latest/architecture-design/plugin.md ## @@ -26,8 +26,8 @@ title: Plugin `Plugin` 配置可直接绑定在 `Route` 上，也可以被绑定在 `Service` 或 `Consumer`上。而对于同一 个插件的配置，只能有一份是有效的，配置选择优先级总是 `Consumer` > `Route` > `Service`。 -在 `conf/config.yaml` 中，可以声明本地 APISIX 节点都支持哪些插件。这是个白名单机制，不在该 -白名单的插件配置，都将会被自动忽略。这个特性可用于临时关闭或打开特定插件，应对突发情况非常有效。 +在 `conf/config.yaml` 中，可以声明本地 APISIX 节点都支持哪些插件。这是个白名单机制，不在该白名单的插件配置， Review comment: 🙈🙈 How about closing this PR? cc @Nidaozi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
tokers commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-995615095 Not sure whether this is good for the user experience as it adds more constraints for the version of luarocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #3159: request help: when config one route,but post failed
github-actions[bot] commented on issue #3159: URL: https://github.com/apache/apisix/issues/3159#issuecomment-995620937 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #799: proposal: Add annotations to combine ApisixPluginConfig with k8s ingress resource
tokers commented on issue #799: URL: https://github.com/apache/apisix-ingress-controller/issues/799#issuecomment-995625284 @lxm Assigned! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
zaunist commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-995626061 Hi, @zjzwjcbj . It's recommend to develop on Linux. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #5796: bug: The traffic split plug-in runs and reports an error according to the official configuration
nic-chen commented on issue #5796:
URL: https://github.com/apache/apisix/issues/5796#issuecomment-995630190
hi @tzssangglass
Do you have time to help take a look? thanks!
The script generated by the dashboard looks like this:
```lua
local core = require("apisix.core")
local plugin = require("apisix.plugin")
local tablepool = core.tablepool
local _M = {}
_M.conf_e7dff882_6ea8_4c39_b167_2ef655e4de6e = core.json.decode(
[[{"disable":false,"rules":[{"match":[{"vars":[["arg_shop","==","aa"]]}],"weighted_upstreams":[{"upstream":{"name":"upstream_A","nodes":{"uat-open-app-ads.uat.svc.cluster.local:8080":10},"type":"roundrobin"}}]}]}]]
)
local traffic_split = plugin.get("traffic-split")
local function func_rule_e7dff882_6ea8_4c39_b167_2ef655e4de6e(ctx)
local phase_fun = traffic_split.access or traffic_split.rewrite
local plugins = ctx.script_plugins
local code, body = phase_fun(_M.conf_e7dff882_6ea8_4c39_b167_2ef655e4de6e,
ctx)
core.table.insert(plugins, "traffic-split")
core.table.insert(plugins, "conf_e7dff882_6ea8_4c39_b167_2ef655e4de6e")
return _M.func_rule_84700f3e_7edc_4552_892f_62d3e72483be(ctx)
end
_M.func_rule_e7dff882_6ea8_4c39_b167_2ef655e4de6e =
func_rule_e7dff882_6ea8_4c39_b167_2ef655e4de6e
_M.conf_84700f3e_7edc_4552_892f_62d3e72483be = core.json.decode(
[[{"disable":false,"regex_uri":["^/zendesk/(.*)","/$1"],"scheme":"http"}]]
)
local proxy_rewrite = plugin.get("proxy-rewrite")
local function func_rule_84700f3e_7edc_4552_892f_62d3e72483be(ctx)
local plugins = ctx.script_plugins
local phase_fun = proxy_rewrite.access or proxy_rewrite.rewrite
if phase_fun then
local code, body =
phase_fun(_M.conf_84700f3e_7edc_4552_892f_62d3e72483be, ctx)
if code or body then
core.response.exit(code, body)
end
end
core.table.insert(plugins, "proxy-rewrite")
core.table.insert(plugins, "conf_84700f3e_7edc_4552_892f_62d3e72483be")
return
end
_M.func_rule_84700f3e_7edc_4552_892f_62d3e72483be =
func_rule_84700f3e_7edc_4552_892f_62d3e72483be
_M.access = function(ctx)
ctx.script_plugins = {}
return func_rule_e7dff882_6ea8_4c39_b167_2ef655e4de6e(ctx)
end
_M.header_filter = function(ctx)
local plugins = ctx.script_plugins
for i = 1, #plugins, 2 do
local plugin_name = plugins[i]
local plugin_conf_name = plugins[i + 1]
local plugin_obj = plugin.get(plugin_name)
local phase_fun = plugin_obj.header_filter
if phase_fun then
phase_fun(_M[plugin_conf_name], ctx)
end
end
end
_M.body_filter = function(ctx)
local plugins = ctx.script_plugins
for i = 1, #plugins, 2 do
local plugin_name = plugins[i]
local plugin_conf_name = plugins[i + 1]
local plugin_obj = plugin.get(plugin_name)
local phase_fun = plugin_obj.body_filter
if phase_fun then
phase_fun(_M[plugin_conf_name], ctx)
end
end
end
_M.log = function(ctx)
local plugins = ctx.script_plugins
for i = 1, #plugins, 2 do
local plugin_name = plugins[i]
local plugin_conf_name = plugins[i + 1]
local plugin_obj = plugin.get(plugin_name)
local phase_fun = plugin_obj.log
if phase_fun then
phase_fun(_M[plugin_conf_name], ctx)
end
end
tablepool.release("script_plugins", ctx.script_plugins)
end
return _M
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] panhow commented on issue #3498: apisix access have 500 status code
panhow commented on issue #3498: URL: https://github.com/apache/apisix/issues/3498#issuecomment-995632845 > @panhow this issue is old. > > you can create a new issue with your reproduce steps(apisix version, os version, etc.) > > https://github.com/apache/apisix/issues/new?assignees=&labels=&template=bug_report.yml&title=bug%3A+ > > many thx. thx for replied, after i reproduce on latest apisix, i will create a new issue with reproduce steps. i tried on ``2.10`` this morning, but it didn't reproduce again, i dont known it has been fixed or not enough pressure for the server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] guoqqqi opened a new pull request #5831: feat: add `file-logger` plugin
guoqqqi opened a new pull request #5831: URL: https://github.com/apache/apisix/pull/5831 ### What this PR does / why we need it: 1. add file-logger plugin Related: Discuss on the [mailing list](https://mail.google.com/mail/u/0/?zx=ynbavjb165m7#inbox/QgrcJHsHnPNSqGvMKclFwpZBtkfXPgGBjTB) ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nimohunter commented on issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0
nimohunter commented on issue #2246: URL: https://github.com/apache/apisix-dashboard/issues/2246#issuecomment-995686769 > > so can i move the swagger json path summary as operationId? > > Actually, I'm not very sure about this, may need @nic-chen's help to have a check. thanks! and if we move swagger path summary as operationid, then we can import the swagger json generate by swaggo. Of course that we may miss some route's parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] webfrogs opened a new pull request #5832: doc: fix typo in reqeust-id plugin documents.
webfrogs opened a new pull request #5832: URL: https://github.com/apache/apisix/pull/5832 ### What this PR does / why we need it: fix typo in snowflake documents ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0
juzhiyuan commented on issue #2246: URL: https://github.com/apache/apisix-dashboard/issues/2246#issuecomment-995726005 > Of course that we may miss some route's parameter. And we could make sure all parameters that Apache APISIX needs are kept? 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5831: feat: add `file-logger` plugin
juzhiyuan commented on pull request #5831: URL: https://github.com/apache/apisix/pull/5831#issuecomment-995739305 Hi, maybe you'd better add a TODO checklist in this PR's description 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Nidaozi commented on a change in pull request #5823: docs: remove the redundant space between Chinese characters
Nidaozi commented on a change in pull request #5823: URL: https://github.com/apache/apisix/pull/5823#discussion_r770516115 ## File path: docs/zh/latest/architecture-design/plugin.md ## @@ -26,8 +26,8 @@ title: Plugin `Plugin` 配置可直接绑定在 `Route` 上，也可以被绑定在 `Service` 或 `Consumer`上。而对于同一 个插件的配置，只能有一份是有效的，配置选择优先级总是 `Consumer` > `Route` > `Service`。 -在 `conf/config.yaml` 中，可以声明本地 APISIX 节点都支持哪些插件。这是个白名单机制，不在该 -白名单的插件配置，都将会被自动忽略。这个特性可用于临时关闭或打开特定插件，应对突发情况非常有效。 +在 `conf/config.yaml` 中，可以声明本地 APISIX 节点都支持哪些插件。这是个白名单机制，不在该白名单的插件配置， Review comment: ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Nidaozi closed pull request #5823: docs: remove the redundant space between Chinese characters
Nidaozi closed pull request #5823: URL: https://github.com/apache/apisix/pull/5823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Josh-Cena commented on pull request #5823: docs: remove the redundant space between Chinese characters
Josh-Cena commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-995796155 Hold on, why close this? Are we going to come up with a better resolution or is this just wontfix? I honestly think this is a legitimate fix and we can just fix this everywhere if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] RagavMaddali commented on issue #65: java.lang.IllegalStateException: Failed to execute CommandLineRunner
RagavMaddali commented on issue #65: URL: https://github.com/apache/apisix-java-plugin-runner/issues/65#issuecomment-995804317 do we have a way to resolve the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] arabot777 commented on issue #65: java.lang.IllegalStateException: Failed to execute CommandLineRunner
arabot777 commented on issue #65: URL: https://github.com/apache/apisix-java-plugin-runner/issues/65#issuecomment-995818872 > 1. if you use mac m1, please import the aarch64 version of the netty-transport-native-kqueue package 2. in other cases, please check the permissions of the runner.sock file, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] RagavMaddali commented on issue #65: java.lang.IllegalStateException: Failed to execute CommandLineRunner
RagavMaddali commented on issue #65: URL: https://github.com/apache/apisix-java-plugin-runner/issues/65#issuecomment-995822594 > if you use mac m1, please import the aarch64 version of the netty-transport-native-kqueue package > in other cases, please check the permissions of the runner.sock file, On the run mode the file is created dynamically. I tried running the process with both sudo and as as root user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 commented on pull request #254: feat: bump APISIX Dashboard to 2.10
bzp2010 commented on pull request #254: URL: https://github.com/apache/apisix-docker/pull/254#issuecomment-995899930 Please don't merge for now ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 edited a comment on pull request #254: feat: bump APISIX Dashboard to 2.10
bzp2010 edited a comment on pull request #254: URL: https://github.com/apache/apisix-docker/pull/254#issuecomment-995899930 # Please don't merge for now, I can't get the local build test to pass correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lizhouyang opened a new issue #5834: request help: how to set redirect_uri, when i use openid-connect
lizhouyang opened a new issue #5834:
URL: https://github.com/apache/apisix/issues/5834
### Issue description
hello , i use
[spring-authorization-server](https://github.com/spring-projects/spring-authorization-server)
as a OpenID authorization server. It requires a redirect_uri to limit the
redirect . In apisix settings how to set it?
here is my settings:
`{
"name": "oauth",
"upstream_id": "386066599586562754",
"plugins": {
"openid-connect": {
"client_id": "login-client",
"client_secret": "{noop}openid-connect",
"disable": false,
"discovery":
"http://auth-server:/.well-known/openid-configuration";,
"redirect_uri": "http://lizhouyang.cn:9080/";
}
}
}`
### Environment
- apisix version (cmd: `apisix version`):
- OS (cmd: `uname -a`):
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5796: bug: The traffic split plug-in runs and reports an error according to the official configuration
tzssangglass commented on issue #5796:
URL: https://github.com/apache/apisix/issues/5796#issuecomment-995924387
> ```lua
>
[[{"disable":false,"rules":[{"match":[{"vars":[["arg_shop","==","aa"]]}],"weighted_upstreams":[{"upstream":{"name":"upstream_A","nodes":{"uat-open-app-ads.uat.svc.cluster.local:8080":10},"type":"roundrobin"}}]}]}]]
> ```
should be
```lua
[[{"disable":false,"rules":[{"match":[{"vars":[[["arg_shop","==","aa"]]]}],"weighted_upstreams":[{"upstream":{"name":"upstream_A","nodes":{"uat-open-app-ads.uat.svc.cluster.local:8080":10},"type":"roundrobin"}}]}]}]]
```
putting this code in IDEA quickly reveals the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass edited a comment on issue #5767: bug: nacos.lua make some duplicate instance
tzssangglass edited a comment on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-995934980 do the following request to your nacos and what do you get ``` curl -X GET '127.0.0.1:8848/nacos/v1/ns/instance/list?healthyOnly=true&serviceName=demo1026' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance
tzssangglass commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-995934980 do the following request to your nacos and what do you get ``` curl -X GET '127.0.0.1:8848/nacos/v1/ns/instance/list?healthyOnly=true&serviceName= demo1026' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xetraforest-fenghan opened a new pull request #5835: add openwhisk apisix lua and t file
xetraforest-fenghan opened a new pull request #5835: URL: https://github.com/apache/apisix/pull/5835 ### What this PR does / why we need it: ### Pre-submission checklist: * [ x] Did you explain what problem does this PR solve? Or what new features have been added? * [ x] Have you added corresponding test cases? * [ x] Have you modified the corresponding document? * [ x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist opened a new pull request #2250: feat: add append query string to redirect
zaunist opened a new pull request #2250: URL: https://github.com/apache/apisix-dashboard/pull/2250 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Add append query string for redirect plugin. **Related issues** resolve #2095 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2247: update the kin-openapi to v0.86.0
nic-chen commented on a change in pull request #2247:
URL: https://github.com/apache/apisix-dashboard/pull/2247#discussion_r770968693
##
File path: api/internal/handler/data_loader/route_import.go
##
@@ -147,7 +147,7 @@ func (h *ImportHandler) Import(c droplet.Context)
(interface{}, error) {
} else {
if _, err := h.routeStore.Create(c.Context(), route);
err != nil {
return handler.SpecCodeResponse(err),
- fmt.Errorf("create route(uris:%v)
failed: %s", route.Uris, err)
+ fmt.Errorf("111create route(uris:%v)
failed: %s", route.Uris, err)
Review comment:
you could use meaningful worlds to distinguish from the previous message.
##
File path: api/internal/handler/data_loader/route_import.go
##
@@ -133,7 +133,7 @@ func (h *ImportHandler) Import(c droplet.Context)
(interface{}, error) {
if _, err := h.routeStore.CreateCheck(route); err != nil {
return handler.SpecCodeResponse(err),
- fmt.Errorf("create route(uris:%v) failed: %s",
route.Uris, err)
+ fmt.Errorf("222create route(uris:%v) failed:
%s", route.Uris, err)
Review comment:
please remove the debug info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0
nic-chen commented on issue #2246: URL: https://github.com/apache/apisix-dashboard/issues/2246#issuecomment-996248817 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] danielkocot commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy
danielkocot commented on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-996245043 I used the mqtt client from HiveMQ. Now I used mosquito_pub with `mosquitto_pub -t test -m "Hello" -h 127.0.0.1 -p 9100` and the result is `Error: The connection is lost`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #5796: bug: The traffic split plug-in runs and reports an error according to the official configuration
nic-chen commented on issue #5796:
URL: https://github.com/apache/apisix/issues/5796#issuecomment-996251938
> > ```lua
>
> >
[[{"disable":false,"rules":[{"match":[{"vars":[["arg_shop","==","aa"]]}],"weighted_upstreams":[{"upstream":{"name":"upstream_A","nodes":{"uat-open-app-ads.uat.svc.cluster.local:8080":10},"type":"roundrobin"}}]}]}]]
>
> > ```
>
>
>
> should be
>
>
>
> ```lua
>
>
[[{"disable":false,"rules":[{"match":[{"vars":[[["arg_shop","==","aa"]]]}],"weighted_upstreams":[{"upstream":{"name":"upstream_A","nodes":{"uat-open-app-ads.uat.svc.cluster.local:8080":10},"type":"roundrobin"}}]}]}]]
>
> ```
>
>
>
> putting this code in IDEA quickly reveals the error
>
>
>
>
>
>
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5828: docs: fix typo introduced in the refactor
spacewander merged pull request #5828: URL: https://github.com/apache/apisix/pull/5828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (a68a03c -> b1cd36f)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from a68a03c docs: Fix typo in documentation (#5830) add b1cd36f docs: fix typo introduced in the refactor (#5828) No new revisions were added by this update. Summary of changes: docs/en/latest/how-to-build.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [apisix] spacewander commented on pull request #5728: fix(ua-restriction): refine the ua-restriction plugin configuration checksum logic
spacewander commented on pull request #5728: URL: https://github.com/apache/apisix/pull/5728#issuecomment-996338635 @zuiyangqingzhou Would you update the test to make CI pass? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix(sls-logger): log entry unable get millisecond timestamp (#5820)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new fce2b44 fix(sls-logger): log entry unable get millisecond timestamp
(#5820)
fce2b44 is described below
commit fce2b44f5fe5c3358ec7dcdeb8fdb5530ee3e8a2
Author: 帅进超
AuthorDate: Fri Dec 17 09:06:31 2021 +0800
fix(sls-logger): log entry unable get millisecond timestamp (#5820)
---
apisix/plugins/slslog/rfc5424.lua | 9 +++--
t/plugin/sls-logger.t | 76 +++
2 files changed, 57 insertions(+), 28 deletions(-)
diff --git a/apisix/plugins/slslog/rfc5424.lua
b/apisix/plugins/slslog/rfc5424.lua
index ff73d19..5d09a58 100644
--- a/apisix/plugins/slslog/rfc5424.lua
+++ b/apisix/plugins/slslog/rfc5424.lua
@@ -78,16 +78,15 @@ local Severity = {
DEBUG = LOG_DEBUG,
}
-local os_date = os.date
-local ngx = ngx
-local rfc5424_timestamp_format = "!%Y-%m-%dT%H:%M:%S.000Z"
+local log_util = require("apisix.utils.log-util")
+
+
local _M = { version = 0.1 }
function _M.encode(facility, severity, hostname, appname, pid, project,
logstore, access_key_id, access_key_secret, msg)
local pri = (Facility[facility] * 8 + Severity[severity])
-ngx.update_time()
-local t = os_date(rfc5424_timestamp_format, ngx.now())
+local t = log_util.get_rfc3339_zulu_timestamp()
if not hostname then
hostname = "-"
end
diff --git a/t/plugin/sls-logger.t b/t/plugin/sls-logger.t
index 7e8b1eb..296372c 100644
--- a/t/plugin/sls-logger.t
+++ b/t/plugin/sls-logger.t
@@ -19,7 +19,21 @@ use t::APISIX 'no_plan';
repeat_each(1);
no_long_string();
no_root_location();
-run_tests;
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+
+if (!defined $block->request) {
+$block->set_value("request", "GET /t");
+}
+
+});
+
+run_tests();
__DATA__
@@ -37,12 +51,8 @@ __DATA__
ngx.say("done")
}
}
request
-GET /t
--- response_body
done
no_error_log
-[error]
@@ -60,13 +70,9 @@ done
ngx.say("done")
}
}
request
-GET /t
--- response_body
property "access_key_secret" is required
done
no_error_log
-[error]
@@ -84,13 +90,9 @@ done
ngx.say("done")
}
}
request
-GET /t
--- response_body
property "timeout" validation failed: wrong type: expected integer, got string
done
no_error_log
-[error]
@@ -155,12 +157,8 @@ done
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -169,8 +167,6 @@ passed
GET /hello
--- response_body
hello world
no_error_log
-[error]
--- wait: 1
@@ -188,9 +184,43 @@ hello world
ngx.say(data)
}
}
request
-GET /t
--- response_body
123
no_error_log
-[error]
+
+
+
+=== TEST 7: sls log get milliseconds
+--- config
+location /t {
+content_by_lua_block {
+local function get_syslog_timestamp_millisecond(log_entry)
+local first_idx = string.find(log_entry, " ") + 1
+local last_idx2 = string.find(log_entry, " ", first_idx)
+local rfc3339_date = string.sub(log_entry, first_idx,
last_idx2)
+local rfc3339_len = string.len(rfc3339_date)
+local rfc3339_millisecond = string.sub(rfc3339_date,
rfc3339_len - 4, rfc3339_len - 2)
+return tonumber(rfc3339_millisecond)
+end
+
+math.randomseed(os.time())
+local rfc5424 = require("apisix.plugins.slslog.rfc5424")
+local m = 0
+-- because the millisecond value obtained by `ngx.now` may be `0`
+-- it is executed multiple times to ensure the accuracy of the test
+for i = 1, 5 do
+ngx.sleep(string.format("%0.3f", math.random()))
+local log_entry = rfc5424.encode("SYSLOG", "INFO",
"localhost", "apisix",
+ 123456, "apisix.apache.org",
"apisix.apache.log",
+ "apisix.sls.logger",
"BD274822-96AA-4DA6-90EC-15940FB2",
+ "hello world")
+m = get_syslog_timestamp_millisecond(log_entry) + m
+end
+
+if m > 0 then
+ngx.say("passed")
+end
+}
+}
+--- response_body
+passed
+--- timeout: 5
[GitHub] [apisix] spacewander merged pull request #5820: fix(sls-logger): log entry unable get millisecond timestamp
spacewander merged pull request #5820: URL: https://github.com/apache/apisix/pull/5820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
tzssangglass commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996344485 Recommended for development on x86 systems, dependency support on M1 is not complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
tzssangglass commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996344675 @zjzwjcbj we can close this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5826: request help: How to get request header and response header?
tzssangglass commented on issue #5826: URL: https://github.com/apache/apisix/issues/5826#issuecomment-996345395 `core.request.header()` or `core.request.headers()`, it is easy to search in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5793: docs: sync stream proxy Chinese version
juzhiyuan commented on a change in pull request #5793: URL: https://github.com/apache/apisix/pull/5793#discussion_r771032513 ## File path: docs/zh/latest/stream-proxy.md ## @@ -72,7 +72,11 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 'X-API-KEY: edd1c9f03 ## 更多 route 匹配选项 -我们可以添加更多的选项来匹配 route。 +我们可以添加更多的选项来匹配 route。目前 stream 路由配置支持 3 个字段进行过滤： + +- server_addr: 接受四层（流式）连接的 APISIX 服务器的地址。 +- server_port: 接受四层（流式）连接的 APISIX 服务器的端口。 Review comment: Hi @tzssangglass, should we use `四层（流式）` or `Stream Route`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'
juzhiyuan commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r771032942 ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Installation via RPM Offline Package(CentOS 7) + +Download APISIX offline RPM package to `./apisix` folder + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix Review comment: `uptime` is a command, right? 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5823: docs: remove the redundant space between Chinese characters
spacewander commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996346967 What about providing a check to the Chinese doc? We can add a script to check if 1. the last char of the line is not ascii 2. the next line is not empty 3. the first char of the next line is not ascii If so, we can fold the Chinese phrase into one line. Such script can be integrated into the CI: https://github.com/apache/apisix/blob/fce2b44f5fe5c3358ec7dcdeb8fdb5530ee3e8a2/.github/workflows/doc-lint.yml#L22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'
leslie-tsang commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r771035675 ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Installation via RPM Offline Package(CentOS 7) + +Download APISIX offline RPM package to `./apisix` folder + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix Review comment: yep -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy
spacewander commented on issue #5802:
URL: https://github.com/apache/apisix/issues/5802#issuecomment-996355964
Interesting. Here is the result running on my machine:
```
incubator-apisix (master) 0
￥ mosquitto_sub -t test -v &
[1] 23990
incubator-apisix (master) 0
￥ mosquitto_pub -t test -m "Hello" -p 9100
test Hello
```
My stream route conf is:
```
{"plugins":{"mqtt-proxy":{"protocol_level":4,"protocol_name":"MQTT","upstream":{"host":"127.0.0.1","port":1883
```
My config.yaml is:
```
apisix:
#dns_resolver: # If not set, read from `/etc/resolv.conf`
#- 127.0.0.1:1053
enable_admin: true
stream_proxy: # TCP/UDP proxy
only: false
tcp:# TCP proxy port list
- addr: 9100
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5827: init_worker_by_lua error: ./apisix/plugins/prometheus/exporter.lua:17: module 'prometheus' not found:
tzssangglass commented on issue #5827: URL: https://github.com/apache/apisix/issues/5827#issuecomment-996355925 zip file is source code of APISIX, as @spacewander said, you need to build APISIX form source code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5814: bug: java plugin error permission denied
tzssangglass commented on issue #5814: URL: https://github.com/apache/apisix/issues/5814#issuecomment-996356616 @sunyu-2020 If you verify this is complete, would you be willing to submit a PR to add documentation about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander edited a comment on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy
spacewander edited a comment on issue #5802:
URL: https://github.com/apache/apisix/issues/5802#issuecomment-996355964
Interesting. Here is the result running on my machine:
```
incubator-apisix (master) 0
￥ mosquitto_sub -t test -v &
[1] 23990
incubator-apisix (master) 0
￥ mosquitto_pub -t test -m "Hello" -p 9100
test Hello
```
My stream route conf is:
```
{"plugins":{"mqtt-proxy":{"protocol_level":4,"protocol_name":"MQTT","upstream":{"host":"127.0.0.1","port":1883
```
My config.yaml is:
```
apisix:
#dns_resolver: # If not set, read from `/etc/resolv.conf`
#- 127.0.0.1:1053
enable_admin: true
stream_proxy: # TCP/UDP proxy
only: false
tcp:# TCP proxy port list
- addr: 9100
```
My mosquitto_pub version is:
```
mosquitto_pub --version
mosquitto_pub version 2.0.14 running on libmosquitto 2.0.14.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zjzwjcbj closed issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
zjzwjcbj closed issue #5817: URL: https://github.com/apache/apisix/issues/5817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zjzwjcbj commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
zjzwjcbj commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996357675 > @zjzwjcbj we can close this? Ok,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #2251: ci: remove push docker image to demo env
nic-chen opened a new pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** remove push docker image to demo env in Github Actions **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996378124 @dmsolr Any update about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] chanjet1213 opened a new issue #5837: 期待监控指标添加对nginx共享内存使用情况的监控
chanjet1213 opened a new issue #5837: URL: https://github.com/apache/apisix/issues/5837 ### Issue description 期待监控指标添加对nginx共享内存使用情况的监控 ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new issue #5838: improve: google-cloud-logging unable to set up SSL Verify
shuaijinchao opened a new issue #5838:
URL: https://github.com/apache/apisix/issues/5838
### Issue description
`google-cloud-logging` SSL verification settings currently need to be
configured in the auth_config structure or auth_file configuration file to take
effect. Currently, when using the file key configuration configuration, the key
file downloaded from Google Cloud is usually configured directly into APISIX.
The default file does not contain SSL-related settings. At this time, SSL
Verify cannot be dynamically adjusted through the plug-in configuration.
Solution: Adjust the configuration of SSL Verify to the primary structure of
the plugin configuration.
For example:
```json
{
"google-cloud-logging":{
"auth_file":"/path/to/private_key.json",
"ssl_verify":true,
"...":"..."
}
}
```
### Environment
- apisix version (cmd: `apisix version`):
- OS (cmd: `uname -a`):
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
### Steps to reproduce
google-cloud-logging
### Actual result
google-cloud-logging
### Error log
google-cloud-logging
### Expected result
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new pull request #5839: chore(google-cloud-logging): move ssl_verify to plugin configuration top level
shuaijinchao opened a new pull request #5839: URL: https://github.com/apache/apisix/pull/5839 ### What this PR does / why we need it: FIX #5838 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #3498: apisix access have 500 status code
membphis closed issue #3498: URL: https://github.com/apache/apisix/issues/3498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3498: apisix access have 500 status code
membphis commented on issue #3498: URL: https://github.com/apache/apisix/issues/3498#issuecomment-996392247 ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout
dmsolr commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996392753 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout
dmsolr commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996393391 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr removed a comment on issue #4301: bug: skywalking not work when upsteam timeout
dmsolr removed a comment on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996393391 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang opened a new pull request #5840: fix(core.log): log level need to be updated in some scenario
leslie-tsang opened a new pull request #5840:
URL: https://github.com/apache/apisix/pull/5840
### What this PR does / why we need it:
log level need to be update in some scenario, such as called in init phase.
POC:
> set error_log log level as `error`
```yaml
extra_lua_path: ""# extend lua_package_path to load third
party code
extra_lua_cpath: "" # extend lua_package_cpath to load third
party code
lua_module_hook: "my_project.my_hook" # the hook module which will be
used to inject third party code into APISIX
```
```lua
# code in my_project.my_hook
local core.log = require("apisix.core.log")
core_log.info("test")
# `info` func will be cached in `apisix.core.log`
# which break the expectation of the error_log log level
```
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible,
please discuss on the [mailing
list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2251: ci: remove push docker image to demo env
juzhiyuan commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996395345 Hi, may I know visitors how to use the manager-api? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] webup closed issue #182: feat: add service monitor for main chart
webup closed issue #182: URL: https://github.com/apache/apisix-helm-chart/issues/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] webup commented on issue #182: feat: add service monitor for main chart
webup commented on issue #182: URL: https://github.com/apache/apisix-helm-chart/issues/182#issuecomment-996397990 Closed with #192. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996398822 > I honestly think this is a legitimate fix and we can just fix this everywhere if needed Hi @Josh-Cena, I can't clearly remember why we have breaking lines in our docs 😅 And +1 from me to improve the original docs by folding Chinese phrases into one line. @Nidaozi Would you please have a try?  Hi @spacewander, how about improving those markdown files first, then deciding if we need to implement the CI? Just to make sure, you mean we could use CI to check all coming Chinese documentation changes, right? 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5834: request help: how to set redirect_uri, when i use openid-connect
juzhiyuan commented on issue #5834: URL: https://github.com/apache/apisix/issues/5834#issuecomment-996401543 Hi @leslie-tsang, would you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat(plugin): change button desc (#2248)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 40822d7 feat(plugin): change button desc (#2248)
40822d7 is described below
commit 40822d7a803ce3152f90a8b1606a9af9a19b1f8d
Author: Yu.Bozhong
AuthorDate: Fri Dec 17 11:14:16 2021 +0800
feat(plugin): change button desc (#2248)
---
web/src/components/Plugin/locales/en-US.ts | 2 +-
web/src/components/Plugin/locales/zh-CN.ts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/src/components/Plugin/locales/en-US.ts
b/web/src/components/Plugin/locales/en-US.ts
index d62764d..1ec4b1b 100644
--- a/web/src/components/Plugin/locales/en-US.ts
+++ b/web/src/components/Plugin/locales/en-US.ts
@@ -24,7 +24,7 @@ export default {
'component.plugin.pluginTemplate.tip2':
'2. The same plugin in the plugin template will override one in the
plugins.',
'component.plugin.enable': 'Enable',
- 'component.plugin.disable': 'Disable',
+ 'component.plugin.disable': 'Edit',
'component.plugin.authentication': 'Authentication',
'component.plugin.security': 'Security',
'component.plugin.traffic': 'Traffic Control',
diff --git a/web/src/components/Plugin/locales/zh-CN.ts
b/web/src/components/Plugin/locales/zh-CN.ts
index c76f2d3..094af63 100644
--- a/web/src/components/Plugin/locales/zh-CN.ts
+++ b/web/src/components/Plugin/locales/zh-CN.ts
@@ -23,7 +23,7 @@ export default {
'1. 若路由已配置插件，则插件模板数据将与已配置的插件数据合并。',
'component.plugin.pluginTemplate.tip2': '2. 插件模板相同的插件会覆盖掉原有的插件。',
'component.plugin.enable': '启用',
- 'component.plugin.disable': '禁用',
+ 'component.plugin.disable': '编辑',
'component.plugin.authentication': '身份验证',
'component.plugin.security': '安全防护',
'component.plugin.traffic': '流量控制',
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2248: feat(plugin): change button desc
juzhiyuan merged pull request #2248: URL: https://github.com/apache/apisix-dashboard/pull/2248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #2245: The `禁用` button on the plugin list page has ambiguity issues
juzhiyuan closed issue #2245: URL: https://github.com/apache/apisix-dashboard/issues/2245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Josh-Cena commented on pull request #5823: docs: remove the redundant space between Chinese characters
Josh-Cena commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996402605 So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Josh-Cena edited a comment on pull request #5823: docs: remove the redundant space between Chinese characters
Josh-Cena edited a comment on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996402605 So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `"proseWrap": "never"` and it will collapse all wrapping line breaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403248 > So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. Just to make sure, do you mean to use Prettier to format all markdown files in this repo? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan edited a comment on pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan edited a comment on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403248 > So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. Just to make sure, do you mean to use Prettier to format all markdown files in this repo? 🙈🙈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Josh-Cena commented on pull request #5823: docs: remove the redundant space between Chinese characters
Josh-Cena commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403699 Yeah, that could be helpful 🤪 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996404873 Get it, I will create an issue to track this 🥳 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
