[GitHub] [apisix] zuiyangqingzhou commented on pull request #5728: fix(ua-restriction): refine the ua-restriction plugin configuration checksum logic

2021-12-17 Thread GitBox


zuiyangqingzhou commented on pull request #5728:
URL: https://github.com/apache/apisix/pull/5728#issuecomment-997155763


   
![image](https://user-images.githubusercontent.com/17425270/146632094-48f350ec-242a-417e-a370-7ed9628fa4e8.png)
   This should be caused by something else


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zuiyangqingzhou commented on pull request #5728: fix(ua-restriction): refine the ua-restriction plugin configuration checksum logic

2021-12-17 Thread GitBox


zuiyangqingzhou commented on pull request #5728:
URL: https://github.com/apache/apisix/pull/5728#issuecomment-997155462


   > @zuiyangqingzhou Would you update the test to make CI pass?
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-docker] zzyork commented on issue #253: real-ip plugin can not work

2021-12-17 Thread GitBox


zzyork commented on issue #253:
URL: https://github.com/apache/apisix-docker/issues/253#issuecomment-997147738


   > Can you provide a full test case? We need to confirm whether it is a bug.
   
   Thank you for your help, I found the reason, because I configured a wrong 
plug-in in config.yaml, which caused all the plug-ins to not work. Currently 
real-ip has been working normally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2253: chore: update echo description to apisix-dashboard

2021-12-17 Thread GitBox


codecov-commenter commented on pull request #2253:
URL: https://github.com/apache/apisix-dashboard/pull/2253#issuecomment-997139863


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2253?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2253](https://codecov.io/gh/apache/apisix-dashboard/pull/2253?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ecfe089) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ffa596d) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2253/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2253?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2253  +/-   ##
   ==
   - Coverage   68.12%   68.06%   -0.06% 
   ==
 Files 127  127  
 Lines3369 3369  
 Branches  829  829  
   ==
   - Hits 2295 2293   -2 
   - Misses   1074 1076   +2 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.06% <ø> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2253?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2253/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==)
 | `70.49% <0.00%> (-3.28%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2253?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2253?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Last update 
[ffa596d...ecfe089](https://codecov.io/gh/apache/apisix-dashboard/pull/2253?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] okaybase opened a new pull request #2253: chore: update echo description to apisix-dashboard

2021-12-17 Thread GitBox


okaybase opened a new pull request #2253:
URL: https://github.com/apache/apisix-dashboard/pull/2253


   Please answer these questions before submitting a pull request, **or your PR 
will get closed**.
   
   **Why submit this pull request?**
   because `version-check.sh` check the version of apisix-dashboard, so update 
echo description to apisix-dashboard.
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Please update this section with detailed description.
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, 
please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] guoqqqi commented on a change in pull request #5793: docs: sync stream proxy Chinese version

2021-12-17 Thread GitBox


guoqqqi commented on a change in pull request #5793:
URL: https://github.com/apache/apisix/pull/5793#discussion_r771772056



##
File path: docs/zh/latest/stream-proxy.md
##
@@ -72,7 +72,11 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 
'X-API-KEY: edd1c9f03
 
 ## 更多 route 匹配选项
 
-我们可以添加更多的选项来匹配 route。
+我们可以添加更多的选项来匹配 route。目前 stream 路由配置支持 3 个字段进行过滤:
+
+- server_addr: 接受四层(流式)连接的 APISIX 服务器的地址。
+- server_port: 接受四层(流式)连接的 APISIX 服务器的端口。

Review comment:
   Should I change the `四层(流式)` to `Stream Route`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis merged pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://

2021-12-17 Thread GitBox


membphis merged pull request #5825:
URL: https://github.com/apache/apisix/pull/5825


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated: feat: upgrade luarocks to 3.8.0 which converts git:// to https:// (#5825)

2021-12-17 Thread membphis
This is an automated email from the ASF dual-hosted git repository.

membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 5cde5ae  feat: upgrade luarocks to 3.8.0 which converts git:// to 
https:// (#5825)
5cde5ae is described below

commit 5cde5ae0040f9fa7468dae12649276f07b0e9031
Author: 罗泽轩 
AuthorDate: Sat Dec 18 08:29:57 2021 +0800

feat: upgrade luarocks to 3.8.0 which converts git:// to https:// (#5825)

The Luarocks 2.x is already broken.
---
 .github/workflows/fuzzing-ci.yaml  | 1 -
 Makefile   | 8 ++--
 ci/common.sh   | 1 -
 ci/linux_apisix_current_luarocks_runner.sh | 2 --
 ci/linux_apisix_master_luarocks_runner.sh  | 2 --
 docs/en/latest/FAQ.md  | 3 +--
 docs/zh/latest/FAQ.md  | 4 +---
 utils/linux-install-luarocks.sh| 9 +
 8 files changed, 9 insertions(+), 21 deletions(-)

diff --git a/.github/workflows/fuzzing-ci.yaml 
b/.github/workflows/fuzzing-ci.yaml
index b23ec2d..bb132da 100644
--- a/.github/workflows/fuzzing-ci.yaml
+++ b/.github/workflows/fuzzing-ci.yaml
@@ -50,7 +50,6 @@ jobs:
 sudo apt-get install -y git openresty curl openresty-openssl111-dev 
unzip make gcc libldap2-dev
 ./utils/linux-install-luarocks.sh
 
-git config --global url.https://github.com/.insteadOf git://github.com/
 make deps
 make init
 make run
diff --git a/Makefile b/Makefile
index adcd64d..2b25def 100644
--- a/Makefile
+++ b/Makefile
@@ -155,12 +155,8 @@ deps: runtime
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL) 
variables.OPENSSL_INCDIR $(addprefix $(ENV_OPENSSL_PREFIX), /include); \
$(ENV_LUAROCKS) install rockspec/apisix-master-0.rockspec 
--tree=deps --only-deps --local $(ENV_LUAROCKS_SERVER_OPT); \
else \
-   $(call func_echo_warn_status, "WARNING: You're not using 
LuaRocks 3.x; please add the following items to your LuaRocks config file:"); \
-   echo "variables = {"; \
-   echo "OPENSSL_LIBDIR=$(addprefix $(ENV_OPENSSL_PREFIX), 
/lib)"; \
-   echo "OPENSSL_INCDIR=$(addprefix $(ENV_OPENSSL_PREFIX), 
/include)"; \
-   echo "}"; \
-   $(ENV_LUAROCKS) install rockspec/apisix-master-0.rockspec 
--tree=deps --only-deps --local $(ENV_LUAROCKS_SERVER_OPT); \
+   $(call func_echo_warn_status, "WARNING: You're not using 
LuaRocks 3.x; please remove the luarocks and reinstall it via 
https://raw.githubusercontent.com/apache/apisix/master/utils/linux-install-luarocks.sh;);
 \
+   exit 1; \
fi
 
 
diff --git a/ci/common.sh b/ci/common.sh
index ec8b7e6..612236e 100644
--- a/ci/common.sh
+++ b/ci/common.sh
@@ -26,7 +26,6 @@ export_or_prefix() {
 create_lua_deps() {
 echo "Create lua deps"
 
-git config --global url.https://github.com/.insteadOf git://github.com/
 make deps
 # maybe reopen this feature later
 # luarocks install luacov-coveralls --tree=deps --local > build.log 2>&1 
|| (cat build.log && exit 1)
diff --git a/ci/linux_apisix_current_luarocks_runner.sh 
b/ci/linux_apisix_current_luarocks_runner.sh
index 2682a4f..a143d47 100755
--- a/ci/linux_apisix_current_luarocks_runner.sh
+++ b/ci/linux_apisix_current_luarocks_runner.sh
@@ -32,8 +32,6 @@ script() {
 
 sudo rm -rf /usr/local/apisix
 
-git config --global url.https://github.com/.insteadOf git://github.com/
-
 # install APISIX with local version
 sudo luarocks install rockspec/apisix-master-0.rockspec --only-deps > 
build.log 2>&1 || (cat build.log && exit 1)
 sudo luarocks make rockspec/apisix-master-0.rockspec > build.log 2>&1 || 
(cat build.log && exit 1)
diff --git a/ci/linux_apisix_master_luarocks_runner.sh 
b/ci/linux_apisix_master_luarocks_runner.sh
index ed3e58c..a75fdf6 100755
--- a/ci/linux_apisix_master_luarocks_runner.sh
+++ b/ci/linux_apisix_master_luarocks_runner.sh
@@ -36,8 +36,6 @@ script() {
 mkdir tmp && cd tmp
 cp -r ../utils ./
 
-git config --global url.https://github.com/.insteadOf git://github.com/
-
 # install APISIX by luarocks
 sudo luarocks install $APISIX_MAIN > build.log 2>&1 || (cat build.log && 
exit 1)
 cp ../bin/apisix /usr/local/bin/apisix
diff --git a/docs/en/latest/FAQ.md b/docs/en/latest/FAQ.md
index 8038b9c..9f56094 100644
--- a/docs/en/latest/FAQ.md
+++ b/docs/en/latest/FAQ.md
@@ -66,7 +66,6 @@ See more [etcd 
why](https://etcd.io/docs/latest/learning/why/#comparison-chart).
 There are two possibilities when encountering slow luarocks:
 
 1. Server used for luarocks installation is blocked
-2. There is a place between your network and github server to block the 'git' 
protocol
 
 For the first problem, you can use https_proxy or use the `--server` option to 
specify a luarocks server 

[GitHub] [apisix] lizhouyang commented on issue #5834: request help: how to set redirect_uri, when i use openid-connect

2021-12-17 Thread GitBox


lizhouyang commented on issue #5834:
URL: https://github.com/apache/apisix/issues/5834#issuecomment-996700851


   我主要是不懂将redirect url 设置成什么,我已经获得了code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-website] branch master updated: docs: add Istio with APISIX Ingress blog (#814)

2021-12-17 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new d53f9a3  docs: add Istio with APISIX Ingress blog (#814)
d53f9a3 is described below

commit d53f9a3cff60b2dd735aae542deca8f8228c1ef5
Author: Sylvia <39793568+sylviab...@users.noreply.github.com>
AuthorDate: Fri Dec 17 19:53:24 2021 +0800

docs: add Istio with APISIX Ingress blog (#814)
---
 .../blog/2021/12/15/deploy-apisix-in-kubernetes.md |   4 +
 .../12/17/exposure-istio-with-apisix-ingress.md| 408 +
 .../2021/12/15/deploy-apisix-in-kubernetes.md  |   3 +
 .../12/17/exposure-istio-with-apisix-ingress.md| 408 +
 4 files changed, 823 insertions(+)

diff --git a/website/blog/2021/12/15/deploy-apisix-in-kubernetes.md 
b/website/blog/2021/12/15/deploy-apisix-in-kubernetes.md
index 93e61ed..7112f53 100644
--- a/website/blog/2021/12/15/deploy-apisix-in-kubernetes.md
+++ b/website/blog/2021/12/15/deploy-apisix-in-kubernetes.md
@@ -88,6 +88,10 @@ Finally, the verification of the new route is performed.
 
 Since this article uses Kind to build a local K8s cluster, the 
`apisix-gateway` NodePort is not accessible, so an additional step is needed 
before validation, i.e. forwarding port `80` from the cluster to port `8080` on 
the local machine.
 
+```shell
+kubectl port-forward service/apisix-gateway 8080:80
+```
+
 Start the verification process.
 
 ```shell
diff --git a/website/blog/2021/12/17/exposure-istio-with-apisix-ingress.md 
b/website/blog/2021/12/17/exposure-istio-with-apisix-ingress.md
new file mode 100644
index 000..2a155de
--- /dev/null
+++ b/website/blog/2021/12/17/exposure-istio-with-apisix-ingress.md
@@ -0,0 +1,408 @@
+---
+title: "Secure Exposure of Istio Services with APISIX Ingress"
+authors:
+  - name: "Jintao Zhang"
+title: "Author"
+url: "https://github.com/tao12345666333;
+image_url: "https://avatars.githubusercontent.com/u/3264292?v=4;
+  - name: "Sylvia"
+title: "Technical Writer"
+url: "https://github.com/SylviaBABY;
+image_url: "https://avatars.githubusercontent.com/u/39793568?v=4;
+keywords: 
+- Apache APISIX
+- Istio
+- Kubernetes
+- APISIX Ingress Controller
+- Service Mesh
+description: This article shows you step by step how to use Istio Service Mesh 
and Apache APISIX, to expose services in a Service Mesh-enabled Kubernetes 
cluster to the outside of the cluster through very detailed steps.
+tags: [Technology]
+---
+
+> This article shows you step by step how to use Istio Service Mesh and Apache 
APISIX, to expose services in a Service Mesh-enabled Kubernetes cluster to the 
outside of the cluster through very detailed steps.
+
+
+
+## Service Mesh
+
+With the hot development of Cloud-Native technology, Service Mesh is gradually 
becoming popular in the microservices field. The popular implementations of 
Service Mesh are [Istio](https://istio.io/) and [Linkerd](https://linkerd.io/).
+
+The following diagram shows the schematic diagram of Service Mesh, which 
introduces Sidecar Proxy to complete the interconnection and communication 
between microservices.
+
+![Service 
Mesh](https://static.apiseven.com/202108/1639730484170-fbf2e5ed-3041-4975-8730-a16c92be68f2.png)
+
+The diagram above shows that Service Mesh focuses more on east-west traffic in 
the traditional sense, i.e., traffic between services. When we use Service Mesh 
with Kubernetes, the east-west traffic corresponds to the traffic within the 
Kubernetes cluster.
+
+Back in real-world usage scenarios, we won't only be exposed to traffic within 
the Kubernetes cluster, we will mostly need to expose some services outside of 
the cluster for users or other services to use. But when exposing services in a 
Kubernetes cluster outside the cluster, we have to consider factors such as 
security and observability.
+
+We'll show you how to securely expose services in a Service Mesh-enabled 
Kubernetes cluster outside the cluster using Istio Service Mesh and Apache 
APISIX.
+
+![How to 
deal](https://static.apiseven.com/202108/1639730236819-0911b90b-811f-4451-b0e5-f89ac3e04b77.png)
+
+## Step 1: Prepare the Kubernetes cluster
+
+Here we use [Kind](https://github.com/kubernetes-sigs/kind/) to create a 
temporary cluster locally for demonstration purposes. You can refer to the 
[official 
documentation](https://kind.sigs.k8s.io/docs/user/quick-start/#installation) 
for how to install it with the Kind command.
+
+Here is the yaml configuration file used to create the demo cluster, save it 
as `kind-config.yaml`.
+
+```yaml
+kind: Cluster
+apiVersion: kind.x-k8s.io/v1alpha4
+nodes:
+- role: control-plane
+- role: worker
+- role: worker
+- role: worker
+```
+
+Then use this configuration file to create a cluster.
+
+```bash
+(MoeLove) ➜ kind create cluster --config kind-config.yaml
+Creating 

[GitHub] [apisix-website] juzhiyuan merged pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-17 Thread GitBox


juzhiyuan merged pull request #814:
URL: https://github.com/apache/apisix-website/pull/814


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2238: feat: Support APISIX_PROFILE for env-specific configuration

2021-12-17 Thread GitBox


bzp2010 commented on pull request #2238:
URL: https://github.com/apache/apisix-dashboard/pull/2238#issuecomment-996615437


   Hi, @kevinw66.
   
   Sorry to reply to your delay, I miss it when dealing with PR, I have learned 
the purpose of this function, this feature is also used in Apache APISIX, I 
think it is no problem, but can you add some tests to it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj removed a comment on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-17 Thread GitBox


zjzwjcbj removed a comment on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-996578191


   > See 
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/README.md,
 and you check focus on the configurations about `apisix.customPlugins`.
   
   Like this ?
   helm install apisix apisix/apisix  --set gateway.type=NodePort --set 
admin.allow.ipList="{0.0.0.0/0}" --set apisix.customPlugins.enabled=true --set 
apisix.customPlugins.luaPath="/opt/apisix/custom_plugin/third-plugin.lua" --set 
apisix.customPlugins.plugins.name="third-plugin" -n apisix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] gxthrj commented on issue #136: How does the ingress controller work well with dashboard without relying on the Apache APISIX-Admin api?

2021-12-17 Thread GitBox


gxthrj commented on issue #136:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/136#issuecomment-996612762


   We will indeed consider some new architectures so that APISIX will not rely 
on `etcd` when deploying. 
   But this is different from the APISIX stand-alone mode. 
   Our goal is to make `APISIX ingress` a stateless deployment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 merged pull request #2251: ci: remove push docker image to demo env

2021-12-17 Thread GitBox


bzp2010 merged pull request #2251:
URL: https://github.com/apache/apisix-dashboard/pull/2251


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-dashboard] branch master updated (40822d7 -> ffa596d)

2021-12-17 Thread bzp2010
This is an automated email from the ASF dual-hosted git repository.

bzp2010 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.


from 40822d7  feat(plugin): change button desc (#2248)
 add ffa596d  chore: remove push docker image to demo env (#2251)

No new revisions were added by this update.

Summary of changes:
 .github/workflows/deploy-with-docker.yml | 13 -
 1 file changed, 13 deletions(-)


[GitHub] [apisix-docker] bzp2010 commented on pull request #254: feat: bump APISIX Dashboard to 2.10

2021-12-17 Thread GitBox


bzp2010 commented on pull request #254:
URL: https://github.com/apache/apisix-docker/pull/254#issuecomment-996610045


   Hi,@gxthrj.
   
   Docker buildx used in this PR uses the QEMU analog ARM instruction mode to 
compile the GO program and NodeJS, which will result in serious performance 
issues, I am working on it (using cross-compilation and fixing `--platform`).
   
   It still needs to be waited for a while, and about it will be prepared to 
merge it tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] gxthrj commented on issue #787: request help: ApisixRoute apiversion Inconsistency

2021-12-17 Thread GitBox


gxthrj commented on issue #787:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-996609143


   > I am using 
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/crds/customresourcedefinitions.yaml
 It seems that the latest version of the crd configuration is the v1 version, 
then I also change all to v1?
   
   I suggest you use v2beta2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] gxthrj edited a comment on issue #781: request help: The route name generated by default is too long

2021-12-17 Thread GitBox


gxthrj edited a comment on issue #781:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-996602883






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] gxthrj commented on issue #781: request help: The route name generated by default is too long

2021-12-17 Thread GitBox


gxthrj commented on issue #781:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-996602883


   This is indeed a problem, we can discuss it.
   I suggest that Id can be generated with a fixed length, but this will reduce 
readability. 
   At the same time, adding the complete resource path in the desc field will 
be a balanced solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #727: e2e: optimize before_each function in scaffold

2021-12-17 Thread GitBox


gxthrj commented on pull request #727:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/727#issuecomment-996591037


   CI re-runed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] github-actions[bot] closed issue #1919: support vars in URI

2021-12-17 Thread GitBox


github-actions[bot] closed issue #1919:
URL: https://github.com/apache/apisix-dashboard/issues/1919


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #1919: support vars in URI

2021-12-17 Thread GitBox


github-actions[bot] commented on issue #1919:
URL: 
https://github.com/apache/apisix-dashboard/issues/1919#issuecomment-996590926


   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] github-actions[bot] commented on issue #3037: after configoure the SSL,log error

2021-12-17 Thread GitBox


github-actions[bot] commented on issue #3037:
URL: https://github.com/apache/apisix/issues/3037#issuecomment-996590392


   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] github-actions[bot] closed issue #3037: after configoure the SSL,log error

2021-12-17 Thread GitBox


github-actions[bot] closed issue #3037:
URL: https://github.com/apache/apisix/issues/3037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] gxthrj edited a comment on issue #712: request help: apisix-ingress-controller "error": "unexpected non-empty object"

2021-12-17 Thread GitBox


gxthrj edited a comment on issue #712:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/712#issuecomment-996588031


   This is still a bit troublesome. We have to figure out the scope of 
historical data. We may not be compatible with the old version. I suggest that 
we can distinguish it according to the LTS version. We only support the LTS 
version and the latest version of APISIX.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] gxthrj commented on issue #712: request help: apisix-ingress-controller "error": "unexpected non-empty object"

2021-12-17 Thread GitBox


gxthrj commented on issue #712:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/712#issuecomment-996588031


   This is still a bit troublesome. We have to figure out the scope of 
historical data. We may not be compatible with the old version. I suggest that 
we can distinguish it according to the LTS version. We only support the LTS 
version and the latest version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://

2021-12-17 Thread GitBox


tokers commented on pull request #5825:
URL: https://github.com/apache/apisix/pull/5825#issuecomment-996586682


   > No, as I mentioned in the commit message. The luarocks 2.x is actually 
broken. We just make sure people won't be trapped in it.
   
   Sorry, I misunderstood the meaning of this PR, I thought we add some 
constraints for the LuaRocks 3.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on issue #5850: request help:About use key-auth to control consumer access to different routes

2021-12-17 Thread GitBox


tokers commented on issue #5850:
URL: https://github.com/apache/apisix/issues/5850#issuecomment-996585327


   @123libohan Is the number of consumers are huge in your case? And the 
consumer list in the Route is long?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-docker] gxthrj commented on pull request #254: feat: bump APISIX Dashboard to 2.10

2021-12-17 Thread GitBox


gxthrj commented on pull request #254:
URL: https://github.com/apache/apisix-docker/pull/254#issuecomment-99658


   LGTM, Can we merge this feature now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] 123libohan opened a new issue #5850: request help:About use key-auth to control consumer access to different routes

2021-12-17 Thread GitBox


123libohan opened a new issue #5850:
URL: https://github.com/apache/apisix/issues/5850


   ### Issue description
   
   We want to use key-auth to control consumer access to different routes and 
prevent unauthorized consumers from accessing the route.
   That's the way we do it right now:
   1)POST:http://:9080/apisix/admin/consumers/
   `{
   "username": "consumer_A",
   "plugins": {
   "key-auth": {
   "key": "consumer_A"
   }
   }
   }`
   2)POST:http://xxx:9080/apisix/admin/routes/
   {
   "uri": "/nacos-remote/call",
   "plugins": {
   "key-auth": {
   "query": "ak",
   "header": "apikey"
   },
"consumer-restriction": {
   "whitelist": [
   "consumer_A","consumer_B"
   ]
   },
   "limit-count-by-client": {
   }
   },
   "service_id": "00032029"
   }
   This method is very inconvenient when adding or deleting a consumer, because 
every time the route adds or deletes a consumer, it needs to check all 
whitelist names under the consumer, and then set the whitelist again, which is 
prone to error.
   Is there a better way to do this?
   
   In addition, when you want to give a consumer access to all routes under the 
service, you need to traverse all routes under the service and then set them 
one by one through the above method. Is there a better way?
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin

2021-12-17 Thread GitBox


zjzwjcbj commented on issue #5791:
URL: https://github.com/apache/apisix/issues/5791#issuecomment-996578191


   > See 
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/README.md,
 and you check focus on the configurations about `apisix.customPlugins`.
   
   Like this ?
   helm install apisix apisix/apisix  --set gateway.type=NodePort --set 
admin.allow.ipList="{0.0.0.0/0}" --set apisix.customPlugins.enabled=true --set 
apisix.customPlugins.luaPath="/opt/apisix/custom_plugin/third-plugin.lua" --set 
apisix.customPlugins.plugins.name="third-plugin" -n apisix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2095: Feature request: support appending query string in redirect plugin

2021-12-17 Thread GitBox


juzhiyuan commented on issue #2095:
URL: 
https://github.com/apache/apisix-dashboard/issues/2095#issuecomment-996560736


   > I checked [redirect 
plugin](https://apisix.apache.org/docs/apisix/plugins/redirect/), `Only one of 
http_to_https, uri or regex_uri can be specified.`, but `append_query_string` 
not one of them. So `append_query_string` maybe a separate button or option 
menu, because `append_query_string` can coexist with `http_to_https, uri, 
regex_uri`. Is it right ?
   
   Yes, both append_query_string & encode_uri are two seprate buttons, we could 
use Switch component to handle this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] chanjet1213 opened a new issue #5849: request help: dashboard认证登录

2021-12-17 Thread GitBox


chanjet1213 opened a new issue #5849:
URL: https://github.com/apache/apisix/issues/5849


   ### Issue description
   
   dashboard何时支持认证登录?比如支持openLDAP。
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2251: ci: remove push docker image to demo env

2021-12-17 Thread GitBox


juzhiyuan commented on pull request #2251:
URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996558625


   ping @LiteSun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] danielkocot edited a comment on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-17 Thread GitBox


danielkocot edited a comment on issue #5802:
URL: https://github.com/apache/apisix/issues/5802#issuecomment-996548206


   I use the stream route configuration from the documentation
   `{
   "remote_addr": "127.0.0.1",
   "plugins": {
   "mqtt-proxy": {
   "protocol_name": "MQTT",
   "protocol_level": 5,
   "upstream": {
   "host": "127.0.0.1",
   "port": 1883
   }
   }
   }
   }`
   I will test it with your configuration :). Maybe `remote_addr`is the problem 
;).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] danielkocot commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-17 Thread GitBox


danielkocot commented on issue #5802:
URL: https://github.com/apache/apisix/issues/5802#issuecomment-996548206


   I use the stream route configuration from the documentation
   `{
   "remote_addr": "127.0.0.1",
   "plugins": {
   "mqtt-proxy": {
   "protocol_name": "MQTT",
   "protocol_level": 5,
   "upstream": {
   "host": "127.0.0.1",
   "port": 1883
   }
   }
   }
   }`
   I will test it with your configuration :).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-17 Thread GitBox


netlify[bot] edited a comment on pull request #814:
URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
    Explore the source changes: 381ec2f9004775e6b52ffec7779b84e762c5040a
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61bc4d75f751160007278450](https://app.netlify.com/sites/apache-apisix/deploys/61bc4d75f751160007278450)
   
    Browse the preview: 
[https://deploy-preview-814--apache-apisix.netlify.app](https://deploy-preview-814--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-17 Thread GitBox


netlify[bot] edited a comment on pull request #814:
URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
    Explore the source changes: 3b44a1a6646a51205eec45029e39514c2ea2ec67
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61bc4cbfd0ce940007a07692](https://app.netlify.com/sites/apache-apisix/deploys/61bc4cbfd0ce940007a07692)
   
    Browse the preview: 
[https://deploy-preview-814--apache-apisix.netlify.app](https://deploy-preview-814--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-17 Thread GitBox


netlify[bot] edited a comment on pull request #814:
URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821


    Deploy Preview for *apache-apisix* processing.
   
   
    Explore the source changes: 381ec2f9004775e6b52ffec7779b84e762c5040a
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61bc4d75f751160007278450](https://app.netlify.com/sites/apache-apisix/deploys/61bc4d75f751160007278450)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-17 Thread GitBox


netlify[bot] edited a comment on pull request #814:
URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821


    Deploy Preview for *apache-apisix* processing.
   
   
    Explore the source changes: 3b44a1a6646a51205eec45029e39514c2ea2ec67
   
    Inspect the deploy log: 
[https://app.netlify.com/sites/apache-apisix/deploys/61bc4cbfd0ce940007a07692](https://app.netlify.com/sites/apache-apisix/deploys/61bc4cbfd0ce940007a07692)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-java-plugin-runner] branch main updated (82bef6b -> d5adbe0)

2021-12-17 Thread tzssangglass
This is an automated email from the ASF dual-hosted git repository.

tzssangglass pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git.


from 82bef6b  chore: upgrade log4j2 version to 2.16.0 (#99)
 add d5adbe0  docs: add zh Quick Start (#95)

No new revisions were added by this update.

Summary of changes:
 docs/zh/Quick Start.md | 112 +
 1 file changed, 112 insertions(+)
 create mode 100644 docs/zh/Quick Start.md


[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #95: docs: add zh Quick Start

2021-12-17 Thread GitBox


tzssangglass merged pull request #95:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/95


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander merged pull request #5848: fix(install-dependencies): the execution of the script should not be interrupted

2021-12-17 Thread GitBox


spacewander merged pull request #5848:
URL: https://github.com/apache/apisix/pull/5848


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated: fix(install-dependencies): the execution of the script should not be interrupted (#5848)

2021-12-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 37d469e  fix(install-dependencies): the execution of the script should 
not be interrupted (#5848)
37d469e is described below

commit 37d469e081d26ecd48ebede0518dc3afaef74e5b
Author: leslie <59061168+leslie-ts...@users.noreply.github.com>
AuthorDate: Fri Dec 17 16:13:14 2021 +0800

fix(install-dependencies): the execution of the script should not be 
interrupted (#5848)
---
 utils/install-dependencies.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/install-dependencies.sh b/utils/install-dependencies.sh
index 6ffaba5..b2bd4df 100755
--- a/utils/install-dependencies.sh
+++ b/utils/install-dependencies.sh
@@ -44,7 +44,7 @@ function install_dependencies_with_aur() {
 
 # Install dependencies on centos and fedora
 function install_dependencies_with_yum() {
-sudo yum install yum-utils
+sudo yum install -y yum-utils
 
 local common_dep="curl git gcc openresty-openssl111-devel unzip pcre 
pcre-devel openldap-devel"
 if [ "${1}" == "centos" ]; then


[GitHub] [apisix-dashboard] zaunist commented on issue #2095: Feature request: support appending query string in redirect plugin

2021-12-17 Thread GitBox


zaunist commented on issue #2095:
URL: 
https://github.com/apache/apisix-dashboard/issues/2095#issuecomment-996516960


   I checked [redirect 
plugin](https://apisix.apache.org/docs/apisix/plugins/redirect/), `Only one of 
http_to_https, uri or regex_uri can be specified.`, but `append_query_string` 
not one of them. So `append_query_string` maybe a separate button or option 
menu, because `append_query_string` can coexist with `http_to_https, uri, 
regex_uri`. Is it right ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org