[GitHub] [apisix] shuaijinchao commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
shuaijinchao commented on a change in pull request #5839:
URL: https://github.com/apache/apisix/pull/5839#discussion_r771910150
##
File path: apisix/plugins/google-cloud-logging.lua
##
@@ -61,13 +61,13 @@ local schema = {
type = "string",
default = "https://logging.googleapis.com/v2/entries:write;
},
-ssl_verify = {
Review comment:
I think this has no substantive significance. In most cases, this field
remains the default setting, and general users will not actively set this
option. this plugin is a new feature released in version 2.11. In such a short
period of time, I don't think it will be used in a mass production environment.
In addition, it is a bug for people who use file configuration ^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 opened a new issue #255: bug: wrong APISIX ARM64 image
bzp2010 opened a new issue #255: URL: https://github.com/apache/apisix-docker/issues/255 Previously, we used `openresty/openresty` as the base image, which can support ARM64 architecture. And now we switch to `api7/apisix-base` as the base image, which does not support ARM64, and based on the original CI build infrastructure, we are still releasing ARM64-based APISIX images, so currently there is an ARM64 APISIX image using x86_64 `apisix-base` as the base, which does not work properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #781: request help: The route name generated by default is too long
tokers commented on issue #781: URL: https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-997332223 > This is indeed a problem, we can discuss it. I suggest that `ID` can be generated with a fixed length, but this will reduce readability. At the same time, adding the complete resource path in the `desc` field will be a balanced solution. Labels can be added so that the readability can be remedied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #791: feat: add ApisixPluginConfig translator (#638)
tokers commented on a change in pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#discussion_r771899067
##
File path: pkg/kube/translation/apisix_pluginconfig.go
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+ configv2beta3
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+func (t *translator) TranslateApisixPluginConfig(apc
*configv2beta3.ApisixPluginConfig) (*apisixv1.PluginConfig, error) {
+ pluginMap := make(apisixv1.Plugins)
+ if len(apc.Spec.Plugins) > 0 {
+ for _, plugin := range apc.Spec.Plugins {
+ for k, v := range plugin {
+ // Here, it will override same key.
Review comment:
I think either the override behavior should be documented or we should
enrich the CRD schema so that the overridden won't happen.
##
File path: pkg/kube/translation/apisix_pluginconfig_test.go
##
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+ "testing"
+
+ configv2beta3
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+
+ "github.com/stretchr/testify/assert"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Review comment:
```suggestion
"github.com/stretchr/testify/assert"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
configv2beta3
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
tokers commented on a change in pull request #5839:
URL: https://github.com/apache/apisix/pull/5839#discussion_r771898379
##
File path: apisix/plugins/google-cloud-logging.lua
##
@@ -61,13 +61,13 @@ local schema = {
type = "string",
default = "https://logging.googleapis.com/v2/entries:write;
},
-ssl_verify = {
Review comment:
I don't know whether this plugin is used by someone, if we just remove
this setting, it's bad for these users. Or we can just reserve and deprecate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5847: request help: proxy_pass cannot use https
tokers commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-997330512 Please describe your architecture elaborately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 edited a comment on issue #5834: request help: how to set redirect_uri, when i use openid-connect
bzp2010 edited a comment on issue #5834: URL: https://github.com/apache/apisix/issues/5834#issuecomment-997328733 Enable this plugin on the route, when the user request arrives, APISIX will get the session in the request, if it cannot find it, it will jump to the OIDC authentication address (where the default value of redirect_uri is the path of the current request), when the authentication is completed, it will carry the code and state back to the original request address, then APISIX will send the code and other information to the token endpoint to get the token, after that APISIX will cache the token and expiration time to the memory cache and release the legitimate request. When a user holds a token, but it is not yet cached in APISIX, APISIX will send a request to introspection to get information about the token to confirm its validity. Therefore, you don't need to do anything with the code. After the user returns from the OIDC authentication service, the user will visit such address `xxx.com/xxx?code=xxx=xxx`, and APISIX will automatically handle the subsequent steps, such as exchanging tokens and pass requests, etc. 在路由上开启这个插件后，当用户请求到达时，APISIX会获取请求中的session，如果无法找到，它将会跳转至OIDC认证地址（其中redirect_uri默认值为当前请求的路径），当认证完成后，将会携带code和state回到原有的请求地址，这时APISIX会将code等信息发送至token端点以获取token，之后APISIX会将token和过期时间缓存至内存缓存中，并放行合法请求。 当一个用户持有token，但APISIX中尚未缓存它时，APISIX将会向introspection发送请求以获取token的信息确认其是否有效。 因此，您不需要对code做任何操作，用户从OIDC认证服务返回后，用户将访问这样的地址`xxx.com/xxx?code=xxx=xxx`，而APISIX会自动处理后续步骤，如换取token和放行请求等。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on issue #5834: request help: how to set redirect_uri, when i use openid-connect
bzp2010 commented on issue #5834: URL: https://github.com/apache/apisix/issues/5834#issuecomment-997328733 Enable this plugin on the route, when the user request arrives, APISIX will get the session in the request, if it cannot find it, it will jump to the OIDC authentication address (where the default value of redirect_uri is the path of the current request), when the authentication is completed, it will carry the code and state back to the original request address, then APISIX will send the code and other information to the token endpoint to get the token, after that APISIX will cache the token and expiration time to the memory cache and release the legitimate request. When a user holds a token, but it is not yet cached in APISIX, APISIX will send a request to introspection to get information about the token to confirm its validity. Therefore, you don't need to do anything with the code. After the user returns from the OIDC authentication service, the user will visit such address `xxx.com/xxx?code=xxx=xxx`, and APISIX will automatically handle the subsequent steps, such as exchanging tokens, etc. 在路由上开启这个插件后，当用户请求到达时，APISIX会获取请求中的session，如果无法找到，它将会跳转至OIDC认证地址（其中redirect_uri默认值为当前请求的路径），当认证完成后，将会携带code和state回到原有的请求地址，这时APISIX会将code等信息发送至token端点以获取token，之后APISIX会将token和过期时间缓存至内存缓存中，并放行合法请求。 当一个用户持有token，但APISIX中尚未缓存它时，APISIX将会向introspection发送请求以获取token的信息确认其是否有效。 因此，您不需要对code做任何操作，用户从OIDC认证服务返回后，用户将访问这样的地址`xxx.com/xxx?code=xxx=xxx`，而APISIX会自动处理后续步骤，如换取token等。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5793: docs: sync stream proxy Chinese version
tzssangglass commented on a change in pull request #5793: URL: https://github.com/apache/apisix/pull/5793#discussion_r771894926 ## File path: docs/zh/latest/stream-proxy.md ## @@ -72,7 +72,11 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 'X-API-KEY: edd1c9f03 ## 更多 route 匹配选项 -我们可以添加更多的选项来匹配 route。 +我们可以添加更多的选项来匹配 route。目前 stream 路由配置支持 3 个字段进行过滤： + +- server_addr: 接受四层（流式）连接的 APISIX 服务器的地址。 +- server_port: 接受四层（流式）连接的 APISIX 服务器的端口。 Review comment: yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist commented on issue #5851: request help: how to install in ubuntu
zaunist commented on issue #5851: URL: https://github.com/apache/apisix/issues/5851#issuecomment-997326751 Hi, @Carson-T , we have a [repository](https://github.com/api7/apisix-build-tools) to packaging apisix for ubuntu, you can refer to package apisix on your machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #101: fix: ensure correct encoding and decoding when data length is greater…
tzssangglass opened a new pull request #101: URL: https://github.com/apache/apisix-java-plugin-runner/pull/101 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #731: feat: Grafana Dashboard Configuration
tao12345666333 commented on a change in pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#discussion_r771891099 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -0,0 +1,124 @@ +--- +title: prometheus +--- + + + +This guide shows how to monitor Apache APISIX Ingress Controller using Prometheus and Grafana. + +## Enable Prometheus + +You can find example CRD files in `apisix-ingress-controller/samples/deploy/crd/v1`. +The CRD file `ApisixClusterConfig` is required to use to enable prometheus in global configurations. +In `ApisixClusterConfig`, `monitoring.prometheus` field is used to describe Prometheus settings. +```yaml Review comment: This file is a definition file for custom resources. In order to be able to configure correctly, we should create a custom resource configuration file, like this: ```yaml apiVersion: apisix.apache.org/v2beta3 kind: ApisixClusterConfig metadata: name: default spec: monitoring: prometheus: enable: true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy
juzhiyuan commented on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-997321397 > Maybe remote_addris the problem ;). Hi Daniel, if this is the root cause, kindly let us know -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #791: feat: add ApisixPluginConfig translator (#638)
tao12345666333 commented on a change in pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#discussion_r771836509
##
File path: pkg/kube/translation/apisix_pluginconfig.go
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+ configv2beta3
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+func (t *translator) TranslateApisixPluginConfig(apc
*configv2beta3.ApisixPluginConfig) (*apisixv1.PluginConfig, error) {
+ pluginMap := make(apisixv1.Plugins)
+ if len(apc.Spec.Plugins) > 0 {
Review comment:
Add a judgment condition that `apc.Spec` is not nil.
##
File path: pkg/kube/translation/apisix_pluginconfig_test.go
##
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+ "testing"
+
+ configv2beta3
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+
+ "github.com/stretchr/testify/assert"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestTranslateApisixPluginConfig(t *testing.T) {
+ apc := {
+ ObjectMeta: metav1.ObjectMeta{
+ Name: "apc",
+ Namespace: "test-ns",
+ },
+ Spec: configv2beta3.ApisixPluginConfigSpec{
+ Plugins: []configv2beta3.ApisixRouteHTTPPluginConfig{
+ {
+ "key-1": 123,
+ "key-2": map[string][]string{
+ "whitelist": {
+ "127.0.0.0/24",
+ "113.74.26.106",
+ },
+ },
+ "key-3": map[string]int{
+ "count": 2,
+ "time_window": 60,
+ "rejected_code": 503,
+ },
+ },
+ {
+ "key-1": 123456,
+ "key-2": map[string][]string{
+ "whitelist": {
+ "1.1.1.1",
+ },
+ },
+ "key-4": map[string]int{
+ "count": 5,
+ "time_window": 60,
+ "rejected_code": 503,
+ },
+ },
+ },
+ },
+ }
+ trans := {}
+ pluginConfig, err := trans.TranslateApisixPluginConfig(apc)
+ assert.NoError(t, err)
+ assert.Len(t, pluginConfig.Plugins, 4)
+ assert.Equal(t, pluginConfig.Plugins["key-1"],
apc.Spec.Plugins[1]["key-1"])
Review comment:
```
func
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
juzhiyuan merged pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: authentication middleware is implemented by changing from framework droplet to framework gin (#2254)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new b565f7c fix: authentication middleware is implemented by changing
from framework droplet to framework gin (#2254)
b565f7c is described below
commit b565f7cd090e9ee2043fbb726fbaae01737f83cd
Author: JunXu Chen
AuthorDate: Sun Dec 19 10:08:27 2021 +0800
fix: authentication middleware is implemented by changing from framework
droplet to framework gin (#2254)
---
api/internal/core/server/http.go | 3 +-
api/internal/core/server/server.go | 2 +-
api/internal/filter/authentication.go | 123 +
api/internal/filter/authentication_test.go | 86 --
api/internal/filter/ip_filter_test.go | 6 +-
api/internal/filter/logging_test.go| 7 +-
api/internal/handler/upstream/upstream_test.go | 34 +++---
api/internal/route.go | 2 +-
api/test/e2e/route_import_test.go | 12 +-
api/test/e2enew/base/base.go | 2 +-
api/test/e2enew/migrate/migrate_test.go| 21
api/test/e2enew/stream_route/stream_route_test.go | 2 +
.../e2enew/upstream/upstream_keepalive_pool.go | 4 +-
api/test/e2enew/upstream/upstream_test.go | 12 +-
api/test/testdata/import/multi-routes.yaml | 42 +++
15 files changed, 163 insertions(+), 195 deletions(-)
diff --git a/api/internal/core/server/http.go b/api/internal/core/server/http.go
index 53a4216..ea0c56c 100644
--- a/api/internal/core/server/http.go
+++ b/api/internal/core/server/http.go
@@ -27,7 +27,6 @@ import (
"github.com/apisix/manager-api/internal"
"github.com/apisix/manager-api/internal/conf"
- "github.com/apisix/manager-api/internal/filter"
"github.com/apisix/manager-api/internal/handler"
)
@@ -37,7 +36,7 @@ func (s *server) setupAPI() {
var newMws []droplet.Middleware
// default middleware order: resp_reshape, auto_input,
traffic_log
// We should put err_transform at second to catch all error
- newMws = append(newMws, mws[0],
{}, {})
+ newMws = append(newMws, mws[0],
{})
newMws = append(newMws, mws[1:]...)
return newMws
}
diff --git a/api/internal/core/server/server.go
b/api/internal/core/server/server.go
index c46ab3a..6d0d20b 100644
--- a/api/internal/core/server/server.go
+++ b/api/internal/core/server/server.go
@@ -35,7 +35,7 @@ type server struct {
options *Options
}
-type Options struct {}
+type Options struct{}
// NewServer Create a server manager
func NewServer(options *Options) (*server, error) {
diff --git a/api/internal/filter/authentication.go
b/api/internal/filter/authentication.go
index 7b565f2..7c7e728 100644
--- a/api/internal/filter/authentication.go
+++ b/api/internal/filter/authentication.go
@@ -17,84 +17,67 @@
package filter
import (
- "errors"
"net/http"
"strings"
"github.com/dgrijalva/jwt-go"
- "github.com/shiningrush/droplet"
- "github.com/shiningrush/droplet/data"
- "github.com/shiningrush/droplet/middleware"
+ "github.com/gin-gonic/gin"
"github.com/apisix/manager-api/internal/conf"
"github.com/apisix/manager-api/internal/log"
)
-type AuthenticationMiddleware struct {
- middleware.BaseMiddleware
-}
-
-func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) error {
- httpReq := ctx.Get(middleware.KeyHttpRequest)
- if httpReq == nil {
- err := errors.New("input middleware cannot get http request")
-
- // Wrong usage, just panic here and let recoverHandler to deal
with
- panic(err)
- }
-
- req := httpReq.(*http.Request)
-
- if req.URL.Path == "/apisix/admin/tool/version" || req.URL.Path ==
"/apisix/admin/user/login" {
- return mw.BaseMiddleware.Handle(ctx)
- }
-
- if !strings.HasPrefix(req.URL.Path, "/apisix") {
- return mw.BaseMiddleware.Handle(ctx)
- }
-
- // Need check the auth header
- tokenStr := req.Header.Get("Authorization")
-
- // verify token
- token, err := jwt.ParseWithClaims(tokenStr, {},
func(token *jwt.Token) (interface{}, error) {
- return []byte(conf.AuthConf.Secret), nil
- })
-
- // TODO: design the response error code
- response := data.Response{Code: 010013, Message: "request unauthorized"}
-
- if err != nil || token == nil || !token.Valid {
- log.Warnf("token validate failed: %s", err)
- log.Warn("please check the secret in conf.yaml")
-
[GitHub] [apisix-docker] membphis closed issue #253: real-ip plugin can not work
membphis closed issue #253: URL: https://github.com/apache/apisix-docker/issues/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #5728: fix(ua-restriction): refine the ua-restriction plugin configuration checksum logic
membphis commented on a change in pull request #5728:
URL: https://github.com/apache/apisix/pull/5728#discussion_r771885455
##
File path: t/plugin/ua-restriction.t
##
@@ -783,5 +790,7 @@ load_full_data(): failed to check item data of
[/apisix/routes] err:failed to ch
ngx.say("done")
}
}
error_log
-load_full_data(): failed to check item data of [/apisix/routes] err:failed to
check the configuration of plugin ua-restriction
+--- response_body
+property "denylist" validation failed: wrong type: expected array, got table
+done
+--- ONLY
Review comment:
need to remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] yangxikun edited a comment on issue #3891: request help: opentelemetry luajit SDK and intergration with APISIX
yangxikun edited a comment on issue #3891: URL: https://github.com/apache/apisix/issues/3891#issuecomment-997208793 I am writing an opentelemetry-lua sdk, and will integrate with APISIX. https://github.com/yangxikun/opentelemetry-lua -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (76224b3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **increase** coverage by `1.73%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == + Coverage 68.12% 69.85% +1.73% == Files 127 184 +57 Lines3369 7272+3903 Branches 829 829 == + Hits 2295 5080+2785 - Misses 1074 1897 +823 - Partials0 295 +295 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.12% <57.89%> (?)` | | | backend-e2e-test-ginkgo | `59.69% <57.89%> (?)` | | | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `68.12% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.50% <100.00%> (ø)` | | | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | `59.67% <0.00%> (ø)` | | | [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | `92.30% <0.00%> (ø)` | | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (76224b3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **increase** coverage by `3.23%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == + Coverage 68.12% 71.35% +3.23% == Files 127 57 -70 Lines3369 3903 +534 Branches 8290 -829 == + Hits 2295 2785 +490 + Misses 1074 823 -251 - Partials0 295 +295 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.12% <57.89%> (?)` | | | backend-e2e-test-ginkgo | `59.69% <57.89%> (?)` | | | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.50% <100.00%> (ø)` | | | [...src/pages/SSL/components/CertificateForm/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZUZvcm0vaW5kZXgudHN4) | | | | [...mponents/PluginFlow/components/FlowGraph/shapes.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvc2hhcGVzLnRz) | | | | [...c/components/Upstream/components/KeepalivePool.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvS2VlcGFsaXZlUG9vbC50c3g=) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (76224b3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **increase** coverage by `0.46%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == + Coverage 68.12% 68.58% +0.46% == Files 127 57 -70 Lines3369 3903 +534 Branches 8290 -829 == + Hits 2295 2677 +382 + Misses 1074 934 -140 - Partials0 292 +292 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `59.69% <57.89%> (?)` | | | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.50% <100.00%> (ø)` | | | [web/src/pages/Service/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL3NlcnZpY2UudHM=) | | | | [...nents/PluginFlow/components/FlowGraph/FlowGraph.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvRmxvd0dyYXBoLnRz) | | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (76224b3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `18.92%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.19% -18.93% === Files 127 41 -86 Lines3369 3169 -200 Branches 8290 -829 === - Hits 2295 1559 -736 - Misses 1074 1411 +337 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [web/src/app.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hcHAudHN4) | | | | [.../components/passive-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9IZWFsdGh5L0h0dHBTdGF0dXNlcy50c3g=) | | | | [web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4) | | | | [...eam/components/active-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9UaW1lb3V0cy50c3g=) | | | | [...ages/Route/components/Step2/RequestRewriteView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL1JlcXVlc3RSZXdyaXRlVmlldy50c3g=) | | | | [web/src/pages/SSL/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvQ3JlYXRlLnRzeA==) | | | | [web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (152a535) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `3.26%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 64.85% -3.27% == Files 127 184 +57 Lines3369 7272+3903 Branches 829 829 == + Hits 2295 4716+2421 - Misses 1074 2270+1196 - Partials0 286 +286 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.17% <57.89%> (?)` | | | backend-unit-test | `49.16% <77.77%> (?)` | | | frontend-e2e-test | `68.06% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `80.00% <100.00%> (ø)` | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: | | [api/internal/core/entity/interface.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2ludGVyZmFjZS5nbw==) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `92.00% <0.00%> (ø)` | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `50.00% <0.00%> (ø)` | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (152a535) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `6.04%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 62.08% -6.05% == Files 127 57 -70 Lines3369 3903 +534 Branches 8290 -829 == + Hits 2295 2423 +128 - Misses 1074 1194 +120 - Partials0 286 +286 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.17% <57.89%> (?)` | | | backend-unit-test | `49.16% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `80.00% <100.00%> (ø)` | | | [web/src/components/Plugin/UI/basic-auth.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9iYXNpYy1hdXRoLnRzeA==) | | | | [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | | | | [web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hY2Nlc3MudHM=) | | | | [web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (152a535) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `6.11%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 62.00% -6.12% == Files 127 57 -70 Lines3369 3903 +534 Branches 8290 -829 == + Hits 2295 2420 +125 - Misses 1074 1197 +123 - Partials0 286 +286 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.09% <57.89%> (?)` | | | backend-unit-test | `49.16% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `80.00% <100.00%> (ø)` | | | [web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4) | | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [...components/PluginFlow/components/Toolbar/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9Ub29sYmFyL2luZGV4LnRzeA==) | | | | [...rc/components/Upstream/components/RetryTimeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUmV0cnlUaW1lb3V0LnRzeA==) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (152a535) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `18.95%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.16% -18.96% === Files 127 41 -86 Lines3369 3169 -200 Branches 8290 -829 === - Hits 2295 1558 -737 - Misses 1074 1412 +338 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.16% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | | | | [...nents/PluginFlow/components/FlowGraph/FlowGraph.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvRmxvd0dyYXBoLnRz) | | | | [web/src/pages/Consumer/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9zZXJ2aWNlLnRz) | | | | [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | | | | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | | | | [...src/pages/SSL/components/CertificateForm/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZUZvcm0vaW5kZXgudHN4) | | | | [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | | | |
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
tao12345666333 commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997216472 re-run all jobs. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (83cbf68) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `9.17%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 58.94% -9.18% == Files 127 168 +41 Lines3369 6538+3169 Branches 829 829 == + Hits 2295 3854+1559 - Misses 1074 2485+1411 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `68.12% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `64.00% <0.00%> (ø)` | | | [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | `80.76% <0.00%> (ø)` | | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `76.08% <0.00%> (ø)` | | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | `76.19% <0.00%> (ø)` | | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `71.23% <0.00%> (ø)` | | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `59.68% <0.00%> (ø)` | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `69.35%
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (83cbf68) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `18.92%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.19% -18.93% === Files 127 41 -86 Lines3369 3169 -200 Branches 8290 -829 === - Hits 2295 1559 -736 - Misses 1074 1411 +337 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==) | | | | [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | | | | [web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz) | | | | [web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz) | | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/components/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL3NlcnZpY2UudHM=) | | | | [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9nbG9iYWwudHN4) | | | |
[GitHub] [apisix] yangxikun commented on issue #3891: request help: opentelemetry luajit SDK and intergration with APISIX
yangxikun commented on issue #3891: URL: https://github.com/apache/apisix/issues/3891#issuecomment-997208793 I am writing an opentelemetry-lua sdk, and will integrate with APISIX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xetraforest-fenghan opened a new pull request #5852: feat(openwhisk): add openwhisk complex response process
xetraforest-fenghan opened a new pull request #5852: URL: https://github.com/apache/apisix/pull/5852 ### What this PR does / why we need it: This PR added openwhisk response parsing mechanism, implement issue [#5756](https://github.com/apache/apisix/issues/5756). As of now, user defined response header, params and body for openwhisk plugin are supported. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2297d14) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `9.20%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 58.91% -9.21% == Files 127 168 +41 Lines3369 6538+3169 Branches 829 829 == + Hits 2295 3852+1557 - Misses 1074 2487+1413 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `68.06% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `66.00% <0.00%> (ø)` | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `58.08% <0.00%> (ø)` | | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (ø)` | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.68% <0.00%> (ø)` | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `74.13% <0.00%> (ø)` | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2297d14) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `18.92%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.19% -18.93% === Files 127 41 -86 Lines3369 3169 -200 Branches 8290 -829 === - Hits 2295 1559 -736 - Misses 1074 1411 +337 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [...mponents/Upstream/components/active-check/Port.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1BvcnQudHN4) | | | | [...eb/src/pages/PluginTemplate/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1ByZXZpZXcudHN4) | | | | [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | | | | [...ream/components/active-check/Healthy/Successes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvU3VjY2Vzc2VzLnRzeA==) | | | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | | | | [web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (281d858) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `18.92%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.19% -18.93% === Files 127 41 -86 Lines3369 3169 -200 Branches 8290 -829 === - Hits 2295 1559 -736 - Misses 1074 1411 +337 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [web/src/components/PanelSection/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BhbmVsU2VjdGlvbi9pbmRleC50c3g=) | | | | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | | | | [...nents/Upstream/components/ServiceDiscoveryArgs.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvU2VydmljZURpc2NvdmVyeUFyZ3MudHN4) | | | | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | | | | [web/src/components/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL3NlcnZpY2UudHM=) | | | | [web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==) | | | | [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | | |
[GitHub] [apisix-dashboard] starsz commented on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
starsz commented on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997200317 Need to fix CI @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1984b63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **increase** coverage by `1.66%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == + Coverage 68.12% 69.78% +1.66% == Files 127 184 +57 Lines3369 7272+3903 Branches 829 829 == + Hits 2295 5075+2780 - Misses 1074 1901 +827 - Partials0 296 +296 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.12% <57.89%> (?)` | | | backend-e2e-test-ginkgo | `58.87% <57.89%> (?)` | | | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `68.12% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.50% <100.00%> (ø)` | | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `100.00% <0.00%> (ø)` | | | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `100.00% <0.00%> (ø)` | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `58.25% <0.00%> (ø)` | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `56.00% <0.00%> (ø)` | | |
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #731: feat: Grafana Dashboard Configuration
codecov-commenter edited a comment on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-97877 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#731](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4affd60) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b127ff4) will **increase** coverage by `0.64%`. > The diff coverage is `34.24%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #731 +/- ## == + Coverage 32.50% 33.14% +0.64% == Files 66 67 +1 Lines6800 7142 +342 == + Hits 2210 2367 +157 - Misses 4340 4505 +165 - Partials 250 270 +20 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `72.72% <ø> (-2.28%)` | :arrow_down: | | [pkg/api/validation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL2FwaXNpeF9jb25zdW1lci5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/api/validation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL2FwaXNpeF9yb3V0ZS5nbw==) | `21.73% <0.00%> (+2.50%)` | :arrow_up: | | [pkg/api/validation/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL2FwaXNpeF90bHMuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/api/validation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL2FwaXNpeF91cHN0cmVhbS5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | | | [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: | | [pkg/ingress/apisix\_cluster\_config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NvbnN1bWVyLmdv) | `0.00% <0.00%> (ø)` | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1984b63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `0.07%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 68.04% -0.08% == Files 127 184 +57 Lines3369 7272+3903 Branches 829 829 == + Hits 2295 4948+2653 - Misses 1074 2033 +959 - Partials0 291 +291 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `58.87% <57.89%> (?)` | | | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `68.12% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `44.68% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.50% <100.00%> (ø)` | | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `100.00% <0.00%> (ø)` | | | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `100.00% <0.00%> (ø)` | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `58.25% <0.00%> (ø)` | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `56.00% <0.00%> (ø)` | | |
[GitHub] [apisix-ingress-controller] Sindweller commented on issue #691: request help: Grafana dashboard config for apisix-ingress-controller
Sindweller commented on issue #691: URL: https://github.com/apache/apisix-ingress-controller/issues/691#issuecomment-997196458 should be closed as it's fixed in #670 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Sindweller closed issue #691: request help: Grafana dashboard config for apisix-ingress-controller
Sindweller closed issue #691: URL: https://github.com/apache/apisix-ingress-controller/issues/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Sindweller commented on issue #696: request help: metrics was exposed but not exist in Prometheus
Sindweller commented on issue #696: URL: https://github.com/apache/apisix-ingress-controller/issues/696#issuecomment-997196346 should be closed as it's fixed in #670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Sindweller closed issue #696: request help: metrics was exposed but not exist in Prometheus
Sindweller closed issue #696: URL: https://github.com/apache/apisix-ingress-controller/issues/696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xetraforest-fenghan closed pull request #5835: feat(openwhisk): add openwhisk complex response process
xetraforest-fenghan closed pull request #5835: URL: https://github.com/apache/apisix/pull/5835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1984b63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `0.14%`. > The diff coverage is `78.94%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 67.97% -0.15% == Files 127 57 -70 Lines3369 3903 +534 Branches 8290 -829 == + Hits 2295 2653 +358 + Misses 1074 959 -115 - Partials0 291 +291 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `58.87% <57.89%> (?)` | | | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `44.68% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.50% <100.00%> (ø)` | | | [...omponents/Upstream/components/ServiceDiscovery.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvU2VydmljZURpc2NvdmVyeS50c3g=) | | | | [web/src/pages/User/Logout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ291dC50c3g=) | | | | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | | | | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1984b63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `18.92%`. > The diff coverage is `77.77%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.19% -18.93% === Files 127 41 -86 Lines3369 3169 -200 Branches 8290 -829 === - Hits 2295 1559 -736 - Misses 1074 1411 +337 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.19% <77.77%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `77.77% <77.77%> (ø)` | | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | | | | [...eb/src/components/Upstream/components/TimeUnit.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZVVuaXQudHN4) | | | | [...components/active-check/Unhealthy/HttpFailures.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9IdHRwRmFpbHVyZXMudHN4) | | | | [web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz) | | | | [web/src/pages/Dashboard/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvc2VydmljZS50cw==) | | | | [web/src/pages/PluginTemplate/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9DcmVhdGUudHN4) | | | | [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | |
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997193358 e2e-test-ci failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
codecov-commenter commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997183430 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#791](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ee7c93f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/eeb7a49afb7219faaa41e55bef187f3a7ad03f0f?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (eeb7a49) will **increase** coverage by `0.19%`. > The diff coverage is `85.18%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #791 +/- ## == + Coverage 33.14% 33.33% +0.19% == Files 67 68 +1 Lines7142 7157 +15 == + Hits 2367 2386 +19 + Misses 4505 4501 -4 Partials 270 270 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `46.07% <ø> (ø)` | | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `21.74% <66.66%> (+0.71%)` | :arrow_up: | | [pkg/kube/translation/apisix\_pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3BsdWdpbmNvbmZpZy5nbw==) | `100.00% <100.00%> (ø)` | | | [pkg/kube/translation/context.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vY29udGV4dC5nbw==) | `89.47% <100.00%> (+3.75%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [eeb7a49...ee7c93f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (71ab6bf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `5.95%`. > The diff coverage is `76.47%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 62.16% -5.96% == Files 127 57 -70 Lines3369 3899 +530 Branches 8290 -829 == + Hits 2295 2424 +129 - Misses 1074 1190 +116 - Partials0 285 +285 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.18% <52.94%> (?)` | | | backend-unit-test | `49.09% <75.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <ø> (ø)` | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `75.00% <75.00%> (ø)` | | | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | `56.52% <100.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `80.00% <100.00%> (ø)` | | | [...mponents/Upstream/components/active-check/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1R5cGUudHN4) | | | | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | | | | [...src/pages/SSL/components/CertificateForm/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZUZvcm0vaW5kZXgudHN4) | | | | [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (71ab6bf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `19.02%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.09% -19.03% === Files 127 41 -86 Lines3369 3165 -204 Branches 8290 -829 === - Hits 2295 1554 -741 - Misses 1074 1412 +338 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.09% <75.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `75.00% <75.00%> (ø)` | | | [web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==) | | | | [web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=) | | | | [web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=) | | | | [...am/components/passive-check/Unhealthy/Timeouts.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9VbmhlYWx0aHkvVGltZW91dHMudHN4) | | | | [web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz) | | | | [web/src/components/Upstream/components/Scheme.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvU2NoZW1lLnRzeA==) | | | | [web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | |
[GitHub] [apisix-ingress-controller] neverCase edited a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase edited a comment on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997175498
@tao12345666333
From the
[https://apisix.apache.org/docs/apisix/architecture-design/plugin-config/](https://apisix.apache.org/docs/apisix/architecture-design/plugin-config/),
I thought the filed `plugin_config_id` maybe `type int`.
But in the apisixv1.Route I found the `UpstreamId` was `type string`.
```sh
// Route apisix route object
// +k8s:deepcopy-gen=true
type Route struct {
Metadata `json:",inline" yaml:",inline"`
Hoststring `json:"host,omitempty"
yaml:"host,omitempty"`
Hosts []string `json:"hosts,omitempty"
yaml:"hosts,omitempty"`
Uri string `json:"uri,omitempty"
yaml:"uri,omitempty"`
Priorityint `json:"priority,omitempty"
yaml:"priority,omitempty"`
Timeout *UpstreamTimeout `json:"timeout,omitempty"
yaml:"timeout,omitempty"`
VarsVars `json:"vars,omitempty"
yaml:"vars,omitempty"`
Uris[]string `json:"uris,omitempty"
yaml:"uris,omitempty"`
Methods []string `json:"methods,omitempty"
yaml:"methods,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"
yaml:"enable_websocket,omitempty"`
RemoteAddrs []string `json:"remote_addrs,omitempty"
yaml:"remote_addrs,omitempty"`
UpstreamId string `json:"upstream_id,omitempty"
yaml:"upstream_id,omitempty"`
Plugins Plugins `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
// I add it temporarily, I'm not sure the type
PluginConfigId string `json:"plugin_config_id,omitempty"
yaml:"plugin_config_id,omitempty"`
}
```
So I'm sure not where are the `PluginConfigId` from, and which type it
should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase edited a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase edited a comment on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997175498
@tao12345666333
From the
[https://apisix.apache.org/docs/apisix/architecture-design/plugin-config/](https://apisix.apache.org/docs/apisix/architecture-design/plugin-config/),
I thought the filed `plugin_config_id` maybe `type int`.
But in the apisixv1.Route I found the `UpstreamId` was `type string`.
```sh
// Route apisix route object
// +k8s:deepcopy-gen=true
type Route struct {
Metadata `json:",inline" yaml:",inline"`
Hoststring `json:"host,omitempty"
yaml:"host,omitempty"`
Hosts []string `json:"hosts,omitempty"
yaml:"hosts,omitempty"`
Uri string `json:"uri,omitempty"
yaml:"uri,omitempty"`
Priorityint `json:"priority,omitempty"
yaml:"priority,omitempty"`
Timeout *UpstreamTimeout `json:"timeout,omitempty"
yaml:"timeout,omitempty"`
VarsVars `json:"vars,omitempty"
yaml:"vars,omitempty"`
Uris[]string `json:"uris,omitempty"
yaml:"uris,omitempty"`
Methods []string `json:"methods,omitempty"
yaml:"methods,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"
yaml:"enable_websocket,omitempty"`
RemoteAddrs []string `json:"remote_addrs,omitempty"
yaml:"remote_addrs,omitempty"`
UpstreamId string `json:"upstream_id,omitempty"
yaml:"upstream_id,omitempty"`
Plugins Plugins `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
PluginConfigId string `json:"plugin_config_id,omitempty"
yaml:"plugin_config_id,omitempty"`
}
```
So I'm sure not where are the `PluginConfigId` from, and which type it
should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (78f51ed) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `18.98%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.13% -18.99% === Files 127 41 -86 Lines3369 3165 -204 Branches 8290 -829 === - Hits 2295 1555 -740 - Misses 1074 1411 +337 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.13% <75.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `75.00% <75.00%> (ø)` | | | [web/src/components/PanelSection/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BhbmVsU2VjdGlvbi9pbmRleC50c3g=) | | | | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | | | | [...nents/Upstream/components/ServiceDiscoveryArgs.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvU2VydmljZURpc2NvdmVyeUFyZ3MudHN4) | | | | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | | | | [web/src/components/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL3NlcnZpY2UudHM=) | | | | [web/src/components/Upstream/components/TLS.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVExTLnRzeA==) | | | | [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | | |
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997175498
@tao12345666333
From the
[https://apisix.apache.org/docs/apisix/architecture-design/plugin-config/](url),
I thought the filed `plugin_config_id` maybe `type int`.
But in the apisixv1.Route I found the `UpstreamId` was `type string`.
```sh
// Route apisix route object
// +k8s:deepcopy-gen=true
type Route struct {
Metadata `json:",inline" yaml:",inline"`
Hoststring `json:"host,omitempty"
yaml:"host,omitempty"`
Hosts []string `json:"hosts,omitempty"
yaml:"hosts,omitempty"`
Uri string `json:"uri,omitempty"
yaml:"uri,omitempty"`
Priorityint `json:"priority,omitempty"
yaml:"priority,omitempty"`
Timeout *UpstreamTimeout `json:"timeout,omitempty"
yaml:"timeout,omitempty"`
VarsVars `json:"vars,omitempty"
yaml:"vars,omitempty"`
Uris[]string `json:"uris,omitempty"
yaml:"uris,omitempty"`
Methods []string `json:"methods,omitempty"
yaml:"methods,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"
yaml:"enable_websocket,omitempty"`
RemoteAddrs []string `json:"remote_addrs,omitempty"
yaml:"remote_addrs,omitempty"`
UpstreamId string `json:"upstream_id,omitempty"
yaml:"upstream_id,omitempty"`
Plugins Plugins `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
PluginConfigId string `json:"plugin_config_id,omitempty"
yaml:"plugin_config_id,omitempty"`
}
```
So I'm sure not where are the `PluginConfigId` from, and which type it
should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Carson-T opened a new issue #5851: request help: how to install in ubuntu
Carson-T opened a new issue #5851: URL: https://github.com/apache/apisix/issues/5851 ### Issue description I can not find any course about how to install APISIX on ubuntu, please help me ### Environment ubuntu20.04.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter edited a comment on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0b57a36) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `9.22%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2254 +/- ## == - Coverage 68.12% 58.89% -9.23% == Files 127 168 +41 Lines3369 6534+3165 Branches 829 829 == + Hits 2295 3848+1553 - Misses 1074 2487+1413 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.13% <75.00%> (?)` | | | frontend-e2e-test | `68.06% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `75.00% <75.00%> (ø)` | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (ø)` | | | [api/internal/core/entity/interface.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2ludGVyZmFjZS5nbw==) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `56.00% <0.00%> (ø)` | | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `56.87% <0.00%> (ø)` | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `66.00% <0.00%> (ø)` | | |
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
codecov-commenter commented on pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254#issuecomment-997168332 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2254](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0b57a36) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ffa596d68b17b8a583ef641aeffb096b0b1428e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ffa596d) will **decrease** coverage by `18.98%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2254 +/- ## === - Coverage 68.12% 49.13% -18.99% === Files 127 41 -86 Lines3369 3165 -204 Branches 8290 -829 === - Hits 2295 1555 -740 - Misses 1074 1411 +337 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.13% <75.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2254?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `75.00% <75.00%> (ø)` | | | [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | | | | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | | | | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | | | | [.../src/pages/Route/components/Step1/ProxyRewrite.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1Byb3h5UmV3cml0ZS50c3g=) | | | | [web/src/components/HeaderDropdown/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0hlYWRlckRyb3Bkb3duL2luZGV4LnRzeA==) | | | | [web/src/pages/Upstream/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2254/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=) | | | |
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #2254: fix: authentication middleware is implemented by changing from framework droplet to framework gin
nic-chen opened a new pull request #2254: URL: https://github.com/apache/apisix-dashboard/pull/2254 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** authentication middleware is implemented by changing from framework droplet to framework gin **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
