[GitHub] [apisix] danielkocot commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy
danielkocot commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r775776978 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) -- [**Attributes**](#attributes) -- [**How To Enable**](#how-to-enable) -- [**Delete Plugin**](#delete-plugin) +- [Summary](#summary) Review comment: You're right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775782894 ## File path: ci/pod/opa/debug.rego ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +package debug Review comment: It will be better. changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] haoren22 commented on issue #262: Apache APISIX Container gets restarting when using Docker Compose
haoren22 commented on issue #262: URL: https://github.com/apache/apisix-docker/issues/262#issuecomment-1001935450 > OK, could we close this issue? 可以了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] The-White-Lion commented on a change in pull request #5934: feat: support to use path parameter with plugin's control api
The-White-Lion commented on a change in pull request #5934: URL: https://github.com/apache/apisix/pull/5934#discussion_r775790451 ## File path: docs/en/latest/control-api.md ## @@ -38,6 +38,9 @@ apisix: port: 9090 ``` +The control API server does not support parameter matching by default, if you want to enable parameter matching Review comment: > I update the documention about control-api.md and indicate the config will efficetive with plugin's control API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2267: feat: add plugin_metadata
codecov-commenter commented on pull request #2267: URL: https://github.com/apache/apisix-dashboard/pull/2267#issuecomment-1001951385 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2267](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8faf69) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/81474ef635f2664ee3451360e85d80623143dd63?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81474ef) will **decrease** coverage by `19.41%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2267 +/- ## === - Coverage 68.12% 48.70% -19.42% === Files 127 42 -85 Lines3369 3199 -170 Branches 8290 -829 === - Hits 2295 1558 -737 - Misses 1074 1442 +368 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `48.70% <0.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (ø)` | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (ø)` | | | [...nternal/handler/plugin\_metadata/plugin\_metadata.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX21ldGFkYXRhL3BsdWdpbl9tZXRhZGF0YS5nbw==) | `0.00% <0.00%> (ø)` | | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | | | | [...mponents/Upstream/components/active-check/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1R5cGUudHN4) | | | | [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | | | | [web/src/components/PanelSection/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BhbmVsU2VjdGlvbi9pbmRleC50c3g=) | | | | [...omponents/Upstream/components/ServiceD
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2267: feat: add plugin_metadata
codecov-commenter edited a comment on pull request #2267: URL: https://github.com/apache/apisix-dashboard/pull/2267#issuecomment-1001951385 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2267](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8faf69) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/81474ef635f2664ee3451360e85d80623143dd63?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81474ef) will **decrease** coverage by `6.68%`. > The diff coverage is `48.38%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2267 +/- ## == - Coverage 68.12% 61.43% -6.69% == Files 127 58 -69 Lines3369 3934 +565 Branches 8290 -829 == + Hits 2295 2417 +122 - Misses 1074 1232 +158 - Partials0 285 +285 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `36.65% <48.38%> (?)` | | | backend-unit-test | `48.70% <0.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `68.18% <ø> (ø)` | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `48.61% <33.33%> (ø)` | | | [...nternal/handler/plugin\_metadata/plugin\_metadata.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX21ldGFkYXRhL3BsdWdpbl9tZXRhZGF0YS5nbw==) | `52.38% <52.38%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `80.48% <100.00%> (ø)` | | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | | | | [...s/Upstream/components/active-check/Concurrency.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0NvbmN1cnJlbmN5LnRzeA==) | | | | [...pages/SSL/components/CertificateUploader/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWd
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2267: feat: add plugin_metadata
codecov-commenter edited a comment on pull request #2267: URL: https://github.com/apache/apisix-dashboard/pull/2267#issuecomment-1001951385 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2267](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8faf69) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/81474ef635f2664ee3451360e85d80623143dd63?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81474ef) will **increase** coverage by `2.87%`. > The diff coverage is `48.38%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2267 +/- ## == + Coverage 68.12% 70.99% +2.87% == Files 127 58 -69 Lines3369 3934 +565 Branches 8290 -829 == + Hits 2295 2793 +498 + Misses 1074 843 -231 - Partials0 298 +298 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `36.65% <48.38%> (?)` | | | backend-e2e-test-ginkgo | `59.40% <48.38%> (?)` | | | backend-unit-test | `48.70% <0.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `90.90% <ø> (ø)` | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `70.13% <33.33%> (ø)` | | | [...nternal/handler/plugin\_metadata/plugin\_metadata.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX21ldGFkYXRhL3BsdWdpbl9tZXRhZGF0YS5nbw==) | `52.38% <52.38%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.80% <100.00%> (ø)` | | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | | | | [...mponents/PluginFlow/components/FlowGraph/shapes.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29tcG9uZW50cy9GbG93R3JhcGgvc2hhcGVzLnRz) | | | | [web/src/pages/Dashboard/Dashboard.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo
[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
bzp2010 commented on a change in pull request #5874:
URL: https://github.com/apache/apisix/pull/5874#discussion_r775807818
##
File path: t/plugin/opa2.t
##
@@ -0,0 +1,206 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+
+if (!defined $block->request) {
+$block->set_value("request", "GET /t");
+}
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: setup all-in-one test
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/upstreams/u1',
+ngx.HTTP_PUT,
+[[{
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+return
+end
+ngx.say(body)
+
+local code, body = t('/apisix/admin/consumers',
+ngx.HTTP_PUT,
+[[{
+"username": "test",
+"plugins": {
+"key-auth": {
+"disable": false,
+"key": "test-key"
+}
+}
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
Review comment:
fixed, change to TDT and ngx.say(code..body)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775808663 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf, ctx, subsystem) -local request = build_http_request(conf, ctx) +local function build_http_route(conf, ctx, remove_upstream) +local route = core.table.clone(ctx.matched_route).value + +if remove_upstream and route and route.upstream then +route.upstream = nil +end + +return route +end + + +local function build_http_service(conf, ctx) +local service_id = ctx.service_id + +-- possible that the route is not bind a service +if service_id then +local service = core.table.clone(get_service(service_id)).value + +if service then +if service.upstream and service.upstream.parent then Review comment: changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2267: feat: add plugin_metadata
codecov-commenter edited a comment on pull request #2267: URL: https://github.com/apache/apisix-dashboard/pull/2267#issuecomment-1001951385 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2267](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8faf69) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/81474ef635f2664ee3451360e85d80623143dd63?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81474ef) will **increase** coverage by `1.55%`. > The diff coverage is `51.51%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2267 +/- ## == + Coverage 68.12% 69.67% +1.55% == Files 127 185 +58 Lines3369 7304+3935 Branches 829 829 == + Hits 2295 5089+2794 - Misses 1074 1917 +843 - Partials0 298 +298 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `36.65% <48.38%> (?)` | | | backend-e2e-test-ginkgo | `59.40% <48.38%> (?)` | | | backend-unit-test | `48.70% <0.00%> (?)` | | | frontend-e2e-test | `68.13% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `90.90% <ø> (ø)` | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `70.13% <33.33%> (ø)` | | | [...nternal/handler/plugin\_metadata/plugin\_metadata.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX21ldGFkYXRhL3BsdWdpbl9tZXRhZGF0YS5nbw==) | `52.38% <52.38%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `87.80% <100.00%> (ø)` | | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `70.52% <100.00%> (+0.17%)` | :arrow_up: | | [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | `53.03% <0.00%> (ø)` | | | [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2267/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
[GitHub] [apisix] tzssangglass commented on issue #5904: request help: Request help about prometheus plugin
tzssangglass commented on issue #5904: URL: https://github.com/apache/apisix/issues/5904#issuecomment-1001967157 > Using the prometheus plugin collect logs The prometheus plugin is not used to collect logs, it is used to collect metrics. > hen the log volume is large, the size of lua_shared_dict prometheus-metrics will become a bottleneck? I think you're talking about a large number of total requests, in this case you need to increase the storage space for prometheus-metrics, otherwise you will encounter an error similar to the following: `prometheus.lua:732: log_error(): Unexpected error adding a key: no memory while logging request`, refer to: https://github.com/apache/apisix/issues/3917 BTW, the prometheus plugin does affect performance by generating long-tail requests, which we are fixing. refer to: https://github.com/apache/apisix/issues/5755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2262: Apisix dashboard service's health check does not take effect
Baoyuantop commented on issue #2262: URL: https://github.com/apache/apisix-dashboard/issues/2262#issuecomment-1001968488 Hi @vickychen2022, thank you for reporting the bug! I would like to confirm if you have used the [Admin API](https://apisix.apache.org/docs/apisix/admin-api/) to create resources, and if you use the Admin API to create these resources would you have the same problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #3174: request help: prometheus not support filter by route
github-actions[bot] commented on issue #3174: URL: https://github.com/apache/apisix/issues/3174#issuecomment-1001979857 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #3237: feature request: public ECR repo on AWS
github-actions[bot] commented on issue #3237: URL: https://github.com/apache/apisix/issues/3237#issuecomment-1001979871 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #3257: How to smoothly upgrade from 2.1 to 2.2? 2.1 is deployed with RPM
github-actions[bot] commented on issue #3257: URL: https://github.com/apache/apisix/issues/3257#issuecomment-1001979902 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #3244: request help: How the nginx configured Location smoothly migrates to apisix
github-actions[bot] commented on issue #3244: URL: https://github.com/apache/apisix/issues/3244#issuecomment-1001979890 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hesh222 opened a new issue #5946: request help: K8S 无法部署apisix
hesh222 opened a new issue #5946: URL: https://github.com/apache/apisix/issues/5946 ### Issue description /usr/local/openresty/luajit/bin/luajit ./apisix/cli/apisix.lua init_etcd 2021/12/28 09:30:35 [emerg] 1#1: socket() [::]:9080 failed (97: Address family not supported by protocol) ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] starsz closed issue #262: Apache APISIX Container gets restarting when using Docker Compose
starsz closed issue #262: URL: https://github.com/apache/apisix-docker/issues/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] starsz commented on issue #258: Push apache/apisix-dashboard:2.10.0 to Dockerhub
starsz commented on issue #258: URL: https://github.com/apache/apisix-docker/issues/258#issuecomment-1001995639 Hi @AnoyiX. Recommend to use 2.10.1 instead. Refer: https://hub.docker.com/r/apache/apisix-dashboard/tags -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] AnoyiX closed issue #258: Push apache/apisix-dashboard:2.10.0 to Dockerhub
AnoyiX closed issue #258: URL: https://github.com/apache/apisix-docker/issues/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] AnoyiX commented on issue #258: Push apache/apisix-dashboard:2.10.0 to Dockerhub
AnoyiX commented on issue #258: URL: https://github.com/apache/apisix-docker/issues/258#issuecomment-1001996419 @starsz 👍🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance
tzssangglass commented on issue #5767:
URL: https://github.com/apache/apisix/issues/5767#issuecomment-1001998778
After checked, I found that this is a bug.
As I mentioned above, add the service configuration as follows
```
{
"name": "arch.test.nacos",
"upstream": {
"timeout": {
"connect": 6,
"send": 6,
"read": 6
},
"type": "roundrobin",
"scheme": "http",
"discovery_type": "nacos",
"pass_host": "pass",
"service_name": "service-provider",
"keepalive_pool": {
"idle_timeout": 60,
"requests": 1000,
"size": 320
}
}
}
```
add the upstream configuration as follows
```
{
"timeout": {
"connect": 6,
"send": 6,
"read": 6
},
"type": "roundrobin",
"scheme": "http",
"discovery_type": "nacos",
"pass_host": "pass",
"name": "arch.test.nacos",
"service_name": "service-provider",
"keepalive_pool": {
"idle_timeout": 60,
"requests": 1000,
"size": 320
}
}
```
We should note that the service itself does not have a `service_name`
attribute.
my error.log is
```
2021/12/28 18:10:29 [warn] 695#14133352: *20589 [lua] upstream.lua:251:
set_upstream(): new_nodes : { {
host = "192.168.2.43",
port = 8070,
weight = 1
}, {
host = "192.168.2.43",
port = 8070,
weight = 1
}, {
host = "192.168.2.43",
port = 8070,
weight = 1
} }, client: 127.0.0.1, server: _, request: "GET /echo/hello HTTP/1.1",
host: "127.0.0.1:9080"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance
tzssangglass commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1002018439 hi @xianshun163 would you like to submit a PR to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5940: feat: mocking plugin
shuaijinchao commented on a change in pull request #5940:
URL: https://github.com/apache/apisix/pull/5940#discussion_r775853230
##
File path: apisix/plugins/mocking.lua
##
@@ -0,0 +1,148 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local ngx = ngx
+local plugin_name = "mocking"
+
+local schema = {
+type = "object",
+properties = {
+response_schema = { type = "object" }
+},
+required = { "response_schema" }
+}
+
+local _M = {
+version = 0.1,
+priority = 9900,
+name = plugin_name,
+schema = schema,
+}
+
+function _M.check_schema(conf)
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return false, err
+end
+
+return true, nil
+end
+
+function _M.access(conf)
+local output = gen_object(conf.response_schema)
+ngx.header["Content-Type"] = "application/json"
Review comment:
Why must it be json? I think the configuration will be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5940: feat: mocking plugin
shuaijinchao commented on a change in pull request #5940:
URL: https://github.com/apache/apisix/pull/5940#discussion_r775853230
##
File path: apisix/plugins/mocking.lua
##
@@ -0,0 +1,148 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local ngx = ngx
+local plugin_name = "mocking"
+
+local schema = {
+type = "object",
+properties = {
+response_schema = { type = "object" }
+},
+required = { "response_schema" }
+}
+
+local _M = {
+version = 0.1,
+priority = 9900,
+name = plugin_name,
+schema = schema,
+}
+
+function _M.check_schema(conf)
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return false, err
+end
+
+return true, nil
+end
+
+function _M.access(conf)
+local output = gen_object(conf.response_schema)
+ngx.header["Content-Type"] = "application/json"
Review comment:
I think the Moking plugin should not only support JSON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on pull request #5940: feat: mocking plugin
shuaijinchao commented on pull request #5940: URL: https://github.com/apache/apisix/pull/5940#issuecomment-1002044382 hi, @Drery thanks for your contribution. Mock has many applications in front-end and back-end development and client troubleshooting scenarios. this is a good idea. However, I checked this PR. Its current completion rate is relatively low and only supports responses in a single data format.I think the simulation plug-in should support custom responses, custom data formats, custom headers, custom status codes, and custom timeouts to meet the basic simulation requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy
spacewander commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r775867440 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) -- [**Attributes**](#attributes) -- [**How To Enable**](#how-to-enable) -- [**Delete Plugin**](#delete-plugin) +- [Summary](#summary) Review comment: We don't need to change the summary in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5934: feat: support to use path parameter with plugin's control api
spacewander commented on a change in pull request #5934: URL: https://github.com/apache/apisix/pull/5934#discussion_r775867893 ## File path: docs/en/latest/control-api.md ## @@ -38,6 +38,9 @@ apisix: port: 9090 ``` +The control API server does not support parameter matching in plugin's control API by default, if you want to enable parameter matching Review comment: ```suggestion The control API server does not support parameter matching by default, if you want to enable parameter matching in plugin's control API ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #815: feat: refactor ApisixPluginConfig and add e2e cases
codecov-commenter edited a comment on pull request #815: URL: https://github.com/apache/apisix-ingress-controller/pull/815#issuecomment-1001920990 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#815](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e23bda8) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/819b00318e8cd9b6639913301fb89d2acb168926?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (819b003) will **decrease** coverage by `0.71%`. > The diff coverage is `24.47%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #815 +/- ## == - Coverage 32.55% 31.84% -0.72% == Files 68 70 +2 Lines7284 7726 +442 == + Hits 2371 2460 +89 - Misses 4643 4984 +341 - Partials 270 282 +12 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `61.36% <ø> (ø)` | | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `28.73% <0.00%> (-4.92%)` | :arrow_down: | | [pkg/ingress/apisix\_pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3BsdWdpbmNvbmZpZy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/compare.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29tcGFyZS5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.94% <0.00%> (-0.03%)` | :arrow_down: | | [pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `6.81% <0.00%> (-0.08%)` | :arrow_down: | | [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#
[GitHub] [apisix] tzssangglass commented on issue #5946: request help: K8S 无法部署apisix
tzssangglass commented on issue #5946: URL: https://github.com/apache/apisix/issues/5946#issuecomment-1002080077 you can try: https://github.com/apache/apisix-helm-chart and from the error.log, it seems that listen to ipv6 failed. pls provide version, configuration, and reproduction steps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] spacewander opened a new pull request #263: fix: rollback the docker image used in chaos test
spacewander opened a new pull request #263: URL: https://github.com/apache/apisix-docker/pull/263 The apisix-base version is not up-to-date. So we fail back to use OpenResty to let CI pass. See https://github.com/apache/apisix/pull/5943. TODO: use CI to provide a latest apisix-base image. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5938: docs: How to understand the internal working mechanism of apisix in depth
tzssangglass commented on issue #5938: URL: https://github.com/apache/apisix/issues/5938#issuecomment-1002092557 Yes, we have discussed the need for plugin development documentation, but no one has contributed yet, and I will do this if I have time. refer to: https://github.com/apache/apisix/discussions/5421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy
tzssangglass commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r775898746 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) -- [**Attributes**](#attributes) -- [**How To Enable**](#how-to-enable) -- [**Delete Plugin**](#delete-plugin) +- [Summary](#summary) +- [Name](#name) +- [Attributes](#attributes) +- [How To Enable](#how-to-enable) +- [Delete Plugin](#delete-plugin) Review comment: why we remove `**`? I see that all the plugin docs follows the original format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] alex8224 commented on issue #5938: docs: How to understand the internal working mechanism of apisix in depth
alex8224 commented on issue #5938: URL: https://github.com/apache/apisix/issues/5938#issuecomment-1002105876 @tzssangglass Thank you for your work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] alex8224 closed issue #5938: docs: How to understand the internal working mechanism of apisix in depth
alex8224 closed issue #5938: URL: https://github.com/apache/apisix/issues/5938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
tzssangglass commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775925697 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf, ctx, subsystem) -local request = build_http_request(conf, ctx) +local function build_http_route(conf, ctx, remove_upstream) +local route = core.table.clone(ctx.matched_route).value + +if remove_upstream and route and route.upstream then Review comment: what is `remove_upstream` used? I see that true is passed directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xianshun163 commented on issue #5767: bug: nacos.lua make some duplicate instance
xianshun163 commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1002126098 > > hi @xianshun163 would you like to submit a PR to fix it? OK, I will do it. If you have any official guidelines, can you send them to me? I haven't submitted them in GitHub. Or I'll find it myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775929570 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf, ctx, subsystem) -local request = build_http_request(conf, ctx) +local function build_http_route(conf, ctx, remove_upstream) +local route = core.table.clone(ctx.matched_route).value + +if remove_upstream and route and route.upstream then Review comment: Yes, it has been used to generate upstream data before, when it did not need to be removed. It is possible that it will be used again in the future, should I remove it now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775929570 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf, ctx, subsystem) -local request = build_http_request(conf, ctx) +local function build_http_route(conf, ctx, remove_upstream) +local route = core.table.clone(ctx.matched_route).value + +if remove_upstream and route and route.upstream then Review comment: Yes, it has been used to generate upstream data before, on that time, it did not need to remove. It is possible that it will be used again in the future, should I remove it now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5923: feat: support custom package, headers and body in openwhisk plugin
tzssangglass commented on a change in pull request #5923:
URL: https://github.com/apache/apisix/pull/5923#discussion_r775936726
##
File path: apisix/plugins/openwhisk.lua
##
@@ -104,8 +108,31 @@ function _M.access(conf, ctx)
return 503
end
+-- parse OpenWhisk JSON response
+-- OpenWhisk supports two types of responses, the user can return only
+-- the response body, or set the status code and header.
+local result, err = core.json.decode(res.body)
+
+if not result or err then
+core.log.error("failed to parse openwhisk response data: ", err)
+return 503
+end
+
-- setting response headers
-core.response.set_header(res.headers)
+if result.headers ~= nil then
+core.response.set_header(result.headers)
+end
+
+if result.statusCode ~= nil and result.body ~= nil then
Review comment:
we can use `local code = result.statusCode` and `local body =
result.body`, and then use `code` and `body`
##
File path: apisix/plugins/openwhisk.lua
##
@@ -104,8 +108,31 @@ function _M.access(conf, ctx)
return 503
end
+-- parse OpenWhisk JSON response
+-- OpenWhisk supports two types of responses, the user can return only
+-- the response body, or set the status code and header.
+local result, err = core.json.decode(res.body)
Review comment:
should check the `res.body` is not nil?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance
tzssangglass commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1002137600 here: https://apisix.apache.org/docs/general/contributor-guide/ If you have questions, you can call me in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775929570 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf, ctx, subsystem) -local request = build_http_request(conf, ctx) +local function build_http_route(conf, ctx, remove_upstream) +local route = core.table.clone(ctx.matched_route).value + +if remove_upstream and route and route.upstream then Review comment: @tzssangglass Yes, it has been used to generate upstream data before, on that time, it did not need to remove. It is possible that it will be used again in the future, should I remove it now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5727: feat: add CSRF plugin
tzssangglass commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r775945667 ## File path: docs/zh/latest/plugins/csrf.md ## @@ -0,0 +1,127 @@ +--- +title: csrf +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +- [**如何启用**](#如何启用) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) + +## 简介 + +`CSRF` 插件基于 `Double Submit Cookie` 的方式，保护您的 API 免于 CSRF 攻击。 + +## 属性 + +| Name | Type| Requirement | Default | Valid | Description | +| | --- | --- | --- | - | | +| name | string |false| `apisix_csrf_token` || 生成的 Cookie 中的 token 的名字，需要使用这个名字从 Cookie 中读取 | Review comment: `需要使用这个名字从 Cookie 中读取` is strange -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on issue #5942: request help: How to build APISIX-OpenResty when I have deploy apisix by the source code way
leslie-tsang commented on issue #5942: URL: https://github.com/apache/apisix/issues/5942#issuecomment-1002150477 @juzhiyuan Consider solved. Feel free to reopen it if need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #815: feat: refactor ApisixPluginConfig and add e2e cases
codecov-commenter edited a comment on pull request #815: URL: https://github.com/apache/apisix-ingress-controller/pull/815#issuecomment-1001920990 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#815](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e23bda8) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/819b00318e8cd9b6639913301fb89d2acb168926?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (819b003) will **decrease** coverage by `0.70%`. > The diff coverage is `24.47%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #815 +/- ## == - Coverage 32.55% 31.84% -0.71% == Files 68 71 +3 Lines7284 7727 +443 == + Hits 2371 2461 +90 - Misses 4643 4984 +341 - Partials 270 282 +12 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `61.36% <ø> (ø)` | | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `28.73% <0.00%> (-4.92%)` | :arrow_down: | | [pkg/ingress/apisix\_pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3BsdWdpbmNvbmZpZy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/compare.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29tcGFyZS5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.94% <0.00%> (-0.03%)` | :arrow_down: | | [pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `6.81% <0.00%> (-0.08%)` | :arrow_down: | | [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/815/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#
[GitHub] [apisix] tzssangglass opened a new pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of use resty.c…
tzssangglass opened a new pull request #5947: URL: https://github.com/apache/apisix/pull/5947 …ookie Signed-off-by: tzssangglass ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5727: feat: add CSRF plugin
tzssangglass commented on a change in pull request #5727:
URL: https://github.com/apache/apisix/pull/5727#discussion_r775946413
##
File path: apisix/plugins/csrf.lua
##
@@ -0,0 +1,170 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local resty_sha256 = require("resty.sha256")
+local ck = require("resty.cookie")
+local ngx = ngx
+local plugin_name = "csrf"
+local ngx_encode_base64 = ngx.encode_base64
+local ngx_decode_base64 = ngx.decode_base64
+local ngx_time = ngx.time
+local cookie_time = ngx.cookie_time
+local math = math
+
+local schema = {
+type = "object",
+properties = {
+key = {
+description = "use to generate csrf token",
+type = "string",
+},
+expires = {
+description = "expires time(s) for csrf token",
+type = "integer",
+default = 7200
+},
+name = {
+description = "the csrf token name",
+type = "string",
+default = "apisix_csrf_token"
+}
+},
+required = {"key"}
+}
+
+local _M = {
+version = 0.1,
+priority = 2980,
+name = plugin_name,
+schema = schema,
+}
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function gen_sign(random, expires, key)
+local sha256 = resty_sha256:new()
+
+local sign = {
+random = random,
+expires = expires,
+key = key,
+}
+
+sha256:update(core.json.encode(sign))
+local digest = sha256:final()
+
+return ngx_encode_base64(digest)
+end
+
+
+local function gen_csrf_token(conf)
+local random = math.random()
+local sign = gen_sign(random, conf.expires, conf.key)
+
+local token = {
+random = random,
+expires = conf.expires,
+sign = sign,
+}
+
+local cookie = ngx_encode_base64(core.json.encode(token))
+return cookie
+end
+
+
+local function check_csrf_token(conf, ctx, token)
+local _token = ngx_decode_base64(token)
+if _token == nil then
+core.log.error("csrf token is nil")
+return false
+end
+
+local _token_table, err = core.json.decode(_token)
+if err then
+core.log.error("decode token error: ", err)
+return false
+end
+
+local random = _token_table["random"]
+if not random then
+core.log.error("no random in token")
+return false
+end
+
+local expires = _token_table["expires"]
+if not expires then
+core.log.error("no expires in token")
+return false
+end
+
+local sign = gen_sign(random, expires, conf.key)
+if _token_table["sign"] ~= sign then
+return false
+end
+
+return true
+end
+
+
+function _M.access(conf, ctx)
+local method = core.request.get_method
Review comment:
`local method = core.request.get_method(ctx)` ?
##
File path: apisix/plugins/csrf.lua
##
@@ -0,0 +1,170 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local resty_sha256 = require("resty.sha256")
+local ck = require("resty.cookie")
+local ngx = ngx
+local plugin_name = "csrf"
+local ngx_encode_base64 = ngx.encode_base64
+local ngx_decode_base64 = ngx.decode_base64
+local ngx_time = ngx.time
+local cookie_time = ngx.cookie_time
+local math = math
+
+local schema = {
+type = "object",
+properties = {
+key = {
+
[GitHub] [apisix] danielkocot commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy
danielkocot commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r775958696 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) -- [**Attributes**](#attributes) -- [**How To Enable**](#how-to-enable) -- [**Delete Plugin**](#delete-plugin) +- [Summary](#summary) +- [Name](#name) +- [Attributes](#attributes) +- [How To Enable](#how-to-enable) +- [Delete Plugin](#delete-plugin) Review comment: A lot docs also don't use `**` any longer. So in my opinion it is a general question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5727: feat: add CSRF plugin
tzssangglass commented on a change in pull request #5727:
URL: https://github.com/apache/apisix/pull/5727#discussion_r775959656
##
File path: apisix/plugins/csrf.lua
##
@@ -0,0 +1,170 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local resty_sha256 = require("resty.sha256")
+local ck = require("resty.cookie")
+local ngx = ngx
+local plugin_name = "csrf"
+local ngx_encode_base64 = ngx.encode_base64
+local ngx_decode_base64 = ngx.decode_base64
+local ngx_time = ngx.time
+local cookie_time = ngx.cookie_time
+local math = math
+
+local schema = {
+type = "object",
+properties = {
+key = {
+description = "use to generate csrf token",
+type = "string",
+},
+expires = {
+description = "expires time(s) for csrf token",
+type = "integer",
+default = 7200
+},
+name = {
+description = "the csrf token name",
+type = "string",
+default = "apisix_csrf_token"
+}
+},
+required = {"key"}
+}
+
+local _M = {
+version = 0.1,
+priority = 2980,
+name = plugin_name,
+schema = schema,
+}
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function gen_sign(random, expires, key)
+local sha256 = resty_sha256:new()
+
+local sign = {
+random = random,
+expires = expires,
+key = key,
+}
+
+sha256:update(core.json.encode(sign))
+local digest = sha256:final()
+
+return ngx_encode_base64(digest)
+end
+
+
+local function gen_csrf_token(conf)
+local random = math.random()
+local sign = gen_sign(random, conf.expires, conf.key)
+
+local token = {
+random = random,
+expires = conf.expires,
+sign = sign,
+}
+
+local cookie = ngx_encode_base64(core.json.encode(token))
+return cookie
+end
+
+
+local function check_csrf_token(conf, ctx, token)
+local _token = ngx_decode_base64(token)
+if _token == nil then
+core.log.error("csrf token is nil")
+return false
+end
+
+local _token_table, err = core.json.decode(_token)
+if err then
+core.log.error("decode token error: ", err)
+return false
+end
+
+local random = _token_table["random"]
+if not random then
+core.log.error("no random in token")
+return false
+end
+
+local expires = _token_table["expires"]
+if not expires then
+core.log.error("no expires in token")
+return false
+end
+
+local sign = gen_sign(random, expires, conf.key)
+if _token_table["sign"] ~= sign then
+return false
+end
+
+return true
+end
+
+
+function _M.access(conf, ctx)
+local method = core.request.get_method
+if method == 'GET' then
+return
+end
+
+local token = core.request.header(ctx, conf.name)
+if not token then
+return 401, {error_msg = "no csrf token in request header"}
+end
+
+local cookie, err = ck:new()
+if not cookie then
+return nil, err
+end
+
+local field_cookie, err = cookie:get(conf.name)
+if not field_cookie then
+return 401, {error_msg = "no csrf cookie"}
+end
+
+if err then
+core.log.error(err)
+return 400, {error_msg = "read csrf cookie failed"}
+end
+
+if token ~= field_cookie then
+return 401, {error_msg = "csrf token mismatch"}
+end
+
+local result = check_csrf_token(conf, ctx, token)
+if not result then
+return 401, {error_msg = "Failed to verify the csrf token signature"}
+end
+end
+
+
+function _M.header_filter(conf, ctx)
+local csrf_token = gen_csrf_token(conf)
+core.response.add_header("Set-Cookie", {conf.name .. "=" .. csrf_token
+.. ";path=/;Expires="
+.. cookie_time(ngx_time() +
conf.expires)})
Review comment:
```suggestion
local cookie = conf.name .. "=" .. csrf_token .. ";path=/;Expires="
.. cookie_time(ngx_time() + conf.expires)
core.response.add_header("Set-Cooki
[GitHub] [apisix-dashboard] vickychen2022 commented on issue #2262: Apisix dashboard service's health check does not take effect
vickychen2022 commented on issue #2262: URL: https://github.com/apache/apisix-dashboard/issues/2262#issuecomment-1002159374 Hi @Baoyuantop , sorry for late reply! I haven't used admin api to create resources, I created the upstream and service by dashboard. Actually the bug is easy to reproduce: select "custom" in Select upstream and select “node" in upstream type, the health check configuration controls will be enabled to edit, and choose to turn on active health check, and you will find the issue occur. i haven't tried to create resource through admin api yet. will try later and update the result here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
tzssangglass commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775960928 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf, ctx, subsystem) -local request = build_http_request(conf, ctx) +local function build_http_route(conf, ctx, remove_upstream) +local route = core.table.clone(ctx.matched_route).value + +if remove_upstream and route and route.upstream then Review comment: ok, keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy
tzssangglass commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r775962466 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) -- [**Attributes**](#attributes) -- [**How To Enable**](#how-to-enable) -- [**Delete Plugin**](#delete-plugin) +- [Summary](#summary) +- [Name](#name) +- [Attributes](#attributes) +- [How To Enable](#how-to-enable) +- [Delete Plugin](#delete-plugin) Review comment: Maybe we should use the tool to make uniform changes. I think we can leave it as it is in this PR. 😁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan closed issue #5942: request help: How to build APISIX-OpenResty when I have deploy apisix by the source code way
juzhiyuan closed issue #5942: URL: https://github.com/apache/apisix/issues/5942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5942: request help: How to build APISIX-OpenResty when I have deploy apisix by the source code way
juzhiyuan commented on issue #5942: URL: https://github.com/apache/apisix/issues/5942#issuecomment-1002347452 ok, I'm going to close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy
juzhiyuan commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r776118185 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) -- [**Attributes**](#attributes) -- [**How To Enable**](#how-to-enable) -- [**Delete Plugin**](#delete-plugin) +- [Summary](#summary) +- [Name](#name) +- [Attributes](#attributes) +- [How To Enable](#how-to-enable) +- [Delete Plugin](#delete-plugin) Review comment: agree to @tzssangglass, and @danielkocot Daniel, if not necessary, we'd better keep the Top of Contents and only change doc contents 😄 if the ToC needs to be updated, we'd better update other plugins' docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
juzhiyuan commented on pull request #5874: URL: https://github.com/apache/apisix/pull/5874#issuecomment-1002350048 cc @Baoyuantop to have a review 🙈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie
tokers commented on pull request #5947: URL: https://github.com/apache/apisix/pull/5947#issuecomment-1002350164 @tzssangglass Could you describe the reason for this or add the corresponding issue link? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5767: bug: nacos.lua make some duplicate instance
juzhiyuan commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1002350865 @xianshun163 kindly let us know if you encounter problems when submitting PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5938: docs: How to understand the internal working mechanism of apisix in depth
juzhiyuan commented on issue #5938: URL: https://github.com/apache/apisix/issues/5938#issuecomment-1002351313 Maybe we could keep this issue open to tracking this improvement? @alex8224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5941: feat: support registering custom variable
juzhiyuan commented on pull request #5941: URL: https://github.com/apache/apisix/pull/5941#issuecomment-1002351478 Hi @leslie-tsang, could you please have a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3237: feature request: public ECR repo on AWS
juzhiyuan commented on issue #3237: URL: https://github.com/apache/apisix/issues/3237#issuecomment-1002352504 Hi @spacewander, do we need to support the ECR repo as Pahud suggests? 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie
tzssangglass commented on pull request #5947: URL: https://github.com/apache/apisix/pull/5947#issuecomment-1002354410 > @tzssangglass Could you describe the reason for this or add the corresponding issue link? ok, inspired by review this PR is the comments seen: https://github.com/apache/apisix/pull/5727#discussion_r774275326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass edited a comment on pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie
tzssangglass edited a comment on pull request #5947: URL: https://github.com/apache/apisix/pull/5947#issuecomment-1002354410 > @tzssangglass Could you describe the reason for this or add the corresponding issue link? ok, inspired by review this PR is the comments seen: https://github.com/apache/apisix/pull/5727#discussion_r774275326 It is recommended to use `ctx.var.cookie_*` in the plugin to get cookies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5941: feat: support registering custom variable
leslie-tsang commented on a change in pull request #5941: URL: https://github.com/apache/apisix/pull/5941#discussion_r776125463 ## File path: apisix/core/ctx.lua ## @@ -215,11 +215,18 @@ do key = sub_str(key, 9) val = get_parsed_graphql()[key] -elseif apisix_var_names[key] then -val = ngx.ctx.api_ctx and ngx.ctx.api_ctx[key] - else -val = get_var(key, t._request) +local getter = apisix_var_names[key] +if getter then +if getter == true then +val = ngx.ctx.api_ctx and ngx.ctx.api_ctx[key] +else +val = getter(ngx.ctx.api_ctx) Review comment: Maybe we should add a comment here, to notify developer where the `getter` from ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie
tokers commented on a change in pull request #5947:
URL: https://github.com/apache/apisix/pull/5947#discussion_r776125596
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -344,8 +341,8 @@ end
function _M.rewrite(conf, ctx)
local jwt_token, err = fetch_jwt_token(ctx)
if not jwt_token then
-if err and err:sub(1, #"no cookie") ~= "no cookie" then
-core.log.error("failed to fetch JWT token: ", err)
+if err then
Review comment:
Do we still need this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie
leslie-tsang commented on a change in pull request #5947:
URL: https://github.com/apache/apisix/pull/5947#discussion_r776126818
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -344,8 +341,8 @@ end
function _M.rewrite(conf, ctx)
local jwt_token, err = fetch_jwt_token(ctx)
if not jwt_token then
-if err and err:sub(1, #"no cookie") ~= "no cookie" then
-core.log.error("failed to fetch JWT token: ", err)
+if err then
Review comment:
Seems we don't need to check `err` as func `fetch_jwt_token` doesn't
return it any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] foreveryang321 opened a new issue #2268: Configure response-rewrite using Apisix Dashboard does not take effect.
foreveryang321 opened a new issue #2268:
URL: https://github.com/apache/apisix-dashboard/issues/2268
### Issue description
Configure `response-rewrite` using `Apisix Dashboard` does not take effect.
### Expected behavior
the response header is `Server: xx/x`, not `Server: APISIX/2.11.0`
```shell
yl-mac:apisix yl$ curl http://127.0.0.1 -v -H 'User-Agent: baidu-bot'
* Trying 127.0.0.1...
* TCP_NODELAY set
* Connected to 127.0.0.1 (127.0.0.1) port 80 (#0)
> GET / HTTP/1.1
> Host: 127.0.0.1
> Accept: */*
> User-Agent: baidu-bot
>
< HTTP/1.1 403 Forbidden
< Date: Wed, 29 Dec 2021 01:44:15 GMT
< Content-Type: text/plain; charset=utf-8
< Transfer-Encoding: chunked
< Connection: keep-alive
< Server: APISIX/2.11.0
<
{"message":"Not allowed"}
```
### How to Reproduce
ignore
### Screenshots
> Configure `response-rewrite` using `Apisix Dashboard`
- Routing Mode
- Global Mode
> apisix/conf/config.yaml
### Environment
- apisix version (cmd: `apisix version`): apache/apisix:2.11.0-alpine
- OS (cmd: `uname -a`): Mac OS X 10.15.7
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
nginx version: openresty/1.19.3.2
built by gcc 9.3.0 (Alpine 9.3.0)
built with OpenSSL 1.1.1g 21 Apr 2020
- etcd version, if have (cmd: run `etcd --version`): etcd Version: 3.5.0
- apisix-dashboard version, if have: apache/apisix-dashboard:2.10.1-alpine
- Browser version, if have: Chrome/96
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5901: request help: How to add ext-plugin in config.yaml ,since apisix installed by helm
juzhiyuan commented on issue #5901: URL: https://github.com/apache/apisix/issues/5901#issuecomment-1002362286 > Oops. If I am correct, our helm chart doesn't expose the ext-plugin field, we may enhance the helm chart. Hi @tokers, do we need to set this as Good first issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan edited a comment on issue #5901: request help: How to add ext-plugin in config.yaml ,since apisix installed by helm
juzhiyuan edited a comment on issue #5901: URL: https://github.com/apache/apisix/issues/5901#issuecomment-1002362286 > Oops. If I am correct, our helm chart doesn't expose the ext-plugin field, we may enhance the helm chart. Hi @tokers, do we need to set this as Good first issue or enhancement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2262: Apisix dashboard service's health check does not take effect
Baoyuantop commented on issue #2262: URL: https://github.com/apache/apisix-dashboard/issues/2262#issuecomment-1002362705 OK, I'll try to reproduce it locally and look forward to your results after using the Admin API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (eb8362c -> e9cea44)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from eb8362c docs: improved `plugin-develop` doc (#5933) add e9cea44 feat: support to use path parameter with plugin's control api (#5934) No new revisions were added by this update. Summary of changes: apisix/control/router.lua | 15 ++- docs/en/latest/control-api.md | 3 +++ docs/zh/latest/control-api.md | 2 ++ 3 files changed, 19 insertions(+), 1 deletion(-)
[GitHub] [apisix] spacewander merged pull request #5934: feat: support to use path parameter with plugin's control api
spacewander merged pull request #5934: URL: https://github.com/apache/apisix/pull/5934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5882: feat: support to use path parameter with plugin's control api
spacewander closed issue #5882: URL: https://github.com/apache/apisix/issues/5882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?
juzhiyuan commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002363080 Hi @jagerzhang, AFAIK, you could follow this step to configure kafka-logger plugin: 1. (optional) `PUT /plugin_metedata` to use your custom `log_format` configuration for that plugin; 2. `PUT /routes` with `kafka-logger` configuration. plugin_metedata is more like a General configuration, and it will work for all `kafka-logger` plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5915: request help: logger plugins supports limit size of request/response body
juzhiyuan commented on issue #5915: URL: https://github.com/apache/apisix/issues/5915#issuecomment-1002363371 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie
tzssangglass commented on a change in pull request #5947:
URL: https://github.com/apache/apisix/pull/5947#discussion_r776128336
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -344,8 +341,8 @@ end
function _M.rewrite(conf, ctx)
local jwt_token, err = fetch_jwt_token(ctx)
if not jwt_token then
-if err and err:sub(1, #"no cookie") ~= "no cookie" then
-core.log.error("failed to fetch JWT token: ", err)
+if err then
Review comment:
`fetch_jwt_token` would return `"JWT not found in cookie"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] jagerzhang commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?
jagerzhang commented on issue #5910:
URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002364234
> Hi @jagerzhang, AFAIK, you could follow this step to configure
kafka-logger plugin:
>
> 1. (optional) `PUT /plugin_metedata` to use your custom `log_format`
configuration for that plugin;
> 2. `PUT /routes` with `kafka-logger` configuration.
>
> plugin_metedata is more like a General configuration, and it will work for
all `kafka-logger` plugin.
感谢回复，这个方法我知道了哈，但是有另外一个疑问，因为如果按照这个方法来定义log_format，那么日志格式就完全按照定义的log_format来生成了，这里是一个覆盖模式，希望支持下增量模式，即我定义的字段只是append到默认的日志里面而不是直接覆盖。
比如 log_format 我定义为 `{"upstream_latency":
$upstream_latency}`，那么最终日志格式希望是在默认日志的基础上，**增加**这个字段。
不知道我这样描述清楚了么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] jagerzhang edited a comment on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?
jagerzhang edited a comment on issue #5910:
URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002364234
> Hi @jagerzhang, AFAIK, you could follow this step to configure
kafka-logger plugin:
>
> 1. (optional) `PUT /plugin_metedata` to use your custom `log_format`
configuration for that plugin;
> 2. `PUT /routes` with `kafka-logger` configuration.
>
> plugin_metedata is more like a General configuration, and it will work for
all `kafka-logger` plugin.
@juzhiyuan
感谢回复，这个方法我知道了哈，但是有另外一个疑问，因为如果按照这个方法来定义log_format，那么日志格式就完全按照定义的log_format来生成了，这里是一个覆盖模式，希望支持下增量模式，即我定义的字段只是append到默认的日志里面而不是直接覆盖。
比如 log_format 我定义为 `{"upstream_latency":
$upstream_latency}`，那么最终日志格式希望是在默认日志的基础上，**增加**这个字段。
不知道我这样描述清楚了么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie
tzssangglass commented on a change in pull request #5947:
URL: https://github.com/apache/apisix/pull/5947#discussion_r776128652
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -344,8 +341,8 @@ end
function _M.rewrite(conf, ctx)
local jwt_token, err = fetch_jwt_token(ctx)
if not jwt_token then
-if err and err:sub(1, #"no cookie") ~= "no cookie" then
-core.log.error("failed to fetch JWT token: ", err)
+if err then
Review comment:
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5573: docs: dont found the usage of etcd in discovery.md
juzhiyuan commented on issue #5573: URL: https://github.com/apache/apisix/issues/5573#issuecomment-1002364849 Just have a discussion with @bzp2010, we don't support ETCD as Service Discovery yet 🤔 @leslie-tsang could you please have a confirmation? 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #5948: docs: avoid newline in the middle of Chinese sentences
spacewander opened a new pull request #5948: URL: https://github.com/apache/apisix/pull/5948 Fix #5842 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] spacewander merged pull request #263: fix: rollback the docker image used in chaos test
spacewander merged pull request #263: URL: https://github.com/apache/apisix-docker/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch master updated: fix: rollback the docker image used in chaos test (#263)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new 5d3c4c6 fix: rollback the docker image used in chaos test (#263) 5d3c4c6 is described below commit 5d3c4c63d21f0c40655d005fdb9cb3746f2e4af3 Author: 罗泽轩 AuthorDate: Wed Dec 29 10:25:23 2021 +0800 fix: rollback the docker image used in chaos test (#263) --- alpine-local/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/alpine-local/Dockerfile b/alpine-local/Dockerfile index f6ea788..1fcf46c 100644 --- a/alpine-local/Dockerfile +++ b/alpine-local/Dockerfile @@ -1,6 +1,6 @@ ARG ENABLE_PROXY=false -FROM api7/apisix-base:1.19.3.2.2 AS production-stage +FROM openresty/openresty:1.19.3.2-alpine-fat AS production-stage ARG ENABLE_PROXY ARG APISIX_PATH
[GitHub] [apisix-dashboard] mangoGoForward opened a new pull request #2269: feat: show route id in list and edit views.
mangoGoForward opened a new pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269 Signed-off-by: mango Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Display route id at route list and edit views. **Related issues** fix/resolve #1595 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?
juzhiyuan commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002366148 Yes, it's clearly now :) (Just like PATCH and PUT methods 😄) I found the default configuration here, see https://github.com/apache/apisix/blob/master/apisix/utils/log-util.lua#L35-L38 As for if we could support "PATCH" log_format, need @tzssangglass's confirmation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat: show route id in list and edit views.
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002366410 Please have a look. @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new issue #816: bug: namespace update event will be retried unconditionally even if it was deleted
tokers opened a new issue #816:
URL: https://github.com/apache/apisix-ingress-controller/issues/816
### Issue description
Namespace events will be retried endlessly even if it's expired, for
instance, an update event should be mark as expired if a new delete event is
handled.
```
2021-12-29T10:12:04+08:00 warningress/namespace.go:121sync
namespace info failed, will retry {"namespace": "cp-387818008396956540",
"error": "namespaces \"cp-387818008396956540\" not found"}
2021-12-29T10:12:04+08:00 warningress/namespace.go:121sync
namespace info failed, will retry {"namespace": "cp-387634093115835119",
"error": "namespaces \"cp-387634093115835119\" not found"}
```
### Environment
- your apisix-ingress-controller version (output of
apisix-ingress-controller version --long):
```
2021-12-29T10:14:35+08:00 infoingress/ingress.go:114 version:
Version: 1.3.0
Git SHA: no-git-module
Go Version: go1.13.8
Building OS/Arch: linux/amd64
Running OS/Arch: linux/amd64
```
- your Kubernetes cluster version (output of kubectl version):
```
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.5",
GitCommit:"6b1d87acf3c8253c123756b9e61dac642678305f", GitTreeState:"archive",
BuildDate:"2021-03-30T00:00:00Z", GoVersion:"go1.16", Compiler:"gc",
Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21+",
GitVersion:"v1.21.2-eks-06eac09",
GitCommit:"5f6d83fe4cb7febb5f4f4e39b3b2b64ebbbe3e97", GitTreeState:"clean",
BuildDate:"2021-09-13T14:20:15Z", GoVersion:"go1.16.5", Compiler:"gc",
Platform:"linux/amd64"}
```
- if you run apisix-ingress-controller in Bare-metal environment, also show
your OS version (uname -a):
### Minimal test code / Steps to reproduce
Nope.
### Actual result
Stale events should be ignored.
### Error log
2021-12-29T10:12:04+08:00 warningress/namespace.go:121sync
namespace info failed, will retry {"namespace": "cp-387818008396956540",
"error": "namespaces \"cp-387818008396956540\" not found"}
2021-12-29T10:12:04+08:00 warningress/namespace.go:121sync
namespace info failed, will retry {"namespace": "cp-387634093115835119",
"error": "namespaces \"cp-387634093115835119\" not found"}
### Expected result
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2268: Configure response-rewrite using Apisix Dashboard does not take effect.
juzhiyuan commented on issue #2268: URL: https://github.com/apache/apisix-dashboard/issues/2268#issuecomment-1002366605 cc @Baoyuantop to have a check 🙈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2269: feat: show route id in list and edit views.
juzhiyuan commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002366881 also cc @guoqqqi to have a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jagerzhang commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?
jagerzhang commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002367080 > Yes, it's clearly now :) (Just like PATCH and PUT methods 😄) > > I found the default configuration here, see https://github.com/apache/apisix/blob/master/apisix/utils/log-util.lua#L35-L38 > > As for if we could support "PATCH" log_format, need @tzssangglass's confirmation. Fantastic, looking forward to support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
mangoGoForward commented on issue #1595: URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-1002367848 > Oh btw, we have a meeting today, welcome to join in if you have time 😄 see [apache/apisix#5721](https://github.com/apache/apisix/discussions/5721) So regretful missing the meeting, I was delayed by other things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5941: feat: support registering custom variable
spacewander commented on a change in pull request #5941: URL: https://github.com/apache/apisix/pull/5941#discussion_r776131295 ## File path: apisix/core/ctx.lua ## @@ -215,11 +215,18 @@ do key = sub_str(key, 9) val = get_parsed_graphql()[key] -elseif apisix_var_names[key] then -val = ngx.ctx.api_ctx and ngx.ctx.api_ctx[key] - else -val = get_var(key, t._request) +local getter = apisix_var_names[key] +if getter then +if getter == true then +val = ngx.ctx.api_ctx and ngx.ctx.api_ctx[key] +else +val = getter(ngx.ctx.api_ctx) Review comment: @leslie-tsang Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2269: feat: show route id in list and edit views.
zaunist commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002368922 Hi，@mangoGoForward. Can you take some screenshoot for this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat: show route id in list and edit views.
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002369228 > just add the test cases as @juzhiyuan said, thanks @mangoGoForward Ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat: show route id in list and edit views.
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002369416 > Hi @mangoGoForward, those changes LGTM, could you please add some test cases for this PR? Thanks for your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin
spacewander commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r776132041 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf, ctx, subsystem) -local request = build_http_request(conf, ctx) +local function build_http_route(conf, ctx, remove_upstream) +local route = core.table.clone(ctx.matched_route).value + +if remove_upstream and route and route.upstream then +route.upstream = nil +end + +return route +end + + +local function build_http_service(conf, ctx) +local service_id = ctx.service_id + +-- possible that the route is not bind a service +if service_id then +local service = core.table.clone(get_service(service_id)).value + +if service then +if service.upstream then +service.upstream = nil +end +return service +end +end + +return nil +end + +local function build_http_consumer(conf, ctx) +-- possible that the route is not relative consumer Review comment: ```suggestion -- possible that there is no consumer bound to the route ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2269: feat: show route id in list and edit views.
guoqqqi commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002369992 LGTM, Hi @mangoGoForward, as we don't have a preview environment at the moment, it would be nice if we could post a picture up ~ If you have any questions about the test and need help. just @ me～ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat: show route id in list and edit views.
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002371228 The screenshot like below: List page  Edit page  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2268: Configure response-rewrite using Apisix Dashboard does not take effect.
zaunist commented on issue #2268:
URL:
https://github.com/apache/apisix-dashboard/issues/2268#issuecomment-1002371706
Hi, @foreveryang321. If you want rewrite `header`, you need configure
`response-rewrite` like this:
```
"headers": {
"Server": "baidu",
}
```
I can give you a example configuration:
```
{
"body": "{\"code\":\"ok\",\"message\":\"new json body\"}",
"disable": false,
"headers": {
"Server": "baidu",
"X-Server-id": 3,
"X-Server-status": "on"
}
}
```
test response header:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2269: feat: show route id in list and edit views.
zaunist commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002372404 /LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
