[GitHub] [apisix] zlhgo commented on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


zlhgo commented on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022941369


   attempt to index local 'up_conf' (a nil value) 相关错误日志。
   
   ```
   2022/01/27 04:11:34 [info] 36#36: *144813 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: true, client: 117.136.86.244, server: _, 
request: "POST 
/api/14/store/?sentry_key=c95cef49d5e44f5c989f45f2b862f7fa_version=7 
HTTP/2.0", host: "sentry.ky.cn", referrer: "https://h5.ky.cn/;
   2022/01/27 04:11:34 [info] 36#36: *144813 [lua] radixtree.lua:488: 
compare_param(): pcre pat: \/api\/1*, client: 117.136.86.244, server: _, 
request: "POST 
/api/14/store/?sentry_key=c95cef49d5e44f5c989f45f2b862f7fa_version=7 
HTTP/2.0", host: "sentry.ky.cn", referrer: "https://h5.ky.cn/;
   2022/01/27 04:11:34 [info] 36#36: *144813 [lua] init.lua:398: 
http_access_phase(): matched route: 
{"prev_plugin_config_ver":328214,"orig_plugins":{"ky-traffic-control":{"ab":{"key":"monitoring_sentry_relay","split_type":"distinct_id","enable":false},"header":{"enable":false},"upstreams":{}}},"update_count":1,"createdIndex":1669,"key":"\/apisix\/prod-1\/routes\/dc0b6538","clean_handlers":{},"has_domain":false,"orig_modifiedIndex":328215,"modifiedIndex":"328215#1","value":{"update_time":1643244706,"upstream_id":"733aa9ed","status":1,"create_time":1639561609,"uris":["\/api\/store*","\/api\/1*","\/api\/2*","\/api\/3*","\/api\/4*","\/api\/5*","\/api\/6*","\/api\/7*","\/api\/8*","\/api\/9*"],"plugin_config_id":"a45e88d1","id":"dc0b6538","plugins":{"ky-traffic-control":{"ab":{"key":"monitoring_sentry_relay","split_type":"distinct_id","enable":false},"header":{"enable":false},"upstreams":{}}},"labels":{"managed-by":"apisix-ingress-controller"},"desc":"Created
 by apisix-ingress-controller,
  DO NOT modify it 
manually","priority":0,"name":"sentry_sentry-14_relay","hosts":["sentry.ky.cn"]}},
 client: 117.136.86.244, server: _, request: "POST 
/api/14/store/?sentry_key=c95cef49d5e44f5c989f45f2b862f7fa_version=7 
HTTP/2.0", host: "sentry.ky.cn", referrer: "https://h5.ky.cn/;
   2022/01/27 04:11:34 [info] 36#36: *144813 [lua] init.lua:305: 
get_upstream_by_id(): parsed upstream: 
{"key":"\/apisix\/prod-1\/upstreams\/733aa9ed","clean_handlers":{},"has_domain":false,"modifiedIndex":328241,"createdIndex":1668,"value":{"labels":{"managed-by":"apisix-ingress-controller"},"nodes_ref":[{"weight":100,"priority":0,"port":3000,"host":"172.16.108.163"},{"weight":100,"priority":0,"port":3000,"host":"172.16.87.161"}],"nodes":"table:
 
0x7f61c85fac88","create_time":1639561609,"update_time":1643244709,"type":"roundrobin","original_nodes":"table:
 0x7f61c85fac88","desc":"Created by apisix-ingress-controller, DO NOT modify it 
manually","id":"733aa9ed","pass_host":"pass","timeout":{"connect":5,"read":20,"send":20},"hash_on":"vars","parent":{"key":"\/apisix\/prod-1\/upstreams\/733aa9ed","clean_handlers":"table:
 
0x7f61b0807b50","has_domain":false,"modifiedIndex":328241,"createdIndex":1668,"value":"table:
 0x7f61c85fabb8"},"name":"sentry_stable-sentry-relay_3000","scheme":"http"}},
  client: 117.136.86.244, server: _, request: "POST 
/api/14/store/?sentry_key=c95cef49d5e44f5c989f45f2b862f7fa_version=7 
HTTP/2.0", host: "sentry.ky.cn", referrer: "https://h5.ky.cn/;
   2022/01/27 04:11:34 [info] 36#36: *144813 [lua] balancer.lua:183: 
pick_server(): route: 
{"prev_plugin_config_ver":328214,"orig_plugins":{"ky-traffic-control":{"ab":{"key":"monitoring_sentry_relay","split_type":"distinct_id","enable":false},"header":{"enable":false},"upstreams":{}}},"update_count":1,"createdIndex":1669,"key":"\/apisix\/prod-1\/routes\/dc0b6538","clean_handlers":{},"has_domain":false,"orig_modifiedIndex":328215,"modifiedIndex":"328215#1","value":{"update_time":1643244706,"upstream_id":"733aa9ed","status":1,"create_time":1639561609,"uris":["\/api\/store*","\/api\/1*","\/api\/2*","\/api\/3*","\/api\/4*","\/api\/5*","\/api\/6*","\/api\/7*","\/api\/8*","\/api\/9*"],"plugin_config_id":"a45e88d1","id":"dc0b6538","plugins":{"ky-traffic-control":{"ab":{"key":"monitoring_sentry_relay","split_type":"distinct_id","enable":false},"header":{"enable":false},"upstreams":{}}},"labels":{"managed-by":"apisix-ingress-controller"},"desc":"Created
 by apisix-ingress-controller, DO NOT mo
 dify it 
manually","priority":0,"name":"sentry_sentry-14_relay","hosts":["sentry.ky.cn"]}},
 client: 117.136.86.244, server: _, request: "POST 
/api/14/store/?sentry_key=c95cef49d5e44f5c989f45f2b862f7fa_version=7 
HTTP/2.0", host: "sentry.ky.cn", referrer: "https://h5.ky.cn/;
   2022/01/27 04:11:34 [info] 36#36: *144813 [lua] balancer.lua:184: 
pick_server(): ctx: 

[GitHub] [apisix] spacewander commented on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


spacewander commented on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022939813


   > 现在我已经关闭了我自定义的分流插件
   
   Hi, can it be reproduced with a fresh APISIX? (without any additional code)
   
   Maybe we can add more log when `up_conf` is accessed, like logging the 
`tostring(up_conf)` with the route id and upstream id.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


shuaijinchao commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793338641



##
File path: apisix/cli/file.lua
##
@@ -52,6 +58,32 @@ local function tab_is_array(t)
 end
 
 
+local function generate_random_str(len)
+local rand_str = ""
+local rand_num = 0
+
+-- set random seed
+randomseed(tostring(os_time()):reverse():sub(1, 5))

Review comment:
   I got it, thanks for the pointers.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao edited a comment on pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


shuaijinchao edited a comment on pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#issuecomment-1022925095


   hi @moonming , Regarding setting the admin token to remove, I think it would 
be more flexible to replace with an environment variable. Users can modify the 
admin token through system environment variables. If the environment variable 
is not read. At this point, APISIX will generate a random token for it and 
prompt it on standard output and logs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


moonming commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793332466



##
File path: apisix/cli/file.lua
##
@@ -52,6 +58,32 @@ local function tab_is_array(t)
 end
 
 
+local function generate_random_str(len)
+local rand_str = ""
+local rand_num = 0
+
+-- set random seed
+randomseed(tostring(os_time()):reverse():sub(1, 5))

Review comment:
   I means you can make random seed of CLI in 
https://github.com/apache/apisix/blob/master/apisix/cli/ops.lua#L149




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on issue #5755: [DISCUSS]: Improving the performance of the prometheus plugin

2022-01-26 Thread GitBox


moonming commented on issue #5755:
URL: https://github.com/apache/apisix/issues/5755#issuecomment-1022932291


   @tzssangglass https://github.com/knyar/nginx-lua-prometheus/pull/131 merged, 
so any update for this issue? thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


shuaijinchao commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793329918



##
File path: apisix/cli/file.lua
##
@@ -52,6 +58,32 @@ local function tab_is_array(t)
 end
 
 
+local function generate_random_str(len)
+local rand_str = ""
+local rand_num = 0
+
+-- set random seed
+randomseed(tostring(os_time()):reverse():sub(1, 5))

Review comment:
   APISIX and CLI are two completely separate programs. There is no sharing 
between them. APISIX runs on OpenResty and the CLI runs on luajit or native lua.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zlhgo edited a comment on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


zlhgo edited a comment on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022925843


   @tzssangglass 你好。
   ky-traffic-control 这个插件我已经在中午12点以前已经禁用了,所以应该和我的插件没有关系吧?
   这段日志是12点以后的。我通过日志分析发现可能请求了错误的后端和`attempt to index local 'up_conf' (a nil 
value)`应该没有直接的关系。 因为我发现日志里记录的请求了错误的后端早于`attempt to index local 'up_conf' (a nil 
value)`之前发生。谢谢。
   
   请稍等我提供 `attempt to index local 'up_conf' (a nil value)` 相关的日志。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zlhgo edited a comment on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


zlhgo edited a comment on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022925843


   @tzssangglass 你好。
   ~~ky-traffic-control 这个插件我已经在中午12点以前已经禁用了,所以应该和我的插件没有关系吧?
   这段日志是12点以后的。我通过日志分析发现可能请求了错误的后端和`attempt to index local 'up_conf' (a nil 
value)`应该没有直接的关系。 因为我发现日志里记录的请求了错误的后端早于`attempt to index local 'up_conf' (a nil 
value)`之前发生。谢谢。~~
   
   请稍等我提供 `attempt to index local 'up_conf' (a nil value)` 相关的日志。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zlhgo commented on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


zlhgo commented on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022925843


   @tzssangglass 你好。
   ky-traffic-control 这个插件我已经在中午12点以前已经禁用了,所以应该和我的插件没有关系吧?
   这段日志是12点以后的。我通过日志分析发现可能请求了错误的后端和`attempt to index local 'up_conf' (a nil 
value)`应该没有直接的关系。 因为我发现日志里记录的请求了错误的后端早于`attempt to index local 'up_conf' (a nil 
value)`之前发生。谢谢。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass edited a comment on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


tzssangglass edited a comment on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022922914


   ~From your logs, you have a plugin `ky-traffic-control`, maybe imitating 
`traffic-split`, you need to know that `traffic-split` plugin would to 
rewriting `upstream_conf`.~
   
   here: 
https://github.com/apache/apisix/blob/427e9269efe32836051bf280ea2af4a566730ae4/apisix/plugins/traffic-split.lua#L196
   
   Let's ignore the ip issue for a moment.
   
   Just from the information you have provided so far
   
   1. this error occurred during the balancer phase retry.
   ~2. This error is probably related to `*-traffic-control` modifying 
upstream_conf.~
   
   From the information you've provided so far, I still can't reproduce it. As 
already mentioned above, I need to be able to reproduce this issue in order to 
troubleshoot this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


shuaijinchao commented on pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#issuecomment-1022925095


   hi @moonming , Regarding setting the admin token to remove 
https://github.com/apache/apisix/pull/6214#discussion_r793302104, I think it 
would be more flexible to replace with an environment variable. Users can 
modify the admin token through system environment variables. If the environment 
variable is not read. At this point, APISIX will generate a random token for it 
and prompt it on standard output and logs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


tzssangglass commented on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022922914


   From your logs, you have a plugin `ky-traffic-control`, maybe imitating 
`traffic-control`, you need to know that `traffic-control` plugin is rewriting 
`upstream_conf`.
   
   here: 
https://github.com/apache/apisix/blob/427e9269efe32836051bf280ea2af4a566730ae4/apisix/plugins/traffic-split.lua#L196
   
   Let's ignore the ip issue for a moment.
   
   Just from the information you have provided so far
   
   1. this error occurred during the balancer phase retry.
   2. This error is probably related to `*-traffic-control` modifying 
upstream_conf.
   
   From the information you've provided so far, I still can't reproduce it. As 
already mentioned above, I need to be able to reproduce this issue in order to 
troubleshoot this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass edited a comment on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


tzssangglass edited a comment on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022922914


   From your logs, you have a plugin `ky-traffic-control`, maybe imitating 
`traffic-control`, you need to know that `traffic-control` plugin would to 
rewriting `upstream_conf`.
   
   here: 
https://github.com/apache/apisix/blob/427e9269efe32836051bf280ea2af4a566730ae4/apisix/plugins/traffic-split.lua#L196
   
   Let's ignore the ip issue for a moment.
   
   Just from the information you have provided so far
   
   1. this error occurred during the balancer phase retry.
   2. This error is probably related to `*-traffic-control` modifying 
upstream_conf.
   
   From the information you've provided so far, I still can't reproduce it. As 
already mentioned above, I need to be able to reproduce this issue in order to 
troubleshoot this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


shuaijinchao commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793319518



##
File path: conf/config.yaml
##
@@ -43,5 +43,5 @@
 apisix:
   admin_key:
 - name: admin
-  key: edd1c9f034335f136f87ad84b625c8f1  # using fixed API token has 
security risk, please update it when you deploy to production environment
+  key: ${{APISIX_ADMIN_API_KEY}}

Review comment:
   I think it would be more flexible to replace with an environment 
variable. Users can modify the admin token through system environment 
variables. If the environment variable is not read. At this point, APISIX will 
generate a random token for it and prompt it on standard output and logs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 commented on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


bzp2010 commented on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022920994


   @stutipatelorigo 
   NoNoNo, I give the JSON writing method in the Admin API, you need to take 
the content in quotes and write it in the `regexp` and `template` lines 
respectively.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zlhgo edited a comment on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


zlhgo edited a comment on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022910062


   请求到错误后端的日志
   ```
   2022/01/27 04:11:31 [info] 36#36: *144572 [lua] init.lua:554: fetch_ctx(): 
fetch ngx ctx: 1 while reading response header from upstream, client: 
223.116.236.28, server: _, request: "POST /VideoMusic/GetInfo HTTP/2.0", 
upstream: "http://172.16.89.222:80/VideoMusic/GetInfo;, host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: true, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:488: 
compare_param(): pcre pat: \/((.|\n)*), client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] init.lua:398: 
http_access_phase(): matched route: 

[GitHub] [apisix] moonming commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


moonming commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793310867



##
File path: apisix/cli/file.lua
##
@@ -52,6 +58,32 @@ local function tab_is_array(t)
 end
 
 
+local function generate_random_str(len)
+local rand_str = ""
+local rand_num = 0
+
+-- set random seed
+randomseed(tostring(os_time()):reverse():sub(1, 5))

Review comment:
   https://github.com/apache/apisix/blob/master/apisix/cli/ops.lua#L149 
Maybe you can put this function in cli `init`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zlhgo commented on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


zlhgo commented on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022910062


   请求到错误后端的日志
   ```
   2022/01/27 04:11:31 [info] 36#36: *144572 [lua] init.lua:554: fetch_ctx(): 
fetch ngx ctx: 1 while reading response header from upstream, client: 
223.116.236.28, server: _, request: "POST /VideoMusic/GetInfo HTTP/2.0", 
upstream: "http://172.16.89.222:80/VideoMusic/GetInfo;, host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: false, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:564: 
match_route_opts(): hosts match: true, client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] radixtree.lua:488: 
compare_param(): pcre pat: \/((.|\n)*), client: 223.116.236.28, server: _, 
request: "POST /VideoMusic/AppInit HTTP/2.0", host: "api.ky.cn"
   2022/01/27 04:11:34 [info] 36#36: *144572 [lua] init.lua:398: 
http_access_phase(): matched route: 

[GitHub] [apisix] shuaijinchao commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


shuaijinchao commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793302288



##
File path: apisix/cli/file.lua
##
@@ -52,6 +58,32 @@ local function tab_is_array(t)
 end
 
 
+local function generate_random_str(len)
+local rand_str = ""
+local rand_num = 0
+
+-- set random seed
+randomseed(tostring(os_time()):reverse():sub(1, 5))

Review comment:
   the cli program runs independently of APISIX, and the logic here has not 
been triggered when the cli is executed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


moonming commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793302104



##
File path: conf/config.yaml
##
@@ -43,5 +43,5 @@
 apisix:
   admin_key:
 - name: admin
-  key: edd1c9f034335f136f87ad84b625c8f1  # using fixed API token has 
security risk, please update it when you deploy to production environment
+  key: ${{APISIX_ADMIN_API_KEY}}

Review comment:
   any do need to remove 
https://github.com/apache/apisix/blob/master/apisix/admin/init.lua#L64-L68?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


moonming commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793300246



##
File path: conf/config.yaml
##
@@ -43,5 +43,5 @@
 apisix:
   admin_key:
 - name: admin
-  key: edd1c9f034335f136f87ad84b625c8f1  # using fixed API token has 
security risk, please update it when you deploy to production environment
+  key: ${{APISIX_ADMIN_API_KEY}}

Review comment:
   According to the discussion on the mailing list, the default value 
should be empty? I don't understand what the environment variables here mean

##
File path: conf/config.yaml
##
@@ -43,5 +43,5 @@
 apisix:
   admin_key:
 - name: admin
-  key: edd1c9f034335f136f87ad84b625c8f1  # using fixed API token has 
security risk, please update it when you deploy to production environment
+  key: ${{APISIX_ADMIN_API_KEY}}

Review comment:
   do we need to update 
https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L91-L100?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on a change in pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


moonming commented on a change in pull request #6214:
URL: https://github.com/apache/apisix/pull/6214#discussion_r793270205



##
File path: apisix/cli/file.lua
##
@@ -52,6 +58,32 @@ local function tab_is_array(t)
 end
 
 
+local function generate_random_str(len)
+local rand_str = ""
+local rand_num = 0
+
+-- set random seed
+randomseed(tostring(os_time()):reverse():sub(1, 5))

Review comment:
   I don't think we need to set seed again 
https://github.com/apache/apisix/blob/427e9269efe32836051bf280ea2af4a566730ae4/apisix/init.lua#L98




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] drrrMikado commented on issue #5233: request help: no host allowed while connecting to upstream

2022-01-26 Thread GitBox


drrrMikado commented on issue #5233:
URL: https://github.com/apache/apisix/issues/5233#issuecomment-1022895719


   > hi @drrrMikado, the cause and the solution of this problem are provided 
above. Since it is your own plugin, there is nothing I can do about it.
   
   Ok, Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-java-plugin-runner] branch main updated: chore: adjust the matching APISIX version to 2.12.0 (#124)

2022-01-26 Thread tzssangglass
This is an automated email from the ASF dual-hosted git repository.

tzssangglass pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git


The following commit(s) were added to refs/heads/main by this push:
 new 65c6fcd  chore: adjust the matching APISIX version to 2.12.0 (#124)
65c6fcd is described below

commit 65c6fcda68e050fb79e6d935127d5ae7eb65b549
Author: tzssangglass 
AuthorDate: Thu Jan 27 14:28:11 2022 +0800

chore: adjust the matching APISIX version to 2.12.0 (#124)
---
 README.md | 2 +-
 docs/en/latest/development.md | 2 +-
 docs/zh/quick-start.md| 8 
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index c006b7d..0e18ca2 100644
--- a/README.md
+++ b/README.md
@@ -28,7 +28,7 @@ Version Matrix
 | apisix-java-plugin-runner | APISIX   
   |
 
|---|-|
 | 0.1.0 | >= 
[2.7.0](https://github.com/apache/apisix/blob/master/CHANGELOG.md#270)   |
-| 0.2.0 | >= 
[2.10.2](https://github.com/apache/apisix/blob/master/CHANGELOG.md#2102) |
+| 0.2.0 | >= 
[2.12.0](https://github.com/apache/apisix/blob/master/CHANGELOG.md#2102) |
 
 How it Works
 -
diff --git a/docs/en/latest/development.md b/docs/en/latest/development.md
index db007a7..339f58f 100644
--- a/docs/en/latest/development.md
+++ b/docs/en/latest/development.md
@@ -29,7 +29,7 @@ Prerequisites
 -
 
 * JDK 11
-* APISIX 2.10.x
+* APISIX 2.12.0
 * Clone the 
[apisix-java-plugin-runner](https://github.com/apache/apisix-java-plugin-runner)
 project.
 * Refer to [Debug](how-it-works.md#debug)  to build the debug environment.
 
diff --git a/docs/zh/quick-start.md b/docs/zh/quick-start.md
index 15d19a7..77bfe58 100644
--- a/docs/zh/quick-start.md
+++ b/docs/zh/quick-start.md
@@ -3,7 +3,7 @@
 ### 准备工作
 
 * JDK 11
-* APISIX 2.10.0
+* APISIX 2.12.0
 * Clone the 
[apisix-java-plugin-runner](https://github.com/apache/apisix-java-plugin-runner)
 project。
 
 ### 开发扩展插件过滤器
@@ -54,7 +54,7 @@ apache-apisix-java-plugin-runner-0.1.0-bin.tar.gz
 在`dist`目录添加`Dockerfile`文件
 
 ```dockerfile
-FROM apache/apisix:2.10.0-alpine
+FROM apache/apisix:${version}-alpine
 
 RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" 
/etc/apk/repositories && apk add --no-cache openjdk8-jre
 
@@ -66,7 +66,7 @@ ADD apache-apisix-java-plugin-runner-0.1.0-bin.tar.gz 
/usr/local/
 
 ```shell
  cd dist
- docker build -t apache/apisix:2.10.0-alpine-with-java-plugin .
+ docker build -t apache/apisix:${version}-alpine-with-java-plugin .
 ```
 
 最后在 APISIX 的 `config.yaml` 文件中增加配置,如下
@@ -76,7 +76,7 @@ ext-plugin:
   cmd: ['java', '-jar', '-Xmx4g', '-Xms4g', 
'/path/to/apisix-runner-bin/apisix-java-plugin-runner.jar']
 ```
 
-构建完成的 `apache/apisix:2.10.0-alpine-with-java-plugin` 镜像内即包含 APISIX 与 
apisix-java-plugun-runner。
+构建完成的 `apache/apisix:${version}-alpine-with-java-plugin` 镜像内即包含 APISIX 与 
apisix-java-plugun-runner。
 
 ### 使用插件
 


[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #118: bug: failed to handle RPC_EXTRA_INFO: unsupported info type: 2

2022-01-26 Thread GitBox


tzssangglass closed issue #118:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/118


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #124: chore: adjust the matching APISIX version to 2.12.0

2022-01-26 Thread GitBox


tzssangglass merged pull request #124:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/124


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhendongcmss opened a new pull request #6215: feat: clickhouse logger

2022-01-26 Thread GitBox


zhendongcmss opened a new pull request #6215:
URL: https://github.com/apache/apisix/pull/6215


   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Drery commented on pull request #5940: feat: mocking plugin

2022-01-26 Thread GitBox


Drery commented on pull request #5940:
URL: https://github.com/apache/apisix/pull/5940#issuecomment-1022882747


   > LGTM. But CI failed.
   @starsz hello,I fixed, please run the CI again
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bisakhmondal commented on a change in pull request #6203: feat(batchprocessor): support partial consumption of batch entries

2022-01-26 Thread GitBox


bisakhmondal commented on a change in pull request #6203:
URL: https://github.com/apache/apisix/pull/6203#discussion_r793275311



##
File path: apisix/plugins/datadog.lua
##
@@ -108,127 +109,144 @@ local function generate_tag(entry, const_tags)
 end
 
 
-function _M.log(conf, ctx)
-local entry = fetch_log(ngx, {})
-entry.balancer_ip = ctx.balancer_ip or ""
-entry.scheme = ctx.upstream_scheme or ""
+local function send_metric_over_udp(entry, metadata)
+local err_msg
+local sock = udp()
+local host, port = metadata.value.host, metadata.value.port
 
--- if prefer_name is set, fetch the service/route name. If the name is 
nil, fall back to id.
-if conf.prefer_name then
-if entry.service_id and entry.service_id ~= "" then
-local svc = service_fetch(entry.service_id)
+local ok, err = sock:setpeername(host, port)
+if not ok then
+return false, "failed to connect to UDP server: host[" .. host
+   .. "] port[" .. tostring(port) .. "] err: " .. err
+end
 
-if svc and svc.value.name ~= "" then
-entry.service_id =  svc.value.name
-end
-end
+-- Generate prefix & suffix according dogstatsd udp data format.
+local suffix = generate_tag(entry, metadata.value.constant_tags)
+local prefix = metadata.value.namespace
+if prefix ~= "" then
+prefix = prefix .. "."
+end
 
-if ctx.route_name and ctx.route_name ~= "" then
-entry.route_id = ctx.route_name
-end
+-- request counter
+ok, err = sock:send(format("%s:%s|%s%s", prefix ..
+   "request.counter", 1, "c", suffix))

Review comment:
   Fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] purekeeper commented on issue #6209: request help: why proxy_rewrite dones't work well

2022-01-26 Thread GitBox


purekeeper commented on issue #6209:
URL: https://github.com/apache/apisix/issues/6209#issuecomment-1022869819


   okay,thanks all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] purekeeper closed issue #6209: request help: why proxy_rewrite dones't work well

2022-01-26 Thread GitBox


purekeeper closed issue #6209:
URL: https://github.com/apache/apisix/issues/6209


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on issue #6198: bug: core.json cannot serialise sparse array if enabled healthcheck

2022-01-26 Thread GitBox


tokers commented on issue #6198:
URL: https://github.com/apache/apisix/issues/6198#issuecomment-1022868556


   > It's a bit tricky, the content of the checker is too big……
   
   Right, I think estimating the sparse degree is not available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #223: feat(apisix): customized config.yaml

2022-01-26 Thread GitBox


tokers commented on a change in pull request #223:
URL: https://github.com/apache/apisix-helm-chart/pull/223#discussion_r793268552



##
File path: charts/apisix/README.md
##
@@ -63,7 +63,7 @@ The following tables lists the configurable parameters of the 
apisix chart and t
 | `apisix.enabled` | Enable or disable Apache APISIX 
itself  | `true`  |
 | `apisix.enableIPv6`  | Enable nginx IPv6 resolver
  | `true`  |
 | `apisix.enableCustomizedConfig`  | Enable full customized 
`config.yaml`| `false`  
|
-| `apisix.customizedConfig`| If 
`apisix.enableCustomizedConfig` is true, full customized `config.yaml`  | `{}`  
   |
+| `apisix.customizedConfig`| If 
`apisix.enableCustomizedConfig` is true, full customized `config.yaml`. Please 
note that other settings will be ignored  | `{}`
 |

Review comment:
   ```suggestion
   | `apisix.customizedConfig`| If 
`apisix.enableCustomizedConfig` is true, full customized `config.yaml`. Please 
note that other settings about APISIX config will be ignored  | `{}`
 |
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bisakhmondal commented on a change in pull request #6212: feat(loggly): support http/s bulk sending for batch logs

2022-01-26 Thread GitBox


bisakhmondal commented on a change in pull request #6212:
URL: https://github.com/apache/apisix/pull/6212#discussion_r793267767



##
File path: apisix/plugins/loggly.lua
##
@@ -232,13 +233,71 @@ local function send_data_over_udp(message)
 end
 
 
+local function send_bulk_over_http(message, metadata, conf)
+local endpoint = path.join(metadata.value.host, "bulk", 
conf.customer_token, "tag", "bulk")
+local has_prefix = metadata.value.host:find("http")

Review comment:
   Nice. Thanks for the suggestion.
   Updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] juzhiyuan merged pull request #862: docs: update single author template

2022-01-26 Thread GitBox


juzhiyuan merged pull request #862:
URL: https://github.com/apache/apisix-website/pull/862


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-website] branch master updated: docs: update single author template (#862)

2022-01-26 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 5891d10  docs: update single author template (#862)
5891d10 is described below

commit 5891d1019adf4a769fb395aab86071a3a0ef60c4
Author: yilinzeng <36651058+yzen...@users.noreply.github.com>
AuthorDate: Thu Jan 27 13:19:31 2022 +0800

docs: update single author template (#862)
---
 website/docs/general/blog-contributing-guide.md | 30 +
 1 file changed, 5 insertions(+), 25 deletions(-)

diff --git a/website/docs/general/blog-contributing-guide.md 
b/website/docs/general/blog-contributing-guide.md
index 6f4934f..8376f66 100644
--- a/website/docs/general/blog-contributing-guide.md
+++ b/website/docs/general/blog-contributing-guide.md
@@ -50,9 +50,9 @@ To add a new blog, please perform the following steps:
 
 # Single author template
 
-Our blogs start with a header sections containing fields such as `title`, 
`author`, `authorURL`, `authorImageURL`, `keywords`, `description`, and `tags`.
+Our blogs start with a header sections containing fields such as `title`, 
`authors`, `authors.name`, `authors.title`, `authors.url`, `authors.image_url`, 
`description`, and `tags`.
 
-While `title` and `author` are starightforward, the other fields might be a 
bit confusing for first-time contributors. Explanation of each field is 
mentioned below. Please note that these fields could change over time.
+Some fields might be a bit confusing for first-time contributors. Explanation 
of each field is mentioned below. Please note that these fields could change 
over time.
 
 ```markdown
 title: "blog's title"
@@ -95,26 +95,6 @@ description: description of this blog
 tags: [tag1,tag2,...,tagn]
 ```
 
-# title
-
-Required field for single author template, the title of the article, the 
standard expression in the form of `title: "title"`.
-
-# author
-
-Required field for single author template, the article's author name, the 
standard form of expression for `author: "author"`.
-
-1. Community author: if you are willing to provide your real name, use your 
real name, if not, use your GitHub account name.
-
-2. Business case authors: please provide real name, such as John Doe.
-
-# authorURL
-
-For business users or business cases, you can leave this item blank. Because 
GitHub is personal, and in the case of a business case, the person represents 
his company rather than himself, it is recommended that you leave this blank to 
avoid unnecessary controversy. This does not mean leave `authorURL`: blank, it 
means just delete the entire line that corresponds to it, including the 
variable name.
-
-# authorImageURL
-
-The author's GitHub avatar, it is related with `authorURL`. For the same 
reason described above, this is an optional field. See below for how to get the 
avatar.
-
  authors
 
 The required field for co-author template. When a blog is co-authored by 2 
people, please use `authors` instead of `author` to give credits to both 
authors. `authors` consists of the following fields: `authors.name`, 
`authors.url`, `authors.title` and `authors.image_url`.
@@ -147,13 +127,13 @@ Required field, tag, which is used to categorize the 
blog. Each post can have mo
 
 We can help authors to use a better category once a pull request is submitted.
 
- How to get the authorImageURL or authors.image_url
+ How to get the authors.image_url
 
 1. Open Chrome or your preferred browser.
 2. Enter the author's GitHub address to access the author's GitHub home page.
 3. Right click on the author's avatar, and click "copy image address".
-4. Paste image address to the authorImageURL field.
-![How to get the 
authorImageURL](https://static.apiseven.com/202108/1638257037354-10fc1d17-c0f7-4826-84c9-5966b1ae43ad.png)
+4. Paste image address to the authors.image_url field.
+![How to get the 
authors.image_url](https://static.apiseven.com/202108/1638257037354-10fc1d17-c0f7-4826-84c9-5966b1ae43ad.png)
 
  truncate and overview
 


[GitHub] [apisix] membphis commented on pull request #4880: feat: add kubernetes discovery module

2022-01-26 Thread GitBox


membphis commented on pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#issuecomment-1022852415


   @zhixiongdu027 CI still fails.
   
   Do you need assistance? If yes, you can contact my email: 
membp...@gmail.com, we can communicate via IM or online meeting then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander merged pull request #6196: change: don't expose public API by default & remove plugin interceptor

2022-01-26 Thread GitBox


spacewander merged pull request #6196:
URL: https://github.com/apache/apisix/pull/6196


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated: change: don't expose public API by default & remove plugin interceptor (#6196)

2022-01-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 427e926  change: don't expose public API by default & remove plugin 
interceptor (#6196)
427e926 is described below

commit 427e9269efe32836051bf280ea2af4a566730ae4
Author: Zeping Bai 
AuthorDate: Thu Jan 27 12:57:53 2022 +0800

change: don't expose public API by default & remove plugin interceptor 
(#6196)
---
 apisix/admin/plugin_metadata.lua   |  10 --
 apisix/api_router.lua  |  77 +-
 apisix/init.lua|  12 --
 apisix/plugins/public-api.lua  |   5 +-
 t/admin/plugin-metadata.t  | 202 +
 t/admin/plugins-reload.t   |  16 ++
 t/chaos/delayetcd/delayetcd.go |   4 +
 t/chaos/killetcd/killetcd.go   |   4 +
 t/chaos/utils/utils.go |  21 +++
 t/cli/test_admin.sh|  52 ++-
 t/cli/test_prometheus.sh   |  32 
 t/config-center-yaml/consumer.t|   8 +
 t/config-center-yaml/global-rule.t |   5 +
 t/config-center-yaml/plugin.t  |   5 +
 t/node/global-rule.t   |  61 ++--
 t/plugin/batch-requests.t  | 121 +++
 t/plugin/batch-requests2.t |  65 +++-
 t/plugin/jwt-auth-vault.t  |  46 --
 t/plugin/jwt-auth.t| 297 +++--
 t/plugin/node-status.t |  55 +--
 t/plugin/prometheus.t  | 175 +++---
 t/plugin/prometheus2.t | 247 +-
 t/plugin/prometheus3.t |  74 -
 t/plugin/wolf-rbac.t   | 118 ++-
 24 files changed, 703 insertions(+), 1009 deletions(-)

diff --git a/apisix/admin/plugin_metadata.lua b/apisix/admin/plugin_metadata.lua
index f2620fc..bde9af0 100644
--- a/apisix/admin/plugin_metadata.lua
+++ b/apisix/admin/plugin_metadata.lua
@@ -14,12 +14,10 @@
 -- See the License for the specific language governing permissions and
 -- limitations under the License.
 --
-local error   = error
 local pcall   = pcall
 local require = require
 local core= require("apisix.core")
 local utils   = require("apisix.admin.utils")
-local api_router = require("apisix.api_router")
 
 local injected_mark = "injected metadata_schema"
 local _M = {
@@ -61,14 +59,6 @@ local function check_conf(plugin_name, conf)
 end
 local schema = plugin_object.metadata_schema
 
--- inject interceptors schema to each plugins
-if schema.properties.interceptors
-  and api_router.interceptors_schema['$comment'] ~= 
schema.properties.interceptors['$comment']
-then
-error("'interceptors' can not be used as the name of metadata schema's 
field")
-end
-schema.properties.interceptors = api_router.interceptors_schema
-
 core.log.info("schema: ", core.json.delay_encode(schema))
 core.log.info("conf: ", core.json.delay_encode(conf))
 
diff --git a/apisix/api_router.lua b/apisix/api_router.lua
index 9f63acd..0996701 100644
--- a/apisix/api_router.lua
+++ b/apisix/api_router.lua
@@ -16,9 +16,7 @@
 --
 local require = require
 local router = require("apisix.utils.router")
-local apisix_router = require("apisix.router")
 local plugin_mod = require("apisix.plugin")
-local ip_restriction = require("apisix.plugins.ip-restriction")
 local core = require("apisix.core")
 local ipairs = ipairs
 local type = type
@@ -27,50 +25,6 @@ local type = type
 local _M = {}
 local match_opts = {}
 local has_route_not_under_apisix
-local interceptors = {
-["ip-restriction"] = {
-run = function (conf, ctx)
-return ip_restriction.access(conf, ctx)
-end,
-schema = ip_restriction.schema,
-}
-}
-
-
-_M.interceptors_schema = {
-["$comment"] = "this is the mark for our interceptors schema",
-type = "array",
-items = {
-type = "object",
-minItems = 1,
-properties = {
-name = {
-type = "string",
-enum = {},
-},
-conf = {
-type = "object",
-}
-},
-required = {"name", "conf"},
-dependencies = {
-name = {
-oneOf = {}
-}
-}
-}
-}
-for name, attrs in pairs(interceptors) do
-core.table.insert(_M.interceptors_schema.items.properties.name.enum, name)
-core.table.insert(_M.interceptors_schema.items.dependencies.name.oneOf, {
-properties = {
-name = {
-enum = {name},
-},
-conf = attrs.schema,
-}
-})
-end
 
 
 local fetch_api_router
@@ -84,7 +38,6 @@ function fetch_api_router()
 for _, plugin in ipairs(plugin_mod.plugins) do
 local api_fun = plugin.api
 if api_fun then
-local name = 

[GitHub] [apisix-dashboard] stutipatelorigo edited a comment on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


stutipatelorigo edited a comment on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022804429


   @bzp2010 , I tried that as a first option before i created this help 
requests in first place.
   or  that means i have to use request_uri as a parameter ALSO why is the 
template needed ?
   
   STILL NOT WORKING
   ![Screenshot 
(23)](https://user-images.githubusercontent.com/97489149/151285080-0edb7a29-2ce7-47ea-b1e8-f9587d5dcffe.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zlhgo edited a comment on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


zlhgo edited a comment on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022833791


   昨天已经把大部分流量切回了 `kubernetes/ingress-nginx`, 今天早上还是出现了几次 
`/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value)` 同时也有路由请求到了错误的后端地址。
   
   告警日志
   ```
   At least 3 events occurred between 2022-01-27 10:23 CST and 2022-01-27 10:28 
CST
   
   instance.keyword:
   stable: 5
   inner: 1
   
   message.keyword:
   2022/01/27 02:28:18 [error] 34#34: 27527237 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   2022/01/27 02:28:20 [error] 34#34: 27531572 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   2022/01/27 02:28:22 [error] 36#36: 27408336 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   2022/01/27 02:28:23 [error] 36#36: 27408064 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   2022/01/27 02:28:23 [error] 36#36: 27408537 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   
   @timestamp: 2022-01-27T02:28:20.029Z
   _id: k2JcmX4BJEYEGnF4xPKm
   _index: ingress_apisix-gateway_app-log-2022.01.27
   _type: _doc
   instance: stable
   message: 2022/01/27 02:28:20 [error] 34#34: 27531572 failed to run 
balancer_by_lua: /usr/local/apisix/apisix/balancer.lua:187: attempt to index 
local 'up_conf' (a nil value)
   num_hits: 6
   num_matches: 2
   ```
   
   
   阿里云sls查的最近1小时ingress access log日志。
   ```sql
   * | select proxy_upstream_name, min(time) as min_time, max(time) as 
max_time, count(*) as count where upstream_addr = '172.16.90.251:8080' and 
_container_name_='apisix-gateway' group by proxy_upstream_name
   ```
   
   查询结果
   | proxy\_upstream\_name| min\_time| max\_time
| count  |
   |  |  | 
 | -- |
   | sentry\_stable-sentry-relay\_3000| 27/Jan/2022:02:28:21 | 
27/Jan/2022:02:28:23 | 2  |
   | h5\_h5-api\_80   | 27/Jan/2022:02:28:19 | 27/Jan/2022:02:28:19 
| 1  |
   | api\_adv-api-online\_8080 | 27/Jan/2022:02:27:03 | 27/Jan/2022:03:27:08 | 
111394 |
   | bigdata\_sa-api-online\_80| 27/Jan/2022:02:28:22 | 
27/Jan/2022:02:28:22 | 1  |
   
   通过access log可以看到,同一个时间范围,的确有不同的路由请求打到了同一个后端 `upstream_addr = 
'172.16.90.251:8080'` 上。
   
   补充一个证据, stable-sentry-relay 这个服务已经80多天没有重启了。POD IP也没有 172.16.90.251 这个IP。
   ```
   → kubectl --context prod-1 -n sentry get pods -o wide | grep relay   

   
   stable-sentry-relay-56bf48f677-h5fqw  1/1 
Running 0  82d 172.16.87.161cn-beijing.172.16.24.167   
   
   stable-sentry-relay-56bf48f677-hzvtn  1/1 
Running 0  82d 172.16.108.163   cn-beijing.172.16.78.67
   
   ```
   
   现在我已经关闭了我自定义的分流插件,并且开启了info级别的日志,并重启了apisix-gateway。
   
   
   
   就刚准备提交这个回复之前,这个问题又出现了。请稍等我提交error_log日志。
   
   @leslie-tsang @tzssangglass @starsz 请各位大佬帮忙关注下。谢谢。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zlhgo commented on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)

2022-01-26 Thread GitBox


zlhgo commented on issue #6184:
URL: https://github.com/apache/apisix/issues/6184#issuecomment-1022833791


   昨天已经把大部分流量切回了 `kubernetes/ingress-nginx`, 今天早上还是出现了几次 
`/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value)` 同时也有路由请求到了错误的后端地址。
   
   告警日志
   ```
   At least 3 events occurred between 2022-01-27 10:23 CST and 2022-01-27 10:28 
CST
   
   instance.keyword:
   stable: 5
   inner: 1
   
   message.keyword:
   2022/01/27 02:28:18 [error] 34#34: 27527237 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   2022/01/27 02:28:20 [error] 34#34: 27531572 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   2022/01/27 02:28:22 [error] 36#36: 27408336 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   2022/01/27 02:28:23 [error] 36#36: 27408064 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   2022/01/27 02:28:23 [error] 36#36: 27408537 failed to run balancer_by_lua: 
/usr/local/apisix/apisix/balancer.lua:187: attempt to index local 'up_conf' (a 
nil value): 1
   
   @timestamp: 2022-01-27T02:28:20.029Z
   _id: k2JcmX4BJEYEGnF4xPKm
   _index: ingress_apisix-gateway_app-log-2022.01.27
   _type: _doc
   instance: stable
   message: 2022/01/27 02:28:20 [error] 34#34: 27531572 failed to run 
balancer_by_lua: /usr/local/apisix/apisix/balancer.lua:187: attempt to index 
local 'up_conf' (a nil value)
   num_hits: 6
   num_matches: 2
   ```
   
   
   阿里云sls查的最近1小时ingress access log日志。
   ```sql
   * | select proxy_upstream_name, min(time) as min_time, max(time) as 
max_time, count(*) as count where upstream_addr = '172.16.90.251:8080' and 
_container_name_='apisix-gateway' group by proxy_upstream_name
   ```
   
   查询结果
   | proxy\_upstream\_name| min\_time| max\_time
| count  |
   |  |  | 
 | -- |
   | sentry\_stable-sentry-relay\_3000| 27/Jan/2022:02:28:21 | 
27/Jan/2022:02:28:23 | 2  |
   | h5\_h5-api\_80   | 27/Jan/2022:02:28:19 | 27/Jan/2022:02:28:19 
| 1  |
   | api\_adv-api-online\_8080 | 27/Jan/2022:02:27:03 | 27/Jan/2022:03:27:08 | 
111394 |
   | bigdata\_sa-api-online\_80| 27/Jan/2022:02:28:22 | 
27/Jan/2022:02:28:22 | 1  |
   
   通过access log可以看到,同一个时间范围,的确有不同的路由请求打到了同一个后端 `upstream_addr = 
'172.16.90.251:8080'` 上。
   
   
   现在我已经关闭了我自定义的分流插件,并且开启了info级别的日志,并重启了apisix-gateway。
   
   
   
   就刚准备提交这个回复之前,这个问题又出现了。请稍等我提交error_log日志。
   
   @leslie-tsang @tzssangglass @starsz 请各位大佬帮忙关注下。谢谢。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] shuaijinchao opened a new pull request #6214: fix(admin-token): fixed token is used by default

2022-01-26 Thread GitBox


shuaijinchao opened a new pull request #6214:
URL: https://github.com/apache/apisix/pull/6214


   ### What this PR does / why we need it:
   https://lists.apache.org/thread/m6s1ozvhp8ww4mcw85q2m5mp4x7fkoxh
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] kennethToyuan commented on issue #119: lua pipe child execvp() failed while executing java

2022-01-26 Thread GitBox


kennethToyuan commented on issue #119:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/119#issuecomment-1022811769


   Error reason: jdk version problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] kennethToyuan closed issue #119: lua pipe child execvp() failed while executing java

2022-01-26 Thread GitBox


kennethToyuan closed issue #119:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/119


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6198: bug: core.json cannot serialise sparse array if enabled healthcheck

2022-01-26 Thread GitBox


tzssangglass commented on issue #6198:
URL: https://github.com/apache/apisix/issues/6198#issuecomment-1022808748


   It's a bit tricky, the content of the checker is too big……


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on pull request #4880: feat: add kubernetes discovery module

2022-01-26 Thread GitBox


moonming commented on pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#issuecomment-1022808238


   > 
   
   @membphis please take a look
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on a change in pull request #6212: feat(loggly): support http/s bulk sending for batch logs

2022-01-26 Thread GitBox


spacewander commented on a change in pull request #6212:
URL: https://github.com/apache/apisix/pull/6212#discussion_r793221388



##
File path: apisix/plugins/loggly.lua
##
@@ -232,13 +233,71 @@ local function send_data_over_udp(message)
 end
 
 
+local function send_bulk_over_http(message, metadata, conf)
+local endpoint = path.join(metadata.value.host, "bulk", 
conf.customer_token, "tag", "bulk")
+local has_prefix = metadata.value.host:find("http")

Review comment:
   Better to use 
https://github.com/apache/apisix/blob/615ee41312282ca2375abddae1d074637a901d89/apisix/core/string.lua#L46




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #6206: bug: nacos discovery config valid error when using special character password symbol in config.yaml

2022-01-26 Thread GitBox


spacewander commented on issue #6206:
URL: https://github.com/apache/apisix/issues/6206#issuecomment-1022805329


   Yes. We should fix host match pattern.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen commented on issue #2285: request help: dashboards are not refreshed after the update is successful

2022-01-26 Thread GitBox


nic-chen commented on issue #2285:
URL: 
https://github.com/apache/apisix-dashboard/issues/2285#issuecomment-1022804620


   Consider whether the intermediate watch etcd failed.
   
   Please upload the error log at your convenience. @valleyFrost 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] stutipatelorigo commented on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


stutipatelorigo commented on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022804429


   @bzp2010 , I tried that as a first option before i created this help 
requests in first place.
   or  that means i have to use request_uri as a parameter 
   
   STILL NOT WORKING
   ![Screenshot 
(23)](https://user-images.githubusercontent.com/97489149/151285080-0edb7a29-2ce7-47ea-b1e8-f9587d5dcffe.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #6189: bug: Error collecting logs with jaeger-collector-agent 9411

2022-01-26 Thread GitBox


spacewander commented on issue #6189:
URL: https://github.com/apache/apisix/issues/6189#issuecomment-1022803490


   @myoss 
   Could you provide the way that you configure & run the 
jaeger-collector-agent so we can reproduce it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander closed issue #5119: request help: APISIX can export current configratures to apisix.yaml

2022-01-26 Thread GitBox


spacewander closed issue #5119:
URL: https://github.com/apache/apisix/issues/5119


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 commented on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


bzp2010 commented on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022799905


   @stutipatelorigo 
   
   You can use the `regex_uri`.
   
   ```json
   {
 "regex_uri": ["^/sw/users/(.*)", "/users/$1"]
   }
   ```
   
   The above code is not syntax-checked, you need to pay attention to it. 
However, the ideas it contains are completely correct. This is the content of 
Nginx's rewrite directive, and you can use the experience about it to do this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-helm-chart] branch gh-pages updated: Update index.yaml

2022-01-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git


The following commit(s) were added to refs/heads/gh-pages by this push:
 new 0ca5a73  Update index.yaml
0ca5a73 is described below

commit 0ca5a731ccdbfb25936b905fa6ee6e1bec4ac80d
Author: tao12345666333 
AuthorDate: Thu Jan 27 02:58:34 2022 +

Update index.yaml

Signed-off-by: tao12345666333 
---
 index.yaml | 30 +-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/index.yaml b/index.yaml
index 36e8e4f..ba9c164 100644
--- a/index.yaml
+++ b/index.yaml
@@ -2,6 +2,34 @@ apiVersion: v1
 entries:
   apisix:
   - apiVersion: v2
+appVersion: 2.12.0
+created: "2022-01-27T02:58:34.566876453Z"
+dependencies:
+- condition: etcd.enabled
+  name: etcd
+  repository: https://charts.bitnami.com/bitnami
+  version: 6.2.6
+- alias: dashboard
+  condition: dashboard.enabled
+  name: apisix-dashboard
+  repository: https://charts.apiseven.com
+  version: 0.3.0
+- alias: ingress-controller
+  condition: ingress-controller.enabled
+  name: apisix-ingress-controller
+  repository: https://charts.apiseven.com
+  version: 0.8.0
+description: A Helm chart for Apache APISIX
+digest: e27441bb06401fa901f2fd5e69a8ac7a288843f2ab921543975a2448c5684ef8
+icon: https://apache.org/logos/res/apisix/apisix.png
+maintainers:
+- name: tao12345666333
+name: apisix
+type: application
+urls:
+- 
https://github.com/apache/apisix-helm-chart/releases/download/apisix-0.8.0/apisix-0.8.0.tgz
+version: 0.8.0
+  - apiVersion: v2
 appVersion: 2.10.0
 created: "2022-01-03T05:14:25.882387486Z"
 dependencies:
@@ -379,4 +407,4 @@ entries:
 urls:
 - 
https://github.com/apache/apisix-helm-chart/releases/download/apisix-ingress-controller-0.6.0/apisix-ingress-controller-0.6.0.tgz
 version: 0.6.0
-generated: "2022-01-27T01:47:32.122016694Z"
+generated: "2022-01-27T02:58:34.566932255Z"


[apisix-helm-chart] tag apisix-0.8.0 created (now eae4612)

2022-01-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a change to tag apisix-0.8.0
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git.


  at eae4612  (commit)
No new revisions were added by this update.


[apisix-helm-chart] branch master updated (337936c -> eae4612)

2022-01-26 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository.

zhangjintao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git.


from 337936c  chore: apisix-ingress v1.4 (#208)
 add eae4612  chore: bump apisix to 2.12.0 (#222)

No new revisions were added by this update.

Summary of changes:
 charts/apisix/Chart.yaml  | 4 ++--
 charts/apisix/values.yaml | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)


[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #222: chore: bump apisix to 2.12.0

2022-01-26 Thread GitBox


tao12345666333 merged pull request #222:
URL: https://github.com/apache/apisix-helm-chart/pull/222


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] stutipatelorigo commented on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


stutipatelorigo commented on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022797912


   hi @bzp2010 , I tried but some config is missing i guess. is there any good 
or proper example for this? The documentation does not actually justify 
properly what to include in the config


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 edited a comment on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


bzp2010 edited a comment on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022796751


   @stutipatelorigo 
   You can use the proxy-rewrite plugin. It supports rewriting request uri in a 
manner consistent with Nginx rewrite using regular rewrites.
   Document: 
[https://apisix.apache.org/docs/apisix/plugins/proxy-rewrite](https://apisix.apache.org/docs/apisix/plugins/proxy-rewrite)
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on issue #2279: I have created a new consumer by AdminAPI, but it is not visible in consumers list.

2022-01-26 Thread GitBox


zaunist commented on issue #2279:
URL: 
https://github.com/apache/apisix-dashboard/issues/2279#issuecomment-1022796907


   > 
   
   May I ask how many routes are configured in your apisix? I have not been 
able to reproduce this problem. I wonder if it requires a lot of data to 
reproduce.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 edited a comment on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


bzp2010 edited a comment on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022796751


   @stutipatelorigo 
   You can use the proxy-rewrite plugin.
   Document: 
[https://apisix.apache.org/docs/apisix/plugins/proxy-rewrite](https://apisix.apache.org/docs/apisix/plugins/proxy-rewrite)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 commented on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


bzp2010 commented on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022796751


   @stutipatelorigo 
   You can use the 
proxy-rewrite[[1]](https://apisix.apache.org/docs/apisix/plugins/proxy-rewrite) 
plugin.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] stutipatelorigo edited a comment on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


stutipatelorigo edited a comment on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022788961


   @bzp2010 
   thanks for your response. Currently i am facing issue with replacing the 
path uris. Which is From path "/sw/users/*" to "/users/$1".
   Can you help how to do it with URI Override method ? or its redirecting to 
different uris


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bzp2010 edited a comment on pull request #6196: change: don't expose public API by default & remove plugin interceptor

2022-01-26 Thread GitBox


bzp2010 edited a comment on pull request #6196:
URL: https://github.com/apache/apisix/pull/6196#issuecomment-1022785595


   ## Review guide
   
   There is a lot of content in this PR revision, so I am providing a 
modifications list here.
   
   ### Modified content
   1.  **Core modifications: `apisix/admin/plugin_metadata.lua`, 
`apisix/api_router.lua`, `apisix/init.lua`**
   Remove the public API match in the access phase and remove the plugin 
interceptor.
   
   2.  **Plugin modification: `apisix/plugins/public-api.lua`**
   Remove the skip global rule, it will now be executed unconditionally (since 
the public API is now also managed by the normal HTTP request router)
   
   3. Tests based on Test::Nginx: Several files in *.t
 Add a pre-step for creating public API routes (those provide public API).
 Modify the default settings for partial `GET /t` and `no_error_log`.
   
   4. CLI tests: `t/cli/test_admin.sh`, `t/cli/test_prometheus.sh`
   Add a pre-step for creating public API routes (`node-status` and 
`prometheus` plugin)
   
   5. Chaos tests
   Add a pre-step for creating public API routes (`prometheus` plugin)
   
   ### Other
   
   This PR does not contain documentation for the public API and changes to its 
documentation involving plugin interceptors and plugin development.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] stutipatelorigo edited a comment on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


stutipatelorigo edited a comment on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022788961


   @bzp2010 
   thanks for your response. Currently i am facing issue with replacing the 
path uris. Which is From path "/sw/users/*" to "/users/$1".
   Can you help how to do it with URI Override method ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] stutipatelorigo commented on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


stutipatelorigo commented on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022788961


   @bzp2010 
   thanks for your response. Currently i am facing issue with replacing the 
path uris. Which is "/sw/users/*" to "/users/$1".
   Can you help how to do it with URI Override method ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass edited a comment on issue #84: request help: How do I get my Java custom plug-in to take precedence over the VARS feature

2022-01-26 Thread GitBox


tzssangglass edited a comment on issue #84:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/84#issuecomment-1022786750


   apisix-java-runner 0.2.0 release support to read request body.
   
   And to correct what I said above, the global plugin runs after the route 
matches.
   
   considered as resolved, feel free to reopen this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #84: request help: How do I get my Java custom plug-in to take precedence over the VARS feature

2022-01-26 Thread GitBox


tzssangglass closed issue #84:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/84


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #84: request help: How do I get my Java custom plug-in to take precedence over the VARS feature

2022-01-26 Thread GitBox


tzssangglass commented on issue #84:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/84#issuecomment-1022786750


   apisix-java-runner 0.2.0 release support to read request body.
   
   considered as resolved, feel free to reopen this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bzp2010 edited a comment on pull request #6196: feat: tweak public-api plugin

2022-01-26 Thread GitBox


bzp2010 edited a comment on pull request #6196:
URL: https://github.com/apache/apisix/pull/6196#issuecomment-1022785595


   ## Review guide
   
   There is a lot of content in this PR revision, so I am providing a 
modifications list here.
   
   ### Modified content
   1.  **Core modifications: `apisix/admin/plugin_metadata.lua`, 
`apisix/api_router.lua`, `apisix/init.lua`**
   Remove the public API match in the access phase and remove the plugin 
interceptor.
   
   2.  **Plugin modification: `apisix/plugins/public-api.lua`**
   Remove the skip global rule, it will now be executed unconditionally (since 
the public API is now also managed by the normal HTTP request router)
   
   3. Tests based on Test::Nginx: Several files in *.t
 Add a pre-step for creating public API routes (those provide public API).
 Modify the default settings for partial `GET /t` and `no_error_log`.
   
   4. CLI tests: `t/cli/test_admin.sh`, `t/cli/test_prometheus.sh`
   Add a pre-step for creating public API routes (`node-status` and 
`prometheus` plugin)
   
   5. Chaos tests
   Add a pre-step for creating public API routes (`prometheus` plugin)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it starts

2022-01-26 Thread GitBox


tzssangglass closed issue #78:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/78


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #78: bug: socket type file permissions not set accurately after apisix-java-plugin-runner automatically create this file when it st

2022-01-26 Thread GitBox


tzssangglass commented on issue #78:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/78#issuecomment-1022785798


   considered as resolved, feel free to reopen this.
   
   ref to: 
https://github.com/apache/apisix-java-plugin-runner/blob/cbd3b3a6ad536df5d1ea71336c4a319a28c0622d/runner-core/src/main/java/org/apache/apisix/plugin/runner/server/ApplicationRunner.java#L109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bzp2010 commented on pull request #6196: feat: tweak public-api plugin

2022-01-26 Thread GitBox


bzp2010 commented on pull request #6196:
URL: https://github.com/apache/apisix/pull/6196#issuecomment-1022785595


   ## Review guide
   
   There is a lot of content in this PR revision, so I am providing a guide 
here.
   
   ### Modified content
   1. Core modifications: `apisix/admin/plugin_metadata.lua`, 
`apisix/api_router.lua`, `apisix/init.lua`
   Remove the public API match in the access phase and remove the plugin 
interceptor.
   
   2. Plugin modification: `apisix/plugins/public-api.lua`
   Remove the skip global rule, it will now be executed unconditionally (since 
the public API is now also managed by the normal HTTP request router)
   
   3. Tests based on Test::Nginx: Several files in *.t
   - Add a pre-step for creating public API routes (those provide public API).
   - Modify the default settings for partial `GET /t` and `no_error_log`.
   
   4. CLI tests: `t/cli/test_admin.sh`, `t/cli/test_prometheus.sh`
   Add a pre-step for creating public API routes (`node-status` and 
`prometheus` plugin)
   
   5. Chaos tests
   Add a pre-step for creating public API routes (`prometheus` plugin)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] bzp2010 edited a comment on pull request #6196: feat: tweak public-api plugin

2022-01-26 Thread GitBox


bzp2010 edited a comment on pull request #6196:
URL: https://github.com/apache/apisix/pull/6196#issuecomment-1022785595


   ## Review guide
   
   There is a lot of content in this PR revision, so I am providing a 
modifications list here.
   
   ### Modified content
   1. Core modifications: `apisix/admin/plugin_metadata.lua`, 
`apisix/api_router.lua`, `apisix/init.lua`
   Remove the public API match in the access phase and remove the plugin 
interceptor.
   
   2. Plugin modification: `apisix/plugins/public-api.lua`
   Remove the skip global rule, it will now be executed unconditionally (since 
the public API is now also managed by the normal HTTP request router)
   
   3. Tests based on Test::Nginx: Several files in *.t
   - Add a pre-step for creating public API routes (those provide public API).
   - Modify the default settings for partial `GET /t` and `no_error_log`.
   
   4. CLI tests: `t/cli/test_admin.sh`, `t/cli/test_prometheus.sh`
   Add a pre-step for creating public API routes (`node-status` and 
`prometheus` plugin)
   
   5. Chaos tests
   Add a pre-step for creating public API routes (`prometheus` plugin)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #94: request help: can i rewrite the proxy response with java-plugin-runner

2022-01-26 Thread GitBox


tzssangglass commented on issue #94:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/94#issuecomment-1022785119


considered as resolved, feel free to reopen this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #94: request help: can i rewrite the proxy response with java-plugin-runner

2022-01-26 Thread GitBox


tzssangglass closed issue #94:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/94


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #102: request help: I want to get the upstream response status code。How can I do?

2022-01-26 Thread GitBox


tzssangglass commented on issue #102:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/102#issuecomment-1022784893


   This relies on APISIX support for calling the plugin runner in the 
`header_filter` and `body_filter` phases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] xianshun163 commented on issue #2279: I have created a new consumer by AdminAPI, but it is not visible in consumers list.

2022-01-26 Thread GitBox


xianshun163 commented on issue #2279:
URL: 
https://github.com/apache/apisix-dashboard/issues/2279#issuecomment-1022784591


   some times   I have the similar problem。It  looks  like  the connection with 
the etcd   have make some err, and the dashboard  can not get the newst data 
from the etcd.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 commented on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


bzp2010 commented on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022783180


   Hi, @stutipatelorigo 
   You can create multiple routes with different priorities for the different 
paths you need to match, and they will be matched in turn.
   
   Again, no matter what optimizations are made to match regular expressions, 
it is a costly operation to perform and you may want to avoid performing one or 
more regular matches per request by other engineering means whenever possible. 
For example, using a header, a cookie, or some kind of token containing the 
above information (you can handle it with a custom plugin) are relatively more 
viable options.
   If we were to natively support the `{params}` syntax, as some Golang 
frameworks do, we wouldn't be able to use radixtree to provide extremely 
efficient route matching, so using this pattern would cause performance 
degradation in either the route matching phase or the HTTP request processing 
phase, so it's a tradeoff.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #87: release 0.2.0 task list

2022-01-26 Thread GitBox


tzssangglass closed issue #87:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/87


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #87: release 0.2.0 task list

2022-01-26 Thread GitBox


tzssangglass commented on issue #87:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/87#issuecomment-1022781361


   after 0.2.0 released, close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #93: bug: HttpRequest.getConfig(this) raise IndexOutOfBoundsException

2022-01-26 Thread GitBox


tzssangglass commented on issue #93:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/93#issuecomment-1022780611


   no more response, considered as resolved, feel free to reopen this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #93: bug: HttpRequest.getConfig(this) raise IndexOutOfBoundsException

2022-01-26 Thread GitBox


tzssangglass closed issue #93:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/93


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #89: bug: 部署好java的plugin之后,调用报错

2022-01-26 Thread GitBox


tzssangglass closed issue #89:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/89


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #89: bug: 部署好java的plugin之后,调用报错

2022-01-26 Thread GitBox


tzssangglass commented on issue #89:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/89#issuecomment-1022780461


   no more response, considered as resolved, feel free to reopen this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #92: request help: How to get all the information in the original request header.

2022-01-26 Thread GitBox


tzssangglass commented on issue #92:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/92#issuecomment-1022780064


   here: 
https://github.com/apache/apisix-java-plugin-runner/blob/1a682617a12a2350370f9bf5d6daa3f0bf11f099/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java#L141-L150
   
   maybe rename this function to `getHeaders` is better, would you like to 
submit a PR to fix it and add more use cases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] stutipatelorigo edited a comment on issue #2284: APISIX DASHBOARD: how to use regex to strict match uri with both path and query params in a single request

2022-01-26 Thread GitBox


stutipatelorigo edited a comment on issue #2284:
URL: 
https://github.com/apache/apisix-dashboard/issues/2284#issuecomment-1022765859


   hi @bzp2010 @zaunist  , I am still not sure about this. I tried. It seems 
like We can declare a global uri for many matching urls but not the specific 
one which is vulnurable at some point.
   
   for e.g. If i have below urls to create in apisix routes:
   1. GET /users/{username}
   2. GET /users/{username}/authorities
   3. GET /users/{username}/tenants
   4. GET /users/{username}/tenants/{tenantCode}}
   etc
   
   only one route path in apisix matches all i.e. " PATH = /users/* ", which is 
not quite correct. Also if I declare a different route like below to redirect 
to another url how to do it ?
   for e.g. PATH = " /sw/users/* " SHOULD REDIRECT TO "/users/{$1}"
   
   how to use regex URI here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #85: requst help:how to get request body params

2022-01-26 Thread GitBox


tzssangglass commented on issue #85:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/85#issuecomment-1022777941


   has support on new release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #85: requst help:how to get request body params

2022-01-26 Thread GitBox


tzssangglass closed issue #85:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/85


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #81: request help: java-plugin-runner args

2022-01-26 Thread GitBox


tzssangglass closed issue #81:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/81


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #81: request help: java-plugin-runner args

2022-01-26 Thread GitBox


tzssangglass commented on issue #81:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/81#issuecomment-1022777150


   considered as resolved, feel free to reopen this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #77: failed to receive RPC_PREPARE_CONF: timeout

2022-01-26 Thread GitBox


tzssangglass commented on issue #77:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/77#issuecomment-1022777010


   no more response, considered as resolved, feel free to reopen this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #77: failed to receive RPC_PREPARE_CONF: timeout

2022-01-26 Thread GitBox


tzssangglass closed issue #77:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/77


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #71: request help: get the parameters in the post body

2022-01-26 Thread GitBox


tzssangglass commented on issue #71:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/71#issuecomment-1022776711


   has support by new release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #71: request help: get the parameters in the post body

2022-01-26 Thread GitBox


tzssangglass closed issue #71:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/71


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #72: bug: Following the official steps to create two filters, two different requests are successful, but the second request is followed b

2022-01-26 Thread GitBox


tzssangglass closed issue #72:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/72


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #72: bug: Following the official steps to create two filters, two different requests are successful, but the second request is foll

2022-01-26 Thread GitBox


tzssangglass commented on issue #72:
URL: 
https://github.com/apache/apisix-java-plugin-runner/issues/72#issuecomment-1022776097


   no more response, considered as resolved, feel free to reopen this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on a change in pull request #6203: feat(batchprocessor): support partial consumption of batch entries

2022-01-26 Thread GitBox


spacewander commented on a change in pull request #6203:
URL: https://github.com/apache/apisix/pull/6203#discussion_r793197231



##
File path: apisix/plugins/datadog.lua
##
@@ -108,127 +109,144 @@ local function generate_tag(entry, const_tags)
 end
 
 
-function _M.log(conf, ctx)
-local entry = fetch_log(ngx, {})
-entry.balancer_ip = ctx.balancer_ip or ""
-entry.scheme = ctx.upstream_scheme or ""
+local function send_metric_over_udp(entry, metadata)
+local err_msg
+local sock = udp()
+local host, port = metadata.value.host, metadata.value.port
 
--- if prefer_name is set, fetch the service/route name. If the name is 
nil, fall back to id.
-if conf.prefer_name then
-if entry.service_id and entry.service_id ~= "" then
-local svc = service_fetch(entry.service_id)
+local ok, err = sock:setpeername(host, port)
+if not ok then
+return false, "failed to connect to UDP server: host[" .. host
+   .. "] port[" .. tostring(port) .. "] err: " .. err
+end
 
-if svc and svc.value.name ~= "" then
-entry.service_id =  svc.value.name
-end
-end
+-- Generate prefix & suffix according dogstatsd udp data format.
+local suffix = generate_tag(entry, metadata.value.constant_tags)
+local prefix = metadata.value.namespace
+if prefix ~= "" then
+prefix = prefix .. "."
+end
 
-if ctx.route_name and ctx.route_name ~= "" then
-entry.route_id = ctx.route_name
-end
+-- request counter
+ok, err = sock:send(format("%s:%s|%s%s", prefix ..
+   "request.counter", 1, "c", suffix))

Review comment:
   My bad! Actually, I mean the alignment like:
   
https://github.com/apache/apisix/blob/615ee41312282ca2375abddae1d074637a901d89/apisix/upstream.lua#L274-L275




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   >