[GitHub] [apisix] kwanhur opened a new pull request #6236: build: make uninstall related files of runtime
kwanhur opened a new pull request #6236: URL: https://github.com/apache/apisix/pull/6236 ### What this PR does / why we need it: `make uninstall` on no need of the runtime #5225 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhendongcmss commented on pull request #6215: feat: clickhouse logger
zhendongcmss commented on pull request #6215: URL: https://github.com/apache/apisix/pull/6215#issuecomment-1024851343 Hi, @spacewander How fix this test case ? https://github.com/apache/apisix/runs/4989817705?check_suite_focus=true#step:7:22 ``` Installing collected packages: zhon Successfully installed zhon-1.1.5 find broken newline in file: docs/zh/latest/plugins/clickhouse-logger.md cat: /tmp/error.log: No such file or directory Error: Process completed with exit code 1. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] jiangy edited a comment on issue #277: bug: apache/apisix:2.12.0-alpine image misses some packages
jiangy edited a comment on issue #277:
URL: https://github.com/apache/apisix-docker/issues/277#issuecomment-1024848807
> Can't reproduce on my side. Also the openldap-dev is listed in the
Dockerfile:
>
>
https://github.com/apache/apisix-docker/blob/ced794a6e94f905e0b9998f3b7554d22bed70a7d/alpine/Dockerfile#L43
reproduce：
➜ example git:(master) git remote -v
origin https://github.com/apache/apisix-docker.git (fetch)
origin https://github.com/apache/apisix-docker.git (push)
➜ example git:(master) vim docker-compose.yml
➜ example git:(master) ✗ git diff | cat
diff --git a/example/docker-compose.yml b/example/docker-compose.yml
index a182f39..0e972b8 100644
--- a/example/docker-compose.yml
+++ b/example/docker-compose.yml
@@ -29,7 +29,7 @@ services:
apisix:
apisix:
-image: apache/apisix:2.11.0-alpine
+image: apache/apisix:2.12.0-alpine
restart: always
volumes:
- ./apisix_log:/usr/local/apisix/logs
➜ example git:(master) ✗ docker-compose -p docker-apisix up -d
Creating network "docker-apisix_apisix" with driver "bridge"
Creating volume "docker-apisix_etcd_data" with local driver
Creating docker-apisix_web1_1 ... done
Creating docker-apisix_web2_1 ... done
Creating docker-apisix_apisix-dashboard_1 ... done
Creating docker-apisix_prometheus_1 ... done
Creating docker-apisix_etcd_1 ... done
Creating docker-apisix_grafana_1 ... done
Creating docker-apisix_apisix_1 ... done
➜ example git:(master) ✗ grep 'error loading' -A 1 apisix_log/error.log
2022/01/29 06:29:24 [error] 46#46: *3 [lua] plugin.lua:109: load_plugin():
failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file
'/usr/local/apisix//deps/lib/lua/5.1/lualdap.so':
Error loading shared library libldap-2.4.so.2: No such file or
directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context:
init_worker_by_lua*
--
2022/01/29 06:29:24 [error] 45#45: *2 [lua] plugin.lua:109: load_plugin():
failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file
'/usr/local/apisix//deps/lib/lua/5.1/lualdap.so':
Error loading shared library libldap-2.4.so.2: No such file or
directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context:
init_worker_by_lua*
--
2022/01/29 06:29:24 [error] 47#47: *5 [lua] plugin.lua:109: load_plugin():
failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file
'/usr/local/apisix//deps/lib/lua/5.1/lualdap.so':
Error loading shared library libldap-2.4.so.2: No such file or
directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context:
init_worker_by_lua*
--
2022/01/29 06:29:24 [error] 50#50: *4 [lua] plugin.lua:109: load_plugin():
failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file
'/usr/local/apisix//deps/lib/lua/5.1/lualdap.so':
Error loading shared library libldap-2.4.so.2: No such file or
directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context:
init_worker_by_lua*
--
2022/01/29 06:29:24 [error] 44#44: *1 [lua] plugin.lua:109: load_plugin():
failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file
'/usr/local/apisix//deps/lib/lua/5.1/lualdap.so':
Error loading shared library libldap-2.4.so.2: No such file or
directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context:
init_worker_by_lua*
➜ example git:(master) ✗ docker exec -it docker-apisix_apisix_1 bash
bash-5.1# apk list --installed | grep openldap-dev
WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.14/main: No such
file or directory
WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.14/community: No
such file or directory
bash-5.1# ls /usr/lib/libldap-2.4.so.2
ls: /usr/lib/libldap-2.4.so.2: No such file or directory
bash-5.1# /bin/sed -i
's,https://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g'
/etc/apk/repositories
bash-5.1# apk add openldap-dev >/dev/null
bash-5.1# apk list --installed | grep openldap-dev
openldap-dev-2.4.58-r0 x86_64 {openldap} (OLDAP-2.8) [installed]
bash-5.1# ls /usr/lib/libldap-2.4.so.2
/usr/lib/libldap-2.4.so.2
bash-5.1#
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] jiangy edited a comment on issue #277: bug: apache/apisix:2.12.0-alpine image misses some packages
jiangy edited a comment on issue #277: URL: https://github.com/apache/apisix-docker/issues/277#issuecomment-1024849295  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] jiangy commented on issue #277: bug: apache/apisix:2.12.0-alpine image misses some packages
jiangy commented on issue #277: URL: https://github.com/apache/apisix-docker/issues/277#issuecomment-1024849295  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] jiangy edited a comment on issue #277: bug: apache/apisix:2.12.0-alpine image misses some packages
jiangy edited a comment on issue #277: URL: https://github.com/apache/apisix-docker/issues/277#issuecomment-1024848807 > Can't reproduce on my side. Also the openldap-dev is listed in the Dockerfile: > > https://github.com/apache/apisix-docker/blob/ced794a6e94f905e0b9998f3b7554d22bed70a7d/alpine/Dockerfile#L43 reproduce： ➜ example git:(master) git remote -v origin https://github.com/apache/apisix-docker.git (fetch) origin https://github.com/apache/apisix-docker.git (push) ➜ example git:(master) vim docker-compose.yml ➜ example git:(master) ✗ git diff | cat diff --git a/example/docker-compose.yml b/example/docker-compose.yml index a182f39..0e972b8 100644 --- a/example/docker-compose.yml +++ b/example/docker-compose.yml @@ -29,7 +29,7 @@ services: apisix: apisix: -image: apache/apisix:2.11.0-alpine +image: apache/apisix:2.12.0-alpine restart: always volumes: - ./apisix_log:/usr/local/apisix/logs ➜ example git:(master) ✗ docker-compose -p docker-apisix up -d Creating network "docker-apisix_apisix" with driver "bridge" Creating volume "docker-apisix_etcd_data" with local driver Creating docker-apisix_web1_1 ... done Creating docker-apisix_web2_1 ... done Creating docker-apisix_apisix-dashboard_1 ... done Creating docker-apisix_prometheus_1 ... done Creating docker-apisix_etcd_1 ... done Creating docker-apisix_grafana_1 ... done Creating docker-apisix_apisix_1 ... done ➜ example git:(master) ✗ grep 'error loading' -A 1 apisix_log/error.log 2022/01/29 06:29:24 [error] 46#46: *3 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* -- 2022/01/29 06:29:24 [error] 45#45: *2 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* -- 2022/01/29 06:29:24 [error] 47#47: *5 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* -- 2022/01/29 06:29:24 [error] 50#50: *4 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* -- 2022/01/29 06:29:24 [error] 44#44: *1 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* ➜ example git:(master) ✗ docker exec -it docker-apisix_apisix_1 bash bash-5.1# apk list --installed | grep openldap-dev WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.14/main: No such file or directory WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.14/community: No such file or directory bash-5.1# ls /usr/lib/libldap-2.4.so.2 ls: /usr/lib/libldap-2.4.so.2: No such file or directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] jiangy commented on issue #277: bug: apache/apisix:2.12.0-alpine image misses some packages
jiangy commented on issue #277: URL: https://github.com/apache/apisix-docker/issues/277#issuecomment-1024848807 > Can't reproduce on my side. Also the openldap-dev is listed in the Dockerfile: > > https://github.com/apache/apisix-docker/blob/ced794a6e94f905e0b9998f3b7554d22bed70a7d/alpine/Dockerfile#L43 reproduce： ` ➜ example git:(master) git remote -v origin https://github.com/apache/apisix-docker.git (fetch) origin https://github.com/apache/apisix-docker.git (push) ➜ example git:(master) vim docker-compose.yml ➜ example git:(master) ✗ git diff | cat diff --git a/example/docker-compose.yml b/example/docker-compose.yml index a182f39..0e972b8 100644 --- a/example/docker-compose.yml +++ b/example/docker-compose.yml @@ -29,7 +29,7 @@ services: apisix: apisix: -image: apache/apisix:2.11.0-alpine +image: apache/apisix:2.12.0-alpine restart: always volumes: - ./apisix_log:/usr/local/apisix/logs ➜ example git:(master) ✗ docker-compose -p docker-apisix up -d Creating network "docker-apisix_apisix" with driver "bridge" Creating volume "docker-apisix_etcd_data" with local driver Creating docker-apisix_web1_1 ... done Creating docker-apisix_web2_1 ... done Creating docker-apisix_apisix-dashboard_1 ... done Creating docker-apisix_prometheus_1 ... done Creating docker-apisix_etcd_1 ... done Creating docker-apisix_grafana_1 ... done Creating docker-apisix_apisix_1 ... done ➜ example git:(master) ✗ grep 'error loading' -A 1 apisix_log/error.log 2022/01/29 06:29:24 [error] 46#46: *3 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* -- 2022/01/29 06:29:24 [error] 45#45: *2 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* -- 2022/01/29 06:29:24 [error] 47#47: *5 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* -- 2022/01/29 06:29:24 [error] 50#50: *4 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* -- 2022/01/29 06:29:24 [error] 44#44: *1 [lua] plugin.lua:109: load_plugin(): failed to load plugin [ldap-auth] err: error loading module 'lualdap' from file '/usr/local/apisix//deps/lib/lua/5.1/lualdap.so': Error loading shared library libldap-2.4.so.2: No such file or directory (needed by /usr/local/apisix//deps/lib/lua/5.1/lualdap.so), context: init_worker_by_lua* ➜ example git:(master) ✗ docker exec -it docker-apisix_apisix_1 bash bash-5.1# apk list --installed | grep openldap-dev WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.14/main: No such file or directory WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.14/community: No such file or directory bash-5.1# ls /usr/lib/libldap-2.4.so.2 ls: /usr/lib/libldap-2.4.so.2: No such file or directory ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhixiongdu027 commented on pull request #4880: feat: add kubernetes discovery module
zhixiongdu027 commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1024841838 > > haha，your WeChat in my friend list > > you can continue your job now ^_^ TKS, Work is continuing and may be completed within a week. Also, I'm trying to increase the label_selector feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhixiongdu027 removed a comment on pull request #4880: feat: add kubernetes discovery module
zhixiongdu027 removed a comment on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1024841581 Work is continuing and may be completed this week. Also, I'm trying to increase the labels_selector feature > > haha，your WeChat in my friend list > > you can continue your job now ^_^ TKS, Work is continuing and may be completed this week. Also, I'm trying to increase the label_selector feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhixiongdu027 commented on pull request #4880: feat: add kubernetes discovery module
zhixiongdu027 commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1024841581 Work is continuing and may be completed this week. Also, I'm trying to increase the labels_selector feature > > haha，your WeChat in my friend list > > you can continue your job now ^_^ TKS, Work is continuing and may be completed this week. Also, I'm trying to increase the label_selector feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #6235: docs: data panel => data plane
spacewander opened a new pull request #6235: URL: https://github.com/apache/apisix/pull/6235 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6225: request help: install failed via source on Mac(2.12.0)
tzssangglass commented on issue #6225: URL: https://github.com/apache/apisix/issues/6225#issuecomment-1024835699 In my experience, if you are trying to do source development, after you successfully execute `make deps`, you can execute `. /bin/apisix start|stop|version` under source dir, don't need to `make install`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6221: bug: Setting rejected_msg in "limit-req" plugin does not save
tzssangglass commented on issue #6221: URL: https://github.com/apache/apisix/issues/6221#issuecomment-1024834773 Can you post the full configuration of this route in etcd? That way I can verify it directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #125: request help: java runner is only support epoll or kqueue
tzssangglass commented on issue #125: URL: https://github.com/apache/apisix-java-plugin-runner/issues/125#issuecomment-1024834086 > Does it only run on linux or mac? yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] 1657486787 opened a new issue #125: request help: java runner is only support epoll or kqueue
1657486787 opened a new issue #125: URL: https://github.com/apache/apisix-java-plugin-runner/issues/125 ### Issue description Running the apisix-java-plugin-runner project, the error message is as follows： Caused by: java.lang.RuntimeException: java runner is only support epoll or kqueue at org.apache.apisix.plugin.runner.server.ApplicationRunner.start(ApplicationRunner.java:103) ~[classes/:?] at org.apache.apisix.plugin.runner.server.ApplicationRunner.run(ApplicationRunner.java:141) ~[classes/:?] at org.springframework.boot.SpringApplication.callRunner(SpringApplication.java:819) ~[spring-boot-2.4.5.jar:2.4.5] Does it only run on linux or mac? ### Environment - apisix version (cmd: `apisix version`): 2.12 - OS (cmd: `uname -a`): windows - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #125: request help: java runner is only support epoll or kqueue
tzssangglass closed issue #125: URL: https://github.com/apache/apisix-java-plugin-runner/issues/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6231: request help: failed to connect to the unix socket unix:/tmp/runner.sock: connection refused
tzssangglass commented on issue #6231: URL: https://github.com/apache/apisix/issues/6231#issuecomment-1024833983 You need to give the reproduction steps. BTW, `connection refused` means that no plugin runner is listening at this address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #6068: request help: building failed on Mac(2.11 ldap.h)
kwanhur commented on issue #6068: URL: https://github.com/apache/apisix/issues/6068#issuecomment-1024833287 > > I got this trouble too, `brew info openldap` show installed dir `/usr/local/opt/openldap`, setted `LDAP_DIR` then `make deps` successfully. > > So, suggest to post this prerequisite. > > Hi @kwanhur, Would you like to improve the docs? yep, #6227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on pull request #863: Updated Blog list page's style
yzeng25 commented on pull request #863: URL: https://github.com/apache/apisix-website/pull/863#issuecomment-1024832868 > Hi @yzeng25, due to jsDelivr limitation, the CSS loading failed 樂 Could you please run locally to have a check? LGTM. Cool. I copied the CSS file down and ran it locally. Everything works out fine in both languages. Please continue the merging process. Thanks @BeeBombshell cc @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #4880: feat: add kubernetes discovery module
membphis commented on pull request #4880: URL: https://github.com/apache/apisix/pull/4880#issuecomment-1024832144 > haha，your WeChat in my friend list you can continue your job now ^_^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 opened a new pull request #6234: docs: update MAINTAIN.md patch section
bzp2010 opened a new pull request #6234: URL: https://github.com/apache/apisix/pull/6234 ### What this PR does / why we need it: Update the `patch` section of the `MAINTAIN.md` document to add more process descriptions. ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Chever-John commented on issue #6225: request help: install failed via source on Mac(2.12.0)
Chever-John commented on issue #6225: URL: https://github.com/apache/apisix/issues/6225#issuecomment-1024828090 That's so terrible, but we've at least ruled out that it's not Apache APISIX's fault. I suggest that you could close this issue. Best wish & happy Chinese New Year! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on issue #34: request help: Introduce context to run plugin
Belyenochi commented on issue #34: URL: https://github.com/apache/apisix-go-plugin-runner/issues/34#issuecomment-1024823046 pls assigned to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] water1st opened a new pull request #6232: add consul support
water1st opened a new pull request #6232: URL: https://github.com/apache/apisix/pull/6232 ### What this PR does / why we need it: add consul support ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #863: Updated Blog list page's style
juzhiyuan commented on pull request #863: URL: https://github.com/apache/apisix-website/pull/863#issuecomment-1024812606 Hi @yzeng25, due to jsDelivr limitation, the CSS loading failed 樂 Could you please run locally to have a check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6228: feat(loggly): support HTTP response code to SYSLOG severity mapping
spacewander commented on a change in pull request #6228: URL: https://github.com/apache/apisix/pull/6228#discussion_r794986279 ## File path: apisix/plugins/loggly.lua ## @@ -184,9 +202,18 @@ local function generate_log_message(conf, ctx) core.table.insert(taglist, "tag=\"" .. conf.tags[i] .. "\"") end end + +local message_severity = severity[conf.severity:upper()] Review comment: Let's do the conversion in `check_schema` so we don't need to do it per request. ## File path: apisix/plugins/loggly.lua ## @@ -145,6 +150,19 @@ function _M.check_schema(conf, schema_type) if not ok then return nil, err end + +if conf.severity_map then +for k, v in pairs(conf.severity_map) do +local rcode = tonumber(k) Review comment: We can do part of the validation in jsonschema? Like https://github.com/apache/apisix/blob/82d17abf9987528856cbd20ce5f17f2ae0a799ce/apisix/schema_def.lua#L94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 1657486787 opened a new issue #6231: request help: failed to connect to the unix socket unix:/tmp/runner.sock: connection refused
1657486787 opened a new issue #6231: URL: https://github.com/apache/apisix/issues/6231 ### Issue description Run apisix-java-plugin-runner to view log exceptions: ### Environment - apisix version (cmd: `apisix version`): 2.12 - OS (cmd: `uname -a`): Linux wx-2 3.10.0-1160.el7.x86_64 - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] spacewander commented on issue #277: bug: apache/apisix:2.12.0-alpine image misses some packages
spacewander commented on issue #277: URL: https://github.com/apache/apisix-docker/issues/277#issuecomment-1024809132 Can't reproduce on my side. Also the openldap-dev is listed in the Dockerfile: https://github.com/apache/apisix-docker/blob/ced794a6e94f905e0b9998f3b7554d22bed70a7d/alpine/Dockerfile#L43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 1657486787 opened a new issue #6230: request help: java runner is only support epoll or kqueue
1657486787 opened a new issue #6230: URL: https://github.com/apache/apisix/issues/6230 ### Issue description Running the apisix-java-plugin-runner project, the error message is as follows： Caused by: java.lang.RuntimeException: java runner is only support epoll or kqueue at org.apache.apisix.plugin.runner.server.ApplicationRunner.start(ApplicationRunner.java:103) ~[classes/:?] at org.apache.apisix.plugin.runner.server.ApplicationRunner.run(ApplicationRunner.java:141) ~[classes/:?] at org.springframework.boot.SpringApplication.callRunner(SpringApplication.java:819) ~[spring-boot-2.4.5.jar:2.4.5] Does it only run on linux or mac? ### Environment - apisix version (cmd: `apisix version`): 2.12 - OS (cmd: `uname -a`): windows - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6227: docs: solution for lualdap when install failed with luarocks
spacewander merged pull request #6227: URL: https://github.com/apache/apisix/pull/6227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (20dfb3b -> 82d17ab)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 20dfb3b chore(deps): upgrade jsonschema to `0.9.7` to ensure character % will be handled correctly (#6222) add 82d17ab docs: solution for lualdap when install failed with luarocks (#6227) No new revisions were added by this update. Summary of changes: docs/en/latest/how-to-build.md | 4 docs/zh/latest/how-to-build.md | 4 2 files changed, 8 insertions(+)
[GitHub] [apisix] spacewander merged pull request #6222: chore(deps): upgrade jsonschema to `0.9.7` to ensure character % will be handled correctly
spacewander merged pull request #6222: URL: https://github.com/apache/apisix/pull/6222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (c210add -> 20dfb3b)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from c210add feat(batchprocessor): support partial consumption of batch entries (#6203) add 20dfb3b chore(deps): upgrade jsonschema to `0.9.7` to ensure character % will be handled correctly (#6222) No new revisions were added by this update. Summary of changes: rockspec/apisix-master-0.rockspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [apisix] 1657486787 closed issue #6220: bug: Setting head-name in "request-id" plugin has no effect
1657486787 closed issue #6220: URL: https://github.com/apache/apisix/issues/6220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 1657486787 commented on issue #6220: bug: Setting head-name in "request-id" plugin has no effect
1657486787 commented on issue #6220:
URL: https://github.com/apache/apisix/issues/6220#issuecomment-1024771176
> Hey @1657486787, I just looked into the configuration, you are having
multilevel nesting in `request-id` plugin. and you are putting all the
configuration inside the second level request-id. It doesn't make any sense.
>
> > "request-id": {
> > ~"disable": false,~ // delete it
> > ~"request-id": {~ // request-id inside request-id won't be decoded
> > "header_name": "mk-id",
> > "include_in_response": true
> > ~}~
> > },
>
> Replace it with:
>
> ```shell
> "request-id": {
> "header_name": "mk-id",
> "include_in_response": true
> }
> ```
>
> Also, why are you putting the `disable:false` inside all the plugin
configurations. It doesn't make any sense. Whenever confused, always consider
the documentation [see
https://apisix.apache.org/docs/apisix/plugins/request-id/ for request id].
> Hey @1657486787, I just looked into the configuration, you are having
multilevel nesting in `request-id` plugin. and you are putting all the
configuration inside the second level request-id. It doesn't make any sense.
>
> > "request-id": {
> > ~"disable": false,~ // delete it
> > ~"request-id": {~ // request-id inside request-id won't be decoded
> > "header_name": "mk-id",
> > "include_in_response": true
> > ~}~
> > },
>
> Replace it with:
>
> ```shell
> "request-id": {
> "header_name": "mk-id",
> "include_in_response": true
> }
> ```
>
> Also, why are you putting the `disable:false` inside all the plugin
configurations. It doesn't make any sense. Whenever confused, always consider
the documentation [see
https://apisix.apache.org/docs/apisix/plugins/request-id/ for request id].
thank you so much！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] jenskeiner commented on issue #3479: authz-keycloak: support configurating token refresh/expire time
jenskeiner commented on issue #3479: URL: https://github.com/apache/apisix/issues/3479#issuecomment-1024632184 @Belyenochi I'd say go for it. I actually have a modified and improved version of this plugin that I have tested in a prod-like environment, but haven't gotten around to add these changes here so far. But will do my best to get that done as well soon. In the meantime, don't hesitate to fix/improve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bisakhmondal edited a comment on issue #6220: bug: Setting head-name in "request-id" plugin has no effect
bisakhmondal edited a comment on issue #6220:
URL: https://github.com/apache/apisix/issues/6220#issuecomment-1024513139
Hey @1657486787, I just looked into the configuration, you are having
multilevel nesting in `request-id` plugin. and you are putting all the
configuration inside the second level request-id. It doesn't make any sense.
> "request-id": {
~~"disable": false,~~ // delete it
~~"request-id": {~~ // request-id inside request-id won't be decoded
"header_name": "mk-id",
"include_in_response": true
~~}~~
},
Replace it with:
```shell
"request-id": {
"header_name": "mk-id",
"include_in_response": true
}
```
Also, why are you putting the `disable:false` inside all the plugin
configurations. It doesn't make any sense. Whenever confused, always consider
the documentation [see
https://apisix.apache.org/docs/apisix/plugins/request-id/ for request id].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] BeeBombshell edited a comment on pull request #863: Updated Blog list page's style
BeeBombshell edited a comment on pull request #863: URL: https://github.com/apache/apisix-website/pull/863#issuecomment-1024521041 @yzeng25 The Netlify preview deployment has a staggering view but I can't seem to find a fix. What do I refer to? Possible Problems: * customTheme.css file is not loaded * There is something wrong with my Docusaurus configuration. I tried fixing both of these but no luck. Would appreciate the help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] BeeBombshell commented on pull request #863: Updated Blog list page's style
BeeBombshell commented on pull request #863: URL: https://github.com/apache/apisix-website/pull/863#issuecomment-1024521041 The Netlify preview deployment has a staggering view but I can't seem to find a fix. What do I refer to? Possible Problems: * customTheme.css file is not loaded * There is something wrong with my Docusaurus configuration. I tried fixing both of these but no luck. Would appreciate the help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on issue #6220: bug: Setting head-name in "request-id" plugin has no effect
bisakhmondal commented on issue #6220:
URL: https://github.com/apache/apisix/issues/6220#issuecomment-1024513139
Hey @1657486787, I just looked into the configuration, you are having
multilevel nesting in `request-id` plugin. and you are putting all the
configuration inside the second level request-id. It doesn't make any sense.
> "request-id": {
"disable": false, // delete it
"request-id": { // request-id inside request-id won't be decoded
"header_name": "mk-id",
"include_in_response": true
}
},
Replace it with:
```shell
"request-id": {
"header_name": "mk-id",
"include_in_response": true
}
```
Also, why are you putting the `disable:false` inside all the plugin
configurations. It doesn't make any sense. Whenever confused, always consider
the documentation [see
https://apisix.apache.org/docs/apisix/plugins/request-id/ for request id].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] gardun0 commented on issue #226: Chart apisix-ingress-controller 0.9.0 version was not updated on apisix 0.8.0 dependencies
gardun0 commented on issue #226: URL: https://github.com/apache/apisix-helm-chart/issues/226#issuecomment-1024424770 Sure, Ill Work on it, I've found an issue working this two versions, but I'll try to debug it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Belyenochi opened a new pull request #6229: feat:support configurating token refresh/expire time
Belyenochi opened a new pull request #6229: URL: https://github.com/apache/apisix/pull/6229 https://github.com/apache/apisix/issues/3479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #5225: request help: support `make uninstall`
kwanhur commented on issue #5225: URL: https://github.com/apache/apisix/issues/5225#issuecomment-1024356910 > @kwanhur Would you like to solve this problem? yep, I'll work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #6225: request help: install failed via source on Mac(2.12.0)
kwanhur commented on issue #6225: URL: https://github.com/apache/apisix/issues/6225#issuecomment-1024344494 > Maybe I have a little difference of understanding with you on `sudo` and I suggest you try `mkdir /usr/share/lua` first. > > In addition, I would like to confirm whether the processor of your MBP is M1 arch? If so, you can refer to this issues #6099 and this [blog](https://github.com/apache/apisix-website/pull/837). Under macOS 11.6.1 (Intel Core i5), command `sudo mkdir /usr/share/lua` got failure `Operation not permmitted` :-( It's enforced by [System Integrity Protection](https://apple.stackexchange.com/questions/193368/what-is-the-rootless-feature-in-el-capitan-really/193379). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] jiangy opened a new issue #277: bug: apache/apisix:2.12.0-alpine image misses some packages
jiangy opened a new issue #277: URL: https://github.com/apache/apisix-docker/issues/277 There are maybe some problem for the building of apache/apisix:2.12.0-alpine. It misses some packages such as openldap-dev which makes ldap-auth plugin load failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #850: bug: the secret controller cannot handle secret update events in sometime
tao12345666333 commented on issue #850: URL: https://github.com/apache/apisix-ingress-controller/issues/850#issuecomment-1024263845 Thanks! What's your APISIX Ingress version? And did you use the ApisixTls resource? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Chever-John commented on issue #6225: request help: install failed via source on Mac(2.12.0)
Chever-John commented on issue #6225: URL: https://github.com/apache/apisix/issues/6225#issuecomment-1024246376 Maybe I have a little difference of understanding with you on `sudo` and I suggest you try `mkdir /usr/share/lua` first. In addition, I would like to confirm whether the processor of your MBP is M1 arch? If so, you can refer to this issues #6099 and this [blog](https://github.com/apache/apisix-website/pull/837). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2298: fix: retries field to support zero value
juzhiyuan commented on pull request #2298: URL: https://github.com/apache/apisix-dashboard/pull/2298#issuecomment-1024243627 I just retriggered the CI, wait for a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #6225: request help: install failed via source on Mac(2.12.0)
kwanhur commented on issue #6225: URL: https://github.com/apache/apisix/issues/6225#issuecomment-1024152733 > Could it be that you don't have operation permissions for the file( /usr/share/lua)? Try "ls -" :) 1. this dir `/usr/share/lua` not exist 2. it hasn't enough authority, even command with `sudo` 3. on my opinion, it should install at lua share dir which from `brew info lua`, not the fixed dir -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6218: docs: add public-api related content
tzssangglass commented on a change in pull request #6218:
URL: https://github.com/apache/apisix/pull/6218#discussion_r794445379
##
File path: docs/en/latest/plugins/public-api.md
##
@@ -0,0 +1,132 @@
+---
+title: public-api
+---
+
+
+
+## Summary
+
+- [**Description**](#description)
+- [**Attributes**](#attributes)
+- [**Example**](#example)
+
+## Description
+
+The `public-api` plugin is used to enhance the plugin public API access
control.
+When current users develop custom plugins, they can register some public APIs
for fixed functionality, such as the `/apisix/plugin/jwt/sign` API in
`jwt-auth`. These APIs can only apply limited plugins for access control
(currently only `ip-restriction`) by way of plugin interceptors.
+
+With the `public-api` plugin, we put the all public API into general HTTP API
router, which is consistent with the normal route registered by the user and
can apply any plugin. The public API added in the user plugin is no longer open
by default by APISIX, but the user manually configures the route for it, and
the user can configure any uri and plugin.
+
+## Attributes
+
+| Name | Type | Requirement | Default | Valid | Description |
+| -- | -- | -- | -- | -- | -- |
+| uri | string | optional | "" | | The uri of the public API. When you set
up the route, you can use this to configure the original API uri if it is used
in a way that is inconsistent with the original public API uri. |
+
+## Example
+
+We take the `jwt-auth` token sign API as an example to show how to configure
the `public-api` plugin. Also, the `key-auth` will be used to show how to
configure the protection plugin for the public API.
+
+### Prerequisites
+
+The use of key-auth and jwt-auth requires the configuration of a consumer that
contains the configuration of these plugins, and you need to create one in
advance, the process will be omitted here.
+
+### Basic Use Case
+
+First we will setup a route.
+
+```shell
+$ curl -X PUT 'http://127.0.0.1:9080/apisix/admin/routes/r1' \
+-H 'X-API-KEY: ' \
+-H 'Content-Type: application/json' \
+-d '{
+"uri": "/apisix/plugin/jwt/sign",
+"plugins": {
+"public-api": {}
+}
+}'
+```
+
+Let's test it.
+
+```shell
+$ curl 'http://127.0.0.1:9080/apisix/plugin/jwt/sign?key=user-key'
+```
+
+It will respond to a text JWT.
+
+### Customize URI
+
+Let's setup another route.
+
+```shell
+$ curl -X PUT 'http://127.0.0.1:9080/apisix/admin/routes/r2' \
+-H 'X-API-KEY: ' \
+-H 'Content-Type: application/json' \
+-d '{
+"uri": "/gen_token",
+"plugins": {
+"public-api": {
+"uri": "/apisix/plugin/jwt/sign"
+}
+}
+}'
+```
+
+Let's test it.
+
+```shell
+$ curl 'http://127.0.0.1:9080/gen_token?key=user-key'
+```
+
+It will still respond to a text JWT. We can see that users are free to
configure URI for the public API to match.
+
+### Protect Route
+
+Let's modify the last route and add `key-auth` authentication to it.
+
+```shell
+$ curl -X PUT 'http://127.0.0.1:9080/apisix/admin/routes/r2' \
+-H 'X-API-KEY: ' \
+-H 'Content-Type: application/json' \
+-d '{
+"uri": "/gen_token",
+"plugins": {
+"public-api": {
+"uri": "/apisix/plugin/jwt/sign"
+},
+"key-auth": {}
+}
+}'
+```
+
+Let's test it.
+
+```shell
+$ curl -i 'http://127.0.0.1:9080/gen_token?key=user-key'
+-H "apikey: test-apikey"
+HTTP/1.1 200 OK
+
+# Failed request
+$ curl -i 'http://127.0.0.1:9080/gen_token?key=user-key'
+HTTP/1.1 401 UNAUTHORIZED
+```
+
Review comment:
got
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] nic-6443 opened a new issue #850: bug: secret controller stop sync
nic-6443 opened a new issue #850: URL: https://github.com/apache/apisix-ingress-controller/issues/850 ### Issue description In our environment, there is a bug that the certificate in secret is updated, but the ingress controller does not update the new certificate to APISIX. The reason for this is not known yet. Since the environment where the bug occurred is no longer present, we cannot provide more information for now. If we reproduce it later, we will provide further information. ### Environment - your apisix-ingress-controller version (output of apisix-ingress-controller version --long): - your Kubernetes cluster version (output of kubectl version): - if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a): ### Minimal test code / Steps to reproduce / ### Actual result / ### Error log / ### Expected result _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2298: fix: retries field to support zero value
codecov-commenter edited a comment on pull request #2298: URL: https://github.com/apache/apisix-dashboard/pull/2298#issuecomment-1023259673 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2298?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2298](https://codecov.io/gh/apache/apisix-dashboard/pull/2298?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (aed4b21) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ff84e03d1b7e0e59bac3b7416e3aac8654a853b5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ff84e03) will **decrease** coverage by `16.62%`. > The diff coverage is `n/a`. > :exclamation: Current head aed4b21 differs from pull request most recent head 844bc36. Consider uploading reports for the commit 844bc36 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/2298?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2298 +/- ## === - Coverage 68.16% 51.54% -16.63% === Files 127 184 +57 Lines3374 7279 +3905 Branches 830 830 === + Hits 2300 3752 +1452 - Misses 1074 3256 +2182 - Partials0 271 +271 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.23% <ø> (?)` | | | frontend-e2e-test | `68.10% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2298?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `68.18% <ø> (ø)` | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `33.56% <0.00%> (ø)` | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `51.18% <0.00%> (ø)` | | | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | `61.70% <0.00%> (ø)` | | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | `0.00% <0.00%> (ø)` | | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `60.86% <0.00%> (ø)` | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2298: fix: retries field to support zero value
codecov-commenter edited a comment on pull request #2298: URL: https://github.com/apache/apisix-dashboard/pull/2298#issuecomment-1023259673 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2298?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2298](https://codecov.io/gh/apache/apisix-dashboard/pull/2298?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (844bc36) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ff84e03d1b7e0e59bac3b7416e3aac8654a853b5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ff84e03) will **decrease** coverage by `6.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2298?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2298 +/- ## == - Coverage 68.16% 62.09% -6.07% == Files 127 57 -70 Lines3374 3905 +531 Branches 8300 -830 == + Hits 2300 2425 +125 - Misses 1074 1194 +120 - Partials0 286 +286 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `37.10% <ø> (?)` | | | backend-unit-test | `49.19% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2298?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `68.18% <ø> (ø)` | | | [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | | | | [web/src/components/Plugin/UI/basic-auth.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9iYXNpYy1hdXRoLnRzeA==) | | | | [...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==) | | | | [web/src/pages/SSL/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvc2VydmljZS50cw==) | | | | [web/src/components/Footer/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0Zvb3Rlci9pbmRleC50c3g=) | | | | [...mponents/Upstream/components/active-check/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1R5cGUudHN4) | | | | [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2298/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | | | |
[GitHub] [apisix-dashboard] zaunist commented on issue #2299: 插件相关界面添加 "已启用" 分组选项，Insert new ButtonGroup component which with `All` , `Enabled` Child items in Plugin List View.
zaunist commented on issue #2299: URL: https://github.com/apache/apisix-dashboard/issues/2299#issuecomment-1024029349 Hi, @inickel . If you have any idea, welcome to send eamil to dev-subscr...@apisix.apache.org and follow the reply to subscribe mailing list, and you can send your idea to mailing list to discuss with other community members. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Chaunceyan commented on pull request #2298: fix: retries field to support zero value
Chaunceyan commented on pull request #2298: URL: https://github.com/apache/apisix-dashboard/pull/2298#issuecomment-1024027675 @zaunist @juzhiyuan It seems some of the ginkgo e2e tests failed. Is this a concern or they were being broken? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 1657486787 edited a comment on issue #6220: bug: Setting head-name in "request-id" plugin has no effect
1657486787 edited a comment on issue #6220:
URL: https://github.com/apache/apisix/issues/6220#issuecomment-1024022252
>
1. My configuration information is as follows：
{
"uri": "/dw2/*",
"name": "r02",
"methods": [
"GET"
],
"plugins": {
"limit-req": {
"burst": 1,
"disable": false,
"key": "1",
"key_type": "var",
"nodelay": false,
"rate": 1,
"rejected_code": 505,
"rejected_msg": "请求太多了111，稍后重试..."
},
"request-id": {
"disable": false,
"request-id": {
"header_name": "mk-id",
"include_in_response": true
}
},
"response-rewrite": {
"body_base64": false,
"disable": false,
"headers": {
"X-Server-balancer_addr": "$balancer_ip:$balancer_port",
"X-Server-id": 3,
"X-Server-status": "on",
"body": "{\"code\":\"ok\",\"message\":\"new json body\"}"
},
"vars": [
[
"status",
"==",
200
]
]
}
},
"upstream_id": "392266237876372160",
"status": 1
}
2. The result is as follows：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] 1657486787 commented on issue #6220: bug: Setting head-name in "request-id" plugin has no effect
1657486787 commented on issue #6220: URL: https://github.com/apache/apisix/issues/6220#issuecomment-1024022252 > My configuration information is as follows： -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch release/apisix-2.12.0 created (now 186ead7)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch release/apisix-2.12.0 in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. at 186ead7 feat: upgrade APISIX to 2.12.0 No new revisions were added by this update.
[GitHub] [apisix] 1657486787 commented on issue #6221: bug: Setting rejected_msg in "limit-req" plugin does not save
1657486787 commented on issue #6221: URL: https://github.com/apache/apisix/issues/6221#issuecomment-1024015553 > How did you create the plugin? Using Admin API or Manager API? using manager api -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #6201: feat: add expires timestamp for CSRF plugin
bisakhmondal commented on a change in pull request #6201:
URL: https://github.com/apache/apisix/pull/6201#discussion_r794309154
##
File path: apisix/plugins/csrf.lua
##
@@ -129,6 +135,10 @@ function _M.access(conf, ctx)
return
end
+if conf.expires == 0 then
+return
+end
Review comment:
Ahh, sorry I confused you. I didn't mean to ignore csrf token
validation. I meant we can ignore `token has expired check`.
##
File path: docs/en/latest/plugins/csrf.md
##
@@ -43,6 +43,8 @@ In the following we define `GET`, `HEAD` and `OPTIONS` as the
`safe-methods` and
| expires | number | optional | `7200` | | Expiration time(s) of csrf cookie.
|
| key | string | required | | | The secret key used to encrypt the cookie. |
+**Note: When expires is set to 0 the plugin will ignore all checks**
Review comment:
```suggestion
**Note: When expires is set to 0 the plugin will ignore checking if the
token is expired or not.**
```
##
File path: apisix/plugins/csrf.lua
##
@@ -112,6 +113,11 @@ local function check_csrf_token(conf, ctx, token)
core.log.error("no expires in token")
return false
end
+local time_now = ngx_time()
+if time_now - expires > conf.expires then
+core.log.error("token has expired")
+return false
+end
Review comment:
```suggestion
if conf.expires > 0 and time_now - expires > conf.expires then
core.log.error("token has expired")
return false
end
```
Just that's it.
##
File path: t/plugin/csrf.t
##
@@ -158,5 +159,92 @@ Cookie:
apisix-csrf-token=eyJleHBpcmVzIjo3MjAwLCJyYW5kb20iOjAuMjE2ODAxOTYyNTEwND
--- request
POST /hello
--- more_headers
-apisix-csrf-token:
eyJzaWduIjoiZTlhNWVkOTBmZDc2YjRhMTYyMzg1ZDU2Y2ZhZDI1N2MxNmI0MWY1MjFjZWUwODczNzExM2NlYzZkZDQwMWJmNyIsInJhbmRvbSI6MC4zNjcxNDg2NDI2MjE0MywiZXhwaXJlcyI6NzIwMH0=
-Cookie:
apisix-csrf-token=eyJzaWduIjoiZTlhNWVkOTBmZDc2YjRhMTYyMzg1ZDU2Y2ZhZDI1N2MxNmI0MWY1MjFjZWUwODczNzExM2NlYzZkZDQwMWJmNyIsInJhbmRvbSI6MC4zNjcxNDg2NDI2MjE0MywiZXhwaXJlcyI6NzIwMH0=
+apisix-csrf-token:
eyJyYW5kb20iOjAuNDI5ODYzMTk3MTYxMzksInNpZ24iOiI0ODRlMDY4NTkxMWQ5NmJhMDc5YzQ1ZGI0OTE2NmZkYjQ0ODhjODVkNWQ0NmE1Y2FhM2UwMmFhZDliNjE5OTQ2IiwiZXhwaXJlcyI6MjY0MzExOTYyNH0=
+Cookie:
apisix-csrf-token=eyJyYW5kb20iOjAuNDI5ODYzMTk3MTYxMzksInNpZ24iOiI0ODRlMDY4NTkxMWQ5NmJhMDc5YzQ1ZGI0OTE2NmZkYjQ0ODhjODVkNWQ0NmE1Y2FhM2UwMmFhZDliNjE5OTQ2IiwiZXhwaXJlcyI6MjY0MzExOTYyNH0=
+
+
+
+=== TEST 10: change expired
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[[{
+"uri": "/hello",
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1980": 1
+}
+},
+"plugins": {
+"csrf": {
+"key": "userkey",
+"expires": 1
+}
+}
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- response_body
+passed
+
+
+
+=== TEST 11: expired csrf token
+--- request
+POST /hello
+--- more_headers
+apisix-csrf-token:
eyJyYW5kb20iOjAuMDY3NjAxMDQwMDM5MzI4LCJzaWduIjoiOTE1Yjg2MjBhNTg1N2FjZmIzNjIxOTNhYWVlN2RkYjY5NmM0NWYwZjE5YjY5Zjg3NjM4ZTllNGNjNjYxYjQwNiIsImV4cGlyZXMiOjE2NDMxMjAxOTN9
+Cookie:
apisix-csrf-token=eyJyYW5kb20iOjAuMDY3NjAxMDQwMDM5MzI4LCJzaWduIjoiOTE1Yjg2MjBhNTg1N2FjZmIzNjIxOTNhYWVlN2RkYjY5NmM0NWYwZjE5YjY5Zjg3NjM4ZTllNGNjNjYxYjQwNiIsImV4cGlyZXMiOjE2NDMxMjAxOTN9
+--- error_code: 401
+--- error_log: token has expired
+
+
+
+=== TEST 12: set expires 0
Review comment:
please update it accordingly. Split it into 2 cases
- expires = 1 sec, sleep = 2 sec after drawing a token then check `token has
expired`
- expires = 0, sleep = 1, no expiration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot opened a new pull request #227: feat(apisix): expose stream proxy tcp/udp ports
Gallardot opened a new pull request #227: URL: https://github.com/apache/apisix-helm-chart/pull/227 #224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #226: Chart apisix-ingress-controller 0.9.0 version was not updated on apisix 0.8.0 dependencies
tokers commented on issue #226: URL: https://github.com/apache/apisix-helm-chart/issues/226#issuecomment-1023999368 > @gardun0 Would you like to submit a PR to update it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #226: Chart apisix-ingress-controller 0.9.0 version was not updated on apisix 0.8.0 dependencies
tao12345666333 commented on issue #226: URL: https://github.com/apache/apisix-helm-chart/issues/226#issuecomment-1023998805 we need open a PR to upgrade dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #6218: docs: add public-api related content
bzp2010 commented on a change in pull request #6218: URL: https://github.com/apache/apisix/pull/6218#discussion_r794298535 ## File path: docs/zh/latest/plugin-develop.md ## @@ -326,8 +326,7 @@ function _M.api() end ``` -注意注册的接口会暴露到外网。 -你可能需要使用 [interceptors](plugin-interceptors.md) 来保护它。 +注意，注册的接口将不会默认暴露，您需要使用[public-api 插件](plugins/public-api.md)来暴露它。 Review comment: ping @shuaijinchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers edited a comment on issue #226: Chart apisix-ingress-controller 0.9.0 version was not updated on apisix 0.8.0 dependencies
tokers edited a comment on issue #226: URL: https://github.com/apache/apisix-helm-chart/issues/226#issuecomment-1023997192 cc @tao12345666333 does the ingress-controller chart`0.9.0` can be used with the apisix chart `0.8.0`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #226: Chart apisix-ingress-controller 0.9.0 version was not updated on apisix 0.8.0 dependencies
tokers commented on issue #226: URL: https://github.com/apache/apisix-helm-chart/issues/226#issuecomment-1023997192 cc @tao12345666333 Is the ingress-controller chart`0.9.0` matched with apisix `0.8.0`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #6218: docs: add public-api related content
bzp2010 commented on a change in pull request #6218:
URL: https://github.com/apache/apisix/pull/6218#discussion_r794295329
##
File path: docs/en/latest/plugins/public-api.md
##
@@ -0,0 +1,132 @@
+---
+title: public-api
+---
+
+
+
+## Summary
+
+- [**Description**](#description)
+- [**Attributes**](#attributes)
+- [**Example**](#example)
+
+## Description
+
+The `public-api` plugin is used to enhance the plugin public API access
control.
+When current users develop custom plugins, they can register some public APIs
for fixed functionality, such as the `/apisix/plugin/jwt/sign` API in
`jwt-auth`. These APIs can only apply limited plugins for access control
(currently only `ip-restriction`) by way of plugin interceptors.
+
+With the `public-api` plugin, we put the all public API into general HTTP API
router, which is consistent with the normal route registered by the user and
can apply any plugin. The public API added in the user plugin is no longer open
by default by APISIX, but the user manually configures the route for it, and
the user can configure any uri and plugin.
+
+## Attributes
+
+| Name | Type | Requirement | Default | Valid | Description |
+| -- | -- | -- | -- | -- | -- |
+| uri | string | optional | "" | | The uri of the public API. When you set
up the route, you can use this to configure the original API uri if it is used
in a way that is inconsistent with the original public API uri. |
+
+## Example
+
+We take the `jwt-auth` token sign API as an example to show how to configure
the `public-api` plugin. Also, the `key-auth` will be used to show how to
configure the protection plugin for the public API.
+
+### Prerequisites
+
+The use of key-auth and jwt-auth requires the configuration of a consumer that
contains the configuration of these plugins, and you need to create one in
advance, the process will be omitted here.
+
+### Basic Use Case
+
+First we will setup a route.
+
+```shell
+$ curl -X PUT 'http://127.0.0.1:9080/apisix/admin/routes/r1' \
+-H 'X-API-KEY: ' \
+-H 'Content-Type: application/json' \
+-d '{
+"uri": "/apisix/plugin/jwt/sign",
+"plugins": {
+"public-api": {}
+}
+}'
+```
+
+Let's test it.
+
+```shell
+$ curl 'http://127.0.0.1:9080/apisix/plugin/jwt/sign?key=user-key'
+```
+
+It will respond to a text JWT.
+
+### Customize URI
+
+Let's setup another route.
+
+```shell
+$ curl -X PUT 'http://127.0.0.1:9080/apisix/admin/routes/r2' \
+-H 'X-API-KEY: ' \
+-H 'Content-Type: application/json' \
+-d '{
+"uri": "/gen_token",
+"plugins": {
+"public-api": {
+"uri": "/apisix/plugin/jwt/sign"
+}
+}
+}'
+```
+
+Let's test it.
+
+```shell
+$ curl 'http://127.0.0.1:9080/gen_token?key=user-key'
+```
+
+It will still respond to a text JWT. We can see that users are free to
configure URI for the public API to match.
+
+### Protect Route
+
+Let's modify the last route and add `key-auth` authentication to it.
+
+```shell
+$ curl -X PUT 'http://127.0.0.1:9080/apisix/admin/routes/r2' \
+-H 'X-API-KEY: ' \
+-H 'Content-Type: application/json' \
+-d '{
+"uri": "/gen_token",
+"plugins": {
+"public-api": {
+"uri": "/apisix/plugin/jwt/sign"
+},
+"key-auth": {}
+}
+}'
+```
+
+Let's test it.
+
+```shell
+$ curl -i 'http://127.0.0.1:9080/gen_token?key=user-key'
+-H "apikey: test-apikey"
+HTTP/1.1 200 OK
+
+# Failed request
+$ curl -i 'http://127.0.0.1:9080/gen_token?key=user-key'
+HTTP/1.1 401 UNAUTHORIZED
+```
+
Review comment:
@tzssangglass
It will still be inserted into the radixtree built in `api_router` at
startup, but in the default `http_access_phase`, no match will be made. If the
user configures a route for it and turns on the `public-api` plugin, we do an
`api_router` match in the `public-api` plugin's access hook to process the
public API request.
Therefore, the conclusion is that it is not exposed and the user needs to
configure the route to access it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on issue #224: missing TCP port after set stream tcp port on values file
Gallardot commented on issue #224: URL: https://github.com/apache/apisix-helm-chart/issues/224#issuecomment-1023990318 > @labaq The `ports` field in the Pod definition is just used to tell readers or other controllers that this pod will expose these ports, but it won't affect the real behaviors of the process inside the pod, ports missing from the field can still be listened. > > But I think it would be better to advertise all ports in the `ports` field, would you like to submit a PR to enhance this? Thanks! @tokers I think the service of apisix-gateway should expose the `stream proxy tcp/udp port` on `spec.ports`. Otherwise, these ports cannot be accessed through the service. I will try to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #225: Proposal: APISIX can run as DaemonSet
tokers commented on issue #225: URL: https://github.com/apache/apisix-helm-chart/issues/225#issuecomment-1023989865 @Gallardot Could you provide some real scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #6218: docs: add public-api related content
bzp2010 commented on a change in pull request #6218: URL: https://github.com/apache/apisix/pull/6218#discussion_r794290368 ## File path: docs/zh/latest/plugins/batch-requests.md ## @@ -52,8 +52,7 @@ title: batch-requests ## 接口 -插件会增加 `/apisix/batch-requests` 这个接口，你可能需要通过 [interceptors](../plugin-interceptors.md) -来保护它。 +插件会增加 `/apisix/batch-requests` 这个接口，你可能需要通过 [public-api](public-api.md) 插件来暴露它。 Review comment: updated, please re-check and resolve it. XD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #6218: docs: add public-api related content
bzp2010 commented on a change in pull request #6218: URL: https://github.com/apache/apisix/pull/6218#discussion_r794289914 ## File path: docs/en/latest/plugins/prometheus.md ## @@ -46,17 +46,16 @@ plugin_attr: Assume environment variable `INTRANET_IP` is `172.1.1.1`, now APISIX will export the metrics via `172.1.1.1:9092`. -**Before version `2.6`, the metrics are exposed via the data panel port, -you may need to use [interceptors](../plugin-interceptors.md) to protect it.** - -If you still want this behavior, you can configure it like this: +If you still want expose the metrics via the data panel port, you can configure it like this: Review comment: @juzhiyuan updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] inickel opened a new issue #2299: 插件相关界面添加 "已启用" 分组选项，Insert new ButtonGroup component which with `All` , `Enabled` Child items in Plugin List View.
inickel opened a new issue #2299: URL: https://github.com/apache/apisix-dashboard/issues/2299 # Feature request - Route > Route List > Create or Configure > `STEP 3 Plugin Config` - Service > Create Service > `Step 2 Plugin` - Plugin > Plugin List > Enable > `Global Plugin List` ## Please describe your feature Insert new ButtonGroup(or Tabs) component which with `All` , `Enabled` child items. When child item is selected `Plugin List` shows the results by filter `all` or `enabled` plugins 界面上添加一个按钮组或者选项卡组，选项为 默认选中 `全部` 和`已启用` ，快速区分`已经启用`的插件功能。 ## Describe the solution you'd like ## Describe alternatives you've considered ## Additional context 有没有计划做一个类似 `插件市场` 的功能? 或者在线添加一个插件。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #6217: request help: does apisix authentication plugin support multiple authentication methods at the same time
tokers commented on issue #6217: URL: https://github.com/apache/apisix/issues/6217#issuecomment-1023986392 > In fact, I have doubts about this OR approach, which I now feel adds complexity. We now have the public-API plugin and maybe we can achieve similar functionality with the help of this plugin approach. > > Why do you need to support so many authentication methods on only one route? Is the upstream service a compatible SSO service? Exactly, we may need some real scenarios to help us to understand this use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #6221: bug: Setting rejected_msg in "limit-req" plugin does not save
tokers commented on issue #6221: URL: https://github.com/apache/apisix/issues/6221#issuecomment-1023982964 How did you create the plugin? Using Admin API or Manager API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6203: feat(batchprocessor): support partial consumption of batch entries
spacewander merged pull request #6203: URL: https://github.com/apache/apisix/pull/6203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat(batchprocessor): support partial consumption of batch entries (#6203)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new c210add feat(batchprocessor): support partial consumption of batch
entries (#6203)
c210add is described below
commit c210add58becdf609baef29961c1c01fd12e91fa
Author: Bisakh
AuthorDate: Fri Jan 28 13:38:46 2022 +0530
feat(batchprocessor): support partial consumption of batch entries (#6203)
---
apisix/plugins/datadog.lua| 207 +-
apisix/plugins/loggly.lua | 2 +-
apisix/utils/batch-processor.lua | 29 +-
docs/en/latest/batch-processor.md | 7 +-
docs/zh/latest/batch-processor.md | 7 +-
t/utils/batch-processor.t | 43
6 files changed, 191 insertions(+), 104 deletions(-)
diff --git a/apisix/plugins/datadog.lua b/apisix/plugins/datadog.lua
index 154e89c..7f0ed8a 100644
--- a/apisix/plugins/datadog.lua
+++ b/apisix/plugins/datadog.lua
@@ -23,7 +23,6 @@ local ngx = ngx
local udp = ngx.socket.udp
local format = string.format
local concat = table.concat
-local ipairs = ipairs
local tostring = tostring
local plugin_name = "datadog"
@@ -64,6 +63,7 @@ local _M = {
metadata_schema = metadata_schema,
}
+
function _M.check_schema(conf, schema_type)
if schema_type == core.schema.TYPE_METADATA then
return core.schema.check(metadata_schema, conf)
@@ -71,6 +71,7 @@ function _M.check_schema(conf, schema_type)
return core.schema.check(schema, conf)
end
+
local function generate_tag(entry, const_tags)
local tags
if const_tags and #const_tags > 0 then
@@ -108,127 +109,143 @@ local function generate_tag(entry, const_tags)
end
-function _M.log(conf, ctx)
-local entry = fetch_log(ngx, {})
-entry.balancer_ip = ctx.balancer_ip or ""
-entry.scheme = ctx.upstream_scheme or ""
+local function send_metric_over_udp(entry, metadata)
+local err_msg
+local sock = udp()
+local host, port = metadata.value.host, metadata.value.port
--- if prefer_name is set, fetch the service/route name. If the name is
nil, fall back to id.
-if conf.prefer_name then
-if entry.service_id and entry.service_id ~= "" then
-local svc = service_fetch(entry.service_id)
+local ok, err = sock:setpeername(host, port)
+if not ok then
+return false, "failed to connect to UDP server: host[" .. host
+ .. "] port[" .. tostring(port) .. "] err: " .. err
+end
-if svc and svc.value.name ~= "" then
-entry.service_id = svc.value.name
-end
-end
+-- Generate prefix & suffix according dogstatsd udp data format.
+local suffix = generate_tag(entry, metadata.value.constant_tags)
+local prefix = metadata.value.namespace
+if prefix ~= "" then
+prefix = prefix .. "."
+end
-if ctx.route_name and ctx.route_name ~= "" then
-entry.route_id = ctx.route_name
-end
+-- request counter
+ok, err = sock:send(format("%s:%s|%s%s", prefix .. "request.counter", 1,
"c", suffix))
+if not ok then
+err_msg = "error sending request.counter: " .. err
+core.log.error("failed to report request count to dogstatsd server:
host[" .. host
+ .. "] port[" .. tostring(port) .. "] err: " .. err)
end
-if batch_processor_manager:add_entry(conf, entry) then
-return
+-- request latency histogram
+ok, err = sock:send(format("%s:%s|%s%s", prefix .. "request.latency",
+ entry.latency, "h", suffix))
+if not ok then
+err_msg = "error sending request.latency: " .. err
+core.log.error("failed to report request latency to dogstatsd server:
host["
+ .. host .. "] port[" .. tostring(port) .. "] err: " ..
err)
end
--- Generate a function to be executed by the batch processor
-local func = function(entries, batch_max_size)
--- Fetching metadata details
-local metadata = plugin.plugin_metadata(plugin_name)
-if not metadata then
-core.log.info("received nil metadata: using metadata defaults: ",
-core.json.delay_encode(defaults, true))
-metadata = {}
-metadata.value = defaults
+-- upstream latency
+if entry.upstream_latency then
+ok, err = sock:send(format("%s:%s|%s%s", prefix .. "upstream.latency",
+ entry.upstream_latency, "h", suffix))
+if not ok then
+err_msg = "error sending upstream.latency: " .. err
+core.log.error("failed to report upstream latency to dogstatsd
server: host["
+ .. host .. "] port[" .. tostring(port) .. "] err: "
.. err)
end
+end
-
[GitHub] [apisix] bisakhmondal opened a new pull request #6228: feat(loggly): support HTTP response code to SYSLOG severity mapping
bisakhmondal opened a new pull request #6228: URL: https://github.com/apache/apisix/pull/6228 ### What this PR does / why we need it: closed #6112 (phase 2 step 2) ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
