[GitHub] [apisix-ingress-controller] purekeeper commented on issue #813: request help: 采用CRD方式,如何通过ApisixRoute配置转发到三方ip:端口服务

2022-02-08 Thread GitBox


purekeeper commented on issue #813:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/813#issuecomment-1033439132


   @tao12345666333   How about this issue ,i have the same error , "not found"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] leslie-tsang commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


leslie-tsang commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033434531


   > sorry, i'm try to discuss about how APISIX deal with graphql request. it 
seems that the mock GraphQL data of APISIX is not a standard GraphQL request.
   
   Oh, I see, the error caused by 
[graphql/parse.lua](https://github.com/bjornbytes/graphql-lua/blob/master/graphql/parse.lua#L317),
 it seems the [graphql](https://github.com/bjornbytes/graphql-lua) can't 
process a standard GraphQL request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] biubiue commented on a change in pull request #6267: docs: add forward-auth zh document

2022-02-08 Thread GitBox


biubiue commented on a change in pull request #6267:
URL: https://github.com/apache/apisix/pull/6267#discussion_r802328026



##
File path: docs/zh/latest/plugins/forward-auth.md
##
@@ -0,0 +1,140 @@
+---
+title: forward-auth
+---
+
+
+
+## 目录
+
+- [**名字**](#名字)
+- [**属性**](#属性)
+- [**数据定义**](#数据定义)
+- [**示例**](#示例)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+
+## 名字
+
+`forward-auth` 插件使用的是经典外部认证。在认证失败的时候,我们可以实现自定义错误或者重定向到认证页面。
+
+Forward Auth 巧妙地将认证和授权逻辑移到了一个专门的外部服务中,网关将用户的请求转发给认证服务并阻塞原始请求,并在认证服务以非 2xx 
状态响应时替换结果。
+
+## 属性
+
+| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 |
+| -- | -- | -- | -- | -- | -- |
+| host | string | 必须 |  |  | 设置 `authorization` 服务的地址 (eg. 
https://localhost:9188) |
+| ssl_verify | boolean | 可选 | true |   | 是否验证证书 |
+| request_headers | array[string] | 可选 |  |  | 设置需要由 `client` 转发到 
`authorization` 服务的请求头。未设置时,只有 Apache APISIX 的(X-Forwarded-XXX)会被转发到 
`authorization` 服务。 |
+| upstream_headers | array[string] | 可选 |  |  | 认证通过时,设置 `authorization` 服务转发至 
`upstream` 的请求头。如果不设置则不转发任何请求头。
+| client_headers | array[string] | 可选 |  |  | 认证失败时,由 `authorization` 服务向 
`client` 发送的响应头。如果不设置则不转发任何响应头。 |
+| timeout | integer | 可选 | 3000ms | [1, 6]ms | `authorization` 服务请求超时时间 |
+| keepalive | boolean | 可选 | true |  | HTTP 长连接 |
+| keepalive_timeout | integer | 可选 | 6ms | [1000, ...]ms | 长连接空闲时间 |
+| keepalive_pool | integer | 可选 | 5 | [1, ...]ms | 连接池大小 |
+
+## 数据定义
+
+request_headers属性中转发到 `authorization` 服务中的 Apache APISIX 内容清单

Review comment:
   It’s ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] pcyan commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


pcyan commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033424701


   > I could not find the relevant description in the `curl` document. Could 
you please provide.
   > 
   > Suggest like this:
   > 
   > ```
   > ### apisix graphql
   > curl 'https://localhost:9080/v2/c4d7a195/graphql' \
   >  -H 'authority: api.mocki.io' \
   >  -H 'accept: */*' \
   >  -H 'content-type: application/json' \
   >  -H 'origin: https://api.mocki.io' \
   >  -X PUT
   >  --data-raw '{"operationName":"getUser","variables":{},"query":"query 
getUser {\n  user(id: \"4dc70521-22bb-4396-b37a-4a927c66d43b\") {\nid\n
email\nname\n  }\n}\n"}' \
   >  --compressed
   > ```
   
   ```bash
   $ curl --help
   Usage: curl [options...] 
-d, --data**HTTP POST data**
   ...
   
   ```
   use `-v` to print verbose log
   ```bash
   curl -v 'https://api.mocki.io/v2/c4d7a195/graphql' \
 -H 'authority: api.mocki.io' \
 -H 'accept: */*' \
 -H 'content-type: application/json' \
 -H 'origin: https://api.mocki.io' \
 --data-raw '{"operationName":"getUser","variables":{},"query":"query 
getUser {\n  user(id: \"4dc70521-22bb-4396-b37a-4a927c66d43b\") {\nid\n
email\nname\n  }\n}\n"}' \
 --compressed
   ```
   
   it will print something like this `> POST /v2/c4d7a195/graphql HTTP/2`, 
thought i'm not use `-X POST`
   
   sorry, i'm try to discuss about how APISIX deal with graphql request. it 
seems that the mock GraphQL data of APISIX is not a standard GraphQL request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zaunist commented on a change in pull request #6267: docs: add forward-auth zh document

2022-02-08 Thread GitBox


zaunist commented on a change in pull request #6267:
URL: https://github.com/apache/apisix/pull/6267#discussion_r802324826



##
File path: docs/zh/latest/plugins/forward-auth.md
##
@@ -0,0 +1,140 @@
+---
+title: forward-auth
+---
+
+
+
+## 目录
+
+- [**名字**](#名字)
+- [**属性**](#属性)
+- [**数据定义**](#数据定义)
+- [**示例**](#示例)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+
+## 名字
+
+`forward-auth` 插件使用的是经典外部认证。在认证失败的时候,我们可以实现自定义错误或者重定向到认证页面。
+
+Forward Auth 巧妙地将认证和授权逻辑移到了一个专门的外部服务中,网关将用户的请求转发给认证服务并阻塞原始请求,并在认证服务以非 2xx 
状态响应时替换结果。
+
+## 属性
+
+| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 |
+| -- | -- | -- | -- | -- | -- |
+| host | string | 必须 |  |  | 设置 `authorization` 服务的地址 (eg. 
https://localhost:9188) |
+| ssl_verify | boolean | 可选 | true |   | 是否验证证书 |
+| request_headers | array[string] | 可选 |  |  | 设置需要由 `client` 转发到 
`authorization` 服务的请求头。未设置时,只有 Apache APISIX 的(X-Forwarded-XXX)会被转发到 
`authorization` 服务。 |
+| upstream_headers | array[string] | 可选 |  |  | 认证通过时,设置 `authorization` 服务转发至 
`upstream` 的请求头。如果不设置则不转发任何请求头。
+| client_headers | array[string] | 可选 |  |  | 认证失败时,由 `authorization` 服务向 
`client` 发送的响应头。如果不设置则不转发任何响应头。 |
+| timeout | integer | 可选 | 3000ms | [1, 6]ms | `authorization` 服务请求超时时间 |
+| keepalive | boolean | 可选 | true |  | HTTP 长连接 |
+| keepalive_timeout | integer | 可选 | 6ms | [1000, ...]ms | 长连接空闲时间 |
+| keepalive_pool | integer | 可选 | 5 | [1, ...]ms | 连接池大小 |
+
+## 数据定义
+
+request_headers属性中转发到 `authorization` 服务中的 Apache APISIX 内容清单

Review comment:
   ```suggestion
   request_headers 属性中转发到 `authorization` 服务中的 Apache APISIX 内容清单
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] starsz commented on a change in pull request #6270: feat(oidc): add set_userinfo_detail_header

2022-02-08 Thread GitBox


starsz commented on a change in pull request #6270:
URL: https://github.com/apache/apisix/pull/6270#discussion_r802322836



##
File path: apisix/plugins/openid-connect.lua
##
@@ -317,6 +323,13 @@ function _M.rewrite(plugin_conf, ctx)
 core.request.set_header(ctx, "X-Userinfo",
 ngx_encode_base64(core.json.encode(response.user)))
 end
+-- Add X-Userinfo-Detail header, maybe.
+if response.user and conf.set_userinfo_detail_header then
+for k in string.gmatch(conf.scope..' ', '(.-)'..' ')

Review comment:
   ```suggestion
   for k in string.gmatch(conf.scope .. ' ', '(.-)' .. ' ')
   ```

##
File path: apisix/plugins/openid-connect.lua
##
@@ -317,6 +323,13 @@ function _M.rewrite(plugin_conf, ctx)
 core.request.set_header(ctx, "X-Userinfo",
 ngx_encode_base64(core.json.encode(response.user)))
 end
+-- Add X-Userinfo-Detail header, maybe.
+if response.user and conf.set_userinfo_detail_header then
+for k in string.gmatch(conf.scope..' ', '(.-)'..' ')
+do
+core.request.set_header(ctx, 
'X-Userinfo-Detail-'..k,response.user[k])

Review comment:
   ```suggestion
   core.request.set_header(ctx, 'X-Userinfo-Detail-' .. k, 
response.user[k])
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on issue #2310: bug: Setting rejected_msg in "limit-req" plugin does not save

2022-02-08 Thread GitBox


zaunist commented on issue #2310:
URL: 
https://github.com/apache/apisix-dashboard/issues/2310#issuecomment-1033405058


   @1657486787 I checked this issue,  due to rejected_msg is not supported on 
the front-end form, it is not displayed, but there is already data in etcd. We 
should support this filed in front, @guoqqqi please take a look.
   
![image](https://user-images.githubusercontent.com/38528079/153136204-59c1da8a-e043-4d8f-8cc4-2057168cda29.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass opened a new pull request #6274: chore: enable new QQ group

2022-02-08 Thread GitBox


tzssangglass opened a new pull request #6274:
URL: https://github.com/apache/apisix/pull/6274


   the original group was nearly full
   
   Signed-off-by: tzssangglass 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John edited a comment on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033401459


   I could not find the relevant description in the `curl` document. Could you 
please provide.
   
   Suggest like this:
```
   ### apisix graphql
   curl 'https://localhost:9080/v2/c4d7a195/graphql' \
 -H 'authority: api.mocki.io' \
 -H 'accept: */*' \
 -H 'content-type: application/json' \
 -H 'origin: https://api.mocki.io' \
 -X PUT
 --data-raw '{"operationName":"getUser","variables":{},"query":"query 
getUser {\n  user(id: \"4dc70521-22bb-4396-b37a-4a927c66d43b\") {\nid\n
email\nname\n  }\n}\n"}' \
 --compressed
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033401459


   I could not find the relevant description in the curl document. Could you 
please provide.
   
   Suggest like this:
```
   ### apisix graphql
   curl 'https://localhost:9080/v2/c4d7a195/graphql' \
 -H 'authority: api.mocki.io' \
 -H 'accept: */*' \
 -H 'content-type: application/json' \
 -H 'origin: https://api.mocki.io' \
 -X PUT
 --data-raw '{"operationName":"getUser","variables":{},"query":"query 
getUser {\n  user(id: \"4dc70521-22bb-4396-b37a-4a927c66d43b\") {\nid\n
email\nname\n  }\n}\n"}' \
 --compressed
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on a change in pull request #6242: fix(redirect-plugin): redirection loop behind a proxy or lb

2022-02-08 Thread GitBox


tzssangglass commented on a change in pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#discussion_r802304473



##
File path: t/plugin/redirect.t
##
@@ -1000,3 +1000,49 @@ Location: /hello?type=string=json
 --- error_code: 302
 --- no_error_log
 [error]
+
+
+
+=== TEST 41: enable http_to_https (pass X-Forwarded-Proto)
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[[{
+"uri": "/hello",
+"host": "foo.com",
+"vars": [
+[
+"scheme",
+"==",
+"http"
+]
+],
+"plugins": {
+"redirect": {
+"http_to_https": true
+}
+}
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+

Review comment:
   lost 
   
   ```
   --- request
   GET /t
   --- response_body
   passed
   --- no_error_log
   [error]
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on issue #2309: How to use BASIC AUTH header inside header override or a plugin for a particular service only

2022-02-08 Thread GitBox


zaunist commented on issue #2309:
URL: 
https://github.com/apache/apisix-dashboard/issues/2309#issuecomment-1033397673


   I am afraid the answer is no, our current authentication is supported by 
plugins and there is no way to configure it separately. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


tzssangglass commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033397467


   > and `--data` will perform request with `POST` method ,see `curl` document
   
   Where is it? I'm wondering where the error is caused by missing `-X POST`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhixiongdu027 commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802303317



##
File path: apisix/discovery/kubernetes/informer_factory.lua
##
@@ -152,48 +152,47 @@ local function split_event (body, dispatch_event)
 remainder_body = string.sub(body, captured_size + 1)
 end
 
-return remainder_body, "Success", nil
+return remainder_body, "Success"

Review comment:
   @membphis 
   Let's Imagine,  if we use  local ok ,body ,err  way :
   
   case error  -> return  false , remainer_body, reason, err
   case ok -> return true, remainer_body 
   
   and  code in  watch function will like 
   ```lua
   ok, remainer_body, reason, err = split_event(body, dispatch_event, informer)
   if not ok  then
   if reason == "ResourceGone" then
   return true
   end
   return false, reason, err
   end
   
   .
   ```
   
   is this what you expect
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] pcyan edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


pcyan edited a comment on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033360012


   > In fact, I tested both commands locally and they worked
   > 
   > config
   > 
   > ```
   > curl http://127.0.0.1:9080/apisix/admin/routes/7 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
   > {
   > "methods": ["POST"],
   > "name":"mockGetUser",
   > "uri": "/graphql",
   > "vars": [
   > ["graphql_operation", "==", "query"],
   > ["graphql_name", "==", "getUser"]
   > ],
   > "upstream": {
   > "type": "roundrobin",
   > "nodes": {
   > "127.0.0.1:1980": 1
   > }
   > }
   > }'
   > ```
   > 
   > curl command
   > 
   > ```
   > curl -X POST http://127.0.0.1:9080/graphql -d '
   > query getUser {
   > owner {
   > name
   > }
   > repo {
   > created
   > }
   > }'
   > ```
   > 
   > It could be that you missed '-POST'?
   
   A standard GraphQL POST request should use the application/json content 
type, and include a JSON-encoded body of the following form:
   ```json
   {
 "query": "...",
 "operationName": "...",
 "variables": { "myVariable": "someValue", ... }
   }
   ```
   see official graphql document, 
https://graphql.org/learn/serving-over-http/#post-request
   
   and `--data` will perform request with `POST` method ,see `curl` document


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


Chever-John commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033363110


   The 
[link](https://apisix.apache.org/zh/docs/apisix/getting-started#:~:text=Apache%20APISIX%20%E5%B7%B2%E6%94%AF%E6%8C%81%20ARM64%20%E6%9E%B6%E6%9E%84%E3%80%82%E5%A6%82%E6%9E%9C%E6%82%A8%E6%AD%A3%E5%9C%A8%E4%BD%BF%E7%94%A8%20ARM64%EF%BC%8C%E8%AF%B7%E5%9C%A8%E6%9C%80%E5%90%8E%E4%B8%80%E6%AD%A5%E6%89%A7%E8%A1%8C%20docker%2Dcompose%20%2Dp%20docker%2Dapisix%20%2Df%20docker%2Dcompose%2Darm64.yml%20up%20%2Dd%E3%80%82)
 you put forward is misleading to me. If you mean to add tips on LTS 
installation at 
[link](https://apisix.apache.org/docs/apisix/how-to-build/#:~:text=You%20can%20install%20Apache%20APISIX%20via%20RPM%20Repository%2C%20Docker%2C%20Helm%20Chart%2C%20and%20source%20release%20package.%20Please%20choose%20one%20from%20the%20following%20options.),
 I think it is feasible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] pcyan edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


pcyan edited a comment on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033360012


   > In fact, I tested both commands locally and they worked
   > 
   > config
   > 
   > ```
   > curl http://127.0.0.1:9080/apisix/admin/routes/7 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
   > {
   > "methods": ["POST"],
   > "name":"mockGetUser",
   > "uri": "/graphql",
   > "vars": [
   > ["graphql_operation", "==", "query"],
   > ["graphql_name", "==", "getUser"]
   > ],
   > "upstream": {
   > "type": "roundrobin",
   > "nodes": {
   > "127.0.0.1:1980": 1
   > }
   > }
   > }'
   > ```
   > 
   > curl command
   > 
   > ```
   > curl -X POST http://127.0.0.1:9080/graphql -d '
   > query getUser {
   > owner {
   > name
   > }
   > repo {
   > created
   > }
   > }'
   > ```
   > 
   > It could be that you missed '-POST'?
   
   A standard GraphQL POST request should use the application/json content 
type, and include a JSON-encoded body of the following form:
   ```json
   {
 "query": "...",
 "operationName": "...",
 "variables": { "myVariable": "someValue", ... }
   }
   ```
   see official graphql document, 
https://graphql.org/learn/serving-over-http/#post-request
   
   and `--data` will perform request as `POST` method ,see `curl` document


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] pcyan edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


pcyan edited a comment on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033360012


   > In fact, I tested both commands locally and they worked
   > 
   > config
   > 
   > ```
   > curl http://127.0.0.1:9080/apisix/admin/routes/7 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
   > {
   > "methods": ["POST"],
   > "name":"mockGetUser",
   > "uri": "/graphql",
   > "vars": [
   > ["graphql_operation", "==", "query"],
   > ["graphql_name", "==", "getUser"]
   > ],
   > "upstream": {
   > "type": "roundrobin",
   > "nodes": {
   > "127.0.0.1:1980": 1
   > }
   > }
   > }'
   > ```
   > 
   > curl command
   > 
   > ```
   > curl -X POST http://127.0.0.1:9080/graphql -d '
   > query getUser {
   > owner {
   > name
   > }
   > repo {
   > created
   > }
   > }'
   > ```
   > 
   > It could be that you missed '-POST'?
   
   A standard GraphQL POST request should use the application/json content 
type, and include a JSON-encoded body of the following form:
   ```json
   {
 "query": "...",
 "operationName": "...",
 "variables": { "myVariable": "someValue", ... }
   }
   ```
   see official graphql document
   
   and `--data` will perform request as `POST` method ,see `curl` document


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] pcyan commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


pcyan commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033360012


   > In fact, I tested both commands locally and they worked
   > 
   > config
   > 
   > ```
   > curl http://127.0.0.1:9080/apisix/admin/routes/7 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
   > {
   > "methods": ["POST"],
   > "name":"mockGetUser",
   > "uri": "/graphql",
   > "vars": [
   > ["graphql_operation", "==", "query"],
   > ["graphql_name", "==", "getUser"]
   > ],
   > "upstream": {
   > "type": "roundrobin",
   > "nodes": {
   > "127.0.0.1:1980": 1
   > }
   > }
   > }'
   > ```
   > 
   > curl command
   > 
   > ```
   > curl -X POST http://127.0.0.1:9080/graphql -d '
   > query getUser {
   > owner {
   > name
   > }
   > repo {
   > created
   > }
   > }'
   > ```
   > 
   > It could be that you missed '-POST'?
   
   A standard GraphQL POST request should use the application/json content 
type, and include a JSON-encoded body of the following form:
   ```json
   {
 "query": "...",
 "operationName": "...",
 "variables": { "myVariable": "someValue", ... }
   }
   ```
   see official graphql document


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhixiongdu027 commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802265594



##
File path: apisix/discovery/kubernetes/informer_factory.lua
##
@@ -152,48 +152,47 @@ local function split_event (body, dispatch_event)
 remainder_body = string.sub(body, captured_size + 1)
 end
 
-return remainder_body, "Success", nil
+return remainder_body, "Success"

Review comment:
   Ok,I will  update
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] DevGautam2000 commented on issue #667: feat: add Apache APISIX dashboard playground on website

2022-02-08 Thread GitBox


DevGautam2000 commented on issue #667:
URL: https://github.com/apache/apisix-website/issues/667#issuecomment-108670


   can I get an insight of the feature wanted?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


membphis commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802258750



##
File path: apisix/discovery/kubernetes/init.lua
##
@@ -316,7 +322,14 @@ function _M.nodes(service_name)
 create_endpoint_lrucache, endpoint_key, endpoint_port)
 end
 
+
 function _M.init_worker()
+-- TODO: maybe we can read dict name from discovery config
+endpoint_dict = ngx.shared.discovery
+if not endpoint_dict then
+error("failed to get ngx.shared.dict discovery")

Review comment:
   failed to get Nginx shared dict: `discovery`, please check your APISIX 
version




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


membphis commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802257125



##
File path: apisix/discovery/kubernetes/informer_factory.lua
##
@@ -152,48 +152,47 @@ local function split_event (body, dispatch_event)
 remainder_body = string.sub(body, captured_size + 1)
 end
 
-return remainder_body, "Success", nil
+return remainder_body, "Success"

Review comment:
   In Lua land, we mainly use this way: `local ok, body, err = ... ...`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SkyeYoung opened a new issue #872: UI problem of switching color mode in mobile browser

2022-02-08 Thread GitBox


SkyeYoung opened a new issue #872:
URL: https://github.com/apache/apisix-website/issues/872


   **Actual Behaviour**
   
   The switch keep show dark mode, when reset to light mode
   
   **Expected Behaviour**
   
   Actually, color mode switch should not show (As shown in the view on the 
large screen). But if we need to keep this switch in the phone, we need to 
refresh the state of the switch after resetting back to light mode.
   
   **Steps to reproduce it**
   
   As shown in GIF below
   
   **Screenshots of the issue**
   
   
![20220209_114520](https://user-images.githubusercontent.com/48400568/153120268-f17eb869-ff5f-4f5c-9e12-a216a27e6b68.gif)
   
   **Would you like to work on the issue?**
   
   Yes, but I don't have time now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #829: fix: objects get from lister must be treated as read-only

2022-02-08 Thread GitBox


codecov-commenter commented on pull request #829:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/829#issuecomment-1033319304


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#829](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (83cf5d3) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/df8316aaceec40ae86857b1ef972a812c55b1252?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (df8316a) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master #829  +/-   ##
   ==
   - Coverage   32.12%   32.11%   -0.02% 
   ==
 Files  71   70   -1 
 Lines7725 7726   +1 
   ==
   - Hits 2482 2481   -1 
   - Misses   4968 4970   +2 
 Partials  275  275  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv)
 | `0.00% <0.00%> (ø)` | |
   | 
[test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv)
 | | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Last update 
[df8316a...83cf5d3](https://codecov.io/gh/apache/apisix-ingress-controller/pull/829?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] SkyeYoung commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


SkyeYoung commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033316208


   >If there is a way to install the LTS version, I think he should look at the 
installation directory first.
   
   So, have you visited this link? Is it wrong?
   
   > Just like 
[here](https://apisix.apache.org/zh/docs/apisix/getting-started#:~:text=Apache%20APISIX%20%E5%B7%B2%E6%94%AF%E6%8C%81%20ARM64%20%E6%9E%B6%E6%9E%84%E3%80%82%E5%A6%82%E6%9E%9C%E6%82%A8%E6%AD%A3%E5%9C%A8%E4%BD%BF%E7%94%A8%20ARM64%EF%BC%8C%E8%AF%B7%E5%9C%A8%E6%9C%80%E5%90%8E%E4%B8%80%E6%AD%A5%E6%89%A7%E8%A1%8C%20docker%2Dcompose%20%2Dp%20docker%2Dapisix%20%2Df%20docker%2Dcompose%2Darm64.yml%20up%20%2Dd%E3%80%82)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


Chever-John commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033315283


   > 
   
   Adding a hint, I think, would compromise the integrity of the description.
   If there is a way to install the LTS version, I think he should look at the 
installation directory first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] scott-wong closed issue #6273: bug: failed to install via RPM Repository(CentOS 7)

2022-02-08 Thread GitBox


scott-wong closed issue #6273:
URL: https://github.com/apache/apisix/issues/6273


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] scott-wong commented on issue #6273: bug: failed to install via RPM Repository(CentOS 7)

2022-02-08 Thread GitBox


scott-wong commented on issue #6273:
URL: https://github.com/apache/apisix/issues/6273#issuecomment-1033314246


   Got it,thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] SkyeYoung edited a comment on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


SkyeYoung edited a comment on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033313180


   > Since this article is mainly about installing the current version, the LTS 
version is only an additional option.
   
   Yes, so you should make it as a TIP, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] leslie-tsang commented on issue #6273: bug: failed to install via RPM Repository(CentOS 7)

2022-02-08 Thread GitBox


leslie-tsang commented on issue #6273:
URL: https://github.com/apache/apisix/issues/6273#issuecomment-1033313562


   Seems you are using a `Red Hat Enterprise Linux 7`.
   Some variables, such as `$releasever`, have different values in `Red Hat 
Enterprise Linux 7` and `CentOS7`, which resulting in this issue.
   | var | CentOS7 | Red Hat Enterprise Linux 7 |
   |:--: | :: | :: |
   |$releasever| 7 | 7Server |
   
   ## Solution
   To fix it, replace `$releasever` with `7` in 
`/etc/yum.repos.d/apache-apisix.repo` as shown below
   ```ini
   [release]
   name=Apache APISIX Repository for CentOS
   baseurl=https://repos.apiseven.com/packages/centos/7/$basearch
   skip_if_unavailable=False
   gpgcheck=1
   repo_gpgcheck=1
   gpgkey=https://repos.apiseven.com/KEYS
   enabled=1
   enabled_metadata=1
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] SkyeYoung commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


SkyeYoung commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033313180


   > Since this article is mainly about installing the current version, the LTS 
version is only an additional option.
   
   Affirmative, so you should make it as a TIP, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


Chever-John commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033311028


   > Why not just give the tip to install the LTS version in step 1? Now I had 
to jump back to step 1 and look at it again.
   
   Since this article is mainly about installing the current version, the LTS 
version is only an additional option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John closed pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


Chever-John closed pull request #6269:
URL: https://github.com/apache/apisix/pull/6269


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


Chever-John commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033310138


   > > Why not just give the tip to install the LTS version in step 1?
   > 
   > Just like 
[here](https://apisix.apache.org/zh/docs/apisix/getting-started#:~:text=Apache%20APISIX%20%E5%B7%B2%E6%94%AF%E6%8C%81%20ARM64%20%E6%9E%B6%E6%9E%84%E3%80%82%E5%A6%82%E6%9E%9C%E6%82%A8%E6%AD%A3%E5%9C%A8%E4%BD%BF%E7%94%A8%20ARM64%EF%BC%8C%E8%AF%B7%E5%9C%A8%E6%9C%80%E5%90%8E%E4%B8%80%E6%AD%A5%E6%89%A7%E8%A1%8C%20docker%2Dcompose%20%2Dp%20docker%2Dapisix%20%2Df%20docker%2Dcompose%2Darm64.yml%20up%20%2Dd%E3%80%82)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass edited a comment on issue #6268: request help: Could it be interesting to implement cookie/session management in APISIX?

2022-02-08 Thread GitBox


tzssangglass edited a comment on issue #6268:
URL: https://github.com/apache/apisix/issues/6268#issuecomment-1033307130


   releated to
   
   https://github.com/apache/apisix/issues/881
   
   I'm not sure if this is what you need: 
https://github.com/apache/apisix/blob/ec0fc2ceaf04a20b0bd0ebdaad67296a1d3f621c/t/node/chash-hashon.t#L401-L487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6268: request help: Could it be interesting to implement cookie/session management in APISIX?

2022-02-08 Thread GitBox


tzssangglass commented on issue #6268:
URL: https://github.com/apache/apisix/issues/6268#issuecomment-1033307130


   releated to
   
   https://github.com/apache/apisix/issues/881
   
   I'm not sure if this is what you need: 
https://github.com/apache/apisix/blob/master/t/node/chash-hashon.t#L401-L487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SkyeYoung commented on issue #871: A strange problem caused by switching color modes in multiple tabs

2022-02-08 Thread GitBox


SkyeYoung commented on issue #871:
URL: https://github.com/apache/apisix-website/issues/871#issuecomment-1033305165


   @Baoyuantop Maybe you should take a closer look at the GIF I recorded (note 
my switch between the two tabs), and I've reproduced this issue on my phone 
(also Chrome)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6260: request help: JWT Auth

2022-02-08 Thread GitBox


tzssangglass commented on issue #6260:
URL: https://github.com/apache/apisix/issues/6260#issuecomment-1033303471


   > After I added one, it is giving me a 405 now
   
   Can you show your configuration?
   
   > s there an example config with Keycloak that would work for this
   
   PLAT 
https://github.com/apache/apisix/blob/ec0fc2ceaf04a20b0bd0ebdaad67296a1d3f621c/t/plugin/authz-keycloak2.t#L168-L305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John removed a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John removed a comment on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033276700


   In my experience, try removing the '-i' from the request configuration 
command first.
   ```
   curl http://localhost:9080/apisix/admin/routes/7 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
   "methods": ["POST"],
   "name":"mockGetUser",
   "uri": "/v2/c4d7a195/graphql",
   "vars": [
   ["graphql_operation", "==", "query"],
   ["graphql_name", "==", "getUser"]
   ],
   "upstream": {
   "type": "roundrobin",
   "nodes": {
   "api.mocki.io": 1
   }
   }
   }'
   ```
   If that doesn't work, try looking at the log, and I'll cover the entire 
troubleshooting process later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033303115


   In fact, I tested both commands locally and they worked
   
   config
   ```
   curl http://127.0.0.1:9080/apisix/admin/routes/7 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
   {
   "methods": ["POST"],
   "name":"mockGetUser",
   "uri": "/graphql",
   "vars": [
   ["graphql_operation", "==", "query"],
   ["graphql_name", "==", "getUser"]
   ],
   "upstream": {
   "type": "roundrobin",
   "nodes": {
   "127.0.0.1:1980": 1
   }
   }
   }'
   ```
   
   curl command
   ```
   curl -X POST http://127.0.0.1:9080/graphql -d '
   query getUser {
   owner {
   name
   }
   repo {
   created
   }
   }'
   ```
   It could be that you missed '-POST'?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033295447


   > @pcyan The route method has been set to `POST`, you should add `-X POST` 
in your curl CMD.
   
   As stated above, this should be a must


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John removed a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John removed a comment on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033295265


   > 
   
   As stated above, this should be a must


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033295265


   > 
   
   As stated above, this should be a must


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header

2022-02-08 Thread GitBox


tzssangglass commented on pull request #6270:
URL: https://github.com/apache/apisix/pull/6270#issuecomment-1033290896


   hi @yaule , thanks for submitting the PR, can you explain the background of 
this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


tzssangglass commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033290484


   pls add en docs too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on pull request #6229: docs(authz-keycloak): add token refresh/expire time configuration

2022-02-08 Thread GitBox


tzssangglass commented on pull request #6229:
URL: https://github.com/apache/apisix/pull/6229#issuecomment-1033290222


   pls add description of `access_token_expires_in` and 
`refresh_token_expires_in`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass removed a comment on pull request #6229: docs(authz-keycloak): add token refresh/expire time configuration

2022-02-08 Thread GitBox


tzssangglass removed a comment on pull request #6229:
URL: https://github.com/apache/apisix/pull/6229#issuecomment-1033289516


   pls add en docs too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on pull request #6229: docs(authz-keycloak): add token refresh/expire time configuration

2022-02-08 Thread GitBox


tzssangglass commented on pull request #6229:
URL: https://github.com/apache/apisix/pull/6229#issuecomment-1033289516


   pls add en docs too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on pull request #6229: docs(authz-keycloak): add token refresh/expire time configuration

2022-02-08 Thread GitBox


tzssangglass commented on pull request #6229:
URL: https://github.com/apache/apisix/pull/6229#issuecomment-1033289406


   > No feature added?
   
   The code has been implemented, but not covered by the documentation and test 
cases, 
https://github.com/apache/apisix/blob/ec0fc2ceaf04a20b0bd0ebdaad67296a1d3f621c/apisix/plugins/authz-keycloak.lua#L316-L327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] scott-wong opened a new issue #6273: bug: failed to install via RPM Repository(CentOS 7)

2022-02-08 Thread GitBox


scott-wong opened a new issue #6273:
URL: https://github.com/apache/apisix/issues/6273


   ### Issue description
   
   follow the official doc, failed to install via RPM Repository(CentOS 7).
   https://apisix.apache.org/docs/apisix/how-to-build/
   
   ### Environment
   
   - apisix version (cmd: `apisix version`): 2.12.1
   - OS (cmd: `uname -a`): Linux eu-server 3.10.0-1160.45.1.el7.x86_64 #1 SMP 
Wed Oct 13 17:20:51 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): nginx 
version: openresty/1.19.9.1
   built by gcc 10.2.1 20200804 (Red Hat 10.2.1-2) (GCC) 
   built with OpenSSL 1.1.1k  25 Mar 2021
   - etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: 
depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks 
--version`):
   
   
   ### Steps to reproduce
   
   `yum-config-manager --add-repo 
https://repos.apiseven.com/packages/centos/apache-apisix.repo`
   `yum info -y apisix`
   
   ### Actual result
   
   failure: repodata/repomd.xml from release: [Errno 256] No more mirrors to 
try.
   
https://repos.apiseven.com/packages/centos/7Server/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   
   ### Error log
   
   (base) [root@eu-server yum.repos.d]# yum info -y apisix
   已加载插件:fastestmirror, langpacks, ulninfo
   Loading mirror speeds from cached hostfile
   
https://repos.apiseven.com/packages/centos/7Server/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   正在尝试其它镜像。
   To address this issue please refer to the below wiki article 
   
   https://wiki.centos.org/yum-errors
   
   If above article doesn't help to resolve this issue please use 
https://bugs.centos.org/.
   
   
   
One of the configured repositories failed (Apache APISIX Repository for 
CentOS),
and yum doesn't have enough cached data to continue. At this point the only
safe thing yum can do is fail. There are a few ways to work "fix" this:
   
1. Contact the upstream for the repository and get them to fix the 
problem.
   
2. Reconfigure the baseurl/etc. for the repository, to point to a 
working
   upstream. This is most often useful if you are using a newer
   distribution release than is supported by the repository (and the
   packages for the previous distribution release still work).
   
3. Run the command with the repository temporarily disabled
   yum --disablerepo=release ...
   
4. Disable the repository permanently, so yum won't use it by default. 
Yum
   will then just ignore the repository until you permanently enable it
   again or use --enablerepo for temporary usage:
   
   yum-config-manager --disable release
   or
   subscription-manager repos --disable=release
   
5. Configure the failing repository to be skipped, if it is unavailable.
   Note that yum will try to contact the repo. when it runs most 
commands,
   so will have to try and fail each time (and thus. yum will be be much
   slower). If it is a very temporary problem though, this is often a 
nice
   compromise:
   
   yum-config-manager --save 
--setopt=release.skip_if_unavailable=true
   
   failure: repodata/repomd.xml from release: [Errno 256] No more mirrors to 
try.
   
https://repos.apiseven.com/packages/centos/7Server/x86_64/repodata/repomd.xml: 
[Errno 14] HTTPS Error 404 - Not Found
   
   ### Expected result
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] hongbinhsu edited a comment on issue #2307: update golang-jwt/jwt to v4

2022-02-08 Thread GitBox


hongbinhsu edited a comment on issue #2307:
URL: 
https://github.com/apache/apisix-dashboard/issues/2307#issuecomment-1033286306


   @zaunist
   Keep version iteration
   for example support for go1.17 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] hongbinhsu edited a comment on issue #2307: update golang-jwt/jwt to v4

2022-02-08 Thread GitBox


hongbinhsu edited a comment on issue #2307:
URL: 
https://github.com/apache/apisix-dashboard/issues/2307#issuecomment-1033286306


   @zaunist(https://github.com/zaunist)
   Keep version iteration
   for example support for go1.17 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] hongbinhsu commented on issue #2307: update golang-jwt/jwt to v4

2022-02-08 Thread GitBox


hongbinhsu commented on issue #2307:
URL: 
https://github.com/apache/apisix-dashboard/issues/2307#issuecomment-1033286306


   > Hi there, @hongbinhsu why need to update jwt version ?
   
   Keep version iteration
   for example support for go1.17 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Drery commented on a change in pull request #5940: feat: mocking plugin

2022-02-08 Thread GitBox


Drery commented on a change in pull request #5940:
URL: https://github.com/apache/apisix/pull/5940#discussion_r802221664



##
File path: docs/zh/latest/plugins/mocking.md
##
@@ -0,0 +1,234 @@
+---
+title: mocking
+---
+
+
+
+## 目录
+
+- [**简介**](#简介)
+- [**属性**](#属性)
+- [**如何启用**](#如何启用)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+
+## 简介
+
+Mock API插件,绑定该插件后将随机返回指定格式的mock数据,不再转发到后端。
+
+## 属性
+
+| 名称| 类型| 必选项 | 默认值 | 有效值  
  | 描述  

|
+| -   | ---| - | - | 
-- | 
-
 |
+| delay   | integer | 可选 ||
 | 延时返回的时间,单位为秒 
   |
+| response_status | integer| 可选  | 200 |   
  | 返回的响应http status code   
 |
+| content_type| string | 可选  | application/json |  
   | 返回的响应头的Content-Type。   
 |
+| response_example| string | 可选  ||
 | 返回的响应体,与response_schema二选一   
 |
+| response_schema | object | 可选  ||
 | 指定响应的json 
schema对象,未指定response_example时生效,具体结构看后文说明   
 |
+| with_mock_header | boolean | 可选 | true  |
 | 是否返回响应头:"x-mock-by: 
APISIX/{version}",默认返回,指定为false则不返回|
+
+支持的字段类型:`string`, `number`, `integer`, `boolean`, `object`, `array`
+基础数据类型(string,number,integer,boolean)可通过配置example属性指定生成的响应值,未配置时随机返回。
+以下是一个JSON-Schema实例:
+
+```json
+{
+"properties":{
+"field0":{
+"example":"abcd",
+"type":"string"
+},
+"field1":{
+"example":123.12,
+"type":"number"
+},
+"field3":{
+"properties":{
+"field3_1":{
+"type":"string"
+},
+"field3_2":{
+"properties":{
+"field3_2_1":{
+"example":true,
+"type":"boolean"
+},
+"field3_2_2":{
+"items":{
+"example":155.55,
+"type":"integer"
+},
+"type":"array"
+}
+},
+"type":"object"
+}
+},
+"type":"object"
+},
+"field2":{
+"items":{
+"type":"string"
+},
+"type":"array"
+}
+},
+"type":"object"
+}
+```
+
+以下为该JSON-Schema可能生成的返回对象:
+
+```json
+{
+"field1": 123.12,
+"field3": {
+"field3_1": "LCFE0",
+"field3_2": {
+"field3_2_1": true,
+"field3_2_2": [
+155,
+155
+]
+}
+},
+"field0": "abcd",
+"field2": [
+"sC"
+]
+}
+```
+
+## 如何启用
+
+这里以`route`为例(`service`的使用是同样的方法),在指定的 `route` 上启用 `mocking` 插件。
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"methods": ["GET"],
+"uri": "/index.html",
+"plugins": {
+"mocking": {
+"delay": 1,
+"content_type": "application/json",
+"response_status": 200,
+"response_schema": {
+   "properties":{
+   "field0":{
+   "example":"abcd",
+   "type":"string"
+   },
+   "field1":{
+   "example":123.12,
+   "type":"number"
+   },
+   "field3":{
+   "properties":{
+   "field3_1":{
+   "type":"string"
+   },
+   "field3_2":{
+   "properties":{
+   "field3_2_1":{
+   "example":true,
+   "type":"boolean"
+   },
+   "field3_2_2":{
+   

[GitHub] [apisix] Drery commented on a change in pull request #5940: feat: mocking plugin

2022-02-08 Thread GitBox


Drery commented on a change in pull request #5940:
URL: https://github.com/apache/apisix/pull/5940#discussion_r802221664



##
File path: docs/zh/latest/plugins/mocking.md
##
@@ -0,0 +1,234 @@
+---
+title: mocking
+---
+
+
+
+## 目录
+
+- [**简介**](#简介)
+- [**属性**](#属性)
+- [**如何启用**](#如何启用)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+
+## 简介
+
+Mock API插件,绑定该插件后将随机返回指定格式的mock数据,不再转发到后端。
+
+## 属性
+
+| 名称| 类型| 必选项 | 默认值 | 有效值  
  | 描述  

|
+| -   | ---| - | - | 
-- | 
-
 |
+| delay   | integer | 可选 ||
 | 延时返回的时间,单位为秒 
   |
+| response_status | integer| 可选  | 200 |   
  | 返回的响应http status code   
 |
+| content_type| string | 可选  | application/json |  
   | 返回的响应头的Content-Type。   
 |
+| response_example| string | 可选  ||
 | 返回的响应体,与response_schema二选一   
 |
+| response_schema | object | 可选  ||
 | 指定响应的json 
schema对象,未指定response_example时生效,具体结构看后文说明   
 |
+| with_mock_header | boolean | 可选 | true  |
 | 是否返回响应头:"x-mock-by: 
APISIX/{version}",默认返回,指定为false则不返回|
+
+支持的字段类型:`string`, `number`, `integer`, `boolean`, `object`, `array`
+基础数据类型(string,number,integer,boolean)可通过配置example属性指定生成的响应值,未配置时随机返回。
+以下是一个JSON-Schema实例:
+
+```json
+{
+"properties":{
+"field0":{
+"example":"abcd",
+"type":"string"
+},
+"field1":{
+"example":123.12,
+"type":"number"
+},
+"field3":{
+"properties":{
+"field3_1":{
+"type":"string"
+},
+"field3_2":{
+"properties":{
+"field3_2_1":{
+"example":true,
+"type":"boolean"
+},
+"field3_2_2":{
+"items":{
+"example":155.55,
+"type":"integer"
+},
+"type":"array"
+}
+},
+"type":"object"
+}
+},
+"type":"object"
+},
+"field2":{
+"items":{
+"type":"string"
+},
+"type":"array"
+}
+},
+"type":"object"
+}
+```
+
+以下为该JSON-Schema可能生成的返回对象:
+
+```json
+{
+"field1": 123.12,
+"field3": {
+"field3_1": "LCFE0",
+"field3_2": {
+"field3_2_1": true,
+"field3_2_2": [
+155,
+155
+]
+}
+},
+"field0": "abcd",
+"field2": [
+"sC"
+]
+}
+```
+
+## 如何启用
+
+这里以`route`为例(`service`的使用是同样的方法),在指定的 `route` 上启用 `mocking` 插件。
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"methods": ["GET"],
+"uri": "/index.html",
+"plugins": {
+"mocking": {
+"delay": 1,
+"content_type": "application/json",
+"response_status": 200,
+"response_schema": {
+   "properties":{
+   "field0":{
+   "example":"abcd",
+   "type":"string"
+   },
+   "field1":{
+   "example":123.12,
+   "type":"number"
+   },
+   "field3":{
+   "properties":{
+   "field3_1":{
+   "type":"string"
+   },
+   "field3_2":{
+   "properties":{
+   "field3_2_1":{
+   "example":true,
+   "type":"boolean"
+   },
+   "field3_2_2":{
+   

[GitHub] [apisix] leslie-tsang commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


leslie-tsang commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033282779


   @pcyan The route method has been set to `POST`, you should add `-X POST` in 
your curl CMD.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2308: chore : update to github.com/golang-jwt/jwt/v4

2022-02-08 Thread GitBox


codecov-commenter edited a comment on pull request #2308:
URL: 
https://github.com/apache/apisix-dashboard/pull/2308#issuecomment-1032737085


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2308](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (e717933) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/758c43262a3ae26d6f4a51e2f0a765842b66936d?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (758c432) will **increase** coverage by `1.30%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2308  +/-   ##
   ==
   + Coverage   69.91%   71.22%   +1.30% 
   ==
 Files 184   57 -127 
 Lines7280 3906-3374 
 Branches  8300 -830 
   ==
   - Hits 5090 2782-2308 
   + Misses   1896  828-1068 
   - Partials  294  296   +2 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `36.76% <100.00%> (-0.49%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `59.39% <100.00%> (-0.21%)` | :arrow_down: |
   | backend-unit-test | `49.22% <100.00%> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `77.77% <100.00%> (ø)` | |
   | 
[.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=)
 | `100.00% <100.00%> (ø)` | |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `47.24% <0.00%> (-3.94%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `89.58% <0.00%> (-1.05%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `92.74% <0.00%> (-0.81%)` | :arrow_down: |
   | 
[web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=)
 | | |
   | 
[web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=)
 | | |
   | 

[GitHub] [apisix] zhixiongdu027 commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802220178



##
File path: apisix/discovery/kubernetes/init.lua
##
@@ -29,7 +29,10 @@ local core = require("apisix.core")
 local util = require("apisix.cli.util")
 local local_conf = require("apisix.core.config_local").local_conf()
 local informer_factory = 
require("apisix.discovery.kubernetes.informer_factory")
-local endpoint_dict = ngx.shared.discovery
+local endpoint_dict = ngx.shared["discovery"]
+if not endpoint_dict then
+error("failed to get ngx.shared.dict discovery when load kubernetes 
discovery plugin ")

Review comment:
   Now, I Had move it  into function init_worker()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on a change in pull request #6242: fix(redirect-plugin): redirection loop behind a proxy or lb

2022-02-08 Thread GitBox


tzssangglass commented on a change in pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#discussion_r802219849



##
File path: t/plugin/redirect.t
##
@@ -1000,3 +1000,44 @@ Location: /hello?type=string=json
 --- error_code: 302
 --- no_error_log
 [error]
+
+
+
+=== TEST 41: redirect

Review comment:
   ```suggestion
   === TEST 41: enable http_to_https (pass X-Forwarded-Proto)
   ```

##
File path: t/plugin/redirect.t
##
@@ -1000,3 +1000,44 @@ Location: /hello?type=string=json
 --- error_code: 302
 --- no_error_log
 [error]
+
+
+
+=== TEST 41: redirect
+--- config
+location /t {
+content_by_lua_block {
+local t = require("plugin.redirect").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[[{
+"uri": "/hello",
+"host": "foo.com",
+"vars": [
+[
+"scheme",
+"==",
+"http"
+]
+],
+"plugins": {
+"redirect": {
+"uri": "https://$host$request_uri;,
+"ret_code": 301
+}
+}
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]

Review comment:
   and add a test case like 
   
   
   ```
   === TEST 2: enable http_to_https (pass X-Forwarded-Proto)
   --- request
   GET /hello
   --- more_headers
   Host: foo.com
   X-Forwarded-Proto: http
   --- error_code: 301
   --- response_headers
   Location: https://foo.com/hello
   ```

##
File path: t/plugin/redirect.t
##
@@ -1000,3 +1000,44 @@ Location: /hello?type=string=json
 --- error_code: 302
 --- no_error_log
 [error]
+
+
+
+=== TEST 41: redirect
+--- config
+location /t {
+content_by_lua_block {
+local t = require("plugin.redirect").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[[{
+"uri": "/hello",
+"host": "foo.com",
+"vars": [
+[
+"scheme",
+"==",
+"http"
+]
+],
+"plugins": {
+"redirect": {
+"uri": "https://$host$request_uri;,
+"ret_code": 301

Review comment:
   ```suggestion
   "http_to_https": true
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John edited a comment on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033276700


   In my experience, try removing the '-i' from the request configuration 
command first.
   ```
   curl http://localhost:9080/apisix/admin/routes/7 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
   "methods": ["POST"],
   "name":"mockGetUser",
   "uri": "/v2/c4d7a195/graphql",
   "vars": [
   ["graphql_operation", "==", "query"],
   ["graphql_name", "==", "getUser"]
   ],
   "upstream": {
   "type": "roundrobin",
   "nodes": {
   "api.mocki.io": 1
   }
   }
   }'
   ```
   If that doesn't work, try looking at the log, and I'll cover the entire 
troubleshooting process later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


Chever-John commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033276700


   In my experience, try removing the '-i' from the request configuration 
command first.
   
   If that doesn't work, try looking at the log, and I'll cover the entire 
troubleshooting process later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] nic-6443 commented on issue #850: bug: the secret controller cannot handle secret update events in sometime

2022-02-08 Thread GitBox


nic-6443 commented on issue #850:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/850#issuecomment-1033272503


   Okay, we will try to test with the latest version of the ingress controller 
and sync up if we get any new clues


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] SkyeYoung commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


SkyeYoung commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033264944


   > Why not just give the tip to install the LTS version in step 1? 
   
   Just like 
[here](https://apisix.apache.org/zh/docs/apisix/getting-started#:~:text=Apache%20APISIX%20%E5%B7%B2%E6%94%AF%E6%8C%81%20ARM64%20%E6%9E%B6%E6%9E%84%E3%80%82%E5%A6%82%E6%9E%9C%E6%82%A8%E6%AD%A3%E5%9C%A8%E4%BD%BF%E7%94%A8%20ARM64%EF%BC%8C%E8%AF%B7%E5%9C%A8%E6%9C%80%E5%90%8E%E4%B8%80%E6%AD%A5%E6%89%A7%E8%A1%8C%20docker%2Dcompose%20%2Dp%20docker%2Dapisix%20%2Df%20docker%2Dcompose%2Darm64.yml%20up%20%2Dd%E3%80%82)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] stutipatelorigo opened a new issue #2309: How to use BASIC AUTH header inside header override or a plugin for a particular service only

2022-02-08 Thread GitBox


stutipatelorigo opened a new issue #2309:
URL: https://github.com/apache/apisix-dashboard/issues/2309


   # Feature request
   
   Suppose, I have a third party api which requires basic authentication to 
fetch request. But all i have is user info to pass on. Is it possible to add 
basic auth header directly to the service or route 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] yaule opened a new pull request #6270: feat(oidc): add set_userinfo_detail_header

2022-02-08 Thread GitBox


yaule opened a new pull request #6270:
URL: https://github.com/apache/apisix/pull/6270


   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] SkyeYoung commented on issue #871: A strange problem caused by switching color modes in multiple tabs

2022-02-08 Thread GitBox


SkyeYoung commented on issue #871:
URL: https://github.com/apache/apisix-website/issues/871#issuecomment-1033254918


   @Baoyuantop in multiple tabs? I found that only in the same tab is the case 
you described. I will give my chrome info below. 
   
   
   Chrome Info
   
   
   Google Chrome | 97.0.4692.99 (Official Build) (64-bit)
   -- | --
   Revision | 
d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
   OS | Linux
   JavaScript | V8 9.7.106.19
   User Agent | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like 
Gecko) Chrome/97.0.4692.99 Safari/537.36
   Command Line | /opt/google/chrome/google-chrome --enable-crashpad 
--flag-switches-begin --flag-switches-end 
--origin-trial-disabled-features=CaptureHandle
   
   
   
   Although I only give the infomation about Chrome in Linux, I also reproduced 
this problem in Windows. In fact, the GIF was recorded in Windows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] jwrookie commented on issue #2292: 希望支持设置密文密码,而不是明文密码。同时为登陆增加简单的登陆尝试限制

2022-02-08 Thread GitBox


jwrookie commented on issue #2292:
URL: 
https://github.com/apache/apisix-dashboard/issues/2292#issuecomment-1033252677


   MFA(Multi-Factor Authentication) can help us, and also not recommended to 
open it to the public network


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2306: web build in node 16 rjsf/core version to lower

2022-02-08 Thread GitBox


Baoyuantop commented on issue #2306:
URL: 
https://github.com/apache/apisix-dashboard/issues/2306#issuecomment-1033251417


   You can refer to 
https://github.com/ant-design/ant-design-pro/blob/master/package.json


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] Baoyuantop commented on issue #871: A strange problem caused by switching color modes in multiple tabs

2022-02-08 Thread GitBox


Baoyuantop commented on issue #871:
URL: https://github.com/apache/apisix-website/issues/871#issuecomment-1033245285


   I noticed that after switching to dark mode on other pages, it automatically 
changes back to the light mode when I return to the home page of the site.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on a change in pull request #6242: fix(redirect-plugin): redirection loop behind a proxy or lb

2022-02-08 Thread GitBox


tzssangglass commented on a change in pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#discussion_r802196294



##
File path: apisix/plugins/redirect.lua
##
@@ -150,7 +150,9 @@ function _M.rewrite(conf, ctx)
 local uri = conf.uri
 local regex_uri = conf.regex_uri
 
-if conf.http_to_https and ctx.var.scheme == "http" then
+local proxy_proto = core.request.header(ctx, "x-forwarded-proto")
+local _scheme = proxy_proto or ctx.var.scheme

Review comment:
   ```suggestion
   local proxy_proto = core.request.header(ctx, "X-Forwarded-Proto")
   local _scheme = proxy_proto or core.request.get_scheme(ctx)
   ```

##
File path: t/plugin/redirect.t
##
@@ -1000,3 +1000,44 @@ Location: /hello?type=string=json
 --- error_code: 302
 --- no_error_log
 [error]
+
+
+
+=== TEST 41: redirect
+--- config
+location /t {
+content_by_lua_block {
+local t = require("plugin.redirect").test

Review comment:
   ```suggestion
   local t = require("lib.test_admin").test
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhixiongdu027 commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802189698



##
File path: apisix/discovery/kubernetes/init.lua
##
@@ -29,7 +29,10 @@ local core = require("apisix.core")
 local util = require("apisix.cli.util")
 local local_conf = require("apisix.core.config_local").local_conf()
 local informer_factory = 
require("apisix.discovery.kubernetes.informer_factory")
-local endpoint_dict = ngx.shared.discovery
+local endpoint_dict = ngx.shared["discovery"]
+if not endpoint_dict then
+error("failed to get ngx.shared.dict discovery when load kubernetes 
discovery plugin ")

Review comment:
   Sorry,  I didn't get your point.
   Your means is error mesage not clear ?
   
   Maybe your means is   local endpoit_dict = ngx.shared.discovery or 
error("") ?
   
   Or move local endpoint_dict  into function  init_worker()  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] Baoyuantop commented on a change in pull request #870: chore:add the LTS download button of 'apisix'

2022-02-08 Thread GitBox


Baoyuantop commented on a change in pull request #870:
URL: https://github.com/apache/apisix-website/pull/870#discussion_r802195668



##
File path: website/src/pages/downloads/ProjectCard.js
##
@@ -112,12 +156,47 @@ const ProjectCard = (props) => {
   Release Date ·{" "}
   {releaseDate}
 
-
+
+ 
+  
+  
+  
+https://www.apache.org/dyn/closer.cgi/apisix/2.10.3/apache-apisix-2.10.3-src.tgz`}

Review comment:
   As the version is updated we may need to be more flexible with this 
link?樂




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhixiongdu027 commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802189698



##
File path: apisix/discovery/kubernetes/init.lua
##
@@ -29,7 +29,10 @@ local core = require("apisix.core")
 local util = require("apisix.cli.util")
 local local_conf = require("apisix.core.config_local").local_conf()
 local informer_factory = 
require("apisix.discovery.kubernetes.informer_factory")
-local endpoint_dict = ngx.shared.discovery
+local endpoint_dict = ngx.shared["discovery"]
+if not endpoint_dict then
+error("failed to get ngx.shared.dict discovery when load kubernetes 
discovery plugin ")

Review comment:
   Sorry,  I didn't get your point.
   Your means is error mesage not clear ?
   
   Maybe your means is   local endpoit_dict = ngx.shared.discovery or 
error("") ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] SkyeYoung commented on pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


SkyeYoung commented on pull request #6269:
URL: https://github.com/apache/apisix/pull/6269#issuecomment-1033227734


   Why not just give the tip to install the LTS version in step 1? Now I had to 
jump back to step 1 and look at it again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhixiongdu027 commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802189698



##
File path: apisix/discovery/kubernetes/init.lua
##
@@ -29,7 +29,10 @@ local core = require("apisix.core")
 local util = require("apisix.cli.util")
 local local_conf = require("apisix.core.config_local").local_conf()
 local informer_factory = 
require("apisix.discovery.kubernetes.informer_factory")
-local endpoint_dict = ngx.shared.discovery
+local endpoint_dict = ngx.shared["discovery"]
+if not endpoint_dict then
+error("failed to get ngx.shared.dict discovery when load kubernetes 
discovery plugin ")

Review comment:
   Sorry,  I didn't get your point.
   Your means is error mesage not clear ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tokers commented on issue #850: bug: the secret controller cannot handle secret update events in sometime

2022-02-08 Thread GitBox


tokers commented on issue #850:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/850#issuecomment-1033224383


   > Yes
   
   We may try to reproduce this problem with the standard version. @nic-6443 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] pcyan commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-08 Thread GitBox


pcyan commented on issue #6266:
URL: https://github.com/apache/apisix/issues/6266#issuecomment-1033224262


   @tzssangglass 
   1. 一个正常的graphql请求
   ```bash
   curl 'https://api.mocki.io/v2/c4d7a195/graphql' \
 -H 'authority: api.mocki.io' \
 -H 'accept: */*' \
 -H 'content-type: application/json' \
 -H 'origin: https://api.mocki.io' \
 --data-raw '{"operationName":"getUser","variables":{},"query":"query 
getUser {\n  user(id: \"4dc70521-22bb-4396-b37a-4a927c66d43b\") {\nid\n
email\nname\n  }\n}\n"}' \
 --compressed
   ```
   会返回
   ```json
   {
 "data": {
   "user": {
 "id": "Hello World",
 "email": "Hello World",
 "name": "Hello World"
   }
 }
   }
   ```
   2. 
参照[apisix官方文档](https://apisix.apache.org/zh/docs/apisix/router-radixtree#%E5%A6%82%E4%BD%95%E9%80%9A%E8%BF%87-graphql-%E5%B1%9E%E6%80%A7%E8%BF%87%E6%BB%A4%E8%B7%AF%E7%94%B1),通过apisix配置
   ```bash
   ### 添加测试的graphql请求
   curl http://localhost:9080/apisix/admin/routes/7 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
   {
   "methods": ["POST"],
   "name":"mockGetUser",
   "uri": "/v2/c4d7a195/graphql",
   "vars": [
   ["graphql_operation", "==", "query"],
   ["graphql_name", "==", "getUser"]
   ],
   "upstream": {
   "type": "roundrobin",
   "nodes": {
   "api.mocki.io": 1
   }
   }
   }'
   
   ### apisix graphql
   curl 'https://localhost:9080/v2/c4d7a195/graphql' \
 -H 'authority: api.mocki.io' \
 -H 'accept: */*' \
 -H 'content-type: application/json' \
 -H 'origin: https://api.mocki.io' \
 --data-raw '{"operationName":"getUser","variables":{},"query":"query 
getUser {\n  user(id: \"4dc70521-22bb-4396-b37a-4a927c66d43b\") {\nid\n
email\nname\n  }\n}\n"}' \
 --compressed
   ```
   
   会返回
   ```json
   {
 "error_msg": "404 Route Not Found"
   }
   ```
   
   错误日志是` ctx.lua:80: get_parsed_graphql(): failed to parse graphql: Syntax 
error near line 1 body:`
   麻烦你也试一下,或者告诉我是哪里配置错了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhixiongdu027 commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802187707



##
File path: apisix/discovery/kubernetes/informer_factory.lua
##
@@ -152,48 +152,47 @@ local function split_event (body, dispatch_event)
 remainder_body = string.sub(body, captured_size + 1)
 end
 
-return remainder_body, "Success", nil
+return remainder_body, "Success"

Review comment:
   ```lua   
remainder_body, reason, err = split_event(body, dispatch_event, 
informer)
   if reason ~= "Success" then
   if reason == "ResourceGone" then
   return true
   end
   return false, reason, err
   end
   ```
   
   "Success" makes sense here because the code above will use it.
   If there is no "Success", 
   how can only use remainder_body is nil as a detection method, 
   I think this is not a good code style
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhixiongdu027 commented on a change in pull request #4880: feat: add kubernetes discovery module

2022-02-08 Thread GitBox


zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802187707



##
File path: apisix/discovery/kubernetes/informer_factory.lua
##
@@ -152,48 +152,47 @@ local function split_event (body, dispatch_event)
 remainder_body = string.sub(body, captured_size + 1)
 end
 
-return remainder_body, "Success", nil
+return remainder_body, "Success"

Review comment:
   ```lua   
remainder_body, reason, err = split_event(body, dispatch_event, 
informer)
   if reason ~= "Success" then
   if reason == "ResourceGone" then
   return true
   end
   return false, reason, err
   end
   ```
   
   "Success" makes sense here because the code above will use it.
   If there is no "Success", 
   how can only use remain_body is nil as a detection method, 
   I think this is not a good code style
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] HelloBug0 edited a comment on issue #6078: request help: Use plugin redirect for http_to_https,the browser access unlimited 301.

2022-02-08 Thread GitBox


HelloBug0 edited a comment on issue #6078:
URL: https://github.com/apache/apisix/issues/6078#issuecomment-1032595558


   If parameter http_to_https is true, the response status is 301 or 308. When 
we configure uri or regex_uri, I think the parameter ret_code may be not 
meaningful.  And because of the difference of method, get or post, we can get 
two different response status, 301 or 308 as for one uri. Also, If we configure 
parameter ret_code 200, the brower won't redirect it anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Chever-John opened a new pull request #6269: docs: added installation mode for LTS version

2022-02-08 Thread GitBox


Chever-John opened a new pull request #6269:
URL: https://github.com/apache/apisix/pull/6269


   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] seanleblanc edited a comment on issue #6260: request help: JWT Auth

2022-02-08 Thread GitBox


seanleblanc edited a comment on issue #6260:
URL: https://github.com/apache/apisix/issues/6260#issuecomment-1033063150


   > > it fails with a 401 for caller, and the apisix pod log shows 
openid-connect.lua:268: phase_func(): OIDC introspection failed: response 
indicates failure, status=401
   > 
   > It seems APISIX requested to the `introspection_endpoint` but got 401 from 
the `introspection_endpoint`.
   > 
   > Can you check the log of the introspection_endpoint?
   
   Thanks. I had not even defined one. After I added one, it is giving me a 405 
now - no resource method found for POST. We are using Keycloak, I've tried 
setting 
https://{keycloakhost}/auth/realms/{realm}/.well-known/openid-configuration as 
well as the /certs path 
(https://{keycloakhost}/auth/realms/{realm}/protocol/openid-connect/certs), and 
neither work. 
   
   Is there an example config with Keycloak that would work for this? Is it 
trying to authenticate to Keycloak at some point? As mentioned above, I am 
trying to get equivalent functionality to what Istio's RequestAuthentication 
and AuthorizationPolicy objects do - they use similar endpoints to retrieve 
cert(s) to validate JWT (and I have this working with Istio, so I know the 
Keycloak/JWTs it emits should work). Am I using the right plugin for this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] seanleblanc edited a comment on issue #6260: request help: JWT Auth

2022-02-08 Thread GitBox


seanleblanc edited a comment on issue #6260:
URL: https://github.com/apache/apisix/issues/6260#issuecomment-1033059506


   > we have JWT plugin, see 
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/jwt-auth.md
   > 
   > Please describe the scenario in detail, I can't get to your needs.
   
   I'm trying to get apisix to do do authz on a route. I want it to look at the 
Authentication header to inspect JWT token and that it has proper scope(s) on 
it and then either pass on the request - or reject it. Much like what Istio 
does with RequestAuthentication and AuthorizationPolicy objects.
   
   In the first case, I'm trying to get it to do this with KeyCloak, if that 
helps at all. Though we will likely swap out KeyCloak for other token 
providers, depending on environment/project we are on.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] seanleblanc edited a comment on issue #6260: request help: JWT Auth

2022-02-08 Thread GitBox


seanleblanc edited a comment on issue #6260:
URL: https://github.com/apache/apisix/issues/6260#issuecomment-1033063150


   > > it fails with a 401 for caller, and the apisix pod log shows 
openid-connect.lua:268: phase_func(): OIDC introspection failed: response 
indicates failure, status=401
   > 
   > It seems APISIX requested to the `introspection_endpoint` but got 401 from 
the `introspection_endpoint`.
   > 
   > Can you check the log of the introspection_endpoint?
   
   Thanks. I had not even defined one. After I added one, it is giving me a 405 
now - no resource method found for POST. We are using Keycloak, I've tried 
setting 
https://{keycloakhost}/auth/realms/{realm}/.well-known/openid-configuration as 
well as the /certs path, and neither work. 
   
   Is there an example config with Keycloak that would work for this? Is it 
trying to authenticate to Keycloak at some point? As mentioned above, I am 
trying to get equivalent functionality to what Istio's RequestAuthentication 
and AuthorizationPolicy objects do - they use similar endpoints to retrieve 
cert(s) to validate JWT (and I have this working with Istio, so I know the 
Keycloak/JWTs it emits should work). Am I using the right plugin for this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] seanleblanc commented on issue #6260: request help: JWT Auth

2022-02-08 Thread GitBox


seanleblanc commented on issue #6260:
URL: https://github.com/apache/apisix/issues/6260#issuecomment-1033063150


   > > it fails with a 401 for caller, and the apisix pod log shows 
openid-connect.lua:268: phase_func(): OIDC introspection failed: response 
indicates failure, status=401
   > 
   > It seems APISIX requested to the `introspection_endpoint` but got 401 from 
the `introspection_endpoint`.
   > 
   > Can you check the log of the introspection_endpoint?
   
   Thanks. I had not even defined one. After I added one, it is giving me a 405 
now - no resource method found for POST. We are using Keycloak, I've tried 
setting 
https://{keycloakhost}/auth/realms/{realm}/.well-known/openid-configuration as 
well as the /certs path, and neither work. 
   
   Is there an example config with Keycloak that would work for this? Is it 
trying to authenticate to Keycloak at some point? As mentioned above, I am 
trying to get equivalent functionality to what Istio's RequestAuthentication 
and AuthorizationPolicy objects do - they use similar endpoints to retrieve 
cert(s) to validate JWT. Am I using the right plugin for this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #853: question: How to use Service IP as upstream instead of Pod IP

2022-02-08 Thread GitBox


tao12345666333 commented on issue #853:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/853#issuecomment-1033059652


   thank you for your message. let me confirm again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] seanleblanc commented on issue #6260: request help: JWT Auth

2022-02-08 Thread GitBox


seanleblanc commented on issue #6260:
URL: https://github.com/apache/apisix/issues/6260#issuecomment-1033059506


   > we have JWT plugin, see 
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/jwt-auth.md
   > 
   > Please describe the scenario in detail, I can't get to your needs.
   
   I'm trying to get apisix to do do authz on a route. I want it to look at the 
Authentication header to inspect JWT token and that it has proper scope(s) on 
it and then either pass on the request - or reject it. Much like what Istio 
does with AuthenticationPolicy and AuthorizationPolicy objects.
   
   In the first case, I'm trying to get it to do this with KeyCloak, if that 
helps at all. Though we will likely swap out KeyCloak for other token 
providers, depending on environment/project we are on.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-website] DevGautam2000 commented on issue #667: feat: add Apache APISIX dashboard playground on website

2022-02-08 Thread GitBox


DevGautam2000 commented on issue #667:
URL: https://github.com/apache/apisix-website/issues/667#issuecomment-1033009978


   Would like to work on this issue
   Please assign this to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] MirtoBusico commented on issue #853: question: How to use Service IP as upstream instead of Pod IP

2022-02-08 Thread GitBox


MirtoBusico commented on issue #853:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/853#issuecomment-1032916023


   @tao12345666333 Sorry it is a real bug. Please reopen
   
   After three or four times that I restart the cluster (it is a lab framework: 
start on the morning and shutdown on the night) the route takes a POD address 
again.
   
   The same framework used in my previous reply now shows:
   Route definition, service addresses and pod addresses
   ```
   sysop@m01serv:~/software/apisisx$ cat productpage-ar.yaml 
   apiVersion: apisix.apache.org/v2beta2
   kind: ApisixRoute
   metadata:
 name: productpage
   spec:
 http:
 - name: rule1
   match:
 hosts:
 - www2.m01.net
 paths:
 - /*
   backends:
   - serviceName: productpage
 servicePort: 9080
 resolveGranularity: service
   
   sysop@m01serv:~/software/apisisx$ kubectl get svc -n bookinfo
   NAME  TYPECLUSTER-IP  EXTERNAL-IP   PORT(S)AGE
   details   ClusterIP   10.43.230.138   9080/TCP   13d
   ratings   ClusterIP   10.43.16.57 9080/TCP   13d
   reviews   ClusterIP   10.43.236.529080/TCP   13d
   productpage   ClusterIP   10.43.189.220   9080/TCP   13d
   sysop@m01serv:~/software/apisisx$ 
   sysop@m01serv:~/software/apisisx$ kubectl get pods -n bookinfo -o wide
   NAME  READY   STATUSRESTARTS  AGE   IP   
 NODE NOMINATED NODE   READINESS GATES
   reviews-v3-5cddf46b56-x2hbz   2/2 Running   10 (9h ago)   9d
10.42.2.210   m01kw2  
   details-v1-65fff9896-fw7qv2/2 Running   10 (9h ago)   9d
10.42.1.244   m01kw1  
   reviews-v1-d7f5b879b-bf7tz2/2 Running   10 (9h ago)   9d
10.42.1.4 m01kw1  
   productpage-v1-77748558b4-w2h2h   2/2 Running   10 (9h ago)   9d
10.42.1.2 m01kw1  
   ratings-v1-5db74dc944-5z2rz   2/2 Running   10 (9h ago)   9d
10.42.0.17m01km   
   reviews-v2-6fcf6d48b4-bvtzn   2/2 Running   10 (9h ago)   9d
10.42.0.23m01km   
   sysop@m01serv:~/software/apisisx$ 
   
   ```
   The route definition taken from the apisix dashboard:
   ```
   nodes:
 - host: 10.42.1.232
   port: 9080
   weight: 100
   type: roundrobin
   hash_on: vars
   scheme: http
   pass_host: pass
   name: bookinfo_productpage_9080
   desc: Created by apisix-ingress-controller, DO NOT modify it manually
   labels:
 managed-by: apisix-ingress-controller
   
   ```
   Clearly the route don't work
   I cannot figure out why the address changes.
   
   BTW another route defined using the apisix dashboard continues to work 
regularly
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on issue #2306: web build in node 16 rjsf/core version to lower

2022-02-08 Thread GitBox


zaunist commented on issue #2306:
URL: 
https://github.com/apache/apisix-dashboard/issues/2306#issuecomment-1032849956


   Expect dashboard to support node 16.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on issue #2307: update golang-jwt/jwt to v4

2022-02-08 Thread GitBox


zaunist commented on issue #2307:
URL: 
https://github.com/apache/apisix-dashboard/issues/2307#issuecomment-1032845226


   Hi there, @hongbinhsu why need to update jwt version ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2308: chore : update to github.com/golang-jwt/jwt/v4

2022-02-08 Thread GitBox


codecov-commenter edited a comment on pull request #2308:
URL: 
https://github.com/apache/apisix-dashboard/pull/2308#issuecomment-1032737085


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2308](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (fbcf763) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/758c43262a3ae26d6f4a51e2f0a765842b66936d?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (758c432) will **decrease** coverage by `5.88%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@Coverage Diff @@
   ##   master#2308  +/-   ##
   ==
   - Coverage   69.91%   64.02%   -5.89% 
   ==
 Files 184   57 -127 
 Lines7280 3906-3374 
 Branches  8300 -830 
   ==
   - Hits 5090 2501-2589 
   + Misses   1896 1047 -849 
   - Partials  294  358  +64 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `36.86% <100.00%> (-0.39%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `59.39% <100.00%> (-0.21%)` | :arrow_down: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `55.55% <100.00%> (-22.23%)` | :arrow_down: |
   | 
[.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=)
 | `90.47% <100.00%> (-9.53%)` | :arrow_down: |
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `5.55% <0.00%> (-61.12%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `65.62% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `68.54% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `68.11% <0.00%> (-17.40%)` | :arrow_down: |
   | 

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2308: chore : update to github.com/golang-jwt/jwt/v4

2022-02-08 Thread GitBox


codecov-commenter commented on pull request #2308:
URL: 
https://github.com/apache/apisix-dashboard/pull/2308#issuecomment-1032737085


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2308](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (fbcf763) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/758c43262a3ae26d6f4a51e2f0a765842b66936d?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (758c432) will **decrease** coverage by `33.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/graphs/tree.svg?width=650=150=pr=Q1HERXN96P_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#2308   +/-   ##
   ===
   - Coverage   69.91%   36.86%   -33.06% 
   ===
 Files 184   57  -127 
 Lines7280 3906 -3374 
 Branches  8300  -830 
   ===
   - Hits 5090 1440 -3650 
   - Misses   1896 2196  +300 
   + Partials  294  270   -24 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `36.86% <100.00%> (-0.39%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2308?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `44.44% <100.00%> (-33.34%)` | :arrow_down: |
   | 
[.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=)
 | `90.47% <100.00%> (-9.53%)` | :arrow_down: |
   | 
[api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==)
 | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
   | 
[api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==)
 | `20.00% <0.00%> (-80.00%)` | :arrow_down: |
   | 
[api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv)
 | `0.00% <0.00%> (-76.20%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `10.34% <0.00%> (-75.87%)` | :arrow_down: |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2308/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `28.00% <0.00%> (-72.00%)` | :arrow_down: |
   | 

[GitHub] [apisix-dashboard] hongbinhsu opened a new pull request #2308: chore : update to github.com/golang-jwt/jwt/v4

2022-02-08 Thread GitBox


hongbinhsu opened a new pull request #2308:
URL: https://github.com/apache/apisix-dashboard/pull/2308


   Please answer these questions before submitting a pull request, **or your PR 
will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Improve performance
   
   **What changes will this PR take into?**
   
   Use latest 4.2.0 version,
   Starting with v4.0.0 this project adds Go module support, but maintains 
backwards compatibility with older v3.x.y tags
   
   **Related issues**
   
   resolve #2307
   
   **Checklist:**
   
   - [ ] keep golang-jwt/jwt use latest version
   - [ ] added corresponding test cases
   - [ ] modified the corresponding document, go version 1.13 to 1.15
   - [ ] Is this PR backward compatible
   
   test api /apisix/admin/user/login success
   
   `{
   "code": 0,
   "message": "",
   "data": {
   "token": 
"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJhZG1pbiIsImV4cCI6MTY0NDMzNjg1NCwiaWF0IjoxNjQ0MzMzMjU0fQ.prTnPWvTDRezEwew03j3lELYXn2HUuArdM3ToA7YwT0"
   },
   "request_id": "a90c0a8f-c859-478b-bef8-ced7846d14b5"
   }`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] hongbinhsu opened a new issue #2307: update golang-jwt/jwt to v4

2022-02-08 Thread GitBox


hongbinhsu opened a new issue #2307:
URL: https://github.com/apache/apisix-dashboard/issues/2307


   # Feature request
   
   ## Please describe your feature
   
   update golang-jwt/jwt to latest version (v4),upgrade version 
   
   ## Describe the solution you'd like
   
   A clear and concise description of what you want to happen.
   
   ## Describe alternatives you've considered
   
   A clear and concise description of any alternative solutions or features 
you've considered.
   
   ## Additional context
   
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 edited a comment on issue #2285: request help: dashboards are not refreshed after the update is successful

2022-02-08 Thread GitBox


bzp2010 edited a comment on issue #2285:
URL: 
https://github.com/apache/apisix-dashboard/issues/2285#issuecomment-1032680707






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] bzp2010 commented on issue #2285: request help: dashboards are not refreshed after the update is successful

2022-02-08 Thread GitBox


bzp2010 commented on issue #2285:
URL: 
https://github.com/apache/apisix-dashboard/issues/2285#issuecomment-1032680707


   ### Update
   
   I tried single-node and multi-node etcd, for node/leader, and found nothing 
that could cause `Watch` to fail. If the etcd is unavailable, writes to the 
etcd will be cached and redone when the connection is restored (this is 
incorrent and may result in duplicate writes, but has nothing to do with the 
cache not being updated) 
   
   Whether it is a single-node or multi-node etcd service, the client can 
restore the connection itself.
   
   
![image](https://user-images.githubusercontent.com/8078418/153009100-6e219df1-71da-4a87-a510-b26c11bc57ef.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on issue #2302: api use dgrijalva / jwt-go have Access Restriction Bypass

2022-02-08 Thread GitBox


zaunist commented on issue #2302:
URL: 
https://github.com/apache/apisix-dashboard/issues/2302#issuecomment-1032648681


   @juzhiyuan We can close this issue after 
https://github.com/apache/apisix-dashboard/pull/2304  merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-dashboard] branch master updated (19ccb2b -> 758c432)

2022-02-08 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.


from 19ccb2b  fix: idle_timeout filed to support set zero value (#2296)
 add 758c432  chore: update dgrijalva/jwt-go 3.2  to golang-jwt/jwt 3.2.2 
(#2304)

No new revisions were added by this update.

Summary of changes:
 .github/workflows/auto-build-rpm.yml   |  2 +-
 .github/workflows/backend-e2e-test.yml |  2 +-
 .github/workflows/backend-unit-test.yml|  4 +-
 .github/workflows/frontend-e2e-test.yml|  4 +-
 .github/workflows/frontend-plugin-e2e-test.yml |  4 +-
 .github/workflows/go-lint.yml  |  2 +-
 .github/workflows/make-build.yaml  |  4 +-
 .github/workflows/release-test.yml |  4 +-
 Dockerfile |  2 +-
 Makefile   |  2 +-
 api/go.mod | 12 ++---
 api/go.sum | 52 +-
 api/internal/filter/authentication.go  |  2 +-
 api/internal/filter/authentication_test.go |  2 +-
 .../handler/authentication/authentication.go   |  2 +-
 api/test/docker/Dockerfile |  2 +-
 api/test/docker/docker-compose.yaml|  6 +--
 17 files changed, 31 insertions(+), 77 deletions(-)


  1   2   >