[GitHub] [apisix-ingress-controller] xianshun163 commented on issue #860: request help: Install by Kustomize fail
xianshun163 commented on issue #860: URL: https://github.com/apache/apisix-ingress-controller/issues/860#issuecomment-1035955345 hi, @tao12345666333 I have deploy the ingress version 1.3.0 by the follow step： 1、kubectl apply -k samples/deploy/crd -n ingress-apisix 2、kubectl apply -k samples/deploy/rbac -n ingress-apisix 3、kubectl apply -k samples/deploy/admission -n ingress-apisix 4、kubectl apply -k samples/deploy/configmap -n ingress-apisix 5、kubectl apply -k samples/deploy/deployment -n ingress-apisix It work ok, I can create some apisixroute for the apisix. but, when I change the images version to 1.4.0 , the po can not run, it is a err like this, do you know how to upgrade to 1.4.0? : `bash I0211 15:46:23.897763 1 leaderelection.go:248] attempting to acquire leader lease ingress-apisix/ingress-apisix-leader... panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0xde92db] goroutine 52 [running]: github.com/apache/apisix-ingress-controller/pkg/apisix.(*cluster).getList(0xcd06c0, 0x1fd9c28, 0xcc0018, 0xc0002da000, 0x33, 0x1d3fef7, 0x6, 0x0, 0x0, 0x0, ...) /build/controller/pkg/apisix/cluster.go:739 +0x19b github.com/apache/apisix-ingress-controller/pkg/apisix.(*pluginClient).List(0xc00041fd40, 0x1fd9c28, 0xcc0018, 0x0, 0x0, 0x0, 0x1, 0x0) /build/controller/pkg/apisix/plugin.go:44 +0x3b9 github.com/apache/apisix-ingress-controller/pkg/apisix.(*cluster).syncSchemaOnce(0xcd06c0, 0x1fd9c28, 0xcc0018, 0x0, 0x0) /build/controller/pkg/apisix/cluster.go:388 +0x74f github.com/apache/apisix-ingress-controller/pkg/apisix.(*cluster).syncSchema(0xcd06c0, 0x1fd9c28, 0xcc0018, 0x13a52453c000) /build/controller/pkg/apisix/cluster.go:352 +0xa5 created by github.com/apache/apisix-ingress-controller/pkg/apisix.newCluster /build/controller/pkg/apisix/cluster.go:152 +0x8f4 ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #234: feat: upgrade APISIX to 2.12.1
tao12345666333 commented on a change in pull request #234: URL: https://github.com/apache/apisix-helm-chart/pull/234#discussion_r804418352 ## File path: charts/apisix/Chart.yaml ## @@ -31,12 +31,12 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.8.1 +version: 0.8.2 Review comment: Sorry, can you please bump this to 0.8.3? https://github.com/apache/apisix-helm-chart/pull/233/ has been merged. It has modified this to 0.8.2. ```suggestion version: 0.8.3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] MirtoBusico commented on issue #853: question: How to use Service IP as upstream instead of Pod IP
MirtoBusico commented on issue #853: URL: https://github.com/apache/apisix-ingress-controller/issues/853#issuecomment-1035954493 Hi @tao12345666333 I didn't see anything in the controller log. In this moment I'm reistalling from scratch. asap I can test I'll post the complete controller log -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] MirtoBusico commented on issue #853: question: How to use Service IP as upstream instead of Pod IP
MirtoBusico commented on issue #853: URL: https://github.com/apache/apisix-ingress-controller/issues/853#issuecomment-1035952958 Hi, @liangyuanpeng this issue started as a bug report. You can follow the section "Step to reproduce" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] xianshun163 removed a comment on issue #860: request help: Install by Kustomize fail
xianshun163 removed a comment on issue #860: URL: https://github.com/apache/apisix-ingress-controller/issues/860#issuecomment-1034661206 if this a good way to install : https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/practices/the-hard-way.md when I look at the install.md , it like below, there are almost base the cloud. My k8s is deploy in my linux local home. Installation This is an index page about installing Ingress APISIX in several environments. Click the following links on demands. [Install Ingress APISIX on Azure AKS](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/azure.md) [Install Ingress APISIX on AWS EKS](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/aws.md) [Install Ingress APISIX on ACK](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/ack.md) [Install Ingress APISIX on Google Cloud GKE](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/gke.md) [Install Ingress APISIX on Minikube](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/minikube.md) [Install Ingress APISIX on KubeSphere](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/kubesphere.md) [Install Ingress APISIX on K3S and RKE](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/k3s-rke.md)[](https://github.com/apache/apisix-ingress-controller/blob/master/install.md#kustomize-support) Kustomize Support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 2298814528 opened a new issue #6296: request help: apisix enforces the translation of routed domain names to IP addresses
2298814528 opened a new issue #6296: URL: https://github.com/apache/apisix/issues/6296 ### Issue description I want to use apisix gateway to forward requests to backend **HTTPS service**, but apisix will convert my configured domain name to IP and then forward it. Since the back-end service can only be accessed using domain names and does not support IP access, the forwarding fails. Is there a way to make apisix not automatically convert domain names to IPs? ### Environment - apisix version (cmd: `apisix version`):2.8 - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): openresty/1.19.9.1 - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):3.4.0 - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] liangyuanpeng commented on issue #853: question: How to use Service IP as upstream instead of Pod IP
liangyuanpeng commented on issue #853: URL: https://github.com/apache/apisix-ingress-controller/issues/853#issuecomment-1035936850 > but if you delete an apisixroute, it results deleted for kubernetes it's absolutely weird, how can we reproduce it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on issue #34: request help: Introduce context to run plugin
Belyenochi commented on issue #34: URL: https://github.com/apache/apisix-go-plugin-runner/issues/34#issuecomment-1035929748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #6295: chore: upgrade lua-resty-dns-client to the latest
spacewander opened a new pull request #6295: URL: https://github.com/apache/apisix/pull/6295 Action for https://github.com/apache/apisix/pull/5999#discussion_r777844345 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated (d8178b9 -> f284031)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from d8178b9 docs: added splunk blog (#876) add f284031 feat: release APISIX 2.12.1 (#874) No new revisions were added by this update. Summary of changes: website/config/docs.js | 4 ++-- website/config/downloads.js | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)
[GitHub] [apisix-go-plugin-runner] Belyenochi removed a comment on issue #34: request help: Introduce context to run plugin
Belyenochi removed a comment on issue #34: URL: https://github.com/apache/apisix-go-plugin-runner/issues/34#issuecomment-1035929748 > Yes. But at least it won't break existing code. This is also the way used in the std lib. > Yes. But at least it won't break existing code. This is also the way used in the std lib. Thanks for your patience, and I don't understand what's wrong with resetting the timer (for example, the client timeout is no longer controllable)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #877: added authz-casbin in plugin hub
netlify[bot] edited a comment on pull request #877: URL: https://github.com/apache/apisix-website/pull/877#issuecomment-1035923359 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 21b8365b0227ee47abfe6f7ad7a4fb784738189e Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/62060657900fd200088fa4a7](https://app.netlify.com/sites/apache-apisix/deploys/62060657900fd200088fa4a7) Browse the preview: [https://deploy-preview-877--apache-apisix.netlify.app](https://deploy-preview-877--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] spacewander merged pull request #874: feat: release APISIX 2.12.1
spacewander merged pull request #874: URL: https://github.com/apache/apisix-website/pull/874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] crazyMonkey1995 commented on a change in pull request #6292: fix(traffic-split): failed to match rule when the first rule failed
crazyMonkey1995 commented on a change in pull request #6292: URL: https://github.com/apache/apisix/pull/6292#discussion_r804394349 ## File path: apisix/plugins/traffic-split.lua ## @@ -238,6 +238,7 @@ function _M.access(conf, ctx) for _, rule in ipairs(conf.rules) do if not rule.match then +match_passed = true Review comment: ok, I'll look into it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #877: added authz-casbin in plugin hub
netlify[bot] edited a comment on pull request #877: URL: https://github.com/apache/apisix-website/pull/877#issuecomment-1035923359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #876: docs: add splunk blog
juzhiyuan merged pull request #876: URL: https://github.com/apache/apisix-website/pull/876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6292: fix(traffic-split): failed to match rule when the first rule failed
spacewander commented on a change in pull request #6292: URL: https://github.com/apache/apisix/pull/6292#discussion_r804392034 ## File path: apisix/plugins/traffic-split.lua ## @@ -238,6 +238,7 @@ function _M.access(conf, ctx) for _, rule in ipairs(conf.rules) do if not rule.match then +match_passed = true Review comment: You can refer to https://github.com/apache/apisix/pull/6242#issuecomment-1028625979 and the https://github.com/apache/apisix/blob/master/t/plugin/traffic-split5.t -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: docs: added splunk blog (#876)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new d8178b9 docs: added splunk blog (#876) d8178b9 is described below commit d8178b979ba7b46226a4c74133ff94d6ec272ed5 Author: yilinzeng <36651058+yzen...@users.noreply.github.com> AuthorDate: Fri Feb 11 14:52:14 2022 +0800 docs: added splunk blog (#876) --- .../blog/2022/02/10/apisix-splunk-integration.md | 192 + .../2022/02/10/apisix-splunk-integration.md| 191 2 files changed, 383 insertions(+) diff --git a/website/blog/2022/02/10/apisix-splunk-integration.md b/website/blog/2022/02/10/apisix-splunk-integration.md new file mode 100644 index 000..ccead21 --- /dev/null +++ b/website/blog/2022/02/10/apisix-splunk-integration.md @@ -0,0 +1,192 @@ +--- +title: "Integrating Splunk HTTP Event Collector with Apache APISIX" +authors: + - name: "Jinchao Shuai" +title: "Author" +url: "https://github.com/shuaijinchao; +image_url: "https://avatars.githubusercontent.com/u/8529452?v=4; + - name: "Yilin Zeng" +title: "Technical Writer" +url: "https://github.com/yzeng25; +image_url: "https://avatars.githubusercontent.com/u/36651058?v=4; +keywords: +- Apache APISIX +- Logging +- Observability +- Ecosystem +description: This article explains how to configure and use the Splunk HEC service in Apache APISIX. +tags: [Technology,Ecosystem,Logging] +--- + +> This article explains how to configure and use the Splunk HEC service in Apache APISIX. + + + +The complexity of systems is increasing as technology iterates and enterprise architecture evolves. **Logs can support and be compatible with different analysis engines to reduce the cost for users in the selection, operation and maintenance process.** Log-based analysis and observation plays a very important role as the cornerstone to ensure system stability. + +Apache APISIX is not only an API Gateway with exceptional performance, but also has supported most of the mainstream open source and commercial logging solutions through the communication with community users on data and logging operation and maintenance, including: [HTTP Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/http-logger.md), [TCP Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/tcp-logger.md), [Kafka Logger](https://github [...] + +We now have a new addition to the Apache APISIX Logger support matrix: [Splunk HEC Logging](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/google-cloud-logging.md). + +This article explains how to configure and use the [Splunk HEC](https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/TroubleshootHTTPEventCollector) service in Apache APISIX. + +## About Splunk HTTP Event Collector + +[Splunk](https://www.splunk.com/) is a full-text search engine for machine data that can be used to collect, index, search, and analyze data from a variety of applications. According to DB Engines' search engine ranking, Splunk is currently in second place and is a widely used full-text search software. Splunk, like ElasticSearch, is a quasi-real-time data stream that provides uninterrupted search results. + +[Splunk HTTP Event Collector (HEC)](https://docs.splunk.com/Documentation/Splunk/latest/Data/UsetheHTTPEventCollector)is an HTTP event collector provided by Splunk that provides the ability to send data and application events to Splunk using the HTTP(S) protocol. + +## About splunk-hec-logging lugin + +The [splunk-hec-logging](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/splunk-hec-logging.md) is used to forward Apache APISIX request logs to Splunk for analysis and storage. When enabled, Apache APISIX will take the request context information during the Log phase, serialize it into [Splunk Event Data 格式](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata) and submit it to the batch queue. The data in the queu [...] + +## How to use the splunk-hec-logging plugin + +### Splunk Configuration + + Deploy Splunk Enterprise + +Please refer to [Splunk's installation guide](https://docs.splunk.com/Documentation/Splunk/8.2.3/Installation/Chooseyourplatform) for deployment. This article will demonstrate deployment via Docker. + +Docker command parameters are as follows. + +```shell +docker run -p 18088:8088 -p 18000:8000 \# 8088 is the HEC port, 8000 is the management backend port + -e "SPLUNK_PASSWORD=your-password" \ # Admin Login Password + -e "SPLUNK_START_ARGS=--accept-license" \ # Accept the license terms (Splunk will provide an Enterprise Trial License by default) + -e "SPLUNK_HEC_TOKEN=your-hec-token" \# Set the default HEC token, this will create a
[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on a change in pull request #41: refactor(plugin): plugins automatically register and standard interfaces
shuaijinchao commented on a change in pull request #41: URL: https://github.com/apache/apisix-python-plugin-runner/pull/41#discussion_r804391874 ## File path: apisix/runner/server/handle.py ## @@ -16,7 +16,7 @@ # import flatbuffers -import apisix.runner.plugin.core as runner_plugin +from apisix.runner.plugin.core import PluginProcess as RunnerPlugin Review comment: Uniform style with other names ^_^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch gh-pages updated: Update index.yaml
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/gh-pages by this push: new 2cc5c25 Update index.yaml 2cc5c25 is described below commit 2cc5c25c43056324357f1dce49c671b58b2c50c2 Author: tao12345666333 AuthorDate: Fri Feb 11 06:45:36 2022 + Update index.yaml Signed-off-by: tao12345666333 --- index.yaml | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/index.yaml b/index.yaml index 07f8e57..1dbe2a9 100644 --- a/index.yaml +++ b/index.yaml @@ -3,6 +3,34 @@ entries: apisix: - apiVersion: v2 appVersion: 2.12.0 +created: "2022-02-11T06:45:36.829822504Z" +dependencies: +- condition: etcd.enabled + name: etcd + repository: https://charts.bitnami.com/bitnami + version: 6.2.6 +- alias: dashboard + condition: dashboard.enabled + name: apisix-dashboard + repository: https://charts.apiseven.com + version: 0.4.0 +- alias: ingress-controller + condition: ingress-controller.enabled + name: apisix-ingress-controller + repository: https://charts.apiseven.com + version: 0.9.0 +description: A Helm chart for Apache APISIX +digest: df7ef64931644d0aace67e219988ae92b3b23bc0efbfe500b482037d0864cefd +icon: https://apache.org/logos/res/apisix/apisix.png +maintainers: +- name: tao12345666333 +name: apisix +type: application +urls: +- https://github.com/apache/apisix-helm-chart/releases/download/apisix-0.8.2/apisix-0.8.2.tgz +version: 0.8.2 + - apiVersion: v2 +appVersion: 2.12.0 created: "2022-02-01T02:43:56.230050803Z" dependencies: - condition: etcd.enabled @@ -435,4 +463,4 @@ entries: urls: - https://github.com/apache/apisix-helm-chart/releases/download/apisix-ingress-controller-0.6.0/apisix-ingress-controller-0.6.0.tgz version: 0.6.0 -generated: "2022-02-01T02:43:56.23016731Z" +generated: "2022-02-11T06:45:36.830066803Z"
[apisix-helm-chart] tag apisix-0.8.2 created (now 051998d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag apisix-0.8.2 in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git. at 051998d (commit) No new revisions were added by this update.
[apisix-helm-chart] branch master updated (3d9afdd -> 051998d)
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git. from 3d9afdd feat(apisix): expose stream proxy tcp/udp ports (#227) add 051998d fix: enable stream_route mode when ingress enabled (#233) No new revisions were added by this update. Summary of changes: charts/apisix/Chart.yaml | 2 +- charts/apisix/templates/configmap.yaml | 14 +++--- 2 files changed, 12 insertions(+), 4 deletions(-)
[GitHub] [apisix-website] netlify[bot] commented on pull request #877: added auth-casbin in plugin hub
netlify[bot] commented on pull request #877: URL: https://github.com/apache/apisix-website/pull/877#issuecomment-1035923359 Deploy Preview for *apache-apisix* processing. Explore the source changes: bf3b89c6c8e216e59ca90fd5e2aad402dc4febe4 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6206060d900fd200088f94ef](https://app.netlify.com/sites/apache-apisix/deploys/6206060d900fd200088f94ef) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] rushitote opened a new pull request #877: added auth-casbin in plugin hub
rushitote opened a new pull request #877: URL: https://github.com/apache/apisix-website/pull/877 Changes: Added the authz-casbin plugin to the plugin hub. Screenshots of the change:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6292: fix(traffic-split): failed to match rule when the first rule failed
spacewander commented on a change in pull request #6292: URL: https://github.com/apache/apisix/pull/6292#discussion_r804389955 ## File path: apisix/plugins/traffic-split.lua ## @@ -238,6 +238,7 @@ function _M.access(conf, ctx) for _, rule in ipairs(conf.rules) do if not rule.match then +match_passed = true Review comment: I see. Can you add a test to cover it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #233: fix: enable stream_route mode when ingress enabled
tao12345666333 merged pull request #233: URL: https://github.com/apache/apisix-helm-chart/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] spacewander commented on a change in pull request #41: refactor(plugin): plugins automatically register and standard interfaces
spacewander commented on a change in pull request #41: URL: https://github.com/apache/apisix-python-plugin-runner/pull/41#discussion_r804389546 ## File path: apisix/runner/server/handle.py ## @@ -16,7 +16,7 @@ # import flatbuffers -import apisix.runner.plugin.core as runner_plugin +from apisix.runner.plugin.core import PluginProcess as RunnerPlugin Review comment: Why not use the original name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] crazyMonkey1995 commented on a change in pull request #6292: fix(traffic-split): failed to match rule when the first rule failed
crazyMonkey1995 commented on a change in pull request #6292: URL: https://github.com/apache/apisix/pull/6292#discussion_r804388373 ## File path: apisix/plugins/traffic-split.lua ## @@ -238,6 +238,7 @@ function _M.access(conf, ctx) for _, rule in ipairs(conf.rules) do if not rule.match then +match_passed = true Review comment: But if match_passed is set to false on the first loop, it will remain false instead of true on the second loop  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] oil-oil commented on issue #2310: bug: Setting rejected_msg in "limit-req" plugin does not save
oil-oil commented on issue #2310: URL: https://github.com/apache/apisix-dashboard/issues/2310#issuecomment-1035919843 Please assign it to me, I'll fix this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6292: fix(traffic-split): failed to match rule when the first rule failed
spacewander commented on a change in pull request #6292: URL: https://github.com/apache/apisix/pull/6292#discussion_r804386823 ## File path: apisix/plugins/traffic-split.lua ## @@ -238,6 +238,7 @@ function _M.access(conf, ctx) for _, rule in ipairs(conf.rules) do if not rule.match then +match_passed = true Review comment: The match_passed is true by default: https://github.com/apache/apisix/blob/50d6465fd7b6288f517fd5c408a3171ace7882dd/apisix/plugins/traffic-split.lua#L237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on a change in pull request #876: docs: add splunk blog
guoqqqi commented on a change in pull request #876: URL: https://github.com/apache/apisix-website/pull/876#discussion_r804386858 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2022/02/10/apisix-splunk-integration.md ## @@ -0,0 +1,191 @@ +--- +title: "生态扩大进行中！Apache APISIX 集成 Splunk HTTP Event Collector" +authors: + - name: "帅进超" +title: "Author" +url: "https://github.com/shuaijinchao; +image_url: "https://avatars.githubusercontent.com/u/8529452?v=4; + - name: "曾奕霖" +title: "Technical Writer" +url: "https://github.com/yzeng25; +image_url: "https://avatars.githubusercontent.com/u/36651058?v=4; +keywords: +- Apache APISIX +- 日志 +- 可观测性 +- 生态 +description: 本文将为大家介绍如何在 Apache APISIX 中配置和使用 Splunk HEC 服务。 +tags: [Technology,Ecosystem,Logging] +--- + +> 本文将为大家介绍如何在 Apache APISIX 中配置和使用 Splunk HEC 服务。 + + + +随着技术的不断迭代和企业架构的不断演进，系统的复杂度越来越高。**日志作为分析和观测的“原材料”，能支持和兼容不同的分析引擎会为用户在选型和后期运维过程中降低很大成本。**基于日志的分析和观测作为保障系统稳定的基石，它的角色非常重要。 + +Apache APISIX 作为一个高性能的 API 网关不仅在性能上有着良好的表现，并且在数据和日志的运维上通过和社区用户的交流共建也已经支持了大部分主流的开源及商业日志解决方案，包括：[HTTP Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/http-logger.md) 、[TCP Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/tcp-logger.md)、[Kafka Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/kafka-logger.md)、[UDP Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/udp-logger.md)、[RocketMQ Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/rocketmq-logger.md)、[SkyWalking Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/skywalking-logger.md)、[Aliyun Cloud Logging（SLS）](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/sls-logger.md)、[Google Cloud Log ging](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/google-cloud-logging.md) 等。 + +最近通过社区的共建支持，Apache APISIX 的 Logger 全家桶中又多了一位新成员：[Splunk HEC Logging](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/google-cloud-logging.md)。 + +本文将为大家介绍如何在 Apache APISIX 中配置和使用 [Splunk HEC](https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/TroubleshootHTTPEventCollector) 服务。 + +## 关于 Splunk HTTP Event Collector + +[Splunk](https://www.splunk.com/) 是一个机器数据的全文搜索引擎，可应用于采集、索引、搜索和分析各种应用数据，根据 [DB Engines 的检索引擎排名](https://db-engines.com/en/ranking/search+engine)，目前 Splunk 位列第二，是一款应用广泛的全文检索软件。Splunk 和 ElasticSearch 一样，是准实时可以提供不间断搜索结果的数据流。 + +[Splunk HTTP Event Collector (HEC)](https://docs.splunk.com/Documentation/Splunk/latest/Data/UsetheHTTPEventCollector) 是 Splunk 提供的 HTTP 事件收集器，主要提供以 HTTP(S) 协议将数据和应用程序事件发送到 Splunk 的能力。 + +## 关于 Splunk HEC Logging 插件 + +[splunk-hec-logging](https://github.com/apache/apisix/blob/master/docs/zh/latest/plugins/splunk-hec-logging.md) 插件用于将 Apache APISIX 的请求日志转发到 Splunk 中进行分析和存储。启用该插件后，Apache APISIX 将在 Log 阶段获取请求上下文信息，并将其序列化为 [Splunk Event Data 格式](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata)后提交到批处理队列中。当触发批处理队列每批次最大处理容量，或刷新缓冲区的最大时间时，会将队列中的数据提交到 Splunk HEC 中。 + +## 如何使用 Splunk HEC Logging 插件 + +### Splunk 配置步骤 + + 部署 Splunk Enterprise + +请参考 Splunk 的 [官方安装指南](https://docs.splunk.com/Documentation/Splunk/8.2.3/Installation/Chooseyourplatform) 进行部署，本文将通过 Docker 进行部署演示。 +Docker 命令参数如下： + +```shell +docker run -p 18088:8088 -p 18000:8000 \# 8088为HEC端口，8000为管理后台端口 + -e "SPLUNK_PASSWORD=your-password" \ # 管理后台登录密码 + -e "SPLUNK_START_ARGS=--accept-license" \ # 接受许可证条款（Splunk默认将提供一张Enterprise Trial License） + -e "SPLUNK_HEC_TOKEN=your-hec-token" \# 设置默认HEC令牌，配置此项后将创建一个默认的HEC + -itd --rm --name splunk-example splunk/splunk:latest +``` + +命令参数具体释义可参考：[Docker Splunk 文档](https://splunk.github.io/docker-splunk/)。 + + 配置 Splunk HEC + +Docker 中已经配置并创建了默认的 HEC，在这里不再过多赘述创建 HEC 的流程。具体手动创建的流程可参考文档：[Set up and use HTTP Event Collector in Splunk Web](https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/UsetheHTTPEventCollector)。 + + 登录 Splunk Enterprise 并检查 HEC + +通过浏览器访问 Docker 的映射端口。因为需要把管理后台的 `8000` 端口映射到宿主机的 `18000` 端口，所以在操作时可以在宿主机上通过「回环地址加端口」的方式在浏览器访问即可。例如：http://127.0.0.1:18000，登录的默认用户名是 admin，密码是在上例的环境变量中设置的 `SPLUNK_PASSWORD` 的值。 + +如下图所示，表示登录成功。 + + + +单击界面右上方 “Settings > Data Inputs” 检查默认 HEC 是否设置成功： + + + +在 HTTP Event Collector 的 Inputs 列中我们已经可以看到 HEC 的数量，表示设置成功。 + + + +此时可以点击 HTTP Event Collector 进入 HEC 详情列表查看 HECs 的 Token 信息。 + + + +Token Values 即在上文中 Docker 环境变量中配置的 `SPLUNK_HEC_TOKEN` 的值。 + +### Apache APISIX 配置步骤 + + 启用插件 +
[GitHub] [apisix] spacewander commented on a change in pull request #6215: feat: clickhouse logger
spacewander commented on a change in pull request #6215:
URL: https://github.com/apache/apisix/pull/6215#discussion_r804384280
##
File path: t/plugin/clickhouse-logger.t
##
@@ -0,0 +1,220 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+use t::APISIX 'no_plan';
+
+log_level("info");
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+
+if (!defined $block->request) {
+$block->set_value("request", "GET /t");
+}
+
+my $http_config = $block->http_config // <<_EOC_;
+server {
+listen 10420;
+location /clickhouse-logger/test {
+content_by_lua_block {
+ngx.req.read_body()
+local data = ngx.req.get_body_data()
+local headers = ngx.req.get_headers()
+ngx.log(ngx.ERR, "clickhouse body: ", data)
+ngx.say("ok")
+}
+}
+}
+_EOC_
+
+$block->set_value("http_config", $http_config);
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: Full configuration verification
+--- yaml_config
Review comment:
Let's remove empty `--- yaml_config`
##
File path: t/plugin/clickhouse-logger.t
##
@@ -0,0 +1,220 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+use t::APISIX 'no_plan';
+
+log_level("info");
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+
+if (!defined $block->request) {
+$block->set_value("request", "GET /t");
+}
+
+my $http_config = $block->http_config // <<_EOC_;
+server {
+listen 10420;
+location /clickhouse-logger/test {
+content_by_lua_block {
+ngx.req.read_body()
+local data = ngx.req.get_body_data()
+local headers = ngx.req.get_headers()
+ngx.log(ngx.ERR, "clickhouse body: ", data)
+ngx.say("ok")
+}
+}
+}
+_EOC_
+
+$block->set_value("http_config", $http_config);
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: Full configuration verification
+--- yaml_config
+--- config
+location /t {
+content_by_lua_block {
+local plugin = require("apisix.plugins.clickhouse-logger")
+local ok, err = plugin.check_schema({timeout = 3,
+ retry_delay = 1,
+ batch_max_size = 500,
+ user = "default",
+ password = "a",
+ database = "default",
+ logtable = "t",
+ endpoint_addr =
"http://127.0.0.1:10420/clickhouse-logger/test;,
+ max_retry_count = 1,
+ name = "clickhouse logger",
+ ssl_verify = false
+ })
+
+if not ok then
+
[GitHub] [apisix] hf400159 commented on a change in pull request #6284: docs: added cpanm installation commands and remove $ sign
hf400159 commented on a change in pull request #6284: URL: https://github.com/apache/apisix/pull/6284#discussion_r804384369 ## File path: docs/en/latest/how-to-build.md ## @@ -204,23 +204,30 @@ Run the `apisix help` command to see the returned results and get commands and d ```shell # more actions find by `help` -$ apisix help +apisix help ``` ## Step 4: Run Test Cases 1. Install `cpanminus`, the package manager for `perl`. +```shell +curl -L https://cpanmin.us/ -o cpanm Review comment: That's a good idea, I have changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on pull request #233: fix: enable stream_route mode when ingress enabled
Gallardot commented on pull request #233: URL: https://github.com/apache/apisix-helm-chart/pull/233#issuecomment-1035916092 > Why? This is for compatibility with Ingress controller behavior only, not for APISIX users. If the user really needs to expose stream_route, then modify the corresponding configuration. Okay, got it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on a change in pull request #63: feature: try to introduce context to plugin runner
spacewander commented on a change in pull request #63:
URL:
https://github.com/apache/apisix-go-plugin-runner/pull/63#discussion_r804383251
##
File path: internal/plugin/plugin.go
##
@@ -134,7 +136,9 @@ func reportAction(id uint32, req *inHTTP.Request, resp
*inHTTP.Response) *flatbu
}
func HTTPReqCall(buf []byte, conn net.Conn) (*flatbuffers.Builder, error) {
- req := inHTTP.CreateRequest(buf)
+ ctx, cancel := context.WithTimeout(context.Background(), 56*time.Second)
+ defer cancel()
+ req := inHTTP.CreateRequest(buf).WithContext(ctx)
Review comment:
Better to set the ctx inside `CreateRequest` instead of providing it as
a method.
As we will reuse the Request, such a method will make reusing impossible.
##
File path: internal/plugin/plugin.go
##
@@ -134,7 +136,9 @@ func reportAction(id uint32, req *inHTTP.Request, resp
*inHTTP.Response) *flatbu
}
func HTTPReqCall(buf []byte, conn net.Conn) (*flatbuffers.Builder, error) {
- req := inHTTP.CreateRequest(buf)
+ ctx, cancel := context.WithTimeout(context.Background(), 56*time.Second)
Review comment:
Better to add a comment to explain why 56 is chosen.
##
File path: internal/http/request.go
##
@@ -18,18 +18,18 @@
package http
import (
+ "context"
"encoding/binary"
+ "github.com/api7/ext-plugin-proto/go/A6"
Review comment:
Let's configure your environment to make sure 3 party imports are sorted
separated.
##
File path: internal/http/request.go
##
@@ -52,6 +52,26 @@ type Request struct {
rawArgs url.Values
vars map[string][]byte
+
+ ctx context.Context
+}
+
+func (r *Request) Context() context.Context {
+ if r.ctx != nil {
+ return r.ctx
Review comment:
Don't forget to reset the ctx before reusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #233: fix: enable stream_route mode when ingress enabled
tao12345666333 commented on pull request #233: URL: https://github.com/apache/apisix-helm-chart/pull/233#issuecomment-1035915070 > Maybe we should update both Deployment and Service as well. Why? This is for compatibility with Ingress controller behavior only, not for APISIX users. If the user really needs to expose stream_route, then modify the corresponding configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #41: refactor(plugin): plugins automatically register and standard interfaces
codecov[bot] edited a comment on pull request #41: URL: https://github.com/apache/apisix-python-plugin-runner/pull/41#issuecomment-1035830371 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#41](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6c867cf) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/8e6f2bc12dd1c82a18fde06d0fee799612d1?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8e6f2bc) will **increase** coverage by `0.02%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #41 +/- ## == + Coverage 93.27% 93.30% +0.02% == Files 12 11 -1 Lines 744 732 -12 == - Hits 694 683 -11 + Misses 50 49 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `100.00% <100.00%> (+0.62%)` | :arrow_up: | | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `100.00% <100.00%> (ø)` | | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `88.13% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [8e6f2bc...6c867cf](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #63: feature: try to introduce context to plugin runner
codecov-commenter commented on pull request #63: URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1035914590 # [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#63](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (83acf28) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/6bb1c4bd98ec374638af7ed02931e0efb2604044?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6bb1c4b) will **increase** coverage by `1.80%`. > The diff coverage is `21.42%`. [](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #63 +/- ## == + Coverage 77.74% 79.55% +1.80% == Files 11 11 Lines 701 714 +13 == + Hits 545 568 +23 + Misses119 110 -9 + Partials 37 36 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `89.62% <0.00%> (-4.91%)` | :arrow_down: | | [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `79.36% <100.00%> (+0.67%)` | :arrow_up: | | [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `67.47% <0.00%> (+17.07%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [6bb1c4b...83acf28](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] edited a comment on pull request #41: refactor(plugin): plugins automatically register and standard interfaces
codecov[bot] edited a comment on pull request #41: URL: https://github.com/apache/apisix-python-plugin-runner/pull/41#issuecomment-1035830371 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#41](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a699b78) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/8e6f2bc12dd1c82a18fde06d0fee799612d1?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8e6f2bc) will **decrease** coverage by `1.06%`. > The diff coverage is `81.81%`. > :exclamation: Current head a699b78 differs from pull request most recent head 6c867cf. Consider uploading reports for the commit 6c867cf to get more accurate results [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #41 +/- ## == - Coverage 93.27% 92.21% -1.07% == Files 12 11 -1 Lines 744 732 -12 == - Hits 694 675 -19 - Misses 50 57 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `81.81% <79.48%> (-18.19%)` | :arrow_down: | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `100.00% <100.00%> (+0.62%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `88.13% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [8e6f2bc...6c867cf](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on pull request #233: fix: enable stream_route mode when ingress enabled
Gallardot commented on pull request #233: URL: https://github.com/apache/apisix-helm-chart/pull/233#issuecomment-1035914025 Maybe we should update both Deployment and Service as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #233: fix: enable stream_route mode when ingress enabled
tao12345666333 commented on pull request #233: URL: https://github.com/apache/apisix-helm-chart/pull/233#issuecomment-1035913059 This is a serious problem, we need an upgrade version to release it immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
netlify[bot] edited a comment on pull request #870: URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: f3f46025622e11a7454f5859623e5019866e34e3 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6205feb9a26da7000721f723](https://app.netlify.com/sites/apache-apisix/deploys/6205feb9a26da7000721f723) Browse the preview: [https://deploy-preview-870--apache-apisix.netlify.app](https://deploy-preview-870--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'
netlify[bot] edited a comment on pull request #870: URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360 Deploy Preview for *apache-apisix* processing. Explore the source changes: f3f46025622e11a7454f5859623e5019866e34e3 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6205feb9a26da7000721f723](https://app.netlify.com/sites/apache-apisix/deploys/6205feb9a26da7000721f723) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #233: fix: enable stream_route mode when ingress enabled
tao12345666333 opened a new pull request #233: URL: https://github.com/apache/apisix-helm-chart/pull/233 Since the release of APISIX v2.12, we found that when using Helm chart to install both APISIX and Ingress controller, the Ingress controller does not work properly. This is because the stream_route mode is disabled by default in APISIX, but it is required by the Ingress controller. xref: issue: https://github.com/apache/apisix-ingress-controller/issues/851#issuecomment-1026306420 https://github.com/apache/apisix-ingress-controller/issues/858 Another fix on the APISIX Ingress controller is tracked at https://github.com/apache/apisix-ingress-controller/issues/856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #876: docs: add splunk blog
netlify[bot] edited a comment on pull request #876: URL: https://github.com/apache/apisix-website/pull/876#issuecomment-1035854806 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 1ef40b479797b877e2e5f5165dd3fe3aade7e1d1 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6205f79c4b871a0008136eb0](https://app.netlify.com/sites/apache-apisix/deploys/6205f79c4b871a0008136eb0) Browse the preview: [https://deploy-preview-876--apache-apisix.netlify.app](https://deploy-preview-876--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #876: docs: add splunk blog
netlify[bot] edited a comment on pull request #876: URL: https://github.com/apache/apisix-website/pull/876#issuecomment-1035854806 Deploy Preview for *apache-apisix* processing. Explore the source changes: 1ef40b479797b877e2e5f5165dd3fe3aade7e1d1 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6205f79c4b871a0008136eb0](https://app.netlify.com/sites/apache-apisix/deploys/6205f79c4b871a0008136eb0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch release/apisix-2.10.4 created (now a9dc449)
This is an automated email from the ASF dual-hosted git repository. bzp2010 pushed a change to branch release/apisix-2.10.4 in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. at a9dc449 feat: add dashboard support for docker-compose-arm64.yml (#269) No new revisions were added by this update.
[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #876: docs: add splunk blog
SylviaBABY commented on a change in pull request #876: URL: https://github.com/apache/apisix-website/pull/876#discussion_r804370888 ## File path: website/blog/2022/02/10/apisix-splunk-integration.md ## @@ -0,0 +1,192 @@ +--- +title: "Integrating Splunk HTTP Event Collector with Apache APISIX" +authors: + - name: "Jinchao Shuai" +title: "Author" +url: "https://github.com/shuaijinchao; +image_url: "https://avatars.githubusercontent.com/u/8529452?v=4; + - name: "Yilin Zeng" +title: "Technical Writer" +url: "https://github.com/yzeng25; +image_url: "https://avatars.githubusercontent.com/u/36651058?v=4; +keywords: +- Apache APISIX +- Logging +- Observability +- Ecosystem +description: This article explains how to configure and use the Splunk HEC service in Apache APISIX. +tags: [Technology,Ecosystem,Logging] +--- + +> This article explains how to configure and use the Splunk HEC service in Apache APISIX. + + + +The complexity of systems is increasing as technology iterates and enterprise architecture evolves. **Logs can support and be compatible with different analysis engines to reduce the cost for users in the selection, operation and maintenance process.** Log-based analysis and observation plays a very important role as the cornerstone to ensure system stability. + +Apache APISIX is not only an API Gateway with exceptional performance, but also has supported most of the mainstream open source and commercial logging solutions through the communication with community users on data and logging operation and maintenance, including: [HTTP Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/http-logger.md), [TCP Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/tcp-logger.md), [Kafka Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/kafka-logger.md), [UDP Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/udp-logger.md), [RocketMQ Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/rocketmq-logger.md), [SkyWalking Logger](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/skywalking-logger.md), [Aliyun Cloud Logging(SLS)](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/sls-logger.md), [Googl e Cloud Logging](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/google-cloud-logging.md), etc. + +We now have a new addition to the Apache APISIX Logger support matrix: [Splunk HEC Logging](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/google-cloud-logging.md). + +This article explains how to configure and use the [Splunk HEC](https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/TroubleshootHTTPEventCollector) service in Apache APISIX. + +## About Splunk HTTP Event Collector + +[Splunk](https://www.splunk.com/) is a full-text search engine for machine data that can be used to collect, index, search, and analyze data from a variety of applications. According to DB Engines' search engine ranking, Splunk is currently in second place and is a widely used full-text search software. Splunk, like ElasticSearch, is a quasi-real-time data stream that provides uninterrupted search results. + +[Splunk HTTP Event Collector (HEC)](https://docs.splunk.com/Documentation/Splunk/latest/Data/UsetheHTTPEventCollector)is an HTTP event collector provided by Splunk that provides the ability to send data and application events to Splunk using the HTTP(S) protocol. + +## About splunk-hec-logging lugin + +The [splunk-hec-logging](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/splunk-hec-logging.md) is used to forward Apache APISIX request logs to Splunk for analysis and storage. When enabled, Apache APISIX will take the request context information during the Log phase, serialize it into [Splunk Event Data 格式](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata) and submit it to the batch queue. The data in the queue is committed to Splunk HEC when the maximum processing capacity of the batch queue per batch is triggered, or when the maximum time to refresh the buffer is reached. + +## How to use the splunk-hec-logging plugin + +### Splunk Configuration + + Deploy Splunk Enterprise + +Please refer to [Splunk's installation guide](https://docs.splunk.com/Documentation/Splunk/8.2.3/Installation/Chooseyourplatform) for deployment. This article will demonstrate deployment via Docker. + +Docker command parameters are as follows. + +```shell +docker run -p 18088:8088 -p 18000:8000 \# 8088 is the HEC port, 8000 is the management backend port + -e "SPLUNK_PASSWORD=your-password" \ # Admin Login Password + -e "SPLUNK_START_ARGS=--accept-license" \ # Accept the license terms (Splunk will provide an Enterprise Trial License by default) + -e
[GitHub] [apisix] syokensyo commented on issue #4942: bug: upstreaam response http code 302，then we found it was be redirected to an new port 9080
syokensyo commented on issue #4942: URL: https://github.com/apache/apisix/issues/4942#issuecomment-1035885054 > > @eastearth @nic-chen @tokers 您们好，请问这个问题有被解决么？我遇到了与之相同的问题  > > 我去查看了jenkins自己的文档中关于[反向代理](https://www.jenkins.io/doc/book/system-administration/reverse-proxy-configuration-troubleshooting/)的说明， ↓上述文档中关于此内容描述的截图  > > 根据其中的描述，是jenkins在某些步骤会自己通过302状态码进行重定向，并在http响应头的Location返回要重定向到的地址，但是目前jenkins方面每次返回的Localtion的端口都是apisix的端口，有两种处理方式，其中一种是需要我们在请求头中设置以下参数： X-Forwarded-Host: jenkins.xxx.xxx（自身jenkins的域名） X-Forwarded-Port: 80 X-Forwarded-Proto: https > > 关于设置请求头的这种方式，这是我尝试过的方法，但都没有效果，jenkins依然返回了带有9080端口的重定向地址： 1、通过界面的“路由”(routes)中的“请求头重写”功能设置请求头  ↓这是通过该方式形成的路由配置在“数据编辑器”中展示的样子  2、通过界面的“服务”(service)中的“[proxy-rewrite](https://apisix.apache.org/zh/docs/apisix/plugins/proxy-rewrite)”插件设置请求头  ↓这是通过该方式形成的服务配置在“数据编辑器”中展示的样子  > > 然后因为我不太确定这是jenkins自身的问题还是apisix插件的问题，于是我现在想要试试另一种修改响应头中的Location的方法，请问有什么方式能让我对响应头中的Location进行正则匹配，并进行修改的么？想要的效果大概是这样的： response header: Location：https://jenkins.xxx.xxx:9080/* ↓ response header: Location：https://jenkins.xxx.xxx/* > > 我知道有个“[response-rewrite](https://apisix.apache.org/zh/docs/apisix/plugins/response-rewrite)”插件可以对上面所说的Location进行修改，但因为该插件提供的说明中并没有对其进行较多的描述，也没有提供类似的改写范例，我并不确定他是否能做到我上面说的这种基于正则的改写，如果可以的话，能否给我说下我应该怎么去配置，谢谢。 > > 除此之外，我目前觉得大概能有效的一种方法是，我将9080端口也开放出去，然后再重新配置一个路由去识别来自9080端口的请求，并将其重新重定向到80端口，但老实说不到万不得已，我并不是太想新开放一个端口，而且这样的处理方式会让多增加一次http的请求，总感觉不太美好。 > > 你字多，就回复你吧。你域名解析到哪里了，是 nginx 还是 slb？如果是 Nginx 加一个 proxy_set_header X-Forwarded-Port 443; slb 应该有单独的选项可以设置。 这个问题存在很久了，https://github.com/apache/apisix/issues/2777 ，测试在apisix上一层的nginx 添加proxy_set_header X-Forwarded-Port 443; 可用，感觉是目前最简单的workaround -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6278: docs: improve consul_kv.md
spacewander commented on a change in pull request #6278: URL: https://github.com/apache/apisix/pull/6278#discussion_r804357533 ## File path: docs/en/latest/discovery/consul_kv.md ## @@ -23,7 +23,7 @@ title: consul_kv ## Summary -For users who used [nginx-upsync-module](https://github.com/weibocom/nginx-upsync-module) and consul key value for service discovery way, as we Weibo Mobile Team, maybe need it. +For users that are using [nginx-upsync-module](https://github.com/weibocom/nginx-upsync-module) and Consul KV as a service discovery, like the Weibo Mobile Team, this may be required. Review comment: ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] rushitote commented on a change in pull request #2290: chore: added form function to authz-casbin plugin
rushitote commented on a change in pull request #2290:
URL: https://github.com/apache/apisix-dashboard/pull/2290#discussion_r804353504
##
File path: web/src/components/Plugin/locales/en-US.ts
##
@@ -145,4 +145,16 @@ export default {
'component.pluginForm.limit-count.redis_cluster_name.tooltip':
'When using redis-cluster policy, this property is the name of Redis
cluster service nodes.',
'component.pluginForm.limit-count.atLeast2Characters.rule': 'Please enter at
least 2 characters',
+ // authz-casbin
+ 'component.pauginForm.authz-casbin.model_path.tooltip':'The path of the
Casbin model configuration file.',
+ 'compoenet.pauginForm.authz-casbin.policy_path.tooltip': 'The path of the
Casbin model configuration file.',
+ 'compoenet.pauginForm.authz-casbin.model.tooltip':'The Casbin model
configuration in text format.',
+ 'compoenet.pauginForm.authz-casbin.policy.tooltip': 'The Casbin model
configuration in text format.',
+ 'compoenet.pauginForm.authz-casbin.username.tooltip': 'The header you will
be using in request to pass the username (subject).',
Review comment:
```suggestion
'component.pluginForm.authz-casbin.model_path.tooltip':'The path of the
Casbin model configuration file.',
'component.pluginForm.authz-casbin.policy_path.tooltip': 'The path of the
Casbin model configuration file.',
'component.pluginForm.authz-casbin.model.tooltip':'The Casbin model
configuration in text format.',
'component.pluginForm.authz-casbin.policy.tooltip': 'The Casbin model
configuration in text format.',
'component.pluginForm.authz-casbin.username.tooltip': 'The header you will
be using in request to pass the username (subject).',
```
##
File path: web/src/components/Plugin/UI/authz-casbin.tsx
##
@@ -0,0 +1,76 @@
+import { useIntl } from "umi";
+import Form, { FormInstance } from "antd/es/form";
+import React from "react";
+import { Input } from "antd";
+
+type Props = {
+form: FormInstance;
+schema: Record | undefined;
+ref?: any;
+}
+
+const FORM_ITEM_LAYOUT = {
+labelCol: {
+span: 7,
+},
+wrapperCol: {
+span: 8,
+},
+};
+
+const AuthzCasbin: React.FC = ({ form, schema }) => {
+const { formatMessage } = useIntl();
+const properties = schema?.properties
+
+return (
+
+ | undefined;
+ref?: any;
+}
+
+const FORM_ITEM_LAYOUT = {
+labelCol: {
+span: 7,
+},
+wrapperCol: {
+span: 8,
+},
+};
+
+const AuthzCasbin: React.FC = ({ form, schema }) => {
+const { formatMessage } = useIntl();
+const properties = schema?.properties
+
+return (
+
+
+
+
+ | undefined;
+ref?: any;
+}
+
+const FORM_ITEM_LAYOUT = {
+labelCol: {
+span: 7,
+},
+wrapperCol: {
+span: 8,
+},
+};
+
+const AuthzCasbin: React.FC = ({ form, schema }) => {
+const { formatMessage } = useIntl();
+const properties = schema?.properties
+
+return (
+
+
+
+
+
+
+
+
+
[GitHub] [apisix] spacewander commented on a change in pull request #6228: feat(loggly): support HTTP response code to SYSLOG severity mapping
spacewander commented on a change in pull request #6228:
URL: https://github.com/apache/apisix/pull/6228#discussion_r804344901
##
File path: apisix/plugins/loggly.lua
##
@@ -85,6 +86,17 @@ local schema = {
type = "boolean",
default = true
},
+severity_map = {
+type = "object",
+description = "upstream response code vs syslog severity mapping",
+patternProperties = {
+[".*"] = {
Review comment:
Got it. What about adding `additionalProperties = false,`? So the
mismatch key will cause an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6228: feat(loggly): support HTTP response code to SYSLOG severity mapping
spacewander commented on a change in pull request #6228:
URL: https://github.com/apache/apisix/pull/6228#discussion_r804344901
##
File path: apisix/plugins/loggly.lua
##
@@ -85,6 +86,17 @@ local schema = {
type = "boolean",
default = true
},
+severity_map = {
+type = "object",
+description = "upstream response code vs syslog severity mapping",
+patternProperties = {
+[".*"] = {
Review comment:
Got it. What about adding `"additionalProperties": false`? So the
mismatch key will cause an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] SkyeYoung commented on a change in pull request #6278: docs: improve consul_kv.md
SkyeYoung commented on a change in pull request #6278: URL: https://github.com/apache/apisix/pull/6278#discussion_r804344573 ## File path: docs/en/latest/discovery/consul_kv.md ## @@ -23,7 +23,7 @@ title: consul_kv ## Summary -For users who used [nginx-upsync-module](https://github.com/weibocom/nginx-upsync-module) and consul key value for service discovery way, as we Weibo Mobile Team, maybe need it. +For users that are using [nginx-upsync-module](https://github.com/weibocom/nginx-upsync-module) and Consul KV as a service discovery, like the Weibo Mobile Team, this may be required. Review comment: @spacewander Sorry, in my opinion, "may be required" doesn't mean "enforce". If I change it to "this may be needed", do you think it will be better? Or do I change back? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] spacewander merged pull request #269: feat: add dashboard support for docker-compose-arm64.yml
spacewander merged pull request #269: URL: https://github.com/apache/apisix-docker/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #6086: request help: macos arm docker-compose.yaml add apisix-dashboard
spacewander closed issue #6086: URL: https://github.com/apache/apisix/issues/6086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch master updated: feat: add dashboard support for docker-compose-arm64.yml (#269)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new a9dc449 feat: add dashboard support for docker-compose-arm64.yml (#269) a9dc449 is described below commit a9dc4499f43acf4362d716bf4dda54965403dbe1 Author: leslie <59061168+leslie-ts...@users.noreply.github.com> AuthorDate: Fri Feb 11 11:59:18 2022 +0800 feat: add dashboard support for docker-compose-arm64.yml (#269) --- example/docker-compose-arm64.yml | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/example/docker-compose-arm64.yml b/example/docker-compose-arm64.yml index d46a9a5..cb6f263 100644 --- a/example/docker-compose-arm64.yml +++ b/example/docker-compose-arm64.yml @@ -18,8 +18,18 @@ version: "3" services: + apisix-dashboard: +image: apache/apisix-dashboard:2.10.1-alpine +restart: always +volumes: + - ./dashboard_conf/conf.yaml:/usr/local/apisix-dashboard/conf/conf.yaml +ports: + - "9000:9000" +networks: + apisix: + apisix: -image: apache/apisix:2.9-alpine +image: apache/apisix:2.11.0-alpine restart: always volumes: - ./apisix_log:/usr/local/apisix/logs @@ -35,7 +45,7 @@ services: apisix: etcd: -image: rancher/coreos-etcd:v3.4.13-arm64 +image: rancher/coreos-etcd:v3.4.15-arm64 user: root restart: always volumes:
[GitHub] [apisix-go-plugin-runner] Belyenochi edited a comment on issue #34: request help: Introduce context to run plugin
Belyenochi edited a comment on issue #34: URL: https://github.com/apache/apisix-go-plugin-runner/issues/34#issuecomment-1035851566 > Thanks for your design. My original thought is simpler: we can add a method in the Request to return a Context. It works like the one from the standard library: https://pkg.go.dev/net/http#Request.Context. > > People can fetch it only when they need the Context. And the timeout of Context is slightly smaller than 60s so people can still break the execution with a custom response before the actual timeout. > > There is a tricky place: the timeout of Nginx is per-operation, so when we communicate with Nginx again in > > https://github.com/apache/apisix-go-plugin-runner/blob/6bb1c4bd98ec374638af7ed02931e0efb2604044/internal/http/request.go#L326 > > > the timer will be reset. Maybe we can handle this in a separate PR. There is a doubt, although we have added a timeout context to the Request, but if the plugin written by the user does not handle this context, it will still cause a timeout -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 commented on pull request #269: feat: add dashboard support for docker-compose-arm64.yml
bzp2010 commented on pull request #269: URL: https://github.com/apache/apisix-docker/pull/269#issuecomment-1035860370 ### Update The latest versions of arm64 are currently supported, they include 2.10.3, 2.10.4, 2.12+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot opened a new pull request #232: feat(apisix): add timezone and extraEnvVars
Gallardot opened a new pull request #232: URL: https://github.com/apache/apisix-helm-chart/pull/232 You may need to set the timezone to be consistent with your local time zone, otherwise the apisix's logs may used to retrieve event maybe in wrong timezone. Also define `extraEnvVars` to allow users to extend additional environment variables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6197: request help: How to current limit both in minutes and day by using plugin limit-count
spacewander commented on issue #6197: URL: https://github.com/apache/apisix/issues/6197#issuecomment-1035859304 We should also deal with redis backend too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #876: docs: add splunk blog
netlify[bot] edited a comment on pull request #876: URL: https://github.com/apache/apisix-website/pull/876#issuecomment-1035854806 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 2e021463a7d6d62da72a723148ff5ac4c9777c3b Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6205da89216ad20007dd8c42](https://app.netlify.com/sites/apache-apisix/deploys/6205da89216ad20007dd8c42) Browse the preview: [https://deploy-preview-876--apache-apisix.netlify.app](https://deploy-preview-876--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6284: docs: added cpanm installation commands and remove $ sign
spacewander commented on a change in pull request #6284: URL: https://github.com/apache/apisix/pull/6284#discussion_r804341405 ## File path: docs/en/latest/how-to-build.md ## @@ -204,23 +204,30 @@ Run the `apisix help` command to see the returned results and get commands and d ```shell # more actions find by `help` -$ apisix help +apisix help ``` ## Step 4: Run Test Cases 1. Install `cpanminus`, the package manager for `perl`. +```shell +curl -L https://cpanmin.us/ -o cpanm Review comment: I have reconsidered it. Maybe putting a link to the official installation is better? https://metacpan.org/pod/App::cpanminus#INSTALLATION -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on pull request #2308: chore : update to github.com/golang-jwt/jwt/v4
bzp2010 edited a comment on pull request #2308: URL: https://github.com/apache/apisix-dashboard/pull/2308#issuecomment-1035858693 I noticed that you updated the version of etcd used for CLI testing and it caused the test case about etcd mTLS to fail, can you check that? No problem with other code changes. ping @hongbinhsu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2308: chore : update to github.com/golang-jwt/jwt/v4
bzp2010 commented on pull request #2308: URL: https://github.com/apache/apisix-dashboard/pull/2308#issuecomment-1035858693 I noticed that you updated the version of etcd used for CLI testing and it caused the test case about etcd mTLS to fail, can you check that? No problem with other code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6278: docs: improve consul_kv.md
spacewander commented on a change in pull request #6278: URL: https://github.com/apache/apisix/pull/6278#discussion_r804340816 ## File path: docs/en/latest/discovery/consul_kv.md ## @@ -23,7 +23,7 @@ title: consul_kv ## Summary -For users who used [nginx-upsync-module](https://github.com/weibocom/nginx-upsync-module) and consul key value for service discovery way, as we Weibo Mobile Team, maybe need it. +For users that are using [nginx-upsync-module](https://github.com/weibocom/nginx-upsync-module) and Consul KV as a service discovery, like the Weibo Mobile Team, this may be required. Review comment: Why change `maybe need it`? We just suggest people use but not enforce them to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] spacewander merged pull request #281: chore: solve build error (type *big.Int has no field or method FillBy…
spacewander merged pull request #281: URL: https://github.com/apache/apisix-docker/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch master updated: chore: solve build error (type *big.Int has no field or method FillBy… (#281)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new 10a8c99 chore: solve build error (type *big.Int has no field or method FillBy… (#281) 10a8c99 is described below commit 10a8c99d2de7cbf2e5377e725a0185aaa3d9214c Author: 罗泽轩 AuthorDate: Fri Feb 11 11:45:57 2022 +0800 chore: solve build error (type *big.Int has no field or method FillBy… (#281) --- all-in-one/apisix-dashboard/Dockerfile | 2 +- dashboard/Dockerfile.alpine| 2 +- dashboard/Dockerfile.centos| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/all-in-one/apisix-dashboard/Dockerfile b/all-in-one/apisix-dashboard/Dockerfile index c7a4432..5591704 100644 --- a/all-in-one/apisix-dashboard/Dockerfile +++ b/all-in-one/apisix-dashboard/Dockerfile @@ -73,7 +73,7 @@ RUN set -x \ && tar -xvf /tmp/apisix-dashboard.tar.gz -C /usr/local/apisix-dashboard --strip 1 # Build APISIX Dashboard - 2. build manager-api from source code -FROM golang:1.14 as api-builder +FROM golang:1.17 as api-builder ARG APISIX_DASHBOARD_VERSION ARG ENABLE_PROXY diff --git a/dashboard/Dockerfile.alpine b/dashboard/Dockerfile.alpine index 2267707..a724cc2 100644 --- a/dashboard/Dockerfile.alpine +++ b/dashboard/Dockerfile.alpine @@ -26,7 +26,7 @@ RUN set -x \ && cd /usr/local/apisix-dashboard && git clean -Xdf \ && rm -f ./.githash && git log --pretty=format:"%h" -1 > ./.githash -FROM --platform=$BUILDPLATFORM golang:1.14 as api-builder +FROM --platform=$BUILDPLATFORM golang:1.17 as api-builder ARG ENABLE_PROXY=false diff --git a/dashboard/Dockerfile.centos b/dashboard/Dockerfile.centos index d8c19ff..c949980 100644 --- a/dashboard/Dockerfile.centos +++ b/dashboard/Dockerfile.centos @@ -26,7 +26,7 @@ RUN set -x \ && cd /usr/local/apisix-dashboard && git clean -Xdf \ && rm -f ./.githash && git log --pretty=format:"%h" -1 > ./.githash -FROM --platform=$BUILDPLATFORM golang:1.14 as api-builder +FROM --platform=$BUILDPLATFORM golang:1.17 as api-builder ARG ENABLE_PROXY=false
[GitHub] [apisix] spacewander merged pull request #6279: build(deps): bump actions/setup-go from 2.1.5 to 2.2.0
spacewander merged pull request #6279: URL: https://github.com/apache/apisix/pull/6279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: build(deps): bump actions/setup-go from 2.1.5 to 2.2.0 (#6279)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 50d6465 build(deps): bump actions/setup-go from 2.1.5 to 2.2.0 (#6279) 50d6465 is described below commit 50d6465fd7b6288f517fd5c408a3171ace7882dd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Fri Feb 11 11:41:51 2022 +0800 build(deps): bump actions/setup-go from 2.1.5 to 2.2.0 (#6279) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/build.yml | 2 +- .github/workflows/chaos.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5e5891e..530cc48 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,7 +40,7 @@ jobs: submodules: recursive - name: Setup Go -uses: actions/setup-go@v2.1.5 +uses: actions/setup-go@v2.2.0 with: go-version: "1.15" diff --git a/.github/workflows/chaos.yml b/.github/workflows/chaos.yml index d4dafac..e26a4e9 100644 --- a/.github/workflows/chaos.yml +++ b/.github/workflows/chaos.yml @@ -21,7 +21,7 @@ jobs: submodules: recursive - name: Setup go -uses: actions/setup-go@v2.1.5 +uses: actions/setup-go@v2.2.0 with: go-version: "1.16"
[GitHub] [apisix-website] yzeng25 opened a new pull request #876: docs: add splunk blog
yzeng25 opened a new pull request #876: URL: https://github.com/apache/apisix-website/pull/876 Changes: add splunk blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #876: docs: add splunk blog
netlify[bot] commented on pull request #876: URL: https://github.com/apache/apisix-website/pull/876#issuecomment-1035854806 Deploy Preview for *apache-apisix* processing. Explore the source changes: 2e021463a7d6d62da72a723148ff5ac4c9777c3b Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6205da89216ad20007dd8c42](https://app.netlify.com/sites/apache-apisix/deploys/6205da89216ad20007dd8c42) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] spacewander merged pull request #280: feat: upgrade APISIX to 2.12.1
spacewander merged pull request #280: URL: https://github.com/apache/apisix-docker/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch master updated (3dc527c -> 029656a)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git. from 3dc527c fix(alpine): missing openldap (#278) add 029656a feat: upgrade APISIX to 2.12.1 (#280) No new revisions were added by this update. Summary of changes: .github/workflows/apisix-docker-test.yaml | 2 +- Makefile | 2 +- all-in-one/apisix/Dockerfile | 2 +- alpine/Dockerfile | 2 +- centos/Dockerfile | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
[GitHub] [apisix] spacewander commented on a change in pull request #6281: chore: compresses the redis lua script in limit-count
spacewander commented on a change in pull request #6281:
URL: https://github.com/apache/apisix/pull/6281#discussion_r804339102
##
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##
@@ -37,6 +38,10 @@ local script = [=[
return redis.call('incrby', KEYS[1], -1)
]=]
+--- compact the redis lua script
+script = string.gsub(script, "", "")
Review comment:
Better to put it in `core.string`. And the `ngx.re` version will be
faster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #34: request help: Introduce context to run plugin
spacewander commented on issue #34: URL: https://github.com/apache/apisix-go-plugin-runner/issues/34#issuecomment-1035853174 Yes. But at least it won't break existing code. This is also the way used in the std lib. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on issue #34: request help: Introduce context to run plugin
Belyenochi commented on issue #34: URL: https://github.com/apache/apisix-go-plugin-runner/issues/34#issuecomment-1035851566 > Thanks for your design. My original thought is simpler: we can add a method in the Request to return a Context. It works like the one from the standard library: https://pkg.go.dev/net/http#Request.Context. > > People can fetch it only when they need the Context. And the timeout of Context is slightly smaller than 60s so people can still break the execution with a custom response before the actual timeout. > > There is a tricky place: the timeout of Nginx is per-operation, so when we communicate with Nginx again in > > https://github.com/apache/apisix-go-plugin-runner/blob/6bb1c4bd98ec374638af7ed02931e0efb2604044/internal/http/request.go#L326 > > > the timer will be reset. Maybe we can handle this in a separate PR. There is a doubt, although we have added a timeout request to the Request, but if the plugin written by the user does not handle this context, it will still cause a timeout -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] tag 2.10.4 created (now d4e658f)
This is an automated email from the ASF dual-hosted git repository. bzp2010 pushed a change to tag 2.10.4 in repository https://gitbox.apache.org/repos/asf/apisix.git. at d4e658f (commit) No new revisions were added by this update.
[GitHub] [apisix-ingress-controller] 283713406 closed issue #844: request help: Using the client control plug-in, call the interface to return 501 Not Implemented
283713406 closed issue #844: URL: https://github.com/apache/apisix-ingress-controller/issues/844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] 283713406 commented on issue #844: request help: Using the client control plug-in, call the interface to return 501 Not Implemented
283713406 commented on issue #844: URL: https://github.com/apache/apisix-ingress-controller/issues/844#issuecomment-1035831971 Upgrade the version of APISIX and the problem is solved，Please close this issue。thanks！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] commented on pull request #41: refactor(plugin): plugins automatically register and standard interfaces
codecov[bot] commented on pull request #41: URL: https://github.com/apache/apisix-python-plugin-runner/pull/41#issuecomment-1035830371 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#41](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a699b78) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/8e6f2bc12dd1c82a18fde06d0fee799612d1?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8e6f2bc) will **decrease** coverage by `1.06%`. > The diff coverage is `81.81%`. [](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #41 +/- ## == - Coverage 93.27% 92.21% -1.07% == Files 12 11 -1 Lines 744 732 -12 == - Hits 694 675 -19 - Misses 50 57 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [apisix/runner/plugin/core.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9wbHVnaW4vY29yZS5weQ==) | `81.81% <79.48%> (-18.19%)` | :arrow_down: | | [apisix/runner/http/request.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9odHRwL3JlcXVlc3QucHk=) | `100.00% <100.00%> (+0.62%)` | :arrow_up: | | [apisix/runner/server/handle.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci9zZXJ2ZXIvaGFuZGxlLnB5) | `88.13% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [8e6f2bc...a699b78](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/41?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #861: bug: plugin kafka-logger configuration error
tao12345666333 commented on issue #861: URL: https://github.com/apache/apisix-ingress-controller/issues/861#issuecomment-1035828803 Thanks for your report. Let me check it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-python-plugin-runner] shuaijinchao opened a new pull request #41: refactor(plugin): plugins automatically register and standard interfaces
shuaijinchao opened a new pull request #41: URL: https://github.com/apache/apisix-python-plugin-runner/pull/41 FIX #40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on pull request #6214: fix(admin-token): fixed token is used by default
shuaijinchao commented on pull request #6214: URL: https://github.com/apache/apisix/pull/6214#issuecomment-1035812852 @moonming The current known security issue of `Admin API` is due to `X-REAL-IP` and has been fixed, should this PR continue? I think the implementation of this PR can still improve the security capabilities of APISIX and does not conflict with the repair of `X-REAL-IP`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hf400159 commented on pull request #6284: docs: added cpanm installation commands and remove $ sign
hf400159 commented on pull request #6284: URL: https://github.com/apache/apisix/pull/6284#issuecomment-1035783349 @tzssangglass @bzp2010 @bisakhmondal can you review this PR ? The last PR only modified the EN docs，so I submitted another PR. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] hsluoyz commented on pull request #2290: chore: added form function to authz-casbin plugin
hsluoyz commented on pull request #2290: URL: https://github.com/apache/apisix-dashboard/pull/2290#issuecomment-1035779313 @rushitote plz review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] purekeeper opened a new issue #6294: request help: Does route support regular expression ？
purekeeper opened a new issue #6294:
URL: https://github.com/apache/apisix/issues/6294
### Issue description
I have a nginx location config like :
location ~ "^/newservice/dos/api2/v2/documents/([^/]{16,})/" {
todo something
}
So how do i rewrite it by apisix's router ?
### Environment
- apisix version (cmd: `apisix version`):
- OS (cmd: `uname -a`):
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] biubiue edited a comment on issue #6283: bug: plugin kafka-logger configuration error
biubiue edited a comment on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1035750711 Not apisix-ingress-contoller, I user by `"ip": port` ,it's ok. You can try like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] biubiue commented on issue #6283: bug: plugin kafka-logger configuration error
biubiue commented on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1035750711 Not apisix-ingress-contoller, I user by `"ip": port` ,it's ok. You can try by this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist commented on a change in pull request #6202: feat: use keepalive in server-info plugin
zaunist commented on a change in pull request #6202: URL: https://github.com/apache/apisix/pull/6202#discussion_r804311241 ## File path: apisix/plugins/server-info.lua ## @@ -87,36 +80,35 @@ local function get_boot_time() end -local function uninitialized_server_info() +local function uninitialize_server_info() Review comment: Yes, I will discard this modification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist commented on a change in pull request #6202: feat: use keepalive in server-info plugin
zaunist commented on a change in pull request #6202:
URL: https://github.com/apache/apisix/pull/6202#discussion_r804311003
##
File path: apisix/plugins/server-info.lua
##
@@ -158,25 +150,70 @@ local function report(premature, report_ttl)
end
end
-server_info.last_report_time = ngx_time()
-
+-- get inside etcd data, if not exist, create it
local key = "/data_plane/server_info/" .. server_info.id
-local ok, err = core.etcd.set(key, server_info, report_ttl)
+local res, err = core.etcd.get(key)
+if err ~= nil then
+core.log.error("failed to get server_info from etcd: ", err)
+end
+
+if not res.body.node then
+local newres, err = core.etcd.set(key, server_info, report_ttl)
+if not newres then
+core.log.error("failed to set server_info: ", err)
+return
+end
+
+-- set lease_id to ngx dict
+local _, err = internal_status:set("lease_id", newres.body.lease_id)
+if err ~= nil then
+core.log.error("failed to save boot_time to shdict: ", err)
Review comment:
Thanks for your carefulness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] purekeeper opened a new issue #6293: request help: Miss metrics when call /apisix/prometheus/metrics
purekeeper opened a new issue #6293: URL: https://github.com/apache/apisix/issues/6293 ### Issue description Hi there, I enable prometheus plugin ,and call the api /apisix/prometheus/metrics just get data like pic show, miss data http_status/http_latency/bandwidth... ,anybody known the reason ? https://user-images.githubusercontent.com/15372524/153527024-e661cbaa-7d58-40cb-a243-b48fa7ca1f65.png;> ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist commented on a change in pull request #6202: feat: use keepalive in server-info plugin
zaunist commented on a change in pull request #6202:
URL: https://github.com/apache/apisix/pull/6202#discussion_r804310584
##
File path: apisix/plugins/server-info.lua
##
@@ -158,25 +150,70 @@ local function report(premature, report_ttl)
end
end
-server_info.last_report_time = ngx_time()
-
+-- get inside etcd data, if not exist, create it
local key = "/data_plane/server_info/" .. server_info.id
-local ok, err = core.etcd.set(key, server_info, report_ttl)
+local res, err = core.etcd.get(key)
+if err ~= nil then
+core.log.error("failed to get server_info from etcd: ", err)
+end
+
+if not res.body.node then
+local newres, err = core.etcd.set(key, server_info, report_ttl)
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zaunist commented on a change in pull request #6202: feat: use keepalive in server-info plugin
zaunist commented on a change in pull request #6202:
URL: https://github.com/apache/apisix/pull/6202#discussion_r804310419
##
File path: apisix/plugins/server-info.lua
##
@@ -87,36 +80,35 @@ local function get_boot_time()
end
-local function uninitialized_server_info()
+local function uninitialize_server_info()
local boot_time = get_boot_time()
return {
etcd_version = "unknown",
hostname = core.utils.gethostname(),
id = core.id.get(),
version = core.version.VERSION,
-up_time = ngx_time() - boot_time,
boot_time= boot_time,
-last_report_time = -1,
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] devops-utils-tools opened a new issue #861: bug: plugin kafka-logger configuration error
devops-utils-tools opened a new issue #861:
URL: https://github.com/apache/apisix-ingress-controller/issues/861
### Issue description
plugin kafka-logger configuration error
### Environment
- your apisix-ingress-controller version (output of
apisix-ingress-controller version --long):
- your Kubernetes cluster version (output of kubectl version):
- if you run apisix-ingress-controller in Bare-metal environment, also show
your OS version (uname -a):
### Minimal test code / Steps to reproduce
### Actual result
source yaml
```
apiVersion: apisix.apache.org/v2beta3
kind: ApisixRoute
metadata:
name: method-route
spec:
http:
- name: method
backends:
- serviceName: kubernetes
servicePort: 443
match:
methods:
- GET
paths:
- /111
plugins:
- name: request-id
enable: true
config:
include_in_response: true
header_name: "X-Request-Id"
- name: cors
enable: true
- name: proxy-rewrite
enable: true
config:
regex_uri:
- ^/case/(.*)
- /newcase/$1
- name: kafka-logger
enable: true
config:
# broker_list: "{192.168.25.111:9092}"
broker_list:
- "192.168.25.111:9092"
kafka_topic: apisix_method
name: kafka-logger-method
key: kafka-logger-method
producer_type: async
batch_max_size: 3000
inactive_timeout: 30
buffer_duration: 300
retry_delay: 5
max_retry_count: 3
```
### Error log
error log
```
[GIN] 2022/02/11 - 09:50:19 | 200 | 61.689µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:50:20 | 200 | 42.786µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:50:29 | 200 | 52.027µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:50:30 | 200 | 44.317µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:50:39 | 200 | 62.893µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:50:40 | 200 | 59.451µs | 192.168.25.63 | GET
"/healthz"
2022-02-11T09:50:41+08:00error apisix/route.go:164 failed to
create route: unexpected status code 400; error message: {"error_msg":"failed
to check the configuration of plugin kafka-logger err: property \"broker_list\"
validation failed: wrong type: expected object, got table"}
2022-02-11T09:50:41+08:00warningress/apisix_route.go:307 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/method-route","OldObject":null,"GroupVersion":"apisix.apache.org/v2beta1"},"Tombstone":null},
"error": "1 error occurred:\n\t* unexpected status code 400; error message:
{\"error_msg\":\"failed to check the configuration of plugin kafka-logger err:
property \\\"broker_list\\\" validation failed: wrong type: expected object,
got table\"}\n\n\n"}
```
### Expected result
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2290: chore: added form function to authz-casbin plugin
guoqqqi commented on a change in pull request #2290:
URL: https://github.com/apache/apisix-dashboard/pull/2290#discussion_r804301828
##
File path: CHANGELOG.md
##
@@ -50,7 +50,7 @@ This release contains some features and bugfixes, and all the
existing functiona
### Bugfix
- fix: supports search by name for service options when add router
[#2066](https://github.com/apache/apisix-dashboard/pull/2066)
-- fix: gzip plugin schema typo
[#2142](https://github.com/apache/apisix-dashboard/pull/2142)
+- fix: gzip schema typo
[#2142](https://github.com/apache/apisix-dashboard/pull/2142)
Review comment:
What is the reason for this change?
##
File path: web/src/components/Plugin/UI/authz-keycloak.tsx
##
@@ -0,0 +1,92 @@
+import { FormInstance, Input } from "antd";
+import React from "react";
+import { useIntl } from "umi";
+import Form from "antd/es/form";
+
+type Props = {
+form: FormInstance;
+schema: Record | undefined;
+ref?: any;
+}
+
+const FORM_ITEM_LAYOUT = {
+labelCol: {
+span: 7,
+},
+wrapperCol: {
+span: 8,
+},
+};
+
+const AuthzKeycloak: React.FC = ({ form, schema }) => {
+const { formatMessage } = useIntl();
+const properties = schema?.properties
+
+return (
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+)
+}
+
+export default AuthzKeycloak
Review comment:
need a new blank
##
File path: web/src/components/Plugin/UI/plugin.tsx
##
@@ -75,6 +79,11 @@ export const PluginForm: React.FC = ({ name, schema,
renderForm, form })
return ;
case 'referer-restriction':
return ;
+case 'authz-casbin':
+ return ;
+ case 'authz-keycloak':
+ return ;
Review comment:
format code the file
##
File path: web/src/components/Plugin/UI/authz-keycloak.tsx
##
@@ -0,0 +1,92 @@
+import { FormInstance, Input } from "antd";
+import React from "react";
+import { useIntl } from "umi";
+import Form from "antd/es/form";
+
+type Props = {
+form: FormInstance;
+schema: Record | undefined;
+ref?: any;
+}
+
+const FORM_ITEM_LAYOUT = {
+labelCol: {
+span: 7,
+},
+wrapperCol: {
+span: 8,
+},
+};
+
+const AuthzKeycloak: React.FC = ({ form, schema }) => {
+const { formatMessage } = useIntl();
+const properties = schema?.properties
+
+return (
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+)
+}
+
+export default AuthzKeycloak
Review comment:
and format the file
##
File path: yarn.lock
##
@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
Review comment:
This file seems to be a redundant file
##
File path: web/src/components/Plugin/UI/authz-casbin.tsx
##
@@ -0,0 +1,76 @@
+import { useIntl } from "umi";
+import Form, { FormInstance } from "antd/es/form";
+import React from "react";
+import { Input } from "antd";
+
+type Props = {
Review comment:
Please set spaces to 2 and format the code
##
File path: web/src/components/Plugin/UI/authz-casbin.tsx
##
@@ -0,0 +1,76 @@
+import { useIntl } from "umi";
+import Form, { FormInstance } from "antd/es/form";
+import React from "react";
+import { Input } from "antd";
+
+type Props = {
+form: FormInstance;
+schema: Record | undefined;
+ref?: any;
+}
+
+const FORM_ITEM_LAYOUT = {
+labelCol: {
+span: 7,
+},
+wrapperCol: {
+span: 8,
+},
+};
+
+const AuthzCasbin: React.FC = ({ form, schema }) => {
+const { formatMessage } = useIntl();
+const properties = schema?.properties
+
+return (
+
+
+
+
+
+
+
+
+
+
+
+
+)
+}
+
+
+
+export default AuthzCasbin
Review comment:
Usually we need to add a new blank line at the end of the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #853: question: How to use Service IP as upstream instead of Pod IP
tao12345666333 commented on issue #853: URL: https://github.com/apache/apisix-ingress-controller/issues/853#issuecomment-1035708112 Is there any information in the apisix-ingress-controller log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on issue #6260: request help: JWT Auth
starsz commented on issue #6260:
URL: https://github.com/apache/apisix/issues/6260#issuecomment-1035707770
> Sure, this is our most recent config, which kind of works. I see that
adding the public key works, but without that, it seems to try to do something
like POSTing to introspection_endpoint? It seems the scope value is not used to
inspect the scope(s) in the token, but instead is used somehow with these
endpoints? So basically any valid token gets through.
>
> { "access_token_in_authorization_header": true, "bearer_only": true,
"client_id": "unconfigured", "client_secret": "unconfigured", "disable": false,
"discovery":
"https://KEYCLOAKHOST/auth/realms/REALM/.well-known/openid-configuration;,
"public_key": "-BEGIN PUBLIC KEY-KEY\n-END PUBLIC KEY-" }
>
> The samples you are showing seem to be from authz-keycloak? We are using
keycloak for testing, but are likely to be using something else in other
envs/projects. Will authz-keycloak interop only with Keycloak, or can it be
used with any JWT token provider, assuming it has endpoints for certs? Also, in
that sample up above for authz-keycloak, it has a client_id value, how is that
used? Is it expecting the jwt token to have that client_id as a value, or is it
somehow using that to authenticate to Keycloak for some reason?
Hi, @seanleblanc Can you have a try at the master version. Since we have
supported use jwks in this PR:
https://github.com/apache/apisix/commit/fec47142eb1e98f387686a2f172920a9fd5cbb90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] devops-utils-tools edited a comment on issue #6283: bug: plugin kafka-logger configuration error
devops-utils-tools edited a comment on issue #6283:
URL: https://github.com/apache/apisix/issues/6283#issuecomment-1035705124
```
[GIN] 2022/02/11 - 09:32:49 | 200 | 43.49µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:32:50 | 200 | 57.352µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:32:59 | 200 | 55.962µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:00 | 200 | 39.507µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:09 | 200 | 71.029µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:10 | 200 | 41.372µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:19 | 200 | 59.775µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:20 | 200 | 41.427µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:29 | 200 | 48.348µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:30 | 200 | 42.612µs | 192.168.25.63 | GET
"/healthz"
2022-02-11T09:33:34+08:00error apisix/route.go:164 failed to
create route: unexpected status code 400; error message: {"error_msg":"failed
to check the configuration of plugin kafka-logger err: property \"broker_list\"
validation failed: wrong type: expected object, got table"}
2022-02-11T09:33:34+08:00warningress/apisix_route.go:307 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/method-route","OldObject":null,"GroupVersion":"apisix.apache.org/v2beta1"},"Tombstone":null},
"error": "1 error occurred:\n\t* unexpected status code 400; error message:
{\"error_msg\":\"failed to check the configuration of plugin kafka-logger err:
property \\\"broker_list\\\" validation failed: wrong type: expected object,
got table\"}\n\n\n"}
```
config:
# broker_list: "{192.168.25.111:9092}"
broker_list:
- "192.168.25.111:9092"
```
```
NAME NAMESPACE REVISIONUPDATED
STATUS CHART APP
VERSION
apisix apisix 1 2022-02-10
19:41:53.407147858 +0800 CST deployedapisix-0.8.1
2.12.0
apisix-dashboard apisix 1 2022-02-11
09:25:59.048174135 +0800 CST deployedapisix-dashboard-0.3.0
2.9.0
apisix-ingress-controllerapisix 1 2022-02-11
09:26:16.594555966 +0800 CST deployedapisix-ingress-controller-0.9.0
1.4.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] devops-utils-tools commented on issue #6283: bug: plugin kafka-logger configuration error
devops-utils-tools commented on issue #6283:
URL: https://github.com/apache/apisix/issues/6283#issuecomment-1035705124
```
[GIN] 2022/02/11 - 09:32:49 | 200 | 43.49µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:32:50 | 200 | 57.352µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:32:59 | 200 | 55.962µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:00 | 200 | 39.507µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:09 | 200 | 71.029µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:10 | 200 | 41.372µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:19 | 200 | 59.775µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:20 | 200 | 41.427µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:29 | 200 | 48.348µs | 192.168.25.63 | GET
"/healthz"
[GIN] 2022/02/11 - 09:33:30 | 200 | 42.612µs | 192.168.25.63 | GET
"/healthz"
2022-02-11T09:33:34+08:00error apisix/route.go:164 failed to
create route: unexpected status code 400; error message: {"error_msg":"failed
to check the configuration of plugin kafka-logger err: property \"broker_list\"
validation failed: wrong type: expected object, got table"}
2022-02-11T09:33:34+08:00warningress/apisix_route.go:307 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/method-route","OldObject":null,"GroupVersion":"apisix.apache.org/v2beta1"},"Tombstone":null},
"error": "1 error occurred:\n\t* unexpected status code 400; error message:
{\"error_msg\":\"failed to check the configuration of plugin kafka-logger err:
property \\\"broker_list\\\" validation failed: wrong type: expected object,
got table\"}\n\n\n"}
```
config:
# broker_list: "{192.168.25.111:9092}"
broker_list:
- "192.168.25.111:9092"
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
