[GitHub] [apisix-helm-chart] zaunist opened a new pull request #241: docs(README): unify namespace
zaunist opened a new pull request #241: URL: https://github.com/apache/apisix-helm-chart/pull/241 Unify namespace in README.md and fix some formatting errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on pull request #6426: feat: add `rewrite:RespHeaders` and modify the upstream response headers via `request` implementation
shuaijinchao commented on pull request #6426: URL: https://github.com/apache/apisix/pull/6426#issuecomment-1055132608 @rampagecong r Ok, I need some time to check this question and get back to you later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao edited a comment on pull request #6426: feat: add `rewrite:RespHeaders` and modify the upstream response headers via `request` implementation
shuaijinchao edited a comment on pull request #6426: URL: https://github.com/apache/apisix/pull/6426#issuecomment-1055132608 @rampagecong OK, I need some time to check this question and get back to you later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #897: docs: improve Community Section
netlify[bot] edited a comment on pull request #897: URL: https://github.com/apache/apisix-website/pull/897#issuecomment-104755 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 0f17128034eaf9e87d3d899bb8dd0c2f201905f0 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621dd4580230cb00077ac2aa](https://app.netlify.com/sites/apache-apisix/deploys/621dd4580230cb00077ac2aa) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #897: docs: improve Community Section
netlify[bot] edited a comment on pull request #897: URL: https://github.com/apache/apisix-website/pull/897#issuecomment-104755 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 0f17128034eaf9e87d3d899bb8dd0c2f201905f0 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621dd4580230cb00077ac2aa](https://app.netlify.com/sites/apache-apisix/deploys/621dd4580230cb00077ac2aa) 😎 Browse the preview: [https://deploy-preview-897--apache-apisix.netlify.app](https://deploy-preview-897--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] navendu-pottekkat commented on pull request #897: docs: improve Community Section
navendu-pottekkat commented on pull request #897: URL: https://github.com/apache/apisix-website/pull/897#issuecomment-1055140371 @Anita-ihuman There is a merge conflict here. Could you check that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #6442: docs: refactor how-to-build.md
shuaijinchao commented on a change in pull request #6442:
URL: https://github.com/apache/apisix/pull/6442#discussion_r816535374
##
File path: docs/en/latest/how-to-build.md
##
@@ -117,20 +117,20 @@ Follow the steps below to install Apache APISIX via the
source release package.
make install
```
- **Note**: If `make deps` fails with "install `lualdap` failed" with an error
like `Could not find header file for LDAP` try the solution below.
-
- Solution: luarocks supports adding custom package filepaths to the
project. You can set `LDAP_DIR` with `luarocks config` manually, for example
`luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`. You should
config as follows:
- 1. Install `openldap` locally using tools including but not limited to
'brew';
- 2. Locate the 'openldap' local installation directory. If you are macOS
and use `brew` to install `openldap`, you can find the local installation
directory with the `brew --prefix openldap` command.
- 3. Manually set the `LDAP_DIR` variable via `luarocks config`, e.g.
`luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`.
- 4. Of course, you can also choose to change the default configuration
file of luarocks directly, execute the 'cat ~/.luarocks/config-5.1.lua'
command, and then add the installation directory of 'openldap' to the file.
Example as follows:
- ```lua
- variables = {
- LDAP_DIR = "/opt/homebrew/cellar/openldap/2.6.1",
- LDAP_INCDIR = "/opt/homebrew/cellar/openldap/2.6.1/include",
- }
- ```
- If you have similar problems installing other dependencies, you can
refer to this solution as well.
+ **Note**: It will definitely be a problem set of dependency failed
installation, If you fail to install with `make deps` and get an error message
like `Could not find header file for LDAP`. Similarly, you can use this method
to solve installation problems such as `Could not find header file for PCRE` or
others.
+
+ Solution for macOS:
+
+1. Install `openldap` with `brew install openldap`;
+2. Locate installation directory with `brew --prefix openldap`;
+3. Add the path to the project configuration file(choose one of the
following two methods):
+ 1. Solution A: You can set `LDAP_DIR` with `luarocks config` manually,
for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`;
Review comment:
The first method is the original general solution. Is it suitable to
integrate it into the macos system general solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6467: refactor(grpc-transcode): new way to handle pb file
spacewander commented on a change in pull request #6467:
URL: https://github.com/apache/apisix/pull/6467#discussion_r816539196
##
File path: apisix/plugins/grpc-transcode/proto.lua
##
@@ -77,20 +77,22 @@ local function compile_proto_bin(content)
return nil
end
+local files = pb.decode("google.protobuf.FileDescriptorSet", content).file
Review comment:
The test cases are
https://github.com/apache/apisix/blob/beff2df3311d86260db75315af1974e8d7326217/t/plugin/grpc-transcode2.t#L236
and below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2341](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86fcf4d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/fd44364d2563aac83e2ad8f4a340fc64af4375d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd44364) will **decrease** coverage by `19.07%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2341 +/- ## === - Coverage 68.17% 49.10% -19.08% === Files 127 41 -86 Lines3375 3179 -196 Branches 8300 -830 === - Hits 2301 1561 -740 - Misses 1074 1419 +345 - Partials0 199 +199 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `49.10% <0.00%> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (ø)` | | | [web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==) | | | | [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | | | | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | | | | [...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==) | | | | [...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==) | | | | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZ
[GitHub] [apisix] starsz commented on a change in pull request #6455: feat: support post_logout_redirect_uri config in openid-connect plugin
starsz commented on a change in pull request #6455:
URL: https://github.com/apache/apisix/pull/6455#discussion_r816554852
##
File path: t/plugin/openid-connect.t
##
@@ -1665,3 +1665,319 @@ GET /t
false
--- error_log
OIDC introspection failed: invalid jwt: invalid jwt string
+
+
+
+=== TEST 28: Modify route to match catch-all URI `/*` and add
post_logout_redirect_uri option.
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"openid-connect": {
+"discovery":
"http://127.0.0.1:8090/auth/realms/University/.well-known/openid-configuration";,
+"realm": "University",
+"client_id": "course_management",
+"client_secret":
"d1ec69e9-55d2-4109-a3ea-befa071579d5",
+"redirect_uri": "http://127.0.0.1:]] ..
ngx.var.server_port .. [[/authenticated",
+"ssl_verify": false,
+"timeout": 10,
+"introspection_endpoint_auth_method":
"client_secret_post",
+"introspection_endpoint":
"http://127.0.0.1:8090/auth/realms/University/protocol/openid-connect/token/introspect";,
+"set_access_token_header": true,
+"access_token_in_authorization_header": false,
+"set_id_token_header": true,
+"set_userinfo_header": true,
+"post_logout_redirect_uri":
"http://127.0.0.1:]] .. ngx.var.server_port .. [[/hello"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]],
+[[{
+"node": {
+"value": {
+"plugins": {
+"openid-connect": {
+"client_id": "course_management",
+"client_secret":
"d1ec69e9-55d2-4109-a3ea-befa071579d5",
+"discovery":
"http://127.0.0.1:8090/auth/realms/University/.well-known/openid-configuration";,
+"redirect_uri": "http://127.0.0.1:]] ..
ngx.var.server_port .. [[/authenticated",
+"ssl_verify": false,
+"timeout": 10,
+"realm": "University",
+"introspection_endpoint_auth_method":
"client_secret_post",
+"introspection_endpoint":
"http://127.0.0.1:8090/auth/realms/University/protocol/openid-connect/token/introspect";,
+"set_access_token_header": true,
+"access_token_in_authorization_header":
false,
+"set_id_token_header": true,
+"set_userinfo_header": true,
+"post_logout_redirect_uri":
"http://127.0.0.1:]] .. ngx.var.server_port .. [[/hello"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+},
+"key": "/apisix/routes/1"
+},
+"action": "set"
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 29: Access route w/o bearer token and request logout to redirect to
post_logout_redirect_uri.
+--- config
+location /t {
+content_by_lua_block {
+local http = require "resty.http"
+local httpc = http.new()
+
+-- Invoke /uri endpoint w/o bearer token. Should receive redirect
to Keycloak authorization endpoint.
+local uri = "http://127.0.0.1:"; .. ngx.var.server_port .. "/uri"
+local res, err = httpc:request_uri(uri, {method = "GET"})
+
+
[GitHub] [apisix] starsz commented on a change in pull request #6455: feat: support post_logout_redirect_uri config in openid-connect plugin
starsz commented on a change in pull request #6455:
URL: https://github.com/apache/apisix/pull/6455#discussion_r816555329
##
File path: t/plugin/openid-connect.t
##
@@ -1665,3 +1665,319 @@ GET /t
false
--- error_log
OIDC introspection failed: invalid jwt: invalid jwt string
+
+
+
+=== TEST 28: Modify route to match catch-all URI `/*` and add
post_logout_redirect_uri option.
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"openid-connect": {
+"discovery":
"http://127.0.0.1:8090/auth/realms/University/.well-known/openid-configuration";,
+"realm": "University",
+"client_id": "course_management",
+"client_secret":
"d1ec69e9-55d2-4109-a3ea-befa071579d5",
+"redirect_uri": "http://127.0.0.1:]] ..
ngx.var.server_port .. [[/authenticated",
+"ssl_verify": false,
+"timeout": 10,
+"introspection_endpoint_auth_method":
"client_secret_post",
+"introspection_endpoint":
"http://127.0.0.1:8090/auth/realms/University/protocol/openid-connect/token/introspect";,
+"set_access_token_header": true,
+"access_token_in_authorization_header": false,
+"set_id_token_header": true,
+"set_userinfo_header": true,
+"post_logout_redirect_uri":
"http://127.0.0.1:]] .. ngx.var.server_port .. [[/hello"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]],
+[[{
+"node": {
Review comment:
Let me remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2290: feat: added form function to authz-casbin plugin
bzp2010 commented on pull request #2290: URL: https://github.com/apache/apisix-dashboard/pull/2290#issuecomment-1055163198 @juxianzheng I have read the code and I don't think you need to add separate test code for this feature, we already have testing capabilities dedicated to various plugin UI's. You can see it in this file `web/cypress/fixtures/plugin-dataset.json`, just add the corresponding json data to automatically generate the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6429: request help: A TLS API is routed, but the Client Key is different from the original one
tzssangglass commented on issue #6429: URL: https://github.com/apache/apisix/issues/6429#issuecomment-1055171499 Can you upload successfully with the py scripts and certs of the official test cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] xgenvn opened a new issue #242: Add option to enable control_api for apisix gateway
xgenvn opened a new issue #242: URL: https://github.com/apache/apisix-helm-chart/issues/242 In some scenarios where we need an endpoint to return 20x status for lb service health check (eg: on GKE, APISIX is configured to sit behind an ingress route). The easiest way is to enable `control_api` when installing through helm and a way to configure health check configuration in deployment resource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #6478: test: switch back to openresty/test-nginx
spacewander opened a new pull request #6478: URL: https://github.com/apache/apisix/pull/6478 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6429: request help: A TLS API is routed, but the Client Key is different from the original one
tzssangglass commented on issue #6429: URL: https://github.com/apache/apisix/issues/6429#issuecomment-1055176740 > Bag Attributes > friendlyName: client > localKeyID: 54 69 6D 65 20 31 36 34 36 31 31 38 36 33 35 38 32 31 > Key Attributes: I think it is the format of this paragraph is wrong, you can refer to the format of cert he key under `t/certs` and use the official reference py sctipt to read them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] drrrMikado edited a comment on issue #886: bug: ingress-controller always shows this log not found service, but the service is actually there
drrrMikado edited a comment on issue #886:
URL:
https://github.com/apache/apisix-ingress-controller/issues/886#issuecomment-1054899795
log:
```
2022-03-01T09:49:03+08:00 error translation/apisix_route.go:338 failed
to get service port in backend {"backend":
{"serviceName":"flow-control-server-go-dev","servicePort":80,"weight":null},
"apisix_route":
{"kind":"ApisixRoute","apiVersion":"apisix.apache.org/v2beta2","metadata":{"name":"flow-control-server-go-dev","namespace":"flow-control-server-go","selfLink":"/apis/apisix.apache.org/v2beta2/namespaces/flow-control-server-go/apisixroutes/flow-control-server-go-dev","uid":"178a1217-3674-465e-b07b-be7d60acc57c","resourceVersion":"9564966417","generation":1,"creationTimestamp":"2022-02-28T03:51:33Z","annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"apisix.apache.org/v2beta3\",\"kind\":\"ApisixRoute\",\"metadata\":{\"annotations\":{},\"name\":\"flow-control-server-go-dev\",\"namespace\":\"flow-control-server-go\"},\"spec\":{\"http\":[{\"backends\":[{\"serviceName\":\"flow-control-server-go-dev\",\"servicePort\":80}],\"match\":{\"hosts\":[\"flow-
control-server-go-dev.xxx.com\"],\"paths\":[\"/ws\"]},\"name\":\"websocket\",\"websocket\":true},{\"backends\":[{\"serviceName\":\"flow-control-server-go-dev\",\"servicePort\":80}],\"match\":{\"hosts\":[\"flow-control-server-go-dev.xxx.com\"],\"paths\":[\"/*\"]},\"name\":\"default\"}]}}\n"},"managedFields":[{"manager":"apisix-ingress-controller","operation":"Update","apiVersion":"apisix.apache.org/v2beta2","time":"2022-02-28T03:51:33Z","fieldsType":"FieldsV1","fieldsV1":{"f:spec":{"f:http":{}},"f:status":{".":{},"f:conditions":{,{"manager":"kubectl-client-side-apply","operation":"Update","apiVersion":"apisix.apache.org/v2beta3","time":"2022-02-28T03:51:33Z","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:annotations":{".":{},"f:kubectl.kubernetes.io/last-applied-configuration":{}}},"f:spec":{}}}]},"spec":{"http":[{"name":"websocket","match":{"paths":["/ws"],"hosts":["flow-control-server-go-dev.xxx.com"]},"backends":[{"serviceName":"flow-control-server-go-dev","servicePort":
80,"weight":null}],"websocket":true,"authentication":{"enable":false,"type":"","keyauth":{}}},{"name":"default","match":{"paths":["/*"],"hosts":["flow-control-server-go-dev.xxx.com"]},"backends":[{"serviceName":"flow-control-server-go-dev","servicePort":80,"weight":null}],"websocket":false,"authentication":{"enable":false,"type":"","keyauth":{}}}]},"status":{"conditions":[{"type":"ResourcesAvailable","status":"True","observedGeneration":1,"lastTransitionTime":null,"reason":"ResourcesSynced","message":"Sync
Successfully"}]}}, "error": "service \"flow-control-server-go-dev\" not found"}
2022-03-01T09:49:03+08:00 error ingress/apisix_route.go:159 failed
to translate ApisixRoute v2beta2 {"error": "service
\"flow-control-server-go-dev\" not found", "object": {}}
2022-03-01T09:49:03+08:00 warningress/apisix_route.go:307 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"flow-control-server-go/flow-control-server-go-dev","OldObject":null,"GroupVersion":"apisix.apache.org/v2beta2"},"Tombstone":null},
"error": "service \"flow-control-server-go-dev\" not found"}
// 'platform/account-system' also not found, but log level is info, not
error.
2022-03-01T09:49:03+08:00 infoingress/controller.go:609 service
platform/account-system not found
```
ApisixRoute:
```yaml
apiVersion: apisix.apache.org/v2beta3
kind: ApisixRoute
metadata:
name: flow-control-server-go-dev
namespace: flow-control-server-go
spec:
http:
- name: websocket
match:
hosts:
- flow-control-server-go-dev.xxx.com
paths:
- /ws
backends:
- serviceName: flow-control-server-go-dev
servicePort: 80
websocket: true
- name: default
match:
hosts:
- flow-control-server-go-dev.xxx.com
paths:
- /*
backends:
- serviceName: flow-control-server-go-dev
servicePort: 80
```
Service:
```yaml
kind: Service
apiVersion: v1
metadata:
name: flow-control-server-go-dev
namespace: flow-control-server-go
labels:
app: flow-control-server-go-dev
spec:
ports:
- name: web
protocol: TCP
port: 80
targetPort: 8000
selector:
app: flow-control-server-go-dev
version: v1
type: NodePort
sessionAffinity: None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zlhgo edited a comment on issue #6184: bug: balancer.lua:187: attempt to index local 'up_conf' (a nil value)
zlhgo edited a comment on issue #6184: URL: https://github.com/apache/apisix/issues/6184#issuecomment-1053857163 经过20天的线上验证，该问题目前没有再出现过。下面说下解决方法、思路和自查是否同样的问题。 1、解决方法 修改 `/usr/local/openresty/lualib/tablepool.lua` 文件，去掉内存复用相关的功能，每次申请新的内存。 ```lua local newtab = require "table.new" local _M = newtab(0, 2) function _M.fetch(tag, narr, nrec) return newtab(narr, nrec) end function _M.release(tag, obj, noclear) -- nil end return _M -- vi: ft=lua ts=4 sw=4 et ``` 2、解决思路 其实也是蒙的。因为看了apisix的代码感觉也没什么问题，从`access.log`日志里看就是串站了，所以怀疑可能是api_ctx的内存串了，但是我也不敢确定是这个问题。 3、问题自查 ```bash cat /usr/local/apisix/logs/error.log | grep pick_server | grep picked_server ``` 如果上面命令没有输出就是对的(需开启info级别的error log)。思路就是执行 `pick_server` 的时候正常情况下 `api_ctx` 变量里是没有 `picked_server` 这个属性存在。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juxianzheng commented on pull request #2290: feat: added form function to authz-casbin plugin
juxianzheng commented on pull request #2290: URL: https://github.com/apache/apisix-dashboard/pull/2290#issuecomment-1055182300 > @juxianzheng我已经阅读了代码，我认为您不需要为此功能添加单独的测试代码，我们已经拥有专门针对各种插件 UI 的测试功能。在这个文件中可以看到`web/cypress/fixtures/plugin-dataset.json`，只需添加相应的json数据即可自动生成测试。 So do I still need to make changes to the code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] drrrMikado commented on issue #886: bug: ingress-controller always shows this log not found service, but the service is actually there
drrrMikado commented on issue #886: URL: https://github.com/apache/apisix-ingress-controller/issues/886#issuecomment-1055186323 > hi @drrrMikado I see that your ApisixRoute resource is in `flow-control-server-go` namespace, but Service `flow-control-server-go-dev` is in `flow-control-server-go-dev` namespace, so it will not be found. I'm sorry. It's my fault. I copied it wrong. I updated the above configuration and added screenshots.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on a change in pull request #6428: ci: add shellcheck linter
kwanhur commented on a change in pull request #6428:
URL: https://github.com/apache/apisix/pull/6428#discussion_r816604421
##
File path: .github/workflows/code-lint.yml
##
@@ -28,3 +28,20 @@ jobs:
. ./ci/common.sh
export_or_prefix
make lint
+
+ sc-lint:
+runs-on: ubuntu-latest
+timeout-minutes: 5
+steps:
+ - name: Checkout code
+uses: actions/checkout@v2.4.0
+with:
+ submodules: true
+
+ - name: Shellcheck code
+run: |
+ scversion="latest"
+ wget -O-
"https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz";
| tar -xJv
+ cp -av "shellcheck-${scversion}/shellcheck" /usr/local/bin/
+ shellcheck --version
+ shellcheck **/*.sh
Review comment:
Ok, I got the meaning that checkout repo without submodule, so it won't
lint the code from git submodule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on a change in pull request #6428: ci: add shellcheck linter
kwanhur commented on a change in pull request #6428:
URL: https://github.com/apache/apisix/pull/6428#discussion_r816607893
##
File path: .github/workflows/code-lint.yml
##
@@ -28,3 +28,20 @@ jobs:
. ./ci/common.sh
export_or_prefix
make lint
+
+ sc-lint:
+runs-on: ubuntu-latest
+timeout-minutes: 5
+steps:
+ - name: Checkout code
+uses: actions/checkout@v2.4.0
+with:
+ submodules: true
+
+ - name: Shellcheck code
+run: |
+ scversion="latest"
+ wget -O-
"https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz";
| tar -xJv
+ cp -av "shellcheck-${scversion}/shellcheck" /usr/local/bin/
+ shellcheck --version
+ shellcheck **/*.sh
Review comment:
> Let's limit the scope. We don't want to lint the code from git
submodule.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] drrrMikado commented on issue #886: bug: ingress-controller always shows this log not found service, but the service is actually there
drrrMikado commented on issue #886:
URL:
https://github.com/apache/apisix-ingress-controller/issues/886#issuecomment-1055245468
Also, I get a different error.
```
2022-03-01T17:55:49+08:00 error ingress/status.go:197 failed to get
APISIX gateway external IPs {"error": "resource name may not be empty"}
2022-03-01T17:55:49+08:00 error ingress/status.go:197 failed to get
APISIX gateway external IPs {"error": "resource name may not be empty"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] aiyiyi121 opened a new issue #6479: request help: Can I send HTTPS requests to apisix via IP
aiyiyi121 opened a new issue #6479: URL: https://github.com/apache/apisix/issues/6479 ### Issue description Because our firewall can only use IP to check HTTPS security. How can I send HTTPS requests to apisix via IP? ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rampagecong commented on a change in pull request #6426: feat: add `rewrite:RespHeaders` and modify the upstream response headers via `request` implementation
rampagecong commented on a change in pull request #6426:
URL: https://github.com/apache/apisix/pull/6426#discussion_r816629285
##
File path: t/lib/ext-plugin.lua
##
@@ -367,6 +367,33 @@ function _M.go(case)
local action = http_req_call_rewrite.End(builder)
build_action(action, http_req_call_action.Rewrite)
+elseif case.rewrite_resp_header == true then
+local hdrs = {
Review comment:
I have added two test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] rampagecong commented on pull request #6426: feat: add `rewrite:RespHeaders` and modify the upstream response headers via `request` implementation
rampagecong commented on pull request #6426: URL: https://github.com/apache/apisix/pull/6426#issuecomment-1055263080 `[root@iZbp1efn5vn52xspp2bid5Z apisix]# prove -I. -I../test-nginx/inc -I../test-nginx/lib -r t/plugin/ext-plugin/http-req-call.t t/plugin/ext-plugin/http-req-call.t .. ok All tests successful. Files=1, Tests=18, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.39 cusr 0.10 csys = 0.51 CPU) Result: PASS` Successfully! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #242: Add option to enable control_api for apisix gateway
tokers commented on issue #242: URL: https://github.com/apache/apisix-helm-chart/issues/242#issuecomment-1055265501 @xgenvn PR is welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #3818: request help: type mismatch at offset 33, bytes expected for type string, got varint
github-actions[bot] commented on issue #3818: URL: https://github.com/apache/apisix/issues/3818#issuecomment-1055268326 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #3704: [DISCUSS] Use label instead of ID
github-actions[bot] closed issue #3704: URL: https://github.com/apache/apisix/issues/3704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #3704: [DISCUSS] Use label instead of ID
github-actions[bot] commented on issue #3704: URL: https://github.com/apache/apisix/issues/3704#issuecomment-1055268279 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Chever-John commented on a change in pull request #6442: docs: refactor how-to-build.md
Chever-John commented on a change in pull request #6442:
URL: https://github.com/apache/apisix/pull/6442#discussion_r816636240
##
File path: docs/en/latest/how-to-build.md
##
@@ -117,20 +117,20 @@ Follow the steps below to install Apache APISIX via the
source release package.
make install
```
- **Note**: If `make deps` fails with "install `lualdap` failed" with an error
like `Could not find header file for LDAP` try the solution below.
-
- Solution: luarocks supports adding custom package filepaths to the
project. You can set `LDAP_DIR` with `luarocks config` manually, for example
`luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`. You should
config as follows:
- 1. Install `openldap` locally using tools including but not limited to
'brew';
- 2. Locate the 'openldap' local installation directory. If you are macOS
and use `brew` to install `openldap`, you can find the local installation
directory with the `brew --prefix openldap` command.
- 3. Manually set the `LDAP_DIR` variable via `luarocks config`, e.g.
`luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`.
- 4. Of course, you can also choose to change the default configuration
file of luarocks directly, execute the 'cat ~/.luarocks/config-5.1.lua'
command, and then add the installation directory of 'openldap' to the file.
Example as follows:
- ```lua
- variables = {
- LDAP_DIR = "/opt/homebrew/cellar/openldap/2.6.1",
- LDAP_INCDIR = "/opt/homebrew/cellar/openldap/2.6.1/include",
- }
- ```
- If you have similar problems installing other dependencies, you can
refer to this solution as well.
+ **Note**: It will definitely be a problem set of dependency failed
installation, If you fail to install with `make deps` and get an error message
like `Could not find header file for LDAP`. Similarly, you can use this method
to solve installation problems such as `Could not find header file for PCRE` or
others.
+
+ Solution for macOS:
+
+1. Install `openldap` with `brew install openldap`;
+2. Locate installation directory with `brew --prefix openldap`;
+3. Add the path to the project configuration file(choose one of the
following two methods):
+ 1. Solution A: You can set `LDAP_DIR` with `luarocks config` manually,
for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`;
Review comment:
I think first method is a part of solution.
macOS needs it. Ubuntu also needs it.
If I separate it from solution, two problems will arise, solution for macOS
will lose its integrity, and the luarocks approach will lose support(path of
package) leading to a lose of persuasion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #6429: request help: A TLS API is routed, but the Client Key is different from the original one
tokers commented on issue #6429:
URL: https://github.com/apache/apisix/issues/6429#issuecomment-1055274630
> @tokers It is mTLS Between APISIX and Upstream, how do I config
config.yaml? And I refer to the official document to use
patch_upstream_mtls.py, and the error is as follows : Refer:
https://apisix.apache.org/docs/apisix/mtls/#mtls-between-apisix-and-upstream
>
> 404 {"message":"Key not found"}
You can check out this:
https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L147.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] lijing-21 commented on pull request #237: feat: allow defining security context on ingress controller helm chart
lijing-21 commented on pull request #237: URL: https://github.com/apache/apisix-helm-chart/pull/237#issuecomment-1055275647 Hi @dgff07 , thank you for your contribution! Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :) [1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #6479: request help: Can I send HTTPS requests to apisix via IP
tokers commented on issue #6479:
URL: https://github.com/apache/apisix/issues/6479#issuecomment-1055277098
@aiyiyi121 FYI:
```
curl https://{APISIX IP}:{APISIX HTTPS PORT}/path/to/your/api
```
If the requests failed since the TLS issues, check out curl manual and find
some options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #912: docs: edit title, del nacos introduction
netlify[bot] edited a comment on pull request #912: URL: https://github.com/apache/apisix-website/pull/912#issuecomment-1053974719 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 36a97fb751dab9c8c933fcd632bd7f6e98b81280 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621df581c4da290007b58be6](https://app.netlify.com/sites/apache-apisix/deploys/621df581c4da290007b58be6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #912: docs: edit title, del nacos introduction
netlify[bot] edited a comment on pull request #912: URL: https://github.com/apache/apisix-website/pull/912#issuecomment-1053974719 ✔️ Deploy Preview for *apache-apisix* canceled. 🔨 Explore the source changes: 36a97fb751dab9c8c933fcd632bd7f6e98b81280 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621df581c4da290007b58be6](https://app.netlify.com/sites/apache-apisix/deploys/621df581c4da290007b58be6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lijing-21 commented on issue #6369: docs: need to update https://apisix.apache.org/zh/docs/apisix/plugin-develop/
lijing-21 commented on issue #6369: URL: https://github.com/apache/apisix/issues/6369#issuecomment-1055280719 Hi @shenzhuangzhi1 , thank you for your contribution! Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :) [1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lijing-21 commented on pull request #872: fix ingress delete panic
lijing-21 commented on pull request #872: URL: https://github.com/apache/apisix-ingress-controller/pull/872#issuecomment-1055283794 Hi @champly , thank you for your contribution! Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :) [1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] lijing-21 commented on pull request #899: docs: Updated Contributor Guide page and Committer Guide page
lijing-21 commented on pull request #899: URL: https://github.com/apache/apisix-website/pull/899#issuecomment-1055285498 Hi @BhavyaT-135 , thank you for your contribution! Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :) [1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aiyiyi121 commented on issue #6479: request help: Can I send HTTPS requests to apisix via IP
aiyiyi121 commented on issue #6479:
URL: https://github.com/apache/apisix/issues/6479#issuecomment-1055293842
> @aiyiyi121 FYI:
>
> ```
> curl https://{APISIX IP}:{APISIX HTTPS PORT}/path/to/your/api
> ```
>
> If the requests failed since the TLS issues, check out curl manual and
find some options.
It will fail using the `config-default.yaml`, and report errors "failed to
fetch ssl config: failed to find SNI: please check if the client requests via
IP or uses an outdated protocol".
But I have found the solution by reading the source code，and change the
config.yaml-apisix-ssl-fallback_sni, it can set the default SNI when the client
doesn't send SNI during handshake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] wilson-1024 commented on issue #5244: Is it possible to read environment variables from yaml configuration files?
wilson-1024 commented on issue #5244: URL: https://github.com/apache/apisix/issues/5244#issuecomment-1055296983 I want to try to implement this function, can it be assigned to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #6455: feat: support post_logout_redirect_uri config in openid-connect plugin
starsz commented on a change in pull request #6455:
URL: https://github.com/apache/apisix/pull/6455#discussion_r816672530
##
File path: t/plugin/openid-connect.t
##
@@ -1665,3 +1665,319 @@ GET /t
false
--- error_log
OIDC introspection failed: invalid jwt: invalid jwt string
+
+
+
+=== TEST 28: Modify route to match catch-all URI `/*` and add
post_logout_redirect_uri option.
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"openid-connect": {
+"discovery":
"http://127.0.0.1:8090/auth/realms/University/.well-known/openid-configuration";,
+"realm": "University",
+"client_id": "course_management",
+"client_secret":
"d1ec69e9-55d2-4109-a3ea-befa071579d5",
+"redirect_uri": "http://127.0.0.1:]] ..
ngx.var.server_port .. [[/authenticated",
+"ssl_verify": false,
+"timeout": 10,
+"introspection_endpoint_auth_method":
"client_secret_post",
+"introspection_endpoint":
"http://127.0.0.1:8090/auth/realms/University/protocol/openid-connect/token/introspect";,
+"set_access_token_header": true,
+"access_token_in_authorization_header": false,
+"set_id_token_header": true,
+"set_userinfo_header": true,
+"post_logout_redirect_uri":
"http://127.0.0.1:]] .. ngx.var.server_port .. [[/hello"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]],
+[[{
+"node": {
+"value": {
+"plugins": {
+"openid-connect": {
+"client_id": "course_management",
+"client_secret":
"d1ec69e9-55d2-4109-a3ea-befa071579d5",
+"discovery":
"http://127.0.0.1:8090/auth/realms/University/.well-known/openid-configuration";,
+"redirect_uri": "http://127.0.0.1:]] ..
ngx.var.server_port .. [[/authenticated",
+"ssl_verify": false,
+"timeout": 10,
+"realm": "University",
+"introspection_endpoint_auth_method":
"client_secret_post",
+"introspection_endpoint":
"http://127.0.0.1:8090/auth/realms/University/protocol/openid-connect/token/introspect";,
+"set_access_token_header": true,
+"access_token_in_authorization_header":
false,
+"set_id_token_header": true,
+"set_userinfo_header": true,
+"post_logout_redirect_uri":
"http://127.0.0.1:]] .. ngx.var.server_port .. [[/hello"
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+},
+"key": "/apisix/routes/1"
+},
+"action": "set"
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 29: Access route w/o bearer token and request logout to redirect to
post_logout_redirect_uri.
+--- config
+location /t {
+content_by_lua_block {
+local http = require "resty.http"
+local httpc = http.new()
+
+-- Invoke /uri endpoint w/o bearer token. Should receive redirect
to Keycloak authorization endpoint.
+local uri = "http://127.0.0.1:"; .. ngx.var.server_port .. "/uri"
+local res, err = httpc:request_uri(uri, {method = "GET"})
+
+
[GitHub] [apisix-website] hf400159 opened a new pull request #923: docs: edit title, del nacos introduction
hf400159 opened a new pull request #923: URL: https://github.com/apache/apisix-website/pull/923 Edit title, del nacos introduction and add Apache APISIX introduction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #923: docs: edit title, del nacos introduction
netlify[bot] commented on pull request #923: URL: https://github.com/apache/apisix-website/pull/923#issuecomment-1055316245 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 7e80457d1a44c5bfc9c2db2df15314474435b8c9 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621dff7ef66738000748b4cc](https://app.netlify.com/sites/apache-apisix/deploys/621dff7ef66738000748b4cc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #923: docs: edit title, del nacos introduction
netlify[bot] edited a comment on pull request #923: URL: https://github.com/apache/apisix-website/pull/923#issuecomment-1055316245 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 7e80457d1a44c5bfc9c2db2df15314474435b8c9 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621dff7ef66738000748b4cc](https://app.netlify.com/sites/apache-apisix/deploys/621dff7ef66738000748b4cc) 😎 Browse the preview: [https://deploy-preview-923--apache-apisix.netlify.app](https://deploy-preview-923--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] hf400159 commented on pull request #912: docs: edit title, del nacos introduction
hf400159 commented on pull request #912: URL: https://github.com/apache/apisix-website/pull/912#issuecomment-1055322900 Close this pull request, conflicts were solved in #923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] hf400159 closed pull request #912: docs: edit title, del nacos introduction
hf400159 closed pull request #912: URL: https://github.com/apache/apisix-website/pull/912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6474: request help: Some questions about proxy cache plugin, disk cache, cache_ttl and logs
tzssangglass commented on issue #6474: URL: https://github.com/apache/apisix/issues/6474#issuecomment-1055337847 > it seems that memory_handler.lua never be called. it's base on `cache_strategy` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on pull request #6214: fix(admin-token): fixed token is used by default
shuaijinchao commented on pull request #6214: URL: https://github.com/apache/apisix/pull/6214#issuecomment-1055342991 the problem has not been confirmed, and the PR is temporarily closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao closed pull request #6214: fix(admin-token): fixed token is used by default
shuaijinchao closed pull request #6214: URL: https://github.com/apache/apisix/pull/6214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #923: docs: edit title, del nacos introduction
netlify[bot] edited a comment on pull request #923: URL: https://github.com/apache/apisix-website/pull/923#issuecomment-1055316245 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: eac222fedecea396e7d9832be345282f604eed2a 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e07c66c4dfc0008242341](https://app.netlify.com/sites/apache-apisix/deploys/621e07c66c4dfc0008242341) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #923: docs: edit title, del nacos introduction
netlify[bot] edited a comment on pull request #923: URL: https://github.com/apache/apisix-website/pull/923#issuecomment-1055316245 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: eac222fedecea396e7d9832be345282f604eed2a 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e07c66c4dfc0008242341](https://app.netlify.com/sites/apache-apisix/deploys/621e07c66c4dfc0008242341) 😎 Browse the preview: [https://deploy-preview-923--apache-apisix.netlify.app](https://deploy-preview-923--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6442: docs: refactor how-to-build.md
tzssangglass commented on a change in pull request #6442: URL: https://github.com/apache/apisix/pull/6442#discussion_r816710615 ## File path: docs/zh/latest/how-to-build.md ## @@ -113,9 +113,22 @@ sudo yum install ./apisix/*.rpm make install ``` -- 4.1 `make deps` 安装 `lualdap` 失败, 错误信息如: `Could not find header file for LDAP` - - 解决方案: 通过 `luarocks config` 手动设置 `LDAP_DIR` 变量, 比如 `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/` + **注意**：如果使用 `make deps` 安装 `lualdap` 失败, 错误信息如： `Could not find header file for LDAP`，那么可以肯定这是一类关于安装依赖失败的问题。同理，遇到 `PCRE`、`openssl` 等依赖包安装失败问题，皆可以使用本方法解决问题。 + + 解决思路：根据 luarocks 支持添加自定义包到项目中的思想，使用第三方工具安装缺失的包，并将其地址添加到项目的配置文件中以识别。 Review comment: ```suggestion 解决思路：luarocks 支持自定义编译时依赖目录，使用第三方工具安装缺失的依赖，并将其文件路径添加到 luarocks 的变量表中。 ``` ## File path: docs/zh/latest/how-to-build.md ## @@ -113,9 +113,22 @@ sudo yum install ./apisix/*.rpm make install ``` -- 4.1 `make deps` 安装 `lualdap` 失败, 错误信息如: `Could not find header file for LDAP` - - 解决方案: 通过 `luarocks config` 手动设置 `LDAP_DIR` 变量, 比如 `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/` + **注意**：如果使用 `make deps` 安装 `lualdap` 失败, 错误信息如： `Could not find header file for LDAP`，那么可以肯定这是一类关于安装依赖失败的问题。同理，遇到 `PCRE`、`openssl` 等依赖包安装失败问题，皆可以使用本方法解决问题。 + + 解决思路：根据 luarocks 支持添加自定义包到项目中的思想，使用第三方工具安装缺失的包，并将其地址添加到项目的配置文件中以识别。 Review comment: what about add link? https://github.com/luarocks/luarocks/wiki/Config-file-format#variables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aiyiyi121 closed issue #6479: request help: Can I send HTTPS requests to apisix via IP
aiyiyi121 closed issue #6479: URL: https://github.com/apache/apisix/issues/6479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Chever-John commented on a change in pull request #6442: docs: refactor how-to-build.md
Chever-John commented on a change in pull request #6442: URL: https://github.com/apache/apisix/pull/6442#discussion_r816775845 ## File path: docs/zh/latest/how-to-build.md ## @@ -113,9 +113,22 @@ sudo yum install ./apisix/*.rpm make install ``` -- 4.1 `make deps` 安装 `lualdap` 失败, 错误信息如: `Could not find header file for LDAP` - - 解决方案: 通过 `luarocks config` 手动设置 `LDAP_DIR` 变量, 比如 `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/` + **注意**：如果使用 `make deps` 安装 `lualdap` 失败, 错误信息如： `Could not find header file for LDAP`，那么可以肯定这是一类关于安装依赖失败的问题。同理，遇到 `PCRE`、`openssl` 等依赖包安装失败问题，皆可以使用本方法解决问题。 + + 解决思路：根据 luarocks 支持添加自定义包到项目中的思想，使用第三方工具安装缺失的包，并将其地址添加到项目的配置文件中以识别。 Review comment: I think that's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #6410: request help: mTLS Between APISIX and Upstream
spacewander closed issue #6410: URL: https://github.com/apache/apisix/issues/6410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (beff2df -> aed26c8)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from beff2df build(deps): bump actions/setup-go from 2.2.0 to 3 (#6475) add aed26c8 feat: set proxy_ssl_trusted_certificate as ssl_trusted_certificate (#6468) No new revisions were added by this update. Summary of changes: apisix/cli/ngx_tpl.lua | 4 ++ t/cli/test_upstream_mtls.sh | 157 2 files changed, 161 insertions(+) create mode 100755 t/cli/test_upstream_mtls.sh
[GitHub] [apisix] spacewander merged pull request #6468: feat: set proxy_ssl_trusted_certificate as ssl_trusted_certificate
spacewander merged pull request #6468: URL: https://github.com/apache/apisix/pull/6468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #924: docs: add public-api plugin blog
netlify[bot] commented on pull request #924: URL: https://github.com/apache/apisix-website/pull/924#issuecomment-1055456183 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 9ef82769abed93c690383a13ff2925a33e4ecc4b 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e22fe427c2c000756527a](https://app.netlify.com/sites/apache-apisix/deploys/621e22fe427c2c000756527a) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] hf400159 opened a new pull request #924: docs: add public-api plugin blog
hf400159 opened a new pull request #924: URL: https://github.com/apache/apisix-website/pull/924 docs: add public-api plugin blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #924: docs: add public-api plugin blog
netlify[bot] edited a comment on pull request #924: URL: https://github.com/apache/apisix-website/pull/924#issuecomment-1055456183 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 9ef82769abed93c690383a13ff2925a33e4ecc4b 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e22fe427c2c000756527a](https://app.netlify.com/sites/apache-apisix/deploys/621e22fe427c2c000756527a) 😎 Browse the preview: [https://deploy-preview-924--apache-apisix.netlify.app](https://deploy-preview-924--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #924: docs: add public-api plugin blog
netlify[bot] edited a comment on pull request #924: URL: https://github.com/apache/apisix-website/pull/924#issuecomment-1055456183 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: b0d310cf538ad1c6835f22e55f8a7ea7d6090a4b 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e257bbc2e08000709c8e9](https://app.netlify.com/sites/apache-apisix/deploys/621e257bbc2e08000709c8e9) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #924: docs: add public-api plugin blog
netlify[bot] edited a comment on pull request #924: URL: https://github.com/apache/apisix-website/pull/924#issuecomment-1055456183 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: b0d310cf538ad1c6835f22e55f8a7ea7d6090a4b 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e257bbc2e08000709c8e9](https://app.netlify.com/sites/apache-apisix/deploys/621e257bbc2e08000709c8e9) 😎 Browse the preview: [https://deploy-preview-924--apache-apisix.netlify.app](https://deploy-preview-924--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #242: Add option to enable control_api for apisix gateway
tao12345666333 commented on issue #242: URL: https://github.com/apache/apisix-helm-chart/issues/242#issuecomment-1055469141 Thanks for your report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #924: docs: add public-api plugin blog
netlify[bot] edited a comment on pull request #924: URL: https://github.com/apache/apisix-website/pull/924#issuecomment-1055456183 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 3e3cce94c2b5d82a741a88ffce7db8f81933405f 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e26d4f1164f000877d479](https://app.netlify.com/sites/apache-apisix/deploys/621e26d4f1164f000877d479) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #924: docs: add public-api plugin blog
netlify[bot] edited a comment on pull request #924: URL: https://github.com/apache/apisix-website/pull/924#issuecomment-1055456183 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 3e3cce94c2b5d82a741a88ffce7db8f81933405f 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e26d4f1164f000877d479](https://app.netlify.com/sites/apache-apisix/deploys/621e26d4f1164f000877d479) 😎 Browse the preview: [https://deploy-preview-924--apache-apisix.netlify.app](https://deploy-preview-924--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: refactor(grpc-transcode): new way to handle pb file (#6467)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new a7bde90 refactor(grpc-transcode): new way to handle pb file (#6467)
a7bde90 is described below
commit a7bde90d9a492fe88f94f20ca0b405311299090d
Author: 罗泽轩
AuthorDate: Tue Mar 1 22:05:27 2022 +0800
refactor(grpc-transcode): new way to handle pb file (#6467)
---
apisix/plugins/grpc-transcode/proto.lua | 16 +---
rockspec/apisix-master-0.rockspec | 2 +-
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/apisix/plugins/grpc-transcode/proto.lua
b/apisix/plugins/grpc-transcode/proto.lua
index e997b55..c30c17e 100644
--- a/apisix/plugins/grpc-transcode/proto.lua
+++ b/apisix/plugins/grpc-transcode/proto.lua
@@ -77,20 +77,22 @@ local function compile_proto_bin(content)
return nil
end
+local files = pb.decode("google.protobuf.FileDescriptorSet", content).file
local index = {}
-for name, _, methods in pb.services() do
-local method_index = {}
-for _, m in ipairs(methods) do
-method_index[m.name] = m
+for _, f in ipairs(files) do
+for _, s in ipairs(f.service or {}) do
+local method_index = {}
+for _, m in ipairs(s.method) do
+method_index[m.name] = m
+end
+
+index[f.package .. '.' .. s.name] = method_index
end
--- remove the prefix '.'
-index[name:sub(2)] = method_index
end
local compiled = {}
compiled[proto_fake_file] = {}
compiled[proto_fake_file].index = index
-
return compiled
end
diff --git a/rockspec/apisix-master-0.rockspec
b/rockspec/apisix-master-0.rockspec
index ae12950..55f06b4 100644
--- a/rockspec/apisix-master-0.rockspec
+++ b/rockspec/apisix-master-0.rockspec
@@ -46,7 +46,7 @@ dependencies = {
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
"lua-resty-radixtree = 2.8.1",
-"api7-lua-protobuf = 0.1.0",
+"lua-protobuf = 0.3.4",
"lua-resty-openidc = 1.7.2-1",
"luafilesystem = 1.7.0-2",
"api7-lua-tinyyaml = 0.4.2",
[GitHub] [apisix] spacewander merged pull request #6467: refactor(grpc-transcode): new way to handle pb file
spacewander merged pull request #6467: URL: https://github.com/apache/apisix/pull/6467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #886: bug: ingress-controller always shows this log not found service, but the service is actually there
tao12345666333 commented on issue #886: URL: https://github.com/apache/apisix-ingress-controller/issues/886#issuecomment-1055482569 Could you please post the complete installation and reproduction steps? Your newly posted log indicates that you have enabled the Ingress LB status function, which requires you to check your Kubernetes environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #868: fix: check if stream_routes is disabled
tao12345666333 commented on pull request #868: URL: https://github.com/apache/apisix-ingress-controller/pull/868#issuecomment-1055510049 ping @gxthrj @tokers PTAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Gallardot commented on a change in pull request #6444: docs: fix forward-auth plugin doc
Gallardot commented on a change in pull request #6444:
URL: https://github.com/apache/apisix/pull/6444#discussion_r816842105
##
File path: docs/en/latest/plugins/forward-auth.md
##
@@ -117,32 +117,35 @@ We can perform the following three tests.
1. **request_headers** Send Authorization header from `client` to
`authorization` service
```shell
-$ curl http://127.0.0.1:9080/headers -H 'Authorization: 123'
-{
+curl http://127.0.0.1:9080/headers -H 'Authorization: 123' \
+-d '{
Review comment:
Good catch! I changed this to two text blocks. PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Gallardot commented on a change in pull request #6444: docs: fix forward-auth plugin doc
Gallardot commented on a change in pull request #6444:
URL: https://github.com/apache/apisix/pull/6444#discussion_r816842274
##
File path: docs/en/latest/plugins/forward-auth.md
##
@@ -117,32 +117,35 @@ We can perform the following three tests.
1. **request_headers** Send Authorization header from `client` to
`authorization` service
```shell
-$ curl http://127.0.0.1:9080/headers -H 'Authorization: 123'
-{
+curl http://127.0.0.1:9080/headers -H 'Authorization: 123' \
+-d '{
"headers": {
"Authorization": "123",
"Next": "More-headers"
}
-}
+}'
```
2. **upstream_headers** Send `authorization` service response header to the
`upstream`
```shell
-$ curl http://127.0.0.1:9080/headers -H 'Authorization: 321'
-{
+curl http://127.0.0.1:9080/headers -H 'Authorization: 321' \
+-d '{
Review comment:
good catch! I changed this to two text blocks. PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #6477: docs: zh/*.md some file first dir is "名字"
kwanhur commented on issue #6477: URL: https://github.com/apache/apisix/issues/6477#issuecomment-1055599988 `Description` maybe the better. When we fetch GNU tool's usage with `man`, `Description` is in common use. If ok, I can fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #897: docs: improve Community Section
netlify[bot] edited a comment on pull request #897: URL: https://github.com/apache/apisix-website/pull/897#issuecomment-104755 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: f6844571315708e0085759a410ac8f1f2adbe127 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e44f9fff2bb0007fdc605](https://app.netlify.com/sites/apache-apisix/deploys/621e44f9fff2bb0007fdc605) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #6473: APISIX's V3 (2022) Roadmap
kwanhur commented on issue #6473: URL: https://github.com/apache/apisix/issues/6473#issuecomment-1055606966 2. backend will talk with Admin API, `apisix-adminctl` or `apisixctl` will come into the plan together? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #897: docs: improve Community Section
netlify[bot] edited a comment on pull request #897: URL: https://github.com/apache/apisix-website/pull/897#issuecomment-104755 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: f6844571315708e0085759a410ac8f1f2adbe127 🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/621e44f9fff2bb0007fdc605](https://app.netlify.com/sites/apache-apisix/deploys/621e44f9fff2bb0007fdc605) 😎 Browse the preview: [https://deploy-preview-897--apache-apisix.netlify.app](https://deploy-preview-897--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 opened a new issue #2353: APISIX Dashboard V3 Roadmap
bzp2010 opened a new issue #2353: URL: https://github.com/apache/apisix-dashboard/issues/2353 ## Background Apache APISIX has released a roadmap for version 3.0, and as a counterpart to this, I am also releasing the roadmap for the dashboard here. In the new dashboard, we will implement better compatibility with APISIX, simpler deployment methods, and will also improve issues that existed in the previous version. ### Objectives Easier to use, better experience. ### Past problems There are many problems for user. - Unreasonable operating logic - Some features are not supported (just like plugin_metadata) - Less reliable storage capabilities (although being a stateless application can be solved by rebooting) - Differences behavior from APISIX Admin API And some for developer. - Difficult to develop and also to migrate between versions - Unable to support new features in older versions (it corresponds one-to-one with APISIX version) - Overly complex code architecture (data storage layer, multi-layer middleware, duplicate implementations of handlers) - Poor support for custom plugins for APISIX (need to update the schema file manually, it's really hard) ### From now We want to improve the problem in the new version, or at least part of them. We will improve one of the root causes of the current complexity, the "Manager API", which makes some things complicated. When I learned that APISIX V3 will improve the Admin API, I learned that we can use it directly in Dashboard, in a proxy-based way. This is the most important change we have made in this version. At the same time, we may also make changes to the project versioning system to better help users interface with APISIX (TBD). ## Roadmap Here are the features about what we are going to implement in this version and the features to be discussed. Only a rough description is provided here, no details about the implementation are available. | Content| Category | Priority | Description | Status | | --- | :--: | :---: | --- | :--: | | Manager API simplify - remove complex storage layer implementations - reduce overall complexity | core | High | | | | Frontend operation experience - goal-oriented resource control - more image of consumer and service control - support full function UI configuration | core | High | | | | Multi-version support - support for APISIX migration on upgrade | core | High | Maybe use data-driven form generation UI | | | Data Storage - store dashboard only data | core | High | Store content such as settings, authentication, etc. | | | Custom Plugin Support - support add plugin on UI - support generating forms for user-defined plugins | core | Middle || | | Scalable Architecture Design - API specification for secondary development | extension dev | Middle | Provide interface to support identity authentication, local data storage of replaceable design | | | OpenAPI Import and Export Support | extension | Middle | | | | Plugin Orchestration - Graphical design plugin flow | extension | Low | | | | **The following is note, no plan for now** | | External authentication / permissions | extension | None | | | | Operation logging / audit | extension | None | | | | Multi-Cluster Support - supports configuration of multiple Admin API endpoints + token | extension | None | | | | Data Rollback - record old version data and support setting back | extension | None | | | ## Other If you have any suggestions or questions about this, you can communicate them in a discussion thread or mailing list that will be started later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 opened a new issue #2354: APISIX Dashboard V3 Discuss
bzp2010 opened a new issue #2354: URL: https://github.com/apache/apisix-dashboard/issues/2354 Here is the discussion thread for APISIX Dashboard V3 version, you can discuss it by replying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #2353: APISIX Dashboard V3 Roadmap
bzp2010 commented on issue #2353: URL: https://github.com/apache/apisix-dashboard/issues/2353#issuecomment-1055700869 Discuss thread: [https://github.com/apache/apisix-dashboard/issues/2354](https://github.com/apache/apisix-dashboard/issues/2354) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #888: fix json unmarshal error when list plguins
lingsamuel commented on pull request #888: URL: https://github.com/apache/apisix-ingress-controller/pull/888#issuecomment-1056018001 We need a mechanism to ensure that the APISIX interface we are using is not outdated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on issue #6477: docs: zh/*.md some file first dir is "名字"
liangliang4ward commented on issue #6477: URL: https://github.com/apache/apisix/issues/6477#issuecomment-1056021056 1. Maybe we can remove inner dir 2. Unified directory name，include zh/*.md & en/*.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: fix json unmarshal error when list plguins (#888)
This is an automated email from the ASF dual-hosted git repository.
zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new cc9b6be fix json unmarshal error when list plguins (#888)
cc9b6be is described below
commit cc9b6be606b4d41267064c45e7ef1e9f5a6d8e47
Author: cmssczy
AuthorDate: Wed Mar 2 09:01:39 2022 +0800
fix json unmarshal error when list plguins (#888)
---
pkg/apisix/cluster.go | 9 +++--
pkg/apisix/plugin_test.go | 10 +-
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/pkg/apisix/cluster.go b/pkg/apisix/cluster.go
index 4a5dbd7..8b7a938 100644
--- a/pkg/apisix/cluster.go
+++ b/pkg/apisix/cluster.go
@@ -750,10 +750,15 @@ func (c *cluster) getList(ctx context.Context, url,
resource string) ([]string,
return nil, err
}
- var listResponse []string
+ var listResponse map[string]interface{}
dec := json.NewDecoder(resp.Body)
if err := dec.Decode(&listResponse); err != nil {
return nil, err
}
- return listResponse, nil
+ res := make([]string, 0, len(listResponse))
+
+ for name := range listResponse {
+ res = append(res, name)
+ }
+ return res, nil
}
diff --git a/pkg/apisix/plugin_test.go b/pkg/apisix/plugin_test.go
index dd64201..2d5c15a 100644
--- a/pkg/apisix/plugin_test.go
+++ b/pkg/apisix/plugin_test.go
@@ -19,6 +19,7 @@ import (
"encoding/json"
"net/http"
"net/url"
+ "sort"
"strings"
"testing"
@@ -46,8 +47,13 @@ func (srv *fakeAPISIXPluginSrv) ServeHTTP(w
http.ResponseWriter, r *http.Request
return
}
+ fakePluginsResp := make(map[string]interface{}, len(srv.plugins))
+ for _, fp := range srv.plugins {
+ fakePluginsResp[fp] = struct{}{}
+ }
+
if r.Method == http.MethodGet {
- data, _ := json.Marshal(srv.plugins)
+ data, _ := json.Marshal(fakePluginsResp)
_, _ = w.Write(data)
w.WriteHeader(http.StatusOK)
return
@@ -101,6 +107,8 @@ func TestPluginClient(t *testing.T) {
objs, err := cli.List(context.Background())
assert.Nil(t, err)
assert.Len(t, objs, len(fakePluginNames))
+ sort.Strings(fakePluginNames)
+ sort.Strings(objs)
for i := range fakePluginNames {
assert.Equal(t, fakePluginNames[i], objs[i])
}
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #888: fix json unmarshal error when list plguins
tao12345666333 commented on pull request #888: URL: https://github.com/apache/apisix-ingress-controller/pull/888#issuecomment-1056024988 > We need a mechanism to ensure that the APISIX interface we are using is not outdated. yep. we may need to convert directly from the upstream schema. now let's move forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #888: fix json unmarshal error when list plguins
tao12345666333 merged pull request #888: URL: https://github.com/apache/apisix-ingress-controller/pull/888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #883: bug: failed to list plugins' names
tao12345666333 closed issue #883: URL: https://github.com/apache/apisix-ingress-controller/issues/883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #890: docs: fix #887
tao12345666333 merged pull request #890: URL: https://github.com/apache/apisix-ingress-controller/pull/890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #887: request help: "error retrieving resource lock" on APISIX Ingress Controller the Hard Way
tao12345666333 closed issue #887: URL: https://github.com/apache/apisix-ingress-controller/issues/887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6477: docs: zh/*.md some file first dir is "名字"
spacewander commented on issue #6477: URL: https://github.com/apache/apisix/issues/6477#issuecomment-1056026362 > `Description` maybe the better. > > When we fetch GNU tool's usage with `man`, `Description` is in common use. > > If ok, I can fix them. I prefer to have a full discussion before rushing to a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6477: docs: zh/*.md some file first dir is "名字"
spacewander commented on issue #6477: URL: https://github.com/apache/apisix/issues/6477#issuecomment-1056027990 CC @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: docs: fix #887 (#890)
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 8d25525 docs: fix #887 (#890) 8d25525 is described below commit 8d255252a206311bde756eb21424c7b6743d6187 Author: FesonX AuthorDate: Wed Mar 2 09:02:58 2022 +0800 docs: fix #887 (#890) --- docs/en/latest/practices/the-hard-way.md | 204 --- 1 file changed, 105 insertions(+), 99 deletions(-) diff --git a/docs/en/latest/practices/the-hard-way.md b/docs/en/latest/practices/the-hard-way.md index ddb538e..1acc477 100644 --- a/docs/en/latest/practices/the-hard-way.md +++ b/docs/en/latest/practices/the-hard-way.md @@ -158,104 +158,111 @@ Create a config file for our APISIX. We are going to deploy APISIX version 2.5. Note that the APISIX ingress controller needs to communicate with the APISIX admin API, so we set `apisix.allow_admin` to `0.0.0.0/0` for test. ```yaml -apisix: - node_listen: 9080 # APISIX listening port - enable_heartbeat: true - enable_admin: true - enable_admin_cors: true - enable_debug: false - enable_dev_mode: false # Sets nginx worker_processes to 1 if set to true - enable_reuseport: true # Enable nginx SO_REUSEPORT switch if set to true. - enable_ipv6: true - config_center: etcd # etcd: use etcd to store the config value - - allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow -- 0.0.0.0/0 - port_admin: 9180 - - # Default token when use API to call for Admin API. - # *NOTE*: Highly recommended to modify this value to protect APISIX's Admin API. - # Disabling this configuration item means that the Admin API does not - # require any authentication. - admin_key: -# admin: can everything for configuration data -- name: "admin" - key: edd1c9f034335f136f87ad84b625c8f1 - role: admin -# viewer: only can view configuration data -- name: "viewer" - key: 4054f7cf07e344346cd3f287985e76a2 - role: viewer - # dns_resolver: - # - 127.0.0.1 - dns_resolver_valid: 30 - resolver_timeout: 5 - -nginx_config: # config for render the template to genarate nginx.conf - error_log: "/dev/stderr" - error_log_level: "warn" # warn,error - worker_rlimit_nofile: 20480 # the number of files a worker process can open, should be larger than worker_connections - event: -worker_connections: 10620 - http: -access_log: "/dev/stdout" -keepalive_timeout: 60s # timeout during which a keep-alive client connection will stay open on the server side. -client_header_timeout: 60s # timeout for reading client request header, then 408 (Request Time-out) error is returned to the client -client_body_timeout: 60s # timeout for reading client request body, then 408 (Request Time-out) error is returned to the client -send_timeout: 10s # timeout for transmitting a response to the client.then the connection is closed -underscores_in_headers: "on" # default enables the use of underscores in client request header fields -real_ip_header: "X-Real-IP"# http://nginx.org/en/docs/http/ngx_http_realip_module.html#real_ip_header -real_ip_from: # http://nginx.org/en/docs/http/ngx_http_realip_module.html#set_real_ip_from - - 127.0.0.1 - - 'unix:' - -etcd: - host: -- "http://etcd-headless.apisix.svc.cluster.local:2379"; - prefix: "/apisix" # apisix configurations prefix - timeout: 30 # seconds -plugins: # plugin list - - api-breaker - - authz-keycloak - - basic-auth - - batch-requests - - consumer-restriction - - cors - - echo - - fault-injection - - grpc-transcode - - hmac-auth - - http-logger - - ip-restriction - - jwt-auth - - kafka-logger - - key-auth - - limit-conn - - limit-count - - limit-req - - node-status - - openid-connect - - prometheus - - proxy-cache - - proxy-mirror - - proxy-rewrite - - redirect - - referer-restriction - - request-id - - request-validation - - response-rewrite - - serverless-post-function - - serverless-pre-function - - sls-logger - - syslog - - tcp-logger - - udp-logger - - uri-blocker - - wolf-rbac - - zipkin - - traffic-split -stream_plugins: - - mqtt-proxy +apiVersion: v1 +kind: ConfigMap +metadata: + name: apisix-conf + namespace: apisix +data: + config.yaml: |- +apisix: + node_listen: 9080 # APISIX listening port + enable_heartbeat: true + enable_admin: true + enable_admin_cors: true + enable_debug: false + enable_dev_mode: false # Sets nginx worker_processes to 1 if set to true + enable_reuseport: true # Enable nginx SO_REUSEPORT switch if set to true. + enable_ipv6
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #868: fix: check if stream_routes is disabled
tokers commented on a change in pull request #868:
URL:
https://github.com/apache/apisix-ingress-controller/pull/868#discussion_r817268219
##
File path: test/e2e/ingress/sanity.go
##
@@ -186,3 +186,49 @@ var _ = ginkgo.Describe("leader election", func() {
}
})
})
+
+var _ = ginkgo.Describe("stream_routes disabled", func() {
+ opts := &scaffold.Options{
+ Name: "default",
+ Kubeconfig:scaffold.GetKubeconfig(),
+ APISIXConfigPath: "testdata/apisix-stream-disabled.yaml",
+ IngressAPISIXReplicas: 1,
+ HTTPBinServicePort:80,
+ APISIXRouteVersion:"apisix.apache.org/v2beta3",
+ }
+ s := scaffold.NewScaffold(opts)
+ ginkgo.It("/ip should return your ip", func() {
Review comment:
What's the correlation between this case and "stream route disabled"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6460: request help: in authz-keycloak plugin is it possible to customize the "access denied" message?
spacewander commented on issue #6460: URL: https://github.com/apache/apisix/issues/6460#issuecomment-1056031443 Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6426: feat: add `rewrite:RespHeaders` and modify the upstream response headers via `request` implementation
spacewander commented on a change in pull request #6426:
URL: https://github.com/apache/apisix/pull/6426#discussion_r817270826
##
File path: apisix/plugins/ext-plugin/init.lua
##
@@ -611,6 +611,29 @@ local rpc_handlers = {
end
end
+local len = rewrite:RespHeadersLength()
+local exclude_resp_header = {
Review comment:
Let's move the table in the module level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #913: feat: generate contribute page needed static data
bzp2010 commented on a change in pull request #913:
URL: https://github.com/apache/apisix-website/pull/913#discussion_r817271598
##
File path: scripts/generate-repos-info.js
##
@@ -0,0 +1,71 @@
+const fs = require("fs");
+const axios = require("axios");
+const listr = require("listr")
+
+axios.defaults.timeout = 5000;
+
+const axiosConfig = {
+ headers: {
+"content-type": "application/json",
+Accept: "application/vnd.github.v3+json"
+ },
+}
+
+const repoList = require("../website/config/docs").map(v => v.githubRepo)
+const res = {}
+
+const tasks = new listr([
+ {
+title: "Fetch repos' info and good first issues",
+task: ()=> new listr(repoList.map((repo)=>{
+ return {
+title: `Fetch ${repo}`,
+task: ()=>new listr([
Review comment:
Formatting code required.
##
File path: website/repos-info.json
##
@@ -0,0 +1 @@
+{"apache/apisix":{"info":{"description":"The Cloud-Native API
Gateway","Star":8480,"Watch":281,"Fork":1558},"issues":[{"comments":5,"number":6460,"title":"request
help: in authz-keycloak plugin is it possible to customize the \"access
denied\"
message?","htmlUrl":"https://github.com/apache/apisix/issues/6460"},{"comments":5,"number":6410,"title":"request
help: mTLS Between APISIX and
Upstream","htmlUrl":"https://github.com/apache/apisix/issues/6410"},{"comments":2,"number":6406,"title":"docs:
add datadog plugin document in
Chinese","htmlUrl":"https://github.com/apache/apisix/issues/6406"},{"comments":0,"number":6366,"title":"feat:
As a User, I want to have the port in the Host header when `pass_host = node`
and the port is not
standard","htmlUrl":"https://github.com/apache/apisix/issues/6366"},{"comments":8,"number":6344,"title":"request
help: forward-auth plugin cann't support request
body","htmlUrl":"https://github.com/apache/apisix/issues/6344"},{"comments":3,"number":6332,"title
":"docs: need to update
https://hub.docker.com/r/apache/apisix","htmlUrl":"https://github.com/apache/apisix/issues/6332"},{"comments":13,"number":6197,"title":"request
help: How to current limit both in minutes and day by using plugin
limit-count","htmlUrl":"https://github.com/apache/apisix/issues/6197"},{"comments":4,"number":6118,"title":"docs:
No docs for
Vault","htmlUrl":"https://github.com/apache/apisix/issues/6118"},{"comments":13,"number":5966,"title":"doc:
benchmark results is not so good,what is the
problem,help","htmlUrl":"https://github.com/apache/apisix/issues/5966"},{"comments":3,"number":5915,"title":"request
help: logger plugins supports limit size of request/response
body","htmlUrl":"https://github.com/apache/apisix/issues/5915"},{"comments":3,"number":5710,"title":"request
help: Can the jwt plugin support custom authentication parameter
names?","htmlUrl":"https://github.com/apache/apisix/issues/5710"},{"comments":7,"number":5451,"title":"request
help: Does \brespo
nse-rewrite plugin support partial or regular
substitution","htmlUrl":"https://github.com/apache/apisix/issues/5451"},{"comments":4,"number":5305,"title":"request
help: APISIX Proxy-mirror plugin support custom
path","htmlUrl":"https://github.com/apache/apisix/issues/5305"},{"comments":3,"number":5244,"title":"Is
it possible to read environment variables from yaml configuration
files?","htmlUrl":"https://github.com/apache/apisix/issues/5244"},{"comments":9,"number":5165,"title":"bug:
plugin wolf-rbac /apisix/plugin/wolf-rbac/login resturn header is text/plain
, cors
error","htmlUrl":"https://github.com/apache/apisix/issues/5165"},{"comments":11,"number":4933,"title":"docs:
limit-conn plugin in stream
proxy","htmlUrl":"https://github.com/apache/apisix/issues/4933"},{"comments":9,"number":3931,"title":"redirect
plugins add curl test for
`http_to_https`","htmlUrl":"https://github.com/apache/apisix/issues/3931"},{"comments":11,"number":2848,"title":"request
help: High cpu & network t
raffic triggered when batch processing router rules with large number of
rules","htmlUrl":"https://github.com/apache/apisix/issues/2848"}]},"apache/apisix-dashboard":{"info":{"description":"Dashboard
for Apache
APISIX","Star":561,"Watch":41,"Fork":296},"issues":[{"comments":1,"number":2197,"title":"Proposal:
Migrate old backend e2e
tests","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/2197"},{"comments":7,"number":2189,"title":"support
protobuf on
Web","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/2189"},{"comments":9,"number":2148,"title":"Proposal:
support Plugin Metadata
API","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/2148"},{"comments":2,"number":2107,"title":"Proposal:
goreleaser as release automation
tool","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/2107"},{"comments":7,"number":2095,"title":"Feature
request: support appending query string in redirect
plugin","htmlUrl":"https://github.com/apache/apisix-dashboard/i
ssues/2095"},{"comments":6,"number":1991,
[GitHub] [apisix-website] SkyeYoung commented on a change in pull request #913: feat: generate contribute page needed static data
SkyeYoung commented on a change in pull request #913:
URL: https://github.com/apache/apisix-website/pull/913#discussion_r817273625
##
File path: scripts/generate-repos-info.js
##
@@ -0,0 +1,71 @@
+const fs = require("fs");
+const axios = require("axios");
+const listr = require("listr")
+
+axios.defaults.timeout = 5000;
+
+const axiosConfig = {
+ headers: {
+"content-type": "application/json",
+Accept: "application/vnd.github.v3+json"
+ },
+}
+
+const repoList = require("../website/config/docs").map(v => v.githubRepo)
+const res = {}
+
+const tasks = new listr([
+ {
+title: "Fetch repos' info and good first issues",
+task: ()=> new listr(repoList.map((repo)=>{
+ return {
+title: `Fetch ${repo}`,
+task: ()=>new listr([
Review comment:
Sorry, do we have any lint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #913: feat: generate contribute page needed static data
bzp2010 commented on a change in pull request #913:
URL: https://github.com/apache/apisix-website/pull/913#discussion_r817272899
##
File path: scripts/generate-repos-info.js
##
@@ -0,0 +1,71 @@
+const fs = require("fs");
+const axios = require("axios");
+const listr = require("listr")
+
+axios.defaults.timeout = 5000;
+
+const axiosConfig = {
+ headers: {
+"content-type": "application/json",
+Accept: "application/vnd.github.v3+json"
+ },
+}
+
+const repoList = require("../website/config/docs").map(v => v.githubRepo)
+const res = {}
+
+const tasks = new listr([
+ {
+title: "Fetch repos' info and good first issues",
+task: ()=> new listr(repoList.map((repo)=>{
+ return {
+title: `Fetch ${repo}`,
+task: ()=>new listr([
+ {
+title: `${repo}'s info`,
+task: () => axios.get(`https://api.github.com/repos/${repo}`,
axiosConfig)
Review comment:
We should consider the case of a failed data pull, at which point we
might be to interrupt the CI execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on a change in pull request #913: feat: generate contribute page needed static data
SkyeYoung commented on a change in pull request #913:
URL: https://github.com/apache/apisix-website/pull/913#discussion_r817275273
##
File path: website/repos-info.json
##
@@ -0,0 +1 @@
+{"apache/apisix":{"info":{"description":"The Cloud-Native API
Gateway","Star":8480,"Watch":281,"Fork":1558},"issues":[{"comments":5,"number":6460,"title":"request
help: in authz-keycloak plugin is it possible to customize the \"access
denied\"
message?","htmlUrl":"https://github.com/apache/apisix/issues/6460"},{"comments":5,"number":6410,"title":"request
help: mTLS Between APISIX and
Upstream","htmlUrl":"https://github.com/apache/apisix/issues/6410"},{"comments":2,"number":6406,"title":"docs:
add datadog plugin document in
Chinese","htmlUrl":"https://github.com/apache/apisix/issues/6406"},{"comments":0,"number":6366,"title":"feat:
As a User, I want to have the port in the Host header when `pass_host = node`
and the port is not
standard","htmlUrl":"https://github.com/apache/apisix/issues/6366"},{"comments":8,"number":6344,"title":"request
help: forward-auth plugin cann't support request
body","htmlUrl":"https://github.com/apache/apisix/issues/6344"},{"comments":3,"number":6332,"title
":"docs: need to update
https://hub.docker.com/r/apache/apisix","htmlUrl":"https://github.com/apache/apisix/issues/6332"},{"comments":13,"number":6197,"title":"request
help: How to current limit both in minutes and day by using plugin
limit-count","htmlUrl":"https://github.com/apache/apisix/issues/6197"},{"comments":4,"number":6118,"title":"docs:
No docs for
Vault","htmlUrl":"https://github.com/apache/apisix/issues/6118"},{"comments":13,"number":5966,"title":"doc:
benchmark results is not so good,what is the
problem,help","htmlUrl":"https://github.com/apache/apisix/issues/5966"},{"comments":3,"number":5915,"title":"request
help: logger plugins supports limit size of request/response
body","htmlUrl":"https://github.com/apache/apisix/issues/5915"},{"comments":3,"number":5710,"title":"request
help: Can the jwt plugin support custom authentication parameter
names?","htmlUrl":"https://github.com/apache/apisix/issues/5710"},{"comments":7,"number":5451,"title":"request
help: Does \brespo
nse-rewrite plugin support partial or regular
substitution","htmlUrl":"https://github.com/apache/apisix/issues/5451"},{"comments":4,"number":5305,"title":"request
help: APISIX Proxy-mirror plugin support custom
path","htmlUrl":"https://github.com/apache/apisix/issues/5305"},{"comments":3,"number":5244,"title":"Is
it possible to read environment variables from yaml configuration
files?","htmlUrl":"https://github.com/apache/apisix/issues/5244"},{"comments":9,"number":5165,"title":"bug:
plugin wolf-rbac /apisix/plugin/wolf-rbac/login resturn header is text/plain
, cors
error","htmlUrl":"https://github.com/apache/apisix/issues/5165"},{"comments":11,"number":4933,"title":"docs:
limit-conn plugin in stream
proxy","htmlUrl":"https://github.com/apache/apisix/issues/4933"},{"comments":9,"number":3931,"title":"redirect
plugins add curl test for
`http_to_https`","htmlUrl":"https://github.com/apache/apisix/issues/3931"},{"comments":11,"number":2848,"title":"request
help: High cpu & network t
raffic triggered when batch processing router rules with large number of
rules","htmlUrl":"https://github.com/apache/apisix/issues/2848"}]},"apache/apisix-dashboard":{"info":{"description":"Dashboard
for Apache
APISIX","Star":561,"Watch":41,"Fork":296},"issues":[{"comments":1,"number":2197,"title":"Proposal:
Migrate old backend e2e
tests","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/2197"},{"comments":7,"number":2189,"title":"support
protobuf on
Web","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/2189"},{"comments":9,"number":2148,"title":"Proposal:
support Plugin Metadata
API","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/2148"},{"comments":2,"number":2107,"title":"Proposal:
goreleaser as release automation
tool","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/2107"},{"comments":7,"number":2095,"title":"Feature
request: support appending query string in redirect
plugin","htmlUrl":"https://github.com/apache/apisix-dashboard/i
ssues/2095"},{"comments":6,"number":1991,"title":"在预览插件的时候，建议只显示启动的插件而不是显示所有的插件","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/1991"},{"comments":2,"number":1953,"title":"At
least storage the PATH of the grafana in the etcd
","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/1953"},{"comments":29,"number":1944,"title":"When
Dashboard and APISIX version do not match, make the prompt information
clearer","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/1944"},{"comments":3,"number":1777,"title":"build
UI for serverless-xx
plugin","htmlUrl":"https://github.com/apache/apisix-dashboard/issues/1777"},{"comments":7,"number":1642,"title":"Whether
to consider adding scheme configuration items in th
[GitHub] [apisix] spacewander commented on a change in pull request #6428: ci: add shellcheck linter
spacewander commented on a change in pull request #6428:
URL: https://github.com/apache/apisix/pull/6428#discussion_r817275345
##
File path: .github/workflows/code-lint.yml
##
@@ -28,3 +28,20 @@ jobs:
. ./ci/common.sh
export_or_prefix
make lint
+
+ sc-lint:
+runs-on: ubuntu-latest
+timeout-minutes: 5
+steps:
+ - name: Checkout code
+uses: actions/checkout@v2.4.0
+with:
+ submodules: true
+
+ - name: Shellcheck code
+run: |
+ scversion="latest"
+ wget -O-
"https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz";
| tar -xJv
+ cp -av "shellcheck-${scversion}/shellcheck" /usr/local/bin/
+ shellcheck --version
+ shellcheck **/*.sh
Review comment:
> shellcheck **/*.sh
? It is still linting all the shell files in this repo, including the one
from submodule...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] stray-dog opened a new issue #6481: request help: {"error_msg":"unknown plugin [ext-plugin-pre-req]"}
stray-dog opened a new issue #6481:
URL: https://github.com/apache/apisix/issues/6481
### Issue description
https://apisix.apache.org/zh/docs/apisix/plugins/ext-plugin-pre-req
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri":"/get",
"plugins":{
"ext-plugin-pre-req":{
"conf":[
{
"name":"myPluginName",
"value":"{\"key1\":\"feature\"}"
}
]
}
},
"upstream":{
"nodes":{
"httpbin.org:80":1
},
"type":"roundrobin"
}
}'
### Environment
- apisix version : 2.12.1
- OS (cmd: ``): Linux
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on a change in pull request #913: feat: generate contribute page needed static data
SkyeYoung commented on a change in pull request #913:
URL: https://github.com/apache/apisix-website/pull/913#discussion_r817276881
##
File path: scripts/generate-repos-info.js
##
@@ -0,0 +1,71 @@
+const fs = require("fs");
+const axios = require("axios");
+const listr = require("listr")
+
+axios.defaults.timeout = 5000;
+
+const axiosConfig = {
+ headers: {
+"content-type": "application/json",
+Accept: "application/vnd.github.v3+json"
+ },
+}
+
+const repoList = require("../website/config/docs").map(v => v.githubRepo)
+const res = {}
+
+const tasks = new listr([
+ {
+title: "Fetch repos' info and good first issues",
+task: ()=> new listr(repoList.map((repo)=>{
+ return {
+title: `Fetch ${repo}`,
+task: ()=>new listr([
+ {
+title: `${repo}'s info`,
+task: () => axios.get(`https://api.github.com/repos/${repo}`,
axiosConfig)
Review comment:
I use this part.
```js
tasks.run()
.then(()=> {
console.log("[Finish] Generate repos' info and good first issues
finished")
})
.catch((err)=>{
console.error(err)
process.exit(1)
})
```
Is it not enough? I'm not familiar with this part. I'll check other files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
