[GitHub] [apisix] spacewander commented on pull request #7643: feat: add elasticsearch-logger
spacewander commented on PR #7643: URL: https://github.com/apache/apisix/pull/7643#issuecomment-1216179952 Please make the doc lint pass, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #7482: Remove deprecated configuration in the V3
spacewander closed issue #7482: Remove deprecated configuration in the V3 URL: https://github.com/apache/apisix/issues/7482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7677: change: remove deprecated lua_shared_dicts
spacewander merged PR #7677: URL: https://github.com/apache/apisix/pull/7677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7686: chore: remove useless judge in pubsub init
spacewander merged PR #7686: URL: https://github.com/apache/apisix/pull/7686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7685: test: fix test case with not escaped bracket
spacewander merged PR #7685: URL: https://github.com/apache/apisix/pull/7685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] akalittle commented on issue #7693: bug: helm apisix template generated leads to an etcd error
akalittle commented on issue #7693: URL: https://github.com/apache/apisix/issues/7693#issuecomment-1216169202 Every time etcd0 & etcd2 are normal. https://user-images.githubusercontent.com/38489160/184805253-aa59ac31-cf9c-4289-92e5-e6bcdcfeee88.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2590: chore: Move from yarn to pnpm
FangSen9000 commented on PR #2590: URL: https://github.com/apache/apisix-dashboard/pull/2590#issuecomment-1216168806  @SkyeYoung Have you ever encountered this situation? The local test case is running well, and no exception is found by the naked eye. However, the test case is not running, and it is not a failure. If it fails, he should prompt several assertions. It should not be started, but it seems that it is not different from other test cases. Cypress is useless. It took half a day to find out the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kingluo commented on issue #7689: help request: Setting up OIDC plugin with proxy-rewrite
kingluo commented on issue #7689: URL: https://github.com/apache/apisix/issues/7689#issuecomment-1216164046 @desidia26 When `bearer_only` is false (by default), the `redirect_uri` must be provided. Otherwise, the plugin has no way to recognize the "code" authorization response from the OP/IdP. And to be simple and no typo, the `rediect_uri` is normally a path without `scheme://host:port` part, e.g. `/thing/_callback`. Note that you should not access `redirect_uri` directly (otherwise it would warn no session found), because it's only for OP/IdP to callback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] akalittle opened a new issue, #7693: bug: helm apisix template generated leads to an etcd error
akalittle opened a new issue, #7693:
URL: https://github.com/apache/apisix/issues/7693
### Current Behavior
helm template --release-name apisix-istio -f ./apisix/values.yaml
apisix/apisix --output-dir ./apisix-deploy
```yaml
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
global:
imagePullSecrets: []
apisix:
# Enable or disable Apache APISIX itself
# Set it to false and ingress-controller.enabled=true will deploy only
ingress-controller
enabled: true
# Enable nginx IPv6 resolver
enableIPv6: true
# Use Pod metadata.uid as the APISIX id.
setIDFromPodUID: false
customLuaSharedDicts: []
# - name: foo
# size: 10k
# - name: bar
# size: 1m
luaModuleHook:
enabled: false
# extend lua_package_path to load third party code
luaPath: ""
# the hook module which will be used to inject third party code into
APISIX
# use the lua require style like: "module.say_hello"
hookPoint: ""
# configmap that stores the codes
configMapRef:
name: ""
# mounts decides how to mount the codes to the container.
mounts:
- key: ""
path: ""
enableCustomizedConfig: false
customizedConfig: {}
image:
repository: apache/apisix
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: 2.15.0-alpine
# Use a `DaemonSet` or `Deployment`
kind: Deployment
# kind is DaemonSet,replicaCount not become effective
replicaCount: 1
podAnnotations: {}
podSecurityContext: {}
# fsGroup: 2000
securityContext: {}
# capabilities:
# drop:
# - ALL
# readOnlyRootFilesystem: true
# runAsNonRoot: true
# runAsUser: 1000
# See https://kubernetes.io/docs/tasks/run-application/configure-pdb/ for
more details
podDisruptionBudget:
enabled: false
minAvailable: 90%
maxUnavailable: 1
resources: {}
# We usually recommend not to specify default resources and to leave
this as a conscious
# choice for the user. This also increases chances charts run on
environments with little
# resources, such as Minikube. If you do want to specify resources,
uncomment the following
# lines, adjust them as necessary, and remove the curly braces after
'resources:'.
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi
nodeSelector: {}
tolerations: []
affinity: {}
# If true, it will sets the anti-affinity of the Pod.
podAntiAffinity:
enabled: false
# timezone is the timezone where apisix uses.
# For example: "UTC" or "Asia/Shanghai"
# This value will be set on apisix container's environment variable TZ.
# You may need to set the timezone to be consistent with your local time
zone,
# otherwise the apisix's logs may used to retrieve event maybe in wrong
timezone.
timezone: ""
# extraEnvVars An array to add extra env vars
# e.g:
# extraEnvVars:
# - name: FOO
# value: "bar"
# - name: FOO2
# valueFrom:
# secretKeyRef:
# name: SECRET_NAME
# key: KEY
extraEnvVars: []
nameOverride: ""
fullnameOverride: ""
gateway:
type: NodePort
# If you want to keep the client source IP, you can set this to Local.
# ref:
https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip
externalTrafficPolicy: Cluster
# type: LoadBalancer
# annotations:
# service.beta.kubernetes.io/aws-load-balancer-type: nlb
externalIPs: []
http:
enabled: true
servicePort: 80
containerPort: 9080
tls:
enabled: false
servicePort: 443
containerPort: 9443
existingCASecret: ""
certCAFilename: ""
http2:
enabled: true
stream: # L4 proxy (TCP/UDP)
enabled:
[GitHub] [apisix] akalittle commented on issue #7674: help request: opentelemetry error in lua script
akalittle commented on issue #7674: URL: https://github.com/apache/apisix/issues/7674#issuecomment-1216158802 I'm sure I just use system generated trace_id. In my yaml file, I just simply use like below, I didn't use any other attributes, you can also see in the json object. ```yaml - name: opentelemetry enable: true config: sampler: name: always_on ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass closed issue #7684: bug: After plugin is closed, there are still some requests to execute the plugin
tzssangglass closed issue #7684: bug: After plugin is closed, there are still some requests to execute the plugin URL: https://github.com/apache/apisix/issues/7684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #7684: bug: After plugin is closed, there are still some requests to execute the plugin
tzssangglass commented on issue #7684: URL: https://github.com/apache/apisix/issues/7684#issuecomment-1216151040 > 当我特意去复现时我不能做到百分百复现 Since this issue is related to your custom plugin, I'm going to turn this issue into a discussion. if the plugin in the official repository also has this issue, please open a separate issue to report it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #7684: bug: After plugin is closed, there are still some requests to execute the plugin
tzssangglass commented on issue #7684: URL: https://github.com/apache/apisix/issues/7684#issuecomment-1216150107 > 我通过调用apisix中的服务接口（插件配置在服务上）put方法修改服务中插件，进行关闭，是否存在某worker中内存没有及时清理造成的这种情况呢 The worker writes the updates to etcd, and other workers watch for etcd changes and update the data in memory. There is a delay in between, but if everything is working properly, the delay should be low enough to be negligible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1056: feat: add mqtt-proxy plugin in ApisixRoute (#966)
tao12345666333 commented on PR #1056: URL: https://github.com/apache/apisix-ingress-controller/pull/1056#issuecomment-1216145083 hi, there has one conflicting file, do you have time to resolve it? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1216: fix: log Secret name instead of all data
tao12345666333 commented on PR #1216: URL: https://github.com/apache/apisix-ingress-controller/pull/1216#issuecomment-1216144433 ping @lingsamuel for review, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1222: fix: nodes convert failed
tao12345666333 commented on code in PR #1222:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1222#discussion_r946334199
##
pkg/types/apisix/v1/types.go:
##
@@ -216,21 +217,55 @@ type UpstreamNodes []UpstreamNode
// and by default empty array will be encoded as '{}'.
// We have to maintain the compatibility.
func (n *UpstreamNodes) UnmarshalJSON(p []byte) error {
+ var data []UpstreamNode
if p[0] == '{' {
- if len(p) != 2 {
- return errors.New("unexpected non-empty object")
+ value := map[string]float64{}
+ if err := json.Unmarshal(p, ); err != nil {
+ return err
+ }
+ for k, v := range value {
+ node, err := mapKV2Node(k, v)
+ if err != nil {
+ return err
+ }
+ data = append(data, *node)
}
- *n = UpstreamNodes{}
+ *n = data
return nil
}
- var data []UpstreamNode
if err := json.Unmarshal(p, ); err != nil {
return err
}
*n = data
return nil
}
+func mapKV2Node(key string, val float64) (*UpstreamNode, error) {
+ hp := strings.Split(key, ":")
+ host := hp[0]
+ // according to APISIX upstream nodes policy, port is optional
+ port := "0"
Review Comment:
> is this here to be compatible with existing data change scenarios in etcd?
For example, ingress data is modified by dashboard, etc.
yes. ref: #712 #1218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] bzp2010 commented on a diff in pull request #1222: fix: nodes convert failed
bzp2010 commented on code in PR #1222:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1222#discussion_r946328504
##
pkg/types/apisix/v1/types.go:
##
@@ -216,21 +217,55 @@ type UpstreamNodes []UpstreamNode
// and by default empty array will be encoded as '{}'.
// We have to maintain the compatibility.
func (n *UpstreamNodes) UnmarshalJSON(p []byte) error {
+ var data []UpstreamNode
if p[0] == '{' {
- if len(p) != 2 {
- return errors.New("unexpected non-empty object")
+ value := map[string]float64{}
+ if err := json.Unmarshal(p, ); err != nil {
+ return err
+ }
+ for k, v := range value {
+ node, err := mapKV2Node(k, v)
+ if err != nil {
+ return err
+ }
+ data = append(data, *node)
}
- *n = UpstreamNodes{}
+ *n = data
return nil
}
- var data []UpstreamNode
if err := json.Unmarshal(p, ); err != nil {
return err
}
*n = data
return nil
}
+func mapKV2Node(key string, val float64) (*UpstreamNode, error) {
+ hp := strings.Split(key, ":")
+ host := hp[0]
+ // according to APISIX upstream nodes policy, port is optional
+ port := "0"
Review Comment:
I think it is appropriate to configure the default port to `80`, unless the
user manually specifies a scheme for Upstream. We can perform a similar
speculative process as APISIX.
_But the port in Ingress should be determined by the k8s service, is this
here to be compatible with existing data change scenarios in etcd? For example,
ingress data is modified by dashboard, etc._
-
BTW, the dashboard now uses the `object` to store nodes data (when created
graphically using a form) it can be created without filling in the port, at
this point there will be APISIX to determine the port automatically based on
the scheme; when the user manually enters JSON to create it, a schema check
will be performed, and if the port does not exist it will not be created
successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] bzp2010 commented on a diff in pull request #1222: fix: nodes convert failed
bzp2010 commented on code in PR #1222:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1222#discussion_r946328504
##
pkg/types/apisix/v1/types.go:
##
@@ -216,21 +217,55 @@ type UpstreamNodes []UpstreamNode
// and by default empty array will be encoded as '{}'.
// We have to maintain the compatibility.
func (n *UpstreamNodes) UnmarshalJSON(p []byte) error {
+ var data []UpstreamNode
if p[0] == '{' {
- if len(p) != 2 {
- return errors.New("unexpected non-empty object")
+ value := map[string]float64{}
+ if err := json.Unmarshal(p, ); err != nil {
+ return err
+ }
+ for k, v := range value {
+ node, err := mapKV2Node(k, v)
+ if err != nil {
+ return err
+ }
+ data = append(data, *node)
}
- *n = UpstreamNodes{}
+ *n = data
return nil
}
- var data []UpstreamNode
if err := json.Unmarshal(p, ); err != nil {
return err
}
*n = data
return nil
}
+func mapKV2Node(key string, val float64) (*UpstreamNode, error) {
+ hp := strings.Split(key, ":")
+ host := hp[0]
+ // according to APISIX upstream nodes policy, port is optional
+ port := "0"
Review Comment:
I think it is appropriate to configure the default port to `80`, unless the
user manually specifies a schema for Upstream.
-
BTW, the dashboard now uses the `object` to store nodes data (when created
graphically using a form) it can be created without filling in the port, at
this point there will be APISIX to determine the port automatically based on
the scheme; when the user manually enters JSON to create it, a schema check
will be performed, and if the port does not exist it will not be created
successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] bzp2010 commented on a diff in pull request #1222: fix: nodes convert failed
bzp2010 commented on code in PR #1222:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1222#discussion_r946328504
##
pkg/types/apisix/v1/types.go:
##
@@ -216,21 +217,55 @@ type UpstreamNodes []UpstreamNode
// and by default empty array will be encoded as '{}'.
// We have to maintain the compatibility.
func (n *UpstreamNodes) UnmarshalJSON(p []byte) error {
+ var data []UpstreamNode
if p[0] == '{' {
- if len(p) != 2 {
- return errors.New("unexpected non-empty object")
+ value := map[string]float64{}
+ if err := json.Unmarshal(p, ); err != nil {
+ return err
+ }
+ for k, v := range value {
+ node, err := mapKV2Node(k, v)
+ if err != nil {
+ return err
+ }
+ data = append(data, *node)
}
- *n = UpstreamNodes{}
+ *n = data
return nil
}
- var data []UpstreamNode
if err := json.Unmarshal(p, ); err != nil {
return err
}
*n = data
return nil
}
+func mapKV2Node(key string, val float64) (*UpstreamNode, error) {
+ hp := strings.Split(key, ":")
+ host := hp[0]
+ // according to APISIX upstream nodes policy, port is optional
+ port := "0"
Review Comment:
I think it is appropriate to configure the default port to `80`, unless the
user manually specifies a schema for Upstream.
-
Tips:
The dashboard now uses the `object` to store nodes data (when created
graphically using a form) it can be created without filling in the port, at
this point there will be APISIX to determine the port automatically based on
the scheme; when the user manually enters JSON to create it, a schema check
will be performed, and if the port does not exist it will not be created
successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] liweitianux commented on pull request #7691: feat(openid-connect): Add 'symmetric_key' option to support HS??? tokens
liweitianux commented on PR #7691: URL: https://github.com/apache/apisix/pull/7691#issuecomment-1216135013 **NOTE**: the `lua-resty-openidc` is having a bug in verifying HS??? tokens, and I've submitted a PR to fix it: https://github.com/zmartzone/lua-resty-openidc/pull/447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jackkkkklee commented on a diff in pull request #7634: feat: add openfunction plugin
jacklee commented on code in PR #7634:
URL: https://github.com/apache/apisix/pull/7634#discussion_r946328279
##
apisix/plugins/openfunction.lua:
##
@@ -0,0 +1,36 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx_encode_base64 = ngx.encode_base64
+local plugin_name, plugin_version, priority = "openfunction", 0.1, -1902
+
+local openfunction_authz_schema = {
+service_token = {type = "string"}
+}
+
+local function request_processor(conf, ctx, params)
+local headers = params.headers or {}
+-- setting authorization headers if not already set
+if not headers["authorization"] and conf.authorization
Review Comment:
Yes,it is a problem.
I think it can be avoided by overwriting authorization headers only when
'conf.authorization.service_Token' is given by users ,since auth plugin runs
before OpenFcuntion plugin.
However,it is still hard for user to apply user-specific authorization
header when auth plugin runs.Will it be a good way to put user-specific token
in an other header(e.g. 'o-function-token') and convert it to authorization
header in access step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] liweitianux opened a new pull request, #7691: feat(openid-connect): Add 'symmetric_key' option to support HS??? tokens
liweitianux opened a new pull request, #7691: URL: https://github.com/apache/apisix/pull/7691 ### Description The underlying `lua-resty-openidc` module already supports the `symmetric_key` option to specify the HMAC key for verifying HS??? tokens. However, note that `lua-resty-openidc` just passes the `symmetric_key` value as-is to HMAC. So we choose to accept a base64url-encoded secret, which is easier to obtain from OP and configure, and then decode it before passing it to `lua-resty-openidc`. ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [x] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #7674: help request: opentelemetry error in lua script
tzssangglass commented on issue #7674: URL: https://github.com/apache/apisix/issues/7674#issuecomment-1216126760 @akalittle from your configuration, it looks like you commented out ``` opentelemetry: trace_id_source: x-request-id ``` This means that the system-generated `trace_id`(https://github.com/yangxikun/opentelemetry-lua/blob/463a70993b2a87b9ab13a49322f6ec6089af55d2/lib/opentelemetry/trace/id_generator.lua#L22-L40) is used. Please make sure that in your environment the trace_id is not obtained from the x-request-id of the request, but is system generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #7674: help request: opentelemetry error in lua script
tzssangglass commented on issue #7674:
URL: https://github.com/apache/apisix/issues/7674#issuecomment-1216123324
In any case, I think the immediate cause is that `string.char()` is
converting number that over the range 0..255.
here is the test cases:
```
use t::APISIX 'no_plan';
add_block_preprocessor(sub {
my ($block) = @_;
if (!$block->request) {
$block->set_value("request", "GET /t");
}
if (!defined $block->response_body) {
$block->set_value("response_body", "passed\n");
}
if (!$block->no_error_log && !$block->error_log) {
$block->set_value("no_error_log", "[error]");
}
$block;
});
repeat_each(1);
no_long_string();
no_root_location();
log_level("info");
run_tests;
__DATA__
=== TEST 19: set additional_attributes
--- config
location /t {
content_by_lua_block {
local id_generator = require("opentelemetry.trace.id_generator")
local trace_id =id_generator.new_ids()
-- mock hex2bytes
local function hex2bytes(str)
return (str:gsub('..', function (cc)
local n = tonumber(cc, 16)
if n then
-- hack n to be over the range 0..255
return string.char(256)
end
end))
end
hex2bytes(trace_id)
ngx.say("done")
}
}
--- response_body
done
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] whioue commented on issue #7684: bug: After plugin is closed, there are still some requests to execute the plugin
whioue commented on issue #7684: URL: https://github.com/apache/apisix/issues/7684#issuecomment-1216117475 > > 考虑到是因为openresty中部分工人的连接句柄没有释放导致吗？ > > 我认为它与文件处理程序没有任何关系，插件信息在内存中并且与文件处理程序无关。 > > 对于第 4 步，如何关闭自定义插件？ 我通过调用apisix中的服务接口（插件配置在服务上）put方法修改服务中插件，进行关闭，是否存在某worker中内存没有及时清理造成的这种情况呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] liweitianux opened a new pull request, #7690: fix(openid-connect): Fix the default 'redirect_uri' (#2426)
liweitianux opened a new pull request, #7690: URL: https://github.com/apache/apisix/pull/7690 ### Description Previously the `redirect_uri` was set to `ngx.var.request_uri` if not configured. However, it caused the underlying `lua-resty-openidc` module to raise this error: ``` request to the redirect_uri path but there's no session state found ``` because `lua-resty-openidc` would think it was the redirection response from OP when the `redirect_uri` equals `ngx.var.request_uri`. Although the OAuth 2.0 Security Best Current Practice [1] recommends that the `redirect_uri` should be explicitly specified to prevent malicious redirection attacks, it would also be handy for APISIX to properly determine a default one if `redirect_uri` not given. Therefore, append the `.apisix/redirect` suffix to the current request URI to determine the default `redirect_uri`. It makes `lua-resty-openidc` happy and it's almost unlikely to conflict with user's URIs. Also note that the OP should be properly configured to accept such auto-determined redirect URIs. Update the documentation accordingly. Fix #2426. [1] https://datatracker.ietf.org/doc/draft-ietf-oauth-security-topics/ ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [x] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] PhanPirang commented on issue #121: request help: cannot find conf token and receive undefined filter
PhanPirang commented on issue #121: URL: https://github.com/apache/apisix-java-plugin-runner/issues/121#issuecomment-1216108421 > it's resolved, because my code error, thanks very much. I also faced this issue, what's your solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] PhanPirang opened a new issue, #186: request help:
PhanPirang opened a new issue, #186: URL: https://github.com/apache/apisix-java-plugin-runner/issues/186 ### Issue description I got "receive undefined filter: TokenValidator, skip it" message. In Java, my plugin's name is "TokenValidator" ### Environment Ubuntu 20.04 * apisix-java-plugin-runner version 0.3.0  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1222: fix: nodes convert failed
tao12345666333 commented on code in PR #1222:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1222#discussion_r946308536
##
pkg/types/apisix/v1/types.go:
##
@@ -216,21 +217,55 @@ type UpstreamNodes []UpstreamNode
// and by default empty array will be encoded as '{}'.
// We have to maintain the compatibility.
func (n *UpstreamNodes) UnmarshalJSON(p []byte) error {
+ var data []UpstreamNode
if p[0] == '{' {
- if len(p) != 2 {
- return errors.New("unexpected non-empty object")
+ value := map[string]float64{}
+ if err := json.Unmarshal(p, ); err != nil {
+ return err
+ }
+ for k, v := range value {
+ node, err := mapKV2Node(k, v)
+ if err != nil {
+ return err
+ }
+ data = append(data, *node)
}
- *n = UpstreamNodes{}
+ *n = data
return nil
}
- var data []UpstreamNode
if err := json.Unmarshal(p, ); err != nil {
return err
}
*n = data
return nil
}
+func mapKV2Node(key string, val float64) (*UpstreamNode, error) {
+ hp := strings.Split(key, ":")
+ host := hp[0]
+ // according to APISIX upstream nodes policy, port is optional
+ port := "0"
Review Comment:
ref:
https://github.com/apache/apisix/blob/c4d5f2fca5b9ef98b551c769e2b1565185ed9630/apisix/schema_def.lua#L316-L341
port is not optional.
When APISIX is processing, there is a method to determine the port according
to the protocol
https://github.com/apache/apisix/blob/c4d5f2fca5b9ef98b551c769e2b1565185ed9630/apisix/upstream.lua#L167-L175
So here I suggest setting it to 80, WDYT @bzp2010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] zaunist commented on a diff in pull request #1216: fix: log Secret name instead of all data
zaunist commented on code in PR #1216:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1216#discussion_r946286709
##
pkg/providers/k8s/secret.go:
##
@@ -400,8 +400,8 @@ func (c *secretController) onUpdate(prev, curr interface{})
{
return
}
log.Debugw("secret update event arrived",
- zap.Any("new object", curr),
- zap.Any("old object", prev),
+ zap.Any("new object", curr.(*corev1.Secret).ObjectMeta.Name),
+ zap.Any("old object", prev.(*corev1.Secret).ObjectMeta.Name),
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on issue #7674: help request: opentelemetry error in lua script
monkeyDluffy6017 commented on issue #7674: URL: https://github.com/apache/apisix/issues/7674#issuecomment-1216078334 Let me follow this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on issue #7674: help request: opentelemetry error in lua script
monkeyDluffy6017 commented on issue #7674: URL: https://github.com/apache/apisix/issues/7674#issuecomment-1216078151 我来 follow 下这个问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #7639: feat: convert grpc-status-details-bin in header to HTTP response body…
monkeyDluffy6017 commented on code in PR #7639:
URL: https://github.com/apache/apisix/pull/7639#discussion_r946271862
##
t/plugin/grpc-transcode3.t:
##
@@ -122,3 +122,447 @@ POST /grpctest
Content-Type: application/json
--- response_body chomp
{"message":"Hello world, name: Joe, age: 1, name: Jake, age: 2"}
+
+
+
+=== TEST 3: set proto (id: 1, get error response from rpc)
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+
+local code, body = t('/apisix/admin/proto/1',
+ ngx.HTTP_PUT,
+ [[{
+"content" : "syntax = \"proto3\";
+ package helloworld;
+ service Greeter {
+ rpc GetErrResp (HelloRequest) returns (HelloReply) {}
+ }
+ message HelloRequest {
+ string name = 1;
+ repeated string items = 2;
+ }
+ message HelloReply {
+ string message = 1;
+ repeated string items = 2;
+ }
+ message ErrorDetail {
+ int64 code = 1;
+ string message = 2;
+ string type = 3;
+ }"
+ }]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #7639: feat: convert grpc-status-details-bin in header to HTTP response body…
monkeyDluffy6017 commented on code in PR #7639: URL: https://github.com/apache/apisix/pull/7639#discussion_r946270701 ## docs/en/latest/plugins/grpc-transcode.md: ## @@ -44,6 +44,9 @@ APISIX takes in an HTTP request, transcodes it and forwards it to a gRPC service | method| string | True | | Method name of the gRPC service. | | deadline | number | False | 0 | Deadline for the gRPC service in ms. | | pb_option | array[string([pb_option_def](#options-for-pb_option))] | False | | protobuf options.| +| show_status_in_body | boolean | False | False | Whether to display the parsed `grpc-status-details-bin` in the response body | +| status_detail_type | string| False | | The message type corresponding to the [details](https://github.com/googleapis/googleapis/blob/master/google/rpc/status.proto#L46) part of `grpc-status-details-bin`, if not specified, this part will not be decoded | Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #7639: feat: convert grpc-status-details-bin in header to HTTP response body…
monkeyDluffy6017 commented on code in PR #7639:
URL: https://github.com/apache/apisix/pull/7639#discussion_r946269341
##
apisix/plugins/grpc-transcode.lua:
##
@@ -72,6 +72,17 @@ local schema = {
"disable_hooks",
}
},
+show_status_in_body = {
+description = "show decoded grpc-status-details-bin in response
body",
+type= "boolean",
+default = false
+},
+--
https://github.com/googleapis/googleapis/blob/master/google/rpc/status.proto#L46
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on a diff in pull request #7634: feat: add openfunction plugin
tokers commented on code in PR #7634:
URL: https://github.com/apache/apisix/pull/7634#discussion_r946266422
##
apisix/plugins/openfunction.lua:
##
@@ -0,0 +1,36 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx_encode_base64 = ngx.encode_base64
+local plugin_name, plugin_version, priority = "openfunction", 0.1, -1902
+
+local openfunction_authz_schema = {
+service_token = {type = "string"}
+}
+
+local function request_processor(conf, ctx, params)
+local headers = params.headers or {}
+-- setting authorization headers if not already set
+if not headers["authorization"] and conf.authorization
Review Comment:
What if users configure an auth plugin with the OpenFunction plugin, and the
authorization header from client is not designed for the FaaS. In such a case,
the authentication will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #7689: help request: Setting up OIDC plugin with proxy-rewrite
tokers commented on issue #7689: URL: https://github.com/apache/apisix/issues/7689#issuecomment-1216048752 That's indeed a quit implicit requirement that the `redirect_uri` should be matched to the same route which the OIDC starts. In your case, try to set `redirect_uri` to something like `/thing/_callback`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #7684: bug: After plugin is closed, there are still some requests to execute the plugin
tokers commented on issue #7684: URL: https://github.com/apache/apisix/issues/7684#issuecomment-1216046292 Check out if there are any suspicious error logs when you close the plugin and make sure the close logic is effective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7639: feat: convert grpc-status-details-bin in header to HTTP response body…
spacewander commented on code in PR #7639:
URL: https://github.com/apache/apisix/pull/7639#discussion_r946257652
##
t/plugin/grpc-transcode3.t:
##
@@ -122,3 +122,447 @@ POST /grpctest
Content-Type: application/json
--- response_body chomp
{"message":"Hello world, name: Joe, age: 1, name: Jake, age: 2"}
+
+
+
+=== TEST 3: set proto (id: 1, get error response from rpc)
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+
+local code, body = t('/apisix/admin/proto/1',
+ ngx.HTTP_PUT,
+ [[{
+"content" : "syntax = \"proto3\";
+ package helloworld;
+ service Greeter {
+ rpc GetErrResp (HelloRequest) returns (HelloReply) {}
+ }
+ message HelloRequest {
+ string name = 1;
+ repeated string items = 2;
+ }
+ message HelloReply {
+ string message = 1;
+ repeated string items = 2;
+ }
+ message ErrorDetail {
+ int64 code = 1;
+ string message = 2;
+ string type = 3;
+ }"
+ }]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
Review Comment:
`--- request` is set in
https://github.com/apache/apisix/blob/c4d5f2fca5b9ef98b551c769e2b1565185ed9630/t/plugin/grpc-transcode3.t#L27.
There is no need to set it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7639: feat: convert grpc-status-details-bin in header to HTTP response body…
spacewander commented on code in PR #7639:
URL: https://github.com/apache/apisix/pull/7639#discussion_r946257951
##
apisix/plugins/grpc-transcode.lua:
##
@@ -72,6 +72,17 @@ local schema = {
"disable_hooks",
}
},
+show_status_in_body = {
+description = "show decoded grpc-status-details-bin in response
body",
+type= "boolean",
+default = false
+},
+--
https://github.com/googleapis/googleapis/blob/master/google/rpc/status.proto#L46
Review Comment:
You should use GitHub's permalink feature, not a link to the master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] ccxhwmy commented on a diff in pull request #7643: feat: add elasticsearch-logger
ccxhwmy commented on code in PR #7643:
URL: https://github.com/apache/apisix/pull/7643#discussion_r946235479
##
t/plugin/elasticsearch-logging.t:
##
@@ -0,0 +1,299 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+
+if (!defined $block->request) {
+$block->set_value("request", "GET /t");
+}
+
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: sanity
+--- config
+location /t {
+content_by_lua_block {
+local ok, err
+local configs = {
+-- full configuration
+{
+endpoint = {
+uri = "http://127.0.0.1:9200;,
+index = "services",
+type = "collector",
+timeout = 60,
+username = "elastic",
+password = "123456",
+ssl_verify = false
+},
+max_retry_count = 0,
+retry_delay = 1,
+buffer_duration = 60,
+inactive_timeout = 2,
+batch_max_size = 10,
+},
+-- minimize configuration
+{
+endpoint = {
+uri = "http://127.0.0.1:9200;,
+index = "services"
+}
+},
+-- property "uri" is required
+{
+endpoint = {
+index = "services",
+}
+},
+-- property "index" is required
+{
+endpoint = {
+uri = "http://127.0.0.1:9200;,
+}
+},
+-- property "uri" validation failed
+{
+endpoint = {
+uri = "127.0.0.1:9200",
+index = "services"
+}
+}
+}
+
+local plugin = require("apisix.plugins.elasticsearch-logging")
+for i = 1, #configs do
+ok, err = plugin.check_schema(configs[i])
+if err then
+ngx.say(err)
+else
+ngx.say("passed")
+end
+end
+}
+}
+--- response_body_like
+passed
+passed
+property "endpoint" validation failed: property "uri" is required
+property "endpoint" validation failed: property "index" is required
+property "endpoint" validation failed: property "uri" validation failed.*
+
+
+
+=== TEST 2: set route
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1', ngx.HTTP_PUT, {
+uri = "/hello",
+upstream = {
+type = "roundrobin",
+nodes = {
+["127.0.0.1:1980"] = 1
+}
+},
+plugins = {
+["elasticsearch-logging"] = {
+endpoint = {
+uri = "http://127.0.0.1:9200;,
+index = "services"
+},
+batch_max_size = 1,
+inactive_timeout = 1
+}
+}
+})
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- response_body
+passed
+
+
+
+=== TEST 3: test route (success write)
+--- request
+GET /hello
+--- wait: 2
+--- response_body
+hello world
+
+
+
+=== TEST 4: set route (auth)
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+
[GitHub] [apisix] desidia26 opened a new issue, #7689: help request: Setting up OIDC plugin with proxy-rewrite
desidia26 opened a new issue, #7689:
URL: https://github.com/apache/apisix/issues/7689
### Description
I am attempting to put some services behind APISIX in such a manner that
some services are behind an OIDC plugin, and others are not.
Deployment was done via the [apisix/docker
docker-compose](https://github.com/apache/apisix-docker/blob/master/example/docker-compose.yml)
Configuration:
Routes:
```
{
"uri": "/thing/*",
"name": "httpbin",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"openid-connect": {
"bearer_only": false,
"client_id": "apisix",
"client_secret": "somesecret",
"disable": false,
"discovery":
"http://host.docker.internal:8091/auth/realms/my-realm/.well-known/openid-configuration;,
"introspection_endpoint_auth_method": "client_secret_post",
"realm": "my-realm",
"redirect_uri": "http://localhost:9080/;,
"scope": "openid profile"
},
"proxy-rewrite": {
"regex_uri": [
"/thing/(.*)",
"/$1"
]
}
},
"upstream_id": "421225011701875398",
"status": 1
}
```
Upstreams:
```
{
"nodes": [
{
"host": "httpbin.org",
"port": 80,
"weight": 1
}
],
"timeout": {
"connect": 6,
"send": 6,
"read": 6
},
"type": "roundrobin",
"scheme": "http",
"pass_host": "pass",
"name": "httpbin",
"keepalive_pool": {
"idle_timeout": 60,
"requests": 1000,
"size": 320
}
}
```
If I visit `http://localhost:9080/thing/get` (what I expect would be the
equivalent of http://httpbin.org/get), I am routed to my IdP as expected, and
then am redirected to:
`http://localhost:9080/?state=3f8d35d79a43728d1419a0ba3192c82a_state=129b46da-8448-4dbe-8a90-01dc51844d21=bfa03039-ba35-413b-9bbd-ae97042f0d99.129b46da-8448-4dbe-8a90-01dc51844d21.3be76236-43a2-4f3f-a3a9-ccce5defb966`,
which APISIX give a `{"error_msg":"404 Route Not Found"}` for.
I tried setting the `redirect_uri` to something like
`http://localhost:9080/thing/redirect`, but that sends me down the `request to
the redirect_uri path but there's no session state found` rabbit hole.
Of course everything works if I change the route to match on`/*`, but
doesn't this make it so that I can no longer have some services that *aren't*
behind the plugin?
Any help on the matter would be greatly appreciated.
Also let me know if I'm forgetting to elaborate on anything.
### Environment
- APISIX version (run `apisix version`): `**2.15.0**`
- Operating system (run `uname -a`): `**Linux dad329b3f8dd 5.10.104-linuxkit
#1 SMP Thu Mar 17 17:08:06 UTC 2022 x86_64 Linux**`
- OpenResty / Nginx version (run `openresty -V` or `nginx -V`): `**nginx
version: openresty/1.21.4.1**`
- etcd version, if relevant (run `curl
http://127.0.0.1:9090/v1/server_info`):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #7634: feat: add openfunction plugin
tzssangglass commented on PR #7634: URL: https://github.com/apache/apisix/pull/7634#issuecomment-1215343401 rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] sangnguyen7 closed issue #7661: bug: [Plugin] OpenID-Connect had an issue or not supported when using "use_jwks=true" and use "discovery" as the JWKS endpoint
sangnguyen7 closed issue #7661: bug: [Plugin] OpenID-Connect had an issue or not supported when using "use_jwks=true" and use "discovery" as the JWKS endpoint URL: https://github.com/apache/apisix/issues/7661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] sangnguyen7 commented on issue #7661: bug: [Plugin] OpenID-Connect had an issue or not supported when using "use_jwks=true" and use "discovery" as the JWKS endpoint
sangnguyen7 commented on issue #7661: URL: https://github.com/apache/apisix/issues/7661#issuecomment-1215242674 @Hazel6869 Got it, thanks a lot. @tokers yes, I just saw it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #7684: bug: After plugin is closed, there are still some requests to execute the plugin
tzssangglass commented on issue #7684: URL: https://github.com/apache/apisix/issues/7684#issuecomment-1215144241 > 考虑到是因为openresty中部分worker里的连接句柄没有得到释放导致？ I don't think it has anything to do with the file handler, the plugin information is in memory and not associated with the file handler. for step 4, how do you close your custom plugin? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6540: bug: health check Sometimes there is data, sometimes there is no data
tzssangglass commented on issue #6540: URL: https://github.com/apache/apisix/issues/6540#issuecomment-1215140746 answer by: https://github.com/apache/apisix/issues/7141#issuecomment-1140175036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] akalittle commented on issue #7674: help request: opentelemetry error in lua script
akalittle commented on issue #7674:
URL: https://github.com/apache/apisix/issues/7674#issuecomment-1215131247
CRD:
```yaml
apiVersion: apisix.apache.org/v2beta3
kind: ApisixRoute
metadata:
name: status-tracker
namespace: launcher
spec:
http:
- name: status-tracker-rule
match:
hosts:
- api.xxx.cc
paths:
- /status-tracker*
plugins:
- name: proxy-rewrite
enable: true
config:
regex_uri:
- ^/status-tracker/(.*)
- /$1
- name: limit-count
enable: true
config:
count: 100
time_window: 60
- name: opentelemetry
enable: true
config:
sampler:
name: always_on
backends:
- serviceName: status-tracker
servicePort: 8000
# authentication:
#enable: true
#type: keyAuth
```
in json format:
```json
{
"uris": [
"/status-tracker*"
],
"name": "launcher_status-tracker_status-tracker-rule",
"desc": "Created by apisix-ingress-controller, DO NOT modify it manually",
"hosts": [
"api.xxx.cc"
],
"plugins": {
"limit-count": {
"allow_degradation": false,
"count": 100,
"key": "remote_addr",
"key_type": "var",
"policy": "local",
"rejected_code": 503,
"show_limit_quota_header": true,
"time_window": 60
},
"opentelemetry": {
"sampler": {
"name": "always_on",
"options": {
"fraction": 0,
"root": {
"name": "always_off"
}
}
}
},
"proxy-rewrite": {
"regex_uri": [
"^/status-tracker/(.*)",
"/$1"
],
"use_real_request_uri_unsafe": false
}
},
"upstream_id": "b407a3",
"labels": {
"managed-by": "apisix-ingress-controller"
},
"status": 1
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] jackkkkklee commented on pull request #7634: feat: add openfunction plugin
jacklee commented on PR #7634: URL: https://github.com/apache/apisix/pull/7634#issuecomment-1215129913 > > Could you please re-run "CI / build (ubuntu-18.04, linux_openresty_1_19, t/plugin) (pull_request) " ? > > Timeout happened during building function. > > accord to: https://github.com/apache/apisix/runs/7833789308?check_suite_focus=true, maybe some error in test cases? I think the root cause is network. In test case ,the server do not give response and test failed because of timeout in pre env step. accord to https://github.com/apache/apisix/runs/7833789308?check_suite_focus=true#step:11:568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7643: feat: add elasticsearch-logger
tzssangglass commented on code in PR #7643:
URL: https://github.com/apache/apisix/pull/7643#discussion_r945835824
##
apisix/plugins/elasticsearch-logging.lua:
##
@@ -0,0 +1,154 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local ngx = ngx
+local core= require("apisix.core")
+local ngx_now = ngx.now
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+local DEFAULT_ELASTICSEARCH_SOURCE = "apache-apisix-elasticsearch-logging"
+
+local plugin_name = "elasticsearch-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+local str_format = core.string.format
+local str_sub = string.sub
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+index = { type = "string"},
+type = { type = "string"},
+username = { type = "string"},
+password = { type = "string"},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+ssl_verify = {
+type = "boolean",
+default = true
+}
+},
+required = { "uri", "index" }
+},
+},
+required = { "endpoint" },
+}
+
+
+local _M = {
+version = 0.1,
+priority = 413,
+name = plugin_name,
+schema = batch_processor_manager:wrap_schema(schema),
+}
+
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
+return core.json.encode({
+create = {
+_index = conf.endpoint.index,
+_type = conf.endpoint.type
+}
+}) .. "\n" ..
+core.json.encode({
+time = ngx_now(),
+host = entry.server.hostname,
Review Comment:
my mistake. json string is ok. we can follow this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7643: feat: add elasticsearch-logger
tzssangglass commented on code in PR #7643:
URL: https://github.com/apache/apisix/pull/7643#discussion_r945832191
##
apisix/plugins/elasticsearch-logging.lua:
##
@@ -0,0 +1,154 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local ngx = ngx
+local core= require("apisix.core")
+local ngx_now = ngx.now
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+local DEFAULT_ELASTICSEARCH_SOURCE = "apache-apisix-elasticsearch-logging"
+
+local plugin_name = "elasticsearch-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+local str_format = core.string.format
+local str_sub = string.sub
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+index = { type = "string"},
+type = { type = "string"},
+username = { type = "string"},
+password = { type = "string"},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+ssl_verify = {
+type = "boolean",
+default = true
+}
+},
+required = { "uri", "index" }
+},
+},
+required = { "endpoint" },
+}
+
+
+local _M = {
+version = 0.1,
+priority = 413,
+name = plugin_name,
+schema = batch_processor_manager:wrap_schema(schema),
+}
+
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #7643: feat: add elasticsearch-logger
tzssangglass commented on PR #7643: URL: https://github.com/apache/apisix/pull/7643#issuecomment-1215102647 > Thank you for your suggestions, there are helpful to me. > Would you offer me some doc about document specification you are using, so that I can write docs more norm next. IMO, I learn the document specification from existing plugins docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #7634: feat: add openfunction plugin
tzssangglass commented on PR #7634: URL: https://github.com/apache/apisix/pull/7634#issuecomment-1215099723 > Could you please re-run "CI / build (ubuntu-18.04, linux_openresty_1_19, t/plugin) (pull_request) " ? > Timeout happened during building function. accord to: https://github.com/apache/apisix/runs/7833789308?check_suite_focus=true, maybe some error in test cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hf400159 opened a new pull request, #7688: docs: refactor loggers plugin doc
hf400159 opened a new pull request, #7688: URL: https://github.com/apache/apisix/pull/7688 ### Description Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #7674: help request: opentelemetry error in lua script
tzssangglass commented on issue #7674: URL: https://github.com/apache/apisix/issues/7674#issuecomment-1215051363 @akalittle Can you provide the routing configuration in text format? Do not provide images. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] hf400159 opened a new pull request, #1287: docs: update documentation-guide
hf400159 opened a new pull request, #1287: URL: https://github.com/apache/apisix-website/pull/1287 Fixes: #[Add issue number here] Changes: Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #1287: docs: update documentation-guide
netlify[bot] commented on PR #1287: URL: https://github.com/apache/apisix-website/pull/1287#issuecomment-1215033721 ### Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit | f53b6c08b889c70f1991d473508c8df6886485e3 | | Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/62fa4e6b69b34300084ce29c | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #7674: help request: opentelemetry error in lua script
juzhiyuan commented on issue #7674: URL: https://github.com/apache/apisix/issues/7674#issuecomment-1215026817 FYI: The related Slack link[1]. [1] https://the-asf.slack.com/archives/CUC5MN17A/p1660569995134259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ccxhwmy commented on pull request #7643: feat: add elasticsearch-logger
ccxhwmy commented on PR #7643: URL: https://github.com/apache/apisix/pull/7643#issuecomment-1215023063 > great work! Thank you for your suggestions, there are helpful to me. Would you offer me some doc about document specification you are using, so that I can write docs more norm next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hf400159 opened a new pull request, #7687: docs: refactor rocketmq-logger plugin doc
hf400159 opened a new pull request, #7687: URL: https://github.com/apache/apisix/pull/7687 ### Description Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ccxhwmy commented on a diff in pull request #7643: feat: add elasticsearch-logger
ccxhwmy commented on code in PR #7643:
URL: https://github.com/apache/apisix/pull/7643#discussion_r945708290
##
apisix/plugins/elasticsearch-logging.lua:
##
@@ -0,0 +1,154 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local ngx = ngx
+local core= require("apisix.core")
+local ngx_now = ngx.now
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+local DEFAULT_ELASTICSEARCH_SOURCE = "apache-apisix-elasticsearch-logging"
+
+local plugin_name = "elasticsearch-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+local str_format = core.string.format
+local str_sub = string.sub
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+index = { type = "string"},
+type = { type = "string"},
+username = { type = "string"},
+password = { type = "string"},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+ssl_verify = {
+type = "boolean",
+default = true
+}
+},
+required = { "uri", "index" }
+},
+},
+required = { "endpoint" },
+}
+
+
+local _M = {
+version = 0.1,
+priority = 413,
+name = plugin_name,
+schema = batch_processor_manager:wrap_schema(schema),
+}
+
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
Review Comment:
> We do not reference the code of another plugin in one plugin. Unless we
pull some generic code into a common module.
> Please also support the custom log format.
Is the `custom log format` like:
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/kafka-logger.md#metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] ccxhwmy commented on a diff in pull request #7643: feat: add elasticsearch-logger
ccxhwmy commented on code in PR #7643:
URL: https://github.com/apache/apisix/pull/7643#discussion_r945705071
##
apisix/plugins/elasticsearch-logging.lua:
##
@@ -0,0 +1,154 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local ngx = ngx
+local core= require("apisix.core")
+local ngx_now = ngx.now
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+local DEFAULT_ELASTICSEARCH_SOURCE = "apache-apisix-elasticsearch-logging"
+
+local plugin_name = "elasticsearch-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+local str_format = core.string.format
+local str_sub = string.sub
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+index = { type = "string"},
+type = { type = "string"},
+username = { type = "string"},
+password = { type = "string"},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+ssl_verify = {
+type = "boolean",
+default = true
+}
+},
+required = { "uri", "index" }
+},
+},
+required = { "endpoint" },
+}
+
+
+local _M = {
+version = 0.1,
+priority = 413,
+name = plugin_name,
+schema = batch_processor_manager:wrap_schema(schema),
+}
+
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
+return core.json.encode({
+create = {
+_index = conf.endpoint.index,
+_type = conf.endpoint.type
+}
+}) .. "\n" ..
+core.json.encode({
+time = ngx_now(),
+host = entry.server.hostname,
Review Comment:
> we just need to use `log_util.get_req_original(ctx, conf)` to get `entry`,
This is a json, and ES supports this format.
I found that `log_util.get_req_original(ctx, conf)` will return a string
instead of json:
https://github.com/apache/apisix/blob/c4d5f2fca5b9ef98b551c769e2b1565185ed9630/apisix/utils/log-util.lua#L196-L211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] kumaxl closed issue #7678: help request: how to manage ip whitelist used on many routes? Is there any way to group requests to different consumers just by ip?
kumaxl closed issue #7678: help request: how to manage ip whitelist used on many routes? Is there any way to group requests to different consumers just by ip? URL: https://github.com/apache/apisix/issues/7678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kumaxl commented on issue #7678: help request: how to manage ip whitelist used on many routes? Is there any way to group requests to different consumers just by ip?
kumaxl commented on issue #7678: URL: https://github.com/apache/apisix/issues/7678#issuecomment-1214927009  well, found it! Many Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 opened a new pull request, #7686: chore: remove useless judge in pubsub init
monkeyDluffy6017 opened a new pull request, #7686: URL: https://github.com/apache/apisix/pull/7686 ### Description remove useless judge in pubsub init, the `loaded` table is empty after `new` https://github.com/starwing/lua-protobuf/blob/master/protoc.lua#L301 ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2540: refactor: config
bzp2010 commented on PR #2540: URL: https://github.com/apache/apisix-dashboard/pull/2540#issuecomment-1214877862 ping @nic-chen @starsz @LiteSun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2540: refactor: config
bzp2010 commented on PR #2540: URL: https://github.com/apache/apisix-dashboard/pull/2540#issuecomment-1214877509 ### Update It currently completes the refactoring of the `config` package without touching any meaningful CI tests, and eliminates all other package coupling dependencies on `conf`, and currently it completely uses parameter passing to pass configuration to dependencies. However, it should be noted that part of the CI related to release packaging is turned off and it will be turned on when the v3 version on the `next` branch is ready for release. Also the current configuration pass has been modified so that some of the function arguments have been changed, they are crude and only meet the criteria of being usable, not elegant, I need to optimize them further in iterations, please don't get hung up on the function argument changes. ### Tips The core of this PR is to remove the `conf` package, implement the new `config` package, strip and replace its use cases. I had to modify a lot of coupled code and related test CIs, such as CLI and E2E. So this PR was huge, involving many files and hundreds of lines of code changes. You can focus on those new feature implementations rather than simply replacing code with packages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 opened a new pull request, #7685: test: fix test case with not escaped bracket
monkeyDluffy6017 opened a new pull request, #7685: URL: https://github.com/apache/apisix/pull/7685 ### Description fix test case with not escaped bracket ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] wangfeng22 closed issue #100: request help:
wangfeng22 closed issue #100: request help: URL: https://github.com/apache/apisix-go-plugin-runner/issues/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2590: chore: Move from yarn to pnpm
FangSen9000 commented on PR #2590: URL: https://github.com/apache/apisix-dashboard/pull/2590#issuecomment-1214862714 @bzp2010 I have finished all the work based on your work. You can have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1213: feat: support docker-compose command detect
lingsamuel commented on code in PR #1213:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1213#discussion_r945592442
##
test/e2e/testdata/wolf-rbac/cmd.sh:
##
@@ -20,20 +20,26 @@
cd test/e2e/testdata/wolf-rbac/
OPTION=$1
+COMPOSE="docker-compose"
+
+if ! command -v "docker-compose" > /dev/null; then
+ echo "docker-compose not found, try docker compose"
+COMPOSE="docker compose"
+fi
if [ $OPTION = "ip" ]; then
echo -n `docker inspect -f '{{range
.NetworkSettings.Networks}}{{.Gateway}}{{end}}' wolf-server`
elif [ $OPTION = "start" ]; then
-docker-compose -f 'docker-compose.yaml' -p 'wolf-rbac' down
+eval "$COMPOSE -f 'docker-compose.yaml' -p 'wolf-rbac' down"
Review Comment:
```bash
cmd=( docker compose )
```
##
test/e2e/testdata/wolf-rbac/cmd.sh:
##
@@ -20,20 +20,26 @@
cd test/e2e/testdata/wolf-rbac/
OPTION=$1
+COMPOSE="docker-compose"
+
+if ! command -v "docker-compose" > /dev/null; then
+ echo "docker-compose not found, try docker compose"
+COMPOSE="docker compose"
+fi
if [ $OPTION = "ip" ]; then
echo -n `docker inspect -f '{{range
.NetworkSettings.Networks}}{{.Gateway}}{{end}}' wolf-server`
elif [ $OPTION = "start" ]; then
-docker-compose -f 'docker-compose.yaml' -p 'wolf-rbac' down
+eval "$COMPOSE -f 'docker-compose.yaml' -p 'wolf-rbac' down"
Review Comment:
```bash
cmd=( docker compose )
$cmd
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1216: fix: log Secret name instead of all data
lingsamuel commented on code in PR #1216:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1216#discussion_r945589277
##
pkg/providers/k8s/secret.go:
##
@@ -400,8 +400,8 @@ func (c *secretController) onUpdate(prev, curr interface{})
{
return
}
log.Debugw("secret update event arrived",
- zap.Any("new object", curr),
- zap.Any("old object", prev),
+ zap.Any("new object", curr.(*corev1.Secret).ObjectMeta.Name),
+ zap.Any("old object", prev.(*corev1.Secret).ObjectMeta.Name),
Review Comment:
we don't need to log secret name twice since it is immutable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #4829: request help: kafka-logger batch-processor error
github-actions[bot] closed issue #4829: request help: kafka-logger batch-processor error URL: https://github.com/apache/apisix/issues/4829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #4904: Integration of eureka as discovery registry fail
github-actions[bot] commented on issue #4904: URL: https://github.com/apache/apisix/issues/4904#issuecomment-1214847100 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #4829: request help: kafka-logger batch-processor error
github-actions[bot] commented on issue #4829: URL: https://github.com/apache/apisix/issues/4829#issuecomment-1214847061 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #4796: request help: Whether the active health check is not perfect？
github-actions[bot] closed issue #4796: request help: Whether the active health check is not perfect？ URL: https://github.com/apache/apisix/issues/4796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #4794: bug: APISIX v2.7 doesn't support S3(Object Storage API) signature_v4
github-actions[bot] commented on issue #4794: URL: https://github.com/apache/apisix/issues/4794#issuecomment-1214847012 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #4796: request help: Whether the active health check is not perfect？
github-actions[bot] commented on issue #4796: URL: https://github.com/apache/apisix/issues/4796#issuecomment-1214847035 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #4794: bug: APISIX v2.7 doesn't support S3(Object Storage API) signature_v4
github-actions[bot] closed issue #4794: bug: APISIX v2.7 doesn't support S3(Object Storage API) signature_v4 URL: https://github.com/apache/apisix/issues/4794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #2972: [DISCUSS] rich command line options to enhance the bin/apisix
github-actions[bot] commented on issue #2972: URL: https://github.com/apache/apisix/issues/2972#issuecomment-1214846982 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: fix: TestRotateLog (#1246)
This is an automated email from the ASF dual-hosted git repository.
zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 356b220f fix: TestRotateLog (#1246)
356b220f is described below
commit 356b220f4b92c644e8a937164fca2517ed3e6a4f
Author: Xin Rong
AuthorDate: Mon Aug 15 18:05:34 2022 +0800
fix: TestRotateLog (#1246)
---
cmd/ingress/ingress_test.go | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/cmd/ingress/ingress_test.go b/cmd/ingress/ingress_test.go
index a32a00b7..c72a2fe1 100644
--- a/cmd/ingress/ingress_test.go
+++ b/cmd/ingress/ingress_test.go
@@ -170,6 +170,8 @@ func TestRotateLog(t *testing.T) {
cmd.SetArgs([]string{
"--log-rotate-output-path", "./testlog/test.log",
"--log-rotate-max-size", "1",
+ "--log-level", "debug",
+ "--log-output", "./testlog/test.log",
"--http-listen", listen,
"--enable-profiling",
"--kubeconfig", "/foo/bar/baz",
@@ -185,6 +187,12 @@ func TestRotateLog(t *testing.T) {
close(stopCh)
}()
+ fws := {}
+ logger, err := log.NewLogger(log.WithLogLevel("debug"),
log.WithWriteSyncer(fws))
+ assert.Nil(t, err)
+ defer logger.Close()
+ log.DefaultLogger = logger
+
// fill logs with data until the size > 1m
line := ""
for i := 0; i < 256; i++ {
@@ -192,7 +200,7 @@ func TestRotateLog(t *testing.T) {
}
for i := 0; i < 4096; i++ {
- log.Info(line)
+ log.Debug(line)
}
time.Sleep(5 * time.Second)
@@ -206,5 +214,4 @@ func TestRotateLog(t *testing.T) {
}
assert.Equal(t, true, len(files) >= 2)
-
}
[GitHub] [apisix-ingress-controller] dependabot[bot] closed pull request #1229: chore(deps): bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0
dependabot[bot] closed pull request #1229: chore(deps): bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0 URL: https://github.com/apache/apisix-ingress-controller/pull/1229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1246: fix: TestRotateLog
tao12345666333 merged PR #1246: URL: https://github.com/apache/apisix-ingress-controller/pull/1246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dependabot[bot] commented on pull request #1229: chore(deps): bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0
dependabot[bot] commented on PR #1229: URL: https://github.com/apache/apisix-ingress-controller/pull/1229#issuecomment-1214846161 Looks like github.com/prometheus/client_golang is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #1244: chore(deps): bump go.uber.org/zap and github.com/prometheus/client_golang
gxthrj merged PR #1244: URL: https://github.com/apache/apisix-ingress-controller/pull/1244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dependabot[bot] commented on pull request #1240: chore(deps): bump go.uber.org/zap from 1.21.0 to 1.22.0
dependabot[bot] commented on PR #1240: URL: https://github.com/apache/apisix-ingress-controller/pull/1240#issuecomment-1214845605 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: chore(deps): bump go.uber.org/zap and github.com/prometheus/client_golang (#1244)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new e2b68f45 chore(deps): bump go.uber.org/zap and github.com/prometheus/client_golang (#1244) e2b68f45 is described below commit e2b68f455812c872d6e5cb49f2b76355542ba898 Author: Jintao Zhang AuthorDate: Mon Aug 15 18:04:44 2022 +0800 chore(deps): bump go.uber.org/zap and github.com/prometheus/client_golang (#1244) --- go.mod | 17 - go.sum | 35 --- test/e2e/go.mod | 14 +++--- test/e2e/go.sum | 33 ++--- 4 files changed, 53 insertions(+), 46 deletions(-) diff --git a/go.mod b/go.mod index 83720cb4..8b4b6c96 100644 --- a/go.mod +++ b/go.mod @@ -7,14 +7,14 @@ require ( github.com/hashicorp/go-memdb v1.3.3 github.com/hashicorp/go-multierror v1.1.1 github.com/pkg/errors v0.9.1 - github.com/prometheus/client_golang v1.12.2 + github.com/prometheus/client_golang v1.13.0 github.com/prometheus/client_model v0.2.0 github.com/slok/kubewebhook/v2 v2.3.0 github.com/spf13/cobra v1.5.0 github.com/stretchr/testify v1.8.0 github.com/xeipuuv/gojsonschema v1.2.0 go.uber.org/multierr v1.8.0 - go.uber.org/zap v1.21.0 + go.uber.org/zap v1.22.0 golang.org/x/net v0.0.0-20220725212005-46097bf591d3 gopkg.in/natefinch/lumberjack.v2 v2.0.0 gopkg.in/yaml.v2 v2.4.0 @@ -44,7 +44,7 @@ require ( github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect github.com/golang/protobuf v1.5.2 // indirect github.com/google/gnostic v0.6.9 // indirect - github.com/google/go-cmp v0.5.7 // indirect + github.com/google/go-cmp v0.5.8 // indirect github.com/google/gofuzz v1.1.0 // indirect github.com/hashicorp/errwrap v1.0.0 // indirect github.com/hashicorp/go-immutable-radix v1.3.0 // indirect @@ -62,24 +62,23 @@ require ( github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect github.com/pelletier/go-toml/v2 v2.0.2 // indirect github.com/pmezard/go-difflib v1.0.0 // indirect - github.com/prometheus/common v0.32.1 // indirect - github.com/prometheus/procfs v0.7.3 // indirect + github.com/prometheus/common v0.37.0 // indirect + github.com/prometheus/procfs v0.8.0 // indirect github.com/spf13/pflag v1.0.5 // indirect github.com/ugorji/go/codec v1.2.7 // indirect github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f // indirect github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect - go.uber.org/atomic v1.7.0 // indirect + go.uber.org/atomic v1.10.0 // indirect golang.org/x/crypto v0.0.0-20220722155217-630584e8d5aa // indirect golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4 // indirect - golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8 // indirect + golang.org/x/oauth2 v0.0.0-20220223155221-ee480838109b // indirect golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f // indirect golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect golang.org/x/text v0.3.7 // indirect golang.org/x/time v0.0.0-20220210224613-90d013bbcef8 // indirect golang.org/x/tools v0.1.11 // indirect - golang.org/x/xerrors v0.0.0-20220609144429-65e65417b02f // indirect google.golang.org/appengine v1.6.7 // indirect - google.golang.org/protobuf v1.28.0 // indirect + google.golang.org/protobuf v1.28.1 // indirect gopkg.in/inf.v0 v0.9.1 // indirect gopkg.in/yaml.v3 v3.0.1 // indirect k8s.io/gengo v0.0.0-20220613173612-397b4ae3bce7 // indirect diff --git a/go.sum b/go.sum index a29610c4..e1b6b625 100644 --- a/go.sum +++ b/go.sum @@ -153,9 +153,11 @@ github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200222043503-6f7a984d4dc4/go.mod h1:tQ2 github.com/go-kit/kit v0.8.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as= github.com/go-kit/kit v0.9.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as= github.com/go-kit/log v0.1.0/go.mod h1:zbhenjAZHb184qTLMA9ZjW7ThYL0H2mk7Q6pNt4vbaY= +github.com/go-kit/log v0.2.0/go.mod h1:NwTd00d/i8cPZ3xOwwiv2PO5MOcx78fFErGNcVmBjv0= github.com/go-logfmt/logfmt v0.3.0/go.mod h1:Qt1PoO58o5twSAckw1HlFXLmHsOX5/0LbT9GBnD5lWE= github.com/go-logfmt/logfmt v0.4.0/go.mod h1:3RMwSq7FuexP4Kalkev3ejPJsZTpXXBr9+V4qmtdjCk= github.com/go-logfmt/logfmt v0.5.0/go.mod h1:wCYkCAKZfumFQihp8CzCvQ3paCTfi41vtzG1KdI/P7A= +github.com/go-logfmt/logfmt v0.5.1/go.mod h1:WYhtIu8zTZfxdn5+rREduYbwxfcBr/Vr6KEVveWlfTs= github.com/go-logr/logr v0.1.0/go.mod h1:ixOQHD9gLJUVQQ2ZOR7zLEifBX6tGkNJF4QyIY7sIas=
[GitHub] [apisix-ingress-controller] gxthrj closed issue #1129: test: Remove `time.Sleep` and replace with wait.poll
gxthrj closed issue #1129: test: Remove `time.Sleep` and replace with wait.poll URL: https://github.com/apache/apisix-ingress-controller/issues/1129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj closed pull request #1240: chore(deps): bump go.uber.org/zap from 1.21.0 to 1.22.0
gxthrj closed pull request #1240: chore(deps): bump go.uber.org/zap from 1.21.0 to 1.22.0 URL: https://github.com/apache/apisix-ingress-controller/pull/1240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #610: proposal: New architecture of Apache APISIX Ingress controller
tao12345666333 commented on issue #610: URL: https://github.com/apache/apisix-ingress-controller/issues/610#issuecomment-1214843279 APISIX standalone mode will fully update the configuration, which will have some impact on health checks or caching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lunarwhite commented on a diff in pull request #7667: docs(plugin): refactor proxy-mirror.md
lunarwhite commented on code in PR #7667: URL: https://github.com/apache/apisix/pull/7667#discussion_r945576853 ## docs/zh/latest/plugins/proxy-mirror.md: ## @@ -59,29 +67,60 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 }' ``` -测试： +### 指定 mirror 子请求的超时时间 + +我们可以在 `conf/config.yaml` 的 `plugin_attr` 中指定子请求的超时时间。这在连接复用的场景下 mirror 流量到一个非常慢的后端服务时非常有用。 + +| 名称 | 类型 | 默认值 | 描述 | +| --- | --- | --- | --- | +| connect | string | 60s | 镜像请求到上游的连接超时时间。 | +| read | string | 60s | 镜像请求到上游的读超时时间。 | +| send | string | 60s | 镜像请求到上游的写超时时间。 | + +```yaml +plugin_attr: + proxy-mirror: +timeout: + connect: 2000ms + read: 2000ms + send: 2000ms +``` + +## 测试插件 + +:::tip 提示 + +因为指定的镜像地址是 `127.0.0.1:9797`，所以验证此插件是否正常工作需要在端口为 `9797` 的服务上确认。 + +我们可以通过 `python` 启动一个简单的 server： Review Comment: What's your suggestion? Shall we remove this step? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lunarwhite commented on a diff in pull request #7667: docs(plugin): refactor proxy-mirror.md
lunarwhite commented on code in PR #7667: URL: https://github.com/apache/apisix/pull/7667#discussion_r945575372 ## docs/zh/latest/plugins/proxy-mirror.md: ## @@ -59,29 +67,60 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 }' ``` -测试： +### 指定 mirror 子请求的超时时间 + +我们可以在 `conf/config.yaml` 的 `plugin_attr` 中指定子请求的超时时间。这在连接复用的场景下 mirror 流量到一个非常慢的后端服务时非常有用。 Review Comment: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kumaxl commented on issue #7678: help request: how to manage ip whitelist used on many routes? Is there any way to group requests to different consumers just by ip?
kumaxl commented on issue #7678: URL: https://github.com/apache/apisix/issues/7678#issuecomment-1214830284 > @kumaxl Try to use `plugin_config` object. Thanks for your reply. Do you mean to configue a common iplimit plugin_config, and apply it on each route? It seems dashboard do not support common plugin configuration. we can only use apiadmin to manage it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] whioue opened a new issue, #7684: bug: After plugin is closed, there are still some requests to execute the plugin
whioue opened a new issue, #7684: URL: https://github.com/apache/apisix/issues/7684 ### Current Behavior 当我开启自定义插件使用过一段时间后，关闭此插件，偶现部分请求仍然会执行此插件 ### Expected Behavior 预期在关闭插件后不会所有请求都不会再执行此插件 ### Error Logs 暂无 ### Steps to Reproduce 1.编辑自定义插件，并能正常运行。 2.配置一条路由，并在路由所在的服务中开启此插件。 3.并发请求此路由，所有请求会执行此插件，并能生效。 4.关闭此插件。 5.请求此路由发现偶现个别请求仍然会执行插件功能。 当我特意去复现时我不能做到百分百复现，但此问题确实存在。考虑到是因为openresty中部分worker里的连接句柄没有得到释放导致？不知道大佬有没有遇到相关问题，以及解决的指导建议呢？ ### Environment - APISIX version (run `apisix version`): apisix v2.0 - Operating system (run `uname -a`): centos7 - OpenResty / Nginx version (run `openresty -V` or `nginx -V`): 1.17.8.2 - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`): - APISIX Dashboard version, if relevant: - Plugin runner version, for issues related to plugin runners: - LuaRocks version, for installation issues (run `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass opened a new pull request, #7683: change(authz-keycloak): remove deprecated audience
tzssangglass opened a new pull request, #7683: URL: https://github.com/apache/apisix/pull/7683 ### Description Fixes #7482 ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #610: proposal: New architecture of Apache APISIX Ingress controller
tokers commented on issue #610: URL: https://github.com/apache/apisix-ingress-controller/issues/610#issuecomment-1214822401 What about using an ETCD adapter to let the custom component support ETCD APIs so that we can avoid any changes for APISIX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #610: proposal: New architecture of Apache APISIX Ingress controller
tao12345666333 commented on issue #610: URL: https://github.com/apache/apisix-ingress-controller/issues/610#issuecomment-1214820288 In the simplest terms, to make it easier to scale and manage, etcd must be removed. So there is a high probability that we will no longer use the Admin API I guess it will be ``` APISIX Ingress (gRPC server) —> gRPC client ｜ -> APISIX standalone mode ``` APISIX may become a child process managed by another component we implement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #7661: bug: [Plugin] OpenID-Connect had an issue or not supported when using "use_jwks=true" and use "discovery" as the JWKS endpoint
tokers commented on issue #7661: URL: https://github.com/apache/apisix/issues/7661#issuecomment-1214816593 The error reason says: > WWW-Authenticate="Bearer realm="apisix", error="invalid_token", error_description="opts.discovery.jwks_uri is not present or not a string" Have you ever checked the discovery configuration? Especially for the `jwks_uri`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1235: request help: Does apisixroute v2beta3 support multiple plugins?
tao12345666333 commented on issue #1235: URL: https://github.com/apache/apisix-ingress-controller/issues/1235#issuecomment-1214814788 thanks for your reply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jackkkkklee commented on pull request #7634: feat: add openfunction plugin
jacklee commented on PR #7634: URL: https://github.com/apache/apisix/pull/7634#issuecomment-1214813513 @tokers Could you please re-run "CI / build (ubuntu-18.04, linux_openresty_1_19, t/plugin) (pull_request) " ? Timeout happened during building function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
