[GitHub] [apisix] 15349185792 commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
15349185792 commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373313417 @An-DJ 非常感谢你的耐心回答！我只是猜测可能会有这类使用场景。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch release/2.15 updated: ci: use fixed os version of ubuntu (#8438) (#8614)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch release/2.15 in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/release/2.15 by this push: new d8f17609b ci: use fixed os version of ubuntu (#8438) (#8614) d8f17609b is described below commit d8f17609bb161b0924516d7fb688304b96be6aa8 Author: 罗泽轩 AuthorDate: Fri Jan 6 15:56:52 2023 +0800 ci: use fixed os version of ubuntu (#8438) (#8614) Co-authored-by: tzssangglass --- .github/workflows/centos7-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/centos7-ci.yml b/.github/workflows/centos7-ci.yml index b308c79fb..920e17522 100644 --- a/.github/workflows/centos7-ci.yml +++ b/.github/workflows/centos7-ci.yml @@ -22,7 +22,7 @@ permissions: jobs: test_apisix: name: run ci on centos7 -runs-on: ubuntu-latest +runs-on: ubuntu-20.04 timeout-minutes: 90 strategy: fail-fast: false
[GitHub] [apisix] spacewander merged pull request #8614: ci: use fixed os version of ubuntu (#8438)
spacewander merged PR #8614: URL: https://github.com/apache/apisix/pull/8614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8275: refactor: remove if statement in nginx.conf
monkeyDluffy6017 commented on code in PR #8275: URL: https://github.com/apache/apisix/pull/8275#discussion_r1063212619 ## apisix/init.lua: ## @@ -267,6 +267,11 @@ local function set_upstream_headers(api_ctx, picked_server) api_ctx.var.var_x_forwarded_host = x_forwarded_host end +local x_forwarded_for = api_ctx.var.proxy_add_x_forwarded_for +if x_forwarded_for then +api_ctx.var.var_x_forwarded_for = x_forwarded_for Review Comment: So we don't need `var_x_forwarded_for`? But `var_x_forwarded_proto` , `var_x_forwarded_host`, `var_x_forwarded_port` are still needed, because they have default value, right ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8275: refactor: remove if statement in nginx.conf
monkeyDluffy6017 commented on code in PR #8275: URL: https://github.com/apache/apisix/pull/8275#discussion_r1063212619 ## apisix/init.lua: ## @@ -267,6 +267,11 @@ local function set_upstream_headers(api_ctx, picked_server) api_ctx.var.var_x_forwarded_host = x_forwarded_host end +local x_forwarded_for = api_ctx.var.proxy_add_x_forwarded_for +if x_forwarded_for then +api_ctx.var.var_x_forwarded_for = x_forwarded_for Review Comment: so we don't need `var_x_forwarded_for`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ronething commented on issue #8626: help request: how to use fixed values as response content
ronething commented on issue #8626:
URL: https://github.com/apache/apisix/issues/8626#issuecomment-1373279997
Maybe you can try `serverless-post-function` plugin, refer:
https://apisix.apache.org/docs/apisix/plugins/serverless/
```
$ curl http://127.0.0.1:9180/apisix/admin/routes/1 \
-H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/hello",
"plugins": {
"serverless-post-function": {
"phase": "rewrite",
"functions" : ["return function(conf, ctx) return 200, \"Hello,
World!\" end"]
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:80": 1
}
}
}'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] bobbyz007 closed issue #399: docker start error: apisix container is always in restarting status
bobbyz007 closed issue #399: docker start error: apisix container is always in restarting status URL: https://github.com/apache/apisix-docker/issues/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #8609: fix: use previous way to disable plugins
spacewander merged PR #8609: URL: https://github.com/apache/apisix/pull/8609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch release/2.15 updated: fix: use previous way to disable plugins (#8609)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch release/2.15
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/release/2.15 by this push:
new e1c3008c9 fix: use previous way to disable plugins (#8609)
e1c3008c9 is described below
commit e1c3008c9eb7a336390d436ef9ffae6628f498d6
Author: 罗泽轩
AuthorDate: Fri Jan 6 15:39:51 2023 +0800
fix: use previous way to disable plugins (#8609)
Fixes https://github.com/apache/apisix/issues/8603
---
apisix/plugin.lua | 4 +++
t/plugin/plugin2.t | 82 ++
2 files changed, 86 insertions(+)
diff --git a/apisix/plugin.lua b/apisix/plugin.lua
index 7408786cb..0f7845fe0 100644
--- a/apisix/plugin.lua
+++ b/apisix/plugin.lua
@@ -81,6 +81,10 @@ local function check_disable(plugin_conf)
return nil
end
+if plugin_conf.disable then
+return plugin_conf.disable
+end
+
if not plugin_conf._meta then
return nil
end
diff --git a/t/plugin/plugin2.t b/t/plugin/plugin2.t
new file mode 100644
index 0..71a3593a8
--- /dev/null
+++ b/t/plugin/plugin2.t
@@ -0,0 +1,82 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+$block->set_value("no_error_log", "[error]");
+
+if (!defined $block->request) {
+$block->set_value("request", "GET /t");
+}
+
+$block;
+});
+
+no_long_string();
+no_root_location();
+log_level("info");
+run_tests;
+
+__DATA__
+
+=== TEST 1: disable plugin in the previous way
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[[{
+"plugins": {
+"limit-count": {
+"count": 2,
+"time_window": 60,
+"rejected_code": 503,
+"key": "remote_addr",
+"disable": true
+}
+},
+"uri": "/server_port",
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+}
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- response_body
+passed
+
+
+
+=== TEST 2: hit routes
+--- request
+GET /server_port
+--- raw_response_headers_unlike eval
+qr/X-RateLimit-Limit/
+--- response_body eval
+qr/1980/
[GitHub] [apisix-dashboard] bzp2010 closed issue #2699: The download rpm apisix-dashboard-2.15.0-0.el7.x86_64.rpm package address is invalid
bzp2010 closed issue #2699: The download rpm apisix-dashboard-2.15.0-0.el7.x86_64.rpm package address is invalid URL: https://github.com/apache/apisix-dashboard/issues/2699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #2699: The download rpm apisix-dashboard-2.15.0-0.el7.x86_64.rpm package address is invalid
bzp2010 commented on issue #2699: URL: https://github.com/apache/apisix-dashboard/issues/2699#issuecomment-1373276196 Fixed https://github.com/apache/apisix-dashboard/releases/tag/v2.15.0 The missing resources have been uploaded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] An-DJ commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
An-DJ commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373257205 Now the `ext-plugin` can configure only one external plugin-runner. @15349185792 Could you plz explain why you need to use multiple plugin-runners? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #8612: fix: correct inspect plugin default hooks file path and add hook remove logs
spacewander merged PR #8612: URL: https://github.com/apache/apisix/pull/8612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix: correct inspect plugin default hooks file path and add hook remove logs (#8612)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 1609ce699 fix: correct inspect plugin default hooks file path and add
hook remove logs (#8612)
1609ce699 is described below
commit 1609ce6990b6d93262ea80efb29836eab2109c0e
Author: jinhua luo
AuthorDate: Fri Jan 6 15:22:04 2023 +0800
fix: correct inspect plugin default hooks file path and add hook remove
logs (#8612)
---
apisix/inspect/dbg.lua | 9 +
apisix/inspect/init.lua | 2 +-
t/plugin/inspect.t | 30 ++
3 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/apisix/inspect/dbg.lua b/apisix/inspect/dbg.lua
index a8a619a26..7f4e7b114 100644
--- a/apisix/inspect/dbg.lua
+++ b/apisix/inspect/dbg.lua
@@ -44,6 +44,7 @@ local function hook(_, arg)
local key = finfo.source .. "#" .. arg
local hooks2 = {}
+local removed_hooks = {}
for _, hook in ipairs(hooks) do
if key:sub(-#hook.key) == hook.key then
local filter_func = hook.filter_func
@@ -74,9 +75,12 @@ local function hook(_, arg)
local r1, r2_or_err = pcall(filter_func, info)
if not r1 then
core.log.error("inspect: pcall filter_func:", r2_or_err)
+table_insert(removed_hooks, hook)
elseif r2_or_err == false then
-- if filter_func returns false, keep the hook
table_insert(hooks2, hook)
+else
+table_insert(removed_hooks, hook)
end
else
-- key not match, keep the hook
@@ -84,10 +88,15 @@ local function hook(_, arg)
end
end
+for _, hook in ipairs(removed_hooks) do
+core.log.warn("inspect: remove hook: ", hook.key)
+end
+
-- disable debug mode if all hooks done
if #hooks2 ~= #hooks then
hooks = hooks2
if #hooks == 0 then
+core.log.warn("inspect: all hooks removed")
debug.sethook()
end
end
diff --git a/apisix/inspect/init.lua b/apisix/inspect/init.lua
index 649532d1a..7014b613a 100644
--- a/apisix/inspect/init.lua
+++ b/apisix/inspect/init.lua
@@ -107,7 +107,7 @@ end
function _M.init(delay, file)
if not running then
-file = file or "/var/run/apisix_inspect_hooks.lua"
+file = file or "/usr/local/apisix/plugin_inspect_hooks.lua"
delay = delay or 3
setup_hooks(file)
diff --git a/t/plugin/inspect.t b/t/plugin/inspect.t
index e938431b4..0bbbfd7ff 100644
--- a/t/plugin/inspect.t
+++ b/t/plugin/inspect.t
@@ -497,3 +497,33 @@ upvar2=yes
assert(t4-t8 < t4*0.8, "hot2 jit recover")
}
}
+
+
+
+=== TEST 13: remove hook log
+--- config
+location /t {
+content_by_lua_block {
+local code = set_test_route("run1")
+if code >= 300 then
+ngx.status = code
+return
+end
+
+write_hooks([[
+local dbg = require "apisix.inspect.dbg"
+dbg.set_hook("t/lib/test_inspect.lua", 27, nil, function(info)
+return true
+end)
+]])
+
+ngx.sleep(1.5)
+
+do_request()
+
+os.remove("/tmp/apisix_inspect_hooks.lua")
+}
+}
+--- error_log
+inspect: remove hook: t/lib/test_inspect.lua#27
+inspect: all hooks removed
[GitHub] [apisix] spacewander commented on a diff in pull request #8275: refactor: remove if statement in nginx.conf
spacewander commented on code in PR #8275: URL: https://github.com/apache/apisix/pull/8275#discussion_r1063198605 ## apisix/init.lua: ## @@ -267,6 +267,11 @@ local function set_upstream_headers(api_ctx, picked_server) api_ctx.var.var_x_forwarded_host = x_forwarded_host end +local x_forwarded_for = api_ctx.var.proxy_add_x_forwarded_for +if x_forwarded_for then +api_ctx.var.var_x_forwarded_for = x_forwarded_for Review Comment: Maybe we can set `proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for` directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 15349185792 commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
15349185792 commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373243186 @An-DJ 是的 不好意思，我刚开始描述错了，我实际问的是`plugin-runner` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8601: feat(secret): add ci and doc for some auth plugins
spacewander commented on code in PR #8601:
URL: https://github.com/apache/apisix/pull/8601#discussion_r1063195906
##
docs/zh/latest/plugins/jwt-auth.md:
##
@@ -42,9 +42,9 @@ Consumer 端：
| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述
|
| - | --- | - | --- | --- |
|
| key | string | 是| | |
Consumer 的 `access_key` 必须是唯一的。如果不同 Consumer 使用了相同的 `access_key` ，将会出现请求匹配异常。 |
-| secret| string | 否| | |
加密秘钥。如果未指定，后台将会自动生成。
|
-| public_key| string | 否| | | RSA
或 ECDSA 公钥， `algorithm` 属性选择 `RS256` 或 `ES256` 算法时必选。
|
-| private_key | string | 否| | | RSA
或 ECDSA 私钥， `algorithm` 属性选择 `RS256` 或 `ES256` 算法时必选。
|
+| secret| string | 否| | |
加密秘钥。如果未指定，后台将会自动生。成。该字段支持使用 [APISIX Secret](../terminology/secret.md) 资源，将值保存在
Secret Manager 中。 |
Review Comment:
Typo
##
t/plugin/hmac-auth4.t:
##
@@ -0,0 +1,172 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_shuffle();
+no_root_location();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if (!$block->request) {
+$block->set_value("request", "GET /t");
+}
+
+if (!$block->no_error_log && !$block->error_log) {
+$block->set_value("no_error_log", "[error]\n[alert]");
+}
+});
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set hmac-auth conf: secret_key uses secret ref
+--- request
+GET /t
Review Comment:
We already specified it at the top?
##
t/plugin/hmac-auth4.t:
##
@@ -0,0 +1,172 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_shuffle();
+no_root_location();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if (!$block->request) {
+$block->set_value("request", "GET /t");
+}
+
+if (!$block->no_error_log && !$block->error_log) {
+$block->set_value("no_error_log", "[error]\n[alert]");
+}
+});
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set hmac-auth conf: secret_key uses secret ref
+--- request
+GET /t
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+-- put secret vault config
+local code, body = t('/apisix/admin/secrets/vault/test1',
+ngx.HTTP_PUT,
+[[{
+"uri": "http://127.0.0.1:8200;,
+"prefix" : "kv/apisix",
+"token" : "root"
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+return ngx.say(body)
+end
+
+-- change consumer with secrets ref: vault
+code, body = t('/apisix/admin/consumers',
+ngx.HTTP_PUT,
+
[GitHub] [apisix] An-DJ commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
An-DJ commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373238255 > 下面的图是配置一个java插件，那如果配置多个java插件呢？  This is how to configure a `plugin-runner`, not a external `plugin`. Do you mean how to configure multiple `plugin-runners`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 15349185792 commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
15349185792 commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373233631 下面的图是配置一个java插件，那如果配置多个java插件呢？  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #8587: fix: issue 8511 The format of response body that returned by plugin should match Content-Type
spacewander commented on PR #8587: URL: https://github.com/apache/apisix/pull/8587#issuecomment-1373219611 > > > @spacewander I saw the CI failed due to this line, 121 : `local accept_header = core_request.header(ctx, "Accept")` Because `ctx` is 'not defined' Wich is true, but it works, i am a beginner in .lua so maybe there is something i am missing. > > > To have the correct syntax should we add the `ctx `parameter to the method resp_exit ? > > > > > > I think a bit it seems that there is no better way to do it. It's OK to add the parameter. > > @spacewander , so i checked quickly, i see at least 93 call to `response.exit(...)` SO before doing the update i want to be sure of what need to be done. > > As today we use this function with this definition : `function resp_exit(code, ...)` > > i must update it to : `function resp_exit(ctx, code, ...)` > > And then it means check all the usage to add the parameter ? For example `return core.response.exit(502)` will become `return core.response.exit(ctx, 502)` Yes, you are right -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] An-DJ commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
An-DJ commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373216119 > @An-DJ 我在官网看 是需要把自定义java插件在config,yaml中进行配置的  ，不然apisix如何发现java插件呢？ @15349185792 The `plugin runner` handles the RPC call from APISIX, creates a fake request at its side, runs external `plugins` and returns the result back to APISIX. So if you have implemented multiple external plugins in java-plugin-runner, you only need to configure that runner into the config.yaml, just like you mentioned above. Actually the cmd in `ext-plugins` is the real command of how to start this runner. Ref: https://apisix.apache.org/docs/apisix/external-plugin/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan closed issue #873: Occasionally some unexpected logs appear
AlinsRan closed issue #873: Occasionally some unexpected logs appear URL: https://github.com/apache/apisix-ingress-controller/issues/873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on issue #873: Occasionally some unexpected logs appear
AlinsRan commented on issue #873: URL: https://github.com/apache/apisix-ingress-controller/issues/873#issuecomment-1373205485 This is because ApisixConsumer is not register in scheme. This problem has been fixed in 1.4.1 * https://github.com/apache/apisix-ingress-controller/pull/833 I will close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] chenyyyang commented on issue #8626: help request: how to use fixed values as response content
chenyyyang commented on issue #8626: URL: https://github.com/apache/apisix/issues/8626#issuecomment-1373204020 @ronething thank you for your response. The pic is generated via asking ChatGPT from OpenAI's website... Is there another way due to the priority of response-write (899) is much bigger than my self-devloped plugin? Since i can not change the priority. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ronething commented on issue #8626: help request: how to use fixed values as response content
ronething commented on issue #8626:
URL: https://github.com/apache/apisix/issues/8626#issuecomment-1373198081
@chenyyyang Hi, where is your pic come from? And if you want to return
fixed_value, you can use `response-write` plugin.
refer: https://apisix.apache.org/docs/apisix/plugins/response-rewrite/
```
curl http://127.0.0.1:9180/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"methods": ["GET"],
"uri": "/hello",
"plugins": {
"response-rewrite": {
"body": "Hello, World!"
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:80": 1
}
}
}'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] alptugay commented on a diff in pull request #8620: fix: Compression in log-rotate plugin exceeds the default timeout of shell.run
alptugay commented on code in PR #8620: URL: https://github.com/apache/apisix/pull/8620#discussion_r1063153128 ## apisix/plugins/log-rotate.lua: ## @@ -277,6 +277,7 @@ local function rotate() max_size = attr.max_size or max_size enable_compression = attr.enable_compression or enable_compression end +local timeout = interval * 100 -- Timeout for compression is interval in milliseconds Review Comment: I don't agree that timeout should be a user defined parameter. Because, setting a timeout greater than interval may cause undefined behaviour (eg. second rotation starts but first compression is still running), and setting the value too low also causes the mentioned undesired behaviour (so doesn't fix the issue in the first place). So, this value should be automatically set based on interval and shoud not be user defined imho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on issue #8622: help request: can not get response body in the body_filter on my custom plugin
monkeyDluffy6017 commented on issue #8622: URL: https://github.com/apache/apisix/issues/8622#issuecomment-1373189171 Do you have any other plugins use `core.response.hold_body_chunk` before your custom plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ronething commented on a diff in pull request #8593: feat: stream subsystem support dns service discovery
ronething commented on code in PR #8593:
URL: https://github.com/apache/apisix/pull/8593#discussion_r1063150054
##
t/discovery/stream/dns.t:
##
@@ -0,0 +1,431 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if (!$block->yaml_config) {
+my $yaml_config = <<_EOC_;
+apisix:
+node_listen: 1984
+enable_admin: false
+deployment:
+role: data_plane
+role_data_plane:
+config_provider: yaml
+discovery:# service discovery center
+dns:
+servers:
+- "127.0.0.1:1053"
+_EOC_
+
+$block->set_value("yaml_config", $yaml_config);
+}
+
+if ($block->apisix_yaml) {
+my $upstream = <<_EOC_;
+stream_routes:
+ - id: 1
+server_port: 1985
+upstream_id: 1
+#END
+_EOC_
+
+$block->set_value("apisix_yaml", $block->apisix_yaml . $upstream);
+}
+
+if (!$block->stream_request) {
+# GET /hello HTTP/1.0\r\nHost: 127.0.0.1:1985\r\n\r\n
+$block->set_value("stream_request",
"\x47\x45\x54\x20\x2f\x68\x65\x6c\x6c\x6f\x20\x48\x54\x54\x50\x2f\x31\x2e\x30\x0d\x0a\x48\x6f\x73\x74\x3a\x20\x31\x32\x37\x2e\x30\x2e\x30\x2e\x31\x3a\x31\x39\x38\x35\x0d\x0a\x0d\x0a");
+}
+
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: default port to 53
+--- log_level: debug
+--- yaml_config
+apisix:
+node_listen: 1984
+enable_admin: false
+deployment:
+role: data_plane
+role_data_plane:
+config_provider: yaml
+discovery:# service discovery center
+dns:
+servers:
+- "127.0.0.1"
+--- apisix_yaml
+upstreams:
+- service_name: sd.test.local
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- error_log
+127.0.0.1:53
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] ronething commented on a diff in pull request #8593: feat: stream subsystem support dns service discovery
ronething commented on code in PR #8593:
URL: https://github.com/apache/apisix/pull/8593#discussion_r1063149797
##
t/discovery/stream/dns.t:
##
@@ -0,0 +1,431 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if (!$block->yaml_config) {
+my $yaml_config = <<_EOC_;
+apisix:
+node_listen: 1984
+enable_admin: false
+deployment:
+role: data_plane
+role_data_plane:
+config_provider: yaml
+discovery:# service discovery center
+dns:
+servers:
+- "127.0.0.1:1053"
+_EOC_
+
+$block->set_value("yaml_config", $yaml_config);
+}
+
+if ($block->apisix_yaml) {
+my $upstream = <<_EOC_;
+stream_routes:
+ - id: 1
+server_port: 1985
+upstream_id: 1
+#END
+_EOC_
+
+$block->set_value("apisix_yaml", $block->apisix_yaml . $upstream);
+}
+
+if (!$block->stream_request) {
+# GET /hello HTTP/1.0\r\nHost: 127.0.0.1:1985\r\n\r\n
+$block->set_value("stream_request",
"\x47\x45\x54\x20\x2f\x68\x65\x6c\x6c\x6f\x20\x48\x54\x54\x50\x2f\x31\x2e\x30\x0d\x0a\x48\x6f\x73\x74\x3a\x20\x31\x32\x37\x2e\x30\x2e\x30\x2e\x31\x3a\x31\x39\x38\x35\x0d\x0a\x0d\x0a");
+}
+
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: default port to 53
+--- log_level: debug
+--- yaml_config
+apisix:
+node_listen: 1984
+enable_admin: false
+deployment:
+role: data_plane
+role_data_plane:
+config_provider: yaml
+discovery:# service discovery center
+dns:
+servers:
+- "127.0.0.1"
+--- apisix_yaml
+upstreams:
+- service_name: sd.test.local
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- error_log
+127.0.0.1:53
+
+
+
+=== TEST 2: A
+--- apisix_yaml
+upstreams:
+- service_name: "sd.test.local:1980"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- grep_error_log eval
+qr/upstream nodes: \{[^}]+\}/
+--- grep_error_log_out eval
+qr/upstream nodes:
\{("127.0.0.1:1980":1,"127.0.0.2:1980":1|"127.0.0.2:1980":1,"127.0.0.1:1980":1)\}/
+--- stream_response_like
+hello world
+
+
+
+=== TEST 3:
+--- listen_ipv6
+--- apisix_yaml
+upstreams:
+- service_name: "ipv6.sd.test.local:1980"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- stream_response_like
+hello world
+--- grep_error_log eval
+qr/proxy request to \S+/
+--- grep_error_log_out
+proxy request to [0:0:0:0:0:0:0:1]:1980
+
+
+
+=== TEST 4: prefer A to
+--- listen_ipv6
+--- apisix_yaml
+upstreams:
+- service_name: "mix.sd.test.local:1980"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- stream_response_like
+hello world
+--- grep_error_log eval
+qr/proxy request to \S+/
+--- grep_error_log_out
+proxy request to 127.0.0.1:1980
+
+
+
+=== TEST 5: no /etc/hosts
+--- apisix_yaml
+upstreams:
+- service_name: test.com
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- error_log
+failed to query the DNS server
+
+
+
+=== TEST 6: no /etc/resolv.conf
+--- yaml_config
+apisix:
+node_listen: 1984
+enable_admin: false
+enable_resolv_search_option: false
+deployment:
+role: data_plane
+role_data_plane:
+config_provider: yaml
+discovery:# service discovery center
+dns:
+servers:
+- "127.0.0.1:1053"
+--- apisix_yaml
+upstreams:
+- service_name: apisix
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- error_log
+failed to query the DNS server
+
+
+
+=== TEST 7: SRV
+--- apisix_yaml
+upstreams:
+- service_name: "srv.test.local"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- grep_error_log eval
+qr/upstream nodes: \{[^}]+\}/
+--- grep_error_log_out eval
+qr/upstream nodes:
\{("127.0.0.1:1980":60,"127.0.0.2:1980":20|"127.0.0.2:1980":20,"127.0.0.1:1980":60)\}/
+--- stream_response_like
+hello world
+
+
+
+=== TEST 8: SRV (RFC 2782 style)
+--- apisix_yaml
+upstreams:
+- service_name: "_sip._tcp.srv.test.local"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+---
[GitHub] [apisix] monkeyDluffy6017 commented on issue #8621: 希望能支持从请求体中进行条件过滤来进行灰度转发
monkeyDluffy6017 commented on issue #8621: URL: https://github.com/apache/apisix/issues/8621#issuecomment-1373180246 Maybe you can consider use `filter_func ` in `route`, get request body in `filter_func` and judge if exist `useId`. https://user-images.githubusercontent.com/9354193/210939884-1f94dcb2-a099-4c28-9831-232d4723121c.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] chenyyyang opened a new issue, #8626: help request: how to use fixed values as response content
chenyyyang opened a new issue, #8626: URL: https://github.com/apache/apisix/issues/8626 ### Description APISIX_VERSION=2.11.0 the method from the below picture seems not work...Could you give more advise  ### Environment - APISIX version (run `apisix version`): - Operating system (run `uname -a`): - OpenResty / Nginx version (run `openresty -V` or `nginx -V`): - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`): - APISIX Dashboard version, if relevant: - Plugin runner version, for issues related to plugin runners: - LuaRocks version, for installation issues (run `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 15349185792 commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
15349185792 commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373167073 @An-DJ 我在官网看 是需要把自定义java插件在config,yaml中进行配置的  ，不然apisix如何发现java插件呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Martinprobu commented on issue #8617: bug: One of the three etcd nodes is broken (once every two weeks)
Martinprobu commented on issue #8617: URL: https://github.com/apache/apisix/issues/8617#issuecomment-1373161357 this is apisix logs [apisix_20230106A_query_data.csv](https://github.com/apache/apisix/files/10357504/apisix_20230106A_query_data.csv) (24hours). this is etcd logs (124 houres) [etcd_20230106A_query_data.csv](https://github.com/apache/apisix/files/10357512/etcd_20230106A_query_data.csv) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Martinprobu commented on issue #8617: bug: One of the three etcd nodes is broken (once every two weeks)
Martinprobu commented on issue #8617: URL: https://github.com/apache/apisix/issues/8617#issuecomment-1373157064 k8s version : 1.24.3 in azure aks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch dependabot/github_actions/actions/setup-node-3.6.0 created (now c2bb3696a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-node-3.6.0 in repository https://gitbox.apache.org/repos/asf/apisix.git at c2bb3696a chore(deps): bump actions/setup-node from 3.5.1 to 3.6.0 No new revisions were added by this update.
[GitHub] [apisix] dependabot[bot] opened a new pull request, #8625: chore(deps): bump actions/setup-node from 3.5.1 to 3.6.0
dependabot[bot] opened a new pull request, #8625: URL: https://github.com/apache/apisix/pull/8625 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.5.1 to 3.6.0. Release notes Sourced from https://github.com/actions/setup-node/releases;>actions/setup-node's releases. Add Support for Nightly, Canary and RC builds for Node.js In scope of this release we added support to download nightly, rc (https://github-redirect.dependabot.com/actions/setup-node/pull/611;>actions/setup-node#611) and canary (https://github-redirect.dependabot.com/actions/setup-node/pull/619;>actions/setup-node#619) Node.js distributions. For nightly versions: jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test For canary versions: jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test For rc versions: jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ... (truncated) Commits https://github.com/actions/setup-node/commit/64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c;>64ed1c7 Add support for v8-canary, nightly and rc (https://github-redirect.dependabot.com/actions/setup-node/issues/655;>#655) https://github.com/actions/setup-node/commit/92a57f4a935efe978b0a4d8e5b19fb42658c7ef7;>92a57f4 Merge pull request https://github-redirect.dependabot.com/actions/setup-node/issues/650;>#650 from actions/update-code-owners https://github.com/actions/setup-node/commit/99e61d697ac985dd26c630fb5e8f9476131abbdb;>99e61d6 Update CODEOWNERS https://github.com/actions/setup-node/commit/3e8819f8f297df8b29fc3e383683a29be2bf129a;>3e8819f Merge pull request https://github-redirect.dependabot.com/actions/setup-node/issues/649;>#649 from actions/update-codeowners https://github.com/actions/setup-node/commit/8cd2fb28b8f13cfe537ae737100b155acc87e562;>8cd2fb2 Update CODEOWNERS https://github.com/actions/setup-node/commit/c406543918243bdbe7b25799f6a378e753fed484;>c406543 Merge pull request https://github-redirect.dependabot.com/actions/setup-node/issues/647;>#647 from akv-platform/apply-reusable-workflows https://github.com/actions/setup-node/commit/92a07fe46640c3ab57d394b7b01308a008a3231d;>92a07fe Fix review points https://github.com/actions/setup-node/commit/217387cf3e2597f3eed81c19f662eeddbdd397de;>217387c Update action to use reusable-workflows repo https://github.com/actions/setup-node/commit/2db36638708d0ad3215bcdff9f8a61d64021ae68;>2db3663 Merge branch 'main' of https://github.com/akv-platform/setup-node;>https://github.com/akv-platform/setup-node into apply-... https://github.com/actions/setup-node/commit/bbe2ac79a1347190c27c8a7ca53301a26c066415;>bbe2ac7 Fix typo in README (https://github-redirect.dependabot.com/actions/setup-node/issues/646;>#646) Additional commits viewable in https://github.com/actions/setup-node/compare/v3.5.1...v3.6.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen
[apisix] branch dependabot/github_actions/actions/checkout-3.3.0 created (now 13eff5dfd)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/checkout-3.3.0 in repository https://gitbox.apache.org/repos/asf/apisix.git at 13eff5dfd chore(deps): bump actions/checkout from 3.2.0 to 3.3.0 No new revisions were added by this update.
[GitHub] [apisix] dependabot[bot] opened a new pull request, #8624: chore(deps): bump actions/checkout from 3.2.0 to 3.3.0
dependabot[bot] opened a new pull request, #8624: URL: https://github.com/apache/apisix/pull/8624 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v3.3.0 What's Changed Implement branch list using callbacks from exec function by https://github.com/cory-miller;>@cory-miller in https://github-redirect.dependabot.com/actions/checkout/pull/1045;>actions/checkout#1045 Add in explicit reference to private checkout options by https://github.com/vanZeben;>@vanZeben in https://github-redirect.dependabot.com/actions/checkout/pull/1050;>actions/checkout#1050 Fix comment typos (that got added in https://github-redirect.dependabot.com/actions/checkout/issues/770;>#770) by https://github.com/lurch;>@lurch in https://github-redirect.dependabot.com/actions/checkout/pull/1057;>actions/checkout#1057 New Contributors https://github.com/vanZeben;>@vanZeben made their first contribution in https://github-redirect.dependabot.com/actions/checkout/pull/1050;>actions/checkout#1050 https://github.com/lurch;>@lurch made their first contribution in https://github-redirect.dependabot.com/actions/checkout/pull/1057;>actions/checkout#1057 Full Changelog: https://github.com/actions/checkout/compare/v3.2.0...v3.3.0;>https://github.com/actions/checkout/compare/v3.2.0...v3.3.0 Commits https://github.com/actions/checkout/commit/ac593985615ec2ede58e132d2e21d2b1cbd6127c;>ac59398 Fix comment typos (that got added in https://github-redirect.dependabot.com/actions/checkout/issues/770;>#770) (https://github-redirect.dependabot.com/actions/checkout/issues/1057;>#1057) https://github.com/actions/checkout/commit/3ba5ee6fac7e0e30e2ea884e236f282d3a775891;>3ba5ee6 Add in explicit reference to private checkout options (https://github-redirect.dependabot.com/actions/checkout/issues/1050;>#1050) https://github.com/actions/checkout/commit/885641592076c27bfb56c028cd5612cdad63e16d;>8856415 Implement branch list using callbacks from exec function (https://github-redirect.dependabot.com/actions/checkout/issues/1045;>#1045) See full diff in https://github.com/actions/checkout/compare/v3.2.0...v3.3.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #8617: bug: One of the three etcd nodes is broken (once every two weeks)
nic-chen commented on issue #8617: URL: https://github.com/apache/apisix/issues/8617#issuecomment-1373133608 hi, @Martinprobu Could you upload more logs? The current logs posted do not have any helpful information. By the way, what is your k8s runtime? Containerd or Docker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8275: refactor: remove if statement in nginx.conf
monkeyDluffy6017 commented on code in PR #8275: URL: https://github.com/apache/apisix/pull/8275#discussion_r1063077396 ## apisix/core/ctx.lua: ## @@ -201,6 +201,7 @@ do var_x_forwarded_proto = true, var_x_forwarded_port = true, var_x_forwarded_host = true, +var_x_forwarded_for = true, Review Comment: Done ## apisix/init.lua: ## @@ -267,6 +267,17 @@ local function set_upstream_headers(api_ctx, picked_server) api_ctx.var.var_x_forwarded_host = x_forwarded_host end +local x_forwarded_for = api_ctx.var.http_x_forwarded_for Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xuruidong opened a new pull request, #8623: docs: change the file name to 'create-ssl.py'.If 'ssl.py' is used as …
xuruidong opened a new pull request, #8623:
URL: https://github.com/apache/apisix/pull/8623
…the file name, an error occurs.AttributeError: module 'requests' has no
attribute 'put'
### Description
Change the file name to "create-ssl.py" in certificate.md.
If "ssl.py" is used as the file name, an error occurs.
```
./ssl.py .txt main.cc aa
Traceback (most recent call last):
File "./create-ssl.py", line 6, in
import requests
File "D:\Programs\Python\Python37\lib\site-packages\requests\__init__.py",
line 43, in
import urllib3
File "D:\Programs\Python\Python37\lib\site-packages\urllib3\__init__.py",
line 11, in
from . import exceptions
File
"D:\Programs\Python\Python37\lib\site-packages\urllib3\exceptions.py", line 3,
in
from .packages.six.moves.http_client import IncompleteRead as
httplib_IncompleteRead
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 670, in _load_unlocked
File "", line 583, in module_from_spec
File
"D:\Programs\Python\Python37\lib\site-packages\urllib3\packages\six.py", line
234, in create_module
return self.load_module(spec.name)
File
"D:\Programs\Python\Python37\lib\site-packages\urllib3\packages\six.py", line
209, in load_module
mod = mod._resolve()
File
"D:\Programs\Python\Python37\lib\site-packages\urllib3\packages\six.py", line
118, in _resolve
return _import_module(self.mod)
File
"D:\Programs\Python\Python37\lib\site-packages\urllib3\packages\six.py", line
87, in _import_module
__import__(name)
File "D:\Programs\Python\Python37\lib\http\client.py", line 1341, in
import ssl
File "ssl.py", line 17, in
resp = requests.put("http://127.0.0.1:9180/apisix/admin/ssls/1;, json={
AttributeError: module 'requests' has no attribute 'put'
```
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not,
please discuss on the [APISIX mailing
list](https://github.com/apache/apisix/tree/master#community) first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-website] branch dependabot/github_actions/actions/checkout-3.3.0 created (now 19640b01beb)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/checkout-3.3.0 in repository https://gitbox.apache.org/repos/asf/apisix-website.git at 19640b01beb chore(deps): bump actions/checkout from 3.1.0 to 3.3.0 No new revisions were added by this update.
[GitHub] [apisix-website] netlify[bot] commented on pull request #1466: chore(deps): bump actions/checkout from 3.1.0 to 3.3.0
netlify[bot] commented on PR #1466: URL: https://github.com/apache/apisix-website/pull/1466#issuecomment-1373114317 ### Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit | 19640b01beba7f50f4d0b87fb04449acf2842593 | | Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/63b79d4bd787310008e2e818 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] dependabot[bot] closed pull request #1445: chore(deps): bump actions/checkout from 3.1.0 to 3.2.0
dependabot[bot] closed pull request #1445: chore(deps): bump actions/checkout from 3.1.0 to 3.2.0 URL: https://github.com/apache/apisix-website/pull/1445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] dependabot[bot] commented on pull request #1445: chore(deps): bump actions/checkout from 3.1.0 to 3.2.0
dependabot[bot] commented on PR #1445: URL: https://github.com/apache/apisix-website/pull/1445#issuecomment-1373114301 Superseded by #1466. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1
netlify[bot] commented on PR #1465: URL: https://github.com/apache/apisix-website/pull/1465#issuecomment-1373114306 ### Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit | b3276443237dad6a4af8502113e6817106b104b3 | | Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/63b79d496d60f4000a502791 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch dependabot/github_actions/peaceiris/actions-gh-pages-3.9.1 created (now b3276443237)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/peaceiris/actions-gh-pages-3.9.1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git at b3276443237 chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1 No new revisions were added by this update.
[GitHub] [apisix-website] dependabot[bot] opened a new pull request, #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1
dependabot[bot] opened a new pull request, #1465: URL: https://github.com/apache/apisix-website/pull/1465 Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.0 to 3.9.1. Release notes Sourced from https://github.com/peaceiris/actions-gh-pages/releases;>peaceiris/actions-gh-pages's releases. actions-github-pages v3.9.1 update deps See https://github.com/peaceiris/actions-gh-pages/blob/v3.9.1/CHANGELOG.md;>CHANGELOG.md for more details. Changelog Sourced from https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md;>peaceiris/actions-gh-pages's changelog. https://github.com/peaceiris/actions-gh-pages/compare/v3.9.0...v3.9.1;>3.9.1 (2023-01-05) chore change cicd label name (https://github.com/peaceiris/actions-gh-pages/commit/180896524151a5634ff5815a72c59467fc27c874;>1808965) ci add Renovate config (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/802;>#802) (https://github.com/peaceiris/actions-gh-pages/commit/072d16c439270cd3a36c3e0977ccbe10f2b2bc55;>072d16c), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/802;>#802 bump actions/dependency-review-action from 2 to 3 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/799;>#799) (https://github.com/peaceiris/actions-gh-pages/commit/e3b45f27007dc55bcdd52f01e38af6f61576ec7f;>e3b45f2), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/799;>#799 bump peaceiris/actions-github-app-token from 1.1.4 to 1.1.5 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/798;>#798) (https://github.com/peaceiris/actions-gh-pages/commit/a5f971f112fd50b6dd28469f23be2618b1ea87e7;>a5f971f), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/798;>#798 bump peaceiris/actions-mdbook from 1.1.14 to 1.2.0 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/793;>#793) (https://github.com/peaceiris/actions-gh-pages/commit/9af6a68dde7720af8fd55364c2c637ca5922a879;>9af6a68), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/793;>#793 bump peaceiris/workflows from 0.17.1 to 0.17.2 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/794;>#794) (https://github.com/peaceiris/actions-gh-pages/commit/087a759f907a127fdee23c8994321ff96f7d9430;>087a759), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/794;>#794 bump peaceiris/workflows from 0.17.2 to 0.18.1 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/806;>#806) (https://github.com/peaceiris/actions-gh-pages/commit/f94667a25cd2716a8a046111457e4b17c8c28407;>f94667a), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/806;>#806 deps bump @actions/github from 5.0.1 to 5.1.1 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/785;>#785) (https://github.com/peaceiris/actions-gh-pages/commit/679dbf02f69022f8c402975fdefe41ddb31516cd;>679dbf0), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/785;>#785 bump @actions/glob from 0.2.1 to 0.3.0 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/735;>#735) (https://github.com/peaceiris/actions-gh-pages/commit/25b12e2a24490dbc96aa0d5201e94b1b4cca7fb0;>25b12e2), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/735;>#735 bump minimatch from 3.0.4 to 3.1.2 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/807;>#807) (https://github.com/peaceiris/actions-gh-pages/commit/2f463a5ad59a66a5a83e0f072f6d556898e6cc9e;>2f463a5), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/807;>#807 docs replace deprecated set-output (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/800;>#800) (https://github.com/peaceiris/actions-gh-pages/commit/7166f2caa423717780ff24040f0163cbe511c18c;>7166f2c), closes https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/800;>#800 Commits https://github.com/peaceiris/actions-gh-pages/commit/64b46b4226a4a12da2239ba3ea5aa73e3163c75b;>64b46b4 chore(release): 3.9.1 https://github.com/peaceiris/actions-gh-pages/commit/1a7c3d89ae38d38b1082f72bed9b4fdf82aaccfa;>1a7c3d8 chore(release): Add build assets https://github.com/peaceiris/actions-gh-pages/commit/679dbf02f69022f8c402975fdefe41ddb31516cd;>679dbf0 deps: bump @actions/github from 5.0.1 to 5.1.1 (https://github-redirect.dependabot.com/peaceiris/actions-gh-pages/issues/785;>#785) https://github.com/peaceiris/actions-gh-pages/commit/25b12e2a24490dbc96aa0d5201e94b1b4cca7fb0;>25b12e2 deps: bump @actions/glob from 0.2.1 to 0.3.0
[GitHub] [apisix-website] dependabot[bot] opened a new pull request, #1466: chore(deps): bump actions/checkout from 3.1.0 to 3.3.0
dependabot[bot] opened a new pull request, #1466: URL: https://github.com/apache/apisix-website/pull/1466 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v3.3.0 What's Changed Implement branch list using callbacks from exec function by https://github.com/cory-miller;>@cory-miller in https://github-redirect.dependabot.com/actions/checkout/pull/1045;>actions/checkout#1045 Add in explicit reference to private checkout options by https://github.com/vanZeben;>@vanZeben in https://github-redirect.dependabot.com/actions/checkout/pull/1050;>actions/checkout#1050 Fix comment typos (that got added in https://github-redirect.dependabot.com/actions/checkout/issues/770;>#770) by https://github.com/lurch;>@lurch in https://github-redirect.dependabot.com/actions/checkout/pull/1057;>actions/checkout#1057 New Contributors https://github.com/vanZeben;>@vanZeben made their first contribution in https://github-redirect.dependabot.com/actions/checkout/pull/1050;>actions/checkout#1050 https://github.com/lurch;>@lurch made their first contribution in https://github-redirect.dependabot.com/actions/checkout/pull/1057;>actions/checkout#1057 Full Changelog: https://github.com/actions/checkout/compare/v3.2.0...v3.3.0;>https://github.com/actions/checkout/compare/v3.2.0...v3.3.0 v3.2.0 What's Changed Add GitHub Action to perform release by https://github.com/rentziass;>@rentziass in https://github-redirect.dependabot.com/actions/checkout/pull/942;>actions/checkout#942 Fix status badge by https://github.com/ScottBrenner;>@ScottBrenner in https://github-redirect.dependabot.com/actions/checkout/pull/967;>actions/checkout#967 Replace datadog/squid with ubuntu/squid Docker image by https://github.com/cory-miller;>@cory-miller in https://github-redirect.dependabot.com/actions/checkout/pull/1002;>actions/checkout#1002 Wrap pipeline commands for submoduleForeach in quotes by https://github.com/jokreliable;>@jokreliable in https://github-redirect.dependabot.com/actions/checkout/pull/964;>actions/checkout#964 Update @actions/io to 1.1.2 by https://github.com/cory-miller;>@cory-miller in https://github-redirect.dependabot.com/actions/checkout/pull/1029;>actions/checkout#1029 Upgrading version to 3.2.0 by https://github.com/vmjoseph;>@vmjoseph in https://github-redirect.dependabot.com/actions/checkout/pull/1039;>actions/checkout#1039 New Contributors https://github.com/ScottBrenner;>@ScottBrenner made their first contribution in https://github-redirect.dependabot.com/actions/checkout/pull/967;>actions/checkout#967 https://github.com/cory-miller;>@cory-miller made their first contribution in https://github-redirect.dependabot.com/actions/checkout/pull/1002;>actions/checkout#1002 https://github.com/jokreliable;>@jokreliable made their first contribution in https://github-redirect.dependabot.com/actions/checkout/pull/964;>actions/checkout#964 https://github.com/vmjoseph;>@vmjoseph made their first contribution in https://github-redirect.dependabot.com/actions/checkout/pull/1039;>actions/checkout#1039 Full Changelog: https://github.com/actions/checkout/compare/v3.1.0...v3.2.0;>https://github.com/actions/checkout/compare/v3.1.0...v3.2.0 Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog Commits https://github.com/actions/checkout/commit/ac593985615ec2ede58e132d2e21d2b1cbd6127c;>ac59398 Fix comment typos (that got added in https://github-redirect.dependabot.com/actions/checkout/issues/770;>#770) (https://github-redirect.dependabot.com/actions/checkout/issues/1057;>#1057) https://github.com/actions/checkout/commit/3ba5ee6fac7e0e30e2ea884e236f282d3a775891;>3ba5ee6 Add in explicit reference to private checkout options (https://github-redirect.dependabot.com/actions/checkout/issues/1050;>#1050) https://github.com/actions/checkout/commit/885641592076c27bfb56c028cd5612cdad63e16d;>8856415 Implement branch list using callbacks from exec function (https://github-redirect.dependabot.com/actions/checkout/issues/1045;>#1045) https://github.com/actions/checkout/commit/755da8c3cf115ac066823e79a1e1788f8940201b;>755da8c 3.2.0 (https://github-redirect.dependabot.com/actions/checkout/issues/1039;>#1039) https://github.com/actions/checkout/commit/26d48e8ea150211a9bc3b1f0c20448599687d926;>26d48e8 Update @actions/io to 1.1.2 (https://github-redirect.dependabot.com/actions/checkout/issues/1029;>#1029) https://github.com/actions/checkout/commit/bf085276cecdb0cc76fbbe0687a5a0e786646936;>bf08527 wrap pipeline commands for submoduleForeach in quotes (https://github-redirect.dependabot.com/actions/checkout/issues/964;>#964)
[GitHub] [apisix] spacewander commented on pull request #8609: fix: use previous way to disable plugins
spacewander commented on PR #8609: URL: https://github.com/apache/apisix/pull/8609#issuecomment-1373112483 > Changes LGTM. > > However, since we have two options to control if a plugin is disabled, we need to classify the priority of these two fields. > > In the current PR, the `plugin_config.disable` field has a higher priority than `plugin_config._meta.disable`. It is intended. `plugin_config._meta.disable` should not exist in 2.15. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] An-DJ commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
An-DJ commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373112164 @15349185792 The section `ext-plugin` in config.yaml is used to config the external plugin runner. Your custom plugins can be implemented in the java-plugin-runner, so you do not need to configure with `config.yaml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix(ext-plugin-post-resp): can't set content-type response header (#8588)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 91122f9e9 fix(ext-plugin-post-resp): can't set content-type response
header (#8588)
91122f9e9 is described below
commit 91122f9e9bf12f352c103b74df3b60d7f6223841
Author: soulbird
AuthorDate: Fri Jan 6 11:56:57 2023 +0800
fix(ext-plugin-post-resp): can't set content-type response header (#8588)
Co-authored-by: soulbird
Fixes https://github.com/apache/apisix/issues/8388
---
apisix/plugins/ext-plugin/init.lua | 12 +---
t/lib/ext-plugin.lua | 2 ++
t/plugin/ext-plugin/response.t | 1 +
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/apisix/plugins/ext-plugin/init.lua
b/apisix/plugins/ext-plugin/init.lua
index 0f9e0de14..b6fcf6fea 100644
--- a/apisix/plugins/ext-plugin/init.lua
+++ b/apisix/plugins/ext-plugin/init.lua
@@ -791,13 +791,11 @@ local rpc_handlers = {
for i = 1, len do
local entry = call_resp:Headers(i)
local name = str_lower(entry:Name())
-if not exclude_resp_header[name] then
-if resp_headers[name] == nil then
-core.response.set_header(name, entry:Value())
-resp_headers[name] = true
-else
-core.response.add_header(name, entry:Value())
-end
+if resp_headers[name] == nil then
+core.response.set_header(name, entry:Value())
+resp_headers[name] = true
+else
+core.response.add_header(name, entry:Value())
end
end
else
diff --git a/t/lib/ext-plugin.lua b/t/lib/ext-plugin.lua
index 6403e74f5..b19a79838 100644
--- a/t/lib/ext-plugin.lua
+++ b/t/lib/ext-plugin.lua
@@ -534,6 +534,8 @@ function _M.go(case)
if runner and runner == "Go-runner" then
headers["x-runner"] = "Test-Runner"
end
+
+headers["Content-Type"] = "application/json"
end
local i = 1
diff --git a/t/plugin/ext-plugin/response.t b/t/plugin/ext-plugin/response.t
index 2500e5db0..d8a2be2a5 100644
--- a/t/plugin/ext-plugin/response.t
+++ b/t/plugin/ext-plugin/response.t
@@ -155,6 +155,7 @@ resp-X-Runner: Go-runner
--- error_code: 200
--- response_headers
X-Runner: Test-Runner
+Content-Type: application/json
--- response_body
hello world
[GitHub] [apisix] spacewander closed issue #8388: bug: external-plugin-post-resp plugin converts content-type from upstream response
spacewander closed issue #8388: bug: external-plugin-post-resp plugin converts content-type from upstream response URL: https://github.com/apache/apisix/issues/8388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #8588: fix(ext-plugin-post-resp): can't set content-type response header
spacewander merged PR #8588: URL: https://github.com/apache/apisix/pull/8588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Martinprobu commented on issue #8617: bug: One of the three etcd nodes is broken (once every two weeks)
Martinprobu commented on issue #8617: URL: https://github.com/apache/apisix/issues/8617#issuecomment-1373109111 @nic-chen @membphis do you need any other information ? or need a calling? We're waiting online -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 15349185792 commented on issue #8602: Java开发的多个external plugin 如何在配置文件中配置
15349185792 commented on issue #8602: URL: https://github.com/apache/apisix/issues/8602#issuecomment-1373094645 @An-DJ 不是，是在config.yaml中如何配置多个java自定义插件 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] kvii opened a new pull request, #125: fix time.Since issue
kvii opened a new pull request, #125: URL: https://github.com/apache/apisix-go-plugin-runner/pull/125 Change `time.Now().Sub` to `time.Since`. reference: [should use time.Since instead of time.Now().Sub (S1012)go-staticcheck](https://staticcheck.io/docs/checks#S1012) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] showcup opened a new issue, #8622: help request: can not get response body in the body_filter on my custom plugin
showcup opened a new issue, #8622:
URL: https://github.com/apache/apisix/issues/8622
### Description
Can not get response body in the body_filter on my custom plugin，The
following code is in body_filter:
```
function _M.body_filter(conf,ctx)
local final_body = core.response.hold_body_chunk(ctx)
if not final_body then
core.log.warn(' response body is nil')
return
end
--final_body = transform(final_body)
ngx.arg[1] = final_body
end
```
final_body is nil when it runs, I want to transform response , these codes
refer to the response-rewrite plugin. In response-rewrite, response body can
be modified through filters, but respone body cannot be obtained in my custom
plugin please help me!
### Environment
- APISIX version (run `apisix version`): 3.0.0
- Operating system (run `uname -a`): apisix docker
- OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
- etcd version, if relevant (run `curl
http://127.0.0.1:9090/v1/server_info`):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8611: refactor(admin): refactor resource routes
spacewander commented on code in PR #8611:
URL: https://github.com/apache/apisix/pull/8611#discussion_r1063037789
##
apisix/admin/resource.lua:
##
@@ -0,0 +1,201 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local utils = require("apisix.admin.utils")
+local setmetatable = setmetatable
+local type = type
+
+
+local _M = {
+version = 0.2,
+need_v3_filter = true,
+}
+
+
+local mt = {
+__index = _M
+}
+
+
+local function get(self, id)
+local key = "/" .. self.name
+if id then
+key = key .. "/" .. id
+end
+
+local res, err = core.etcd.get(key, not id)
+if not res then
+core.log.error("failed to get " .. self.kind .. "[", key, "] from
etcd: ", err)
Review Comment:
The log function will concat the string, no need to do it ourselves
##
apisix/admin/routes.lua:
##
@@ -17,13 +17,16 @@
local expr = require("resty.expr.v1")
local core = require("apisix.core")
local apisix_upstream = require("apisix.upstream")
+local resource = require("apisix.admin.resource")
local schema_plugin = require("apisix.admin.plugins").check_schema
-local utils = require("apisix.admin.utils")
local tostring = tostring
local type = type
local loadstring = loadstring
+local handler = resource.new("routes", "route")
Review Comment:
We can pass the check_conf when creating the resource.
Like
https://github.com/apache/apisix/blob/030019b5297268b2171df5aa661d84c3c1ab6b92/apisix/upstream.lua#L558
So we can return handler instead of _M directly (note that we need to change
how we call it in the admin's init.lua)
##
apisix/admin/routes.lua:
##
@@ -17,13 +17,16 @@
local expr = require("resty.expr.v1")
local core = require("apisix.core")
local apisix_upstream = require("apisix.upstream")
+local resource = require("apisix.admin.resource")
local schema_plugin = require("apisix.admin.plugins").check_schema
-local utils = require("apisix.admin.utils")
local tostring = tostring
local type = type
local loadstring = loadstring
+local handler = resource.new("routes", "route")
+
+
local _M = {
Review Comment:
We can remove it?
##
apisix/admin/resource.lua:
##
@@ -0,0 +1,201 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local utils = require("apisix.admin.utils")
+local setmetatable = setmetatable
+local type = type
+
+
+local _M = {
+version = 0.2,
+need_v3_filter = true,
+}
+
+
+local mt = {
+__index = _M
+}
+
+
+local function get(self, id)
+local key = "/" .. self.name
+if id then
+key = key .. "/" .. id
+end
+
+local res, err = core.etcd.get(key, not id)
+if not res then
+core.log.error("failed to get " .. self.kind .. "[", key, "] from
etcd: ", err)
+return 503, {error_msg = err}
+end
+
+utils.fix_count(res.body, id)
+return res.status, res.body
+end
+
+
+local function post(self, check_conf, id, conf, sub_path, args)
+local id, err = check_conf(id, conf, false)
+if not id then
+return 400, err
+end
+
+local key = "/" .. self.name
+utils.inject_timestamp(conf)
+local res, err = core.etcd.push(key, conf, args.ttl)
+if not res then
+core.log.error("failed to post " .. self.kind .. "[", key, "] to etcd:
", err)
+return 503, {error_msg = err}
+end
+
+return res.status,
[GitHub] [apisix] monkeyDluffy6017 commented on issue #8591: help request: TCP proxy
monkeyDluffy6017 commented on issue #8591:
URL: https://github.com/apache/apisix/issues/8591#issuecomment-1373082332
```
curl http://127.0.0.1:9180/apisix/admin/stream_routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"server_addr": "192.168.3.73",
"server_port": 9006,
"upstream": {
"nodes": {
"192.168.3.73:3306": 1
},
"type": "roundrobin"
}
}'
mysql --host=192.168.3.73 --port=9006 -u root -p
Enter password:
Welcome to the MySQL monitor. Commands end with ; or \g.
Your MySQL connection id is 12
Server version: 8.0.31 MySQL Community Server - GPL
```
@ffjiang666 I tested with your example, and it worked，could you try to use
the mysql in our example
https://apisix.apache.org/docs/apisix/stream-proxy/#more-route-match-options
```
docker run --name mysql -e MYSQL_ROOT_PASSWORD=toor -p 3306:3306 -d mysql
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] swtseaman commented on issue #8621: 希望能支持从请求体中进行条件过滤来进行灰度转发
swtseaman commented on issue #8621:
URL: https://github.com/apache/apisix/issues/8621#issuecomment-1373078262
比如：
http body : {"userId": "u1"}
希望插件能提取userId，或者哪怕是判断整个body里有没有包含u1，就进行灰度转发
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] swtseaman opened a new issue, #8621: 希望能支持从请求体中进行条件过滤来进行灰度转发
swtseaman opened a new issue, #8621: URL: https://github.com/apache/apisix/issues/8621 ### Description 我的接口都是跑了很久的json请求，无法改造请求或增加请求头；所以希望能从请求体的json中判断用户身份或用户账号来进行灰度；不知道traffic-split这种插件是否能支持，或者改造支持呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] BERZERKCOOLeST commented on issue #121: request help: How to get right body from grpc?
BERZERKCOOLeST commented on issue #121: URL: https://github.com/apache/apisix-go-plugin-runner/issues/121#issuecomment-1373059506 > @BERZERKCOOLeST Could you plz give the steps to reproduce the problem you met? 1. Set a route in APISIX dashboard. Set a upstream for the route and the scheme of upstream is grpc(need to implement a simple grpc service as upstream). And set plugin for it; 2. Send a request with payload using a grpc cli. Try to use r.Body() in plugin to get the payload, but failed, it got a messy payload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ronething commented on a diff in pull request #8593: feat: stream subsystem support dns service discovery
ronething commented on code in PR #8593:
URL: https://github.com/apache/apisix/pull/8593#discussion_r1062169542
##
t/discovery/stream/dns.t:
##
@@ -0,0 +1,431 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if (!$block->yaml_config) {
+my $yaml_config = <<_EOC_;
+apisix:
+node_listen: 1984
+enable_admin: false
+deployment:
+role: data_plane
+role_data_plane:
+config_provider: yaml
+discovery:# service discovery center
+dns:
+servers:
+- "127.0.0.1:1053"
+_EOC_
+
+$block->set_value("yaml_config", $yaml_config);
+}
+
+if ($block->apisix_yaml) {
+my $upstream = <<_EOC_;
+stream_routes:
+ - id: 1
+server_port: 1985
+upstream_id: 1
+#END
+_EOC_
+
+$block->set_value("apisix_yaml", $block->apisix_yaml . $upstream);
+}
+
+if (!$block->stream_request) {
+# GET /hello HTTP/1.0\r\nHost: 127.0.0.1:1985\r\n\r\n
+$block->set_value("stream_request",
"\x47\x45\x54\x20\x2f\x68\x65\x6c\x6c\x6f\x20\x48\x54\x54\x50\x2f\x31\x2e\x30\x0d\x0a\x48\x6f\x73\x74\x3a\x20\x31\x32\x37\x2e\x30\x2e\x30\x2e\x31\x3a\x31\x39\x38\x35\x0d\x0a\x0d\x0a");
+}
+
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: default port to 53
+--- log_level: debug
+--- yaml_config
+apisix:
+node_listen: 1984
+enable_admin: false
+deployment:
+role: data_plane
+role_data_plane:
+config_provider: yaml
+discovery:# service discovery center
+dns:
+servers:
+- "127.0.0.1"
+--- apisix_yaml
+upstreams:
+- service_name: sd.test.local
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- error_log
+127.0.0.1:53
+
+
+
+=== TEST 2: A
+--- apisix_yaml
+upstreams:
+- service_name: "sd.test.local:1980"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- grep_error_log eval
+qr/upstream nodes: \{[^}]+\}/
+--- grep_error_log_out eval
+qr/upstream nodes:
\{("127.0.0.1:1980":1,"127.0.0.2:1980":1|"127.0.0.2:1980":1,"127.0.0.1:1980":1)\}/
+--- stream_response_like
+hello world
+
+
+
+=== TEST 3:
+--- listen_ipv6
+--- apisix_yaml
+upstreams:
+- service_name: "ipv6.sd.test.local:1980"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- stream_response_like
+hello world
+--- grep_error_log eval
+qr/proxy request to \S+/
+--- grep_error_log_out
+proxy request to [0:0:0:0:0:0:0:1]:1980
+
+
+
+=== TEST 4: prefer A to
+--- listen_ipv6
+--- apisix_yaml
+upstreams:
+- service_name: "mix.sd.test.local:1980"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- stream_response_like
+hello world
+--- grep_error_log eval
+qr/proxy request to \S+/
+--- grep_error_log_out
+proxy request to 127.0.0.1:1980
+
+
+
+=== TEST 5: no /etc/hosts
+--- apisix_yaml
+upstreams:
+- service_name: test.com
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- error_log
+failed to query the DNS server
+
+
+
+=== TEST 6: no /etc/resolv.conf
+--- yaml_config
+apisix:
+node_listen: 1984
+enable_admin: false
+enable_resolv_search_option: false
+deployment:
+role: data_plane
+role_data_plane:
+config_provider: yaml
+discovery:# service discovery center
+dns:
+servers:
+- "127.0.0.1:1053"
+--- apisix_yaml
+upstreams:
+- service_name: apisix
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- error_log
+failed to query the DNS server
+
+
+
+=== TEST 7: SRV
+--- apisix_yaml
+upstreams:
+- service_name: "srv.test.local"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+--- grep_error_log eval
+qr/upstream nodes: \{[^}]+\}/
+--- grep_error_log_out eval
+qr/upstream nodes:
\{("127.0.0.1:1980":60,"127.0.0.2:1980":20|"127.0.0.2:1980":20,"127.0.0.1:1980":60)\}/
+--- stream_response_like
+hello world
+
+
+
+=== TEST 8: SRV (RFC 2782 style)
+--- apisix_yaml
+upstreams:
+- service_name: "_sip._tcp.srv.test.local"
+ discovery_type: dns
+ type: roundrobin
+ id: 1
+---
[GitHub] [apisix-go-plugin-runner] An-DJ commented on issue #121: request help: How to get right body from grpc?
An-DJ commented on issue #121: URL: https://github.com/apache/apisix-go-plugin-runner/issues/121#issuecomment-1373034103 @BERZERKCOOLeST Could you plz give the steps to reproduce the problem you met? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat
spacewander commented on issue #8569: URL: https://github.com/apache/apisix/issues/8569#issuecomment-1373024899 We can use fewer PRs to implement it. The refactor progress can be faster after several PRs as we will have a stable foundation. What about refactoring 2~3 resources in the upcoming PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: chore: release apisix 3.1 docs (#1464)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 07d91be85e9 chore: release apisix 3.1 docs (#1464)
07d91be85e9 is described below
commit 07d91be85e9e6cedcdb79e28665ece35dc03917f
Author: Young
AuthorDate: Fri Jan 6 09:35:29 2023 +0800
chore: release apisix 3.1 docs (#1464)
---
config/apisix-versions.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/apisix-versions.js b/config/apisix-versions.js
index 457b70ea9e2..9679be26659 100644
--- a/config/apisix-versions.js
+++ b/config/apisix-versions.js
@@ -3,7 +3,7 @@
/**
* @type {Array} version list
*/
-const versions = ['2.12', '2.13', '2.14', '2.15', '3.0'];
+const versions = ['2.12', '2.13', '2.14', '2.15', '3.0', '3.1'];
/**
* @type {Array} LTS version list
[GitHub] [apisix-website] juzhiyuan merged pull request #1464: chore: release apisix 3.1 docs
juzhiyuan merged PR #1464: URL: https://github.com/apache/apisix-website/pull/1464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] An-DJ commented on issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat
An-DJ commented on issue #8569: URL: https://github.com/apache/apisix/issues/8569#issuecomment-1373018001 I think we can refactor the resources one by one: - [ ] routes #8611 - [ ] services - [ ] upstreams - [ ] consumers - [ ] ssls - [ ] plugins - [ ] protos - [ ] global_rules - [ ] stream_routes - [ ] plugin_metadata - [ ] plugin_configs - [ ] consumer_groups - [ ] secrets -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] github-actions[bot] commented on issue #1300: e2e-test: add case for unwatched namespace being watched
github-actions[bot] commented on issue #1300: URL: https://github.com/apache/apisix-ingress-controller/issues/1300#issuecomment-1373017540 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] github-actions[bot] closed issue #1300: e2e-test: add case for unwatched namespace being watched
github-actions[bot] closed issue #1300: e2e-test: add case for unwatched namespace being watched URL: https://github.com/apache/apisix-ingress-controller/issues/1300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] soulbird commented on issue #401: bug: Apisix Config File Overwritten in Standalone Mode
soulbird commented on issue #401: URL: https://github.com/apache/apisix-docker/issues/401#issuecomment-1373015858 Can you show your `config.yaml` ？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #1464: chore: release apisix 3.1 docs
netlify[bot] commented on PR #1464: URL: https://github.com/apache/apisix-website/pull/1464#issuecomment-1373013142 ### Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit | a7bbd852f9c6248b0d63b7d0a48b843a2aa5c2c3 | | Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/63b777fac88e38995990 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] SkyeYoung opened a new pull request, #1464: chore: release apisix 3.1 docs
SkyeYoung opened a new pull request, #1464: URL: https://github.com/apache/apisix-website/pull/1464 Fixes: #[Add issue number here] Changes: release apisix 3.1 docs Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] 01/01: chore: release apisix 3.1 docs
This is an automated email from the ASF dual-hosted git repository.
young pushed a commit to branch SkyeYoung-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit a7bbd852f9c6248b0d63b7d0a48b843a2aa5c2c3
Author: Young
AuthorDate: Fri Jan 6 09:22:51 2023 +0800
chore: release apisix 3.1 docs
---
config/apisix-versions.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/apisix-versions.js b/config/apisix-versions.js
index 457b70ea9e2..9679be26659 100644
--- a/config/apisix-versions.js
+++ b/config/apisix-versions.js
@@ -3,7 +3,7 @@
/**
* @type {Array} version list
*/
-const versions = ['2.12', '2.13', '2.14', '2.15', '3.0'];
+const versions = ['2.12', '2.13', '2.14', '2.15', '3.0', '3.1'];
/**
* @type {Array} LTS version list
[apisix-website] branch SkyeYoung-patch-1 created (now a7bbd852f9c)
This is an automated email from the ASF dual-hosted git repository. young pushed a change to branch SkyeYoung-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git at a7bbd852f9c chore: release apisix 3.1 docs This branch includes the following new commits: new a7bbd852f9c chore: release apisix 3.1 docs The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix-website] SkyeYoung commented on a diff in pull request #1463: docs:add weekly report and 2022 commmunity summary
SkyeYoung commented on code in PR #1463: URL: https://github.com/apache/apisix-website/pull/1463#discussion_r1063022946 ## blog/zh/blog/2023/01/04/weekly-report-0105.md: ## @@ -0,0 +1,73 @@ +--- +title: "社区双周报 (12.19 - 1.1)" +keywords: +- Apache APISIX +- API 网关 +- 社区周报 +- 贡献者 +description: “独行者速，众行者远”。Apache APISIX 社区周报希望可以帮助社区小伙伴们更好地掌握 Apache APISIX 社区的进展，方便大家参与到 Apache APISIX 社区中来。 +tags: [Community] +image: https://static.apiseven.com/2023/01/05/63b66c8388a6c.png +--- + +> 从 2022.12.19 - 2023.1.1，有 21 位开发者为 Apache APISIX 提交了 64 个 commits。感谢这些小伙伴为 Apache APISIX 添砖加瓦，是你们的无私付出，让 Apache APISIX 项目变得更好！ Review Comment: ```suggestion > 从 2022.12.19 - 2023.1.1，有 21 位开发者为 Apache APISIX 提交了 64 个 commit。感谢这些小伙伴为 Apache APISIX 添砖加瓦，是你们的无私付出，让 Apache APISIX 项目变得更好！ ``` ## blog/zh/blog/2023/01/02/2022-summary.md: ## @@ -0,0 +1,95 @@ +--- +title: "2022 Apache APISIX 年度记忆" +author: "Sylvia" +authorURL: "https://github.com/SylviaBABY; +authorImageURL: "https://github.com/SylviaBABY.png; +keywords: +- 社区动态 +- 年终总结 +- APISIX +- 开源社区 +description: 本文介绍了 Apache APISIX 社区在 2022 年取得的成绩。 +tags: [Community] +--- + +> 本文将带您回顾 Apache APISIX 社区在 2022 年在各领域取得的成绩。 + + + +时光已逝，转眼 2022 年已然落下了帷幕。Apache APISIX 社区在众多开源爱好者和开发者的陪伴下，又一起走过了新的四季。 + +在过去的一年中，我们的开源项目和社区都取得了许多成就，并得到了来自全球范围的广泛关注和支持。2022 年，APISIX 社区仍然在为全球技术开发者和企业提供优质的产品与支持，并不断改进和升级产品。这一年中，APISIX 新增了许多功能，并迈入了全新的 3.0 时代；改善了用户体验，并得到了许多优秀贡献者的陪伴与合作。 + +我们希望通过这一份纸上告白，向大家展示 Apache APISIX 在过去一年中取得的成就，并感谢所有为 APISIX 项目做出贡献的人。 + +## 迈进 3.0 大版本，新增超多实用性功能 + +进入 2022 年后，APISIX 从 1 月份开始依旧保持着良好的发版速度。**这一年中，APISIX 一共发布了 15 个版本，涉及 6 个版本的更迭，包括旧版本的维护更新以及正常版本的迭代。** + + + +同时，在今年 APISIX 也将产品拉进了新的 3.0 时代，目前已针对 3.x 系列发布了 3 个更新版本。在 3.0 的整体规划中，将会陆续带来更多的针对生态和产品体验上的功能提升，使 APISIX 的可用性更上一层楼。**在新的一年中，APISIX 也会为产品带来更多实用性功能，助力企业在数字化转型的过程中，愈发轻松。** + + + +从 2019 年在 Apache 软件基金会毕业成为 Apache 社区顶级项目，到现在保持着稳定发版速度和活跃社区氛围的三年时间里，APISIX 项目在 GitHub 上已得到 10K+ star 并拥有 6 亿多下载量，contributor 数量已经超过 500 人。同时每月保持贡献 70+ commit、处理 80+ issue 的响应速度。高活跃度的社区氛围，正是推动产品快速成长的关键因素。 + + + +## 泵入新鲜血液，收获行业认可 + +**产品快速成长的背后，离不开社区中每一位成员的支持。** 在过去的一年中，APISIX 的贡献者人数增加了 200 人左右。相比总贡献者人数，这一年的增长相当于总人数的近 40% 比例，可见今年 APISIX 收获了开发者们超高的热情反馈，并将对开源产品的喜爱体现在了社区贡献中来。 + +这三年的发展过程中，APISIX 得到了非常多开发者的肯定与认可，他们也在全球 20 多个国家和地区进行 APISIX 项目的宣传。为了感谢各位对 APISIX 社区的喜爱，我们也会定期为参与 APISIX 社区的新晋贡献者们赠送社区周边，今年也是一样。 + +上半年的新晋贡献者我们已派发过相关周边，下半年的新晋贡献者礼物也在紧锣密鼓地制作中。如果你有收到来自 APISIX 社区的相关邮件，记得填写信息哦。当然，你也可以主动在 [GitHub 页面](https://github.com/apache/apisix/blob/master/CONTRIBUTING.md)进行填写，之后就会有精美周边送到你手上。 + + + +除了国内外开发者的认可外，今年 APISIX 也收获了很多企业级的技术赞誉。比如在互联网保险领域，[众安保险](https://apisix.apache.org/zh/blog/2022/03/02/zhongan-usercase-with-apache-apisix/) 在整个 DevOps 的全生命周期中，将 APISIX 作为流量治理的关键环节去处理，实现了更好的多渠道流量隔离；在智能汽车 AI 领域，[地平线](https://apisix.apache.org/zh/blog/2022/10/28/apisix-ingress-with-horizon-ai/) 则选择了 APISIX Ingress 替换 Traefik 作为公司的统一流量网关，丰富了多云环境下的服务调用等功能；在国产手机领军队伍中，[vivo](https://apisix.apache.org/zh/blog/2022/11/13/vivo-with-apache-apisix/) 使用 APISIX 替换了之前传统的 NGINX，同时基于 APISIX 还自研了内部业务配置管理系统，在 vivo 业务架构的实践和场景支持上都表现得十分出色。 + + + +当然，以上也仅仅只选取了部分使用 APISIX 的企业用户，想要了解不同行业对于 APISIX 的实践，可以前往 [社区官网](https://apisix.apache.org/zh/blog/tags/case-studies/) 查看更多细节。 + +## 活动形式多样，持续践行 Apache Way + +在 2022 年中旬，APISIX 社区举办了第一次全球性质的大会—— Apache APISIX Summit Asia 2022。在为期两天的活动中，我们见证了不同行业领域下的 APISIX 实践用例。由来自腾讯云、阿里云、VMvare Tanzu Labs 等顶级科技公司的工程师以及 APISIX PMC 成员们，带来了干货满满又富有借鉴意义的技术展示。 Review Comment: ```suggestion 在 2022 年中旬，APISIX 社区举办了第一次全球性质的大会—— Apache APISIX Summit Asia 2022。在为期两天的活动中，我们见证了不同行业领域下的 APISIX 实践用例。由来自腾讯云、阿里云、VMware Tanzu Labs 等顶级科技公司的工程师以及 APISIX PMC 成员们，带来了干货满满又富有借鉴意义的技术展示。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1589: feat: add openid connect auth
codecov-commenter commented on PR #1589: URL: https://github.com/apache/apisix-ingress-controller/pull/1589#issuecomment-137260 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1589?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1589](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1589?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e65e093) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/486b46abd1c9665005e83036433af213aaa28f21?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (486b46a) will **increase** coverage by `0.12%`. > The diff coverage is `43.75%`. ```diff @@Coverage Diff @@ ## master#1589 +/- ## == + Coverage 41.44% 41.56% +0.12% == Files 87 87 Lines7420 7836 +416 == + Hits 3075 3257 +182 - Misses 3990 4202 +212 - Partials 355 377 +22 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/providers/apisix/translation/apisix\_plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3BsdWdpbi5nbw==) | `50.00% <43.34%> (-7.55%)` | :arrow_down: | | [...kg/providers/apisix/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv) | `66.66% <60.00%> (-1.08%)` | :arrow_down: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on a diff in pull request #8620: fix: Compression in log-rotate plugin exceeds the default timeout of shell.run
membphis commented on code in PR #8620: URL: https://github.com/apache/apisix/pull/8620#discussion_r1063015447 ## apisix/plugins/log-rotate.lua: ## @@ -277,6 +277,7 @@ local function rotate() max_size = attr.max_size or max_size enable_compression = attr.enable_compression or enable_compression end +local timeout = interval * 100 -- Timeout for compression is interval in milliseconds Review Comment: We'd better add a new configuration item to control the timeout parameter. https://user-images.githubusercontent.com/6814606/210908411-53c1ad81-f9ba-4b11-90bb-a0eea139c6bf.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #8617: bug: One of the three etcd nodes is broken (once every two weeks)
membphis commented on issue #8617: URL: https://github.com/apache/apisix/issues/8617#issuecomment-1372991998 @nic-chen do you have time to take a look at this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #438: CI: Split the helm-docs task so it only needs to be executed once
tao12345666333 commented on issue #438: URL: https://github.com/apache/apisix-helm-chart/issues/438#issuecomment-1372828862 Don't worry. Thanks for your contributions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1563: request help: apisix send request to offline pod ip
tao12345666333 commented on issue #1563: URL: https://github.com/apache/apisix-ingress-controller/issues/1563#issuecomment-1372827290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Fabriceli opened a new pull request, #1589: feat: add openid connect auth
Fabriceli opened a new pull request, #1589: URL: https://github.com/apache/apisix-ingress-controller/pull/1589 ### Type of change: - [x] New feature provided ### What this PR does / why we need it: #1587 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Fabriceli commented on pull request #1576: fix: fix sync delete svc error
Fabriceli commented on PR #1576: URL: https://github.com/apache/apisix-ingress-controller/pull/1576#issuecomment-1372322577 @tao12345666333 please take a look at this PR, i had fixed the e2e test error, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] sandro-qiang opened a new issue, #2702: Use Mutual TLS Authentication to access dashboard
sandro-qiang opened a new issue, #2702: URL: https://github.com/apache/apisix-dashboard/issues/2702 # Feature request Use Mutual TLS Authentication to access dashboard ## Please describe your feature I saw old version has `client_cert_auth` and `trusted_ca options` in conf, but latest version has no these options -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kingluo commented on pull request #8612: fix: correct inspect plugin default hooks file path and add hook remove logs
kingluo commented on PR #8612: URL: https://github.com/apache/apisix/pull/8612#issuecomment-1372220106 > no test cases? It's not necessary, the path is corrected. No need > no test cases? Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #8616: bug: Apisix Config File Overwritten in Standalone Mode
juzhiyuan commented on issue #8616: URL: https://github.com/apache/apisix/issues/8616#issuecomment-1372213130 Hello, I haven't tried using Standalone mode in Docker, but as far as I know, if using Standalone mode, we should put Routes/Upstreams/... in apisix.yaml file instead of config.yaml. 樂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] sashokbg commented on issue #8616: bug: Apisix Config File Overwritten in Standalone Mode
sashokbg commented on issue #8616:
URL: https://github.com/apache/apisix/issues/8616#issuecomment-1372198175
It seems there is some log generated at startup:
apache-apisix | 2023/01/05 13:10:40 [error] 38#38: *7
[lua] config_yaml.lua:210: failed to check item data of [routes] err:allOf 1
failed: value should match only one schema, but matches none ,val:
{"priority":0,"status":1}, context: init_worker_by_lua*
For some reason the lua script thinks the config is bad and ends up
overwriting the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] alptugay opened a new pull request, #8620: Update log-rotate.lua
alptugay opened a new pull request, #8620: URL: https://github.com/apache/apisix/pull/8620 Fixes: Compression in log-rotate plugin exceeds the default timeout of shell.run ### Description This issue fixes the bug: "Compression in log-rotate plugin exceeds the default timeout of shell.run" #8619 The interval parameter is passed to shell.run() function Fixes #8619 ### Checklist - [X] I have explained the need for this PR and the problem it solves - [X] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [X] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] alptugay opened a new issue, #8619: bug: Compression in log-rotate plugin exceeds the default timeout of shell.run
alptugay opened a new issue, #8619: URL: https://github.com/apache/apisix/issues/8619 ### Current Behavior When rotating log files, the log-rotate plugin uses shell.run() function which has a default timeout of 10 seconds. When rotating big log files this timeout is exceeded thus the tar command is being killed with SIGTERM. This causes the rotated files to be incomplete, and also the log files doesn't get removed.  ### Expected Behavior Logs should be rotated completely unless it takes more time than log rotate interval. Therefor the timeout of the shell.run() function should be the same as the interval value. ### Error Logs _No response_ ### Steps to Reproduce Generate a log file (1GB or more) which takes more than 10 seconds to compress using `tar -cvf` Let the log rotate plugin work ### Environment - APISIX 2.15 but should be the same on v3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] soulbird commented on a diff in pull request #8604: feat(elasticsearch-logger): support multi elasticsearch endpoints(#8431)
soulbird commented on code in PR #8604:
URL: https://github.com/apache/apisix/pull/8604#discussion_r1062011352
##
apisix/plugins/elasticsearch-logger.lua:
##
@@ -31,10 +32,19 @@ local batch_processor_manager =
bp_manager_mod.new(plugin_name)
local schema = {
type = "object",
properties = {
+-- deprecated, use "endpoint_addrs" instead
endpoint_addr = {
type = "string",
pattern = "[^/]$",
},
+endpoint_addrs = {
Review Comment:
Looking at this:
https://github.com/apache/apisix/pull/7517/files#diff-d8d1670bb4d48884ee796f652172591cc371e5da972d7581ca585e60ddaab0f2R35,
it also indicates the need to unify into one. You can refer to the definition
of nodes_schema to allow endpoint_addrs to be set to multiple types:
https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] vmaillot opened a new issue, #326: feature request/security: avoid container running root
vmaillot opened a new issue, #326: URL: https://github.com/apache/apisix-docker/issues/326 Hey there, In advance, thanks for your time and help. # Context I was trying to make Apisix run in a OpenShift cluster but without having root running the container. To do so I am using the official upstream Helm [chart](https://github.com/apache/apisix-helm-chart). I was able to run everything but the Apisix deployment without root. A work around is to use the [SCC](https://docs.openshift.com/container-platform/4.10/authentication/managing-security-context-constraints.html) as `anyuid` on the service account running the application to let the application run as user root (0). Obviously in a perfect world we do not want that. That is why I am asking if that would be possible to make the application run as a non-root user. When trying this solution with the help of the Helm chart, and without setting up the SCC I am getting this error below: ``` /usr/local/openresty/luajit/bin/luajit ./apisix/cli/apisix.lua init failed to update nginx.conf: failed to open file: /usr/local/apisi/conf/nginx.conf, error info:/usr/local/apisix/conf/nginx.conf: Permission denied ``` The error makes total sense, as the generated nginx configuration has those permissions: ``` bash-5.1# ls -la /usr/local/apisix/conf/nginx.conf -rw-r--r--1 root root 11422 Jul 5 10:49 /usr/local/apisix/conf/nginx.conf ``` # Solutions The first easy solution would be to add write access to the group root on this file as every container is started with the root group (0) on OpenShift. The nginx configuration seems to be generated somehow, maybe it would be doable to add the write permission to the group on the fly? The second one is a bit more tricky and might require more work but would simply follows the [Best practices for writing Dockerfiles](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#user). Again maybe we have a application limitation, but I think that should be feasible! Please let me know if something is unclear or not understood here. Thanks for evaluating this proposition of a new feature to gain a bit of flexibility and security while running Apisix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] fengxsong opened a new pull request, #400: fix: add etcdctl binary when use_grpc
fengxsong opened a new pull request, #400: URL: https://github.com/apache/apisix-docker/pull/400 Signed-off-by: fengxsong When `etcd.use_grpc=true`, without `etcdctl` binary tool apisix will crash infinite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] fengxsong commented on issue #326: feature request/security: avoid container running root
fengxsong commented on issue #326: URL: https://github.com/apache/apisix-docker/issues/326#issuecomment-1372124381 Does this change need to be applied to centos based image? and also, this may required some more docs, non root user can not bind ports under 1024, unless use `securityContext.runAsUser` to override the default user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Martinprobu opened a new issue, #8617: bug: One of the three etcd nodes is broken (once every two weeks)
Martinprobu opened a new issue, #8617: URL: https://github.com/apache/apisix/issues/8617 ### Current Behavior One of the three etcd nodes is broken (once every two weeks) ### Expected Behavior Three nodes should be operating normally ### Error Logs https://user-images.githubusercontent.com/7867886/210766576-31f09964-b4b1-462e-a46c-945d132818dc.png;> https://user-images.githubusercontent.com/7867886/210766611-b85dd612-16c1-4f8a-8ef5-caa1423b816f.png;> ### Steps to Reproduce 1.insatll the etcd cluster: helm upgrade etcd-release --install --create-namespace --namespace etcd --version v8.5.11 --values apisix/etcd.yaml etcd-repo/etcd 2.install the apisix: helm upgrade apisix-release --install --create-namespace --namespace apisix --version v0.11.4 --values apisix/apisix-new.values.yml apisix/apisix ### Environment - APISIX version (run `apisix version`): 2.15.0 - Operating system (run `uname -a`): Linux etcd-release-2 5.4.0-1089-azure - OpenResty / Nginx version (run `openresty -V` or `nginx -V`): openresty/1.21.4.1 - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`): helm.sh/chart:etcd-8.5.11 - APISIX Dashboard version, if relevant: - Plugin runner version, for issues related to plugin runners: - LuaRocks version, for installation issues (run `luarocks --version`): 3.8.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] MekelCon commented on pull request #8587: fix: issue 8511 The format of response body that returned by plugin should match Content-Type
MekelCon commented on PR #8587: URL: https://github.com/apache/apisix/pull/8587#issuecomment-1372033540 > > @spacewander I saw the CI failed due to this line, 121 : `local accept_header = core_request.header(ctx, "Accept")` Because `ctx` is 'not defined' Wich is true, but it works, i am a beginner in .lua so maybe there is something i am missing. > > To have the correct syntax should we add the `ctx `parameter to the method resp_exit ? > > I think a bit it seems that there is no better way to do it. It's OK to add the parameter. @spacewander , so i checked quickly, i see at least 93 call to `response.exit(...)` SO before doing the update i want to be sure of what need to done. As today we use this function with this definition : `function resp_exit(code, ...)` i must update it to : `function resp_exit(ctx, code, ...)` And then it means check all the usage to add the parameter ? For example `return core.response.exit(502)` will become `return core.response.exit(ctx, 502)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #6021: bug: in Orchestration, OpenID-Connect Plug-in Properties Timeout does not set, there will be an error
github-actions[bot] closed issue #6021: bug: in Orchestration, OpenID-Connect Plug-in Properties Timeout does not set, there will be an error URL: https://github.com/apache/apisix/issues/6021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #6005: bug: error happened when using core.etcd:getkey
github-actions[bot] closed issue #6005: bug: error happened when using core.etcd:getkey URL: https://github.com/apache/apisix/issues/6005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #3690: Support for AzureAD/OIDC integration with APISIX
github-actions[bot] commented on issue #3690: URL: https://github.com/apache/apisix/issues/3690#issuecomment-1372013171 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #6021: bug: in Orchestration, OpenID-Connect Plug-in Properties Timeout does not set, there will be an error
github-actions[bot] commented on issue #6021: URL: https://github.com/apache/apisix/issues/6021#issuecomment-1372013379 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
