[GitHub] [apisix-docker] sashokbg commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh
sashokbg commented on code in PR #405:
URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1069071945
##
centos/docker-entrypoint.sh:
##
@@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix}
if [[ "$1" == "docker-start" ]]; then
if [ "$APISIX_STAND_ALONE" = "true" ]; then
-cat > ${PREFIX}/conf/config.yaml << _EOC_
+if [ ! -f ${PREFIX}/conf/config.yaml ]; then
Review Comment:
Ok, I see. I was thinking that if the developer provided a config file it is
then their responsibility to put the appropriate configuration values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh
tokers commented on code in PR #405:
URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1069082845
##
centos/docker-entrypoint.sh:
##
@@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix}
if [[ "$1" == "docker-start" ]]; then
if [ "$APISIX_STAND_ALONE" = "true" ]; then
-cat > ${PREFIX}/conf/config.yaml << _EOC_
+if [ ! -f ${PREFIX}/conf/config.yaml ]; then
Review Comment:
Maybe we can append this part of the config if the config provided by users
doesn't have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed pull request #1512: chore(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0
tao12345666333 closed pull request #1512: chore(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0 URL: https://github.com/apache/apisix-ingress-controller/pull/1512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dependabot[bot] commented on pull request #1511: chore(deps): bump k8s.io/code-generator from 0.25.4 to 0.26.0
dependabot[bot] commented on PR #1511: URL: https://github.com/apache/apisix-ingress-controller/pull/1511#issuecomment-1381479087 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed pull request #1514: chore(deps): bump k8s.io/api from 0.25.4 to 0.26.0
tao12345666333 closed pull request #1514: chore(deps): bump k8s.io/api from 0.25.4 to 0.26.0 URL: https://github.com/apache/apisix-ingress-controller/pull/1514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dependabot[bot] commented on pull request #1513: chore(deps): bump k8s.io/apimachinery from 0.25.4 to 0.26.0
dependabot[bot] commented on PR #1513: URL: https://github.com/apache/apisix-ingress-controller/pull/1513#issuecomment-1381479111 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch dependabot/go_modules/go.uber.org/multierr-1.9.0 updated (bf55aab2 -> 9fbba31d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/go.uber.org/multierr-1.9.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git discard bf55aab2 chore(deps): bump go.uber.org/multierr from 1.8.0 to 1.9.0 add 9208f582 docs: update APISIX CRD tutorial (#1544) add 39cffdc8 docs: update synchronization status check docs (#1548) add 60061d05 docs: update tutorial on installing APISIX in Kubernetes (#1550) add e734b2d7 chore: extra annotations logs (#1549) add 1c429936 fix: bad configuration item: apisix-admin-api-version (#1551) add b5e89cf6 chore: set v1.6 as protect branch (#1556) add 5f98bc17 docs: add match stream route with SNI tutorial (#1543) add 949c1da5 chore: admin-api default version v2 (#1558) add 695a5e1f docs: add instructions to use Network LoadBalancer (#1557) add 634b43f5 feat: sync route crd labels to apisix (#1526) add b62be90c chore(deps): bump github.com/onsi/ginkgo/v2 in /test/e2e (#1541) add 486b46ab chore: rename TranslateXXNotStrictly to GenerateXXDeleteMark (#1490) add 78272a54 docs: Update the-hard-way.md (#1581) (#1584) add d701fefb docs: add example link. (#1582) (#1583) add 84390d4f docs: add CHANGELOG for v1.6.0 (#1585) add 32561d01 fix: allow passing plugin config name for route with no backends (#1578) add 2024a09d docs: add note about enabling the Plugin (#1596) add d3f23598 docs: update controller to use adminAPIVersion=v3 (#1593) add eb0bd817 docs: update compatibility with APISIX (#1598) add 1acb058e chore(deps): bump dependencies from 0.25.4 to 0.26.0 (#1520) add 9fbba31d chore(deps): bump go.uber.org/multierr from 1.8.0 to 1.9.0 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (bf55aab2) \ N -- N -- N refs/heads/dependabot/go_modules/go.uber.org/multierr-1.9.0 (9fbba31d) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .asf.yaml | 3 + .github/workflows/codeql-analysis.yml | 2 +- .github/workflows/dependency-review.yml| 2 +- .github/workflows/e2e-test-ci-v2-cron.yml | 2 +- .github/workflows/e2e-test-ci.yml | 2 +- .github/workflows/golangci-lint.yml| 2 +- .github/workflows/license-checker.yml | 2 +- .github/workflows/lint-checker.yml | 2 +- .github/workflows/spell-checker.yml| 2 +- .github/workflows/unit-test-ci.yml | 2 +- .github/workflows/verify-codegen.yml | 2 +- .golangci.yml | 2 + CHANGELOG.md | 215 + Makefile | 6 +- conf/config-default.yaml | 3 +- docs/en/latest/concepts/apisix_route.md| 6 + docs/en/latest/deployments/ack.md | 7 +- docs/en/latest/deployments/aws.md | 27 ++- docs/en/latest/deployments/azure.md| 7 +- docs/en/latest/deployments/gke.md | 7 +- docs/en/latest/deployments/k3s-rke.md | 5 +- docs/en/latest/deployments/kind.md | 7 +- docs/en/latest/deployments/kubesphere.md | 7 +- docs/en/latest/deployments/minikube.md | 7 +- docs/en/latest/deployments/tke.md | 7 +- docs/en/latest/getting-started.md | 3 +- docs/en/latest/tutorials/check-crd-status.md | 73 +++--- ...ow-to-use-go-plugin-runner-in-apisix-ingress.md | 14 +- .../manage-certificates-with-cert-manager.md | 9 +- ...anage-ingress-certificates-with-cert-manager.md | 9 +- .../latest/tutorials/match-stream-route-by-sni.md | 230 ++ docs/en/latest/tutorials/mtls.md | 8 +- docs/en/latest/tutorials/proxy-grpc-service.md | 9 +- .../latest/tutorials/proxy-the-httpbin-service.md | 67 +++--- docs/en/latest/tutorials/the-hard-way.md | 266 +++-- go.mod | 34 +-- go.sum | 72 +++--- pkg/config/config.go | 4 + pkg/con
[GitHub] [apisix] soulbird commented on issue #8677: interface help urgently!!!
soulbird commented on issue #8677: URL: https://github.com/apache/apisix/issues/8677#issuecomment-1381481432 What does `apisix users` mean? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1520: chore(deps): bump dependencies from 0.25.4 to 0.26.0
tao12345666333 merged PR #1520: URL: https://github.com/apache/apisix-ingress-controller/pull/1520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed pull request #1511: chore(deps): bump k8s.io/code-generator from 0.25.4 to 0.26.0
tao12345666333 closed pull request #1511: chore(deps): bump k8s.io/code-generator from 0.25.4 to 0.26.0 URL: https://github.com/apache/apisix-ingress-controller/pull/1511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] soulbird commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh
soulbird commented on code in PR #405:
URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1069084512
##
centos/docker-entrypoint.sh:
##
@@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix}
if [[ "$1" == "docker-start" ]]; then
if [ "$APISIX_STAND_ALONE" = "true" ]; then
-cat > ${PREFIX}/conf/config.yaml << _EOC_
+if [ ! -f ${PREFIX}/conf/config.yaml ]; then
Review Comment:
So we should check config.yaml first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed pull request #1513: chore(deps): bump k8s.io/apimachinery from 0.25.4 to 0.26.0
tao12345666333 closed pull request #1513: chore(deps): bump k8s.io/apimachinery from 0.25.4 to 0.26.0 URL: https://github.com/apache/apisix-ingress-controller/pull/1513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dependabot[bot] commented on pull request #1514: chore(deps): bump k8s.io/api from 0.25.4 to 0.26.0
dependabot[bot] commented on PR #1514: URL: https://github.com/apache/apisix-ingress-controller/pull/1514#issuecomment-1381479120 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] dependabot[bot] commented on pull request #1512: chore(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0
dependabot[bot] commented on PR #1512: URL: https://github.com/apache/apisix-ingress-controller/pull/1512#issuecomment-1381479097 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: chore(deps): bump dependencies from 0.25.4 to 0.26.0 (#1520)
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 1acb058e chore(deps): bump dependencies from 0.25.4 to 0.26.0 (#1520) 1acb058e is described below commit 1acb058e2025d93a57283dec7b499c78ae568688 Author: Jintao Zhang AuthorDate: Fri Jan 13 16:35:02 2023 +0800 chore(deps): bump dependencies from 0.25.4 to 0.26.0 (#1520) * chore(deps): bump k8s.io/client-go from 0.25.4 to 0.26.0 Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.25.4 to 0.26.0. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.25.4...v0.26.0) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] * chore(deps): bump k8s.io/code-generator from 0.25.4 to 0.26.0 Signed-off-by: Jintao Zhang * chore: go mod tidy Signed-off-by: Jintao Zhang * lint: disable errcheck Signed-off-by: Jintao Zhang * chore: convert corev1.LoadBalancerIngress to other type Signed-off-by: Jintao Zhang Signed-off-by: dependabot[bot] Signed-off-by: Jintao Zhang Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .golangci.yml | 2 + go.mod | 34 +- go.sum | 72 ++-- .../apisix/apis/config/v2/zz_generated.deepcopy.go | 32 - .../apis/config/v2beta3/zz_generated.deepcopy.go | 16 - .../apisix/client/clientset/versioned/clientset.go | 3 +- .../client/informers/externalversions/factory.go | 79 -- pkg/providers/gateway/gateway.go | 31 + pkg/providers/ingress/ingress.go | 6 +- .../annotations/plugins/response_rewrite_test.go | 3 +- .../upstreamscheme/upstreamscheme_test.go | 3 +- pkg/providers/utils/ingress_status.go | 66 ++ test/e2e/go.mod| 8 +-- test/e2e/go.sum| 16 ++--- 14 files changed, 217 insertions(+), 154 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index b1c29baf..a99243c5 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -27,6 +27,8 @@ linters-settings: local-prefixes: github.com/apache/apisix-ingress-controller linters: + disable: +- errcheck enable: - goimports - govet diff --git a/go.mod b/go.mod index 9246784e..e97f1461 100644 --- a/go.mod +++ b/go.mod @@ -17,13 +17,13 @@ require ( github.com/xeipuuv/gojsonschema v1.2.0 go.uber.org/multierr v1.8.0 go.uber.org/zap v1.24.0 - golang.org/x/net v0.0.0-20220725212005-46097bf591d3 + golang.org/x/net v0.3.1-0.20221206200815-1e63c2f08a10 gopkg.in/natefinch/lumberjack.v2 v2.0.0 gopkg.in/yaml.v2 v2.4.0 - k8s.io/api v0.25.4 - k8s.io/apimachinery v0.25.4 - k8s.io/client-go v0.25.4 - k8s.io/code-generator v0.25.4 + k8s.io/api v0.26.0 + k8s.io/apimachinery v0.26.0 + k8s.io/client-go v0.26.0 + k8s.io/code-generator v0.26.0 sigs.k8s.io/gateway-api v0.5.1 sigs.k8s.io/yaml v1.3.0 ) @@ -32,7 +32,7 @@ require ( github.com/beorn7/perks v1.0.1 // indirect github.com/cespare/xxhash/v2 v2.1.2 // indirect github.com/davecgh/go-spew v1.1.1 // indirect - github.com/emicklei/go-restful/v3 v3.9.0 // indirect + github.com/emicklei/go-restful/v3 v3.10.1 // indirect github.com/evanphx/json-patch v4.12.0+incompatible // indirect github.com/gin-contrib/sse v0.1.0 // indirect github.com/go-logr/logr v1.2.3 // indirect @@ -47,8 +47,8 @@ require ( github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect github.com/golang/protobuf v1.5.2 // indirect github.com/google/gnostic v0.6.9 // indirect - github.com/google/go-cmp v0.5.8 // indirect - github.com/google/gofuzz v1.1.0 // indirect + github.com/google/go-cmp v0.5.9 // indirect + github.com/google/gofuzz v1.2.0 // indirect github.com/hashicorp/errwrap v1.0.0 // indirect github.com/hashicorp/go-immutable-radix v1.3.1 // indirect github.com/hashicorp/golang-lru v0.5.4 // indirect @@ -71,22 +71,22 @@ require ( github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f // indirect github.com/xeipuuv/gojs
[GitHub] [apisix] starsz opened a new issue, #8678: feat: As a user, I want to support send error-log to kafka, so that we can get error logs from kafka
starsz opened a new issue, #8678: URL: https://github.com/apache/apisix/issues/8678 ### Description Hi, folks. Now I found that we only support sending error log to `tcp server` , `skywalking`, `clickhouse ` . I want to support sending error log to kafka, so that we can collect `access log` and `error log` via kafka. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ronething commented on issue #8677: interface help urgently!!!
ronething commented on issue #8677: URL: https://github.com/apache/apisix/issues/8677#issuecomment-1381494258 > What does apisix users mean? maybe means `admin_key` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ronething commented on issue #8678: feat: As a user, I want to support send error-log to kafka, so that we can get error logs from kafka
ronething commented on issue #8678: URL: https://github.com/apache/apisix/issues/8678#issuecomment-1381495176 @starsz i will try this, please assign to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on issue #8678: feat: As a user, I want to support send error-log to kafka, so that we can get error logs from kafka
starsz commented on issue #8678: URL: https://github.com/apache/apisix/issues/8678#issuecomment-1381497320 > @starsz i will try this, please assign to me. Nice, look forward to this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] githubxubin commented on issue #8677: interface help urgently!!!
githubxubin commented on issue #8677: URL: https://github.com/apache/apisix/issues/8677#issuecomment-1381554647 > mean Whether there is interface to add manage user to login apisix-dashboard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #6087: request help: apisix latency sometime very high
github-actions[bot] commented on issue #6087: URL: https://github.com/apache/apisix/issues/6087#issuecomment-1381589046 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #6087: request help: apisix latency sometime very high
github-actions[bot] closed issue #6087: request help: apisix latency sometime very high URL: https://github.com/apache/apisix/issues/6087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ronething opened a new pull request, #8679: fix: check upstream conf in stream routes
ronething opened a new pull request, #8679: URL: https://github.com/apache/apisix/pull/8679 ### Description Fixes # (issue) check upstream conf in stream routes. ### Checklist - [x] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] JohnQI8888 opened a new issue, #8680: help request: 是否有文档可以指导实现多环境
JohnQI opened a new issue, #8680: URL: https://github.com/apache/apisix/issues/8680 ### Description 我们有多套环境， 我们希望在入口流量上 打上一个标签，让apisix 可以按照流量标签 分流。 比如 http 请求头里 包含 host: www.a.com 加上 ”env: env-1" 流量进去 192.168.2.1 实例 比如 http 请求头里 包含 host: www.a.com 加上 ”env: env-1" 流量进去 192.168.2.2 实例 比如 http 请求头里 包含 host: www.a.com 没有其他 标签 流量进去 192.168.2.3 实例 这样的功能， 该怎么样利用apisix 实现 ### Environment - APISIX version (run `apisix version`): - Operating system (run `uname -a`): - OpenResty / Nginx version (run `openresty -V` or `nginx -V`): - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`): - APISIX Dashboard version, if relevant: - Plugin runner version, for issues related to plugin runners: - LuaRocks version, for installation issues (run `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] MirtoBusico commented on a diff in pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"
MirtoBusico commented on code in PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#discussion_r1069349353 ## blog/en/blog/2023/01/Readme.md: ## @@ -0,0 +1 @@ +Placeholder Review Comment: I deleted the correct file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] e1ijah1 opened a new pull request, #8681: feat(file-logger): support standard output for file logger plugins
e1ijah1 opened a new pull request, #8681: URL: https://github.com/apache/apisix/pull/8681 ### Description support standard output for file logger plugins Fixes #6797 ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] NextStation commented on issue #8406: help request: Add Jwt-Plugin Return 400 Request Header Or Cookie Too Large
NextStation commented on issue #8406: URL: https://github.com/apache/apisix/issues/8406#issuecomment-1382110368 这个问题”400 Request Header Or Cookie Too Large“ 总是会出现再搭建apisix集群的时候。 通过docker-compose拉起2个apisix实例+3个etcd实例，请求jwt token（curl http://127.0.0.1:9080/apisix/plugin/jwt/sign?key=user-key -i）就会报这个400错误。 很明显，仅获取token，抓包并没发现过大的header。 查apisix的access日志，发起curl 指令的时候，每次apisix自动产生了682条请求，很神奇，难以理解。 如果用同样的容器镜像配置拉起单个apisix+etcd+dashboard的时候， token 就可以正常获取。 请问是否有标准的apisix集群 docker-compose.yml文件参考呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] pixeldin commented on issue #8646: help request: 3.1.0 report error cannot open logs/error: Permission denied
pixeldin commented on issue #8646: URL: https://github.com/apache/apisix/issues/8646#issuecomment-1382131522 ## Some reason Hi，community! This problem also occurs in my environment(ubuntu 22.04), after struggling for long time trying to figure out what is the problem, most of the solution I found pointed to mutual access permission issues between docker containers and your OS mounted filesystems. ## Solution refer to safe policy - @mscb402 If your machine supports SELinux command, such as (CentOS), maybe you can try update the access policy by `setenforce 0` temporarily. - In my environment，since the ubuntu system adopts the `AppArmor` to management file security access mode, some way for reference only is replace policy manager way with SELinux and I think that is a little complicated. https://www.linode.com/docs/guides/how-to-install-selinux-on-ubuntu-22-04/ ## Perhaps a less elegant way Finally, it somehow works in my env, my solution steps are： - First I change the docker-compose.yml configuration like this: ``` apisix: image: apache/apisix:latest restart: always volumes: - ./apisix_log:/usr/local/apisix/logs - ./apisix_conf/nginx.conf:/usr/local/apisix/conf/nginx.conf - ./apisix_conf/config.yaml:/usr/local/apisix/conf/config.yaml:ro - ./apisix_client_body_temp:/usr/local/apisix/client_body_temp - ./apisix_proxy_temp:/usr/local/apisix/proxy_temp ``` **I found the file volumes list above will be initialized by apisix startup in the docker's running log.** - And then pre-create them into your file location(like `apisix-docker/example/`) before the container starts. Maybe this is not a best solution, if anyone have a better idea, I hope to get your advice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] MarkCupitt commented on issue #8663: bug: failed to find any SSL certificate by SNI:
MarkCupitt commented on issue #8663: URL: https://github.com/apache/apisix/issues/8663#issuecomment-1382610007 Issue for upload via V3 api still remains Solution for Dashboard Concern Seems the Dashboard ONLY supports the V2 api which uses `/ssl`, whereas the V3 version of apisix requires certs to be loaded accessed form api `/ssls` #8173 #8599 #8183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ronething commented on issue #8680: help request: 是否有文档可以指导实现多环境
ronething commented on issue #8680: URL: https://github.com/apache/apisix/issues/8680#issuecomment-1382644253 maybe you need traffic-split plugin? refer: https://apisix.apache.org/docs/apisix/plugins/traffic-split/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] forget99 opened a new issue, #225: apisix-java-plugin-runner running success，but unable to connect by /usr/local/apisix/conf/apisix-1.sock
forget99 opened a new issue, #225: URL: https://github.com/apache/apisix-java-plugin-runner/issues/225 hello，my apisix-java-plugin-runner is running success，java runner is listening on the socket file: /usr/local/apisix/conf/apisix-1.sock，but unable to connect，project filter logs is not print。 runing logs as follows： . ___ _ _ /\\ / ___'_ __ _ _(_)_ __ __ _ \ \ \ \ ( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \ \\/ ___)| |_)| | | | | || (_| | ) ) ) ) ' || .__|_| |_|_| |_\__, | / / / / =|_|==|___/=/_/_/_/ :: Spring Boot ::(v2.7.1) , context: ngx.timer 2023/01/14 05:16:31 [warn] 47#47: *16 [lua] init.lua:955: 2023-01-14 05:16:31.099 INFO 57 --- [ main] c.e.d.DemoApplication : Starting DemoApplication v0.0.1-SNAPSHOT using Java 11.0.17 on 2d1dc15a24af with PID 57 (/opt/apisix-runner-bin/demo-0.0.1-SNAPSHOT.jar started by root in /usr/local/apisix) 2023-01-14 05:16:31.113 INFO 57 --- [ main] c.e.d.DemoApplication : No active profile set, falling back to 1 default profile: "default" , context: ngx.timer 2023/01/14 05:16:32 [warn] 47#47: *16 [lua] init.lua:955: 2023-01-14 05:16:32.644 INFO 57 --- [ main] c.e.d.DemoApplication : Started DemoApplication in 2.817 seconds (JVM running for 5.27) , context: ngx.timer 2023/01/14 05:16:33 [warn] 47#47: *16 [lua] init.lua:955: 2023-01-14 05:16:33.173 WARN 57 --- [ main] o.a.a.p.r.s.ApplicationRunner : java runner is listening on the socket file: /usr/local/apisix/conf/apisix-1.sock , context: ngx.timer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zlhgo opened a new issue, #8682: bug: apisix 3.x lost config cache values when etcd compacted
zlhgo opened a new issue, #8682:
URL: https://github.com/apache/apisix/issues/8682
### Current Behavior
https://github.com/apache/apisix/blob/df1cadb27744234f2f9fe6b6bfa5ea18442fb8e6/apisix/core/config_etcd.lua#L370
Perhaps should be
```lua
local dir_res, headers = res.body.node or {}, res.headers
```
#8675
### Expected Behavior
_No response_
### Error Logs
_No response_
### Steps to Reproduce
1.
```bash
etcdctl compact `etcdctl get -w json /apisix/upstreams/ | jq
.header.revision`
```
Perhaps this command should be run multiple times.
2. do not update related keys, for example global_rules.
3. wait a moment, the global plugins not working.
### Environment
- APISIX version (run `apisix version`): 3.1.0
- Operating system (run `uname -a`):
- OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
- etcd version, if relevant (run `curl
http://127.0.0.1:9090/v1/server_info`):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] forget99 commented on issue #218: request help: application success but the plugins can't work
forget99 commented on issue #218: URL: https://github.com/apache/apisix-java-plugin-runner/issues/218#issuecomment-1382674594 @Jimy-Guo I have the same problem as you，please modify apisix-docker/example/apisix_conf/config.yml，enbaled plugin，like this： plugins: - skywalking # 启用skywalking插件 - ext-plugin-pre-req # 开启插件 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
