[apisix-dashboard] branch master updated: feat: disable route's export OpenAPI func (#2802)
This is an automated email from the ASF dual-hosted git repository.
guoqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 764a04ea3 feat: disable route's export OpenAPI func (#2802)
764a04ea3 is described below
commit 764a04ea3e0f2fdfa50b69fc51bbd14fc6347295
Author: Qi Guo <979918...@qq.com>
AuthorDate: Wed May 10 13:51:32 2023 +0800
feat: disable route's export OpenAPI func (#2802)
---
docs/en/latest/modules/data_loader/openapi3.md | 9 ---
...mplate-create-edit-delete-plugin-template.cy.js | 3 +
web/src/pages/Route/List.tsx | 87 +-
web/src/pages/Route/service.ts | 6 +-
4 files changed, 6 insertions(+), 99 deletions(-)
diff --git a/docs/en/latest/modules/data_loader/openapi3.md
b/docs/en/latest/modules/data_loader/openapi3.md
index f3c5be6c4..433aaf78a 100644
--- a/docs/en/latest/modules/data_loader/openapi3.md
+++ b/docs/en/latest/modules/data_loader/openapi3.md
@@ -113,12 +113,3 @@ Save the upstream configuration.
6. Test API
Use the test tool to call the API to determine if it is configured correctly.
-
-### Export
-
-1. Open the route, and select routes you want to export.
- 
-2. Click `Export OpenAPI` button.
- 
-3. Select the export format, eg `Yaml`. Then click `Confirm` to export.
- 
diff --git
a/web/cypress/e2e/rest/pluginTemplate-create-edit-delete-plugin-template.cy.js
b/web/cypress/e2e/rest/pluginTemplate-create-edit-delete-plugin-template.cy.js
index 8cda4a74e..35e31aa66 100644
---
a/web/cypress/e2e/rest/pluginTemplate-create-edit-delete-plugin-template.cy.js
+++
b/web/cypress/e2e/rest/pluginTemplate-create-edit-delete-plugin-template.cy.js
@@ -46,7 +46,9 @@ context('Create Configure and Delete PluginTemplate', () => {
it('should create pluginTemplate', function () {
cy.visit('/');
+cy.intercept('GET', '/apisix/admin/routes?*').as('view');
cy.contains('Route').click();
+cy.wait('@view');
cy.get(selector.empty).should('be.visible');
cy.contains('Advanced').should('be.visible').click();
cy.contains('Advanced').trigger('mouseover');
@@ -95,6 +97,7 @@ context('Create Configure and Delete PluginTemplate', () => {
cy.contains('button', 'Search').click();
cy.contains(data.pluginTemplateName).siblings().contains('Configure').click();
+cy.get(selector.description).should('have.value', data.pluginTemplateName);
cy.get(selector.description).clear().type(data.pluginTemplateName2);
cy.contains('Next').click();
cy.contains('Next').click();
diff --git a/web/src/pages/Route/List.tsx b/web/src/pages/Route/List.tsx
index 7ff4d7de2..aa561c630 100755
--- a/web/src/pages/Route/List.tsx
+++ b/web/src/pages/Route/List.tsx
@@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-import { DownOutlined, ExportOutlined, ImportOutlined, PlusOutlined } from
'@ant-design/icons';
+import { DownOutlined, ImportOutlined, PlusOutlined } from '@ant-design/icons';
import { PageHeaderWrapper } from '@ant-design/pro-layout';
import type { ActionType, ProColumns } from '@ant-design/pro-table';
import ProTable from '@ant-design/pro-table';
@@ -22,23 +22,17 @@ import { useThrottleFn } from 'ahooks';
import {
Button,
Dropdown,
- Form,
Menu,
Modal,
notification,
Popconfirm,
- Radio,
Select,
Space,
Table,
Tag,
Tooltip,
} from 'antd';
-import { saveAs } from 'file-saver';
-import { js_beautify } from 'js-beautify';
-import yaml from 'js-yaml';
import { omit } from 'lodash';
-import moment from 'moment';
import type { ReactNode } from 'react';
import React, { useEffect, useRef, useState } from 'react';
import { history, useIntl } from 'umi';
@@ -50,16 +44,7 @@ import usePagination from '@/hooks/usePagination';
import DataLoaderImport from '@/pages/Route/components/DataLoader/Import';
import { DebugDrawView } from './components/DebugViews';
-import { EXPORT_FILE_MIME_TYPE_SUPPORTED } from './constants';
-import {
- create,
- exportRoutes,
- fetchLabelList,
- fetchList,
- remove,
- update,
- updateRouteStatus,
-} from './service';
+import { create, fetchLabelList, fetchList, remove, update, updateRouteStatus
} from './service';
const { OptGroup, Option } = Select;
@@ -72,11 +57,6 @@ const Page: React.FC = () => {
Publish,
}
- enum ExportFileType {
-JSON = 0,
-YAML,
- }
-
const [labelList, setLabelList] = useState({});
const [selectedRowKeys, setSelectedRowKeys] = useState([]);
const [showImportDrawer, setShowImportDrawer] = useState(false);
@@
[GitHub] [apisix-dashboard] guoqqqi merged pull request #2802: feat: disable route's export OpenAPI func
guoqqqi merged PR #2802: URL: https://github.com/apache/apisix-dashboard/pull/2802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lingliy commented on pull request #9334: feat: incremental route radixtree update
lingliy commented on PR #9334: URL: https://github.com/apache/apisix/pull/9334#issuecomment-1541347650 > I also really need this incremental update feature, there are two puzzles > > 1. According to the routing semantics of apisix, when route or service changes, the route is rebuilt, but service changes are not observed. How is the incremental update implemented >2.radixtree_host_uri.lua, radixtree_uri_with_parameter.lua, these two related incremental updates do not seem to be implemented >Finally, thank you very much for the implementation of feature I see. I read the semantics of version 2.9, and routes will not be rebuilt after service changes. Later versions will appear -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wklken commented on issue #9336: bug: error_log report error in the way apisix connected to etcd using gRPC
wklken commented on issue #9336: URL: https://github.com/apache/apisix/issues/9336#issuecomment-1541332122 we met the same error after upgrade from 3.2 to 3.3(same config, the 3.2 is ok) ``` 2023/05/10 04:16:12 [error] 584#584: *263473 upstream timed out (110: Connection timed out) while reading upstream, client: unix:, server: , request: "POST /v3/watch HTTP/1.1", upstream: "http://x.x.x.x:2379/v3/watch;, host: "127.0.0.1" ``` and in the same container, use curl to test the `/v3/watch`, no timed out error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ranxuxin001 commented on pull request #9334: feat: incremental route radixtree update
ranxuxin001 commented on PR #9334: URL: https://github.com/apache/apisix/pull/9334#issuecomment-1541331564 > > I also really need this incremental update feature, there are two puzzles > > > > 1. According to the routing semantics of apisix, when route or service changes, the route is rebuilt, but service changes are not observed. How is the incremental update implemented > >2.radixtree_host_uri.lua, radixtree_uri_with_parameter.lua, these two related incremental updates do not seem to be implemented > >Finally, thank you very much for the implementation of feature > > Thank you to send request. I wrote this patch based on apisix 2.9. The radixtree_uri.lua runs as default. So I mainly wrote codes for this strategy. Later I will wrote codes based on radixtree_host_uri.lua as the default strategy of apisix 3.3. > > I deleted codes rebuilding whote tree when version changed because the modifying routes codes are moved in the filter() called by sync_data(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ranxuxin001 commented on pull request #9334: feat: incremental route radixtree update
ranxuxin001 commented on PR #9334: URL: https://github.com/apache/apisix/pull/9334#issuecomment-1541330929 > I also really need this incremental update feature, there are two puzzles > > 1. According to the routing semantics of apisix, when route or service changes, the route is rebuilt, but service changes are not observed. How is the incremental update implemented >2.radixtree_host_uri.lua, radixtree_uri_with_parameter.lua, these two related incremental updates do not seem to be implemented >Finally, thank you very much for the implementation of feature Thank you to send request. I wrote this patch based on apisix 2.9. The radixtree_uri.lua runs as default. So I mainly wrote codes for this strategy. Later I will wrote codes based on radixtree_host_uri.lua. I deleted codes rebuilding whote tree when version changed because the modifying routes codes are moved in the filter() called by sync_data(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] freemindcore commented on issue #9009: bug: response-rewrite in v2.15.3 does not remove header when setting to ""
freemindcore commented on issue #9009: URL: https://github.com/apache/apisix/issues/9009#issuecomment-1541276133 > Nope, I could not find any. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (c02abcfb4 -> fc06d79ce)
This is an automated email from the ASF dual-hosted git repository. monkeydluffy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from c02abcfb4 fix: body-transformer plugin return raw body anytime (#9446) add fc06d79ce fix: 404 error in ci test (#9447) No new revisions were added by this update. Summary of changes: ci/linux_openresty_common_runner.sh | 2 ++ 1 file changed, 2 insertions(+)
[GitHub] [apisix] monkeyDluffy6017 merged pull request #9447: fix: 404 error in ci test
monkeyDluffy6017 merged PR #9447: URL: https://github.com/apache/apisix/pull/9447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 closed issue #9417: ci: the CI is unstable
monkeyDluffy6017 closed issue #9417: ci: the CI is unstable URL: https://github.com/apache/apisix/issues/9417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jiangfucheng commented on issue #9443: bug: http-logger plugin gives 400 error while pushing the logs to HTTP server
jiangfucheng commented on issue #9443: URL: https://github.com/apache/apisix/issues/9443#issuecomment-1541267366 Please assign it to me, I will fix it, thanks for you report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix: body-transformer plugin return raw body anytime (#9446)
This is an automated email from the ASF dual-hosted git repository.
monkeydluffy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new c02abcfb4 fix: body-transformer plugin return raw body anytime (#9446)
c02abcfb4 is described below
commit c02abcfb47a9905210c6235082107ef6d31d2689
Author: Sn0rt
AuthorDate: Wed May 10 11:06:22 2023 +0800
fix: body-transformer plugin return raw body anytime (#9446)
---
apisix/plugins/body-transformer.lua | 3 +-
t/plugin/body-transformer.t | 57 +
2 files changed, 59 insertions(+), 1 deletion(-)
diff --git a/apisix/plugins/body-transformer.lua
b/apisix/plugins/body-transformer.lua
index 9ca6b86ba..1d1afa06e 100644
--- a/apisix/plugins/body-transformer.lua
+++ b/apisix/plugins/body-transformer.lua
@@ -112,7 +112,7 @@ end
local function transform(conf, body, typ, ctx)
-local out = {_body = body}
+local out = {}
if body then
local err
local format = conf[typ].input_format
@@ -137,6 +137,7 @@ local function transform(conf, body, typ, ctx)
end
out._ctx = ctx
+out._body = body
out._escape_xml = escape_xml
out._escape_json = escape_json
local ok, render_out = pcall(render, out)
diff --git a/t/plugin/body-transformer.t b/t/plugin/body-transformer.t
index be07f9ac0..fd21621cb 100644
--- a/t/plugin/body-transformer.t
+++ b/t/plugin/body-transformer.t
@@ -764,3 +764,60 @@ location /demo {
assert(res2.headers["Apisix-Cache-Status"] == "HIT")
}
}
+
+
+
+=== TEST 11: return raw body with _body anytime
+--- http_config
+--- config
+location /demo {
+content_by_lua_block {
+ngx.header.content_type = "application/json"
+ngx.print('{"result": "hello world"}')
+}
+}
+
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin")
+
+local rsp_template = ngx.encode_base64[[
+{"raw_body": {*_escape_json(_body)*}, "result":
{*_escape_json(result)*}}
+]]
+
+local code, body = t.test('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+string.format([[{
+"uri": "/capital",
+"plugins": {
+"proxy-rewrite": {
+"uri": "/demo"
+},
+"body-transformer": {
+"response": {
+"template": "%s"
+}
+}
+},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:%d": 1
+}
+}
+}]], rsp_template, ngx.var.server_port)
+)
+
+local core = require("apisix.core")
+local http = require("resty.http")
+local uri = "http://127.0.0.1:; .. ngx.var.server_port ..
"/capital"
+local opt = {method = "GET", headers = {["Content-Type"] =
"application/json"}}
+local httpc = http.new()
+
+local res = httpc:request_uri(uri, opt)
+assert(res.status == 200)
+local data = core.json.decode(res.body)
+assert(data.result == "hello world")
+assert(data.raw_body == '{"result": "hello world"}')
+}
+}
[GitHub] [apisix] monkeyDluffy6017 merged pull request #9446: fix: body-transformer plugin return raw body anytime
monkeyDluffy6017 merged PR #9446: URL: https://github.com/apache/apisix/pull/9446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 closed issue #9413: feat: As a user, I want to do some data formatting in the body-transformer plugin
monkeyDluffy6017 closed issue #9413: feat: As a user, I want to do some data formatting in the body-transformer plugin URL: https://github.com/apache/apisix/issues/9413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt commented on pull request #9447: fix: 404 error in ci test
Sn0rt commented on PR #9447: URL: https://github.com/apache/apisix/pull/9447#issuecomment-1541251295 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on pull request #543: chore: upgrade APISIX to 3.3.0
Gallardot commented on PR #543: URL: https://github.com/apache/apisix-helm-chart/pull/543#issuecomment-1541249261 > Change the default router from `radixtree_uri` to `radixtree_host_uri`. Perhaps we should be consistent with APISIX? > > https://github.com/apache/apisix-helm-chart/blob/5092739f02dd9d29587ed319f797f23e0992c019/charts/apisix/values.yaml#L65-L69 > > https://github.com/apache/apisix/blob/master/CHANGELOG.md#change Done. PTAL. @AlinsRan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 opened a new pull request, #9452: test: replace all httpbin upstream
monkeyDluffy6017 opened a new pull request, #9452: URL: https://github.com/apache/apisix/pull/9452 ### Description We use httpbin.org as an upstream in many of our test cases, but this service is not stable and often causes ci tests to fail Fixes #9417 ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [x] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anilaws opened a new issue, #9451: request: OpenSSL/3.0.8: error:0A000438:SSL routines::tlsv1 alert internal error
anilaws opened a new issue, #9451: URL: https://github.com/apache/apisix/issues/9451 ### Description followed https://apisix.apache.org/docs/ingress-controller/deployments/aws/ and deployed apisix gateway using NLB on EKS. http://apsisix-gateway-url/ works fine. I have enabled tls on gateway and when i try https://apsisix-gateway-url/ , i am getting error OpenSSL/3.0.8: error:0A000438:SSL routines::tlsv1 alert internal error I even tried hitting the gateway service without the load balancer URL from one of the pods inside the cluster curl -kv https://apisix-gateway.ingress-apisix.svc.cluster.local/headers -H 'Host: local.httpbin.org' * Trying 172.20.168.24:443... * Connected to apisix-gateway.ingress-apisix.svc.cluster.local (172.20.168.24) port 443 (#0) * ALPN: offers h2,http/1.1 * TLSv1.3 (OUT), TLS handshake, Client hello (1): * TLSv1.3 (IN), TLS alert, internal error (592): * OpenSSL/3.0.8: error:0A000438:SSL routines::tlsv1 alert internal error * Closing connection 0 curl: (35) OpenSSL/3.0.8: error:0A000438:SSL routines::tlsv1 alert internal error ### Environment - APISIX version (run `apisix version`): 3.2.0 - Operating system (run `uname -a`): Linux apisix-6bfbd9c7cb-jjvql 5.15.93-55.139.amzn2.x86_64 #1 SMP Tue Feb 14 21:47:11 UTC 2023 x86_64 GNU/Linux - OpenResty / Nginx version (run `openresty -V` or `nginx -V`): nginx version: openresty/1.21.4.1 - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`): - APISIX Dashboard version, if relevant: - Plugin runner version, for issues related to plugin runners: - LuaRocks version, for installation issues (run `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek closed pull request #9402: fix: syslog double encoding message
shreemaan-abhishek closed pull request #9402: fix: syslog double encoding message URL: https://github.com/apache/apisix/pull/9402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wklken commented on issue #9366: bug: Adding routes to a Radix Tree in a different order can lead to the same URL matching the first added route instead of the longest path match
wklken commented on issue #9366: URL: https://github.com/apache/apisix/issues/9366#issuecomment-1541206696 after check [lua-resty-radixtree](https://github.com/api7/lua-resty-radixtree) and [chi router](https://github.com/go-chi/chi) Conclusion: 1. Without any parameters and subpath, the result is independent of the registration order, and the longest match is used. - path: `/api/test/prod/test` - path: `/api/test/prod/` 2. Without any parameters, but with subpath, the result is independent of the registration order, and the longest match is used. - path: `/api/test/prod/*subp` - path: `/api/test/prod/webconsole/*subp` 3. With parameters and subpath, the result is dependent on the registration order and is not the longest match (this is not an issue with the golang version of radixtree). - path: `/api/test/prod/:v/*subp` - path: `/api/test/prod/:v/webconsole/*subp` - path: `/api/test/prod/v4/webconsole/*subp` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on pull request #9401: fix: support $hostname in skywalking service_instance_name
shreemaan-abhishek commented on PR #9401: URL: https://github.com/apache/apisix/pull/9401#issuecomment-1541203324 > It looks like just a pick from other branch: #7252 @monkeyDluffy6017 Oh yes, it is. But that branch wasn't merged to master so this issue still exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt commented on pull request #9402: fix: syslog double encoding message
Sn0rt commented on PR #9402: URL: https://github.com/apache/apisix/pull/9402#issuecomment-1541192058 > @Sn0rt Should this pr be closed? sorry. I can't see the close button. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
Sn0rt commented on code in PR #9388:
URL: https://github.com/apache/apisix/pull/9388#discussion_r1189277500
##
t/APISIX.pm:
##
@@ -743,6 +744,8 @@ _EOC_
}
location / {
+set \$upstream_mirror_scheme '';
Review Comment:
yep. not need this var anymore. I will rollback some change.
##
apisix/plugins/proxy-mirror.lua:
##
@@ -114,12 +117,14 @@ function _M.rewrite(conf, ctx)
if conf.sample_ratio == 1 then
enable_mirror(ctx, conf)
+ctx.enable_mirror = 1
Review Comment:
of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] wklken closed issue #9428: help request: apisix 3.3.0 docker image missing
wklken closed issue #9428: help request: apisix 3.3.0 docker image missing URL: https://github.com/apache/apisix/issues/9428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wklken commented on issue #9428: help request: apisix 3.3.0 docker image missing
wklken commented on issue #9428: URL: https://github.com/apache/apisix/issues/9428#issuecomment-1541181589 closed, can be found now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on pull request #1568: docs: add 10 api management trends blog
yzeng25 commented on PR #1568: URL: https://github.com/apache/apisix-website/pull/1568#issuecomment-1541180219 @SylviaBABY @SkyeYoung I updated the file, should be good to go after checks, PTAL when available, thanks. cc @KID-G -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on issue #1583: [Site]: Clicking on the doc version dropdown will bring the doc page to the first available doc
yzeng25 commented on issue #1583: URL: https://github.com/apache/apisix-website/issues/1583#issuecomment-1541177756 cc @SkyeYoung -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a diff in pull request #2801: feat: disable route export openapi func
guoqqqi commented on code in PR #2801: URL: https://github.com/apache/apisix-dashboard/pull/2801#discussion_r1189276635 ## web/yarn.lock: ## Review Comment: We do not need to submit this file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2802: feat: disable route's export OpenAPI func
codecov-commenter commented on PR #2802: URL: https://github.com/apache/apisix-dashboard/pull/2802#issuecomment-1541171202 ## [Codecov](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2802?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2802](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2802?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (83cf414) into [master](https://app.codecov.io/gh/apache/apisix-dashboard/commit/8390d3dfd53bae19fc31e5dbc8753882e69a8ff3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8390d3d) will **decrease** coverage by `0.64%`. > The diff coverage is `n/a`. > :exclamation: Current head 83cf414 differs from pull request most recent head b2d5dcf. Consider uploading reports for the commit b2d5dcf to get more accurate results ```diff @@Coverage Diff @@ ## master#2802 +/- ## == - Coverage 68.61% 67.98% -0.64% == Files 139 39 -100 Lines3769 1040-2729 Branches 883 268 -615 == - Hits 2586 707-1879 + Misses 1183 333 -850 ``` | Flag | Coverage Δ | | |---|---|---| | frontend-e2e-test | `67.98% <ø> (-0.64%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. [see 114 files with indirect coverage changes](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2802/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] AlinsRan commented on pull request #543: chore: upgrade APISIX to 3.3.0
AlinsRan commented on PR #543: URL: https://github.com/apache/apisix-helm-chart/pull/543#issuecomment-1541165718 Change the default router from radixtree_uri to radixtree_host_uri. Perhaps we should be consistent with APISIX? https://github.com/apache/apisix-helm-chart/blob/5092739f02dd9d29587ed319f797f23e0992c019/charts/apisix/values.yaml#L65-L69 https://github.com/apache/apisix/blob/master/CHANGELOG.md#change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi opened a new pull request, #2802: fix: disable route's export OpenAPI func
guoqqqi opened a new pull request, #2802: URL: https://github.com/apache/apisix-dashboard/pull/2802 Please answer these questions before submitting a pull request, **or your PR will get closed**. - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. **Related issues** fix/resolve #0001 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [x] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
Sn0rt commented on code in PR #9388: URL: https://github.com/apache/apisix/pull/9388#discussion_r1189268288 ## apisix/init.lua: ## @@ -711,11 +712,16 @@ function _M.grpc_access_phase() return end + Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] github-actions[bot] closed issue #1435: request help: upgrade 2.14.1 to 2.15
github-actions[bot] closed issue #1435: request help: upgrade 2.14.1 to 2.15 URL: https://github.com/apache/apisix-ingress-controller/issues/1435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] github-actions[bot] commented on issue #1435: request help: upgrade 2.14.1 to 2.15
github-actions[bot] commented on issue #1435: URL: https://github.com/apache/apisix-ingress-controller/issues/1435#issuecomment-1541147115 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
Sn0rt commented on code in PR #9388: URL: https://github.com/apache/apisix/pull/9388#discussion_r1189265668 ## docs/zh/latest/plugins/proxy-mirror.md: ## @@ -40,9 +40,9 @@ description: 本文介绍了 Apache APISIX proxy-mirror 插件的相关操作， | 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 | | | -- | -- | -- | -- | --- | -| host | string | 是 ||| 指定镜像服务的地址，地址中需要包含 `schema`（`http` 或 `https`），但不能包含 `path` 部分。例如 `http://127.0.0.1:9797`。 | -| path | string | 否 ||| 指定镜像请求的路径。如果不指定，则默认会使用当前路径。 | -| path_concat_mode | string | 否 | replace | ["replace", "prefix"] | 当指定镜像请求的路径时，设置请求路径的拼接模式。`replace` 模式将会直接使用 `path` 作为镜像请求的路径。`prefix` 模式将会使用 `path` + `来源请求 URI` 作为镜像请求的路径。 | +| host | string | 是 ||| 指定镜像服务的地址，地址中需要包含 `schema`（`http(s)` 或 `grpc(s)`），但不能包含 `path` 部分。例如 `http://127.0.0.1:9797`。 | +| path | string | 否 ||| 指定镜像请求的路径。如果不指定，则默认会使用当前路径。如果是为了镜像 grpc 流量，这个选项不再适用。| Review Comment: At present, the document format is one case for one plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
Sn0rt commented on code in PR #9388: URL: https://github.com/apache/apisix/pull/9388#discussion_r1189265668 ## docs/zh/latest/plugins/proxy-mirror.md: ## @@ -40,9 +40,9 @@ description: 本文介绍了 Apache APISIX proxy-mirror 插件的相关操作， | 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 | | | -- | -- | -- | -- | --- | -| host | string | 是 ||| 指定镜像服务的地址，地址中需要包含 `schema`（`http` 或 `https`），但不能包含 `path` 部分。例如 `http://127.0.0.1:9797`。 | -| path | string | 否 ||| 指定镜像请求的路径。如果不指定，则默认会使用当前路径。 | -| path_concat_mode | string | 否 | replace | ["replace", "prefix"] | 当指定镜像请求的路径时，设置请求路径的拼接模式。`replace` 模式将会直接使用 `path` 作为镜像请求的路径。`prefix` 模式将会使用 `path` + `来源请求 URI` 作为镜像请求的路径。 | +| host | string | 是 ||| 指定镜像服务的地址，地址中需要包含 `schema`（`http(s)` 或 `grpc(s)`），但不能包含 `path` 部分。例如 `http://127.0.0.1:9797`。 | +| path | string | 否 ||| 指定镜像请求的路径。如果不指定，则默认会使用当前路径。如果是为了镜像 grpc 流量，这个选项不再适用。| Review Comment: At present, the document format is a case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Fabriceli commented on issue #1805: request help: How to set up global plugin config?
Fabriceli commented on issue #1805: URL: https://github.com/apache/apisix-ingress-controller/issues/1805#issuecomment-1541132902 @tao12345666333 `ApisixGlobalRule` has released in 1.6.1 version? ```sh error: the server doesn't have a resource type "ApisixGlobalRule" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9401: fix: support $hostname in skywalking service_instance_name
monkeyDluffy6017 commented on PR #9401: URL: https://github.com/apache/apisix/pull/9401#issuecomment-1541123868 It looks like just a pick from other branch: https://github.com/apache/apisix/pull/7252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #9423: feat(proxy-rewrite): proxy-rewrite plugin support `vars` conditional expression
soulbird commented on PR #9423: URL: https://github.com/apache/apisix/pull/9423#issuecomment-1541105199 This feature is already implemented: https://github.com/apache/apisix/blob/master/docs/en/latest/terminology/plugin.md#custom-plugin-priority -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Fabriceli commented on a diff in pull request #9423: feat(proxy-rewrite): proxy-rewrite plugin support `vars` conditional expression
Fabriceli commented on code in PR #9423: URL: https://github.com/apache/apisix/pull/9423#discussion_r1189255947 ## apisix/plugins/proxy-rewrite.lua: ## @@ -233,6 +237,21 @@ do core.table.insert(upstream_names, name) end +local function vars_matched(conf, ctx) +if not conf.vars then +return true +end + +if not conf.proxy_expr then +local proxy_expr, _ = expr.new(conf.vars) +conf.proxy_expr = proxy_expr +end + +local match_result = conf.proxy_expr:eval(ctx.var) +core.log.error(match_result) Review Comment: Why print the `match_result` each time as a error log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] AlinsRan opened a new pull request, #9450: fix: failed to configure `key: mqtt_client_id` using upstream
AlinsRan opened a new pull request, #9450: URL: https://github.com/apache/apisix/pull/9450 ### Description Fixes #9449 ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] AlinsRan opened a new issue, #9449: bug: failed to configure `key: mqtt_client_id` using upstream
AlinsRan opened a new issue, #9449:
URL: https://github.com/apache/apisix/issues/9449
### Current Behavior
When stream_route references an upstream, it cannot configure `key:
mqtt_client_id` for load balancing in the upstream.
### Expected Behavior
_No response_
### Error Logs
_No response_
### Steps to Reproduce
```shell
curl --noproxy '*' http://apisix-admin:9180/apisix/admin/upstreams/mqtt -H
'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"nodes": {
"httpbin.org:80": 1
},
"type": "chash",
"key": "mqtt_client_id"
}
'
{"error_msg":"invalid configuration: failed to match pattern
\"^((uri|server_name|server_addr|request_uri|remote_port|remote_addr|query_string|host|hostname)|arg_[0-9a-zA-z_-]+)$\"
with \"mqtt_client_id\""}
```
### Environment
- APISIX version (run `apisix version`): 3.2.0
- Operating system (run `uname -a`):
- OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
- etcd version, if relevant (run `curl
http://127.0.0.1:9090/v1/server_info`):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] shreemaan-abhishek closed pull request #1531: chore: add go.work files
shreemaan-abhishek closed pull request #1531: chore: add go.work files URL: https://github.com/apache/apisix-ingress-controller/pull/1531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on issue #9009: bug: response-rewrite in v2.15.3 does not remove header when setting to ""
shreemaan-abhishek commented on issue #9009: URL: https://github.com/apache/apisix/issues/9009#issuecomment-1540636185 Do you notice any error logs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9402: fix: syslog double encoding message
monkeyDluffy6017 commented on PR #9402: URL: https://github.com/apache/apisix/pull/9402#issuecomment-1540417899 @Sn0rt Should this pr be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
monkeyDluffy6017 commented on code in PR #9388: URL: https://github.com/apache/apisix/pull/9388#discussion_r1188789599 ## docs/zh/latest/plugins/proxy-mirror.md: ## @@ -40,9 +40,9 @@ description: 本文介绍了 Apache APISIX proxy-mirror 插件的相关操作， | 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 | | | -- | -- | -- | -- | --- | -| host | string | 是 ||| 指定镜像服务的地址，地址中需要包含 `schema`（`http` 或 `https`），但不能包含 `path` 部分。例如 `http://127.0.0.1:9797`。 | -| path | string | 否 ||| 指定镜像请求的路径。如果不指定，则默认会使用当前路径。 | -| path_concat_mode | string | 否 | replace | ["replace", "prefix"] | 当指定镜像请求的路径时，设置请求路径的拼接模式。`replace` 模式将会直接使用 `path` 作为镜像请求的路径。`prefix` 模式将会使用 `path` + `来源请求 URI` 作为镜像请求的路径。 | +| host | string | 是 ||| 指定镜像服务的地址，地址中需要包含 `schema`（`http(s)` 或 `grpc(s)`），但不能包含 `path` 部分。例如 `http://127.0.0.1:9797`。 | +| path | string | 否 ||| 指定镜像请求的路径。如果不指定，则默认会使用当前路径。如果是为了镜像 grpc 流量，这个选项不再适用。| Review Comment: could you give an example about how to use grpc mirror in doc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
monkeyDluffy6017 commented on code in PR #9388:
URL: https://github.com/apache/apisix/pull/9388#discussion_r1188786154
##
t/APISIX.pm:
##
@@ -743,6 +744,8 @@ _EOC_
}
location / {
+set \$upstream_mirror_scheme '';
Review Comment:
upstream_mirror_scheme is not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
monkeyDluffy6017 commented on code in PR #9388: URL: https://github.com/apache/apisix/pull/9388#discussion_r1188748118 ## apisix/plugins/proxy-mirror.lua: ## @@ -114,12 +117,14 @@ function _M.rewrite(conf, ctx) if conf.sample_ratio == 1 then enable_mirror(ctx, conf) +ctx.enable_mirror = 1 Review Comment: Is `true` better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
monkeyDluffy6017 commented on code in PR #9388: URL: https://github.com/apache/apisix/pull/9388#discussion_r1188746769 ## apisix/init.lua: ## @@ -711,11 +712,16 @@ function _M.grpc_access_phase() return end + Review Comment: remove this blank -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2801: feat: disable route export openapi func
codecov-commenter commented on PR #2801: URL: https://github.com/apache/apisix-dashboard/pull/2801#issuecomment-1540283921 ## [Codecov](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2801?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2801](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2801?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3605145) into [master](https://app.codecov.io/gh/apache/apisix-dashboard/commit/8390d3dfd53bae19fc31e5dbc8753882e69a8ff3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8390d3d) will **decrease** coverage by `20.60%`. > The diff coverage is `n/a`. > :exclamation: Current head 3605145 differs from pull request most recent head b53325e. Consider uploading reports for the commit b53325e to get more accurate results ```diff @@ Coverage Diff @@ ## master#2801 +/- ## === - Coverage 68.61% 48.01% -20.60% === Files 139 46 -93 Lines3769 3145 -624 Branches 8830 -883 === - Hits 2586 1510 -1076 - Misses 1183 1450 +267 - Partials0 185 +185 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `48.01% <ø> (?)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. [see 185 files with indirect coverage changes](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2801/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] monkeyDluffy6017 opened a new pull request, #2801: feat: disable route export openapi func
monkeyDluffy6017 opened a new pull request, #2801: URL: https://github.com/apache/apisix-dashboard/pull/2801 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** The export openapi func doesn't work well, we need to disable it for now **Related issues** fix/resolve #0001 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [x] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch disable-openapi-export deleted (was dc5beb925)
This is an automated email from the ASF dual-hosted git repository. monkeydluffy pushed a change to branch disable-openapi-export in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git was dc5beb925 feat: disable route export openapi func This change permanently discards the following revisions: discard dc5beb925 feat: disable route export openapi func
[apisix-dashboard] branch disable-openapi-export created (now dc5beb925)
This is an automated email from the ASF dual-hosted git repository. monkeydluffy pushed a change to branch disable-openapi-export in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git at dc5beb925 feat: disable route export openapi func This branch includes the following new commits: new dc5beb925 feat: disable route export openapi func The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix] jiangfucheng opened a new pull request, #9448: feat(ua-restriction): support allowlist-only mode
jiangfucheng opened a new pull request, #9448: URL: https://github.com/apache/apisix/pull/9448 ### Description Close https://github.com/apache/apisix/issues/7467 ### Checklist - [x] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [x] I have added tests corresponding to this change - [x] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 closed issue #1505: [Site]: Wrong image
yzeng25 closed issue #1505: [Site]: Wrong image URL: https://github.com/apache/apisix-website/issues/1505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 merged pull request #1584: docs: fix wrong image
yzeng25 merged PR #1584: URL: https://github.com/apache/apisix-website/pull/1584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on issue #1505: [Site]: Wrong image
yzeng25 commented on issue #1505: URL: https://github.com/apache/apisix-website/issues/1505#issuecomment-1540093685 Closed via https://github.com/apache/apisix-website/pull/1584, thanks @Fabriceli ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix wrong image (#1584)
This is an automated email from the ASF dual-hosted git repository. yilinzeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 66b7e2a0525 fix wrong image (#1584) 66b7e2a0525 is described below commit 66b7e2a0525c33ffec5fb2d1bc961641214d27e7 Author: fabriceli AuthorDate: Tue May 9 21:07:20 2023 +0800 fix wrong image (#1584) --- blog/en/blog/2021/10/09/apisix-ingress-techblog.md | 4 ++-- blog/zh/blog/2021/10/09/apisix-ingress-techblog.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/blog/en/blog/2021/10/09/apisix-ingress-techblog.md b/blog/en/blog/2021/10/09/apisix-ingress-techblog.md index 1949801bf1b..bbf60a455fb 100644 --- a/blog/en/blog/2021/10/09/apisix-ingress-techblog.md +++ b/blog/en/blog/2021/10/09/apisix-ingress-techblog.md @@ -141,13 +141,13 @@ By using APISIX Ingress, you can achieve the effect of proportional traffic slic Step 1: Configure APISIX Upstream - + Step 2: Configure APISIX Route Configure `subset` and `weight` in `backends` to split the incoming user request traffic. The example below shows that 90% of the traffic will go to v1 and 10% of the traffic will go to v2. - + With the above two steps, it is very easy to slice and dice traffic proportionally to achieve scenarios like canary release. For more details, please refer to: [Traffic Segmentation in Apache APISIX Ingress Controller](https://www.apiseven.com/zh/blog/traffic-split-in-apache-apisix-ingress-controller). diff --git a/blog/zh/blog/2021/10/09/apisix-ingress-techblog.md b/blog/zh/blog/2021/10/09/apisix-ingress-techblog.md index b59db29a57a..62df18f0bb1 100644 --- a/blog/zh/blog/2021/10/09/apisix-ingress-techblog.md +++ b/blog/zh/blog/2021/10/09/apisix-ingress-techblog.md @@ -142,13 +142,13 @@ APISIX TLS 主要是为了进行证书的管理。如示例所示，用户可以 步骤一：配置 APISIX Upstream - + 步骤二：配置 APISIX Route 通过在 `backends` 中去配置 `subset` 和 `weight`，来实现用户请求流量进入时的分流。如下图示例就是 90% 的流量会进入到 v1 中，10% 的流量进入到 v2 中。 - + 通过以上两步，就可以十分方便地按比例进行流量切分，实现类似灰度发布等场景需求。 更多具体操作细节也可参考：[Apache APISIX Ingress Controller 中的流量切分](https://www.apiseven.com/zh/blog/traffic-split-in-apache-apisix-ingress-controller)。
[GitHub] [apisix-website] SkyeYoung commented on pull request #1568: docs: add 10 api management trends blog
SkyeYoung commented on PR #1568: URL: https://github.com/apache/apisix-website/pull/1568#issuecomment-1539967540 @KID-G any update here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] SylviaBABY commented on pull request #1568: docs: add 10 api management trends blog
SylviaBABY commented on PR #1568: URL: https://github.com/apache/apisix-website/pull/1568#issuecomment-1539956936 As there haven't been any changes in this PR for quite some time, I would recommend closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Fabriceli commented on pull request #1584: fix: fix wrong image
Fabriceli commented on PR #1584: URL: https://github.com/apache/apisix-website/pull/1584#issuecomment-1539945051 @yzeng25 @SkyeYoung @SylviaBABY please take a look at this PR, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #1584: fix: fix wrong image
netlify[bot] commented on PR #1584: URL: https://github.com/apache/apisix-website/pull/1584#issuecomment-1539942862 ### Deploy Preview for *apache-apisix* processing. | Name | Link | |:-:|| | Latest commit | 583c0e0a70238f9fa710c77f4152b2191267676b | | Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/645a2496fe5f490008b9cf34 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Fabriceli opened a new pull request, #1584: fix: fix wrong image
Fabriceli opened a new pull request, #1584: URL: https://github.com/apache/apisix-website/pull/1584 Fixes: #[Add issue number here] #1505 Changes: Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kayx23 commented on issue #9433: apisix have more globalrules
kayx23 commented on issue #9433: URL: https://github.com/apache/apisix/issues/9433#issuecomment-1539932740 As for determining which phase the plugin runs in, it seems that the current plugin docs do not address this info (either intentionally or unintentionally). Def some room for improvements here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kayx23 commented on issue #9433: apisix have more globalrules
kayx23 commented on issue #9433: URL: https://github.com/apache/apisix/issues/9433#issuecomment-1539923862 Hi @kellyseeme , you can adjust the order of execution by plugin priorities, given that they are executed in the same phase (e.g. rewrite, access). In your case, `ip-restriction` has a [default priority of 3000](https://github.com/apache/apisix/blob/e85ef647471effdc2eb861a9bc29565660172558/conf/config-default.yaml#L426). Not sure about your other arbitrary plugin. So two cases: 1. if two plugins are executed in the same phase, then whichever plugin has the higher priority will be executed first. 2. if two plugins are executed in different phases, say [`ip-restriction` is in rewrite](https://github.com/apache/apisix/blob/e85ef647471effdc2eb861a9bc29565660172558/apisix/plugins/ip-restriction.lua#L23) and the other one is in access, then the logic of rewrite will be executed before the logic of access, regardless of priority. For more info, see [Plugin Execution Order](https://docs.api7.ai/apisix/key-concepts/plugins#plugins-execution-order) doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 opened a new pull request, #9447: fix: 404 error in ci test
monkeyDluffy6017 opened a new pull request, #9447: URL: https://github.com/apache/apisix/pull/9447 ### Description The following error always occurs in ci tests because the ETCD is not initialised  Fixes # (issue) ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #6962: help request: Why does apisix not have lua-resty-openssl?
github-actions[bot] closed issue #6962: help request: Why does apisix not have lua-resty-openssl? URL: https://github.com/apache/apisix/issues/6962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #6962: help request: Why does apisix not have lua-resty-openssl?
github-actions[bot] commented on issue #6962: URL: https://github.com/apache/apisix/issues/6962#issuecomment-1539840457 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #6702: How to register and use custom variable?
github-actions[bot] commented on issue #6702: URL: https://github.com/apache/apisix/issues/6702#issuecomment-1539840330 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] commented on pull request #442: fix: ETCD_ADVERTISE_CLIENT_URLS of arm64
github-actions[bot] commented on PR #442: URL: https://github.com/apache/apisix-docker/pull/442#issuecomment-1539838676 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt opened a new pull request, #9446: fix: body-transformer plugin return raw body anytime
Sn0rt opened a new pull request, #9446: URL: https://github.com/apache/apisix/pull/9446 ### Description Fixes #9413 ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [x] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kayx23 opened a new pull request, #9445: chore: removed duplicated `protos.t` and renamed file
kayx23 opened a new pull request, #9445: URL: https://github.com/apache/apisix/pull/9445 ### Description [protos.t](https://github.com/apache/apisix/blob/master/t/admin/protos.t) is a duplicate of TEST 1 in [proto.t](https://github.com/apache/apisix/blob/master/t/admin/proto.t). In this PR: * deleted `protos.t` * renamed `proto.t` to `protos.t` Fixes #9403 ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [x] I have added tests corresponding to this change **(N/A)** - [x] I have updated the documentation to reflect this change **(N/A)** - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] afzal442 commented on pull request #1819: chore: updates latest go mod lib and modifies the ginkgo install instruction
afzal442 commented on PR #1819: URL: https://github.com/apache/apisix-ingress-controller/pull/1819#issuecomment-1539800567 Ah I see! Thanks for that. So what would you recommend doing instead that? any suggestion or I should revert it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kayx23 closed pull request #9444: docs: Improve Building APISIX from source
kayx23 closed pull request #9444: docs: Improve Building APISIX from source URL: https://github.com/apache/apisix/pull/9444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kayx23 opened a new pull request, #9444: docs: Improve Building APISIX from source
kayx23 opened a new pull request, #9444: URL: https://github.com/apache/apisix/pull/9444 Improving doc as I build from source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch SkyeYoung-patch-2 deleted (was cc17954302d)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch SkyeYoung-patch-2 in repository https://gitbox.apache.org/repos/asf/apisix-website.git was cc17954302d Update config/apisix-versions.js The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[GitHub] [apisix-website] juzhiyuan merged pull request #1580: fix: apisix LTS version in nav
juzhiyuan merged PR #1580: URL: https://github.com/apache/apisix-website/pull/1580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: apisix LTS version in nav (#1580)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new bb0ef640922 fix: apisix LTS version in nav (#1580)
bb0ef640922 is described below
commit bb0ef64092299de28f26eebce00a065f08e15dd0
Author: Young
AuthorDate: Tue May 9 16:56:45 2023 +0800
fix: apisix LTS version in nav (#1580)
---
config/apisix-versions.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/apisix-versions.js b/config/apisix-versions.js
index fd5dad677d5..09d80fd2d83 100644
--- a/config/apisix-versions.js
+++ b/config/apisix-versions.js
@@ -8,7 +8,7 @@ const versions = ['2.12', '2.13', '2.14', '2.15', '3.0', '3.1',
'3.2', '3.3'];
/**
* @type {Array} LTS version list
*/
-const LTSVersions = ['2.15'];
+const LTSVersions = ['3.2'];
/**
* @type {{[origin: string]: string}} version display name mapping to origin
name
[GitHub] [apisix] zccabb commented on issue #9422: docs: apisix/getting-started ##using-the-apisix-dashboard
zccabb commented on issue #9422: URL: https://github.com/apache/apisix/issues/9422#issuecomment-1539702302 thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on issue #9422: docs: apisix/getting-started ##using-the-apisix-dashboard
navendu-pottekkat commented on issue #9422: URL: https://github.com/apache/apisix/issues/9422#issuecomment-1539699506 The current getting started guide uses a different install script that does not install the dashboard by default. You can follow an older version of the guide, and it should work out of the box: https://apisix.apache.org/docs/apisix/3.0/getting-started/ cc: @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1817: chore: remove v2beta3
codecov-commenter commented on PR #1817: URL: https://github.com/apache/apisix-ingress-controller/pull/1817#issuecomment-1539699157 ## [Codecov](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1817](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cdab4f0) into [master](https://app.codecov.io/gh/apache/apisix-ingress-controller/commit/31891bac85f02bc3487069af47a22ad403a863e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (31891ba) will **increase** coverage by `0.35%`. > The diff coverage is `n/a`. > :exclamation: Current head cdab4f0 differs from pull request most recent head 3ace70d. Consider uploading reports for the commit 3ace70d to get more accurate results ```diff @@Coverage Diff @@ ## master#1817 +/- ## == + Coverage 39.45% 39.80% +0.35% == Files 91 91 Lines8043 7258 -785 == - Hits 3173 2889 -284 + Misses 4463 3985 -478 + Partials 407 384 -23 ``` | [Impacted Files](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/config/config.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `64.64% <ø> (ø)` | | | [...viders/apisix/translation/apisix\_cluster\_config.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | `100.00% <ø> (ø)` | | | [...kg/providers/apisix/translation/apisix\_consumer.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv) | `63.15% <ø> (-2.06%)` | :arrow_down: | | [pkg/providers/apisix/translation/apisix\_plugin.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3BsdWdpbi5nbw==) | `85.02% <ø> (+26.95%)` | :arrow_up: | | [...roviders/apisix/translation/apisix\_pluginconfig.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3BsdWdpbmNvbmZpZy5nbw==) | `50.00% <ø> (+20.27%)` | :arrow_up: | | [pkg/providers/apisix/translation/apisix\_route.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `39.87% <ø> (+8.73%)` | :arrow_up: | | [pkg/providers/apisix/translation/apisix\_ssl.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <ø> (ø)` | | | [pkg/providers/apisix/translation/translator.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `0.00% <ø> (ø)` | | | [pkg/providers/translation/apisix\_upstream.go](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1817?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy90cmFuc2xhdGlvbi9hcGlzaXhfdXBzdHJlYW0uZ28=) | `79.49% <ø> (-0.46%)` | :arrow_down: | |
[GitHub] [apisix] kayx23 commented on issue #7368: docs: support API Reference for better experience
kayx23 commented on issue #7368: URL: https://github.com/apache/apisix/issues/7368#issuecomment-1539659856 related issue https://github.com/apache/apisix/issues/9276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Revolyssup opened a new issue, #9443: bug: http-logger gives 400 error while pushing the logs to HTTP server
Revolyssup opened a new issue, #9443:
URL: https://github.com/apache/apisix/issues/9443
### Current Behavior
http-logger fails to perform a successful POST on the HTTP log server and
instead returns a 400 error.
### Expected Behavior
http-logger should successfully POST the logs on the HTTP server.
### Error Logs
```
2023/05/09 10:39:19 [error] 32037#0: *57331 [lua] batch-processor.lua:95:
Batch Processor[http logger] failed to process entries: server returned status
code[400] host[localhost] port[3000] body[], context: ngx.timer, client:
127.0.0.1, server: 0.0.0.0:9080
2023/05/09 10:39:19 [error] 32037#0: *57331 [lua] batch-processor.lua:104:
Batch Processor[http logger] exceeded the max_retry_count[1] dropping the
entries, context: ngx.timer, client: 127.0.0.1, server: 0.0.0.0:9080
```
### Steps to Reproduce
1. Run APISIX
2. Run vector server (either locally or in a container with exposed port)
with the following configuration
```
[sources.log-from-http]
type = "http_server"
address = "0.0.0.0:3000"
[sinks.log-2-console]
inputs = ["log-from-http"]
type = "console"
encoding.codec = "json"
```
3. Pass the below configurations to admin API
```
curl http://127.0.0.1:9180/apisix/admin/plugin_metadata/http-logger \
-H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"log_format": {
"host": "$host",
"@timestamp": "$time_iso8601",
"client_ip": "$remote_addr"
}
}'
```
```
curl http://127.0.0.1:9180/apisix/admin/routes/1 \
-H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"plugins": {
"http-logger": {
"uri": "http://localhost:3000;
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"httpbin.org:80": 1
}
},
"uri": "/"
}'
```
4. Send request: `curl -i http://127.0.0.1:9080`
5. Check error logs
### Environment
- APISIX version 3.3.0
- Operating system: Linux 6.2.13-arch1-1
- nginx version: openresty/1.21.4.1
- LuaRocks version, for installation issues : 3.8.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] helloxubo opened a new issue, #9442: It takes more than one minute for the backend service to receive 504 errors
helloxubo opened a new issue, #9442: URL: https://github.com/apache/apisix/issues/9442 ### Description It takes more than one minute for the backend service to receive 504 errors. I try to modify the configmap.yaml file that in the folder apisix/templates in the following way, but it had no effect.  or  ### Environment - APISIX version is 2.13.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] afzal442 commented on pull request #1824: Refactor the apisix route validation test function
afzal442 commented on PR #1824: URL: https://github.com/apache/apisix-ingress-controller/pull/1824#issuecomment-1539593177 Sorry @tao12345666333 ! are those tests failing related to this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] heresie commented on a diff in pull request #528: feat: allow proxy protocol configuration for APISIX
heresie commented on code in PR #528: URL: https://github.com/apache/apisix-helm-chart/pull/528#discussion_r1188233615 ## charts/apisix/Chart.yaml: ## @@ -31,7 +31,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 1.3.1 +version: 1.4.0 Review Comment: ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] heresie commented on a diff in pull request #528: feat: allow proxy protocol configuration for APISIX
heresie commented on code in PR #528:
URL: https://github.com/apache/apisix-helm-chart/pull/528#discussion_r1188232304
##
charts/apisix/templates/configmap.yaml:
##
@@ -69,14 +69,16 @@ data:
enable_ipv6: {{ .Values.apisix.enableIPv6 }} # Enable nginx IPv6 resolver
enable_server_tokens: {{ .Values.apisix.enableServerTokens }} # Whether
the APISIX version number should be shown in Server header
- # proxy_protocol: # Proxy Protocol configuration
- # listen_http_port: 9181 # The port with proxy protocol for
http, it differs from node_listen and admin_listen.
- # # This port can only receive http
request with proxy protocol, but node_listen & admin_listen
- # # can only receive http request. If
you enable proxy protocol, you must use this port to
- # # receive http request with proxy
protocol
- # listen_https_port: 9182 # The port with proxy protocol for
https
- # enable_tcp_pp: true # Enable the proxy protocol for tcp
proxy, it works for stream_proxy.tcp option
- # enable_tcp_pp_to_upstream: true # Enables the proxy protocol to the
upstream server
+ {{- if .Values.apisix.proxyProtocol.enabled }}
+ proxy_protocol:
# Proxy Protocol configuration
+listen_http_port: {{ .Values.apisix.proxyProtocol.listenHttpPort }}
# The port with proxy protocol for http, it differs from node_listen and
port_admin.
+
# This port can only receive http request with proxy protocol, but node_listen
& port_admin
+
# can only receive http request. If you enable proxy protocol, you must use
this port to
+
# receive http request with proxy protocol
+listen_https_port: {{ .Values.apisix.proxyProtocol.listenHttpsPort }}
# The port with proxy protocol for https
+enable_tcp_pp: {{ .Values.apisix.proxyProtocol.enabled }}
# Enable the proxy protocol for tcp proxy, it works for stream_proxy.tcp option
Review Comment:
Hello @tao12345666333, thank you for the feedback.
I'm afraid I don't understand what you mean by "new configuration item".
I already match the reference configuration file
(https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L37-L44).
Can you please be more specific?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1819: chore: updates latest go mod lib and modifies the ginkgo install instruction
tao12345666333 commented on PR #1819: URL: https://github.com/apache/apisix-ingress-controller/pull/1819#issuecomment-1539566384 @afzal442 I don't recommend doing it this way. We can simply export the environment variable instead. I don't want us to directly modify the user's configuration file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch dependabot/go_modules/test/e2e/github.com/onsi/ginkgo/v2-2.9.4 deleted (was 36229cc4)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/test/e2e/github.com/onsi/ginkgo/v2-2.9.4 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git was 36229cc4 chore(deps): bump github.com/onsi/ginkgo/v2 in /test/e2e The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[apisix-ingress-controller] branch master updated (31891bac -> c6a13b3b)
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git from 31891bac fix: Referencing empty objects during tcproute and httproute updates (#1825) add c6a13b3b chore(deps): bump github.com/onsi/ginkgo/v2 in /test/e2e (#1827) No new revisions were added by this update. Summary of changes: test/e2e/go.mod | 4 ++-- test/e2e/go.sum | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-)
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1827: chore(deps): bump github.com/onsi/ginkgo/v2 from 2.9.2 to 2.9.4 in /test/e2e
tao12345666333 merged PR #1827: URL: https://github.com/apache/apisix-ingress-controller/pull/1827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kayx23 opened a new issue, #9441: Stream Route `remote_addr` Naming Suggestion
kayx23 opened a new issue, #9441: URL: https://github.com/apache/apisix/issues/9441 ### Description ## Current State `remote_addr` in a stream route is used to filter requests by client's IP address. The naming of this attribute is confusing. It is difficult to tell if `remote_addr` means upstream service or downstream client's IP. ## Suggestion Rename `remote_addr` to `client_addr` or similar ## Relevant Docs * [Admin API Stream Routes](https://apisix.apache.org/docs/apisix/admin-api/#stream-route-api) * [Stream Proxy doc](https://apisix.apache.org/docs/apisix/next/stream-proxy/) ### Environment latest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] yujinchoi-94 commented on issue #228: request help: request.getUpstreamHeaders java.lang.IndexOutOfBoundsException: null?
yujinchoi-94 commented on issue #228: URL: https://github.com/apache/apisix-java-plugin-runner/issues/228#issuecomment-1539496297 Did you solve this problem? I'm having same problem @15003476628 Any progress with this? @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt commented on pull request #9425: fix: syslog plugin doesn't work
Sn0rt commented on PR #9425: URL: https://github.com/apache/apisix/pull/9425#issuecomment-1539457668 @shreemaan-abhishek your commit has been duplicated here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Sn0rt commented on pull request #9402: fix: syslog double encoding message
Sn0rt commented on PR #9402: URL: https://github.com/apache/apisix/pull/9402#issuecomment-1539457065 @shreemaan-abhishek I mean the syslog encoding error. so the log server such `rsyslog` can't receive the log entry. aha. now your commit has been copy to https://github.com/apache/apisix/pull/9425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
