Re: [I] bug: Upstream HealthCheck Issue - Unhealthy Upstream doesn't be excluded temporarily [apisix-ingress-controller]

2024-03-27 Thread via GitHub


kworkbee commented on issue #2176:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/2176#issuecomment-2024447208

   The certificate problem was solved. It was a problem that occurred when 
terminated traffic went to Secure ALB. However, the `ApisixUpstream` health 
check still does not work.
   
   @Revolyssup @shreemaan-abhishek 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] chore: release APISIX 3.9.0 [apisix-docker]

2024-03-27 Thread via GitHub


shreemaan-abhishek opened a new pull request, #549:
URL: https://github.com/apache/apisix-docker/pull/549

   release new version of APISIX docker images


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] bug: aws-lambda plugin with IAM auth fails with URL-encoded query parameters [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek commented on issue #11097:
URL: https://github.com/apache/apisix/issues/11097#issuecomment-2024385718

   welcome to raise a PR to fix this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Is it possible to get the matched route_id in a custom wasm plugin? [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek commented on issue #11098:
URL: https://github.com/apache/apisix/issues/11098#issuecomment-2024384466

   If you have access to the `ctx` variable, you can get it like so: 
`ctx.matched_route.value.id`. You can learn more here: 
https://blog.frankel.ch/rabbit-hole-apisix-plugin/. written by @nfrankel  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] bug: Upstream HealthCheck Issue - Unhealthy Upstream doesn't be excluded temporarily [apisix]

2024-03-27 Thread via GitHub


kworkbee commented on issue #11016:
URL: https://github.com/apache/apisix/issues/11016#issuecomment-2024361932

   @shreemaan-abhishek Can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat(openid-connect): allow set headers in introspection request [apisix]

2024-03-27 Thread via GitHub


yuweizzz commented on PR #11090:
URL: https://github.com/apache/apisix/pull/11090#issuecomment-2024344528

   this pr allows provide extra HTTP headers when talks to the OpenID Connect 
introspection endpoint, In other API gateway has this feature alrealy, like 
traefik. and some oauth libs has this feature too, like oauthlib. this may 
helpful when introspection endpoint is proxied.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] docs: add docs for `http-dubbo` plugin [apisix]

2024-03-27 Thread via GitHub


sunheyi6 commented on issue #11067:
URL: https://github.com/apache/apisix/issues/11067#issuecomment-2024302466

   Is this plugin need to test using 
[tengine](https://github.com/alibaba/tengine/tree/master/modules/mod_dubbo#quick-start)?
 If so, there are some problems with the installation of tenginte. I have tried 
several methods, but none of them can be installed. I am unable to test what 
the final result is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: 请教如何配置可以进入我自己的server [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek commented on issue #11092:
URL: https://github.com/apache/apisix/issues/11092#issuecomment-2024262826

   hi could you please update the issue description in english?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix(brotli): brotli partial response fix [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek commented on PR #11087:
URL: https://github.com/apache/apisix/pull/11087#issuecomment-2024254877

   okay makes sense now, thanks for the apt explanation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat(openid-connect): allow set headers in introspection request [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek commented on PR #11090:
URL: https://github.com/apache/apisix/pull/11090#issuecomment-2024248000

   could you please explain about the use cases where this feature would be 
helpful in the linked issue thread?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix(openid-connect): Close session in case of error to avoid blocked … [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek commented on PR #11089:
URL: https://github.com/apache/apisix/pull/11089#issuecomment-2024246398

   the solution looks good in first observation, let's wait for the CI to run 
then I will review this again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] bug: routing not working properly to pods with appropriate labels [apisix-ingress-controller]

2024-03-27 Thread via GitHub


github-actions[bot] commented on issue #2109:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/2109#issuecomment-2024234298

   This issue has been marked as stale due to 90 days of inactivity. It will be 
closed in 30 days if no further activity occurs. If this issue is still 
relevant, please simply write any comment. Even if closed, you can still revive 
the issue at any time or discuss it on the d...@apisix.apache.org list. Thank 
you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: Add automatic key generation in docker compose [apisix-docker]

2024-03-27 Thread via GitHub


Revolyssup commented on code in PR #548:
URL: https://github.com/apache/apisix-docker/pull/548#discussion_r1541839765


##
compose/modify_config.sh:
##
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+# Generate a random string
+random_string=$(head /dev/urandom | tr -dc A-Za-z0-9 | head -c 32)
+
+# Perform substitution using sed
+sed "s/key: ''/key: $random_string/g" /config.yaml > /tmp/temp_config.yaml
+
+# Copy the content of the temporary file back to the original file
+cat /tmp/temp_config.yaml > /config.yaml
+
+# Remove the temporary file
+rm /tmp/temp_config.yaml

Review Comment:
   Directly pushing to config.yaml was giving some errors so i created a temp 
file 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: enable sensitive fields encryption by default [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1541332469


##
t/plugin/key-auth.t:
##
@@ -23,6 +23,31 @@ use t::APISIX 'no_plan';
 repeat_each(2);
 no_long_string();
 no_root_location();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+my $user_yaml_config = <<_EOC_;
+deployment:
+  role: traditional
+  role_traditional:
+config_provider: etcd
+  admin:
+admin_key: null
+apisix:
+  node_listen: 1984
+  proxy_mode: http
+  stream_proxy:
+tcp:
+  - 9100
+  enable_resolv_search_opt: false
+  data_encryption:
+enable_encrypt_fields: false

Review Comment:
   I think this should work. let me try



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] bug: Enabling discovery kubernetes services configuration doesn't list cluster existing endpoints in Dashboard Service list [apisix]

2024-03-27 Thread via GitHub


singhajitk commented on issue #11057:
URL: https://github.com/apache/apisix/issues/11057#issuecomment-2022962730

   > @singhajitk , From view source code , I don not find dump_data interface 
in discovery kubernetes .
   
   @hanqingwu, Thank you for looking into it.  
   
   @shreemaan-abhishek , will this feature get added ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Http check route to return default response [apisix]

2024-03-27 Thread via GitHub


Hectorsong commented on issue #11093:
URL: https://github.com/apache/apisix/issues/11093#issuecomment-2022748453

   Appreciate it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Http check route to return default response [apisix]

2024-03-27 Thread via GitHub


Hectorsong closed issue #11093: Http check route to return default response
URL: https://github.com/apache/apisix/issues/11093


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] docs: Is it enable here rather than disable about admin_key_required? [apisix]

2024-03-27 Thread via GitHub


sunheyi6 commented on issue #11091:
URL: https://github.com/apache/apisix/issues/11091#issuecomment-2022689735

   By default, it is enabled, but you have the option to disable it if you 
prefer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] bug: aws-lambda plugin with IAM auth fails with URL-encoded query parameters [apisix]

2024-03-27 Thread via GitHub


deiwin opened a new issue, #11097:
URL: https://github.com/apache/apisix/issues/11097

   ### Current Behavior
   
   When using the the `aws-lambda` plugin with IAM auth, then any request that 
includes URL-encoded query parameters will fail with the following error 
returned from AWS:
   ```
   HTTP/2 403
   ..
   x-amzn-errortype: InvalidSignatureException
   ..
   
   {"message":"The request signature we calculated does not match the signature 
you provided. Check your AWS Secret Access Key and signing method. Consult the 
service documentation for details."}
   ```
   
   I believe this happens because:
   - [`get_uri_args` unescapes query 
parameters](https://github.com/openresty/lua-nginx-module#ngxreqget_uri_args)
   - The `aws-lambda` plugin [uses 
`get_uri_args`](https://github.com/apache/apisix/blob/538b9480fd1d0fc41d627936279fcf28cb5802d7/apisix/plugins/serverless/generic-upstream.lua#L62),
 which unescapes the parameters but then [also unescapes them 
itself](https://github.com/apache/apisix/blob/538b9480fd1d0fc41d627936279fcf28cb5802d7/apisix/plugins/aws-lambda.lua#L128),
 causing the args to be unescaped twice.
   - Per [AWS 
docs](https://docs.aws.amazon.com/IAM/latest/UserGuide/create-signed-request.html#create-canonical-request)
 the "canonical query parameters" used for the signature should be escaped, but 
they are double-unescaped instead.
   
   ### Expected Behavior
   
   _No response_
   
   ### Error Logs
   
   _No response_
   
   ### Steps to Reproduce
   
   Create a route including the `aws-lambda` plugin:
   ```yaml
   function_uri: 
   authorization:
 iam:
   accesskey: 
   secretkey: 
   aws_region: 
   service: 
   ```
   
   Then send a request to the route, including a query parameter such as 
`?param=with%20spaces`, for example.
   
   ### Environment
   
   - APISIX version (run `apisix version`): 3.7.0 (but the issue is also on 
master)
   - Operating system (run `uname -a`): Debian (from 
`apache/apisix:3.7.0-debian` Docker image)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] forward-auth support setting custom response status_code [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] commented on issue #9257:
URL: https://github.com/apache/apisix/issues/9257#issuecomment-2022369666

   This issue has been marked as stale due to 350 days of inactivity. It will 
be closed in 2 weeks if no further activity occurs. If this issue is still 
relevant, please simply write any comment. Even if closed, you can still revive 
the issue at any time or discuss it on the d...@apisix.apache.org list. Thank 
you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: grpc server is java, when using grPC-transcode plugin error in the background [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] closed issue #10686: help request: grpc server is java, 
when using grPC-transcode plugin error in the background
URL: https://github.com/apache/apisix/issues/10686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: The apisix upstream address is the k8s servicename domain, and it will always be 504 after the pod is restarted. [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] commented on issue #10432:
URL: https://github.com/apache/apisix/issues/10432#issuecomment-2022363785

   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: grpc server is java, when using grPC-transcode plugin error in the background [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] commented on issue #10686:
URL: https://github.com/apache/apisix/issues/10686#issuecomment-2022363845

   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: The apisix upstream address is the k8s servicename domain, and it will always be 504 after the pod is restarted. [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] closed issue #10432: help request: The apisix upstream 
address is the k8s servicename domain, and it will always be 504 after the pod 
is restarted.
URL: https://github.com/apache/apisix/issues/10432


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: module 'apisix.plugins.reload' not found [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] closed issue #10211: help request: module 
'apisix.plugins.reload' not found
URL: https://github.com/apache/apisix/issues/10211


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: module 'apisix.plugins.reload' not found [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] commented on issue #10211:
URL: https://github.com/apache/apisix/issues/10211#issuecomment-2022363672

   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: Program deadlock, cpu usage reaches 100% [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] closed issue #9464: help request: Program deadlock, cpu 
usage reaches 100% 
URL: https://github.com/apache/apisix/issues/9464


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: Program deadlock, cpu usage reaches 100% [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] commented on issue #9464:
URL: https://github.com/apache/apisix/issues/9464#issuecomment-2022363582

   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Apisix always actively closes TCP connections, leading to too many TIME_WAIT states. The throughput has been unable to increase. [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] closed issue #9398: Apisix always actively closes TCP 
connections, leading to too many TIME_WAIT states. The throughput has been 
unable to increase.
URL: https://github.com/apache/apisix/issues/9398


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: After finding with nacos service, the weights with weights polling, where the weight is to obtain the weight configured on nacos [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] closed issue #9416: help request: After finding with nacos 
service, the weights with weights polling, where the weight is to obtain the 
weight configured on nacos
URL: https://github.com/apache/apisix/issues/9416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Apisix always actively closes TCP connections, leading to too many TIME_WAIT states. The throughput has been unable to increase. [apisix]

2024-03-27 Thread via GitHub


github-actions[bot] commented on issue #9398:
URL: https://github.com/apache/apisix/issues/9398#issuecomment-2022363436

   This issue has been closed due to lack of activity. If you think that is 
incorrect, or the issue requires additional review, you can revive the issue at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: Add automatic key generation in docker compose [apisix-docker]

2024-03-27 Thread via GitHub


starsz commented on code in PR #548:
URL: https://github.com/apache/apisix-docker/pull/548#discussion_r1540772212


##
compose/modify_config.sh:
##
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+# Generate a random string
+random_string=$(head /dev/urandom | tr -dc A-Za-z0-9 | head -c 32)
+
+# Perform substitution using sed
+sed "s/key: ''/key: $random_string/g" /config.yaml > /tmp/temp_config.yaml
+
+# Copy the content of the temporary file back to the original file
+cat /tmp/temp_config.yaml > /config.yaml
+
+# Remove the temporary file
+rm /tmp/temp_config.yaml

Review Comment:
   I think we can combine those command into one command.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]

2024-03-27 Thread via GitHub


starsz commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1540768643


##
charts/apisix/templates/configmap.yaml:
##
@@ -326,6 +326,8 @@ data:
   - name: "admin"
 {{- if .Values.apisix.admin.credentials.secretName }}
 key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+{{- else if eq .Values.apisix.admin.credentials.admin "" }}
+key: {{ randAlphaNum 32 }}

Review Comment:
   I think we can write how to get the key in the docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: enable sensitive fields encryption by default [apisix]

2024-03-27 Thread via GitHub


starsz commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1540720522


##
t/plugin/key-auth.t:
##
@@ -23,6 +23,31 @@ use t::APISIX 'no_plan';
 repeat_each(2);
 no_long_string();
 no_root_location();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+my $user_yaml_config = <<_EOC_;
+deployment:
+  role: traditional
+  role_traditional:
+config_provider: etcd
+  admin:
+admin_key: null
+apisix:
+  node_listen: 1984
+  proxy_mode: http
+  stream_proxy:
+tcp:
+  - 9100
+  enable_resolv_search_opt: false
+  data_encryption:
+enable_encrypt_fields: false

Review Comment:
   Could we only keep 
   
   ```
   apisix:
   data_encryption:
   enable_encrypt_fields: false
   ```
   this ? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] help request: 源码安装 [apisix]

2024-03-27 Thread via GitHub


zhangliweixyz closed issue #11096: help request: 源码安装
URL: https://github.com/apache/apisix/issues/11096


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: Autogenerate random API Key with helm install if not passed [apisix-helm-chart]

2024-03-27 Thread via GitHub


Revolyssup commented on code in PR #740:
URL: https://github.com/apache/apisix-helm-chart/pull/740#discussion_r1540666022


##
charts/apisix/templates/configmap.yaml:
##
@@ -326,6 +326,8 @@ data:
   - name: "admin"
 {{- if .Values.apisix.admin.credentials.secretName }}
 key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}}
+{{- else if eq .Values.apisix.admin.credentials.admin "" }}
+key: {{ randAlphaNum 32 }}

Review Comment:
   Since this is in the confimap. Users can look at the configmap using kubectl 
to look at the key. Is there an issue there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: support more sensitive fields for encryption [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek commented on code in PR #11095:
URL: https://github.com/apache/apisix/pull/11095#discussion_r1540639909


##
t/plugin/authz-casdoor.t:
##
@@ -506,6 +506,8 @@ apisix:
 -- get plugin conf from etcd, password is encrypted
 local etcd = require("apisix.core.etcd")
 local res = assert(etcd.get('/routes/1'))
+local core = require("apisix.core")
+core.log.warn("dibag", 
core.json.encode(res.body.node.value.plugins["authz-casdoor"].client_secret))

Review Comment:
   oops, let me remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: support more sensitive fields for encryption [apisix]

2024-03-27 Thread via GitHub


starsz commented on code in PR #11095:
URL: https://github.com/apache/apisix/pull/11095#discussion_r1540633125


##
t/plugin/authz-casdoor.t:
##
@@ -506,6 +506,8 @@ apisix:
 -- get plugin conf from etcd, password is encrypted
 local etcd = require("apisix.core.etcd")
 local res = assert(etcd.get('/routes/1'))
+local core = require("apisix.core")
+core.log.warn("dibag", 
core.json.encode(res.body.node.value.plugins["authz-casdoor"].client_secret))

Review Comment:
   Debug line ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] help request: 源码安装 [apisix]

2024-03-27 Thread via GitHub


zhangliweixyz opened a new issue, #11096:
URL: https://github.com/apache/apisix/issues/11096

   ### Description
   
   安装依赖项脚本install-dependencies.sh执行报错,错误如下:
   install-dependencies.sh: line 123: APISIX_RUNTIME: parameter null or not set
   
   对应脚本内容为:
   
![image](https://github.com/apache/apisix/assets/70928799/4eb211aa-5ed7-4286-8f3e-d463ca8e6f4a)
   
   APISIX_RUNTIME这个变量该如何设置
   
   ### Environment
   
   - APISIX version (run `apisix version`): 2.15.0
   - Operating system (run `uname -a`):
   - OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
   - etcd version, if relevant (run `curl 
http://127.0.0.1:9090/v1/server_info`):
   - APISIX Dashboard version, if relevant:
   - Plugin runner version, for issues related to plugin runners:
   - LuaRocks version, for installation issues (run `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] feat: support more sensitive fields for encryption [apisix]

2024-03-27 Thread via GitHub


shreemaan-abhishek opened a new pull request, #11095:
URL: https://github.com/apache/apisix/pull/11095

   ### Description
   
   
   
   
   Fixes # (issue)
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] bug: Compression plugin brotli is sending partial response [apisix]

2024-03-27 Thread via GitHub


yuweizzz commented on issue #11079:
URL: https://github.com/apache/apisix/issues/11079#issuecomment-2022088389

   I had some test in local env, this part will handle by openresty correctly, 
`core.response.clear_header_as_body_modified` will clear  `content-length` 
header, and the `transfer-encoding` header will control by openresty.
   
   > yes, the fix for the partial response is required, but now I am thinking 
if we need to clear somes headers from upstream when we use http2. so that we 
can avoid http2 protocol error.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] why the apisix-dashboard take so much cpu and memory [apisix-dashboard]

2024-03-27 Thread via GitHub


hanqingwu commented on issue #2935:
URL: 
https://github.com/apache/apisix-dashboard/issues/2935#issuecomment-2022041374

   try to apply this patch  ? 
   https://github.com/apache/apisix-dashboard/pull/2920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org