[GitHub] [apisix] EnableAsync commented on a change in pull request #2225: move etcd cluster in docker for CI

[GitBox]

EnableAsync commented on a change in pull request #2225:
URL: https://github.com/apache/apisix/pull/2225#discussion_r511543177



##
File path: utils/install-etcd-client.sh
##
@@ -0,0 +1,23 @@
+#!/bin/sh
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+wget 
https://github.com/etcd-io/etcd/releases/download/v3.4.0/etcd-v3.4.0-linux-amd64.tar.gz

Review comment:
   should i change to `linux-install-etcd-client.sh` ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] EnableAsync commented on a change in pull request #2225: move etcd cluster in docker for CI

[GitBox]

EnableAsync commented on a change in pull request #2225:
URL: https://github.com/apache/apisix/pull/2225#discussion_r489142349



##
File path: .github/workflows/build.yml
##
@@ -28,9 +28,13 @@ jobs:
 
 #
   - name: Linux Get dependencies
-if: matrix.platform == 'ubuntu-18.04'
+if: matrix.platform == 'ubuntu-18.04' && matrix.os_name != 
'linux_openresty' && matrix.os_name != 'linux_tengine'
 run: sudo apt install -y cpanminus build-essential libncurses5-dev 
libreadline-dev libssl-dev perl etcd
 
+  - name: Linux Get dependencies
+if: matrix.platform == 'ubuntu-18.04' && (matrix.os_name == 
'linux_openresty' || matrix.os_name == 'linux_tengine')
+run: sudo apt install -y cpanminus build-essential libncurses5-dev 
libreadline-dev libssl-dev perl etcd-client

Review comment:
   This test example uses the command `etcdctl`.
   https://github.com/apache/apisix/blob/master/t/core/etcd-auth.t#L29





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org