[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-722294843 > @gy09535 you need to resolve the conflict first yeah, fix it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-714854919 > > I do another test , the msg is send with no error ,it is success. And we can check it in sls log console. > > can we run it in CI? The test case can run in CI, ref: https://github.com/apache/apisix/pull/2177/files#diff-1108dce1e7823ca0b746c4ba69e692e4b02c6d49117d70859954b56cbb810c29R99 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-714854919 > > I do another test , the msg is send with no error ,it is success. And we can check it in sls log console. > > can we run it in CI? The test case can run in CI ref: https://github.com/apache/apisix/pull/2177/files#diff-1108dce1e7823ca0b746c4ba69e692e4b02c6d49117d70859954b56cbb810c29R99 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special config, we should has different plugin to config it and I reference tcp logger plugin to implement it, I think I can refactor tcp logger and sls logger plugin , change the common code into one module, For sys-logger plugin I think some code is duplicate , for example the batch processor has [retry]( https://github.com/apache/apisix/blob/master/apisix/plugins/syslog.lua#L179) the "resty.logger.socket" also has [retry](https://github.com/apache/apisix/blob/master/apisix/plugins/syslog.lua#L96) etc. so I prefer use cosocket . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special config, we should has different plugin to config it and I reference tcp logger plugin to implement it, I think I can refactor tcp logger and sls logger plugin , change the common code into one module, For syslog I think some code is duplicate , for example the batch processor has [retry]( https://github.com/apache/apisix/blob/master/apisix/plugins/syslog.lua#L179) the "resty.logger.socket" also has [retry](https://github.com/apache/apisix/blob/master/apisix/plugins/syslog.lua#L96) etc. so I prefer use cosocket . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special config, we should has different plugin to config it and I reference tcp logger plugin to implement it, I think I can refactor tcp logger and sls logger plugin , change the common code into one module, For system log I think some code is duplicate , for example the batch processor has [retry]( https://github.com/apache/apisix/blob/master/apisix/plugins/syslog.lua#L179) the "resty.logger.socket" also has [retry](https://github.com/apache/apisix/blob/master/apisix/plugins/syslog.lua#L96) etc. so I prefer use cosocket . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
