[GitHub] [apisix] juzhiyuan commented on a change in pull request #2751: docs: how could I only enable passive health check

2020-11-16 Thread GitBox 


juzhiyuan commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524867441



##
File path: FAQ.md
##
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling 
HTTP requests. If you
 ```
 
 2. Reload or restart APISIX
+
+## How could I only enable passive health check?

Review comment:
   Oh I know what happened, looks good to me.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2751: docs: how could I only enable passive health check

2020-11-16 Thread GitBox 


juzhiyuan commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524825421



##
File path: FAQ.md
##
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling 
HTTP requests. If you
 ```
 
 2. Reload or restart APISIX
+
+## How could I only enable passive health check?

Review comment:
   
![image](https://user-images.githubusercontent.com/2106987/99328434-08ff3000-28b7-11eb-9671-6c52c924a933.png)
   
   I mean this PR's content is more like a new QA? How about creating a new QA 
in the FAQ instead of adding content under `How to change the log level?`
   
   I'm not sure if it's a new QA or the improvements for `How to change the log 
level?`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2751: docs: how could I only enable passive health check

2020-11-15 Thread GitBox 


juzhiyuan commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r523825777



##
File path: FAQ.md
##
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling 
HTTP requests. If you
 ```
 
 2. Reload or restart APISIX
+
+## How could I only enable passive health check?

Review comment:
   How about adding this tip standalone?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org