[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-05 Thread GitBox


juzhiyuan commented on pull request #4155:
URL: https://github.com/apache/apisix/pull/4155#issuecomment-832613243


   Each Plugin PR will have both Chinese & English changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-05 Thread GitBox


juzhiyuan commented on pull request #4155:
URL: https://github.com/apache/apisix/pull/4155#issuecomment-832612967


   Hi, to prevent from misleading PRs or contents, I will split them into 
smaller PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox


juzhiyuan commented on pull request #4155:
URL: https://github.com/apache/apisix/pull/4155#issuecomment-831648865


   After reviewing Chinese versions, I will submit PRs to update EN.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox


juzhiyuan commented on pull request #4155:
URL: https://github.com/apache/apisix/pull/4155#issuecomment-831641900


   > Please fix English doc first
   
   @moonming Please review Chinese docs first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox


juzhiyuan commented on pull request #4155:
URL: https://github.com/apache/apisix/pull/4155#issuecomment-831641725


   > Is it necessary to use docusaurus special syntax? Why not use  
directly?
   
   Those contents are used in the docs site, this syntax will be rendered as 
`Admonitions Box`.
   
   
![image](https://user-images.githubusercontent.com/2106987/116953146-1a01f900-acbf-11eb-9e1e-2d1971f64114.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox


juzhiyuan commented on pull request #4155:
URL: https://github.com/apache/apisix/pull/4155#issuecomment-831629657


   After discuss with @Yiyiyimu, I agree with him, this is more challenge for a 
non-CN speaker, you could pick other issues like `Web Test` or `Featrures` or 
`bugfix` issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox


juzhiyuan commented on pull request #4155:
URL: https://github.com/apache/apisix/pull/4155#issuecomment-831345303


   @iamayushdas ok! Once this PR is merged without incorrect contents, then you 
could start doing it :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)

2021-05-03 Thread GitBox


juzhiyuan commented on pull request #4155:
URL: https://github.com/apache/apisix/pull/4155#issuecomment-831087183


   For docs in English, I would prefer submitting a new PR ✌️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org