[GitHub] [apisix] liuhengloveyou commented on pull request #2340: feature: limit-count use redis cluster

2020-10-10 Thread GitBox 


liuhengloveyou commented on pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#issuecomment-706539087


   > @liuhengloveyou is this PR still a draft?
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2340: feature: limit-count use redis cluster

2020-10-10 Thread GitBox 


liuhengloveyou commented on pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#issuecomment-706541484


   > please fix the old issue first
   
   fixed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2340: feature: limit-count use redis cluster

2020-10-11 Thread GitBox 


liuhengloveyou commented on pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#issuecomment-706828797


   > @liuhengloveyou no test case?
   
   added



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2340: feature: limit-count use redis cluster

2020-10-11 Thread GitBox 


liuhengloveyou commented on pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#issuecomment-706829329


   > > @liuhengloveyou no test case?
   > 
   > @liuhengloveyou are you kiding me? NO test cases AT ALL!
   
   added



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] liuhengloveyou commented on pull request #2340: feature: limit-count use redis cluster

2020-10-12 Thread GitBox 


liuhengloveyou commented on pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#issuecomment-707031088


   The limit-count plugin used to support REIDS, the new Redis-Cluster has the 
same functional logic except that redis connections are differently.
   
   Now added new code, in order not to change the old code, copy part of the 
functional logic code. It's not pretty. 
   
   We need to come up with a solution to refactor the old code and reuse the 
common parts. @moonming @membphis 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org