[GitHub] [apisix] liuhengloveyou edited a comment on pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox


liuhengloveyou edited a comment on pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#issuecomment-701166312


   > @liuhengloveyou please confirm your ENV, all test cases fail :(
   
   sorry. updated



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] liuhengloveyou edited a comment on pull request #2339: feature: breaker request by api

2020-09-29 Thread GitBox


liuhengloveyou edited a comment on pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#issuecomment-700586491


   > > The current version only considers a single upstream.
   > 
   > if so, what's the different with upstream circuit breaker?
   
   I don't know what the implementation of `upstream circuit breaker`. 
   @membphis Please answer the question?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org