[GitHub] [apisix] membphis commented on issue #2394: bug:prometheus metrics 500 Internal Server Error

2020-10-15 Thread GitBox


membphis commented on issue #2394:
URL: https://github.com/apache/apisix/issues/2394#issuecomment-709421926


   I think we can close this issue. @zh417233956 if you still have a problem, 
please feel free to reopen this issue



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2394: bug:prometheus metrics 500 Internal Server Error

2020-10-12 Thread GitBox


membphis commented on issue #2394:
URL: https://github.com/apache/apisix/issues/2394#issuecomment-707018790


   > @membphis Can you tell me what is the triggering condition of this bug?
   
   The `item.modifiedIndex` maybe updated in here: 
   
   https://github.com/apache/apisix/blob/v1.5/apisix/init.lua#L251
   
   It has changed to `string` object. 
   
   So we need to fetch the original value from `modifiedIndex_org`.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2394: bug:prometheus metrics 500 Internal Server Error

2020-10-12 Thread GitBox


membphis commented on issue #2394:
URL: https://github.com/apache/apisix/issues/2394#issuecomment-707008901


   this bug should have been fixed in `master` branch, you can make a try with 
the latest version.
   
   
https://github.com/apache/apisix/blob/master/apisix/plugins/prometheus/exporter.lua#L197



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org