[GitHub] [apisix] membphis commented on pull request #2339: feature: breaker request by api

2020-10-17 Thread GitBox 


membphis commented on pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#issuecomment-70662


   continue this job in new PR: https://github.com/apache/apisix/pull/2455



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox 


membphis commented on pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#issuecomment-706452466


   @liuhengloveyou 
   
   
![image](https://user-images.githubusercontent.com/6814606/95640793-17487800-0ad1-11eb-9872-d350f63ab1c3.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2339: feature: breaker request by api

2020-10-06 Thread GitBox 


membphis commented on pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#issuecomment-704275765


   @liuhengloveyou and please take a look at the output of CI, you need to fix 
them at first



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2339: feature: breaker request by api

2020-09-29 Thread GitBox 


membphis commented on pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#issuecomment-701144285


   @liuhengloveyou please confirm your ENV, all test cases fail :(
   
   ```shell
   $ prove t/plugin/api-breaker.t
   
   t/plugin/api-breaker.t .. 1/?
   #   Failed test 'TEST 1: sanity - response_body - response is expected 
(repeated req 0, req 0)'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 1589.
   #  got: 'property "unhealthy_response_code" is required
   # done
   # '
   # expected: 'done
   # '
   
   #   Failed test 'TEST 2: default http_statuses - response_body - response is 
expected (repeated req 0, req 0)'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 1589.
   #  got: 'property "unhealthy_response_code" is required
   # done
   # '
   # expected: 'done
   # '
   
   #   Failed test 'TEST 3: add plugin - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 948.
   #  got: '400'
   # expected: '200'
   
   #   Failed test 'TEST 3: add plugin - response_body - response is expected 
(repeated req 0, req 0)'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 1589.
   #  got: '{"error_msg":"failed to check the configuration of plugin 
api-breaker err: property \"unhealthy_response_code\" is required"}
   #
   # '
   # expected: 'passed
   # '
   
   #   Failed test 'TEST 4: trigger breaker - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '200'
   
   #   Failed test 'TEST 4: trigger breaker - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 4: trigger breaker - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '503'
   t/plugin/api-breaker.t .. 16/?
   #   Failed test 'TEST 4: trigger breaker - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 4: trigger breaker - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '502'
   
   #   Failed test 'TEST 4: trigger breaker - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '502'
   
   #   Failed test 'TEST 5: trigger reset status - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 5: trigger reset status - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 5: trigger reset status - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '200'
   t/plugin/api-breaker.t .. 28/?
   #   Failed test 'TEST 5: trigger reset status - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '200'
   
   #   Failed test 'TEST 5: trigger reset status - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '200'
   
   #   Failed test 'TEST 5: trigger reset status - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 5: trigger reset status - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 6: trigger del healthy numeration - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 6: trigger del healthy numeration - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '200'
   t/plugin/api-breaker.t .. 40/?
   #   Failed test 'TEST 6: trigger del healthy numeration - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 6: trigger del healthy numeration - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '500'
   
   #   Failed test 'TEST 6: trigger del healthy numeration - status code ok'
   #   at /usr/local/share/perl/5.30.0/Test/Nginx/Socket.pm line 935.
   #  got: '404'
   # expected: '502'
   
   #   Failed test 'TEST 6: