[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8404: fix: the x-forwarded-* header will be influenced by ai plugin
monkeyDluffy6017 commented on code in PR #8404:
URL: https://github.com/apache/apisix/pull/8404#discussion_r1061302696
##
t/plugin/proxy-rewrite3.t:
##
@@ -455,3 +454,51 @@ passed
GET /echo HTTP/1.1
--- response_headers
test: test_in_set
+
+
+
+=== TEST 21: set route (test if X-Forwarded-Port can be set before proxy)
+--- config
+location /t {
Review Comment:
@spacewander i can not reproduce the problem any more, even fallback to the
old version, I will close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8404: fix: the x-forwarded-* header will be influenced by ai plugin
monkeyDluffy6017 commented on code in PR #8404:
URL: https://github.com/apache/apisix/pull/8404#discussion_r1035558005
##
t/plugin/proxy-rewrite3.t:
##
@@ -455,3 +454,51 @@ passed
GET /echo HTTP/1.1
--- response_headers
test: test_in_set
+
+
+
+=== TEST 21: set route (test if X-Forwarded-Port can be set before proxy)
+--- config
+location /t {
Review Comment:
ok, i'll figure it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8404: fix: the x-forwarded-* header will be influenced by ai plugin
monkeyDluffy6017 commented on code in PR #8404:
URL: https://github.com/apache/apisix/pull/8404#discussion_r1034340773
##
t/plugin/proxy-rewrite3.t:
##
@@ -455,3 +454,51 @@ passed
GET /echo HTTP/1.1
--- response_headers
test: test_in_set
+
+
+
+=== TEST 21: set route (test if X-Forwarded-Port can be set before proxy)
+--- config
+location /t {
Review Comment:
You could check this, the test case failed when the ai module is triggered
in the ci env, but works fine locally. when i remove the ai module, the ci test
passed.
https://github.com/apache/apisix/actions/runs/3421218504/jobs/5697063260
I think it maybe satisfy the condition in ci env.
https://github.com/apache/apisix/blob/master/apisix/plugins/ai.lua#L277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8404: fix: the x-forwarded-* header will be influenced by ai plugin
monkeyDluffy6017 commented on code in PR #8404:
URL: https://github.com/apache/apisix/pull/8404#discussion_r1033471736
##
t/plugin/proxy-rewrite3.t:
##
@@ -455,3 +454,51 @@ passed
GET /echo HTTP/1.1
--- response_headers
test: test_in_set
+
+
+
+=== TEST 21: set route (test if X-Forwarded-Port can be set before proxy)
+--- config
+location /t {
Review Comment:
Yes, the ai module is not triggered locally, try the test case in ci env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8404: fix: the x-forwarded-* header will be influenced by ai plugin
monkeyDluffy6017 commented on code in PR #8404: URL: https://github.com/apache/apisix/pull/8404#discussion_r1033148245 ## t/plugin/proxy-rewrite3.t: ## @@ -455,3 +454,51 @@ passed GET /echo HTTP/1.1 --- response_headers test: test_in_set + + + +=== TEST 21: set route (test if X-Forwarded-Port can be set before proxy) Review Comment: `var_x_forwarded_port` is set in `set_upstream_headers`, `set_upstream_headers` is called in `handle_upstream`, and `handle_upstream` is replaced in the ai module. It will fail in the ci env if the ai module is triggered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
