[GitHub] [apisix] moonming commented on issue #2809: [DISCUSS]: add vars matching rules to public methods

2020-11-20 Thread GitBox 


moonming commented on issue #2809:
URL: https://github.com/apache/apisix/issues/2809#issuecomment-731506870


   > But these rules are in the apisix/deps/share/lua/5.1/resty/radixtree.lua 
file, not in the public method. 
   
   @Firstsawyou I am not get your point. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on issue #2809: [DISCUSS]: add vars matching rules to public methods

2020-11-20 Thread GitBox 


moonming commented on issue #2809:
URL: https://github.com/apache/apisix/issues/2809#issuecomment-731506793


   > Maybe we can move the matching rules to a separate repo, so that we can 
also use this to satisfy 
[api7/lua-resty-radixtree#74](https://github.com/api7/lua-resty-radixtree/issues/74)
   
   agreed, router already support match rules.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org