[GitHub] [apisix] spacewander commented on issue #3855: The available key types in limit-count plugin are not recorded in docs

2021-03-18 Thread GitBox


spacewander commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802527024


   Close this issue as we don't need it actually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #3855: The available key types in limit-count plugin are not recorded in docs

2021-03-18 Thread GitBox


spacewander commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802524313


   Note that the website is generated from the markdown.
   This is the markdown source: 
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/limit-count.md#attributes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #3855: The available key types in limit-count plugin are not recorded in docs

2021-03-18 Thread GitBox


spacewander commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802523388


   I don't like to repeat the same words multiple times.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #3855: The available key types in limit-count plugin are not recorded in docs

2021-03-18 Thread GitBox


spacewander commented on issue #3855:
URL: https://github.com/apache/apisix/issues/3855#issuecomment-802503020


   @tokers 
   The key types are recorded in docs.
   See http://apisix.apache.org/docs/apisix/plugins/limit-count
   
   ```
   ["remote_addr", "server_addr", "http_x_real_ip", "http_x_forwarded_for", 
"consumer_name", "service_id"]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org