[GitHub] [apisix] spacewander commented on issue #3861: Proposition ldap-auth plugin

2021-03-22 Thread GitBox


spacewander commented on issue #3861:
URL: https://github.com/apache/apisix/issues/3861#issuecomment-804575841


   @jp-gouin 
   Would you submit a PR? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #3861: Proposition ldap-auth plugin

2021-03-18 Thread GitBox


spacewander commented on issue #3861:
URL: https://github.com/apache/apisix/issues/3861#issuecomment-802439993


   LGTM.
   
   Only a small thing: we can map the dn to an existed consumer instead of 
creating a temporary one.
   
   For example,
   
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/key-auth.md#how-to-enable
   
   ```
   curl http://127.0.0.1:9080/apisix/admin/consumers -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
   "username": "jack",
   "plugins": {
   "ldap-auth": {
   "dn": "cn=admin,dc=example,dc=org"
   }
   }
   }'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org