[GitHub] [apisix] spacewander commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox


spacewander commented on issue #6276:
URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034398011


   This is caused by the break change: 
https://github.com/apache/apisix/pull/6196
   The change is introduced to reduce attack vector.
   
   Let's add a new route with public-api plugin to work around it: 
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/public-api.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox


spacewander commented on issue #6276:
URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034495761


   > They are a logical AND relationship.
   > 
   > Need to configure both `enable_export_server: false` and `public_api` 
plugin.
   
   Yes
   
   
   
   > @spacewander thanks for your reply. Does that mean these descriptions in 
the documentation are wrong? `enable_export_server=false` no longer have any 
real value?
   > 
   > ```
   > If you still want to expose the metrics via the data plane port (default: 
9080), you can configure it like this:
   > 
   > plugin_attr:
   >   prometheus:
   > enable_export_server: false
   > You may need to use 
[public-api](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/public-api.md)
 plugin to expose it.
   > ```
   > 
   > 
[https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/prometheus.md#api](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/prometheus.md?rgh-link-date=2022-02-10T02%3A01%3A57Z#api)
   
   Look like we should fix the description of `You may need to use`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org