[GitHub] [apisix] spacewander commented on pull request #8609: fix: use previous way to disable plugins

2023-01-04 Thread GitBox 


spacewander commented on PR #8609:
URL: https://github.com/apache/apisix/pull/8609#issuecomment-1371775563

   The t/xds-library tests fail because the latest libxds doesn't work with 
APISIX 2.15, which is not relative to our change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #8609: fix: use previous way to disable plugins

2023-01-05 Thread GitBox 


spacewander commented on PR #8609:
URL: https://github.com/apache/apisix/pull/8609#issuecomment-1373112483

   > Changes LGTM.
   > 
   > However, since we have two options to control if a plugin is disabled, we 
need to classify the priority of these two fields.
   > 
   > In the current PR, the `plugin_config.disable` field has a higher priority 
than `plugin_config._meta.disable`.
   
   It is intended. `plugin_config._meta.disable` should not exist in 2.15.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org