[GitHub] [apisix] tokers commented on a change in pull request #3660: chore: update makefile install to install everything in conf
tokers commented on a change in pull request #3660: URL: https://github.com/apache/apisix/pull/3660#discussion_r582551397 ## File path: Makefile ## @@ -143,9 +143,7 @@ install: default $(INSTALL) -d /usr/local/apisix/ $(INSTALL) -d /usr/local/apisix/logs/ $(INSTALL) -d /usr/local/apisix/conf/cert - $(INSTALL) conf/mime.types /usr/local/apisix/conf/mime.types - $(INSTALL) conf/config.yaml /usr/local/apisix/conf/config.yaml - $(INSTALL) conf/config-default.yaml /usr/local/apisix/conf/config-default.yaml + $(INSTALL) conf/* /usr/local/apisix/conf/ Review comment: OK, got it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3660: chore: update makefile install to install everything in conf
tokers commented on a change in pull request #3660: URL: https://github.com/apache/apisix/pull/3660#discussion_r582415967 ## File path: Makefile ## @@ -143,9 +143,7 @@ install: default $(INSTALL) -d /usr/local/apisix/ $(INSTALL) -d /usr/local/apisix/logs/ $(INSTALL) -d /usr/local/apisix/conf/cert - $(INSTALL) conf/mime.types /usr/local/apisix/conf/mime.types - $(INSTALL) conf/config.yaml /usr/local/apisix/conf/config.yaml - $(INSTALL) conf/config-default.yaml /usr/local/apisix/conf/config-default.yaml + $(INSTALL) conf/* /usr/local/apisix/conf/ Review comment: The `cert` dir inside `conf/` is not necessary in the production environment, I think it should be excluded. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
