[GitHub] [apisix] tzssangglass commented on issue #6198: bug: core.json cannot serialise sparse array if enabled healthcheck

2022-01-26 Thread GitBox


tzssangglass commented on issue #6198:
URL: https://github.com/apache/apisix/issues/6198#issuecomment-1022808748


   It's a bit tricky, the content of the checker is too big……


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6198: bug: core.json cannot serialise sparse array if enabled healthcheck

2022-01-25 Thread GitBox


tzssangglass commented on issue #6198:
URL: https://github.com/apache/apisix/issues/6198#issuecomment-1021898686


   > Or just use the `encode_sparse_array` method?
   
   Sounds good, I will try it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6198: bug: core.json cannot serialise sparse array if enabled healthcheck

2022-01-25 Thread GitBox


tzssangglass commented on issue #6198:
URL: https://github.com/apache/apisix/issues/6198#issuecomment-1021308875


   > Is it caused by this part?
   > 
   > ```
   > http_statuses = {
   > [200] = true,
   > [302] = true
   > },
   > ```
   > 
   > Since here both the `200` and `302` are numeric.
   
   maybe, if health checks are enabled, the route or upstream must contain a 
checker, and the checker must contain these.
   
   I think a way to avoid such mistakes is needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6198: bug: core.json cannot serialise sparse array if enabled healthcheck

2022-01-25 Thread GitBox


tzssangglass commented on issue #6198:
URL: https://github.com/apache/apisix/issues/6198#issuecomment-1021308875


   > Is it caused by this part?
   > 
   > ```
   > http_statuses = {
   > [200] = true,
   > [302] = true
   > },
   > ```
   > 
   > Since here both the `200` and `302` are numeric.
   
   maybe, if health checks are enabled, the route or upstream must contain a 
checker, and the checker must contain these.
   
   I think a way to avoid such mistakes is needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org