[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header
tzssangglass commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1039260840 > Yes, the upstream services do not need base64 decoding user information, they can be obtained directly from X-userinfo-Detail-* My concern is that this is only grafana usage and is not a universal standard. I would like to know if there are more common standards that support this header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header
tzssangglass commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1039260840 > Yes, the upstream services do not need base64 decoding user information, they can be obtained directly from X-userinfo-Detail-* My concern is that this is only grafana usage and is not a universal standard. I would like to know if there are more common standards that support this header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header
tzssangglass commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1038599088 > Grafana requires the header is plaintext, but X-Userinfo is base64 encoded. Another question, is there an introduction to `X-Userinfo-Detail-*`? Is this header specifically for Grafana? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header
tzssangglass commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1034582381 we have `set_userinfo_header` attributes in openid-connect plugin, see: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/openid-connect.md#attributes It looks like this feature is already available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header
tzssangglass commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1034395905 Can you show the relevant docs or issue, I don't understand its usefulness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header
tzssangglass commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1033290896 hi @yaule , thanks for submitting the PR, can you explain the background of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
