[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-832015165 Any idea why the upstream test suite is breaking🤔, the PR doesn't touch anything on that segment and moreover, it's HTTP 400!! All starts with `test upstream delete [It] create upstream without plugin ` i.e failing to process upstream request and rest (other tests) is dominos effect. But it's working fine locally  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-833320046 > Hi @bisakhmondal, there have some errors in Backend CI. Yeshh!! Sad moments🥺 Looking into it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-836538380 Hi guys, the CI hadn't passed in this PR. Some checking was left to be done from my side. I truly am sorry, I got caught up in university exams for a few days. I think we should revert the commit. CI has failed in the master too. https://github.com/apache/apisix-dashboard/pull/1814#discussion_r627478821 Also this need to be taken care of. Sorry for the inconvenience. I am updating the PR as soon as possible. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-836596045 > @bisakhmondal Hi, if it's ok, could you please send a new PR to fix that failure? Ya, that sounds awesome. but yet, I can't reproduce the failure(totally irrelevant to this PR) locally even with the same environment like CI inside a docker container,  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1814: fix: efficient error handling in manager-api including graceful shutdown, self contained methods.
bisakhmondal commented on pull request #1814: URL: https://github.com/apache/apisix-dashboard/pull/1814#issuecomment-836598386 > @bisakhmondal Hi, if it's ok, could you please send a new PR to fix that failure? @juzhiyuan It seems to be a CI glitch, now the master is fine after a recent commit.  Even the last commit has passed all CI. What do you think, can we ignore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
