[GitHub] [apisix-dashboard] fregie commented on issue #1884: feat: provide command line interface of Manager API

2021-05-14 Thread GitBox


fregie commented on issue #1884:
URL: 
https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-841187436


   @imjoey 
   I agree with you,this is a good design.
   I have two more suggestion
   1. I think there should be two ways to control apisix,one is operational 
interface like `apisixctl add/delete/update _resource_`,the other is 
declarative interface like `deployment.yaml` of k8s.So I think we need two kind 
of api on  APISIX-apiserver too.
   2. We can try to add grpc api of APISIX-apiserver,Maybe this way we don’t 
need to provide SDKs in multiple languages


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] fregie commented on issue #1884: feat: provide command line interface of Manager API

2021-05-13 Thread GitBox


fregie commented on issue #1884:
URL: 
https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-840963465


   Maybe we can open another issues of separating of public library


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] fregie commented on issue #1884: feat: provide command line interface of Manager API

2021-05-13 Thread GitBox


fregie commented on issue #1884:
URL: 
https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-840925324






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] fregie commented on issue #1884: feat: provide command line interface of Manager API

2021-05-11 Thread GitBox


fregie commented on issue #1884:
URL: 
https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-838266342


   I think we can separate the store and storege module at the same time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] fregie commented on issue #1884: feat: provide command line interface of Manager API

2021-05-10 Thread GitBox


fregie commented on issue #1884:
URL: 
https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837578486


   > I think it's a great idea to provide a data entity library, but 
implementing it requires some modifications to the existing code.
   I think it worth to do,Let's listen to other's opinions.
   Ping @starsz @nic-chen 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] fregie commented on issue #1884: feat: provide command line interface of Manager API

2021-05-10 Thread GitBox


fregie commented on issue #1884:
URL: 
https://github.com/apache/apisix-dashboard/issues/1884#issuecomment-837568998


   I don't think it's a good idea put the cli feature in manager-api.Maybe it's 
better put it in 
[apisix-control-plane](https://github.com/apache/apisix-control-plane).
   We can use yaml or cli declarative definition method to define complete 
rules.
   
   On the other hand,I think we can abstract a library of managing data in etcd 
for the other project to use.Like _apisix-control-plane_ and 
_apisix-ingress-controller_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org